| vishalmanchanda | rdopiera: Hi, just tested you latest P.S. https://review.opendev.org/c/openstack/horizon/+/818763 | 11:34 |
|---|---|---|
| vishalmanchanda | rdopiera: I see one issue with your patch, Could you please check. | 11:34 |
| vishalmanchanda | rdopiera: thanks for the fix. | 11:34 |
| rdopiera | vishalmanchanda: you should see "identity" when you switch to system scope | 12:02 |
| rdopiera | it's basically moved to that menu | 12:03 |
| vishalmanchanda | rdopiera: so, a admin user can't see identity dashboard without switching to system scope? | 12:05 |
| rdopiera | vishalmanchanda: yes, since it requires system scope token to use it | 12:09 |
| vishalmanchanda | rdopiera: ack, let me try 1-2 more cases in my mind. | 12:13 |
| vishalmanchanda | rdopiera: So, If someone use horizon after your patch is merged. | 12:16 |
| vishalmanchanda | rdopiera: As a admin, he will not be able to use Identity dashboard by default. | 12:17 |
| vishalmanchanda | until he add SYSTEM_SCOPE_SERVICES = ['identity'] | 12:18 |
| vishalmanchanda | rdopiera: What if not change the default behavior for now and show the Identity dashboard as well? | 12:24 |
| vishalmanchanda | amotoki: e0ne: tmazur: Please let us know your thoughts about the above patch! | 12:26 |
| rdopiera | vishalmanchanda: no, with SYSTEM_SCOPE_SERVICES=[] the identity panel should be there as normal | 12:32 |
| rdopiera | vishalmanchanda: only with SYSTEM_SCOPE_SERVICES=["identity"] it is moved into the system scope menu | 12:34 |
| vishalmanchanda | rdopiera: but if apply your patch the identity panel is missing for me. | 14:53 |
| vishalmanchanda | rdopiera: I have also attached a screenshot of that in the review comment. Please take a look. | 14:54 |
| rdopiera | vishalmanchanda: that was a bug previously, but it should be fixed with the current version | 15:01 |
| rdopiera | vishalmanchanda: is it missing with SYSTEM_SCOPE_SERVICES=[]? | 15:02 |
| vishalmanchanda | rdopiera: yes I guess. | 15:02 |
| rdopiera | are you sure the setting is taking effect? | 15:02 |
| vishalmanchanda | rdopiera: I can try again with a different environment. | 15:02 |
| rdopiera | do you see system scope in the context switching menu? | 15:03 |
| rdopiera | if you don't see system scope, you should see identity panel | 15:03 |
| vishalmanchanda | rdopiera: no | 15:03 |
| rdopiera | is that devstack? | 15:03 |
| vishalmanchanda | Yup. | 15:03 |
| vishalmanchanda | rdopiera: let me try with a new environment. | 15:04 |
| rdopiera | vishalmanchanda: can you click on the "admin" project in the context selection menu? does that make the identity menu appear? | 15:05 |
| rdopiera | if (('identity' in settings.SYSTEM_SCOPE_SERVICES) != bool(context['request'].user.system_scoped)): return False | 15:06 |
| rdopiera | this is the condition I am using | 15:06 |
| rdopiera | that means that somehow user.system_scoped is True for you, even though you are not in the system scope | 15:06 |
| vishalmanchanda | rdopiera: will check and let you know, outside right now. | 15:06 |
| rdopiera | thanks, sorry for this, but I really don't understand what is happening there | 15:07 |
| vishalmanchanda | rdopiera: could you drop a screenshot of your env. Where identity panel is there and system scope option is not in switching menu. | 15:08 |
| rdopiera | vishalmanchanda: http://paste.sheep.art.pl/Fe4FZcu3/+inline | 15:12 |
| vishalmanchanda | rdopiera: you are right, it was some issue in my browser(cache) that's why I am not able to see Identity panel in default case. | 16:33 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!