| *** whoami-rajat__ is now known as whoami-rajat | 13:59 | |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: Update pyScss to 1.4.0 https://review.opendev.org/c/openstack/horizon/+/830618 | 14:03 |
|---|---|---|
| vishalmanchanda | #startmeeting horizon | 15:00 |
| opendevmeet | Meeting started Wed Feb 23 15:00:27 2022 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| vishalmanchanda | hello everyone | 15:00 |
| ganso | o/ | 15:00 |
| e0ne | hi | 15:01 |
| vishalmanchanda | let's wait for 2-3 minutes if more people joins us. | 15:02 |
| vishalmanchanda | amotoki: rdopiera tmazur: ping for horizon weekly meeting | 15:02 |
| vishalmanchanda | ok Let's start the meeting. | 15:04 |
| vishalmanchanda | #topic Notices | 15:04 |
| vishalmanchanda | few announcement from my side for this week | 15:05 |
| vishalmanchanda | As usual Yoga Schedule https://releases.openstack.org/yoga/schedule.html | 15:05 |
| vishalmanchanda | This week is R-5 week. | 15:05 |
| vishalmanchanda | This week is also Feature freeze weak but anyone can ask for feature freeze exception if you want your bp to merge in Yoga release. | 15:06 |
| vishalmanchanda | but in case you are going to ask for feature freeze exception please let me know asap by this week | 15:07 |
| vishalmanchanda | Horizon follows cycle-with-intermediary model. | 15:07 |
| vishalmanchanda | So I will cut Final release of horizon in week of Mar 14 - Mar 18. | 15:08 |
| vishalmanchanda | sorry forgot to drop agenda for today meeting link | 15:08 |
| vishalmanchanda | https://etherpad.opendev.org/p/horizon-release-priorities | 15:08 |
| vishalmanchanda | at Line 33 | 15:09 |
| vishalmanchanda | moving to next announcement | 15:09 |
| vishalmanchanda | I have pushed a patch to add Yoga cycle highlights for horizon | 15:10 |
| vishalmanchanda | Please take a look https://review.opendev.org/c/openstack/releases/+/830564 | 15:10 |
| rdopiera | o/ sorry for being late | 15:11 |
| vishalmanchanda | Let me know if I missed any updates which can be add in cycle highlights | 15:11 |
| vishalmanchanda | rdopiera: hi, np | 15:11 |
| -amotoki- is just back to home. today is a holiday in Japan | 15:12 | |
| rdopiera | vishalmanchanda: I will need to merge a small patch that lets us disable the system scope token support on per-service basis, because only keystone is ready in yoga | 15:12 |
| vishalmanchanda | rdopiera: ok, I See. | 15:12 |
| vishalmanchanda | rdopiera: that patch also going to remove System Scope from context switch menu? | 15:13 |
| rdopiera | vishalmanchanda: yes, if it's disabled for all services | 15:14 |
| rdopiera | we can make that the default | 15:14 |
| vishalmanchanda | rdopiera: ok, then I think I should remove System Scope update from Yoga Cycle highlights | 15:15 |
| vishalmanchanda | https://review.opendev.org/c/openstack/releases/+/830564/1/deliverables/yoga/horizon.yaml | 15:15 |
| rdopiera | I will remove it in the same patch? | 15:15 |
| vishalmanchanda | e0ne: amotoki rdopiera : wdys. | 15:16 |
| vishalmanchanda | rdopiera: No I am asking that either we should keep System Scope in Horizon Cycle highlights or not? | 15:17 |
| amotoki | vishalmanchanda: I did not get your point. I am not sure what you are asking. | 15:17 |
| vishalmanchanda | I have pushed a patch to add horizon Yoga cycle highlights | 15:18 |
| vishalmanchanda | https://review.opendev.org/c/openstack/releases/+/830564/1/deliverables/yoga/horizon.yaml | 15:18 |
| rdopiera | vishalmanchanda: I think we can keep it, even if it's disabled by default | 15:18 |
| rdopiera | vishalmanchanda: it is a new feature after all | 15:18 |
| vishalmanchanda | I also mention in that patch horizon added a entry of System scope. | 15:18 |
| vishalmanchanda | but now rdopiera saying that he going to disable it | 15:18 |
| vishalmanchanda | So that's why I am asking we should keep that point or not | 15:19 |
| rdopiera | we can either disable it by default, or only enable it for keystone | 15:19 |
| vishalmanchanda | Sorry for confusion! | 15:19 |
| rdopiera | it's up to us | 15:19 |
| rdopiera | I think that keeping it disabled for now, and only enabling it once it works with most of services is the best from the point of view of the user experience | 15:20 |
| amotoki | regarding the cycle highlight, I think we can mention that the system-scope support in horizon is experimental or partially available for keystone operations. | 15:20 |
| rdopiera | people who want to try it can always enable it themselves | 15:20 |
| vishalmanchanda | rdopiera: amotoki ok cool, agreed. | 15:20 |
| vishalmanchanda | I will update my cycle highlights patch after the meeting and mention that System scope feature is experimental as of now. | 15:22 |
| vishalmanchanda | Also https://review.opendev.org/c/openstack/releases/+/830564 take a look if anything need to be updated there. | 15:22 |
| vishalmanchanda | that's all announcement from my side for this week | 15:23 |
| vishalmanchanda | If anyone else have any announcement to make please go ahead. | 15:23 |
| vishalmanchanda | moving to next topic | 15:24 |
| vishalmanchanda | #topic Release priorities | 15:24 |
| opendevreview | Akihiro Motoki proposed openstack/horizon master: Avoid extra flavor_get in resize server form https://review.opendev.org/c/openstack/horizon/+/830630 | 15:25 |
| vishalmanchanda | New release of pyscss is up https://pypi.org/project/pyScss/1.4.0/ | 15:25 |
| vishalmanchanda | thanks to Ivan | 15:26 |
| vishalmanchanda | It include many fixes https://github.com/Kronuz/pyScss/commits/master | 15:26 |
| vishalmanchanda | So I have pushed a patch to update pyScss version in requirements and horizon project. | 15:27 |
| vishalmanchanda | https://review.opendev.org/c/openstack/requirements/+/830615 | 15:28 |
| vishalmanchanda | https://review.opendev.org/c/openstack/horizon/+/830618 | 15:28 |
| vishalmanchanda | Please take a look at patches. | 15:28 |
| amotoki | what is the impcat to Yoga release? This week is the requirement freeze too (as you may know) | 15:29 |
| amotoki | Can we defer it to Zed or do we need to land it in Yoga? | 15:29 |
| e0ne | amotoki: it enables python 3.10 witch isn't an official runtime for Yoga | 15:30 |
| vishalmanchanda | amotoki: I don't see any issue in bumping the pyScss version to latest. | 15:31 |
| vishalmanchanda | It going to fix some deprecation warning as weel | 15:31 |
| amotoki | e0ne: yes, so my understanding is we don't need to have it in Yoga necessarily, right? | 15:31 |
| vishalmanchanda | well* | 15:31 |
| e0ne | amotoki: it's not required | 15:32 |
| vishalmanchanda | amotoki: I am also fine with doing it in Zed cycle. | 15:32 |
| vishalmanchanda | early Zed cycle | 15:32 |
| amotoki | early Zed cycle makes sense. | 15:32 |
| amotoki | thanks. I just would like to clarify it as this week is the requirement freeze. | 15:33 |
| vishalmanchanda | ok Let's do it in early in Zed early cycle to avoid any issues. | 15:34 |
| vishalmanchanda | moving to next topic | 15:34 |
| vishalmanchanda | #topic Bug deputy report | 15:35 |
| vishalmanchanda | We have 1 new bugs reported from last week. | 15:35 |
| vishalmanchanda | #link https://bugs.launchpad.net/horizon/+bug/1961560 | 15:35 |
| vishalmanchanda | It is related to Zun but I am not have such env. to confirm it. | 15:36 |
| vishalmanchanda | So if anyone else use Zun please confirm the bug or I will also ask the author to add some error logs for the bug | 15:37 |
| vishalmanchanda | moving to next topic | 15:38 |
| amotoki | trying to reproduce it is not the only way to confrim a bug. I | 15:38 |
| amotoki | for example, you can ask an example of volume information response and/or related information to the bug author. | 15:38 |
| vishalmanchanda | amotoki: +1. | 15:39 |
| amotoki | it will help narrowing down the issue | 15:39 |
| vishalmanchanda | #topic On-Demand Agenda | 15:40 |
| vishalmanchanda | there is a patch purposed in openstack/governance about runtime of Nodejs for Zed cycle | 15:41 |
| vishalmanchanda | #link https://review.opendev.org/c/openstack/governance/+/830454/2/reference/runtimes/zed.rst#35 | 15:41 |
| vishalmanchanda | I would like to know your opinion about migration to next nodejs version. | 15:42 |
| vishalmanchanda | Do you think we should migrate to next node js version in next release | 15:42 |
| amotoki | basically yes. horizon dependency on node.js is just a test env, so it should work and otherwise we need to adjust our test env. | 15:43 |
| vishalmanchanda | amotoki: ok. | 15:44 |
| vishalmanchanda | that's all from my side for this week | 15:45 |
| amotoki | I plan to clean up a lot of warnings we see before the yoga release. | 15:45 |
| amotoki | for example RemovedInDjango40 warning, oslo.policy warnings on deprecated rules | 15:45 |
| amotoki | regarding RemovedInDjango40, patches are already proposed. | 15:45 |
| vishalmanchanda | amotoki: that would be great:) | 15:45 |
| amotoki | I am preparing a patch for oslo.policy warnings too | 15:45 |
| vishalmanchanda | amotoki: thanks for letting me know. | 15:46 |
| amotoki | one thing I would like to ask is about django.template debug message. | 15:46 |
| rdopiera | I looked into that | 15:46 |
| rdopiera | it's not possible to fix the templates to not generate those messages | 15:47 |
| rdopiera | the best we can do is silence them | 15:47 |
| amotoki | yeah, previously we did not filter django.template log message as we try to fix but it is not easy and practical to pass ALL parametres in templates. | 15:47 |
| rdopiera | even Django's own built-in templates have that | 15:48 |
| amotoki | so I am wondering to change the log level of django.template to INFO. | 15:48 |
| rdopiera | yes, please | 15:48 |
| vishalmanchanda | +1 on changing log level to INFO. | 15:49 |
| amotoki | thanks for the feedback. I will push a patch on this too | 15:49 |
| vishalmanchanda | Does anyone else have any topic to discuss, please go ahead. | 15:50 |
| ganso | I just wanted to raise awareness of post-merge comments on https://review.opendev.org/c/openstack/horizon/+/806454 so right now it is unclear to me whether there is a problem that would need to be addressed in Yoga or not. Right now everything looks fine to me but I just wanted to make sure we are in agreement | 15:50 |
| amotoki | ganso: I confirmed all pages work after your commit, so there is no issue from user perspective. | 15:51 |
| ganso | IMO there is much more that I wanted to accomplish within Yoga w.r.t to pagination but we are too far late in the dev cycle for this release IMO. Patch https://review.opendev.org/c/openstack/horizon/+/829843 looks like the next step in that big network pagination effort, but I tested it and didn't work for me, or I just don't understand how it works | 15:51 |
| ganso | amotoki: thanks! I was mostly referring to your concern on the function return value, but as I said, it is part of a bigger incremental effort until the old return value type is no longer needed | 15:52 |
| ganso | that's all I had | 15:54 |
| ganso | if there is nothing to discuss further in this topic | 15:54 |
| vishalmanchanda | ganso: I will try to test soon https://review.opendev.org/c/openstack/horizon/+/829843 | 15:55 |
| vishalmanchanda | ganso: You don't see any changes after applying tatina patch? | 15:56 |
| ganso | vishalmanchanda: yea, zero changes | 15:56 |
| ganso | vishalmanchanda: I tried clearing browser cache, restarting services and stuff | 15:56 |
| vishalmanchanda | ganso: maybe you browser not picking up latest code. | 15:56 |
| vishalmanchanda | ganso: just check in developer mode for your browser that these files static/dashboard/project/workflow/launch-instance/network/network.controller.js picks new code or not | 15:57 |
| ganso | vishalmanchanda: thanks, I will try that and report back in the patch | 15:58 |
| vishalmanchanda | ganso: thanks for working on Pagination patch. | 15:58 |
| amotoki | ganso: I understand the situation, but perhaps perhaps we need to have separate functions for paged/non-paged usages. in addition, we should not have an argument for internal usage insdie neutron.py like "single_page" in functions exposed to other layer even during refactoring, but all can be done separately. I am exploring how we can make it more readable. | 15:58 |
| *** gmann is now known as gmann_afk | 15:59 | |
| vishalmanchanda | ok we are out of time. | 16:00 |
| vishalmanchanda | thanks everyone for joining. | 16:00 |
| ganso | amotoki: thanks! | 16:00 |
| vishalmanchanda | #endmeeting | 16:00 |
| opendevmeet | Meeting ended Wed Feb 23 16:00:41 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:00 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-02-23-15.00.html | 16:00 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-02-23-15.00.txt | 16:00 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-02-23-15.00.log.html | 16:00 |
| amotoki | bye | 16:01 |
| opendevreview | Thales Elero Cervi proposed openstack/horizon master: Create Horizon session control logic https://review.opendev.org/c/openstack/horizon/+/817570 | 16:05 |
| *** gmann_afk is now known as gmann | 16:17 | |
| opendevreview | Thales Elero Cervi proposed openstack/horizon master: Create Horizon session control logic https://review.opendev.org/c/openstack/horizon/+/817570 | 17:14 |
| opendevreview | Thales Elero Cervi proposed openstack/horizon master: Create Horizon session control logic https://review.opendev.org/c/openstack/horizon/+/817570 | 19:35 |
| tcervi | amotoki, thanks for putting your time on reviewing our bp merge. | 19:52 |
| opendevreview | Sam Morrison proposed openstack/horizon master: Bugfix: Add missing closing </div> tags to network topology https://review.opendev.org/c/openstack/horizon/+/830692 | 21:36 |
| opendevreview | Merged openstack/horizon master: Integration tests: Allow to run a specific test from tox https://review.opendev.org/c/openstack/horizon/+/829513 | 23:13 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!