| opendevreview | Vishal Manchanda proposed openstack/horizon master: Add a Note Under Install and configure Section in documentation https://review.opendev.org/c/openstack/horizon/+/825254 | 05:15 |
|---|---|---|
| opendevreview | Vishal Manchanda proposed openstack/horizon master: [WIP] Fix hardcoded link error https://review.opendev.org/c/openstack/horizon/+/825315 | 14:23 |
| ade_lee | vishalmanchanda, hey there | 14:42 |
| vishalmanchanda | ade_lee: hello, you can add your topic in our agenda etherpad https://etherpad.opendev.org/p/horizon-release-priorities ( at line 41) | 14:43 |
| vishalmanchanda | ade_lee: let's discuss your issue in today weekly meeting | 14:44 |
| ade_lee | vishalmanchanda, sounds good - will do | 14:44 |
| vishalmanchanda | ade_lee: thanks | 14:44 |
| vishalmanchanda | #startmeeting horizon | 15:00 |
| opendevmeet | Meeting started Wed Jan 19 15:00:09 2022 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| ganso | o/ | 15:01 |
| vishalmanchanda | hello everyone | 15:01 |
| vishalmanchanda | rdopiera: tmazur e0ne amotoki : ping | 15:01 |
| tmazur | o/ | 15:01 |
| e0ne | hi | 15:02 |
| e0ne | vishalmanchanda: I just came back from the vacation. I'm going to continue my contributions starting this week | 15:02 |
| vishalmanchanda | e0ne: great, welcome back:) | 15:02 |
| vishalmanchanda | we will start in two minutes | 15:03 |
| vishalmanchanda | ok let's start | 15:05 |
| vishalmanchanda | #topic Notices | 15:05 |
| vishalmanchanda | Agenda for today meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities (at line 31) | 15:06 |
| vishalmanchanda | As usual Yoga Schedule https://releases.openstack.org/yoga/schedule.html | 15:06 |
| vishalmanchanda | This week is R-10 week. | 15:06 |
| vishalmanchanda | We have only one month left for feature freeze, so please a look at your bp if you want them to merge in yoga cycle. | 15:06 |
| vishalmanchanda | next announcement about CFP | 15:07 |
| vishalmanchanda | Call for Presentations: OpenInfra Summit Berlin 2022 is up. | 15:07 |
| vishalmanchanda | So if you want to purpose any idea, please go for it. | 15:07 |
| vishalmanchanda | The deadline for CFP is February 9th. | 15:07 |
| vishalmanchanda | #link http://cfp.openinfra.dev/app/berlin-2022 | 15:08 |
| vishalmanchanda | moving to next announcement | 15:08 |
| vishalmanchanda | nominations for "Z" release cycle is open till 24th January | 15:09 |
| vishalmanchanda | #link http://lists.openstack.org/pipermail/openstack-discuss/2022-January/026620.html | 15:10 |
| vishalmanchanda | 15:10 | |
| vishalmanchanda | that's all announcement from my side for this week. | 15:10 |
| vishalmanchanda | Does anyone have any announcement to make. | 15:10 |
| vishalmanchanda | moving to next topic | 15:11 |
| vishalmanchanda | #topic release-priorities | 15:11 |
| vishalmanchanda | Can I have 2nd review on Drop Django based implementation of launch instance patch | 15:12 |
| vishalmanchanda | #link https://review.opendev.org/c/openstack/horizon/+/816303 | 15:12 |
| vishalmanchanda | So I can cut a new release of horizon with this and drop of Django 2.2 support. | 15:13 |
| vishalmanchanda | We also have to cut a new release of horizon so plugin like openstack/senlin-dashboard can consume this change https://review.opendev.org/c/openstack/horizon/+/822212 | 15:14 |
| vishalmanchanda | As of now openstack/senlin-dashboard doc job is failing, once we cut a new horizon release it will be fixed. | 15:15 |
| vishalmanchanda | Taking about doc job, you have noticed horizon doc job is also failing. | 15:15 |
| vishalmanchanda | I have purposed a patch to fix it https://review.opendev.org/c/openstack/horizon/+/825315 | 15:16 |
| vishalmanchanda | will let you know once it ready. | 15:16 |
| vishalmanchanda | So Please take a look at https://review.opendev.org/c/openstack/horizon/+/825315 | 15:16 |
| vishalmanchanda | e0ne: tmazur :^^ | 15:16 |
| vishalmanchanda | moving to next item | 15:17 |
| tmazur | I'll take a look later today, thanks | 15:17 |
| vishalmanchanda | As you already know we decided some priority item in the last ptg we added it in our release priority etherpad | 15:18 |
| vishalmanchanda | https://etherpad.opendev.org/p/horizon-release-priorities ( from L6 - L23) | 15:19 |
| vishalmanchanda | So if you are working on of those item please add it's status so everybody. | 15:19 |
| vishalmanchanda | like tmazur working on Improve integartion test and add more integartion test for angular view | 15:20 |
| vishalmanchanda | Please add some summary/status about that so everybody know. | 15:21 |
| vishalmanchanda | e0ne: Did you get time to test saas patch https://review.opendev.org/c/openstack/horizon/+/794809 ? | 15:22 |
| e0ne | sorry, I just deployed devstack :( | 15:22 |
| e0ne | will test. it asap | 15:22 |
| vishalmanchanda | e0ne: ok please take a look and see if we can make it work with Default theme | 15:23 |
| vishalmanchanda | moving to next topic | 15:23 |
| vishalmanchanda | #topic Bug deputy report | 15:24 |
| vishalmanchanda | We have 4 new bugs reported this week | 15:25 |
| vishalmanchanda | I am working on first as of now | 15:26 |
| vishalmanchanda | 2nd bug need to confirm | 15:26 |
| vishalmanchanda | For 3rd bug I tried it on my env. but it works fine for me. | 15:27 |
| vishalmanchanda | I will check it again on a new env. | 15:27 |
| vishalmanchanda | tmazur: e0ne : Could you also try to reproduce in your env and confirm. | 15:28 |
| vishalmanchanda | #link https://bugs.launchpad.net/horizon/+bug/1956552 | 15:28 |
| vishalmanchanda | 4th bug https://bugs.launchpad.net/horizon/+bug/1956091 also need to confirm | 15:29 |
| vishalmanchanda | So please a look at all these bug and add your comment in bug summary on launchpad. | 15:30 |
| vishalmanchanda | moving to next topic | 15:30 |
| vishalmanchanda | #topic On-Demand Agenda | 15:30 |
| vishalmanchanda | So there is a request for patch review https://review.opendev.org/c/openstack/horizon/+/808102 | 15:31 |
| ganso | o/ I added the above ^ link | 15:31 |
| ganso | I just wanted to raise awareness for that patch, since it has been complete, with +1 from vishalmanchanda and sitting from a while, looks like it is in a good shape to be merged | 15:32 |
| vishalmanchanda | I have tested this patch long time back and it look fine to me | 15:32 |
| vishalmanchanda | but got doubt about the naming convention for the unit tests. | 15:32 |
| vishalmanchanda | See my comment at https://review.opendev.org/c/openstack/horizon/+/808102/7/openstack_dashboard/test/unit/api/test_nova.py | 15:33 |
| vishalmanchanda | If it look fine to other core reviewer I will revote to +2. | 15:33 |
| ganso | vishalmanchanda: I saw it, but I'm assuming you were ok with the response | 15:33 |
| ganso | oh cool, so we could get an extra set of core-reviewer eyes it could be pushed to the gate | 15:34 |
| vishalmanchanda | I tested this patch with microversion < or > 2. 46 and it works fine in both the cases. | 15:34 |
| vishalmanchanda | e0ne tmazur : Could you also take a look at https://review.opendev.org/c/openstack/horizon/+/808102 | 15:35 |
| vishalmanchanda | added review-priority for above patch to get more eyes. | 15:36 |
| ganso | thanks! that's all I had for today | 15:36 |
| vishalmanchanda | Next topic is django issues with fips | 15:37 |
| vishalmanchanda | ade_lee: ping | 15:37 |
| ade_lee | hi all - so there is a general push to be able to run on fips enabled systems | 15:37 |
| ade_lee | there is a proposed community goal -- https://review.opendev.org/c/openstack/governance/+/816587 | 15:37 |
| ade_lee | and many projects now have a fips gate | 15:38 |
| ade_lee | I'd like to add one for horizon and will work on one, but there are some fips issues with django | 15:38 |
| ade_lee | as you can see on the agenda, I put up a patch for those issues and it has been merged in django main | 15:39 |
| ade_lee | which I guess means that it will show up in 5.x? | 15:39 |
| ade_lee | but has not been backported | 15:39 |
| ade_lee | so -- question is how we can deal with this? | 15:39 |
| vishalmanchanda | looking at the links | 15:40 |
| ade_lee | one possible approach is to update dependency to later version of django - but not sure if this is possible | 15:41 |
| ade_lee | without the patch, when we run ci tests with devstack, a call to django-admin to set stuff up fails. we could patch django in devstack to avoid this. | 15:44 |
| vishalmanchanda | ade_lee: FYI horizon as of now horizon support Dajngo 3.2 | 15:44 |
| ade_lee | vishalmanchanda, yeah - unless django can be convinced otherwise, they rejected backport to 3.2 | 15:45 |
| ade_lee | or 4.x | 15:45 |
| vishalmanchanda | ade_lee: few of thing already not working in horizon with django 3.2 like django-pyscss | 15:46 |
| vishalmanchanda | ade_lee: django-pyscss doesn't support dajngo 3.2 so we some workaround for that and you are asking about moving Django version to 5.x | 15:47 |
| ade_lee | vishalmanchanda, ack -- I didn;t think it was likely - but had to ask | 15:48 |
| vishalmanchanda | ade_lee: I am not sure about the plan yet but will definitely bring this topic in next ptg. | 15:49 |
| ade_lee | vishalmanchanda, ok -- until we move forward then, are you all ok with a patch to devstack to patch django 3.2? | 15:50 |
| vishalmanchanda | ade_lee: We generally support Django LTS version in horizon like Django 3.2 have LTS support till April 2024. | 15:51 |
| vishalmanchanda | #link https://www.djangoproject.com/download/ | 15:51 |
| vishalmanchanda | ade_lee: but if you can help in the effort in migrating to Django 5.x we can do that in coming cycle | 15:51 |
| vishalmanchanda | ade_lee: even with reviews, as we not have much active contributor in horizon. | 15:52 |
| ade_lee | vishalmanchanda, ack -- I can look - but don't really know horizon :/ | 15:52 |
| ade_lee | vishalmanchanda, but I'll keep that in mind | 15:53 |
| ade_lee | vishalmanchanda, for now, I'll plan to patch devstack so that we can at least get testing going | 15:54 |
| ade_lee | and I'll plan to add a patch for a fips gate for horizon shortly afterwards | 15:54 |
| vishalmanchanda | ade_lee: About the fips, honestly I have no idea about it as of now, will go through the url you have added and let you know the horizon team plan. | 15:54 |
| ade_lee | vishalmanchanda, that would be great - feel free to ping me if you have questions | 15:55 |
| ade_lee | but what we've done so far is create ci jobs that test functionality under fips enabled | 15:55 |
| vishalmanchanda | ade_lee: but it will take time as migrating to 5.x not a easy thing. | 15:56 |
| ade_lee | for bunches of the projects -- found and fixed any issues | 15:56 |
| ade_lee | understood | 15:56 |
| vishalmanchanda | ade_lee: anyway thanks for joining. | 15:56 |
| ade_lee | that will be something I'll call out on the goal proposal | 15:56 |
| ade_lee | yup - thanks for listening all. | 15:57 |
| vishalmanchanda | anyone would like to add anything about this topic. | 15:57 |
| vishalmanchanda | e0ne: tmazur :^^ | 15:57 |
| vishalmanchanda | If nothing else we can end this meeting. | 15:59 |
| vishalmanchanda | Thanks everyone for joining. See you next week! | 15:59 |
| vishalmanchanda | #endmeeting | 15:59 |
| opendevmeet | Meeting ended Wed Jan 19 15:59:51 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:59 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-01-19-15.00.html | 15:59 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-01-19-15.00.txt | 15:59 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-01-19-15.00.log.html | 15:59 |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: Fix hardcoded link error in sphinx 4.4.0 https://review.opendev.org/c/openstack/horizon/+/825386 | 19:30 |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: Fix hardcoded link error in sphinx 4.4.0 https://review.opendev.org/c/openstack/horizon/+/825393 | 20:17 |
| lajoskatona | vishalmanchanda: Hi, sorry for disturbing, could you please increase priority for https://review.opendev.org/c/openstack/horizon/+/805360 | 20:30 |
| vishalmanchanda | lajoskatona: ack. | 20:31 |
| lajoskatona | vishalmanchanda: I changed only min_pps to allow ANY direction for this type of rule (I had to take over this patch from Nitish, as due to reorg He was moved to another project) | 20:31 |
| lajoskatona | vishalmanchanda: thanks :-) | 20:31 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!