| opendevreview | Nitish Venkata Patcherla proposed openstack/horizon master: Add Rules operation to Network QoS Policy https://review.opendev.org/c/openstack/horizon/+/805360 | 05:08 |
|---|---|---|
| vishalmanchanda | amotoki: rdopiera e0ne tmazur: hi all, I have no topic to discuss for today weekly meeting, just few announcement from my side which I can make here. | 14:58 |
| vishalmanchanda | Please Let me know if anyone got any topic to discuss otherwise we will skip this week meeting. | 14:58 |
| amotoki | vishalmanchanda: I have no topic either, but I am not sure whether someone else has a topic. | 15:03 |
| amotoki | vishalmanchanda: It might be better to have a meeting only with On-Demand section rather than canceling it suddely just before it starts. | 15:03 |
| amotoki | vishalmanchanda: it can potentially lose a chance for more folks to raise topics. | 15:04 |
| vishalmanchanda | amotoki: hmm make sense. | 15:04 |
| amotoki | the team meeting is not only for cores | 15:04 |
| rdopiera | o/ | 15:04 |
| amotoki | o/ | 15:05 |
| amotoki | the meeting is not started | 15:05 |
| vishalmanchanda | amotoki: I will update our release priority etherpad and add On-Demand section | 15:06 |
| vishalmanchanda | in case if we go no topic to discuss for the weekly meeting I will send a mail before 1 hour that weekly meeting is cancelled due to lack of topics for discussion. | 15:07 |
| vishalmanchanda | ok announcement from my side. | 15:08 |
| vishalmanchanda | You may have noticed a mail from gmann about RBAC discussion during Yoga PTG | 15:08 |
| vishalmanchanda | http://lists.openstack.org/pipermail/openstack-discuss/2021-October/025322.html | 15:09 |
| vishalmanchanda | So I have also added horizon session Where we can ask keystone team for help about the bugs we are discussing last week or any other issue related to system scope. | 15:09 |
| vishalmanchanda | https://etherpad.opendev.org/p/policy-popup-yoga-ptg at line 38 | 15:10 |
| vishalmanchanda | Timing for Session is Tuesday, Oct 19 @ 16:25 UTC - 17:00 UTC in Cactus. | 15:10 |
| vishalmanchanda | Please let me know if doesn't work for anyone? | 15:10 |
| vishalmanchanda | amotoki: rdopiera : especially you. | 15:11 |
| amotoki | it would work unless I am very sleepy :) | 15:12 |
| vishalmanchanda | 🙂 | 15:12 |
| amotoki | rdopiera: do we need UT in https://review.opendev.org/c/openstack/python-keystoneclient/+/811966 ? I asked it in a cover comment but I am not sure you noticed it. | 15:14 |
| vishalmanchanda | rdopiera: Also Could you please add some references or summary of the issue which you are facing as of now for system Scope in horizon ptg etherpad. | 15:15 |
| rdopiera | amotoki: UT? | 15:16 |
| rdopiera | vishalmanchanda: will do | 15:16 |
| rdopiera | amotoki: by the way, I found that keystoneauth has the code for creating a system scope token, it's just undocumented | 15:16 |
| rdopiera | amotoki: https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/identity/v3/base.py#L166-L174 | 15:17 |
| vishalmanchanda | rdopiera: thanks, link of etherpad for adding references https://etherpad.opendev.org/p/horizon-yoga-ptg at line 64 | 15:17 |
| amotoki | rdopiera: don't we need a test coverage for handling a system scope token in your patch? I see test for domains/projects. | 15:18 |
| amotoki | yeah, keystoneauth already supports it. otherwise, OSC and openstacksdk cannot support the system-scoped token. | 15:21 |
| rdopiera | amotoki: no idea, I just copied the code and changed the names | 15:23 |
| rdopiera | amotoki: if they need anything more, they will tell us | 15:23 |
| rdopiera | eventually, when they get to reviewing it, maybe | 15:23 |
| amotoki | rdopiera: I don't know what is required, so I asked it. Was it better to use an inline comment? no response just confused me. | 15:24 |
| amotoki | * I asked it in the review. | 15:24 |
| amotoki | anyway let's wait feedbacks from the keystone team | 15:25 |
| vishalmanchanda | Last but not least Can I have 2nd review on stable branches backport to drop lc job which fixes stable branches CI. | 15:26 |
| vishalmanchanda | https://review.opendev.org/q/topic:%2522drop-l-c%2522+status:open+project:openstack/horizon | 15:27 |
| vishalmanchanda | e0ne: amotoki :^^ | 15:27 |
| amotoki | vishalmanchanda: ack | 15:29 |
| vishalmanchanda | amotoki: thanks. | 15:29 |
| ganso | amotoki, vishalmanchanda hi! just a reminder to please take a look and provide some feedback athttps://review.opendev.org/c/openstack/horizon/+/806454 when you have some time, so I can finish it up for Yoga. Thanks | 16:16 |
| -opendevstatus- NOTICE: Both Gerrit and Zuul services are being restarted briefly for minor updates, and should return to service momentarily; all previously running builds will be reenqueued once Zuul is fully started again | 22:50 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!