| opendevreview | Akihiro Motoki proposed openstack/horizon master: Add a release note on Django 3.2 support https://review.opendev.org/c/openstack/horizon/+/810347 | 07:11 |
|---|---|---|
| amotoki | vishalmanchanda: ^ a release note on Django 3.2 | 07:11 |
| vishalmanchanda | amotoki: ack. | 07:11 |
| zigo | amotoki: Any idea about this one? https://bugs.launchpad.net/murano/+bug/1944523 | 07:38 |
| zigo | So far, all the other plugins build fine, but I'm stuck with that one ... | 07:38 |
| zigo | amotoki: This one too: https://storyboard.openstack.org/#!/story/2009240 | 07:41 |
| vishalmanchanda | zigo: hi, looks like it is removed in django3.0 https://docs.djangoproject.com/en/3.0/releases/3.0/#features-removed-in-3-0 | 07:44 |
| vishalmanchanda | zigo: try this now from django.templatetags.static import static | 07:45 |
| zigo | vishalmanchanda: Which one? The murano-dashboard one? | 07:45 |
| vishalmanchanda | zigo: yes for murano-dashboard | 07:45 |
| zigo | Ok, thanks, will try. | 07:45 |
| vishalmanchanda | zigo: I am also pushing a patch to gate to see. | 07:46 |
| * zigo is rebuilding murano-dashboard | 07:49 | |
| zigo | vishalmanchanda: Thanks for you help, this was helpful. However, after writing this patch: https://paste.opendev.org/show/809486/ | 08:05 |
| zigo | I still have these: https://paste.opendev.org/show/809485/ | 08:05 |
| zigo | Any clue for the remaining 2 errors? | 08:05 |
| vishalmanchanda | zigo: running unit tests in local env. | 08:15 |
| vishalmanchanda | e0ne: rdopiera : hi, Could you take a look at https://review.opendev.org/c/openstack/horizon/+/810347 | 08:17 |
| vishalmanchanda | I will add above patch hash in release patch https://review.opendev.org/c/openstack/releases/+/810337 | 08:18 |
| e0ne | vishalmanchanda: approved | 08:26 |
| opendevreview | Merged openstack/horizon master: Add a release note on Django 3.2 support https://review.opendev.org/c/openstack/horizon/+/810347 | 08:46 |
| zigo | vishalmanchanda: Only murano-dashboard and trove-dashboard are still failing for me, all the others have been built and uploaded. | 09:18 |
| zigo | I'm going to propose the 1st patch I have for murano-dashboard now. | 09:19 |
| vishalmanchanda | zigo: nice go ahead. | 09:19 |
| zigo | https://review.opendev.org/c/openstack/murano-dashboard/+/810373 | 09:21 |
| amotoki | honestly I am not sure murano-dashboard is maintained. it has almost no meaningful changes. I personally have never run it. | 09:35 |
| amotoki | when I tried to fix murano-dashboard UT, I sometimes hit tests which I cannot understand what is and why needed..... | 09:36 |
| amotoki | UTs failing currently is really specific to murano-dashboard. I am not sure who is actually maintaining it..... | 09:36 |
| amotoki | horizon team is not a maintainer of murano-dashboard :p | 09:37 |
| amotoki | zigo: is an error you hit in trove-dashboard "RuntimeError: dictionary changed size during iteration"? | 09:43 |
| amotoki | zigo: vishalmanchanda: trove-dashboard failure with Django 3.2 looks like a horizon bug. I am investigating it. | 09:57 |
| zigo | amotoki: Cool, thanks ! | 09:57 |
| zigo | amotoki: Indeed, I get the "dictionary changed size during iteration" when running unit tests at Debian package build time ... | 09:58 |
| amotoki | zigo: it seems to happen because Django 3.2 uses dict now to maintain form fields (because dict order is ensured in python 3.7+ as the language spec (and python 3.6 implicitly) | 10:00 |
| zigo | Ah... That's above my skills ! :) | 10:01 |
| amotoki | zigo: np. that's collaboration :) | 10:01 |
| vishalmanchanda | amotoki: yes, need some update here https://github.com/openstack/horizon/blob/master/horizon/workflows/base.py#L172 | 10:02 |
| opendevreview | Radomir Dopieralski proposed openstack/horizon master: Hide enable_port_security checkbox when disallowed by policy https://review.opendev.org/c/openstack/horizon/+/810224 | 10:28 |
| opendevreview | Radomir Dopieralski proposed openstack/horizon master: Hide enable_port_security checkbox when disallowed by policy https://review.opendev.org/c/openstack/horizon/+/810224 | 10:35 |
| opendevreview | Akihiro Motoki proposed openstack/horizon master: workflow: Do not touch dict during iteration https://review.opendev.org/c/openstack/horizon/+/810388 | 10:43 |
| amotoki | vishalmanchanda: ^ a fix for trove-dashboard with django 3.2 | 10:43 |
| vishalmanchanda | amotoki: cool. | 10:44 |
| amotoki | vishalmanchanda: I would like to investigate why it was not detected in the horizon/openstack_dashboard UT but it would be nice to propose a fix first. | 10:44 |
| amotoki | vishalmanchanda: I will be afk from now. feel free to update it if needed. | 10:44 |
| vishalmanchanda | amotoki: LGTM, sure. | 10:44 |
| vishalmanchanda | amotoki: I will include this patch as well in release patch. | 10:45 |
| zigo | vishalmanchanda: amotoki: My patch here fixes all unit tests of murano-dashboard ! :) https://review.opendev.org/c/openstack/murano-dashboard/+/810373 | 10:45 |
| zigo | (I managed to fix the last 2 with a colleague of mine) | 10:45 |
| vishalmanchanda | e0ne: Could you take a look at https://review.opendev.org/c/openstack/horizon/+/800283 | 10:54 |
| opendevreview | Vishal Manchanda proposed openstack/horizon stable/wallaby: Dropping lower constraints testing from stable branches https://review.opendev.org/c/openstack/horizon/+/810432 | 13:26 |
| amotoki | zigo: i am trying my comments on your murano-dashboard patch in my local env. let me try a bit | 13:35 |
| zigo | amotoki: Cheers ! | 13:39 |
| opendevreview | Vishal Manchanda proposed openstack/horizon stable/victoria: Dropping lower constraints testing from stable branches https://review.opendev.org/c/openstack/horizon/+/810436 | 13:44 |
| opendevreview | Vishal Manchanda proposed openstack/horizon stable/victoria: Dropping lower constraints testing from stable branches https://review.opendev.org/c/openstack/horizon/+/810436 | 13:45 |
| opendevreview | Vishal Manchanda proposed openstack/horizon stable/ussuri: Dropping lower constraints testing from stable branches https://review.opendev.org/c/openstack/horizon/+/810444 | 14:05 |
| vishalmanchanda | #startmeeting horizon | 15:00 |
| opendevmeet | Meeting started Wed Sep 22 15:00:14 2021 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| e0ne | hi | 15:00 |
| vishalmanchanda | hello everyone | 15:00 |
| tmazur | o/ | 15:00 |
| amotoki | hi | 15:01 |
| vishalmanchanda | ok let's start the meeting. | 15:02 |
| vishalmanchanda | #topic Notices | 15:02 |
| vishalmanchanda | This week is Xena RC2 week. | 15:02 |
| vishalmanchanda | Xena Schedule https://releases.openstack.org/xena/schedule.html | 15:02 |
| rdopiera | o/ | 15:03 |
| vishalmanchanda | Next week is Final RCs week. | 15:03 |
| vishalmanchanda | During next week only final-release-critical releases will be accepted. | 15:03 |
| vishalmanchanda | I have purposed a patch to cut a new release for horizon to include latest patch merged. | 15:04 |
| vishalmanchanda | https://review.opendev.org/c/openstack/releases/+/810337 | 15:04 |
| vishalmanchanda | Please take a look. | 15:04 |
| amotoki | horizon is cycle-with-intermediary, so it might not be true. we can backport such bugs with priorities though | 15:05 |
| vishalmanchanda | amotoki: +1. | 15:05 |
| amotoki | it depends on when a stable branch is cut. | 15:05 |
| amotoki | s/a/the/ :p | 15:05 |
| vishalmanchanda | release team purpose a patch to cut stable branch https://review.opendev.org/c/openstack/releases/+/810145 but I have -1 on it. | 15:06 |
| vishalmanchanda | I will release horizon 20.1.0 which can be used to create stable/xena branch. | 15:07 |
| vishalmanchanda | I am waiting for https://review.opendev.org/c/openstack/horizon/+/810388 to get merged. | 15:08 |
| vishalmanchanda | Then I will update hash in https://review.opendev.org/c/openstack/releases/+/810337 | 15:08 |
| vishalmanchanda | JFYI https://review.opendev.org/c/openstack/horizon/+/810388 is required for horizon-plugins(trove-dashboard) to build with Django3.2 | 15:09 |
| vishalmanchanda | Acc. to zigo all horizon plugins builds fine with Django3.2 as of now except for two plugins (trove-dashboard, murano-dashboard) | 15:10 |
| vishalmanchanda | Patch to fix murano-dashboard build with Django3.2 is also up https://review.opendev.org/c/openstack/murano-dashboard/+/810373 | 15:11 |
| vishalmanchanda | But I haven't looked it yet. | 15:11 |
| vishalmanchanda | e0ne: rdopiera tmazur : So please take a look at https://review.opendev.org/c/openstack/horizon/+/810388 | 15:11 |
| vishalmanchanda | that's the only announcement from my side for this week. | 15:13 |
| vishalmanchanda | If anyone have any announcement to make please go ahead. | 15:13 |
| vishalmanchanda | moving to next topic. | 15:14 |
| vishalmanchanda | #topic Stable-branches | 15:14 |
| vishalmanchanda | You may have noticed that lower-constraints job is started failing for the stable branches. | 15:14 |
| vishalmanchanda | I have purposed patches to drop lower-constraints job from stable branches, please take a look. | 15:15 |
| vishalmanchanda | https://review.opendev.org/q/topic:%2522drop-l-c%2522+(status:open+OR+status:merged)+project:openstack/horizon | 15:15 |
| vishalmanchanda | that's all update from my side for this week. | 15:17 |
| vishalmanchanda | #topic open-discussion | 15:17 |
| vishalmanchanda | Does anyone have any topic to discuss? | 15:18 |
| tmazur | Just a friendly call for reviewers from my side. I am working on integration tests now, so would be great to have this patch merged: https://review.opendev.org/c/openstack/horizon/+/800283 | 15:20 |
| tmazur | I am planning to unskip more tests and add some new for angular panels | 15:21 |
| amotoki | tmazur: sure. will look into it after django32 work in plugins is done | 15:21 |
| vishalmanchanda | tmazur: great. | 15:21 |
| tmazur | Thank you! | 15:21 |
| vishalmanchanda | need one more +2 on https://review.opendev.org/c/openstack/horizon/+/807047 | 15:23 |
| vishalmanchanda | If nothing more to discuss we can end this meeting. | 15:23 |
| tmazur | Nothing from me | 15:24 |
| vishalmanchanda | Thanks everyone for joining. | 15:24 |
| vishalmanchanda | #endmeeting | 15:24 |
| opendevmeet | Meeting ended Wed Sep 22 15:24:38 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:24 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-09-22-15.00.html | 15:24 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-09-22-15.00.txt | 15:24 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-09-22-15.00.log.html | 15:24 |
| amotoki | I wonder how the situtation would be nice if django32 effort was moved forward two weeks earilier........ | 15:28 |
| vishalmanchanda | amotoki: yeah, my bad:( I take too much time to investigate django-pyscss alternative. | 15:30 |
| opendevreview | Vishal Manchanda proposed openstack/horizon stable/train: Dropping lower constraints testing from stable branches https://review.opendev.org/c/openstack/horizon/+/810490 | 17:15 |
| opendevreview | Vishal Manchanda proposed openstack/horizon stable/train: Dropping lower constraints testing from stable branches https://review.opendev.org/c/openstack/horizon/+/810490 | 17:16 |
| amotoki | zigo: I updated your murano-dashboard patch. hopefully it works | 17:24 |
| opendevreview | Vishal Manchanda proposed openstack/horizon stable/stein: Dropping lower constraints testing from stable branches https://review.opendev.org/c/openstack/horizon/+/810492 | 17:24 |
| amotoki | vishalmanchanda: JFYI tomorrow (already today here) is a holiday in Japan. my reponse would be slow. | 17:27 |
| opendevreview | Vishal Manchanda proposed openstack/horizon stable/wallaby: Escape unicode characters when setting logout_reason cookie https://review.opendev.org/c/openstack/horizon/+/810472 | 17:28 |
| opendevreview | Vishal Manchanda proposed openstack/horizon stable/victoria: Escape unicode characters when setting logout_reason cookie https://review.opendev.org/c/openstack/horizon/+/810473 | 17:30 |
| -opendevstatus- NOTICE: Zuul has been restarted in order to address a performance regression related to event processing; any changes pushed or approved between roughly 17:00 and 18:30 UTC should be rechecked if they're not already enqueued according to the Zuul status page | 18:36 | |
| opendevreview | Merged openstack/horizon master: workflow: Do not touch dict during iteration https://review.opendev.org/c/openstack/horizon/+/810388 | 20:37 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!