| vishalmanchanda | #startmeeting horizon | 15:00 |
|---|---|---|
| opendevmeet | Meeting started Wed Sep 1 15:00:16 2021 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| rdopiera | o/ | 15:00 |
| tmazur | o/ | 15:01 |
| vishalmanchanda | hello everyone | 15:01 |
| vishalmanchanda | Let's wait for few minutes if more people joins us. | 15:02 |
| vishalmanchanda | ok Let's start. | 15:04 |
| vishalmanchanda | #topic Notices | 15:04 |
| vishalmanchanda | This week is Xena-3 milestone. | 15:04 |
| vishalmanchanda | Xena Schedule https://releases.openstack.org/xena/schedule.html | 15:05 |
| vishalmanchanda | Also Feature freeze so no feature patch should be merged after September 3rd. | 15:05 |
| vishalmanchanda | So reviewer please keep that in mind while reviewing any feature patch. | 15:05 |
| vishalmanchanda | I was hoping Qos Policy rule patch merged in xena release but it's look difficult now. | 15:06 |
| vishalmanchanda | https://review.opendev.org/c/openstack/horizon/+/805360 | 15:06 |
| vishalmanchanda | I have pushed the patch to add horizon xena cycle highlight https://review.opendev.org/c/openstack/releases/+/806886 | 15:07 |
| vishalmanchanda | release team is so fast and patch is already merged:) | 15:07 |
| vishalmanchanda | Please let me know if I forgot to add anything that should be good to have in cycle highlights. | 15:07 |
| vishalmanchanda | I will update try to update it. | 15:08 |
| vishalmanchanda | that's all update from my side for this week. | 15:08 |
| vishalmanchanda | #topic open-discussion | 15:09 |
| vishalmanchanda | we have many patches with single +2 so please take a took at those patches. | 15:09 |
| vishalmanchanda | I will also try to push a patch to update 'policy.yaml' file for different backend services under https://github.com/openstack/horizon/tree/master/openstack_dashboard/conf/default_policies by tomorrow. | 15:10 |
| vishalmanchanda | I have no more topic to discuss. | 15:11 |
| vishalmanchanda | Please go ahead if anyone have any topic to discuss. | 15:11 |
| rdopiera | I would like to talk a bit about integration tests. | 15:12 |
| vishalmanchanda | rdopiera: sure, go ahead. | 15:12 |
| rdopiera | We started to look into writing additional integration tests for individual features that have been implemented. However, many of those features require a specific setting in the local_settings.py | 15:12 |
| rdopiera | I wonder how we could implement that with our current system. | 15:13 |
| rdopiera | Obviously, selenium itself can't modify the settings of a running horizon instance. | 15:13 |
| vishalmanchanda | Could you give me some specific example for such case. | 15:14 |
| rdopiera | One change that we have made was changing the order of fields on the login screen with multidomain support enabled. | 15:16 |
| rdopiera | Obviously to test this, we need to enable multidomain support. | 15:16 |
| vishalmanchanda | ahh I see, nothing coming to my mind atm. | 15:19 |
| vishalmanchanda | Does anyone have any thoughts in your mind how can we handle it? | 15:20 |
| vishalmanchanda | e0ne: ^^around? | 15:20 |
| rdopiera | the only thing that I can think of is to have several horizon configurations defined, as required by the tests, and then to tag the tests marking which configuration they expect, then in the job setup one config, run the tests for that config, setup the next, run the tests for it, etc. | 15:21 |
| rdopiera | but this wouldn't work for running the tests locally | 15:21 |
| amotoki | the integration tests runs as a separate process from the web server, so what we can in my initial thought do is to repeat steps with horizon configuration and then running tests. | 15:22 |
| amotoki | rdopiera: you arefaster than me. what doesn't work in your local run? | 15:23 |
| rdopiera | well, in a local run you would need to make the config changes yourself manually | 15:23 |
| amotoki | ah, I see | 15:24 |
| amotoki | our current integration is not so fast and it is run in serial, so adding more tests is not so welcome. perhaps we need to explore how we can make it run in parallel (or run extra tests in a separate job) | 15:25 |
| tmazur | Can we have a few jobs to somehow make them "parallel"? | 15:26 |
| tmazur | With different configs | 15:26 |
| amotoki | sorry, "welcome" was confusing. I mean developers need to wait more and it is not a happy situtation. | 15:27 |
| amotoki | tmazur: thoretically we can. perhaps we need some way to split tests into multiple sets (tag?). | 15:28 |
| rdopiera | we can mark some of the tests as "blocking" and only run those on the gate | 15:28 |
| amotoki | ideally we can run the integration tests in parallel with tox | 15:28 |
| rdopiera | and only run the others locally | 15:28 |
| vishalmanchanda | rdopiera: +1. | 15:29 |
| amotoki | do you mean such "blocking" tests are not run in the CI? | 15:30 |
| rdopiera | I think there is also an opportunity to speed up the integration tests considerably -- I noticed that they spend a long time waiting before handling any modal, but I wasn't able to track down where that wait was happening in code exactly | 15:30 |
| rdopiera | amotoki: tests that are not blocking wouldn't be run on the gate, but they would still run if you run it manually, or we could even have a job that runs all tests once a week or something | 15:30 |
| amotoki | I am not sure we have tests to be marked as "blocking" now. | 15:33 |
| amotoki | btw, perhaps "periodic" job allows us to run more jobs. we can check their results via zuul build results. | 15:34 |
| rdopiera | test_login and test_create_delete_instance come to mind | 15:35 |
| amotoki | test_create_delete_instance is slow but it covers the essential feature. I am not sure it is the thing we can skip in the gate. | 15:38 |
| vishalmanchanda | I am agree with amotoki | 15:39 |
| rdopiera | amotoki: that is why we want it to be blocking | 15:42 |
| rdopiera | amotoki: that is, to run on the gate | 15:42 |
| amotoki | I don't know it is the slowest one | 15:43 |
| ikanias | radopiera: can we just put tests that need pre-configuration under a separate folder and just run them separately? just so we can distinguish between them and the regular tests | 15:43 |
| amotoki | looking at https://zuul.opendev.org/t/openstack/build/54700c9e3d2f4c0fb6180299b7af9410/log/job-output.txt#25385 (one of the recent runs of integration tests) | 15:44 |
| amotoki | project test_create_delete_instances took almost 1m30s | 15:44 |
| rdopiera | ikanias: that's essentially what I proposed, except we don't have to put them in a different directory, we can just tag them,or even use skipif | 15:45 |
| amotoki | I see other tests with around 1m30s or more | 15:45 |
| ikanias | rdopiera: i see | 15:45 |
| rdopiera | yes, we have some unnecessary waits in there | 15:45 |
| vishalmanchanda | Do we have anything else to discuss about this topic? | 15:53 |
| tmazur | I have a question about https://review.opendev.org/c/openstack/horizon/+/793970 | 15:53 |
| tmazur | One integration test is skipped because of this bug | 15:54 |
| tmazur | But the fix is not ideal as far as I can tell | 15:54 |
| vishalmanchanda | tmazur: ok thanks for letting me know. | 15:55 |
| vishalmanchanda | tmazur: I will check it after the meeting and revote. | 15:55 |
| tmazur | Thanks vishalmanchanda | 15:56 |
| tmazur | And also I kindly ask for some attention here: https://review.opendev.org/c/openstack/horizon/+/800283 | 15:57 |
| vishalmanchanda | ok let's end the meeting. | 15:59 |
| vishalmanchanda | Thank you everyone for joining. See you next week. | 16:00 |
| vishalmanchanda | #endmeeting | 16:00 |
| opendevmeet | Meeting ended Wed Sep 1 16:00:58 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:00 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-09-01-15.00.html | 16:00 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-09-01-15.00.txt | 16:00 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-09-01-15.00.log.html | 16:00 |
| tmazur | Thanks everyone! | 16:01 |
| opendevreview | Radomir Dopieralski proposed openstack/horizon master: Escape unicode characters when setting logout_reason cookie https://review.opendev.org/c/openstack/horizon/+/806949 | 16:03 |
| opendevreview | Radomir Dopieralski proposed openstack/horizon master: Escape unicode characters when setting logout_reason cookie https://review.opendev.org/c/openstack/horizon/+/806949 | 16:07 |
| ganso | Hi horizon folks! I have a quick question. I just heard about the future interface. I don't know if that's a separate project or if that's part of the Horizon project roadmap, but I am curious to know when that is expected to be deployed. The main reason of my question is because I was working on pagination for the networks page but it was raised to me the concern that is likely that a lot of things may change and my effort | 16:42 |
| ganso | might be wasted, as everything would be reworked anyway as part of the new interface. Could any of you please confirm this? | 16:42 |
| rdopiera | it's a separate project | 16:44 |
| rdopiera | it's called Skyline | 16:44 |
| ganso | rdopiera: hmm ok so it will not officially replace horizon? more like an alternative web UI ? | 16:44 |
| rdopiera | efforts on Horizon are not going to be wasted, it will likely be still used for years | 16:44 |
| rdopiera | they have different goals | 16:45 |
| rdopiera | of course if it becomes really good and feature-complete, then at some point it might replace horizon, but so far there are no such plans | 16:46 |
| ganso | rdopiera: got it, thanks! Could you please tell me more (or a link to where I can find more info) about this system-scope change? how it will affect existing projects and queries? when it is estimated to be implemented? | 16:47 |
| ganso | rdopiera: context: "horizon is also studying the support of system-scope and the situation may change as API reuqests with a regular user no longer have admin-ness (after switching to system-scope token)" | 16:47 |
| ganso | rdopiera: my main concern is how it will affect the pagination of network tab | 16:48 |
| rdopiera | ganso: there was a detailed discussion on the last PTG, see https://etherpad.opendev.org/p/xena-ptg-horizon-planning#L95 and the other etherpad linked there | 16:48 |
| ganso | rdopiera: thanks! | 16:49 |
| supamatt | any work on this ^ Xena gets release 1st week of oct, only one month away | 18:27 |
| supamatt | its the only openstack project missing system-scope support | 18:27 |
| amotoki | ganso: hi, good morning. I had internal works and haven't looked your patch yet, but I think we can discuss it here (instead of #-neutron) | 23:30 |
| amotoki | ganso: if we need changes in neutron side let's discuss it there. | 23:30 |
| amotoki | ganso: I will look thru yours this afternoon | 23:30 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!