| opendevreview | Michal Nasiadka proposed openstack/horizon stable/victoria: Handle an attached volume without volume_image_metadata https://review.opendev.org/c/openstack/horizon/+/803430 | 04:15 |
|---|---|---|
| *** stack_ is now known as nitish | 06:42 | |
| opendevreview | Nitish Venkata Patcherla proposed openstack/horizon master: Add Create QoS operation to Network QoS Panel https://review.opendev.org/c/openstack/horizon/+/799461 | 11:22 |
| opendevreview | Manpreet Kaur proposed openstack/horizon master: [WIP] Changes for tacker-horizon integration tests https://review.opendev.org/c/openstack/horizon/+/803465 | 11:24 |
| opendevreview | Vadym Markov proposed openstack/horizon master: [WIP] Remove NoVNC authorization token from URL https://review.opendev.org/c/openstack/horizon/+/615599 | 12:10 |
| amotoki | vishalmanchanda: nitish: could you use "network QoS policy" and "QoS policy" consistently? | 12:21 |
| amotoki | vishalmanchanda: nitish: I am against using "Network QoS policy" only in the Create operation. | 12:22 |
| amotoki | vishalmanchanda: nitish: as I commented, it should be done together. I read vishalmanchanda's comments in the previous patch set, but I am not sure what is your intention. | 12:22 |
| vishalmanchanda | amotoki: +1. | 12:30 |
| nitish | amotoki: could you please suggest what should I use for create policy "network qos policy" or "qos policy"? | 12:42 |
| amotoki | nitish: either one works for me. I am just requesting to use it *consistently& | 12:44 |
| amotoki | s/&/*/ | 12:45 |
| amotoki | I don't know what vishalmanchanda suggested in the previous patch set. | 12:45 |
| amotoki | vishalmanchanda: could you clarify what is your intention in your comment in the previous patch set? Did you suggest to use "Network QoS Policy" inclduing the existing ones? | 12:46 |
| amotoki | vishalmanchanda: it would answer nitish's question above. | 12:46 |
| amotoki | nitish: I already commented my opinion in the previous patch set https://review.opendev.org/c/openstack/horizon/+/799461/17/openstack_dashboard/static/app/core/network_qos/actions/actions.module.js#52 | 12:47 |
| vishalmanchanda | amotoki: nitish : yeah I suggested to use "Network QoS Policy". | 12:49 |
| amotoki | vishalmanchanda: in nitish's change? | 12:49 |
| vishalmanchanda | amotoki: yes. | 12:49 |
| amotoki | vishalmanchanda: including the existing ones like "Delete QoS policy"? | 12:50 |
| amotoki | it is not clear per your comment | 12:50 |
| vishalmanchanda | amotoki: ahh sorry for that | 12:52 |
| amotoki | I did not comment about it as I confirmed "QoS policy" is used consistently but you suggested it. I was confused. | 12:52 |
| vishalmanchanda | nitish: as amotoki suggested in his comment you can use "Qos Policy" as of now in your current patch | 12:53 |
| vishalmanchanda | nitish: then you can push a separate patch in which you can change it to "network Qos policy" at all places. | 12:54 |
| vishalmanchanda | amotoki: am I correct? | 12:54 |
| nitish | to maintain consistency for network qos panel I need to make changes for delete operation button also as it is labeled as delete policies | 13:01 |
| vishalmanchanda | nitish: yes. | 13:02 |
| nitish | and for create button the length of "create network qos policy" is more than "create qos policy" | 13:03 |
| amotoki | vishalmanchanda: nitish: I don't have a strong opinions on "network qos policy" vs "qos policy" in the buttons in the QoS panel. | 13:04 |
| amotoki | vishalmanchanda: nitish: I think "QoS policy" is clear enough as long as used in the panel. vishalmanchanda may have a different opinion as he suggested "*network* qos policy. | 13:05 |
| vishalmanchanda | nitish: then let's use "QoS policy" at all places:) | 13:06 |
| vishalmanchanda | nitish: sorry for the confusion:( | 13:06 |
| nitish | yeah np, I got confused. thank you | 13:08 |
| nitish | I have updated the patch could you please review it https://review.opendev.org/c/openstack/horizon/+/799461 | 13:09 |
| opendevreview | Vadym Markov proposed openstack/horizon master: Show image names at Admin-Instances dashboard https://review.opendev.org/c/openstack/horizon/+/803485 | 14:45 |
| vishalmanchanda | Hi team, I have no topics to discuss for this week. | 14:58 |
| vishalmanchanda | Please let me know if anyone would like to discuss anything or we can skip today's weekly meeting. | 14:59 |
| tmazur | Nothing from me as well | 14:59 |
| vishalmanchanda | e0ne: tmazur rdoperia: amotoki :^^ | 14:59 |
| tmazur | rdopiera has PTO today | 14:59 |
| vishalmanchanda | tmazur: ok | 15:00 |
| e0ne | hi | 15:04 |
| e0ne | no updates from me :( | 15:04 |
| vishalmanchanda | e0ne: np. | 15:05 |
| vishalmanchanda | e0ne: Could you take a look at https://review.opendev.org/c/openstack/horizon/+/803465 once you have time, thanks. | 15:06 |
| vishalmanchanda | e0ne: How can we avoid this workaround. | 15:07 |
| e0ne | let me run my devstack vm and open tacker dashboard | 15:13 |
| opendevreview | Vadym Markov proposed openstack/horizon master: Remove NoVNC authorization token from URL https://review.opendev.org/c/openstack/horizon/+/615599 | 15:25 |
| *** whoami-rajat__ is now known as whoami-rajat | 15:37 | |
| opendevreview | Tatiana Ovchinnikova proposed openstack/horizon master: Proper title for Disk Format column https://review.opendev.org/c/openstack/horizon/+/802958 | 16:29 |
| *** ricolin_ is now known as ricolin | 18:02 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!