| zigo | Hi there! | 08:40 |
|---|---|---|
| zigo | In openstack_dashboard/dashboards/identity/users/tabs.py (last line of the file) we have: | 08:40 |
| zigo | tabs = (OverviewTab, RoleAssignmentsTab, GroupsTab,) | 08:40 |
| zigo | Unfortunate, this works only for admins, so we should really do: | 08:40 |
| zigo | tabs = (OverviewTab, ) | 08:40 |
| zigo | for non-admins. How can I add the check there to see if the user is logged as admin? | 08:40 |
| zigo | amotoki: ^ | 08:40 |
| vishalmanchanda | zigo: Hi code looks fine to me, right now RoleAssignmentsTab and GroupsTab will only display for admin user | 09:07 |
| vishalmanchanda | zigo: because of policy rules defined for both tabs. | 09:07 |
| vishalmanchanda | https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/users/tabs.py#L92 | 09:07 |
| vishalmanchanda | https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/users/tabs.py#L139 | 09:08 |
| zigo | vishalmanchanda: That's not what I experienced (Victoria deployment). | 09:08 |
| vishalmanchanda | zigo: hmm a backport patch is up https://review.opendev.org/c/openstack/horizon/+/783547 but not merged yet. | 09:10 |
| zigo | I knew talking about it on IRC was a good idea ! | 09:12 |
| zigo | vishalmanchanda: Thanks a lot, I'll add the patch to the Bullseye package and ask for a release team exception ! | 09:12 |
| vishalmanchanda | e0ne: rdopiera : Could you take a look https://review.opendev.org/c/openstack/horizon/+/783547 | 09:13 |
| vishalmanchanda | ^^ | 09:13 |
| opendevreview | Merged openstack/horizon stable/victoria: Don't load user role assignment or groups tabs for non-admins https://review.opendev.org/c/openstack/horizon/+/783547 | 11:48 |
| vishalmanchanda | #startmeeting horizon | 15:00 |
| opendevmeet | Meeting started Wed Jul 14 15:00:31 2021 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| vishalmanchanda | hi anyone around for horizon meeting? | 15:01 |
| nitish | hi | 15:02 |
| amotoki | hi | 15:03 |
| vishalmanchanda | e0ne: rdopiera tmazur amotoki : around? | 15:03 |
| tmazur | Hi! | 15:03 |
| tmazur | Yes | 15:03 |
| vishalmanchanda | Let's wait for 2 more minutes if more people joins us. | 15:04 |
| vishalmanchanda | ok Let's start. | 15:05 |
| vishalmanchanda | #topic Notices | 15:05 |
| vishalmanchanda | This week is Xena-2 milestone. | 15:06 |
| vishalmanchanda | Xena Schedule https://releases.openstack.org/xena/schedule.html | 15:06 |
| vishalmanchanda | but nothing special for horizon. | 15:06 |
| vishalmanchanda | next announcement is about Yoga Virtual PTG. | 15:07 |
| vishalmanchanda | I have created a etherpad to collect topics for yoga ptg discussion. | 15:08 |
| vishalmanchanda | #link https://etherpad.opendev.org/p/horizon-yoga-ptg | 15:08 |
| vishalmanchanda | Please start adding your topics which you want to discuss during the ptg. | 15:08 |
| vishalmanchanda | For the time slots I have created a poll please vote asap because we have to book the room before July 21. | 15:09 |
| vishalmanchanda | #link https://doodle.com/poll/7vxwprypskrhidhq?utm_source=poll&utm_medium=link | 15:09 |
| vishalmanchanda | I have added most of time slot which we used during past Virtual PTG. | 15:10 |
| vishalmanchanda | I am not sure about how much we needed for ptg discussion atm but I think 4-5 hours are more than enough for us. | 15:11 |
| vishalmanchanda | I have also kept some extra time slots in pole and we can unbook the room it if not required at that time. | 15:12 |
| vishalmanchanda | e0ne: amotoki rdopiera :^^ please vote on doodle once you see. | 15:12 |
| vishalmanchanda | anyway I will send a mail about it on open-discuss. | 15:13 |
| vishalmanchanda | next announcement is about moving stable/queen to EOL | 15:13 |
| amotoki | I cannot decide preferred timeslots as I don't have a priority on horizon sessions perhaps. it would be only up to my timezone and cannot vote more. | 15:14 |
| vishalmanchanda | amotoki: fine. | 15:14 |
| amotoki | my schedule would be decided considering session conflicts with others. | 15:14 |
| rosmaita | (please forgive this interruption, but please ping me when you get to open discussion ... thanks!) | 15:15 |
| vishalmanchanda | amotoki: yeah | 15:15 |
| vishalmanchanda | rosmaita: sure. | 15:15 |
| vishalmanchanda | https://review.opendev.org/c/openstack/releases/+/799543 | 15:15 |
| vishalmanchanda | There is only one issue in moving horizon stable/queen to EOL i.e. manial-ui stable/queens uses horizon stable/queens django template. | 15:17 |
| amotoki | vishalmanchanda: what about points raised by elodilles? | 15:18 |
| vishalmanchanda | but I think manila team also thinking about moving manial-ui stable/queens to EOL(current status EM) which they will discuss in tomorrow's weekly meeting. | 15:18 |
| vishalmanchanda | amotoki: I will follow up with manila team about this. | 15:18 |
| vishalmanchanda | that's all announcement from my side for today. | 15:19 |
| vishalmanchanda | If anyone has other announcements to make please go ahead. | 15:19 |
| nitish | I was working on QoS CRUD operations from Horizon | 15:20 |
| nitish | made a base commit | 15:20 |
| nitish | https://review.opendev.org/c/openstack/horizon/+/799461 | 15:20 |
| vishalmanchanda | nitish: we can discuss it in the end during open-discussion | 15:20 |
| nitish | ok | 15:20 |
| vishalmanchanda | nitish: please wait, thanks. | 15:20 |
| vishalmanchanda | ok moving to next topic | 15:21 |
| vishalmanchanda | #topic retire django_openstack_auth | 15:21 |
| vishalmanchanda | ``django_openstack_auth`` code was merged into the main horizon repository during the queens release. | 15:22 |
| vishalmanchanda | It is already deprecated and I have pushed a series of patches to retire it. | 15:22 |
| vishalmanchanda | Please take a look once you have time and Let me know if I missed any steps for the retirement process. | 15:23 |
| vishalmanchanda | #link https://review.opendev.org/q/topic:%22retire-django-openstack-auth%22+(status:open%20OR%20status:merged) | 15:23 |
| amotoki | regarding tagging pike-eol, https://review.opendev.org/c/openstack/releases/+/800493 has landed and pike-eol tag was created but stable/pike branch was not deleted yet. | 15:24 |
| amotoki | the post job failed https://zuul.opendev.org/t/openstack/build/aac7e7108b26477e9f30542b64ea8694 | 15:24 |
| amotoki | I am not sure this failuree is related to that stalbe/pike branch still exists. | 15:25 |
| vishalmanchanda | but If I am correct then release going to delete stable/pike branch after https://review.opendev.org/c/openstack/releases/+/800493 merged. | 15:26 |
| vishalmanchanda | I am not sure but it is what I observed so far. | 15:26 |
| amotoki | that is what we expect but the script failed due to the absense of .gitreview in the master branch due to the master branch retirement. | 15:27 |
| vishalmanchanda | amotoki: hmm I see. | 15:27 |
| vishalmanchanda | I will discuss with the release team how to proceed further. | 15:28 |
| vishalmanchanda | moving to next topic | 15:30 |
| vishalmanchanda | #topic open-discussion | 15:30 |
| vishalmanchanda | nitish: please go ahead. | 15:30 |
| nitish | I was working on QoS CRUD operations from Horizon | 15:31 |
| nitish | and made a commit for enablin qos panel and creating qos policy | 15:31 |
| nitish | commit link : https://review.opendev.org/c/openstack/horizon/+/799461 | 15:32 |
| nitish | I want to know what are the expectations on this feature | 15:33 |
| vishalmanchanda | nitish: thanks for working on that. | 15:33 |
| vishalmanchanda | nitish: I will try to review it by end of this week and let you know. | 15:33 |
| nitish | ok | 15:34 |
| amotoki | nitish: what do you mean by "the expectations"? | 15:34 |
| amotoki | nitish: you are working on the feature so I wonder you are more familiar with the feature. | 15:34 |
| amotoki | (while I know the feature as I am working on neutron too) | 15:35 |
| nitish | I was working on this feature by going through the openstack neutron qos docs | 15:36 |
| amotoki | not now? | 15:37 |
| vishalmanchanda | rosmaita: hi, ping. | 15:39 |
| rosmaita | hello | 15:40 |
| rosmaita | i have a quick question | 15:40 |
| rosmaita | we are removing v2 support from the cinderclient | 15:40 |
| rosmaita | #link https://review.opendev.org/c/openstack/python-cinderclient/+/792959 | 15:40 |
| rosmaita | and sorry, that patch had passed earlier, but now is failing tempest | 15:40 |
| rosmaita | turns out that horizon is still using v2 a bit | 15:41 |
| rosmaita | in this place: | 15:41 |
| rosmaita | https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/api/cinder.py | 15:41 |
| rosmaita | at lines 31 | 15:41 |
| rosmaita | and then 59-68 | 15:41 |
| rosmaita | i'm working on a patch | 15:41 |
| rosmaita | but my question is, | 15:41 |
| rosmaita | for xena horizon, you will be packaged with xena cinderclient, right? | 15:42 |
| rosmaita | so horizon won't need to check anymore to see which client is available | 15:42 |
| rosmaita | at lines 59-68 | 15:42 |
| rosmaita | or, i could put line 31 in a similar kind of try/catch block | 15:43 |
| rosmaita | if you can't import v2, get list-extensions from v3 | 15:43 |
| rosmaita | was just wondering what you would suggest | 15:43 |
| amotoki | generally speaking, horizon support should be along with corresponding back-end services from a same release, | 15:44 |
| amotoki | so yes we need to clean up cinder v2 support. | 15:44 |
| rosmaita | ok, so if i put up a patch that only uses v3, that would be OK with you? | 15:44 |
| amotoki | i am fine. | 15:45 |
| vishalmanchanda | rosmaita: +1. | 15:45 |
| rosmaita | the only other place i see cinderclient v2 is in some tests, and those should convert to v3 fine | 15:45 |
| rosmaita | https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/test/test_data/cinder_data.py | 15:45 |
| rosmaita | i will get a patch up within the next hour | 15:46 |
| amotoki | we also need to clean up attributes only available in cinder v2 API. | 15:46 |
| amotoki | for example, consistencygroup_id at https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/api/cinder.py#L90 | 15:46 |
| rosmaita | amotoki: hopefully there won't be any | 15:46 |
| rosmaita | i will check though | 15:46 |
| amotoki | it can be cleanup separately though. | 15:46 |
| rosmaita | version 3.0 is supposed to be exactly the same as v2 | 15:47 |
| rosmaita | but we will see if that is true! | 15:47 |
| rosmaita | thanks, i will ping you here when the patch is ready | 15:47 |
| amotoki | ah, consistency group feature is available in v3 while it is deprecated(?) in favor of the group feature. | 15:47 |
| rosmaita | amotoki: yes, we never got rid of it | 15:48 |
| rosmaita | at least not in the API | 15:48 |
| rosmaita | hopefully , the client classes are consistent with that | 15:48 |
| rosmaita | (it happened before i started working on cinder) | 15:48 |
| amotoki | anyway the first step is to remove the dependency on cinderclient v2 code. I will help the effort. | 15:49 |
| rosmaita | amotoki: ty, i will get a patch up, so if you can review quickly that will be awesome | 15:49 |
| rosmaita | appreciate your help! | 15:49 |
| vishalmanchanda | rosmaita: thanks for bringing this topic, I saw your mail about v2 removal but I thought we didn't use the v2 version. | 15:49 |
| rosmaita | and sorry i didn't figure out until today that this was a problem! | 15:49 |
| amotoki | rosmaita: no problem | 15:50 |
| vishalmanchanda | rosmaita: just for curiosity could please paste here failed tempest patch link. | 15:50 |
| rosmaita | sure | 15:50 |
| rosmaita | https://zuul.opendev.org/t/openstack/build/e048e80cd52c4cb69a84e3a728ddf19d | 15:50 |
| rosmaita | it's in tempest.scenario.test_dashboard_basic_ops.TestDashboardBasicOps.test_basic_scenario | 15:51 |
| vishalmanchanda | rosmaita: thanks. | 15:51 |
| rosmaita | right when tempest tries to log in to the dashboard | 15:51 |
| rosmaita | good thing it's there! | 15:52 |
| vishalmanchanda | rosmaita: nice we added it there during the last release. | 15:52 |
| amotoki | it is a good side-effect which I did not expect when we merged tempest-horizon into horizon :) | 15:52 |
| vishalmanchanda | haha🙂) | 15:52 |
| amotoki | otherwise perhaps the horizon UT in the requirements repo after cinderclient release will detect this failure. | 15:53 |
| amotoki | early detection would be much nicer :) | 15:54 |
| vishalmanchanda | ok anyone has any other topic to discuss otherwise we can end this meeting. | 15:54 |
| vishalmanchanda | thanks everyone for joining, see you next week! | 15:56 |
| vishalmanchanda | tc. | 15:56 |
| vishalmanchanda | #endmeeting | 15:57 |
| opendevmeet | Meeting ended Wed Jul 14 15:57:10 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:57 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-07-14-15.00.html | 15:57 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-07-14-15.00.txt | 15:57 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-07-14-15.00.log.html | 15:57 |
| amotoki | vishalmanchanda: I confirmed the release-post job failure in the #-releases channel. the release manager (ie. the release team) run the script to delete eol'ed branch manually, so let's wait for a while. | 16:04 |
| vishalmanchanda | amotoki: ok thanks for the info. | 16:04 |
| vishalmanchanda | tmazur: nitish:^^ I have update the doodle poll time-slots, Could please revote. | 16:13 |
| tmazur | vishalmanchanda: thanks, done! | 16:15 |
| opendevreview | Brian Rosmaita proposed openstack/horizon master: Use cinderclient v3 classes https://review.opendev.org/c/openstack/horizon/+/800814 | 16:36 |
| rosmaita | amotoki: looks like you were right about v2-only attributes, looking at that now | 17:32 |
| rosmaita | ok, looks like i need to make the horizon patch dependent on the cinderclient patch, was hoping i could keep them independent | 17:35 |
| opendevreview | Brian Rosmaita proposed openstack/horizon master: Use cinderclient v3 classes https://review.opendev.org/c/openstack/horizon/+/800814 | 17:36 |
| amotoki | rosmaita: thanks for the patch. It drops v2 support from horizon so it is nice to have a release note on this. We also need to bump the major version of horizon. | 17:40 |
| rosmaita | np, i will add a release note | 17:41 |
| amotoki | rosmaita: thanks | 17:43 |
| amotoki | vishalmanchanda: stable/pike of d-o-a has been removed. you can move the retirement process forward now. | 17:44 |
| vishalmanchanda | amotoki: ack. | 17:45 |
| opendevreview | Brian Rosmaita proposed openstack/horizon master: Use cinderclient v3 classes https://review.opendev.org/c/openstack/horizon/+/800814 | 18:26 |
| rosmaita | amotoki: let me know what you think of the release note ... in the meantime, i figured out why all the tests are still failing, namely, horizon uses a released version of python-cinderclient | 18:27 |
| rosmaita | i think if i make the cinderclient patch dependent on this one, though, we should see the tempest tests pass in cinderclient | 18:27 |
| rosmaita | working on that now | 18:27 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!