| *** vishalmanchanda has quit IRC | 00:05 | |
| *** tosky has quit IRC | 00:36 | |
| *** iurygregory_ has joined #openstack-horizon | 01:30 | |
| *** another_larsks has joined #openstack-horizon | 01:31 | |
| *** iurygregory has quit IRC | 01:38 | |
| *** larsks has quit IRC | 01:39 | |
| *** jamesdenton has joined #openstack-horizon | 03:42 | |
| *** jamesdenton has quit IRC | 03:50 | |
| *** jamesdenton has joined #openstack-horizon | 03:51 | |
| *** gyee has quit IRC | 03:58 | |
| *** vishalmanchanda has joined #openstack-horizon | 04:59 | |
| *** jamesdenton has quit IRC | 05:57 | |
| *** jamesden_ has joined #openstack-horizon | 05:58 | |
| *** e0ne has joined #openstack-horizon | 06:31 | |
| *** ChanServ sets mode: +o e0ne | 06:31 | |
| *** e0ne has quit IRC | 06:31 | |
| *** e0ne has joined #openstack-horizon | 07:22 | |
| *** ChanServ sets mode: +o e0ne | 07:22 | |
| *** e0ne has quit IRC | 07:27 | |
| *** BakaKuna has joined #openstack-horizon | 07:46 | |
| *** dklyle has quit IRC | 07:48 | |
| *** rdopiera has joined #openstack-horizon | 07:56 | |
| *** rpittau|afk is now known as rpittau | 08:27 | |
| *** tosky has joined #openstack-horizon | 08:46 | |
| *** rcernin has quit IRC | 09:54 | |
| *** BakaKuna has quit IRC | 10:00 | |
| *** BakaKuna has joined #openstack-horizon | 10:02 | |
| *** e0ne has joined #openstack-horizon | 10:35 | |
| *** ChanServ sets mode: +o e0ne | 10:35 | |
| *** iurygregory_ is now known as iurygregory | 11:33 | |
| *** disap has joined #openstack-horizon | 12:05 | |
| *** kevko has joined #openstack-horizon | 12:06 | |
| *** BakaKuna has quit IRC | 12:53 | |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon master: [DNM] Testing Plugin-related unit tests https://review.opendev.org/c/openstack/horizon/+/779770 | 14:02 |
|---|---|---|
| *** BakaKuna has joined #openstack-horizon | 14:06 | |
| *** tmazur has joined #openstack-horizon | 14:07 | |
| *** jamesden_ is now known as jamesdenton | 14:09 | |
| *** disap has quit IRC | 14:15 | |
| *** BakaKuna1 has joined #openstack-horizon | 14:33 | |
| *** BakaKuna has quit IRC | 14:35 | |
| *** BakaKuna1 is now known as BakaKuna | 14:35 | |
| *** fnordahl has quit IRC | 14:42 | |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon master: [DNM] Testing Plugin-related unit tests https://review.opendev.org/c/openstack/horizon/+/779770 | 15:02 |
| *** jamesdenton has quit IRC | 15:35 | |
| *** jamesdenton has joined #openstack-horizon | 15:36 | |
| *** BakaKuna has quit IRC | 15:37 | |
| *** dklyle has joined #openstack-horizon | 15:43 | |
| *** ikanias has joined #openstack-horizon | 16:00 | |
| -amotoki- moving here | 16:00 | |
| tmazur | So what do you think of user-domain-password order? | 16:01 |
| amotoki | if so, I prefer to user-password-domain | 16:01 |
| ikanias | tmazur: I still stick to username/pass/domain | 16:01 |
| amotoki | as we don't need to move the extra field | 16:01 |
| amotoki | the usual pattern is to typy username, TAB (to the password field) and type password. | 16:02 |
| amotoki | s/typy/type/ | 16:02 |
| ikanias | tamotoki: exactly | 16:02 |
| e0ne | amotoki: +1 | 16:02 |
| tmazur | e0ne: what is your opinion on user-password-domain? | 16:02 |
| e0ne | I'm ok for it | 16:02 |
| amotoki | I am okay to move the domain field at the bottom. it looks like it addresses user frustration. | 16:03 |
| amotoki | it can also avoid a new setting. | 16:03 |
| tmazur | Okay then it seems we have an agreement | 16:03 |
| ikanias | like amotoki said it does not seperate username/password | 16:04 |
| ikanias | which is important | 16:04 |
| tmazur | So I am simply moving Domain field to the bottom, no new setting | 16:04 |
| ikanias | tmazur: +1 | 16:04 |
| tmazur | And we can consider it as a bugfix now | 16:04 |
| amotoki | if we keep the order of domain->user->password and focus "user" by default, users are forced to move the cursor up and down if the domain field is empty | 16:05 |
| tmazur | amotoki: true | 16:05 |
| e0ne | amotoki: or we can focus on domain field (the fist field) by default | 16:05 |
| tmazur | e0ne: we have it now :) | 16:06 |
| tmazur | e0ne: the point was to shift it to user name since we have a customer's request for this | 16:06 |
| amotoki | e0ne: but the problem we are tackling is that focusing on domain field is unnecessary when the domain field is already filled (in case of second or later login) | 16:06 |
| e0ne | I understand it... | 16:07 |
| e0ne | so moving domain field to to bottom sounds good, we just need to be sure that we can submit a form by pressing 'enter' button | 16:08 |
| amotoki | so I see only two choicse: (1) move "domain" to the bottom (2) set the default focus to "domain" if empty and to "user" if "domain" is filled | 16:08 |
| tmazur | Let's vote maybe? | 16:09 |
| amotoki | through our discussion (1) sounds simpler | 16:09 |
| ikanias | amotoki: it seems to me the first option is more simple or am i wrong | 16:09 |
| ikanias | amotoki: testing it will be simpler too :-) | 16:10 |
| amotoki | I just rewind our dissuccion and clarify the options we have as I believe it moves us to the agreement. | 16:10 |
| amotoki | I agree (1) looks simpler, so my vote is (1) now. | 16:11 |
| e0ne | +1 | 16:11 |
| ikanias | +1 | 16:11 |
| tmazur | (1) is simple indeed, and we can even simplify the existing code with it | 16:11 |
| tmazur | so +1 | 16:11 |
| vishalmanchanda | vote for option 1. | 16:11 |
| amotoki | sounds fine :) | 16:11 |
| amotoki | we seem to reach the consensus | 16:12 |
| amotoki | let's move the domain field to the bottom | 16:12 |
| tmazur | Ok cool :) Thanks everyone for your time! | 16:12 |
| e0ne | can we discuss one more patch? | 16:12 |
| amotoki | it was nice to cover various options and compare them :) | 16:13 |
| amotoki | e0ne: go ahead | 16:13 |
| tmazur | sure | 16:13 |
| e0ne | https://review.opendev.org/c/openstack/horizon/+/779125 | 16:13 |
| e0ne | since we agreed to do it on the last meeting, I'm OK to merge it | 16:13 |
| e0ne | but we shouldn't do such things just before feature freeze in the future | 16:13 |
| e0ne | maybe we should agree to add deprecations only before milestone-2 | 16:14 |
| tmazur | e0ne: will it be Horizon's way or other projects have similar agreements? | 16:15 |
| amotoki | e0ne: the deprecation does not mean a corresponding feature will be dropped in the next release, so I think it is acceptable | 16:15 |
| amotoki | If you see any feature gap, please file a bug to horizon or contact the horizon team. | 16:15 |
| e0ne | tmazur: I don't know if other projects do this | 16:15 |
| e0ne | but since horizonn does several releases during release cycle it's good to have some agreement on deprecations | 16:16 |
| amotoki | I added the above notice in the release note. | 16:16 |
| e0ne | amotoki: sure, I'm not going to block it. just want to raise this topic | 16:17 |
| amotoki | e0ne: yeah, good point | 16:17 |
| e0ne | we can discuss it on PTG | 16:17 |
| amotoki | in case of neutron, we don't block any deprecation before the feature freeze. | 16:17 |
| vishalmanchanda | I also have a topic to discuss. | 16:18 |
| amotoki | even after the feature freeze, we sometimes add a deprecation notice if needed. they does not change any features. | 16:18 |
| amotoki | Does discussing it in PTG mean we defer the deprecation to Xena? | 16:19 |
| e0ne | no | 16:19 |
| e0ne | we agreed to deprecate it | 16:19 |
| e0ne | I approved it | 16:21 |
| amotoki | I can add more note like "we plan to drop it in 'Y' release at latest" in the relnote | 16:21 |
| amotoki | to clarify we need feedbacks from operators. | 16:21 |
| -amotoki- "at latest" might be wrong usage.... | 16:22 | |
| *** gyee has joined #openstack-horizon | 16:22 | |
| amotoki | anyway we can decide when we drop it carefully | 16:23 |
| e0ne | +1 | 16:23 |
| vishalmanchanda | I am investigating a bug today i.e. https://bugs.launchpad.net/horizon/+bug/1866666 . | 16:25 |
| openstack | Launchpad bug 1866666 in OpenStack Dashboard (Horizon) "Plugin-related unit tests depend on import and test order" [Undecided,New] - Assigned to Ivan Kolodyazhny (e0ne) | 16:25 |
| amotoki | perhaps https://governance.openstack.org/tc/reference/tags/assert_follows-standard-deprecation.html is a good document to read. | 16:25 |
| vishalmanchanda | but I am not able to run these test on my local env. https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/test_plugins/test_panel.py#L50 | 16:26 |
| amotoki | vishalmanchanda: have you got any finding? | 16:26 |
| vishalmanchanda | here is my error logs https://pastebin.com/tCsE2hQF | 16:27 |
| amotoki | vishalmanchanda: this happens when we run horizon UT in parallel (I mean "with muptiple processes") | 16:27 |
| amotoki | vishalmanchanda: it depends on the number of processes of pytest. | 16:27 |
| amotoki | vishalmanchanda: I don't remember the right number but it happened when I tried the number of processes of pytest from all numbers from 2 to 8. | 16:28 |
| amotoki | vishalmanchanda: perhaps one of 2,3,4 triggered the failure. | 16:29 |
| vishalmanchanda | amotoki: ok, do you have any doc. link for that. | 16:30 |
| vishalmanchanda | If I want to run it on my local env. and want to debug it how can I do that | 16:30 |
| amotoki | vishalmanchanda: I cannot remember the right comments on this, but perhaps bug 1809983 referred in the bug you post | 16:35 |
| openstack | bug 1809983 in OpenStack Dashboard (Horizon) "unittest: NoReverseMatch for test panels sometimes happens" [High,Fix released] https://launchpad.net/bugs/1809983 - Assigned to Akihiro Motoki (amotoki) | 16:35 |
| amotoki | in addition, my comment on testing results in https://review.opendev.org/c/openstack/horizon/+/730289 may help you. | 16:36 |
| amotoki | perhaps the first is more related. | 16:36 |
| vishalmanchanda | amotoki: ok thanks for the links will look into that. | 16:37 |
| amotoki | but both are related in the context that it happens when we run UT in parallel or run a specific set of tests. | 16:37 |
| *** takamatsu has quit IRC | 16:37 | |
| vishalmanchanda | amotoki: ok got your point. | 16:38 |
| *** rpittau is now known as rpittau|afk | 17:05 | |
| *** takamatsu has joined #openstack-horizon | 17:38 | |
| openstackgerrit | Merged openstack/horizon master: Deprecate Django launch instance form https://review.opendev.org/c/openstack/horizon/+/779125 | 18:03 |
| *** takamatsu has quit IRC | 18:10 | |
| *** BakaKuna has joined #openstack-horizon | 18:22 | |
| *** tbarron has joined #openstack-horizon | 18:37 | |
| *** e0ne has quit IRC | 18:48 | |
| *** rdopiera has quit IRC | 18:49 | |
| *** BakaKuna has quit IRC | 19:29 | |
| *** mugsie__ has joined #openstack-horizon | 19:37 | |
| *** tosky_ has joined #openstack-horizon | 19:37 | |
| *** benj_- has joined #openstack-horizon | 19:37 | |
| *** tosky has quit IRC | 19:42 | |
| *** benj_ has quit IRC | 19:42 | |
| *** mugsie has quit IRC | 19:42 | |
| *** irclogbot_2 has quit IRC | 19:44 | |
| *** jamesdenton has quit IRC | 19:45 | |
| *** mugsie__ is now known as mugsie | 19:47 | |
| *** jamesdenton has joined #openstack-horizon | 19:48 | |
| *** ysirndjuro has joined #openstack-horizon | 19:52 | |
| ysirndjuro | Hello. Is there a way to pregenerate static and cache files for Horizon? We noticed a long build on initial login into a newly provisioned cloud, as well as the first time a user/admin loads each component tab. Theoretically it could be done by using a standalong requests python module to emulate a login and hitting each page, but was wondering if manage.py in the horizon container already supported functionality to bui | 19:54 |
| *** tosky_ is now known as tosky | 20:16 | |
| *** takamatsu has joined #openstack-horizon | 20:25 | |
| *** tosky has quit IRC | 20:49 | |
| *** tosky has joined #openstack-horizon | 20:49 | |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon master: Move "Domain" field under "User Name" and "Password" https://review.opendev.org/c/openstack/horizon/+/777690 | 20:58 |
| *** dklyle has quit IRC | 21:10 | |
| *** NobodyCam has quit IRC | 21:39 | |
| *** NobodyCam has joined #openstack-horizon | 21:40 | |
| *** dklyle has joined #openstack-horizon | 21:42 | |
| *** johnsom has quit IRC | 21:46 | |
| *** johnsom has joined #openstack-horizon | 21:46 | |
| *** vishalmanchanda has quit IRC | 22:08 | |
| *** rcernin has joined #openstack-horizon | 22:27 | |
| *** ysirndjuro has left #openstack-horizon | 23:20 | |
| *** ysirndjuro has quit IRC | 23:20 | |
| *** rpittau|afk has quit IRC | 23:37 | |
| *** rpittau|afk has joined #openstack-horizon | 23:37 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!