| *** tosky has quit IRC | 00:00 | |
| *** tkajinam has quit IRC | 00:16 | |
| *** tkajinam has joined #openstack-horizon | 00:16 | |
| *** tmazur has quit IRC | 00:29 | |
| *** benj_ has quit IRC | 00:54 | |
| *** zigo has quit IRC | 00:54 | |
| *** benj_ has joined #openstack-horizon | 00:54 | |
| -openstackstatus- NOTICE: The Gerrit service on review.opendev.org is being restarted quickly to make heap memory and jgit config adjustments, downtime should be less than 5 minutes | 01:09 | |
| *** amotoki has quit IRC | 02:01 | |
| *** amotoki has joined #openstack-horizon | 02:02 | |
| *** ChanServ sets mode: +v amotoki | 02:02 | |
| *** lifeless has quit IRC | 02:25 | |
| *** lifeless has joined #openstack-horizon | 02:27 | |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Update lower constraints to match the pylint v.2.6.0 https://review.opendev.org/c/openstack/horizon/+/765865 | 02:34 |
|---|---|---|
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Update lower constraints to match the pylint v.2.6.0 https://review.opendev.org/c/openstack/horizon/+/765865 | 02:35 |
| *** vishalmanchanda has joined #openstack-horizon | 04:55 | |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon stable/rocky: Cap bandit for python 2.7 env https://review.opendev.org/c/openstack/horizon/+/766129 | 05:12 |
| *** gyee has quit IRC | 06:28 | |
| *** dklyle has quit IRC | 07:34 | |
| *** lifeless has quit IRC | 07:54 | |
| *** lifeless has joined #openstack-horizon | 07:56 | |
| *** tosky has joined #openstack-horizon | 08:02 | |
| *** rpittau|afk is now known as rpittau | 08:14 | |
| *** rcernin has quit IRC | 08:56 | |
| *** rcernin has joined #openstack-horizon | 08:56 | |
| *** CeeMac has quit IRC | 09:07 | |
| *** rcernin has quit IRC | 09:23 | |
| *** rcernin has joined #openstack-horizon | 09:32 | |
| *** rcernin has quit IRC | 09:48 | |
| *** rcernin has joined #openstack-horizon | 09:49 | |
| *** rcernin has quit IRC | 10:31 | |
| *** rcernin has joined #openstack-horizon | 10:53 | |
| *** e0ne has joined #openstack-horizon | 11:37 | |
| *** ChanServ sets mode: +o e0ne | 11:37 | |
| *** rcernin has quit IRC | 12:04 | |
| e0ne | amotoki, vishalmanchanda: hi. I have an unexpected call today at 15.00. I hope it won't be lonther than 30 minutes, but I can't attend our meeting from the beginning | 13:47 |
| *** noonedeadpunk has quit IRC | 14:30 | |
| *** tmazur has joined #openstack-horizon | 14:31 | |
| *** noonedeadpunk_ has joined #openstack-horizon | 14:33 | |
| tmazur | Hey, do we have weekly meeting today? | 15:08 |
| *** hoonetorg has quit IRC | 15:14 | |
| e0ne | we can do it now | 15:24 |
| e0ne | amotoki, vishalmanchanda, tmazur: do we need a meeting today? | 15:24 |
| tmazur | I was going to ask for some attention to my js dependencies update patch | 15:26 |
| tmazur | apparently it needs to set a global variable to zuul job and I have no idea so far how to do that properly | 15:28 |
| e0ne | tmazur: could you please drop links here? I'll test them | 15:28 |
| tmazur | e0ne: https://review.opendev.org/c/openstack/horizon/+/766106 | 15:28 |
| tmazur | e0ne: locally it works perfectly but the job fails with "No binary for Chrome browser on your platform. Please, set "CHROME_BIN" env variable." | 15:30 |
| tmazur | e0ne: thanks! | 15:30 |
| *** dklyle has joined #openstack-horizon | 15:37 | |
| *** ChanServ sets mode: +o dklyle | 15:37 | |
| amotoki | e0ne: i had a short sleep. I have nothing special today. | 15:39 |
| *** lxkong has quit IRC | 15:39 | |
| e0ne | tmazur: I'm looking what do we install with bindep profile nodejs | 15:40 |
| amotoki | tmazur: how did you test it locally? Jasmine or npm run test? | 15:41 |
| amotoki | tmazur: e0ne: a browser is installed via zuul-jobs/playbooks/javascript/browser.yaml, so it is not handled by bindep.txt. | 15:42 |
| e0ne | amotoki, tmazur: we install firefox using bindep for integration tests | 15:43 |
| amotoki | tmazur: e0ne: more specifically we install chromium-browser in zuul-jobs/roles/nodejs-test-dependencies/tasks/main.yaml. the binary name is not 'chrome' but 'chromium-browser'. it might be a problem with the updated packages. | 15:44 |
| tmazur | amotoki: npm run test | 15:44 |
| e0ne | amotoki: good catch. I don't think we can use chrome | 15:44 |
| tmazur | amotoki: thanks, that might be it! | 15:45 |
| amotoki | e0ne: tmazur: but what i am not sure is why it works now. | 15:45 |
| tmazur | amotoki: it works only locally in my env | 15:46 |
| tmazur | but I have chrome, yes | 15:46 |
| e0ne | we can check browser to chromium or firefox in our karma configs | 15:49 |
| tmazur | e0ne: I'll change and we will see | 15:50 |
| e0ne | tmazur, amotoki: maybe this commit https://github.com/karma-runner/karma-chrome-launcher/commit/33e8d82 breaks gate now | 15:51 |
| e0ne | it's introduced in 2.1.0 | 15:52 |
| e0ne | https://github.com/karma-runner/karma-chrome-launcher/commit/33e8d82#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346R152 | 15:53 |
| amotoki | so do we need to set Chromium as a browser in karma config? | 16:04 |
| amotoki | or do we want to switch to firefox? | 16:04 |
| e0ne | I prefer firefox just because I have it on my env | 16:14 |
| tmazur | so we have to change it to firefox in zuul-jobs/roles/nodejs-test-dependencies/tasks/main.yaml first? | 16:19 |
| amotoki | tmazur: I think we can have both chromium and firefox in our env, so I don't think we need to update zuul-jobs/roles/nodejs-test-dependencies/tasks/main.yaml | 16:25 |
| amotoki | tmazur: we can install firefox in our job config and use it in karma. | 16:25 |
| tmazur | amotoki: hope it won't fail with "please set FIREFOX_BIN". Anyway, let's try | 16:27 |
| amotoki | tmazur: e0ne: if we go to the route with chromium, I think add 'Chromium' or replace 'Chrome' with 'Chromium' in https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/karma.conf.js#L163 | 16:31 |
| amotoki | tmazur: e0ne: the available browsers are listed at https://github.com/karma-runner/karma-chrome-launcher#available-browsers | 16:32 |
| e0ne | amotoki, tmazur: please, keep in mind, we've got several karma.conf.js files in our repo | 16:32 |
| amotoki | yeah, we have horizon/karma.conf.js too | 16:33 |
| tmazur | amotoki: yep, two of them | 16:40 |
| tmazur | Ok, so now it fails with "No binary for Chromium browser on your platform. Please, set "CHROMIUM_BIN" env variable." on my env | 16:42 |
| *** dklyle sets mode: -o dklyle | 16:52 | |
| e0ne | tmazur: it's because you don't have it, do you? | 16:57 |
| *** dayou has quit IRC | 17:10 | |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon master: Update devDependencies in package.json https://review.opendev.org/c/openstack/horizon/+/766106 | 17:11 |
| tmazur | e0ne: yes, sure. I am still curios how did it work before with zuul with chrome though... | 17:11 |
| *** rpittau is now known as rpittau|afk | 17:12 | |
| *** e0ne has quit IRC | 17:12 | |
| *** e0ne has joined #openstack-horizon | 17:34 | |
| *** ChanServ sets mode: +o e0ne | 17:34 | |
| *** hoonetorg has joined #openstack-horizon | 17:41 | |
| *** gyee has joined #openstack-horizon | 17:57 | |
| *** noonedeadpunk_ is now known as noonedeadpunk | 18:01 | |
| -openstackstatus- NOTICE: The Gerrit service on review.opendev.org is currently responding slowly or timing out due to resource starvation, investigation is underway | 18:15 | |
| *** e0ne has quit IRC | 18:51 | |
| *** lxkong has joined #openstack-horizon | 19:40 | |
| *** hoonetorg has quit IRC | 20:08 | |
| *** dayou has joined #openstack-horizon | 20:11 | |
| *** dave-mccowan has joined #openstack-horizon | 20:31 | |
| *** vishalmanchanda has quit IRC | 20:54 | |
| *** e0ne has joined #openstack-horizon | 21:38 | |
| *** ChanServ sets mode: +o e0ne | 21:38 | |
| *** rcernin has joined #openstack-horizon | 22:02 | |
| *** rcernin has quit IRC | 22:04 | |
| *** rcernin has joined #openstack-horizon | 22:05 | |
| *** e0ne has quit IRC | 22:14 | |
| *** tmazur has quit IRC | 23:59 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!