| *** rcernin has joined #openstack-horizon | 00:05 | |
| *** rcernin has quit IRC | 00:06 | |
| *** ianychoi_ has joined #openstack-horizon | 01:46 | |
| *** ianychoi has quit IRC | 01:48 | |
| openstackgerrit | zhangchun proposed openstack/horizon master: Remove install unnecessary packages https://review.opendev.org/751945 | 02:06 |
|---|---|---|
| *** vishalmanchanda has joined #openstack-horizon | 04:33 | |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: pylint: Address no-else-continue/no-else-raise warnings https://review.opendev.org/751969 | 06:03 |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: pylint: Address no-else-return warning https://review.opendev.org/751970 | 06:03 |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: pylint: Fix unnecessary-comprehension warning https://review.opendev.org/751971 | 06:03 |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Use python3-style super() https://review.opendev.org/751972 | 06:03 |
| *** jtomasek has joined #openstack-horizon | 06:04 | |
| *** dklyle has quit IRC | 06:29 | |
| *** rdopiera has joined #openstack-horizon | 06:54 | |
| *** ircuser-1 has quit IRC | 07:26 | |
| *** rdopiera has quit IRC | 07:32 | |
| *** rdopiera has joined #openstack-horizon | 07:32 | |
| *** tosky has joined #openstack-horizon | 07:34 | |
| *** priteau has joined #openstack-horizon | 07:40 | |
| *** e0ne has joined #openstack-horizon | 08:04 | |
| *** ChanServ sets mode: +o e0ne | 08:04 | |
| *** kevko has joined #openstack-horizon | 09:13 | |
| *** lxkong_ has joined #openstack-horizon | 09:43 | |
| *** tkajinam has quit IRC | 09:49 | |
| *** lxkong_ is now known as lxkong | 09:56 | |
| e0ne | vishalmanchanda: hi. could you please remind me where this https://review.opendev.org/#/c/708069/23/horizon/templates/horizon/client_side/_alert_message.html template is used? | 10:06 |
| e0ne | I need to test a fix for https://bugs.launchpad.net/horizon/+bug/1895570 | 10:07 |
| openstack | Launchpad bug 1895570 in OpenStack Dashboard (Horizon) "when multiple error popups are shown we cannot show details of second or later popups" [High,Confirmed] - Assigned to Ivan Kolodyazhny (e0ne) | 10:07 |
| vishalmanchanda | e0ne: here I think https://review.opendev.org/#/c/708069/23/horizon/static/horizon/js/horizon.messages.js@42 | 10:09 |
| vishalmanchanda | e0ne: I think we need to make href id unique here https://review.opendev.org/#/c/708069/23/horizon/templates/horizon/_messages.html@38 | 10:12 |
| e0ne | vishalmanchanda: yes, I've got it http://paste.openstack.org/show/797872/ | 10:13 |
| e0ne | vishalmanchanda: but I want to test client-side template too | 10:13 |
| * e0ne will be AFK for the next 30 minutes | 10:14 | |
| vishalmanchanda | e0ne: cool. | 10:14 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Set unique identifier for Django messages https://review.opendev.org/752016 | 11:17 |
| e0ne | amotoki, vishalmanchanda: here is it ^^ | 11:18 |
| vishalmanchanda | e0ne: error-messages using this template https://review.opendev.org/#/c/752016/1/horizon/templates/horizon/_messages.html going to add Count as well | 11:20 |
| vishalmanchanda | like Details1, Details2 ,........... | 11:20 |
| vishalmanchanda | even in case of one error message pop-up on the page it will Show Details1 | 11:21 |
| vishalmanchanda | Is it right? | 11:21 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Set unique identifier for Django messages https://review.opendev.org/752016 | 11:22 |
| e0ne | vishalmanchanda: it will show several messages, but Details link works as expected now (I hope :) ) | 11:23 |
| vishalmanchanda | e0ne: yeah thanks... | 11:23 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Set unique identifier for Django messages https://review.opendev.org/752016 | 11:43 |
| *** jtomasek has quit IRC | 11:54 | |
| amotoki | e0ne: vishalmanchanda: thanks for working on a fix. question: can't we use UUID from message instead of forloop.counter or date.now? | 12:15 |
| amotoki | e0ne: vishalmanchanda: ah, sorry. I was confused with cinder messages :( | 12:15 |
| amotoki | e0ne: vishalmanchanda: but, we can generate UUID when adding messages. I think it would be most unique. | 12:16 |
| amotoki | e0ne: vishalmanchanda: I might be missing something though | 12:16 |
| e0ne | amotoki, vishalmanchanda: we need to create own class based on https://docs.djangoproject.com/en/3.1/ref/contrib/messages/#the-message-class for it | 12:16 |
| *** lxkong has quit IRC | 12:21 | |
| *** priteau has quit IRC | 12:42 | |
| *** dave-mccowan has joined #openstack-horizon | 12:44 | |
| *** priteau has joined #openstack-horizon | 12:55 | |
| *** priteau has quit IRC | 13:15 | |
| vishalmanchanda | e0ne: It is what you suggest initially when I start this bp:) | 13:17 |
| e0ne | vishalmanchanda: yep. it seems that we have to follow this way in the next release to make code less complicated | 13:18 |
| vishalmanchanda | e0ne: We have added too much of work-around for this bp. | 13:19 |
| vishalmanchanda | e0ne: I think it looks fine to us right now as it fixes things but maybe difficult to understand for others. | 13:20 |
| e0ne | vishalmanchanda: +1 | 13:21 |
| vishalmanchanda | so better we should add some comments for such work-arounds. | 13:21 |
| amotoki | vishalmanchanda: if inline comments are big or too spread among codes, another idea is to write down a document under the contributor doc. | 13:22 |
| vishalmanchanda | amotoki: I will work on that. | 13:23 |
| amotoki | I am concerning that I usually point out a lot in last reviews and found bugs easily related to commits merged recently in first runs of horizon..... | 13:31 |
| amotoki | are we merging patches too easily without enough testing? | 13:31 |
| amotoki | or my review criteria is a bit high compared to the standard among core reviewers.... | 13:32 |
| amotoki | I will spend more time on neutron and OSC and less time on horizon in the next cycle. I am worrying about review quality but it may be a thing we cannot avoid considering the current situation. | 13:34 |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon master: [DNM] Testing CI https://review.opendev.org/752050 | 13:35 |
| amotoki | vishalmanchanda: it would be nice if you describe what is your DNM patch for. | 13:36 |
| amotoki | vishalmanchanda: I usually mention it in commit message like testing pep8 job / testing ironic-ui cross job and so on. | 13:37 |
| vishalmanchanda | amotoki: sure will do that from next time. | 13:41 |
| e0ne | amotoki: I understand your concerns | 13:50 |
| e0ne | amotoki: IMO, we need to spend more time on testing such patches | 13:50 |
| amotoki | e0ne: yeah, we need to image more corner cases, hehe, its' too much, at least we need to consider NON-simple cases. developers themselves tend to consider simple cases and forget more cases. | 13:52 |
| *** andrein_ has joined #openstack-horizon | 13:57 | |
| *** gouthamr__ has joined #openstack-horizon | 13:57 | |
| *** ShadowJonathan_ has joined #openstack-horizon | 13:57 | |
| *** gmann_ has joined #openstack-horizon | 13:57 | |
| *** priteau has joined #openstack-horizon | 13:57 | |
| *** coreycb_ has joined #openstack-horizon | 14:00 | |
| *** tmazur has joined #openstack-horizon | 14:00 | |
| *** gouthamr has quit IRC | 14:00 | |
| *** ShadowJonathan has quit IRC | 14:00 | |
| *** fungi has quit IRC | 14:00 | |
| *** andrein has quit IRC | 14:00 | |
| *** logan- has quit IRC | 14:00 | |
| *** gmann has quit IRC | 14:00 | |
| *** coreycb has quit IRC | 14:00 | |
| *** ShadowJonathan_ is now known as ShadowJonathan | 14:00 | |
| *** gouthamr__ is now known as gouthamr | 14:00 | |
| *** logan_ has joined #openstack-horizon | 14:00 | |
| *** gmann_ is now known as gmann | 14:00 | |
| *** andrein_ is now known as andrein | 14:00 | |
| *** logan_ is now known as logan- | 14:00 | |
| *** coreycb_ is now known as coreycb | 14:00 | |
| *** btully has joined #openstack-horizon | 14:02 | |
| *** fungi has joined #openstack-horizon | 14:08 | |
| *** dklyle has joined #openstack-horizon | 14:37 | |
| *** ChanServ sets mode: +o dklyle | 14:37 | |
| *** dklyle sets mode: -o dklyle | 14:38 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/horizon master: Fix open redirect https://review.opendev.org/750207 | 14:46 |
| *** kevko_ has joined #openstack-horizon | 15:09 | |
| *** kevko has quit IRC | 15:12 | |
| *** dklyle has quit IRC | 15:24 | |
| *** e0ne has quit IRC | 15:26 | |
| *** ianychoi__ has joined #openstack-horizon | 15:41 | |
| *** ianychoi_ has quit IRC | 15:45 | |
| *** gyee has joined #openstack-horizon | 16:06 | |
| -openstackstatus- NOTICE: Our PyPI caching proxies are serving stale package indexes for some packages. We think because PyPI's CDN is serving stale package indexes. We are sorting out how we can either fix or workaround that. In the meantime updating requirements is likely the wrong option. | 16:10 | |
| *** btully has quit IRC | 16:13 | |
| *** jtomasek has joined #openstack-horizon | 16:59 | |
| *** rdopiera has quit IRC | 17:08 | |
| *** kevko_ has quit IRC | 17:27 | |
| *** tosky has quit IRC | 17:40 | |
| *** vishalmanchanda has quit IRC | 18:13 | |
| *** priteau has quit IRC | 19:16 | |
| *** dave-mccowan has quit IRC | 21:43 | |
| *** ircuser-1 has joined #openstack-horizon | 22:02 | |
| *** tmazur has quit IRC | 22:12 | |
| *** rcernin has joined #openstack-horizon | 22:25 | |
| *** tkajinam has joined #openstack-horizon | 22:51 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!