| *** tsmith2 has joined #openstack-horizon | 00:15 | |
| *** rcernin has quit IRC | 02:40 | |
| *** gyee has quit IRC | 03:13 | |
| *** rcernin has joined #openstack-horizon | 03:13 | |
| *** rcernin has quit IRC | 03:19 | |
| *** rcernin has joined #openstack-horizon | 03:19 | |
| *** ircuser-1 has joined #openstack-horizon | 04:01 | |
| openstackgerrit | Nafiz Haider proposed openstack/horizon stable/train: Add policy_rules to aggregates dashboard https://review.opendev.org/749177 | 04:36 |
|---|---|---|
| openstackgerrit | Nafiz Haider proposed openstack/horizon stable/train: Add policy_rules to flavors dashboard https://review.opendev.org/749178 | 04:36 |
| *** e0ne has joined #openstack-horizon | 06:06 | |
| *** ChanServ sets mode: +o e0ne | 06:06 | |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon master: Update geckodriver version to v0.27.0. https://review.opendev.org/748881 | 06:16 |
| *** jtomasek has joined #openstack-horizon | 07:12 | |
| *** tosky has joined #openstack-horizon | 07:21 | |
| *** rcernin has quit IRC | 07:36 | |
| *** rcernin has joined #openstack-horizon | 07:59 | |
| *** rcernin has quit IRC | 08:02 | |
| *** adriant has quit IRC | 08:03 | |
| *** adriant has joined #openstack-horizon | 08:03 | |
| *** priteau has joined #openstack-horizon | 08:04 | |
| openstackgerrit | Tobias Urdin proposed openstack/horizon master: Support allowing extention of in-use volumes https://review.opendev.org/749013 | 08:16 |
| openstackgerrit | Tobias Urdin proposed openstack/horizon master: Support allowing extention of in-use volumes https://review.opendev.org/749013 | 08:23 |
| openstackgerrit | Tobias Urdin proposed openstack/horizon master: Support extending in-use volumes https://review.opendev.org/749013 | 08:59 |
| *** viks____ has joined #openstack-horizon | 09:02 | |
| *** tkajinam has quit IRC | 09:54 | |
| *** tkajinam has joined #openstack-horizon | 09:55 | |
| openstackgerrit | Merged openstack/horizon master: Update geckodriver version to v0.27.0. https://review.opendev.org/748881 | 10:04 |
| *** rdopiera has joined #openstack-horizon | 10:24 | |
| *** rdopiera has quit IRC | 10:32 | |
| *** mgagne has quit IRC | 10:39 | |
| *** tonyb has quit IRC | 11:05 | |
| *** tonyb has joined #openstack-horizon | 11:31 | |
| *** vishalmanchanda has joined #openstack-horizon | 11:39 | |
| openstackgerrit | Tobias Urdin proposed openstack/horizon master: Support extending in-use volumes https://review.opendev.org/749013 | 11:43 |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon stable/ussuri: Update geckodriver version to v0.27.0. https://review.opendev.org/749249 | 11:54 |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon stable/train: Update geckodriver version to v0.27.0. https://review.opendev.org/749252 | 11:55 |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon stable/stein: [DNM] Testing CI https://review.opendev.org/737520 | 11:58 |
| *** chenhaw has quit IRC | 12:00 | |
| vishalmanchanda | e0ne: amotoki : Hi there is a small update on focal-migration. | 12:12 |
| vishalmanchanda | e0ne: amotoki : I have added libfontconfig1 package in bindep.txt for those plugins which are failing with this error "error while loading shared libraries: libfontconfig.so.1: cannot open shared object file: No such file or directory" as discuss in last meeting. | 12:13 |
| vishalmanchanda | but it only works for openstack/designate-dashboard (https://review.opendev.org/#/c/744714/)not for others like ironic-ui (https://review.opendev.org/#/c/744708/) | 12:14 |
| vishalmanchanda | I wonder why this is happening. | 12:14 |
| vishalmanchanda | Also if I remove depends-on patch https://review.opendev.org/#/c/744647/ for designate-dashboard nodejs jobs fails with "py38: InterpreterNotFound: python3.8" error. | 12:15 |
| vishalmanchanda | So I think we have to merge horizon patch first. | 12:15 |
| *** dave-mccowan has joined #openstack-horizon | 12:33 | |
| *** dave-mccowan has quit IRC | 12:38 | |
| e0ne | vishalmanchanda: looking on it | 12:48 |
| *** spatel has joined #openstack-horizon | 12:58 | |
| e0ne | vishalmanchanda: I just updated your patch to ironic-ui. I'm not sure yet that it's absolutely correct | 13:00 |
| vishalmanchanda | e0ne: thanks Let's see if it's works. | 13:01 |
| e0ne | vishalmanchanda: the issue is: 'selenium' profile is not used for bindep for nodejs tests. we need to figure out the correct one | 13:01 |
| e0ne | 'tests' bindep profile is too wide, but I didn't find more suitable yet | 13:05 |
| *** chenhaw has joined #openstack-horizon | 13:05 | |
| *** spatel has quit IRC | 13:11 | |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon stable/stein: Update geckodriver version to v0.27.0. https://review.opendev.org/749281 | 13:14 |
| *** chenhaw has quit IRC | 13:18 | |
| *** tmazur has joined #openstack-horizon | 13:19 | |
| amotoki | e0ne: vishalmanchanda: I thought 'selenium' profile was used. sorry for the confusion. | 13:20 |
| amotoki | e0ne: vishalmanchanda: we can define a new bindep profile for nodejs test (like 'npm') as the npm jobs are defined in the horizon repo. | 13:21 |
| amotoki | e0ne: vishalmanchanda: that's one option, but what we need to do first is to make it work on focal envs of course. | 13:21 |
| amotoki | e0ne: vishalmanchanda: note that 'test' is the correct name instead of 'tests'. | 13:22 |
| e0ne | amotoki, vishalmanchanda: as I understood, only these jobs http://codesearch.openstack.org/?q=bindep_profile%3A%20selenium&i=nope&files=&repos= uses bindep profile 'selenium' | 13:23 |
| amotoki | e0ne: yeah, I was confused with selenium tests and npm tests somehow when I commented the focal migration patch in ironic-ui...... | 13:24 |
| amotoki | e0ne: so 'selenium' profile in ironic-ui bindep is unnecessary. | 13:25 |
| e0ne | amotoki: let's see if my fix actually works | 13:25 |
| e0ne | amotoki: ironic-ui has integration tests too. need to check how it works | 13:25 |
| e0ne | amotoki: https://github.com/openstack/ironic-ui/blob/master/.zuul.yaml#L3 will it use bindep from horizon? | 13:27 |
| e0ne | amotoki, vishalmanchanda: it works now https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_34f/744708/13/check/horizon-nodejs10-run-test/34fb340/job-output.txt | 13:28 |
| vishalmanchanda | e0ne: yeah it's works now. thanks for help. | 13:32 |
| e0ne | vishalmanchanda: np | 13:33 |
| amotoki | e0ne: yes, ironic-ui integration test consumes horizon integration test and bindep from horizon is called in pre-run, so it will be used. | 13:33 |
| e0ne | amotoki: oh.. I didn't know it | 13:34 |
| e0ne | but it means we can introduce 'node' bindep profile in horizon to get it working in plugins | 13:35 |
| e0ne | 'node' or 'nodejs' I really don'te care a lot on this naming | 13:35 |
| amotoki | e0ne: bindep.txt itself is per-project. what I thought is just to add a task to call bindep with 'node' or 'npm' in playbooks/horizon-nodejs/pre.yaml | 13:37 |
| *** chenhaw has joined #openstack-horizon | 13:37 | |
| amotoki | e0ne: but if you are okay to use 'test' profile in bindep I am okay with it too. | 13:37 |
| amotoki | e0ne: I just comment an idea to avoid a generic bindep profile like 'test' :) | 13:38 |
| vishalmanchanda | e0ne: amotoki : Should I add this profile "libfontconfig1 [ npm platform:dpkg]" in bindep.txt for this patch https://review.opendev.org/#/c/744647/ ? | 13:40 |
| amotoki | vishalmanchanda: I don't think so. horizon does not need it. | 13:41 |
| e0ne | amotoki: speciffic bindep profile is better | 13:41 |
| vishalmanchanda | amotoki: ok I will add it only for failed plugins.... | 13:41 |
| amotoki | e0ne: I am fine with it. | 13:42 |
| amotoki | e0ne: vishalmanchanda: so is our current plan as follows? | 13:42 |
| amotoki | 1. merge horizon focal migration patch as-is | 13:42 |
| amotoki | 2. update horizon-nodejs10-run-test to look up 'npm' bindep profile | 13:43 |
| amotoki | 3. update plugin bindep.txt files to install libfontconfig1 if required | 13:43 |
| amotoki | right? | 13:43 |
| vishalmanchanda | amotoki: sounds good. | 13:43 |
| vishalmanchanda | amotoki: e0ne : but there are 2-3 plugins where some jobs like py36, pep8 or others are failing on focal | 13:45 |
| amotoki | vishalmanchanda: can I find them in the etherpad? | 13:46 |
| vishalmanchanda | So if we lands horizon patch then it can those plugins. | 13:46 |
| vishalmanchanda | amotoki: yup https://etherpad.opendev.org/p/Focal-migration-status-horizon | 13:46 |
| amotoki | vishalmanchanda: which plugins are failing with other reasons? | 13:54 |
| vishalmanchanda | amotoki: like for this https://review.opendev.org/#/c/744726/ "neutron-tempest-plugin-bgpvpn-bagpipe" job is failing. | 13:56 |
| amotoki | vishalmanchanda: in case of bgpvpn, most part is neutron plugin. Unless you want to work on bgpvpn itself it is a separate topic. | 13:57 |
| amotoki | vishalmanchanda: bpnvpn is a repository of a neutron plugin with horizon support. | 13:59 |
| vishalmanchanda | amotoki: yeah but don't we need to fix failed job first before moving horizon to focal. | 14:00 |
| amotoki | vishalmanchanda: it is case by case. | 14:01 |
| vishalmanchanda | amotoki: openstack/mistral-dashboard (https://review.opendev.org/#/c/744718/) and openstack/ freezer-eb-ui (https://review.opendev.org/#/c/747165/) also needs attention. | 14:04 |
| vishalmanchanda | I can fix mistral-dashboard atleast https://review.opendev.org/#/c/744718/ | 14:04 |
| e0ne | vishalmanchanda: do they have the same issue as ironic-ui? | 14:06 |
| vishalmanchanda | e0ne: no it's completely different. | 14:06 |
| amotoki | vishalmanchanda: my main point is how *horizon* focal migration affects horizon plugins. If you are talking about the whole focal migration in plugins, it is a different topic. | 14:07 |
| vishalmanchanda | e0ne: Something that should be taken care by the plugins maintainer not horizon-team works... | 14:07 |
| e0ne | freezer-web-ui seems to be a plugin issue | 14:11 |
| amotoki | mistral-dashboard too | 14:11 |
| e0ne | mistral-dashboard could be fixed by us - it's a pep8 issue | 14:11 |
| openstackgerrit | Matthias Runge proposed openstack/horizon stable/train: Fix use of ngettext in registry getName https://review.opendev.org/749291 | 14:12 |
| vishalmanchanda | yeah. | 14:12 |
| amotoki | "freezer-web-ui" job in freezer-web-ui repo does not inherit horizon jobs. it is a plugin specific issue | 14:12 |
| e0ne | TBH, we can ask plugin maintainers to fix their plugins | 14:12 |
| vishalmanchanda | e0ne: ok. I will check with these plugins maintainer on IRC first. | 14:14 |
| e0ne | it's their responsibility to keep plugins CI working. we just help as much as we can | 14:14 |
| amotoki | TBH, as minimum, we need to care plugin healthiness affected by horizon changes. | 14:14 |
| e0ne | amotoki: +1 | 14:15 |
| vishalmanchanda | +1. | 14:15 |
| amotoki | as best effort, we can help plugin maintenance | 14:15 |
| e0ne | amotoki: that's why I asked for +2 permissions | 14:15 |
| amotoki | e0ne: +100 | 14:15 |
| amotoki | but we are not maintainers of plugins. | 14:15 |
| e0ne | amotoki: that's what I ment | 14:15 |
| amotoki | yeah | 14:15 |
| e0ne | it | 14:16 |
| e0ne | it's great if we can fix plugins but it's not our top-priority task. | 14:16 |
| amotoki | so in this case our first priority is about horizon-nodejs10-jobs including plugins | 14:16 |
| amotoki | we are totally in a same page | 14:17 |
| vishalmanchanda | People starts adding me as a reviewer for their bug-fixes in plugins🙂) | 14:17 |
| e0ne | I mean we're doing our best in plugin maintenance, but we hope to get a help from projects teams | 14:17 |
| amotoki | vishalmanchanda: it shows you work on many plugin issues :) | 14:17 |
| e0ne | vishalmanchanda: that's because you do a lot of reviews :) | 14:17 |
| amotoki | e0ne: vishalmanchanda: I changed my score to +2 in the focal migration patch https://review.opendev.org/#/c/744647/ | 14:20 |
| amotoki | I will care "2. update horizon-nodejs10-run-test to look up 'npm' bindep profile" soon | 14:20 |
| e0ne | approved | 14:21 |
| vishalmanchanda | thanks guys. | 14:21 |
| e0ne | vishalmanchanda: amotoki: according to https://review.opendev.org/#/c/705886/. we've got this patch too long in open state. since it fixes a real issue, I'm OK to +2 on it if somebody agrees to merge | 14:22 |
| amotoki | e0ne: I totally forgot it :p it is my patch but I need to refresh my memory. Let's check it and discuss it tomorrow meeting. | 14:25 |
| e0ne | amotoki: I +2'ed on it. it was on my todo list for a while and it's time to move it forward | 14:25 |
| vishalmanchanda | amotoki: I have already +2ed on it but removed my vote due to Ivan concern. | 14:25 |
| vishalmanchanda | If it's fine for everyone then i can approve it or we can discuss it in tomorrow meting.... | 14:27 |
| amotoki | e0ne: vishalmanchanda: thanks for your feedback. I am not a fan of this kind changes but it is a real solution. Before we move it forward, I need to add a release note on this anyway. | 14:30 |
| vishalmanchanda | amotoki: cool. | 14:31 |
| openstackgerrit | Merged openstack/horizon master: Fix Angular mediumDateFilter https://review.opendev.org/747046 | 14:33 |
| openstackgerrit | Merged openstack/horizon master: Fix tooltips and popovers for flavor details on the instance list. https://review.opendev.org/739685 | 14:59 |
| *** e0ne has quit IRC | 15:02 | |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon master: [goal] Migrate testing to ubuntu focal https://review.opendev.org/744647 | 15:38 |
| tmazur | Hey everyone! Do we have same integration tests issue in stable/train? | 15:55 |
| vishalmanchanda | tmazur: yup, I have purpose a backport https://review.opendev.org/#/c/749252/ to fix it. | 15:56 |
| tmazur | @vishalmanchanda cool thanks! | 15:56 |
| vishalmanchanda | tmazur: yw. | 15:56 |
| *** gyee has joined #openstack-horizon | 16:38 | |
| *** priteau has quit IRC | 16:59 | |
| *** jtomasek has quit IRC | 17:26 | |
| *** tonyb has quit IRC | 17:44 | |
| *** adriant has quit IRC | 17:44 | |
| *** tonyb has joined #openstack-horizon | 17:46 | |
| *** adriant has joined #openstack-horizon | 17:46 | |
| *** noonedeadpunk has quit IRC | 17:48 | |
| *** noonedeadpunk has joined #openstack-horizon | 17:51 | |
| *** openstackgerrit has quit IRC | 19:21 | |
| *** viks____ has quit IRC | 19:28 | |
| *** openstackgerrit has joined #openstack-horizon | 19:45 | |
| openstackgerrit | Merged openstack/horizon master: doc: Enable parallel build https://review.opendev.org/747058 | 19:45 |
| *** e0ne has joined #openstack-horizon | 19:45 | |
| *** ChanServ sets mode: +o e0ne | 19:45 | |
| *** e0ne has quit IRC | 20:19 | |
| *** spatel has joined #openstack-horizon | 20:28 | |
| *** spatel has quit IRC | 20:38 | |
| *** vishalmanchanda has quit IRC | 20:58 | |
| *** tosky has quit IRC | 22:43 | |
| *** rcernin has joined #openstack-horizon | 23:01 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!