| *** openstack has joined #openstack-horizon | 07:32 | |
| *** ChanServ sets mode: +o openstack | 07:32 | |
| *** rcernin_ has quit IRC | 07:34 | |
| *** tosky has joined #openstack-horizon | 07:37 | |
| *** rcernin_ has joined #openstack-horizon | 08:16 | |
| *** priteau has joined #openstack-horizon | 08:24 | |
| openstackgerrit | Oleksiy Petrenko proposed openstack/horizon master: Adds flatten_volume_from_snapshot config option https://review.opendev.org/741990 | 08:25 |
|---|---|---|
| *** rcernin_ has quit IRC | 08:26 | |
| *** e0ne has joined #openstack-horizon | 08:31 | |
| *** ChanServ sets mode: +o e0ne | 08:31 | |
| *** rcernin_ has joined #openstack-horizon | 08:46 | |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon master: Refactor-error-messages for admin dashboard https://review.opendev.org/742106 | 08:54 |
| *** rcernin_ has quit IRC | 09:07 | |
| openstackgerrit | Merged openstack/horizon master: Imported Translations from Zanata https://review.opendev.org/742077 | 09:14 |
| *** kevko has joined #openstack-horizon | 09:23 | |
| vishalmanchanda | rdopiera: amotoki : hi around? | 09:27 |
| rdopiera | vishalmanchanda: sure | 09:31 |
| rdopiera | vishalmanchanda: I saw you updated your patch, I'm going to review it later today | 09:31 |
| vishalmanchanda | rdopiera: thanks:). | 09:31 |
| *** rcernin_ has joined #openstack-horizon | 09:41 | |
| *** rcernin_ has quit IRC | 09:55 | |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon master: Refactor-error-messages for admin dashboard https://review.opendev.org/742106 | 09:57 |
| *** rcernin_ has joined #openstack-horizon | 10:28 | |
| openstackgerrit | Oleksiy Petrenko proposed openstack/horizon master: Fix instance integration tests https://review.opendev.org/741655 | 10:41 |
| *** tkajinam has quit IRC | 11:56 | |
| amotoki | vishalmanchanda: looking. I am just seeing what happens if I am not a first reviewer of horizon patches. That's the reason I am quiet in horizon :) | 12:06 |
| e0ne | vishalmanchanda: hi. I'm looking on your patch https://review.opendev.org/#/c/742106/2 | 12:15 |
| e0ne | vishalmanchanda: if we add 'details' argument for 'execption.handle function everythere, why can't we just get it from sys.exc_info()? | 12:17 |
| *** dave-mccowan has joined #openstack-horizon | 12:28 | |
| amotoki | e0ne: really good point. I thought it before but forgot it now. thanks. | 12:32 |
| rdopiera | e0ne: maybe you don't want to have details everywhere? | 12:33 |
| rdopiera | or not always from the exception | 12:33 |
| e0ne | rdopiera: that's a good point too | 12:34 |
| vishalmanchanda | sorry guys away from my lappy. | 12:38 |
| vishalmanchanda | online now. | 12:38 |
| vishalmanchanda | thanks for the review guys will fix your comment asap. | 12:39 |
| vishalmanchanda | e0ne: I didn't get what you mean? | 12:39 |
| vishalmanchanda | e0ne: ok got you. | 12:50 |
| *** rcernin_ has quit IRC | 12:54 | |
| openstackgerrit | Oleksiy Petrenko proposed openstack/horizon master: Adds flatten_volume_from_snapshot config option https://review.opendev.org/741990 | 13:26 |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon master: Refactor error messages. https://review.opendev.org/708069 | 14:01 |
| vishalmanchanda | amotoki: replied to your comments on this patch https://review.opendev.org/#/c/708069/13. | 14:03 |
| *** yaawang has quit IRC | 14:05 | |
| *** yaawang has joined #openstack-horizon | 14:05 | |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon master: Refactor-error-messages for admin dashboard https://review.opendev.org/742106 | 14:06 |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon master: Refactor error messages. https://review.opendev.org/708069 | 14:17 |
| *** rcernin_ has joined #openstack-horizon | 14:52 | |
| *** rcernin_ has quit IRC | 14:57 | |
| *** gyee has joined #openstack-horizon | 15:41 | |
| *** priteau has quit IRC | 16:28 | |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon master: Refactor-error-messages for identity dashboard https://review.opendev.org/742241 | 16:34 |
| *** priteau has joined #openstack-horizon | 17:01 | |
| *** priteau has quit IRC | 17:21 | |
| *** vishalmanchanda has quit IRC | 18:26 | |
| *** jadonn has joined #openstack-horizon | 18:58 | |
| *** jadonn has quit IRC | 19:50 | |
| *** e0ne has quit IRC | 20:27 | |
| *** adriant has quit IRC | 20:39 | |
| *** adriant has joined #openstack-horizon | 20:40 | |
| *** ircuser-1 has joined #openstack-horizon | 20:40 | |
| *** kevko has quit IRC | 21:01 | |
| *** kevko has joined #openstack-horizon | 21:46 | |
| *** rcernin_ has joined #openstack-horizon | 22:21 | |
| *** rcernin_ has quit IRC | 22:22 | |
| *** rcernin has joined #openstack-horizon | 22:34 | |
| *** rdopiera has quit IRC | 22:50 | |
| *** tkajinam has joined #openstack-horizon | 22:55 | |
| *** kevko has quit IRC | 23:44 | |
| *** tosky has quit IRC | 23:47 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!