| *** btully has joined #openstack-horizon | 00:22 | |
| *** btully has quit IRC | 00:27 | |
| *** gyee has quit IRC | 02:18 | |
| openstackgerrit | Kieran Spear proposed openstack/horizon master: Fix display of application credential roles https://review.opendev.org/728357 | 04:37 |
|---|---|---|
| *** vishalmanchanda has joined #openstack-horizon | 04:55 | |
| *** dklyle has quit IRC | 06:27 | |
| openstackgerrit | Kieran Spear proposed openstack/horizon master: Fix display of application credential roles https://review.opendev.org/728357 | 06:45 |
| *** rpittau|afk is now known as rpittau | 07:12 | |
| *** tosky has joined #openstack-horizon | 07:35 | |
| *** btully has joined #openstack-horizon | 07:38 | |
| *** btully has quit IRC | 07:42 | |
| *** e0ne has joined #openstack-horizon | 07:57 | |
| *** ChanServ sets mode: +o e0ne | 07:57 | |
| *** e0ne has quit IRC | 08:00 | |
| *** tkajinam has quit IRC | 08:14 | |
| *** e0ne has joined #openstack-horizon | 08:37 | |
| *** ChanServ sets mode: +o e0ne | 08:37 | |
| *** ircuser-1 has quit IRC | 09:32 | |
| *** rpittau is now known as rpittau|bbl | 10:09 | |
| *** happyhemant has joined #openstack-horizon | 10:28 | |
| *** threestrands has quit IRC | 11:46 | |
| Nizars | Am I understanding this correctly that you are not supposed to use 'const' and 'let' in the angularjs part of the plugin's code? Should everything really be 'var'? That is what the output of 'tox -e eslint' is giving me. | 11:51 |
| *** rpittau|bbl is now known as rpittau | 12:06 | |
| Nizars | e0ne: I am around whenever you have time :) | 12:07 |
| e0ne | Nizars: hi. ok. what help do you need? | 12:08 |
| e0ne | Nizars: I'm ok to use let/const in our js code. we just need to update or linter settings | 12:09 |
| Nizars | e0ne: Awesome! So I am still new to a lot of the tox/karma/jasmine stuff but I have looked at other plugins and the available documentation. The goal is to be able to run some of the spec tests in static angularjs code. I keep hitting error after error and I am not sure what the cause of it is, if it is the npm installation on my server instance or some misconfigured files in the plugin. | 12:12 |
| Nizars | So let's start from the beginning. I found the following two links to be very helpful: | 12:13 |
| Nizars | Make them three*: | 12:13 |
| Nizars | https://docs.openstack.org/horizon/latest/contributor/testing.html | 12:13 |
| e0ne | could you please share tests output via http://paste.openstack.org/? | 12:13 |
| Nizars | https://docs.openstack.org/horizon/latest/contributor/topics/testing.html | 12:13 |
| Nizars | Sure! | 12:13 |
| Nizars | https://docs.openstack.org/horizon/latest/contributor/topics/javascript_testing.html | 12:13 |
| Nizars | I will try the first one now: "Open <dev_server_ip:port>/jasmine in a browser. The development server can be run with tox -e runserver from the horizon root directory." | 12:14 |
| Nizars | The result: | 12:16 |
| Nizars | http://paste.openstack.org/show/793657/ | 12:16 |
| Nizars | e0ne: here is the code for the plugin: https://github.com/nizos/horizon-policies-plugin | 12:27 |
| e0ne | looks like ypur plugin is not installed inside virtualenv | 12:28 |
| Nizars | I see | 12:28 |
| Nizars | How do I install it in the virtual env? | 12:28 |
| e0ne | activate virtual env end execute 'tox -e .' inside your plugin directory | 12:32 |
| Nizars | I will give it a go | 12:33 |
| Nizars | any specific virtual env I should activate? venv? | 12:34 |
| e0ne | this one opt/stack/horizon/.tox/venv | 12:37 |
| Nizars | https://www.irccloud.com/pastebin/MjmCCmeW/ | 12:39 |
| *** AJaeger has left #openstack-horizon | 12:40 | |
| Nizars | I am going to try just 'tox' | 12:41 |
| e0ne | Nizars: I's sorry, I did a type | 12:41 |
| e0ne | *type | 12:41 |
| e0ne | *typo | 12:42 |
| Nizars | no worries :) | 12:42 |
| e0ne | you have to execute 'pip install -e .' instead of 'tox -e' | 12:42 |
| e0ne | :( | 12:42 |
| Nizars | ok i will try it :) | 12:42 |
| Nizars | done | 12:43 |
| Nizars | http://paste.openstack.org/show/793658/ | 12:43 |
| e0ne | good. now try to deactivate virtualenv and run 'tox -e server again'. it should work now | 12:44 |
| Nizars | ok :) | 12:44 |
| Nizars | It shows a lot of DEBUG | 12:47 |
| Nizars | I am not sure how to access the webpage for jasmin. ip-address/jasmine gives me a 404 | 12:47 |
| Nizars | I assume i didn't add the port but I am not sure what it is | 12:48 |
| e0ne | oh.. you need to tun 'tox -e npm' for it | 12:49 |
| Nizars | ok, in a new terminal instance right? :) | 12:50 |
| e0ne | or stop a current tox | 12:51 |
| Nizars | do i run it in the plugin dir or horizon dir? | 12:51 |
| e0ne | it depends which tests you want to run | 12:52 |
| Nizars | ok :) | 12:52 |
| Nizars | http://paste.openstack.org/show/793660/ | 12:54 |
| Nizars | This has been the error that we have been getting the most | 12:54 |
| Nizars | http://paste.openstack.org/show/793661/ | 12:56 |
| e0ne | it's something not obvious :( | 13:17 |
| Nizars | I agree | 13:18 |
| Nizars | It doesn't seem to find a spec file i created | 13:18 |
| Nizars | I wonder if i should create one for the main module | 13:18 |
| Nizars | I tried tox -e karma-local | 13:19 |
| Nizars | here is the log | 13:19 |
| Nizars | http://paste.openstack.org/show/793663/ | 13:21 |
| Nizars | http://paste.openstack.org/show/793664/ | 13:21 |
| Nizars | that was a long log, but here is the end of it: | 13:23 |
| Nizars | http://paste.openstack.org/show/793665/ | 13:23 |
| e0ne | `ERROR: Directory '../horizon' is not installable. Neither 'setup.py' nor 'pyproject.toml' found.` - ths errors looks like a critical one | 13:24 |
| Nizars | true | 13:25 |
| Nizars | I am not sure what to do about it | 13:25 |
| e0ne | seems to be some requirement how projects should be organised :) | 13:25 |
| Nizars | This is where the plugin is in the horizon directory | 13:26 |
| Nizars | https://usercontent.irccloud-cdn.com/file/Jnd5j020/image.png | 13:26 |
| Nizars | Should it be somewhere else? | 13:26 |
| e0ne | plugin dir should be on the same level as horizon | 13:27 |
| e0ne | not inside horizon dir | 13:27 |
| Nizars | Oh! so inside /opt/stack/ ? | 13:28 |
| Nizars | This is how the plugin's directories look like: https://usercontent.irccloud-cdn.com/file/aQwD5S8t/image.png | 13:29 |
| Nizars | I will move it, reinstall it and try again | 13:29 |
| Nizars | I am getting a different error now: | 13:40 |
| *** e0ne has quit IRC | 13:40 | |
| Nizars | http://paste.openstack.org/show/793667/ | 13:40 |
| Nizars | This happened when I activated venv and tried to run 'pip install -e .' | 13:40 |
| *** e0ne has joined #openstack-horizon | 13:44 | |
| *** ChanServ sets mode: +o e0ne | 13:44 | |
| Nizars | I guess I will make an sdist for the plugin | 13:44 |
| Nizars | ok I got past that error | 13:47 |
| Nizars | Back to the same error as before | 13:53 |
| Nizars | http://paste.openstack.org/show/793668/ | 13:54 |
| Nizars | http://paste.openstack.org/show/793669/ | 13:54 |
| *** dklyle has joined #openstack-horizon | 14:41 | |
| *** ChanServ sets mode: +o dklyle | 14:41 | |
| *** dklyle sets mode: -o dklyle | 14:42 | |
| *** gyee has joined #openstack-horizon | 16:13 | |
| *** kberger_ has joined #openstack-horizon | 16:31 | |
| *** KeithMnemonic has quit IRC | 16:31 | |
| *** kberger_ has quit IRC | 16:32 | |
| *** kberger_ has joined #openstack-horizon | 16:32 | |
| *** btully has joined #openstack-horizon | 16:42 | |
| *** btully has quit IRC | 16:47 | |
| *** rpittau is now known as rpittau|afk | 17:11 | |
| *** noonedeadpunk has quit IRC | 19:42 | |
| *** noonedeadpunk has joined #openstack-horizon | 19:42 | |
| *** kberger_ has quit IRC | 19:48 | |
| *** KeithMnemonic has joined #openstack-horizon | 19:48 | |
| *** btully has joined #openstack-horizon | 20:19 | |
| *** btully has quit IRC | 20:24 | |
| *** e0ne has quit IRC | 20:42 | |
| *** KeithMnemonic has quit IRC | 21:47 | |
| *** btully has joined #openstack-horizon | 22:08 | |
| *** btully has quit IRC | 22:12 | |
| *** tosky has quit IRC | 23:39 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
