| openstackgerrit | Ghanshyam Mann proposed openstack/horizon master: Fix hacking min version to 3.0.1 https://review.opendev.org/727497 | 00:25 |
|---|---|---|
| openstackgerrit | Ghanshyam Mann proposed openstack/tempest-horizon master: Fix hacking min version to 3.0.1 https://review.opendev.org/727540 | 00:33 |
| *** awalende has joined #openstack-horizon | 02:07 | |
| *** awalende has quit IRC | 02:12 | |
| *** gyee has quit IRC | 03:18 | |
| *** dklyle has quit IRC | 05:01 | |
| *** awalende has joined #openstack-horizon | 06:00 | |
| *** awalende has quit IRC | 06:04 | |
| openstackgerrit | Gayathri Devi proposed openstack/horizon master: Fix "Edit Port Security" tab on Horizon https://review.opendev.org/727284 | 07:02 |
| *** vishalmanchanda has joined #openstack-horizon | 07:02 | |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon master: [DNM] Testing CI https://review.opendev.org/727640 | 07:14 |
| *** rpittau|afk is now known as rpittau | 07:29 | |
| *** tosky has joined #openstack-horizon | 07:35 | |
| *** awalende has joined #openstack-horizon | 07:39 | |
| *** e0ne has joined #openstack-horizon | 08:05 | |
| *** ChanServ sets mode: +o e0ne | 08:05 | |
| *** AJaeger has joined #openstack-horizon | 09:07 | |
| AJaeger | Sorry for breaking the npm-run-test job, it's fixed now by https://review.opendev.org/727670 | 09:20 |
| AJaeger | vishalmanchanda, amotoki, FYI ^ | 09:21 |
| * AJaeger rechecked https://review.opendev.org/#/c/726698, you can +A again | 09:21 | |
| vishalmanchanda | AJaeger: thanks for fixing it. | 09:22 |
| *** btully has joined #openstack-horizon | 10:17 | |
| *** btully has quit IRC | 10:22 | |
| amotoki | AJaeger: thanks. you are faster :) | 10:39 |
| AJaeger | ;) | 10:47 |
| amotoki | AJaeger: it is a part of zuul-jobs. I wonder zuul-jobs test coverage is not good.... | 10:58 |
| e0ne | amotoki, AJaeger: do we want to merge https://review.opendev.org/#/c/726698/ and https://review.opendev.org/#/c/727202/ into the one patch to make CI happy? | 10:58 |
| amotoki | e0ne: https://review.opendev.org/#/c/726698/fixes the failure in the master branch | 10:59 |
| amotoki | e0ne: https://review.opendev.org/#/c/727202/ is to catch up the recent useful change in zuul-jobs | 11:00 |
| amotoki | e0ne: the latter should fix the gate failure in stable branches rocky and older. | 11:00 |
| amotoki | e0ne: so I think we can do them separately. | 11:00 |
| e0ne | amotoki: ok, let's wait for CI after recheck | 11:01 |
| amotoki | AJaeger: is my understanding above right? | 11:01 |
| *** rpittau is now known as rpittau|bbl | 11:04 | |
| AJaeger | amotoki: yes, test coverage is not good enough. We're working on that but it takes time... | 11:26 |
| AJaeger | agreed, CI should be fine and we don't need to merge those two | 11:26 |
| AJaeger | let me rebase the two on top of each other | 11:28 |
| openstackgerrit | Andreas Jaeger proposed openstack/horizon master: Switch to new javascript jobs https://review.opendev.org/727202 | 11:28 |
| AJaeger | amotoki, e0ne, please backport 727202 as needed yourself | 11:28 |
| AJaeger | if you there're questions or you want me to review, feel free to ask | 11:29 |
| AJaeger | https://zuul.opendev.org/t/openstack/status/change/726698,2 is passing - the npm-run-test job is green now. | 11:35 |
| amotoki | AJaeger: thanks! | 11:36 |
| e0ne | AJaeger: thanks a lot for the help | 12:04 |
| AJaeger | you're welcome! | 12:04 |
| *** rpittau|bbl is now known as rpittau | 12:19 | |
| *** tkajinam has quit IRC | 12:24 | |
| *** ianychoi has quit IRC | 12:55 | |
| *** gshippey has joined #openstack-horizon | 13:03 | |
| AJaeger | so, 726698 is in the gate now and https://review.opendev.org/727202 passed, ready for review | 13:09 |
| openstackgerrit | Zara proposed openstack/horizon stable/pike: Allow OVA upload for images https://review.opendev.org/725785 | 13:32 |
| Nizars | Hello | 13:52 |
| Nizars | I need some help running tests for a Horizon plugin that I am working on | 13:52 |
| e0ne | Nizars: hi. what actually help do you need? | 13:53 |
| Nizars | Thank you eOne! So I have created a spec file for an angularjs controller and wanted to run the test and see how it works. I installed Karma, and the plugins listed in karma.conf.js in the plugin's directory. But when I execute the command to run the test I get an error that I can not solve. The error says: xStatic libraries not found, please set up venv. | 13:56 |
| Nizars | Now I suspect that The configuration in the karma.conf.js file is faulty. I have looked around for an existing .venv file in horizon but I couldn't find any. | 13:57 |
| e0ne | did you run tests via tox? | 13:57 |
| e0ne | https://docs.openstack.org/horizon/latest/contributor/testing.html#npm | 13:57 |
| Nizars | Here is what the karma.conf.js file contains: | 13:58 |
| Nizars | https://gist.github.com/nizos/471219bd396f7bbd9f3faaf1f70f619c | 13:58 |
| Nizars | I will have a look at the link you just posted | 13:58 |
| amotoki | FYI: ussuri community meeting will start in one min :) | 13:59 |
| Nizars | Awesome! | 14:00 |
| openstackgerrit | Merged openstack/horizon master: Fix tempest and pep8 tests https://review.opendev.org/726698 | 14:02 |
| Nizars | I am not having much success getting the tests to run. I think a have a lot of things misconfigured and it will take a while to figure everything out. | 14:24 |
| Nizars | e0ne do you think you can help me with it by having a look? | 14:24 |
| e0ne | Nizars: how do you run tests? | 14:25 |
| Nizars | I am new to testing but I was hoping to follow this guide: https://www.credera.com/blog/technology-insights/open-source-technology-insights/testing-angularjs-part-1-setting-unit-testing-karma/ | 14:26 |
| Nizars | This is the code repository for our plugin: | 14:26 |
| Nizars | https://github.com/nizos/horizon-policies-plugin | 14:26 |
| Nizars | I think the tox.ini file is not properly configured. It specifies python 2.7 when we are using python 3.6. | 14:28 |
| Nizars | Running tox -e karma gives the following output: | 14:29 |
| Nizars | https://www.irccloud.com/pastebin/TUcH5fG9/ | 14:30 |
| Nizars | Followed by: | 14:30 |
| Nizars | https://www.irccloud.com/pastebin/Q5bM1S9u/ | 14:30 |
| amotoki | Nizars: while I didn't check the detail you posted, did you check what other horizon plugins with npm tests do? | 14:34 |
| Nizars | I will have a look now :) | 14:35 |
| amotoki | Nizars: I think it would be helpful to check other plugins | 14:35 |
| *** dklyle has joined #openstack-horizon | 14:42 | |
| *** ChanServ sets mode: +o dklyle | 14:42 | |
| *** dklyle sets mode: -o dklyle | 14:42 | |
| e0ne | do we want to have a horizon meeting today or everybody is listening Ussuri Community Meeting? | 14:54 |
| Nizars | I have a request to have a look at our blueprint and have it accepted but otherwise it's all good here. | 14:55 |
| e0ne | Nizars: which blueprint? | 14:57 |
| Nizars | https://blueprints.launchpad.net/horizon/+spec/policies-plugin | 14:57 |
| e0ne | hm.. I'm not sure that we need a blueprint for this | 14:59 |
| vishalmanchanda | e0ne: we can do it after it finish. | 15:01 |
| Nizars | Ok, the goal of our project was to create a plugin and work with the upstream community and have it approved or something like that. | 15:01 |
| Nizars | vishalmanchanda: when do you think it will end? | 15:01 |
| *** priteau has joined #openstack-horizon | 15:01 | |
| vishalmanchanda | vishalmanchanda: it's already ended. | 15:02 |
| amotoki | e0ne: the community meeting was just over :) | 15:02 |
| e0ne | yep. just started a meeting | 15:03 |
| *** gyee has joined #openstack-horizon | 15:43 | |
| *** btully has joined #openstack-horizon | 15:44 | |
| *** btully has quit IRC | 15:49 | |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon master: Fix hacking min version to 3.0.1 https://review.opendev.org/727497 | 15:51 |
| amotoki | Nizars: hi, have you checked what is policy-in-code effort in OpenStack? | 16:03 |
| amotoki | Nizars: it happened a couple of years ago | 16:04 |
| amotoki | Nizars: after that, the default policies are defined in python codes and policy files are used to override the default policies. | 16:04 |
| *** rpittau is now known as rpittau|afk | 16:21 | |
| openstackgerrit | Zara proposed openstack/horizon stable/pike: Allow OVA upload for images https://review.opendev.org/725785 | 16:35 |
| *** btully has joined #openstack-horizon | 17:33 | |
| *** btully has quit IRC | 17:37 | |
| *** priteau has quit IRC | 17:38 | |
| openstackgerrit | Merged openstack/horizon master: Switch to new javascript jobs https://review.opendev.org/727202 | 17:40 |
| *** e0ne has quit IRC | 17:55 | |
| *** dklyle has quit IRC | 19:38 | |
| *** dklyle has joined #openstack-horizon | 19:46 | |
| *** ChanServ sets mode: +o dklyle | 19:46 | |
| *** dklyle sets mode: -o dklyle | 19:46 | |
| *** gshippey has quit IRC | 20:24 | |
| *** vishalmanchanda has quit IRC | 20:31 | |
| *** btully has joined #openstack-horizon | 21:10 | |
| *** btully has quit IRC | 21:15 | |
| *** awalende has quit IRC | 21:38 | |
| *** awalende has joined #openstack-horizon | 21:39 | |
| *** awalende has quit IRC | 21:43 | |
| *** spatel has joined #openstack-horizon | 22:08 | |
| *** spatel has quit IRC | 22:12 | |
| *** spatel has joined #openstack-horizon | 22:20 | |
| *** spatel has quit IRC | 22:45 | |
| *** tkajinam has joined #openstack-horizon | 22:46 | |
| *** tosky has quit IRC | 23:06 | |
| *** threestrands has joined #openstack-horizon | 23:29 | |
| *** rcernin has quit IRC | 23:31 | |
| *** rcernin has joined #openstack-horizon | 23:32 | |
| *** early has quit IRC | 23:38 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!