| *** btully has joined #openstack-horizon | 00:11 | |
| *** btully has quit IRC | 00:19 | |
| *** btully has joined #openstack-horizon | 00:23 | |
| *** btully has quit IRC | 00:36 | |
| *** btully has joined #openstack-horizon | 00:40 | |
| *** btully has quit IRC | 00:44 | |
| *** btully has joined #openstack-horizon | 00:45 | |
| *** spatel has joined #openstack-horizon | 00:48 | |
| *** btully has quit IRC | 00:49 | |
| *** dayou_ has quit IRC | 00:56 | |
| *** duochao has joined #openstack-horizon | 00:59 | |
| *** spatel has quit IRC | 01:26 | |
| *** BjoernT has quit IRC | 01:31 | |
| *** dayou_ has joined #openstack-horizon | 01:36 | |
| *** btully has joined #openstack-horizon | 01:45 | |
| *** rcernin has quit IRC | 01:48 | |
| *** rcernin has joined #openstack-horizon | 01:48 | |
| *** btully has quit IRC | 01:49 | |
| *** btully has joined #openstack-horizon | 01:51 | |
| *** btully has quit IRC | 01:55 | |
| *** whoami-rajat has joined #openstack-horizon | 02:07 | |
| *** rcernin has quit IRC | 02:42 | |
| *** rcernin has joined #openstack-horizon | 02:42 | |
| *** rcernin has quit IRC | 03:04 | |
| *** rcernin has joined #openstack-horizon | 03:04 | |
| *** fyx has quit IRC | 03:18 | |
| *** mnaser has quit IRC | 03:19 | |
| *** fyx has joined #openstack-horizon | 03:19 | |
| *** mnaser has joined #openstack-horizon | 03:20 | |
| *** BjoernT has joined #openstack-horizon | 03:26 | |
| *** rcernin has quit IRC | 03:30 | |
| *** rcernin has joined #openstack-horizon | 03:31 | |
| *** BjoernT has quit IRC | 03:31 | |
| *** BjoernT has joined #openstack-horizon | 03:35 | |
| *** btully has joined #openstack-horizon | 03:51 | |
| *** btully has quit IRC | 03:55 | |
| *** btully has joined #openstack-horizon | 04:00 | |
| *** btully has quit IRC | 04:04 | |
| *** btully has joined #openstack-horizon | 04:08 | |
| *** btully has quit IRC | 04:12 | |
| *** btully has joined #openstack-horizon | 04:12 | |
| *** BjoernT has quit IRC | 04:18 | |
| *** btully has quit IRC | 04:25 | |
| *** btully has joined #openstack-horizon | 05:02 | |
| *** btully has quit IRC | 05:11 | |
| *** btully has joined #openstack-horizon | 05:12 | |
| *** btully has quit IRC | 05:17 | |
| *** btully has joined #openstack-horizon | 05:23 | |
| *** btully has quit IRC | 05:27 | |
| *** mlycka has joined #openstack-horizon | 05:31 | |
| *** jtomasek has joined #openstack-horizon | 05:51 | |
| *** pcaruana has joined #openstack-horizon | 05:56 | |
| *** pcaruana has quit IRC | 05:57 | |
| *** pcaruana has joined #openstack-horizon | 05:57 | |
| *** btully has joined #openstack-horizon | 06:02 | |
| *** btully has quit IRC | 06:07 | |
| *** e0ne has joined #openstack-horizon | 06:29 | |
| *** ChanServ sets mode: +o e0ne | 06:29 | |
| *** cshen has joined #openstack-horizon | 06:34 | |
| *** rcernin has quit IRC | 06:41 | |
| *** altlogbot_1 has quit IRC | 06:46 | |
| *** altlogbot_1 has joined #openstack-horizon | 06:49 | |
| *** altlogbot_1 has quit IRC | 06:50 | |
| *** yoctozepto has joined #openstack-horizon | 06:51 | |
| yoctozepto | hello horizon devs, kolla dev here, we have been hit by https://opendev.org/openstack/horizon/commit/4e911e2889ebe7f0a577a0323649dceb9cef363c (Explicitly set LOCALE_PATHS for Horizon apps), details and my current solution are here: https://review.opendev.org/667204 in short: we were compiling messages for all dashboards/uis in a loop using horizon manage.py and this latest horizon change caused them to do needless work | 06:53 |
|---|---|---|
| yoctozepto | please advise whether the proposed solution is the correct approach | 06:54 |
| *** altlogbot_1 has joined #openstack-horizon | 06:55 | |
| *** e0ne has quit IRC | 06:57 | |
| *** jpich has joined #openstack-horizon | 07:07 | |
| *** btully has joined #openstack-horizon | 07:08 | |
| *** tesseract has joined #openstack-horizon | 07:11 | |
| *** btully has quit IRC | 07:13 | |
| *** rdopiera has joined #openstack-horizon | 07:17 | |
| *** btully has joined #openstack-horizon | 07:24 | |
| *** btully has quit IRC | 07:28 | |
| *** tosky has joined #openstack-horizon | 07:28 | |
| *** jtomasek has quit IRC | 07:31 | |
| *** jtomasek has joined #openstack-horizon | 07:32 | |
| *** Emine has joined #openstack-horizon | 07:33 | |
| amotoki | yoctozepto: not all folks are always online. please file a bug to horizon if you hit an issue around the change of LOCALE_PATHS. | 07:34 |
| amotoki | yoctozepto: LOCALE_PATHS was set several releases ago (with relative paths). Django searches 'locale' dir in all django apps and the old LOCALE_PATHS was unnecessary so it was dropped. | 07:35 |
| amotoki | yoctozepto: LOCALE_PATHS was previously set, so I don't see a reason the change in horizon affects kolla build... | 07:36 |
| amotoki | yoctozepto: does kolla do something special around horizon plugins? | 07:36 |
| yoctozepto | amotoki: we loop over all plugin directories to compile messages, it used not to recompile all messages for horizon, openstack_dashboard, openstack_auth, yet now it does | 07:38 |
| amotoki | yoctozepto: perhaps e0ne knows more than me. According to his commit msg, it seems a django bug or expected behavior (I am not sure) and a workaround is needed. | 07:38 |
| amotoki | yoctozepto: do you mean kolla depends on LOCALE_PATHS? | 07:38 |
| yoctozepto | amotoki: in a sense, yes, we do: for locale in /var/lib/kolla/venv/lib/python{{distro_python_version}}/site-packages/*/locale; do \ | 07:39 |
| yoctozepto | (cd ${locale%/*} && /var/lib/kolla/venv/bin/python /var/lib/kolla/venv/bin/manage.py compilemessages) \ | 07:39 |
| yoctozepto | done \ | 07:39 |
| yoctozepto | (did at least) | 07:39 |
| yoctozepto | manage.py is the one from horizon which sets the settings | 07:40 |
| yoctozepto | doing it this way triggers extra compilations with each invocatin | 07:40 |
| yoctozepto | it caused timeout in our CI because CentOS gettext seems to be slow | 07:40 |
| yoctozepto | and doing it 40+ times had its best | 07:41 |
| *** btully has joined #openstack-horizon | 07:56 | |
| *** e0ne has joined #openstack-horizon | 08:01 | |
| *** ChanServ sets mode: +o e0ne | 08:01 | |
| amotoki | yoctozepto: I tested with horizon+neutron-fwaas-dashboard master latest but it seems to work expected http://paste.openstack.org/show/753338/ | 08:02 |
| amotoki | yoctozepto: I will be offline a while. I will check irc logs later when back to online a bit later | 08:03 |
| *** btully has quit IRC | 08:05 | |
| yoctozepto | amotoki: the problem is not that it does not work but that it resulted in a ton of unnecessary recompilations - your example did openstack_auth, openstack_dashboard and horizon along with neutron-fwaas-dashboard - now imagine the same but for all languages and each such plugin | 08:05 |
| *** btully has joined #openstack-horizon | 08:06 | |
| yoctozepto | ubuntu copes with the extra work but centos 7 seems to have slow gettext which cannot deal with such amount of work | 08:06 |
| * e0ne reading irc logs to understand the issue | 08:07 | |
| *** btully has quit IRC | 08:10 | |
| yoctozepto | see http://logs.openstack.org/15/666015/3/gate/kolla-build-centos-source/423deec/logs/build/horizon.txt.gz for example of such a run | 08:10 |
| e0ne | yoctozepto: sorry, I still don't understand what is the issue :( | 08:27 |
| *** tkajinam has quit IRC | 08:27 | |
| *** tkajinam has joined #openstack-horizon | 08:28 | |
| *** tkajinam has quit IRC | 08:29 | |
| yoctozepto | e0ne: the issue is the change in behavior - pre that change we did fine with that loop because it only triggered compilation of the locales files in cwd | 08:34 |
| yoctozepto | post it we get recompilations for _auth, _dashboard and horizon extra for each such module | 08:35 |
| yoctozepto | (which combined with centos slowness caused our recent problems) | 08:36 |
| yoctozepto | I switched to using django-admin in my patch to kolla but wonder whether this is the right approach, it works for us but I am not django-expert | 08:37 |
| amotoki | yoctozepto: My test result above did the same thing as you do..... | 08:44 |
| amotoki | yoctozepto: it installs horizon into a virtualenv, cd to each plugin dir and then run compilemessages. Is there any difference? | 08:45 |
| amotoki | yoctozepto: from my test result, horizon change does not affect compilemessages.... | 08:45 |
| amotoki | yoctozepto: what is the problem? do you mean compilemessages needs more time after that change? | 08:47 |
| yoctozepto | amotoki: yes, exactly, due to repetitive recompilations and these seem to have started for us with that commit | 08:48 |
| yoctozepto | previously it only did the project it was currently in | 08:49 |
| amotoki | e0ne: btw, is your change on LOCALE_PATHS caused caused by a djnago bug or is it the expected behavior of Django? | 08:49 |
| amotoki | e0ne: I see no Django bug report mentioned in your commit, so I am wondering your change works but am not sure it is the right approach or not now. | 08:50 |
| amotoki | e0ne: in addition, horizon plugins would hit in the same problem in ch-tw as dklyle mentioned yesterday here. | 08:50 |
| amotoki | yoctozepto: okay, understood. As of now, the bug fix fixed by that change is much more important rather than compilation time (critical vs wishlist) so we need a working alternative instead of reverting the change to address your problem. | 08:53 |
| yoctozepto | amotoki: it's ok, I never demanded a revert in the first place :D my question is whether I might be doing something utterly wrong by using django-admin instead which fixes our problem and does not seem to cause any problems at the first glance | 08:56 |
| *** priteau has joined #openstack-horizon | 08:56 | |
| *** btully has joined #openstack-horizon | 09:09 | |
| e0ne | django loads locales by relative paths and it doesn't work now for deprecated chaneese locale names | 09:11 |
| *** btully has quit IRC | 09:14 | |
| e0ne | amotoki, yoctozepto: it would be good to switch to the new locale names, but this affects our translation team. I need to figure out how to proceed this | 09:14 |
| yoctozepto | amotoki, e0ne: sorry for being repetitive myself but can you answer the question whether doing this via django-admin instead of via manage.py has some repercussions :D | 09:16 |
| e0ne | afaik, manage.py and django-admin should work in the same way | 09:17 |
| yoctozepto | e0ne: django-admin does not reference the horizon settings.py | 09:18 |
| yoctozepto | but would it affect compilemessages in a bad way? | 09:18 |
| yoctozepto | if we are doing it for every project that has some locales | 09:18 |
| e0ne | I don't understand how it affects compilemessages | 09:19 |
| e0ne | from horizon perspective, we just drop django's localization messages and explicitly set what we want to use | 09:20 |
| e0ne | yoctozepto: anyway, could you please file a bug for horizon? | 09:38 |
| yoctozepto | e0ne: sure | 09:43 |
| e0ne | thanks | 09:43 |
| *** duochao has quit IRC | 10:39 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon master: Imported Translations from Zanata https://review.opendev.org/667327 | 11:00 |
| *** e0ne has quit IRC | 11:05 | |
| *** e0ne has joined #openstack-horizon | 11:05 | |
| *** ChanServ sets mode: +o e0ne | 11:05 | |
| *** cshen has quit IRC | 11:10 | |
| *** cshen has joined #openstack-horizon | 11:19 | |
| *** btully has joined #openstack-horizon | 11:23 | |
| *** btully has quit IRC | 11:27 | |
| *** btully has joined #openstack-horizon | 11:38 | |
| *** btully has quit IRC | 11:42 | |
| *** priteau has quit IRC | 11:43 | |
| *** spatel has joined #openstack-horizon | 11:55 | |
| *** spatel has quit IRC | 12:00 | |
| openstackgerrit | Merged openstack/horizon master: Imported Translations from Zanata https://review.opendev.org/667327 | 12:28 |
| *** btully has joined #openstack-horizon | 12:30 | |
| *** btully has quit IRC | 12:37 | |
| *** btully has joined #openstack-horizon | 12:39 | |
| *** btully has quit IRC | 12:43 | |
| *** btully has joined #openstack-horizon | 12:47 | |
| *** btully has quit IRC | 12:51 | |
| *** btully has joined #openstack-horizon | 13:06 | |
| *** lseki has joined #openstack-horizon | 13:10 | |
| *** btully has quit IRC | 13:10 | |
| *** whoami-rajat has quit IRC | 13:16 | |
| *** btully has joined #openstack-horizon | 13:19 | |
| *** btully has quit IRC | 13:24 | |
| *** cshen_ has joined #openstack-horizon | 13:26 | |
| *** cshen has quit IRC | 13:29 | |
| amotoki | e0ne: do you have any specific plan to switch Chinese lang codes to the new ones used by Django? | 13:29 |
| amotoki | e0ne: this needs coordination among infra, i18n and horizon teams. | 13:30 |
| amotoki | e0ne: Especially we need to discuss what lang codes we would like to use in zanata. Also we need to discuss what lang codes for doc website. | 13:32 |
| *** dave-mccowan has joined #openstack-horizon | 13:32 | |
| e0ne | amotoki: it's on top of my TODOs list. I'm going to attend the meeting if there is one with i18n team next week | 13:33 |
| e0ne | I'm not familiar with zanata now :( | 13:33 |
| amotoki | do you mean the i18n meeting? | 13:35 |
| *** BjoernT has joined #openstack-horizon | 13:37 | |
| *** openstackgerrit has quit IRC | 13:48 | |
| *** spatel has joined #openstack-horizon | 13:52 | |
| *** spatel has quit IRC | 13:52 | |
| e0ne | amotoki: yes | 13:53 |
| *** vmarkov has joined #openstack-horizon | 13:58 | |
| *** btully has joined #openstack-horizon | 14:06 | |
| *** btully has quit IRC | 14:10 | |
| *** btully has joined #openstack-horizon | 14:13 | |
| *** btully has quit IRC | 14:18 | |
| *** btully has joined #openstack-horizon | 14:36 | |
| *** btully has quit IRC | 14:40 | |
| amotoki | e0ne: sounds nice. While I know the context around this, I don't attend the i18n meeting recently due to conflict with weekly f2f meetings. | 14:47 |
| amotoki | e0ne: I mentioned some in #-i18n channel. If someone wants me to write more context, I can send a mail to the mailing list but would like to wait responses for a while. | 14:48 |
| *** e0ne has quit IRC | 15:26 | |
| *** BjoernT_ has joined #openstack-horizon | 15:29 | |
| *** yan0s has joined #openstack-horizon | 15:30 | |
| *** BjoernT has quit IRC | 15:30 | |
| *** btully has joined #openstack-horizon | 15:33 | |
| *** btully has quit IRC | 15:37 | |
| *** Emine has quit IRC | 15:39 | |
| *** btully has joined #openstack-horizon | 15:49 | |
| *** cshen_ has quit IRC | 15:49 | |
| *** btully has quit IRC | 15:53 | |
| *** btully has joined #openstack-horizon | 15:57 | |
| *** BjoernT has joined #openstack-horizon | 16:00 | |
| *** btully has quit IRC | 16:01 | |
| *** BjoernT_ has quit IRC | 16:02 | |
| *** yan0s has quit IRC | 16:05 | |
| *** btully has joined #openstack-horizon | 16:05 | |
| *** mlycka has quit IRC | 16:09 | |
| *** btully has quit IRC | 16:10 | |
| *** btully has joined #openstack-horizon | 16:18 | |
| *** btully has quit IRC | 16:22 | |
| *** btully has joined #openstack-horizon | 16:25 | |
| *** btully has quit IRC | 16:29 | |
| *** tesseract has quit IRC | 16:35 | |
| *** tesseract has joined #openstack-horizon | 16:36 | |
| *** btully has joined #openstack-horizon | 16:41 | |
| *** btully has quit IRC | 16:46 | |
| *** btully has joined #openstack-horizon | 16:48 | |
| *** jpich has quit IRC | 16:56 | |
| *** btully has quit IRC | 16:57 | |
| *** tesseract has quit IRC | 16:59 | |
| *** jtomasek has quit IRC | 17:21 | |
| *** vmarkov has quit IRC | 17:52 | |
| *** btully has joined #openstack-horizon | 17:58 | |
| *** btully has quit IRC | 18:02 | |
| *** btully has joined #openstack-horizon | 18:39 | |
| *** btully has quit IRC | 18:43 | |
| *** ianychoi_ has quit IRC | 18:49 | |
| *** ianychoi_ has joined #openstack-horizon | 18:50 | |
| *** e0ne has joined #openstack-horizon | 19:07 | |
| *** ChanServ sets mode: +o e0ne | 19:07 | |
| *** jtomasek has joined #openstack-horizon | 19:19 | |
| *** e0ne has quit IRC | 19:31 | |
| *** pcaruana has quit IRC | 19:38 | |
| *** tosky has quit IRC | 19:40 | |
| *** btully has joined #openstack-horizon | 20:00 | |
| *** btully has quit IRC | 20:05 | |
| *** e0ne has joined #openstack-horizon | 20:18 | |
| *** ChanServ sets mode: +o e0ne | 20:18 | |
| *** e0ne has quit IRC | 20:32 | |
| *** btully has joined #openstack-horizon | 20:55 | |
| *** ianychoi_ has quit IRC | 20:59 | |
| *** btully has quit IRC | 21:00 | |
| *** ianychoi_ has joined #openstack-horizon | 21:00 | |
| *** ianychoi_ has quit IRC | 21:05 | |
| *** btully has joined #openstack-horizon | 21:05 | |
| *** ianychoi_ has joined #openstack-horizon | 21:09 | |
| *** btully has quit IRC | 21:10 | |
| *** btully has joined #openstack-horizon | 21:13 | |
| *** btully has quit IRC | 21:17 | |
| *** ianychoi_ is now known as ianychoi | 21:18 | |
| *** jtomasek has quit IRC | 21:24 | |
| *** Emine has joined #openstack-horizon | 21:45 | |
| *** tobberydberg has quit IRC | 21:49 | |
| *** tobberydberg has joined #openstack-horizon | 21:51 | |
| *** rdopiera has quit IRC | 22:02 | |
| *** Emine has quit IRC | 22:07 | |
| *** BjoernT has quit IRC | 22:23 | |
| *** btully has joined #openstack-horizon | 22:39 | |
| *** btully has quit IRC | 22:43 | |
| *** tkajinam has joined #openstack-horizon | 22:56 | |
| *** rcernin has joined #openstack-horizon | 23:05 | |
| *** lseki has quit IRC | 23:26 | |
| *** btully has joined #openstack-horizon | 23:28 | |
| *** btully has quit IRC | 23:33 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!