Tuesday, 2019-03-05

*** itlinux has joined #openstack-horizon00:09
*** btully has quit IRC00:12
*** itlinux_ has joined #openstack-horizon00:13
*** itlinux has quit IRC00:15
*** btully has joined #openstack-horizon00:17
*** btully has quit IRC00:29
*** btully has joined #openstack-horizon00:29
*** cshen has joined #openstack-horizon00:29
*** cshen has quit IRC00:33
*** btully has quit IRC00:42
*** gouthamr has quit IRC01:48
*** btully has joined #openstack-horizon01:53
*** btully has quit IRC01:58
*** btully has joined #openstack-horizon02:02
*** whoami-rajat has joined #openstack-horizon02:02
*** btully has quit IRC02:06
*** btully has joined #openstack-horizon02:26
*** ircuser-1 has joined #openstack-horizon02:28
*** cshen has joined #openstack-horizon02:29
*** cshen has quit IRC02:34
*** btully has quit IRC02:35
*** gouthamr has joined #openstack-horizon02:50
*** btully has joined #openstack-horizon02:57
*** btully has quit IRC03:01
*** itlinux_ has quit IRC03:06
*** itlinux has joined #openstack-horizon03:12
*** itlinux has quit IRC03:21
*** itlinux has joined #openstack-horizon03:25
*** vishalmanchanda has joined #openstack-horizon03:49
*** gyee has quit IRC03:54
*** btully has joined #openstack-horizon04:27
*** cshen has joined #openstack-horizon04:30
*** btully has quit IRC04:31
*** cshen has quit IRC04:34
*** btully has joined #openstack-horizon04:56
*** btully has quit IRC05:00
*** btully has joined #openstack-horizon05:39
*** btully has quit IRC05:43
*** jhesketh has quit IRC05:47
*** jhesketh has joined #openstack-horizon05:48
*** pcaruana has joined #openstack-horizon05:52
*** pcaruana has quit IRC06:07
*** jtomasek has joined #openstack-horizon06:16
*** dims has quit IRC06:24
*** e0ne has joined #openstack-horizon06:24
*** ChanServ sets mode: +o e0ne06:24
*** dims has joined #openstack-horizon06:26
*** e0ne has quit IRC06:33
*** itlinux has quit IRC06:34
*** dims has quit IRC06:36
*** dims has joined #openstack-horizon06:37
*** vishalmanchanda has quit IRC06:38
*** nooryameen has joined #openstack-horizon06:39
*** e0ne has joined #openstack-horizon06:46
*** ChanServ sets mode: +o e0ne06:46
*** cshen has joined #openstack-horizon06:46
*** dayou has quit IRC07:01
nooryameenhi e0ne07:01
*** dayou has joined #openstack-horizon07:01
*** btully has joined #openstack-horizon07:05
*** e0ne has quit IRC07:07
*** btully has quit IRC07:10
*** btully has joined #openstack-horizon07:22
*** openstackgerrit has joined #openstack-horizon07:25
openstackgerritMerged openstack/horizon master: Fix policy function check error  https://review.openstack.org/64052007:25
*** btully has quit IRC07:30
*** btully has joined #openstack-horizon07:30
*** btully has quit IRC07:34
*** dayou has quit IRC07:37
*** btully has joined #openstack-horizon07:39
*** btully has quit IRC07:43
*** btully has joined #openstack-horizon07:48
*** btully has quit IRC07:57
*** dayou has joined #openstack-horizon07:58
*** btully has joined #openstack-horizon08:06
*** btully has quit IRC08:10
*** btully has joined #openstack-horizon08:14
*** e0ne has joined #openstack-horizon08:17
*** ChanServ sets mode: +o e0ne08:17
*** btully has quit IRC08:18
*** pcaruana has joined #openstack-horizon08:18
*** btully has joined #openstack-horizon08:19
*** jtomasek has quit IRC08:20
e0nenooryameen: hi08:20
e0nenooryameen: I'll update my branches with horizon react plugin a bit later today with some code changes and detailed instructions08:21
nooryameene0ne great :)08:22
*** tkajinam has quit IRC08:22
*** btully has quit IRC08:23
*** pcaruana has quit IRC08:25
*** vishalmanchanda has joined #openstack-horizon08:26
*** btully has joined #openstack-horizon08:27
*** btully has quit IRC08:31
*** btully has joined #openstack-horizon08:31
openstackgerritVishal Manchanda proposed openstack/horizon master: Add Project Information column in group-snapshot table  https://review.openstack.org/64058808:34
*** pcaruana has joined #openstack-horizon08:37
*** priteau has joined #openstack-horizon08:42
*** pcaruana has quit IRC08:44
openstackgerritVishal Manchanda proposed openstack/horizon master: Updating Note to Setup guide  https://review.openstack.org/63811008:46
*** btully has quit IRC08:47
*** btully has joined #openstack-horizon08:48
*** btully has quit IRC08:56
*** jpich has joined #openstack-horizon08:56
*** e0ne has quit IRC08:58
*** btully has joined #openstack-horizon08:59
*** e0ne has joined #openstack-horizon09:00
*** ChanServ sets mode: +o e0ne09:00
*** pcaruana has joined #openstack-horizon09:01
*** tsmith_ has joined #openstack-horizon09:04
*** tsmith2 has quit IRC09:07
*** tsmith_ is now known as tsmith209:07
*** btully has quit IRC09:08
*** btully has joined #openstack-horizon09:08
*** tsmith_ has joined #openstack-horizon09:09
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: Switch integration tests to run with python3  https://review.openstack.org/63440609:10
*** btully has quit IRC09:12
*** tsmith2 has quit IRC09:12
*** tsmith_ is now known as tsmith209:12
*** btully has joined #openstack-horizon09:12
*** btully has quit IRC09:17
*** btully has joined #openstack-horizon09:20
*** nooryameen has quit IRC09:22
*** btully has quit IRC09:25
*** btully has joined #openstack-horizon09:28
*** btully has quit IRC09:37
*** btully has joined #openstack-horizon09:40
*** btully has quit IRC09:49
*** btully has joined #openstack-horizon09:49
*** btully has quit IRC09:54
*** btully has joined #openstack-horizon10:06
*** btully has quit IRC10:14
*** btully has joined #openstack-horizon10:14
*** btully has quit IRC10:22
*** btully has joined #openstack-horizon10:23
*** btully has quit IRC10:31
*** btully has joined #openstack-horizon10:35
*** btully has quit IRC10:39
*** btully has joined #openstack-horizon10:39
*** btully has quit IRC10:47
*** btully has joined #openstack-horizon10:47
*** v12aml has quit IRC10:48
*** btully has quit IRC10:51
*** btully has joined #openstack-horizon10:52
*** v12aml has joined #openstack-horizon10:53
*** btully has quit IRC10:56
*** btully has joined #openstack-horizon11:00
rdopierae0ne: so... Chinese translations don't work since two releases...11:00
rdopierae0ne: because of https://code.djangoproject.com/ticket/1841911:00
openstackDjango bug 18419 in Internationalization "Language code is not correct for Chinese" [Normal,Closed] - Assigned to Unknown11:00
e0nerdopiera: oh s...11:01
rdopierabasically they renamed their language codes11:01
rdopieraI'm reporting a bug11:03
rdopierae0ne: how would one go about renaming translations?11:06
e0nerdopiera: it's good to have amotoki's input here11:07
*** btully has quit IRC11:08
*** btully has joined #openstack-horizon11:08
rdopierae0ne: I don't think he speaks Chinese %)11:09
e0nerdopiera: he is i18n core:)11:11
*** btully has quit IRC11:12
rdopieraaah11:15
rdopieramy racism shows, I guess11:15
rdopierasorry11:15
rdopieraanyways, https://bugs.launchpad.net/horizon/+bug/181863911:16
openstackLaunchpad bug 1818639 in OpenStack Dashboard (Horizon) "Chinese translations got renamed from zh-cn and zh-tw to zh-hans and zh-hant" [Critical,New]11:16
*** btully has joined #openstack-horizon11:16
openstackgerritRadomir Dopieralski proposed openstack/horizon master: Remove zh-cn and zh-tw translations to zh-hans and zh-hant  https://review.openstack.org/64098111:24
rdopiera^^ in any case, I proposed a fix11:24
openstackgerritRadomir Dopieralski proposed openstack/horizon master: Remove zh-cn and zh-tw translations to zh-hans and zh-hant  https://review.openstack.org/64098111:25
openstackgerritRadomir Dopieralski proposed openstack/horizon master: Remove zh-cn and zh-tw translations to zh-hans and zh-hant  https://review.openstack.org/64098111:26
*** btully has quit IRC11:28
openstackgerritRadomir Dopieralski proposed openstack/horizon master: Rename zh-cn and zh-tw translations to zh-hans and zh-hant  https://review.openstack.org/64098111:30
*** e0ne has quit IRC11:32
*** btully has joined #openstack-horizon11:32
*** vishalmanchanda has quit IRC11:36
*** e0ne has joined #openstack-horizon11:42
*** ChanServ sets mode: +o e0ne11:42
*** btully has quit IRC11:44
*** btully has joined #openstack-horizon11:45
*** btully has quit IRC11:53
*** btully has joined #openstack-horizon11:57
*** jtomasek has joined #openstack-horizon12:05
*** btully has quit IRC12:09
*** btully has joined #openstack-horizon12:09
*** btully has quit IRC12:14
*** btully has joined #openstack-horizon12:17
*** dave-mccowan has joined #openstack-horizon12:19
openstackgerritVishal Manchanda proposed openstack/horizon master: Add Project Information column in group-snapshot table  https://review.openstack.org/64058812:20
*** btully has quit IRC12:22
*** btully has joined #openstack-horizon12:22
*** early` has quit IRC12:26
*** early` has joined #openstack-horizon12:29
*** btully has quit IRC12:30
*** btully has joined #openstack-horizon12:30
*** cshen has quit IRC12:35
*** btully has quit IRC12:38
*** btully has joined #openstack-horizon12:38
*** cshen has joined #openstack-horizon12:39
*** btully has quit IRC12:42
*** btully has joined #openstack-horizon12:46
*** tosky has joined #openstack-horizon12:48
*** btully has quit IRC12:51
*** btully has joined #openstack-horizon12:54
*** btully has quit IRC13:03
*** btully has joined #openstack-horizon13:03
*** btully has quit IRC13:08
*** btully has joined #openstack-horizon13:13
*** btully has quit IRC13:17
*** btully has joined #openstack-horizon13:17
*** btully has quit IRC13:21
*** btully has joined #openstack-horizon13:21
*** btully has quit IRC13:26
*** btully has joined #openstack-horizon13:34
*** btully has quit IRC13:39
*** priteau has quit IRC13:41
*** priteau has joined #openstack-horizon13:52
*** btully has joined #openstack-horizon14:00
*** btully has quit IRC14:05
*** dklyle has joined #openstack-horizon14:13
*** ChanServ sets mode: +o dklyle14:13
*** btully has joined #openstack-horizon14:19
*** btully has quit IRC14:23
amotokie0ne: rdopiera: yeah, I cannot speak Chinese :-) Last time I checked zh-hans/hant and zh-cn/tw, Django provided aliases so it worked. It was more than a year ago, so I am not sure it is correct now.14:29
rdopieraamotoki: looks like they deleted the aliases now14:29
rdopieraamotoki: note that it works when you run with manage.py, because then it's fionding django.po in the LOCALE_PATHS, but it will be missing the Django translations14:30
amotokirdopiera: you proposed a patch to rename zh-cn/tw to zh-hans/hant. What happens if we merge this? I have a concern on the impact on the current translation infrastructure.14:30
e0neamotoki, rdopiera : that's what I'm thinking about. we've got our translations proposed automatically14:32
amotokirdopiera: perhaps it requires some changes on translate.o.o and project-config/openstack-zuul-jobs.14:32
* e0ne just understood that we don't test horizon+tls on gates14:37
amotokie0ne: is there any problem with horizon+tls?14:39
e0neamotoki: I need to check with the latest version14:39
e0neamotoki: I'm pretty sure that it should work14:40
e0ne I've found one more issue14:41
e0newe don't support CSRF_COOKIE_HTTPONLY = True for Horizon :(14:41
amotokirdopiera: which Django version and python version do you use?14:47
amotokirdopiera: I recently use python2.7 + django 1.11 and I see zh-ch/zh-tw transltaions.14:48
*** btully has joined #openstack-horizon14:50
*** btully has quit IRC14:55
*** pcaruana has quit IRC14:57
*** e0ne has quit IRC15:02
rdopierapython2-django-1.11.11-1.el7ost.noarch15:09
rdopieraon rhel/fedora15:09
rdopieraso I guess it our packagers who decided the aliases are no longer needed15:12
rdopierasorry for the alarm15:12
*** e0ne has joined #openstack-horizon15:13
*** ChanServ sets mode: +o e0ne15:13
rdopierae0ne: what is involved in supporting it?15:13
rdopieraamotoki: I have no idea what would happen if we merged that patch, but that is for sure one step that we need to do, so I proposed it to start the discussion15:14
e0nerdopiera: we can't access csrf token if this flag is enabled. we have to use hidden input in this case or even add a note to the documentation that we don15:14
e0nethat we don't support this option15:15
*** btully has joined #openstack-horizon15:17
rdopierae0ne: that's just because we use javascript forms, right?15:18
e0neyes15:18
rdopieralet's ditch angular XD15:18
*** btully has quit IRC15:22
e0ne:D15:22
amotokirdopiera: As far as I checked, Django 1.11.16 and 2.0.10, conf/locale/__init__.py defines a fallback for zh-cn and zh-tw.15:25
amotokirdopiera: it seems my devstack env shows zh-tw and zh-cn correctly.... I haven't understood what is the actual problem...15:25
amotokirdopiera: I am wondering whether this is really critical or we can tackle it at the beginning of Train cycle. I cannot believe the translation infra can support zh-hans/hant so quickly without affecting translators.15:27
rdopieraamotoki: the exact problem is that translation.check_for_language(lang_code) that we use in the user settings form to validate the language code (and silently ignore it without any errors when it's invalid, of course), reliest on gettext.find() directly to check if a translation is available15:27
*** openstackgerrit has quit IRC15:28
rdopieraamotoki: furthermore, the paths passed to that gettext.find are relative, so it "works" when run from the horizon's main directory (because then the paths resolve), because it finds horiozn's django.mo file, but fails when run from any other directory, because then the relative paths are invalid, and it only checks the django path, with is absolute, but doesn't contain those translations15:28
rdopieraI was also considering simply removing that check_for_language call and check it against the list of languages we have in configuration anyways15:29
rdopierathat would certainly be a less invasive option15:29
rdopieraI will prepare a patch for that15:31
amotokirdopiera: does this come from some mismatch from the docs and code? when we assume Django automatically looks for translations from INSTALLED_APPS, 'locale' dir must exist under a django app. If a packager adopts a different approach, they should configure LOCALE_PATHS accordingly.15:32
rdopieraamotoki: https://code.djangoproject.com/ticket/2875515:36
openstackDjango bug 28755 in Internationalization "django.utils.translation.check_for_language doesn't check in the app folders" [Normal,Closed] - Assigned to Unknown15:36
rdopieraamotoki: so yes, there are two bugs15:37
amotokipersonally I would like to avoid renaming zh-cn/tw at this moment because language configuration in translate.o.o (zanata) is global to all projects and I cannot estimate how the renaming impacts translations for other projects including release note translations. translation will start after Stein-3.15:41
*** cshen has quit IRC15:41
amotokiif it is only specific to the horizon repo I am okay, but I don't think so. Thus I am exploring a way with less impact.15:41
*** pcaruana has joined #openstack-horizon15:42
*** openstackgerrit has joined #openstack-horizon15:44
openstackgerritRadomir Dopieralski proposed openstack/horizon master: Don't use check_for_language in the user settings form  https://review.openstack.org/64105415:44
rdopieraamotoki: ^-- please take a look at this15:44
rdopierait will also fix this particular problem15:44
*** btully has joined #openstack-horizon15:44
rdopierabtw, we don't validate timezone in that form15:45
rdopieraor pretty much anything else, tbh15:45
*** btully has quit IRC15:49
amotokirdopiera: (just from curiosity) where is django locale data placed in rhel/fedora packages?15:51
rdopieraamotoki: in site-packages, with all the rest of the code15:52
rdopierawe're not Debian :)15:52
*** btully has joined #openstack-horizon15:53
-amotoki- is still trying to understand the problem correctly15:58
rdopieraamotoki: let me explain what is happening step by step15:58
-amotoki- runs horizon using apache (not with manage.py runserver)15:58
rdopieraamotoki: when the user settings form is submitted with a zh-cn language code, we use translation.check_for_language() to see if it's a valid code, and ignore it without any error message if it's not valid15:59
rdopieraamotoki: translation.check_for_language() uses gettext.find() to look for django.mo in the paths defined in LOCALE_PATHS, however due to a bug, doesn't expand those paths, so only the path to Django's own translations is absolute, the other two (to horizon and openstack_dashboard) are relative16:01
*** btully has quit IRC16:02
rdopieraamotoki: that makes check_for_language fail and return False, because it can't find a zh_CN/django.mo file in Django's own directory, and the other two don't exist if you are not in the right working directory16:02
rdopieraamotoki: any of the following will fix it: 1. don't use check_for_language in that form in the first place, 2. symlink zh_Hans to zh_CN in django's locale directory, 3. rename zh_CN translations and languages to zh_Hans, 4. provide absolute paths in LOCALE_PATHS16:04
rdopieraamotoki: for now I told the customer to do 4., as this is a configuration change, but I would hope we can do 1. or 3.16:04
*** btully has joined #openstack-horizon16:05
amotokirdopiera: thanks. I now succeeded to reproduce this in my local env. Last time I tested it I saw Chinese dashboard translation somehow :-(16:06
rdopiera(don't ask how I found it)16:06
amotokihttps://bugs.launchpad.net/horizon/+bug/1804289 sounds a same problem16:09
openstackLaunchpad bug 1804289 in OpenStack Dashboard (Horizon) "LOCALE_PATH causes message mo files not found" [Undecided,Invalid] - Assigned to Gloria Gu (gloria-gu)16:09
amotokithis is from SUSE16:09
*** btully has quit IRC16:09
rdopierayup16:09
rdopierawell, it's due to the same django bug16:11
rdopierabut that solution won't fix this bug, I think16:11
rdopierano, wait, the paths Django will put there automatically are absolute16:12
rdopieraso it will work, by accident16:13
*** btully has joined #openstack-horizon16:13
rdopieraI would still prefer https://review.openstack.org/#/c/641054/1/openstack_dashboard/dashboards/settings/user/forms.py as a long-term solution16:13
amotokirdopiera: from what I understand, this is caused by two django bugs: the one is https://code.djangoproject.com/ticket/28755 and the other is check_for_language does not honor 'fallback' in django/conf/locale/__init__.py (alias), right?16:17
openstackDjango bug 28755 in Internationalization "django.utils.translation.check_for_language doesn't check in the app folders" [Normal,Closed] - Assigned to Unknown16:17
rdopieraamotoki: precisely16:18
*** btully has quit IRC16:18
rdopieraamotoki: however, I think that our use of check_for_laguages in validating the language is a mistake as well16:18
amotokirdopiera: thanks16:18
rdopieraamotoki: that dropdown list is populated from settings.LANGUAGES initially, so it should also be validated against settings.LANGUAGES in my opinion16:19
amotokirdopiera: yeah, check_for_laguages was introduced perhaps to prevent langugaes which are not covered by django16:19
rdopieraamotoki: otherwise, if someone changes settings.LANGUAGES to limit the languages available on their system, it will still be possible to set a language that is not present16:19
amotokiif we use check_for_laguages we should check when setting the dropdown list, but it is too much.16:20
amotokisomeone who changes settings.LANGUAGES should be responsible to configure the right value :)16:20
rdopiera(als, tha validation should be happening in a clean() method, but that's a separate thing...)16:20
rdopieraamotoki: right16:20
amotokirdopiera: let me check your patch tomorrow morning.16:21
*** btully has joined #openstack-horizon16:21
amotokiI believe I got the full context.16:21
rdopieraamotoki: thanks, I can actually clean it up properly and add proper validation...16:21
rdopierafor all the fields in there16:22
rdopierabut I wanted to keep it small for backporting16:22
*** btully has quit IRC16:25
openstackgerritAkihiro Motoki proposed openstack/horizon master: Updating Note to Setup guide  https://review.openstack.org/63811016:32
*** btully has joined #openstack-horizon16:39
*** btully has quit IRC16:44
-openstackstatus- NOTICE: Gerrit is being restarted for a configuration change, it will be briefly offline.17:10
*** btully has joined #openstack-horizon17:12
*** btully has quit IRC17:16
*** e0ne has quit IRC17:18
*** cshen has joined #openstack-horizon17:21
*** cshen has quit IRC17:26
*** jpich has quit IRC17:33
*** itlinux has joined #openstack-horizon17:35
*** gyee has joined #openstack-horizon17:54
*** e0ne has joined #openstack-horizon18:19
*** ChanServ sets mode: +o e0ne18:19
*** btully has joined #openstack-horizon18:20
*** btully has quit IRC18:24
*** btully has joined #openstack-horizon18:28
*** btully has quit IRC18:32
*** btully has joined #openstack-horizon18:33
*** itlinux has quit IRC18:42
*** btully has quit IRC18:45
*** itlinux has joined #openstack-horizon18:47
*** btully has joined #openstack-horizon18:48
*** btully has quit IRC18:53
*** btully has joined #openstack-horizon18:53
openstackgerritMerged openstack/horizon master: Updating Note to Setup guide  https://review.openstack.org/63811018:55
*** btully has quit IRC18:57
*** e0ne has quit IRC19:17
*** cshen has joined #openstack-horizon19:23
*** cshen has quit IRC19:27
*** btully has joined #openstack-horizon19:28
*** cshen has joined #openstack-horizon19:30
*** btully has quit IRC19:32
*** cshen has quit IRC19:34
*** btully has joined #openstack-horizon19:36
*** e0ne has joined #openstack-horizon19:37
*** ChanServ sets mode: +o e0ne19:37
*** btully has quit IRC19:41
*** btully has joined #openstack-horizon19:45
*** btully has quit IRC19:49
*** dave-mccowan has quit IRC19:55
*** btully has joined #openstack-horizon19:55
*** itlinux has quit IRC19:56
*** btully has quit IRC20:00
*** btully has joined #openstack-horizon20:02
*** dave-mccowan has joined #openstack-horizon20:03
*** btully has quit IRC20:07
*** itlinux has joined #openstack-horizon20:08
*** itlinux has quit IRC20:15
*** whoami-rajat has quit IRC20:22
*** btully has joined #openstack-horizon20:36
*** btully has quit IRC20:40
*** pcaruana has quit IRC21:10
*** btully has joined #openstack-horizon21:12
*** e0ne has quit IRC21:13
*** btully has quit IRC21:20
*** btully has joined #openstack-horizon21:24
*** e0ne has joined #openstack-horizon21:26
*** ChanServ sets mode: +o e0ne21:26
*** btully has quit IRC21:28
*** cshen has joined #openstack-horizon21:30
*** e0ne has quit IRC21:30
*** btully has joined #openstack-horizon21:33
*** cshen has quit IRC21:34
*** btully has quit IRC21:40
*** btully has joined #openstack-horizon21:43
*** btully has quit IRC21:47
*** btully has joined #openstack-horizon21:48
*** btully has quit IRC21:52
*** btully has joined #openstack-horizon22:00
*** priteau has quit IRC22:01
*** btully has quit IRC22:04
*** btully has joined #openstack-horizon22:08
*** btully has quit IRC22:13
*** mvkr has quit IRC22:25
*** tkajinam has joined #openstack-horizon22:54
*** rdopiera has quit IRC23:10
*** btully has joined #openstack-horizon23:24
*** cshen has joined #openstack-horizon23:30
*** cshen has quit IRC23:35
*** btully has quit IRC23:36
*** btully has joined #openstack-horizon23:50
*** btully has quit IRC23:55

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!