| *** rdopiera has joined #openstack-horizon | 00:03 | |
| openstackgerrit | Adrian Turjak proposed openstack/horizon master: Fix django.contrib.auth.middleware monkey patching https://review.openstack.org/614673 | 00:07 |
|---|---|---|
| openstackgerrit | Adrian Turjak proposed openstack/horizon master: Fix django.contrib.auth.middleware monkey patching https://review.openstack.org/614673 | 00:09 |
| *** lblanchard has quit IRC | 00:20 | |
| *** gyee has quit IRC | 00:25 | |
| *** rdopiera has quit IRC | 00:26 | |
| openstackgerrit | Andy Botting proposed openstack/horizon master: Support setting more visibility options for edit/create image https://review.openstack.org/602468 | 00:36 |
| *** cshen has joined #openstack-horizon | 00:38 | |
| *** cshen has quit IRC | 00:43 | |
| *** ianychoi has quit IRC | 02:10 | |
| *** ianychoi has joined #openstack-horizon | 02:10 | |
| openstackgerrit | Wangliangyu proposed openstack/horizon master: Table checkbox display problem when updating row https://review.openstack.org/613217 | 02:33 |
| *** rajalokan has joined #openstack-horizon | 05:04 | |
| *** rajalokan has left #openstack-horizon | 05:05 | |
| *** rajalokan has joined #openstack-horizon | 05:05 | |
| *** jtomasek has joined #openstack-horizon | 05:14 | |
| *** e0ne has joined #openstack-horizon | 06:24 | |
| *** ChanServ sets mode: +o e0ne | 06:24 | |
| *** jtomasek has quit IRC | 06:39 | |
| *** e0ne has quit IRC | 06:44 | |
| *** e0ne has joined #openstack-horizon | 06:48 | |
| *** ChanServ sets mode: +o e0ne | 06:48 | |
| openstackgerrit | pengyuesheng proposed openstack/horizon master: the user details page, the name needs to be word wrap https://review.openstack.org/615741 | 06:55 |
| *** dayou has quit IRC | 07:07 | |
| *** dayou has joined #openstack-horizon | 07:07 | |
| *** e0ne has quit IRC | 07:07 | |
| *** cshen has joined #openstack-horizon | 07:26 | |
| *** pcaruana has joined #openstack-horizon | 07:36 | |
| *** rdopiera has joined #openstack-horizon | 07:47 | |
| *** rdopiera has quit IRC | 07:47 | |
| *** rdopiera has joined #openstack-horizon | 07:47 | |
| *** rdopiera has quit IRC | 07:49 | |
| *** rdopiera has joined #openstack-horizon | 07:49 | |
| *** rdopiera has quit IRC | 07:49 | |
| *** rdopiera has joined #openstack-horizon | 07:50 | |
| *** dayou_ has joined #openstack-horizon | 08:03 | |
| *** dayou has quit IRC | 08:04 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon master: Imported Translations from Zanata https://review.openstack.org/614704 | 08:13 |
| *** rajalokan has quit IRC | 08:19 | |
| *** priteau has joined #openstack-horizon | 08:39 | |
| *** jtomasek has joined #openstack-horizon | 08:41 | |
| *** jpich has joined #openstack-horizon | 08:57 | |
| *** betherly has joined #openstack-horizon | 09:01 | |
| *** itlinux has joined #openstack-horizon | 09:14 | |
| *** priteau has quit IRC | 09:20 | |
| *** Emine has joined #openstack-horizon | 09:20 | |
| *** priteau has joined #openstack-horizon | 09:23 | |
| *** mvkr has quit IRC | 09:31 | |
| *** mvkr has joined #openstack-horizon | 10:01 | |
| openstackgerrit | Vadym Markov proposed openstack/horizon master: Call Glance list with certain image ids https://review.openstack.org/238189 | 10:31 |
| *** dayou_ has quit IRC | 10:43 | |
| *** mvkr has quit IRC | 10:44 | |
| *** mvkr has joined #openstack-horizon | 10:58 | |
| *** e0ne has joined #openstack-horizon | 11:11 | |
| *** ChanServ sets mode: +o e0ne | 11:11 | |
| *** dayou has joined #openstack-horizon | 12:25 | |
| *** e0ne has quit IRC | 12:29 | |
| *** dave-mccowan has joined #openstack-horizon | 12:29 | |
| *** e0ne has joined #openstack-horizon | 12:43 | |
| *** ChanServ sets mode: +o e0ne | 12:43 | |
| *** Emine has quit IRC | 12:59 | |
| *** Emine has joined #openstack-horizon | 13:15 | |
| *** emine__ has joined #openstack-horizon | 13:19 | |
| *** Emine has quit IRC | 13:20 | |
| *** kforde has joined #openstack-horizon | 13:33 | |
| *** lblanchard has joined #openstack-horizon | 14:00 | |
| *** emine__ has quit IRC | 14:15 | |
| *** early has quit IRC | 14:25 | |
| *** early has joined #openstack-horizon | 14:28 | |
| *** munimeha1 has joined #openstack-horizon | 14:59 | |
| *** e0ne has quit IRC | 15:06 | |
| *** itlinux has quit IRC | 15:38 | |
| *** priteau has quit IRC | 15:49 | |
| *** cshen has quit IRC | 15:55 | |
| *** gyee has joined #openstack-horizon | 16:21 | |
| *** cshen has joined #openstack-horizon | 16:29 | |
| *** cshen has quit IRC | 16:34 | |
| openstackgerrit | Merged openstack/horizon master: Add "Create Router" button to admin panel https://review.openstack.org/577083 | 17:16 |
| *** cshen has joined #openstack-horizon | 17:24 | |
| *** Leo_m has joined #openstack-horizon | 17:28 | |
| *** e0ne has joined #openstack-horizon | 17:32 | |
| *** ChanServ sets mode: +o e0ne | 17:32 | |
| *** jpich has quit IRC | 17:34 | |
| *** e0ne has quit IRC | 18:03 | |
| *** e0ne has joined #openstack-horizon | 18:06 | |
| *** ChanServ sets mode: +o e0ne | 18:06 | |
| *** jtomasek has quit IRC | 18:18 | |
| *** e0ne has quit IRC | 18:24 | |
| openstackgerrit | Merged openstack/horizon master: Call Glance list with certain image ids https://review.openstack.org/238189 | 18:30 |
| *** gyee has quit IRC | 18:34 | |
| *** mvkr has quit IRC | 19:10 | |
| larsks | I don't see any chatter here other than gerrit, but I'll cross my fingers...we have two cinder volume types defined. In Pike, when creating a volume, the "Type" menu has two entries. | 19:19 |
| larsks | In Queens, with the same configuration, the "Type" menu has three entries: "No volume type", and then the two defined types. | 19:19 |
| larsks | Is that expected? | 19:20 |
| rdopiera | I think it was added | 19:38 |
| larsks | rdopiera: I'm a little confused; looking at stable/pike it seems to be there already. | 19:42 |
| larsks | There seems to be some code that explicitly removes the 'no volume type' entry...let me see if that is gone from queens... | 19:42 |
| larsks | rdopiera: I'm looking at this comment here: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/volumes/forms.py#L297 | 19:43 |
| larsks | What is a "default volume type"? | 19:43 |
| larsks | Is that a cinder setting? | 19:44 |
| * larsks checks | 19:44 | |
| larsks | I think it is. That might be it. | 19:45 |
| *** david-lyle has joined #openstack-horizon | 19:46 | |
| *** ChanServ sets mode: +o david-lyle | 19:46 | |
| *** dklyle has quit IRC | 19:49 | |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Fix django.contrib.auth.middleware monkey patching https://review.openstack.org/614673 | 19:52 |
| *** mvkr has joined #openstack-horizon | 19:58 | |
| *** jtomasek has joined #openstack-horizon | 20:21 | |
| amotoki | larsks: yes, that means the default volume type. it might be better to rephrase it to "Default volume type" (or "No volume type specified") | 20:23 |
| amotoki | larsks: "default volume type" is a cinder configuration and we can get the default volume type via the API. | 20:24 |
| *** jtomasek has quit IRC | 20:24 | |
| larsks | amotoki: thanks, I found that. Going to try that out shortly. | 20:25 |
| *** munimeha1 has quit IRC | 20:46 | |
| *** cshen has quit IRC | 21:22 | |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Clarify middleware public methods https://review.openstack.org/616010 | 21:24 |
| *** pcaruana has quit IRC | 21:31 | |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Fix django.contrib.auth.middleware monkey patching https://review.openstack.org/614673 | 21:36 |
| *** cshen has joined #openstack-horizon | 21:40 | |
| *** lblanchard has quit IRC | 21:57 | |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Show snapshots list correctly when launching instance https://review.openstack.org/548181 | 22:06 |
| *** rdopiera has quit IRC | 22:17 | |
| *** dave-mccowan has quit IRC | 22:35 | |
| *** cshen has quit IRC | 22:39 | |
| adriant | amotoki: https://review.openstack.org/#/c/614673 looks good as is, and if we backport to queens we can deal with the minor differences then | 22:44 |
| adriant | mgagne: hope that works for you? ^ | 22:44 |
| adriant | I know that in our case, we maintain an internal repo anyway, and just rebase on the stable branch for backports every now and again, so cherrypicking this and updating it is easy enough. Not sure if you are doing the same | 22:46 |
| mgagne | we do have an internal repository | 22:46 |
| adriant | We're currently on pike anyway (soon to be upgrading to queens), so I'll have to backport it myself anyway | 22:46 |
| mgagne | cool | 22:46 |
| mgagne | it's already committed, packaged and deployed on our side. | 22:46 |
| adriant | cool :) | 22:47 |
| adriant | then best to just get it merged as is, and the horizon team can decide how far back to port it | 22:47 |
| mgagne | yea | 22:47 |
| mgagne | as long as people are satisfied with the change. I was just not interested in reviewing it daily as I thought it was a fairy simple change to begin with. | 22:48 |
| adriant | welcome to upstream development! :P | 22:49 |
| mgagne | it looks like django 1.11 is still tested/supported? https://github.com/openstack/horizon/blob/master/tox.ini#L36 | 22:49 |
| * adriant groans | 22:49 | |
| mgagne | adriant: yea, I know the drill, I also used to be core in Puppet projects. | 22:49 |
| mgagne | the issue isn't with Django 1.11 itself, it's that Horizon uses the deprecated MIDDLEWARE_CLASSES setting which doesn't pass the get_response parameter. | 22:50 |
| adriant | but only on the queens branch? | 22:50 |
| mgagne | the setting? | 22:50 |
| adriant | post queens I think we did switch to MIDDLEWARE = [ | 22:50 |
| mgagne | oh good | 22:51 |
| mgagne | +1 then | 22:51 |
| adriant | https://github.com/openstack/horizon/blob/stable/rocky/openstack_dashboard/settings.py#L112 | 22:52 |
| mgagne | yea, I checked ;) | 22:52 |
| adriant | that said, it's nice to slowly see Horizon actually getting better, but... we have a long way to go | 22:54 |
| * adriant not so secretly wishes for a Horizon rewrite in Vue | 22:54 | |
| *** Leo_m has quit IRC | 23:00 | |
| openstackgerrit | Merged openstack/horizon master: Show snapshots list correctly when launching instance https://review.openstack.org/548181 | 23:03 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!