Thursday, 2018-09-27

*** btully has quit IRC00:02
*** btully has joined #openstack-horizon00:06
*** btully has quit IRC00:11
*** btully has joined #openstack-horizon00:23
*** btully has quit IRC00:28
*** btully has joined #openstack-horizon00:32
*** btully has quit IRC00:36
*** cshen has joined #openstack-horizon00:46
*** cshen has quit IRC00:51
*** Emine has quit IRC00:55
*** btully has joined #openstack-horizon01:12
*** btully has quit IRC01:17
*** Bhujay has joined #openstack-horizon02:19
*** Bhujay has quit IRC02:19
*** Bhujay has joined #openstack-horizon02:20
*** btully has joined #openstack-horizon02:32
*** btully has quit IRC02:36
*** Bhujay has quit IRC02:59
*** btully has joined #openstack-horizon03:11
*** btully has quit IRC03:18
*** btully has joined #openstack-horizon03:31
*** btully has quit IRC03:36
*** rcernin_ has quit IRC03:42
*** rcernin has joined #openstack-horizon03:43
*** btully has joined #openstack-horizon03:46
*** dave-mccowan has quit IRC03:46
*** btully has quit IRC03:50
*** cshen has joined #openstack-horizon04:54
*** cshen has quit IRC04:58
*** btully has joined #openstack-horizon05:21
*** btully has quit IRC05:25
*** btully has joined #openstack-horizon05:28
*** Bhujay has joined #openstack-horizon05:35
*** btully has quit IRC05:37
*** btully has joined #openstack-horizon05:45
*** btully has quit IRC05:49
*** btully has joined #openstack-horizon05:53
*** btully has quit IRC05:57
*** btully has joined #openstack-horizon06:01
*** hoangcx has quit IRC06:11
*** hoangcx has joined #openstack-horizon06:12
*** eric_fairbanks has joined #openstack-horizon06:14
*** btully has quit IRC06:17
*** btully has joined #openstack-horizon06:21
*** btully has quit IRC06:26
*** cshen has joined #openstack-horizon06:29
*** btully has joined #openstack-horizon06:30
*** pcaruana has joined #openstack-horizon06:33
*** btully has quit IRC06:38
*** btully has joined #openstack-horizon06:42
*** btully has quit IRC06:46
*** btully has joined #openstack-horizon06:50
*** btully has quit IRC06:55
*** btully has joined #openstack-horizon06:58
*** btully has quit IRC07:03
*** btully has joined #openstack-horizon07:07
*** btully has quit IRC07:11
*** rcernin has quit IRC07:12
*** rdopiera has joined #openstack-horizon07:13
*** btully has joined #openstack-horizon07:15
adriantrdopiera: i've yet to test out the last memoized patch you did, but it looks sane and should help.07:16
*** btully has quit IRC07:19
rdopierait will only help with the functions that take a request object, though07:20
rdopieraeverything else will still be cached indifinitely07:20
*** btully has joined #openstack-horizon07:23
*** openstackgerrit has joined #openstack-horizon07:24
openstackgerritAdrian Turjak proposed openstack/horizon master: Ugly fix to clear memo cache every request  https://review.openstack.org/60493407:24
adriantrdopiera: just realised why my old version fo ^ failed to help07:26
adriantto*07:26
adriantof*07:26
adriantclearing the top level cache I was creating did nothing if the cache inside the closure was still there... new version in theory, while drastic should clear everything07:27
adriantwill test it again tomorrow, and your patch07:27
*** btully has quit IRC07:28
rdopieraadriant: to be clear, please test this: https://review.openstack.org/#/c/605024/07:28
rdopieraadriant: and not the first one07:28
adriantyep, that was the plan07:29
rdopierathe first one, with the clear function, suffers from race conditions07:29
rdopierawhen there are multiple requests07:29
adrianthmmm, that's  a point... my patch probably would too. It would clear the cache for requests along side it rather than just the request in question07:31
* adriant has an idea07:31
*** btully has joined #openstack-horizon07:32
*** cshen has quit IRC07:32
adrianthmmm, no, doing a cache per request isn't particularly doable since the decorator doesn't know the request unless it happens to be called for a function which passes one in07:35
rdopieraright, and for functions that don't take a request we really don't know when the value will be needed again07:35
rdopieraone more possibility is to use an LRU cache -- this way we can have a cap on the total amount of memory used07:36
adriantat which point we may as well just use memcached which already does that07:37
rdopierawe can't, because Horizon doesn't require memcached07:37
rdopierathere are installs that don't have it07:37
rdopierabesides, it's slow07:37
adriantyeah, we lose a lot of the benefit of replacing an api call, with... well a different api call really07:40
*** btully has quit IRC07:40
adriantunless memcache is running on the same host07:40
adriantwhich isn't often the case07:40
rdopierawith python 3's dicts that keep the insertion order, making a LRU cache should be easy07:40
rdopierayou basically check the len of the dict, and if it's over the limit, remove the first element07:41
adriantand it would be faster than iterating through and checking expiry times too07:42
*** btully has joined #openstack-horizon07:44
adriantand if the MAX_MEMOIZED_ENTRIES or some setting key is configurable it makes it easy enough to tweak, but we'd want to do some testing and add docs for approximate max entries vs memory usage so a deployment can easily enough tweak it07:44
*** tosky has joined #openstack-horizon07:45
adriantand so they are aware that it's a per worker setting (depending on their server)07:45
rdopierait could be a global setting, like you say, or it could be set in the decorator per function07:46
rdopieraor some mix of the two (maybe a multiplier set per function)07:46
adriantoooh, yeah that could be useful.07:46
rdopierain any case, let's try the simlest thing for now07:46
adriantyep, will test things tomorrow07:47
rdopierawe can't do that anyways while python 2 is still supported07:47
adriantand we're still running horizon in py27 :(07:47
rdopierasome customers are07:47
adriantbut switching to py36 in docker soon07:47
*** jpich has joined #openstack-horizon07:47
adriantok07:48
adriantwill update you how tests go07:48
* adriant finally leaves the office07:48
*** btully has quit IRC07:52
*** btully has joined #openstack-horizon07:57
*** cshen has joined #openstack-horizon07:59
*** btully has quit IRC08:01
*** cshen has quit IRC08:03
*** btully has joined #openstack-horizon08:04
*** btully has quit IRC08:09
*** e0ne has joined #openstack-horizon08:12
*** ChanServ sets mode: +o e0ne08:12
*** btully has joined #openstack-horizon08:13
*** eric_fairbanks has quit IRC08:16
*** btully has quit IRC08:17
*** btully has joined #openstack-horizon08:21
*** btully has quit IRC08:26
*** btully has joined #openstack-horizon08:29
*** btully has quit IRC08:33
openstackgerritEdward Hope-Morley proposed openstack/horizon master: Add enabled check in Backups panel  https://review.openstack.org/60544208:37
*** btully has joined #openstack-horizon08:37
*** btully has quit IRC08:42
*** btully has joined #openstack-horizon08:45
*** btully has quit IRC08:50
*** btully has joined #openstack-horizon08:54
*** btully has quit IRC08:58
*** btully has joined #openstack-horizon09:02
*** btully has quit IRC09:06
*** btully has joined #openstack-horizon09:10
*** btully has quit IRC09:15
*** btully has joined #openstack-horizon09:18
*** Bhujay has quit IRC09:19
*** btully has quit IRC09:23
*** btully has joined #openstack-horizon09:24
*** Emine has joined #openstack-horizon09:24
*** Bhujay has joined #openstack-horizon09:25
*** btully has quit IRC09:29
adriantoh, rdopiera (since I'm still online for silly reasons) why not just use an ordereddict since that then works with both py3 and 2?09:30
*** btully has joined #openstack-horizon09:31
*** btully has quit IRC09:35
*** btully has joined #openstack-horizon09:39
*** btully has quit IRC09:44
*** btully has joined #openstack-horizon09:47
*** btully has quit IRC09:52
*** btully has joined #openstack-horizon09:55
*** btully has quit IRC10:00
*** btully has joined #openstack-horizon10:04
*** btully has quit IRC10:08
*** btully has joined #openstack-horizon10:12
*** eric_fairbanks has joined #openstack-horizon10:15
*** btully has quit IRC10:21
*** btully has joined #openstack-horizon10:24
*** btully has quit IRC10:29
*** btully has joined #openstack-horizon10:32
*** btully has quit IRC10:37
*** btully has joined #openstack-horizon10:41
*** btully has quit IRC10:45
*** btully has joined #openstack-horizon10:49
*** btully has quit IRC10:54
*** btully has joined #openstack-horizon10:57
*** btully has quit IRC11:02
*** btully has joined #openstack-horizon11:05
*** btully has quit IRC11:14
*** btully has joined #openstack-horizon11:18
*** btully has quit IRC11:26
*** btully has joined #openstack-horizon11:30
*** eric_fairbanks is now known as eric__11:33
*** eric__ is now known as erickes11:33
*** btully has quit IRC11:34
*** btully has joined #openstack-horizon11:38
*** btully has quit IRC11:43
*** tosky__ has joined #openstack-horizon11:44
*** tosky has quit IRC11:44
*** tosky has joined #openstack-horizon11:45
*** btully has joined #openstack-horizon11:46
*** pcaruana has quit IRC11:50
*** btully has quit IRC11:51
*** Bhujay has quit IRC11:51
*** Bhujay has joined #openstack-horizon11:52
*** Bhujay has quit IRC11:53
*** Bhujay has joined #openstack-horizon11:53
*** Bhujay has quit IRC11:54
*** btully has joined #openstack-horizon11:55
*** lblanchard has joined #openstack-horizon11:59
*** btully has quit IRC11:59
*** btully has joined #openstack-horizon12:03
*** btully has quit IRC12:07
*** e0ne has quit IRC12:09
*** e0ne has joined #openstack-horizon12:09
*** ChanServ sets mode: +o e0ne12:09
*** btully has joined #openstack-horizon12:11
*** tosky__ has quit IRC12:15
*** btully has quit IRC12:16
*** btully has joined #openstack-horizon12:19
*** btully has quit IRC12:24
*** btully has joined #openstack-horizon12:27
*** btully has quit IRC12:32
*** btully has joined #openstack-horizon12:36
*** pcaruana has joined #openstack-horizon12:39
*** btully has quit IRC12:40
*** btully has joined #openstack-horizon12:44
*** noonedeadpunk has joined #openstack-horizon12:44
noonedeadpunkhi folks, can you please look at the patch https://review.openstack.org/#/c/605442/ ?12:45
*** btully has quit IRC12:48
*** btully has joined #openstack-horizon12:52
*** btully has quit IRC13:00
e0nenoonedeadpunk: done13:02
*** btully has joined #openstack-horizon13:04
noonedeadpunke0ne thanks)13:04
*** btully has quit IRC13:13
*** btully has joined #openstack-horizon13:21
*** e0ne has quit IRC13:22
*** btully has quit IRC13:25
*** e0ne has joined #openstack-horizon13:26
*** ChanServ sets mode: +o e0ne13:26
*** btully has joined #openstack-horizon13:29
openstackgerritMerged openstack/horizon master: Add enabled check in Backups panel  https://review.openstack.org/60544213:33
*** btully has quit IRC13:34
*** btully has joined #openstack-horizon13:37
*** btully has quit IRC13:42
*** btully has joined #openstack-horizon13:47
*** btully has quit IRC13:52
*** itlinux has quit IRC13:59
*** btully has joined #openstack-horizon14:01
openstackgerritVadym Markov proposed openstack/horizon master: Hide Swift network info in Horizon error message  https://review.openstack.org/60573114:01
*** btully has quit IRC14:05
*** Leo_m has joined #openstack-horizon14:09
*** lblanchard has quit IRC14:19
*** btully has joined #openstack-horizon14:39
*** btully has quit IRC14:44
*** lblanchard has joined #openstack-horizon14:55
*** itlinux has joined #openstack-horizon14:58
*** btully has joined #openstack-horizon15:28
*** tsmith_ has joined #openstack-horizon15:32
*** btully has quit IRC15:32
*** tsmith_ is now known as tsmith215:36
*** dave-mccowan has joined #openstack-horizon15:41
*** e0ne has quit IRC15:51
*** gyee has joined #openstack-horizon15:53
*** gyee has quit IRC15:54
*** cshen has joined #openstack-horizon15:56
*** gyee has joined #openstack-horizon15:57
*** btully has joined #openstack-horizon16:03
*** btully has quit IRC16:07
*** dave-mccowan has quit IRC16:08
*** rdopiera has quit IRC16:10
*** cshen has quit IRC16:11
*** jpich has quit IRC16:12
*** cshen has joined #openstack-horizon16:31
*** btully has joined #openstack-horizon16:37
*** btully has quit IRC16:42
*** cshen has quit IRC16:43
*** cshen has joined #openstack-horizon16:44
*** cshen has quit IRC16:49
*** e0ne has joined #openstack-horizon16:52
*** ChanServ sets mode: +o e0ne16:52
*** e0ne has quit IRC16:54
openstackgerritTobias Urdin proposed openstack/horizon master: Add hide_create_volume to LAUNCH_INSTANCE_DEFAULTS  https://review.openstack.org/60581317:08
*** btully has joined #openstack-horizon17:15
*** e0ne has joined #openstack-horizon17:16
*** ChanServ sets mode: +o e0ne17:16
*** btully has quit IRC17:19
*** Emine has quit IRC17:21
*** btully has joined #openstack-horizon17:23
*** btully has quit IRC17:28
*** btully has joined #openstack-horizon17:33
*** Emine has joined #openstack-horizon17:34
*** cshen has joined #openstack-horizon17:35
*** goldenfri has joined #openstack-horizon17:36
*** btully has quit IRC17:38
*** mvkr has quit IRC17:42
dtruonge0ne: the patch to fix horizon gate for the xstatic-jquery problem was merged yesterday, but we are still seeing the same problem with the senlin-dashboard17:47
dtruongthis patch is failing the nodejs-npm-run-test: https://review.openstack.org/#/c/603303/17:48
dtruongit looks senlin-dashboard is still using xstatic-jquery-3.3.1.1: http://logs.openstack.org/03/603303/1/check/nodejs-npm-run-test/e190788/job-output.txt.gz#_2018-09-27_07_32_33_61337617:49
dtruongany idea what's going on?17:49
e0nedtruong: it sounds like we've got two issues here17:51
e0nedtruong: https://github.com/openstack/senlin-dashboard/blob/master/requirements.txt#L10 - you use horizon rocky17:51
e0nedtruong: and I didn't backport my patch to older releases yet(17:51
dtruongi see.  let me check why we have a dependency to horizon rocky in senlin-dashboard17:55
*** btully has joined #openstack-horizon17:55
e0nedtruong: TBH, I'm not sure that it will help17:55
toskymox removal maybe?17:56
*** eandersson has joined #openstack-horizon17:57
e0neI'm trying to figure out what is going with senlin17:58
goldenfrihello, in the admin docs for queens it says you can update cpu/disk etc in horizon in queens. I could do that in mitaka but I don't have an edit flavor option in queens, only update metadata.17:58
goldenfriAre the docs outdated, is it a bug, or a missing feature?17:59
*** btully has quit IRC17:59
e0nedtruong: so it looks even worse now18:00
e0nedtruong: I'm afraid, that all plugins are affected, but I'm not sure18:02
e0nedtruong: new jquery is installed as a horizon's dependency18:02
e0nedtruong: or something went wrong with this https://github.com/openstack/senlin-dashboard/blob/master/package.json#L2418:03
*** dims_ is now known as dims18:05
*** cshen has quit IRC18:05
e0neit looks like some hack:(18:06
dtruongyea, that line looks pretty confusing18:07
dtruonglet me dig into and compare with some other dashboard projects18:07
e0neas I understand, it was done for local testing. we don't need it for CI18:08
e0nedtruong: https://review.openstack.org/#/c/605826/ - let's wait for gates. maybe it will help us18:10
dtruongsounds good.  thanks for your help.18:11
e0negoldenfri: sounds like a docs issue. we removed 'edit flavor' feature18:11
e0nedtruong: np18:11
eanderssonpretty sure magnum-ui has the same issue18:11
eanderssonYea - magnum suffers from the same bug18:12
e0neeandersson: :(((18:13
eanderssonhttps://github.com/openstack/magnum-ui/blob/master/package.json#L2918:13
eanderssonIt also has that lovely postinstall18:13
e0neeandersson: I like how do you call it:)18:14
e0nehttp://lists.openstack.org/pipermail/openstack-dev/2018-September/134599.html - an important thread about plugis18:15
e0ne*plugins18:16
e0neit's not an ideal solution, but should work fine in a short-term perspective with a limited resources18:16
goldenfrithanks e0ne is that ever expected to come back or is the only option to delete then re-create a flavor just to change a disk size?18:21
e0negoldenfri: yes18:21
e0negoldenfri: nova doesn't support flavor edit. so we just removed it to not confuse people18:21
goldenfriah ok, thanks18:22
e0neeandersson: let's wait to see if my patch works for senlin18:22
eanderssonsounds good18:22
eanderssonthanks e0ne18:22
e0neeandersson: np18:23
e0nelooks like zun-ui and zaqar-ui are also affected18:24
e0neI've just sent a note to the openstack-dev ML18:34
*** btully has joined #openstack-horizon18:47
*** btully has quit IRC18:52
*** btully has joined #openstack-horizon19:03
*** btully has quit IRC19:07
*** itlinux has quit IRC19:09
*** dayou has quit IRC19:10
*** btully has joined #openstack-horizon19:20
*** cshen has joined #openstack-horizon19:22
*** btully has quit IRC19:25
*** cshen has quit IRC19:34
*** dayou has joined #openstack-horizon19:37
*** e0ne has quit IRC19:42
*** e0ne has joined #openstack-horizon19:47
*** ChanServ sets mode: +o e0ne19:47
*** e0ne has quit IRC19:50
*** btully has joined #openstack-horizon19:54
*** pcaruana has quit IRC19:54
*** btully has quit IRC19:59
*** btully has joined #openstack-horizon20:02
*** cshen has joined #openstack-horizon20:05
*** btully has quit IRC20:06
*** e0ne has joined #openstack-horizon20:08
*** ChanServ sets mode: +o e0ne20:08
*** btully has joined #openstack-horizon20:13
*** btully has quit IRC20:17
*** Emine has quit IRC20:27
*** Emine has joined #openstack-horizon20:28
*** cshen has quit IRC20:29
*** lblanchard has quit IRC20:33
*** dayou has quit IRC20:38
*** btully has joined #openstack-horizon20:42
*** btully has quit IRC20:46
*** dayou has joined #openstack-horizon21:06
*** e0ne has quit IRC21:14
*** btully has joined #openstack-horizon21:21
*** btully has quit IRC21:25
*** btully has joined #openstack-horizon21:59
*** Leo_m has quit IRC22:01
*** btully has quit IRC22:03
*** mvkr has joined #openstack-horizon22:13
*** cshen has joined #openstack-horizon22:25
*** rcernin has joined #openstack-horizon22:29
*** cshen has quit IRC22:32
*** jtomasek has quit IRC22:35
*** btully has joined #openstack-horizon22:41
*** btully has quit IRC22:46
*** tosky has quit IRC22:53
*** btully has joined #openstack-horizon23:22
*** btully has quit IRC23:31
*** btully has joined #openstack-horizon23:42
*** btully has quit IRC23:46
*** btully has joined #openstack-horizon23:50
*** btully has quit IRC23:55
*** btully has joined #openstack-horizon23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!