Wednesday, 2018-08-08

openstackgerritMerged openstack/horizon master: add dns_name and dns_domain into admin column  https://review.openstack.org/58563900:02
*** gyee has quit IRC00:38
amotokiflwang: as of now, we cannot control whether a panel is displayed based on users's role.00:53
amotokiflwang: panels in the project dashboard have no policy_rules now. potentially horizon panels can check policies for read operations (though a discussion is needed on what policies should be referred to)00:55
openstackgerritMerged openstack/horizon master: fix bug of fail to create volume type encryption from dashboard  https://review.openstack.org/58562901:16
flwangamotoki: ok, then is it possible to determine if a service panel is displayed or not based on the keystone catalog?01:26
flwange.g. if the service is not in keystone catalog, the panel won't be displayed01:26
*** btully has joined #openstack-horizon01:32
*** btully has quit IRC01:36
amotokiflwang: this is what the current horizon does.01:49
flwangamotoki: does pike support that?01:50
amotokiflwang: for example, you can find "permissions = ('openstack.services.compute',)" in openstack_dashboard/dashboards/project/instances/panel.py01:50
flwangamotoki: cool01:51
amotokiflwang: it exists from long ago so I think it works for pike01:52
flwangamotoki: does that mean we do need similar 'permissions' attribute for the panel we want to control ? like https://github.com/openstack/magnum-ui/blob/master/magnum_ui/content/clusters/panel.py01:52
*** dave-mccowan has quit IRC02:57
*** dklyle has quit IRC02:58
*** zhurong has joined #openstack-horizon03:01
adriantflwang, amotoki: I'm confused, I'm fairly sure that if you edited (or wrote your own) policy files for horizon, and set a policy rule for the panel, you can easily hide/show panels based on role03:27
adriante.g. https://github.com/openstack/adjutant-ui/blob/master/adjutant_ui/content/tasks/panel.py#L23 and the note about editing the keystone policy file here: https://github.com/openstack/adjutant-ui/blob/master/doc/source/installation.rst03:29
adriantisn't that hiding a panel based on role?03:29
flwangadriant: that's the one i was asking, thanks03:48
flwangamotoki: ^ thoughts?03:48
*** zhurong has quit IRC04:20
amotokiflwang: it depends on your point of view. as developer, you can control a panel based on service and/or policy.04:49
amotokiflwang: as operators, you cannot define panel permission as you want.04:49
flwangamotoki: thanks, that makes sense04:50
amotokiflwang: for example, http://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/dashboards/identity/projects/panel.py04:51
*** hoonetorg has quit IRC05:31
*** e0ne has joined #openstack-horizon05:40
*** ChanServ sets mode: +o e0ne05:40
e0neamotoki: hi Akihiro. are you going to create a patch for https://bugs.launchpad.net/horizon/+bug/1785178 before rc1?05:41
openstackLaunchpad bug 1785178 in OpenStack Dashboard (Horizon) "default_cgsnapshot_type should not be listed in "Group Type" selection in "Create Group" form" [High,New]05:41
*** e0ne has quit IRC05:52
*** hoonetorg has joined #openstack-horizon05:52
*** zhurong has joined #openstack-horizon05:57
*** e0ne has joined #openstack-horizon06:03
*** ChanServ sets mode: +o e0ne06:03
*** hoonetorg has quit IRC06:06
*** pcaruana has joined #openstack-horizon06:27
*** rdopiera has joined #openstack-horizon06:31
*** e0ne has quit IRC06:51
*** btully has joined #openstack-horizon06:58
*** btully has quit IRC07:03
*** jpich has joined #openstack-horizon07:09
*** cshen has joined #openstack-horizon07:17
*** tosky has joined #openstack-horizon07:29
*** rcernin has quit IRC07:35
Guest74859hi07:35
Guest74859I thought about my question about tests, yesterday, and I don't know if I understand the way it should be07:37
Guest74859Panel tests should be in ``{{ module_name }}/test``, then ?07:38
Guest74859(by panel tests, I mean Django tests)07:38
Guest74859or should it stay in ``{{ modude_name }}/content/{{ panel }}/tests.py`` ?07:39
Guest74859(which was removed from ui-cookiecutter)07:40
*** zhurong has quit IRC08:26
josecastroleonamotoki: I tried today with "basepython = python2" in the releasenotes tox env in tox.ini and then ran "tox -e releasenotes -r" and it worked08:27
josecastroleonamotoki: I had to specify python2 to have the 2.7 version08:27
josecastroleonamotoki: but on the sphinx-build command it runs sdist first. If you activate the virtualenv (. .tox/releasenotes/bin/activate) and run python setup.py sdist you'll get the same encoding error as in the sphinx job08:29
josecastroleonamotoki: http://logs.openstack.org/10/587010/4/check/build-openstack-sphinx-docs/d54a639/job-output.txt.gz in the task [install-if-python : Make sdist to generate ChangeLog]08:31
*** btully has joined #openstack-horizon08:47
*** btully has quit IRC08:51
*** priteau has quit IRC09:45
*** priteau has joined #openstack-horizon09:45
*** edmondsw has joined #openstack-horizon09:45
*** edmondsw has quit IRC09:49
openstackgerritBoxiang Zhu proposed openstack/horizon master: Add package-lock.json which generate by npm  https://review.openstack.org/58942409:57
*** cshen has quit IRC10:02
*** tonyb has quit IRC10:16
*** tonyb has joined #openstack-horizon10:23
*** madorn has quit IRC10:25
*** madorn has joined #openstack-horizon10:27
*** btully has joined #openstack-horizon10:36
*** btully has quit IRC10:40
*** dave-mccowan has joined #openstack-horizon10:59
*** rmart04 has joined #openstack-horizon11:02
*** cshen has joined #openstack-horizon11:15
Guest74859oh, and if I use ``{{ module_name }}/test`` for my tests, do I really need to use the ``manage.py`` file from Django ?11:52
openstackgerritAkihiro Motoki proposed openstack/horizon master: Hide default_cgsnapshot_type from cinder group types  https://review.openstack.org/58986412:11
*** btully has joined #openstack-horizon12:24
*** btully has quit IRC12:29
*** e0ne has joined #openstack-horizon12:34
*** ChanServ sets mode: +o e0ne12:34
*** jpich has quit IRC12:37
*** edmondsw has joined #openstack-horizon13:05
*** e0ne has quit IRC13:18
*** lblanchard has quit IRC13:24
*** e0ne has joined #openstack-horizon13:31
*** ChanServ sets mode: +o e0ne13:31
*** _ix has joined #openstack-horizon13:49
openstackgerritDavid Gutman proposed openstack/horizon master: Change project details view in a tab view.  https://review.openstack.org/58859113:53
*** _ix has quit IRC14:13
*** _ix has joined #openstack-horizon14:22
amotokie0ne: On bug 1785178, I sent a small patch https://review.openstack.org/58986414:38
openstackbug 1785178 in OpenStack Dashboard (Horizon) "default_cgsnapshot_type should not be listed in "Group Type" selection in "Create Group" form" [High,New] https://launchpad.net/bugs/178517814:38
e0neamotoki: great! thank you! I'll review it a bit later today and will propose a release patch tomorrow morning (UTC+3)14:40
amotokijosecastroleon: is it still broken in py3 env? I would like to know whether it works in others' env. It works in my side.14:42
*** trevormc has joined #openstack-horizon14:43
amotokijosecastroleon: I am curios why it is not broken in our gate and broken only your env. I am not against to replace unicode char with ascii, but would like to know what happens.14:46
*** priteau has quit IRC14:53
*** e0ne has quit IRC14:58
openstackgerritDavid Gutman proposed openstack/horizon master: Add user tab in project details view.  https://review.openstack.org/58993215:00
openstackgerritDavid Gutman proposed openstack/horizon master: Change project details view in a tab view.  https://review.openstack.org/58859115:03
*** priteau has joined #openstack-horizon15:04
*** trevormc has quit IRC15:07
openstackgerritDavid Gutman proposed openstack/horizon master: Add user tab in project details view.  https://review.openstack.org/58993215:09
openstackgerritDavid Gutman proposed openstack/horizon master: Display users with role through group in users project details tab.  https://review.openstack.org/58993815:12
openstackgerritDavid Gutman proposed openstack/horizon master: Display users with role through group in users project details tab.  https://review.openstack.org/58993815:15
*** Guest74859 has left #openstack-horizon15:21
*** Guest74859 has joined #openstack-horizon15:21
josecastroleonamotoki: it works under py3 in my env15:23
josecastroleonbut every time i retest my code that has a release note the sphinx-job in zuul crashes15:23
amotokijosecastroleon: any example?15:24
josecastroleonamotoki: http://logs.openstack.org/10/587010/4/check/build-openstack-sphinx-docs/d54a639/job-output.txt.gz15:24
josecastroleonit you see in the task [install-if-python : Make sdist to generate ChangeLog]15:24
amotokijosecastroleon: surprisingly, build-openstack-sphinx-docs jobs in my patch did not fail even though I can see the same error http://logs.openstack.org/64/589864/1/check/build-openstack-sphinx-docs/b7ef4c6/job-output.txt.gz#_2018-08-08_12_32_10_13159215:28
*** cshen has quit IRC15:29
amotokijosecastroleon: it seems the root cause is different.15:29
amotokijosecastroleon: I agree it is better to fix it.15:29
amotokijosecastroleon: when I ran 'tox -e docs' against your patch, I can find the root cause easily15:33
amotokijosecastroleon: it says "/home/ubuntu/tmp/horizon/doc/source/configuration/settings.rst:1528:Error in "versionadded" directive:  1 argument(s) required, 0 supplied. "15:33
*** pcaruana has quit IRC15:34
*** rmart04 has quit IRC15:42
*** dklyle has joined #openstack-horizon15:55
*** ChanServ sets mode: +o dklyle15:55
*** david-lyle has joined #openstack-horizon15:59
*** ChanServ sets mode: +o david-lyle15:59
*** dklyle has quit IRC16:01
*** david-lyle is now known as dklyle16:02
*** btully has joined #openstack-horizon16:02
*** btully has quit IRC16:06
*** dklyle has quit IRC16:43
*** marlinc has quit IRC16:45
*** ediardo has joined #openstack-horizon16:52
*** gyee has joined #openstack-horizon16:52
*** marlinc has joined #openstack-horizon16:59
*** e0ne has joined #openstack-horizon17:11
*** ChanServ sets mode: +o e0ne17:11
*** dklyle has joined #openstack-horizon17:21
*** ChanServ sets mode: +o dklyle17:21
*** btully has joined #openstack-horizon17:51
*** btully has quit IRC17:55
*** dklyle has quit IRC17:57
*** e0ne has quit IRC18:03
*** dklyle has joined #openstack-horizon18:09
*** ChanServ sets mode: +o dklyle18:09
*** e0ne has joined #openstack-horizon18:20
*** ChanServ sets mode: +o e0ne18:20
*** itlinux has joined #openstack-horizon18:25
*** ircuser-1 has quit IRC18:30
*** dklyle has quit IRC18:31
*** dklyle has joined #openstack-horizon18:34
*** ChanServ sets mode: +o dklyle18:34
*** dklyle has quit IRC18:59
*** ediardo has quit IRC19:01
*** ediardo has joined #openstack-horizon19:02
*** e0ne has quit IRC19:11
*** e0ne has joined #openstack-horizon19:19
*** ChanServ sets mode: +o e0ne19:19
*** e0ne has quit IRC19:23
*** rmart04 has joined #openstack-horizon19:45
*** rmart04 has quit IRC19:45
*** Guest74859 is now known as Linkid20:04
*** ircuser-1 has joined #openstack-horizon20:05
*** dklyle has joined #openstack-horizon20:05
*** ChanServ sets mode: +o dklyle20:05
openstackgerritMerged openstack/horizon master: Hide default_cgsnapshot_type from cinder group types  https://review.openstack.org/58986420:06
*** itlinux has quit IRC20:12
*** lblanchard has joined #openstack-horizon20:25
ediardoo/20:56
*** dklyle has quit IRC20:58
*** dklyle has joined #openstack-horizon21:02
*** ChanServ sets mode: +o dklyle21:02
*** dklyle has quit IRC21:07
*** pcaruana has joined #openstack-horizon21:07
*** priteau has quit IRC21:20
*** lblanchard has quit IRC21:52
*** kei-ichi has joined #openstack-horizon21:54
*** kei-ichi has quit IRC21:57
*** kei-ichi has joined #openstack-horizon22:00
*** pcaruana has quit IRC22:02
*** edmondsw has quit IRC22:10
*** rcernin has joined #openstack-horizon22:19
*** priteau has joined #openstack-horizon22:26
*** gary-smith_ has joined #openstack-horizon22:53
*** jtomasek_ has joined #openstack-horizon22:54
*** zioproto_ has joined #openstack-horizon22:55
*** r-daneel has joined #openstack-horizon22:59
*** amotoki_ has joined #openstack-horizon23:01
*** ChanServ sets mode: +v amotoki_23:01
*** Tahvok has quit IRC23:02
*** jtomasek has quit IRC23:02
*** gary-smith has quit IRC23:02
*** NikitaKonovalov has quit IRC23:02
*** honza has quit IRC23:02
*** amotoki has quit IRC23:02
*** zioproto has quit IRC23:02
*** rickflare has quit IRC23:02
*** zioproto_ is now known as zioproto23:02
*** Tahvok has joined #openstack-horizon23:03
*** btully has joined #openstack-horizon23:17
*** btully has quit IRC23:22
*** tosky has quit IRC23:49
*** rmcall has joined #openstack-horizon23:50

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!