Friday, 2018-04-20

*** gyee has quit IRC00:04
*** hoangcx_ has joined #openstack-horizon00:07
*** hoangcx_ is now known as hoangcx00:08
*** ethfci_ has joined #openstack-horizon00:24
*** ethfci has quit IRC00:24
*** ethfci_ has quit IRC00:29
*** ethfci has joined #openstack-horizon00:30
*** btully has joined #openstack-horizon00:40
*** phuongnh has joined #openstack-horizon00:42
*** btully has quit IRC00:44
*** harlowja has quit IRC00:46
*** dave-mccowan has quit IRC01:01
*** dave-mccowan has joined #openstack-horizon01:26
*** dave-mccowan has quit IRC01:47
openstackgerritAdrian Turjak proposed openstack/horizon master: Create new wsgi.py file and deprecate old file  https://review.openstack.org/56180202:23
*** lblanchard has quit IRC02:35
*** lblanchard has joined #openstack-horizon02:36
*** lblanchard has quit IRC02:37
*** threestrands has joined #openstack-horizon02:59
*** zhurong has joined #openstack-horizon03:00
*** germs has quit IRC03:21
*** germs has joined #openstack-horizon03:21
openstackgerritAkihiro Motoki proposed openstack/horizon master: Disable mox usage by default in test helper  https://review.openstack.org/55804803:34
*** binBASH has quit IRC03:48
*** binBASH has joined #openstack-horizon03:50
adriantamotoki: for the wsgi file change. If I rename the bug file name, should I still keep it in bug or move it up to the generic release notes folder?03:52
openstackgerritShu Muto proposed openstack/ui-cookiecutter master: Run tox on created plugin  https://review.openstack.org/55446103:52
*** hoangcx has quit IRC03:54
*** hoangcx has joined #openstack-horizon03:55
openstackgerritAdrian Turjak proposed openstack/horizon master: Create new wsgi.py file and deprecate old file  https://review.openstack.org/56180203:56
amotokiadriant: IIRC we already have one relnotes per bug and bp directory. You need not to touch the existing one in 'bug' dir.04:09
openstackgerritAdrian Turjak proposed openstack/horizon master: Rework old customization templates and add new blocks  https://review.openstack.org/56182204:09
adriantamotoki: I've just moved it out to the main folder for relnotes. It looks like the random bugs folder was added ages ago and not used since04:11
amotokiadriant: I would like to check them later. I don't know how you determined they are not used.04:13
*** shu-mutow has joined #openstack-horizon04:14
amotokiadriant: they are automatically collected by reno, so we need to check they are orphaned carefully.04:14
adriantamotoki: 'horizon/releasenotes/notes/bug' only has one file in it, and it was added one year ago, but all the other bug relnotes are in 'horizon/releasenotes/notes/' directly04:15
adriantI was just looking at the git history04:15
* adriant shrugs04:15
amotokiadriant: yes, but reno searches git history and determine a relnote belong to which release, so moving it might confuse our rel note.04:15
adriantah04:16
amotokithat's a tricky point. I struggled the behavior several releases ago.04:17
adriantWell I'll put it where ever is correct. Feel free to edit the patch yourself to move it04:17
adriantto generate it originally I did: "reno new bug/1763204"04:17
adriantand I assume the "bug/" is what put it into the folder04:17
amotokithanks. I usually use 'reno new <short-string-which-describes-what-is-done>"04:18
*** btully has joined #openstack-horizon04:18
*** btully has quit IRC04:22
*** zhurong has quit IRC04:24
*** e0ne has joined #openstack-horizon05:23
*** ChanServ sets mode: +o e0ne05:23
*** lajoskatona has joined #openstack-horizon06:05
*** btully has joined #openstack-horizon06:06
*** btully has quit IRC06:11
*** e0ne has quit IRC06:18
*** phuongnh has quit IRC06:30
*** Liuqing has joined #openstack-horizon06:35
*** lajoskatona has quit IRC06:35
Liuqinghello afternoon06:43
*** pcaruana has joined #openstack-horizon06:43
*** lajoskatona has joined #openstack-horizon06:50
*** yamamoto has quit IRC06:50
*** threestrands has quit IRC07:00
*** rcernin has quit IRC07:02
*** Liuqing has quit IRC07:07
*** tesseract has joined #openstack-horizon07:12
*** tosky has joined #openstack-horizon07:17
*** cshen has joined #openstack-horizon07:27
*** jpich has joined #openstack-horizon07:50
*** yamamoto has joined #openstack-horizon07:51
*** yamamoto has quit IRC08:01
openstackgerritOpenStack Proposal Bot proposed openstack/horizon master: Imported Translations from Zanata  https://review.openstack.org/56297608:09
*** yamamoto has joined #openstack-horizon08:13
*** e0ne has joined #openstack-horizon08:19
*** ChanServ sets mode: +o e0ne08:19
*** cshen has quit IRC08:29
*** yamamoto has quit IRC08:44
*** shu-mutow is now known as shu-mutow-AWAY08:46
*** btully has joined #openstack-horizon08:57
*** lajoskatona has quit IRC09:07
*** dayou has quit IRC09:09
*** dayou has joined #openstack-horizon09:11
*** btully has quit IRC09:30
*** lajoskatona has joined #openstack-horizon09:34
*** lajoskatona has quit IRC09:38
*** yamamoto has joined #openstack-horizon09:44
openstackgerritMerged openstack/horizon master: usage: Use tenant_quota_usages() for Limit Summary  https://review.openstack.org/52685709:45
*** lajoskatona has joined #openstack-horizon09:52
*** yamamoto has quit IRC09:54
openstackgerritMerged openstack/horizon master: usage: move field-specific logic from template to code  https://review.openstack.org/52685809:55
openstackgerritMerged openstack/horizon master: usage: Add network resources to Limit Summary  https://review.openstack.org/52685909:55
*** cshen has joined #openstack-horizon09:58
*** hoangcx has quit IRC10:04
adriantrdopiera: the wsgi folder isn't a python module :P10:10
adriantI did at one point thing it was then was quite confused when realizing it was literally just a folder called wsgi, with an unimportable wsgi file in it...10:10
adrianthence the patch/bug report10:11
rdopieraadriant: for python3 it is10:11
rdopieraadriant: it doesn't have to have __init__.py in it10:11
adriantrdopiera: oh well damn, huh, I never realised10:12
rdopierathat's what the review is for :)10:12
adriantI use python3 mostly but kind of always assumed the __init__ file was still required10:12
rdopierait's one of the breaking changes they made10:12
adriantugh then that makes this whole problem a mess10:14
adriantmaybe we throw the wsgi file somewhere else :/10:14
rdopieramaybe you can just put it in wsgi?10:14
rdopieraso wsgi/wsgi.py10:14
adriantopenstack_dashboard.wsgi.wsgi ? :P10:14
rdopieraand add an __init__.py for python210:14
rdopierayou could also have it as __main__.py in wsgi10:15
adriantyeah, that could work. or... have the content of wsgi.py in the __init__10:15
rdopierathen it's openstack_dashboard.wsgi still10:15
adriantyeah10:15
adriantbut then there isn't a clear wsgi file for people to find10:15
rdopierabut it shows how clever we are!10:16
rdopiera(just kidding)10:16
* adriant cries10:16
adriantopenstack_dashboard.wsgi.wsgi is the 'least' awful option :/10:16
rdopierawsgi/wsgi.py sounds best to me10:16
rdopieraalso, make django.wsgi import it, instead of having a copy of all that code10:17
adriantyeah, that works too10:17
adriantalthough what I'm confused by is I'm actually buildin a docker container with horizon and I do: "cp openstack_dashboard/wsgi/django.wsgi openstack_dashboard/wsgi.py" and then run gunicorn with 'openstack_dashboard.wsgi'10:19
*** lajoskatona has quit IRC10:19
adriantso I know I'm not getting a conflict...10:19
adriantmaybe a file module has precedence over a folder module?10:20
rdopieras/folder module/package/10:20
* adriant is gonna test10:20
adriantyeah10:20
rdopierano, package has precedence10:20
rdopieraat least in python 310:20
adriantodd, then why does my container run10:20
adriantwait, does the package have to have anything actually in it/10:21
adriant?10:21
adriantbecause django.wsgi isn't actually valid python (not .py)10:21
rdopieraah10:22
rdopieraprobably that's why it works10:22
rdopierabut it still seems fragile to me10:22
adriantlemme test actually how python3 handles this. I'm now curious10:22
rdopieraI know for sure that when __init__.py is there, it has precedence10:23
rdopieraand I know that __init__.py is not required in python 3 for a directory to be a package10:23
rdopierabut if it's not there, then you probably can't import it anyways10:23
adrianthuh10:25
adriantwithout __init__ it appears module has precedence :/10:26
rdopierasimple is better than complex, ech10:26
adriantbut when I add an __init__ it does work10:26
*** Nil_ has quit IRC10:27
adriantyep, so long as no one adds an __init__.py wsgi.py is find where that patch puts it10:28
adriantpython3 is weird it seems10:29
rdopierait is10:29
adriantI think they have it work like that because the lack of a __init__.py suddenly making folders into packages is too breaking if there are modules of the same name10:29
adriantrdopiera: I'm inclined to live with the potential fragility of openstack_dashboard.wsgi over openstack_dashboard.wsgi.wsgi if we do get rid of the wsgi folder in the T release10:31
rdopierathanks for looking ito it10:31
rdopierainto10:31
*** pcaruana has quit IRC10:31
rdopieraadriant: it would still be nice to import it in the .wsgi file instead of having the code duplicated10:32
adriantrdopiera: my main reason for not doing that is I believe people are copying that old file somewhere and renaming it currently10:32
adriantwhich... should still work if it imports from 'openstack_dashboard.wsgi' i guess10:33
rdopierait should10:33
adriantyeah, as long as horizon is actually installed into the env they are running it, the location of the file shouldn't matter10:34
*** lajoskatona has joined #openstack-horizon10:36
adriantcool, rdopiera, I'll update that old wsgi file then to import the app from the new one. But can you double check the python3 module vs package precedence to make sure I'm not insane?10:37
adriantI just did it with a python3 interpreter, and a few quick folders and python modules that print on import10:38
rdopierathat's another advantage of doing the import — this way we always test it, even when using the old file10:38
rdopieraso if it doesn't work, we will know10:39
rdopieraadriant: I think you should also search the docs for mentions of that file, and correct them if necessary10:39
adriantyes! Good idea. I have a very cursory look, but should look properly10:40
rdopierajust grep for it10:40
adriantmy intention :P10:43
adriantI'm vaguely annoyed at myself for not doing that originally.10:43
adriantrdopiera: thanks, will get that up and sorted over the weekend or more likely when I'm back in the office on monday10:46
rdopierathanks10:46
*** cshen has quit IRC10:46
*** Nil_ has joined #openstack-horizon10:52
*** btully has joined #openstack-horizon11:16
*** cshen has joined #openstack-horizon11:20
*** btully has quit IRC11:20
*** yamamoto has joined #openstack-horizon11:31
*** obre_ has quit IRC11:37
*** obre has joined #openstack-horizon11:39
*** obre has quit IRC11:40
*** obre has joined #openstack-horizon11:41
*** yamamoto_ has joined #openstack-horizon11:44
*** pcaruana has joined #openstack-horizon11:46
*** yamamoto has quit IRC11:47
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: WIP. Fix selenuim-headless tests  https://review.openstack.org/55846712:35
*** yamamoto_ has quit IRC12:46
*** yamamoto has joined #openstack-horizon12:47
*** yamamoto has quit IRC12:52
*** dave-mccowan has joined #openstack-horizon12:57
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: WIP. Fix selenuim-headless tests  https://review.openstack.org/55846712:59
*** dave-mccowan has quit IRC13:02
*** btully has joined #openstack-horizon13:05
*** dave-mccowan has joined #openstack-horizon13:08
*** btully has quit IRC13:09
*** yamamoto has joined #openstack-horizon13:21
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: WIP. Fix selenuim-headless tests  https://review.openstack.org/55846713:24
*** jtriley has joined #openstack-horizon13:31
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: WIP. Fix selenuim-headless tests  https://review.openstack.org/55846713:36
*** dims has quit IRC13:58
*** mnaser has quit IRC14:00
*** mnaser has joined #openstack-horizon14:01
*** dims has joined #openstack-horizon14:04
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: Use default Django test runner instead of nose  https://review.openstack.org/54429614:15
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: WIP. Fix selenuim-headless tests  https://review.openstack.org/55846714:15
*** ygl has joined #openstack-horizon14:22
yglhi all14:33
*** nguyenhai has quit IRC14:33
e0nehi14:33
ygli am unable to find some images when launching an instance in the source search bar in horizon14:34
yglbut I can find that image when using glance cli14:34
yglis anyone aware of this problem ?14:35
yglis this a bug ?14:35
e0nedo you use the same tenant both for cli and horizon?14:39
e0neI'm not  aware of such bugs14:39
ygljust a min I am testing14:40
ygli am still unable to see it in horizon14:43
yglwhen launching an instance14:44
*** ygl has quit IRC14:51
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: Use default Django test runner instead of nose  https://review.openstack.org/54429614:52
*** zioproto has quit IRC14:52
*** zioproto has joined #openstack-horizon14:52
*** btully has joined #openstack-horizon14:53
*** btully has quit IRC14:58
*** felipemonteiro has joined #openstack-horizon15:00
*** felipemonteiro_ has joined #openstack-horizon15:02
*** felipemonteiro has quit IRC15:06
*** dklyle has joined #openstack-horizon15:08
*** ChanServ sets mode: +o dklyle15:08
*** redondo-mk has quit IRC15:11
*** redondo-mk has joined #openstack-horizon15:12
*** wlmbasson has quit IRC15:12
*** wlmbasson has joined #openstack-horizon15:12
*** cshen has quit IRC15:17
*** germs has quit IRC15:21
*** germs has joined #openstack-horizon15:22
*** germs has quit IRC15:22
*** germs has joined #openstack-horizon15:22
*** dave-mccowan has quit IRC15:24
*** e0ne has quit IRC15:36
*** jtriley_ has joined #openstack-horizon15:38
*** jtriley has quit IRC15:41
*** gyee has joined #openstack-horizon15:45
*** gyee has quit IRC15:45
*** jtomasek has quit IRC15:53
*** tesseract has quit IRC15:58
*** felipemonteiro_ has quit IRC16:04
*** gyee has joined #openstack-horizon16:06
*** dims has quit IRC16:06
*** jtomasek has joined #openstack-horizon16:11
*** dims has joined #openstack-horizon16:11
*** jtomasek has quit IRC16:12
*** germs has quit IRC16:22
*** germs has joined #openstack-horizon16:23
*** germs has quit IRC16:23
*** germs has joined #openstack-horizon16:23
*** jtriley_ has quit IRC16:27
*** yamamoto has quit IRC16:31
*** jpich has quit IRC16:35
*** btully has joined #openstack-horizon16:42
*** jtriley has joined #openstack-horizon16:43
*** btully has quit IRC16:47
*** dklyle has quit IRC16:49
*** rmart04 has joined #openstack-horizon16:57
*** rmart04 has quit IRC16:58
*** jtriley has quit IRC17:07
*** pcaruana has quit IRC17:22
*** jtriley has joined #openstack-horizon17:24
*** e0ne has joined #openstack-horizon17:31
*** ChanServ sets mode: +o e0ne17:31
*** yamamoto has joined #openstack-horizon17:32
*** pcaruana has joined #openstack-horizon17:33
*** felipemonteiro_ has joined #openstack-horizon17:33
*** yamamoto has quit IRC17:38
*** felipemonteiro_ has quit IRC17:39
*** dklyle has joined #openstack-horizon18:04
*** ChanServ sets mode: +o dklyle18:04
*** dave-mccowan has joined #openstack-horizon18:07
*** pcaruana has quit IRC18:29
*** yamamoto has joined #openstack-horizon18:34
*** yamamoto has quit IRC18:38
*** gugl has joined #openstack-horizon18:40
*** marlinc_ has joined #openstack-horizon18:41
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: Use default Django test runner instead of nose  https://review.openstack.org/54429618:44
*** jtomasek has joined #openstack-horizon18:44
*** marlinc_ has quit IRC18:47
*** marlinc_ has joined #openstack-horizon18:55
*** marlinc_ has quit IRC18:56
*** harlowja has joined #openstack-horizon19:02
*** marlinc_ has joined #openstack-horizon19:06
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: Use default Django test runner instead of nose  https://review.openstack.org/54429619:07
*** yamamoto has joined #openstack-horizon19:34
*** marlinc has quit IRC19:36
*** imacdonn has quit IRC19:36
*** marlinc_ has quit IRC19:36
*** imacdonn has joined #openstack-horizon19:36
*** yamamoto has quit IRC19:39
*** marlinc has joined #openstack-horizon19:42
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: Use default Django test runner instead of nose  https://review.openstack.org/54429619:44
*** marlinc has quit IRC19:52
*** tsmith2 has quit IRC19:54
*** marlinc has joined #openstack-horizon20:02
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: Use default Django test runner instead of nose  https://review.openstack.org/54429620:10
*** btully has joined #openstack-horizon20:20
*** germs has quit IRC20:22
*** btully has quit IRC20:24
*** germs has joined #openstack-horizon20:25
*** germs has quit IRC20:25
*** germs has joined #openstack-horizon20:25
*** lajoskatona has quit IRC20:28
*** dave-mccowan has quit IRC20:32
*** yamamoto has joined #openstack-horizon20:36
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: Use default Django test runner instead of nose  https://review.openstack.org/54429620:37
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: Use default Django test runner instead of nose  https://review.openstack.org/54429620:39
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: Fix selenuim-headless tests  https://review.openstack.org/55846720:40
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: Fix selenuim-headless tests  https://review.openstack.org/55846720:40
*** yamamoto has quit IRC20:41
*** yamamoto has joined #openstack-horizon20:57
*** jtriley has quit IRC20:59
*** yamamoto has quit IRC21:04
*** felipemonteiro has joined #openstack-horizon21:06
*** lbragstad has quit IRC21:17
*** lbragstad has joined #openstack-horizon21:19
*** yamamoto has joined #openstack-horizon21:20
*** jtomasek has quit IRC21:21
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: Use default Django test runner instead of nose  https://review.openstack.org/54429621:23
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: Fix selenuim-headless tests  https://review.openstack.org/55846721:23
*** yamamoto has quit IRC21:25
*** e0ne has quit IRC21:25
*** jtriley has joined #openstack-horizon21:34
*** e0ne has joined #openstack-horizon21:35
*** ChanServ sets mode: +o e0ne21:35
*** yamamoto has joined #openstack-horizon21:41
*** yamamoto has quit IRC21:47
*** felipemonteiro_ has joined #openstack-horizon21:52
*** felipemonteiro has quit IRC21:55
*** felipemonteiro_ has quit IRC21:56
*** felipemonteiro_ has joined #openstack-horizon21:57
*** yamamoto has joined #openstack-horizon22:04
*** e0ne has quit IRC22:05
*** gyee has quit IRC22:06
*** yamamoto has quit IRC22:08
*** btully has joined #openstack-horizon22:08
*** btully has quit IRC22:13
*** yamamoto has joined #openstack-horizon22:24
*** felipemonteiro__ has joined #openstack-horizon22:26
*** yamamoto has quit IRC22:29
*** felipemonteiro_ has quit IRC22:29
*** felipemonteiro_ has joined #openstack-horizon22:30
*** felipemonteiro__ has quit IRC22:30
*** jtriley has quit IRC22:44
*** yamamoto has joined #openstack-horizon22:45
*** jtriley has joined #openstack-horizon22:46
*** jtriley has quit IRC22:51
*** yamamoto has quit IRC22:51
*** yamamoto has joined #openstack-horizon23:08
*** yamamoto has quit IRC23:12
*** tosky has quit IRC23:15
*** rcernin has joined #openstack-horizon23:15
*** yamamoto has joined #openstack-horizon23:20
*** felipemonteiro_ has quit IRC23:21
*** yamamoto has quit IRC23:32
*** yamamoto has joined #openstack-horizon23:33
*** jtriley has joined #openstack-horizon23:46
*** btully has joined #openstack-horizon23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!