Tuesday, 2018-03-20

*** jtriley has joined #openstack-horizon00:00
*** germs has joined #openstack-horizon00:01
*** germs has quit IRC00:01
*** germs has joined #openstack-horizon00:01
*** tosky has quit IRC00:04
*** germs has quit IRC00:05
*** ircuser-1 has joined #openstack-horizon00:12
*** itlinux has joined #openstack-horizon00:23
*** yamamoto has quit IRC00:26
*** yamamoto has joined #openstack-horizon00:28
*** yamamoto has quit IRC00:28
*** lifeless_ has joined #openstack-horizon00:46
*** lifeless has quit IRC00:46
openstackgerritMerged openstack/horizon master: Fix Angular errors in openstack_auth  https://review.openstack.org/55278900:50
*** itlinux has quit IRC00:51
*** wolverineav has quit IRC00:54
*** wolverineav has joined #openstack-horizon00:57
*** wolverineav has quit IRC01:03
*** lblanchard has quit IRC01:04
*** wolverineav has joined #openstack-horizon01:04
*** yamamoto has joined #openstack-horizon01:07
*** wolverineav has quit IRC01:11
*** jtriley has quit IRC01:22
*** felipemonteiro has quit IRC01:26
*** felipemonteiro has joined #openstack-horizon01:27
*** yamamoto has quit IRC01:27
*** jtriley has joined #openstack-horizon01:28
*** felipemonteiro has quit IRC01:46
*** dayou has quit IRC01:56
*** germs has joined #openstack-horizon02:02
*** germs has quit IRC02:06
*** wolverineav has joined #openstack-horizon02:08
*** jtriley has quit IRC02:12
*** Nil_ has quit IRC02:12
*** jtriley has joined #openstack-horizon02:24
*** dave-mccowan has quit IRC02:31
*** r-daneel has joined #openstack-horizon02:32
*** r-daneel_ has joined #openstack-horizon02:34
*** r-daneel has quit IRC02:36
*** r-daneel_ is now known as r-daneel02:36
openstackgerritXinni Ge proposed openstack/horizon master: Add plugin xstatic modules support  https://review.openstack.org/55225902:39
*** itlinux has joined #openstack-horizon02:42
*** wolverineav has quit IRC02:58
*** wolverineav has joined #openstack-horizon03:04
*** jtriley has quit IRC03:10
*** jtriley has joined #openstack-horizon03:13
*** dangtrinhnt_ has joined #openstack-horizon03:15
*** wolverineav has quit IRC03:18
*** wolverineav has joined #openstack-horizon03:22
*** dangtrinhnt_ has quit IRC03:25
openstackgerritMerged openstack/horizon master: Add angular create server group action  https://review.openstack.org/51775503:38
*** itlinux has quit IRC03:49
*** yamamoto has joined #openstack-horizon03:52
*** Coldblackice6NLV has joined #openstack-horizon03:55
openstackgerritMerged openstack/horizon master: Add angular delete server groups action  https://review.openstack.org/51775603:56
openstackgerritMerged openstack/horizon master: Add angular server group details page  https://review.openstack.org/51782403:56
openstackgerritMerged openstack/horizon master: Make size of Angular modal form specifiable  https://review.openstack.org/53733603:56
openstackgerritMerged openstack/horizon master: Fix layout of dialogs for Angularized users panel  https://review.openstack.org/53572303:56
openstackgerritMerged openstack/horizon master: Tabbify quota default panel  https://review.openstack.org/54010003:56
openstackgerritMerged openstack/horizon master: Update Django versions in horizon requirements  https://review.openstack.org/55362803:56
openstackgerritMerged openstack/horizon master: Update RHEL/CentOS horizon install instruction  https://review.openstack.org/55363103:56
*** yamamoto has quit IRC04:01
openstackgerritVu Cong Tuan proposed openstack/horizon master: Sahara projects have been migrated to Storyboard  https://review.openstack.org/55440904:02
*** germs has joined #openstack-horizon04:03
*** germs has quit IRC04:03
*** germs has joined #openstack-horizon04:03
*** yamamoto has joined #openstack-horizon04:04
*** germs has quit IRC04:07
*** yamamoto has quit IRC04:08
*** yamamoto has joined #openstack-horizon04:09
*** yamamoto has quit IRC04:14
*** wolverineav has quit IRC04:15
*** yamamoto has joined #openstack-horizon04:16
openstackgerritMerged openstack/horizon master: Sahara projects have been migrated to Storyboard  https://review.openstack.org/55440904:19
*** yamamoto has quit IRC04:27
*** yamamoto has joined #openstack-horizon04:28
*** wolverineav has joined #openstack-horizon04:42
*** yamamoto has quit IRC04:43
*** yamamoto has joined #openstack-horizon04:46
*** wolverineav has quit IRC05:00
*** wolverineav has joined #openstack-horizon05:01
openstackgerritAdrian Turjak proposed openstack/horizon master: Fix wrong setting name for SHOW_KEYSTONE_V2_RC  https://review.openstack.org/55441305:03
*** wolverineav has quit IRC05:05
*** masco has joined #openstack-horizon05:26
openstackgerritAkihiro Motoki proposed openstack/horizon master: Exclude nova-network quotas properly  https://review.openstack.org/53438605:27
*** btully has joined #openstack-horizon05:40
*** btully has quit IRC05:44
amotokiI decided to hold my feature patches until related mock conversion patches land. features will come later after mock migration05:53
*** germs has joined #openstack-horizon06:04
*** germs has quit IRC06:08
*** e0ne has joined #openstack-horizon06:21
*** ChanServ sets mode: +o e0ne06:21
*** Jack_Iv has joined #openstack-horizon06:22
*** Jack_Iv has quit IRC06:26
*** dayou has joined #openstack-horizon06:48
*** rcernin has quit IRC07:23
*** rcernin has joined #openstack-horizon07:24
*** rcernin has quit IRC07:24
openstackgerritAkihiro Motoki proposed openstack/horizon master: Update the doc links to the newest ones  https://review.openstack.org/55382507:25
openstackgerritOpenStack Proposal Bot proposed openstack/horizon master: Imported Translations from Zanata  https://review.openstack.org/55443307:29
*** pcaruana has joined #openstack-horizon07:34
*** lajoskatona has joined #openstack-horizon07:52
*** tesseract has joined #openstack-horizon08:00
*** namnh has joined #openstack-horizon08:01
*** germs has joined #openstack-horizon08:05
*** germs has quit IRC08:05
*** germs has joined #openstack-horizon08:05
*** jtomasek has joined #openstack-horizon08:05
*** rmart04 has joined #openstack-horizon08:07
*** priteau has joined #openstack-horizon08:08
*** germs has quit IRC08:08
openstackgerritMerged openstack/horizon master: Imported Translations from Zanata  https://review.openstack.org/55443308:18
*** dangtrinhnt has quit IRC08:23
*** redondo-mk has quit IRC08:30
*** redondo-mk has joined #openstack-horizon08:31
*** fbouliane has quit IRC08:31
*** fbouliane has joined #openstack-horizon08:33
*** e0ne has quit IRC08:33
openstackgerritMerged openstack/horizon master: Update the doc links to the newest ones  https://review.openstack.org/55382508:59
openstackgerritShu Muto proposed openstack/ui-cookiecutter master: Run tox on created plugin  https://review.openstack.org/55446109:02
*** jpich has joined #openstack-horizon09:07
openstackgerritShu Muto proposed openstack/horizon master: Avoid popup blocker after key-pair creation  https://review.openstack.org/55447109:16
*** tosky has joined #openstack-horizon09:21
amotokirdopiera: I cannot understand your comment https://review.openstack.org/#/c/534386/4/openstack_dashboard/api/nova.py09:26
rdopieraamotoki: did you commit that change by mistake?09:26
amotokirdopiera: the code around your comment exists before my patch.09:26
rdopieraamotoki: aah, you rebased?09:27
rdopierasorry, I didn't notice that09:27
rdopieraI just looked at differences between this and previous patches09:27
amotokirdopiera: yeah, rebased to address merge conflict :)09:27
rdopierasorry09:27
amotokinp09:27
amotokimock conversion gives me a lot of presents of merge conflicts :p09:28
rdopierayeah, that sucks09:28
rdopierabut mox sucks even worse09:28
amotokiyeah09:29
*** _glb has quit IRC09:30
*** glb has joined #openstack-horizon09:31
*** btully has joined #openstack-horizon09:33
*** glb has quit IRC09:50
*** glb has joined #openstack-horizon09:51
*** gleblanc has joined #openstack-horizon09:53
gleblanchello, here :)09:53
gleblancI encoutered this bug https://bugs.launchpad.net/horizon/+bug/1641383 but I have the patch ...09:54
openstackLaunchpad bug 1641383 in OpenStack Dashboard (Horizon) "Uploading OVA to Glance via Horizon Fails" [Low,Fix released] - Assigned to Jay Jahns (jjahns)09:54
*** e0ne has joined #openstack-horizon09:55
*** ChanServ sets mode: +o e0ne09:55
*** btully has quit IRC09:55
gleblancAnd after some digging I found that there is the same code at two location ... I don't really know if it's normal09:55
gleblancmaybe someone here can tell me if it is ?09:56
gleblanchttps://github.com/openstack/horizon/blob/master/openstack_dashboard/api/rest/glance.py#L30709:56
gleblanchttps://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/images/images/forms.py#L4709:56
*** yamamoto has quit IRC10:04
*** germs has joined #openstack-horizon10:05
*** germs has quit IRC10:05
*** germs has joined #openstack-horizon10:05
*** jtriley has quit IRC10:05
*** yamamoto has joined #openstack-horizon10:09
*** germs has quit IRC10:10
*** namnh has quit IRC10:10
*** yamamoto has quit IRC10:14
e0negleblanc: hi. code duplication is always not a good way10:20
rdopieraexcept for tests10:21
e0nerdopiera: we can minimize duplication even in tests too10:27
gleblancyes I agree eOne. as I'm not a django developper I don't know where the use of one or another of this function is defined, do you know ?10:30
e0negleblanc: what do you mean?10:30
*** mvk has quit IRC10:31
rdopierae0ne: that's usually not a good idea10:32
e0nerdopiera: why? could you please provide some example or more details10:33
rdopieragleblanc: those functions are not used in django, they are only used in horizon, and you can simply grep the source code for the function name10:33
gleblancThe two function, I mentionned above are not for test, no ?10:33
rdopierae0ne: code for a test should show all the steps that are being performed explicitly, if you start to refactor the common parts, you will end up with undreadable mess and tightly coupled tests, where changing one thing leads to changes everywhere10:35
rdopierae0ne: we have that in a few places, amotoki recently cleaned up a few10:36
e0nerdopiera: I understand your point10:36
e0nerdopiera: I mean that we can use setUp/cleanUp methods for tests10:37
e0nerdopiera: also we can use something like ddt or follow our current approach to create test data and have all checks in one place  like https://github.com/openstack/horizon/blob/b8919e19af994f3dcf7f12a94e381534104ca5c7/openstack_dashboard/test/unit/api/test_nova.py#L33210:40
rdopierae0ne: as long as the groupings make sense10:42
rdopierae0ne: but generally, the actions to be tested you want to keep explicit, even if they repeat10:42
gleblancAnd just for my information, do you know the difference between the file under horizon/openstack_dashboard/api/* and horizon/openstack_dashboard/dashboards/* ?10:43
rdopieragleblanc: the ones under api are for talking to the services, the ones under dashboards are for displaying the particular views10:46
*** mvk has joined #openstack-horizon10:46
amotokigleblanc: regarding to your specific question on create_image_metadata, i think it is just from historical reason10:50
amotokigleblanc: openstack_dashboard/api/*.py are API wrappers for backend services.10:50
amotokigleblanc: openstack_dashboard/api/rest/*.py provides REST API for horizon angular implemenattions.10:50
amotokigleblanc: openstack_dashboard/dashboards/*.py implement particular views using Django10:51
amotokigleblanc: ideally create_image_metadata() in two places should be moved to openstack_dashboard/api/glance.py IMHO10:52
gleblancOk, so if angular POST the form of an image of type OVA it will go in this file openstack_dashboard/api/rest/glance.py and fail.11:01
*** rcernin has joined #openstack-horizon11:02
openstackgerritdongjx proposed openstack/horizon master: Delete choice of image source when file is the only option  https://review.openstack.org/55450411:02
*** rcernin has quit IRC11:06
*** yamamoto has joined #openstack-horizon11:10
*** yamamoto has quit IRC11:12
*** yamamoto has joined #openstack-horizon11:12
openstackgerritAdrian Turjak proposed openstack/horizon master: Fix wrong setting name for SHOW_KEYSTONE_V2_RC  https://review.openstack.org/55441311:16
*** pcaruana has quit IRC11:23
*** dayou has quit IRC11:25
*** jtriley has joined #openstack-horizon11:39
*** yamamoto has quit IRC11:40
*** yamamoto has joined #openstack-horizon11:41
*** dayou has joined #openstack-horizon11:47
amotokie0ne: hopefully the team discusses xstatic-core in the team meeting http://lists.openstack.org/pipermail/openstack-dev/2018-March/thread.html#12853311:47
e0neamotoki: I didn't had a chance to read it yet:(11:48
amotokie0ne: no problem. I post some options in the last mail of the thread.11:51
*** pcaruana has joined #openstack-horizon11:55
*** dangtrinhnt has joined #openstack-horizon12:04
*** germs has joined #openstack-horizon12:06
*** germs has quit IRC12:06
*** germs has joined #openstack-horizon12:06
*** germs has quit IRC12:10
*** openstackgerrit has quit IRC12:33
*** r-daneel has quit IRC12:41
*** jtriley has quit IRC12:42
*** dangtrinhnt has quit IRC13:06
*** lblanchard has joined #openstack-horizon13:23
*** btully has joined #openstack-horizon13:29
*** r-daneel has joined #openstack-horizon13:32
*** btully has quit IRC13:33
*** r-daneel has quit IRC13:36
*** jtriley has joined #openstack-horizon13:41
*** lajoskatona has quit IRC13:59
*** lblanchard has quit IRC14:01
*** germs has joined #openstack-horizon14:07
*** germs has quit IRC14:07
*** germs has joined #openstack-horizon14:07
*** germs has quit IRC14:11
*** yamamoto_ has joined #openstack-horizon14:12
*** yamamoto has quit IRC14:12
*** pcaruana has quit IRC14:21
*** felipemonteiro has joined #openstack-horizon14:27
*** pcaruana has joined #openstack-horizon14:28
*** felipemonteiro_ has joined #openstack-horizon14:29
*** felipemonteiro has quit IRC14:32
*** openstackgerrit has joined #openstack-horizon14:35
openstackgerritGuillaume proposed openstack/horizon master: Allow OVA upload for images  https://review.openstack.org/55457214:35
*** Nil_ has joined #openstack-horizon14:35
gleblanchttps://review.openstack.org/554572, merge the create_image_metadata() and fix the OVA image upload. And thanks amotoki for file hierarchy explanation :)14:45
*** itlinux has joined #openstack-horizon14:50
*** r-daneel has joined #openstack-horizon14:55
amotokigleblanc: thanks for the patch. I added comments for minor improvements and clean up.14:57
*** masco has quit IRC14:59
gleblancamotoki: ok I will do that.15:03
openstackgerritGuillaume proposed openstack/horizon master: Allow OVA upload for images  https://review.openstack.org/55457215:16
*** yamamoto_ has quit IRC15:27
*** dave-mccowan has joined #openstack-horizon15:29
*** felipemonteiro_ has quit IRC15:48
*** felipemonteiro_ has joined #openstack-horizon15:49
*** felipemonteiro_ has quit IRC16:06
*** gyee has joined #openstack-horizon16:26
*** yamamoto has joined #openstack-horizon16:28
*** wolverineav has joined #openstack-horizon16:33
openstackgerritGuillaume proposed openstack/horizon master: Allow OVA upload for images  https://review.openstack.org/55457216:33
*** yamamoto has quit IRC16:34
*** wolverineav has quit IRC16:38
*** wolverineav has joined #openstack-horizon16:39
*** rmart04 has quit IRC16:42
*** mvk has quit IRC16:49
*** felipemonteiro has joined #openstack-horizon16:55
openstackgerritGuillaume proposed openstack/horizon master: Allow OVA upload for images  https://review.openstack.org/55457217:00
*** mvk has joined #openstack-horizon17:03
*** felipemonteiro_ has joined #openstack-horizon17:04
*** felipemonteiro has quit IRC17:08
*** felipemonteiro has joined #openstack-horizon17:08
*** felipemonteiro_ has quit IRC17:11
openstackgerritMerged openstack/horizon master: Add plugin xstatic modules support  https://review.openstack.org/55225917:25
*** priteau has quit IRC17:30
*** yamamoto has joined #openstack-horizon17:30
*** gleblanc has quit IRC17:32
*** e0ne has quit IRC17:35
*** yamamoto has quit IRC17:36
*** jpich has quit IRC17:50
*** wolverineav has quit IRC18:03
*** wolverineav has joined #openstack-horizon18:03
openstackgerritAdrian Turjak proposed openstack/horizon master: Fix wrong setting name for SHOW_KEYSTONE_V2_RC  https://review.openstack.org/55441318:22
*** harlowja has joined #openstack-horizon18:23
*** gyee has quit IRC18:30
*** dave-mccowan has quit IRC18:32
*** yamamoto has joined #openstack-horizon18:32
*** yamamoto has quit IRC18:37
*** dave-mccowan has joined #openstack-horizon18:45
*** btully has joined #openstack-horizon18:55
*** btully has quit IRC19:00
*** dave-mccowan has quit IRC19:03
*** rmart04 has joined #openstack-horizon19:15
*** rmart04 has quit IRC19:20
*** yamamoto has joined #openstack-horizon19:34
*** dave-mccowan has joined #openstack-horizon19:36
*** yamamoto has quit IRC19:39
*** e0ne has joined #openstack-horizon19:53
*** ChanServ sets mode: +o e0ne19:53
*** tesseract has quit IRC19:56
*** dave-mccowan has quit IRC20:03
*** dave-mccowan has joined #openstack-horizon20:04
*** germs has joined #openstack-horizon20:10
*** germs has quit IRC20:10
*** germs has joined #openstack-horizon20:10
*** germs has quit IRC20:13
openstackgerritMerged openstack/horizon master: Convert project tests into mock: cgroups/cg_snapshots  https://review.openstack.org/53172920:24
*** priteau has joined #openstack-horizon20:29
*** dave-mccowan has quit IRC20:31
*** openstackgerrit has quit IRC20:33
*** yamamoto has joined #openstack-horizon20:35
*** yamamoto has quit IRC20:41
*** felipemonteiro_ has joined #openstack-horizon20:51
*** felipemonteiro has quit IRC20:54
*** dave-mccowan has joined #openstack-horizon21:00
*** jtriley has quit IRC21:03
*** itlinux has quit IRC21:31
*** e0ne has quit IRC21:33
*** yamamoto has joined #openstack-horizon21:37
*** yamamoto has quit IRC21:43
*** openstackgerrit has joined #openstack-horizon21:53
openstackgerritMerged openstack/horizon master: Update docstring of test.helpers.create_mocks  https://review.openstack.org/54664821:53
*** germs has joined #openstack-horizon22:10
*** germs has quit IRC22:10
*** germs has joined #openstack-horizon22:10
*** rcernin has joined #openstack-horizon22:13
*** germs has quit IRC22:14
*** priteau has quit IRC22:15
*** priteau has joined #openstack-horizon22:15
*** dave-mccowan has quit IRC22:17
*** felipemonteiro_ has quit IRC22:18
*** priteau has quit IRC22:20
*** dave-mccowan has joined #openstack-horizon22:28
*** ianychoi__ is now known as ianychoi22:32
*** btully has joined #openstack-horizon22:33
*** btully has quit IRC22:37
*** yamamoto has joined #openstack-horizon22:39
*** yamamoto has quit IRC22:45
*** harlowja has quit IRC22:57
*** Anticime1 is now known as Anticimex23:29
*** tosky has quit IRC23:34
*** yamamoto has joined #openstack-horizon23:41
*** yamamoto has quit IRC23:46
*** harlowja has joined #openstack-horizon23:49
*** felipemonteiro has joined #openstack-horizon23:50

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!