Wednesday, 2018-03-14

*** kei-ichi has quit IRC00:02
*** kei-ichi has joined #openstack-horizon00:02
*** jtriley has joined #openstack-horizon00:07
*** jtriley has quit IRC00:13
*** germs has quit IRC00:15
*** jtriley has joined #openstack-horizon00:15
*** germs has joined #openstack-horizon00:17
*** gyee has quit IRC00:20
*** jtriley has quit IRC00:20
*** jtriley has joined #openstack-horizon00:24
*** jtriley has quit IRC00:29
*** felipemonteiro has joined #openstack-horizon00:32
*** germs has quit IRC00:32
*** jtriley has joined #openstack-horizon00:39
*** germs has joined #openstack-horizon00:42
*** germs has quit IRC00:42
*** germs has joined #openstack-horizon00:42
*** jtriley has quit IRC00:44
*** germs has quit IRC00:48
*** germs has joined #openstack-horizon00:49
*** jtriley has joined #openstack-horizon00:51
*** germs has quit IRC00:53
*** wolverineav has quit IRC00:56
*** jtriley has quit IRC00:57
*** wolverineav has joined #openstack-horizon00:57
*** wolverineav has quit IRC01:02
*** r-daneel has quit IRC01:02
*** jtriley has joined #openstack-horizon01:06
*** jtriley has quit IRC01:11
*** itlinux has quit IRC01:12
*** jtriley has joined #openstack-horizon01:14
*** harlowja has quit IRC01:20
*** jtriley has quit IRC01:20
*** jtriley has joined #openstack-horizon01:28
*** jtriley has quit IRC01:35
*** lblanchard has quit IRC01:38
*** jtriley has joined #openstack-horizon01:42
*** jtriley has quit IRC01:48
*** jtriley has joined #openstack-horizon01:50
*** jtriley has quit IRC01:55
*** jtriley has joined #openstack-horizon01:59
*** jtriley has quit IRC02:05
*** jtriley has joined #openstack-horizon02:09
*** jtriley has quit IRC02:19
*** germs has joined #openstack-horizon02:20
*** germs has quit IRC02:20
*** germs has joined #openstack-horizon02:20
*** r-daneel has joined #openstack-horizon02:26
*** gugl has quit IRC02:38
*** jtriley has joined #openstack-horizon02:40
*** germs has quit IRC02:43
*** germs has joined #openstack-horizon02:43
*** germs has quit IRC02:43
*** germs has joined #openstack-horizon02:43
*** jtriley has quit IRC02:47
*** germs has quit IRC02:48
*** jtriley has joined #openstack-horizon02:48
*** jtriley has quit IRC02:54
*** jtriley has joined #openstack-horizon03:05
*** shu-mutou has joined #openstack-horizon03:13
*** david-lyle has joined #openstack-horizon03:55
*** ChanServ sets mode: +o david-lyle03:55
*** namnh has joined #openstack-horizon04:09
*** harlowja has joined #openstack-horizon04:12
*** ianychoi_ has joined #openstack-horizon04:12
*** ianychoi has quit IRC04:15
*** wolverineav has joined #openstack-horizon04:17
*** dave-mccowan has quit IRC04:17
*** wolverineav has quit IRC04:21
*** btully has joined #openstack-horizon04:32
*** btully has quit IRC04:36
*** harlowja has quit IRC04:40
openstackgerritXinni Ge proposed openstack/horizon master: Add plugin xstatic modules support  https://review.openstack.org/55225904:52
openstackgerritXinni Ge proposed openstack/horizon master: Add plugin xstatic modules support  https://review.openstack.org/55225905:13
*** shu-mutou is now known as shu-mutow05:16
adriantIs horizon compressing ALL non-inline js?05:20
adriantBecause I'm trying to move some panel specific js out of inline into a file and that JS is now also being run on the login page...05:21
openstackgerritOpenStack Proposal Bot proposed openstack/horizon master: Updated from global requirements  https://review.openstack.org/55232605:30
*** jtriley has quit IRC05:52
*** e0ne has joined #openstack-horizon06:04
*** ChanServ sets mode: +o e0ne06:04
openstackgerritShu Muto proposed openstack/horizon master: Fix Angular errors in openstack_auth  https://review.openstack.org/55278906:08
adriantOk, yeah, that is weird and terrifying. All the js files in horizon are compressed.06:14
adriantThe login page appears to include random JS from everywhere because of it.06:14
adriantI've got a custom panel that has some js for rendering a QR code, and some onclick stuff, which we originally did in inline js, but I was trying to properly move it to js files but... I now have to check "is the thing I'm trying to bind to not null" and such. Which is find but is terrifying because that means ALL the js on the whole site is loading06:17
adriant at once and if there are any generic IDs or class stuff... then things just go weird.06:17
adriantIs something I'm doing broken or is this true?06:17
adriantrobcresswell, ying_zuo, amotoki: ^ for when any of you are in and about.06:17
*** jtriley has joined #openstack-horizon06:19
adriantI'm just terrified because it means that plugins which don't carefully make their ids and such unique in the JS will end up conflicting and attaching stuff to things in places that aren't expected. Not to mention we're then loading a hell of a load of extra JS in places that really really don't need all that JS evaluated and loaded because it isn't06:19
adriant related to that specific page... :/06:19
adriantIs this common practice?  i'm not a frontend/webdev so I honestly have no clue, but this sounds like madness to me.06:20
*** lajoskatona has joined #openstack-horizon06:23
*** jtriley has quit IRC06:24
*** jtriley has joined #openstack-horizon06:33
*** jtriley has quit IRC06:40
*** dims has quit IRC06:41
adriantoh, and because of how that works I've been technically importing one of my libraries twice... once in the html itself, and then again in the compressed js file because the horizon js compression does so based on the list of static files django returns... interesting.06:41
adriantI mean that is kind of handy. Just throw stuff into the static folder, and horizon will compress it, but that's also kind of messy and unclear :/06:42
*** dims has joined #openstack-horizon06:43
*** ianychoi__ has joined #openstack-horizon06:43
*** gary-smith_ has joined #openstack-horizon06:44
*** ianychoi_ has quit IRC06:46
*** gary-smith has quit IRC06:46
*** dims has quit IRC06:48
*** dims has joined #openstack-horizon06:49
adriantOH, it gets worse... and if I'm then rely on just the compressed js, I have no control over eval order other than alphabetical in my plugin. So I have to import/instantiate  the damn thing twice.06:50
adriantrelying* on06:50
*** ianychoi__ is now known as ianychoi06:51
adriantwhich is why we have addHorizonLoadEvent :/06:58
adriantI'm both terrified and impressed right now. All of this feels awful, and yet really clever at the same time. Mostly like some really clever people have written tooling around something that is heavily flawed, but also in it's own flawed way quite clever.07:00
* adriant is very conflicted right now07:00
*** pcaruana has joined #openstack-horizon07:04
*** jtriley has joined #openstack-horizon07:05
adriantfor the curious, the change I'm currently working on that spurred this: https://github.com/catalyst-cloud/adjutant-mfa/compare/new/no_inline_js07:11
openstackgerritOpenStack Proposal Bot proposed openstack/horizon master: Imported Translations from Zanata  https://review.openstack.org/55282007:40
*** masco has quit IRC07:50
*** masco has joined #openstack-horizon08:02
*** tesseract has joined #openstack-horizon08:14
robcresswelladriant: o/ In old school jQuery land, loading everything up front like that is fairly common, which is one of the reasons it has a reputation for spaghetti code :)08:23
*** btully has joined #openstack-horizon08:27
*** hoonetorg has quit IRC08:30
*** xinni9e has joined #openstack-horizon08:30
adriantrobcresswell: what just surprised me is that in the compressed js even on the login page is well... it looks like everything! including all the angular code :P08:30
robcresswellYeah, we've never done any splitting of that loading. It's all done up front.08:31
robcresswellI'm actually not working on Horizon any more fyi, so my knowledge will become increasingly out of date. I just have IRC running in case people want to ping me directly :)08:31
*** vladiskuz has joined #openstack-horizon08:32
*** xinni9e has quit IRC08:32
adriantI mean it works, just feels weird to deal with from the perspective of a plugin :P08:35
adriantrobcresswell: and bah! You will be missed, shan't ping you anymore then regarding horizon08:35
adriantdidn't realise you left horizon entirely08:35
*** jtriley has quit IRC08:35
robcresswelladriant: I'm happy to answer questions. Yeah I reduced my time a great deal a few months back, but then official dropped core duties about a month ago perhaps.08:36
robcresswellBut yeah, feel free to ping; I'll still help however I can08:37
*** e0ne has quit IRC08:37
openstackgerritShu Muto proposed openstack/horizon master: Fix Angular errors in openstack_auth  https://review.openstack.org/55278908:40
*** hoonetorg has joined #openstack-horizon08:44
openstackgerritMerged openstack/horizon master: Imported Translations from Zanata  https://review.openstack.org/55282008:45
*** btully has quit IRC08:47
*** darland has joined #openstack-horizon08:51
*** jtriley has joined #openstack-horizon09:01
*** jpich has joined #openstack-horizon09:04
*** shu-mutow has quit IRC09:14
*** yamamoto_ has joined #openstack-horizon09:18
*** yamamoto has quit IRC09:22
*** jtriley has quit IRC09:32
*** jtriley has joined #openstack-horizon09:37
*** tosky has joined #openstack-horizon09:41
*** jtriley has quit IRC09:45
*** jtriley has joined #openstack-horizon09:50
*** jtriley has quit IRC09:57
*** namnh has quit IRC10:00
*** jtriley has joined #openstack-horizon10:04
*** jtriley has quit IRC10:12
*** rcernin has quit IRC10:13
*** jtriley has joined #openstack-horizon10:15
*** jtriley has quit IRC10:23
*** watanabe_isao has joined #openstack-horizon10:23
*** priteau has joined #openstack-horizon10:26
*** jtriley has joined #openstack-horizon10:28
*** btully has joined #openstack-horizon10:33
*** jtriley has quit IRC10:35
*** btully has quit IRC10:38
*** jtriley has joined #openstack-horizon10:39
*** jtriley has quit IRC10:46
*** jtriley has joined #openstack-horizon10:50
*** belmoreira has joined #openstack-horizon10:56
*** jtriley has quit IRC10:57
*** jtriley has joined #openstack-horizon10:58
*** vladiskuz has quit IRC11:03
*** jtriley has quit IRC11:05
*** ianychoi has quit IRC11:07
*** jtriley has joined #openstack-horizon11:13
*** ianychoi has joined #openstack-horizon11:13
*** watanabe_isao has quit IRC11:14
*** jtriley has quit IRC11:20
*** lblanchard has joined #openstack-horizon11:21
*** jtriley has joined #openstack-horizon11:26
*** e0ne has joined #openstack-horizon12:01
*** ChanServ sets mode: +o e0ne12:01
*** masco has quit IRC12:03
*** kei-ichi has quit IRC12:08
*** kei-ichi has joined #openstack-horizon12:09
*** yamamoto_ has quit IRC12:17
*** yamamoto has joined #openstack-horizon12:18
*** dave-mccowan has joined #openstack-horizon12:32
*** yamamoto has quit IRC12:38
*** yamamoto has joined #openstack-horizon12:39
*** yamamoto has quit IRC12:44
*** jtriley has quit IRC12:50
*** jtriley has joined #openstack-horizon12:51
*** r-daneel has quit IRC12:53
*** yamamoto has joined #openstack-horizon12:55
*** jtriley has quit IRC12:58
*** yamamoto has quit IRC12:59
*** jtriley has joined #openstack-horizon13:01
openstackgerritMatt Riedemann proposed openstack/horizon master: Use microversion 2.60 when attaching a multiattach volume  https://review.openstack.org/54785613:07
*** jtriley has quit IRC13:08
*** jtriley has joined #openstack-horizon13:08
*** yamamoto has joined #openstack-horizon13:10
*** yamamoto has quit IRC13:15
*** jtriley has quit IRC13:17
*** felipemonteiro_ has joined #openstack-horizon13:23
*** yamamoto has joined #openstack-horizon13:25
*** e0ne has quit IRC13:25
*** yamamoto has quit IRC13:29
*** yamamoto has joined #openstack-horizon13:40
*** yamamoto has quit IRC13:44
*** felipemonteiro_ has quit IRC13:51
*** jtriley has joined #openstack-horizon13:52
*** yamamoto has joined #openstack-horizon13:54
*** yamamoto has quit IRC13:55
*** yamamoto has joined #openstack-horizon13:55
*** yamamoto has quit IRC13:55
*** germs has joined #openstack-horizon14:35
*** germs has quit IRC14:35
*** germs has joined #openstack-horizon14:35
*** jtriley has quit IRC14:36
*** mvk has quit IRC14:40
*** felipemonteiro_ has joined #openstack-horizon14:49
*** felipemonteiro__ has joined #openstack-horizon14:51
amotokizigo: you around?14:53
*** jtriley has joined #openstack-horizon14:53
*** germs has quit IRC14:55
*** felipemonteiro_ has quit IRC14:55
*** yamamoto has joined #openstack-horizon14:55
*** mvk has joined #openstack-horizon14:55
*** e0ne has joined #openstack-horizon14:58
*** ChanServ sets mode: +o e0ne14:58
*** yamamoto has quit IRC15:02
*** itlinux has joined #openstack-horizon15:12
*** germs has joined #openstack-horizon15:13
*** germs has quit IRC15:14
*** germs has joined #openstack-horizon15:15
*** germs has quit IRC15:15
*** germs has joined #openstack-horizon15:15
*** felipemonteiro__ has quit IRC15:34
*** felipemonteiro__ has joined #openstack-horizon15:35
*** e0ne has quit IRC15:43
*** jtriley has quit IRC15:47
*** jtriley has joined #openstack-horizon15:55
*** yamamoto has joined #openstack-horizon15:58
*** e0ne has joined #openstack-horizon15:58
*** ChanServ sets mode: +o e0ne15:58
*** lajoskatona has quit IRC16:00
*** felipemonteiro_ has joined #openstack-horizon16:01
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: Remove deprecated fix_auth_url_version function  https://review.openstack.org/55243216:01
*** felipemonteiro_ has quit IRC16:02
*** felipemonteiro_ has joined #openstack-horizon16:03
*** yamamoto has quit IRC16:04
*** felipemonteiro__ has quit IRC16:04
*** felipemonteiro__ has joined #openstack-horizon16:06
*** felipemonteiro_ has quit IRC16:09
*** r-daneel has joined #openstack-horizon16:15
*** felipemonteiro__ has quit IRC16:20
*** vladiskuz has joined #openstack-horizon16:48
*** tosky has quit IRC16:53
*** vladiskuz has quit IRC16:55
*** yamamoto has joined #openstack-horizon16:59
*** sapd_ has joined #openstack-horizon17:01
*** vladiskuz has joined #openstack-horizon17:04
*** sapd has quit IRC17:05
*** yamamoto has quit IRC17:05
*** jpich has quit IRC17:14
*** pcaruana has quit IRC17:18
*** e0ne has quit IRC17:20
openstackgerritAkihiro Motoki proposed openstack/horizon master: Switch project/admin routers tests to mock  https://review.openstack.org/53172517:46
*** lblanchard has quit IRC17:47
*** itlinux has quit IRC17:50
*** e0ne has joined #openstack-horizon17:53
*** ChanServ sets mode: +o e0ne17:53
*** wolverineav has joined #openstack-horizon17:57
*** itlinux has joined #openstack-horizon17:58
openstackgerritAkihiro Motoki proposed openstack/horizon master: Refactor futurist calls  https://review.openstack.org/52255618:00
*** yamamoto has joined #openstack-horizon18:01
*** wolverineav has quit IRC18:03
*** gyee has joined #openstack-horizon18:05
*** jtriley has quit IRC18:05
*** yamamoto has quit IRC18:06
*** wolverineav has joined #openstack-horizon18:09
*** harlowja has joined #openstack-horizon18:11
*** felipemonteiro_ has joined #openstack-horizon18:12
*** wolverineav has quit IRC18:14
*** felipemonteiro__ has joined #openstack-horizon18:15
*** e0ne has quit IRC18:16
*** felipemonteiro_ has quit IRC18:19
*** felipemonteiro__ has quit IRC18:30
*** felipemonteiro__ has joined #openstack-horizon18:30
*** jtriley has joined #openstack-horizon18:31
*** jtriley has quit IRC18:36
*** mvk has quit IRC18:41
*** wolverineav has joined #openstack-horizon18:43
*** jtriley has joined #openstack-horizon18:53
*** e0ne has joined #openstack-horizon18:54
*** ChanServ sets mode: +o e0ne18:54
*** itlinux_ has joined #openstack-horizon18:57
*** itlinux has quit IRC18:57
*** jtriley has quit IRC19:00
*** yamamoto has joined #openstack-horizon19:02
*** jtriley has joined #openstack-horizon19:02
*** yamamoto has quit IRC19:07
*** mvk has joined #openstack-horizon19:09
*** idlemind has joined #openstack-horizon19:14
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: Refactor futurist calls  https://review.openstack.org/52255619:16
e0neamotoki: ^^ I just changed comment a bit according devstack config19:16
*** jtriley has quit IRC19:19
*** tesseract has quit IRC19:20
openstackgerritMerged openstack/horizon master: Updated from global requirements  https://review.openstack.org/55232619:30
*** jtriley has joined #openstack-horizon19:35
*** e0ne has quit IRC19:36
*** itlinux_ has quit IRC19:40
*** e0ne has joined #openstack-horizon19:48
*** ChanServ sets mode: +o e0ne19:48
*** itlinux has joined #openstack-horizon19:52
*** yamamoto has joined #openstack-horizon20:03
*** yamamoto has quit IRC20:08
*** vladiskuz has quit IRC20:24
*** e0ne has quit IRC20:27
*** idlemind_ has joined #openstack-horizon20:44
*** idlemind_ has quit IRC20:44
*** idlemind has quit IRC20:44
openstackgerritAkihiro Motoki proposed openstack/horizon master: Move default settings to a separate module  https://review.openstack.org/55205420:59
openstackgerritAkihiro Motoki proposed openstack/horizon master: Improve mocking in REST API tests (test_glance)  https://review.openstack.org/55196220:59
*** yamamoto has joined #openstack-horizon21:04
*** rcernin has joined #openstack-horizon21:08
*** yamamoto has quit IRC21:10
*** btully has joined #openstack-horizon21:26
*** dave-mccowan has quit IRC21:26
*** btully has quit IRC21:31
*** dave-mccowan has joined #openstack-horizon21:33
*** itlinux has quit IRC21:40
*** belmoreira has quit IRC21:45
*** jtriley has quit IRC21:46
*** Matias has quit IRC21:57
*** Matias has joined #openstack-horizon21:59
*** wolverineav has quit IRC21:59
*** wolverineav has joined #openstack-horizon22:00
*** wolverineav has quit IRC22:01
*** wolverin_ has joined #openstack-horizon22:01
*** Matias has quit IRC22:04
*** yamamoto has joined #openstack-horizon22:06
*** yamamoto has quit IRC22:12
*** priteau has quit IRC22:15
*** felipemonteiro_ has joined #openstack-horizon22:20
*** e0ne has joined #openstack-horizon22:21
*** ChanServ sets mode: +o e0ne22:21
*** e0ne has quit IRC22:22
*** felipemonteiro__ has quit IRC22:23
*** isao_watanabe has joined #openstack-horizon22:28
*** marlinc has quit IRC22:44
*** dave-mccowan has quit IRC22:47
*** felipemonteiro_ has quit IRC22:49
*** yamamoto has joined #openstack-horizon23:07
*** wolverin_ has quit IRC23:09
*** wolverineav has joined #openstack-horizon23:10
*** wolverineav has quit IRC23:11
*** wolverin_ has joined #openstack-horizon23:11
*** yamamoto has quit IRC23:12
*** btully has joined #openstack-horizon23:14
*** btully has quit IRC23:19
*** david-lyle has quit IRC23:21
*** david-lyle has joined #openstack-horizon23:26
*** ChanServ sets mode: +o david-lyle23:26
*** david-lyle has quit IRC23:28
*** marlinc has joined #openstack-horizon23:30
*** david-lyle has joined #openstack-horizon23:30
*** ChanServ sets mode: +o david-lyle23:30
*** Matias has joined #openstack-horizon23:43
*** watanabe_isao has joined #openstack-horizon23:46
*** isao_watanabe has quit IRC23:46
*** itlinux has joined #openstack-horizon23:47

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!