Monday, 2018-03-12

*** Guest27 has joined #openstack-horizon00:05
*** Guest27 has quit IRC00:05
*** lblanchard has joined #openstack-horizon00:18
*** sapd has quit IRC00:19
*** itlinux has quit IRC00:39
*** tosky has quit IRC00:47
*** dayou has quit IRC01:06
*** dayou has joined #openstack-horizon01:07
*** sapd has joined #openstack-horizon01:58
*** lblanchard has quit IRC02:01
*** namnh has joined #openstack-horizon02:28
*** sapd has quit IRC02:55
*** sapd has joined #openstack-horizon02:55
*** shu-mutou-AWAY has quit IRC03:12
*** dave-mccowan has quit IRC03:38
*** btully has joined #openstack-horizon03:55
*** btully has quit IRC04:00
*** zhurong has joined #openstack-horizon04:06
*** masco has joined #openstack-horizon04:20
*** kei-ichi has quit IRC04:26
*** wolverineav has joined #openstack-horizon04:27
*** wolverineav has quit IRC04:27
*** wolverineav has joined #openstack-horizon04:28
*** wolverineav has quit IRC04:28
*** wolverineav has joined #openstack-horizon04:28
*** wolverineav has quit IRC04:30
*** wolverineav has joined #openstack-horizon04:31
*** wolverineav has quit IRC04:35
*** germs has joined #openstack-horizon05:06
*** germs has quit IRC05:06
*** germs has joined #openstack-horizon05:06
*** zhurong has quit IRC05:09
*** germs has quit IRC05:11
*** kei-ichi has joined #openstack-horizon05:13
*** david-lyle has quit IRC06:00
*** zhurong has joined #openstack-horizon06:06
*** david-lyle has joined #openstack-horizon06:07
*** ChanServ sets mode: +o david-lyle06:07
*** threestrands_ has joined #openstack-horizon06:26
*** amotoki_ has joined #openstack-horizon06:27
*** ChanServ sets mode: +v amotoki_06:27
*** BlackDex_ has joined #openstack-horizon06:30
*** threestrands has quit IRC06:34
*** Krenair has quit IRC06:34
*** BlackDex has quit IRC06:34
*** amotoki has quit IRC06:34
*** Krenair_ has joined #openstack-horizon06:35
*** lajoskatona has joined #openstack-horizon06:43
*** v12aml has quit IRC06:56
*** namnh has quit IRC06:57
*** v12aml has joined #openstack-horizon06:57
*** namnh has joined #openstack-horizon06:57
*** germs has joined #openstack-horizon07:07
*** germs has quit IRC07:07
*** germs has joined #openstack-horizon07:07
*** rcernin has quit IRC07:09
*** germs has quit IRC07:11
*** threestrands_ has quit IRC07:13
*** jafeha__ is now known as jafeha07:37
*** vladiskuz has joined #openstack-horizon07:55
*** pcaruana has joined #openstack-horizon07:56
*** tesseract has joined #openstack-horizon08:10
*** jtomasek has joined #openstack-horizon08:11
*** jtomasek has quit IRC08:13
*** jtomasek has joined #openstack-horizon08:14
*** tosky has joined #openstack-horizon08:31
*** hoonetorg has quit IRC08:36
*** hoonetorg has joined #openstack-horizon08:50
*** jpich has joined #openstack-horizon09:01
*** germs has joined #openstack-horizon09:08
*** germs has quit IRC09:08
*** germs has joined #openstack-horizon09:08
*** germs has quit IRC09:12
*** yamamoto has quit IRC10:02
*** namnh has quit IRC10:20
*** zhurong has quit IRC10:37
*** jadajada has joined #openstack-horizon10:41
jadajadaHi, can someone give me a simple explanation how role based authentication should work within Horizon? I can't make sense out of it. I have devstack running, to keep it as simple as possible. I have set "openstack.roles.admin" in a panel. My admin user has the right privileges, and I still get a "permission denied" error. Am I missing something?10:44
*** e0ne has joined #openstack-horizon10:52
*** ChanServ sets mode: +o e0ne10:52
*** yamamoto has joined #openstack-horizon11:03
*** openstackgerrit has joined #openstack-horizon11:08
openstackgerritAkihiro Motoki proposed openstack/horizon master: Improve mocking in REST API tests (test_keystone)  https://review.openstack.org/55196011:08
openstackgerritAkihiro Motoki proposed openstack/horizon master: Improve mocking in REST API tests (test_nova)  https://review.openstack.org/55196111:08
openstackgerritAkihiro Motoki proposed openstack/horizon master: Improve mocking in REST API tests (test_glance)  https://review.openstack.org/55196211:08
*** germs has joined #openstack-horizon11:08
*** germs has quit IRC11:08
*** germs has joined #openstack-horizon11:08
*** yamamoto has quit IRC11:11
*** germs has quit IRC11:13
*** yamamoto has joined #openstack-horizon11:14
openstackgerritAkihiro Motoki proposed openstack/horizon master: TabGroup: Make tabs pluggable via horizon plugin config  https://review.openstack.org/54009711:26
*** BlackDex_ is now known as BlackDex11:30
*** masco has quit IRC11:32
*** lajoskatona has quit IRC11:35
*** lajoskatona has joined #openstack-horizon11:49
openstackgerritAkihiro Motoki proposed openstack/horizon master: TabGroup: Make tabs pluggable via horizon plugin config  https://review.openstack.org/54009712:14
*** mvk has quit IRC12:21
*** yamamoto has quit IRC12:26
*** lvdombrkr has joined #openstack-horizon12:29
*** lblanchard has joined #openstack-horizon12:37
*** mvk has joined #openstack-horizon12:37
*** lblanchard has quit IRC12:43
*** flwang1 has quit IRC12:47
*** flwang1 has joined #openstack-horizon13:00
*** yamamoto has joined #openstack-horizon13:23
*** yamamoto has quit IRC13:28
*** dave-mccowan has joined #openstack-horizon13:30
openstackgerritVladislav Kuzmin proposed openstack/horizon master: Convert admin.instaces tests into mock  https://review.openstack.org/55201413:40
openstackgerritVladislav Kuzmin proposed openstack/horizon master: Convert admin.instances tests into mock  https://review.openstack.org/55201413:41
*** lblanchard has joined #openstack-horizon13:46
*** r-daneel has joined #openstack-horizon13:50
*** lblanchard has quit IRC13:53
*** yamamoto has joined #openstack-horizon13:53
*** yamamoto has quit IRC13:58
*** ianychoi has joined #openstack-horizon13:59
*** pcaruana has quit IRC14:01
openstackgerritVladislav Kuzmin proposed openstack/horizon master: Convert admin.info tests into mock  https://review.openstack.org/55202314:04
openstackgerritVladislav Kuzmin proposed openstack/horizon master: Convert admin.info tests into mock  https://review.openstack.org/55202314:07
openstackgerritAkihiro Motoki proposed openstack/horizon master: Switch test_quotas to mock  https://review.openstack.org/53193714:12
*** jtriley has joined #openstack-horizon14:15
*** pcaruana has joined #openstack-horizon14:15
*** lblanchard has joined #openstack-horizon14:30
*** pcaruana has quit IRC14:30
openstackgerritMerged openstack/horizon master: Switch project networks tests to mock  https://review.openstack.org/53193914:34
*** yamamoto has joined #openstack-horizon14:38
*** yamamoto has quit IRC14:43
*** pcaruana has joined #openstack-horizon14:43
openstackgerritMerged openstack/horizon master: Switch project instances tests to mock  https://review.openstack.org/54603014:49
*** yamamoto has joined #openstack-horizon14:53
*** yamamoto has quit IRC14:53
*** yamamoto has joined #openstack-horizon14:53
*** yamamoto has quit IRC14:58
openstackgerritAkihiro Motoki proposed openstack/horizon master: Move default settings to a separate module  https://review.openstack.org/55205415:17
amotoki_rdopiera: i would like to know your opinion on the above patch ^^15:18
amotoki_rdopiera: it allows us to refer the default settings like POLICY_FILES in local_settings.py.15:18
amotoki_horizon plugins can easily add their policy files to POLICY_FILES without copying the default values defined in horizon.15:19
*** Nil_ has joined #openstack-horizon15:19
*** yamamoto has joined #openstack-horizon15:26
*** felipemonteiro has joined #openstack-horizon15:31
*** yamamoto has quit IRC15:34
*** gyee has joined #openstack-horizon15:41
*** lblanchard has quit IRC15:42
*** jadajada has quit IRC15:42
rdopieraI will review it in a moment15:45
rdopieraamotoki_: I really don't like the name "opts"15:50
*** amotoki_ is now known as amotoki15:50
amotokirdopiera: apart from the naming, how about it?15:51
rdopierait looks like a great idea, actually15:51
amotokirdopiera: I don't think my choice of naming is good enough :p15:51
rdopierain fact, I would even move some of the logic from settings.py into defaults.py15:52
rdopierathe parts that don't depend on local settings15:52
rdopieraand then settings.py could only have the logic to load local_settings15:52
amotokirdopiera: yeah, totally agree.15:52
rdopierayou will also have problems with test setups15:52
rdopierawhich use their own settings.py15:53
rdopierawe could make a 'config' module, and put there defaults.py, utils/settings* and theme_settings.py and whatever is related15:54
rdopierabut that's not important15:54
amotokiI see several more steps: (1) move commented-out default values in local_settings to defaults.py,  (2) clean up getattr(settings, <something>, default>) pattern and define default values in defaults.py,15:54
rdopierathe tests' settings.py may be problematic15:55
amotokiperhaps during (2), test/settings.py needs to be revisit too as you mention.15:55
rdopierayeah15:55
amotoki'config' module sounds reasonable.15:56
rdopieraand then we can even add some logic to settings.py that raises warnings if there are any variables in local_settings.py that are not in defaults.py15:56
rdopieraideally, settings.py should only contain "from openstack_dashboard import config; config.load_config()"15:56
amotokiif we warn non-existing values, we need to care horizon plugin settings.15:57
rdopierayes, that's further work, I'm just looking too far ahead15:57
amotokiit will need more thought on defining default values15:57
rdopierabut this is a good first step15:58
amotokiwe are just brain-storming :)15:58
amotokiperhaps it helps our oslo.config migration too15:58
rdopierayes, definitely15:58
amotokihaving both 'config' and 'conf' might be confusing.... we use 'conf' directory in the same meaning as 'etc' dir in most projects, but it looks better to keep it as-is in a short term..16:00
rdopierawe can't call it "settings"16:01
rdopierawe could call it "settings_utils" or something16:02
amotokiwhat does 'it' mean?16:02
rdopiera"options" would also work better than "opts"16:02
rdopierathe module where to put all the settings-related code16:03
amotokiI see16:03
rdopieradefaults.py utils/settings.py utils/config.py theme_settings.py16:03
rdopieraand probably a bunch of others16:03
amotokidefaults.py can be split into several pieces: django settings, horizon settings and openstack_dashboard related16:04
amotokiso does 'defaults' makes more sense?16:05
amotokior 'settings'?16:05
rdopierait would still be nice to bring all that settings code all together16:05
rdopieraright now it's all over the place16:05
amotoki.... we can use 'settings' :p16:06
rdopierawe can just name it default_settings.py and put it alongside settings.py16:06
rdopierawe can't16:06
rdopierabecause it will then conflict with settings.py16:06
amotoki*can't*16:06
rdopierayou won't be able to import it16:07
amotokiyeah16:07
rdopiera"settings_" ;-)16:08
amotokifrom the nature of second language, i sometimes forget to add 'not' during thinking ...16:08
rdopieraI see16:08
amotokiperhaps defaults.py would be a good start.16:09
rdopierayeah16:09
rdopieralet's do that16:09
rdopieraone step at a time16:09
amotokismall steps helps us :)16:09
amotokiI will update it tomorrow16:10
rdopierait must be the middle of the night for you16:10
rdopieragoodnight16:10
amotokiyeah, it's 1am. due to the jet lag?, tz in my body is still a bit shifted later..16:11
amotokigood night. sleeping will help me adjusting timezone16:12
*** pcaruana has quit IRC16:12
*** lvdombrkr has quit IRC16:13
*** lajoskatona has quit IRC16:26
*** felipemonteiro has quit IRC16:31
*** felipemonteiro has joined #openstack-horizon16:31
*** yamamoto has joined #openstack-horizon16:32
*** yamamoto has quit IRC16:38
*** lblanchard has joined #openstack-horizon16:49
*** jtomasek has quit IRC16:51
*** jtomasek has joined #openstack-horizon16:58
*** jtomasek has quit IRC17:00
*** e0ne has quit IRC17:08
*** felipemonteiro_ has joined #openstack-horizon17:11
*** felipemonteiro has quit IRC17:14
*** felipemonteiro_ has quit IRC17:17
*** felipemonteiro_ has joined #openstack-horizon17:17
*** pcaruana has joined #openstack-horizon17:18
*** pcaruana has quit IRC17:27
*** jpich has quit IRC17:29
*** gugl has joined #openstack-horizon17:31
gugldavid-lyle, hi are you there?17:38
david-lylegugl, I'm here17:40
gugldavid-lyle, just want to check if you have any suggestions regarding fixing https://bugs.launchpad.net/horizon/+bug/1754133 it is caused by recent fix https://review.openstack.org/#/c/541676/ which injects the detail view at he top level when load SiteHorizon17:42
openstackLaunchpad bug 1754133 in OpenStack Dashboard (Horizon) "login page exception - hz-login-finder doesn't function because of horizon.app loading failure" [High,Confirmed] - Assigned to Gloria Gu (gloria-gu)17:42
*** wolverineav has joined #openstack-horizon17:43
guglI tried different ways.....but can not seem to satisfy fix both (fix refresh detail and fix login exception)17:45
guglwant to see if there is anyway to inject the anglar detail view at top level a little bit later17:46
*** itlinux has joined #openstack-horizon17:49
david-lylecatching up, what is the ngdetails page used for, just the details views on angular based pages or something else?17:51
*** r-daneel has quit IRC17:52
*** pcaruana has joined #openstack-horizon17:53
guglif you go to compute-> images, in the table, click image name link it will load the image detail, the but fix the problem when refresh that image detail page17:54
gugl*the bug fixes17:54
guglwithout https://review.openstack.org/#/c/541676, it will have 404 in my case, with it 404 is gone , but if get into login page it has exceptions in the F12 console, and WEBSSO won't not work correctly17:55
gugl*will not17:56
*** felipemonteiro__ has joined #openstack-horizon17:58
*** dave-mccowan has quit IRC18:00
*** felipemonteiro_ has quit IRC18:02
david-lyleI wonder if login should have a different base page, but also isn't the ngdetails something that could be tied to ng based pages rather than blanket?18:02
*** dave-mccowan has joined #openstack-horizon18:04
*** tesseract has quit IRC18:06
guglyeah...I tried to put the angluardetail view in images/images/urls.py to be loaded at component level, but...but it seems to stuck at the loading the details...no errors and no exceptions18:13
*** felipemonteiro__ has quit IRC18:15
*** felipemonteiro__ has joined #openstack-horizon18:16
-openstackstatus- NOTICE: Most jobs in zuul are currently failing due to a recent change to zuul; we are evaluating the issue and will follow up with a recommendation shortly. For the moment, please do not recheck.18:17
*** ChanServ changes topic to "Most jobs in zuul are currently failing due to a recent change to zuul; we are evaluating the issue and will follow up with a recommendation shortly. For the moment, please do not recheck."18:17
guglnow the link is like this....http://localhost:7788/project/images/ngdetails/OS::Glance::Image/63f5a2db-65db-4c9e-812e-9f0136f366e3/ need to figure out how the details view processed18:20
gugllooks like it only takes http://localhost:7788/ngdetails/OS::Glance::Image/63f5a2db-65db-4c9e-812e-9f0136f366e3/ if url injected at top level18:22
david-lylegugl, honestly that patch looks like a kludge18:27
*** jtomasek has joined #openstack-horizon18:28
david-lyleseems like there would be a better way to handle the page refresh action for ngdetails than dumping it into the top level18:28
david-lyleit's contaminating the horizon side with angular code18:29
gugldavid-lyle, I agree it is more of quick and dirty18:29
david-lyleeek, that was cherry-picked to stable/pike18:30
david-lyleI was going to say I would favor reverting it18:30
david-lylebut that's not really an option18:31
guglyeah...18:31
david-lyleI should be reviewing more I guess18:31
gugldavid-lyle, good idea :)18:31
david-lyleit's all about time18:31
guglyep18:32
guglso we can not revert it...need fix both , right?18:33
david-lyleunfortunately18:34
*** lbragstad has quit IRC18:35
guglso inject the url at the image/image/urls.py ...it requires some changes in all the related details view for components18:35
guglinjecting at component's urls.py level requires some more changes...plus there are some other problems18:37
*** ChanServ changes topic to "OpenStack Horizon | Rocky PTG: https://etherpad.openstack.org/p/horizon-ptg-rocky | Rocky-1 priorities: https://launchpad.net/horizon/+milestone/rocky-1 | Docs: https://docs.openstack.org/horizon/latest/"18:40
-openstackstatus- NOTICE: Zuul has been restarted without the breaking change; please recheck any changes which failed tests with the error "Accessing files from outside the working dir ... is prohibited."18:40
*** felipemonteiro_ has joined #openstack-horizon18:44
david-lylegugl, my first concern is the loss of architectural integrity especially to fix a very obscure problem18:46
david-lyleI did get another patch series recently to not break things in a similar way18:47
*** felipemonteiro__ has quit IRC18:48
david-lyleI'm not sure what the correct fix is, but introducing bandaids all over is going to make things very difficult moving forward as you are experiencing18:48
gugldavid-lyle, agree...18:49
*** harlowja has joined #openstack-horizon18:50
*** e0ne has joined #openstack-horizon18:51
*** ChanServ sets mode: +o e0ne18:51
gugle0ne, Hi18:52
gugle0ne, david-lyle and I are discussing how to process on https://bugs.launchpad.net/horizon/+bug/175413318:53
openstackLaunchpad bug 1754133 in OpenStack Dashboard (Horizon) "login page exception - hz-login-finder doesn't function because of horizon.app loading failure" [High,In progress] - Assigned to Gloria Gu (gloria-gu)18:53
*** lblanchard has quit IRC18:53
guglIt is caused by https://review.openstack.org/#/c/541676/18:54
guglit needs to refix...but not that easy18:54
*** lbragstad has joined #openstack-horizon18:55
*** lblanchard has joined #openstack-horizon18:58
*** openstackgerrit has quit IRC19:04
*** jtomasek has quit IRC19:07
*** Krenair_ is now known as Krenair19:21
*** Krenair has joined #openstack-horizon19:21
e0negugl: hi19:27
gugle0ne, hi19:28
e0negugl: thanks for work on it, I don't have an idea how to fix it at the moment(.19:29
gugle0ne, that is ok...I will keep trying19:32
e0nethanks. probably, I cloud take a look on it later this week19:33
guglok. any suggestion is welcome19:34
*** jtriley has quit IRC19:38
*** r-daneel has joined #openstack-horizon19:50
*** jtriley has joined #openstack-horizon19:51
*** vladiskuz has quit IRC19:52
*** r-daneel_ has joined #openstack-horizon20:00
*** mvk has quit IRC20:01
*** r-daneel has quit IRC20:02
*** r-daneel_ is now known as r-daneel20:02
*** lblanchard has quit IRC20:19
*** felipemonteiro_ has quit IRC20:37
*** felipemonteiro_ has joined #openstack-horizon20:37
*** gugl_ has joined #openstack-horizon20:38
*** gugl__ has joined #openstack-horizon20:41
*** gugl_ has quit IRC20:41
*** gugl__ has quit IRC20:45
*** tosky has quit IRC20:45
*** tosky has joined #openstack-horizon20:47
*** wolverineav has quit IRC20:51
*** wolverineav has joined #openstack-horizon20:52
*** wolverineav has quit IRC20:56
*** itlinux has quit IRC20:57
*** jtriley has quit IRC21:00
*** mvk has joined #openstack-horizon21:03
*** r-daneel_ has joined #openstack-horizon21:14
*** r-daneel has quit IRC21:16
*** r-daneel_ is now known as r-daneel21:16
*** openstackgerrit has joined #openstack-horizon21:22
openstackgerritMerged openstack/horizon master: TabGroup: Make tabs pluggable via horizon plugin config  https://review.openstack.org/54009721:22
*** jtriley has joined #openstack-horizon21:26
*** jtriley has quit IRC21:30
openstackgerritColleen Murphy proposed openstack/horizon master: WIP: Add support for application credentials  https://review.openstack.org/55214521:31
*** wolverineav has joined #openstack-horizon21:32
*** jtriley has joined #openstack-horizon21:33
*** pcaruana has quit IRC21:36
*** wolverineav has quit IRC21:36
*** jtriley has quit IRC21:38
*** wolverineav has joined #openstack-horizon21:39
*** jtriley has joined #openstack-horizon21:41
*** felipemonteiro__ has joined #openstack-horizon21:43
*** felipemonteiro_ has quit IRC21:46
*** kei-ichi has quit IRC21:48
*** Krenair has quit IRC21:51
*** kei-ichi has joined #openstack-horizon21:53
*** Krenair has joined #openstack-horizon21:56
*** yohoffman has joined #openstack-horizon21:59
*** e0ne has quit IRC22:13
*** jtriley has quit IRC22:15
*** idlemind has joined #openstack-horizon22:17
*** lblanchard has joined #openstack-horizon22:17
*** lblanchard has quit IRC22:19
*** rcernin has joined #openstack-horizon22:24
*** jtriley has joined #openstack-horizon22:36
*** felipemonteiro__ has quit IRC22:54
*** yamamoto has joined #openstack-horizon22:57
*** r-daneel has quit IRC23:12
openstackgerritAkihiro Motoki proposed openstack/horizon master: Ensure to show security groups only from current project  https://review.openstack.org/54560023:13
*** germs has joined #openstack-horizon23:14
*** germs has quit IRC23:14
*** germs has joined #openstack-horizon23:14
*** germs has quit IRC23:18
*** jtriley has quit IRC23:22
openstackgerritAkihiro Motoki proposed openstack/horizon master: Improve mocking in REST API tests (test_cinder)  https://review.openstack.org/54929023:28
openstackgerritAkihiro Motoki proposed openstack/horizon master: Cinder REST API test: Make list_extensions test work properly  https://review.openstack.org/55217923:28
*** r-daneel has joined #openstack-horizon23:39
*** tosky has quit IRC23:41
*** r-daneel has quit IRC23:44
*** r-daneel has joined #openstack-horizon23:46
*** jtriley has joined #openstack-horizon23:48
*** wolverineav has quit IRC23:50
*** itlinux has joined #openstack-horizon23:51
*** btully has joined #openstack-horizon23:52
*** wolverineav has joined #openstack-horizon23:52
*** jtriley has quit IRC23:53
*** btully has quit IRC23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!