Thursday, 2018-02-15

*** jtriley has quit IRC00:17
*** tosky has quit IRC00:50
*** dave-mccowan has joined #openstack-horizon00:54
*** r-daneel has quit IRC00:56
*** lbragstad has quit IRC01:45
*** itlinux has joined #openstack-horizon01:48
*** jtriley has joined #openstack-horizon02:42
*** harlowja has quit IRC03:08
*** itlinux has quit IRC03:37
*** yamamoto has joined #openstack-horizon03:47
*** yamamoto has quit IRC03:47
*** yamamoto has joined #openstack-horizon03:51
*** itlinux has joined #openstack-horizon04:00
*** jtriley has quit IRC04:02
*** gyee has quit IRC04:14
*** itlinux has quit IRC04:17
*** elod has quit IRC04:18
*** dave-mccowan has quit IRC04:25
*** elod has joined #openstack-horizon04:35
*** r-daneel has joined #openstack-horizon04:57
*** threestrands_ has joined #openstack-horizon05:09
*** threestrands_ has quit IRC05:09
*** threestrands_ has joined #openstack-horizon05:09
*** threestrands has quit IRC05:09
*** threestrands_ has quit IRC05:10
*** threestrands_ has joined #openstack-horizon05:11
*** harlowja has joined #openstack-horizon05:15
*** threestrands has joined #openstack-horizon05:15
*** threestrands has quit IRC05:15
*** threestrands has joined #openstack-horizon05:15
*** threestrands_ has quit IRC05:18
*** threestrands has quit IRC05:28
*** lajoskatona has joined #openstack-horizon05:39
*** wolverineav has joined #openstack-horizon05:41
*** wolverineav has quit IRC05:46
*** harlowja has quit IRC06:14
*** btully has joined #openstack-horizon06:16
*** masco has joined #openstack-horizon06:17
*** e0ne has joined #openstack-horizon06:20
*** btully has quit IRC06:21
*** e0ne has quit IRC06:30
*** rcernin has quit IRC06:44
*** e0ne has joined #openstack-horizon06:44
*** masco has quit IRC06:47
*** e0ne_ has joined #openstack-horizon06:51
*** e0ne_ has quit IRC06:55
*** e0ne has quit IRC06:55
*** hoonetorg has quit IRC06:56
*** e0ne has joined #openstack-horizon06:56
*** hoonetorg has joined #openstack-horizon06:57
*** masco has joined #openstack-horizon06:59
e0neamotoki: hi. are you going to restore https://review.openstack.org/#/c/528497/?07:03
amotokie0ne: I plan to restore it, but I would like to keep my patch list short so I wonder in which order I should restore patches...07:04
e0neI understand07:04
e0neI would like to use django 1.10 feature in my https://review.openstack.org/#/c/544296/07:05
amotokie0ne: i already have 24 pending changes. I can restore django 2.0 support and abandon ~10 open reviews instead07:05
amotokican mock patches be abandoned temporarily?07:05
e0neoh.. let me check them07:06
amotokifuturist refactoring is another candidate of such07:06
e0neI'll be in office in ~2 hours and will review your patched07:06
e0neoh.. futurist... I really want to get all futurist patches landed in R07:06
e0nethe idea is to restore your patch, send an announcement to the openstack-@dev and merge it early next week07:08
*** masco has quit IRC07:08
*** threestrands has joined #openstack-horizon07:09
*** threestrands has quit IRC07:09
*** threestrands has joined #openstack-horizon07:09
amotokie0ne: about django 2.0 series?07:09
amotokie0ne: I think we need rebase on top of the latest master07:10
e0neTBH, I didn't take a look on them yet07:10
e0neI'm OK with django2 support but I need to review that patches07:11
e0nebut I'll check mox-related first. that's my plan07:11
e0neamotoki: are you ok with it?07:12
amotokie0ne: mox-related series is a long way https://review.openstack.org/#/q/project:openstack/horizon+branch:master+topic:bp/mock-framework-in-unit-tests07:17
amotokie0ne: most of them are now abandoned. do you mean merging 4 opening reviews?07:18
e0neoh.. it's a hard choice07:19
amotokiI would like to gather volunteers who can continue my abandoned mox-related patches07:19
e0neamotoki: I can ask my colleague to help you07:19
amotokithere will be many conflicts because several patches landed and new mox tests were introduced07:20
e0neyea, I understand07:20
amotokithank you. I can restore them anytime someone wants to continue or help them. they can be co-author.07:21
e0nethanks07:21
e0neso let's start with mox and drop django <=1.10 support and see how it's going07:22
e0neamotoki: are you ok with this plan?07:22
amotokiokay with the plan07:23
e0neI'm removing old and non-supporting nose now. so I need to have django 1.10+ or to integrate stestr runner (it'll take more time for me)07:24
e0negreat07:24
*** rcernin has joined #openstack-horizon07:28
amotokican we use stestr as django test runner?07:30
amotokinosehtmloutpout is another ugly one07:30
amotokiI talked with the infra team half years ago and I am a core of nosehtmloutput, but I would like to push it away from horizon gate.07:31
amotokibut html output is useful. subunit2 support would be nice to generate html test output.07:31
amotokie0ne: I will rebase open mox-related reviews soon07:35
*** pcaruana has joined #openstack-horizon07:40
e0nethanks07:41
e0neI'll take a look on stestr today07:42
e0neneed to head to the office. bb in ~2 hours07:43
*** e0ne has quit IRC07:43
*** e0ne has joined #openstack-horizon07:43
*** e0ne has quit IRC07:49
*** belmoreira has joined #openstack-horizon07:55
*** eumel8 has joined #openstack-horizon08:03
*** btully has joined #openstack-horizon08:05
*** btully has quit IRC08:09
*** tesseract has joined #openstack-horizon08:17
*** lajoskatona has quit IRC08:30
openstackgerritAkihiro Motoki proposed openstack/horizon master: Provide a way to disable mox completely  https://review.openstack.org/53053808:36
openstackgerritAkihiro Motoki proposed openstack/horizon master: Minor fix on mock migrated tests  https://review.openstack.org/53162008:37
openstackgerritAkihiro Motoki proposed openstack/horizon master: Switch Nova API tests to mock  https://review.openstack.org/53053908:37
openstackgerritAkihiro Motoki proposed openstack/horizon master: Switch swift API tests to mock  https://review.openstack.org/53054008:37
*** lvdombrkr has joined #openstack-horizon08:49
*** lajoskatona has joined #openstack-horizon08:53
*** jpich has joined #openstack-horizon08:59
*** threestrands_ has joined #openstack-horizon09:21
*** threestrands has quit IRC09:21
*** masco has joined #openstack-horizon09:27
*** e0ne has joined #openstack-horizon09:37
*** lvdombrkr89 has joined #openstack-horizon09:42
*** lvdombrkr has quit IRC09:44
*** masco has quit IRC09:45
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: Make old django tests non-voting  https://review.openstack.org/52792409:46
*** ameeda has joined #openstack-horizon09:51
ameedaplease check this https://review.openstack.org/#/c/543231/. it prevent graph glitching every 10 seconds09:52
ameedaalso this https://review.openstack.org/#/c/539526/ , resolved generate new horizon dashboard09:52
*** vladiskuz_ has joined #openstack-horizon09:52
vladiskuz_amotoki: Hi! I can help to you with mox09:53
vladiskuz_What did you do? And what do we need to do?09:54
*** masco has joined #openstack-horizon09:59
*** tacco has joined #openstack-horizon10:11
taccoHi there. Is there a reason why i see all Stacks from all project as user with admin rights but not instances. example if i have a test and admin project i select test project and see only test instances but all stacks even admin stacks10:11
openstackgerritMerged openstack/horizon master: Minor fix on mock migrated tests  https://review.openstack.org/53162010:15
*** vladiskuz_ has quit IRC10:28
*** vladiskuz_ has joined #openstack-horizon10:46
*** tosky has joined #openstack-horizon10:48
*** e0ne has quit IRC10:51
*** priteau has joined #openstack-horizon10:59
*** e0ne has joined #openstack-horizon10:59
*** yamamoto has quit IRC11:01
*** yamamoto has joined #openstack-horizon11:06
amotokivladiskuz_: thanks for volunteering mox work.11:20
amotokivladiskuz_: there is a etherpad to track the effort11:20
amotokivladiskuz_: you can find the etherpad at the top of the whiteboard of https://blueprints.launchpad.net/horizon/+spec/mock-framework-in-unit-tests11:21
amotokivladiskuz_: I post several number of mock migration last month. you can find them at https://review.openstack.org/#/q/project:openstack/horizon+branch:master+topic:bp/mock-framework-in-unit-tests11:21
amotokivladiskuz_: I temporarily abandoned most of them. I can recover them and you can update them (of course I hope you add your name as co-author)11:22
*** vladiskuz_ has quit IRC11:22
amotokivladiskuz_: does it help you?11:22
*** e0ne has quit IRC11:24
openstackgerritAmeed Ashour proposed openstack/horizon master: Network Topology graph "twitches"  https://review.openstack.org/54323111:25
*** e0ne has joined #openstack-horizon11:31
amotokie0ne: I recovered django 2.0 support but almost all are merge conflict https://review.openstack.org/#/q/topic:bp/django2-support+(status:open+OR+status:merged)11:32
e0neamotoki: thanks! I reviewed   mox related patches which were not in merge conflict status11:33
e0neamotoki: I think, we have to make announcement in openstack-dev@ to notify plugins maintainers about supported django versions11:36
amotokie0ne: agree. my question is when we should announce it.11:37
e0nethere are 2 options:11:37
amotokie0ne: I am not sure horizon plugins can move the mirgation forward before horizon support lands.11:37
e0ne1) asap as we discussed it at the meeting few months earlier11:38
e0ne2) after more detailed discussion at PTG if needded11:38
amotokie0ne: IMHO we can announce it in two phaces11:39
amotoki*phases11:40
amotokithe first one is to announce Django 2.x support (I am not sure 2.0 only or 2.x) and drop DJango <1.11 support11:40
amotokiyou can reference my patch series as a pointer.11:40
amotokithe second announce is about readiness of horizon itself11:41
e0nesounds reasonable11:41
amotokiat the point of the first announce, the horizon approach might change (as they are under review)11:41
*** btully has joined #openstack-horizon11:43
e0neok. I'll send a mail later today11:45
*** btully has quit IRC11:47
amotokiperhaps I will resolve merge conflict next week11:47
e0necool. I'll try to help you with that11:48
e0neI'm hitting with stestr now11:48
e0neand my nose-removal patch requires django 1.10+11:49
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: Use default django test runner instead of nose  https://review.openstack.org/54429612:06
*** yamamoto has quit IRC12:09
*** dave-mccowan has joined #openstack-horizon12:10
*** yamamoto has joined #openstack-horizon12:22
*** e0ne has quit IRC12:29
*** yamamoto has quit IRC12:39
*** yamamoto has joined #openstack-horizon12:54
*** yamamoto has quit IRC13:05
*** wolverineav has joined #openstack-horizon13:06
*** wolverineav has quit IRC13:07
*** wolverineav has joined #openstack-horizon13:07
*** wolverineav has quit IRC13:12
*** lvdombrkr89 has quit IRC13:27
*** e0ne has joined #openstack-horizon13:54
*** yamamoto has joined #openstack-horizon14:00
*** dave-mccowan has quit IRC14:23
*** masco has quit IRC14:24
*** lbragstad has joined #openstack-horizon14:29
*** jtriley has joined #openstack-horizon14:35
*** threestrands_ has quit IRC14:39
*** yamamoto has quit IRC14:41
*** yamamoto has joined #openstack-horizon14:48
*** yamamoto has quit IRC14:53
*** TravT has joined #openstack-horizon14:59
*** rcernin has quit IRC15:01
*** lajoskatona has quit IRC15:09
*** r-daneel has quit IRC15:09
*** TravT has quit IRC15:10
*** mrch has joined #openstack-horizon15:11
*** dave-mccowan has joined #openstack-horizon15:14
*** btully has joined #openstack-horizon15:20
*** Nil_ has joined #openstack-horizon15:22
*** btully has quit IRC15:25
amotokie0ne: ping15:25
e0neyep15:25
amotokie0ne: I think it is better to add you to the horizon-stable team15:26
amotokie0ne: can you discuss it in the next team meeting (or the PTG)?15:26
e0neamotoki: there're no objections from my side15:26
e0neI can ask this question to ying_zuo on the next meeting15:27
e0neI was waiting until I'll officially become a PTL15:27
amotokie0ne: looking at https://review.openstack.org/#/admin/groups/537,members, the current members looks out-of-date15:27
amotokiin addition, perhaps the PTL needs to be a member of https://review.openstack.org/#/admin/groups/146,members15:28
e0nesounds reasonable15:29
e0neI don't know how it's working yet15:29
amotokie0ne: which one?15:29
e0neI mean, I don't know what is a procedure to add people to this team15:29
amotokie0ne: about the stable team and/or the release team?15:30
e0nerelease team15:30
amotokihttps://review.openstack.org/#/admin/projects/openstack/horizon,access might answer you15:30
amotokithe release team can approve patches around RC phase15:31
amotokionce a final release is cut, the stable team will approve it.15:31
*** yamamoto has joined #openstack-horizon15:33
*** eumel8 has quit IRC15:33
amotokibasically the release team would be a PTL.15:33
e0neamotoki: yes, it's described here: https://wiki.openstack.org/wiki/CrossProjectLiaisons#Release_management15:35
e0nehere is newer version of that wiki: https://docs.openstack.org/project-team-guide/release-management.html#release-liaisons15:37
amotokie0ne: in my understanding, the release liaisons are responsible to create releases.15:38
*** yamamoto has quit IRC15:38
amotokie0ne: mainly they are responsible to approves release patches in openstack/releases.15:38
amotokie0ne: BTW, could you check my comment in https://review.openstack.org/#/c/530538/5/horizon/test/helpers.py ?15:39
e0nesure, checking it15:39
*** dave-mccowan has quit IRC15:43
e0neamotoki: I answered you in the gerrit. I'm sorry, my first comment wasn't clear enough15:44
amotokie0ne: thanks. can we discuss mox deprecation a bit more here?15:47
amotokie0ne: I proposed use_mox attr to prevent from adding new mox tests to test classes which have migrated to mock.15:48
amotokie0ne: a question is who is the target of deprecation notice or TODO comment15:49
e0nesomething like15:49
e0ne# TODO(e0ne): remove use_mox attribute after mock migration complete15:50
amotokie0ne: if it is inside horizon, dropping mox from test-requirements is the final goal. but I am not sure about horizon plugins.15:50
*** felipemonteiro has joined #openstack-horizon15:50
e0neI refer explicit way to define that some code needs to be removed after some milestone15:50
*** felipemonteiro_ has joined #openstack-horizon15:51
e0neI think plugins can add mox requirements to themself if needed15:53
amotokiideally horizon succeed to push mox away in Rocky-1 and request horizon plugins to drop mox until rocky2 or add mox in their requirements if they cannot complete the goal.15:53
amotokiyeah, we are thinking similar15:53
e0neamotoki: +115:53
amotokithe announcement of requesting to drop mox can be earlier (like Rocky-1) as it is one of the community goal.15:54
amotokipersonally, I am in a dilemma between new features I am proposing and mox->mock migration.15:55
*** felipemonteiro has quit IRC15:55
amotokithey cannot be done in parallel. if mock migration can be done soon, I can wait to push new features.15:56
amotokii don't want to have a crunch time of resolving merge conflict again.15:57
*** r-daneel has joined #openstack-horizon15:58
e0neI understand16:01
e0nemy college vladiskuz will help you with this activity16:02
amotokiyeah, thanks for that. I shared some pointers in this IRC several hours ago.16:03
amotokiat some point it might be better to have a sprint to focus on reviewing/updating mock migration patches.16:04
e0ne+1. let's add this topic for the next meeting16:05
amotokiperhaps the same applies to django 2.0 testing16:05
e0neamotoki: btw, I would like to discuss meeting time at ptg to make it more comfortable for everyone16:05
amotokisounds good :)16:06
e0neI'm interesting in django2 support because it will help me with selenium-related patches16:06
amotokidjango2 support works well in my env two months ago16:07
e0neTBH, I would like to use native django tests tagging feature instead of skipping them via env variable16:07
e0neI mean this patch https://review.openstack.org/#/c/544296/16:07
e0neI still don't know how to make django tests working with stestr :(16:08
amotokiregarding test framework, I have no strong preference.16:08
amotokihopefully it would be nice if we can run tests in parallel16:08
e0neI would like to drop nose because it's unsupportable and it's bugs affects our CI16:09
e0neamotoki: damn, I forgot to add --parallel flag16:09
*** pcaruana has quit IRC16:09
amotokisubunit2 was introduced to support test output from parallel test run16:10
amotokie0ne: for (s)testr , i think stestr (or testr) support is not easy16:11
e0ne:(16:11
amotokiIIUC there is testtools dependency16:11
*** vladiskuz_ has joined #openstack-horizon16:13
amotokiwhen I chatted with infra folks, they thought the minimum line would be subunit2 support.16:13
amotokidjango provides its own testing wrapper of TestCase, so migrating testtools is not a simple thing16:13
amotokithat's the current understanding of the infra team and me.16:14
amotokiwe can generate html output from subunit2 data as most projects do.16:14
amotokiit was a discussion about nosehtmloutput16:14
e0nehtml reports are very helpful16:17
*** yamamoto has joined #openstack-horizon16:18
openstackgerritAkihiro Motoki proposed openstack/horizon master: Switch swift API tests to mock  https://review.openstack.org/53054016:20
*** yamamoto has quit IRC16:23
e0neamotoki: we've got some issues with unit tests - they hangs in a parallel mode:(16:26
e0neI'll take a closer look on this issue next week16:27
amotokie0ne: yeah, there seems dependencies on execution order in our unit tests16:27
e0ne:(16:27
amotokiif I run our unit tests partially, I sometimes get an error : AttributeError: 'AnonymousUser' object has no attribute 'service_catalog'16:28
e0neyes, I remember this issue16:28
amotokiit seems mock for a user object is not setup or cleanup properly...16:28
e0neneed to head away16:30
e0nebe back in ~4 hours16:30
*** e0ne has quit IRC16:37
*** tosky has quit IRC16:42
*** mrch has quit IRC16:45
*** masco has joined #openstack-horizon16:53
*** wolverineav has joined #openstack-horizon16:55
*** yamamoto has joined #openstack-horizon17:03
*** Matias_ has joined #openstack-horizon17:06
*** Matias_ is now known as Matias17:07
*** yamamoto has quit IRC17:08
*** wolverineav has quit IRC17:18
*** harlowja has joined #openstack-horizon17:19
*** wolverineav has joined #openstack-horizon17:19
*** pcaruana has joined #openstack-horizon17:20
*** wolverin_ has joined #openstack-horizon17:24
*** belmoreira has quit IRC17:27
*** wolverineav has quit IRC17:28
*** jpich has quit IRC17:32
*** yamamoto has joined #openstack-horizon17:32
*** yamamoto has quit IRC17:33
*** masco_ has joined #openstack-horizon17:34
*** wolverin_ has quit IRC17:34
*** masco has quit IRC17:34
*** wolverineav has joined #openstack-horizon17:35
*** wolverineav has quit IRC17:39
*** yamamoto has joined #openstack-horizon17:41
*** yamamoto has quit IRC17:46
*** itlinux has joined #openstack-horizon17:47
*** tesseract has quit IRC17:52
*** jtriley has quit IRC18:05
*** wolverineav has joined #openstack-horizon18:11
*** yamamoto has joined #openstack-horizon18:11
*** yamamoto has quit IRC18:16
*** masco_ has quit IRC18:31
*** yamamoto has joined #openstack-horizon18:35
*** yamamoto has quit IRC18:35
*** masco_ has joined #openstack-horizon18:44
*** jtriley has joined #openstack-horizon18:50
*** btully has joined #openstack-horizon18:58
*** harlowja has quit IRC19:00
*** btully has quit IRC19:02
*** wolverineav has quit IRC19:03
*** gyee has joined #openstack-horizon19:03
*** wolverineav has joined #openstack-horizon19:04
*** wolverineav has quit IRC19:08
*** felipemonteiro_ has quit IRC19:16
*** felipemonteiro_ has joined #openstack-horizon19:17
*** r-daneel has quit IRC19:27
*** harlowja has joined #openstack-horizon19:35
*** yamamoto has joined #openstack-horizon19:35
*** harlowja_ has joined #openstack-horizon19:37
*** harlowja has quit IRC19:39
*** vladiskuz_ has quit IRC19:42
*** yamamoto has quit IRC19:45
*** pcaruana has quit IRC20:03
*** e0ne has joined #openstack-horizon20:22
*** r-daneel has joined #openstack-horizon20:31
*** wolverineav has joined #openstack-horizon20:32
*** jtomasek has quit IRC20:34
*** e0ne has quit IRC20:38
*** e0ne has joined #openstack-horizon20:38
*** wolverineav has quit IRC20:45
*** wolverineav has joined #openstack-horizon20:45
e0neying_zuo: in case you missed it, looks like we need your +1 for this patch https://review.openstack.org/#/c/541809/1 (Retire horizon-cisco-ui project)20:48
*** wolverineav has quit IRC20:50
*** e0ne has quit IRC21:31
*** pcaruana has joined #openstack-horizon21:31
*** openstack has joined #openstack-horizon21:47
*** ChanServ sets mode: +o openstack21:47
*** pcaruana has quit IRC21:48
*** felipemonteiro_ has quit IRC21:48
*** rcernin has joined #openstack-horizon21:50
*** jtriley has quit IRC22:04
*** felipemonteiro__ has quit IRC22:09
*** felipemonteiro__ has joined #openstack-horizon22:10
*** belmoreira has joined #openstack-horizon22:11
*** priteau has quit IRC22:29
*** priteau has joined #openstack-horizon22:29
*** priteau has quit IRC22:34
*** felipemonteiro_ has joined #openstack-horizon22:35
*** btully has joined #openstack-horizon22:36
*** felipemonteiro__ has quit IRC22:40
*** btully has quit IRC22:40
*** threestrands has joined #openstack-horizon22:43
*** threestrands has quit IRC22:43
*** threestrands has joined #openstack-horizon22:43
*** itlinux has quit IRC23:09
*** belmoreira has quit IRC23:17
*** r-daneel has quit IRC23:24
*** felipemonteiro_ has quit IRC23:24
*** felipemonteiro_ has joined #openstack-horizon23:24
*** masco_ has quit IRC23:34

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!