Wednesday, 2017-12-27

*** ellopunk has quit IRC00:05
*** jtriley has joined #openstack-horizon00:05
*** jtriley has quit IRC00:11
*** vishwanathj has joined #openstack-horizon00:13
*** jtriley has joined #openstack-horizon00:16
*** btully has joined #openstack-horizon00:18
*** itlinux has quit IRC00:25
*** btully has quit IRC00:28
*** btully has joined #openstack-horizon00:36
*** ellopunk has joined #openstack-horizon00:37
*** ellopunk has quit IRC00:42
*** jtriley has quit IRC00:45
*** btully has quit IRC00:48
*** ellopunk has joined #openstack-horizon00:50
*** ellopunk has quit IRC00:58
*** zhurong has joined #openstack-horizon00:58
*** harlowja has quit IRC01:00
*** jtriley has joined #openstack-horizon01:11
*** jtriley has quit IRC01:16
*** jtriley has joined #openstack-horizon01:22
*** itlinux has joined #openstack-horizon01:33
*** jtriley has quit IRC01:50
*** wolverineav has joined #openstack-horizon02:01
*** wolverineav has quit IRC02:05
*** itlinux has quit IRC02:05
*** yamamoto has joined #openstack-horizon02:07
*** harlowja has joined #openstack-horizon02:07
*** itlinux has joined #openstack-horizon02:09
*** jtriley has joined #openstack-horizon02:16
*** jtriley has quit IRC02:21
*** itlinux has quit IRC02:28
*** jtriley has joined #openstack-horizon02:30
*** btully has joined #openstack-horizon02:35
*** itlinux has joined #openstack-horizon02:36
*** udesale has joined #openstack-horizon02:43
*** btully has quit IRC02:45
*** btully has joined #openstack-horizon02:52
*** ellopunk has joined #openstack-horizon02:53
*** ellopunk has quit IRC02:53
*** zhurong has quit IRC02:58
*** harlowja has quit IRC03:00
*** jtriley has quit IRC03:03
*** btully has quit IRC03:17
*** btully has joined #openstack-horizon03:24
*** jtriley has joined #openstack-horizon03:29
*** yamamoto has quit IRC03:31
*** jtriley has quit IRC03:34
*** jtriley has joined #openstack-horizon03:35
*** itlinux has quit IRC03:38
*** btully has quit IRC03:58
*** btully has joined #openstack-horizon04:03
*** yamamoto has joined #openstack-horizon04:08
*** ratailor has joined #openstack-horizon04:09
*** jtriley has quit IRC04:10
*** btully has quit IRC04:17
*** btully has joined #openstack-horizon04:22
*** itlinux has joined #openstack-horizon04:31
*** itlinux has quit IRC04:31
*** yamamoto has quit IRC04:33
*** yamamoto has joined #openstack-horizon04:34
*** btully has quit IRC04:35
*** jtriley has joined #openstack-horizon04:36
*** yamamoto has quit IRC04:40
*** jtriley has quit IRC04:41
*** jtriley has joined #openstack-horizon04:44
*** itlinux has joined #openstack-horizon04:47
*** btully has joined #openstack-horizon04:52
*** itlinux has quit IRC04:53
*** btully has quit IRC05:05
*** yamamoto has joined #openstack-horizon05:08
*** yamamoto has quit IRC05:08
*** yamamoto has joined #openstack-horizon05:10
*** masco has joined #openstack-horizon05:15
*** masco has quit IRC05:20
*** jtriley has quit IRC05:22
*** btully has joined #openstack-horizon05:23
*** fungi has quit IRC05:23
*** masco has joined #openstack-horizon05:24
openstackgerritwei.ying proposed openstack/horizon master: Fix batch delete key pairs button isn't disabled when the key pair has deleted  https://review.openstack.org/52993205:25
*** btully has quit IRC05:34
*** btully has joined #openstack-horizon05:38
*** itlinux has joined #openstack-horizon05:40
*** zhurong has joined #openstack-horizon05:47
*** jtriley has joined #openstack-horizon05:48
*** btully has quit IRC05:49
*** fungi has joined #openstack-horizon05:51
*** zhurong has quit IRC05:52
*** jtriley has quit IRC05:53
*** btully has joined #openstack-horizon05:55
*** jtriley has joined #openstack-horizon05:57
*** zhurong has joined #openstack-horizon06:00
*** btully has quit IRC06:04
*** e0ne has joined #openstack-horizon06:23
*** btully has joined #openstack-horizon06:26
*** btully has quit IRC06:37
*** jtriley has quit IRC06:42
*** e0ne has quit IRC06:44
*** jtriley has joined #openstack-horizon07:08
*** masco has quit IRC07:10
*** jtriley has quit IRC07:13
*** jtriley has joined #openstack-horizon07:14
*** shu-mutou has quit IRC07:18
*** shu-mutou has joined #openstack-horizon07:19
*** itlinux has quit IRC07:33
*** btully has joined #openstack-horizon07:35
*** btully has quit IRC07:48
*** btully has joined #openstack-horizon07:53
*** cshen has joined #openstack-horizon07:54
*** e0ne has joined #openstack-horizon07:55
*** yamamoto has quit IRC08:02
*** jtriley has quit IRC08:04
*** btully has quit IRC08:05
*** shu-mutou is now known as shu-mutou-AWAY08:07
*** e0ne has quit IRC08:23
*** jtriley has joined #openstack-horizon08:29
*** btully has joined #openstack-horizon08:29
*** jtriley has quit IRC08:34
*** jtriley has joined #openstack-horizon08:37
*** btully has quit IRC08:45
*** btully has joined #openstack-horizon08:52
*** yamamoto has joined #openstack-horizon09:02
*** btully has quit IRC09:05
*** zhurong has quit IRC09:07
*** yamamoto has quit IRC09:09
*** btully has joined #openstack-horizon09:23
*** btully has quit IRC09:27
*** jtriley has quit IRC09:37
*** yamamoto has joined #openstack-horizon09:54
*** wolverineav has joined #openstack-horizon10:02
*** jtriley has joined #openstack-horizon10:03
*** wolverineav has quit IRC10:07
openstackgerritAkihiro Motoki proposed openstack/horizon master: Handle binding__host_id conditionally  https://review.openstack.org/50584210:13
openstackgerritAkihiro Motoki proposed openstack/horizon master: Make enabled filenames consistent  https://review.openstack.org/51056310:13
openstackgerritAkihiro Motoki proposed openstack/horizon master: Allow regular users to specify VNIC type for port  https://review.openstack.org/51388710:13
*** e0ne has joined #openstack-horizon10:15
openstackgerritAkihiro Motoki proposed openstack/horizon master: Support "Get me a network" in launch instance  https://review.openstack.org/51408410:17
*** yamamoto has quit IRC10:18
*** btully has joined #openstack-horizon10:28
*** btully has quit IRC10:39
*** mrch has joined #openstack-horizon10:53
*** jtriley has quit IRC10:55
e0neamotoki: thanks for the review! I think, I have to propose some guidelines how to we migrate to mock11:04
*** yamamoto has joined #openstack-horizon11:05
*** yamamoto has quit IRC11:09
*** yamamoto has joined #openstack-horizon11:11
amotokie0ne: you're welcome. I try to be a man who complains a lot for better options :)11:15
e0neamotoki: it's great! I like such kind of reviews11:16
e0neTHB, it's easier to me to re-write tests to mock and https://review.openstack.org/#/c/238189/ than fixing that with mox:(11:17
*** jtriley has joined #openstack-horizon11:20
*** jtriley has quit IRC11:25
*** ratailor has quit IRC11:30
*** yamamoto has quit IRC11:30
*** jtriley has joined #openstack-horizon11:33
*** yamamoto has joined #openstack-horizon11:34
amotokie0ne: yeah, debuging mock failure is easier to debug mox failure (precisely, mox3)11:35
*** yamamoto has quit IRC11:51
*** wolverineav has joined #openstack-horizon12:07
*** yamamoto has joined #openstack-horizon12:13
*** Brin has joined #openstack-horizon12:35
*** jtriley has quit IRC12:50
*** bttully has joined #openstack-horizon12:54
*** frdm has quit IRC12:56
*** frdm has joined #openstack-horizon12:58
e0neamotoki: +1. especially, when it works only with py3513:07
*** Brin has quit IRC13:14
*** jtriley has joined #openstack-horizon13:16
*** bttully has quit IRC13:18
*** jtriley has quit IRC13:21
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: Switch Glance API tests to mock  https://review.openstack.org/53010313:23
*** bttully has joined #openstack-horizon13:23
*** jtriley has joined #openstack-horizon13:25
*** bttully has quit IRC13:28
*** btully has joined #openstack-horizon13:53
*** btully has quit IRC14:15
*** jtriley has quit IRC14:20
*** jtriley has joined #openstack-horizon14:21
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: Switch Glance-related tests (dashboards.admin.images) to mock  https://review.openstack.org/53011214:25
*** btully has joined #openstack-horizon14:29
*** Nil_ has quit IRC14:37
*** Nil_ has joined #openstack-horizon14:40
*** btully has quit IRC14:41
*** yamamoto_ has joined #openstack-horizon14:43
*** yamamoto has quit IRC14:47
*** udesale has quit IRC14:51
*** udesale has joined #openstack-horizon14:52
*** btully has joined #openstack-horizon14:55
*** udesale has quit IRC14:56
openstackgerritAkihiro Motoki proposed openstack/horizon master: Refactor futurist calls  https://review.openstack.org/52255614:56
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: Switch Glance API tests to mock  https://review.openstack.org/53010314:59
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: Switch Glance-related tests (dashboards.admin.images) to mock  https://review.openstack.org/53011215:01
*** ellopunk has joined #openstack-horizon15:03
*** btully has quit IRC15:06
e0neamotoki, robcresswell: I appreciate if you could take a look on https://review.openstack.org/#/c/522268/15:21
e0neying_zuo: ^^15:22
amotokie0ne: new year holiday season is starting tomorrow here. will be inactive :)15:23
e0neamotoki: I'm sorry, I think you feel uncomfortable a bit to +2 on that patch too15:23
e0neI like these days: almost 2 weeks without meeting and a lot of time for coding15:23
amotokie0ne: I wonder how we can move this forward. I am the original author and you are co-author. does double check by both of us sound reasonable to you?15:24
amotokie0ne: I just wait for your +2. dead lock :(15:25
e0neyes, but I'm still feeling a bit uncomfortable approving such patches15:25
amotokiIIRC, the only thing in question in the patch is https://review.openstack.org/#/c/522268/4/openstack_dashboard/test/test_plugins/panel_tests.py@6715:27
e0nehttps://github.com/openstack/horizon/blob/58e18f0790b6c2d8147fd5d112ad531d8bbdaeeb/openstack_dashboard/test/unit/test_error_pages.py#L3415:28
e0nelooks like commit message https://github.com/openstack/horizon/commit/3488ab3d40f90e9d01598912f7ee398c823f4385 describes why do we need it15:29
e0neI believe, robcresswell can provide more arguments after the Christmas holodays15:30
rdopierabut why did it only surface after removing the +x permission?15:35
e0nenosetests ignores tests in files with +x attribute15:36
*** btully has joined #openstack-horizon15:36
rdopieraoh, so it never ran?15:36
e0neyep15:36
rdopieraI'm surprised it's the only problem then15:36
* e0ne listening 'sad but true'15:36
rdopierawhy aren't we using py.test again?15:36
e0neI think, the answer is: because nobody did it :(15:37
rdopieraI think that vsteiner was working on switching to pytest all over openstack15:38
rdopieraat some point anyways15:38
e0nenose is not supported anymore, so I'm all for removing it15:39
rdopieraI think pytest can even run nose tests15:39
rdopieraI will look into that15:39
e0negrea, thanks15:39
e0ne*great15:39
rdopieraI'm still looking at the selenium test15:41
rdopierano progress on that15:41
*** btully has quit IRC15:48
e0nedo you mean this patch https://review.openstack.org/#/c/524431/2?15:49
*** itlinux has joined #openstack-horizon15:52
*** btully has joined #openstack-horizon15:52
rdopierano, I didn't see it15:56
rdopieraI was working on getting them to work again15:56
rdopierabut I guess if we are getting rid of them, then I can work on something else15:57
*** itlinux has quit IRC16:00
*** yamamoto_ has quit IRC16:00
*** yamamoto has joined #openstack-horizon16:07
e0neI'm interested in them too16:08
*** btully has quit IRC16:09
*** yamamoto has quit IRC16:12
rdopierathey could potentially save a lot of work testing16:12
amotokiwhat is 'pytest'? is this the one? https://docs.pytest.org/en/latest/16:13
rdopieraamotoki: yes16:13
amotokialmost all openstack projects switched to testtools now and I think horizon related projects are the only exception16:14
rdopieratesttools?16:14
amotokiI think testtools + stestr16:14
amotokitesttools is an enhancement of unit test and stestr is a test runner16:15
rdopierayou mean unittest, the ancient thing ported from Java that is in the python's standard library?16:16
amotokirdopiera: yes, unittest + unittest2 (in python)16:16
rdopieraI think we are using nose manily because of the django integration16:17
amotokiexactly16:17
amotokiso perhaps I should mention stestr (or testr) when we talk about 'nose'. you talked about test runner.16:18
e0nerdopiera: +++16:18
e0nerdopiera: we've got some internal test framework to test horizon but we would like to switch to upstream one16:19
*** btully has joined #openstack-horizon16:20
amotokithe current nosetest has no good support for subunit2 testing output interface (which handles parallel testing well).16:20
e0nerdopiera: if current tests covers main of our needs, I can try to find some resources to fix them and contribute new test scenarios16:21
rdopieraamotoki: I thought we are using testr already?16:21
amotokirdopiera: no we haven't. it is an alternative of nose16:21
amotokirdopiera: for other projects, yes16:22
rdopieraI'm sure I saw some stuff related to testr in the repo16:22
*** yamamoto has joined #openstack-horizon16:22
rdopieraI remember being super-confused about why we even need it16:23
amotokisomeone tried to use testr, but it turned out django integration with testr is required and it was gave up16:23
amotokithat's my understanding16:23
rdopieraI guess it's gone now after moving to tox16:23
rdopierafrom runtests.sh16:24
amotokigood cleanup :)16:24
rdopierapytest does have something https://pytest-django.readthedocs.io/en/latest/16:25
rdopieramight be easier, becuase it would also run the nose tests normally16:26
rdopieraand we could get rid of nose dependency then16:26
rdopieraI need to try it16:27
*** yamamoto has quit IRC16:27
amotokiit would be very nice if pytest supports parallel testing and subunit version 2 interface https://pypi.python.org/pypi/python-subunit16:27
rdopierahttps://pytest-django.readthedocs.io/en/latest/faq.html#does-pytest-django-work-with-the-pytest-xdist-plugin16:28
rdopieralooks like it does16:28
rdopierahttps://pypi.python.org/pypi/pytest-subunit/0.0.716:29
rdopieraŁukasz Oleś!16:29
rdopieraa collegue from two jobs ago16:29
amotokioh nice.  if we have subunit output, the infra job generates a html result like http://logs.openstack.org/06/530106/4/check/openstack-tox-py27/082878e/16:30
amotokiso we can get rid of nosehtmloutput too16:30
amotokias a quick look, pytest looks like more modern test runner than nose16:33
rdopierait's done by the pypy people16:33
rdopierawho are generally very smart :)16:33
openstackgerritAkihiro Motoki proposed openstack/horizon master: Refactor futurist calls  https://review.openstack.org/52255616:33
amotokiyeah agree16:34
rdopieraI will try to see how much work it would actually be to switch16:34
rdopieraby the way, tox is done by the same author16:34
rdopierait was created for pytest specifically16:35
*** yamamoto has joined #openstack-horizon16:38
*** logan- has quit IRC16:38
*** logan- has joined #openstack-horizon16:38
*** yamamoto has quit IRC16:42
*** yamamoto has joined #openstack-horizon17:07
*** yamamoto has quit IRC17:12
*** yamamoto has joined #openstack-horizon17:22
*** yamamoto has quit IRC17:22
*** btully has quit IRC17:31
*** jtriley has quit IRC17:35
*** btully has joined #openstack-horizon17:39
*** btully has quit IRC17:51
*** btully has joined #openstack-horizon17:54
openstackgerritMerged openstack/horizon master: Switch Glance API tests to mock  https://review.openstack.org/53010317:54
openstackgerritMerged openstack/horizon master: Switch Glance-related tests (dashboards.admin.images) to mock  https://review.openstack.org/53011217:57
*** harlowja has joined #openstack-horizon18:02
*** btully has quit IRC18:03
*** jtriley has joined #openstack-horizon18:14
*** e0ne has quit IRC18:18
*** jtriley has quit IRC18:19
*** yamamoto has joined #openstack-horizon18:22
*** btully has joined #openstack-horizon18:22
rdopiera======================================================================= 488 passed, 70 skipped, 6 warnings in 6.57 seconds =======================================================================18:25
rdopierathis is pytest running the opestack_dashboard tests18:26
rdopierait fails on horizon and openstack_auth tests, though -- some connection errors, looks like not everything gets mocked18:26
*** yamamoto has quit IRC18:28
*** btully has quit IRC18:33
*** Nil_ has quit IRC18:36
*** Nil_ has joined #openstack-horizon18:36
rdopierahmm, problem is, with nose it runs 1444 tests...18:39
*** itlinux has joined #openstack-horizon19:04
*** zioproto has quit IRC19:12
*** andrewbogott has quit IRC19:13
*** DuncanT has quit IRC19:13
*** wlmbasson has quit IRC19:13
*** e0ne has joined #openstack-horizon19:13
*** betherly has quit IRC19:13
*** mrhillsman has quit IRC19:13
*** hogepodge has quit IRC19:13
*** AndyWojo has quit IRC19:13
*** johnsom has quit IRC19:13
*** ying_zuo has quit IRC19:13
*** robcresswell has quit IRC19:14
*** ameade has quit IRC19:14
*** cargonza has quit IRC19:14
*** kong has quit IRC19:14
*** berendt has quit IRC19:14
*** rwellum has quit IRC19:14
*** mnaser has quit IRC19:14
*** coreycb has quit IRC19:14
*** dham1 has quit IRC19:14
*** serverascode has quit IRC19:14
*** yamamoto has joined #openstack-horizon19:24
*** ircuser-1 has joined #openstack-horizon19:29
*** yamamoto has quit IRC19:29
*** itlinux has quit IRC19:32
*** itlinux has joined #openstack-horizon19:35
*** ameade has joined #openstack-horizon19:36
*** kong has joined #openstack-horizon19:40
*** mnaser has joined #openstack-horizon19:40
*** betherly has joined #openstack-horizon19:41
*** andrewbogott has joined #openstack-horizon19:41
*** mrhillsman has joined #openstack-horizon19:42
*** serverascode has joined #openstack-horizon19:42
*** AndyWojo has joined #openstack-horizon19:43
*** cargonza has joined #openstack-horizon19:43
*** coreycb has joined #openstack-horizon19:43
*** DuncanT has joined #openstack-horizon19:44
*** johnsom has joined #openstack-horizon19:45
*** dham1 has joined #openstack-horizon19:48
*** wlmbasson has joined #openstack-horizon19:50
*** ellopunk has quit IRC19:51
*** ellopunk has joined #openstack-horizon19:53
*** hogepodge has joined #openstack-horizon19:53
*** ellopunk has quit IRC19:53
*** ellopunk has joined #openstack-horizon19:53
*** zioproto has joined #openstack-horizon19:53
*** berendt has joined #openstack-horizon19:57
*** linkmark has joined #openstack-horizon20:10
*** btully has joined #openstack-horizon20:19
*** yamamoto has joined #openstack-horizon20:25
*** yamamoto has quit IRC20:30
*** btully has quit IRC20:30
*** rwellum has joined #openstack-horizon21:02
*** e0ne has quit IRC21:05
*** e0ne has joined #openstack-horizon21:15
*** ellopunk has quit IRC21:18
*** btully has joined #openstack-horizon21:22
*** yamamoto has joined #openstack-horizon21:27
*** robcresswell has joined #openstack-horizon21:30
*** ChanServ sets mode: +o robcresswell21:30
*** ying_zuo has joined #openstack-horizon21:32
*** ChanServ sets mode: +o ying_zuo21:32
*** yamamoto has quit IRC21:32
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: Drop unnecessary executable flags  https://review.openstack.org/52226821:32
*** btully has quit IRC21:35
*** ellopunk has joined #openstack-horizon21:53
*** ellopunk has quit IRC21:57
*** btully has joined #openstack-horizon21:57
*** btully has quit IRC22:04
*** e0ne has quit IRC22:06
*** e0ne has joined #openstack-horizon22:07
*** e0ne has quit IRC22:07
*** e0ne has joined #openstack-horizon22:08
*** e0ne has quit IRC22:09
*** e0ne has joined #openstack-horizon22:10
*** e0ne has quit IRC22:10
*** e0ne has joined #openstack-horizon22:11
*** e0ne has quit IRC22:11
*** e0ne has joined #openstack-horizon22:12
*** e0ne has quit IRC22:13
*** btully has joined #openstack-horizon22:24
*** yamamoto has joined #openstack-horizon22:29
*** yamamoto has quit IRC22:35
*** btully has quit IRC22:36
*** jtriley has joined #openstack-horizon22:43
*** ellopunk has joined #openstack-horizon22:51
*** btully has joined #openstack-horizon22:52
*** jtriley has quit IRC22:54
*** btully has quit IRC23:04
*** jtriley has joined #openstack-horizon23:20
*** jtriley has quit IRC23:26
*** yamamoto has joined #openstack-horizon23:30
*** wolverineav has quit IRC23:31
*** jtriley has joined #openstack-horizon23:34
*** yamamoto has quit IRC23:37
*** ellopunk has quit IRC23:48
*** itlinux has quit IRC23:49
*** ellopunk has joined #openstack-horizon23:52
*** openstackgerrit has quit IRC23:54
*** ellopunk has quit IRC23:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!