| *** ppiela has joined #openstack-horizon | 00:04 | |
| *** ppiela_ has quit IRC | 00:06 | |
| *** hughhalf has joined #openstack-horizon | 00:07 | |
| *** itlinux has joined #openstack-horizon | 00:10 | |
| *** catintheroof has joined #openstack-horizon | 00:11 | |
| *** rcernin has joined #openstack-horizon | 00:21 | |
| *** catintheroof has quit IRC | 00:32 | |
| *** catintheroof has joined #openstack-horizon | 00:38 | |
| *** gyee has quit IRC | 00:40 | |
| *** catintheroof has quit IRC | 00:42 | |
| *** catintheroof has joined #openstack-horizon | 00:44 | |
| *** catintheroof has quit IRC | 00:55 | |
| *** catintheroof has joined #openstack-horizon | 00:56 | |
| *** catintheroof has quit IRC | 01:20 | |
| *** namnh has joined #openstack-horizon | 01:21 | |
| *** catintheroof has joined #openstack-horizon | 01:21 | |
| *** ppiela_ has joined #openstack-horizon | 01:22 | |
| *** ppiela has quit IRC | 01:23 | |
| *** catintheroof has quit IRC | 01:24 | |
| *** dave-mccowan has quit IRC | 01:26 | |
| *** dave-mccowan has joined #openstack-horizon | 01:27 | |
| *** rcernin has quit IRC | 01:43 | |
| *** yamamoto has joined #openstack-horizon | 01:43 | |
| *** rcernin has joined #openstack-horizon | 01:44 | |
| *** yamamoto has quit IRC | 01:49 | |
| *** catintheroof has joined #openstack-horizon | 01:55 | |
| *** catintheroof has quit IRC | 02:00 | |
| *** ppiela has joined #openstack-horizon | 02:20 | |
| *** ppiela_ has quit IRC | 02:22 | |
| *** catintheroof has joined #openstack-horizon | 02:28 | |
| *** catintheroof has quit IRC | 02:33 | |
| *** yamamoto has joined #openstack-horizon | 02:45 | |
| *** yamamoto has quit IRC | 02:51 | |
| *** dave-mccowan has quit IRC | 03:14 | |
| *** yamamoto has joined #openstack-horizon | 03:16 | |
| *** yamamoto has quit IRC | 03:36 | |
| *** gugl has quit IRC | 03:42 | |
| *** yamamoto has joined #openstack-horizon | 03:54 | |
| *** yamamoto has quit IRC | 03:54 | |
| *** yamamoto has joined #openstack-horizon | 03:55 | |
| *** udesale has joined #openstack-horizon | 03:58 | |
| *** catintheroof has joined #openstack-horizon | 04:01 | |
| *** catintheroof has quit IRC | 04:05 | |
| *** ppiela_ has joined #openstack-horizon | 04:14 | |
| *** ppiela has quit IRC | 04:17 | |
| *** masco has joined #openstack-horizon | 04:27 | |
| *** logan- has quit IRC | 04:38 | |
| *** logan- has joined #openstack-horizon | 04:42 | |
| *** shu-mutou has joined #openstack-horizon | 05:02 | |
| *** yamamoto has quit IRC | 05:21 | |
| *** ratailor has joined #openstack-horizon | 06:03 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon master: Imported Translations from Zanata https://review.openstack.org/515608 | 06:13 |
|---|---|---|
| *** spectr has joined #openstack-horizon | 06:22 | |
| *** ratailor has quit IRC | 06:24 | |
| *** kei-ichi has quit IRC | 06:31 | |
| *** kei-ichi has joined #openstack-horizon | 06:32 | |
| *** ratailor has joined #openstack-horizon | 06:37 | |
| *** kei-ichi has quit IRC | 06:40 | |
| *** kei-ichi has joined #openstack-horizon | 06:41 | |
| *** lajoskatona has joined #openstack-horizon | 06:44 | |
| openstackgerrit | Merged openstack/horizon master: Imported Translations from Zanata https://review.openstack.org/515608 | 06:50 |
| *** makowals has joined #openstack-horizon | 06:54 | |
| *** makowals has quit IRC | 06:56 | |
| *** ratailor has quit IRC | 06:56 | |
| *** ratailor has joined #openstack-horizon | 06:57 | |
| *** kei-ichi has quit IRC | 07:03 | |
| *** kei-ichi has joined #openstack-horizon | 07:03 | |
| *** mrch has joined #openstack-horizon | 07:06 | |
| *** tesseract has joined #openstack-horizon | 07:22 | |
| openstackgerrit | Merged openstack/horizon master: doc: Update the URL of noVNC https://review.openstack.org/515296 | 07:28 |
| *** namnh has quit IRC | 07:34 | |
| *** rmart04 has joined #openstack-horizon | 07:38 | |
| *** ratailor has quit IRC | 07:41 | |
| *** ttrifonov has quit IRC | 07:42 | |
| *** itlinux has quit IRC | 07:43 | |
| *** e0ne has joined #openstack-horizon | 07:45 | |
| *** ttrifonov has joined #openstack-horizon | 07:46 | |
| *** hoangcx has quit IRC | 07:53 | |
| *** ratailor has joined #openstack-horizon | 07:54 | |
| *** rcernin has quit IRC | 07:58 | |
| *** makowals has joined #openstack-horizon | 07:58 | |
| *** itxaka has joined #openstack-horizon | 08:08 | |
| *** itxaka has quit IRC | 08:08 | |
| *** itxaka has joined #openstack-horizon | 08:08 | |
| *** itxaka has quit IRC | 08:09 | |
| *** itxaka has joined #openstack-horizon | 08:09 | |
| *** udesale has quit IRC | 08:35 | |
| e0ne | amotoki: hi. sorry, I'm busy with downstream tasks this morning:(. I'll ping you about mocks on Monday | 08:45 |
| *** shu-mutou is now known as shu-mutou-AWAY | 08:46 | |
| amotoki | e0ne: I am not sure I am available next week though | 08:49 |
| amotoki | e0ne: I don't think it is what we need to rush | 08:49 |
| e0ne | amotoki: agree. but I would like to get some agreement with codestyle on this to get things move forward | 08:50 |
| *** namnh has joined #openstack-horizon | 08:51 | |
| *** udesale has joined #openstack-horizon | 08:53 | |
| *** masco has quit IRC | 09:15 | |
| *** tosky has joined #openstack-horizon | 09:17 | |
| *** rmart04 has quit IRC | 09:37 | |
| *** ratailor is now known as rtailor | 09:45 | |
| *** ppiela__ has joined #openstack-horizon | 10:03 | |
| *** ppiela_ has quit IRC | 10:07 | |
| amotoki | e0ne: if you have time today, you can ping me. perhaps i will be online until around 1400UTC | 10:22 |
| *** vladiskuz has quit IRC | 10:24 | |
| *** yamamoto has joined #openstack-horizon | 10:24 | |
| e0ne | amotoki: I'm here | 10:35 |
| e0ne | amotoki: I'm interesting in your concerns according to custom decorators | 10:35 |
| *** namnh has quit IRC | 10:36 | |
| amotoki | e0ne: it is not a special concern. | 10:36 |
| amotoki | e0ne: the custom mock adds attributes to a test instance. It is based on the horizon-specific pattern | 10:37 |
| amotoki | e0ne: my point is to keep the standard mock usage as much as possible. | 10:38 |
| amotoki | e0ne: if there is no much difference the standard mock usage would be nice as developers need not to learn horizon-specifc way | 10:38 |
| e0ne | I understand thit and totally agree | 10:38 |
| e0ne | but in other case, if code is simple enough and keep LoC less - it's good for me | 10:39 |
| amotoki | on the other hand, in the current horizon UT we use assert_called variants. it means we need variables which points to mock object, so the number of variables tends to be high. | 10:40 |
| amotoki | I think that is your point on LoC | 10:40 |
| amotoki | honestly I am okay with either way. Your approach also can save the diff when converting mox to mock. | 10:42 |
| e0ne | ok, I understan your opinion now | 10:42 |
| amotoki | perhaps migration cost will be lower | 10:42 |
| amotoki | e0ne: we now discussed pros and cons. | 10:43 |
| e0ne | I think it's a good idea for me to summarize all ideas to some note or blog post. I'll do it early next week | 10:43 |
| amotoki | e0ne: i think your approach has enough pros and I am okay to introduce the convenient wrapper decorator. | 10:44 |
| e0ne | my biggest argument against a lot of '@mock.patch' and 'with mock()' for one tests that it makes code more messy | 10:45 |
| *** yamamoto has quit IRC | 10:45 | |
| e0ne | it's easier to my to read code with less decorators and complex 'with statements' | 10:45 |
| e0ne | but maybe it's only for me | 10:46 |
| amotoki | hehe. i think you are not alone. | 10:46 |
| e0ne | :) | 10:47 |
| amotoki | a bit different idea is to introduce a decorator like you and it sets a single class attribute with a dict | 10:47 |
| amotoki | the dict contains corresponding mock object | 10:47 |
| ethfci | hi | 10:48 |
| e0ne | from other perspective, we already have some customization on top of django (e.g. forms, fields, tables) and it makes our code less complex | 10:48 |
| e0ne | amotoki: good idea, I'll play with it too | 10:48 |
| e0ne | ethfci: hi | 10:48 |
| amotoki | or something like "with mutiple_mock({api.nova: ('server_get', 'server_list'), api.cinder: (....)}) as mocked_method:" | 10:49 |
| *** rtailor has quit IRC | 10:49 | |
| amotoki | and you can access the mocked methods like mocked_methods['api.nova.server_get"].call_count | 10:49 |
| e0ne | amotoki: yes, I thought about this too | 10:49 |
| e0ne | just didn't have time to implement it | 10:50 |
| amotoki | it is better if we have less implicit variables and the context will be clear. | 10:50 |
| e0ne | amotoki: with one note: it prefer decorator that adds mocked_mothods param to the function to save one indentation with 4 spaces:) | 10:51 |
| e0ne | amotoki: +1 | 10:51 |
| amotoki | e0ne: tend to agree. | 10:52 |
| e0ne | :) | 10:52 |
| amotoki | e0ne: in addition, if we have only one extra argument, i think we can add it to the usual method arguments rather than setting it as an instance attribute. | 10:53 |
| e0ne | amotoki: thanks for interesting and productive conversation | 10:53 |
| amotoki | e0ne: if i have time, i try to update your patch for better exploration. | 10:54 |
| e0ne | amotoki: don't worry. it's enough to add link to IRC logs | 10:54 |
| amotoki | we can compare several approaches using patch sets in your change | 10:54 |
| amotoki | e0ne: 'update' I mean is to update the code itself | 10:54 |
| -amotoki- is going to be offline | 10:55 | |
| e0ne | amotoki: oh.. cool. don't hesitate to add yourself as co-author | 10:55 |
| *** rtailor has joined #openstack-horizon | 11:02 | |
| *** robcresswell has quit IRC | 11:03 | |
| *** yamamoto has joined #openstack-horizon | 11:05 | |
| *** rtailor has quit IRC | 11:15 | |
| *** yamamoto has quit IRC | 11:21 | |
| *** marlinc has quit IRC | 11:28 | |
| *** rtailor has joined #openstack-horizon | 11:34 | |
| *** rtailor has quit IRC | 11:37 | |
| *** ratailor has joined #openstack-horizon | 11:37 | |
| *** marlinc has joined #openstack-horizon | 11:38 | |
| openstackgerrit | Mateusz Kowalski proposed openstack/horizon master: Make API calls in Volumes view parallel https://review.openstack.org/426493 | 11:38 |
| *** belmoreira has joined #openstack-horizon | 11:45 | |
| *** yamamoto has joined #openstack-horizon | 11:50 | |
| *** ratailor has quit IRC | 11:58 | |
| *** ratailor has joined #openstack-horizon | 11:58 | |
| *** yamamoto has quit IRC | 11:59 | |
| *** lahari has joined #openstack-horizon | 12:08 | |
| *** lahari has left #openstack-horizon | 12:11 | |
| *** yamamoto has joined #openstack-horizon | 12:14 | |
| *** ratailor has quit IRC | 12:17 | |
| *** lahari has joined #openstack-horizon | 12:27 | |
| lahari | Hello all | 12:27 |
| lahari | can anyone of you confirm the bug https://bugs.launchpad.net/horizon/+bug/1728031 | 12:27 |
| openstack | Launchpad bug 1728031 in OpenStack Dashboard (Horizon) "unable to change user password" [Undecided,New] | 12:27 |
| *** lahari has quit IRC | 12:27 | |
| *** jtriley has joined #openstack-horizon | 12:39 | |
| *** lblanchard has joined #openstack-horizon | 12:51 | |
| *** wolverineav has joined #openstack-horizon | 12:52 | |
| openstackgerrit | Mateusz Kowalski proposed openstack/horizon master: Make API calls in Volumes view parallel https://review.openstack.org/426493 | 12:55 |
| *** catintheroof has joined #openstack-horizon | 13:04 | |
| *** udesale has quit IRC | 13:08 | |
| *** lblanchard has quit IRC | 13:16 | |
| *** jtriley has quit IRC | 13:24 | |
| openstackgerrit | Bence Romsics proposed openstack/horizon master: Trunks panel: create button https://review.openstack.org/468396 | 13:25 |
| openstackgerrit | Bence Romsics proposed openstack/horizon master: Trunks panel: edit button https://review.openstack.org/485473 | 13:25 |
| openstackgerrit | Bence Romsics proposed openstack/horizon master: Trunks panel: default to enabled https://review.openstack.org/489186 | 13:25 |
| openstackgerrit | wei.ying proposed openstack/horizon master: Hide some actions when the instance is locked for non-admin users https://review.openstack.org/512019 | 13:28 |
| *** catintheroof has quit IRC | 13:34 | |
| *** catintheroof has joined #openstack-horizon | 13:42 | |
| *** jtriley has joined #openstack-horizon | 13:45 | |
| *** spectr has quit IRC | 13:49 | |
| *** dave-mccowan has joined #openstack-horizon | 13:53 | |
| *** jtriley has quit IRC | 13:58 | |
| *** jtriley has joined #openstack-horizon | 14:01 | |
| *** tosky has quit IRC | 14:06 | |
| *** tosky has joined #openstack-horizon | 14:08 | |
| *** spectr has joined #openstack-horizon | 14:09 | |
| *** ratailor has joined #openstack-horizon | 14:17 | |
| *** dave-mccowan has quit IRC | 14:20 | |
| *** rmart04 has joined #openstack-horizon | 14:22 | |
| *** felipemonteiro_ has joined #openstack-horizon | 14:26 | |
| *** felipemonteiro__ has joined #openstack-horizon | 14:32 | |
| openstackgerrit | Bence Romsics proposed openstack/horizon master: Trunks panel: edit button https://review.openstack.org/485473 | 14:35 |
| openstackgerrit | Bence Romsics proposed openstack/horizon master: Trunks panel: default to enabled https://review.openstack.org/489186 | 14:35 |
| *** felipemonteiro_ has quit IRC | 14:36 | |
| *** spectr has quit IRC | 14:39 | |
| *** e0ne has quit IRC | 14:45 | |
| *** e0ne has joined #openstack-horizon | 14:53 | |
| *** e0ne has quit IRC | 14:53 | |
| *** e0ne has joined #openstack-horizon | 14:54 | |
| *** jtriley has quit IRC | 14:54 | |
| *** e0ne has quit IRC | 14:54 | |
| *** e0ne has joined #openstack-horizon | 14:55 | |
| *** e0ne has quit IRC | 14:56 | |
| *** e0ne has joined #openstack-horizon | 14:56 | |
| *** e0ne has quit IRC | 14:57 | |
| *** ethfci has quit IRC | 14:57 | |
| *** rmart04 has quit IRC | 15:06 | |
| *** belmoreira has quit IRC | 15:09 | |
| *** dave-mccowan has joined #openstack-horizon | 15:11 | |
| *** tosky has quit IRC | 15:12 | |
| *** dave-mccowan has quit IRC | 15:21 | |
| *** yamamoto has quit IRC | 15:24 | |
| *** wolverineav has quit IRC | 15:50 | |
| *** wolverineav has joined #openstack-horizon | 15:51 | |
| *** itlinux has joined #openstack-horizon | 15:57 | |
| *** yamamoto has joined #openstack-horizon | 16:01 | |
| *** dave-mccowan has joined #openstack-horizon | 16:03 | |
| *** ratailor has quit IRC | 16:06 | |
| *** robcresswell has joined #openstack-horizon | 16:19 | |
| *** ChanServ sets mode: +o robcresswell | 16:19 | |
| *** tosky has joined #openstack-horizon | 16:19 | |
| *** e0ne has joined #openstack-horizon | 16:21 | |
| *** catintheroof has quit IRC | 16:23 | |
| *** dave-mccowan has quit IRC | 16:26 | |
| *** catintheroof has joined #openstack-horizon | 16:27 | |
| *** catintheroof has quit IRC | 16:35 | |
| *** catintheroof has joined #openstack-horizon | 16:36 | |
| *** catintheroof has quit IRC | 16:39 | |
| *** catintheroof has joined #openstack-horizon | 16:39 | |
| *** dave-mccowan has joined #openstack-horizon | 16:50 | |
| *** mrch has quit IRC | 16:56 | |
| *** dave-mccowan has quit IRC | 17:03 | |
| *** dave-mccowan has joined #openstack-horizon | 17:03 | |
| *** Matias has joined #openstack-horizon | 17:05 | |
| *** yamamoto has quit IRC | 17:13 | |
| *** ianychoi_ has quit IRC | 17:17 | |
| *** yamamoto has joined #openstack-horizon | 17:21 | |
| *** itlinux has quit IRC | 17:28 | |
| *** dave-mccowan has quit IRC | 17:29 | |
| *** lajoskatona has quit IRC | 17:38 | |
| *** jtriley has joined #openstack-horizon | 17:43 | |
| *** yamamoto has quit IRC | 17:49 | |
| *** yamamoto has joined #openstack-horizon | 17:53 | |
| *** itlinux has joined #openstack-horizon | 17:53 | |
| openstackgerrit | Trygve Vea proposed openstack/horizon master: Remove deprecated and unused API function from Nova API https://review.openstack.org/515795 | 17:56 |
| *** yamamoto has quit IRC | 17:59 | |
| *** rmart04 has joined #openstack-horizon | 18:02 | |
| *** harlowja has quit IRC | 18:05 | |
| *** harlowja has joined #openstack-horizon | 18:05 | |
| *** e0ne has quit IRC | 18:15 | |
| *** dave-mccowan has joined #openstack-horizon | 18:38 | |
| *** dave-mccowan has quit IRC | 18:44 | |
| *** jtriley has quit IRC | 18:45 | |
| *** jtriley has joined #openstack-horizon | 18:45 | |
| *** yamamoto has joined #openstack-horizon | 18:59 | |
| *** yamamoto has quit IRC | 19:06 | |
| *** rmart04 has quit IRC | 19:27 | |
| *** catintheroof has quit IRC | 19:29 | |
| *** e0ne has joined #openstack-horizon | 19:29 | |
| *** e0ne has quit IRC | 19:30 | |
| *** tesseract has quit IRC | 19:33 | |
| *** dave-mccowan has joined #openstack-horizon | 19:37 | |
| *** catintheroof has joined #openstack-horizon | 19:41 | |
| *** catintheroof has quit IRC | 19:45 | |
| *** dave-mccowan has quit IRC | 19:49 | |
| *** rcernin has joined #openstack-horizon | 19:57 | |
| *** itlinux has quit IRC | 20:01 | |
| *** yamamoto has joined #openstack-horizon | 20:02 | |
| *** rmart04 has joined #openstack-horizon | 20:03 | |
| *** yamamoto has quit IRC | 20:08 | |
| *** wolverineav has quit IRC | 20:18 | |
| *** wolverineav has joined #openstack-horizon | 20:18 | |
| *** dave-mccowan has joined #openstack-horizon | 20:33 | |
| *** dave-mccowan has quit IRC | 20:38 | |
| *** itlinux has joined #openstack-horizon | 20:41 | |
| *** jtriley has quit IRC | 20:42 | |
| *** felipemonteiro__ has quit IRC | 20:48 | |
| openstackgerrit | Trygve Vea proposed openstack/django_openstack_auth master: Add user_domain_name to logs regarding authentication https://review.openstack.org/515464 | 21:01 |
| *** yamamoto has joined #openstack-horizon | 21:05 | |
| *** itlinux has quit IRC | 21:07 | |
| *** yamamoto has quit IRC | 21:10 | |
| *** itlinux has joined #openstack-horizon | 21:15 | |
| *** rcernin has quit IRC | 21:28 | |
| *** itxaka has quit IRC | 21:36 | |
| *** itlinux has quit IRC | 21:44 | |
| *** wolverineav has quit IRC | 21:50 | |
| *** wolverineav has joined #openstack-horizon | 21:50 | |
| *** wolverineav has quit IRC | 21:54 | |
| *** yamamoto has joined #openstack-horizon | 22:06 | |
| *** yamamoto has quit IRC | 22:11 | |
| *** jtomasek has quit IRC | 22:14 | |
| *** dave-mccowan has joined #openstack-horizon | 22:15 | |
| *** dave-mccowan has quit IRC | 22:24 | |
| *** itlinux has joined #openstack-horizon | 22:33 | |
| *** itlinux has quit IRC | 22:46 | |
| *** wolverineav has joined #openstack-horizon | 22:46 | |
| *** tosky has quit IRC | 23:00 | |
| *** yamamoto has joined #openstack-horizon | 23:07 | |
| *** yamamoto has quit IRC | 23:12 | |
| *** ianychoi has joined #openstack-horizon | 23:56 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!