| *** ppiela has joined #openstack-horizon | 00:18 | |
| *** hoangcx has joined #openstack-horizon | 00:47 | |
| *** kei-ichi has quit IRC | 02:29 | |
| *** kei-ichi has joined #openstack-horizon | 02:30 | |
| *** wolverineav has joined #openstack-horizon | 02:35 | |
| *** wolverineav has quit IRC | 02:40 | |
| *** wolverineav has joined #openstack-horizon | 02:58 | |
| *** wolverineav has quit IRC | 03:02 | |
| *** dave-mccowan has quit IRC | 03:05 | |
| *** hoangcx has quit IRC | 03:23 | |
| *** hoangcx has joined #openstack-horizon | 03:23 | |
| *** wolverineav has joined #openstack-horizon | 03:26 | |
| *** wolverineav has quit IRC | 03:33 | |
| *** udesale has joined #openstack-horizon | 03:49 | |
| *** wolverineav has joined #openstack-horizon | 04:02 | |
| *** wolverineav has quit IRC | 04:07 | |
| *** yamamoto has joined #openstack-horizon | 04:16 | |
| *** wolverineav has joined #openstack-horizon | 04:32 | |
| *** wolverineav has quit IRC | 04:37 | |
| *** masco has joined #openstack-horizon | 04:38 | |
| *** wolverineav has joined #openstack-horizon | 05:11 | |
| *** wolverineav has quit IRC | 05:15 | |
| *** wolverineav has joined #openstack-horizon | 05:28 | |
| *** wolverineav has quit IRC | 05:33 | |
| *** wolverineav has joined #openstack-horizon | 05:42 | |
| *** wolverineav has quit IRC | 05:47 | |
| *** spectr has joined #openstack-horizon | 05:52 | |
| *** udesale__ has joined #openstack-horizon | 06:09 | |
| *** udesale has quit IRC | 06:10 | |
| *** udesale has joined #openstack-horizon | 06:12 | |
| *** udesale__ has quit IRC | 06:14 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon master: Imported Translations from Zanata https://review.openstack.org/514136 | 06:19 |
|---|---|---|
| *** yamamoto has quit IRC | 06:33 | |
| *** yamamoto has joined #openstack-horizon | 06:52 | |
| *** pcaruana has joined #openstack-horizon | 07:00 | |
| *** jtomasek has joined #openstack-horizon | 07:02 | |
| openstackgerrit | Merged openstack/horizon master: Imported Translations from Zanata https://review.openstack.org/514136 | 07:08 |
| *** ircuser-1 has joined #openstack-horizon | 07:10 | |
| *** yamamoto_ has joined #openstack-horizon | 07:11 | |
| *** yamamoto has quit IRC | 07:13 | |
| *** jtomasek has quit IRC | 07:14 | |
| *** tesseract has joined #openstack-horizon | 07:27 | |
| *** yamamoto_ has quit IRC | 07:29 | |
| *** yamamoto has joined #openstack-horizon | 07:29 | |
| *** yamamoto has quit IRC | 07:43 | |
| *** jtomasek has joined #openstack-horizon | 07:53 | |
| *** yamamoto has joined #openstack-horizon | 07:57 | |
| *** yamamoto has quit IRC | 08:03 | |
| *** mrch has joined #openstack-horizon | 08:11 | |
| *** e0ne has joined #openstack-horizon | 08:13 | |
| *** spectr has quit IRC | 08:35 | |
| *** yamamoto has joined #openstack-horizon | 08:36 | |
| *** wolverineav has joined #openstack-horizon | 08:36 | |
| *** yamamoto has quit IRC | 08:38 | |
| *** wolverineav has quit IRC | 08:40 | |
| *** spectr has joined #openstack-horizon | 08:49 | |
| *** yamamoto has joined #openstack-horizon | 08:50 | |
| *** tosky has joined #openstack-horizon | 08:54 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Switch Cinder-related tests to mock https://review.openstack.org/509618 | 09:02 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Switch Cinder-related tests to mock https://review.openstack.org/510117 | 09:03 |
| *** yamamoto has quit IRC | 09:03 | |
| e0ne | amotoki: could you please take a look on https://review.openstack.org/#/c/510117/6? your -1 should be already addresses | 09:04 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Switch Cinder-related tests to mock https://review.openstack.org/510118 | 09:05 |
| amotoki | e0ne: my -1 was put to patch set 2. When I compare your patch set 6 to patch set 2, surprisingly there is no difference | 09:07 |
| amotoki | e0ne: could you check again? I suggested isinstance but I still see issubclass(type(...)) | 09:08 |
| amotoki | e0ne: i think that is the reason gerrit keeps my -1. | 09:08 |
| e0ne | amotoki: IsHttpRequest was implemented in patch set 3 | 09:09 |
| e0ne | amotoki: oh.. I see. it's a rebase issue:( | 09:09 |
| e0ne | amotoki: I've changes to 'isinstance' in the patch set 3, but in patch set 4 it has issubclass | 09:10 |
| e0ne | amotoki: I'll fix it asap | 09:12 |
| *** yamamoto has joined #openstack-horizon | 09:13 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Switch Cinder-related tests to mock https://review.openstack.org/510117 | 09:17 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Switch Cinder-related tests to mock https://review.openstack.org/510118 | 09:17 |
| e0ne | amotoki: fixed | 09:17 |
| *** cshen has joined #openstack-horizon | 09:25 | |
| e0ne | thanks for the help with reviews | 09:26 |
| *** mvk has quit IRC | 09:27 | |
| *** spectr has quit IRC | 09:31 | |
| *** spectr has joined #openstack-horizon | 09:31 | |
| *** cshen has quit IRC | 09:47 | |
| *** cshen has joined #openstack-horizon | 09:49 | |
| *** cshen has quit IRC | 09:52 | |
| *** cshen has joined #openstack-horizon | 09:54 | |
| *** yamamoto has quit IRC | 09:58 | |
| *** cshen has quit IRC | 09:58 | |
| *** yamamoto has joined #openstack-horizon | 09:59 | |
| *** mvk has joined #openstack-horizon | 10:02 | |
| *** spectr has quit IRC | 10:04 | |
| *** yamamoto has quit IRC | 10:06 | |
| *** udesale has quit IRC | 10:06 | |
| *** yamamoto has joined #openstack-horizon | 10:06 | |
| *** spectr has joined #openstack-horizon | 10:21 | |
| *** cshen has joined #openstack-horizon | 10:21 | |
| *** cshen has quit IRC | 10:24 | |
| *** wolverineav has joined #openstack-horizon | 10:30 | |
| amotoki | e0ne: what do you think about my comments in https://review.openstack.org/#/c/509618/10 ? | 10:33 |
| amotoki | e0ne: one is about the tricky mock usage of existing tests. I just would like to hear your opinion. | 10:34 |
| *** wolverineav has quit IRC | 10:35 | |
| *** yamamoto_ has joined #openstack-horizon | 10:37 | |
| e0ne | amotoki: it makes sense. TBH, I'm not sure how should we fix it: in this patch or in a separate one | 10:39 |
| e0ne | amotoki: both options are reasnable | 10:40 |
| *** yamamoto has quit IRC | 10:40 | |
| *** cshen has joined #openstack-horizon | 10:42 | |
| amotoki | e0ne: my vote is a fix in a separate patch as there are other points to be improved | 10:42 |
| e0ne | amotoki: sounds good for me. I'm still working on the 4th patch with some refactoring of https://review.openstack.org/#/c/510118/7 | 10:43 |
| e0ne | amotoki: so, I can fix mock levels in that patch too | 10:43 |
| *** cshen has quit IRC | 10:44 | |
| amotoki | e0ne: agree. thanks anyway. I remember I noticed it a couple of months ago but I totally forgot it. | 10:44 |
| e0ne | amotoki: np | 10:45 |
| *** spectr has quit IRC | 10:45 | |
| e0ne | oh... I must move IsHttpRequest definition to the first patch to address your comment:( | 10:46 |
| e0ne | amotoki: can I ask you to review https://review.openstack.org/#/c/513763/ too? it affects cinder-related tests too | 10:47 |
| *** spectr has joined #openstack-horizon | 10:47 | |
| *** yamamoto_ has quit IRC | 10:48 | |
| *** yamamoto has joined #openstack-horizon | 10:50 | |
| *** yamamoto has quit IRC | 10:55 | |
| *** yamamoto has joined #openstack-horizon | 10:55 | |
| amotoki | e0ne: done. my comments are almost just opinions :) | 11:00 |
| e0ne | amotoki: thanks! I'll take a look on it right after the lanch | 11:01 |
| amotoki | e0ne: enjoy lunch! | 11:03 |
| *** dave-mccowan has joined #openstack-horizon | 11:03 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Fetch Cinder availability zones list for volume creation https://review.openstack.org/513763 | 11:25 |
| *** yamamoto_ has joined #openstack-horizon | 11:30 | |
| *** yamamoto_ has quit IRC | 11:31 | |
| *** yamamoto has quit IRC | 11:32 | |
| *** yamamoto has joined #openstack-horizon | 11:32 | |
| *** jtomasek has quit IRC | 11:39 | |
| *** erlon has joined #openstack-horizon | 11:42 | |
| *** yamamoto has quit IRC | 11:52 | |
| *** yamamoto has joined #openstack-horizon | 11:53 | |
| *** yamamoto has quit IRC | 11:58 | |
| *** jlabarre has joined #openstack-horizon | 12:04 | |
| *** jtomasek has joined #openstack-horizon | 12:08 | |
| *** jpich has joined #openstack-horizon | 12:15 | |
| *** felipemonteiro has joined #openstack-horizon | 12:16 | |
| *** felipemonteiro_ has quit IRC | 12:17 | |
| *** mariusv has quit IRC | 12:25 | |
| *** e0ne has quit IRC | 12:25 | |
| *** mariusv has joined #openstack-horizon | 12:26 | |
| *** mariusv has joined #openstack-horizon | 12:26 | |
| openstackgerrit | Trygve Vea proposed openstack/horizon master: Wrap various API calls with try/except in Router panel https://review.openstack.org/513939 | 12:27 |
| openstackgerrit | Trygve Vea proposed openstack/horizon master: Implement network availability zone column in network list https://review.openstack.org/513920 | 12:29 |
| *** yamamoto has joined #openstack-horizon | 12:36 | |
| *** pcaruana has quit IRC | 12:41 | |
| *** yamamoto has quit IRC | 12:46 | |
| *** masco has quit IRC | 12:47 | |
| *** lblanchard has joined #openstack-horizon | 12:50 | |
| *** lennyb has quit IRC | 12:59 | |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Allow reguler users to specify VNIC type for port https://review.openstack.org/513887 | 12:59 |
| *** yamamoto has joined #openstack-horizon | 13:02 | |
| *** jtomasek has quit IRC | 13:05 | |
| *** lennyb has joined #openstack-horizon | 13:05 | |
| *** jtriley has quit IRC | 13:07 | |
| *** lblanchard has quit IRC | 13:10 | |
| *** jtomasek has joined #openstack-horizon | 13:11 | |
| *** lblanchard has joined #openstack-horizon | 13:15 | |
| *** jtriley has joined #openstack-horizon | 13:21 | |
| *** lennyb has quit IRC | 13:23 | |
| *** jtriley has quit IRC | 13:26 | |
| *** twouters has quit IRC | 13:27 | |
| *** lennyb has joined #openstack-horizon | 13:27 | |
| *** twouters has joined #openstack-horizon | 13:28 | |
| *** twouters has joined #openstack-horizon | 13:28 | |
| *** makowals has quit IRC | 13:29 | |
| *** makowals has joined #openstack-horizon | 13:31 | |
| openstackgerrit | Merged openstack/horizon master: Fetch Cinder availability zones list for volume creation https://review.openstack.org/513763 | 13:34 |
| *** cshen has joined #openstack-horizon | 13:43 | |
| *** jtriley has joined #openstack-horizon | 13:46 | |
| *** jtomasek has quit IRC | 14:08 | |
| *** jtomasek has joined #openstack-horizon | 14:09 | |
| *** felipemonteiro_ has joined #openstack-horizon | 14:18 | |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Correct quota usage check for instances https://review.openstack.org/510188 | 14:18 |
| *** felipemonteiro__ has joined #openstack-horizon | 14:19 | |
| *** wolverineav has joined #openstack-horizon | 14:20 | |
| *** david-lyle has joined #openstack-horizon | 14:21 | |
| *** ChanServ sets mode: +o david-lyle | 14:21 | |
| *** felipemonteiro_ has quit IRC | 14:23 | |
| *** cshen has quit IRC | 14:25 | |
| *** jtomasek has quit IRC | 14:27 | |
| *** makowals has quit IRC | 14:33 | |
| *** makowals has joined #openstack-horizon | 14:38 | |
| *** tosky has quit IRC | 14:46 | |
| *** jtomasek has joined #openstack-horizon | 14:52 | |
| openstackgerrit | Merged openstack/horizon master: Wrap various API calls with try/except in Router panel https://review.openstack.org/513939 | 15:02 |
| *** jtriley_ has joined #openstack-horizon | 15:03 | |
| *** jtriley has quit IRC | 15:06 | |
| *** e0ne has joined #openstack-horizon | 15:10 | |
| *** mrch has quit IRC | 15:34 | |
| *** gyee has joined #openstack-horizon | 15:37 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Switch Cinder-related tests to mock https://review.openstack.org/509618 | 15:39 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Switch Cinder-related tests to mock https://review.openstack.org/509618 | 15:43 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Switch Cinder-related tests to mock https://review.openstack.org/510117 | 15:43 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Switch Cinder-related tests to mock https://review.openstack.org/510118 | 15:43 |
| openstackgerrit | Merged openstack/horizon master: Correct quota usage check for instances https://review.openstack.org/510188 | 15:44 |
| *** rmart04 has joined #openstack-horizon | 15:49 | |
| *** wolverineav has quit IRC | 15:51 | |
| *** udesale has joined #openstack-horizon | 15:58 | |
| *** erlon has left #openstack-horizon | 16:09 | |
| *** cshen has joined #openstack-horizon | 16:11 | |
| *** cshen has quit IRC | 16:13 | |
| openstackgerrit | Trygve Vea proposed openstack/horizon master: Add a checkbox to disable SNAT on routers https://review.openstack.org/513854 | 16:13 |
| *** itlinux has joined #openstack-horizon | 16:18 | |
| *** tosky has joined #openstack-horizon | 16:28 | |
| *** wolverineav has joined #openstack-horizon | 16:47 | |
| *** rmart04 has quit IRC | 16:49 | |
| *** mvk has quit IRC | 16:49 | |
| *** wolverineav has quit IRC | 16:51 | |
| *** udesale has quit IRC | 16:53 | |
| *** jpich has quit IRC | 17:13 | |
| *** katyafervent_awa has quit IRC | 17:16 | |
| *** tsufiev has quit IRC | 17:16 | |
| *** tesseract has quit IRC | 17:18 | |
| *** tsufiev has joined #openstack-horizon | 17:20 | |
| *** katyafervent_awa has joined #openstack-horizon | 17:23 | |
| *** mvk has joined #openstack-horizon | 17:32 | |
| *** gugl has joined #openstack-horizon | 17:40 | |
| *** gugl has quit IRC | 17:46 | |
| *** __zeus__ has joined #openstack-horizon | 17:46 | |
| *** e0ne has quit IRC | 18:06 | |
| *** e0ne has joined #openstack-horizon | 18:08 | |
| *** e0ne has quit IRC | 18:10 | |
| *** wolverineav has joined #openstack-horizon | 18:32 | |
| *** __zeus__ has quit IRC | 18:45 | |
| *** __zeus__ has joined #openstack-horizon | 18:45 | |
| *** e0ne has joined #openstack-horizon | 18:47 | |
| *** e0ne has quit IRC | 18:52 | |
| *** itlinux has quit IRC | 18:52 | |
| *** harlowja has joined #openstack-horizon | 18:53 | |
| *** e0ne has joined #openstack-horizon | 18:55 | |
| *** itlinux has joined #openstack-horizon | 18:55 | |
| *** e0ne has quit IRC | 19:00 | |
| *** e0ne has joined #openstack-horizon | 19:20 | |
| *** e0ne has quit IRC | 19:25 | |
| *** e0ne has joined #openstack-horizon | 19:33 | |
| *** e0ne has quit IRC | 19:38 | |
| *** itlinux has quit IRC | 19:39 | |
| *** e0ne has joined #openstack-horizon | 19:47 | |
| *** e0ne has quit IRC | 19:52 | |
| *** e0ne has joined #openstack-horizon | 19:59 | |
| *** e0ne has quit IRC | 20:04 | |
| *** e0ne has joined #openstack-horizon | 20:11 | |
| *** e0ne has quit IRC | 20:16 | |
| *** e0ne has joined #openstack-horizon | 20:23 | |
| *** e0ne has quit IRC | 20:28 | |
| *** e0ne has joined #openstack-horizon | 20:31 | |
| *** e0ne has quit IRC | 20:35 | |
| *** e0ne has joined #openstack-horizon | 20:45 | |
| *** e0ne has quit IRC | 20:50 | |
| *** e0ne has joined #openstack-horizon | 20:52 | |
| *** e0ne has quit IRC | 20:57 | |
| *** lblanchard has quit IRC | 20:58 | |
| *** jtriley_ has quit IRC | 21:10 | |
| *** dave-mccowan has quit IRC | 21:28 | |
| *** MasterOfBugs has joined #openstack-horizon | 21:34 | |
| *** pramodrj07 has joined #openstack-horizon | 21:34 | |
| *** jlabarre has quit IRC | 21:44 | |
| *** __zeus__ has quit IRC | 22:01 | |
| *** dave-mccowan has joined #openstack-horizon | 22:49 | |
| *** felipemonteiro__ has quit IRC | 23:13 | |
| *** dave-mccowan has quit IRC | 23:27 | |
| *** wolverineav has quit IRC | 23:31 | |
| *** tosky has quit IRC | 23:34 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!