Wednesday, 2017-10-11

*** felipemonteiro has joined #openstack-horizon00:01
*** felipemonteiro_ has joined #openstack-horizon00:02
*** felipemonteiro has quit IRC00:06
*** felipemonteiro_ has quit IRC00:21
flwang1ying_zuo: I mean this patch https://review.openstack.org/51039200:52
*** gyee has quit IRC01:08
*** gary-smith_ has quit IRC02:07
*** catintheroof has joined #openstack-horizon02:20
*** dave-mccowan has joined #openstack-horizon02:20
*** dave-mcc_ has quit IRC02:22
*** catintheroof has quit IRC02:22
openstackgerritFeilong Wang proposed openstack/horizon master: Make image name on instances panel configurable  https://review.openstack.org/51039202:48
*** dave-mccowan has quit IRC02:51
*** erlon has quit IRC02:54
openstackgerritFeilong Wang proposed openstack/horizon master: Add white list for Nova extension  https://review.openstack.org/51109503:23
*** yamamoto has quit IRC03:25
openstackgerritFeilong Wang proposed openstack/horizon master: Rename "Import Key Pair" to "Import Public Key"  https://review.openstack.org/50543103:30
*** flwang1 has quit IRC04:04
*** ratailor has joined #openstack-horizon04:05
*** ratailor_ has joined #openstack-horizon04:07
*** ratailor has quit IRC04:11
*** yamamoto has joined #openstack-horizon04:13
*** ratailor__ has joined #openstack-horizon04:21
*** jtomasek has joined #openstack-horizon04:22
*** ratailor_ has quit IRC04:22
*** ratailor_ has joined #openstack-horizon04:32
*** gyee has joined #openstack-horizon04:34
*** ratailor__ has quit IRC04:36
*** yamamoto has quit IRC04:43
*** gyee has quit IRC05:10
*** ratailor__ has joined #openstack-horizon05:23
*** ratailor_ has quit IRC05:26
*** lajoskatona has joined #openstack-horizon05:30
*** udesale has joined #openstack-horizon05:38
*** yamamoto has joined #openstack-horizon05:43
*** yamamoto has quit IRC05:49
*** yamamoto has joined #openstack-horizon05:54
*** yamamoto has quit IRC05:58
*** yamamoto has joined #openstack-horizon06:02
*** yamamoto has quit IRC06:04
openstackgerritOpenStack Proposal Bot proposed openstack/horizon master: Imported Translations from Zanata  https://review.openstack.org/51075806:09
*** hoonetorg has quit IRC06:17
*** belmoreira has joined #openstack-horizon06:18
*** yamamoto has joined #openstack-horizon06:21
*** spectr has quit IRC06:27
*** spectr has joined #openstack-horizon06:28
*** hoonetorg has joined #openstack-horizon06:31
*** ratailor_ has joined #openstack-horizon06:32
*** ratailor__ has quit IRC06:35
*** openstackgerrit has quit IRC07:03
*** rcernin has joined #openstack-horizon07:05
*** pcaruana has joined #openstack-horizon07:13
*** tesseract has joined #openstack-horizon07:19
*** ratailor__ has joined #openstack-horizon07:21
*** ratailor_ has quit IRC07:24
*** nikhil has quit IRC07:34
*** yamamoto has quit IRC07:35
*** yamamoto has joined #openstack-horizon07:36
*** yamamoto has quit IRC07:36
*** ratailor__ has quit IRC07:36
*** jpich has joined #openstack-horizon07:39
makowalsGood morning everyone07:47
makowalsQuestion about performance measurements & tuning07:48
*** openstackgerrit has joined #openstack-horizon07:48
openstackgerritFerenc Cserepkei proposed openstack/horizon master: Add "prev" link to instance page list pagination  https://review.openstack.org/49801807:48
makowalsI have a problems with instance list taking 15 seconds to load. What I have checked so far, the problem is definitely not with the get_data() function when generating the view as this one takes only 2 seconds07:48
makowalsAny ideas what can I look for in order to make it faster?07:49
*** itlinux has joined #openstack-horizon07:52
*** itlinux has quit IRC08:04
makowalsI have already measured the whole horizon/tables/views.py and this delay is coming somewhere from the outside08:13
*** e0ne has joined #openstack-horizon08:23
*** yamamoto has joined #openstack-horizon08:23
*** pcaruana has quit IRC08:27
*** pcaruana has joined #openstack-horizon08:31
*** openstackgerrit has quit IRC08:33
vladiskuzmakowals: hi! What do you mean when you said "outside"?08:36
makowalsOutside of the "views.py" file08:36
vladiskuzmakowals: we are trying to improve performance of the instances tab. There are several patches on review. You can use profile to understand what's going wrong08:40
*** spectr has quit IRC08:40
vladiskuzmakowals: if you want run a profiler I can help you with this08:41
makowalsvladiskuz: I would appreciate. I have already made some patches upstream for this, but it seems like apparently for some projects I still have a lot of issues08:41
makowalsAlso at this moment I'm not really able to tell what really makes "the good" and "the bad" projects different08:42
*** ianychoi has quit IRC08:42
*** jeremy_moffitt_ has joined #openstack-horizon08:46
*** gary-smith_ has joined #openstack-horizon08:46
*** jgravel has quit IRC08:47
*** jeremy_moffitt has quit IRC08:47
*** gary-smith has quit IRC08:48
*** spectr has joined #openstack-horizon08:50
*** Sudheer has joined #openstack-horizon08:52
SudheerHello all i have question regarding support for displaying gnoochi/adoh information in horizon08:56
SudheerI came across a bule print which basically address this issue: https://blueprints.launchpad.net/horizon/+spec/horizon-gnocchi-graphs08:57
Sudheerbut i have n't found any useful links from the same to check the progress of UI support08:58
*** yamamoto has quit IRC08:58
*** belmoreira has quit IRC08:58
SudheerCan any one suggest whether the support for gnoochi/adoh is already exists or in progress08:59
*** yamamoto has joined #openstack-horizon09:01
*** yamamoto has quit IRC09:06
*** ianychoi has joined #openstack-horizon09:06
*** belmoreira has joined #openstack-horizon09:08
*** belmoreira has quit IRC09:08
*** belmoreira has joined #openstack-horizon09:10
*** ratailor has joined #openstack-horizon09:14
*** priteau has joined #openstack-horizon09:20
*** tosky has joined #openstack-horizon09:21
*** rmart04 has joined #openstack-horizon09:40
*** mvk has quit IRC09:40
*** belmoreira has quit IRC09:53
*** jamesbenson has joined #openstack-horizon09:54
*** udesale has quit IRC09:58
*** jamesbenson has quit IRC09:58
*** gokhan has quit IRC10:03
-openstackstatus- NOTICE: The CI system will be offline starting at 11:00 UTC (in just under an hour) for Zuul v3 rollout: http://lists.openstack.org/pipermail/openstack-dev/2017-October/123337.html10:08
*** wolverineav has joined #openstack-horizon10:08
*** ratailor has quit IRC10:21
*** ratailor has joined #openstack-horizon10:22
*** itxaka has joined #openstack-horizon10:25
*** early has quit IRC10:29
*** early has joined #openstack-horizon10:32
*** openstackgerrit has joined #openstack-horizon10:35
openstackgerritOpenStack Proposal Bot proposed openstack/django_openstack_auth master: Imported Translations from Zanata  https://review.openstack.org/51005410:35
*** ratailor_ has joined #openstack-horizon10:41
*** gokhan has joined #openstack-horizon10:41
*** jgravel has joined #openstack-horizon10:44
*** ratailor has quit IRC10:45
*** itxaka has quit IRC10:50
*** erlon has joined #openstack-horizon10:57
*** itlinux has joined #openstack-horizon11:05
*** mvk has joined #openstack-horizon11:12
*** belmoreira has joined #openstack-horizon11:16
*** hoonetorg has quit IRC11:21
*** udesale has joined #openstack-horizon11:21
*** hoonetorg has joined #openstack-horizon11:35
*** ratailor__ has joined #openstack-horizon11:38
*** rmart04 has quit IRC11:41
*** ratailor_ has quit IRC11:41
*** spectr has quit IRC11:44
*** spectr has joined #openstack-horizon11:46
*** ratailor__ has quit IRC11:49
*** spectr-RH has joined #openstack-horizon11:54
*** yamamoto has joined #openstack-horizon11:55
*** spectr has quit IRC11:57
*** yamamoto has quit IRC11:59
*** dave-mccowan has joined #openstack-horizon12:01
*** jlabarre has joined #openstack-horizon12:04
*** yamamoto has joined #openstack-horizon12:08
*** itlinux has quit IRC12:10
*** spectr-RH has quit IRC12:13
*** spectr has joined #openstack-horizon12:13
*** itlinux has joined #openstack-horizon12:14
*** spectr-RH has joined #openstack-horizon12:14
*** spectr has quit IRC12:18
*** openstackgerrit has quit IRC12:18
*** priteau has quit IRC12:30
*** yamamoto has quit IRC12:31
*** itlinux has quit IRC12:35
*** wolverineav has quit IRC12:35
*** itlinux has joined #openstack-horizon12:35
*** belmoreira has quit IRC12:41
*** catintheroof has joined #openstack-horizon12:43
-openstackstatus- NOTICE: Due to unrelated emergencies, the Zuul v3 rollout has not started yet; stay tuned for further updates13:05
*** zhurong has joined #openstack-horizon13:20
*** wolverineav has joined #openstack-horizon13:27
*** priteau has joined #openstack-horizon13:35
*** tosky_ has joined #openstack-horizon13:36
*** itlinux has quit IRC13:36
*** tosky has quit IRC13:38
*** lblanchard has joined #openstack-horizon13:43
*** udesale has quit IRC13:43
*** jtriley has joined #openstack-horizon13:49
*** udesale has joined #openstack-horizon13:55
*** Tengu has joined #openstack-horizon13:57
Tenguhello!13:57
Tengusmall question: on three load-balanced controllers with openstack HA, we have disconnections from horizon way before the configured session_timeout. How are sessions managed? is it stateless?13:58
robcresswellTengu: We just hold the token in a cookie, but thats about it14:01
Tengurobcresswell: hmmm ok. and any backend understands that cookie and can match the keytone ticket right?14:01
robcresswellTengu: It's the keystone auth token that we store, so yes14:02
Tenguhmm ok. so maybe it's a timeout on keystone side14:02
*** spectr-RH has quit IRC14:04
robcresswelliirc we have a session timeout too, and so it'll time out at the lower of either our setting or keystones14:04
*** spectr has joined #openstack-horizon14:04
*** chlong has joined #openstack-horizon14:05
Tenguok. so might be something like keystone_authtoken/memcache_pool_unused_timeout14:05
cshenHi all, following the question from yesterday. I enabled the debug log in horizon. and try to make a network_topology call to it directly. it timed out after 5 mins.14:05
*** lblanchard1 has joined #openstack-horizon14:05
cshenthe debug only showed [Wed Oct 11 13:38:03.491088 2017] [wsgi:error] [pid 255:tid 140246016505600] [client 10.97.160.27:45328] Timeout when reading response headers from daemon process 'horizon': /openstack/venvs/horizon-14.1.0/lib/python2.7/dist-packages/openstack_dashboard/wsgi/django.wsgi14:05
cshennothing more. how can I make horizon to give me more verbosed logs?14:06
*** lblanchard has quit IRC14:06
cshenI want to figure where it took most time.14:07
*** tosky_ is now known as tosky14:10
robcresswellcshen: That doesnt look like debug level logging to me :)14:10
robcresswellyou'll need to update your settings, then restart horizon14:11
robcresswellMay also need some changes to your wsgi server14:11
cshenI did this change in settings.14:12
cshenDEBUG = True14:12
cshenand restarted horizon.14:13
*** rmart04 has joined #openstack-horizon14:14
cshenand I believe horizon did produce debug logs. because for other requets. I saw these logs.14:16
cshen[Wed Oct 11 13:48:32.385371 2017] [wsgi:error] [pid 251:tid 140246174328576] DEBUG:keystoneauth.session:REQ: curl -g -i --insecure -X GET http://xxx:5000/v3/users/ad262a99ab9d49a18e1d0e63c2912d2a/projects -H "User-Agent: python-keystoneclient" -H "Accept: application/json" -H "X-Auth-Token: {SHA1}63f5fc9dccaf2eac804035be9200df1007dfbc67"14:16
cshen[Wed Oct 11 13:48:32.614877 2017] [wsgi:error] [pid 251:tid 140246174328576] DEBUG:keystoneauth.session:RESP: [200] Date: Wed, 11 Oct 2017 13:48:32 GMT Server: Apache Vary: X-Auth-Token x-openstack-request-id: req-b1298a21-523a-484b-84c1-139557eed92e Content-Length: 4918 Content-Type: application/json14:16
*** rmart04 has left #openstack-horizon14:21
*** zhurong has quit IRC14:29
*** ramineni_ has joined #openstack-horizon14:32
*** lajoskatona has quit IRC14:32
*** udesale has quit IRC14:34
*** felipemonteiro has joined #openstack-horizon14:38
*** mvk has quit IRC14:39
*** jamesbenson has joined #openstack-horizon14:40
*** felipemonteiro_ has joined #openstack-horizon14:40
SudheerHello all i have question regarding support for displaying gnoochi/adoh information in horizon14:43
SudheerI came across a bule print which basically address this issue: https://blueprints.launchpad.net/horizon/+spec/horizon-gnocchi-graphs14:43
Sudheerbut i have n't found any useful links from the same to check the progress of UI support14:43
*** spectr has quit IRC14:43
SudheerCan some one point me in the right direction whether there is new panel/plugin creation is in progress for displaying Gnoochi/Adoh services data14:43
*** gary-smith__ has joined #openstack-horizon14:44
*** felipemonteiro has quit IRC14:44
*** openstackgerrit has joined #openstack-horizon14:47
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: Switch Cinder-related tests to mock  https://review.openstack.org/51011814:47
*** spectr has joined #openstack-horizon14:58
david-lyleSudheer, try #openstack-telemetry it should be owned by the telemetry team15:01
robcresswellSudheer: There's no plugin that I'm aware of to display telemetry data within Horizon15:02
david-lyleThere was work on Aodh alarms, and I vaguely remember a mailing post about a gnocchi panel, but I didn't track it15:03
*** chlong has quit IRC15:06
openstackgerritIvan Kolodyazhny proposed openstack/horizon master: Switch Cinder-related tests to mock  https://review.openstack.org/51011815:30
*** gyee has joined #openstack-horizon15:33
*** jamesbenson has quit IRC15:33
*** jamesbenson has joined #openstack-horizon15:34
*** jamesbenson has quit IRC15:37
*** chlong has joined #openstack-horizon15:38
*** jamesbenson has joined #openstack-horizon15:43
*** jamesbenson has quit IRC15:44
*** jamesbenson has joined #openstack-horizon15:45
*** chlong has quit IRC15:51
*** gary-smith__ has quit IRC15:53
*** ratailor has joined #openstack-horizon15:54
*** pcaruana has quit IRC15:59
*** rcernin has quit IRC15:59
*** gary-smith__ has joined #openstack-horizon16:01
*** ratailor has quit IRC16:03
*** jpich has quit IRC16:08
*** wolverineav has quit IRC16:09
*** itlinux has joined #openstack-horizon16:11
*** chlong has joined #openstack-horizon16:11
*** wolverineav has joined #openstack-horizon16:13
*** jamesbenson has quit IRC16:21
*** jamesbenson has joined #openstack-horizon16:23
*** gary-smith__ has quit IRC16:27
*** e0ne has quit IRC16:38
*** felipemonteiro_ has quit IRC16:40
*** ramineni_ has quit IRC16:41
*** chlong has quit IRC16:48
*** felipemonteiro has joined #openstack-horizon17:00
*** felipemonteiro_ has joined #openstack-horizon17:01
*** felipemonteiro has quit IRC17:06
*** nikhil has joined #openstack-horizon17:14
*** tesseract has quit IRC17:15
*** tosky has quit IRC17:34
*** itlinux has quit IRC17:40
*** e0ne has joined #openstack-horizon17:41
*** cshen_ has joined #openstack-horizon17:51
*** tosky has joined #openstack-horizon17:58
*** e0ne has quit IRC18:06
*** flwang1 has joined #openstack-horizon18:16
flwang1david-lyle: ying_zuo: robcresswell: two topics I'd like to discuss if you're around18:17
flwang11. https://bugs.launchpad.net/horizon/+bug/1722704 bug about image name filter18:18
openstackLaunchpad bug 1722704 in OpenStack Dashboard (Horizon) "Image name filter on instance panel doesn't work" [Undecided,New] - Assigned to Feilong Wang (flwang)18:18
flwang12. https://bugs.launchpad.net/horizon/+bug/1722701 adding a white list for nova extension18:19
openstackLaunchpad bug 1722701 in OpenStack Dashboard (Horizon) "[Performance] Add a white list for nova extension to avoid API calls" [Undecided,In progress] - Assigned to Feilong Wang (flwang)18:19
ying_zuoflwang1: I am here18:23
flwang1ying_zuo: sorry i'm making noisy here again :)18:23
flwang1ying_zuo: yesterday, i had a look at the code about image name filter and I think there are some design faults, pls see bug https://bugs.launchpad.net/horizon/+bug/172270418:24
openstackLaunchpad bug 1722704 in OpenStack Dashboard (Horizon) "Image name filter on instance panel doesn't work" [Undecided,New] - Assigned to Feilong Wang (flwang)18:24
ying_zuono worries :)18:24
robcresswellflwang1: isn't there already a Nova extensions blacklist setting?18:25
flwang1robcresswell: yep, hence why i want to add a white list to reduce unnecessary calls18:26
flwang1in our env, those function calls take 0.2-0.3 second18:26
flwang1and with a white list in settings.py, the number will be 0.01 second18:27
*** gyee has quit IRC18:27
*** gyee has joined #openstack-horizon18:29
*** jlabarre has quit IRC18:33
ying_zuoflwang1: where is the blacklist being set?18:34
*** gyee has quit IRC18:37
*** gyee has joined #openstack-horizon18:38
flwang1ying_zuo: wait a sec18:38
flwang1https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/nova.py#L98918:39
flwang1it's set by ops in settings.py18:39
*** gyee has quit IRC18:39
flwang1ying_zuo: robcresswell: so for the image filter issue, i can't see there is good way to fix them, they're limitations18:42
ying_zuohmm. should probably have a default value for it set on either local_settings or settings18:42
flwang1ying_zuo: you mean the extension list? yep, it would be nice18:42
flwang1and the list extension API will be called when loading horizon first time18:43
*** gyee has joined #openstack-horizon18:45
*** cshen_ has quit IRC18:47
ying_zuohaving a whitelist is not a very robust solution18:49
flwang1ying_zuo: i understand. so i just want to get some feedback from you guys, otherwise, we may keep it in our private repo18:49
ying_zuoit can be a long list18:50
flwang1ying_zuo: no, not really18:50
flwang1you can only put the names you cared18:50
flwang1for instance list panel, only two names18:50
flwang1Shelve, AdminActions18:51
ying_zuoI think there are more18:52
ying_zuooh, just for extensions18:53
ying_zuoif we already have a blacklist maybe it's okay to have a whitelist too18:55
flwang1ying_zuo: it would be nice if you can leave your comments on the bug/patch, so that we can work out a final decision18:57
flwang1and I do need your comments on the image name filter bug18:57
ying_zuoare you going to be around in an hour?18:58
flwang1yep, i'm going to office now and will be online after 1.5 hours18:59
ying_zuookay. I just added the image name filter bug to the list for the weekly meeting https://etherpad.openstack.org/p/horizon-bug-review19:00
flwang1don't think the traffic at Wellington is bad, i'm going to grab breakfast and then send my kids to kindergarten ;)19:00
flwang1ying_zuo: cool, thanks a lot19:00
*** cshen_ has joined #openstack-horizon19:09
*** mvk has joined #openstack-horizon19:18
*** flwang1 has quit IRC19:22
ying_zuoWeekly Horizon meeting will start in half hour.  #openstack-meeting-319:30
*** gary-smith has joined #openstack-horizon19:30
*** gyee has quit IRC19:31
*** makowals_ has joined #openstack-horizon19:39
*** e0ne has joined #openstack-horizon19:40
*** gyee has joined #openstack-horizon19:51
*** ppiela_ has quit IRC19:52
robcresswellflwang, ying_zuo: why a blacklist *and* a whitelist?19:52
robcresswellThat's just more logic to muddle settings with :19:53
robcresswell:/ *19:53
robcresswellflwang: If there's already a blacklist... can't you just put all the extensions in there, and you're done?19:53
*** gyee has quit IRC19:57
*** jamesbenson has quit IRC19:58
*** harlowja has quit IRC20:00
*** itlinux has joined #openstack-horizon20:03
*** cshen_ has quit IRC20:03
*** cshen_ has joined #openstack-horizon20:03
*** jamesbenson has joined #openstack-horizon20:07
*** jamesbenson has quit IRC20:09
*** jamesbenson has joined #openstack-horizon20:13
*** tsmith has joined #openstack-horizon20:16
flwangrobcresswell: that's a good point, though I don't think the blacklist should be used for my purpose20:22
robcresswellflwang: Could you elaborate?20:23
*** flwang1 has joined #openstack-horizon20:23
flwangmy purpose is checking if the extension is supported or not, to save the calls to nova api and even the functions in api/nova.py20:24
flwangso do you think i should just check if the extention name is in the blacklist, if it's not, then I think it's supported?20:25
*** cshen_ has quit IRC20:25
flwangrobcresswell:  currently, Horizon will do things like https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/tables.py#L28020:27
flwangthen call https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/nova.py#L99920:28
flwangas I mentioned in the bug, now there are 5 actions are doing the check like this, and there are 20 instances per pages20:28
robcresswellRight, but if you just blacklist that extension...20:29
flwangso 100 calls, with cache, it still take about 0.2 seconds20:29
*** marlinc has quit IRC20:29
flwangrobcresswell: in otherwords, not in blacklist doesn't mean the nova server supports that20:30
flwangbut if it's in a whitelist, that means the extension name is added explicitly by ops, because ops know what they're doing20:31
flwangrobcresswell: does that make any sense?20:31
*** gary-smith__ has joined #openstack-horizon20:31
robcresswellflwang: Not really. If 0.2 seconds is truly unbearable, just put every extension in the blacklist and explicitly remove the ones your support20:33
robcresswellthats identical to a whitelist anyway20:33
robcresswellExcept without Horizon having to carry logic for both20:34
*** gary-smith has quit IRC20:34
*** priteau has quit IRC20:38
*** gary-smith has joined #openstack-horizon20:50
*** gary-smith__ has quit IRC20:51
*** gary-smith has quit IRC20:55
*** lblanchard1 has quit IRC20:59
*** makowals_ has quit IRC21:00
robcresswellflwang: I'd prefer if we kept the image name there. Just make the ID a popover. problem solved.21:01
robcresswellThen remove the image name filter, because its a magic Horizon invention (we have got to stop doing those)21:01
flwangrobcresswell: but we also need to remove the image name filter?21:01
robcresswellYup21:01
*** catintheroof has quit IRC21:02
e0nebugs discussions are very useful and important, but we have no time for other topics:(21:03
ying_zuooh sorry e0ne21:04
e0nerobcresswell, flwang: glance v2 api supports image filtering by name. can we use it?21:04
david-lylerobcresswell, the API supports filtering by name21:04
robcresswelldavid-lyle: The Nova API?21:04
ying_zuoI see you added a topic on the meeting note21:04
david-lylewe just have to pass the query parameter21:04
e0neying_zuo: np, it's not something that blocks me21:04
david-lyleno image21:04
flwange0ne: as i mentioned, it still returns a list21:04
flwangso that said, there are two images with same name21:04
e0neflwang: yes, we have to map the correct image to instance21:04
flwangyou got two images and which one is the one you care about?21:05
david-lyleflwang, yes I don't think names are exclusive21:05
robcresswellI guess the other alternative is just to assume people don't give their images the same name.21:05
e0neflwang: I'm more concerned about performance as pointed above21:05
david-lyleflwang, it doesn't matter, the API will return all the match21:05
david-lyleit's up to the user beyond that21:05
flwange0ne: yep, the performance is the one i really care about21:05
e0neflwang: +1 on performance21:06
flwangand you can see I have proposed several patches about the instance panel performance21:06
robcresswelldavid-lyle: I think the issue is that its not obvious which image you'll actually be filtering by if you just take the first in a list21:06
robcresswellUnless you go through each and concat them all21:06
david-lylerobcresswell, I'm saying it doesn't matter21:06
david-lyleall matches based on name are valid21:06
e0neflwang: thanks for them. I appreciate your help21:06
david-lylethe user can filter beyond that21:06
flwangdavid-lyle: no21:06
robcresswelldavid-lyle: How?21:07
flwanguser can't do that21:07
robcresswellIt's a single keyword filter21:07
flwangbecause horizon always pick the first one21:07
david-lylethey have a brain21:07
david-lyle:)21:07
david-lylebut artificially filtering for them is wrong21:07
flwangfor that case, why don't let them filter by id21:07
*** harlowja has joined #openstack-horizon21:07
ying_zuoe0ne: I made a note to talk about the mox to mock migration before reviewing the bug reports in the next meeting21:08
david-lylethat is also allowed21:08
david-lyleimage_id and image_name are acceptable filters21:08
robcresswelldavid-lyle: So, get every image that matches the name, then get the instances that match each ID and return that entire list? Because atm, we just return whatever is first in the list glance returns21:08
david-lyleThe API call is different21:08
e0neying_zuo: thanks21:08
robcresswellWhich is problematic, because the user has no control over that21:08
*** jamesbenson has quit IRC21:09
david-lyleI'm not claiming the current implementation is correct, but it could be made correct by making the correct API query21:09
robcresswellSure21:09
e0neying_zuo: probably, we should start meetings with proposed topics if any and then continue bugs discussion21:09
ying_zuoe0ne: yes21:10
e0neying_zuo: but it's up to you and rest of the community to decide how to deal with meetings :)21:10
david-lylegary-smith_, I triaged the bug you mentioned me on from the meeting, thanks, it should be a rather simple fix21:11
flwangrobcresswell: david-lyle: so what's the conclusion? the main purpose I'd like to do is improve the performance actually ;)21:11
e0neflwang, robcresswell, david-lyle: I have to go, it's 12am already in my TZ.  I'll read the conversation tomorrow and will be ready to help if needed21:11
robcresswelle0ne: \o21:11
flwangand fix it bug by the way if there is21:11
flwange0ne: thanks, have a good night21:12
e0neflwang: IMO, we should support only that kind of filters, which are implemented by APIs21:13
e0neflwang: thanks21:13
david-lyleflwang, I'm for the performance improvement of providing setting to not get image name.21:13
david-lyleI think the filter is debatable, it's doable, but is it an overreach for the instances panel to be filtering on a different API result21:13
*** jtomasek has quit IRC21:14
*** jtriley has quit IRC21:15
flwangdavid-lyle: ok, I will focus on the image name configurable first21:15
david-lyleflwang, you had a bug for the filter problem, what was the number?21:18
flwanghttps://bugs.launchpad.net/horizon/+bug/172270421:18
openstackLaunchpad bug 1722704 in OpenStack Dashboard (Horizon) "Image name filter on instance panel doesn't work" [Undecided,New] - Assigned to Feilong Wang (flwang)21:18
david-lyleflwang, do you want me to take that?21:19
david-lyleI imagine the problem is larger than just that21:19
flwangdavid-lyle: feel free to take it21:20
flwangdavid-lyle: but i have a condition21:20
flwangdavid-lyle: please review my performance patches ;)21:20
david-lyleI reviewed the image setting one, I need to look at it again21:21
flwangdavid-lyle: for example, https://review.openstack.org/#/c/510718/21:21
david-lylethat was just a quick tour21:21
flwangand https://review.openstack.org/51109521:21
flwanginstance panel is calling too many api calls21:21
david-lylethe floating IP sync was added because of operator demand :)21:22
david-lylenow we have to have an operator grudge match21:22
david-lylethe delay on fIP sync can be quite large21:23
flwangdavid-lyle: ok, why don't just get the FIP instead of everything?21:23
flwangcurrently, those neutron API calls take 1.3-1.5 seconds in our env21:24
david-lyleflwang, I agree it makes too many API calls21:24
david-lyleunfortunately it's the panel that everyone want to tie everything together on21:24
david-lyleand most of the APIs are not intended to be user consumable alone21:25
david-lyleso we have to balance usability and performance21:25
david-lyleI would prefer getting an async load of the data going rather than removing the usability elements21:26
david-lylebecause values like UUIDs are fairly useless alone21:27
david-lylehence image name lookup21:27
david-lyleproject name lookup21:27
david-lyleflwang, I completely understand your frustration21:28
david-lylethis is why we tried moving toward angular and async loading, we just have been reeeaaaalllly slow at it21:29
flwangdavid-lyle: thank you, and i totally understand the situation21:29
david-lyleit won't fix everything, but perceived page load speed will be much better21:29
flwangyep, TBH, currently, the page is taking 9-10 seconds if there are 20 instances on the page21:30
flwangthat's very bad experience21:30
david-lyleflwang, indeed21:30
*** e0ne has quit IRC21:31
david-lylemaybe your image name lookup setting should be expanded to instance panel performance in general21:31
*** wolverineav has quit IRC21:31
flwangdavid-lyle: that's what i was going to do21:32
david-lyleI fear the code will become a mess of if/else21:32
flwangbefore we totally angulaize the page21:32
david-lylebut maybe that's what we have to do21:32
flwangcould we have a dict in settings.py to turn off something, like the image name, to speed up the page from different angels?21:32
david-lylesure21:33
flwangwould you mind giving a good name? as I'm not a English native speaker21:33
robcresswellI wonder how much work this is, over just adopting the angular instances panel21:34
robcresswellRichard worked on that for a few weeks21:34
flwangso that we have     xxxx = {"ENABLE_INSTANCE_IMAGENAME": True,  "ENABLE_NEUTEON_REALTIME_FIP": True}21:35
flwangrobcresswell: could we have it in Queens?21:35
david-lylemaybe something around "performance_flags"21:35
david-lyleand change ENABLE to DISABLE21:35
robcresswellflwang: Probably, if someone wants to adopt it21:35
robcresswellThen it would be much easier to load the panel and async all the other data21:36
david-lyleit just needs an owner21:36
david-lylerobcresswell, I agree21:36
flwangrobcresswell: but ying_zuo told me now there is nobody working on the angularize stuff for instance panel21:36
flwangit sounds like we have everything but a developer21:36
david-lyleflwang, robcresswell is saying if you're going to put this much time into the current panel, you should just finish the angular panel21:36
david-lyleI think21:36
robcresswelldavid-lyle: +121:37
flwangdavid-lyle: ok, i see. but i don't have the skill  of angularJS21:37
david-lyleno one does, we'll never know21:37
flwangI mostly work on the backend, you know21:37
david-lyle:)21:37
robcresswellMy point is that all this time making the Python panel "less bad" could just be invested into making a good panel :p21:37
flwangzaqar, nova, ceilometer, balablabla21:37
flwangbut not Js and css21:37
robcresswellflwang: *shrug* I dont really know anything, but I manage to contribute :p21:38
david-lyleJs is just like python with some exceptions21:38
flwangdavid-lyle: and another thing is we're using stable pike21:38
flwangand I don't have much time to get this done (in angularJS)21:39
flwangI'm sorry21:39
david-lyleflwang, well your fixes likely won't qualify for a backport21:39
david-lylebut a new panel can be turned on fairly easily21:39
david-lyleI htink most of the REST API support is already there21:39
* david-lyle would have to check on the last part21:39
david-lyleflwang, fair enough21:39
david-lylebut what we're proposing for the current panel is going to make a mess of it21:40
david-lyleand it's going to be very hard to maintain21:40
david-lyleIMO21:41
flwangdavid-lyle: ok, but at least that's the thing i'd like to figure out, if community is not happy with the work I'm proposing, we may have to keep them in private repo21:41
robcresswellHence our reluctance on some of the changes :)21:41
robcresswellSome sound okay. Happy to keep evaluating on a case-by-case basis.21:41
flwangdavid-lyle: yep, i totally understand21:41
robcresswellI'm gonna head off; will catch up with rest of conversation tomorrow21:42
robcresswellnight all21:42
flwangrobcresswell: good night, thanks21:42
flwangdavid-lyle: so basically the image name configurable should be ok?21:42
flwangand the neutron one is not?21:42
flwangdavid-lyle: and do you think this one is backportable https://review.openstack.org/511072 ?21:43
david-lyleflwang, that one's tough, I think amotoki's interpretation is accurate21:48
flwangdavid-lyle: ok, fair enough21:50
*** ppiela has joined #openstack-horizon21:51
*** gary-smith has joined #openstack-horizon22:27
*** wolverineav has joined #openstack-horizon22:27
*** felipemonteiro_ has quit IRC22:34
*** felipemonteiro_ has joined #openstack-horizon22:34
*** marlinc has joined #openstack-horizon22:35
*** priteau has joined #openstack-horizon22:39
*** priteau has quit IRC22:44
*** wolverineav has quit IRC22:54
*** wolverineav has joined #openstack-horizon22:55
*** wolverineav has quit IRC22:59
*** priteau has joined #openstack-horizon23:01
*** priteau has quit IRC23:06
*** felipemonteiro_ has quit IRC23:12
*** yamamoto has joined #openstack-horizon23:28
*** jtriley has joined #openstack-horizon23:38
*** tosky has quit IRC23:43
*** ppiela has quit IRC23:54
*** itlinux has quit IRC23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!