| *** felipemonteiro__ has quit IRC | 00:01 | |
| *** btully has joined #openstack-horizon | 00:02 | |
| *** btully has quit IRC | 00:06 | |
| *** yamamoto_ has joined #openstack-horizon | 00:13 | |
| *** yamamoto_ has quit IRC | 00:13 | |
| *** lblanchard has joined #openstack-horizon | 00:41 | |
| *** zhurong has joined #openstack-horizon | 00:52 | |
| *** yamamoto_ has joined #openstack-horizon | 01:14 | |
| *** lcastell has joined #openstack-horizon | 01:20 | |
| *** yamamoto_ has quit IRC | 01:20 | |
| *** lcastell has quit IRC | 01:32 | |
| *** btully has joined #openstack-horizon | 01:50 | |
| *** btully has quit IRC | 01:55 | |
| *** yamamoto_ has joined #openstack-horizon | 02:16 | |
| *** yamamoto_ has quit IRC | 02:22 | |
| *** dave-mccowan has quit IRC | 02:32 | |
| *** lblanchard has quit IRC | 02:43 | |
| *** yamamoto has joined #openstack-horizon | 02:49 | |
| *** georgem11 has joined #openstack-horizon | 02:50 | |
| *** felipemonteiro__ has joined #openstack-horizon | 02:51 | |
| *** felipemonteiro_ has joined #openstack-horizon | 02:55 | |
| *** felipemonteiro has joined #openstack-horizon | 02:57 | |
| *** felipemonteiro__ has quit IRC | 02:59 | |
| *** georgem11 has quit IRC | 02:59 | |
| *** felipemonteiro_ has quit IRC | 03:00 | |
| *** felipemonteiro has quit IRC | 03:11 | |
| *** yamamoto has quit IRC | 03:12 | |
| *** itlinux has joined #openstack-horizon | 03:13 | |
| *** gary-smith__ has joined #openstack-horizon | 03:15 | |
| *** udesale has joined #openstack-horizon | 03:50 | |
| openstackgerrit | Feilong Wang proposed openstack/horizon master: Get flavor list sorted when launching instance https://review.openstack.org/498672 | 03:58 |
|---|---|---|
| *** gyee has quit IRC | 04:09 | |
| *** hoonetorg has quit IRC | 04:11 | |
| *** yamamoto has joined #openstack-horizon | 04:13 | |
| *** yamamoto has quit IRC | 04:19 | |
| *** itlinux has quit IRC | 04:19 | |
| *** shu-mutou-AWAY is now known as shu-mutou | 04:20 | |
| *** zhurong has quit IRC | 04:21 | |
| *** hoonetorg has joined #openstack-horizon | 04:23 | |
| *** felipemonteiro has joined #openstack-horizon | 04:37 | |
| *** felipemonteiro has quit IRC | 04:47 | |
| openstackgerrit | Shu Muto proposed openstack/horizon master: Add delete action for key pair https://review.openstack.org/482040 | 04:56 |
| *** zhurong has joined #openstack-horizon | 04:56 | |
| *** lajoskatona has joined #openstack-horizon | 05:00 | |
| *** yamamoto has joined #openstack-horizon | 05:15 | |
| *** yamamoto has quit IRC | 05:21 | |
| *** ratailor has joined #openstack-horizon | 05:24 | |
| *** masco has joined #openstack-horizon | 05:28 | |
| *** btully has joined #openstack-horizon | 05:28 | |
| *** btully has quit IRC | 05:32 | |
| openstackgerrit | Shu Muto proposed openstack/horizon master: Add delete action for key pair https://review.openstack.org/482040 | 05:36 |
| openstackgerrit | Shu Muto proposed openstack/horizon master: Add create and import key pair actions https://review.openstack.org/482113 | 05:39 |
| *** hoangcx has quit IRC | 05:41 | |
| *** hoangcx has joined #openstack-horizon | 05:42 | |
| openstackgerrit | Shu Muto proposed openstack/horizon master: Add create and import key pair actions https://review.openstack.org/482113 | 05:47 |
| *** yamamoto has joined #openstack-horizon | 06:13 | |
| *** TravT_ has joined #openstack-horizon | 06:18 | |
| *** TravT has quit IRC | 06:20 | |
| *** yamamoto has quit IRC | 06:38 | |
| *** yamamoto has joined #openstack-horizon | 06:39 | |
| *** yamamoto has quit IRC | 06:39 | |
| *** pcaruana has joined #openstack-horizon | 06:39 | |
| *** gary-smith__ has quit IRC | 06:54 | |
| *** rcernin has joined #openstack-horizon | 07:10 | |
| *** zhurong has quit IRC | 07:15 | |
| *** btully has joined #openstack-horizon | 07:17 | |
| *** zhurong has joined #openstack-horizon | 07:17 | |
| *** btully has quit IRC | 07:21 | |
| *** tesseract has joined #openstack-horizon | 07:25 | |
| *** gxn is now known as xinni90 | 07:29 | |
| *** jpich has joined #openstack-horizon | 07:32 | |
| *** jtomasek has quit IRC | 07:37 | |
| *** jtomasek_ has joined #openstack-horizon | 07:37 | |
| *** ratailor is now known as ratailor|Lunch | 07:39 | |
| *** yamamoto has joined #openstack-horizon | 07:40 | |
| *** yamamoto has quit IRC | 07:45 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon master: Remove remainder of run_tests references https://review.openstack.org/494200 | 07:54 |
| *** slunkad has quit IRC | 08:13 | |
| *** slunkad has joined #openstack-horizon | 08:14 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon master: Remove remainder of run_tests references https://review.openstack.org/494200 | 08:15 |
| *** ratailor|Lunch is now known as ratailor | 08:29 | |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: flake8-import-order: Ensure to place project imports last https://review.openstack.org/495733 | 08:29 |
| openstackgerrit | Ferenc Cserepkei proposed openstack/horizon master: WIP: Add "prev" link to instance page list pagination https://review.openstack.org/498018 | 08:39 |
| *** yamamoto has joined #openstack-horizon | 08:42 | |
| *** yamamoto has quit IRC | 08:47 | |
| *** tosky has joined #openstack-horizon | 08:55 | |
| *** kei1 has quit IRC | 08:58 | |
| *** kei1 has joined #openstack-horizon | 08:58 | |
| *** xinni90 is now known as xinni9e_ | 09:01 | |
| *** ratailor_ has joined #openstack-horizon | 09:01 | |
| *** ratailor_ has quit IRC | 09:01 | |
| *** ratailor_ has joined #openstack-horizon | 09:02 | |
| *** kei1 has quit IRC | 09:02 | |
| *** kei1 has joined #openstack-horizon | 09:03 | |
| *** ratailor has quit IRC | 09:04 | |
| *** rmart04 has joined #openstack-horizon | 09:06 | |
| *** xinni9e_ has quit IRC | 09:15 | |
| *** ratailor has joined #openstack-horizon | 09:22 | |
| *** btully has joined #openstack-horizon | 09:22 | |
| *** ratailor_ has quit IRC | 09:26 | |
| *** btully has quit IRC | 09:35 | |
| *** yamamoto has joined #openstack-horizon | 09:43 | |
| *** yamamoto has quit IRC | 09:49 | |
| *** itxaka has joined #openstack-horizon | 09:53 | |
| *** ethfci has quit IRC | 09:56 | |
| *** xinni9e has joined #openstack-horizon | 09:58 | |
| *** udesale has quit IRC | 10:02 | |
| *** ratailor has quit IRC | 10:07 | |
| *** ethfci has joined #openstack-horizon | 10:08 | |
| *** ratailor has joined #openstack-horizon | 10:08 | |
| *** ethfci has quit IRC | 10:09 | |
| openstackgerrit | Shu Muto proposed openstack/horizon master: Remove deprecated initScope https://review.openstack.org/498741 | 10:14 |
| *** shu-mutou is now known as shu-mutou-AWAY | 10:17 | |
| openstackgerrit | Merged openstack/horizon master: Delete unnecessary judgment when getting the neutron quota https://review.openstack.org/498330 | 10:32 |
| *** zhurong has quit IRC | 10:35 | |
| *** felipemonteiro has joined #openstack-horizon | 10:44 | |
| *** yamamoto has joined #openstack-horizon | 10:45 | |
| *** ethfci has joined #openstack-horizon | 10:48 | |
| *** felipemonteiro has quit IRC | 10:48 | |
| *** yamamoto has quit IRC | 10:51 | |
| *** e0ne has joined #openstack-horizon | 10:52 | |
| *** wolverineav has joined #openstack-horizon | 10:53 | |
| *** e0ne has quit IRC | 10:56 | |
| *** e0ne has joined #openstack-horizon | 10:57 | |
| openstackgerrit | Marek Lyčka proposed openstack/horizon master: Orderes the projects in the primary project combo https://review.openstack.org/498460 | 10:58 |
| *** e0ne has quit IRC | 11:14 | |
| *** e0ne has joined #openstack-horizon | 11:26 | |
| *** zhurong has joined #openstack-horizon | 11:34 | |
| *** udesale has joined #openstack-horizon | 11:36 | |
| *** ratailor has quit IRC | 11:38 | |
| *** yamamoto has joined #openstack-horizon | 11:47 | |
| *** yamamoto has quit IRC | 11:52 | |
| *** dave-mccowan has joined #openstack-horizon | 12:06 | |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: update_catalog: Simplify help message https://review.openstack.org/498784 | 12:20 |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: extract_messages, update_catalog: Simplify help message https://review.openstack.org/498784 | 12:35 |
| *** zhurong has quit IRC | 12:36 | |
| *** obre has quit IRC | 12:39 | |
| *** obre has joined #openstack-horizon | 12:40 | |
| *** obre has quit IRC | 12:42 | |
| *** obre has joined #openstack-horizon | 12:42 | |
| *** lucasxu has joined #openstack-horizon | 12:42 | |
| openstackgerrit | wei.ying proposed openstack/horizon master: Disable 'Create Port' button if ports quota is exceeded https://review.openstack.org/496692 | 12:44 |
| *** obre has quit IRC | 12:45 | |
| *** obre has joined #openstack-horizon | 12:46 | |
| *** felipemonteiro has joined #openstack-horizon | 12:46 | |
| *** yamamoto has joined #openstack-horizon | 12:49 | |
| *** felipemonteiro_ has joined #openstack-horizon | 12:49 | |
| *** felipemonteiro__ has joined #openstack-horizon | 12:50 | |
| *** zhurong has joined #openstack-horizon | 12:50 | |
| *** felipemonteiro has quit IRC | 12:52 | |
| *** yamamoto has quit IRC | 12:54 | |
| *** felipemonteiro_ has quit IRC | 12:54 | |
| *** georgem1 has joined #openstack-horizon | 13:08 | |
| *** hoonetorg has quit IRC | 13:08 | |
| *** btully has joined #openstack-horizon | 13:09 | |
| *** hoonetorg has joined #openstack-horizon | 13:09 | |
| e0ne | rdopiera: hi. thanks for review | 13:12 |
| *** niraj_singh has joined #openstack-horizon | 13:13 | |
| *** btully has quit IRC | 13:13 | |
| rdopiera | e0ne: it seems that the exception is not being handled properly for some reason | 13:16 |
| e0ne | rdopiera: yes, it failed only if we go inside https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/keystone.py#L169 | 13:17 |
| e0ne | rdopiera: I'm digging into the it | 13:17 |
| *** catintheroof has joined #openstack-horizon | 13:19 | |
| *** dave-mccowan has quit IRC | 13:19 | |
| *** lblanchard has joined #openstack-horizon | 13:24 | |
| *** belmoreira has joined #openstack-horizon | 13:26 | |
| e0ne | rdopiera: looks like I've found the root cause. try to run unit tests with a fix | 13:29 |
| *** udesale has quit IRC | 13:30 | |
| *** mrcc has joined #openstack-horizon | 13:30 | |
| *** masco has quit IRC | 13:32 | |
| *** jtriley has joined #openstack-horizon | 13:33 | |
| *** sergio__ has joined #openstack-horizon | 13:33 | |
| rdopiera | e0ne: what fix? | 13:34 |
| e0ne | rdopiera: https://review.openstack.org/#/c/491479/8/horizon/exceptions.py - line #230, there should be a 'raise' not 'return' | 13:35 |
| e0ne | rdopiera: if we return any value, 'handle' method (line #331) will continue to run a normal flow | 13:36 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Show NotAuthorized error message on a separate page https://review.openstack.org/491479 | 13:37 |
| rdopiera | e0ne: that helped with /admin, but I can still visit /admin/hypervisors/ | 13:38 |
| e0ne | omg | 13:40 |
| *** dave-mccowan has joined #openstack-horizon | 13:41 | |
| e0ne | rdopiera: how do we set permissions for pages/panels? | 13:41 |
| rdopiera | in the policy | 13:42 |
| rdopiera | and in the allowed method of the panel | 13:42 |
| rdopiera | however, in this case you should catch the exception from the API, I think | 13:42 |
| e0ne | I have to verify all admin pages | 13:50 |
| *** yamamoto has joined #openstack-horizon | 13:50 | |
| *** yamamoto has quit IRC | 13:56 | |
| *** zhurong has quit IRC | 14:03 | |
| e0ne | rdopiera: I've got bad news:( http://paste.openstack.org/show/619772/ | 14:08 |
| e0ne | rdopiera: Should I fix it in scope of this bug or file a new one? | 14:09 |
| e0ne | IMO, it should be done in scope of a separate bug and patch | 14:11 |
| *** jtriley has quit IRC | 14:12 | |
| kairat | robcresswell, ping | 14:18 |
| robcresswell | kairat: o/ | 14:18 |
| kairat | robcresswell, i am trying to realize part of code in your commit | 14:18 |
| kairat | https://github.com/openstack/horizon/commit/b0099bbb870e4664185e724850db3fdb7887a903 | 14:18 |
| kairat | it is hard to realize why !$scope.model.newInstanceSpec.source_type has been deleted | 14:19 |
| * robcresswell tries to remember | 14:19 | |
| robcresswell | kairat: Honestly, I dont remember | 14:21 |
| robcresswell | kairat: Is that what caused the bug you fixed? | 14:21 |
| kairat | the only thing i can imagine is make the first element in array to be determenistic | 14:22 |
| kairat | yep it has broken several things | 14:22 |
| robcresswell | damn | 14:22 |
| robcresswell | kairat: What else? | 14:22 |
| robcresswell | Gah I hate this code. | 14:22 |
| kairat | any launch instance with context (image, snapshot, volume) | 14:23 |
| kairat | without !$scope.model.newInstanceSpec.source_type launch instance become racy | 14:24 |
| kairat | so scenario is the following: | 14:24 |
| kairat | i created image | 14:24 |
| kairat | i push launch button | 14:24 |
| kairat | i get image in context | 14:25 |
| kairat | appropriate watcher has been called | 14:25 |
| kairat | source_type also set | 14:25 |
| kairat | and after that allowedbootsources watchers are launched | 14:26 |
| kairat | and source_type goes to hell | 14:26 |
| *** gary-smith__ has joined #openstack-horizon | 14:26 | |
| kairat | robcresswell, was description clear? | 14:26 |
| *** felipemonteiro__ has quit IRC | 14:26 | |
| *** felipemonteiro__ has joined #openstack-horizon | 14:26 | |
| robcresswell | Not really :) | 14:27 |
| robcresswell | So, I'd assume that I made that change so that the boot source always got updated every time a new source_type was added | 14:27 |
| robcresswell | and then re-orders it, so the order is always the same | 14:27 |
| kairat | but sometimes source_type has already chosen | 14:28 |
| robcresswell | Yes | 14:28 |
| kairat | when you launch from image or volume and we shouldn't rewrite it from allowedboot sources watchers | 14:29 |
| *** jtriley has joined #openstack-horizon | 14:29 | |
| kairat | but we do rewrite | 14:29 |
| kairat | 3without condition i mentioned | 14:29 |
| robcresswell | So its seeing that it wants to launch from volume, then re-evaluating that to Image since Image is first? | 14:29 |
| robcresswell | after being ordered | 14:29 |
| kairat | yep | 14:29 |
| robcresswell | But why does that cause the issue with missing data? | 14:30 |
| kairat | same for snapshots | 14:30 |
| robcresswell | iirc your patch was because an image wasnt showing up when a user clicked launch from image | 14:30 |
| robcresswell | I guess it needs a refactor :( | 14:30 |
| kairat | ++ | 14:30 |
| kairat | it seems i didn't get true root cause | 14:30 |
| kairat | the code isquite hard to read and i am not js expert tbh =) | 14:31 |
| *** felipemonteiro__ has quit IRC | 14:31 | |
| kairat | but i realized issue after our QA re-opened a bug | 14:31 |
| *** gary-smith__ has quit IRC | 14:31 | |
| kairat | i am thinking how to fix it in right way | 14:32 |
| kairat | if we return !$scope.model.newInstanceSpec.source_type then source_type will be non-determinstic again | 14:34 |
| robcresswell | kairat: Yep. | 14:34 |
| kairat | as an option i could update boot source only if there are no items preselected | 14:37 |
| kairat | it seems hacky but it will work | 14:37 |
| kairat | robcresswell, WDYT? | 14:38 |
| robcresswell | kairat: That seems sensible | 14:38 |
| kairat | ok, hope to finish it before vacation=) | 14:39 |
| *** chlong has joined #openstack-horizon | 14:41 | |
| *** jamesbenson has joined #openstack-horizon | 14:41 | |
| *** mrcc has quit IRC | 14:42 | |
| *** lajoskatona has quit IRC | 14:43 | |
| *** itlinux has joined #openstack-horizon | 14:49 | |
| *** ratailor has joined #openstack-horizon | 14:51 | |
| *** yamamoto has joined #openstack-horizon | 14:52 | |
| *** yamamoto has quit IRC | 14:58 | |
| *** lennyb has quit IRC | 15:12 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/horizon master: Properly sort Heat stacks on Created field https://review.openstack.org/498838 | 15:13 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Speed up quotas fetching using futurist library https://review.openstack.org/483948 | 15:13 |
| *** felipemonteiro has joined #openstack-horizon | 15:14 | |
| *** itlinux has quit IRC | 15:15 | |
| *** felipemonteiro has quit IRC | 15:19 | |
| *** gyee has joined #openstack-horizon | 15:21 | |
| *** lennyb has joined #openstack-horizon | 15:24 | |
| *** rmart04 has quit IRC | 15:32 | |
| *** e0ne has quit IRC | 15:42 | |
| *** sergio__ has quit IRC | 15:49 | |
| *** lcastell has joined #openstack-horizon | 15:50 | |
| *** sergio__ has joined #openstack-horizon | 15:50 | |
| *** felipemonteiro has joined #openstack-horizon | 15:52 | |
| *** yamamoto has joined #openstack-horizon | 15:54 | |
| *** ratailor has quit IRC | 15:56 | |
| *** yamamoto has quit IRC | 16:00 | |
| openstackgerrit | Ferenc Cserepkei proposed openstack/horizon master: Add "prev" link to instance page list pagination https://review.openstack.org/498018 | 16:03 |
| *** gary-smith_ has joined #openstack-horizon | 16:13 | |
| *** tesseract has quit IRC | 16:15 | |
| *** itlinux has joined #openstack-horizon | 16:23 | |
| *** jpich has quit IRC | 16:38 | |
| *** felipemonteiro has quit IRC | 16:41 | |
| *** rcernin has quit IRC | 16:46 | |
| *** belmoreira has quit IRC | 16:46 | |
| *** belmoreira has joined #openstack-horizon | 16:47 | |
| *** belmoreira has quit IRC | 16:48 | |
| *** itlinux has quit IRC | 16:48 | |
| *** pcaruana has quit IRC | 16:48 | |
| *** itlinux has joined #openstack-horizon | 16:49 | |
| *** dave-mccowan has quit IRC | 16:50 | |
| *** yamamoto has joined #openstack-horizon | 16:56 | |
| *** yamamoto has quit IRC | 17:02 | |
| *** catintheroof has quit IRC | 17:49 | |
| *** yamamoto has joined #openstack-horizon | 17:58 | |
| *** felipemonteiro has joined #openstack-horizon | 18:01 | |
| *** lucasxu has quit IRC | 18:01 | |
| *** yamamoto has quit IRC | 18:04 | |
| *** wolverineav has quit IRC | 18:14 | |
| *** wolverineav has joined #openstack-horizon | 18:16 | |
| *** catintheroof has joined #openstack-horizon | 18:23 | |
| *** itxaka has quit IRC | 18:23 | |
| *** georgem1 has left #openstack-horizon | 18:28 | |
| *** jtomasek_ has quit IRC | 18:59 | |
| *** yamamoto has joined #openstack-horizon | 18:59 | |
| *** early has quit IRC | 18:59 | |
| *** early has joined #openstack-horizon | 19:02 | |
| *** yamamoto has quit IRC | 19:05 | |
| *** yamamoto has joined #openstack-horizon | 19:27 | |
| *** catintheroof has quit IRC | 19:30 | |
| *** e0ne has joined #openstack-horizon | 19:34 | |
| *** dave-mccowan has joined #openstack-horizon | 19:35 | |
| *** catintheroof has joined #openstack-horizon | 19:36 | |
| *** e0ne has quit IRC | 19:47 | |
| *** e0ne has joined #openstack-horizon | 19:53 | |
| *** belmoreira has joined #openstack-horizon | 20:04 | |
| *** e0ne has quit IRC | 20:14 | |
| *** felipemonteiro has quit IRC | 20:16 | |
| *** felipemonteiro has joined #openstack-horizon | 20:16 | |
| *** felipemonteiro_ has joined #openstack-horizon | 20:17 | |
| *** felipemonteiro has quit IRC | 20:21 | |
| *** alexvictorchan has joined #openstack-horizon | 20:27 | |
| *** jtriley has quit IRC | 20:37 | |
| *** yamamoto has quit IRC | 21:04 | |
| *** lblanchard has quit IRC | 21:07 | |
| *** yamamoto has joined #openstack-horizon | 21:08 | |
| *** yamamoto has quit IRC | 21:30 | |
| *** yamamoto has joined #openstack-horizon | 21:32 | |
| *** yamamoto has quit IRC | 21:32 | |
| *** catintheroof has quit IRC | 21:34 | |
| *** belmoreira has quit IRC | 21:49 | |
| *** felipemonteiro_ has quit IRC | 21:53 | |
| *** jamesbenson has quit IRC | 21:57 | |
| *** jamesbenson has joined #openstack-horizon | 21:58 | |
| *** jamesben_ has joined #openstack-horizon | 22:00 | |
| *** jamesbenson has quit IRC | 22:02 | |
| *** jamesben_ has quit IRC | 22:04 | |
| *** itlinux has quit IRC | 22:14 | |
| *** lbragstad has quit IRC | 22:20 | |
| *** wolverineav has quit IRC | 22:38 | |
| *** wolverineav has joined #openstack-horizon | 22:38 | |
| *** wolverineav has quit IRC | 22:43 | |
| openstackgerrit | Feilong Wang proposed openstack/horizon master: Get flavor list sorted when launching instance https://review.openstack.org/498672 | 23:00 |
| *** gary-smith_ has quit IRC | 23:15 | |
| *** tosky has quit IRC | 23:15 | |
| *** ianychoi has quit IRC | 23:17 | |
| *** ianychoi has joined #openstack-horizon | 23:17 | |
| *** yamamoto has joined #openstack-horizon | 23:28 | |
| *** lblanchard has joined #openstack-horizon | 23:35 | |
| *** yamamoto has quit IRC | 23:46 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!