| *** tjones has left #openstack-horizon | 00:21 | |
| *** lcastell has quit IRC | 00:21 | |
| *** lcastell has joined #openstack-horizon | 00:22 | |
| *** jtriley has quit IRC | 00:25 | |
| *** lcastell_ has joined #openstack-horizon | 00:26 | |
| *** lcastell has quit IRC | 00:26 | |
| *** lcastell_ has quit IRC | 00:30 | |
| *** dave-mccowan has joined #openstack-horizon | 00:30 | |
| *** felipemonteiro has joined #openstack-horizon | 00:31 | |
| *** jtriley has joined #openstack-horizon | 00:45 | |
| *** jtriley has quit IRC | 00:49 | |
| *** zhurong has joined #openstack-horizon | 01:11 | |
| *** lcastell has joined #openstack-horizon | 01:17 | |
| *** lucasxu has joined #openstack-horizon | 01:20 | |
| *** lcastell has quit IRC | 01:21 | |
| *** lucasxu has quit IRC | 01:22 | |
| *** r-daneel has quit IRC | 01:24 | |
| *** tonyb has quit IRC | 01:24 | |
| *** tonyb has joined #openstack-horizon | 01:25 | |
| *** felipemonteiro has quit IRC | 01:51 | |
| *** lcastell has joined #openstack-horizon | 01:54 | |
| *** dave-mccowan has quit IRC | 01:56 | |
| *** lcastell has quit IRC | 01:58 | |
| *** kei1 has quit IRC | 02:13 | |
| *** kei1 has joined #openstack-horizon | 02:14 | |
| *** openstackgerrit has joined #openstack-horizon | 02:51 | |
| openstackgerrit | Ying Zuo proposed openstack/horizon master: Include add subnet action on admin networks panel https://review.openstack.org/494773 | 02:51 |
|---|---|---|
| openstackgerrit | Ying Zuo proposed openstack/horizon master: Include add subnet action on admin networks panel https://review.openstack.org/494773 | 02:56 |
| *** ircuser-1 has joined #openstack-horizon | 02:58 | |
| openstackgerrit | Ying Zuo proposed openstack/horizon master: Fix js error for hiding required fields with ThemableSelectWidget https://review.openstack.org/492354 | 03:06 |
| *** TravT has joined #openstack-horizon | 03:10 | |
| *** ying_zuo has quit IRC | 03:15 | |
| *** ying_zuo has joined #openstack-horizon | 03:26 | |
| *** ChanServ sets mode: +o ying_zuo | 03:26 | |
| *** udesale has joined #openstack-horizon | 03:42 | |
| *** mkrcmari__ has joined #openstack-horizon | 04:01 | |
| *** ying_zuo has quit IRC | 04:05 | |
| *** ying_zuo has joined #openstack-horizon | 04:08 | |
| *** ChanServ sets mode: +o ying_zuo | 04:08 | |
| *** hoonetorg has joined #openstack-horizon | 04:18 | |
| *** ying_zuo has quit IRC | 04:37 | |
| *** makowals has quit IRC | 04:37 | |
| *** makowals has joined #openstack-horizon | 04:44 | |
| *** gyee has quit IRC | 04:45 | |
| *** ying_zuo has joined #openstack-horizon | 04:55 | |
| *** ChanServ sets mode: +o ying_zuo | 04:55 | |
| *** ying_zuo has quit IRC | 05:03 | |
| *** ratailor has joined #openstack-horizon | 05:25 | |
| openstackgerrit | Ying Zuo proposed openstack/horizon master: Remove hardcoded check for subnet actions of a shared network https://review.openstack.org/494948 | 05:25 |
| *** zhurong has quit IRC | 05:38 | |
| *** zhurong has joined #openstack-horizon | 05:41 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon master: Imported Translations from Zanata https://review.openstack.org/494956 | 06:06 |
| *** rcernin has joined #openstack-horizon | 06:41 | |
| *** jidar has left #openstack-horizon | 06:43 | |
| *** masco has joined #openstack-horizon | 06:47 | |
| *** jpich has joined #openstack-horizon | 06:52 | |
| *** snecklifter has joined #openstack-horizon | 06:57 | |
| *** Ritesh has joined #openstack-horizon | 06:57 | |
| *** snecklifter has quit IRC | 06:58 | |
| Ritesh | Hi everyone, i am trying to customize the dashboard for my learning purpose. I have openstack manual setup on my ubuntu machine. When i try to change the logo of openstack login page it does not reflect on dashboard but the logo from ubuntu theme goes off. Can anyone tell me where i am going wrong. I will be so thankful . | 07:00 |
| amotoki | Ritesh: it depends on how you installed horizon, from source or from package. | 07:09 |
| amotoki | If you install from ubuntu package, ubuntu package may have its own branding customization. | 07:09 |
| amotoki | IIRC, ubuntu has a package to provide ubuntu specific theme, but i am not sure. | 07:10 |
| *** mrch has joined #openstack-horizon | 07:10 | |
| *** tesseract has joined #openstack-horizon | 07:13 | |
| *** pcaruana has quit IRC | 07:32 | |
| *** e0ne has joined #openstack-horizon | 07:46 | |
| *** e0ne has quit IRC | 07:53 | |
| *** pcaruana has joined #openstack-horizon | 07:54 | |
| *** e0ne has joined #openstack-horizon | 07:55 | |
| *** jtomasek has joined #openstack-horizon | 07:57 | |
| *** itxaka has joined #openstack-horizon | 08:01 | |
| *** e0ne has quit IRC | 08:05 | |
| *** e0ne has joined #openstack-horizon | 08:06 | |
| Ritesh | IIRC, Is there any specific format for logo image ? | 08:18 |
| *** Adri2000 has left #openstack-horizon | 08:39 | |
| robcresswell | Ritesh: SVG | 09:03 |
| robcresswell | it'll look for an SVG icon | 09:04 |
| Ritesh | robcresswell: does it support png ? | 09:11 |
| robcresswell | Ritesh: No, it just checks for an SVG file path | 09:12 |
| robcresswell | PNG is not good for web | 09:12 |
| Ritesh | Okay thanks | 09:13 |
| *** tosky has joined #openstack-horizon | 09:23 | |
| *** TravT has quit IRC | 09:27 | |
| e0ne | could anybody please take a look on https://review.openstack.org/#/c/289932/28? it's a long journey which starts almost 1.5 year ago | 09:29 |
| Ritesh | robcresswell: SVG format is also not getting supported by dashboard. What am i missing ? | 09:30 |
| e0ne | and https://review.openstack.org/#/c/241224/7 which is started in Nov, 2015 | 09:33 |
| *** TravT has joined #openstack-horizon | 09:34 | |
| *** TravT has quit IRC | 09:39 | |
| openstackgerrit | Kairat Kushaev proposed openstack/horizon master: do not flush selection on incorrect input https://review.openstack.org/495141 | 09:39 |
| openstackgerrit | Merged openstack/horizon master: Updated from global requirements https://review.openstack.org/494813 | 09:43 |
| openstackgerrit | Merged openstack/horizon master: Imported Translations from Zanata https://review.openstack.org/494956 | 09:44 |
| *** yamamoto has joined #openstack-horizon | 09:51 | |
| *** yamamoto has quit IRC | 09:53 | |
| *** TravT has joined #openstack-horizon | 09:53 | |
| *** yamamoto has joined #openstack-horizon | 09:57 | |
| *** TravT has quit IRC | 09:59 | |
| *** TravT has joined #openstack-horizon | 10:01 | |
| *** pcaruana has quit IRC | 10:02 | |
| *** yamamoto has quit IRC | 10:03 | |
| *** hoangcx has quit IRC | 10:03 | |
| *** udesale has quit IRC | 10:04 | |
| *** yamamoto has joined #openstack-horizon | 10:08 | |
| *** yamamoto has quit IRC | 10:10 | |
| *** TravT has quit IRC | 10:12 | |
| *** yamamoto has joined #openstack-horizon | 10:13 | |
| *** wolverineav has joined #openstack-horizon | 10:13 | |
| *** TravT has joined #openstack-horizon | 10:14 | |
| *** yamamoto has quit IRC | 10:15 | |
| *** TravT has quit IRC | 10:17 | |
| *** pcaruana has joined #openstack-horizon | 10:22 | |
| robcresswell | Ritesh: Well, you're doing something else wrong then, cause they're all SVG upstream :) | 10:23 |
| robcresswell | Ritesh: Probably a file path named wrongly or something | 10:24 |
| Ritesh | robcresswell: path is correct because it is getting reflected on dashboard but the logo is not getting loaded, just a broken image icon is getting displayed. | 10:27 |
| *** TravT has joined #openstack-horizon | 10:29 | |
| *** yamamoto has joined #openstack-horizon | 10:29 | |
| *** TravT has quit IRC | 10:36 | |
| *** TravT_ has joined #openstack-horizon | 10:36 | |
| robcresswell | Ritesh: What version are you on? | 10:36 |
| Ritesh | robcresswell: version of what ? | 10:39 |
| *** TravT_ has quit IRC | 10:39 | |
| openstackgerrit | Merged openstack/django_openstack_auth master: Add support for policy directories per service https://review.openstack.org/487153 | 10:40 |
| *** yamamoto has quit IRC | 10:43 | |
| *** yamamoto has joined #openstack-horizon | 10:43 | |
| *** ritesh_ has joined #openstack-horizon | 10:45 | |
| *** Ritesh has quit IRC | 10:46 | |
| *** yamamoto has quit IRC | 10:47 | |
| *** yamamoto has joined #openstack-horizon | 10:49 | |
| *** yamamoto has quit IRC | 10:55 | |
| robcresswell | ritesh_: Horizon | 10:57 |
| *** zhurong has quit IRC | 11:01 | |
| *** madorn has quit IRC | 11:03 | |
| ritesh_ | robcreswell: repository is from ocata release. | 11:06 |
| *** madorn has joined #openstack-horizon | 11:06 | |
| *** TravT has joined #openstack-horizon | 11:09 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Speed up quotas fetching using futurist library https://review.openstack.org/483948 | 11:13 |
| *** TravT has quit IRC | 11:14 | |
| *** TravT has joined #openstack-horizon | 11:15 | |
| *** TravT has quit IRC | 11:16 | |
| *** TravT_ has joined #openstack-horizon | 11:16 | |
| *** TravT_ has quit IRC | 11:18 | |
| *** TravT has joined #openstack-horizon | 11:18 | |
| *** TravT has quit IRC | 11:22 | |
| *** ratailor has quit IRC | 11:29 | |
| *** yamamoto has joined #openstack-horizon | 11:29 | |
| *** yamamoto has quit IRC | 11:31 | |
| *** yamamoto has joined #openstack-horizon | 11:32 | |
| *** mvk has joined #openstack-horizon | 11:32 | |
| *** mkrcmari__ has quit IRC | 11:35 | |
| *** yamamoto has quit IRC | 11:37 | |
| *** yamamoto has joined #openstack-horizon | 11:39 | |
| *** TravT has joined #openstack-horizon | 11:41 | |
| *** TravT has quit IRC | 11:46 | |
| *** TravT has joined #openstack-horizon | 11:55 | |
| *** TravT has quit IRC | 11:59 | |
| *** TravT has joined #openstack-horizon | 12:13 | |
| *** TravT has quit IRC | 12:17 | |
| *** TravT has joined #openstack-horizon | 12:20 | |
| *** rcernin has quit IRC | 12:21 | |
| *** TravT_ has joined #openstack-horizon | 12:24 | |
| *** TravT has quit IRC | 12:24 | |
| *** TravT_ has quit IRC | 12:24 | |
| *** makowals has quit IRC | 12:28 | |
| *** makowals has joined #openstack-horizon | 12:28 | |
| *** TravT has joined #openstack-horizon | 12:30 | |
| *** dave-mccowan has joined #openstack-horizon | 12:31 | |
| *** TravT has quit IRC | 12:32 | |
| *** TravT_ has joined #openstack-horizon | 12:32 | |
| *** TravT_ has quit IRC | 12:37 | |
| *** rcernin has joined #openstack-horizon | 12:38 | |
| *** catintheroof has joined #openstack-horizon | 12:40 | |
| *** catinthe_ has joined #openstack-horizon | 12:41 | |
| *** catintheroof has quit IRC | 12:41 | |
| *** TravT has joined #openstack-horizon | 12:41 | |
| *** TravT has quit IRC | 12:51 | |
| *** TravT has joined #openstack-horizon | 12:55 | |
| *** TravT has quit IRC | 13:01 | |
| *** itxaka has quit IRC | 13:01 | |
| *** jtriley has joined #openstack-horizon | 13:03 | |
| *** TravT has joined #openstack-horizon | 13:03 | |
| *** masco has quit IRC | 13:05 | |
| *** TravT has quit IRC | 13:07 | |
| *** lucasxu has joined #openstack-horizon | 13:08 | |
| *** TravT has joined #openstack-horizon | 13:10 | |
| *** jtriley has quit IRC | 13:12 | |
| *** ejat has quit IRC | 13:16 | |
| *** TravT has quit IRC | 13:16 | |
| *** TravT has joined #openstack-horizon | 13:18 | |
| *** ejat has joined #openstack-horizon | 13:20 | |
| *** ejat has quit IRC | 13:20 | |
| *** ejat has joined #openstack-horizon | 13:20 | |
| *** TravT has quit IRC | 13:24 | |
| *** TravT has joined #openstack-horizon | 13:25 | |
| *** jtriley has joined #openstack-horizon | 13:29 | |
| *** TravT has quit IRC | 13:30 | |
| *** david-lyle has joined #openstack-horizon | 13:35 | |
| *** ChanServ sets mode: +o david-lyle | 13:35 | |
| *** felipemonteiro_ has joined #openstack-horizon | 13:35 | |
| *** dklyle has quit IRC | 13:36 | |
| *** TravT has joined #openstack-horizon | 13:36 | |
| *** felipemonteiro__ has joined #openstack-horizon | 13:37 | |
| *** TravT has quit IRC | 13:38 | |
| *** TravT_ has joined #openstack-horizon | 13:38 | |
| *** TravT_ has quit IRC | 13:40 | |
| *** felipemonteiro_ has quit IRC | 13:40 | |
| *** TravT has joined #openstack-horizon | 13:42 | |
| *** TravT has quit IRC | 13:46 | |
| e0ne | robcresswell: hi Rob. may I ask a stupid question according to how horizon works? | 13:55 |
| robcresswell | e0ne: Of course! | 13:55 |
| robcresswell | Stupid questions are normally the only ones I can answer | 13:55 |
| e0ne | robcresswell: :) | 13:55 |
| e0ne | robcresswell: I'm trying to figure out how https://github.com/openstack/horizon/blob/70946f629dc051a6016338cf024bb10584784f8b/openstack_dashboard/dashboards/project/instances/workflows/create_instance.py#L365 works | 13:56 |
| e0ne | robcresswell: especially, who and when will invoke this method? I can't find anything even with breakpoints | 13:56 |
| robcresswell | e0ne: Its part of Django | 13:57 |
| e0ne | ok, makes sense | 13:57 |
| *** TravT has joined #openstack-horizon | 13:57 | |
| e0ne | but why my debugger doesn's stop in this method? | 13:58 |
| robcresswell | https://docs.djangoproject.com/en/1.11/ref/forms/validation/ | 13:58 |
| * e0ne feels uncomfortable asking such questions | 13:58 | |
| robcresswell | e0ne: idk, I'm a print statement debugger personally :) | 13:58 |
| e0ne | robcresswell: I use pdb usually | 13:59 |
| *** TravT has quit IRC | 14:00 | |
| *** TravT_ has joined #openstack-horizon | 14:00 | |
| e0ne | robcresswell: when this validation should work? I suppose it should in on a create instance pop-up | 14:02 |
| robcresswell | e0ne: On submit | 14:02 |
| *** TravT_ has quit IRC | 14:04 | |
| *** TravT has joined #openstack-horizon | 14:04 | |
| amotoki | I am another man who use print as debugger :) | 14:05 |
| *** lucasxu has quit IRC | 14:07 | |
| e0ne | finally, I found what I need. I took only 45 mins :( | 14:07 |
| e0ne | that coder works only if I launch instance via http://localhost/dashboard/project/instances/launch, not using 'standard' "launch instance" button | 14:08 |
| robcresswell | e0ne: Ahhh, yes, legacy vs angular | 14:08 |
| robcresswell | Sorry, should've thought of that | 14:08 |
| e0ne | when are we going to remove legacy code? | 14:09 |
| robcresswell | e0ne: I think the images code, can go now | 14:12 |
| robcresswell | run tests is gone | 14:12 |
| *** TravT has quit IRC | 14:12 | |
| amotoki | have we already mark the legacy launch instance form as deprecated ? | 14:12 |
| robcresswell | launch instance still has regressions | 14:12 |
| robcresswell | amotoki: I believe so. | 14:12 |
| amotoki | is grep-ing release notes... | 14:12 |
| *** TravT has joined #openstack-horizon | 14:13 | |
| openstackgerrit | Kairat Kushaev proposed openstack/horizon master: do not flush selection on "old" boot source https://review.openstack.org/495141 | 14:14 |
| amotoki | a feature someone wants to use the legacy one is https://bugs.launchpad.net/horizon/+bug/1609777 | 14:15 |
| openstack | Launchpad bug 1609777 in OpenStack Dashboard (Horizon) "'can_set_password' ignored in the new launch instance experience" [Medium,In progress] - Assigned to Pascal Boutin (pboutin) | 14:15 |
| robcresswell | There are a few regressions | 14:15 |
| robcresswell | There's also the sorting of images etc | 14:15 |
| *** david-lyle has quit IRC | 14:16 | |
| *** dklyle has joined #openstack-horizon | 14:16 | |
| *** ChanServ sets mode: +o dklyle | 14:16 | |
| amotoki | one deployment I am involved in still use the legacy launch form just because we don't want to update the user document :p | 14:17 |
| amotoki | (minor reason) | 14:17 |
| robcresswell | lol | 14:17 |
| e0ne | it's crazy | 14:18 |
| *** TravT has quit IRC | 14:18 | |
| amotoki | perhaps we use it as long as it is available, but if it's gone we will switch it :) | 14:18 |
| e0ne | do we have any plan what should be done to remove legacy code? | 14:19 |
| *** shewless has joined #openstack-horizon | 14:19 | |
| robcresswell | e0ne: Fix the regressions, remove the code | 14:19 |
| e0ne | robcresswell: in such case, we need some list of bugs with regressions | 14:20 |
| robcresswell | e0ne: Like, the bug list? Or the summit etherpads? Pick your poison :) | 14:20 |
| e0ne | I'll be happy to fix these bugs | 14:20 |
| shewless | Hi. I'm in the process of upgrading from Mitaka to Newton. It's mostly gone okay but I'm hitting some weird horizon stuff. I wonder if there are some known bugs on the ubuntu 16.04 newton cloud archive that might be causing it. | 14:21 |
| shewless | THe problems seem related to "LOGIN_URL" in local_settings.py | 14:21 |
| shewless | in my mitaka setup I have them commented out | 14:21 |
| amotoki | totally agree it is hard to maintain two things. it looks better to file a blueprint and gather gaps to be addressed. | 14:21 |
| shewless | but in newton I can't it the main page unless i uncomment out the LOGIN_URL entry | 14:21 |
| shewless | and then it mostly works but I can't login as admin and I can't view images | 14:21 |
| shewless | I can however login as a normal user | 14:22 |
| shewless | and view instances, networks, etc | 14:22 |
| shewless | I don't see any errors in the logs... just wondering if I'm hitting a known bug | 14:22 |
| robcresswell | shewless: By default that URL is just 'auth/login/ | 14:22 |
| robcresswell | shewless: It's not bringing any know issues to mind | 14:22 |
| robcresswell | known* | 14:22 |
| e0ne | robcresswell: I'll be grateful if you point me on such list in launchpad or etherpad | 14:24 |
| shewless | @robcresswell: when I go to view "images" i brings me to this page: foo.com/horizon/undefined | 14:24 |
| *** ritesh_ has quit IRC | 14:24 | |
| shewless | (foo.com would be my domain) | 14:24 |
| robcresswell | e0ne: https://etherpad.openstack.org/p/horizon-pike-feedback and https://etherpad.openstack.org/p/horizon-ptg-pike | 14:25 |
| *** gary-smith_ has joined #openstack-horizon | 14:26 | |
| e0ne | robcresswell: thanks a lot | 14:28 |
| robcresswell | e0ne: The PTG feedback is most useful | 14:28 |
| *** itlinux has joined #openstack-horizon | 14:28 | |
| robcresswell | Pike feedback** sorry | 14:28 |
| *** wolverineav has quit IRC | 14:28 | |
| shewless | @robcresswell: any idea why only images would be exhibiting this problem? | 14:29 |
| *** TravT has joined #openstack-horizon | 14:29 | |
| shewless | ..or how to debug.. not seeing any error messages in /var/log | 14:30 |
| robcresswell | shewless: Any bugs in the JS console? | 14:30 |
| *** wolverineav has joined #openstack-horizon | 14:32 | |
| *** TravT has quit IRC | 14:32 | |
| shewless | @robcresswell. yes there are bugs in there! First one is Uncaught SyntaxError: Invalid or unexpected token | 14:33 |
| shewless | there are more | 14:33 |
| *** TravT has joined #openstack-horizon | 14:33 | |
| robcresswell | shewless: Did you update your dependencies when you moved to Newton? | 14:33 |
| robcresswell | Newton had a fully JS images panel iirc, so any JS error will likely make it fall over | 14:34 |
| shewless | @robcresswell: I moved to the newton ppa by doing this: sudo add-apt-repository cloud-archive:newton. Then I did an update and upgrade. | 14:35 |
| shewless | I *think* that will update my dependencies.. right? | 14:35 |
| robcresswell | er, on ubuntu, you want dist-upgrade, right | 14:35 |
| *** itlinux has quit IRC | 14:36 | |
| robcresswell | I forget exactly how they do upgrades | 14:36 |
| *** itlinux has joined #openstack-horizon | 14:37 | |
| *** TravT has quit IRC | 14:37 | |
| shewless | @robcresswell. No I'm sticking with ubuntu 16.04. I'm quite sure all openstack related packages (and I hope dependencies) have been updated. Anyways.. is there some javascript package I need to check? | 14:37 |
| *** TravT has joined #openstack-horizon | 14:38 | |
| robcresswell | shewless: dist-upgrade isn't a release upgrade lol :) | 14:38 |
| robcresswell | Maybe its not a thing now | 14:39 |
| robcresswell | ANyway, upgrade is probably fine for just software. | 14:40 |
| robcresswell | shewless: The only way to check really is to look through the dependencies you have installed vs those versions in global-requirements | 14:40 |
| shewless | @robcresswell: I see. yes perhaps I can try a dist-upgrade.. if I read the errors top down this is the first one: TypeError: Cannot read property 'replace' of undefined | 14:41 |
| robcresswell | shewless: tbh, your best bet is to ask whoever your packager is | 14:41 |
| shewless | @robcresswell: thanks but shouldn't there be a way to debug this? | 14:42 |
| robcresswell | shewless: Yup, like I said, check your dependency versions first | 14:42 |
| robcresswell | Then paste the (sanitised) logs in paste.openstack.org so I can look | 14:43 |
| shewless | @robcresswell: how do I find the "global-requirements". Also I will try and paste the logs in pastebin | 14:43 |
| robcresswell | shewless: https://github.com/openstack/requirements/blob/master/global-requirements.txt | 14:44 |
| shewless | @robcresswell: thank you. I'll have a look. Here are the js errors btw: http://paste.openstack.org/show/618777/ | 14:45 |
| robcresswell | :/ Not much I can gather from that. It's some angular error, but thats about all I can tell | 14:45 |
| *** lcastell has joined #openstack-horizon | 14:54 | |
| *** itlinux has quit IRC | 14:56 | |
| shewless | @robcresswell: thanks for the help. I'm going to try a few things. | 14:56 |
| *** vishwana_ has joined #openstack-horizon | 15:00 | |
| robcresswell | shewless: No problem. Ping again if you need more help. | 15:01 |
| *** vishwanathj has quit IRC | 15:03 | |
| *** david-lyle has joined #openstack-horizon | 15:04 | |
| *** ChanServ sets mode: +o david-lyle | 15:04 | |
| *** dklyle has quit IRC | 15:04 | |
| *** john89 has joined #openstack-horizon | 15:16 | |
| *** gary-smith_ has quit IRC | 15:17 | |
| *** udesale has joined #openstack-horizon | 15:21 | |
| *** lcastell has quit IRC | 15:28 | |
| *** gyee has joined #openstack-horizon | 15:28 | |
| *** david-lyle has quit IRC | 15:37 | |
| *** dklyle has joined #openstack-horizon | 15:37 | |
| *** ChanServ sets mode: +o dklyle | 15:37 | |
| openstackgerrit | Merged openstack/horizon master: Updated from global requirements https://review.openstack.org/495180 | 15:38 |
| *** gary-smith_ has joined #openstack-horizon | 15:38 | |
| *** dklyle has quit IRC | 15:44 | |
| *** david-lyle has joined #openstack-horizon | 15:46 | |
| *** ChanServ sets mode: +o david-lyle | 15:46 | |
| *** mrch has quit IRC | 15:47 | |
| *** lcastell has joined #openstack-horizon | 15:50 | |
| *** ying_zuo has joined #openstack-horizon | 15:55 | |
| *** ChanServ sets mode: +o ying_zuo | 15:55 | |
| amotoki | robcresswell: ying_zuo: sorry for requesting again. could you check https://review.openstack.org/#/c/494445/ ? currently we cannot create a new security group rule from horizon (only ICMP custom rule can be created) | 16:04 |
| amotoki | this is the only critical one I see now | 16:04 |
| ying_zuo | sure. looking at it now. | 16:05 |
| ying_zuo | same error message as the one that I am fixing https://bugs.launchpad.net/horizon/+bug/1709693 | 16:07 |
| openstack | Launchpad bug 1709693 in OpenStack Dashboard (Horizon) "Cannot create network in the admin/networks panel without creating a subnet" [High,In progress] - Assigned to Ying Zuo (yingzuo) | 16:07 |
| ying_zuo | but mine is for ThemableSelectWidget | 16:07 |
| ying_zuo | but maybe similar fix can be applied? | 16:08 |
| *** jpich has quit IRC | 16:09 | |
| *** wolverineav has quit IRC | 16:09 | |
| *** wolverineav has joined #openstack-horizon | 16:09 | |
| amotoki | ying_zuo: perhaps your fix will be more generic if you see the same error message | 16:09 |
| *** jtomasek has quit IRC | 16:09 | |
| *** e0ne has quit IRC | 16:09 | |
| amotoki | ying_zuo: for SG rule case, we can do another approach like my patch, but it is not general | 16:10 |
| amotoki | perhaps something has changed and it seems we cannot use required=True (default) for hidden fields. | 16:11 |
| ying_zuo | yes, they are both caused by required fields being hidden when the form is submitted | 16:11 |
| ying_zuo | my fix is to set the required field to false with js when it's hidden | 16:11 |
| *** pcaruana has quit IRC | 16:12 | |
| *** tesseract has quit IRC | 16:12 | |
| *** rcernin has quit IRC | 16:12 | |
| amotoki | if it works perfectly the problem will be gone. | 16:12 |
| amotoki | a validation logic in a client side complains and perhaps the approach looks right | 16:13 |
| ying_zuo | yes, let me check | 16:15 |
| amotoki | ying_zuo: one big question which hits me is whether we should use 'required=True' for conditional fields. | 16:16 |
| ying_zuo | I think it would be nice if we can | 16:17 |
| amotoki | most of them were added for asterisk marks for forms | 16:17 |
| amotoki | if we cannot have a good solution, a class like 'required' might help us, but if we can handle the current case it would be nicer | 16:18 |
| ying_zuo | amotoki: yes, my fix will fix this issue too | 16:23 |
| ying_zuo | can you take a look? https://review.openstack.org/#/c/492354/ | 16:24 |
| *** itlinux has joined #openstack-horizon | 16:29 | |
| amotoki | ying_zuo: ack. will take a loot this weekend | 16:30 |
| ying_zuo | thanks amotoki | 16:30 |
| *** itlinux has quit IRC | 16:31 | |
| *** mvk_ has joined #openstack-horizon | 16:36 | |
| *** Guest75213 is now known as med_ | 16:37 | |
| *** med_ has quit IRC | 16:37 | |
| *** med_ has joined #openstack-horizon | 16:37 | |
| *** itlinux has joined #openstack-horizon | 16:38 | |
| *** mvk_ has quit IRC | 16:38 | |
| *** mvk has quit IRC | 16:39 | |
| *** mvk has joined #openstack-horizon | 16:40 | |
| *** mvk_ has joined #openstack-horizon | 16:43 | |
| *** catinthe_ has quit IRC | 16:43 | |
| *** catintheroof has joined #openstack-horizon | 16:45 | |
| *** wolverineav has quit IRC | 16:45 | |
| *** mvk has quit IRC | 16:46 | |
| robcresswell | ying_zuo, amotoki: I think something has changed in django 1.10 or django 1.11 around "required" | 16:49 |
| robcresswell | There's been 2 or 3 bugs that are the same | 16:50 |
| robcresswell | Seems like a wider behaviour change. | 16:50 |
| ying_zuo | probably | 16:51 |
| ying_zuo | I hope the js fix is generic enough to fix all the issues in different panels | 16:51 |
| *** wolverineav has joined #openstack-horizon | 16:53 | |
| *** itlinux has quit IRC | 17:03 | |
| *** lucasxu has joined #openstack-horizon | 17:06 | |
| *** tosky has quit IRC | 17:32 | |
| *** itlinux has joined #openstack-horizon | 17:34 | |
| *** lcastell has quit IRC | 17:36 | |
| *** lcastell has joined #openstack-horizon | 17:36 | |
| *** lcastell has quit IRC | 17:41 | |
| *** lcastell has joined #openstack-horizon | 17:48 | |
| *** lucasxu has quit IRC | 17:48 | |
| *** itlinux has quit IRC | 17:54 | |
| *** tosky has joined #openstack-horizon | 17:57 | |
| *** itlinux has joined #openstack-horizon | 18:05 | |
| *** mvk_ has quit IRC | 18:10 | |
| *** itlinux has quit IRC | 18:16 | |
| *** lucasxu has joined #openstack-horizon | 18:20 | |
| *** sergio__ has joined #openstack-horizon | 18:21 | |
| *** catinthe_ has joined #openstack-horizon | 18:33 | |
| *** catinth__ has joined #openstack-horizon | 18:33 | |
| *** udesale has quit IRC | 18:34 | |
| *** catintheroof has quit IRC | 18:35 | |
| *** catinthe_ has quit IRC | 18:37 | |
| *** makowals has quit IRC | 18:41 | |
| *** john89 has quit IRC | 18:44 | |
| *** itlinux has joined #openstack-horizon | 18:49 | |
| *** lucasxu has quit IRC | 19:06 | |
| *** itlinux_ has joined #openstack-horizon | 19:10 | |
| *** itlinux_ has quit IRC | 19:15 | |
| *** itlinux has quit IRC | 19:15 | |
| *** e0ne has joined #openstack-horizon | 19:17 | |
| *** itlinux has joined #openstack-horizon | 19:18 | |
| *** itlinux_ has joined #openstack-horizon | 19:18 | |
| *** ducttape_ has quit IRC | 19:26 | |
| *** ducttape_ has joined #openstack-horizon | 19:26 | |
| *** yamamoto has quit IRC | 19:30 | |
| *** yamamoto has joined #openstack-horizon | 19:33 | |
| *** jtriley has quit IRC | 19:50 | |
| *** e0ne has quit IRC | 19:51 | |
| *** makowals has joined #openstack-horizon | 19:57 | |
| *** yamamoto has quit IRC | 20:01 | |
| *** jtriley has joined #openstack-horizon | 20:04 | |
| *** itlinux_ has quit IRC | 20:22 | |
| *** itlinux has quit IRC | 20:22 | |
| *** jtriley has quit IRC | 20:28 | |
| *** itlinux has joined #openstack-horizon | 20:29 | |
| *** itlinux_ has joined #openstack-horizon | 20:30 | |
| *** sergio__ has quit IRC | 20:45 | |
| *** itlinux has quit IRC | 20:48 | |
| *** itlinux_ has quit IRC | 20:48 | |
| *** wolverineav has quit IRC | 20:53 | |
| *** wolverineav has joined #openstack-horizon | 20:56 | |
| *** itlinux_ has joined #openstack-horizon | 20:58 | |
| *** itlinux has joined #openstack-horizon | 20:58 | |
| *** makowals has quit IRC | 20:58 | |
| *** dave-mccowan has quit IRC | 21:01 | |
| *** wolverineav has quit IRC | 21:04 | |
| *** jtriley has joined #openstack-horizon | 21:08 | |
| *** dave-mccowan has joined #openstack-horizon | 21:12 | |
| *** dave-mccowan has quit IRC | 21:15 | |
| *** jtriley has quit IRC | 21:21 | |
| *** catintheroof has joined #openstack-horizon | 21:22 | |
| *** catinth__ has quit IRC | 21:25 | |
| *** itlinux_ has quit IRC | 21:33 | |
| *** itlinux has quit IRC | 21:33 | |
| *** catintheroof has quit IRC | 21:57 | |
| *** tjones has joined #openstack-horizon | 21:59 | |
| *** lbragstad has quit IRC | 21:59 | |
| *** felipemonteiro__ has quit IRC | 22:05 | |
| *** makowals has joined #openstack-horizon | 22:13 | |
| *** ducttap__ has joined #openstack-horizon | 22:46 | |
| *** ducttape_ has quit IRC | 22:50 | |
| *** revon has joined #openstack-horizon | 23:05 | |
| *** ducttape_ has joined #openstack-horizon | 23:14 | |
| *** ducttap__ has quit IRC | 23:18 | |
| *** tosky has quit IRC | 23:29 | |
| *** makowals has quit IRC | 23:30 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!