| *** itlinux has quit IRC | 00:00 | |
| *** jtriley has quit IRC | 00:03 | |
| *** wolverineav has joined #openstack-horizon | 00:03 | |
| *** yingjun has joined #openstack-horizon | 00:06 | |
| *** wolverineav has quit IRC | 00:13 | |
| *** jamesbenson has joined #openstack-horizon | 00:13 | |
| *** wolverineav has joined #openstack-horizon | 00:15 | |
| *** jamesbenson has quit IRC | 00:18 | |
| *** itlinux has joined #openstack-horizon | 00:19 | |
| *** wolverineav has quit IRC | 00:20 | |
| *** jtriley has joined #openstack-horizon | 00:22 | |
| *** ducttape_ has joined #openstack-horizon | 00:28 | |
| *** wolverineav has joined #openstack-horizon | 00:30 | |
| *** ducttape_ has quit IRC | 00:32 | |
| *** wolverineav has quit IRC | 00:36 | |
| *** jtriley has quit IRC | 00:37 | |
| *** wolverineav has joined #openstack-horizon | 00:39 | |
| *** wolverineav has quit IRC | 00:40 | |
| *** wolverineav has joined #openstack-horizon | 00:41 | |
| *** zhurong has joined #openstack-horizon | 00:46 | |
| *** ying_zuo has quit IRC | 00:46 | |
| *** wolverineav has quit IRC | 00:48 | |
| *** wolverineav has joined #openstack-horizon | 00:51 | |
| *** makowals has quit IRC | 00:59 | |
| *** makowals has joined #openstack-horizon | 01:03 | |
| *** jtriley has joined #openstack-horizon | 01:03 | |
| *** georgem1 has joined #openstack-horizon | 01:06 | |
| *** wolverineav has quit IRC | 01:06 | |
| *** jamesbenson has joined #openstack-horizon | 01:10 | |
| *** makowals has quit IRC | 01:10 | |
| *** georgem1 has quit IRC | 01:10 | |
| *** wolverineav has joined #openstack-horizon | 01:14 | |
| *** jamesbenson has quit IRC | 01:15 | |
| *** jtriley has quit IRC | 01:22 | |
| *** Daisy_ has joined #openstack-horizon | 01:24 | |
| *** wolverineav has quit IRC | 01:26 | |
| *** georgem1 has joined #openstack-horizon | 01:27 | |
| *** ducttape_ has joined #openstack-horizon | 01:29 | |
| *** jamesbenson has joined #openstack-horizon | 01:31 | |
| *** wolverineav has joined #openstack-horizon | 01:31 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/horizon master: Update URL home-page in documents according to document migration https://review.openstack.org/483675 | 01:32 |
|---|---|---|
| *** ducttape_ has quit IRC | 01:33 | |
| *** jamesbenson has quit IRC | 01:35 | |
| *** itlinux has quit IRC | 01:37 | |
| *** Daisy_ has quit IRC | 01:44 | |
| *** makowals has joined #openstack-horizon | 01:45 | |
| *** Daisy_ has joined #openstack-horizon | 01:45 | |
| *** georgem1 has quit IRC | 01:45 | |
| *** wolverineav has quit IRC | 01:48 | |
| *** georgem1 has joined #openstack-horizon | 01:48 | |
| *** Daisy_ has quit IRC | 01:49 | |
| *** itlinux has joined #openstack-horizon | 01:50 | |
| *** itlinux has quit IRC | 01:51 | |
| openstackgerrit | Allen proposed openstack/horizon master: Adding identity ng-groups create action https://review.openstack.org/480426 | 01:59 |
| *** jtriley has joined #openstack-horizon | 02:01 | |
| *** zhurong has quit IRC | 02:01 | |
| *** jtriley has quit IRC | 02:07 | |
| *** Daisy_ has joined #openstack-horizon | 02:08 | |
| *** wolverineav has joined #openstack-horizon | 02:11 | |
| *** zhurong has joined #openstack-horizon | 02:14 | |
| *** wolverineav has quit IRC | 02:19 | |
| *** Daisy__ has joined #openstack-horizon | 02:21 | |
| *** Daisy_ has quit IRC | 02:22 | |
| *** wolverineav has joined #openstack-horizon | 02:34 | |
| *** wolverineav has quit IRC | 02:39 | |
| *** TravT has joined #openstack-horizon | 02:40 | |
| *** ChanServ sets mode: +v TravT | 02:40 | |
| *** TravT has quit IRC | 02:40 | |
| *** georgem1 has quit IRC | 02:42 | |
| *** wolverineav has joined #openstack-horizon | 02:48 | |
| *** wolverineav has quit IRC | 02:52 | |
| openstackgerrit | Feilong Wang proposed openstack/django_openstack_auth master: Fix region sticky issue https://review.openstack.org/483785 | 03:04 |
| *** jamesbenson has joined #openstack-horizon | 03:14 | |
| *** jamesbenson has quit IRC | 03:19 | |
| *** tjones has joined #openstack-horizon | 03:23 | |
| *** tjones has left #openstack-horizon | 03:23 | |
| *** Daisy__ has quit IRC | 03:24 | |
| *** ducttape_ has joined #openstack-horizon | 03:27 | |
| *** itlinux has joined #openstack-horizon | 03:28 | |
| *** Daisy_ has joined #openstack-horizon | 03:28 | |
| openstackgerrit | Merged openstack/horizon master: Correct the create volume snapshot description and used of quota https://review.openstack.org/457005 | 03:32 |
| *** ducttape_ has quit IRC | 03:32 | |
| *** jtriley has joined #openstack-horizon | 03:32 | |
| *** makowals has quit IRC | 03:34 | |
| *** rajalokan has joined #openstack-horizon | 03:34 | |
| *** Daisy_ has quit IRC | 03:37 | |
| *** Daisy_ has joined #openstack-horizon | 03:37 | |
| *** makowals has joined #openstack-horizon | 03:38 | |
| *** amotoki_away is now known as amotoki | 03:41 | |
| openstackgerrit | Merged openstack/horizon master: Attribute "isServer" of images visibility filter should be true. https://review.openstack.org/465856 | 03:41 |
| *** Daisy_ has quit IRC | 03:42 | |
| *** udesale has joined #openstack-horizon | 03:43 | |
| *** tjones1 has joined #openstack-horizon | 03:44 | |
| *** tjones1 has left #openstack-horizon | 03:44 | |
| *** felipemonteiro has joined #openstack-horizon | 03:45 | |
| *** dave-mccowan has quit IRC | 03:46 | |
| *** Daisy_ has joined #openstack-horizon | 03:55 | |
| *** Daisy_ has quit IRC | 04:00 | |
| *** Daisy_ has joined #openstack-horizon | 04:01 | |
| *** Daisy_ has quit IRC | 04:06 | |
| *** Daisy_ has joined #openstack-horizon | 04:07 | |
| *** Daisy_ has quit IRC | 04:12 | |
| *** Daisy_ has joined #openstack-horizon | 04:14 | |
| *** itlinux has quit IRC | 04:14 | |
| *** Daisy_ has quit IRC | 04:19 | |
| *** Daisy_ has joined #openstack-horizon | 04:20 | |
| *** Daisy_ has quit IRC | 04:29 | |
| *** sudhirag0987 has joined #openstack-horizon | 04:35 | |
| *** sridhar_ram has joined #openstack-horizon | 04:36 | |
| *** yingjun has quit IRC | 04:44 | |
| *** jtriley has quit IRC | 04:46 | |
| *** jamesbenson has joined #openstack-horizon | 04:47 | |
| *** jamesbenson has quit IRC | 04:51 | |
| *** jtriley has joined #openstack-horizon | 04:53 | |
| *** ratailor has joined #openstack-horizon | 04:58 | |
| *** jtriley has quit IRC | 04:59 | |
| *** sudhirag0987 has quit IRC | 05:01 | |
| *** Daisy_ has joined #openstack-horizon | 05:15 | |
| *** wolverineav has joined #openstack-horizon | 05:15 | |
| *** wolverineav has quit IRC | 05:20 | |
| openstackgerrit | Shu Muto proposed openstack/horizon master: Commonize load-edit directive https://review.openstack.org/483810 | 05:21 |
| openstackgerrit | Merged openstack/horizon master: Update URL home-page in documents according to document migration https://review.openstack.org/483675 | 05:26 |
| *** wolverineav has joined #openstack-horizon | 05:28 | |
| *** jamesbenson has joined #openstack-horizon | 05:28 | |
| *** ducttape_ has joined #openstack-horizon | 05:28 | |
| *** wolverineav has quit IRC | 05:32 | |
| *** jamesbenson has quit IRC | 05:33 | |
| *** ducttape_ has quit IRC | 05:33 | |
| *** gyee has quit IRC | 05:37 | |
| *** jtomasek has joined #openstack-horizon | 05:41 | |
| *** jamesbenson has joined #openstack-horizon | 05:49 | |
| *** rcernin has joined #openstack-horizon | 05:52 | |
| *** jamesbenson has quit IRC | 05:53 | |
| *** amotoki is now known as amotoki_away | 06:08 | |
| *** shu-mutou has quit IRC | 06:12 | |
| *** pcaruana has joined #openstack-horizon | 06:25 | |
| *** amotoki_away is now known as amotoki | 06:33 | |
| *** jamesbenson has joined #openstack-horizon | 06:51 | |
| *** jamesbenson has quit IRC | 06:55 | |
| *** makowals has quit IRC | 06:56 | |
| *** e0ne has joined #openstack-horizon | 06:58 | |
| *** amotoki is now known as amotoki_away | 07:02 | |
| *** jamesbenson has joined #openstack-horizon | 07:12 | |
| *** tesseract has joined #openstack-horizon | 07:14 | |
| *** jamesbenson has quit IRC | 07:16 | |
| openstackgerrit | Lajos Katona proposed openstack/horizon master: Trunks panel: create button https://review.openstack.org/468396 | 07:18 |
| *** makowals has joined #openstack-horizon | 07:22 | |
| *** e0ne has quit IRC | 07:28 | |
| *** ducttape_ has joined #openstack-horizon | 07:30 | |
| *** jamesbenson has joined #openstack-horizon | 07:33 | |
| *** amotoki_away is now known as amotoki | 07:35 | |
| *** ducttape_ has quit IRC | 07:35 | |
| *** jamesbenson has quit IRC | 07:37 | |
| openstackgerrit | Lajos Katona proposed openstack/horizon master: Hide forever spinner in case of load problem https://review.openstack.org/481468 | 07:39 |
| *** wolverineav has joined #openstack-horizon | 07:45 | |
| *** Daisy_ has quit IRC | 07:51 | |
| *** jamesbenson has joined #openstack-horizon | 07:54 | |
| *** jpich has joined #openstack-horizon | 07:54 | |
| *** Daisy_ has joined #openstack-horizon | 07:58 | |
| *** jamesbenson has quit IRC | 07:58 | |
| *** Daisy_ has quit IRC | 08:02 | |
| *** Daisy_ has joined #openstack-horizon | 08:04 | |
| *** wolverineav has quit IRC | 08:07 | |
| *** Daisy_ has quit IRC | 08:08 | |
| *** Daisy_ has joined #openstack-horizon | 08:09 | |
| *** Daisy_ has quit IRC | 08:09 | |
| *** Daisy_ has joined #openstack-horizon | 08:10 | |
| *** jamesbenson has joined #openstack-horizon | 08:14 | |
| *** jamesbenson has quit IRC | 08:19 | |
| *** shu-mutou has joined #openstack-horizon | 08:44 | |
| *** wolverineav has joined #openstack-horizon | 08:49 | |
| *** wolverineav has quit IRC | 08:54 | |
| *** wolverineav has joined #openstack-horizon | 08:58 | |
| *** amotoki is now known as amotoki_away | 08:59 | |
| *** amotoki_away is now known as amotoki | 08:59 | |
| *** jtomasek_ has joined #openstack-horizon | 09:00 | |
| *** wolverineav has quit IRC | 09:03 | |
| *** shu-mutou has quit IRC | 09:03 | |
| *** jtomasek_ has quit IRC | 09:07 | |
| *** amotoki is now known as amotoki_away | 09:09 | |
| *** e0ne has joined #openstack-horizon | 09:09 | |
| *** amotoki_away is now known as amotoki | 09:10 | |
| *** Daisy_ has quit IRC | 09:18 | |
| *** amotoki is now known as amotoki_away | 09:25 | |
| *** amotoki_away is now known as amotoki | 09:28 | |
| *** ducttape_ has joined #openstack-horizon | 09:31 | |
| *** mvk has quit IRC | 09:32 | |
| *** ducttape_ has quit IRC | 09:36 | |
| *** jamesbenson has joined #openstack-horizon | 09:37 | |
| *** jamesbenson has quit IRC | 09:42 | |
| *** tosky has joined #openstack-horizon | 09:55 | |
| *** pcaruana has quit IRC | 09:56 | |
| *** jamesbenson has joined #openstack-horizon | 09:58 | |
| *** mvk has joined #openstack-horizon | 10:01 | |
| *** jamesbenson has quit IRC | 10:03 | |
| *** itxaka has joined #openstack-horizon | 10:07 | |
| *** pcaruana has joined #openstack-horizon | 10:09 | |
| *** makowals has quit IRC | 10:14 | |
| *** udesale has quit IRC | 10:43 | |
| *** zhurong has quit IRC | 10:54 | |
| *** wolverineav has joined #openstack-horizon | 10:57 | |
| *** ratailor has quit IRC | 11:08 | |
| *** makowals has joined #openstack-horizon | 11:12 | |
| *** pcaruana has quit IRC | 11:25 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon master: Imported Translations from Zanata https://review.openstack.org/483906 | 11:49 |
| *** amotoki is now known as amotoki_away | 12:02 | |
| openstackgerrit | Bence Romsics proposed openstack/horizon master: Trunks panel: create button https://review.openstack.org/468396 | 12:21 |
| *** dave-mccowan has joined #openstack-horizon | 12:23 | |
| *** dave-mccowan has quit IRC | 12:43 | |
| *** brad[] has quit IRC | 13:00 | |
| *** brad[] has joined #openstack-horizon | 13:00 | |
| *** jtriley has joined #openstack-horizon | 13:02 | |
| *** jtriley has quit IRC | 13:15 | |
| *** dave-mccowan has joined #openstack-horizon | 13:15 | |
| *** amotoki_away is now known as amotoki | 13:16 | |
| *** wolverineav has quit IRC | 13:20 | |
| openstackgerrit | Akihiro Motoki proposed openstack/ui-cookiecutter master: Update document link affected by document migration https://review.openstack.org/483932 | 13:28 |
| *** wolverineav has joined #openstack-horizon | 13:28 | |
| openstackgerrit | Michael Dovgal proposed openstack/horizon master: Get rid of redundant cinder api calls https://review.openstack.org/482486 | 13:29 |
| *** wolverineav has quit IRC | 13:33 | |
| *** rajalokan has quit IRC | 13:34 | |
| openstackgerrit | Merged openstack/horizon master: Imported Translations from Zanata https://review.openstack.org/483906 | 13:36 |
| *** georgem1 has joined #openstack-horizon | 13:38 | |
| *** jtriley has joined #openstack-horizon | 13:39 | |
| *** catintheroof has joined #openstack-horizon | 13:40 | |
| *** pcaruana has joined #openstack-horizon | 13:56 | |
| *** mdovgal has quit IRC | 14:06 | |
| openstackgerrit | Michael Dovgal proposed openstack/horizon master: WIP Speed up horizon using futurist library https://review.openstack.org/483948 | 14:06 |
| *** ducttape_ has joined #openstack-horizon | 14:13 | |
| *** Daisy_ has joined #openstack-horizon | 14:19 | |
| *** Daisy_ has quit IRC | 14:23 | |
| *** felipemonteiro_ has joined #openstack-horizon | 14:24 | |
| *** felipemonteiro__ has joined #openstack-horizon | 14:25 | |
| *** felipemonteiro_ has quit IRC | 14:29 | |
| *** jtriley has quit IRC | 14:34 | |
| *** jtriley has joined #openstack-horizon | 14:36 | |
| *** yamamoto has quit IRC | 14:36 | |
| *** jamesbenson has joined #openstack-horizon | 14:37 | |
| *** yamamoto has joined #openstack-horizon | 14:40 | |
| *** BLZbubba has joined #openstack-horizon | 14:48 | |
| *** chlong has joined #openstack-horizon | 14:48 | |
| BLZbubba | hi guys, just curious: wtf is the "glyphicons halflings" that horizon uses so often? the UI has a bunch of empty squares all over the place and it looks terrible | 14:48 |
| BLZbubba | using an ubuntu 16.04 desktop with chromium | 14:49 |
| robcresswell | BLZbubba: Glyphicons? Those were removed years ago | 14:49 |
| BLZbubba | this is a fresh ocata install | 14:49 |
| robcresswell | Well, somethings gone funky then :) | 14:49 |
| robcresswell | Thats the default icon font in Bootstrap, but we dont use it any more | 14:50 |
| robcresswell | we use fontawesome instead. | 14:50 |
| BLZbubba | what is bootstrap | 14:50 |
| BLZbubba | guess i could just google it :D | 14:50 |
| robcresswell | A CSS framework | 14:50 |
| robcresswell | Either way, somethings gone wrong with your install | 14:50 |
| robcresswell | or your browsers blocking fonts | 14:50 |
| BLZbubba | or maybe both | 14:51 |
| *** yamamoto has quit IRC | 14:51 | |
| robcresswell | or that | 14:51 |
| BLZbubba | where do the files in /var/lib/openstack-dashboard/static come from? do I just need to change a theme or something? | 14:56 |
| robcresswell | BLZbubba: They're collected with manage.py collectstatic and manage.py compress | 14:56 |
| BLZbubba | grep -ir glyphicons /var/lib/openstack-dashboard/static/ | wc -l | 14:56 |
| BLZbubba | 217 | 14:56 |
| BLZbubba | apparently the ocata packagers didn't get the memo, oh well thanks for the info at least I know where to look now | 14:57 |
| robcresswell | BLZbubba: Thats likely just being collected though, I'm not sure they are really used now. | 14:58 |
| *** lucasxu has joined #openstack-horizon | 14:59 | |
| BLZbubba | any idea where the empty squares are coming from? e.g.: <span class="fa fa-cloud-upload"></span> | 15:03 |
| BLZbubba | just renders a square where an icon probably should be | 15:03 |
| robcresswell | BLZbubba: Yeah, fontawesome is missing | 15:03 |
| robcresswell | or not setup properly | 15:03 |
| robcresswell | or the browsers doing something | 15:03 |
| robcresswell | It should be part of the package install though, so I'd go bug the packagers | 15:03 |
| *** rcernin has quit IRC | 15:05 | |
| *** aaustin has joined #openstack-horizon | 15:14 | |
| *** yamamoto has joined #openstack-horizon | 15:23 | |
| *** aaustin has quit IRC | 15:29 | |
| *** ducttape_ has quit IRC | 15:32 | |
| *** mvk has quit IRC | 15:35 | |
| *** e0ne has quit IRC | 15:44 | |
| BLZbubba | robcresswell: ok i see, I have a plugin that forces all fonts to be the Ubuntu font. it is weird that people are putting graphical icons into fonts now; I guess this plugin should make an exception for fontawesome | 15:47 |
| *** itxaka has quit IRC | 15:50 | |
| robcresswell | BLZbubba: Lol, "now". Icon fonts have been around for a very long time. | 15:52 |
| *** itlinux has joined #openstack-horizon | 15:52 | |
| robcresswell | BLZbubba: I'm fairly surprised you haven't seen other websites break. People usually do icons via fonts. | 15:55 |
| BLZbubba | i see squares now and then, but I always assumed it was the ad blocking hosts file | 15:57 |
| BLZbubba | ASSumed | 15:57 |
| BLZbubba | which i run through a proxy. it breaks random things sometimes | 15:58 |
| *** ying_zuo has joined #openstack-horizon | 16:03 | |
| *** elod has quit IRC | 16:09 | |
| *** elod has joined #openstack-horizon | 16:10 | |
| *** Daisy_ has joined #openstack-horizon | 16:19 | |
| *** lcastell has joined #openstack-horizon | 16:22 | |
| *** jpich has quit IRC | 16:22 | |
| amotoki | robcresswell: I noticed your merged patch on openstackdocstheme. looks really nice! | 16:23 |
| *** Daisy_ has quit IRC | 16:24 | |
| *** lcastell has quit IRC | 16:28 | |
| ying_zuo | amotoki: agree. it's a lot more organized and it added lots of settings that were undocumented before | 16:28 |
| *** ducttape_ has joined #openstack-horizon | 16:29 | |
| robcresswell | ying_zuo: amotoki means the openstackdocstheme patch | 16:29 |
| ying_zuo | oh. sorry :p | 16:29 |
| ying_zuo | I guess that one hasn't been merged either | 16:29 |
| ying_zuo | the one that I was talking about | 16:30 |
| robcresswell | ying_zuo: Yep. You can +2 it ;) | 16:30 |
| ying_zuo | I was waiting for amotoki to take another look :) | 16:31 |
| robcresswell | ying_zuo: You can +2 without merging though | 16:31 |
| ying_zuo | but I think you addressed all his comments as well | 16:31 |
| robcresswell | +1 is kinda odd as core tho :) | 16:31 |
| amotoki | robcresswell: ying_zuo: which one are you talking about? | 16:31 |
| ying_zuo | :p | 16:31 |
| robcresswell | amotoki: https://review.openstack.org/#/c/482437/ | 16:32 |
| amotoki | robcresswell: ah. got it | 16:32 |
| ying_zuo | \o/ it's merging | 16:35 |
| amotoki | today's stage of the tour de france was over. I really enjoyed it and will looks through several patches before going to bed :) | 16:38 |
| ying_zuo | :) | 16:39 |
| amotoki | robcresswell: do we consider django-openstack-auth megre in Pike or defer it in Queen? I am fine with do it in Pike | 16:40 |
| ying_zuo | would be nice if it's in in Pike if packaging is not a concern | 16:41 |
| ying_zuo | I see some patches have changes in two repos so this will speed things up | 16:41 |
| *** jtriley has quit IRC | 16:41 | |
| ying_zuo | then we can start fresh in Queens | 16:42 |
| openstackgerrit | Merged openstack/horizon master: Reorganise and update the settings documentation https://review.openstack.org/482437 | 16:42 |
| amotoki | one big question is when we announce it to the community and close d-o-a patches in master | 16:43 |
| robcresswell | Hang on, one several-thousand line patch at a time. | 16:48 |
| robcresswell | Thanks for the docs merge | 16:48 |
| ying_zuo | wow | 16:48 |
| robcresswell | Personally I'm a fan of merging the two | 16:49 |
| robcresswell | I could see the merit in having them separate originally, but now they are so tighly coupled that it seems pointless | 16:49 |
| robcresswell | I'll send an email and see if we get some responses | 16:49 |
| amotoki | robcresswell: sounds good and thanks. I have no objection on the merge as the dev perspective. | 16:50 |
| amotoki | we just would like to avoid confusion around packagers or others. | 16:51 |
| ying_zuo | yes, I guess we just need to figure out a good time to do it | 16:52 |
| ying_zuo | good night to you two and have a good weekend :) | 16:54 |
| amotoki | ying_zuo: thanks. are you US-based? | 16:56 |
| ying_zuo | yes. it's Friday morning here :) | 16:56 |
| amotoki | looks like PCT | 16:57 |
| ying_zuo | PDT | 16:57 |
| amotoki | ah... | 16:57 |
| *** mvk has joined #openstack-horizon | 16:58 | |
| amotoki | I will be back on tuesday. monday is holiday here. have a good weekend! | 16:58 |
| ying_zuo | thank you :) | 16:58 |
| *** ducttap__ has joined #openstack-horizon | 17:01 | |
| robcresswell | amotoki: \o | 17:02 |
| robcresswell | have a nice weekend | 17:02 |
| *** jtriley has joined #openstack-horizon | 17:02 | |
| *** masco has joined #openstack-horizon | 17:03 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon master: Add Django OpenStack Auth to Horizon https://review.openstack.org/482561 | 17:03 |
| *** ductta___ has joined #openstack-horizon | 17:04 | |
| ying_zuo | thanks | 17:04 |
| *** ducttape_ has quit IRC | 17:04 | |
| *** ducttap__ has quit IRC | 17:08 | |
| *** gyee has joined #openstack-horizon | 17:20 | |
| *** tosky has quit IRC | 17:24 | |
| *** ducttape_ has joined #openstack-horizon | 17:29 | |
| *** ductta___ has quit IRC | 17:33 | |
| *** masco has quit IRC | 17:35 | |
| ying_zuo | Hi Rob. Hope you are sleeping by now. just want to leave you a message. I enjoy the discussion with your and amotoki earlier. I hope we can have this kind of team discussion more often. looking forward to the PTG :) | 17:38 |
| robcresswell | ying_zuo: Haha, its only half 6 here :) | 17:40 |
| ying_zuo | oh right.. | 17:40 |
| ying_zuo | amotoki said a few more reviews before bed. I guess it's late for him. not you. | 17:41 |
| *** pcaruana has quit IRC | 17:41 | |
| *** tosky has joined #openstack-horizon | 17:48 | |
| robcresswell | yeah :) | 17:50 |
| *** yamamoto has quit IRC | 18:03 | |
| *** yamamoto has joined #openstack-horizon | 18:03 | |
| *** ducttape_ has quit IRC | 18:03 | |
| *** yamamoto has quit IRC | 18:04 | |
| *** lcastell has joined #openstack-horizon | 18:15 | |
| lucasxu | or you could go to bed at half 6 on a Friday night ;) | 18:17 |
| *** Daisy_ has joined #openstack-horizon | 18:20 | |
| *** Daisy_ has quit IRC | 18:24 | |
| *** wolverineav has joined #openstack-horizon | 18:26 | |
| *** ducttape_ has joined #openstack-horizon | 18:28 | |
| ying_zuo | :P | 18:28 |
| *** dave-mccowan has quit IRC | 18:28 | |
| *** wolverineav has quit IRC | 18:29 | |
| *** wolverineav has joined #openstack-horizon | 18:30 | |
| *** lcastell has quit IRC | 18:41 | |
| *** lucasxu has quit IRC | 18:47 | |
| *** yamamoto has joined #openstack-horizon | 19:05 | |
| *** ducttape_ has quit IRC | 19:10 | |
| *** e0ne has joined #openstack-horizon | 19:14 | |
| *** yamamoto has quit IRC | 19:17 | |
| robcresswell | mgagne: Around? | 19:28 |
| robcresswell | mgagne: For that loop iteration change, a cleaner way would be to just reverse the loop | 19:29 |
| *** ducttape_ has joined #openstack-horizon | 19:29 | |
| robcresswell | patch 482682 | 19:29 |
| *** ducttape_ has quit IRC | 19:33 | |
| *** ducttape_ has joined #openstack-horizon | 19:39 | |
| *** catintheroof has quit IRC | 20:01 | |
| mgagne | @robcresswell: I tried that solution already =) | 20:04 |
| mgagne | let me try to figure out what went wrong | 20:06 |
| *** georgem1 has left #openstack-horizon | 20:07 | |
| mgagne | @robcresswell: ok, the issue is that if you don't use forEach, the index you would get from the for loop and that would be used in the promise would always be the last index of the array due to the async nature of the promise. | 20:10 |
| *** jtriley has quit IRC | 20:11 | |
| robcresswell | ahh | 20:15 |
| robcresswell | ffs | 20:15 |
| robcresswell | okay | 20:15 |
| *** e0ne has quit IRC | 20:15 | |
| robcresswell | mgagne: One more question; wouldnt foreach still skip when an element is removed? | 20:17 |
| mgagne | no, not according to the tests I wrote | 20:17 |
| mgagne | this feature wasn't tested, it is now and it's working | 20:17 |
| mgagne | but | 20:18 |
| mgagne | I can make it so 2 items are blacklisted from steps | 20:18 |
| mgagne | and see if the problem still happen | 20:18 |
| mgagne | it works in our pre-prod environment | 20:18 |
| mgagne | but I can make sure upstream tests the exact use case we have | 20:18 |
| robcresswell | mgagne: Well, your test isnt using a loop, I think | 20:18 |
| mgagne | the loop is in the implementation, not the test? I'm not sure I understand | 20:19 |
| robcresswell | Yeah | 20:19 |
| robcresswell | I think foreach would still skip the item after the array mutates | 20:19 |
| mgagne | I think not, as stated, I tested in our pre-prod environment and it works now | 20:19 |
| robcresswell | say you're looking at step 3. and you splice it. 4 becomes 3, and then foreach moves to 4 | 20:19 |
| mgagne | even before the bug fix, the foreach loop never skipped an item | 20:20 |
| robcresswell | Because all the index did before was reveal the item that foreach is looking at. | 20:20 |
| robcresswell | Hmm | 20:20 |
| mgagne | inspected and tested with console.log | 20:20 |
| mgagne | the promise is executed later on a mutated array | 20:20 |
| *** Daisy_ has joined #openstack-horizon | 20:20 | |
| mgagne | foreach doesn't execute the promises at this point so array is not mutated | 20:21 |
| mgagne | and therefore, no items are skipped | 20:21 |
| robcresswell | ah, you're right again | 20:22 |
| robcresswell | I'm sorry, I'm being slow as anything today. | 20:22 |
| mgagne | I can update the test | 20:23 |
| mgagne | to cover 2 removed steps | 20:23 |
| robcresswell | mgagne: No its fine, just me being stupid | 20:23 |
| mgagne | will still update to match the bug description and symptom | 20:23 |
| mgagne | because you need 2 removed items for the bug to show | 20:23 |
| *** Daisy_ has quit IRC | 20:25 | |
| robcresswell | mgagne: Sorry for the extra work :p | 20:26 |
| mgagne | no problem =) | 20:26 |
| *** ducttape_ has quit IRC | 20:29 | |
| openstackgerrit | Mathieu Gagné proposed openstack/horizon master: Find latest index before splicing non-ready steps in wizard https://review.openstack.org/482682 | 20:31 |
| *** ducttape_ has joined #openstack-horizon | 20:55 | |
| *** lblanchard has quit IRC | 20:58 | |
| *** ducttape_ has quit IRC | 21:07 | |
| *** chlong has quit IRC | 21:19 | |
| *** ducttape_ has joined #openstack-horizon | 21:27 | |
| *** ducttape_ has quit IRC | 21:30 | |
| *** e0ne has joined #openstack-horizon | 21:36 | |
| *** jamesbenson has quit IRC | 21:50 | |
| *** lblanchard has joined #openstack-horizon | 21:55 | |
| *** e0ne has quit IRC | 21:56 | |
| *** jamesbenson_ has joined #openstack-horizon | 21:57 | |
| *** jamesbenson_ has quit IRC | 22:02 | |
| *** lblanchard has quit IRC | 22:12 | |
| *** itlinux has quit IRC | 22:13 | |
| *** felipemonteiro__ has quit IRC | 22:16 | |
| *** vishwana_ has joined #openstack-horizon | 22:35 | |
| *** vishwanathj has quit IRC | 22:38 | |
| *** jamesbenson has joined #openstack-horizon | 22:52 | |
| *** jamesbenson has quit IRC | 22:56 | |
| *** tosky has quit IRC | 23:05 | |
| *** wolverineav has quit IRC | 23:06 | |
| *** wolverineav has joined #openstack-horizon | 23:07 | |
| *** wolverineav has quit IRC | 23:13 | |
| *** vishwana_ has quit IRC | 23:23 | |
| *** vishwanathj has joined #openstack-horizon | 23:24 | |
| *** itlinux has joined #openstack-horizon | 23:27 | |
| *** itlinux_ has joined #openstack-horizon | 23:43 | |
| *** itlinux has quit IRC | 23:49 | |
| *** lblanchard has joined #openstack-horizon | 23:53 | |
| *** jtriley has joined #openstack-horizon | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!