| *** keiichi has joined #openstack-horizon | 00:05 | |
| *** adriant has joined #openstack-horizon | 00:19 | |
| *** keiichi has quit IRC | 00:22 | |
| *** lcastell has joined #openstack-horizon | 00:26 | |
| *** ducttape_ has joined #openstack-horizon | 00:35 | |
| *** yamamoto_ has joined #openstack-horizon | 00:38 | |
| *** lucasxu has joined #openstack-horizon | 00:42 | |
| *** yamamoto_ has quit IRC | 00:44 | |
| *** lucasxu has quit IRC | 00:44 | |
| *** itlinux has joined #openstack-horizon | 00:44 | |
| *** lucasxu has joined #openstack-horizon | 00:45 | |
| *** shuyingya has joined #openstack-horizon | 00:45 | |
| *** lucasxu has quit IRC | 00:47 | |
| *** lucasxu has joined #openstack-horizon | 00:50 | |
| *** lcastell has quit IRC | 00:53 | |
| *** itlinux has quit IRC | 00:55 | |
| *** itlinux has joined #openstack-horizon | 00:56 | |
| *** itlinux has quit IRC | 00:56 | |
| *** lucasxu has quit IRC | 00:56 | |
| *** lucasxu has joined #openstack-horizon | 00:58 | |
| *** lucasxu has quit IRC | 01:05 | |
| *** ducttape_ has quit IRC | 01:08 | |
| *** lcastell has joined #openstack-horizon | 01:14 | |
| *** lcastell has quit IRC | 01:15 | |
| *** gyee has quit IRC | 01:25 | |
| *** zhurong has joined #openstack-horizon | 01:28 | |
| *** itlinux has joined #openstack-horizon | 01:40 | |
| *** yamamoto_ has joined #openstack-horizon | 01:40 | |
| *** itlinux has quit IRC | 01:45 | |
| *** yamamoto_ has quit IRC | 01:45 | |
| *** chlong has quit IRC | 01:50 | |
| *** lbragstad has joined #openstack-horizon | 01:51 | |
| *** itlinux has joined #openstack-horizon | 01:57 | |
| *** itlinux has quit IRC | 02:05 | |
| *** yamamoto_ has joined #openstack-horizon | 02:16 | |
| *** lbragstad has quit IRC | 02:30 | |
| *** zhurong has quit IRC | 02:30 | |
| *** keiichi has joined #openstack-horizon | 02:42 | |
| *** shuyingya has quit IRC | 02:50 | |
| *** shuyingya has joined #openstack-horizon | 02:51 | |
| *** shuyingy_ has joined #openstack-horizon | 02:53 | |
| openstackgerrit | Ying Zuo proposed openstack/horizon master: Add instance locked status on instances table https://review.openstack.org/331874 | 02:54 |
|---|---|---|
| *** shuyingya has quit IRC | 02:57 | |
| *** shuyingy_ has quit IRC | 03:08 | |
| *** shuyingya has joined #openstack-horizon | 03:08 | |
| *** ducttape_ has joined #openstack-horizon | 03:14 | |
| *** keiichi has quit IRC | 03:16 | |
| *** zackf has joined #openstack-horizon | 03:20 | |
| *** itlinux has joined #openstack-horizon | 03:22 | |
| *** zackf has quit IRC | 03:24 | |
| *** TravT has quit IRC | 03:31 | |
| *** TravT has joined #openstack-horizon | 03:31 | |
| *** ChanServ sets mode: +v TravT | 03:31 | |
| *** TravT_ has joined #openstack-horizon | 03:36 | |
| *** ChanServ sets mode: +v TravT_ | 03:36 | |
| *** TravT has quit IRC | 03:38 | |
| *** TravT_ has quit IRC | 03:51 | |
| *** TravT has joined #openstack-horizon | 03:53 | |
| *** ChanServ sets mode: +v TravT | 03:53 | |
| *** keiichi has joined #openstack-horizon | 03:54 | |
| *** keiichi has quit IRC | 04:00 | |
| *** zhurong has joined #openstack-horizon | 04:00 | |
| *** keiichi has joined #openstack-horizon | 04:01 | |
| *** ducttape_ has quit IRC | 04:02 | |
| *** shuyingy_ has joined #openstack-horizon | 04:11 | |
| *** shuyingya has quit IRC | 04:12 | |
| *** hoonetorg has quit IRC | 04:29 | |
| *** zhurong has quit IRC | 04:30 | |
| *** adriant has quit IRC | 04:35 | |
| *** adriant has joined #openstack-horizon | 04:39 | |
| *** zhurong has joined #openstack-horizon | 04:40 | |
| *** adriant has quit IRC | 04:40 | |
| *** adriant has joined #openstack-horizon | 04:41 | |
| *** shuyingy_ has quit IRC | 04:42 | |
| *** yamamoto_ has quit IRC | 04:44 | |
| *** shuyingya has joined #openstack-horizon | 04:46 | |
| *** hoonetorg has joined #openstack-horizon | 04:46 | |
| *** itlinux has quit IRC | 04:49 | |
| *** pcaruana has joined #openstack-horizon | 04:56 | |
| *** shuyingy_ has joined #openstack-horizon | 05:00 | |
| *** shuyingya has quit IRC | 05:00 | |
| *** dims has quit IRC | 05:09 | |
| *** pcaruana has quit IRC | 05:14 | |
| *** yamamoto has joined #openstack-horizon | 05:31 | |
| *** dims has joined #openstack-horizon | 05:41 | |
| *** keiichi has quit IRC | 05:50 | |
| *** ratailor has joined #openstack-horizon | 05:55 | |
| *** keiichi has joined #openstack-horizon | 05:57 | |
| *** keiichi has quit IRC | 05:59 | |
| *** keiichi has joined #openstack-horizon | 05:59 | |
| *** keiichi has quit IRC | 06:18 | |
| *** udesale has joined #openstack-horizon | 06:19 | |
| *** keiichi has joined #openstack-horizon | 06:20 | |
| *** rcernin has joined #openstack-horizon | 06:21 | |
| *** keiichi has quit IRC | 06:22 | |
| *** keiichi has joined #openstack-horizon | 06:31 | |
| *** tonygunk has quit IRC | 06:49 | |
| *** belmoreira has joined #openstack-horizon | 06:55 | |
| *** pcaruana has joined #openstack-horizon | 07:03 | |
| *** tesseract has joined #openstack-horizon | 07:11 | |
| *** rcernin has quit IRC | 07:52 | |
| *** rcernin has joined #openstack-horizon | 07:52 | |
| *** jpich has joined #openstack-horizon | 07:53 | |
| *** itxaka has joined #openstack-horizon | 08:07 | |
| *** eanderson_ has joined #openstack-horizon | 08:17 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/manila-ui master: Imported Translations from Zanata https://review.openstack.org/471631 | 08:28 |
| *** eanderson_ is now known as eandersson_ | 08:29 | |
| *** keiichi has quit IRC | 08:29 | |
| *** vladiskuz has joined #openstack-horizon | 08:29 | |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/horizon master: Fixing types.MethodType signature for Python 3.5 https://review.openstack.org/471638 | 08:38 |
| *** tosky has joined #openstack-horizon | 08:40 | |
| *** zhurong has quit IRC | 08:47 | |
| *** jamielennox is now known as jamielennox|away | 08:50 | |
| *** mvk has joined #openstack-horizon | 08:57 | |
| *** shuyingy_ has quit IRC | 08:57 | |
| *** shuyingya has joined #openstack-horizon | 08:58 | |
| *** zhurong has joined #openstack-horizon | 09:03 | |
| *** eandersson_ has quit IRC | 09:05 | |
| *** jamielennox|away is now known as jamielennox | 09:10 | |
| *** e0ne has joined #openstack-horizon | 09:31 | |
| *** zhurong has quit IRC | 09:51 | |
| *** mvk has quit IRC | 09:55 | |
| *** tonygunk has joined #openstack-horizon | 09:56 | |
| *** shuyingy_ has joined #openstack-horizon | 10:07 | |
| *** shuyingya has quit IRC | 10:11 | |
| *** wolverineav has joined #openstack-horizon | 10:27 | |
| *** mvk has joined #openstack-horizon | 10:27 | |
| *** wolverineav has quit IRC | 10:31 | |
| *** tonygunk has quit IRC | 10:39 | |
| *** wolverineav has joined #openstack-horizon | 10:39 | |
| *** wolverineav has quit IRC | 10:40 | |
| *** wolverin_ has joined #openstack-horizon | 10:40 | |
| *** wolverineav has joined #openstack-horizon | 10:42 | |
| *** wolverin_ has quit IRC | 10:42 | |
| *** tonygunk has joined #openstack-horizon | 10:45 | |
| *** shuyingy_ has quit IRC | 10:47 | |
| *** shuyingya has joined #openstack-horizon | 10:48 | |
| robcresswell | Anyone run into circular reference errors when using the rest api layer? | 10:53 |
| robcresswell | the trace is zero help, just a generic message. | 10:53 |
| *** elajkat has joined #openstack-horizon | 10:54 | |
| *** e0ne has quit IRC | 11:04 | |
| *** yamamoto has quit IRC | 11:10 | |
| openstackgerrit | Merged openstack/manila-ui master: Imported Translations from Zanata https://review.openstack.org/471631 | 11:21 |
| amotoki | robcresswell: previously (two or more years ago?) we saw the similar problem when importing openstack_dashboard.api not api.rest. | 11:42 |
| robcresswell | amotoki: I managed to fix it, was jus the json encoder tripping over object handling with some weird wrapper classes | 11:43 |
| robcresswell | but thankyou for the reply | 11:43 |
| amotoki | robcresswell: nice. it seems a different problem from what i mentioned. | 11:43 |
| amotoki | robcresswell: btw, could you check this doa build fix? https://review.openstack.org/#/c/470900/ it blocks all in doa | 11:44 |
| robcresswell | amotoki: Thanks! | 11:54 |
| robcresswell | I'll have to tag another release | 11:54 |
| *** chlong has joined #openstack-horizon | 12:03 | |
| *** ratailor has quit IRC | 12:12 | |
| *** ratailor has joined #openstack-horizon | 12:26 | |
| *** yamamoto has joined #openstack-horizon | 12:36 | |
| *** shuyingya has quit IRC | 12:42 | |
| *** yamamoto has quit IRC | 12:47 | |
| *** ducttape_ has joined #openstack-horizon | 12:57 | |
| *** ducttape_ has quit IRC | 13:06 | |
| *** e0ne has joined #openstack-horizon | 13:06 | |
| *** yamamoto has joined #openstack-horizon | 13:08 | |
| *** ducttap__ has joined #openstack-horizon | 13:14 | |
| openstackgerrit | Merged openstack/django_openstack_auth master: Fix doc build https://review.openstack.org/470900 | 13:25 |
| *** e0ne has quit IRC | 13:26 | |
| openstackgerrit | Rob Cresswell proposed openstack/django_openstack_auth master: Updated from global requirements https://review.openstack.org/470088 | 13:26 |
| *** e0ne has joined #openstack-horizon | 13:28 | |
| *** dave-mccowan has joined #openstack-horizon | 13:36 | |
| *** dave-mccowan has quit IRC | 13:41 | |
| *** chlong has quit IRC | 13:43 | |
| *** ratailor has quit IRC | 13:43 | |
| *** dave-mccowan has joined #openstack-horizon | 13:45 | |
| *** ducttap__ has quit IRC | 13:45 | |
| *** ducttape_ has joined #openstack-horizon | 13:46 | |
| *** jtriley has joined #openstack-horizon | 13:52 | |
| *** zhurong has joined #openstack-horizon | 13:54 | |
| *** lcastell has joined #openstack-horizon | 13:54 | |
| *** ducttape_ has quit IRC | 14:01 | |
| *** yamamoto has quit IRC | 14:03 | |
| *** yamamoto has joined #openstack-horizon | 14:03 | |
| *** yamamoto has quit IRC | 14:08 | |
| *** dave-mccowan has quit IRC | 14:12 | |
| *** zhurong has quit IRC | 14:17 | |
| *** ducttape_ has joined #openstack-horizon | 14:20 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Fix styles for error page template https://review.openstack.org/471797 | 14:30 |
| sjmc7 | hi robcresswell | 14:43 |
| robcresswell | sjmc7: o/ | 14:43 |
| sjmc7 | still having a spot of bother with npm tests - do you have a second to see if you’ve seen this before? http://logs.openstack.org/12/457212/2/check/gate-searchlight-ui-nodejs4-npm-run-test/ccc7de0/console.html.gz#_2017-05-25_10_31_28_703804 | 14:43 |
| *** lucasxu has joined #openstack-horizon | 14:44 | |
| robcresswell | sjmc7: I'll take a look | 14:45 |
| *** elajkat has quit IRC | 14:46 | |
| *** lbragstad has joined #openstack-horizon | 14:52 | |
| *** lcastell_ has joined #openstack-horizon | 15:00 | |
| *** lcastell has quit IRC | 15:01 | |
| *** georgem1 has joined #openstack-horizon | 15:10 | |
| *** rcernin has quit IRC | 15:11 | |
| georgem1 | Any idea why Dashboard doesn't respect the OPENSTACK_ENDPOINT_TYPE = "internalURL" in "/etc/openstack-dashboard/local_settings.py" ? I see that it always connects to the public endpoints instead of the internal ones. I'm running Mitaka on Ubuntu 16.04 if it matters. | 15:16 |
| e0ne | hi team. what is going with our tempest and selenium jobs? | 15:16 |
| e0ne | looks like they don't test almost anything :( | 15:16 |
| robcresswell | e0ne: They don't. Tempest has a single test that checks if login works, and the selenium jobs just check that all the legacy JS has passed. | 15:17 |
| e0ne | robcresswell: selenium results: 'Ran 197 tests in 3.064s (SKIP=181)' and 'Ran 1530 tests in 4.342s (SKIP=1529)' | 15:18 |
| e0ne | robcresswell: do we really need devstack jpb just to run only 1 test? it takes more than 30min :( | 15:18 |
| robcresswell | e0ne: 30 mins isnt that long really | 15:19 |
| robcresswell | Most of that is probably devstack setup. | 15:19 |
| robcresswell | I don't think the solution for few tests is to have less tests. | 15:19 |
| e0ne | robcresswell: yes, but 30mins to setup env for only 1 test is too long, IMHO | 15:20 |
| robcresswell | e0ne: I don't really think its bottlenecking anything, and the scenario itself is valuable | 15:20 |
| *** dave-mccowan has joined #openstack-horizon | 15:21 | |
| robcresswell | I'd rather keep the infra for people to add more, than remove it because waiting an extra 25 mins is inconvenient. | 15:21 |
| *** itxaka has quit IRC | 15:21 | |
| e0ne | robcresswell: I agree that this test is needed. just surprised why this job takes so much time | 15:21 |
| robcresswell | e0ne: Like I said, its mostly devstack setup time. | 15:21 |
| e0ne | robcresswell: and what about selenium tests? I'm new to horizon community but can help with it if needed | 15:22 |
| robcresswell | iirc the selenium test basically just verifies a couple of legacy JS scripts pass, but I've not spent much time with it | 15:23 |
| e0ne | robcresswell: ok, thanks for the info. I'll try to find some time to take a deeper look on it | 15:24 |
| robcresswell | e0ne: Could look into tempest; or functional JS testing. We still only really unit test the current JS. | 15:25 |
| e0ne | robcresswell: got it, thanks! | 15:26 |
| *** chlong has joined #openstack-horizon | 15:27 | |
| *** lucasxu has quit IRC | 15:30 | |
| *** itlinux has joined #openstack-horizon | 15:34 | |
| *** ralonsoh has joined #openstack-horizon | 15:35 | |
| *** udesale has quit IRC | 15:36 | |
| *** gyee has joined #openstack-horizon | 15:41 | |
| *** itlinux has quit IRC | 15:42 | |
| *** belmoreira has quit IRC | 15:44 | |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/manila-ui master: Some tweaks for modal forms https://review.openstack.org/336445 | 15:48 |
| robcresswell | sjmc7: I would guess it is related to https://review.openstack.org/#/c/313685/ | 15:48 |
| robcresswell | sjmc7: That matches up with the timescale from the initial patch too, 6 weeks ago | 15:48 |
| sjmc7 | wow, that’s got some history | 15:48 |
| openstackgerrit | Merged openstack/horizon master: Add config for default create volume option https://review.openstack.org/425283 | 15:49 |
| sjmc7 | any idea what a fix might be? my angular is terrible | 15:50 |
| openstackgerrit | Merged openstack/horizon master: Fix instance launch dialog under MSIE11 https://review.openstack.org/469452 | 15:52 |
| *** TravT_ has joined #openstack-horizon | 15:54 | |
| *** ChanServ sets mode: +v TravT_ | 15:54 | |
| ralonsoh | amotoki: hi | 15:54 |
| amotoki | ralonsoh: hi | 15:55 |
| ralonsoh | amotoki: about https://bugs.launchpad.net/neutron/+bug/1695954 | 15:55 |
| openstack | Launchpad bug 1695954 in neutron "QoS policy API does not accept 'tenant_id' filter" [Medium,New] - Assigned to Akihiro Motoki (amotoki) | 15:55 |
| ralonsoh | amotoki: I don't think there is a bug here | 15:55 |
| ralonsoh | amotoki: let me explain my self | 15:55 |
| amotoki | ralonsoh: sure. go ahead | 15:55 |
| ralonsoh | amotoki: tenant_id is not use anymore. This parameter was replaced with project_id. | 15:56 |
| ralonsoh | amotoki: and in python-openstackclient is not used anymore | 15:56 |
| *** TravT has quit IRC | 15:56 | |
| ralonsoh | amotoki: pyhton-neutronclient is going to be deprecated | 15:56 |
| amotoki | ralonsoh: this is a bug in neutron. | 15:57 |
| ralonsoh | amotoki: do you need to have project_id and tenant_id in the API? | 15:57 |
| amotoki | ralonsoh: neutron API now accepts both tenant_id and project_id and both should be treated eqaully | 15:57 |
| amotoki | ralonsoh: actually the neutron API does not support microversioning yet and this mean we don't have a way to drop tenant_id support in a way that API consumers discover it. | 15:58 |
| amotoki | ralonsoh: API consumers do not know what OpenStack release actually run in their cloud provider. | 15:59 |
| amotoki | ralonsoh: this is the reason I filed a bug to neutron | 15:59 |
| robcresswell | amotoki, ralonsoh: Could you this discussion in the Neutron channel? It seems more relevant than here :) | 16:00 |
| ralonsoh | amotoki: but you are filling the bug with neutron client commands | 16:00 |
| amotoki | robcresswell: sure. makes sense | 16:01 |
| -amotoki- ralonsoh: let's move to the #-neutron channel | 16:01 | |
| robcresswell | sjmc7: Nothing jumping out at me :( The usage looks the same as in Horizon | 16:02 |
| sjmc7 | that’s sad :( | 16:02 |
| sjmc7 | i guess i can disable the test as a last resort | 16:03 |
| openstackgerrit | Ferenc Cserepkei proposed openstack/horizon master: TrunkPort, Horizon workflow: launch instance https://review.openstack.org/452725 | 16:03 |
| *** dave-mccowan has quit IRC | 16:05 | |
| *** david-lyle has joined #openstack-horizon | 16:07 | |
| *** ChanServ sets mode: +o david-lyle | 16:07 | |
| *** TravT_ has quit IRC | 16:26 | |
| *** lucasxu has joined #openstack-horizon | 16:28 | |
| *** tesseract has quit IRC | 16:34 | |
| *** TravT has joined #openstack-horizon | 16:35 | |
| *** ChanServ sets mode: +v TravT | 16:35 | |
| *** jpich has quit IRC | 16:36 | |
| ralonsoh | betherly: hi | 16:39 |
| ralonsoh | betherly: thank you for adding the QoS panel to horizon | 16:39 |
| ralonsoh | betherly: is there a link for this panel in project > network? Because I don't see it. I can access to this panel using the url /dashboard/project/network_qos | 16:41 |
| betherly | ralonsoh: hi! yes, it is in the menu project > network > network qos | 16:41 |
| betherly | (bottom option) | 16:41 |
| ralonsoh | betherly: hmmm, something must be wrong in my deployment. I can access using the url but I don't see the link in the menu | 16:42 |
| ralonsoh | betherly: I'll try to fix it | 16:42 |
| *** dave-mccowan has joined #openstack-horizon | 16:42 | |
| robcresswell | ralonsoh: Policy, perhaps? | 16:43 |
| ralonsoh | robcresswell: I'm using both demo and admin | 16:44 |
| *** ediardo has quit IRC | 16:45 | |
| robcresswell | ¯\_(ツ)_/¯ | 16:45 |
| ralonsoh | robcresswell: hehehe | 16:46 |
| openstackgerrit | Ferenc Cserepkei proposed openstack/horizon master: TrunkPort, Horizon workflow: launch instance https://review.openstack.org/452725 | 16:49 |
| *** itlinux has joined #openstack-horizon | 16:50 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon master: Angular Overview Panel https://review.openstack.org/450629 | 16:53 |
| robcresswell | ^^ That just needs tests and a couple UI niceties now, but the content is all there I think. Unless Swift have quotas too... | 16:54 |
| *** e0ne has quit IRC | 16:57 | |
| openstackgerrit | Merged openstack/django_openstack_auth master: Updated from global requirements https://review.openstack.org/470088 | 16:59 |
| openstackgerrit | Merged openstack/horizon master: Fix AttributeError in project/admin snapshot detail page https://review.openstack.org/470749 | 17:02 |
| *** ralonsoh has quit IRC | 17:06 | |
| *** yamamoto has joined #openstack-horizon | 17:06 | |
| *** mvk has quit IRC | 17:10 | |
| *** yamamoto has quit IRC | 17:11 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila-ui master: Add support of share groups https://review.openstack.org/468899 | 17:22 |
| *** itlinux has quit IRC | 17:24 | |
| jeremy_moffitt | not going to be able to make the meeting today, but if you're looking for review requests: https://review.openstack.org/#/c/337936/ has been waiting a bit for a core (has a quintet of +1s), and separately https://review.openstack.org/#/c/367629/ has a +2 but not a +A, not sure if there are additional concerns that need addressed there or not... | 17:24 |
| *** wolverineav has quit IRC | 17:26 | |
| *** rcernin has joined #openstack-horizon | 17:30 | |
| *** wolverineav has joined #openstack-horizon | 17:32 | |
| eandersson | Anyone that can take a look at this fix? https://review.openstack.org/#/c/471638/1/openstack_dashboard/test/integration_tests/pages/navigation.py | 17:35 |
| eandersson | For some reason the lbaas dashboard imports the helpers, and that line is currently breaking the Python 3.5 tests | 17:37 |
| eandersson | https://github.com/openstack/octavia-dashboard/blob/master/neutron_lbaas_dashboard/tests/integration_tests/tests/test_loadbalancers.py#L13 | 17:37 |
| *** TravT has quit IRC | 17:38 | |
| *** e0ne has joined #openstack-horizon | 17:39 | |
| *** TravT has joined #openstack-horizon | 17:39 | |
| *** ChanServ sets mode: +v TravT | 17:39 | |
| e0ne | could anybody please review https://review.openstack.org/#/c/471797/? this bug is reproducible on master and ocata branches | 17:45 |
| *** wolverineav has quit IRC | 17:50 | |
| *** wolverineav has joined #openstack-horizon | 17:50 | |
| *** itlinux has joined #openstack-horizon | 17:54 | |
| *** gary-smith has quit IRC | 18:00 | |
| *** e0ne has quit IRC | 18:02 | |
| *** lblanchard has joined #openstack-horizon | 18:03 | |
| *** lblanchard has quit IRC | 18:04 | |
| *** lblanchard has joined #openstack-horizon | 18:04 | |
| *** itlinux has quit IRC | 18:05 | |
| *** itlinux has joined #openstack-horizon | 18:11 | |
| *** gary-smith has joined #openstack-horizon | 18:12 | |
| *** dave-mccowan has quit IRC | 18:12 | |
| *** dave-mccowan has joined #openstack-horizon | 18:16 | |
| *** lblanchard has quit IRC | 18:16 | |
| *** lblanchard has joined #openstack-horizon | 18:16 | |
| *** lblanchard1 has joined #openstack-horizon | 18:16 | |
| *** lblanchard has quit IRC | 18:16 | |
| *** lblanchard has joined #openstack-horizon | 18:18 | |
| *** lblanchard1 has quit IRC | 18:18 | |
| *** e0ne has joined #openstack-horizon | 18:19 | |
| *** dave-mccowan has quit IRC | 18:20 | |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/horizon master: Fixing types.MethodType signature for Python 3.5 https://review.openstack.org/471638 | 18:37 |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/horizon master: Fixing types.MethodType signature for Python 3.5 https://review.openstack.org/471638 | 18:56 |
| *** itlinux has quit IRC | 19:00 | |
| *** itlinux has joined #openstack-horizon | 19:00 | |
| robcresswell | eandersson: Urgh, got any docs reference I can look at? Saves me hunting through the web | 19:01 |
| robcresswell | Looks like a bit of mysterious change, thats all :) | 19:01 |
| eandersson | I couldn't really find any good documentation on this | 19:02 |
| eandersson | We ended up using this as a reference | 19:02 |
| eandersson | https://bitbucket.org/gutworth/six/src/92e1c746e1abfbdb94705b821bc93766083efc54/six.py?at=default&fileviewer=file-view-default#six.py-543 | 19:03 |
| robcresswell | 0.o | 19:03 |
| eandersson | Basically if you try to run that code using Python 3+ you will hit | 19:04 |
| eandersson | > TypeError: method expected 2 arguments, got 3 | 19:04 |
| eandersson | e.g. as seen in the octavia dashboard test here http://logs.openstack.org/41/471841/1/check/gate-octavia-dashboard-python35/323585e/console.html | 19:04 |
| robcresswell | eandersson: Shouldnt the patch wrap it with a py2/3 check? | 19:04 |
| eandersson | robcresswell: I changed it to use six, which does that. | 19:04 |
| robcresswell | eandersson: Ah so you did, stupid gerrit ui. | 19:05 |
| robcresswell | was looking at old patch. | 19:05 |
| robcresswell | I wish they would add a "THIS IS NOT THE LATEST PATCH" banner | 19:05 |
| eandersson | I know right | 19:05 |
| robcresswell | Once its passed and verified that lbaas is fixed I'll merge it | 19:06 |
| eandersson | Sweet - thanks | 19:06 |
| robcresswell | np | 19:08 |
| *** yamamoto has joined #openstack-horizon | 19:08 | |
| *** lblanchard has quit IRC | 19:09 | |
| robcresswell | eandersson: One thing; could you fill out the commit message with the reasoning a little further? Like referencing that lbaas was broken, and the code used as a ref for the fix | 19:10 |
| robcresswell | eandersson: Would be helpful if it ever needs to be updated or reverted | 19:10 |
| eandersson | Sure | 19:10 |
| *** yamamoto has quit IRC | 19:12 | |
| *** rcernin has quit IRC | 19:17 | |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/horizon master: Fixing types.MethodType signature for Python 3.5 https://review.openstack.org/471638 | 19:20 |
| *** lblanchard has joined #openstack-horizon | 19:21 | |
| *** lblanchard has quit IRC | 19:22 | |
| *** lblanchard1 has joined #openstack-horizon | 19:22 | |
| *** dave-mccowan has joined #openstack-horizon | 19:23 | |
| *** wolverineav has quit IRC | 19:24 | |
| eandersson | robcresswell: I didn't include the code, but I could add that simply importing that file will cause the issue (or executing navigation.py) | 19:25 |
| robcresswell | eandersson: Sure, as long as I can figure it out in 6 months time | 19:29 |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/horizon master: Fixing types.MethodType signature for Python 3.5 https://review.openstack.org/471638 | 19:32 |
| eandersson | I suck at writing detailed descriptions :p | 19:32 |
| *** TravT has quit IRC | 19:33 | |
| *** TravT has joined #openstack-horizon | 19:34 | |
| *** ChanServ sets mode: +v TravT | 19:34 | |
| *** rcernin has joined #openstack-horizon | 19:35 | |
| *** TravT_ has joined #openstack-horizon | 19:40 | |
| *** ChanServ sets mode: +v TravT_ | 19:40 | |
| *** TravT has quit IRC | 19:40 | |
| *** lblanchard1 has quit IRC | 20:03 | |
| -openstackstatus- NOTICE: The Gerrit service on review.openstack.org is being restarted now to clear some excessive connection counts while we debug the intermittent request failures reported over the past few minutes | 20:05 | |
| *** lblanchard has joined #openstack-horizon | 20:05 | |
| *** lblanchard has quit IRC | 20:06 | |
| *** rubasov has quit IRC | 20:08 | |
| *** georgem1 has quit IRC | 20:10 | |
| *** rubasov has joined #openstack-horizon | 20:18 | |
| *** e0ne_ has joined #openstack-horizon | 20:19 | |
| *** wolverineav has joined #openstack-horizon | 20:20 | |
| *** e0ne has quit IRC | 20:22 | |
| *** e0ne has joined #openstack-horizon | 20:40 | |
| *** e0ne has quit IRC | 20:42 | |
| *** e0ne_ has quit IRC | 20:42 | |
| *** e0ne has joined #openstack-horizon | 20:44 | |
| *** lblanchard has joined #openstack-horizon | 20:45 | |
| *** pcaruana has quit IRC | 20:53 | |
| *** pcaruana has joined #openstack-horizon | 20:53 | |
| *** jtriley has quit IRC | 20:55 | |
| *** lblanchard has quit IRC | 21:09 | |
| *** pcaruana has quit IRC | 21:16 | |
| *** e0ne has quit IRC | 21:19 | |
| *** cargonza_ has joined #openstack-horizon | 21:24 | |
| *** betherly_ has joined #openstack-horizon | 21:24 | |
| *** frickler_ has joined #openstack-horizon | 21:26 | |
| *** wolverineav has quit IRC | 21:29 | |
| *** Alex_Oughton has joined #openstack-horizon | 21:29 | |
| *** AlexOughton has quit IRC | 21:29 | |
| *** cargonza has quit IRC | 21:29 | |
| *** betherly has quit IRC | 21:29 | |
| *** adriant has quit IRC | 21:29 | |
| *** fbouliane has quit IRC | 21:29 | |
| *** frickler has quit IRC | 21:29 | |
| *** hoonetorg has quit IRC | 21:29 | |
| *** betherly_ is now known as betherly | 21:29 | |
| *** cargonza_ is now known as cargonza | 21:29 | |
| *** hoonetorg has joined #openstack-horizon | 21:30 | |
| *** fbouliane has joined #openstack-horizon | 21:30 | |
| *** rcernin has quit IRC | 21:44 | |
| *** lucasxu has quit IRC | 21:45 | |
| *** catintheroof has joined #openstack-horizon | 21:47 | |
| *** tosky has quit IRC | 22:19 | |
| *** itlinux has quit IRC | 22:31 | |
| *** chlong has quit IRC | 22:32 | |
| openstackgerrit | Merged openstack/horizon master: Fix styles for error page template https://review.openstack.org/471797 | 22:34 |
| *** adriant has joined #openstack-horizon | 22:37 | |
| *** itlinux has joined #openstack-horizon | 22:42 | |
| *** catintheroof has quit IRC | 22:46 | |
| *** itlinux has quit IRC | 22:54 | |
| *** lbragstad has quit IRC | 23:00 | |
| *** yamamoto_ has joined #openstack-horizon | 23:11 | |
| *** openstack has joined #openstack-horizon | 23:16 | |
| *** ducttape_ has quit IRC | 23:24 | |
| *** ducttape_ has joined #openstack-horizon | 23:26 | |
| *** yamamoto_ has joined #openstack-horizon | 23:47 | |
| *** ducttape_ has quit IRC | 23:52 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!