| *** itlinux has joined #openstack-horizon | 00:21 | |
| *** harlowja has quit IRC | 00:41 | |
| *** amotoki_away is now known as amotoki | 00:59 | |
| *** yamamoto has quit IRC | 01:00 | |
| *** yamamoto has joined #openstack-horizon | 01:00 | |
| *** itlinux has quit IRC | 01:10 | |
| *** jtriley has joined #openstack-horizon | 01:29 | |
| *** harlowja has joined #openstack-horizon | 01:29 | |
| *** eandersson has quit IRC | 01:37 | |
| *** yamamoto has quit IRC | 01:39 | |
| *** eandersson has joined #openstack-horizon | 01:47 | |
| *** yamamoto has joined #openstack-horizon | 01:50 | |
| *** yamamoto has quit IRC | 01:53 | |
| *** yamamoto has joined #openstack-horizon | 01:56 | |
| *** harlowja has quit IRC | 02:01 | |
| *** yamamoto has quit IRC | 02:19 | |
| *** yamamoto has joined #openstack-horizon | 02:22 | |
| *** yamamoto has quit IRC | 02:27 | |
| *** amotoki is now known as amotoki_away | 02:39 | |
| *** itlinux has joined #openstack-horizon | 02:56 | |
| *** itlinux has quit IRC | 02:58 | |
| *** lucasxu has joined #openstack-horizon | 03:14 | |
| *** itlinux has joined #openstack-horizon | 03:20 | |
| *** yamamoto has joined #openstack-horizon | 03:27 | |
| *** lucasxu has quit IRC | 03:35 | |
| *** yamamoto has quit IRC | 03:36 | |
| *** harlowja has joined #openstack-horizon | 04:35 | |
| *** itlinux has quit IRC | 05:14 | |
| *** yamamoto has joined #openstack-horizon | 05:26 | |
| *** yamamoto has quit IRC | 05:31 | |
| *** harlowja has quit IRC | 05:32 | |
| *** amotoki_away is now known as amotoki | 05:39 | |
| *** amotoki is now known as amotoki_away | 05:49 | |
| *** ircuser-1 has quit IRC | 06:03 | |
| openstackgerrit | Merged openstack/horizon master: Updated from global requirements https://review.openstack.org/468482 | 08:47 |
|---|---|---|
| *** pcaruana has joined #openstack-horizon | 08:50 | |
| *** pcaruana has quit IRC | 09:24 | |
| *** yingjun has quit IRC | 09:30 | |
| *** yamamoto has joined #openstack-horizon | 09:42 | |
| *** yamamoto has quit IRC | 09:44 | |
| *** yamamoto has joined #openstack-horizon | 10:21 | |
| *** yamamoto has quit IRC | 10:29 | |
| *** rajalokan has joined #openstack-horizon | 10:51 | |
| *** yamamoto has joined #openstack-horizon | 10:54 | |
| *** yamamoto has quit IRC | 10:59 | |
| *** yamamoto has joined #openstack-horizon | 11:40 | |
| *** yamamoto has quit IRC | 11:46 | |
| *** wolverineav has joined #openstack-horizon | 11:51 | |
| *** openstackgerrit has quit IRC | 12:02 | |
| -openstackstatus- NOTICE: The Gerrit service on review.openstack.org is restarting to clear some hung API connections and should return to service momentarily. | 12:03 | |
| *** yamamoto has joined #openstack-horizon | 12:19 | |
| *** yamamoto has quit IRC | 12:25 | |
| *** yamamoto has joined #openstack-horizon | 12:26 | |
| *** makowals has quit IRC | 12:32 | |
| *** aortega has quit IRC | 12:32 | |
| *** aortega has joined #openstack-horizon | 12:32 | |
| *** makowals has joined #openstack-horizon | 12:33 | |
| *** pcaruana has joined #openstack-horizon | 12:34 | |
| *** yamamoto has quit IRC | 13:21 | |
| *** yamamoto has joined #openstack-horizon | 13:24 | |
| *** yamamoto has quit IRC | 13:29 | |
| *** ianychoi has quit IRC | 13:34 | |
| *** ianychoi has joined #openstack-horizon | 13:35 | |
| *** rajalokan has quit IRC | 13:56 | |
| *** yamamoto has joined #openstack-horizon | 14:27 | |
| *** yamamoto has quit IRC | 14:35 | |
| *** wolverineav has quit IRC | 14:45 | |
| *** wolverineav has joined #openstack-horizon | 14:48 | |
| *** savvas has quit IRC | 14:50 | |
| *** wolverineav has quit IRC | 14:52 | |
| *** jerrygb has quit IRC | 15:37 | |
| *** masco has joined #openstack-horizon | 16:33 | |
| *** masco has quit IRC | 16:52 | |
| lenards | I'm trying to work on a bug, and I can't figure out how to pull someone's topic branch | 17:36 |
| lenards | rob mentioned that i could "push a new patchset" to this https://review.openstack.org/#/c/457194/ | 17:36 |
| lenards | but I'm too much of a newb w/ gerrit and git review to understand if bugs/1420370 is a branch I can pull from the `review` remote, or what | 17:37 |
| lenards | I can take this question to #openstack-dev or #openstack-101 if that's the right move | 17:38 |
| lenards | ugh - I meant of found waht I'm missing ... nvm | 17:39 |
| lenards | in someone searches and seeing my flailing... | 17:50 |
| lenards | the answer to my question, is that you can fetch the topic by using the $PARENT_CHANGE_NUMBER, which is the number the review URI and noted Change {id} | 17:50 |
| lenards | In my case, it was 457194 ... so `git review -d 457194` | 17:50 |
| *** openstackgerrit has joined #openstack-horizon | 17:55 | |
| openstackgerrit | Andrew Lenards proposed openstack/horizon master: Remove redundant keyword argument https://review.openstack.org/468665 | 17:55 |
| lenards | ugh - I didn't realize it would make a new review for the change :/ | 17:56 |
| robcresswell | lenards: If you do got review -d and then git review it should override the original | 18:15 |
| lenards | that's what I did | 18:16 |
| lenards | huh | 18:16 |
| lenards | http://paste.openstack.org/show/610792/ | 18:17 |
| lenards | should I have done a `git review -D`? or something else? | 18:17 |
| lenards | the original change is failing 4 of the gates and when I run `tox` locally, it's failing tests | 18:18 |
| lenards | but the local tox fails could be me doing with the local env | 18:18 |
| lenards | robcresswell: is it because I'm not the author of the original patchset? | 18:19 |
| robcresswell | lenards: Nah you should be able to push to anyone's change | 19:00 |
| robcresswell | I do, pretty often | 19:01 |
| *** chlong has joined #openstack-horizon | 19:12 | |
| lenards | But you have the permissions I bet | 19:31 |
| lenards | I tried to do a `git review -D` and got a "you don't have 'Push' right" or something | 19:33 |
| *** pcaruana has quit IRC | 19:40 | |
| lenards | I mean, I know we met in Boston - but it might seem like I'm a dolt or somewhat incompetent, so here's the paste on trying to `git review -D`, which I believe is how I would have overridden the topic branch with a new patchset (maybe) | 20:25 |
| lenards | http://paste.openstack.org/show/610796/ | 20:25 |
| lenards | the key line to me is: "You need 'Push' rights to upload code review requests. " | 20:26 |
| lenards | but I'm totally new to gerrit and git-review, so there's that | 20:26 |
| lenards | I think figured out where I screwed up ...I didn't have a Change-Id in my commit messages | 20:59 |
| openstackgerrit | Andrew Lenards proposed openstack/horizon master: Added an asterisk on the network address field of subnet create https://review.openstack.org/468675 | 21:43 |
| *** wolverineav has joined #openstack-horizon | 21:44 | |
| openstackgerrit | Andrew Lenards proposed openstack/horizon master: Added an asterisk on the network address field of subnet create https://review.openstack.org/457194 | 21:47 |
| robcresswell | lenards: Were you doing a git commit --amend? It should've kept the same change ID. I guess gerrit tracks by the changeid. | 21:55 |
| robcresswell | lenards: Also please don't worry about seeming stupid; I would prefer you ask questions than bang your head against a wall and get nothing done. | 21:56 |
| lenards | No, I misunderstood and I did it as a new comment - so there was a new Change-Id, so I've undone it (I think/hope) by doing a squash of my changes into Rajib's commit | 21:56 |
| robcresswell | lenards: Ah, okay. So the way we work is always single commits; if you edit someone else's, or your own work, you always want to amend the existing commit, not add a new one. | 21:57 |
| lenards | I learned something about gerrit / git-review | 21:57 |
| lenards | Okay, should I try to undo - what I've done? I'm not sure if my squash was a no-no. | 21:58 |
| robcresswell | lenards: If its squashed it should still seem like a single commit. I'll take a look on Monday :) | 21:59 |
| lenards | I see now how doing a `git commit --amend` would have been better - as the changeset would be associated ... from a history perspective, I think what I've done is still acceptable | 21:59 |
| lenards | ya - the squash will just look like the original author did it that way from jump-streeet | 21:59 |
| lenards | which makes the -1 feedback likely a bit odd | 21:59 |
| lenards | but whenever is fine by me ... just trying to become half-productive | 22:01 |
| *** wolverineav has quit IRC | 22:38 | |
| *** wolverineav has joined #openstack-horizon | 22:39 | |
| *** wolverineav has quit IRC | 22:45 | |
| *** andrewbogott has quit IRC | 22:54 | |
| *** sridhar_ram has quit IRC | 22:54 | |
| *** ediardo has quit IRC | 22:54 | |
| *** mgagne has quit IRC | 22:54 | |
| *** asettle has quit IRC | 22:55 | |
| *** sridhar_ram has joined #openstack-horizon | 22:57 | |
| *** ediardo has joined #openstack-horizon | 22:57 | |
| *** jlopezgu has quit IRC | 22:58 | |
| *** asettle has joined #openstack-horizon | 23:00 | |
| *** asettle is now known as Guest59427 | 23:01 | |
| *** mgagne has joined #openstack-horizon | 23:01 | |
| *** andrewbogott has joined #openstack-horizon | 23:01 | |
| *** jlopezgu has joined #openstack-horizon | 23:01 | |
| *** mgagne is now known as Guest79619 | 23:01 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!