Friday, 2016-11-18

openstackgerritErnest Millan proposed openstack/horizon: Pass network object to _create_subnet  https://review.openstack.org/39864700:05
*** zhurong has joined #openstack-horizon00:10
*** ducttape_ has joined #openstack-horizon00:17
*** ducttape_ has quit IRC00:17
*** ducttape_ has joined #openstack-horizon00:17
*** ducttape_ has quit IRC00:23
*** zhurong has quit IRC00:24
*** ducttape_ has joined #openstack-horizon00:33
*** Zer0Byte__ has quit IRC00:43
*** gyee has quit IRC00:53
*** ducttape_ has quit IRC00:57
*** ducttape_ has joined #openstack-horizon01:05
*** chlong has quit IRC01:11
*** tjones has joined #openstack-horizon01:26
*** zhurong has joined #openstack-horizon01:35
*** zhugaoxiao has quit IRC01:47
*** walharthi has joined #openstack-horizon01:49
*** revon has quit IRC01:52
*** chetna1 has quit IRC01:54
*** chetna1 has joined #openstack-horizon01:55
*** ducttape_ has quit IRC02:14
*** bpokorny_ has joined #openstack-horizon02:16
*** bpokorny has quit IRC02:19
*** bpokorny_ has quit IRC02:21
*** tjones has quit IRC02:25
*** lblanchard has quit IRC02:43
*** kenji-i has quit IRC02:44
*** dave-mccowan has joined #openstack-horizon02:47
*** walharthi has quit IRC02:48
*** kenji-i has joined #openstack-horizon02:56
*** walharthi has joined #openstack-horizon03:01
*** ducttape_ has joined #openstack-horizon03:01
*** yamamot__ has joined #openstack-horizon03:05
*** walharthi has quit IRC03:06
*** tqtran has quit IRC03:07
*** zhurong_ has joined #openstack-horizon03:10
*** zhurong has quit IRC03:12
*** bpokorny has joined #openstack-horizon03:33
*** wangbo has quit IRC03:34
*** zhurong_ has quit IRC03:42
*** zhurong has joined #openstack-horizon03:43
*** chetna1 has quit IRC03:46
*** tjones has joined #openstack-horizon03:47
*** chetna1 has joined #openstack-horizon03:47
*** ducttape_ has quit IRC03:49
*** ducttape_ has joined #openstack-horizon03:51
*** wangbo has joined #openstack-horizon03:51
*** ducttape_ has quit IRC03:51
*** ducttape_ has joined #openstack-horizon03:52
kenji-iSomething is happening now in npm test. As far as I see in my env, horizon.languagecode seems to be undefined. hmm.03:54
r1chardj0n3shmm03:55
*** dave-mccowan has quit IRC03:56
*** ducttape_ has quit IRC03:56
r1chardj0n3skenji-i: yep, I can reproduce that locally; seems to be a recent change, I'll bisect to try to narrow it down03:57
*** walharthi has joined #openstack-horizon04:02
r1chardj0n3shttps://review.openstack.org/#/c/382102/ is the culprit04:05
r1chardj0n3sso on my system, I'm not sure LANGUAGE_CODE is set, which results in horizon.languageCode being "" which breaks Date.toLocaleString04:09
*** tjones has quit IRC04:10
r1chardj0n3sbut that's not the issue, even if it is bizarro04:13
r1chardj0n3sok, something changed Horizon to start formatting dates to local dates04:13
r1chardj0n3sin that patch above04:14
r1chardj0n3sthat's broken the test for everyone not in the UTC timezone04:14
*** ctayal has joined #openstack-horizon04:14
r1chardj0n3sso the question is whether I revert the patch or try to fix it04:16
openstackgerritRichard Jones proposed openstack/horizon: Revert "In Images Overview, dates should be properly formatted"  https://review.openstack.org/39937004:17
*** ctayal has quit IRC04:20
*** tjones has joined #openstack-horizon04:21
*** walharthi has quit IRC04:23
*** walharthi has joined #openstack-horizon04:23
*** ratailor has joined #openstack-horizon04:31
*** tjones has quit IRC04:37
*** TravT has joined #openstack-horizon04:52
*** ChanServ sets mode: +v TravT04:52
*** walharthi has quit IRC04:53
*** bpokorny has quit IRC05:00
*** bpokorny has joined #openstack-horizon05:01
*** vishwanathj has joined #openstack-horizon05:05
*** bpokorny has quit IRC05:06
*** masco has joined #openstack-horizon05:06
*** udesale has joined #openstack-horizon05:18
*** ducttape_ has joined #openstack-horizon05:30
kenji-ir1chardj0n3s I had been out. Great investigation! And I confirmed your patch https://review.openstack.org/#/c/399370/1 but same error would occur. I'm missing something?05:30
*** hurgleburgler has quit IRC05:33
*** ducttape_ has quit IRC05:34
*** walharthi has joined #openstack-horizon05:35
*** walharthi has quit IRC05:35
r1chardj0n3shmm, I don't see any errors when running with that patch. weird05:38
r1chardj0n3skenji-i: I saw the check error, and tried to reproduce it locally, but could not (even with a fresh install of npm etc.)05:38
*** yamamot__ has quit IRC05:41
kenji-ir1chardj0n3s: I also did a refresh install of npm and tried again, but its result was same. hmm.. it's curious.05:44
r1chardj0n3sweird05:44
r1chardj0n3syou're seeing the filter error?05:44
kenji-iNo, same as errors of https://review.openstack.org/#/c/399370/105:54
r1chardj0n3shuh. I definitely don't see those locally. can you see a cause for them on your local system?05:56
kenji-ir1chardj0n3s: Oh, It may be caused by https://review.openstack.org/#/c/398292/05:59
r1chardj0n3soh darn06:00
r1chardj0n3sI should have that, but will double-check06:00
openstackgerritRichard Jones proposed openstack/horizon: Remove use of scope from action service  https://review.openstack.org/34514506:03
r1chardj0n3skenji-i: I have XStatic-Angular-Gettext (2.3.8.0) installed in my test env06:04
r1chardj0n3shmm, it's definitely repeatble failure in jenkins though. no idea why I can't repeat it here06:06
r1chardj0n3sgonna completely blow away my env06:06
robcresswellr1chardj0n3s: Probably because of the lib upgrades06:08
r1chardj0n3srobcresswell: that's kenji-i's posit. I can't reproduce tho, even with the latest libs (AFAICT)06:09
robcresswellr1chardj0n3s: npm uses the deps installed in a venv, but won't update that venv unless it doesn't exist iirc06:09
r1chardj0n3srobcresswell: yep, but I checked the versions installed in the venv. must've missed something tho06:09
robcresswellr1chardj0n3s: I bet your .venv doesn't have jsencrypt 2.3.1.006:10
robcresswell:)06:10
r1chardj0n3syep, it does06:10
r1chardj0n3s:/06:10
robcresswellDang06:10
* robcresswell has no more theories06:10
r1chardj0n3sI did a fresh env about 30 minutes ago06:10
r1chardj0n3sbut I'm nuking everything now, just in case there's, like, env bleeding or something06:11
r1chardj0n3sI'm grasping here06:11
robcresswellI'll take a look when I start work. Gym time06:11
r1chardj0n3srobcresswell: yep, have a nice gym :-)06:11
r1chardj0n3swoo, I have errors!!06:11
r1chardj0n3skenji-i: I also only have about 15 minutes before I have to run away :-(06:12
r1chardj0n3shmm06:12
r1chardj0n3syou know how I was saying before that it's odd that we don't define a LANGUAGE_CODE in our test settings?06:12
r1chardj0n3sit looks like these failures are the resule of missing language code...06:13
r1chardj0n3s    gettextCatalog.setStrings(horizon.languageCode, django.catalog);06:14
r1chardj0n3sI betcha horizon.languageCode is undefined06:14
*** mgagne has quit IRC06:18
kenji-ir1chardj0n3s: yes, it's same situation in my env. I'm not sure that not defining a LANGAGE_CODE is correct, though.06:19
kenji-ishare my confirmed.06:19
r1chardj0n3skenji-i: indeed, defining LANGUAGE_CODE does not help (though I'm not 100% sure why)06:19
kenji-iI confirmed about https://review.openstack.org/#/c/399370/1.In my env, errors same as jenkins would occur when running test.06:19
kenji-iAnd then, I changed the version of angular-gettext to 2.1.0.2 in requirements.txt even though version is too old. And did test again. This result was fine.06:20
r1chardj0n3syep06:20
r1chardj0n3sit's definitely breaking on that missing horizon.languageCode though06:20
*** yamamot__ has joined #openstack-horizon06:20
r1chardj0n3sit's the undefined value that's causing the error06:20
r1chardj0n3sI'm just trying to trace through where the jasmine test html gets the horizon object created06:20
*** chetna1 has quit IRC06:21
*** mgagne has joined #openstack-horizon06:21
*** mgagne is now known as Guest5228506:21
kenji-iOh, great06:22
kenji-iand sorry that i also don't have a time to investigate today.06:23
r1chardj0n3sthat's ok - I've been pretty rushed around myself :-)06:23
r1chardj0n3sOK, I fixed it06:27
r1chardj0n3sargh, it's fixed in /jasmine, but now I'm seeing a different error in command-line invocations06:30
r1chardj0n3sno, same error06:31
r1chardj0n3s... because the command-line tests don't run in the django context06:32
r1chardj0n3swhat a mess06:32
openstackgerritRichard Jones proposed openstack/horizon: Revert "In Images Overview, dates should be properly formatted"  https://review.openstack.org/39937006:34
r1chardj0n3skenji-i / robcresswell: I've added languageCode to the base horizon JS object (https://review.openstack.org/#/c/399370/2/horizon/static/horizon/js/horizon.js) because I'm not sure of any other way to set it for the pure JS test suite06:35
r1chardj0n3sbut I have to go now06:35
openstackgerritOpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Zanata  https://review.openstack.org/39938806:35
*** jamielennox is now known as jamielennox|away06:36
*** chetna1 has joined #openstack-horizon06:36
*** chetna1 has quit IRC06:37
*** kzaitsev_mb has joined #openstack-horizon06:44
*** kzaitsev_mb has quit IRC06:50
*** kzaitsev_mb has joined #openstack-horizon06:51
*** kzaitsev_mb has quit IRC07:01
*** tesseract has joined #openstack-horizon07:18
*** tesseract is now known as Guest9031307:18
*** Miouge has joined #openstack-horizon07:20
openstackgerritRob Cresswell proposed openstack/horizon: Revert "In Images Overview, dates should be properly formatted"  https://review.openstack.org/39937007:33
*** chetna1 has joined #openstack-horizon07:37
*** chetna1 has quit IRC07:38
*** pcaruana has joined #openstack-horizon07:45
*** belmoreira has joined #openstack-horizon07:51
openstackgerritsiva proposed openstack/horizon: horizon branch changes  https://review.openstack.org/39941907:52
*** adriant has quit IRC07:55
openstackgerritMerged openstack/horizon: Imported Translations from Zanata  https://review.openstack.org/39938807:56
*** jamielennox|away is now known as jamielennox08:03
*** openstackgerrit has quit IRC08:03
*** vishwana_ has joined #openstack-horizon08:03
*** openstackgerrit has joined #openstack-horizon08:04
*** vishwanathj has quit IRC08:05
*** hogepodge has quit IRC08:15
*** betherly has joined #openstack-horizon08:40
*** lifeless has quit IRC08:45
*** lifeless has joined #openstack-horizon08:47
*** Zer0Byte_ has joined #openstack-horizon08:47
*** Zer0Byte_ has quit IRC08:49
*** jpich has joined #openstack-horizon08:55
*** chetna1 has joined #openstack-horizon08:55
*** chetna1 has quit IRC08:56
*** zhurong has quit IRC09:01
*** zhurong has joined #openstack-horizon09:02
*** belmoreira has quit IRC09:03
openstackgerritAlbert Tu proposed openstack/horizon: Add i18n support to Quota.humanizeNumbers  https://review.openstack.org/19999709:32
*** chetna1 has joined #openstack-horizon09:37
*** chetna1 has quit IRC09:38
openstackgerritsiva proposed openstack/horizon: horizon branch changes  https://review.openstack.org/39941909:52
*** wolverineav has joined #openstack-horizon09:53
*** masco has quit IRC09:54
*** jtomasek has joined #openstack-horizon09:57
*** wolverineav has quit IRC09:57
*** zhurong has quit IRC09:59
*** amotoki has joined #openstack-horizon10:00
*** belmoreira has joined #openstack-horizon10:17
*** ppalacios has joined #openstack-horizon10:40
*** udesale has quit IRC10:50
*** jperry has joined #openstack-horizon11:04
*** ppalacios1 has joined #openstack-horizon11:05
*** ppalacios1 has quit IRC11:06
*** ppalacios has quit IRC11:07
*** wolverineav has joined #openstack-horizon11:10
*** jtomasek has quit IRC11:13
*** ratailor has quit IRC11:23
*** ratailor has joined #openstack-horizon11:23
*** ratailor has quit IRC11:23
*** ducttape_ has joined #openstack-horizon11:35
openstackgerritTimur Sufiev proposed openstack/horizon: Wrap api calls with tracing decorators  https://review.openstack.org/33967511:39
*** ducttape_ has quit IRC11:39
*** amotoki_ has joined #openstack-horizon11:39
*** jtomasek has joined #openstack-horizon11:41
*** amotoki has quit IRC11:42
*** amotoki_ has quit IRC12:02
*** wolverineav has quit IRC12:04
*** wolverineav has joined #openstack-horizon12:07
*** amotoki has joined #openstack-horizon12:11
*** amotoki has quit IRC12:15
*** wolverineav has quit IRC12:24
*** wolverineav has joined #openstack-horizon12:25
rdopieradavid-lyle: sorry, what's the status of https://blueprints.launchpad.net/horizon/+spec/password-expires-validation ?12:25
rdopieradavid-lyle: you are the approver, but it's pending approval?12:25
rdopieradavid-lyle: I'm asking because there are patches for it to review, and I'm not sure if we can merge them...12:26
*** hogepodge has joined #openstack-horizon12:31
*** wolverineav has quit IRC12:32
openstackgerritsiva proposed openstack/horizon: Alert message in 'Create Network' Modal does not have col-* class modification  https://review.openstack.org/39957512:34
*** ianychoi has joined #openstack-horizon12:36
*** ducttape_ has joined #openstack-horizon12:36
*** ducttape_ has quit IRC12:40
*** Jeffrey4l has quit IRC12:47
*** wolverineav has joined #openstack-horizon12:47
*** wolverineav has quit IRC12:48
*** wolverineav has joined #openstack-horizon12:48
*** wolverineav has quit IRC12:48
*** wolverineav has joined #openstack-horizon12:48
*** jsheeren has joined #openstack-horizon12:58
jsheerenhi all12:58
jsheereni'm seeing a ssl exception on my horizon.  it's taken from source and running inside a python venv12:58
*** yamamot__ has quit IRC12:59
jsheerenusing branch stable/mitaka12:59
jsheerenexception is "SSLError: SSL exception connecting to <url> ('bad handshake: SysCallError(0, None)',)"12:59
jsheerenthis bug is similar to what i'm seeing: https://bugs.launchpad.net/openstack-ansible/+bug/162479113:00
openstackLaunchpad bug 1624791 in openstack-ansible "Horizon randomly fails to connect to the service APIs" [High,Won't fix]13:00
jsheereni'm running the 'correct' versions: cryptography (1.5.3)13:00
jsheerenand pyOpenSSL (0.15.1)13:00
jsheereninside the venv13:00
jsheerenremoving pyopenssl does not help13:00
jsheerenhas anyone seen/experienced something similar?13:00
robcresswelljsheeren: Its not something familiar to me, I'm afraid13:04
*** dsneddon is now known as dsneddon_afk13:04
*** Jeffrey4l has joined #openstack-horizon13:07
*** tqtran has joined #openstack-horizon13:08
*** ducttape_ has joined #openstack-horizon13:08
*** tqtran has quit IRC13:12
jsheerenheh, i downgraded some of the packages that are in the requirements.txt and now i'm not seeing the messages anymore13:12
*** jperry has quit IRC13:13
jsheerendowngraded urllib from 1.19.1 to 1.18, requests from 2.12.1 to 2.11.1, keystoneauth1 from 2.15 to  2.12.1, djanog-openstack-auth from 3.0.0 to 2.4.1 and cryptography from 1.5.3 to 1.5.213:14
*** dave-mccowan has joined #openstack-horizon13:18
*** jdwald has joined #openstack-horizon13:25
jsheerenproblem is, there are no upper limits, so i think the versions for newton were installed through pip13:30
ducttape_there is a upper constraints for neutron though, right ?13:33
ducttape_if something is needed in the *newton* upper constraints, file a bug please jsheeren?  seems like something easy to fix13:34
jsheerenargh my bad, i missed this one: http://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt?h=stable/mitaka13:37
ducttape_:D13:38
*** wolverineav has quit IRC13:42
*** wolverineav has joined #openstack-horizon13:46
*** wolverineav has quit IRC13:46
*** wolverineav has joined #openstack-horizon13:47
*** ducttape_ has quit IRC13:48
*** dave-mcc_ has joined #openstack-horizon13:53
*** dave-mccowan has quit IRC13:55
*** lblanchard has joined #openstack-horizon13:55
*** yamamoto has joined #openstack-horizon13:57
*** yamamoto has quit IRC14:01
*** ctayal has joined #openstack-horizon14:06
*** ctayal has quit IRC14:07
*** ctayal has joined #openstack-horizon14:07
openstackgerritRob Cresswell proposed openstack/horizon: Fix npm tests  https://review.openstack.org/39960814:09
*** yamamoto has joined #openstack-horizon14:09
*** hurgleburgler has joined #openstack-horizon14:17
*** ChanServ sets mode: +v hurgleburgler14:17
*** zhurong has joined #openstack-horizon14:18
*** jperry has joined #openstack-horizon14:20
*** ducttape_ has joined #openstack-horizon14:24
*** zhurong has quit IRC14:30
openstackgerritRob Cresswell proposed openstack/horizon: Refactor tox & update docs  https://review.openstack.org/39150614:35
*** zhurong has joined #openstack-horizon14:35
*** jsheeren has quit IRC14:35
*** amotoki has joined #openstack-horizon14:37
*** ducttape_ has quit IRC14:40
*** tqtran has joined #openstack-horizon14:42
*** amotoki_ has joined #openstack-horizon14:45
*** amotoki has quit IRC14:48
*** jtriley has joined #openstack-horizon14:53
*** chlong has joined #openstack-horizon14:53
*** amotoki_ has quit IRC14:55
tsufievdoes anybody know what happened to npm-run-test job recently?14:55
*** zhurong has quit IRC14:55
tsufiev7 tests failed (completely unrelated to patch contents), the error is "Cannot read property 'split' of undefined"14:55
tsufievhttp://logs.openstack.org/75/339675/57/check/gate-horizon-nodejs4-npm-run-test/c8f89d1/console.html14:55
tsufievI'm wondering if it's a known issue, completely fine to debug it if it's unique to my patch14:56
robcresswelltsufiev: Just having some lunch, will check shortly; there are definitely a couple of known npm bugs right now die to package issues15:08
robcresswellCaused by some maniac Newton PTL I think...15:08
robcresswelldue*15:08
tsufievrobcresswell, :) we all are just humans15:08
tsufievI think the issue emerged today or yesterday15:08
tsufievrobcresswell, thanks for looking into it!15:09
*** ratailor has joined #openstack-horizon15:11
*** edtubill has joined #openstack-horizon15:11
*** ctayal_ has joined #openstack-horizon15:13
*** ducttape_ has joined #openstack-horizon15:14
*** ctayal has quit IRC15:15
*** weezS has joined #openstack-horizon15:18
openstackgerritEric Peterson proposed openstack/horizon: Switch cinder to usage quotas  https://review.openstack.org/30920415:21
openstackgerritEric Peterson proposed openstack/horizon: Change icons in launch instance ng transfer  https://review.openstack.org/39859715:21
openstackgerritErnest Millan proposed openstack/horizon: Pass network object to _create_subnet  https://review.openstack.org/39864715:22
lcastello/15:24
*** jtriley has quit IRC15:25
*** yamamoto_ has joined #openstack-horizon15:26
*** yamamoto has quit IRC15:29
openstackgerritSteve Martinelli proposed openstack/django-openstack-auth-kerberos: delete all files in the repo  https://review.openstack.org/39963715:29
ducttape_david-lyle / robcresswell / hurgleburgler - do I need to also change requirements to coordinate this change https://review.openstack.org/#/c/399153/ ?15:33
*** josecastroleon has joined #openstack-horizon15:35
*** kzaitsev_mb has joined #openstack-horizon15:43
*** hoobaman has quit IRC15:44
*** edtubill has quit IRC15:48
*** pcaruana has quit IRC15:50
*** HenryG has quit IRC15:50
*** HenryG has joined #openstack-horizon15:51
*** tjones has joined #openstack-horizon15:52
robcresswellducttape_: Nope, I've already got that going15:52
ducttape_k.  if you have that in related review or need me to reference that lemme know.  I don't usually mess with requirements stuff15:53
*** revon has joined #openstack-horizon15:54
*** ctayal_ has quit IRC15:54
*** ctayal has joined #openstack-horizon15:55
*** tqtran has quit IRC15:55
*** bpokorny has joined #openstack-horizon15:57
ducttape_stevemar - does the jenkins jobs need to be adjusted before https://review.openstack.org/#/c/399637/ gets jenkins verified ?15:57
*** belmoreira has quit IRC15:57
*** jtriley has joined #openstack-horizon15:58
*** ratailor has quit IRC16:04
*** weezS has quit IRC16:06
*** weezS has joined #openstack-horizon16:06
*** Guest90313 has quit IRC16:09
lcastelltsufiev: I'm seeing that nasty issue too16:16
*** alexvictorchan_ has quit IRC16:16
robcresswelltsufiev: https://review.openstack.org/#/c/399608/16:17
robcresswellApprove please :)16:17
robcresswellit will fix all your problems16:17
*** amotoki has joined #openstack-horizon16:18
*** Zer0Byte_ has joined #openstack-horizon16:19
*** bpokorny has quit IRC16:20
*** bpokorny has joined #openstack-horizon16:20
openstackgerritRick Bartra proposed openstack/horizon: Horizon checks non-existent policy action  https://review.openstack.org/39967316:23
*** bpokorny has quit IRC16:24
*** Zer0Byte_ has quit IRC16:28
stevemarducttape_: i forgot the proper process, but i think https://review.openstack.org/#/c/399649/1 has to merge first16:30
robcresswellducttape_: I think we're actually have to remove that import line so the gate can move16:30
stevemarducttape_: someone from infra will correct me if i'm wrong16:30
robcresswellducttape_: Then re-add it. At the moment we're blocked because some of the tests use U-C and some use edge16:30
robcresswellducttape_: Its completely fucking insane, but oh well.16:30
ducttape_thanks stevemar - makes sense to me.   less repos less problems16:31
stevemarfo sho16:31
ducttape_robcresswell - which line ?16:31
ducttape_ah reading16:31
robcresswellthe roboto-font import. I think we'll have to actually patch the import out so the gate can move.16:31
ducttape_that would make me sad16:32
robcresswellYes16:32
robcresswellI'm not actually sure how else to get around it.16:32
ducttape_evidently the cloud could care less about my feelings ;)16:33
*** uxdanielle has joined #openstack-horizon16:33
robcresswellI don't know if SCSS can do conditional imports or anything... I'll have a look16:34
ducttape_I can remove those lines too, not sure what type of garbage that will end up with16:34
robcresswellhurgleburgler: You around? Your insight might be useful here16:35
tsufievlcastell, robcresswell: approved16:37
openstackgerritSteve Martinelli proposed openstack/django-openstack-auth-kerberos: delete all files in the repo  https://review.openstack.org/39963716:38
robcresswellthanks tsufiev16:39
robcresswellducttape_: Yeah so requirements seems to be stuck because of Horizon16:41
robcresswelland Horizon is stuck because of requirements16:42
robcresswell:/16:42
robcresswellducttape_: A neater alternative for the time being would just be to remove Material from  https://github.com/openstack/horizon/blob/master/openstack_dashboard/settings.py#L29416:45
robcresswellThat would stop it being compressed so the gate can pass...16:45
ducttape_that works for me robcresswell.   you want to patch or shall I ?16:45
robcresswellducttape_: Go for it :)16:46
ducttape_roger wilco16:46
*** makowals has quit IRC16:49
robcresswellducttape_: I'll hold it for a day or so, get requirements done, then revert16:49
*** makowals has joined #openstack-horizon16:50
openstackgerritEric Peterson proposed openstack/horizon: Comment out material theme for gate to proceed  https://review.openstack.org/39968916:51
ducttape_is that what you wanted robcresswell ^   ???16:51
*** tqtran has joined #openstack-horizon16:52
*** makowals has quit IRC16:53
david-lylerdopiera: I updated https://blueprints.launchpad.net/horizon/+spec/password-expires-validation it's approved16:53
*** makowals has joined #openstack-horizon16:54
openstackgerritMerged openstack/horizon: Fix npm tests  https://review.openstack.org/39960816:56
*** tqtran has quit IRC16:56
*** makowals has quit IRC16:58
*** alexvictorchan has joined #openstack-horizon16:58
robcresswellducttape_: Yep, so that should allow all the other changes to go through, and then we can revert it17:00
robcresswellBecause now material shouldnt be compressed17:01
*** Miouge has quit IRC17:01
ducttape_k.   tqtran was just on, not sure if david-lyle can help coordinate un-wedging this stuff17:01
*** Miouge has joined #openstack-horizon17:02
*** Miouge has quit IRC17:02
*** ctayal has quit IRC17:05
*** rickflare has quit IRC17:07
*** Miouge has joined #openstack-horizon17:15
openstackgerritDavid Lyle proposed openstack/horizon: Remove broken telemetry policy check  https://review.openstack.org/38824817:16
openstackgerritRob Cresswell proposed openstack/horizon: Comment out material theme for gate to proceed  https://review.openstack.org/39968917:20
openstackgerritRob Cresswell proposed openstack/horizon: Revert "In Images Overview, dates should be properly formatted"  https://review.openstack.org/39937017:21
*** Zer0Byte__ has joined #openstack-horizon17:25
openstackgerritRob Cresswell proposed openstack/horizon: Disable router and fip quotas when router is disabled  https://review.openstack.org/18582017:27
*** Guest52285 is now known as mgagne17:33
*** mgagne has quit IRC17:33
*** mgagne has joined #openstack-horizon17:33
*** amotoki has quit IRC17:34
*** wolverineav has quit IRC17:42
*** wolverineav has joined #openstack-horizon17:51
*** jpich has quit IRC17:53
*** tqtran has joined #openstack-horizon17:53
*** wolverineav has quit IRC17:56
*** jperry has quit IRC17:57
*** tqtran has quit IRC17:58
*** Miouge has quit IRC18:00
*** Miouge has joined #openstack-horizon18:10
*** Miouge has quit IRC18:14
*** Miouge has joined #openstack-horizon18:16
*** hurgleburgler has quit IRC18:26
openstackgerritMerged openstack/horizon: Disable router and fip quotas when router is disabled  https://review.openstack.org/18582018:28
*** Zer0Byte__ has quit IRC18:28
openstackgerritVictoria Martinez de la Cruz proposed openstack/manila-ui: Moves OPENSTACK_MANILA_SETTINGS TO local_settings.d/  https://review.openstack.org/39792618:29
*** uxdanielle has quit IRC18:31
openstackgerritRick Bartra proposed openstack/horizon: Horizon checks non-existent policy action  https://review.openstack.org/39967318:33
*** jtriley has quit IRC18:33
david-lyleholy cow, I let the policy engine get butchered :(18:49
*** weezS has quit IRC18:54
*** weezS has joined #openstack-horizon18:57
*** Miouge has quit IRC19:00
*** Miouge has joined #openstack-horizon19:01
sjmc7david-lyle: my ears are burning19:04
openstackgerritMerged openstack/horizon: take time zone into account  https://review.openstack.org/28992019:04
david-lylenah it was the whole domain scoped nonsense19:05
david-lylewhere we used to do a logical AND when multiple rules were specified, we now just evaluate the first19:05
david-lyleoops19:05
david-lylefixing now19:05
david-lyleno wonder people say it's broken, it is19:05
david-lyleimagine that19:06
david-lylethen we have to fix the domain id thing19:06
sjmc7hahaha, that’s the rock i push up the hill19:07
*** Miouge has quit IRC19:08
*** Miouge has joined #openstack-horizon19:09
*** Miouge has quit IRC19:13
robcresswellIf someone can approve https://review.openstack.org/#/c/399689/ we can get gate fixed properly :)19:15
robcresswellExplanation in the comments19:16
*** jtriley has joined #openstack-horizon19:17
david-lylerobcresswell: done19:17
*** betherly has quit IRC19:18
*** Zer0Byte__ has joined #openstack-horizon19:19
robcresswelldavid-lyle: Thanks. So what's going on with policy? Can we have a bug for backport etc :)19:20
david-lyleyeah, I'm still working through it19:21
david-lylewill post bugs19:21
robcresswellThanks19:21
david-lylestarted with: https://bugs.launchpad.net/horizon/+bug/164301319:21
openstackLaunchpad bug 1643013 in OpenStack Dashboard (Horizon) "admin dashboard policy check wrong" [High,New] - Assigned to David Lyle (david-lyle)19:21
david-lylebut then onion happened19:21
*** Miouge has joined #openstack-horizon19:22
robcresswellAck19:24
* david-lyle is rethinking some life decisions19:26
*** Miouge has quit IRC19:27
*** edtubill has joined #openstack-horizon19:29
*** ctayal has joined #openstack-horizon19:29
david-lyleedtubill: I stamped your bp, you're good to go19:29
*** tqtran has joined #openstack-horizon19:29
*** zul has quit IRC19:30
ducttape_robcresswell how many changes do you have before I revert that change in the gate ?   should I prep the revert asap today ?19:30
david-lyleducttape_: revert is just a button click19:30
david-lylegerrit does some things well19:30
ducttape_david-lyle - listen, buttons don't just "happen" david-lyle19:30
ducttape_it takes a lot of skil19:31
edtubilldavid-lyle: thank you!!19:31
robcresswellducttape_: Nah I'll monitor it, I have it all starred, just waiting on gate19:31
david-lylehover your mouse over the button for the next 6 hours or so19:31
ducttape_some buttons aren't even rectangles19:31
openstackgerritYing Zuo proposed openstack/horizon: Provide available physical networks on create network modal  https://review.openstack.org/38397719:31
david-lyleducttape_: too many corners can be scary19:31
david-lylehalf as many, half as scary19:32
ducttape_you might hurt yourself with 90 degrees19:32
*** kzaitsev_mb has quit IRC19:37
*** dsneddon_afk is now known as dsneddon19:37
*** Miouge has joined #openstack-horizon19:38
*** Miouge has quit IRC19:42
*** Miouge has joined #openstack-horizon19:47
openstackgerritMerged openstack/horizon: Comment out material theme for gate to proceed  https://review.openstack.org/39968919:49
*** zul has joined #openstack-horizon19:49
*** jtriley has quit IRC19:51
*** wolverineav has joined #openstack-horizon19:52
openstackgerritRob Cresswell proposed openstack/horizon: Fix issues with new roboto-font path changes  https://review.openstack.org/39915319:56
*** wolverineav has quit IRC19:57
*** edtubill has quit IRC20:01
*** wolverineav has joined #openstack-horizon20:03
openstackgerritMerged openstack/horizon: Update Angular Users Table use registry  https://review.openstack.org/33632920:07
*** jtriley has joined #openstack-horizon20:07
*** ctayal has quit IRC20:15
*** ctayal has joined #openstack-horizon20:16
*** Miouge has quit IRC20:19
*** piet has joined #openstack-horizon20:19
r1chardj0n3sGood morning folks. Could someone please get me up to speed on the state of Horizon and the gate?20:21
r1chardj0n3sWhen I left last night we had multiple JS failures caused by angular-gettext and also a bad patch that needed reverting. I see a patch for the angular-gettext compat has gone thru but the reversion patch (https://review.openstack.org/#/c/399370/) has not20:22
r1chardj0n3sand we seem to have a "temporary" patch to disable material theme in as well now20:22
r1chardj0n3sanyone?20:26
r1chardj0n3sdavid-lyle? TravT? robcresswell?20:27
r1chardj0n3stsufiev? tqtran?20:27
r1chardj0n3s(don't expect timur to be around, really)20:27
r1chardj0n3sOK, reversion patch https://review.openstack.org/#/c/399370/ still needs to be merged ASAP to fix broken test suite.20:30
r1chardj0n3sducttape_: do you know what needs to be done to revert https://review.openstack.org/#/c/399689/ ?20:30
ediardowhat? Horizon is broken? :(20:32
*** Miouge has joined #openstack-horizon20:33
ducttape_he r1chardj0n3s20:34
ducttape_hey!20:34
r1chardj0n3sediardo: that's what I'm trying to find out. I know a test is broken and there's a patch for that, but material theme is now disabled (and I'm not sure why, but "other changes" need to be applied before it can be reinstated)20:34
r1chardj0n3shey ducttape_!20:35
r1chardj0n3swha the heck is going on around here? :-)20:35
david-lyler1chardj0n3s: it's saturday, don't worry20:35
ducttape_all good questions20:35
david-lyleturns out updating libraries is hard20:35
ducttape_so I know that the roboto font stuff has release upstream of us, and broke our material theme20:35
ducttape_so I think right now we are commenting out material, then rob will pin roboto correctly, then I have a change to make material work ok20:36
ducttape_then we can also enable material after that20:36
ducttape_so far as I understand it20:36
r1chardj0n3sok, but I assume that means Mitaka will also be broken at the moment?20:36
ducttape_it should have upper constraints on this, yes ?20:37
r1chardj0n3sno, Mitaka doesn't20:37
r1chardj0n3sNewton does20:37
ducttape_thats unfortunate20:37
r1chardj0n3syeah20:37
david-lylewhy would we be pulling in a roboto font from upstream is my question20:37
david-lylewhere a random release would effect us20:37
r1chardj0n3supstream is xstatic, yes?20:37
r1chardj0n3sor no?20:37
ducttape_why does xstatic exist david-lyle?   all these questions :P20:38
david-lylebut we control xstatic20:38
david-lyleso someone release without testing20:38
david-lyle*released?20:38
r1chardj0n3syes :-(20:38
david-lyleunless that is one of the 2-3 xstatic we don't own20:38
ducttape_we like to make sure everyone is armed around here20:38
r1chardj0n3sdavid-lyle: no, we own it. we need to tighten up xstatic release process and review.20:39
david-lyleyup https://pypi.python.org/pypi/XStatic-roboto-fontface/0.5.0.020:39
david-lyleI just approved the comment out to grease the wheels, I didn't do the root cause20:39
r1chardj0n3sso, in order for horizon to get stable again, at least three patches need to land, I think?20:40
r1chardj0n3sWe need https://review.openstack.org/#/c/399370/20:40
r1chardj0n3sand robcresswell's patch to do something with pinning roboto correctly?20:40
r1chardj0n3sand then ducttape_ to patch horizon to fix it with roboto too?20:41
david-lylerevert is +a'd20:41
robcresswellSo requirements and u-c has a +220:41
robcresswellThe other npm issues are mostly fixed too btw20:41
robcresswellI'm efficient like that20:42
r1chardj0n3srobcresswell: the requirements patch is https://review.openstack.org/#/c/399190/ ?20:42
r1chardj0n3sthanks david-lyle20:42
robcresswellOui20:42
robcresswellThen we need https://review.openstack.org/#/c/399153/20:42
robcresswellAnd revert the commenting out20:42
ducttape_it's all quite simple really20:42
robcresswellAnd we're all done20:42
r1chardj0n3slol20:42
ducttape_robcresswell - I am going to make it so any comment you provide in irc requires a gerrit review20:43
ducttape_and so will my replies20:43
r1chardj0n3sso, https://review.openstack.org/#/c/399190/ first - we just need to hassle someone in requirements?20:43
david-lyledid we ever figure out how to do the import in SCSS in a backward compatible way? or are we just upgrading minimum20:43
david-lyle?20:43
robcresswellWe also need to revert those language code things that broke everything20:43
robcresswellI split your fix for that up because it wasn't a clean revert -.-20:44
david-lylelanguage code things?20:44
robcresswellhttps://review.openstack.org/#/c/399370/20:44
robcresswellyou just approved it20:44
r1chardj0n3sthat's not language code20:44
david-lylelanguage code things?20:44
r1chardj0n3sthat's a timezone snafu20:45
robcresswell'horizon.languageCode'20:45
robcresswellI'm calling that a language code thing20:45
r1chardj0n3shttps://review.openstack.org/#/c/399370/ is timezone related20:45
r1chardj0n3sI *had* included the languageCode fix in it also, but you removed that20:45
robcresswellyes, you cant include a fix in a revert20:45
robcresswellthat messes up our history20:46
r1chardj0n3ssure, but the gate was broken from both things. I'm very happy that you got the languageCode fix in without also fixing the other thing.20:46
*** edtubill has joined #openstack-horizon20:46
robcresswellhttps://review.openstack.org/#/c/399608/ that fixed the gate20:46
robcresswellso that we could revert that timezone thing20:46
robcresswellit was a series of patches all blocking the gate :/20:46
r1chardj0n3srobcresswell: the gate is also broken on the timezone thing if the node is not UTC20:47
r1chardj0n3sso you got lucky getting https://review.openstack.org/#/c/399608/ in20:47
robcresswellHuh, I thought that fixed it20:47
ducttape_can I nominate robcresswell for http://startuplegup.com/wp-content/uploads/2015/09/4.jpg ?20:47
r1chardj0n3srobcresswell: https://review.openstack.org/#/c/399608/ fixed *one* of the issues, yes :-)20:48
robcresswellOH and I fixed jsencrypt, 2.3.1.1 happened20:48
r1chardj0n3srobcresswell: cool, thanks20:48
robcresswellbasically, we're almost back to where we start 24 hours ago20:48
r1chardj0n3s\o/20:49
robcresswellwell done us :)20:49
*** chlong has quit IRC20:53
r1chardj0n3srobcresswell: could you please track the xstatic version caps we're going to need to backport to Mitaka to unbreak it on Monday?20:56
r1chardj0n3salso, I would like to know why upper-constraints isn't protecting us from these new library releases in master :-(20:57
ducttape_I think master is meant to find these issues early, right ?20:59
r1chardj0n3smaster should still have upper-constraints applied21:01
openstackgerritMerged openstack/horizon: Revert "In Images Overview, dates should be properly formatted"  https://review.openstack.org/39937021:12
openstackgerritRichard Jones proposed openstack/horizon: Revert "Comment out material theme for gate to proceed"  https://review.openstack.org/39977121:12
r1chardj0n3srobcresswell: ^^ is me queueing up the reversion of disabling material21:13
r1chardj0n3sso we need, in order: https://review.openstack.org/#/c/399190/ (will be +a'ed once the jenkins results are in), then https://review.openstack.org/#/c/399153/, and then https://review.openstack.org/#/c/399771/21:14
r1chardj0n3sI think while material is disabled we could get https://review.openstack.org/#/c/399153/ in, couldn't we?21:14
*** Miouge has quit IRC21:18
*** dave-mcc_ has quit IRC21:18
robcresswellr1chardj0n3s: er yes we could :)21:19
david-lylewill the minimum requirements for that library support such a change?21:21
david-lyleor is that the requirements change going in?21:22
r1chardj0n3sthat's https://review.openstack.org/#/c/399190/ yes21:22
david-lyleok21:22
david-lyleWFM21:22
david-lyleas long as we don't tag without both21:23
*** Miouge has joined #openstack-horizon21:23
r1chardj0n3syep21:23
r1chardj0n3sno tagging until I've seen a clean test run and witnessed unbroken material theme21:24
david-lyleso 2017?21:24
* david-lyle ducks21:24
r1chardj0n3sgeez, you're optimistic21:24
r1chardj0n3sthat's not like you21:24
r1chardj0n3s:-P21:24
david-lyleI've been working on it21:24
r1chardj0n3sI've put my vote on https://review.openstack.org/#/c/399153 if someone else wants to put their name to it ;-)21:27
*** edtubill has quit IRC21:31
*** Miouge has quit IRC21:32
*** Jeffrey4l has quit IRC21:33
*** aimeeu has quit IRC21:38
*** aimeeu has joined #openstack-horizon21:38
*** ctayal has quit IRC21:53
*** dave-mcc_ has joined #openstack-horizon21:56
*** jtriley_ has joined #openstack-horizon21:56
*** jtriley has quit IRC21:59
*** dave-mcc_ has quit IRC21:59
*** jtriley_ has quit IRC22:01
*** lblanchard has quit IRC22:01
openstackgerritEric Peterson proposed openstack/horizon: Change icons in launch instance ng transfer  https://review.openstack.org/39859722:03
*** lblanchard has joined #openstack-horizon22:04
*** lblanchard has quit IRC22:08
openstackgerritEric Peterson proposed openstack/horizon: Revert "Comment out material theme for gate to proceed"  https://review.openstack.org/39978222:16
openstackgerritMerged openstack/horizon: Fix issues with new roboto-font path changes  https://review.openstack.org/39915322:24
openstackgerritDavid Lyle proposed openstack/horizon: Rework hardcoded policy in admin dash  https://review.openstack.org/39978622:27
*** jdwald has quit IRC22:27
ducttape_sorry / thanks r1chardj0n3s.   didn't see the other patch22:28
r1chardj0n3sno worries ducttape_! thanks anyway :-)22:28
ducttape_clicking on a revert button is pretty much right at my skill leve22:28
ducttape_level22:28
r1chardj0n3shah! I was going to say the same thing ;-)22:28
r1chardj0n3sabout *me*22:28
r1chardj0n3snot you22:28
r1chardj0n3s*cough*22:28
ducttape_;)22:28
r1chardj0n3sjust waiting on the rerun of https://review.openstack.org/#/c/399190 ...22:29
openstackgerritRichard Jones proposed openstack/horizon: Revert "Comment out material theme for gate to proceed"  https://review.openstack.org/39977122:36
r1chardj0n3smy coffee machine has just died22:36
r1chardj0n3s:-(22:36
robcresswellr1chardj0n3s: All I heard was "I just gave myself permission to buy a really expensive new coffee machine"22:37
r1chardj0n3srobcresswell: I don't need a really expensive one, but I don't relish having to buy a new one now22:38
r1chardj0n3sall the research I will have to do22:38
*** clu_ has joined #openstack-horizon22:38
*** ChanServ sets mode: +v clu_22:38
robcresswellThen you end up with decision paralysis about what to go for :/22:39
r1chardj0n3srobcresswell: fortunately we have choice.com.au who do a lot of the work for us22:40
r1chardj0n3srobcresswell: https://www.choice.com.au/home-and-living/kitchen/coffee-machines/review-and-compare/home-espresso-coffee-machines22:41
robcresswellTIL about .com.au22:42
openstackgerritDavid Lyle proposed openstack/horizon: Rework hardcoded policy in admin dash  https://review.openstack.org/39978622:42
*** dsneddon is now known as dsneddon_afk22:43
*** ducttape_ has quit IRC22:43
robcresswellr1chardj0n3s: Cool site!22:44
openstackgerritDavid Lyle proposed openstack/django_openstack_auth: Fix policy check short circuit  https://review.openstack.org/39979222:47
david-lylethere, policy can be sane again22:48
david-lyleas sane as it ever was I guess22:48
david-lylenobody touch policy again, you HEAR ME!?!?!?!?!22:49
*** weezS has quit IRC22:49
david-lyle:(22:49
david-lylejust remember domain stuff22:49
david-lylethose will at least get us to a place to work on it22:50
r1chardj0n3sdavid-lyle: I'm happy to never touch policy stuff ;-)22:55
r1chardj0n3shmm, looks like we missed our requirements team window :-(23:11
*** wolverin_ has joined #openstack-horizon23:11
*** wolverineav has quit IRC23:11
*** zackf has quit IRC23:17
*** erlon-airlong has quit IRC23:22
*** Jeffrey4l has joined #openstack-horizon23:31
*** wolverin_ has quit IRC23:33
*** wolverineav has joined #openstack-horizon23:35
*** wolverineav has quit IRC23:37
*** wolverineav has joined #openstack-horizon23:37
*** alexvictorchan has quit IRC23:43
*** ducttape_ has joined #openstack-horizon23:45
*** wolverineav has quit IRC23:47
*** ducttape_ has quit IRC23:53
*** wolverineav has joined #openstack-horizon23:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!