Tuesday, 2016-08-23

*** ducttape_ has joined #openstack-horizon00:00
*** david-lyle has joined #openstack-horizon00:00
*** ChanServ sets mode: +o david-lyle00:00
*** david-lyle_ has joined #openstack-horizon00:03
*** alexvictorchan has quit IRC00:04
*** david-lyle has quit IRC00:05
*** david-lyle_ has quit IRC00:09
*** edtubill has joined #openstack-horizon00:11
openstackgerritCindy Lu proposed openstack/horizon: Update NG toast service to use HORIZON_CONFIG's auto_fade_alerts  https://review.openstack.org/34230800:11
*** liuyulong has quit IRC00:14
*** bigdogstl has joined #openstack-horizon00:15
*** sdake has joined #openstack-horizon00:16
*** ducttape_ has quit IRC00:18
*** aortega has joined #openstack-horizon00:19
*** bigdogstl has quit IRC00:21
*** bigdogstl has joined #openstack-horizon00:21
*** Jeffrey4l_ has joined #openstack-horizon00:23
jlopezguIs there any problem with the gates?00:26
*** ducttape_ has joined #openstack-horizon00:29
r1chardj0n3srobcresswell: had a look at https://review.openstack.org/#/c/358473 with tonyb and he has a working theory about why the release didn't happen00:30
*** wolverin_ has quit IRC00:33
*** wolverineav has joined #openstack-horizon00:35
*** wolverin_ has joined #openstack-horizon00:36
*** wolverineav has quit IRC00:36
*** bigdogstl has quit IRC00:37
*** bigdogstl has joined #openstack-horizon00:38
*** aortega has quit IRC00:41
*** bigdogstl has quit IRC00:41
*** aortega has joined #openstack-horizon00:42
*** bigdogstl has joined #openstack-horizon00:43
*** wolverin_ has quit IRC00:44
*** wolverineav has joined #openstack-horizon00:45
*** bigdogst_ has joined #openstack-horizon00:47
*** bigdogstl has quit IRC00:48
*** walharth has quit IRC00:49
*** bigdogst_ has quit IRC00:53
*** piet has quit IRC00:53
*** tqtran has quit IRC00:56
*** bigdogstl has joined #openstack-horizon01:01
*** mine0901 has quit IRC01:03
*** bigdogstl has quit IRC01:06
*** sdake_ has joined #openstack-horizon01:06
*** walharth has joined #openstack-horizon01:08
*** sdake has quit IRC01:10
*** jamielennox is now known as jamielennox|away01:11
*** zhurong has joined #openstack-horizon01:13
*** jamielennox|away is now known as jamielennox01:16
*** sdake_ has quit IRC01:19
*** wolverin_ has joined #openstack-horizon01:19
*** wolveri__ has joined #openstack-horizon01:21
*** wolverin_ has quit IRC01:21
*** wolverin_ has joined #openstack-horizon01:22
*** sdake has joined #openstack-horizon01:22
*** wolverineav has quit IRC01:22
*** wolveri__ has quit IRC01:22
*** wolverineav has joined #openstack-horizon01:23
*** clu_ has quit IRC01:25
*** wolverineav has quit IRC01:25
*** wolverineav has joined #openstack-horizon01:25
*** zhurong has quit IRC01:25
*** zhurong has joined #openstack-horizon01:26
*** wolverin_ has quit IRC01:26
*** ducttape_ has quit IRC01:28
*** ducttape_ has joined #openstack-horizon01:28
*** wolverineav has quit IRC01:35
*** wolverineav has joined #openstack-horizon01:46
*** zhihui has joined #openstack-horizon01:46
*** wolverineav has quit IRC01:50
*** wolverineav has joined #openstack-horizon01:53
*** wolverineav has quit IRC01:59
*** wolverineav has joined #openstack-horizon02:00
*** saksham_ has quit IRC02:01
*** btully has joined #openstack-horizon02:01
*** btully has quit IRC02:06
*** mtanin___ has quit IRC02:07
*** liuyulong_ is now known as liuyulong02:09
*** wolverineav has quit IRC02:10
*** zhurong has quit IRC02:13
*** zhurong has joined #openstack-horizon02:15
*** zackf has quit IRC02:16
*** walharth has quit IRC02:26
openstackgerritAndrew Bogott proposed openstack/horizon: Remove all_tenants flag in quota check  https://review.openstack.org/35879002:27
*** weezS has joined #openstack-horizon02:29
openstackgerritJim Lin proposed openstack/horizon: Set default firefox profile lang to fit current selenium testing  https://review.openstack.org/33283002:41
openstackgerritLIU Yulong proposed openstack/horizon: Disable some network panels if settings are False  https://review.openstack.org/14427302:42
*** wolverineav has joined #openstack-horizon02:46
*** roxanagh_ has joined #openstack-horizon02:47
*** wolverineav has quit IRC02:49
*** wolverineav has joined #openstack-horizon02:49
*** jamielennox is now known as jamielennox|away02:49
*** roxanagh_ has quit IRC02:52
*** tqtran has joined #openstack-horizon02:54
*** tqtran has quit IRC03:00
*** jamielennox|away is now known as jamielennox03:06
tonybrobcresswell, r1chardj0n3s: openstack/xstatic-angular-smart-table is tagged, it's working it's way to publish now.03:14
tonybr1chardj0n3s: you can watch on zuul if you care to03:15
r1chardj0n3s\o/03:15
tonybr1chardj0n3s: https://pypi.python.org/pypi/XStatic-smart-table not quite right but it's there03:24
r1chardj0n3sthe description formatting is a little off - anything else you noticed?03:26
tonybr1chardj0n3s: No just that03:26
tonybr1chardj0n3s: also the mail just hit the list so ... great success!03:27
r1chardj0n3sokie, it looks good to me otherwise too03:27
r1chardj0n3s\o/03:27
*** aortega has quit IRC03:28
*** aortega has joined #openstack-horizon03:31
*** bigdogstl has joined #openstack-horizon03:31
openstackgerritLIU Yulong proposed openstack/horizon: Disable some network panels if settings are False  https://review.openstack.org/14427303:34
*** aortega has quit IRC03:35
*** ducttape_ has quit IRC03:39
*** bigdogstl has quit IRC03:41
*** zul has quit IRC03:41
*** bigdogstl has joined #openstack-horizon03:44
*** zul has joined #openstack-horizon03:46
*** roxanagh_ has joined #openstack-horizon03:48
*** btully has joined #openstack-horizon03:50
*** roxanagh_ has quit IRC03:52
*** btully has quit IRC03:54
*** btully has joined #openstack-horizon04:24
*** ducttape_ has joined #openstack-horizon04:40
*** jtomasek has quit IRC04:42
*** ducttape_ has quit IRC04:44
*** zackf has joined #openstack-horizon04:47
*** jamielennox is now known as jamielennox|away04:49
*** edtubill has quit IRC04:50
*** kzaitsev_mb has joined #openstack-horizon04:51
*** zackf has quit IRC04:51
*** bigdogstl has quit IRC04:53
*** bigdogstl has joined #openstack-horizon04:53
*** bigdogstl has quit IRC04:56
*** bigdogstl has joined #openstack-horizon04:56
*** tqtran has joined #openstack-horizon04:57
*** weezS has quit IRC04:57
*** bigdogstl has quit IRC05:01
*** tqtran has quit IRC05:01
*** jprovazn has joined #openstack-horizon05:02
*** jprovazn has quit IRC05:02
*** roxanagh_ has joined #openstack-horizon05:02
*** jprovazn has joined #openstack-horizon05:03
*** roxanagh_ has quit IRC05:03
*** masco has joined #openstack-horizon05:06
*** ducttape_ has joined #openstack-horizon05:10
*** kzaitsev_mb has quit IRC05:12
*** bigdogstl has joined #openstack-horizon05:13
*** ducttape_ has quit IRC05:15
*** vishwanathj has quit IRC05:17
*** bigdogstl has quit IRC05:17
*** hurgleburgler has quit IRC05:18
*** nandal has joined #openstack-horizon05:21
*** sdake_ has joined #openstack-horizon05:21
nandalHi, does someone know whom should we select as approver for new Blueprint?05:22
*** jamielennox|away is now known as jamielennox05:23
*** ratailor has joined #openstack-horizon05:24
*** sdake has quit IRC05:24
*** ratailor has quit IRC05:25
*** ratailor has joined #openstack-horizon05:25
*** zackf has joined #openstack-horizon05:40
openstackgerritRichard Jones proposed openstack/xstatic-angular-smart-table: Correct the entry point file name  https://review.openstack.org/35896305:40
r1chardj0n3srobcresswell: we need to merge that ^^ and get a new release of smart table out please :-)05:41
*** sdake_ has quit IRC05:41
openstackgerritJim Lin proposed openstack/horizon: Set default firefox profile lang to fit current selenium testing  https://review.openstack.org/33283005:43
*** zackf has quit IRC05:45
*** vishwanathj has joined #openstack-horizon05:55
*** roxanagh_ has joined #openstack-horizon06:04
*** roxanagh_ has quit IRC06:08
*** jamielennox is now known as jamielennox|away06:11
*** ducttape_ has joined #openstack-horizon06:11
*** pcaruana has joined #openstack-horizon06:14
*** ducttape_ has quit IRC06:17
openstackgerritMerged openstack/xstatic-angular-smart-table: Correct the entry point file name  https://review.openstack.org/35896306:20
*** alexvictorchan has joined #openstack-horizon06:23
*** vishwanathj is now known as vishwanathj_zzz06:24
*** pt_15 has joined #openstack-horizon06:25
robcresswellnandal: Which blueprint? I can approve06:27
robcresswellThanks for your help on xstatic (again) r1chardj0n3s and tonyb06:37
robcresswellI hadn't realise that there was another manual release step.06:37
tonybrobcresswell: No problem.06:37
r1chardj0n3snormally you don't notice it, it just got forgotten for some reason06:37
tonybrobcresswell: the releases team is working on gettign rid of it.06:37
*** alexvictorchan has quit IRC06:38
robcresswelltonyb: Yep, one less thing to confuse me :p06:48
openstackgerritRichard Jones proposed openstack/horizon: Migrate Create Container to schema form  https://review.openstack.org/35898406:49
r1chardj0n3srobcresswell: it's actually one of tonyb's KPIs is "confuse Rob as much as possible" :-)06:49
*** lexplua has joined #openstack-horizon06:49
r1chardj0n3srobcresswell: that patch may be of interest to you ... +78, -166 :-)06:50
robcresswell\o/06:50
r1chardj0n3sjust need to solve that form-level help thing06:50
r1chardj0n3salso, I need to remove some of the derp06:50
robcresswellI honestly don't expect it to be much of a cleanup for single page forms. In that respect the main advantage is consistent fields, error states and validation messages06:51
robcresswellIt just scales 100x better than the previous workflows did.06:51
openstackgerritOpenStack Proposal Bot proposed openstack/manila-ui: Imported Translations from Zanata  https://review.openstack.org/35898506:51
openstackgerritRichard Jones proposed openstack/horizon: Migrate Create Container to schema form  https://review.openstack.org/35898406:51
r1chardj0n3syep, though it does remove all the extraneous controllers and modal HTMLs06:51
r1chardj0n3s(now +75, -166)06:52
robcresswellI'll look at help stuff today. Thanks for that r1chardj0n3s06:52
r1chardj0n3sthank you for getting schema form in, it's going to really help clean things up06:53
*** zackf has joined #openstack-horizon06:54
r1chardj0n3sI'd like to look at adding a "name already exists" validator for the container name in that form, similar to the one I just did for object names.06:55
r1chardj0n3sso that'll blow the line count back out. you're welcome.06:56
openstackgerritBéla Vancsics proposed openstack/horizon: Use more specific asserts in tests  https://review.openstack.org/35898706:56
robcresswellbut it'll be better, so thats good :D06:56
*** zackf has quit IRC06:58
*** tqtran has joined #openstack-horizon06:59
*** mpavlase has joined #openstack-horizon06:59
nandalHi Rob, thanks for the information07:02
nandalI select your account as approver then07:02
nandal:)07:02
robcresswellnandal: Can you ping the link? I get notified of just about every blueprint and patch change in Horizon so assigning my name is not really any guarantee I'll see it07:03
*** tqtran has quit IRC07:03
nandalok07:03
nandalhttps://blueprints.launchpad.net/horizon/+spec/volume-backups-management07:03
nandalhttps://blueprints.launchpad.net/horizon/+spec/volume-snapshots-management07:04
r1chardj0n3shey robcresswell, did you sometimes see this?07:04
r1chardj0n3s  File "/Users/richard/src/openstack/horizon/horizon/templatetags/angular.py", line 36, in update_angular_template_hash07:04
r1chardj0n3s    theme = context['THEME']  # current theme being compressed07:04
robcresswellnandal: Can you base them off the template? https://blueprints.launchpad.net/horizon/+spec/template It makes it much easier to check all aspects07:04
r1chardj0n3sjust on a reload. find that I need to restart the dev server to clear it ...07:04
robcresswellr1chardj0n3s: So, this has been a constant thorn in my side for the past 3 weeks07:05
robcresswellr1chardj0n3s: Is your master up to date?07:05
r1chardj0n3syep07:05
r1chardj0n3s:-(07:05
robcresswellI cannot for the life of me recreate it07:05
nandalyes, sure07:05
nandali will do that07:05
robcresswellthanks nandal07:05
r1chardj0n3sright. if I can get excited about it I'll look into it tomorrow07:05
nandalthnk u07:05
robcresswellr1chardj0n3s: https://review.openstack.org/#/c/344871/07:09
robcresswellr1chardj0n3s: That was my attempt to fix it07:10
r1chardj0n3sright :/07:10
openstackgerritRichard Jones proposed openstack/horizon: Migrate Create Container to schema form  https://review.openstack.org/35898407:12
r1chardj0n3srobcresswell: added that container name validation ^^ :-)07:12
*** ducttape_ has joined #openstack-horizon07:12
r1chardj0n3showever... there's something weird going on with the schema form $asyncValidator - it doesn't get fired on the first edit *after* the validator fails07:12
r1chardj0n3sit's weird07:12
r1chardj0n3sbut I've officially had enough of this stout to be unproductive, so have a lovely day old chap and I'll catch you tomorrow :-)07:13
robcresswellhaha, have a good evening richard07:13
*** peristeri has joined #openstack-horizon07:15
*** btully has quit IRC07:15
*** ducttape_ has quit IRC07:16
*** yingjun has joined #openstack-horizon07:17
*** tesseract- has joined #openstack-horizon07:18
openstackgerritMerged openstack/horizon: Use argparse instead of optparse  https://review.openstack.org/34599807:23
openstackgerritecelik proposed openstack/horizon: Volume limits and floating ip  graphic label consistency  https://review.openstack.org/25123707:25
*** jpich has joined #openstack-horizon07:27
robcresswelltsufiev: We seem to be getting consistent failures on a couple of the integration tests fyi07:28
robcresswelltsufiev: floating ip over and over07:28
*** yingjun has quit IRC07:33
*** yingjun has joined #openstack-horizon07:33
*** asettle has joined #openstack-horizon07:33
*** yingjun has quit IRC07:37
*** yamamoto has quit IRC07:38
liuyulongrobcresswell, yes, I've met that 5 times.07:40
liuyulongrobcresswell, Jenkins check `gate-horizon-dsvm-integration-deprecated` is passed, but Jenkins gate failed. Here is an example: https://review.openstack.org/#/c/352537/07:42
*** yingjun has joined #openstack-horizon07:47
*** lexplua has quit IRC07:51
*** roxanagh_ has joined #openstack-horizon07:52
*** rcernin has quit IRC07:56
*** roxanagh_ has quit IRC07:56
*** openstackgerrit has quit IRC08:03
*** wolverineav has quit IRC08:04
*** openstackgerrit has joined #openstack-horizon08:04
openstackgerritOpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Zanata  https://review.openstack.org/35902008:05
*** wolverineav has joined #openstack-horizon08:06
*** jtomasek has joined #openstack-horizon08:07
openstackgerritDavanum Srinivas (dims) proposed openstack/horizon: [WIP] Testing latest u-c  https://review.openstack.org/30342908:10
*** ducttape_ has joined #openstack-horizon08:13
*** wolverineav has quit IRC08:15
*** yamamoto has joined #openstack-horizon08:16
*** ducttape_ has quit IRC08:17
*** BlackDex has joined #openstack-horizon08:22
BlackDexHello there. I experince some slow interface with horizon. The network doesn't seem to be the issue as speed tests just work at the correct speed. Where can i look?08:23
*** lexplua has joined #openstack-horizon08:26
robcresswellBlackDex: Any specific panels? Any logs?08:27
BlackDexFor instance when starting a new instance08:31
BlackDexrabbitmq seems to be working just fine08:31
*** yingjun has quit IRC08:31
BlackDexno high loads08:31
*** yingjun has joined #openstack-horizon08:31
*** lexplua has quit IRC08:31
robcresswellRight, but I mean which part is slow? Is there a delay on the API call? Is the feedback on Horizon slow?08:32
robcresswellIf you look at your logs you should be able to see how long it all takes08:32
openstackgerritKenji Ishii proposed openstack/horizon: Fix unnecessary requests in angular image panel  https://review.openstack.org/35903308:32
robcresswellinstances pages can be slow, but I need data to make any meaningful suggestions :)08:32
robcresswellHorizon version would also help08:33
*** yingjun has quit IRC08:36
*** pt_15 has quit IRC08:36
*** yamamoto has quit IRC08:40
*** lexplua has joined #openstack-horizon08:41
BlackDexthe feedback in horizon seems slow08:47
BlackDexi don't think the actual action is slow08:47
*** yamamoto has joined #openstack-horizon08:48
BlackDexcurrently running Version: 8.0.108:48
BlackDexit doesn't matter if i select the network page or the instances page08:49
*** kzaitsev_mb has joined #openstack-horizon08:52
*** yingjun has joined #openstack-horizon08:55
*** wolverineav has joined #openstack-horizon08:55
*** btully has joined #openstack-horizon08:59
*** wolverineav has quit IRC09:00
*** sjmc7 has joined #openstack-horizon09:03
*** btully has quit IRC09:04
*** sjmc7 has quit IRC09:07
robcresswellBlackDex: Sorry, what does't matter?09:09
BlackDexWell, it is strange, since it doesn't do that always.09:09
robcresswellBlackDex: Sorry, I'm not sure I follow. The slow feedback is intermittent?09:11
BlackDexit is sometimes fast like, click and it shows. And sometimes it takes a long time09:12
robcresswellBlackDex: Oh I see. IMO, that indicates to me that Horizon is capable of showing it quick then; I don't think there is much on our side that would suddenly slow down09:13
robcresswellBut really, you'll need logs of how long these actions are taking09:14
robcresswellSo we can compare it to the horizon feedback. There are a lot of places that could cause a slowdown.09:14
openstackgerritRob Cresswell proposed openstack/horizon: Migrate Create Container to schema form  https://review.openstack.org/35898409:16
robcresswellr1chardj0n3s: Had a go at the schema form adjustment. Take a look tomorrow and let me know what you think.09:17
openstackgerritRadomir Dopieralski proposed openstack/horizon: Use default domain context when listing multidomain users  https://review.openstack.org/35657109:17
*** javeriak has joined #openstack-horizon09:33
*** kzaitsev_mb has quit IRC09:33
BlackDexrobcresswell: Oke. Ill try to get some and see if i can find something which looks like could be the problem09:36
robcresswellBlackDex: Sounds good09:36
BlackDexthx for the help :)09:36
*** roxanagh_ has joined #openstack-horizon09:40
*** amotoki has joined #openstack-horizon09:40
*** tosky has joined #openstack-horizon09:41
tsufievrobcresswell, could you point me to a couple of these integration test failures?09:41
*** roxanagh_ has quit IRC09:45
robcresswellhttp://logs.openstack.org/84/329184/24/check/gate-horizon-dsvm-integration-current/6accc37/09:46
robcresswellhttp://logs.openstack.org/37/352537/1/gate/gate-horizon-dsvm-integration-deprecated/cd7cfdd/09:47
robcresswelltsufiev: Thats a couple ^^09:48
*** amotoki has quit IRC09:51
tsufievrobcresswell, yeah, I saw a few times the flavor_update failed test09:52
robcresswellI've seen floating ips fail a lot too, although I can't see it now09:53
robcresswellMaybe it was intermittent and cleared up elsewhere09:53
robcresswellI really need to make the integration tests stop running twice too :p09:53
robcresswelldeprecated should be deprecated-only. Wil solve after FF I think.09:53
*** zhurong has quit IRC09:59
*** tqtran has joined #openstack-horizon10:01
*** yingjun has quit IRC10:04
*** sjmc7 has joined #openstack-horizon10:04
*** tqtran has quit IRC10:05
openstackgerritAllen proposed openstack/horizon: Fix the parameter name in "allowed" function in "DeleteBackup" class  https://review.openstack.org/35908510:06
*** sjmc7 has quit IRC10:09
*** ducttape_ has joined #openstack-horizon10:10
*** ducttape_ has quit IRC10:16
*** wolverineav has joined #openstack-horizon10:19
*** wolverineav has quit IRC10:23
*** wolverineav has joined #openstack-horizon10:26
*** lexplua has quit IRC10:31
*** wolverineav has quit IRC10:31
*** kzaitsev_mb has joined #openstack-horizon10:33
*** javeriak has quit IRC10:38
*** kzaitsev_mb has quit IRC10:39
*** lexplua has joined #openstack-horizon10:42
*** amotoki has joined #openstack-horizon10:42
*** TravT has quit IRC10:43
*** javeriak has joined #openstack-horizon10:45
*** TravT has joined #openstack-horizon10:45
*** ChanServ sets mode: +v TravT10:45
openstackgerritRodrigo Barbieri proposed openstack/manila-ui: Add share type change to Share Migration UI  https://review.openstack.org/34566410:50
openstackgerritRodrigo Barbieri proposed openstack/manila-ui: Add Share Migration support  https://review.openstack.org/34443110:50
*** kzaitsev_mb has joined #openstack-horizon10:52
*** amotoki has quit IRC10:53
*** rodrigods has quit IRC10:59
*** rodrigods has joined #openstack-horizon10:59
*** wolverineav has joined #openstack-horizon11:00
tsufievrobcresswell, sure, that would decrease load on openstack infra11:03
*** wolverineav has quit IRC11:04
*** ducttape_ has joined #openstack-horizon11:13
*** ducttape_ has quit IRC11:17
*** lexplua has quit IRC11:18
kzaitsev_mbrobcresswell: may I get just a bit of your time for the THEME issue. I've found the root cause and can explain why this happens (and it still happens for me master)11:18
kzaitsev_mbmaybe you'll be able to see why this doesn't happen on devstack11:18
rdopierakzaitsev_mb: what's the theme issue?11:19
*** wolverineav has joined #openstack-horizon11:19
kzaitsev_mbrdopiera: in murano-dashboard we get a KeyError THEME with fresh install from master11:20
kzaitsev_mbgive me 15 secs I'll give pointers and explanation11:20
openstackgerritshizhihui proposed openstack/horizon: Add Python 3.5 classifier and venv  https://review.openstack.org/35450511:21
kzaitsev_mbthe error happens in horizon/templatetags/angular.py https://github.com/openstack/horizon/blob/master/horizon/templatetags/angular.py#L36 here this is a receiver for post_compress signal. I believe it happens after {% compress %} tag finished its work. This signal expects to have 'THEME' in templates context11:23
openstackgerritshizhihui proposed openstack/horizon: Add Python 3.5 classifier and venv  https://review.openstack.org/35450511:24
rdopieraah, angular :(11:24
*** wolverineav has quit IRC11:24
kzaitsev_mb'THEME' is set in openstack_dashboard/templates/horizon/_scripts.html11:26
kzaitsev_mblike this https://github.com/openstack/horizon/blob/master/openstack_dashboard/templates/horizon/_scripts.html#L911:26
kzaitsev_mbso the post_compress signal receiver expects the thing to be in context so in murano-dashboard I've updated all the compress tags to have it11:27
kzaitsev_mblike this https://review.openstack.org/#/c/358778/11:27
kzaitsev_mbbut I still face the issue in openstack_dashboard/templates/horizon/_conf.html11:27
*** roxanagh_ has joined #openstack-horizon11:28
kzaitsev_mbhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/templates/horizon/_conf.html#L7 there is no THEME in the context but this tag would be empty if there are no 3d-party js/css declared11:28
kzaitsev_mb(might be wrong here)11:29
robcresswell:/11:30
*** wolverineav has joined #openstack-horizon11:30
robcresswellMaybe you should just share the base template :)11:30
kzaitsev_mbrobcresswell: we do, I mean, we inherit from it11:30
kzaitsev_mbdoes it make sense, that compress in templates/horizon/_conf.html should also have THEME declared?11:31
* robcresswell is still not sure why you dont just use the same base templates and use o_d compression as intended11:32
robcresswellinstead of rewriting and giving yourself headache11:32
kzaitsev_mbalso — long term — wouldn't it be better to have a template processor, that adds current THEME instead of a templatetag11:32
*** roxanagh_ has quit IRC11:32
openstackgerritTatiana Ovchinnikova proposed openstack/manila-ui: Additional fields for Create/Update Share Type forms  https://review.openstack.org/33850411:33
openstackgerritMerged openstack/manila-ui: Imported Translations from Zanata  https://review.openstack.org/35898511:33
kzaitsev_mbrobcresswell: well, because I'm not sure that all our js/css is ok to load on every horizon page — I'm pretty sure it isn't and would mess with other people's layouts11:33
robcresswellSo, make it not do that thing11:34
robcresswellall that means if you're lacking specificity11:34
robcresswellWhich is bad anyway if a deployer trys to override something11:34
kzaitsev_mbrobcresswell: that would not fix the problem, that https://github.com/openstack/horizon/blob/master/openstack_dashboard/templates/horizon/_conf.html#L7 uses a compress tag and doesn't declare THEME variable in the context properly11:35
openstackgerritshizhihui proposed openstack/horizon: Add Python 3.5 classifier and venv  https://review.openstack.org/35450511:35
robcresswellkzaitsev_mb: If that was improper, everyone would be broken, not just murano11:36
*** jtomasek has quit IRC11:37
tsufievkzaitsev_mb, the thing you're talking about surely can be done, by adding 'THEME' key here https://github.com/openstack/horizon/blob/master/openstack_dashboard/context_processors.py#L6111:37
tsufievthe question is if we should do it, as robcresswell pointed11:37
*** wolverineav has quit IRC11:38
tsufievanyways, you fixed the problem for yourselves11:38
kzaitsev_mbrobcresswell: well I'm still perplexed why this doesn't happen on devstack11:38
robcresswellI still don't even know how to recreate this bug11:38
robcresswellkzaitsev_mb: How are you deploying?11:38
kzaitsev_mbI use a remote cloud and local horizon + murano-dashboard. I've checked out latest horizon and latest murano, mad minmal config to horizon (added ALLOWED_HOSTS and OPENSTACK_KEYSTONE_URL to local_settings.py), then copied muranodashboard/local/enabled/_50_murano.py and muranodashboard/local/local_settings.d/_50_murano.py and muranodashboard/conf/murano_policy.json to respective dirs11:41
kzaitsev_mband well that's all11:42
*** amotoki has joined #openstack-horizon11:42
*** rcernin has joined #openstack-horizon11:43
robcresswellokay. I'm testing new clone of horizon and murano11:44
kzaitsev_mbidk, let me check if these steps would break for something less convoluted that murano-dashboard. app-catalog-ui might be good for testing, since it has next to no python code11:45
robcresswellkzaitsev_mb: Whats the last commit in your horizon?11:45
kzaitsev_mb35bd21ea135cdbc2d3edb684dd595685924abe12 Merge "Use argparse instead of optparse"11:46
robcresswellcool11:46
kzaitsev_mbI run 'tox -e venv -- python manage.py collectstatic --noinput && tox -e venv -- python manage.py runserver' to launch horizon, just to be sure11:47
kzaitsev_mbon a side note our install guide for murano-dashboard is a bit convoluted — gotta squash all the `cp`'s into one11:47
*** wolverineav has joined #openstack-horizon11:48
*** jtomasek has joined #openstack-horizon11:49
kzaitsev_mbrobcresswell: also sorry for all the hassle =) and I really appreciate you taking your time to help me debug this11:49
*** asettle has quit IRC11:51
kzaitsev_mbhm. also I 'tox -e venv -- pip install -e ../murano-dashboard/' (we had a crasy idea that -e could do smth, although i don't believe that)11:51
*** wolverineav has quit IRC11:52
robcresswell-e just means you dont have to keep reinstalling it. Its a dev flag iirc.11:54
*** lexplua has joined #openstack-horizon11:55
kzaitsev_mbyep, know that11:57
robcresswellsure11:57
robcresswellYeah it wouldnt make a difference11:58
*** wolverineav has joined #openstack-horizon12:04
openstackgerritMerged openstack/horizon: Prevent long names breaking table layouts  https://review.openstack.org/32342712:05
robcresswell\o/12:05
*** sjmc7 has joined #openstack-horizon12:05
*** aortega has joined #openstack-horizon12:06
openstackgerritMerged openstack/horizon: Update the xstatic release process  https://review.openstack.org/34400712:06
*** wolverineav has quit IRC12:09
*** ducttape_ has joined #openstack-horizon12:10
robcresswellkzaitsev_mb: I just cloned a fresh horizon and still dont have the issue :(12:10
*** sjmc7 has quit IRC12:10
kzaitsev_mbrobcresswell: do you have murano panels available there?12:10
kzaitsev_mbyou should be able to navigate to 'Applications -> Environments' page without murano-api running12:11
robcresswellYeah, they are all there kzaitsev_mb12:11
*** zhurong has joined #openstack-horizon12:11
kzaitsev_mbthis is just crazy =(12:12
kzaitsev_mbrobcresswell: what OS are you on?12:12
kzaitsev_mbOperating System )12:12
kzaitsev_mb(I use Mac for development)12:12
robcresswellYeah, local horizon and murano dashboard, remote devstack, osx12:13
*** wolverineav has joined #openstack-horizon12:13
robcresswellkzaitsev_mb: ^^12:14
*** aortega has quit IRC12:15
kzaitsev_mbtsufiev was passing by and agreed to let me experiment with him on the fresh install12:15
robcresswellOh, you guys are in the same office?12:15
kzaitsev_mbidk, I currently have no idea what can be the difference =/12:15
kzaitsev_mbyep, different rooms, but same office =)12:16
robcresswellah I see12:16
*** pauloewerton has joined #openstack-horizon12:18
*** wolverineav has quit IRC12:18
*** david_cu has joined #openstack-horizon12:18
tsufievrobcresswell, lol yes, I tried to keep this in secret, but now it is revealed12:20
*** javeriak has quit IRC12:20
*** ducttape_ has quit IRC12:21
*** wolverineav has joined #openstack-horizon12:23
*** rcernin has quit IRC12:23
robcresswelltsufiev: haha! And I've been trying to debug from England when you are in the next room!12:24
tsufievrobcresswell, sorry, shame on me :(12:24
robcresswellhaha, I hope you and kzaitsev_mb can find the issue :)12:25
*** rcernin has joined #openstack-horizon12:28
*** masco has quit IRC12:30
*** wolverineav has quit IRC12:31
*** wolverineav has joined #openstack-horizon12:35
*** btully has joined #openstack-horizon12:37
*** wolverineav has quit IRC12:40
*** asettle has joined #openstack-horizon12:40
*** btully has quit IRC12:41
*** ratailor has quit IRC12:46
*** wolverineav has joined #openstack-horizon12:46
*** lblanchard has joined #openstack-horizon12:52
*** chlong has quit IRC12:56
*** aortega has joined #openstack-horizon12:56
*** vishwanathj_zzz is now known as vishwanathj12:57
*** jtriley has joined #openstack-horizon12:58
*** lexplua has quit IRC13:00
*** tqtran has joined #openstack-horizon13:03
*** wolverineav has quit IRC13:03
*** rcernin has quit IRC13:03
*** sjmc7 has joined #openstack-horizon13:06
tsufiev'Harry Potter and the mysterious murano-dashboard'13:07
*** tqtran has quit IRC13:07
*** wolverineav has joined #openstack-horizon13:07
tsufievrobcresswell, that ^^^ precisely describes the situation13:07
robcresswelltsufiev: haha13:07
kzaitsev_mb=(13:07
tsufievkzaitsev_mb, don't worry. I'm working on it, drinking the second round of tea13:08
kzaitsev_mbyeah, setting THEME either in template itself or in the context processor helps, but there is still problem with offline compression enabled13:08
*** matt-borland has joined #openstack-horizon13:09
tsufievas I said offline, the biggest mystery to me is not the error itself, but the fact it works fine in devstack13:09
robcresswelltsufiev: I tried just pulling a clean horizon down and it worked fine too13:10
robcresswelltsufiev: So its not just devstack horizon13:10
tsufievyeah, I confirm that13:10
*** sjmc7 has quit IRC13:10
tsufievit's devstack horizon + murano-dashboard vs. horizon + murano-dashboard set up manually13:11
robcresswellkzaitsev_mb: You don't have anything in local_settings.d do you? or any mysteries local_settings?13:11
matt-borlando/13:12
robcresswellmatt-borland: o/13:12
*** chlong has joined #openstack-horizon13:13
robcresswellmatt-borland: Still need a bit of work on that images patch matt, but I got one of my colleagues to do the help text13:13
robcresswellmatt-borland: Any remaining issues will hopefully be picked up in RC13:13
matt-borlandI just looked at it 1 second ago, is it addressing Travis' suggestions?13:13
matt-borlandI can work on that today13:14
robcresswellmatt-borland: Yeah, he has a -1 on it13:14
robcresswellmatt-borland: Great!13:14
matt-borlandawesome, thanks!  After my brief vacation I have to context-shift back to work. :)13:14
*** walharth has joined #openstack-horizon13:15
*** wolverineav has quit IRC13:15
*** roxanagh_ has joined #openstack-horizon13:16
*** javeriak has joined #openstack-horizon13:17
robcresswellmatt-borland: You may also want to review https://review.openstack.org/#/c/359033/13:17
robcresswellmatt-borland: Since it touches the same content13:17
matt-borlandcool13:18
matt-borlandInteresting.  I'm surprised that that would register as a problem.13:18
matt-borlandI'm not really convinced it does.13:18
matt-borlandBut I'll take a look, thanks!13:19
kzaitsev_mbrobcresswell: no, only 1 file from murano-dashboard https://github.com/openstack/murano-dashboard/blob/master/muranodashboard/local/local_settings.d/_50_murano.py this one.13:19
kzaitsev_mbbtw don't think it's nice to have db overriden like this, I think it would be a lot better to split the thing13:20
robcresswellmatt-borland: The bug definitely seems to exist. I checked it yesterday, and you can see the double get images log13:20
matt-borlandOK, cool.13:20
*** roxanagh_ has quit IRC13:21
*** julim has joined #openstack-horizon13:21
*** ducttape_ has joined #openstack-horizon13:21
*** wolverineav has joined #openstack-horizon13:21
*** Jeffrey4l_ has quit IRC13:22
*** bigdogstl has joined #openstack-horizon13:24
*** david-lyle has joined #openstack-horizon13:24
*** ChanServ sets mode: +o david-lyle13:24
*** lexplua has joined #openstack-horizon13:26
*** piet has joined #openstack-horizon13:27
*** wolverineav has quit IRC13:30
openstackgerritRob Cresswell proposed openstack/horizon: Add release note for package updates  https://review.openstack.org/30853213:34
*** wolverineav has joined #openstack-horizon13:34
openstackgerritRob Cresswell proposed openstack/horizon: Add release note for package updates  https://review.openstack.org/30853213:34
*** sdake has joined #openstack-horizon13:36
robcresswellmatt-borland: I'm just cleaning up LP. When would you like to consider https://blueprints.launchpad.net/horizon/+spec/angular-registry to be closed?13:36
matt-borlandrobcresswell, do we have any remaining patches with it?13:37
*** sdake_ has joined #openstack-horizon13:37
robcresswellmatt-borland: We can carry it to the next cycle if there are still features being added, but it looks like the majority of the content is in and new content should be under new bps or wishlist bugs.13:37
matt-borlandI think we should close it this release.13:37
robcresswelltyr has his passthrough api tagged to it13:37
matt-borlandI don't think that's really part of the registry13:37
robcresswellBut, happy to bump that to a different bp since it will probably require discussion anyway13:37
robcresswellNo, me neither13:37
robcresswellI'll mark it implemented13:38
*** ducttape_ has quit IRC13:38
matt-borlandOK, sounds great...thanks robcresswell!13:38
*** sdake has quit IRC13:41
*** bigdogstl has quit IRC13:43
*** ducttape_ has joined #openstack-horizon13:45
openstackgerritRob Cresswell proposed openstack/xstatic-d3: Update with xstatic-release script  https://review.openstack.org/35920713:47
*** eandersson_ has quit IRC13:47
ducttape_tsufiev: checking in on quotas, if you have had any thoughts / work in last 24 hrs13:50
*** piet has quit IRC13:50
tsufievducttape_, negative, been busy with other stuff13:50
ducttape_I believe there is a patch from andrewbogott that might land, which has small conflicts - fwiw13:50
tsufievducttape_, okay, feel free to add me as a reviewer there13:51
ducttape_yesterday I did a fair bit or reorganizing13:51
ducttape_on my patch13:51
ducttape_also question for tsufiev or robcresswell - any patches where the quotas and role assignments are broken into two different tools for a project ?13:52
openstackgerritEdmund Rhudy proposed openstack/horizon: Fixes traceback if group name attribute is missing  https://review.openstack.org/35804813:52
*** javeriak_ has joined #openstack-horizon13:52
*** walharth_ has joined #openstack-horizon13:53
*** walharth has quit IRC13:53
*** javeriak has quit IRC13:53
robcresswellducttape_: Doesn't ring any bells, I'm afraid13:53
openstackgerritEdmund Rhudy proposed openstack/horizon: Fixes traceback if group name attribute is missing  https://review.openstack.org/35804813:53
ducttape_ok, thanks robcresswell.   I bet this comes to happen sooner or later fwiw.   piet might have had some review on this too, not sure13:54
*** sjmc7 has joined #openstack-horizon13:55
robcresswellducttape_: That may well just be me not being aware. I've never spent much time with quotas.13:55
ducttape_yep, no worries / no prob13:55
*** kzaitsev_mb has quit IRC13:56
*** eandersson has joined #openstack-horizon13:56
*** bigdogstl has joined #openstack-horizon13:57
*** liuyulong_ has joined #openstack-horizon13:58
*** kzaitsev_mb has joined #openstack-horizon13:59
*** piet has joined #openstack-horizon13:59
*** tqtran has joined #openstack-horizon14:02
*** bigdogstl has quit IRC14:02
*** pcaruana has quit IRC14:02
*** david-lyle has quit IRC14:04
ducttape_is launch pad extra special this am?   can't seem to edit bp work items14:04
*** btully has joined #openstack-horizon14:05
*** wolverineav has quit IRC14:08
*** wolverineav has joined #openstack-horizon14:09
*** btully has quit IRC14:09
openstackgerritRob Cresswell proposed openstack/horizon: Add rel note and example for TOKEN_DELETE_DISABLED  https://review.openstack.org/35922014:12
robcresswellducttape_: Everything is pretty special right now. 15 hour gate queues too :(14:12
ducttape_k.  robcresswell  I am giving a solid 15% effort on quotas, hope that gets some love.   thats like 8% more than I usually try14:13
* ducttape_ double checks the math14:13
*** peristeri has quit IRC14:13
matt-borlandrobcresswell, I'll try to work out with TravT what to do with that patch.  I'm worried about a pile-on effect.14:13
robcresswellmatt-borland: Er, I don't want to swap when there are pretty clear regressions in some of the sorting, it seems like14:14
matt-borlandI guess I need to read the comments better.14:15
robcresswellmatt-borland: It seems to me like you solved everything, just not quite completely. Unless Im misreading, you hit all the point I raised, but one of the filters didnt work as expected, which Trav highlighted.14:15
*** pcaruana has joined #openstack-horizon14:17
*** edtubill has joined #openstack-horizon14:17
*** wolverineav has quit IRC14:18
*** wolverineav has joined #openstack-horizon14:23
*** liuyulong__ has joined #openstack-horizon14:24
matt-borlandgotcha, robcresswell...yeah, I'll research.14:25
*** liuyulong has quit IRC14:27
*** wolverineav has quit IRC14:28
*** david-lyle has joined #openstack-horizon14:28
*** ChanServ sets mode: +o david-lyle14:28
*** TravT has quit IRC14:30
*** zackf has joined #openstack-horizon14:31
*** wolverineav has joined #openstack-horizon14:33
*** TravT has joined #openstack-horizon14:33
*** ChanServ sets mode: +v TravT14:33
*** sdake_ has quit IRC14:35
*** piet has quit IRC14:35
*** davidlenwell has quit IRC14:36
*** vern has quit IRC14:36
*** davidlenwell has joined #openstack-horizon14:37
*** wolverineav has quit IRC14:37
*** ezpz has joined #openstack-horizon14:39
*** sdake has joined #openstack-horizon14:41
*** wolverineav has joined #openstack-horizon14:43
*** TravT has quit IRC14:49
*** tqtran has quit IRC14:49
*** TravT has joined #openstack-horizon14:50
*** ChanServ sets mode: +v TravT14:50
openstackgerritMerged openstack/horizon: Add filter action to Template Versions tables  https://review.openstack.org/35772414:51
*** wolverineav has quit IRC14:51
*** bigdogstl has joined #openstack-horizon14:52
*** wolverineav has joined #openstack-horizon14:53
*** javeriak_ has quit IRC14:53
*** david-lyle has quit IRC14:54
*** bigdogstl has quit IRC14:57
*** yamamoto has quit IRC14:57
*** hurgleburgler has joined #openstack-horizon14:57
*** ChanServ sets mode: +v hurgleburgler14:57
*** liuyulong has joined #openstack-horizon14:58
*** liuyulong__ has quit IRC15:00
*** wolverineav has quit IRC15:01
*** yamamoto has joined #openstack-horizon15:01
*** vern has joined #openstack-horizon15:03
*** wolverineav has joined #openstack-horizon15:05
*** yamamoto has quit IRC15:06
*** edtubill has quit IRC15:07
*** jtomasek has quit IRC15:08
*** liuyulong_ is now known as liuyulong|away15:12
*** wolverineav has quit IRC15:15
*** wolverineav has joined #openstack-horizon15:15
*** tyr has joined #openstack-horizon15:16
*** liuyulong|away has quit IRC15:17
openstackgerritMatt Borland proposed openstack/horizon: Final changes to Angular Images before making default  https://review.openstack.org/35650115:18
openstackgerritMatt Borland proposed openstack/horizon: Final changes to Angular Images before making default  https://review.openstack.org/35650115:23
*** david-lyle has joined #openstack-horizon15:23
*** ChanServ sets mode: +o david-lyle15:23
*** piet has joined #openstack-horizon15:23
*** weezS has joined #openstack-horizon15:24
matt-borlandTravT, robcresswell...^^ I believe I have Visibility working correctly, including fixing the facets15:25
matt-borlandand on Details as well15:25
TravTgreat!15:25
TravTi'll take a look15:25
matt-borlandLet me know your results...I followed the logic from Python15:25
TravTok, did you test out with shared images?15:26
*** davidlenwell has quit IRC15:27
*** wolverineav has quit IRC15:28
*** tyr has quit IRC15:30
*** tyr_ has joined #openstack-horizon15:30
*** walharth_ has quit IRC15:30
*** walharth has joined #openstack-horizon15:31
*** wolverineav has joined #openstack-horizon15:31
*** yamamoto has joined #openstack-horizon15:31
*** yamamoto has quit IRC15:32
*** yamamoto has joined #openstack-horizon15:33
*** yamamoto has quit IRC15:33
*** david-lyle has quit IRC15:33
matt-borlandTravT, yes15:34
*** piet has quit IRC15:35
*** wolverineav has quit IRC15:40
*** wolverineav has joined #openstack-horizon15:40
*** davidlenwell has joined #openstack-horizon15:40
TravTmatt-borland: looks good to me!15:44
*** piet has joined #openstack-horizon15:45
*** piet has quit IRC15:45
matt-borlandthanks TravT15:45
*** zhurong has quit IRC15:46
*** tesseract- has quit IRC15:46
*** bigdogstl has joined #openstack-horizon15:46
*** piet has joined #openstack-horizon15:47
*** sergio_nubeliu has joined #openstack-horizon15:49
*** bigdogstl has quit IRC15:53
*** alexvictorchan has joined #openstack-horizon15:55
*** pcaruana has quit IRC15:56
*** david-lyle has joined #openstack-horizon16:01
*** ChanServ sets mode: +o david-lyle16:01
*** Ephur has joined #openstack-horizon16:02
*** vishwanathj_ has joined #openstack-horizon16:03
*** piet has quit IRC16:08
*** pcaruana has joined #openstack-horizon16:09
*** piet has joined #openstack-horizon16:10
*** jpich has quit IRC16:16
*** bigdogstl has joined #openstack-horizon16:23
*** bigdogstl has quit IRC16:27
*** yamamoto has joined #openstack-horizon16:33
*** zul has quit IRC16:36
*** woodburn has quit IRC16:36
sjmc7david-lyle: got a sec?16:37
robcresswellsjmc7: Think he might not be around this week16:37
sjmc7aww. i’m trying to enforce a pavlovian response to my name16:37
sjmc7do you know if brad’s around?16:37
openstackgerritDaniel Castellanos proposed openstack/horizon: Added Server-side filtering for swift UI  https://review.openstack.org/32722416:38
robcresswellsjmc7: IRC says no16:38
sjmc7yeah, i meant for the week16:38
robcresswellsjmc7: Ah, sorry, I've no idea.16:38
sjmc7anyone else who knows about auth do you know? lin’s not around either16:38
robcresswellsjmc7: Not in depth, no, though a few of us have spent time poking around d_o_a16:40
sjmc7careful, you almost volunteered16:40
robcresswellsjmc7: I kept my reply suitably non-committal16:40
sjmc7it is a genuinely short question - i think https://github.com/openstack/django_openstack_auth/blob/master/openstack_auth/policy.py#L130 and line 144 may be doing a bad thing; domain_id has multiple meanings which don’t match what keystone thinks16:41
*** yamamoto has quit IRC16:41
sjmc7i know david worked on it, albeit a loooong time ago16:42
robcresswellsjmc7: Can you elaborate?16:42
sjmc7yeah… keystone, when it uses ‘domain_id’, means ‘the domain a token is scoped to'16:43
sjmc7the horizon policy check means ‘the domain your user is in, or possibly a domain you’re scoped to’16:43
sjmc7i *think* that it should never push the user’s domain id in there, only a domain that you have a token scoped to16:44
sjmc7i ask this because we’ve been hit with a barrage of v3-related issues in keystone and horizon which i’m trying to untangle16:44
lcastellangular folks, whenever you have a change could you take a look to:https://review.openstack.org/327224 I did something I didn't like too much to pass through a bug... wondering if there's a better way to fix the bug16:46
lcastellchance**16:46
*** zul has joined #openstack-horizon16:48
*** asettle has quit IRC16:48
*** asettle has joined #openstack-horizon16:49
*** asettle has quit IRC16:49
*** asettle has joined #openstack-horizon16:49
* ducttape_ finding spots to make quotas clearer, going to make sjmc7 and tsufiev happy16:50
*** asettle has quit IRC16:50
robcresswellsjmc7: I'd have to bug keystone people to figure it out I'm afraid16:50
sjmc7i tried that :)16:51
sjmc7ok, i can wait til david’s back16:51
robcresswellYeah I dont know enough about domain scoped tokens to give a solid answer16:51
robcresswellSorry!16:51
*** bpokorny has joined #openstack-horizon16:52
openstackgerritEric Peterson proposed openstack/horizon: WIP Quota approach  https://review.openstack.org/35660516:53
*** bpokorny has quit IRC16:54
*** woodburn has joined #openstack-horizon16:55
*** bpokorny has joined #openstack-horizon16:55
*** mtanino has joined #openstack-horizon16:57
*** mpavlase has quit IRC17:04
*** javeriak has joined #openstack-horizon17:04
openstackgerritRob Cresswell proposed openstack/horizon: Update create volume help text for angular workflow  https://review.openstack.org/35875617:05
robcresswellmatt-borland: Looks good to me.17:05
*** Guest25180 is now known as med_17:06
*** med_ has joined #openstack-horizon17:06
matt-borlandrobcresswell, awesome17:06
*** med_ is now known as medberry17:06
*** medberry is now known as med_17:06
matt-borlandthanks for taking the time to review that (again and again in depth)17:06
robcresswellmatt-borland: Yeah. We can get others to go over it and nit pick during RC for any bugs, but I haven't been able to find anything17:07
matt-borlandcool beans robcresswell17:07
robcresswellmatt-borland: I'm still amazed how much smoother the performance is, ha. Nice work.17:07
matt-borlandyeah, now imagine that across the board!17:07
matt-borland:)17:07
matt-borlandthanks17:07
*** wolverineav has quit IRC17:08
*** wolverineav has joined #openstack-horizon17:10
*** mtanin___ has joined #openstack-horizon17:10
robcresswellonce that toggle goes in we're down to final 6 patches I had wanted before FF I think.17:10
tyr_robcresswell: fwiw, I created a version of the schema form panel that doesn't rely on ace.js. It is usable, but much less nice to type into. You think I should post it?17:12
*** mtanino has quit IRC17:12
robcresswelltyr_: If you could, I'd quite like to look at it. Sorry I haven't had much time to investigate, been reviewing and fixing other patches17:13
*** hurgleburgler has quit IRC17:13
*** hurgleburgler1 has joined #openstack-horizon17:13
*** zhihui has quit IRC17:13
*** hurgleburgler1 has quit IRC17:15
*** bigdogstl has joined #openstack-horizon17:15
*** hurgleburgler has joined #openstack-horizon17:16
*** ChanServ sets mode: +v hurgleburgler17:16
*** zhihui has joined #openstack-horizon17:16
openstackgerritTyr Johanson proposed openstack/horizon: Schema Form Developer Panel  https://review.openstack.org/35934917:16
*** jrist has quit IRC17:18
tyr_robcresswell: posted dependent version without ace ^17:19
openstackgerritDoug Hellmann proposed openstack/xstatic-angular-smart-table: fix description metadata  https://review.openstack.org/35935017:19
*** bigdogstl has quit IRC17:20
*** piet has quit IRC17:22
*** wolverineav has quit IRC17:22
*** piet has joined #openstack-horizon17:22
robcresswelltyr_: Cool, thanks17:23
*** piet has quit IRC17:23
*** bpokorny has quit IRC17:23
*** zul has quit IRC17:26
*** weezS has quit IRC17:28
*** lexplua has quit IRC17:32
*** weezS has joined #openstack-horizon17:32
*** tqtran has joined #openstack-horizon17:35
*** jprovazn has quit IRC17:36
*** wolverineav has joined #openstack-horizon17:39
*** tqtran has quit IRC17:39
openstackgerritTyr Johanson proposed openstack/horizon: Pass-through API for client side service calls  https://review.openstack.org/35760017:41
*** tosky has quit IRC17:42
*** btully has joined #openstack-horizon17:43
*** Ephur has quit IRC17:45
*** jrist has joined #openstack-horizon17:46
robcresswelltyr_: I actually prefer it. There's a couple bits and pieces we could tidy up, but it avoids any hassle with external dependencies.17:48
tyr_ok, I'll rebase it against master.17:48
*** btully has quit IRC17:48
robcresswelltyr_: Simply giving it a dark background and monospaced font makes it much nice as a code input too, IMO17:48
tyr_sure. Recommendations how to do the dark background in a theme compatible way?17:49
robcresswelltyr_: http://i.imgur.com/DDrnNpN.png << something like that17:49
robcresswelltyr_: Oh, I'll do it, probs more straightforward17:49
hurgleburglerbootstrap code input should handle that in a theme compliant way17:49
robcresswell... how did you do that17:50
hurgleburglerhttp://getbootstrap.com/css/#code17:50
* robcresswell wonders if hurgleburgler has a watcher on 'theme'17:50
hurgleburglerI don't!  That was just pure luck :-D17:50
openstackgerritRevon Mathews proposed openstack/horizon: Server-side filtering for project images  https://review.openstack.org/33301117:50
*** bigdogstl has joined #openstack-horizon17:51
robcresswellhurgleburgler: Would code override textarea correctly? I imagine it would need a class, not just to be wrapped no?17:52
robcresswellI think of all of bootstraps code modifiers are elements, not classes17:52
hurgleburgleryeah, they tag on the elements17:53
*** zhugaoxiao has joined #openstack-horizon17:53
robcresswellYeah, we need a text area specifically to be styled like a code input, so might be easy to just have a context class that uses the code variables, right?17:53
hurgleburglertextarea is usually for user input17:53
hurgleburglerdoes it need user input?17:53
robcresswellyes17:54
hurgleburglerwhy not set the <code> with contenteditable?17:54
*** weezS has quit IRC17:54
*** zul has joined #openstack-horizon17:55
robcresswellhurgleburgler: Not sure if angular will handle it properly17:55
*** Administrator__ has quit IRC17:55
hurgleburglerwhy wouldn't it? contenteditable is an HTML attribute that it should support17:56
robcresswellhurgleburgler: Because it relies on ng-model, and I just don't know if it will work out the data correctly17:56
tyr_appears to require implementing a 'contenteditable' directive http://fdietz.github.io/recipes-with-angular-js/common-user-interface-patterns/editing-text-in-place-using-html5-content-editable.html17:56
hurgleburglerhttps://docs.angularjs.org/api/ng/type/ngModel.NgModelController17:57
hurgleburgler—> Custom Control Example17:57
hurgleburglerThis example shows how to use NgModelController with a custom control to achieve data-binding. Notice how different directives (contenteditable, ng-model, and required) collaborate together to achieve the desired result.17:57
*** weezS has joined #openstack-horizon17:58
*** bigdogstl has quit IRC17:58
robcresswellhurgleburgler: Yeah, but thats writing out a custom directive for it17:58
robcresswellvs just using a text input with a class17:58
robcresswellSeems like overkill just to use <code>, no?17:59
*** jamielennox|away is now known as jamielennox18:01
robcresswelltyr_: Are you in a rush with that patch? I'd quite like to have a look tomorrow if thats okay.18:03
hurgleburglernot sure I follow what is 'overkill' ?  Putting a lot of overrides in the css or adding a new directive that can be used elsewhere later?18:03
tyr_no worries. I'll just post the master rebased version for now.18:03
robcresswellhurgleburgler: Its not a "lot of ovverides". Its one class that allows use to reuse the code variables18:05
robcresswellI was literally just going to add a ".code-input" that just applies code-color and code-bg18:06
hurgleburglerit sounds like you wanted <kbd> and not <code>18:06
hurgleburglerand you would probably want to use @extend kdb;, instead of setting the variables by hand18:06
hurgleburglerin case someone actually customized the <code> in their theme :(18:06
hurgleburgleror even <kdb>18:07
robcresswellOh, I'd not realised extend worked on elements like that18:07
robcresswellNot sure why18:07
hurgleburglerbecause, they can customize it … and use the variables differently … but then you are assuming they would use them the way you want, and the divergence occurs in how its being applied here, rather than how they themed it later18:07
*** mpavlase has joined #openstack-horizon18:08
robcresswellEr, yes, my way would only have reused the variables, not the element rules if they added more I suppose18:08
hurgleburglerI think @extend works on elements ...18:08
hurgleburglerlemme see18:08
robcresswelltsufiev: Does murano or mistral use any form of code or yaml input widget?18:09
robcresswellI'm now wondering if it might be worth including a basic code input widget like that in base horizon anyway...18:10
kzaitsev_mbrobcresswell: murano doesn't )18:10
robcresswelltyr_: Could you ping me when you've pushed the rebased version? I feel like playing around with it. I may regret this.18:12
tyr_roger18:12
openstackgerritAkihiro Motoki proposed openstack/horizon: Server-side filtering networks  https://review.openstack.org/32918418:16
*** Ephur has joined #openstack-horizon18:17
*** javeriak_ has joined #openstack-horizon18:19
*** wolverineav has quit IRC18:21
*** javeriak has quit IRC18:21
openstackgerritTyr Johanson proposed openstack/horizon: Schema Form Developer Panel  https://review.openstack.org/35934918:21
*** javeriak has joined #openstack-horizon18:23
*** javeriak_ has quit IRC18:25
*** vishwanathj_ has quit IRC18:26
tyr_robcresswell: ping -> https://review.openstack.org/#/c/359349/18:28
*** lexplua has joined #openstack-horizon18:28
robcresswelltyr_: Cheers!18:29
tyr_have a good night!18:29
*** wolverineav has joined #openstack-horizon18:30
*** wolverineav has quit IRC18:31
*** wolverineav has joined #openstack-horizon18:31
robcresswelltyr_: One thing, could you glance over https://review.openstack.org/#/c/354059/ if you get a moment?18:35
robcresswelltyr_: Its your panel, so makes sense for you to see the patch :)18:35
tyr_certainly. thanks! Looks good at a glance. I'll run it in a few minutes and comment.18:36
robcresswelltyr_: much appreciated18:38
*** kzaitsev_mb has quit IRC18:41
*** zul has quit IRC18:46
tsufievrobcresswell: a definite no for murano in its current state18:49
tsufievAs for mistral, i haven't worked on its ui for a while18:49
tsufievPerhaps zhenguo niu knows more18:51
*** javeriak has quit IRC18:56
*** weezS has quit IRC18:57
ducttape_tsufiev: quotas stuff at https://review.openstack.org/#/c/356605/ is not that big of a patch, but I think it is getting quite a bit better19:00
*** zul has joined #openstack-horizon19:01
*** tqtran has joined #openstack-horizon19:04
*** piet has joined #openstack-horizon19:05
*** aortega has quit IRC19:06
*** tyr__ has joined #openstack-horizon19:07
*** tyr_ has quit IRC19:08
*** jtomasek has joined #openstack-horizon19:18
*** sjmc7 has quit IRC19:20
*** jtomasek has quit IRC19:20
*** jtomasek_ has joined #openstack-horizon19:20
*** pcaruana has quit IRC19:20
openstackgerritEric Peterson proposed openstack/horizon: WIP Quota approach  https://review.openstack.org/35660519:25
*** weezS has joined #openstack-horizon19:36
*** piet has quit IRC19:36
*** Ephur has quit IRC19:44
*** wolverineav has quit IRC19:48
*** wolverineav has joined #openstack-horizon19:48
*** asettle has joined #openstack-horizon19:53
*** aortega has joined #openstack-horizon19:58
*** asettle has quit IRC19:58
*** woodburn has left #openstack-horizon19:59
*** amotoki has quit IRC20:00
*** sjmc7 has joined #openstack-horizon20:11
*** pt_15 has joined #openstack-horizon20:33
*** itisha has joined #openstack-horizon20:33
*** bpokorny has joined #openstack-horizon20:35
*** jtriley has quit IRC20:35
*** saksham_ has joined #openstack-horizon20:35
*** gyee has joined #openstack-horizon20:37
*** wolverin_ has joined #openstack-horizon20:42
*** bpokorny has quit IRC20:43
*** wolverineav has quit IRC20:45
*** kzaitsev_mb has joined #openstack-horizon20:49
*** woodburn has joined #openstack-horizon20:53
*** wolverin_ has quit IRC20:58
*** uxdanielle has joined #openstack-horizon20:58
*** ezpz has quit IRC20:59
*** amotoki has joined #openstack-horizon21:01
*** wolverineav has joined #openstack-horizon21:01
*** asettle has joined #openstack-horizon21:02
*** wolverineav has quit IRC21:02
*** wolverineav has joined #openstack-horizon21:02
*** amotoki has quit IRC21:06
*** TravT has quit IRC21:08
*** julim has quit IRC21:12
*** lblanchard has quit IRC21:13
*** david-lyle has quit IRC21:15
*** david-lyle has joined #openstack-horizon21:18
*** ChanServ sets mode: +o david-lyle21:18
*** btully has joined #openstack-horizon21:21
r1chardj0n3sthanks robcresswell for the schema form edits!21:21
*** pauloewerton has quit IRC21:22
*** ducttape_ has quit IRC21:23
*** matt-borland has quit IRC21:23
*** btully has quit IRC21:25
*** tyr_ has joined #openstack-horizon21:27
*** tyr__ has quit IRC21:28
openstackgerritRyan Peters proposed openstack/horizon: All Table Templates should support template overrides  https://review.openstack.org/35943721:29
openstackgerritRob Cresswell proposed openstack/horizon: Add release note for package updates  https://review.openstack.org/30853221:30
*** piet has joined #openstack-horizon21:35
*** wolverin_ has joined #openstack-horizon21:40
*** wolverineav has quit IRC21:43
*** wolverin_ has quit IRC21:44
*** sdake has quit IRC21:45
*** asettle has quit IRC21:45
openstackgerritRyan Peters proposed openstack/horizon: All Table Templates should support template overrides  https://review.openstack.org/35943721:45
*** sdake has joined #openstack-horizon21:45
*** sdake has quit IRC21:45
*** walharth has quit IRC21:45
*** sdake has joined #openstack-horizon21:46
*** ducttape_ has joined #openstack-horizon21:46
*** wolverineav has joined #openstack-horizon21:47
openstackgerritRyan Peters proposed openstack/horizon: All Table Templates should support template overrides  https://review.openstack.org/35943721:47
*** piet has quit IRC21:49
*** wolverineav has quit IRC21:51
robcresswellr1chardj0n3s: No problem :)21:51
robcresswellr1chardj0n3s: I wonder if it might be worth having a template that does the two column split for us, so we have a workflow template and a single form template, rather than a one size fits all21:54
robcresswellr1chardj0n3s: Its only a couple of lines here or there, wont be difficult to refactor if we decide to change it later on anyway21:55
r1chardj0n3srobcresswell: maybe, yeah. I don't know what the ramifications of that are at this early stage for me21:55
*** piet has joined #openstack-horizon22:01
*** amotoki has joined #openstack-horizon22:02
robcresswellr1chardj0n3s: I think, ignore me for now :)22:07
*** amotoki has quit IRC22:07
r1chardj0n3sI'm gonna get that printed on a sticker22:08
*** piet has quit IRC22:14
*** walharth has joined #openstack-horizon22:15
robcresswell:'(22:16
robcresswelltyr_: I've got quite a nice cleanup of the form dev panel... will tidy up the resource panel patch too, tomorrow.22:23
robcresswelltyr_: And then bug you for reviews in a few days time :D22:24
tyr_that's fantastic! Thanks robcresswell22:42
tyr_I'll take a look as soon as you post updated.22:43
*** sdake has quit IRC22:44
*** sdake has joined #openstack-horizon22:44
*** TravT has joined #openstack-horizon22:48
*** ChanServ sets mode: +v TravT22:48
*** yamamoto has joined #openstack-horizon22:51
*** mpavlase has quit IRC22:54
*** alexvictorchan has quit IRC23:01
*** weezS has quit IRC23:02
*** chlong has quit IRC23:03
*** lexplua has quit IRC23:06
*** btully has joined #openstack-horizon23:09
*** btully has quit IRC23:14
*** esp has joined #openstack-horizon23:14
*** erhudy has quit IRC23:22
*** wolverineav has joined #openstack-horizon23:23
*** bigdogstl has joined #openstack-horizon23:25
*** jtriley has joined #openstack-horizon23:28
*** wolverineav has quit IRC23:28
*** wolverineav has joined #openstack-horizon23:28
*** bigdogstl has quit IRC23:29
*** eandersson_ has joined #openstack-horizon23:40
*** eandersson has quit IRC23:43
*** bigdogstl has joined #openstack-horizon23:45
*** bigdogstl has quit IRC23:50
*** ducttape_ has quit IRC23:57
*** ducttape_ has joined #openstack-horizon23:58
*** zhurong has joined #openstack-horizon23:58
*** tyr_ has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!