| *** ducttape_ has quit IRC | 00:00 | |
| *** roxanaghe has quit IRC | 00:00 | |
| *** zhurong has quit IRC | 00:03 | |
| *** yingjun has joined #openstack-horizon | 00:12 | |
| *** jtriley has joined #openstack-horizon | 00:21 | |
| *** tqtran has joined #openstack-horizon | 00:24 | |
| *** tqtran has quit IRC | 00:28 | |
| *** btully has joined #openstack-horizon | 00:32 | |
| *** bpokorny has joined #openstack-horizon | 00:33 | |
| *** btully has quit IRC | 00:36 | |
| *** btully has joined #openstack-horizon | 00:37 | |
| *** aortega has joined #openstack-horizon | 00:51 | |
| *** aortega has quit IRC | 00:52 | |
| *** yingjun has quit IRC | 00:57 | |
| *** yingjun has joined #openstack-horizon | 01:01 | |
| *** ducttape_ has joined #openstack-horizon | 01:01 | |
| *** ducttape_ has quit IRC | 01:05 | |
| *** jtriley has quit IRC | 01:19 | |
| *** jtriley has joined #openstack-horizon | 01:19 | |
| *** roxanaghe has joined #openstack-horizon | 01:25 | |
| *** jtriley has quit IRC | 01:28 | |
| *** jtriley has joined #openstack-horizon | 01:29 | |
| *** roxanaghe has quit IRC | 01:29 | |
| *** zh has joined #openstack-horizon | 01:33 | |
| *** zhihui has joined #openstack-horizon | 01:34 | |
| *** jtriley has quit IRC | 01:41 | |
| *** jtriley has joined #openstack-horizon | 01:42 | |
| *** vishwanathj has joined #openstack-horizon | 01:43 | |
| *** vishwanathj has quit IRC | 01:43 | |
| *** liuyulong has joined #openstack-horizon | 01:45 | |
| liuyulong | amotoki, ping | 01:45 |
|---|---|---|
| *** ducttape_ has joined #openstack-horizon | 01:46 | |
| *** liuyulong has quit IRC | 01:47 | |
| *** liuyulong has joined #openstack-horizon | 01:48 | |
| *** jtriley has quit IRC | 01:55 | |
| *** ducttape_ has quit IRC | 01:56 | |
| *** jtriley has joined #openstack-horizon | 01:56 | |
| *** bpokorny has quit IRC | 01:58 | |
| *** bpokorny has joined #openstack-horizon | 01:59 | |
| *** bpokorny has quit IRC | 02:03 | |
| *** jtriley has quit IRC | 02:04 | |
| *** jtriley has joined #openstack-horizon | 02:05 | |
| *** jamielennox is now known as jamielennox|away | 02:10 | |
| *** jtriley has quit IRC | 02:14 | |
| *** jtriley has joined #openstack-horizon | 02:14 | |
| *** jamielennox|away is now known as jamielennox | 02:30 | |
| *** jtriley has quit IRC | 02:32 | |
| *** ducttape_ has joined #openstack-horizon | 02:32 | |
| *** jtriley has joined #openstack-horizon | 02:33 | |
| *** bpokorny has joined #openstack-horizon | 02:36 | |
| *** btully has quit IRC | 02:45 | |
| *** jtriley has quit IRC | 02:50 | |
| *** jtriley has joined #openstack-horizon | 02:51 | |
| *** amotoki has quit IRC | 02:54 | |
| *** amotoki has joined #openstack-horizon | 02:55 | |
| *** amotoki has quit IRC | 02:56 | |
| *** jtriley has quit IRC | 02:59 | |
| *** zhurong has joined #openstack-horizon | 02:59 | |
| *** jtriley has joined #openstack-horizon | 03:00 | |
| *** ducttape_ has quit IRC | 03:02 | |
| *** btully has joined #openstack-horizon | 03:04 | |
| *** jtriley has quit IRC | 03:09 | |
| *** jtriley has joined #openstack-horizon | 03:09 | |
| openstackgerrit | LIU Yulong proposed openstack/horizon: Restrict user private network cidr input https://review.openstack.org/135877 | 03:10 |
| *** btully has quit IRC | 03:16 | |
| *** jtriley has quit IRC | 03:18 | |
| *** jtriley has joined #openstack-horizon | 03:19 | |
| *** btully has joined #openstack-horizon | 03:19 | |
| *** yamamoto has joined #openstack-horizon | 03:22 | |
| *** yingjun has quit IRC | 03:23 | |
| *** yingjun has joined #openstack-horizon | 03:23 | |
| *** btully has quit IRC | 03:23 | |
| *** yingjun has quit IRC | 03:27 | |
| *** bpokorny has quit IRC | 03:30 | |
| *** bpokorny has joined #openstack-horizon | 03:30 | |
| *** jtriley has quit IRC | 03:32 | |
| *** bpokorny has quit IRC | 03:34 | |
| *** amotoki has joined #openstack-horizon | 03:39 | |
| amotoki | liuyulong: pong | 03:44 |
| liuyulong | amotoki, hi | 03:44 |
| amotoki | liuyulong: i think you pinged me a couple of hours ago | 03:45 |
| liuyulong | amotoki, I noticed that you reviewed the floating IP panel patch again. | 03:45 |
| *** btully has joined #openstack-horizon | 03:46 | |
| liuyulong | amotoki, https://review.openstack.org/#/c/143628/ this patch | 03:46 |
| amotoki | liuyulong: sorry for really late... | 03:46 |
| liuyulong | amotoki, https://review.openstack.org/#/c/143628/41/openstack_dashboard/test/test_data/neutron_data.py, in the patch set 31, I've done that you suggested patch 41. | 03:47 |
| liuyulong | amotoki, But seems you did not like that, then I removed it. | 03:47 |
| liuyulong | amotoki, So which one should I submit again? | 03:48 |
| amotoki | liuyulong: I think you need to add information related to instance_id related stuff between api_q_floating_ips and q_floating_ips. | 03:49 |
| liuyulong | amotoki, and that patch is laying there for a really long time, any news about it can get forward now? | 03:49 |
| amotoki | liuyulong: api_q_floating_ips should match neutron API response and q_floating_ips should match return values from openstack_dashboard.api.neutron. | 03:50 |
| liuyulong | amotoki, agree, So a deepcopy sounds good to you? | 03:51 |
| amotoki | liuyulong: sounds good to me | 03:51 |
| liuyulong | amotoki, and this patch, https://review.openstack.org/#/c/135877/, all done as you suggested. Please review, if you have time. | 03:52 |
| amotoki | liuyulong: I think the only reason is that blueprint is targeted to 'next' a couple of releases ago and it is out-of-rader of most reviewers.... | 03:53 |
| liuyulong | amotoki, also a long stand patch there. | 03:53 |
| amotoki | liuyulong: I think if I can +2 to yours other reviewers are coming. | 03:53 |
| *** kzaitsev_mb has quit IRC | 03:53 | |
| liuyulong | amotoki, great, thank you very much. | 03:54 |
| amotoki | liuyulong: re 135877 (cidr input one), could you add a release note? | 03:54 |
| liuyulong | amotoki, done | 03:54 |
| *** btully has quit IRC | 03:55 | |
| *** yingjun has joined #openstack-horizon | 03:58 | |
| amotoki | liuyulong: you added a relnote to the floating IP panel patch. I am talking about the cidr input patch. | 04:01 |
| amotoki | liuyulong: I dropped a comment to yours. | 04:01 |
| *** amotoki has quit IRC | 04:01 | |
| liuyulong | amotoki, yep | 04:02 |
| *** ducttape_ has joined #openstack-horizon | 04:02 | |
| *** ducttape_ has quit IRC | 04:07 | |
| *** bpokorny has joined #openstack-horizon | 04:08 | |
| *** amotoki has joined #openstack-horizon | 04:09 | |
| *** bpokorny has quit IRC | 04:13 | |
| *** amotoki has quit IRC | 04:13 | |
| *** btully has joined #openstack-horizon | 04:15 | |
| *** yingjun has quit IRC | 04:16 | |
| *** yingjun has joined #openstack-horizon | 04:16 | |
| *** amotoki has joined #openstack-horizon | 04:17 | |
| *** yingjun has quit IRC | 04:21 | |
| *** chlong has joined #openstack-horizon | 04:21 | |
| *** vishwanathj has joined #openstack-horizon | 04:25 | |
| *** tqtran has joined #openstack-horizon | 04:26 | |
| *** btully has quit IRC | 04:26 | |
| *** btully has joined #openstack-horizon | 04:28 | |
| *** jtriley has joined #openstack-horizon | 04:28 | |
| *** tqtran has quit IRC | 04:30 | |
| *** zackf has quit IRC | 04:34 | |
| *** jtriley has quit IRC | 04:37 | |
| *** yingjun has joined #openstack-horizon | 04:37 | |
| *** zhurong has quit IRC | 04:43 | |
| *** zhurong has joined #openstack-horizon | 04:44 | |
| openstackgerrit | LIU Yulong proposed openstack/horizon: Add floating IP panel to admin dashboard https://review.openstack.org/143628 | 04:48 |
| *** roxanaghe has joined #openstack-horizon | 04:49 | |
| *** kzaitsev_mb has joined #openstack-horizon | 04:50 | |
| *** roxanaghe has quit IRC | 04:52 | |
| *** liuyulong has quit IRC | 04:55 | |
| *** liuyulong has joined #openstack-horizon | 04:55 | |
| *** vishwanathj has quit IRC | 04:55 | |
| *** ducttape_ has joined #openstack-horizon | 05:03 | |
| openstackgerrit | LIU Yulong proposed openstack/horizon: Restrict user private network cidr input https://review.openstack.org/135877 | 05:05 |
| *** ducttape_ has quit IRC | 05:08 | |
| *** vishwanathj has joined #openstack-horizon | 05:15 | |
| *** vishwanathj is now known as vishwanathj_zzz | 05:16 | |
| openstackgerrit | LIU Yulong proposed openstack/horizon: Restrict user private network cidr input https://review.openstack.org/135877 | 05:19 |
| *** rcernin has joined #openstack-horizon | 05:25 | |
| *** yingjun has quit IRC | 05:32 | |
| *** yingjun has joined #openstack-horizon | 05:33 | |
| *** yingjun has quit IRC | 05:37 | |
| *** jtriley has joined #openstack-horizon | 05:38 | |
| *** adriant has quit IRC | 05:40 | |
| *** kzaitsev_mb has quit IRC | 05:40 | |
| *** jtriley has quit IRC | 05:47 | |
| *** rkrum has joined #openstack-horizon | 05:47 | |
| *** jtriley has joined #openstack-horizon | 05:48 | |
| *** roxanaghe has joined #openstack-horizon | 05:52 | |
| *** yingjun has joined #openstack-horizon | 05:54 | |
| *** sguduru has joined #openstack-horizon | 05:54 | |
| *** roxanaghe has quit IRC | 05:57 | |
| *** sguduru has quit IRC | 05:58 | |
| *** jtriley has quit IRC | 06:01 | |
| *** agireud has quit IRC | 06:01 | |
| *** jtriley has joined #openstack-horizon | 06:01 | |
| *** ducttape_ has joined #openstack-horizon | 06:04 | |
| *** ducttape_ has quit IRC | 06:09 | |
| *** jtriley has quit IRC | 06:10 | |
| *** agireud has joined #openstack-horizon | 06:10 | |
| *** jtriley has joined #openstack-horizon | 06:11 | |
| *** jmccrory is now known as jmccrory_away | 06:12 | |
| *** wolverineav has quit IRC | 06:14 | |
| *** wolverineav has joined #openstack-horizon | 06:14 | |
| *** zhurong has quit IRC | 06:15 | |
| *** zhurong has joined #openstack-horizon | 06:16 | |
| *** yamamoto has quit IRC | 06:18 | |
| *** jtriley has quit IRC | 06:19 | |
| *** jtriley has joined #openstack-horizon | 06:20 | |
| *** david-lyle has joined #openstack-horizon | 06:36 | |
| *** ChanServ sets mode: +o david-lyle | 06:36 | |
| *** kzaitsev_mb has joined #openstack-horizon | 06:36 | |
| *** pcaruana has joined #openstack-horizon | 06:36 | |
| *** david-lyle_ has quit IRC | 06:39 | |
| *** kzaitsev_mb has quit IRC | 06:41 | |
| *** jtriley has quit IRC | 06:42 | |
| *** jtriley has joined #openstack-horizon | 06:43 | |
| *** javeriak has joined #openstack-horizon | 06:43 | |
| *** belmoreira has joined #openstack-horizon | 06:48 | |
| *** jtriley has quit IRC | 06:51 | |
| *** yamamoto has joined #openstack-horizon | 06:59 | |
| *** javeriak has quit IRC | 07:00 | |
| *** btully has quit IRC | 07:02 | |
| *** ducttape_ has joined #openstack-horizon | 07:05 | |
| *** rkrum has quit IRC | 07:07 | |
| *** chlong has quit IRC | 07:08 | |
| *** ducttape_ has quit IRC | 07:09 | |
| *** btully has joined #openstack-horizon | 07:11 | |
| *** jpich has joined #openstack-horizon | 07:21 | |
| *** btully has quit IRC | 07:24 | |
| *** chlong has joined #openstack-horizon | 07:25 | |
| *** amotoki_ has joined #openstack-horizon | 07:32 | |
| *** amotoki has quit IRC | 07:35 | |
| *** kzaitsev_mb has joined #openstack-horizon | 07:37 | |
| *** javeriak has joined #openstack-horizon | 07:41 | |
| *** roxanaghe has joined #openstack-horizon | 07:41 | |
| *** v12aml has joined #openstack-horizon | 07:42 | |
| *** kzaitsev_mb has quit IRC | 07:42 | |
| *** roxanaghe has quit IRC | 07:45 | |
| *** jtriley has joined #openstack-horizon | 07:53 | |
| *** Ephur has quit IRC | 07:57 | |
| *** jtriley has quit IRC | 07:57 | |
| *** mpavlase has joined #openstack-horizon | 08:01 | |
| *** sdake has joined #openstack-horizon | 08:01 | |
| *** ducttape_ has joined #openstack-horizon | 08:06 | |
| *** chlong has quit IRC | 08:07 | |
| *** ducttape_ has quit IRC | 08:11 | |
| *** sdake has quit IRC | 08:15 | |
| *** btully has joined #openstack-horizon | 08:16 | |
| *** kzaitsev_mb has joined #openstack-horizon | 08:16 | |
| *** btully has quit IRC | 08:27 | |
| *** tqtran has joined #openstack-horizon | 08:27 | |
| *** javeriak_ has joined #openstack-horizon | 08:31 | |
| *** tqtran has quit IRC | 08:31 | |
| *** javeriak has quit IRC | 08:32 | |
| *** javeriak has joined #openstack-horizon | 08:32 | |
| *** sdake has joined #openstack-horizon | 08:35 | |
| *** javeriak_ has quit IRC | 08:36 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Zanata https://review.openstack.org/355371 | 08:37 |
| *** btully has joined #openstack-horizon | 08:42 | |
| *** sdake has quit IRC | 08:43 | |
| *** javeriak has quit IRC | 08:44 | |
| *** javeriak has joined #openstack-horizon | 08:44 | |
| *** btully has quit IRC | 08:46 | |
| robcresswell | Good morning | 08:50 |
| *** jtriley has joined #openstack-horizon | 08:53 | |
| pkarikh | robcresswell, morning :) | 08:53 |
| *** mvk has joined #openstack-horizon | 08:56 | |
| *** jtriley has quit IRC | 08:59 | |
| robcresswell | pkarikh: o/ | 09:00 |
| *** kzaitsev_mb has quit IRC | 09:02 | |
| *** kzaitsev_mb has joined #openstack-horizon | 09:06 | |
| *** ducttape_ has joined #openstack-horizon | 09:07 | |
| *** kzaitsev_mb has quit IRC | 09:11 | |
| *** ducttape_ has quit IRC | 09:11 | |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Remove additional response.render() for tabs https://review.openstack.org/333345 | 09:29 |
| *** roxanaghe has joined #openstack-horizon | 09:29 | |
| *** roxanaghe has quit IRC | 09:33 | |
| openstackgerrit | LIU Yulong proposed openstack/horizon: Add floating IP panel to admin dashboard https://review.openstack.org/143628 | 09:35 |
| liuyulong | amotoki, hi, https://review.openstack.org/#/c/143628/, this patch i've updated, please take a look. | 09:43 |
| liuyulong | amotoki_, ^^ | 09:44 |
| *** sdake has joined #openstack-horizon | 09:46 | |
| *** yingjun has quit IRC | 09:46 | |
| *** yamamoto has quit IRC | 09:50 | |
| *** btully has joined #openstack-horizon | 09:51 | |
| robcresswell | TravT: FYI, this was the patch I wrote for ironic_ui to use the Horizon test settings: https://review.openstack.org/#/c/354785/ | 09:52 |
| openstackgerrit | Merged openstack/horizon: Add Try/Exception block to Network Forms https://review.openstack.org/325671 | 09:52 |
| *** jtriley has joined #openstack-horizon | 09:54 | |
| *** tosky has joined #openstack-horizon | 09:55 | |
| *** btully has quit IRC | 09:56 | |
| *** jtriley has quit IRC | 09:59 | |
| *** btully has joined #openstack-horizon | 10:01 | |
| *** btully has quit IRC | 10:06 | |
| *** ducttape_ has joined #openstack-horizon | 10:08 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/horizon: [WIP] Testing latest u-c https://review.openstack.org/303429 | 10:10 |
| *** ducttape_ has quit IRC | 10:12 | |
| *** kzaitsev_mb has joined #openstack-horizon | 10:18 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Horizon Spinner/Loader should inherit from theme https://review.openstack.org/313685 | 10:22 |
| *** asettle has joined #openstack-horizon | 10:25 | |
| *** yamamoto_ has joined #openstack-horizon | 10:32 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Re-work static_settings to clean up https://review.openstack.org/204838 | 10:34 |
| *** javeriak has quit IRC | 10:36 | |
| *** btully has joined #openstack-horizon | 10:46 | |
| *** btully has quit IRC | 10:50 | |
| *** btully has joined #openstack-horizon | 10:52 | |
| zh | this is my patch: Put py34 first in the env order of tox please take a look,thank you https://review.openstack.org/#/c/353833/ | 10:52 |
| *** jtriley has joined #openstack-horizon | 10:55 | |
| *** javeriak has joined #openstack-horizon | 11:00 | |
| *** jtriley has quit IRC | 11:00 | |
| *** btully has quit IRC | 11:04 | |
| *** zhurong has quit IRC | 11:05 | |
| *** ducttape_ has joined #openstack-horizon | 11:08 | |
| *** btully has joined #openstack-horizon | 11:12 | |
| *** ducttape_ has quit IRC | 11:13 | |
| *** roxanaghe has joined #openstack-horizon | 11:17 | |
| *** roxanaghe has quit IRC | 11:22 | |
| *** btully has quit IRC | 11:25 | |
| *** amotoki_ has quit IRC | 11:31 | |
| *** amotoki has joined #openstack-horizon | 11:34 | |
| *** asettle has quit IRC | 11:36 | |
| *** amotoki has quit IRC | 11:37 | |
| *** rodrigods has quit IRC | 11:38 | |
| *** rodrigods has joined #openstack-horizon | 11:38 | |
| robcresswell | zh: Couldn't recreate the issue | 11:39 |
| *** aortega has joined #openstack-horizon | 11:48 | |
| *** amotoki has joined #openstack-horizon | 11:48 | |
| *** asettle has joined #openstack-horizon | 11:50 | |
| *** btully has joined #openstack-horizon | 11:55 | |
| *** jtriley has joined #openstack-horizon | 11:55 | |
| *** jtriley has quit IRC | 12:00 | |
| *** sdake has quit IRC | 12:02 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Horizon Spinner/Loader should inherit from theme https://review.openstack.org/313685 | 12:04 |
| *** yamamoto_ has quit IRC | 12:06 | |
| *** sdake has joined #openstack-horizon | 12:06 | |
| *** btully has quit IRC | 12:07 | |
| *** yamamoto has joined #openstack-horizon | 12:07 | |
| *** yamamoto has quit IRC | 12:07 | |
| *** yamamoto has joined #openstack-horizon | 12:07 | |
| *** ducttape_ has joined #openstack-horizon | 12:09 | |
| *** asettle has quit IRC | 12:11 | |
| *** btully has joined #openstack-horizon | 12:12 | |
| *** ducttape_ has quit IRC | 12:12 | |
| *** ducttape_ has joined #openstack-horizon | 12:13 | |
| *** amotoki has quit IRC | 12:16 | |
| *** roxanaghe has joined #openstack-horizon | 12:18 | |
| *** amotoki has joined #openstack-horizon | 12:23 | |
| *** roxanaghe has quit IRC | 12:23 | |
| *** btully has quit IRC | 12:25 | |
| *** amotoki has quit IRC | 12:28 | |
| *** yingjun has joined #openstack-horizon | 12:29 | |
| *** mtanino has joined #openstack-horizon | 12:35 | |
| *** ducttape_ has quit IRC | 12:35 | |
| *** sdake has quit IRC | 12:38 | |
| *** yingjun has quit IRC | 12:38 | |
| *** yingjun has joined #openstack-horizon | 12:39 | |
| *** zhihui has quit IRC | 12:41 | |
| *** zh has quit IRC | 12:41 | |
| *** yingjun_ has joined #openstack-horizon | 12:42 | |
| *** yingjun has quit IRC | 12:42 | |
| *** yingjun has joined #openstack-horizon | 12:42 | |
| *** kzaitsev_mb has quit IRC | 12:43 | |
| *** julim has joined #openstack-horizon | 12:44 | |
| *** btully has joined #openstack-horizon | 12:45 | |
| *** yingjun_ has quit IRC | 12:47 | |
| *** rkrum has joined #openstack-horizon | 12:47 | |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Provide the bones of profiler: api, models and middleware https://review.openstack.org/273085 | 12:50 |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Wrap api calls with tracing decorators https://review.openstack.org/339675 | 12:50 |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Add the Profiler panel to the Developer dashboard https://review.openstack.org/303514 | 12:50 |
| *** pauloewerton has joined #openstack-horizon | 12:50 | |
| *** btully has quit IRC | 12:54 | |
| *** ppiela has joined #openstack-horizon | 12:55 | |
| *** aortega has quit IRC | 12:57 | |
| *** aortega has joined #openstack-horizon | 12:59 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Zanata https://review.openstack.org/355371 | 13:00 |
| *** btully has joined #openstack-horizon | 13:01 | |
| *** julim has quit IRC | 13:01 | |
| *** kzaitsev_mb has joined #openstack-horizon | 13:01 | |
| *** julim has joined #openstack-horizon | 13:05 | |
| *** mrunge_ has joined #openstack-horizon | 13:07 | |
| *** lblanchard has joined #openstack-horizon | 13:10 | |
| *** rkrum has quit IRC | 13:10 | |
| *** rkrum has joined #openstack-horizon | 13:11 | |
| tsufiev | TravT, o/ | 13:12 |
| tsufiev | TravT, seems we're pretty close to finish work on GlanceV2 support, the last remaining issue (according to integration tests) is editing metadata on images | 13:13 |
| robcresswell | Yeah, I was just reviewing that patch | 13:13 |
| *** jtriley has joined #openstack-horizon | 13:13 | |
| tsufiev | what prevents test from passing is that with V2 more properties inside image are considered to be metadata, so their empty values prevent metadata widget from being submittable | 13:14 |
| tsufiev | robcresswell, o/ too :) | 13:14 |
| tsufiev | I'm not sure how to best approach the issue with metadata | 13:14 |
| *** ducttape_ has joined #openstack-horizon | 13:14 | |
| robcresswell | I haven't looked into it any further | 13:14 |
| robcresswell | was going to ask TravT for his wisdoms | 13:14 |
| tsufiev | me too :) | 13:15 |
| robcresswell | tsufiev: Btw, if you wanted an example of importable test, settings, I patched ironic ui: https://review.openstack.org/#/c/354785/ | 13:15 |
| robcresswell | test settings* ignore that comma | 13:15 |
| robcresswell | tsufiev: Since I saw you commented on that issue :p | 13:15 |
| *** rkrum has quit IRC | 13:16 | |
| tsufiev | robcresswell, well, my point was that lazy plugins won't have the luxury of being lazy anymore :) | 13:16 |
| tsufiev | which I don't think is a bad thing on its own, even if they gonna blame us for that | 13:16 |
| robcresswell | tsufiev: Well, its actually "lazier" to just import than maintain your own :p | 13:17 |
| *** peristeri has joined #openstack-horizon | 13:17 | |
| *** asettle has joined #openstack-horizon | 13:17 | |
| tsufiev | robcresswell, there are at least 2 kinds of laziness: too lazy to adopt new ways and too lazy to do too much work | 13:17 |
| robcresswell | very true | 13:18 |
| tsufiev | I prefer the second kind | 13:18 |
| *** javeriak has quit IRC | 13:18 | |
| robcresswell | tsufiev: The downside to using get() everywhere is that the default is then defined at *least* twice. | 13:18 |
| robcresswell | This way, a default setting is defined once only. If anyone has any difficulty they can just copy that test settings patch | 13:19 |
| tsufiev | robcresswell, yes, and it's not very pythonic as well - if we consider 'defensive programming' to be not pythonic approach | 13:19 |
| *** javeriak has joined #openstack-horizon | 13:19 | |
| *** amotoki has joined #openstack-horizon | 13:19 | |
| robcresswell | I think most plugins are using the import approach now anyway | 13:20 |
| tsufiev | if they don't, we'll know that soon :) | 13:20 |
| robcresswell | ha | 13:20 |
| robcresswell | yup :) | 13:21 |
| tsufiev | robcresswell, I'd like to switch topic... What's the meaning of 'contrib/' folder in Horizon now? | 13:22 |
| tsufiev | I mean, is it required to present in openstack_dashboard codebase? | 13:22 |
| tsufiev | consequently, should openstack_dashboard work fine if contrib/ is not present at all? | 13:23 |
| *** yingjun has quit IRC | 13:23 | |
| *** yingjun has joined #openstack-horizon | 13:23 | |
| *** javeriak has quit IRC | 13:24 | |
| tsufiev | osprofiler work required us to add a bunch of decorators to openstack_dashboard.api wrappers, I'm wondering if it's needed to add some conditions to make these decorators independent from contrib/developer/profiler content | 13:24 |
| jlopezgu | morning o/ | 13:25 |
| robcresswell | Originally it was just there as content thats not really part of core horizon, david didnt want me putting the dev dashboard in as a panel | 13:25 |
| tsufiev | jlopezgu, o/ | 13:25 |
| robcresswell | jlopezgu: o/ | 13:25 |
| jlopezgu | o/ | 13:25 |
| tsufiev | david-lyle, what do think of ^^^ ? | 13:26 |
| *** yingjun_ has joined #openstack-horizon | 13:27 | |
| *** matt-borland has joined #openstack-horizon | 13:27 | |
| *** yingjun__ has joined #openstack-horizon | 13:28 | |
| *** yingjun has quit IRC | 13:28 | |
| matt-borland | morning robcresswell! Wow, I just tried to autocomplete 'morning' | 13:29 |
| *** belmoreira has quit IRC | 13:31 | |
| *** yingjun_ has quit IRC | 13:32 | |
| *** ducttape_ has quit IRC | 13:33 | |
| *** belmoreira has joined #openstack-horizon | 13:50 | |
| *** yingjun__ has quit IRC | 13:51 | |
| *** yingjun has joined #openstack-horizon | 13:51 | |
| *** yamamoto has quit IRC | 13:52 | |
| *** chlong has joined #openstack-horizon | 13:52 | |
| *** yamamoto has joined #openstack-horizon | 13:52 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Flavors panel can switch to Angular https://review.openstack.org/343917 | 13:54 |
| *** yingjun has quit IRC | 13:54 | |
| *** aortega has quit IRC | 13:54 | |
| *** yingjun has joined #openstack-horizon | 13:54 | |
| robcresswell | matt-borland: Ha! I genuinely do that almost every time | 13:54 |
| matt-borland | lol :) | 13:55 |
| robcresswell | mor - *hits tab* - d'oh | 13:55 |
| matt-borland | yep | 13:55 |
| robcresswell | matt-borland: I'd quite like dave to see the settings patch and get his thoughts if there is time | 13:56 |
| matt-borland | better ask sooner rather than later | 13:57 |
| robcresswell | Yeah I've pinged | 13:57 |
| *** yamamoto has quit IRC | 13:57 | |
| matt-borland | I'm pretty sure there's time. Why would there not be? | 13:57 |
| robcresswell | 10 days till FF :) | 13:57 |
| matt-borland | So do *you* think there's time? | 13:58 |
| matt-borland | We've shown the switch works. | 13:58 |
| matt-borland | I guess I'm trying to understand if you want David's approval of the switch mechanism, or of making NG Images default. | 13:59 |
| robcresswell | Oh, I just meant the settings change | 14:00 |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Enable Angular Flavors Panel https://review.openstack.org/344456 | 14:01 |
| *** aortega has joined #openstack-horizon | 14:01 | |
| robcresswell | As in, he didn't like the previous design, so would like his input on the patch, thats all | 14:01 |
| robcresswell | Seems pointless to register a complaint and not let that person review.. | 14:01 |
| matt-borland | exactly | 14:01 |
| *** jtriley_ has joined #openstack-horizon | 14:02 | |
| matt-borland | I sounded like there was a time component to your question, that was the confusing part. | 14:02 |
| robcresswell | Well, I don't really want to be carrying this work into RC | 14:02 |
| matt-borland | If it's the test switch that keeps us from going forward, that will create ire. Lots of ire. Let's just remain focused on positive development. | 14:03 |
| robcresswell | Right, thats literally what im saying | 14:03 |
| matt-borland | sounds good | 14:04 |
| robcresswell | So we'll give it a day or so for a response otherwise someone else can just approve it and then we can approve the switch | 14:04 |
| matt-borland | thanks for shepherding this through. | 14:04 |
| *** ducttape_ has joined #openstack-horizon | 14:04 | |
| *** jtriley has quit IRC | 14:04 | |
| *** sjmc7 has joined #openstack-horizon | 14:05 | |
| robcresswell | np | 14:06 |
| *** roxanaghe has joined #openstack-horizon | 14:06 | |
| *** uxdanielle has joined #openstack-horizon | 14:08 | |
| *** mtanino has quit IRC | 14:09 | |
| *** yamamoto has joined #openstack-horizon | 14:10 | |
| *** roxanaghe has quit IRC | 14:10 | |
| *** sdake has joined #openstack-horizon | 14:10 | |
| *** jtriley_ has quit IRC | 14:18 | |
| lcastell | o/ morning | 14:18 |
| openstackgerrit | Steve McLellan proposed openstack/horizon: Swift account quota support https://review.openstack.org/345071 | 14:19 |
| *** ezpz has joined #openstack-horizon | 14:19 | |
| *** jtriley has joined #openstack-horizon | 14:21 | |
| *** jtomasek is now known as jtomasek|biab | 14:23 | |
| *** ametts has joined #openstack-horizon | 14:26 | |
| *** tqtran has joined #openstack-horizon | 14:30 | |
| *** pcaruana has quit IRC | 14:30 | |
| robcresswell | matt-borland: The final result of https://review.openstack.org/#/c/339164 is really clean | 14:33 |
| *** tqtran has quit IRC | 14:34 | |
| *** zhurong has joined #openstack-horizon | 14:37 | |
| *** zhurong has quit IRC | 14:39 | |
| *** vishwanathj_zzz is now known as vishwanathj | 14:40 | |
| *** weezS has joined #openstack-horizon | 14:43 | |
| *** ducttape_ has quit IRC | 14:44 | |
| *** kzaitsev_mb has quit IRC | 14:46 | |
| matt-borland | absolutely robcresswell | 14:48 |
| *** sdake has quit IRC | 14:48 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Enable Angular Flavors Panel https://review.openstack.org/344456 | 14:49 |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Add the Profiler panel to the Developer dashboard https://review.openstack.org/303514 | 14:57 |
| *** rcernin has quit IRC | 15:06 | |
| *** hurgleburgler has joined #openstack-horizon | 15:07 | |
| *** ChanServ sets mode: +v hurgleburgler | 15:07 | |
| *** mvk has quit IRC | 15:10 | |
| *** yamamoto has quit IRC | 15:14 | |
| *** yamamoto has joined #openstack-horizon | 15:14 | |
| *** zackf has joined #openstack-horizon | 15:14 | |
| *** kzaitsev_mb has joined #openstack-horizon | 15:15 | |
| *** javeriak has joined #openstack-horizon | 15:18 | |
| *** yamamoto has quit IRC | 15:20 | |
| *** jtomasek|biab is now known as jtomasek | 15:20 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Flavors panel can switch to Angular https://review.openstack.org/343917 | 15:28 |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Wrap api calls with tracing decorators https://review.openstack.org/339675 | 15:31 |
| *** edtubill has joined #openstack-horizon | 15:33 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Enable Angular Flavors Panel https://review.openstack.org/344456 | 15:33 |
| ediardo | o/ | 15:36 |
| robcresswell | o/ ediardo | 15:37 |
| *** tyr has joined #openstack-horizon | 15:38 | |
| *** belmoreira has quit IRC | 15:38 | |
| *** revon has joined #openstack-horizon | 15:38 | |
| *** edtubill has quit IRC | 15:40 | |
| robcresswell | ediardo, jlopezgu: I think there's a few reviews on the server side patches | 15:40 |
| robcresswell | Mine are mostly nits | 15:40 |
| *** edtubill has joined #openstack-horizon | 15:40 | |
| robcresswell | Please ping if you have time to address and I will review again | 15:40 |
| lcastell | don't forget about the swift one: https://review.openstack.org/#/c/327224/ :P | 15:41 |
| ediardo | Ok, thank you robcreswell | 15:42 |
| *** bpokorny has joined #openstack-horizon | 15:43 | |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Provide the bones of profiler: api, models and middleware https://review.openstack.org/273085 | 15:44 |
| *** asettle has quit IRC | 15:46 | |
| *** asettle has joined #openstack-horizon | 15:47 | |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Add the Profiler panel to the Developer dashboard https://review.openstack.org/303514 | 15:48 |
| *** asettle has quit IRC | 15:53 | |
| *** asettle has joined #openstack-horizon | 15:54 | |
| *** bpokorny has quit IRC | 15:55 | |
| *** mtanino has joined #openstack-horizon | 15:57 | |
| *** jpich has quit IRC | 16:00 | |
| *** bpokorny has joined #openstack-horizon | 16:03 | |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Remove additional response.render() for tabs https://review.openstack.org/333345 | 16:06 |
| *** tqtran has joined #openstack-horizon | 16:08 | |
| *** jtomasek is now known as jtomasek|afk | 16:10 | |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Provide the bones of profiler: api and middleware https://review.openstack.org/273085 | 16:11 |
| *** tyr has quit IRC | 16:16 | |
| *** ducttape_ has joined #openstack-horizon | 16:18 | |
| *** Ephur has joined #openstack-horizon | 16:18 | |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Add the Profiler panel to the Developer dashboard https://review.openstack.org/303514 | 16:18 |
| *** yingjun has quit IRC | 16:23 | |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Wrap api calls with tracing decorators https://review.openstack.org/339675 | 16:26 |
| robcresswell | lcastell: Yup, I know :) | 16:27 |
| lcastell | thanks robcresswell :) | 16:27 |
| *** ametts_ has joined #openstack-horizon | 16:28 | |
| *** ametts has quit IRC | 16:30 | |
| *** tqtran has quit IRC | 16:31 | |
| *** tosky has quit IRC | 16:37 | |
| *** tqtran has joined #openstack-horizon | 16:40 | |
| *** tqtran has quit IRC | 16:44 | |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/manila-ui: Additional fields for Create/Update Share Type forms https://review.openstack.org/338504 | 16:46 |
| *** ctayal has joined #openstack-horizon | 16:47 | |
| ctayal | How to check if neutron service is running in openstack horizon code ? | 16:47 |
| *** esp has joined #openstack-horizon | 16:47 | |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Remove additional response.render() for tabs https://review.openstack.org/333345 | 16:48 |
| *** mpavlase has quit IRC | 16:49 | |
| *** Marcellin_ has joined #openstack-horizon | 16:51 | |
| *** yingjun has joined #openstack-horizon | 16:51 | |
| *** mpavlase has joined #openstack-horizon | 16:53 | |
| *** mpavlase has quit IRC | 16:53 | |
| *** yingjun has quit IRC | 16:57 | |
| *** yingjun has joined #openstack-horizon | 16:57 | |
| *** weezS has quit IRC | 16:58 | |
| *** sdake has joined #openstack-horizon | 17:00 | |
| tsufiev | ctayal, send a request to neutron using python-neutronclient ;)? | 17:01 |
| *** yingjun has quit IRC | 17:01 | |
| lcastell | hey tsufiev :), thanks for de review on the inline edit patch. Here is some code I wrote about the snippet you mention in the comments: http://paste.openstack.org/show/557597/ | 17:03 |
| tsufiev | lcastell, hey! | 17:04 |
| tsufiev | lcastell, wow, this thing is starting to look big :) | 17:05 |
| lcastell | I think that if we implement something like this for deprecation it should be reusable, and not tied to each class we want to deprecate | 17:05 |
| lcastell | that's why I'm not sure about that code :) :P | 17:05 |
| tsufiev | sure, but if we want to go that far, perhaps a better option would be to propose a patch into oslo.versionutils | 17:06 |
| tsufiev | I'm not sure if every component should invent such a common feature on its own | 17:06 |
| *** esp has quit IRC | 17:06 | |
| tsufiev | of course, other cores' opinions would be valuable here too, lcastell | 17:07 |
| *** Ephur has quit IRC | 17:07 | |
| *** sguduru has joined #openstack-horizon | 17:08 | |
| *** harlowja has joined #openstack-horizon | 17:08 | |
| *** kzaitsev_mb has quit IRC | 17:08 | |
| *** btully has quit IRC | 17:10 | |
| *** btully has joined #openstack-horizon | 17:13 | |
| lcastell | got it, Thanks tsufiev! | 17:13 |
| *** hurgleburgler has quit IRC | 17:13 | |
| *** esp has joined #openstack-horizon | 17:13 | |
| *** hurgleburgler has joined #openstack-horizon | 17:13 | |
| *** ChanServ sets mode: +v hurgleburgler | 17:13 | |
| tsufiev | lcastell, np. You better post that link somewhere in CR to not lose it | 17:14 |
| *** weezS has joined #openstack-horizon | 17:14 | |
| ctayal | Hi tsufiev, is there any API to check if neutron is running in api.neutron.py ? | 17:15 |
| lcastell | yup :) | 17:15 |
| *** asettle has quit IRC | 17:15 | |
| tsufiev | ctayal, see https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/network.py#L29 | 17:16 |
| openstackgerrit | Daniel Castellanos proposed openstack/horizon: Removed inline_edit functionality for tables https://review.openstack.org/343861 | 17:17 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Syntactic sugar for setting multiple properties in registry https://review.openstack.org/342439 | 17:17 |
| ctayal | cool, Thanks tsufiev | 17:18 |
| *** Ephur has joined #openstack-horizon | 17:19 | |
| *** Ephur has quit IRC | 17:20 | |
| *** tqtran has joined #openstack-horizon | 17:21 | |
| *** weezS has quit IRC | 17:21 | |
| tsufiev | hurgleburgler, I've fixed integration tests in your spinner patch \o/ | 17:23 |
| tsufiev | who would have thought that one single css class is all that takes to make tests passing :) | 17:24 |
| hurgleburgler | whoa! | 17:24 |
| hurgleburgler | which class? | 17:24 |
| *** btully has quit IRC | 17:24 | |
| tsufiev | 'fade' | 17:24 |
| tsufiev | see my comments inline | 17:25 |
| tsufiev | I don't fully understand the mechanics of this modals behavior, but it worked for me and for gate | 17:25 |
| *** asettle has joined #openstack-horizon | 17:26 | |
| *** kzaitsev_mb has joined #openstack-horizon | 17:26 | |
| *** tqtran has quit IRC | 17:29 | |
| *** tqtran has joined #openstack-horizon | 17:32 | |
| *** btully has joined #openstack-horizon | 17:33 | |
| hurgleburgler | tsufiev: thanks for looking into that :) | 17:35 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Cleanup setProperties in image module https://review.openstack.org/355579 | 17:36 |
| *** rcernin has joined #openstack-horizon | 17:37 | |
| *** tyr has joined #openstack-horizon | 17:38 | |
| *** Ephur has joined #openstack-horizon | 17:39 | |
| *** edtubill has quit IRC | 17:40 | |
| *** tyr has quit IRC | 17:40 | |
| *** TravT has quit IRC | 17:40 | |
| stevemar | robcresswell: poke | 17:45 |
| stevemar | robcresswell: can you get someone to look at https://bugs.launchpad.net/keystone/+bug/1588190 | 17:45 |
| openstack | Launchpad bug 1588190 in OpenStack Identity (keystone) "policy.v3cloudsample.json broken in mitaka" [High,Triaged] | 17:45 |
| stevemar | we think it may be horizon related | 17:46 |
| *** snow_ has joined #openstack-horizon | 17:46 | |
| *** snow_ has left #openstack-horizon | 17:49 | |
| *** btully has quit IRC | 17:51 | |
| *** btully has joined #openstack-horizon | 17:51 | |
| ctayal | tsufiev: after I kill the neutron server, " neutron_enabled = base.is_service_enabled(request, 'network')" still return true | 17:53 |
| *** peristeri has quit IRC | 17:54 | |
| *** kzaitsev_mb has quit IRC | 17:58 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Documentation for translation in horizon https://review.openstack.org/328008 | 18:00 |
| *** mpavlase has joined #openstack-horizon | 18:03 | |
| bpokorny | stevemar: I've seen that behavior before, and I duped the bug to this existing one: https://bugs.launchpad.net/oslo.policy/+bug/1547684 | 18:03 |
| openstack | Launchpad bug 1547684 in oslo.policy "Attribute error on Token object when using domain scoped token" [Undecided,New] | 18:03 |
| stevemar | bpokorny: ah excellent (for me anyway) | 18:03 |
| bpokorny | stevemar: Yeah, as far as I can tell, it's a problem in oslo.policy. | 18:04 |
| stevemar | dammit | 18:04 |
| *** Ephur has quit IRC | 18:04 | |
| *** btully has quit IRC | 18:05 | |
| stevemar | bpokorny: https://review.openstack.org/#/c/165908/ seems like a sledgehammer for a pushpin | 18:05 |
| bpokorny | :( | 18:05 |
| *** Ephur has joined #openstack-horizon | 18:06 | |
| bpokorny | I agree. I think that one will hide too many policy failures. | 18:07 |
| *** Ephur has quit IRC | 18:08 | |
| *** Ephur has joined #openstack-horizon | 18:08 | |
| *** wolverineav has quit IRC | 18:10 | |
| *** sguduru has quit IRC | 18:11 | |
| *** wolverineav has joined #openstack-horizon | 18:11 | |
| *** snow_ has joined #openstack-horizon | 18:12 | |
| snow_ | I ask here as nobody said anything for 13 mins in "openstack" | 18:12 |
| snow_ | I deployed horizon-9.1.0 from tar file, and I have an issue with static data, css is only in static/dashboard and img is only in openstack_dashboard/static/dashboard/ when I copy those everything works. Is this a bug or did I overlook a configuration item? | 18:12 |
| *** btully has joined #openstack-horizon | 18:14 | |
| *** wolverineav has quit IRC | 18:16 | |
| ctayal | how to check neutron-server is "running" in horizon code | 18:18 |
| *** sjmc7 has quit IRC | 18:19 | |
| stevemar | bpokorny: commented | 18:19 |
| *** weezS has joined #openstack-horizon | 18:20 | |
| bpokorny | Thanks, stevemar. Just checking - when you addressed Brant in that post, did you mean Brant Knudsen, or me (Brad)? | 18:22 |
| bpokorny | I'm not sure Brant is subscribed to the bug. | 18:23 |
| *** sjmc7 has joined #openstack-horizon | 18:23 | |
| bpokorny | Ah, I see. You commented in the review as well. | 18:23 |
| bpokorny | Which Brant is on. | 18:24 |
| *** Ephur has quit IRC | 18:25 | |
| *** Ephur has joined #openstack-horizon | 18:26 | |
| ctayal | valar morghulis, is there a way to check is neutron-server is "running" in horizon code | 18:30 |
| *** wolverineav has joined #openstack-horizon | 18:31 | |
| stevemar | bpokorny: ha, i meant bknudson | 18:33 |
| bpokorny | stevemar: ok, just making sure :) | 18:34 |
| *** wolverineav has quit IRC | 18:38 | |
| *** wolverineav has joined #openstack-horizon | 18:38 | |
| *** tqtran has quit IRC | 18:39 | |
| *** asettle has quit IRC | 18:41 | |
| *** rcernin has quit IRC | 18:42 | |
| *** snow_ has quit IRC | 18:44 | |
| ctayal | is there a way to check is neutron-server is "running" in horizon code | 18:47 |
| *** tqtran has joined #openstack-horizon | 18:49 | |
| ctayal | Can someone please answer my question | 18:51 |
| ctayal | I am stuck | 18:51 |
| *** javeriak has quit IRC | 18:52 | |
| bpokorny | ctayal: Do you mean you want to add code to Horizon to check whether the neutron-server process is running? | 18:53 |
| *** javeriak has joined #openstack-horizon | 18:54 | |
| bpokorny | There's no code in Horizon that currently checks whether the process is running. Horizon checks whether the neutron endpoint is in the Keystone catalog, and then calls the neutron api if it's in the catalog. | 18:55 |
| ctayal | bpokorny: no, I want to know if server is running in horizon plugin | 18:55 |
| ctayal | even if the server is not running, enpoint will always be present in the keystone catalog | 18:55 |
| ctayal | when API is called it return connection error | 18:56 |
| bpokorny | ctayal: I think the only thing you could do is call the API to see if it returns an error. | 18:57 |
| *** pt_15 has joined #openstack-horizon | 18:57 | |
| ctayal | Thanks bpokorny :) | 18:57 |
| bpokorny | ctayal: No problem! | 18:57 |
| *** itisha has joined #openstack-horizon | 18:58 | |
| *** tqtran has quit IRC | 18:59 | |
| *** tyr has joined #openstack-horizon | 19:02 | |
| *** tyr has quit IRC | 19:03 | |
| mrunge | ctayal, the issue with this approach is: is the api just slow, or did the endpoint stop answering? | 19:05 |
| mrunge | btw. clients don't support timeouts yet | 19:05 |
| *** fifieldt has quit IRC | 19:07 | |
| *** edtubill has joined #openstack-horizon | 19:08 | |
| *** TravT has joined #openstack-horizon | 19:09 | |
| *** ChanServ sets mode: +v TravT | 19:09 | |
| *** tqtran has joined #openstack-horizon | 19:12 | |
| *** ametts_ has quit IRC | 19:13 | |
| ctayal | mrunge: I extended workflow from project/networks, but I just want to check if neutron is enabled before calling my api's, since there is no way to check if neutron-server is running, I have to call a dummy api to check that | 19:15 |
| ctayal | which is a very poor approach, but there is no way out | 19:15 |
| *** TravT_ has joined #openstack-horizon | 19:15 | |
| *** ChanServ sets mode: +v TravT_ | 19:15 | |
| *** asettle has joined #openstack-horizon | 19:16 | |
| *** ametts_ has joined #openstack-horizon | 19:18 | |
| *** ametts_ has quit IRC | 19:18 | |
| *** fifieldt has joined #openstack-horizon | 19:18 | |
| *** asettle has quit IRC | 19:19 | |
| mrunge | agreed. | 19:19 |
| *** ametts has joined #openstack-horizon | 19:19 | |
| *** TravT has quit IRC | 19:19 | |
| mrunge | horizon currently relies on available services listed in keystone catalog | 19:19 |
| mrunge | ctayal, if api endpoints are not available, I'd blame the endpoint itself (or the system deployer) | 19:20 |
| ctayal | yes, it just check if service are enabled in keystone catalog, but does not check if it is running | 19:20 |
| mrunge | correct | 19:20 |
| ctayal | even when neutron server is not running endpoints will still be available in keystone catalog | 19:21 |
| mrunge | but in my experience, that hasn't been an issue any more for quite a while noe | 19:21 |
| mrunge | s/noe/now/ | 19:21 |
| mrunge | not sure, if you're trying to solve a real world issue | 19:22 |
| ctayal | I found this while doing functional testing for the plugin, I killed neutron-server | 19:22 |
| ctayal | why do you think if it is not real world issue? | 19:23 |
| mrunge | because it happens not that often, and should be detected by your availability monitoring | 19:23 |
| mrunge | don't get me wrong, you're right. it can happen | 19:24 |
| mrunge | and there's currently no way around such an issue in horizon | 19:24 |
| ctayal | the problem is when neutron-server is killed or stopped for whatever reason, I see that my plugin is going to bad state, untill I put a check | 19:25 |
| ctayal | yea | 19:25 |
| mrunge | are you using neutronclient? | 19:26 |
| ctayal | yes | 19:27 |
| ctayal | api.neutron api call neutronclient | 19:27 |
| mrunge | how about adding a availability check there? | 19:28 |
| ctayal | in neutronclient ? | 19:28 |
| *** mpavlase has quit IRC | 19:28 | |
| mrunge | yes | 19:29 |
| *** asettle has joined #openstack-horizon | 19:29 | |
| mrunge | as neutronclient will throw an exception after timeout | 19:29 |
| ctayal | how? is there an example | 19:29 |
| mrunge | there is no example | 19:29 |
| ctayal | ok | 19:29 |
| mrunge | if you're adding your check there, the check will work outside of your plugin as well | 19:30 |
| ctayal | yes | 19:30 |
| mrunge | thus, all actions with neutron will be guarded then | 19:30 |
| ctayal | yea | 19:30 |
| mrunge | but that will add a delay to api calls | 19:31 |
| mrunge | depending on how you implement it | 19:31 |
| *** asettle has quit IRC | 19:31 | |
| ctayal | what I am thing is adding availablity api in api.neutron, so that who ever want to check can check | 19:31 |
| ctayal | instead of adding in neutronclient, as it add dealy as you said | 19:32 |
| mrunge | so: adding this to the api does not add a delay? | 19:32 |
| *** tyr has joined #openstack-horizon | 19:32 | |
| mrunge | not sure if I understand you | 19:32 |
| mrunge | I would expect this to be transparent | 19:33 |
| ctayal | no, I am thinking of adding availability as an API, so whoever want to check if neutron server is running can check | 19:33 |
| mrunge | and not requiring any other code change | 19:33 |
| ctayal | not every api need to check it | 19:33 |
| ctayal | yes exactly, no other code change | 19:33 |
| ctayal | just an API in api.neutron | 19:34 |
| mrunge | right. but adding this as an additional api will require code changes | 19:34 |
| mrunge | or you won't have the benefit | 19:34 |
| ctayal | yes, it require code change to provide new API | 19:34 |
| ctayal | something like is_service_running same as is_service_enabled in api/base.py | 19:36 |
| mrunge | nah! that will require an additional call on each place, where you're calling neutron, no? | 19:36 |
| mrunge | if you want this check for all neutron calls | 19:37 |
| mrunge | I meant more like: adding it here: https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/neutron.py#L552-L559 | 19:37 |
| mrunge | check if endpoint is answering | 19:37 |
| ctayal | yes | 19:38 |
| mrunge | but it's up to you. Chances are pretty low, that I will review your code. | 19:38 |
| ctayal | ok | 19:39 |
| ctayal | let me give it a try | 19:39 |
| ctayal | Thanks :) | 19:40 |
| *** btully has quit IRC | 19:43 | |
| *** btully has joined #openstack-horizon | 19:44 | |
| *** kzaitsev_mb has joined #openstack-horizon | 19:46 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Flavors panel can switch to Angular https://review.openstack.org/343917 | 19:48 |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Enable Angular Flavors Panel https://review.openstack.org/344456 | 19:48 |
| *** ctayal has quit IRC | 19:59 | |
| *** tyr has quit IRC | 20:04 | |
| TravT_ | r1chardj0n3s are you back from pycon fun, yet? | 20:08 |
| *** TravT_ is now known as TravT | 20:08 | |
| *** javeriak has quit IRC | 20:19 | |
| matt-borland | TravT, sorry to bug you for another pass, but I added a missing function to https://review.openstack.org/#/c/344949/ (Instance API) on Friday | 20:20 |
| TravT | ok, will look again | 20:20 |
| matt-borland | thanks TravT! | 20:20 |
| *** aortega has quit IRC | 20:22 | |
| *** cargonza has joined #openstack-horizon | 20:23 | |
| cargonza | #openstack-trove | 20:23 |
| *** sdake has quit IRC | 20:32 | |
| *** jtriley has quit IRC | 20:33 | |
| *** sdake has joined #openstack-horizon | 20:57 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Add ANGULAR_FEATURES setting dict https://review.openstack.org/353377 | 21:02 |
| *** julim has quit IRC | 21:03 | |
| *** sdake has quit IRC | 21:08 | |
| *** aortega has joined #openstack-horizon | 21:09 | |
| *** yamamoto has joined #openstack-horizon | 21:10 | |
| *** lblanchard has quit IRC | 21:10 | |
| *** yamamoto has quit IRC | 21:11 | |
| *** tqtran has quit IRC | 21:15 | |
| *** sdake has joined #openstack-horizon | 21:17 | |
| *** pauloewerton has quit IRC | 21:18 | |
| *** mvk has joined #openstack-horizon | 21:19 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Allow invocation of Django actions from Angular https://review.openstack.org/351954 | 21:21 |
| *** tyr has joined #openstack-horizon | 21:24 | |
| *** matt-borland has quit IRC | 21:25 | |
| *** edtubill has quit IRC | 21:28 | |
| robcresswell | stevemar, bpokorny: Looks like I wasn't needed :p Perfect | 21:28 |
| *** ametts has quit IRC | 21:28 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Schema Form Developer Panel https://review.openstack.org/348000 | 21:28 |
| *** btully has quit IRC | 21:28 | |
| bpokorny | robcresswell: While you were gone, we agreed you have to fix the bug in oslo.policy though :) | 21:31 |
| robcresswell | bpokorny: ...oh no | 21:34 |
| *** btully has joined #openstack-horizon | 21:37 | |
| *** sdake has quit IRC | 21:39 | |
| *** edtubill has joined #openstack-horizon | 21:41 | |
| *** amotoki has quit IRC | 21:48 | |
| *** sdake has joined #openstack-horizon | 21:54 | |
| *** tqtran has joined #openstack-horizon | 21:55 | |
| *** harlowja has quit IRC | 21:55 | |
| r1chardj0n3s | TravT: I have one more day to go, mostly :-) | 21:57 |
| *** Marcellin_ has quit IRC | 21:57 | |
| TravT | r1chardj0n3s hope you are having fun! | 21:57 |
| r1chardj0n3s | so tired :-) | 21:57 |
| *** aortega has quit IRC | 21:59 | |
| *** amotoki has joined #openstack-horizon | 22:00 | |
| *** tqtran has quit IRC | 22:00 | |
| *** amotoki has quit IRC | 22:00 | |
| *** mtanino has quit IRC | 22:03 | |
| *** onovy has quit IRC | 22:03 | |
| openstackgerrit | Aditya Vaja proposed openstack/horizon: Remove router rules extension https://review.openstack.org/348095 | 22:04 |
| openstackgerrit | Aditya Vaja proposed openstack/horizon: Remove router rules extension https://review.openstack.org/348095 | 22:06 |
| *** tqtran has joined #openstack-horizon | 22:08 | |
| *** edtubill has quit IRC | 22:10 | |
| *** tqtran has quit IRC | 22:15 | |
| *** tqtran has joined #openstack-horizon | 22:16 | |
| *** onovy has joined #openstack-horizon | 22:19 | |
| *** sjmc7 has quit IRC | 22:20 | |
| *** sdake has quit IRC | 22:20 | |
| *** yamamoto has joined #openstack-horizon | 22:26 | |
| *** sdake has joined #openstack-horizon | 22:35 | |
| *** uxdanielle has quit IRC | 22:36 | |
| *** ducttape_ has quit IRC | 22:40 | |
| *** sdake has quit IRC | 22:57 | |
| *** asettle has joined #openstack-horizon | 23:04 | |
| *** btully has quit IRC | 23:08 | |
| *** asettle has quit IRC | 23:09 | |
| *** tyr has quit IRC | 23:11 | |
| *** btully has joined #openstack-horizon | 23:12 | |
| *** ctayal has joined #openstack-horizon | 23:17 | |
| *** ezpz has quit IRC | 23:18 | |
| *** TravT has quit IRC | 23:18 | |
| *** weezS has quit IRC | 23:21 | |
| *** btully has quit IRC | 23:25 | |
| *** vascoman has joined #openstack-horizon | 23:27 | |
| *** vascoman has quit IRC | 23:28 | |
| *** kzaitsev_mb has quit IRC | 23:33 | |
| *** mpavlase has joined #openstack-horizon | 23:33 | |
| *** harlowja has joined #openstack-horizon | 23:36 | |
| *** btully has joined #openstack-horizon | 23:44 | |
| *** kenji-i has joined #openstack-horizon | 23:48 | |
| *** zhurong has joined #openstack-horizon | 23:49 | |
| *** shu-mutou has joined #openstack-horizon | 23:52 | |
| *** btully has quit IRC | 23:54 | |
| *** zhurong has quit IRC | 23:57 | |
| *** Ephur has quit IRC | 23:58 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Fix jasmine test failing to due missing ngRoute dep https://review.openstack.org/349629 | 23:58 |
| openstackgerrit | Ying Zuo proposed openstack/horizon: Show information of the selected project for create network https://review.openstack.org/349125 | 23:58 |
| *** yingjun has joined #openstack-horizon | 23:58 | |
| *** esp has left #openstack-horizon | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!