| *** lhcheng has quit IRC | 00:01 | |
| *** jtriley has joined #openstack-horizon | 00:04 | |
| *** wolverineav has quit IRC | 00:10 | |
| *** amotoki has joined #openstack-horizon | 00:12 | |
| *** wolverineav has joined #openstack-horizon | 00:17 | |
| *** sdake_ is now known as sdake | 00:19 | |
| *** yingjun has joined #openstack-horizon | 00:21 | |
| *** dan_nguyen has quit IRC | 00:25 | |
| *** btully has quit IRC | 00:27 | |
| *** clu_ has quit IRC | 00:31 | |
| *** TravT_ has quit IRC | 00:32 | |
| *** amotoki has quit IRC | 00:32 | |
| *** ducttape_ has quit IRC | 00:34 | |
| *** btully has joined #openstack-horizon | 00:42 | |
| *** dan_nguyen has joined #openstack-horizon | 00:46 | |
| *** kenji-i_ has joined #openstack-horizon | 00:51 | |
| *** bpokorny_ has joined #openstack-horizon | 00:51 | |
| *** kenji-i has quit IRC | 00:54 | |
| *** bpokorny_ has quit IRC | 00:54 | |
| *** btully has quit IRC | 00:56 | |
| *** bpokorny has quit IRC | 00:56 | |
| *** zhurong has joined #openstack-horizon | 01:05 | |
| *** tjones has left #openstack-horizon | 01:12 | |
| *** btully has joined #openstack-horizon | 01:13 | |
| *** kzaitsev_mb has joined #openstack-horizon | 01:13 | |
| *** amotoki has joined #openstack-horizon | 01:15 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: WIP: Documentation improvements for registry https://review.openstack.org/324154 | 01:21 |
|---|---|---|
| *** amotoki_ has joined #openstack-horizon | 01:24 | |
| *** btully has quit IRC | 01:25 | |
| *** amotoki has quit IRC | 01:26 | |
| *** Daisy has joined #openstack-horizon | 01:26 | |
| *** jtriley has quit IRC | 01:27 | |
| *** jtriley has joined #openstack-horizon | 01:28 | |
| openstackgerrit | Kenji Ishii proposed openstack/horizon: Change from client filter to server filter in metadata page https://review.openstack.org/321935 | 01:32 |
| *** amit213 has joined #openstack-horizon | 01:39 | |
| *** amit213 has quit IRC | 01:41 | |
| *** ducttape_ has joined #openstack-horizon | 01:42 | |
| *** Mounica has quit IRC | 01:43 | |
| *** Mounica has joined #openstack-horizon | 01:43 | |
| *** amit213 has joined #openstack-horizon | 01:44 | |
| *** Mounica has quit IRC | 01:44 | |
| *** dan_nguyen has quit IRC | 01:45 | |
| *** sdake has quit IRC | 01:49 | |
| openstackgerrit | Liuqing Jing proposed openstack/horizon: [TrivialFix] Remove unused image detail route https://review.openstack.org/324164 | 01:55 |
| *** sacharya has joined #openstack-horizon | 01:57 | |
| *** kzaitsev_mb has quit IRC | 02:01 | |
| *** btully has joined #openstack-horizon | 02:01 | |
| *** vishwanathj has joined #openstack-horizon | 02:03 | |
| *** roxanaghe has joined #openstack-horizon | 02:04 | |
| *** erlon has quit IRC | 02:06 | |
| *** roxanaghe has quit IRC | 02:09 | |
| *** btully has quit IRC | 02:11 | |
| *** btully has joined #openstack-horizon | 02:13 | |
| *** jtriley has quit IRC | 02:16 | |
| *** sdake has joined #openstack-horizon | 02:16 | |
| *** btully has quit IRC | 02:18 | |
| *** sdake has quit IRC | 02:18 | |
| *** vinaypotluri has quit IRC | 02:20 | |
| *** btully has joined #openstack-horizon | 02:24 | |
| *** itisha has quit IRC | 02:30 | |
| *** Daisy has quit IRC | 02:31 | |
| *** Daisy has joined #openstack-horizon | 02:31 | |
| *** Daisy has quit IRC | 02:36 | |
| *** pt_15 has quit IRC | 02:36 | |
| *** btully has quit IRC | 02:36 | |
| *** jtriley has joined #openstack-horizon | 02:37 | |
| *** Daisy has joined #openstack-horizon | 02:39 | |
| *** jtriley has quit IRC | 02:43 | |
| *** Mounica has joined #openstack-horizon | 02:54 | |
| *** Mounica has quit IRC | 02:56 | |
| *** Mounica has joined #openstack-horizon | 02:56 | |
| *** kzaitsev_mb has joined #openstack-horizon | 02:57 | |
| *** vishwanathj has quit IRC | 03:01 | |
| *** roxanaghe has joined #openstack-horizon | 03:04 | |
| *** julim has joined #openstack-horizon | 03:05 | |
| *** roxanaghe has quit IRC | 03:09 | |
| openstackgerrit | Allen proposed openstack/horizon: Make error message in modal a unified style https://review.openstack.org/324186 | 03:09 |
| *** yamamoto_ has joined #openstack-horizon | 03:10 | |
| *** tyr_ has quit IRC | 03:15 | |
| *** Mounica has quit IRC | 03:16 | |
| *** Mounica has joined #openstack-horizon | 03:17 | |
| *** zackf has quit IRC | 03:18 | |
| *** ducttape_ has quit IRC | 03:18 | |
| *** dan_nguyen has joined #openstack-horizon | 03:22 | |
| *** dan_nguyen has quit IRC | 03:29 | |
| *** dan_nguyen has joined #openstack-horizon | 03:30 | |
| *** Daisy has quit IRC | 03:30 | |
| *** Daisy has joined #openstack-horizon | 03:31 | |
| *** Daisy has quit IRC | 03:34 | |
| *** Daisy has joined #openstack-horizon | 03:35 | |
| *** kzaitsev_mb has quit IRC | 03:35 | |
| *** julim has quit IRC | 03:36 | |
| *** Mounica has quit IRC | 03:37 | |
| *** Mounica has joined #openstack-horizon | 03:37 | |
| *** wolverineav has quit IRC | 03:39 | |
| *** Daisy has quit IRC | 03:40 | |
| *** btully has joined #openstack-horizon | 03:41 | |
| *** wolverineav has joined #openstack-horizon | 03:41 | |
| *** Mounica has quit IRC | 03:42 | |
| *** yamamoto_ has quit IRC | 03:42 | |
| *** kwathore has quit IRC | 03:45 | |
| *** wolverineav has quit IRC | 03:46 | |
| *** zackf has joined #openstack-horizon | 03:49 | |
| *** btully has quit IRC | 03:52 | |
| *** zackf has quit IRC | 03:53 | |
| *** wangbo has quit IRC | 03:56 | |
| *** zhurong has quit IRC | 04:03 | |
| *** zhurong has joined #openstack-horizon | 04:04 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/323888 | 04:04 |
| *** roxanaghe has joined #openstack-horizon | 04:05 | |
| *** wolverineav has joined #openstack-horizon | 04:05 | |
| *** wangbo has joined #openstack-horizon | 04:09 | |
| *** roxanaghe has quit IRC | 04:09 | |
| *** wolverineav has quit IRC | 04:10 | |
| *** sguduru has joined #openstack-horizon | 04:15 | |
| *** btully has joined #openstack-horizon | 04:15 | |
| *** dan_nguyen has quit IRC | 04:16 | |
| *** roxanaghe has joined #openstack-horizon | 04:17 | |
| *** tjones has joined #openstack-horizon | 04:26 | |
| *** btully has quit IRC | 04:28 | |
| *** yamamoto_ has joined #openstack-horizon | 04:29 | |
| *** kzaitsev_mb has joined #openstack-horizon | 04:31 | |
| *** btully has joined #openstack-horizon | 04:32 | |
| *** edtubill has joined #openstack-horizon | 04:33 | |
| *** edtubill_ has joined #openstack-horizon | 04:35 | |
| *** masco has joined #openstack-horizon | 04:35 | |
| *** kzaitsev_mb has quit IRC | 04:36 | |
| *** btully has quit IRC | 04:36 | |
| *** dave-mccowan has quit IRC | 04:36 | |
| *** edtubill has quit IRC | 04:38 | |
| *** btully has joined #openstack-horizon | 04:39 | |
| *** btully has quit IRC | 04:43 | |
| openstackgerrit | Ankur proposed openstack/horizon: Add Network IP Availability Extension https://review.openstack.org/283171 | 04:45 |
| openstackgerrit | Ankur proposed openstack/horizon: Add Network IP Availability Extension https://review.openstack.org/283171 | 04:46 |
| *** jamielennox is now known as jamielennox|away | 04:48 | |
| *** tjones has left #openstack-horizon | 04:56 | |
| *** sacharya has quit IRC | 04:57 | |
| *** Daisy has joined #openstack-horizon | 05:01 | |
| *** wolverineav has joined #openstack-horizon | 05:01 | |
| *** Daisy_ has joined #openstack-horizon | 05:03 | |
| *** btully has joined #openstack-horizon | 05:03 | |
| *** jamielennox|away is now known as jamielennox | 05:04 | |
| *** Daisy has quit IRC | 05:05 | |
| *** ratailor has joined #openstack-horizon | 05:06 | |
| *** ankur-gupta-f1 has joined #openstack-horizon | 05:07 | |
| ankur-gupta-f1 | amotoki_: Are you online right now? | 05:07 |
| *** Daisy_ has quit IRC | 05:08 | |
| amotoki_ | ankur-gupta-f1: hi | 05:08 |
| ankur-gupta-f1 | hello, just saw your comments posted 15 min ago and figured you were online. | 05:09 |
| ankur-gupta-f1 | Hello | 05:09 |
| ankur-gupta-f1 | Good morning? | 05:09 |
| *** btully has quit IRC | 05:10 | |
| ankur-gupta-f1 | I went ahead and took all your changes into consideration. And had to deal with a rebase. | 05:10 |
| amotoki_ | Just afternoon | 05:10 |
| ankur-gupta-f1 | in terms of your last comment referring to wwriverrat's (TODO) | 05:11 |
| ankur-gupta-f1 | https://github.com/openstack/neutron/blob/master/neutron/extensions/network_ip_availability.py#L26-L42 | 05:11 |
| amotoki_ | ankur-gupta-f1: I think you don't need to take care of that TODO. | 05:11 |
| ankur-gupta-f1 | so yes, the subnet stuff needs to be done. So free_ips is generated by some subtraction within horizon | 05:12 |
| *** btully has joined #openstack-horizon | 05:12 | |
| amotoki_ | ankur-gupta-f1: ah! I got what you mean | 05:12 |
| ankur-gupta-f1 | ah yes, I looked into it back when wwriverrat was working on it. If I recall we came up with some reason why it wasn't worth it at the time :P | 05:12 |
| amotoki_ | ankur-gupta-f1: per subnet information is not well defined here. | 05:13 |
| amotoki_ | ankur-gupta-f1: looking at https://github.com/openstack/neutron/blob/master/neutron/db/network_ip_availability_db.py#L167 | 05:14 |
| ankur-gupta-f1 | yes, so to make up I had to do the ugly stuff here | 05:15 |
| ankur-gupta-f1 | https://review.openstack.org/#/c/283171/45/openstack_dashboard/dashboards/admin/networks/views.py | 05:15 |
| ankur-gupta-f1 | Line #126 | 05:15 |
| openstackgerrit | Richard Jones proposed openstack/horizon: WIP: Documentation improvements for registry https://review.openstack.org/324154 | 05:15 |
| *** Mounica has joined #openstack-horizon | 05:15 | |
| *** tyr_ has joined #openstack-horizon | 05:16 | |
| amotoki_ | ankur-gupta-f1: agree. IMHO it is better to use xxx[yyy] if yyy always exists and use .get() if a given key is optional. | 05:16 |
| *** jtomasek has joined #openstack-horizon | 05:16 | |
| amotoki_ | ankur-gupta-f1: it is clearer for code readers :-) | 05:16 |
| ankur-gupta-f1 | amotoki_: ah okay. quick fix. I will put it a comment so that the next patchset I will change it. Wait till i get a more substantial change before uploading new patch. | 05:18 |
| amotoki_ | ankur-gupta-f1: thanks! | 05:19 |
| *** amotoki_ is now known as amotoki | 05:19 | |
| ankur-gupta-f1 | amotoki: Enough work for one day (past midnight). Just wanted to update the patchset asap and catch you while I could. Thanks for giving the patch a review, especially from a Neutron community standpoint. | 05:20 |
| *** Mounica has quit IRC | 05:20 | |
| *** tyr_ has quit IRC | 05:20 | |
| *** btully has quit IRC | 05:26 | |
| *** ankur-gupta-f1 has left #openstack-horizon | 05:34 | |
| *** roxanaghe has quit IRC | 05:38 | |
| *** roxanaghe has joined #openstack-horizon | 05:38 | |
| *** jbell8 has quit IRC | 05:43 | |
| *** roxanaghe has quit IRC | 05:43 | |
| *** Daisy has joined #openstack-horizon | 05:47 | |
| *** rcernin has joined #openstack-horizon | 05:48 | |
| *** Daisy has quit IRC | 05:51 | |
| *** Daisy has joined #openstack-horizon | 05:52 | |
| *** Daisy_ has joined #openstack-horizon | 05:53 | |
| *** Daisy has quit IRC | 05:53 | |
| *** Daisy_ has quit IRC | 05:55 | |
| *** Daisy has joined #openstack-horizon | 05:55 | |
| *** Daisy has quit IRC | 05:56 | |
| *** Daisy has joined #openstack-horizon | 05:56 | |
| *** sacharya has joined #openstack-horizon | 05:57 | |
| *** Daisy has quit IRC | 05:59 | |
| *** Daisy has joined #openstack-horizon | 05:59 | |
| *** jamielennox is now known as jamielennox|away | 06:01 | |
| *** zackf has joined #openstack-horizon | 06:01 | |
| *** sacharya has quit IRC | 06:02 | |
| *** Daisy has quit IRC | 06:04 | |
| *** Daisy has joined #openstack-horizon | 06:04 | |
| *** zackf has quit IRC | 06:06 | |
| *** zhurong has quit IRC | 06:16 | |
| *** jamielennox|away is now known as jamielennox | 06:16 | |
| *** tyr_ has joined #openstack-horizon | 06:17 | |
| *** zhurong has joined #openstack-horizon | 06:19 | |
| *** ducttape_ has joined #openstack-horizon | 06:20 | |
| *** zackf has joined #openstack-horizon | 06:21 | |
| *** tyr_ has quit IRC | 06:21 | |
| *** zul has quit IRC | 06:21 | |
| *** zackf has quit IRC | 06:26 | |
| *** ducttape_ has quit IRC | 06:26 | |
| *** kzaitsev_mb has joined #openstack-horizon | 06:32 | |
| *** btully has joined #openstack-horizon | 06:33 | |
| *** zul has joined #openstack-horizon | 06:36 | |
| *** btully has quit IRC | 06:37 | |
| *** kzaitsev_mb has quit IRC | 06:38 | |
| *** edtubill_ has quit IRC | 06:39 | |
| *** roxanaghe has joined #openstack-horizon | 06:39 | |
| *** btully has joined #openstack-horizon | 06:39 | |
| *** mpavlase has joined #openstack-horizon | 06:43 | |
| *** roxanaghe has quit IRC | 06:43 | |
| *** sguduru_ has joined #openstack-horizon | 06:45 | |
| *** sguduru has quit IRC | 06:45 | |
| *** mvk_ has quit IRC | 06:52 | |
| *** btully has quit IRC | 06:52 | |
| *** tesseract- has joined #openstack-horizon | 06:53 | |
| *** wangbo has quit IRC | 06:56 | |
| *** btully has joined #openstack-horizon | 06:57 | |
| *** sdake has joined #openstack-horizon | 06:57 | |
| *** Daisy has quit IRC | 07:02 | |
| *** Daisy has joined #openstack-horizon | 07:03 | |
| *** Daisy has quit IRC | 07:07 | |
| *** btully has quit IRC | 07:11 | |
| *** vishwanathj has joined #openstack-horizon | 07:15 | |
| *** vishwana_ has joined #openstack-horizon | 07:15 | |
| *** tyr_ has joined #openstack-horizon | 07:18 | |
| *** btully has joined #openstack-horizon | 07:18 | |
| *** vishwanathj has quit IRC | 07:19 | |
| *** tyr_ has quit IRC | 07:22 | |
| *** vishwana_ is now known as vishwanathj | 07:26 | |
| *** btully has quit IRC | 07:32 | |
| betherly | morning! | 07:32 |
| *** vishwanathj has quit IRC | 07:34 | |
| *** kzaitsev_mb has joined #openstack-horizon | 07:34 | |
| *** Daisy has joined #openstack-horizon | 07:36 | |
| *** Daisy has quit IRC | 07:36 | |
| *** jtomasek_ has joined #openstack-horizon | 07:37 | |
| *** hoonetorg has quit IRC | 07:38 | |
| *** Daisy has joined #openstack-horizon | 07:38 | |
| *** kzaitsev_mb has quit IRC | 07:38 | |
| *** Daisy_ has joined #openstack-horizon | 07:39 | |
| *** sdake has quit IRC | 07:39 | |
| *** Daisy_ has quit IRC | 07:39 | |
| *** Daisy_ has joined #openstack-horizon | 07:40 | |
| *** roxanaghe has joined #openstack-horizon | 07:40 | |
| *** btully has joined #openstack-horizon | 07:42 | |
| *** Daisy has quit IRC | 07:42 | |
| *** jtomasek_ has quit IRC | 07:44 | |
| *** roxanaghe has quit IRC | 07:44 | |
| *** ygbo has joined #openstack-horizon | 07:45 | |
| *** hoonetorg has joined #openstack-horizon | 07:50 | |
| *** kzaitsev_mb has joined #openstack-horizon | 07:51 | |
| *** btully has quit IRC | 07:56 | |
| *** zzxwill has joined #openstack-horizon | 07:58 | |
| *** sacharya has joined #openstack-horizon | 07:59 | |
| *** sacharya has quit IRC | 08:03 | |
| openstackgerrit | zzxwill proposed openstack/horizon: Remove redundant conditional expression https://review.openstack.org/324281 | 08:05 |
| *** jbell8 has joined #openstack-horizon | 08:08 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/horizon: [WIP] Testing latest u-c https://review.openstack.org/303429 | 08:10 |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Add truncated flag support https://review.openstack.org/250869 | 08:11 |
| *** vishwanathj has joined #openstack-horizon | 08:14 | |
| *** btully has joined #openstack-horizon | 08:16 | |
| *** tyr_ has joined #openstack-horizon | 08:18 | |
| *** ducttape_ has joined #openstack-horizon | 08:22 | |
| *** tyr_ has quit IRC | 08:23 | |
| *** Daisy_ has quit IRC | 08:24 | |
| *** Daisy has joined #openstack-horizon | 08:24 | |
| *** btully has quit IRC | 08:25 | |
| *** ducttape_ has quit IRC | 08:26 | |
| *** Daisy has quit IRC | 08:29 | |
| *** Daisy has joined #openstack-horizon | 08:37 | |
| *** Mounica has joined #openstack-horizon | 08:38 | |
| *** btully has joined #openstack-horizon | 08:45 | |
| *** Mounica has quit IRC | 08:48 | |
| *** btully has quit IRC | 08:56 | |
| robcresswell | ankur-gupta-f1: Is https://review.openstack.org/#/c/283171 up for review again or still waiting on some changes? | 09:08 |
| *** hughhalf has quit IRC | 09:12 | |
| *** sdake has joined #openstack-horizon | 09:13 | |
| *** tyr_ has joined #openstack-horizon | 09:19 | |
| *** tyr_ has quit IRC | 09:24 | |
| tsufiev | morning there! | 09:28 |
| robcresswell | morning tsufiev | 09:32 |
| tsufiev | morning, robcresswell. I've added you to https://review.openstack.org/#/c/225334/ as there was a discussion between me and hurgleburgler regarding how table should look | 09:33 |
| tsufiev | your opinion as an expert in CSS would be highly valuable | 09:34 |
| robcresswell | Haha, we are using the term "expert" very liberally :p | 09:34 |
| tsufiev | :) | 09:34 |
| robcresswell | Will take a look today tsufiev | 09:34 |
| tsufiev | perhaps junior guru then ;)? | 09:35 |
| robcresswell | That's more accurate | 09:36 |
| robcresswell | Need to go and yell at my neighbours for playing music too loud again -.- | 09:36 |
| *** yingjun has quit IRC | 09:36 | |
| *** kzaitsev_mb has quit IRC | 09:37 | |
| tsufiev | oh, didn't think there is such problem in UK | 09:37 |
| tsufiev | my neighbour likes to watch TV past mignight, which is quite irritating | 09:37 |
| tsufiev | sometimes knocking the wall helps, sometimes it doesn't :*| | 09:38 |
| *** sdake has quit IRC | 09:40 | |
| *** roxanaghe has joined #openstack-horizon | 09:42 | |
| *** Daisy has quit IRC | 09:42 | |
| *** Daisy has joined #openstack-horizon | 09:42 | |
| *** Daisy_ has joined #openstack-horizon | 09:45 | |
| *** Daisy_ has quit IRC | 09:46 | |
| *** roxanaghe has quit IRC | 09:46 | |
| *** btully has joined #openstack-horizon | 09:46 | |
| *** Daisy_ has joined #openstack-horizon | 09:46 | |
| robcresswell | Yeah, usually takes about 15 minutes of me hammering on the door before they hear it. | 09:47 |
| *** Daisy has quit IRC | 09:47 | |
| *** hughhalf has joined #openstack-horizon | 09:48 | |
| *** Daisy_ has quit IRC | 09:51 | |
| *** btully has quit IRC | 09:55 | |
| *** wangbo has joined #openstack-horizon | 09:56 | |
| *** vishwanathj has quit IRC | 09:57 | |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Refactoring of network details pages https://review.openstack.org/303510 | 09:58 |
| *** sacharya has joined #openstack-horizon | 10:00 | |
| *** shu-mutou is now known as shu-mutou-AFK | 10:00 | |
| *** amotoki has quit IRC | 10:01 | |
| *** amotoki has joined #openstack-horizon | 10:04 | |
| *** sacharya has quit IRC | 10:04 | |
| *** vishwanathj has joined #openstack-horizon | 10:07 | |
| robcresswell | tsufiev: Oh I saw your comment, you're being way too picky :p | 10:08 |
| *** zhurong has quit IRC | 10:10 | |
| tsufiev | robcresswell, well, I won't argue anymore if you think that's okay | 10:11 |
| robcresswell | tsufiev: I left my comment in line. I think its mainly just less developer overhead and css maintenance overhead to always use default when possible. | 10:14 |
| tsufiev | okay | 10:15 |
| * tsufiev playing an evil cop in reviews | 10:15 | |
| *** vishwanathj has quit IRC | 10:21 | |
| *** tyr_ has joined #openstack-horizon | 10:21 | |
| *** ducttape_ has joined #openstack-horizon | 10:22 | |
| *** tyr_ has quit IRC | 10:25 | |
| *** itxaka has joined #openstack-horizon | 10:26 | |
| *** ducttape_ has quit IRC | 10:27 | |
| *** kzaitsev_mb has joined #openstack-horizon | 10:37 | |
| *** amotoki has quit IRC | 10:37 | |
| *** amotoki has joined #openstack-horizon | 10:39 | |
| *** rodrigods has quit IRC | 10:39 | |
| *** rodrigods has joined #openstack-horizon | 10:40 | |
| *** mvk_ has joined #openstack-horizon | 10:41 | |
| *** roxanaghe has joined #openstack-horizon | 10:42 | |
| robcresswell | ankur-gupta-f1: Just reviewed all your Horizon patches. | 10:46 |
| * robcresswell looks for next -1 victim | 10:46 | |
| *** roxanaghe has quit IRC | 10:47 | |
| *** jprovazn has joined #openstack-horizon | 10:48 | |
| *** Mounica has joined #openstack-horizon | 10:49 | |
| openstackgerrit | Merged openstack/horizon: Set some useful default values with the new launch wizard. https://review.openstack.org/323623 | 10:49 |
| *** Mounica has quit IRC | 10:53 | |
| *** btully has joined #openstack-horizon | 11:05 | |
| *** amotoki has quit IRC | 11:07 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: In integration tests prevent getting volume size too early https://review.openstack.org/324370 | 11:13 |
| *** btully has quit IRC | 11:14 | |
| *** amotoki has joined #openstack-horizon | 11:15 | |
| openstackgerrit | Sergei Chipiga proposed openstack/horizon: Implement video capture for failed tests https://review.openstack.org/320004 | 11:21 |
| *** tyr_ has joined #openstack-horizon | 11:22 | |
| *** tyr_ has quit IRC | 11:26 | |
| *** julim has joined #openstack-horizon | 11:31 | |
| *** ducttape_ has joined #openstack-horizon | 11:35 | |
| *** roxanaghe has joined #openstack-horizon | 11:43 | |
| *** sguduru_ has quit IRC | 11:44 | |
| *** zhurong has joined #openstack-horizon | 11:45 | |
| *** btully has joined #openstack-horizon | 11:45 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Modals should inherit from the theme https://review.openstack.org/309581 | 11:47 |
| *** Daisy has joined #openstack-horizon | 11:47 | |
| *** roxanaghe has quit IRC | 11:48 | |
| openstackgerrit | Merged openstack/horizon: Delegate tearDown logic to addCleanup method https://review.openstack.org/323990 | 11:49 |
| robcresswell | tsufiev: Wasnt the previous gate issue integration? I thought that patch had failed npm- | 11:49 |
| openstackgerrit | Sergei Chipiga proposed openstack/horizon: Do not run exception handlers if test was skipped. https://review.openstack.org/323956 | 11:51 |
| *** peristeri has joined #openstack-horizon | 11:51 | |
| *** Daisy has quit IRC | 11:52 | |
| tsufiev | robcresswell, if you mean modals patch, dsvm-integration failed as well as npm-run-test | 11:53 |
| tsufiev | with almost all tests failed | 11:53 |
| robcresswell | ah | 11:54 |
| *** jbell8 has quit IRC | 11:54 | |
| robcresswell | tsufiev: This patch hates me https://review.openstack.org/#/c/316767/ | 11:54 |
| robcresswell | 7th time in gate I think | 11:54 |
| tsufiev | :( | 11:55 |
| tsufiev | just keep pushing, it will land eventually | 11:55 |
| tsufiev | robcresswell, I'd rather call it 'squeezing patch into the gate' | 11:55 |
| *** btully has quit IRC | 11:56 | |
| tsufiev | btw, robcresswell, while reviewing themable volumes patch I found another possible source of integration failures, fixed https://review.openstack.org/#/c/324370/ | 11:57 |
| * tsufiev wonders how many places like this do we still have | 11:57 | |
| tsufiev | video capturing for failed tests is almost there, hopefully it will help us to hunt down the remaining issues with timeouts | 11:58 |
| *** sacharya has joined #openstack-horizon | 12:00 | |
| *** ducttape_ has quit IRC | 12:02 | |
| *** sacharya has quit IRC | 12:05 | |
| *** jtriley has joined #openstack-horizon | 12:06 | |
| *** yingjun has joined #openstack-horizon | 12:10 | |
| *** jtriley has quit IRC | 12:11 | |
| *** amotoki has quit IRC | 12:11 | |
| *** hoonetorg has quit IRC | 12:12 | |
| openstackgerrit | Merged openstack/horizon: Horizon selects are now themable: Volumes https://review.openstack.org/263817 | 12:12 |
| *** kzaitsev_mb has quit IRC | 12:13 | |
| *** btully has joined #openstack-horizon | 12:14 | |
| *** amotoki has joined #openstack-horizon | 12:18 | |
| *** amotoki has quit IRC | 12:18 | |
| *** tyr_ has joined #openstack-horizon | 12:23 | |
| openstackgerrit | Kenji Ishii proposed openstack/horizon: Checkbox for inline edit is themable https://review.openstack.org/296251 | 12:24 |
| *** btully has quit IRC | 12:26 | |
| *** hoonetorg has joined #openstack-horizon | 12:27 | |
| *** masco has quit IRC | 12:27 | |
| *** tyr_ has quit IRC | 12:27 | |
| *** dave-mccowan has joined #openstack-horizon | 12:28 | |
| *** kzaitsev_mb has joined #openstack-horizon | 12:29 | |
| openstackgerrit | Sergei Chipiga proposed openstack/horizon: Implement video capture for failed tests https://review.openstack.org/320004 | 12:29 |
| *** wangbo has quit IRC | 12:33 | |
| *** amotoki has joined #openstack-horizon | 12:36 | |
| *** julim has quit IRC | 12:41 | |
| *** roxanaghe has joined #openstack-horizon | 12:44 | |
| *** wangbo has joined #openstack-horizon | 12:45 | |
| *** roxanaghe has quit IRC | 12:48 | |
| *** amotoki has quit IRC | 12:53 | |
| *** yamamoto_ has quit IRC | 12:58 | |
| *** ratailor has quit IRC | 12:58 | |
| *** btully has joined #openstack-horizon | 13:04 | |
| *** julim has joined #openstack-horizon | 13:14 | |
| *** btully has quit IRC | 13:14 | |
| *** Mounica has joined #openstack-horizon | 13:17 | |
| robcresswell | tsufiev: Have you seen http://bropages.org/ ? haha | 13:21 |
| *** matt-borland has joined #openstack-horizon | 13:21 | |
| matt-borland | morning | 13:21 |
| robcresswell | morning matt-borland | 13:21 |
| matt-borland | hey Rob! how's London? | 13:22 |
| matt-borland | or the appropriate suburb | 13:22 |
| robcresswell | Grey | 13:22 |
| *** pauloewerton has joined #openstack-horizon | 13:22 | |
| *** ducttape_ has joined #openstack-horizon | 13:22 | |
| matt-borland | Is it 12 degrees C? | 13:22 |
| matt-borland | When I was there, it was 54F all week | 13:23 |
| matt-borland | (two years ago) | 13:23 |
| robcresswell | oddly specific. Its probably about that. | 13:23 |
| robcresswell | bit warmer perhaps. I dont have the windows open | 13:23 |
| matt-borland | it's oddly grey here as well | 13:23 |
| openstackgerrit | Zhang Yun proposed openstack/horizon: Make the update user with removing email workable https://review.openstack.org/324526 | 13:24 |
| *** yingjun has quit IRC | 13:24 | |
| matt-borland | and it's 55F | 13:24 |
| *** yingjun has joined #openstack-horizon | 13:24 | |
| *** Mounica has quit IRC | 13:24 | |
| *** ducttape_ has quit IRC | 13:25 | |
| robcresswell | You're not in London are you? | 13:25 |
| matt-borland | I'm not! Just in FoCo | 13:26 |
| matt-borland | feels like it thought | 13:26 |
| matt-borland | *though | 13:26 |
| robcresswell | On the plus side, the giant skull outside my flat has been removed | 13:26 |
| matt-borland | human? | 13:26 |
| *** lblanchard has joined #openstack-horizon | 13:27 | |
| matt-borland | or giant, I suppose? | 13:27 |
| robcresswell | matt-borland: https://twitter.com/robcresswell/status/714715850167681024 | 13:27 |
| matt-borland | Only in London. Henry the Third? | 13:28 |
| *** btully has joined #openstack-horizon | 13:28 | |
| robcresswell | One of my favourite Henrys | 13:29 |
| *** yingjun has quit IRC | 13:29 | |
| robcresswell | Definitely in the top ten | 13:29 |
| tsufiev | robcresswell, lol ) | 13:30 |
| matt-borland | We have a distinct lack of kings here | 13:30 |
| *** yingjun has joined #openstack-horizon | 13:35 | |
| *** zackf has joined #openstack-horizon | 13:36 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: In integration tests prevent getting volume size too early https://review.openstack.org/324370 | 13:39 |
| *** btully has quit IRC | 13:41 | |
| robcresswell | How is it 2:40 already 0.o | 13:42 |
| robcresswell | Days are too short. | 13:42 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Revert "Router namespace not created in controller". https://review.openstack.org/303317 | 13:43 |
| *** btully has joined #openstack-horizon | 13:43 | |
| *** roxanaghe has joined #openstack-horizon | 13:45 | |
| *** Mounica has joined #openstack-horizon | 13:46 | |
| *** roxanaghe has quit IRC | 13:49 | |
| *** lucas__ has joined #openstack-horizon | 13:51 | |
| *** ametts has joined #openstack-horizon | 13:53 | |
| matt-borland | robcresswell, did you see krotscheck's patch and the debug-level log failure? | 13:56 |
| matt-borland | it seems to fail when writing the coverage report | 13:56 |
| matt-borland | which does not surprise me at all | 13:56 |
| matt-borland | http://logs.openstack.org/74/324074/1/check/gate-horizon-npm-run-test/0ec3f6a/console.html | 13:57 |
| *** btully has quit IRC | 13:57 | |
| *** Mounica has quit IRC | 13:57 | |
| matt-borland | robcresswell, seems like we should just turn off the coverage report for now; that's *after* the threshold test has been run. | 13:57 |
| *** btully has joined #openstack-horizon | 13:58 | |
| matt-borland | tyr had run into file limits on his system; could be related | 13:58 |
| schipiga | robcresswell, can you review a good patch to record video of failed tests https://review.openstack.org/#/c/320004/. I believe it will help us to understand core problem of failed tests | 13:58 |
| *** sacharya has joined #openstack-horizon | 14:01 | |
| *** yingjun has quit IRC | 14:03 | |
| *** yingjun has joined #openstack-horizon | 14:03 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Default theme lacks support for dropup menus https://review.openstack.org/318932 | 14:04 |
| krotscheck | Good lord you coloradans are up early | 14:04 |
| matt-borland | just me! | 14:04 |
| * matt-borland is an early bird | 14:05 | |
| krotscheck | matt-borland: Again, I think that's a red herring | 14:05 |
| *** lucas__ has quit IRC | 14:05 | |
| *** sacharya has quit IRC | 14:06 | |
| matt-borland | sure, I just meant, as a workaround | 14:06 |
| matt-borland | it's obviously an environmental issue of some sort | 14:06 |
| *** yingjun_ has joined #openstack-horizon | 14:06 | |
| *** yingjun has quit IRC | 14:06 | |
| *** yamamoto has joined #openstack-horizon | 14:07 | |
| *** lucas__ has joined #openstack-horizon | 14:09 | |
| *** edtubill has joined #openstack-horizon | 14:09 | |
| krotscheck | I also don't think it's file limits. | 14:09 |
| *** wangbo has quit IRC | 14:09 | |
| krotscheck | The line that's missing is "Process Chrome exited with code 0" | 14:09 |
| matt-borland | I'm just putting up suggestions, since I can't access the node where it fails. | 14:09 |
| matt-borland | Chrome exiting is correct at that point I believe. | 14:09 |
| *** _stowa has joined #openstack-horizon | 14:09 | |
| *** wangbo has joined #openstack-horizon | 14:10 | |
| jlopezgu | morning | 14:10 |
| krotscheck | matt-borland: Right, but it never does. | 14:10 |
| *** lucas__ has quit IRC | 14:10 | |
| *** alexvictorchan has quit IRC | 14:11 | |
| matt-borland | krotscheck, so, a premature "happy" closure? | 14:11 |
| krotscheck | maaaybe. | 14:11 |
| *** alexvictorchan has joined #openstack-horizon | 14:11 | |
| krotscheck | I still haven't given up on the coverage thing you mentioned. | 14:11 |
| krotscheck | 2016-06-02 01:13:13.993 | [SCP] No file(s) found: cover/** | 14:11 |
| *** lucas__ has joined #openstack-horizon | 14:12 | |
| matt-borland | I don't think we've ever properly captured the coverage reports, but that's after the point of failure, no? | 14:12 |
| matt-borland | that's the post-run reporting stage | 14:13 |
| krotscheck | The assumption is: If logging the coverage report happens before creating the file, then it fails during report generation, and that report is never created. | 14:13 |
| *** btully has quit IRC | 14:13 | |
| krotscheck | If creating the report passes, and the failure is during chrome shutdown (the line that should come after), then the coverage report should have been created, found, and uploaded | 14:13 |
| krotscheck | ARGH WHY IS PASTE DEAD | 14:14 |
| matt-borland | krotscheck, I'm just saying, that SCP complaint is true on successful runs too | 14:14 |
| matt-borland | it's looking in the wrong place | 14:14 |
| krotscheck | it is? | 14:14 |
| *** jbell8 has joined #openstack-horizon | 14:15 | |
| matt-borland | we store coverage reports in two places: | 14:15 |
| matt-borland | horizon/coverage-karma and openstack_dashboard/coverage-karma | 14:15 |
| krotscheck | Ah, you need to change that. The CTI defines that the coverage report needs to be in ./cover | 14:15 |
| krotscheck | matt-borland: https://governance.openstack.org/reference/cti/javascript-cti.html#executing-tests-and-code-coverage | 14:16 |
| *** lucas__ has quit IRC | 14:16 | |
| matt-borland | ok, but that isn't the problem | 14:16 |
| *** yamamoto has quit IRC | 14:16 | |
| matt-borland | like I say, it's just not being archived, never has, same problem | 14:16 |
| matt-borland | but I will file a bug on that and change that | 14:16 |
| *** mpavlase has quit IRC | 14:16 | |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Refactoring of network details pages https://review.openstack.org/303510 | 14:17 |
| krotscheck | matt-borland: It would provide us valuable info on where the failure is though, whether it's happening during report generation or browser shutdown. | 14:17 |
| krotscheck | Right now, best I can do is try to rerun the job on a local jenkins slave over and over and over. | 14:17 |
| *** _stowa has quit IRC | 14:18 | |
| krotscheck | Which I'm doing :/ | 14:18 |
| *** lucas__ has joined #openstack-horizon | 14:19 | |
| matt-borland | krotscheck, thank you :) | 14:19 |
| matt-borland | FYI: https://bugs.launchpad.net/horizon/+bug/1588389 | 14:19 |
| openstack | Launchpad bug 1588389 in OpenStack Dashboard (Horizon) "Change JS coverage report dir to match CTI " [Undecided,New] | 14:19 |
| matt-borland | gonna file that for you. | 14:19 |
| *** fedexo has joined #openstack-horizon | 14:19 | |
| *** lucas__ has quit IRC | 14:20 | |
| *** lucas__ has joined #openstack-horizon | 14:20 | |
| *** edtubill has quit IRC | 14:21 | |
| *** lucas__ has quit IRC | 14:21 | |
| *** lucas___ has joined #openstack-horizon | 14:21 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Added safety check to initActions so unregistered types pass https://review.openstack.org/317619 | 14:21 |
| *** edtubill has joined #openstack-horizon | 14:21 | |
| *** lucas___ has quit IRC | 14:22 | |
| *** lucas__ has joined #openstack-horizon | 14:22 | |
| *** yamamoto has joined #openstack-horizon | 14:24 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: Launch Instance https://review.openstack.org/289679 | 14:24 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: Launch Instance https://review.openstack.org/289679 | 14:25 |
| krotscheck | On an unrelated note, vkramskikh has asked for a new release of eslint-config-openstack based on eslint 2.x. I'd like to get a few more eyeballs on the es6 rules that he proposed before cutting that version though. If anyone's available, here are the patches.https://review.openstack.org/#/q/topic:es6 | 14:25 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: Admin Panels https://review.openstack.org/290204 | 14:25 |
| matt-borland | thanks krotscheck | 14:25 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Legacy Transfer Table should inherit from theme https://review.openstack.org/303625 | 14:26 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Modals should inherit from the theme https://review.openstack.org/309581 | 14:27 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Output JS Karma test coverage reports to ./coverage/ https://review.openstack.org/324558 | 14:27 |
| matt-borland | krotscheck, see patch above ^^' | 14:30 |
| *** Mounica has joined #openstack-horizon | 14:31 | |
| krotscheck | matt-borland: Reviewed | 14:34 |
| matt-borland | duh, yeah krotscheck :) | 14:34 |
| *** amotoki has joined #openstack-horizon | 14:35 | |
| *** wangbo has quit IRC | 14:35 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Output JS Karma test coverage reports to ./cover/ https://review.openstack.org/324558 | 14:36 |
| matt-borland | heh, krotscheck | 14:36 |
| krotscheck | I must say, chrome spins up FAST in a vm. | 14:37 |
| matt-borland | nice! | 14:37 |
| *** pushkaru has joined #openstack-horizon | 14:37 | |
| *** btully has joined #openstack-horizon | 14:37 | |
| *** wangbo has joined #openstack-horizon | 14:39 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Allowing non-ASCII characters for Security Group names https://review.openstack.org/324079 | 14:40 |
| *** TravT has joined #openstack-horizon | 14:41 | |
| *** ChanServ sets mode: +v TravT | 14:41 | |
| *** mtanino has joined #openstack-horizon | 14:42 | |
| *** yamamoto has quit IRC | 14:43 | |
| *** david-lyle has joined #openstack-horizon | 14:44 | |
| *** ChanServ sets mode: +o david-lyle | 14:44 | |
| *** roxanaghe has joined #openstack-horizon | 14:45 | |
| *** roxanaghe has quit IRC | 14:50 | |
| krotscheck | Ok, so, local slave is useless, the builds all pass. I'm going to create a cloud instance and see what happens. | 14:52 |
| *** vgridnev_ has joined #openstack-horizon | 14:53 | |
| sjmc7 | krotscheck: you could request SSH access to the real infra nodepool and recheck an job until it fails if you can’t repro it locally | 14:53 |
| *** vgridnev_ has quit IRC | 14:53 | |
| krotscheck | sjmc7: That's the next wtep. | 14:53 |
| sjmc7 | if we can get it to fail internally (at HP) that’d be even easier | 14:54 |
| krotscheck | sjmc7: Technically I'm part of the infra team, and I'm quite cognizant of how overloaded we all are. | 14:54 |
| sjmc7 | ah, ok | 14:54 |
| krotscheck | So I don't want to escalate this until I've explored every avenue. | 14:54 |
| sjmc7 | it’s mostly an automatic process to get a private key added to the list though | 14:54 |
| krotscheck | sjmc7: I don't think they do that for anything other than cores, which I'm not. | 14:55 |
| krotscheck | I do know that they can grab a node while it's in process and give someone specific access to that one. | 14:55 |
| sjmc7 | ah, ok, never mind. well, if it’s something we can repro on our internal repositories let me know and i can get you access | 14:56 |
| betherly | hurgleburgler: do you have any idea why this patch is still failing tests? https://review.openstack.org/#/c/316157/ | 14:56 |
| *** zhurong has quit IRC | 14:57 | |
| matt-borland | betherly, it's due to gate failures unrelated to your change | 14:57 |
| hurgleburgler | betherly the gate is failing for everyone | 14:57 |
| matt-borland | just recheck it for now | 14:57 |
| hurgleburgler | I just rebased it | 14:57 |
| betherly | matt-borland: ah! ok thanks! | 14:57 |
| hurgleburgler | Timur put out a fix | 14:57 |
| matt-borland | that's what krotscheck is looking into | 14:57 |
| betherly | hurgleburgler: awesome :D thank you | 14:57 |
| hurgleburgler | no need to recheck since i rebased | 14:57 |
| tsufiev | hurgleburgler, nah, it's about npm-run-test now | 14:57 |
| betherly | matt-borland: ohhhhh click | 14:58 |
| tsufiev | matt-borland, is right, see above | 14:58 |
| hurgleburgler | tsufiev: this patch shouldn't affect integration tests at all though | 14:58 |
| hurgleburgler | it just sets a cursor style | 14:58 |
| krotscheck | Hrm. That one's also in rax-ord | 14:58 |
| *** yamamoto has joined #openstack-horizon | 14:59 | |
| tsufiev | hurgleburgler, I meant that the last failure was due to npm-run-test, not dsvm-integration job | 14:59 |
| matt-borland | krotscheck, I've seen failures at -ord, -iad, -dfw, at least | 14:59 |
| hurgleburgler | tsufiev: are we checking cursor rendering in the tests? | 14:59 |
| hurgleburgler | tsufiev: gotcha | 14:59 |
| krotscheck | matt-borland: Coolio, thanks | 14:59 |
| betherly | hurgleburgler: could it also be because its rebased on top of your branch? | 14:59 |
| hurgleburgler | betherly: good point, forgot we made that dependent on the modal change … I just rebased that one as well … I'll keep an eye on it | 15:00 |
| betherly | hurgleburgler: thanks :) | 15:00 |
| *** kzaitsev_mb has quit IRC | 15:01 | |
| *** kzaitsev_mb has joined #openstack-horizon | 15:02 | |
| *** tjones has joined #openstack-horizon | 15:03 | |
| *** jtriley has joined #openstack-horizon | 15:03 | |
| *** weezS has joined #openstack-horizon | 15:10 | |
| *** alexvictorchan has quit IRC | 15:11 | |
| *** kzaitsev_mb has quit IRC | 15:14 | |
| *** pumarani__ has joined #openstack-horizon | 15:17 | |
| *** kzaitsev_mb has joined #openstack-horizon | 15:17 | |
| *** tjones has left #openstack-horizon | 15:17 | |
| *** jtriley has quit IRC | 15:19 | |
| *** pushkaru has quit IRC | 15:20 | |
| *** jbell8 has quit IRC | 15:29 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Store user settings cookie data with UID https://review.openstack.org/118334 | 15:31 |
| *** pumarani__ has quit IRC | 15:33 | |
| krotscheck | matt-borland: Have you seen these issues in anything _other_ than rackspace? | 15:34 |
| matt-borland | nope | 15:34 |
| matt-borland | but I haven't done a statistical analysis :) | 15:35 |
| krotscheck | matt-borland: The reason I'm asking is because we're also seeing mirror-based coredumps only in rackspace for apt-get install. | 15:37 |
| matt-borland | interesting krotscheck | 15:37 |
| krotscheck | fungi's current thought is that all these things are hypervisor related, and have something to do with clock stepping. | 15:38 |
| matt-borland | I'll take a general look at which nodes were used | 15:38 |
| krotscheck | matt-borland: I just had a passing job in ovh | 15:38 |
| krotscheck | (not-rackspace) | 15:38 |
| matt-borland | yep | 15:38 |
| *** kzaitsev_mb has quit IRC | 15:39 | |
| sjmc7 | krotscheck: using an ER query of build_status:FAILURE AND message:"Build timed out (after 40 minutes). Marking the build as failed." AND build_name:gate-horizon-npm-run-test | 15:40 |
| krotscheck | was just doing that. | 15:40 |
| *** ankur-gupta-f has quit IRC | 15:41 | |
| sjmc7 | there’s no consistency to the failure nodes other than that at least a large number are on RAX ones, but not all of them | 15:41 |
| *** vinaypotluri has joined #openstack-horizon | 15:42 | |
| *** TravT has quit IRC | 15:44 | |
| *** ducttape_ has joined #openstack-horizon | 15:45 | |
| *** sacharya has joined #openstack-horizon | 15:46 | |
| *** sacharya has quit IRC | 15:46 | |
| robcresswell | There's 3 patches in the gate and just about to merge, that have all passed | 15:47 |
| robcresswell | Not that I've taken to permanently running zuul.openstack.org in a separate window, or anything. | 15:47 |
| *** pushkaru has joined #openstack-horizon | 15:48 | |
| matt-borland | robcresswell, it's like watching the races. | 15:49 |
| matt-borland | More like, NASCAR or drag racing | 15:49 |
| *** lucas__ has quit IRC | 15:49 | |
| robcresswell | the way it chains things is sometimes very frustrating. I dont know how it works, but the patch I was waiting for with the 9.0.1 release has been "passed" for a while now | 15:51 |
| *** lucas__ has joined #openstack-horizon | 15:54 | |
| *** lblanchard has quit IRC | 15:55 | |
| ducttape_ | robcresswell: I think the bp for neutron l3 agent info can be closed now \o/ | 15:56 |
| ducttape_ | https://blueprints.launchpad.net/horizon/+spec/admin-neutron-l3-agent done | 15:57 |
| openstackgerrit | Zhang Yun proposed openstack/horizon: Make the update user with removing email workable https://review.openstack.org/324526 | 15:57 |
| *** alexvictorchan has joined #openstack-horizon | 15:58 | |
| *** tesseract- has quit IRC | 15:59 | |
| *** lucas__ has quit IRC | 15:59 | |
| *** peristeri has quit IRC | 16:01 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: Identity Panels https://review.openstack.org/290204 | 16:01 |
| *** rcernin has quit IRC | 16:01 | |
| *** lblanchard has joined #openstack-horizon | 16:02 | |
| *** mvk_ has quit IRC | 16:03 | |
| *** yingjun_ has quit IRC | 16:07 | |
| *** ducttape_ has quit IRC | 16:07 | |
| *** yingjun has joined #openstack-horizon | 16:08 | |
| *** gyee has joined #openstack-horizon | 16:08 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: Identity Panels https://review.openstack.org/324640 | 16:10 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: Admin Panels https://review.openstack.org/290204 | 16:11 |
| *** yingjun has quit IRC | 16:12 | |
| *** lhcheng has joined #openstack-horizon | 16:13 | |
| *** ChanServ sets mode: +v lhcheng | 16:13 | |
| * krotscheck has a jenkins slave captured, let's see what he can do. | 16:15 | |
| matt-borland | awesome krotscheck | 16:20 |
| *** amotoki has quit IRC | 16:20 | |
| *** jbell8 has joined #openstack-horizon | 16:22 | |
| *** amotoki has joined #openstack-horizon | 16:22 | |
| *** wangbo has quit IRC | 16:23 | |
| *** david-lyle has quit IRC | 16:24 | |
| *** schipiga has quit IRC | 16:26 | |
| *** schipiga has joined #openstack-horizon | 16:26 | |
| *** schipiga has quit IRC | 16:27 | |
| *** sacharya has joined #openstack-horizon | 16:27 | |
| *** ducttape_ has joined #openstack-horizon | 16:29 | |
| *** amotoki has quit IRC | 16:32 | |
| *** lucas__ has joined #openstack-horizon | 16:32 | |
| *** lucas__ has quit IRC | 16:32 | |
| *** lucas__ has joined #openstack-horizon | 16:32 | |
| *** wangbo has joined #openstack-horizon | 16:36 | |
| *** kzaitsev_mb has joined #openstack-horizon | 16:37 | |
| *** sdake has joined #openstack-horizon | 16:44 | |
| *** fedexo has quit IRC | 16:44 | |
| *** tesseract has joined #openstack-horizon | 16:44 | |
| *** fedexo has joined #openstack-horizon | 16:45 | |
| *** roxanaghe has joined #openstack-horizon | 16:47 | |
| *** ankur-gupta-f has joined #openstack-horizon | 16:48 | |
| *** jtriley has joined #openstack-horizon | 16:50 | |
| *** roxanaghe has quit IRC | 16:51 | |
| *** julim has quit IRC | 16:51 | |
| *** tesseract has quit IRC | 16:51 | |
| *** ducttape_ has quit IRC | 16:51 | |
| *** fedexo has quit IRC | 16:52 | |
| *** zzxwill has quit IRC | 16:55 | |
| *** cbader has joined #openstack-horizon | 16:55 | |
| *** ducttape_ has joined #openstack-horizon | 16:57 | |
| *** ducttape_ has quit IRC | 16:57 | |
| *** ducttape_ has joined #openstack-horizon | 16:57 | |
| *** mpavlase has joined #openstack-horizon | 16:57 | |
| *** dan_nguyen has joined #openstack-horizon | 16:58 | |
| *** itxaka has quit IRC | 17:00 | |
| robcresswell | matt-borland: FYI, if a bug has been fixed elsewhere, just mark the bug invalid, unless the patch was specifically for the that bug and tracking got confused, in which case link the patch and mark Fix Released. | 17:06 |
| krotscheck | matt-borland: Ya know, I think tyr's problem with open file descriptors might be the thing that's hitting us. | 17:06 |
| krotscheck | It's hung on epoll_wait. | 17:07 |
| krotscheck | I'm increasing the file limit to check | 17:07 |
| robcresswell | krotscheck: File descriptors? Like https://review.openstack.org/#/c/321362/ ? | 17:09 |
| krotscheck | robcresswell: PErhaps, but ultimately unrelated. Basically, xenial's got a soft limit of 1024 open files per process. Given how many files are usually included during a js run, that gets exhausted quick. I'm guessing that as soon as it tries to write the coverage report, the # of open files tips that scale. | 17:11 |
| krotscheck | robcresswell: SImilar I mean. Different root cause though | 17:11 |
| * krotscheck is trying to figure out how to bump that | 17:11 | |
| krotscheck | And then recheck | 17:11 |
| robcresswell | krotscheck: Ah, interesting. Yeah, I wasn't familiar with tyr's initial suggestion, but descriptors just sent my brain straight to my mental bugipedia | 17:12 |
| robcresswell | brb | 17:14 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Navigational Breadcrumb should have contextual class https://review.openstack.org/324719 | 17:14 |
| *** ygbo has quit IRC | 17:14 | |
| *** mvk_ has joined #openstack-horizon | 17:14 | |
| *** pushkaru has quit IRC | 17:14 | |
| *** wolverineav has quit IRC | 17:18 | |
| *** ducttape_ has quit IRC | 17:22 | |
| krotscheck | matt-borland, robcresswell: Bumping up the file limits apparently has removed the issue. I'm going ro rerun a few times to make sure it doesn't hang again | 17:23 |
| *** ducttape_ has joined #openstack-horizon | 17:24 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Datepicker should inherit from theme https://review.openstack.org/318933 | 17:26 |
| *** Daisy has joined #openstack-horizon | 17:27 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Theme Preview Page should include datepicker. https://review.openstack.org/318970 | 17:30 |
| *** Daisy has quit IRC | 17:32 | |
| *** amotoki has joined #openstack-horizon | 17:32 | |
| *** pushkaru has joined #openstack-horizon | 17:36 | |
| *** amotoki has quit IRC | 17:38 | |
| matt-borland | krotscheck...awesome! :) | 17:39 |
| *** wolverineav has joined #openstack-horizon | 17:39 | |
| *** gyee has quit IRC | 17:40 | |
| *** wolverineav has quit IRC | 17:40 | |
| *** wolverineav has joined #openstack-horizon | 17:40 | |
| ducttape_ | tsufiev question on https://github.com/openstack/horizon/commit/408e358f791956e1c39e4ec2c254926ee48a8014 if you are around | 17:40 |
| tsufiev | ducttape_, I am | 17:40 |
| tsufiev | what is it? | 17:40 |
| ducttape_ | so did we really need to change the settings file to include test references? | 17:41 |
| ducttape_ | there is a copy of test settings too, where I would expect to make changes like add INTEGRATION_TESTS_SUPPORT = False | 17:41 |
| tsufiev | before or after this change? | 17:41 |
| ducttape_ | or True / whatever | 17:41 |
| ducttape_ | I'm not sure about before or after.... just pulling down latest changes to preview a deployment and seeing test reference now in the config | 17:42 |
| tsufiev | if local_settings.d/_20_integration_tests_scaffolds.py doesn't exist (only .example file), intergration tests are disabled by default | 17:43 |
| tsufiev | if you copy the file to be a valid .py setting and don't change it in any other way, then tests support is enabled | 17:43 |
| *** yamamoto has quit IRC | 17:43 | |
| tsufiev | maybe I didn't understand the question entirely... which 'test reference' do you mean? | 17:44 |
| *** vinaypotluri has left #openstack-horizon | 17:44 | |
| ducttape_ | I mean that our settings.py file refers to INTEGRATION_TESTS_SUPPORT | 17:44 |
| tsufiev | ah, so it's set to False by default | 17:44 |
| ducttape_ | and that settings is the base copy of config needed to run horizon | 17:44 |
| ducttape_ | sure, but why place test references in stuff I am deploying to prod? | 17:45 |
| tsufiev | but once enable that *_scaffolds.py it becomes True and tests are enabled | 17:45 |
| ducttape_ | thats what I am wondering | 17:45 |
| tsufiev | ducttape_, tests were inside your prod before there was any test-related settings | 17:46 |
| ducttape_ | I believe that you are right and it should have no impact, but usually we keep test config stuff separated elsewhere | 17:46 |
| ducttape_ | like https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/settings.py | 17:46 |
| tsufiev | the real point of this change is to move out tests from prod | 17:46 |
| tsufiev | having few related settings inside settings.py just simplifies handling all these paramters... a bit | 17:47 |
| ducttape_ | ah ok. it just looked strange / curious to me. not a big deal, thanks for giving more information | 17:47 |
| tsufiev | ducttape_, no, it's different. Integration tests are run on top of _real_ Horizon | 17:47 |
| *** lucas__ has quit IRC | 17:47 | |
| ducttape_ | cool, that helps | 17:48 |
| tsufiev | and in order their code to remain less complicated / more stable, some helpers were included into Horizon codebase | 17:48 |
| tsufiev | the change conditionally excludes these helpers in case it's your prod and you don't need to have integration tests support | 17:48 |
| tsufiev | ducttape_, did I answer the question? | 17:49 |
| *** lucas__ has joined #openstack-horizon | 17:49 | |
| ducttape_ | yes thank you tsufiev | 17:51 |
| tsufiev | okay :). It's good to hear that I didn't ruin anybody's deployment :) | 17:52 |
| ducttape_ | no, hurgleburgler usually does that for me :P | 17:52 |
| tsufiev | haha | 17:52 |
| krotscheck | robcresswell, tsufiev, robcresswell: https://review.openstack.org/324735, once landed, will take about 24 hours to propagate. After that we'll see whether the incidence of those timeout errors drops. | 17:52 |
| * ducttape_ likes to tease | 17:53 | |
| krotscheck | matt-borland: ^^ | 17:53 |
| hurgleburgler | (⊙.◎) | 17:53 |
| tsufiev | krotscheck, \o/ | 17:53 |
| *** lucas__ has quit IRC | 17:54 | |
| *** jbell8 has quit IRC | 17:54 | |
| krotscheck | tsufiev: It _may_ also be the root cause of the npm mirror problems we ran into. I'll try that once it lands. | 17:54 |
| tsufiev | krotscheck, while both you and me, here... I had a question regarding OpenStack & CORS | 17:54 |
| krotscheck | Sure!~ | 17:54 |
| tsufiev | how difficult / proper is it to add new allowed_headers across all components? | 17:54 |
| tsufiev | I'm working on supporting CORS for Glance and Swift in Horizon, using library ng-file-upload (for the purposes of file upload, as it names tells) | 17:55 |
| tsufiev | the library adds X-Requested-With header, which I had to manually add to Glance settings in my devstack | 17:55 |
| tsufiev | on the one hand, it has nothing to do with OpenStack set of headers | 17:55 |
| *** kzaitsev_mb has quit IRC | 17:56 | |
| tsufiev | on the other hand, if we use this library systematically in Horizon for interaction with other services (when file uploads are needed), we'll need this header supported in other components | 17:56 |
| *** lucas__ has joined #openstack-horizon | 17:56 | |
| tsufiev | well, the question is 'should CORS middlewares in other OpenStack services be client-headers agnostic?' | 17:57 |
| krotscheck | tsufiev: Ya know, to me that's a bug in the library- it should not be adding additional headers. | 17:57 |
| krotscheck | tsufiev: What I'd do is add an http request interceptor that strips it out. | 17:57 |
| tsufiev | hm... | 17:57 |
| tsufiev | sounds like a good idea in case it doesn't break library behavior ) | 17:58 |
| krotscheck | After all, the client may not have control over the server's CORS implementation (in non-openstack things) | 17:58 |
| tsufiev | I shall try it | 17:58 |
| *** lucas___ has joined #openstack-horizon | 17:58 | |
| *** lucas___ has quit IRC | 17:59 | |
| *** lucas____ has joined #openstack-horizon | 17:59 | |
| *** lucas__ has quit IRC | 17:59 | |
| tsufiev | krotscheck, thank you for the idea! Added it into my tomorrow TODO | 17:59 |
| *** jbell8 has joined #openstack-horizon | 17:59 | |
| krotscheck | tsufiev: But to answer your question specifically, it'd require a manual change to every config file at this time. The CORS middleware tries to not be opinionated about headers. | 17:59 |
| tsufiev | yes, I do not like very much this additional header either | 18:00 |
| tsufiev | will try to eradicate it | 18:00 |
| krotscheck | tsufiev: good luck :D | 18:02 |
| *** kzaitsev_mb has joined #openstack-horizon | 18:04 | |
| *** jtriley has quit IRC | 18:05 | |
| *** david-lyle has joined #openstack-horizon | 18:09 | |
| *** ChanServ sets mode: +o david-lyle | 18:09 | |
| openstackgerrit | Merged openstack/horizon: Improve system info page https://review.openstack.org/225334 | 18:10 |
| *** mvk has joined #openstack-horizon | 18:10 | |
| openstackgerrit | Merged openstack/horizon: Remove memoize that holds connections open https://review.openstack.org/321362 | 18:11 |
| *** mvk_ has quit IRC | 18:13 | |
| *** kzaitsev_mb has quit IRC | 18:15 | |
| *** pushkaru has quit IRC | 18:19 | |
| *** kzaitsev_mb has joined #openstack-horizon | 18:19 | |
| *** pushkaru has joined #openstack-horizon | 18:19 | |
| *** vijaykatam has joined #openstack-horizon | 18:21 | |
| vijaykatam | Hey guys could I get a few eyes on a couple of reviews, they are very small and tests are passing. | 18:23 |
| *** julim has joined #openstack-horizon | 18:23 | |
| vijaykatam | https://review.openstack.org/#/c/316307/ and https://review.openstack.org/#/c/318988/, if there is anything I can do to make the reviews easier let me know. Thanks | 18:24 |
| *** pt_15 has joined #openstack-horizon | 18:25 | |
| *** alexvictorchan has quit IRC | 18:30 | |
| *** amotoki has joined #openstack-horizon | 18:34 | |
| *** garthb has joined #openstack-horizon | 18:34 | |
| *** david-lyle has quit IRC | 18:35 | |
| *** kzaitsev_mb has quit IRC | 18:37 | |
| *** peristeri has joined #openstack-horizon | 18:37 | |
| *** amotoki has quit IRC | 18:39 | |
| *** alexvictorchan has joined #openstack-horizon | 18:40 | |
| *** schipiga has joined #openstack-horizon | 18:41 | |
| openstackgerrit | Daniel Castellanos proposed openstack/horizon: Flavors row level actions integration tests https://review.openstack.org/311788 | 18:43 |
| *** yamamoto has joined #openstack-horizon | 18:44 | |
| *** harlowja has quit IRC | 18:44 | |
| *** wangbo has quit IRC | 18:45 | |
| *** dan_nguyen has quit IRC | 18:45 | |
| *** wangbo has joined #openstack-horizon | 18:45 | |
| *** javeriak has joined #openstack-horizon | 18:47 | |
| *** jbell8 has quit IRC | 18:50 | |
| openstackgerrit | Ankur proposed openstack/horizon: Add Network IP Availability Extension https://review.openstack.org/283171 | 18:51 |
| *** jbell8 has joined #openstack-horizon | 18:52 | |
| *** clu_ has joined #openstack-horizon | 18:53 | |
| *** ChanServ sets mode: +v clu_ | 18:53 | |
| *** yamamoto has quit IRC | 18:53 | |
| *** kzaitsev_mb has joined #openstack-horizon | 18:55 | |
| *** alexvictorchan has quit IRC | 18:59 | |
| openstackgerrit | Ankur proposed openstack/horizon: Add Try/Exception to Extension Supported call in Ports https://review.openstack.org/324095 | 19:03 |
| *** alexvictorchan has joined #openstack-horizon | 19:03 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Datepicker should inherit from theme https://review.openstack.org/318933 | 19:09 |
| *** weezS has left #openstack-horizon | 19:22 | |
| *** david-lyle has joined #openstack-horizon | 19:24 | |
| *** ChanServ sets mode: +o david-lyle | 19:24 | |
| *** tjones has joined #openstack-horizon | 19:26 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Adding actions and views to Instance https://review.openstack.org/316244 | 19:31 |
| matt-borland | Cores: kenji-i_ has a nice patch with one +2 on it...would be good to close | 19:33 |
| *** ducttape_ has quit IRC | 19:33 | |
| *** amotoki has joined #openstack-horizon | 19:34 | |
| *** sdake has quit IRC | 19:35 | |
| robcresswell | matt-borland: You wanna link that patch or... :p | 19:37 |
| matt-borland | whoops :) | 19:37 |
| matt-borland | https://review.openstack.org/#/c/321996/ | 19:37 |
| *** sdake has joined #openstack-horizon | 19:38 | |
| *** amotoki has quit IRC | 19:39 | |
| *** openstackstatus has quit IRC | 19:39 | |
| *** openstack has joined #openstack-horizon | 19:43 | |
| *** jbell8_ has joined #openstack-horizon | 19:45 | |
| *** jbell8 has quit IRC | 19:45 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Angular modal widget for form submittal https://review.openstack.org/324785 | 19:50 |
| openstackgerrit | Merged openstack/manila-ui: Create private share types https://review.openstack.org/319637 | 19:56 |
| *** david-lyle has quit IRC | 19:57 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: getIdsOfType now returns all ids if type undefined https://review.openstack.org/321207 | 20:01 |
| *** jprovazn has quit IRC | 20:04 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: getIdsOfType now returns all ids if type undefined https://review.openstack.org/321207 | 20:07 |
| *** tqtran has joined #openstack-horizon | 20:14 | |
| *** alexvictorchan has quit IRC | 20:14 | |
| *** rcernin has joined #openstack-horizon | 20:20 | |
| *** harlowja has joined #openstack-horizon | 20:24 | |
| *** lucas____ has quit IRC | 20:29 | |
| *** alexvictorchan has joined #openstack-horizon | 20:29 | |
| *** gyee has joined #openstack-horizon | 20:31 | |
| *** lucas___ has joined #openstack-horizon | 20:31 | |
| *** kzaitsev_mb has quit IRC | 20:31 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Relax hz-table parent requirement https://review.openstack.org/321089 | 20:31 |
| *** lucas____ has joined #openstack-horizon | 20:33 | |
| *** dan_nguyen has joined #openstack-horizon | 20:33 | |
| *** lucas____ has quit IRC | 20:33 | |
| *** lucas____ has joined #openstack-horizon | 20:33 | |
| *** lucas___ has quit IRC | 20:34 | |
| *** piet_ has joined #openstack-horizon | 20:34 | |
| *** amotoki has joined #openstack-horizon | 20:35 | |
| *** lucas____ has quit IRC | 20:38 | |
| *** amotoki has quit IRC | 20:40 | |
| *** schipiga has quit IRC | 20:41 | |
| *** jbell8_ has quit IRC | 20:42 | |
| *** lucas___ has joined #openstack-horizon | 20:44 | |
| *** lucas___ has quit IRC | 20:44 | |
| *** lucas___ has joined #openstack-horizon | 20:45 | |
| *** lucas___ has quit IRC | 20:49 | |
| *** roxanagh_ has joined #openstack-horizon | 20:50 | |
| *** julim has quit IRC | 20:53 | |
| *** kzaitsev_mb has joined #openstack-horizon | 20:54 | |
| *** roxanagh_ has quit IRC | 20:55 | |
| openstackgerrit | Merged openstack/horizon: Fix untranslated strings and adding icon to OK button https://review.openstack.org/321996 | 20:59 |
| *** ducttape_ has joined #openstack-horizon | 21:01 | |
| *** lblanchard has quit IRC | 21:02 | |
| *** kzaitsev_mb has quit IRC | 21:03 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/323888 | 21:05 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/manila-ui: Updated from global requirements https://review.openstack.org/323899 | 21:06 |
| *** ducttape_ has quit IRC | 21:08 | |
| *** ankur-gupta-f1 has joined #openstack-horizon | 21:12 | |
| openstackgerrit | Juan Pablo lopez Gutierrez proposed openstack/horizon: Improved table deletion efficiency https://review.openstack.org/322282 | 21:12 |
| *** kzaitsev_mb has joined #openstack-horizon | 21:12 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Theme Preview Page should include form-inline https://review.openstack.org/324876 | 21:15 |
| *** kzaitsev_mb has quit IRC | 21:19 | |
| *** pauloewerton has quit IRC | 21:22 | |
| *** kzaitsev_mb has joined #openstack-horizon | 21:25 | |
| *** schipiga has joined #openstack-horizon | 21:25 | |
| openstackgerrit | Ankur proposed openstack/horizon: Add Network IP Availability Extension https://review.openstack.org/283171 | 21:30 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Datepicker should inherit from theme https://review.openstack.org/318933 | 21:30 |
| *** matt-borland has quit IRC | 21:33 | |
| *** schipiga has quit IRC | 21:33 | |
| *** amotoki has joined #openstack-horizon | 21:36 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Datepicker should inherit from theme https://review.openstack.org/318933 | 21:38 |
| *** rcernin_ has joined #openstack-horizon | 21:38 | |
| *** javeriak has quit IRC | 21:39 | |
| *** amotoki has quit IRC | 21:42 | |
| *** edtubill has quit IRC | 21:43 | |
| r1chardj0n3s | morning | 21:44 |
| *** kzaitsev_mb has quit IRC | 21:44 | |
| hurgleburgler | r1chardj0n3s morning | 21:44 |
| *** peristeri has quit IRC | 21:45 | |
| lcastell | o/ r1chardj0n3s | 21:46 |
| *** ducttape_ has joined #openstack-horizon | 21:49 | |
| *** kzaitsev_mb has joined #openstack-horizon | 21:50 | |
| ankur-gupta-f1 | robcresswell: Had a question about bringing out the Instances "is_deleting" out into utils | 21:52 |
| ankur-gupta-f1 | should it be brought out into its own file or become a part of another? | 21:53 |
| ankur-gupta-f1 | https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/tables.py#L77 | 21:54 |
| *** kzaitsev_mb has quit IRC | 21:59 | |
| *** ducttape_ has quit IRC | 21:59 | |
| *** ametts has quit IRC | 22:03 | |
| *** kzaitsev_mb has joined #openstack-horizon | 22:05 | |
| *** rcernin_ has quit IRC | 22:06 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Theme Preview Page should include form-inline https://review.openstack.org/324876 | 22:11 |
| *** sacharya has quit IRC | 22:17 | |
| *** openstackgerrit has quit IRC | 22:19 | |
| jlopezgu | r1chardj0n3s: morning | 22:20 |
| *** openstackgerrit has joined #openstack-horizon | 22:20 | |
| *** mpavlase has quit IRC | 22:23 | |
| tqtran | hurgleburgler: ping pong | 22:25 |
| hurgleburgler | tqtran: yo | 22:30 |
| *** dave-mccowan has quit IRC | 22:30 | |
| *** edtubill has joined #openstack-horizon | 22:41 | |
| tqtran | question | 22:45 |
| tqtran | https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/steps/create-image/create-image.html#L19 | 22:46 |
| tqtran | doesnt the required class take care of the asterisk? or do we still have to manually add that in? | 22:46 |
| tqtran | i would assume we can use the psuedo class after to insert? | 22:46 |
| *** pushkaru has quit IRC | 22:48 | |
| *** dave-mccowan has joined #openstack-horizon | 22:48 | |
| *** roxanagh_ has joined #openstack-horizon | 22:52 | |
| tqtran | also, im getting [object object] in the modal footer whenever i get a serverside error. | 22:53 |
| tqtran | https://github.com/openstack/horizon/blob/master/horizon/static/framework/widgets/wizard/wizard.controller.js#L97 | 22:53 |
| tqtran | the object is the response, but i really need is response.data (it contains the error message) | 22:54 |
| tqtran | would i have to create a custom errorhandler that resolves this? | 22:54 |
| tqtran | and what was the rationale for using just the response object to begin with? | 22:55 |
| hurgleburgler | tqtran: we use the markup: "<span class="hz-icon-required fa fa-asterisk"></span>" | 22:56 |
| *** roxanagh_ has quit IRC | 22:56 | |
| tqtran | hm... why not use a psuedo class after to append it? seems like it should and would save a bunch of work | 22:57 |
| hurgleburgler | save a bunch of work by not having to add 'fa fa-asterisk' everywhere? | 22:58 |
| *** lucas__ has joined #openstack-horizon | 22:58 | |
| hurgleburgler | the legacy doesn't have to add it everywhere … its in a single template | 22:58 |
| hurgleburgler | I always lean towards using markup when at all possible and fall back to direct css overrides when the former isn't possible | 22:59 |
| *** lucas___ has joined #openstack-horizon | 23:00 | |
| tqtran | https://jsfiddle.net/api/mdn/ example | 23:00 |
| hurgleburgler | in this case, hz-icon-required does drive the special color | 23:00 |
| tqtran | why not just add the asterisk using the after psuedo class? is declaring it have some kind of advantage? | 23:01 |
| hurgleburgler | because that complicates the css for no reason | 23:01 |
| hurgleburgler | whenyou add it to markup, its straightforward | 23:01 |
| hurgleburgler | @extending psuedo classes gets problematic also | 23:01 |
| *** lucas____ has joined #openstack-horizon | 23:02 | |
| tqtran | how does it complicate the css? | 23:02 |
| *** lucas__ has quit IRC | 23:02 | |
| tqtran | its more useful to have it, i see it having more practical advantages | 23:02 |
| hurgleburgler | you are adding extra classes to the css using an @extend, which can be problematic because it shuffles your css around depending on where you are extending and what you are extending | 23:02 |
| tqtran | not sure im following. so you're saying it is ok to add blocks of html without classes, but if we introduce classes, the reference to it is problematic how? | 23:04 |
| tqtran | isnt css rules globally applied? | 23:04 |
| hurgleburgler | I'm saying add existing classes to the html when possible | 23:05 |
| hurgleburgler | only fall back to css extend as a last resort | 23:05 |
| *** lucas___ has quit IRC | 23:05 | |
| hurgleburgler | using @extend actually shuffles your compiled css around | 23:05 |
| hurgleburgler | the ordering of css matters | 23:05 |
| hurgleburgler | especially when you hit rules of the same specificity | 23:05 |
| tqtran | but we're not using @extend (arent we using the after:: psuedo class?) | 23:05 |
| tqtran | or are they one and the same? am i misunderstanding something? | 23:05 |
| hurgleburgler | Also, that won't work with how we are currently overriding icons in themes | 23:06 |
| hurgleburgler | right now, you do a 1-1 extend of all existing icons | 23:06 |
| *** lucas____ has quit IRC | 23:06 | |
| hurgleburgler | other themes use icons other than font awesome | 23:07 |
| hurgleburgler | you can't simply hard code the ::pseudo selector | 23:07 |
| tqtran | but arent you also hard coding when you write <span class="hz-icon-required fa fa-asterisk"></span> ? | 23:07 |
| hurgleburgler | You then @extend on fa-askerisk to set up your theme override | 23:08 |
| tqtran | itsnt it more work if you have to replace all that fa fa-asterisk than a psuedo class somewhere? | 23:08 |
| tqtran | i see.... | 23:08 |
| hurgleburgler | see how material does it here: | 23:08 |
| hurgleburgler | @each $fa-icon, $mdi-icon in $icon-swap { | 23:08 |
| hurgleburgler | .fa-#{$fa-icon} { | 23:08 |
| hurgleburgler | @extend .mdi-#{$mdi-icon}; | 23:08 |
| hurgleburgler | } | 23:08 |
| hurgleburgler | } | 23:08 |
| tqtran | ok, so if you use the after psuedo class, you can still extend it no? | 23:08 |
| hurgleburgler | tqtran: we use a global template for the required markup | 23:08 |
| hurgleburgler | the angular should be using a global template as well | 23:08 |
| hurgleburgler | the icons are a 1-1 swap | 23:09 |
| *** lucas__ has joined #openstack-horizon | 23:09 | |
| hurgleburgler | straight forward, easy to understand | 23:09 |
| tqtran | ok, so i kind of understand what you're saying | 23:09 |
| hurgleburgler | if we start introducing random class names in place of icons, it will get convoluted to extend them | 23:09 |
| hurgleburgler | especially when there is already a class name that is getting extended for it | 23:10 |
| tqtran | once we have dynamic forms, its probably possible to get a global template for the required markup | 23:10 |
| *** rcernin has quit IRC | 23:10 | |
| tqtran | so until then, what you're saying is just add the markup everywhere | 23:10 |
| hurgleburgler | yeah, since its available | 23:10 |
| hurgleburgler | otherwise, you can use the same argument to replace .row … .col-md-6 … all the bootstrap classes | 23:11 |
| hurgleburgler | then it gets very difficult to understand where all your styles even live | 23:11 |
| *** lucas__ has quit IRC | 23:12 | |
| *** lucas___ has joined #openstack-horizon | 23:12 | |
| *** edtubill has quit IRC | 23:12 | |
| *** lucas__ has joined #openstack-horizon | 23:13 | |
| hurgleburgler | and tqtran dont' know if those other questions were directed at me or not, best to ask someone more familiar with that code | 23:15 |
| tqtran | yeah other question was just at anyone that could answer | 23:15 |
| *** pt_15 has quit IRC | 23:16 | |
| *** lucas___ has quit IRC | 23:17 | |
| *** pushkaru has joined #openstack-horizon | 23:17 | |
| *** weezS has joined #openstack-horizon | 23:18 | |
| *** lucas__ has quit IRC | 23:18 | |
| *** agireud has quit IRC | 23:19 | |
| *** ducttape_ has joined #openstack-horizon | 23:20 | |
| *** ducttape_ has quit IRC | 23:20 | |
| *** ducttape_ has joined #openstack-horizon | 23:20 | |
| openstackgerrit | Merged openstack/horizon: Relax hz-table parent requirement https://review.openstack.org/321089 | 23:20 |
| *** david-lyle has joined #openstack-horizon | 23:20 | |
| *** ChanServ sets mode: +o david-lyle | 23:20 | |
| *** hurgleburgler has quit IRC | 23:21 | |
| *** agireud has joined #openstack-horizon | 23:21 | |
| *** pushkaru has quit IRC | 23:22 | |
| *** lhcheng has quit IRC | 23:22 | |
| *** weezS has quit IRC | 23:24 | |
| *** hurgleburgler has joined #openstack-horizon | 23:27 | |
| *** ChanServ sets mode: +v hurgleburgler | 23:27 | |
| hurgleburgler | tqtran: I am hoping to overhaul how we are doing icons | 23:28 |
| hurgleburgler | https://blueprints.launchpad.net/horizon/+spec/horizon-theme-icons | 23:28 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/323888 | 23:29 |
| tqtran | hurgleburgler: what do you mean by abstraction layer? like our very own hz-icon? | 23:30 |
| tqtran | that would then use other icons underneath it (aka glyph, fa, etc..) | 23:30 |
| hurgleburgler | basically, yeah | 23:30 |
| tqtran | i like that idea!!! | 23:31 |
| tqtran | :) | 23:31 |
| hurgleburgler | right now … if you load material or a custom theme, even the markup still says 'fa' which is confusing | 23:31 |
| *** wolverineav has quit IRC | 23:31 | |
| tqtran | right | 23:31 |
| hurgleburgler | Also, having a layer/list that people see when they are adding icons would be nice so that we know which ones we need to extend in other themes | 23:31 |
| *** hurgleburgler has left #openstack-horizon | 23:34 | |
| *** zhurong has joined #openstack-horizon | 23:36 | |
| *** amotoki has joined #openstack-horizon | 23:39 | |
| *** zhurong has quit IRC | 23:40 | |
| *** Mounica has quit IRC | 23:42 | |
| *** Mounica has joined #openstack-horizon | 23:43 | |
| *** Mounica has quit IRC | 23:43 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Adding Identity ng-roles panel https://review.openstack.org/222825 | 23:43 |
| *** amotoki has quit IRC | 23:44 | |
| *** vishwanathj has joined #openstack-horizon | 23:49 | |
| *** roxanaghe has joined #openstack-horizon | 23:52 | |
| *** kzaitsev_mb has quit IRC | 23:53 | |
| *** sdake has joined #openstack-horizon | 23:54 | |
| *** sdake_ has quit IRC | 23:56 | |
| *** roxanaghe has quit IRC | 23:57 | |
| *** sdake has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!