| *** gberginc has joined #openstack-horizon | 00:02 | |
| *** gberginc has quit IRC | 00:07 | |
| *** alexpilotti has joined #openstack-horizon | 00:11 | |
| *** alexpilotti has quit IRC | 00:12 | |
| *** amotoki has joined #openstack-horizon | 00:17 | |
| *** kzaitsev_mb has quit IRC | 00:18 | |
| *** chlong has joined #openstack-horizon | 00:19 | |
| *** amotoki has quit IRC | 00:59 | |
| *** wolverineav has joined #openstack-horizon | 01:00 | |
| *** gberginc has joined #openstack-horizon | 01:03 | |
| *** zhurong has joined #openstack-horizon | 01:03 | |
| *** wolverineav has quit IRC | 01:04 | |
| *** gberginc has quit IRC | 01:12 | |
| *** btully has joined #openstack-horizon | 01:12 | |
| *** kzaitsev_mb has joined #openstack-horizon | 01:18 | |
| *** amotoki has joined #openstack-horizon | 01:21 | |
| *** kzaitsev_mb has quit IRC | 01:24 | |
| *** btully has quit IRC | 01:24 | |
| *** jamielennox is now known as jamielennox|away | 01:26 | |
| *** jamielennox|away is now known as jamielennox | 01:28 | |
| *** zhenguo_ has joined #openstack-horizon | 01:31 | |
| openstackgerrit | Shan Guo proposed openstack/horizon: Add a workflow step to change VIP security group https://review.openstack.org/297571 | 01:34 |
|---|---|---|
| *** wolverineav has joined #openstack-horizon | 01:38 | |
| *** amotoki has quit IRC | 01:47 | |
| *** chlong has quit IRC | 01:56 | |
| *** gberginc has joined #openstack-horizon | 02:08 | |
| *** amotoki has joined #openstack-horizon | 02:10 | |
| *** gberginc has quit IRC | 02:16 | |
| *** kzaitsev_mb has joined #openstack-horizon | 02:20 | |
| *** lnk has joined #openstack-horizon | 02:24 | |
| *** gberginc has joined #openstack-horizon | 02:24 | |
| *** kzaitsev_mb has quit IRC | 02:25 | |
| *** gberginc has quit IRC | 02:30 | |
| *** gberginc has joined #openstack-horizon | 02:32 | |
| *** gberginc has quit IRC | 02:36 | |
| *** gberginc has joined #openstack-horizon | 02:39 | |
| *** wolverineav has quit IRC | 02:39 | |
| *** wangbo has joined #openstack-horizon | 02:39 | |
| *** x00350071_ is now known as xiangxinyong | 02:42 | |
| *** gberginc has quit IRC | 02:44 | |
| *** gberginc has joined #openstack-horizon | 02:46 | |
| *** gberginc has quit IRC | 02:51 | |
| *** gberginc has joined #openstack-horizon | 02:53 | |
| *** yamamot__ has joined #openstack-horizon | 02:54 | |
| *** gberginc has quit IRC | 02:58 | |
| *** bpokorny has joined #openstack-horizon | 02:59 | |
| *** gberginc has joined #openstack-horizon | 03:00 | |
| *** jamielennox is now known as jamielennox|away | 03:06 | |
| *** gberginc has quit IRC | 03:08 | |
| *** wolverineav has joined #openstack-horizon | 03:10 | |
| *** gberginc has joined #openstack-horizon | 03:13 | |
| *** wolverineav has quit IRC | 03:15 | |
| *** yamamot__ has quit IRC | 03:19 | |
| *** kzaitsev_mb has joined #openstack-horizon | 03:21 | |
| *** kzaitsev_mb has quit IRC | 03:26 | |
| *** bpokorny has quit IRC | 03:26 | |
| *** aortega has quit IRC | 03:30 | |
| *** gberginc has quit IRC | 03:30 | |
| *** gberginc has joined #openstack-horizon | 03:34 | |
| *** jamielennox|away is now known as jamielennox | 03:36 | |
| *** gberginc has quit IRC | 03:37 | |
| *** gberginc has joined #openstack-horizon | 03:37 | |
| *** ducttape_ has joined #openstack-horizon | 03:38 | |
| *** wolverineav has joined #openstack-horizon | 03:40 | |
| *** gberginc has quit IRC | 03:41 | |
| *** wolverineav has quit IRC | 03:43 | |
| *** wolverineav has joined #openstack-horizon | 03:43 | |
| *** gberginc has joined #openstack-horizon | 03:45 | |
| *** lnk has quit IRC | 03:47 | |
| *** lnk has joined #openstack-horizon | 03:48 | |
| *** ducttape_ has quit IRC | 04:02 | |
| *** gberginc has quit IRC | 04:02 | |
| *** ducttape_ has joined #openstack-horizon | 04:02 | |
| *** ducttape_ has quit IRC | 04:07 | |
| *** gberginc has joined #openstack-horizon | 04:08 | |
| *** amotoki has quit IRC | 04:15 | |
| *** amotoki has joined #openstack-horizon | 04:16 | |
| *** Mounica has joined #openstack-horizon | 04:19 | |
| *** kzaitsev_mb has joined #openstack-horizon | 04:22 | |
| *** Mounica has quit IRC | 04:22 | |
| *** yamamot__ has joined #openstack-horizon | 04:22 | |
| *** gberginc has quit IRC | 04:27 | |
| *** kzaitsev_mb has quit IRC | 04:27 | |
| *** gberginc has joined #openstack-horizon | 04:32 | |
| *** Liuqing has joined #openstack-horizon | 04:53 | |
| *** mtanino has quit IRC | 04:58 | |
| *** gberginc has quit IRC | 05:01 | |
| *** dratushnyy has joined #openstack-horizon | 05:02 | |
| openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Add "prev" to instance list pagination https://review.openstack.org/289314 | 05:14 |
| *** rcernin has joined #openstack-horizon | 05:16 | |
| openstackgerrit | zhurong proposed openstack/horizon: Hide the flavor which disk is smaller than the old one https://review.openstack.org/316577 | 05:17 |
| *** btully has joined #openstack-horizon | 05:20 | |
| *** rcernin has quit IRC | 05:21 | |
| *** zhurong has quit IRC | 05:31 | |
| *** zhurong has joined #openstack-horizon | 05:32 | |
| *** rcernin has joined #openstack-horizon | 05:38 | |
| *** amotoki_ has joined #openstack-horizon | 05:53 | |
| *** amotoki has quit IRC | 05:54 | |
| *** gberginc has joined #openstack-horizon | 05:58 | |
| *** DevBox has joined #openstack-horizon | 05:58 | |
| *** gberginc has quit IRC | 06:03 | |
| *** shu-mutou-AFK is now known as shu-mutou | 06:04 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add recursive deletion to Swift UI https://review.openstack.org/296173 | 06:09 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Migrate swift ui to use hz-dynamic-table https://review.openstack.org/313243 | 06:13 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add recursive deletion to Swift UI https://review.openstack.org/296173 | 06:13 |
| *** kzaitsev_mb has joined #openstack-horizon | 06:23 | |
| *** dratushnyy has quit IRC | 06:24 | |
| *** kzaitsev_mb has quit IRC | 06:28 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Zanata https://review.openstack.org/315923 | 06:42 |
| *** josecastroleon has joined #openstack-horizon | 06:44 | |
| *** amotoki_ is now known as amotoki | 06:58 | |
| *** mpavlase has joined #openstack-horizon | 07:02 | |
| *** gberginc has joined #openstack-horizon | 07:04 | |
| *** gberginc_ has joined #openstack-horizon | 07:06 | |
| *** gberginc has quit IRC | 07:06 | |
| *** yingjun has joined #openstack-horizon | 07:10 | |
| *** wolverineav has quit IRC | 07:13 | |
| *** josecastroleon has quit IRC | 07:14 | |
| robcresswell | r1chardj0n3s: o/ | 07:18 |
| r1chardj0n3s | robcresswell: o/ | 07:18 |
| r1chardj0n3s | how's you, rob? | 07:18 |
| robcresswell | Good. Took a couple of days PTO, feeling relaxed. How's things with you? | 07:18 |
| r1chardj0n3s | we call those a "weekend" over here ;-) | 07:19 |
| robcresswell | I read https://caremad.io/2016/05/powering-pypi/ the other day, suddenly thought "perhaps we should be more respectful to richard.... nah" | 07:19 |
| robcresswell | haha | 07:19 |
| r1chardj0n3s | I'm doing well. Lots of things afoot in PyCon AU land at the moment | 07:19 |
| robcresswell | Exciting/ stressful? | 07:20 |
| r1chardj0n3s | yeah, Donald kinda snapped there, but it was good to clear things up | 07:20 |
| r1chardj0n3s | yes, response to CFP was amaze, and we're about to open rego so very exciting :-) | 07:21 |
| r1chardj0n3s | also I accidentally bought Stellaris on Friday | 07:22 |
| robcresswell | Ah fantastic. | 07:23 |
| robcresswell | Oh I've been avoiding that, I already have too much Total War and XCOM to play. | 07:23 |
| r1chardj0n3s | :-) | 07:23 |
| *** gberginc_ has quit IRC | 07:23 | |
| robcresswell | Good game? I've heard positive things | 07:23 |
| *** wolverineav has joined #openstack-horizon | 07:23 | |
| r1chardj0n3s | it's one of the best 4x I've played - got so much more going on than the typical 4x space game | 07:24 |
| r1chardj0n3s | lots of extra flavour | 07:24 |
| r1chardj0n3s | the ui's horrid, which is to be expected of a 4x game of course | 07:24 |
| *** kzaitsev_mb has joined #openstack-horizon | 07:24 | |
| *** jtomasek has joined #openstack-horizon | 07:26 | |
| robcresswell | Yeah I need to catch up on my games todo list. *sacrifices more sleep* | 07:26 |
| r1chardj0n3s | :-) | 07:26 |
| *** gberginc has joined #openstack-horizon | 07:27 | |
| *** Liuqing has quit IRC | 07:29 | |
| *** kzaitsev_mb has quit IRC | 07:29 | |
| robcresswell | Does DevStack run reliably on Xenial? Wondering if I can retire my 14.04 VM. I only keep it for openstack testing. | 07:30 |
| *** Liuqing has joined #openstack-horizon | 07:36 | |
| *** wolverineav has quit IRC | 07:37 | |
| openstackgerrit | Merged openstack/horizon: Ensure horizon configurations could be customized https://review.openstack.org/258833 | 07:37 |
| r1chardj0n3s | oh, also, sorry robcresswell but I'm gonna have to miss this week's meeting as my daughter's got a concert | 07:40 |
| *** vponomaryov has quit IRC | 07:43 | |
| Liuqing | that's cool :-) r1chardj0n3s | 07:45 |
| *** vponomaryov has joined #openstack-horizon | 07:45 | |
| *** luolan_ has joined #openstack-horizon | 07:45 | |
| *** gberginc has quit IRC | 07:48 | |
| *** gberginc has joined #openstack-horizon | 07:49 | |
| *** schipiga has joined #openstack-horizon | 07:51 | |
| *** gberginc has quit IRC | 07:55 | |
| *** gberginc has joined #openstack-horizon | 07:59 | |
| *** amotoki has quit IRC | 08:03 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/horizon: [WIP] Testing latest u-c https://review.openstack.org/303429 | 08:10 |
| *** amotoki has joined #openstack-horizon | 08:11 | |
| *** zhurong has quit IRC | 08:12 | |
| *** zhurong has joined #openstack-horizon | 08:12 | |
| *** zhurong has quit IRC | 08:16 | |
| robcresswell | r1chardj0n3s: Sure, no problem | 08:16 |
| *** zhurong has joined #openstack-horizon | 08:17 | |
| *** btully has quit IRC | 08:19 | |
| *** kzaitsev_mb has joined #openstack-horizon | 08:25 | |
| *** amotoki has quit IRC | 08:27 | |
| *** kzaitsev_mb has quit IRC | 08:30 | |
| *** dmk0202 has joined #openstack-horizon | 08:32 | |
| *** kzaitsev_mb has joined #openstack-horizon | 08:36 | |
| *** wolverineav has joined #openstack-horizon | 08:38 | |
| *** Daisy has joined #openstack-horizon | 08:40 | |
| *** wolverineav has quit IRC | 08:43 | |
| *** amotoki has joined #openstack-horizon | 08:46 | |
| openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Add "prev" to instance list pagination https://review.openstack.org/289314 | 08:50 |
| *** shu-mutou is now known as shu-mutou-AFK | 08:58 | |
| *** kzaitsev_mb has quit IRC | 08:59 | |
| pkarikh | Hi folks! Does anyone know where in Horizon is the code which discovers and attaches custom templates from themes? | 09:00 |
| *** kzaitsev_mb has joined #openstack-horizon | 09:03 | |
| Liuqing | pkarikh, please see :TEMPLATE_LOADERS = ('horizon.themes.ThemeTemplateLoader',) | 09:06 |
| *** kzaitsev_mb has quit IRC | 09:09 | |
| *** amotoki has quit IRC | 09:10 | |
| pkarikh | Liuqing, hmm, looks useful. Thank you! | 09:12 |
| *** btully has joined #openstack-horizon | 09:13 | |
| openstackgerrit | zhurong proposed openstack/horizon: Hide the flavor which disk is smaller than the old one https://review.openstack.org/316577 | 09:17 |
| *** Daisy has quit IRC | 09:17 | |
| *** btully has quit IRC | 09:18 | |
| *** mvk has quit IRC | 09:28 | |
| *** luolan_ has quit IRC | 09:29 | |
| *** yingjun has quit IRC | 09:34 | |
| *** yingjun has joined #openstack-horizon | 09:35 | |
| *** yingjun has quit IRC | 09:39 | |
| Liuqing | HI robcresswell, not very clear with the two line code: https://github.com/openstack/horizon/blob/master/horizon/templatetags/breadcrumb_nav.py#L43-L45 | 09:41 |
| robcresswell | Liuqing: Its just avoiding showing the Panel name if youre 'on the index for that page | 09:43 |
| robcresswell | Liuqing: Otherwise you'd have something like Project / Compute / Instances / Instances. | 09:43 |
| robcresswell | My logic looks a bit clumsy though. Could probably tidy that up. | 09:43 |
| Liuqing | Project / Compute / None in ngimage index, because of page_title not in response context | 09:45 |
| Liuqing | how about cleanup the line : breadcrumb.append((context.get('page_title'),)) robcresswell | 09:46 |
| robcresswell | Liuqing: Yeah, I didn't go through every half-developed panel :) | 09:46 |
| Liuqing | and use the panel name | 09:46 |
| robcresswell | Liuqing: Because you won't always be on a specific panel. If you're on the details page, you don't want to use the panel instead of the page_title. | 09:47 |
| robcresswell | But there are definitely some small improvements to make to the logic. | 09:47 |
| Liuqing | yeah, checked the detail page just now, it really .. | 09:49 |
| tsufiev | robcresswell, morning! btw, here http://logs.openstack.org/73/296173/12/check/gate-horizon-dsvm-integration/ef47d42/console.html all tests passed, and even no test showed too long time of execution | 09:57 |
| tsufiev | yet, the overall number of tests is already big enough that even in case of 'things going as planned' it hits global timeout :( | 09:57 |
| *** mvk has joined #openstack-horizon | 09:57 | |
| *** tosky has joined #openstack-horizon | 09:58 | |
| robcresswell | tsufiev: I haven't had time to dig into it. It still seems like a very large amount of time. Even with a slow setup, it seems to be taking 1hr+ to execute somethning like 30 tests? | 10:00 |
| robcresswell | Not sure what the actual test count is now. | 10:00 |
| tsufiev | robcresswell, 57 tests | 10:01 |
| robcresswell | Woah, thats progress. | 10:01 |
| tsufiev | if each test takes slightly more than 1 minute (which is okay), we're out of time | 10:01 |
| tsufiev | time to power on Selenium grid... | 10:03 |
| robcresswell | tsufiev: Are there specific tests taking a long time? I'm kind of reluctant to keep pushing out the test time. | 10:04 |
| robcresswell | Its already a huge blocker when random failures occur. Can take several days for an approved patch to merge with no legitimate failures. If that goes to 2, 3 hours per recheck its going to get in the way | 10:04 |
| *** kzaitsev_mb has joined #openstack-horizon | 10:08 | |
| *** zhurong has quit IRC | 10:09 | |
| *** amotoki has joined #openstack-horizon | 10:14 | |
| tsufiev | robcresswell, the thing is that tests that take more time than others are also more valuable | 10:15 |
| *** btully has joined #openstack-horizon | 10:15 | |
| tsufiev | we (me and schipiga) are aware of this problem and thinking how to address it; unfortunately, that's not an easy one-liner fix | 10:16 |
| schipiga | I suppose, we need to use selenium-grid to provide scalability of integration tests | 10:17 |
| schipiga | But seems, it's a bit infrastructure task | 10:18 |
| schipiga | big* | 10:18 |
| *** yamamot__ has quit IRC | 10:19 | |
| robcresswell | tsufiev: 1hr 21 on recheck https://review.openstack.org/#/c/296173/12 | 10:23 |
| robcresswell | Kinda interesting to see a ten min variability. | 10:23 |
| tsufiev | robcresswell, that's different nodes | 10:23 |
| robcresswell | Yep | 10:23 |
| robcresswell | I don't see any harm in temporarily pushing out the test time to prevent intermittent failures due to slow nodes, just unsure of long term solution. | 10:24 |
| tsufiev | even if everything goes fine, every time when integration tests job arrives at a node with performance lower than _some_ threshold, we'll get a failure | 10:24 |
| tsufiev | yes | 10:24 |
| tsufiev | although infra guys are not very fond with this solution | 10:24 |
| robcresswell | Sorry just trying to understand this recursive deleting | 10:26 |
| tsufiev | it's a good mental exercise ) | 10:26 |
| tsufiev | deleteFolders is the most tricky thing there | 10:27 |
| tsufiev | first, it's recursive, second it's async | 10:27 |
| robcresswell | Yeah there's some odd failures, its not reliable yet | 10:27 |
| *** btully has quit IRC | 10:27 | |
| tsufiev | from my POV code looks good already, neither I had encountered these random failures | 10:28 |
| tsufiev | so, I'll wait for more feedback there | 10:28 |
| tsufiev | since 'works for me' doesn't necessarily means 'works for everyone' | 10:28 |
| robcresswell | tsufiev: When creating some odd folder trees, its fallen over a couple of times. | 10:29 |
| tsufiev | how odd were they? | 10:29 |
| tsufiev | perhaps there were some Swift failures due to that oddness? | 10:29 |
| tsufiev | not related to a particular way of deleting folders | 10:29 |
| robcresswell | alternating odd folders, matching file names in multiple folders, matching folder names too. | 10:30 |
| robcresswell | Anything that might confuse programmers usual perceptions of file gathering. | 10:30 |
| tsufiev | hm, that doesn't seem odd enough for me :) | 10:30 |
| robcresswell | No, nothing super complex, just trying to trip the code up | 10:31 |
| *** wolverineav has joined #openstack-horizon | 10:39 | |
| *** btully has joined #openstack-horizon | 10:44 | |
| *** wolverineav has quit IRC | 10:44 | |
| *** rodrigods has quit IRC | 10:48 | |
| *** rodrigods has joined #openstack-horizon | 10:48 | |
| *** btully has quit IRC | 10:48 | |
| openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Add "prev" to instance list pagination https://review.openstack.org/289314 | 11:00 |
| *** _stowa has quit IRC | 11:13 | |
| *** jtomasek_ has joined #openstack-horizon | 11:15 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Add the Profiler panel to the Developer dashboard https://review.openstack.org/303514 | 11:16 |
| *** aortega has joined #openstack-horizon | 11:17 | |
| *** yamamoto_ has joined #openstack-horizon | 11:18 | |
| *** zhurong has joined #openstack-horizon | 11:36 | |
| *** amotoki has quit IRC | 11:36 | |
| *** jtomasek_ has quit IRC | 11:38 | |
| robcresswell | tsufiev: How's the profiler work coming along? | 11:43 |
| *** peristeri has joined #openstack-horizon | 11:48 | |
| *** kzaitsev_mb has quit IRC | 11:50 | |
| openstackgerrit | Merged openstack/horizon: [TrivialFix]Remove duplicated OS::Nova::Flavor registration https://review.openstack.org/316442 | 11:52 |
| *** amotoki has joined #openstack-horizon | 11:52 | |
| *** sdake has joined #openstack-horizon | 11:55 | |
| *** mtanino has joined #openstack-horizon | 11:57 | |
| openstackgerrit | Pallavi proposed openstack/django-openstack-auth-kerberos: Replaced deprecated 'LOG.warn' with warning https://review.openstack.org/316770 | 12:00 |
| tsufiev | robcresswell, trying to get Horizon and new osprofiler drivers system working together | 12:04 |
| *** sergio_nubeliu has joined #openstack-horizon | 12:05 | |
| *** zhurong has quit IRC | 12:07 | |
| *** amotoki has quit IRC | 12:08 | |
| *** wangbo has quit IRC | 12:09 | |
| *** kzaitsev_mb has joined #openstack-horizon | 12:10 | |
| *** jtomasek_ has joined #openstack-horizon | 12:10 | |
| *** sdake has quit IRC | 12:10 | |
| *** amotoki has joined #openstack-horizon | 12:10 | |
| *** ducttape_ has joined #openstack-horizon | 12:11 | |
| *** amotoki has quit IRC | 12:17 | |
| *** DevBox has quit IRC | 12:23 | |
| openstackgerrit | Wang Bo proposed openstack/horizon: Add policy checks in images panels https://review.openstack.org/261967 | 12:24 |
| *** wangbo has joined #openstack-horizon | 12:26 | |
| *** yamamoto_ has quit IRC | 12:27 | |
| *** ducttape_ has quit IRC | 12:29 | |
| *** yamamoto_ has joined #openstack-horizon | 12:29 | |
| openstackgerrit | Wang Bo proposed openstack/horizon: Add policy checks in images panels https://review.openstack.org/261967 | 12:31 |
| *** zqfan has quit IRC | 12:33 | |
| *** kzaitsev_mb has quit IRC | 12:38 | |
| *** julim has joined #openstack-horizon | 12:40 | |
| *** yamamoto_ has quit IRC | 12:40 | |
| *** wolverineav has joined #openstack-horizon | 12:41 | |
| *** kzaitsev_mb has joined #openstack-horizon | 12:42 | |
| *** ppiela has joined #openstack-horizon | 12:42 | |
| *** wangbo has quit IRC | 12:44 | |
| *** yamamoto_ has joined #openstack-horizon | 12:46 | |
| *** wolverineav has quit IRC | 12:46 | |
| *** yamamoto_ has quit IRC | 12:47 | |
| *** yamamoto has joined #openstack-horizon | 12:50 | |
| *** lnk has quit IRC | 12:51 | |
| *** TravT has quit IRC | 12:55 | |
| *** TravT has joined #openstack-horizon | 12:56 | |
| *** ChanServ sets mode: +v TravT | 12:56 | |
| *** yamamoto has quit IRC | 12:58 | |
| *** yamamoto has joined #openstack-horizon | 12:59 | |
| *** pauloewerton has joined #openstack-horizon | 13:01 | |
| *** wangbo has joined #openstack-horizon | 13:03 | |
| openstackgerrit | Wang Bo proposed openstack/horizon: Add policy checks in images panels https://review.openstack.org/261967 | 13:05 |
| *** xenogear has joined #openstack-horizon | 13:08 | |
| *** mtanino has quit IRC | 13:08 | |
| *** wangbo has quit IRC | 13:09 | |
| *** lblanchard has joined #openstack-horizon | 13:14 | |
| *** josecastroleon has joined #openstack-horizon | 13:16 | |
| *** wangbo has joined #openstack-horizon | 13:22 | |
| *** wangbo has quit IRC | 13:22 | |
| *** wangbo has joined #openstack-horizon | 13:22 | |
| *** Liuqing has quit IRC | 13:23 | |
| *** schipiga has quit IRC | 13:23 | |
| *** schipiga has joined #openstack-horizon | 13:27 | |
| openstackgerrit | Yosef Hoffman proposed openstack/horizon: Fix AttributeError in context_selection.py https://review.openstack.org/316847 | 13:33 |
| *** wangbo has quit IRC | 13:37 | |
| *** jtriley has joined #openstack-horizon | 13:39 | |
| *** Liuqing has joined #openstack-horizon | 13:42 | |
| *** matt-borland has joined #openstack-horizon | 13:47 | |
| *** ducttape_ has joined #openstack-horizon | 13:49 | |
| *** yamamoto has quit IRC | 13:49 | |
| *** mtanino has joined #openstack-horizon | 13:54 | |
| *** ametts has joined #openstack-horizon | 13:57 | |
| *** josecastroleon has quit IRC | 13:59 | |
| *** yingjun has joined #openstack-horizon | 14:02 | |
| *** yamamoto has joined #openstack-horizon | 14:02 | |
| openstackgerrit | Alex Meade proposed openstack/horizon: WIP: Add volume user messages https://review.openstack.org/316862 | 14:05 |
| *** josecastroleon has joined #openstack-horizon | 14:05 | |
| *** weezS has joined #openstack-horizon | 14:07 | |
| *** sdake has joined #openstack-horizon | 14:08 | |
| *** doug-fish has joined #openstack-horizon | 14:08 | |
| *** pushkaru has joined #openstack-horizon | 14:10 | |
| openstackgerrit | Alex Meade proposed openstack/horizon: WIP: Add volume user messages https://review.openstack.org/316862 | 14:11 |
| *** yamamoto has quit IRC | 14:11 | |
| openstackgerrit | Daniel Castellanos proposed openstack/horizon: Stop memoizing on request argument in neutron api https://review.openstack.org/316258 | 14:15 |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Add router L3 agent info to info page https://review.openstack.org/306619 | 14:16 |
| *** jtriley has quit IRC | 14:16 | |
| *** DevBox has joined #openstack-horizon | 14:18 | |
| openstackgerrit | Yosef Hoffman proposed openstack/horizon: Don’t error if dhcp_agent_scheduler not enabled https://review.openstack.org/313100 | 14:18 |
| *** btully has joined #openstack-horizon | 14:20 | |
| *** cbader has joined #openstack-horizon | 14:20 | |
| *** DevBox has quit IRC | 14:21 | |
| matt-borland | robcresswell, thanks for the review of the generic details...did you have any additional questions? | 14:22 |
| *** jtriley has joined #openstack-horizon | 14:23 | |
| *** yamamoto has joined #openstack-horizon | 14:24 | |
| tsufiev | robcresswell, an idea about speeding up integration tests: run git gc at github :) | 14:25 |
| *** btully has quit IRC | 14:25 | |
| tsufiev | this should significantly reduce time of devstack deploy | 14:25 |
| Liuqing | matt-borland, robcresswell, we should get the patch done as soon as possible so that we could moving on:-) | 14:25 |
| matt-borland | Liuqing, sounds good to me, that is my highest priority as well :) | 14:26 |
| matt-borland | thanks for the review! | 14:26 |
| tsufiev | what's the patch everybody is talking about? | 14:26 |
| matt-borland | I think: https://review.openstack.org/#/c/296590/ | 14:26 |
| matt-borland | Generic Details | 14:26 |
| matt-borland | robcresswell, with the breadcrumbs, the notion of Project > Compute > Images may start to degrade somewhat, as the details page can be reached from a variety of contexts (a panel, searchlight, etc.) | 14:28 |
| matt-borland | Liuqing, we have stated that both the generic details and generic table patches are scheduled to be merged by newton-1 (~30 May) | 14:29 |
| tsufiev | I see, it's worth the it ) | 14:29 |
| matt-borland | so that is our goal :) | 14:29 |
| *** woodburn1 has quit IRC | 14:30 | |
| Liuqing | matt-borland, that's cool:-) | 14:31 |
| matt-borland | I appreciate the review Liuqing, please let me know if you have other ideas as well :) | 14:32 |
| *** yamamoto has quit IRC | 14:32 | |
| Liuqing | :--) | 14:33 |
| *** yamamoto has joined #openstack-horizon | 14:34 | |
| *** josecastroleon has quit IRC | 14:35 | |
| *** vinaypotluri has joined #openstack-horizon | 14:36 | |
| *** Mounica has joined #openstack-horizon | 14:42 | |
| robcresswell | matt-borland: Hey matt. Just reading your responses | 14:42 |
| matt-borland | yep, I'm realigning the header to more closely match what we have now | 14:42 |
| matt-borland | the main issue is the actual breadcrumbs, what is appropriate to show there | 14:42 |
| robcresswell | matt-borland: I'm still kinda confused about this default details... surely that would be whatever Horizon provides, and doesnt really need to be a variable? and if it is a variable, is "default" the correct term for a specific details page? | 14:43 |
| robcresswell | And yeah I see your point about the breadcrumbs. Horizon has a similar issue now anyway, since you can hop between panels | 14:43 |
| matt-borland | oh, sure, let me try to explain... | 14:43 |
| robcresswell | So its not true navigation, its just nested panel flows. | 14:43 |
| matt-borland | with the default view, what that means is when no one has specified any details views for a resource type, let's say Hypervisors, then the app can provide a fall-through that still shows *something* about the item. | 14:44 |
| matt-borland | for example in SL we have a property viewers | 14:45 |
| matt-borland | *viewer | 14:45 |
| matt-borland | it's not pretty but it's a fall-through. | 14:45 |
| matt-borland | it's not the most important priority; if it doesn't make sense to have, we can remove it | 14:45 |
| matt-borland | because frankly if you're registering resources at all, you should have at least something for your details, hopefully | 14:45 |
| matt-borland | however for newbie developers it's nice not to break the display right away | 14:46 |
| *** Mounica has quit IRC | 14:46 | |
| *** EZPZ has joined #openstack-horizon | 14:46 | |
| *** jprovazn has joined #openstack-horizon | 14:47 | |
| *** jtriley has quit IRC | 14:47 | |
| robcresswell | Right, but we're not actually providing anything for it from the Horizon side right now? | 14:48 |
| matt-borland | We're not, but I'd be happy to add some default if that helps. | 14:48 |
| matt-borland | it's probably a good idea :) | 14:48 |
| matt-borland | even if it's a blank template for the moment. | 14:48 |
| *** jtriley has joined #openstack-horizon | 14:49 | |
| *** amotoki has joined #openstack-horizon | 14:49 | |
| robcresswell | So the idea with being mutable is that a plugin/deployment could set their own default template for details pages? | 14:50 |
| robcresswell | And yeah, it ties into one of my comments, I didn't want to make it a dependency for this patch necessarily. I like the idea of Horizon doing a simple list view with <dl> etc that can just print out any nested key val pairs. | 14:51 |
| robcresswell | So that simple details or new devs can just give a name and an api and it'll throw a page out. | 14:51 |
| *** josecastroleon has joined #openstack-horizon | 14:52 | |
| matt-borland | robcresswell, yes on the "plugin can set a default viewer when there are no views registered" | 14:52 |
| matt-borland | yeah, perhaps we can get the property viewer that TravT put together up as an add-on patch. | 14:53 |
| matt-borland | it's pretty good | 14:53 |
| matt-borland | I'll note that in the comments | 14:54 |
| robcresswell | Yeah I feel like if we're going to set defaults we should provide something sane ourself | 14:54 |
| matt-borland | exactly | 14:54 |
| matt-borland | so, do you want me to pull that piece out for now and put in the setDefault... and the default feature in a later patch, or do you want me to put in a setDefault... but not implement anything using it yet? | 14:55 |
| matt-borland | either way is fine with me | 14:55 |
| *** Mounica has joined #openstack-horizon | 14:56 | |
| robcresswell | leave it in for now is fine with me, but we should follow it up with something. On its own it seems a little odd to me. | 14:58 |
| robcresswell | No point in removing those parts just to put them in in a few days time. | 14:58 |
| matt-borland | sounds good, thanks robcresswell. | 14:59 |
| *** aortega has quit IRC | 15:00 | |
| *** julim has quit IRC | 15:01 | |
| *** julim has joined #openstack-horizon | 15:03 | |
| *** jlopezgu has quit IRC | 15:04 | |
| *** ntpttr- has joined #openstack-horizon | 15:05 | |
| *** pumaranikar has quit IRC | 15:05 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Generic details display framework https://review.openstack.org/296590 | 15:06 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Images uses generic/extensible details views https://review.openstack.org/296601 | 15:09 |
| *** btully has joined #openstack-horizon | 15:10 | |
| *** pushkaru has quit IRC | 15:10 | |
| *** david_cu_ has joined #openstack-horizon | 15:14 | |
| *** pumaranikar has joined #openstack-horizon | 15:15 | |
| *** zqfan has joined #openstack-horizon | 15:19 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Adding generic table extensibility https://review.openstack.org/309482 | 15:20 |
| *** josecastroleon has quit IRC | 15:21 | |
| pkarikh | hurgleburgler, hi! I have a question about theming. :) Have you ever got an "Non-existent template at" for actually existing template in custom theme with manage.py compress? | 15:24 |
| hurgleburgler | Hi pkarikh | 15:24 |
| hurgleburgler | Haven't had that problem … is it a template that you are overriding in a theme? | 15:25 |
| pkarikh | yep. _login_form.html and _splash.html | 15:25 |
| *** tyr_ has joined #openstack-horizon | 15:26 | |
| pkarikh | moreover, looks like Horizon can use them for rendering login page. But compress throws this error. | 15:26 |
| hurgleburgler | is the theme located in the horizon directory structure? | 15:27 |
| *** yingjun has quit IRC | 15:27 | |
| hurgleburgler | what version are you running? | 15:27 |
| *** yingjun has joined #openstack-horizon | 15:27 | |
| pkarikh | yes. theme is in openstack_dashboard/themes/. Horizon is fresh master. | 15:28 |
| *** amotoki has quit IRC | 15:28 | |
| robcresswell | Does the path match? | 15:29 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Using registration for auto-generation of Image feature https://review.openstack.org/309561 | 15:29 |
| pkarikh | robcresswell, yes. I can copypaste path from error and open file with nano | 15:29 |
| hurgleburgler | Is it only when you run your new theme? How is your AVAILABLE_THEMES and DEFAULT_THEME configured? | 15:30 |
| *** doug-fish has quit IRC | 15:30 | |
| robcresswell | pkarikh: I meant does the path to the template in the theme patch the path in the Horizon structure. Thats how it does the overrides | 15:31 |
| robcresswell | But hurgleburgler will know more about it :) | 15:31 |
| hurgleburgler | robcresswell as a good question :) How is your directory structure set up? | 15:31 |
| *** yingjun has quit IRC | 15:32 | |
| pkarikh | hurgleburgler, AVAILABLE_THEMES = [('custom', 'Custom', 'themes/custom'),] | 15:32 |
| hurgleburgler | and DEFAULT_THEME? | 15:33 |
| pkarikh | robcresswell, hurgleburgler yes, if I got you right. Full error is: `Non-existent template at: /home/paul/horizon/openstack_dashboard/themes/custom/templates/auth/_splash.html` | 15:33 |
| pkarikh | hurgleburgler, nope, there is no DEFAULT_THEME. But I also tried to add it like ('default', 'default', 'themes/default'), there is no effect | 15:35 |
| pkarikh | oh, do you mean DEFAULT_THEME var? let me check | 15:36 |
| hurgleburgler | DEFAULT_THEME take the 'key' value of your AVAILABLE_THEMES theme | 15:36 |
| hurgleburgler | DEFAULT_THEME = 'custom' | 15:36 |
| hurgleburgler | 'key' value == first element of the tuple | 15:36 |
| pkarikh | yep, DEFAULT_THEME is missing | 15:36 |
| hurgleburgler | it should still work … it should default to the only thing in your AVAILABLE_THEMES setting | 15:36 |
| hurgleburgler | if it's not doing that, then its a bug | 15:37 |
| *** kmartin has joined #openstack-horizon | 15:38 | |
| *** pushkaru has joined #openstack-horizon | 15:38 | |
| pkarikh | hurgleburgler, I set DEFAULT_THEME = 'custom' with the last line of local_settings.py and still there is no effect. I've got same errors. | 15:38 |
| pkarikh | I confused that Horizon actually can get these templates right. | 15:39 |
| hurgleburgler | pkarikh: what do you mean? | 15:39 |
| hurgleburgler | Can you configure to run 'material' and see if that compresses cleanly? | 15:40 |
| hurgleburgler | 'material' also overloads _splash.html | 15:40 |
| pkarikh | hurgleburgler, I mean that I see that horizon uses that custom template, because I see that login page is changed. But `compress` for some reason cannot find that template. | 15:40 |
| pkarikh | yes, let me try | 15:41 |
| hurgleburgler | Also, can you show 'ls /home/paul/horizon/openstack_dashboard/themes/custom' | 15:43 |
| pkarikh | hurgleburgler, with 'material' I have more errors: http://paste.openstack.org/show/497234/ :) | 15:43 |
| *** Liuqing has quit IRC | 15:43 | |
| *** dmk0202 has quit IRC | 15:44 | |
| hurgleburgler | And if you remove all AVAILABLE_THEMES and DEFAULT_THEME from your local_settings.py and just run with the default settings.py, do you get the same errors on compress? | 15:44 |
| pkarikh | hurgleburgler, >`ls openstack_dashboard/themes/custom` -> static templates | 15:45 |
| pkarikh | hurgleburgler, no, without AVAILABLE_THEMES and DEFAULT_THEME there is no errors | 15:45 |
| *** bpokorny has joined #openstack-horizon | 15:46 | |
| hurgleburgler | Do you have any old theme settings in your local_settings.py? | 15:46 |
| robcresswell | Hey, I have the same errors. | 15:47 |
| robcresswell | Hooray! | 15:47 |
| *** josecastroleon has joined #openstack-horizon | 15:47 | |
| hurgleburgler | doh! | 15:47 |
| pkarikh | hurgleburgler, no. Just searched with 'theme" key and there is nothing about it on local_settings.py | 15:48 |
| *** wangbo has joined #openstack-horizon | 15:48 | |
| pkarikh | *in | 15:48 |
| hurgleburgler | robcresswell: what local settings did you use? | 15:48 |
| robcresswell | hurgleburgler: DEFAULT_THEME = 'mterial' | 15:49 |
| robcresswell | material* | 15:49 |
| robcresswell | exactly the same errors as pkarikh | 15:49 |
| pkarikh | robcresswell, nice! So I'm not only one who have this bug. :) | 15:49 |
| robcresswell | Those templates definitely exist though. I can open those exact filepaths in vim. | 15:50 |
| hurgleburgler | robcresswell: and the error goes away when you remove your local_settings? | 15:50 |
| hurgleburgler | pkarikh: can you open a bug? | 15:50 |
| hurgleburgler | I can look at fixing it today | 15:51 |
| pkarikh | hurgleburgler, yes | 15:51 |
| robcresswell | For me the error goes as soon as I remove DEFAULT_THEME | 15:51 |
| pkarikh | hurgleburgler, https://bugs.launchpad.net/horizon/+bug/1582298 here it is | 15:56 |
| openstack | Launchpad bug 1582298 in OpenStack Dashboard (Horizon) "Django compressor cannot find custom theme templates" [Undecided,New] | 15:56 |
| *** schipiga has quit IRC | 15:56 | |
| *** vishwanathj has joined #openstack-horizon | 15:56 | |
| *** tosky has quit IRC | 15:59 | |
| hurgleburgler | Thanks pkarikh! | 16:01 |
| *** julim has quit IRC | 16:04 | |
| *** julim has joined #openstack-horizon | 16:06 | |
| pkarikh | hurgleburgler, no problem! :) | 16:06 |
| *** gyee has joined #openstack-horizon | 16:09 | |
| *** ankur-gupta-f has joined #openstack-horizon | 16:09 | |
| *** david_c__ has joined #openstack-horizon | 16:14 | |
| *** wangbo has quit IRC | 16:15 | |
| *** david_cu_ has quit IRC | 16:16 | |
| *** josecastroleon has quit IRC | 16:16 | |
| ankur-gupta-f | robcresswell: you here? | 16:19 |
| *** julim has quit IRC | 16:23 | |
| *** wolverineav has joined #openstack-horizon | 16:26 | |
| *** jlopezgu has joined #openstack-horizon | 16:26 | |
| *** lhcheng has joined #openstack-horizon | 16:27 | |
| *** ChanServ sets mode: +v lhcheng | 16:27 | |
| *** josecastroleon has joined #openstack-horizon | 16:30 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Generic details display framework https://review.openstack.org/296590 | 16:33 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Images uses generic/extensible details views https://review.openstack.org/296601 | 16:34 |
| rodrigods | lhcheng, ping... re: horizon domain scoped token support. what can i find what is working in horizon regarding that? | 16:34 |
| *** julim has joined #openstack-horizon | 16:34 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Instances: Add angular instances panel https://review.openstack.org/261376 | 16:36 |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Adding actions and views to Instance https://review.openstack.org/316244 | 16:40 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Add Line Charts to the Theme Preview Page https://review.openstack.org/316219 | 16:42 |
| *** kzaitsev_mb has quit IRC | 16:42 | |
| lhcheng | rodrigods: most of it should be working now, feature was added in mitaka-3 | 16:43 |
| lhcheng | rodrigods: https://github.com/openstack/horizon/commit/2b846515f388278e2bf8d0198a4f821309e08e69#diff-b2563902a2e374d28979194905a1ea84 | 16:43 |
| rodrigods | lhcheng, so i can do stuff like create domains, add users and projects there? | 16:44 |
| lhcheng | rodrigods: yes, using cloud admin to create domain, and domain admin for managing projects | 16:44 |
| lhcheng | rodrigods: still no HMT support though :( | 16:45 |
| rodrigods | lhcheng, got it | 16:45 |
| rodrigods | thanks lhcheng | 16:45 |
| rodrigods | will play around with it this week :) | 16:45 |
| lhcheng | rodrigods: np, ping me if you have further questions | 16:45 |
| *** revon has joined #openstack-horizon | 16:47 | |
| *** dan_nguyen has joined #openstack-horizon | 16:51 | |
| *** david_c__ has quit IRC | 17:03 | |
| *** josecastroleon has quit IRC | 17:03 | |
| *** david_cu_ has joined #openstack-horizon | 17:06 | |
| *** doug-fish has joined #openstack-horizon | 17:08 | |
| *** tosky has joined #openstack-horizon | 17:09 | |
| *** doug-fis_ has joined #openstack-horizon | 17:10 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Adding generic table extensibility https://review.openstack.org/309482 | 17:10 |
| *** david_cu_ has quit IRC | 17:10 | |
| *** wolverineav has quit IRC | 17:10 | |
| *** clu_ has joined #openstack-horizon | 17:11 | |
| *** ChanServ sets mode: +v clu_ | 17:11 | |
| *** doug-fi__ has joined #openstack-horizon | 17:12 | |
| *** david-lyle_ has quit IRC | 17:12 | |
| *** doug-fish has quit IRC | 17:13 | |
| *** david-lyle has joined #openstack-horizon | 17:13 | |
| *** ChanServ sets mode: +o david-lyle | 17:13 | |
| robcresswell | ankur-gupta-f: How can I help? | 17:14 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Adding generic table extensibility https://review.openstack.org/309482 | 17:14 |
| ankur-gupta-f | good evening. I had questions about your comments to IP Availability | 17:14 |
| *** doug-fis_ has quit IRC | 17:14 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Using registration for auto-generation of Image feature https://review.openstack.org/309561 | 17:14 |
| ankur-gupta-f | https://review.openstack.org/#/c/283171/ | 17:14 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Instances: Add angular instances panel https://review.openstack.org/261376 | 17:14 |
| robcresswell | ankur-gupta-f: Link much appreciated, thanks | 17:14 |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Adding actions and views to Instance https://review.openstack.org/316244 | 17:14 |
| *** Mounica has quit IRC | 17:15 | |
| ankur-gupta-f | the concern at the summit was the amount of api calls | 17:15 |
| ankur-gupta-f | I am working on reworking on it. but still, there is only one api call per network | 17:15 |
| *** Mounica has joined #openstack-horizon | 17:16 | |
| *** doug-fi__ has quit IRC | 17:16 | |
| robcresswell | Right, that's the same issue we discussed at the summit thought isn't it? A GET per item gets very heavy very quickly. | 17:17 |
| ankur-gupta-f | okay. Reworking should have an updated patchset for just the Network Details page. | 17:17 |
| ankur-gupta-f | Just wanted to double check | 17:17 |
| ankur-gupta-f | thanks | 17:17 |
| robcresswell | Sure, sounds good. | 17:18 |
| *** yamamoto has quit IRC | 17:18 | |
| *** yamamoto has joined #openstack-horizon | 17:18 | |
| *** yamamoto has quit IRC | 17:19 | |
| robcresswell | david-lyle: I pushed a few more bugs to stable/mitaka btw. | 17:19 |
| david-lyle | robcresswell: will look | 17:20 |
| *** yamamoto has joined #openstack-horizon | 17:21 | |
| robcresswell | david-lyle: The only just went up today, so no immediate rush. Just wanted to give you a heads up. They were all clean picks too. | 17:21 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Images uses generic/extensible details views https://review.openstack.org/296601 | 17:23 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Using registration for auto-generation of Image feature https://review.openstack.org/309561 | 17:23 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Generic details display framework https://review.openstack.org/296590 | 17:23 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Adding generic table extensibility https://review.openstack.org/309482 | 17:23 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Developer Registry Resource Browser https://review.openstack.org/313790 | 17:23 |
| *** josecastroleon has joined #openstack-horizon | 17:24 | |
| *** piet has joined #openstack-horizon | 17:29 | |
| *** mpavlase has quit IRC | 17:29 | |
| *** wolverineav has joined #openstack-horizon | 17:30 | |
| *** wolverineav has quit IRC | 17:31 | |
| *** wolverineav has joined #openstack-horizon | 17:31 | |
| *** wolverin_ has joined #openstack-horizon | 17:32 | |
| *** wolverineav has quit IRC | 17:32 | |
| *** doug-fish has joined #openstack-horizon | 17:32 | |
| *** mvk has quit IRC | 17:33 | |
| robcresswell | matt-borland: Whats the URL structure for all the angular bits and pieces going to be? Will they all follow this project/details/type/id pattern? | 17:33 |
| matt-borland | hold on robcresswell | 17:34 |
| matt-borland | rebasing issue, brb | 17:34 |
| robcresswell | Sure | 17:34 |
| *** yamamoto has quit IRC | 17:35 | |
| *** wolverin_ has quit IRC | 17:35 | |
| *** wolverineav has joined #openstack-horizon | 17:35 | |
| *** jlopezgu has quit IRC | 17:36 | |
| matt-borland | Hey robcresswell I just got my patch chain blitzed by a bad rebase, how do I best peel back a patchset...is there an easy way? | 17:37 |
| hurgleburgler | matt-borland: you can checkout that specific patchset and review it again? | 17:37 |
| matt-borland | ah, ok, thanks :) | 17:38 |
| hurgleburgler | git review -d #,{patch set #} | 17:38 |
| hurgleburgler | I think | 17:38 |
| *** doug-fish has quit IRC | 17:38 | |
| robcresswell | ^^ | 17:38 |
| robcresswell | That exactly. So git review -d 296590,20 | 17:39 |
| openstackgerrit | Ankur proposed openstack/horizon: Add Network IP Availability Extension https://review.openstack.org/283171 | 17:39 |
| robcresswell | I'm assuming tyr did a bad thing :p | 17:39 |
| tyr_ | yes :) (wasn't my fault) | 17:40 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Generic details display framework https://review.openstack.org/296590 | 17:40 |
| matt-borland | thanks hurgleburgler and robcresswell, that is working :) | 17:40 |
| hurgleburgler | matt-borland: \o/ | 17:40 |
| robcresswell | haha, git patch chaining get away from ya? | 17:40 |
| robcresswell | \o/ | 17:40 |
| tyr_ | I pulled the latest version of a change that depends on Matt's goo, made changes then did 'git review'. Git review helpfully performed an automatic rebase...and then submitted old versions of all dependent patches | 17:41 |
| robcresswell | I think its because it actually depends on specific patchsets when the chain it built | 17:41 |
| tyr_ | key I think was to rebase patch before attempting to submit any changes | 17:42 |
| robcresswell | git review should've highlighted that you were submitted all the others too though | 17:42 |
| tyr_ | sort of...it always shows the list of dependencies, not clear that it was about to make submits that overwrote dependencies | 17:43 |
| robcresswell | tbh I rarely push patches past about 2 deep, because you just end up rebasing all the time and churning on jenkins. So I just keep them locally for the most part. | 17:43 |
| tyr_ | ahhh...sounds lovely | 17:43 |
| robcresswell | Yeah not always possible. | 17:43 |
| robcresswell | matt-borland: So... URLs? | 17:44 |
| tyr_ | "not always" is euphemism for "almost never" ? | 17:44 |
| tyr_ | ;) | 17:44 |
| matt-borland | robcresswell, hold on :) | 17:44 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Images uses generic/extensible details views https://review.openstack.org/296601 | 17:45 |
| robcresswell | tyr_: Depends how much you're collaborating on a patch thats 3+ down on a patch chain. Might be easier to do the first couple then do something else while they merge. | 17:45 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Images uses generic/extensible details views https://review.openstack.org/296601 | 17:47 |
| *** rcernin has quit IRC | 17:47 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Adding generic table extensibility https://review.openstack.org/309482 | 17:47 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Using registration for auto-generation of Image feature https://review.openstack.org/309561 | 17:48 |
| tyr_ | robcresswell: for routes, the idea is that a panel exists that can display a list of any kind of resource....say /project/ngdetails | 17:48 |
| tyr_ | that panel then relies on the 2nd part of the URL to decode which resource to show /project/ngdetails/images | 17:48 |
| matt-borland | robcresswell, until we establish a better routine (looking for guidance from Django types), I'm just using project/[...] as the root | 17:49 |
| *** dratushnyy has joined #openstack-horizon | 17:49 | |
| tyr_ | where that panel is placed doesn't particularly matter, as long as it is unique w.r.t the existing Django panels. | 17:49 |
| matt-borland | but I don't think it's ideal, it's due to my limited knowledge of django | 17:49 |
| matt-borland | I'd prefer details was at something like /angular/details | 17:49 |
| *** wolverin_ has joined #openstack-horizon | 17:49 | |
| *** wolverineav has quit IRC | 17:49 | |
| matt-borland | but that didn't seem to fit into the slug/nav structure well | 17:50 |
| *** wolverineav has joined #openstack-horizon | 17:50 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Adding generic table extensibility https://review.openstack.org/309482 | 17:51 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Using registration for auto-generation of Image feature https://review.openstack.org/309561 | 17:51 |
| robcresswell | Will index pages follow the same scheme? index/<resource_type> for example | 17:51 |
| tyr_ | in general, /some_path_to_the_angular_view/<type>/<identifier> | 17:52 |
| matt-borland | robcresswell, right now it uses: /project/ng* where * is a slug-translator for the type. Check out: https://review.openstack.org/#/c/309561/ as an example | 17:53 |
| matt-borland | in each case, very much open to suggestions as to best path to user | 17:53 |
| matt-borland | but have to go to lunch at the moment...thanks robcresswell | 17:53 |
| *** doug-fish has joined #openstack-horizon | 17:53 | |
| *** tyr_ has quit IRC | 17:55 | |
| robcresswell | Yeah, I'm struggling a little with the details implementation right now. I can see the value with the generic tables, just specifying column names and actions. But the details part, especially without a generic template, not entirely seeing what it gives us. | 17:55 |
| *** doug-fish has quit IRC | 17:58 | |
| *** josecastroleon has quit IRC | 17:58 | |
| tsufiev | btw, have anyone noticed my ML post about angular file uploads? | 17:59 |
| robcresswell | tsufiev: I did! Yet to respond | 17:59 |
| *** doug-fish has joined #openstack-horizon | 17:59 | |
| tsufiev | phew | 17:59 |
| tsufiev | I feared that it did not send ) | 17:59 |
| *** josecastroleon has joined #openstack-horizon | 18:01 | |
| tsufiev | robcresswell, my primary intention with that letter was to gain some kind of community consensus on handling angular file uploads | 18:01 |
| tsufiev | I'm going to upload Create Image with local files upload in 1-2 days | 18:02 |
| robcresswell | tsufiev: When I read it initially, it wasn't entirely clear what the question was. My first thought was "Yes". | 18:02 |
| robcresswell | If you have an implementation it's probably easier to just throw it online and see what people say. Code always wins. | 18:04 |
| tsufiev | robcresswell, yeah, it was more a statement (in CONCLUSION section) which you could agree / disagree with :) | 18:04 |
| tsufiev | sure, will do | 18:04 |
| tsufiev | if I hadn't written it the same day I finished Swift UI uploads, I wouldn't have written it at all | 18:05 |
| robcresswell | Sure | 18:05 |
| tsufiev | well, 'finished' is too bold word :) | 18:05 |
| *** david_cu_ has joined #openstack-horizon | 18:06 | |
| *** julim has quit IRC | 18:07 | |
| *** julim has joined #openstack-horizon | 18:08 | |
| *** david_cu_ has quit IRC | 18:10 | |
| *** javeriak has joined #openstack-horizon | 18:12 | |
| *** doug-fis_ has joined #openstack-horizon | 18:15 | |
| *** doug-fish has quit IRC | 18:18 | |
| *** mpavlase has joined #openstack-horizon | 18:18 | |
| *** jtomasek has quit IRC | 18:19 | |
| *** doug-fis_ has quit IRC | 18:21 | |
| *** doug-fish has joined #openstack-horizon | 18:21 | |
| *** david_cu_ has joined #openstack-horizon | 18:24 | |
| *** yamamoto has joined #openstack-horizon | 18:24 | |
| *** doug-fish has quit IRC | 18:26 | |
| openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Fix actions inside instance details view page https://review.openstack.org/289932 | 18:26 |
| *** josecastroleon has quit IRC | 18:30 | |
| openstackgerrit | Ramana Raja proposed openstack/manila-ui: Add 'cephx' access type https://review.openstack.org/316430 | 18:36 |
| *** josecastroleon has joined #openstack-horizon | 18:41 | |
| *** kzaitsev_mb has joined #openstack-horizon | 18:42 | |
| *** jlopezgu has joined #openstack-horizon | 18:45 | |
| *** Mounica has quit IRC | 18:56 | |
| *** Mounica has joined #openstack-horizon | 18:57 | |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Switch cinder to usage quotas https://review.openstack.org/309204 | 18:59 |
| *** doug-fis_ has joined #openstack-horizon | 19:00 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Django compressor cannot find custom theme templates https://review.openstack.org/317051 | 19:02 |
| *** doug-fis_ has quit IRC | 19:02 | |
| hurgleburgler | pkarikh: can you try that out? ^ | 19:02 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Django compressor cannot find custom theme templates https://review.openstack.org/317051 | 19:04 |
| *** tqtran has joined #openstack-horizon | 19:04 | |
| *** Mounica has quit IRC | 19:08 | |
| *** Mounica has joined #openstack-horizon | 19:09 | |
| *** tyr_ has joined #openstack-horizon | 19:10 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Remove 'default' theme styles https://review.openstack.org/310857 | 19:11 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Legacy Transfer Table should inherit from theme https://review.openstack.org/303625 | 19:12 |
| *** josecastroleon has quit IRC | 19:13 | |
| *** weezS has quit IRC | 19:13 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Developer Registry Resource Browser https://review.openstack.org/313790 | 19:14 |
| *** cbader has left #openstack-horizon | 19:19 | |
| tsufiev | hurgleburgler: I guess he'll be able to do that in 12 hours | 19:29 |
| *** josecastroleon has joined #openstack-horizon | 19:31 | |
| *** javeriak has quit IRC | 19:33 | |
| *** rcernin has joined #openstack-horizon | 19:42 | |
| *** doug-fish has joined #openstack-horizon | 19:46 | |
| *** doug-fis_ has joined #openstack-horizon | 20:00 | |
| *** doug-fi__ has joined #openstack-horizon | 20:01 | |
| *** josecastroleon has quit IRC | 20:01 | |
| *** doug-f___ has joined #openstack-horizon | 20:02 | |
| *** doug-fish has quit IRC | 20:04 | |
| *** doug-fis_ has quit IRC | 20:05 | |
| *** doug-fi__ has quit IRC | 20:05 | |
| *** piet has quit IRC | 20:10 | |
| *** dmk0202 has joined #openstack-horizon | 20:14 | |
| *** dratushnyy has quit IRC | 20:16 | |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Improve system info page https://review.openstack.org/225334 | 20:18 |
| *** josecastroleon has joined #openstack-horizon | 20:20 | |
| openstackgerrit | Merged openstack/manila-ui: Add 'cephx' access type https://review.openstack.org/316430 | 20:23 |
| *** doug-f___ has quit IRC | 20:29 | |
| *** jprovazn has quit IRC | 20:29 | |
| *** ericksonsantos has quit IRC | 20:30 | |
| *** pauloewerton has quit IRC | 20:30 | |
| *** doug-fish has joined #openstack-horizon | 20:31 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Images uses generic/extensible details views https://review.openstack.org/296601 | 20:33 |
| *** pauloewerton has joined #openstack-horizon | 20:34 | |
| *** ericksonsantos has joined #openstack-horizon | 20:34 | |
| *** sdake has quit IRC | 20:37 | |
| *** sdake has joined #openstack-horizon | 20:37 | |
| *** pauloewerton has quit IRC | 20:41 | |
| *** ericksonsantos has quit IRC | 20:41 | |
| *** pauloewerton has joined #openstack-horizon | 20:42 | |
| *** ericksonsantos has joined #openstack-horizon | 20:42 | |
| *** bpokorny_ has joined #openstack-horizon | 20:48 | |
| *** bpokorny_ has quit IRC | 20:49 | |
| *** bpokorny_ has joined #openstack-horizon | 20:49 | |
| *** josecastroleon has quit IRC | 20:50 | |
| *** CIA has quit IRC | 20:51 | |
| *** doug-fis_ has joined #openstack-horizon | 20:51 | |
| *** josecastroleon has joined #openstack-horizon | 20:52 | |
| *** bpokorny has quit IRC | 20:52 | |
| *** doug-fish has quit IRC | 20:54 | |
| *** julim has quit IRC | 20:55 | |
| *** Mounica has quit IRC | 21:05 | |
| *** jtriley_ has joined #openstack-horizon | 21:11 | |
| r1chardj0n3s | morning | 21:12 |
| hurgleburgler | r1chardj0n3s: morning | 21:12 |
| r1chardj0n3s | tsufiev: sorry I haven't responded to your email yet, I've been very distracted lately :/ | 21:12 |
| *** jtriley has quit IRC | 21:13 | |
| *** lblanchard has quit IRC | 21:15 | |
| *** jtriley_ has quit IRC | 21:16 | |
| *** doug-fis_ has quit IRC | 21:17 | |
| matt-borland | morning r1chardj0n3s | 21:17 |
| *** doug-fish has joined #openstack-horizon | 21:18 | |
| r1chardj0n3s | hey matt-borland, I'd like to know whether my explanation on https://review.openstack.org/#/c/313243/ makes sense please :-) | 21:19 |
| r1chardj0n3s | similarly hurgleburgler, my comment on https://review.openstack.org/#/c/195371/ :-) | 21:20 |
| matt-borland | sure, I think part of the motivation for moving the search bar out was to meet accessibilty standards | 21:20 |
| r1chardj0n3s | I get that, yes | 21:20 |
| hurgleburgler | :-O | 21:20 |
| matt-borland | lemme read thru, sorry | 21:20 |
| r1chardj0n3s | hence I changed it to move the search out of the table :-) | 21:20 |
| r1chardj0n3s | *back* out of the table, to be more precise ;-) | 21:20 |
| matt-borland | ah, yeah, I just put those into a row together | 21:20 |
| *** dratushnyy1 has joined #openstack-horizon | 21:21 | |
| *** josecastroleon has quit IRC | 21:22 | |
| *** doug-fish has quit IRC | 21:22 | |
| *** Mounica has joined #openstack-horizon | 21:22 | |
| matt-borland | in other cases, e.g. <div class="row"><bar-stuffs class="col-?-?' | 21:23 |
| r1chardj0n3s | ahh, to have it share space on the row, I need to use the bootstraps | 21:23 |
| r1chardj0n3s | of course | 21:23 |
| matt-borland | "><div class="col-?-?"><actions ...></div></div> | 21:23 |
| r1chardj0n3s | thanks :-) | 21:23 |
| matt-borland | np, sorry for the confusion! | 21:23 |
| *** dratushnyy1 has quit IRC | 21:25 | |
| *** doug-fish has joined #openstack-horizon | 21:25 | |
| *** doug-fish has quit IRC | 21:26 | |
| *** doug-fish has joined #openstack-horizon | 21:27 | |
| *** bpokorny_ has quit IRC | 21:30 | |
| *** bpokorny has joined #openstack-horizon | 21:31 | |
| *** doug-fish has quit IRC | 21:32 | |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Switch cinder to usage quotas https://review.openstack.org/309204 | 21:32 |
| ducttape_ | bpokorny and ankur-gupta-f ^ I switched around the cinder quota thing, to make the new behavior configurable.... thanks for taking a look at it | 21:33 |
| *** doug-fish has joined #openstack-horizon | 21:33 | |
| bpokorny | ducttape_: Cool. I'll take another look. | 21:33 |
| *** doug-fish has quit IRC | 21:37 | |
| *** doug-fish has joined #openstack-horizon | 21:38 | |
| *** doug-fish has quit IRC | 21:38 | |
| *** doug-fish has joined #openstack-horizon | 21:38 | |
| *** josecastroleon has joined #openstack-horizon | 21:42 | |
| *** matt-borland has quit IRC | 21:43 | |
| *** pauloewerton has quit IRC | 21:54 | |
| ankur-gupta-f | alright ducttape_: will take a crack at it later tonight. | 21:55 |
| ducttape_ | ankur-gupta-f: - it probably needs some help, I'd imagine. any of my patches can be amended by others fwiw | 21:56 |
| *** EZPZ has quit IRC | 21:59 | |
| ankur-gupta-f | ducttape_: you don't want me touching it, I would probably ruin everything :P | 22:01 |
| ducttape_ | too late :p | 22:01 |
| tsufiev | r1chardj0n3s: no worries, you're not alone :) | 22:03 |
| *** david_cu_ has quit IRC | 22:04 | |
| tsufiev | I'll try to finalize the patch for create image from local file asap so code would speak for itself - as discussed with robcresswell | 22:05 |
| r1chardj0n3s | ok | 22:05 |
| *** doug-fish has quit IRC | 22:07 | |
| *** dmk0202 has quit IRC | 22:10 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Developer Registry Resource Browser https://review.openstack.org/313790 | 22:11 |
| *** josecastroleon has quit IRC | 22:12 | |
| *** doug-fis_ has joined #openstack-horizon | 22:13 | |
| *** jlopezgu has quit IRC | 22:14 | |
| *** doug-fi__ has joined #openstack-horizon | 22:16 | |
| tsufiev | r1chardj0n3s: btw, would you take a look at https://review.openstack.org/#/c/316025/ | 22:17 |
| tsufiev | It's an xstatic lib update | 22:17 |
| tsufiev | For file uploads | 22:17 |
| *** doug-fis_ has quit IRC | 22:18 | |
| *** doug-fi__ has quit IRC | 22:21 | |
| *** ducttape_ has quit IRC | 22:22 | |
| r1chardj0n3s | yup | 22:27 |
| openstackgerrit | Merged openstack/xstatic-angular-fileupload: Update XStatic-Angular-FileUpload to 12.0.4.0 https://review.openstack.org/316025 | 22:27 |
| tsufiev | Thanks! | 22:31 |
| *** mpavlase has quit IRC | 22:33 | |
| *** piet has joined #openstack-horizon | 22:36 | |
| *** doug-fish has joined #openstack-horizon | 22:40 | |
| *** ametts has quit IRC | 22:41 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Add Line Charts to the Theme Preview Page https://review.openstack.org/316219 | 22:43 |
| *** doug-fish has quit IRC | 22:44 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Add Line Charts to the Theme Preview Page https://review.openstack.org/316219 | 22:44 |
| *** pushkaru has quit IRC | 22:46 | |
| *** piet has quit IRC | 22:50 | |
| *** piet has joined #openstack-horizon | 22:52 | |
| *** peristeri has quit IRC | 22:59 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Modals should inherit from the theme https://review.openstack.org/309581 | 23:00 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Add Line Charts to the Theme Preview Page https://review.openstack.org/316219 | 23:00 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon Spinner/Loader should inherit from theme. https://review.openstack.org/313685 | 23:00 |
| *** Mounica has quit IRC | 23:01 | |
| *** doug-fish has joined #openstack-horizon | 23:02 | |
| *** lhcheng has quit IRC | 23:02 | |
| *** lhcheng has joined #openstack-horizon | 23:02 | |
| *** ChanServ sets mode: +v lhcheng | 23:02 | |
| *** pushkaru has joined #openstack-horizon | 23:03 | |
| *** itisha has joined #openstack-horizon | 23:03 | |
| *** wolverin_ has joined #openstack-horizon | 23:04 | |
| *** wolverin_ has quit IRC | 23:06 | |
| *** piet has quit IRC | 23:07 | |
| *** wolverineav has quit IRC | 23:08 | |
| *** rcernin has quit IRC | 23:08 | |
| *** pushkaru has quit IRC | 23:10 | |
| *** kenji-i has joined #openstack-horizon | 23:12 | |
| *** tyr_ has quit IRC | 23:16 | |
| openstackgerrit | Vijay Katam proposed openstack/horizon: Fix pep8 and update tests https://review.openstack.org/316307 | 23:19 |
| *** Mounica has joined #openstack-horizon | 23:20 | |
| *** tqtran has quit IRC | 23:26 | |
| *** vkramskikh_ has joined #openstack-horizon | 23:31 | |
| *** wolverineav has joined #openstack-horizon | 23:31 | |
| *** wolverineav has quit IRC | 23:35 | |
| *** wolverineav has joined #openstack-horizon | 23:35 | |
| *** jamielennox is now known as jamielennox|away | 23:51 | |
| zackf | I'm having issues launching an instance with the next gen angular workflow... I get CSRF errors, i can only use the NG panel if i disable the CSRF middleware. Anyone seen this before? | 23:52 |
| r1chardj0n3s | hmm, haven't seen that, no. | 23:56 |
| r1chardj0n3s | are you running through a proxy? | 23:56 |
| zackf | yeah | 23:58 |
| zackf | using Haproxy | 23:58 |
| zackf | I'm thinking it's an issue with passing the correct headers or something. | 23:58 |
| r1chardj0n3s | maybe it's blocking / munging the csrf cookie? | 23:58 |
| r1chardj0n3s | yeah | 23:58 |
| r1chardj0n3s | so there should be a cookie called 'csrftoken' | 23:59 |
| zackf | Indeed. | 23:59 |
| *** revon has quit IRC | 23:59 | |
| r1chardj0n3s | and it has to be sent back from the client to the horizon server in a header called X-CSRFToken | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!