| *** ediardo has quit IRC | 00:00 | |
| *** darrenc_ has joined #openstack-horizon | 00:06 | |
| *** Mounica has quit IRC | 00:07 | |
| *** patk has quit IRC | 00:07 | |
| *** darrenc has quit IRC | 00:07 | |
| *** vkramskikh has quit IRC | 00:07 | |
| *** patk has joined #openstack-horizon | 00:07 | |
| *** lhcheng has quit IRC | 00:10 | |
| *** ducttape_ has joined #openstack-horizon | 00:10 | |
| *** vkramskikh has joined #openstack-horizon | 00:13 | |
| *** mtanino has quit IRC | 00:13 | |
| *** SeYeon has joined #openstack-horizon | 00:13 | |
| *** SimonChung has quit IRC | 00:14 | |
| *** ducttape_ has quit IRC | 00:15 | |
| *** patk has quit IRC | 00:21 | |
| *** patk has joined #openstack-horizon | 00:22 | |
| *** ducttape_ has joined #openstack-horizon | 00:23 | |
| *** garthb has quit IRC | 00:23 | |
| *** darrenc_ is now known as darrenc | 00:25 | |
| *** ducttape_ has quit IRC | 00:33 | |
| *** cshahani has quit IRC | 00:34 | |
| *** vishwanathj has joined #openstack-horizon | 00:34 | |
| *** tyr_ has joined #openstack-horizon | 00:34 | |
| TravT | r1chardj0n3s: hey, sorry missed this... just hacked something really quick to show what i mean. | 00:36 |
|---|---|---|
| TravT | genuine hack | 00:36 |
| TravT | but for fun, i combined ngcontainers and containers | 00:36 |
| TravT | (deleted project/ngcontainers) | 00:37 |
| TravT | http://paste.openstack.org/show/490822/ | 00:37 |
| r1chardj0n3s | that doesn't allow people to switch back to old containers though (through enabled file) does it? that was a primary concern IIUC | 00:39 |
| TravT | nope, it doesn't | 00:39 |
| *** tyr_ has quit IRC | 00:39 | |
| *** ducttape_ has joined #openstack-horizon | 00:39 | |
| TravT | just showing what i meant by url registration | 00:39 |
| TravT | in quick hack | 00:39 |
| TravT | it works for index routing | 00:40 |
| *** neelashah has joined #openstack-horizon | 00:43 | |
| r1chardj0n3s | I'm not sure that it's doing anything differently except bringing the ngcontainers index into the containers module | 00:44 |
| r1chardj0n3s | oh, but I think that's your actual point, right | 00:44 |
| *** cloudtrainme has joined #openstack-horizon | 00:45 | |
| r1chardj0n3s | but still, I'm pretty sure the concern with my patch(es) was the inability to trivially switch back to the old containers view, which would require urls.py code hacking with your hack? | 00:45 |
| *** ankurgupta has joined #openstack-horizon | 00:45 | |
| TravT | yes, my point was actually that in django and angular both register the same urls for their respective routing mechanism, that upon lookup of the url it didn't matter to other code who provided the actual routing. | 00:47 |
| TravT | so horizon:project:containers:index lookup would give heat mapping (or whatever) a working URL either way. | 00:49 |
| openstackgerrit | Brad Pokorny proposed openstack/horizon: Add Horizon support for volume consistency groups https://review.openstack.org/257630 | 00:50 |
| r1chardj0n3s | right, except that the URL pattern differs for the angular implementation, because there will be other functionality down the track | 00:50 |
| r1chardj0n3s | '^((?P<container_name>.+?)/)?(?P<subfolder_path>(.+/)+)?$' vs '^(container/(?P<container_name>.+?)/(?P<subfolder_path>(.+/)+)?)?$' | 00:51 |
| r1chardj0n3s | and I get what you're saying about the HEAT urlresolvers.reverse() only needing to know about one of them, but again that fallback then becomes tricky | 00:52 |
| *** ducttape_ has quit IRC | 00:52 | |
| TravT | yes, additional functionality is tough, but from heat perspective and other pages right now, i think they are most concerned with the resource lookup | 00:53 |
| TravT | just to get to it | 00:53 |
| TravT | actions, etc, no | 00:53 |
| TravT | and the angular way of doing that is by resource_type in the registry. | 00:53 |
| *** jtriley has joined #openstack-horizon | 00:54 | |
| r1chardj0n3s | afaict no other pages use reverse() to look up swift stuff | 00:54 |
| *** chlong has joined #openstack-horizon | 00:55 | |
| TravT | yeah, perhaps not for swift | 00:57 |
| TravT | but this will be encountered on other cases | 00:57 |
| TravT | for example instance details page looks up volume and images | 00:57 |
| TravT | https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/views.py#L300-L301 | 00:57 |
| r1chardj0n3s | yep | 00:58 |
| *** shu-mutou-AFK is now known as shu-mutou | 00:58 | |
| TravT | swift only shows up in mappings and current swift | 00:59 |
| TravT | https://github.com/openstack/horizon/search?p=1&q=%22horizon%3Aproject%3Acontainers%3A%22&type=Code&utf8=%E2%9C%93 | 00:59 |
| r1chardj0n3s | can I get to the enabled DISABLED flags from in django code easily? I can't figure out how I might do it | 00:59 |
| r1chardj0n3s | as in if your USE_NG wasn't such a hack, and actually looked to see which panel was enabled (even if both) then it could be viable | 01:00 |
| r1chardj0n3s | (I'm only calling it a hack because you did ;-) | 01:00 |
| *** xinwu has quit IRC | 01:00 | |
| TravT | well, you could get to settings. | 01:01 |
| TravT | i don't know about enabled | 01:01 |
| TravT | but if you register the same slug in the panel | 01:01 |
| TravT | "containers" | 01:01 |
| *** clu_ has quit IRC | 01:02 | |
| TravT | it doesn't like it even if only one is enabled. | 01:02 |
| r1chardj0n3s | yup | 01:02 |
| r1chardj0n3s | oh wait | 01:02 |
| r1chardj0n3s | duh yeah, your change would remove one of the enabled files | 01:02 |
| r1chardj0n3s | there would need to be a separate switch | 01:03 |
| TravT | (hack) | 01:03 |
| r1chardj0n3s | having it in the panel's config file would be nice, but I don't believe we can do that | 01:03 |
| r1chardj0n3s | wait | 01:03 |
| r1chardj0n3s | UPDATE_HORIZON_CONFIG | 01:03 |
| r1chardj0n3s | isn't used by anything, but could be for this | 01:04 |
| r1chardj0n3s | ok, Imma use your hack and see how far it goes | 01:04 |
| *** kzaitsev_mb has quit IRC | 01:04 | |
| TravT | maybe david-lyle knows how you can make it so that slug and path don't have to match | 01:04 |
| *** bpokorny has quit IRC | 01:04 | |
| TravT | anyway, i gotta go get food | 01:05 |
| TravT | will check back later | 01:05 |
| r1chardj0n3s | ok | 01:05 |
| TravT | my brain waved the white flag a little bit ago, i think. | 01:05 |
| r1chardj0n3s | no worries, mine hasn't yet. thanks for the pointer | 01:06 |
| *** zhurong has joined #openstack-horizon | 01:07 | |
| *** cloudtrainme has quit IRC | 01:11 | |
| *** zzxwill has quit IRC | 01:13 | |
| *** chlong has quit IRC | 01:18 | |
| *** Drago1 has quit IRC | 01:19 | |
| *** piet has quit IRC | 01:22 | |
| *** zzxwill has joined #openstack-horizon | 01:23 | |
| *** piet has joined #openstack-horizon | 01:28 | |
| *** Daisy has joined #openstack-horizon | 01:30 | |
| *** chlong has joined #openstack-horizon | 01:31 | |
| *** Daisy has quit IRC | 01:32 | |
| *** Daisy has joined #openstack-horizon | 01:33 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: WIP: Make ngcontainers the default Swift UI https://review.openstack.org/293168 | 01:34 |
| r1chardj0n3s | TravT (/david-lyle, etc, etc) ^^ | 01:36 |
| *** Daisy has quit IRC | 01:37 | |
| r1chardj0n3s | whups, missed the WIP in the commit message :/ | 01:40 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Make ngcontainers the default Swift UI https://review.openstack.org/293168 | 01:40 |
| *** zzxwill has quit IRC | 01:41 | |
| *** zzxwill has joined #openstack-horizon | 01:44 | |
| *** tqtran-afk has quit IRC | 01:48 | |
| *** piet has quit IRC | 01:49 | |
| *** zzxwill has quit IRC | 01:52 | |
| *** dan_nguyen has quit IRC | 01:52 | |
| *** zzxwill has joined #openstack-horizon | 01:55 | |
| *** cshahani has joined #openstack-horizon | 01:56 | |
| *** Daisy has joined #openstack-horizon | 01:58 | |
| *** kzaitsev_mb has joined #openstack-horizon | 02:00 | |
| *** Daisy has quit IRC | 02:01 | |
| *** Daisy has joined #openstack-horizon | 02:02 | |
| *** ttrifonov_ has quit IRC | 02:12 | |
| *** ttrifonov has joined #openstack-horizon | 02:13 | |
| *** darrenc has quit IRC | 02:19 | |
| *** josecastroleon1 has quit IRC | 02:19 | |
| *** slunkad_ has quit IRC | 02:19 | |
| *** tsufiev has quit IRC | 02:19 | |
| *** ski1 has quit IRC | 02:19 | |
| *** tyr_ has joined #openstack-horizon | 02:20 | |
| *** ducttape_ has joined #openstack-horizon | 02:20 | |
| *** dan_nguyen has joined #openstack-horizon | 02:21 | |
| *** ducttape_ has quit IRC | 02:21 | |
| *** zhurong has quit IRC | 02:22 | |
| *** Daisy_ has joined #openstack-horizon | 02:22 | |
| *** Daisy has quit IRC | 02:22 | |
| *** jtriley has quit IRC | 02:22 | |
| TravT | r1chardj0n3s: that looks suspiciously familiar. :P | 02:22 |
| *** cshahani has quit IRC | 02:24 | |
| *** dan_nguyen has quit IRC | 02:24 | |
| *** tyr_ has quit IRC | 02:25 | |
| *** darrenc has joined #openstack-horizon | 02:25 | |
| *** josecastroleon1 has joined #openstack-horizon | 02:25 | |
| *** slunkad_ has joined #openstack-horizon | 02:25 | |
| *** tsufiev has joined #openstack-horizon | 02:25 | |
| *** ski1 has joined #openstack-horizon | 02:25 | |
| *** jtriley has joined #openstack-horizon | 02:26 | |
| *** ducttape_ has joined #openstack-horizon | 02:27 | |
| *** kzaitsev_mb has quit IRC | 02:28 | |
| *** zhurong has joined #openstack-horizon | 02:29 | |
| *** cshahani has joined #openstack-horizon | 02:35 | |
| *** Daisy_ has quit IRC | 02:36 | |
| *** Daisy has joined #openstack-horizon | 02:36 | |
| *** ducttape_ has quit IRC | 02:40 | |
| *** piet has joined #openstack-horizon | 02:40 | |
| *** ducttape_ has joined #openstack-horizon | 02:41 | |
| *** jtriley has quit IRC | 02:42 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: WIP Searchlight Search Panel https://review.openstack.org/227036 | 02:42 |
| *** wangbo has joined #openstack-horizon | 02:43 | |
| *** jtriley has joined #openstack-horizon | 02:43 | |
| *** ducttape_ has quit IRC | 02:47 | |
| *** jtriley has quit IRC | 02:49 | |
| *** wangbo has quit IRC | 02:49 | |
| *** Daisy_ has joined #openstack-horizon | 02:51 | |
| *** Daisy has quit IRC | 02:51 | |
| r1chardj0n3s | TravT: I wasn't sure - would you like a co-author? | 02:52 |
| *** zzxwill has quit IRC | 02:53 | |
| *** cshahani has quit IRC | 02:55 | |
| *** jtriley has joined #openstack-horizon | 02:56 | |
| *** zzxwill has joined #openstack-horizon | 02:58 | |
| *** lhcheng has joined #openstack-horizon | 03:07 | |
| *** gariveradlt has joined #openstack-horizon | 03:07 | |
| *** wangbo has joined #openstack-horizon | 03:08 | |
| openstackgerrit | Wang Bo proposed openstack/horizon: Pass page_url instead of whole request to render https://review.openstack.org/292004 | 03:08 |
| *** piet has quit IRC | 03:10 | |
| *** slogan has quit IRC | 03:15 | |
| *** zzxwill has quit IRC | 03:15 | |
| *** zzxwill has joined #openstack-horizon | 03:17 | |
| *** lhcheng has quit IRC | 03:18 | |
| *** zzxwill has quit IRC | 03:22 | |
| *** kzaitsev_mb has joined #openstack-horizon | 03:25 | |
| *** kzaitsev_mb has quit IRC | 03:31 | |
| *** zzxwill has joined #openstack-horizon | 03:33 | |
| *** lhcheng has joined #openstack-horizon | 03:36 | |
| *** neelashah has quit IRC | 03:37 | |
| *** lhcheng_ has joined #openstack-horizon | 03:37 | |
| *** jtriley has quit IRC | 03:39 | |
| *** lhcheng has quit IRC | 03:40 | |
| openstackgerrit | Merged openstack/horizon: Make region list case-insensitive sorted https://review.openstack.org/292197 | 03:41 |
| *** jtriley has joined #openstack-horizon | 03:41 | |
| *** jtriley has quit IRC | 03:45 | |
| *** jtriley has joined #openstack-horizon | 03:46 | |
| *** tyr_ has joined #openstack-horizon | 03:51 | |
| *** piet has joined #openstack-horizon | 03:51 | |
| *** tyr_ has quit IRC | 03:55 | |
| *** Daisy_ has quit IRC | 03:56 | |
| *** SimonChung has joined #openstack-horizon | 03:57 | |
| *** SimonChung1 has joined #openstack-horizon | 03:59 | |
| *** SimonChung has quit IRC | 04:02 | |
| *** gariveradlt has quit IRC | 04:06 | |
| openstackgerrit | Wang Bo proposed openstack/horizon: Pass page_url instead of whole request to render https://review.openstack.org/292004 | 04:09 |
| *** zzxwill has quit IRC | 04:13 | |
| *** Daisy has joined #openstack-horizon | 04:17 | |
| *** jtriley has quit IRC | 04:18 | |
| *** piet has quit IRC | 04:20 | |
| *** kzaitsev_mb has joined #openstack-horizon | 04:27 | |
| *** kzaitsev_mb has quit IRC | 04:32 | |
| *** zzxwill has joined #openstack-horizon | 04:36 | |
| *** Daisy has quit IRC | 04:36 | |
| *** wolverineav has quit IRC | 04:42 | |
| *** vgridnev has joined #openstack-horizon | 04:43 | |
| *** masco has joined #openstack-horizon | 04:43 | |
| *** fedexo has joined #openstack-horizon | 04:47 | |
| *** tyr_ has joined #openstack-horizon | 04:52 | |
| *** zzxwill_ has joined #openstack-horizon | 04:55 | |
| *** zzxwill has quit IRC | 04:56 | |
| *** tyr_ has quit IRC | 04:56 | |
| *** zzxwill_ has quit IRC | 05:00 | |
| *** wolverineav has joined #openstack-horizon | 05:03 | |
| *** Daisy has joined #openstack-horizon | 05:03 | |
| *** zzxwill has joined #openstack-horizon | 05:05 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Make ngcontainers the default Swift UI https://review.openstack.org/293168 | 05:06 |
| *** cshahani has joined #openstack-horizon | 05:07 | |
| *** wolverineav has quit IRC | 05:07 | |
| *** cshahani has quit IRC | 05:11 | |
| *** wolverineav has joined #openstack-horizon | 05:12 | |
| *** cshahani has joined #openstack-horizon | 05:17 | |
| *** dratushnyy has joined #openstack-horizon | 05:23 | |
| *** lhcheng has joined #openstack-horizon | 05:29 | |
| *** lhcheng_ has quit IRC | 05:29 | |
| *** adiantum has joined #openstack-horizon | 05:37 | |
| *** lhcheng has quit IRC | 05:43 | |
| *** zzxwill has quit IRC | 05:53 | |
| *** zzxwill has joined #openstack-horizon | 05:54 | |
| *** Daisy has quit IRC | 06:01 | |
| *** Daisy has joined #openstack-horizon | 06:02 | |
| *** deray has joined #openstack-horizon | 06:07 | |
| *** chlong has quit IRC | 06:08 | |
| *** cshahani has quit IRC | 06:11 | |
| *** vishwanathj is now known as vishwanathj_zzz | 06:12 | |
| *** zzxwill has quit IRC | 06:17 | |
| *** Daisy has quit IRC | 06:17 | |
| *** roxanagh_ has joined #openstack-horizon | 06:17 | |
| *** zzxwill has joined #openstack-horizon | 06:18 | |
| *** itisha has quit IRC | 06:19 | |
| *** chlong has joined #openstack-horizon | 06:21 | |
| *** roxanagh_ has quit IRC | 06:22 | |
| *** kzaitsev_mb has joined #openstack-horizon | 06:29 | |
| *** BigWillie has joined #openstack-horizon | 06:33 | |
| *** BigWillie has quit IRC | 06:34 | |
| *** kzaitsev_mb has quit IRC | 06:35 | |
| *** zzxwill has quit IRC | 06:36 | |
| *** zzxwill has joined #openstack-horizon | 06:37 | |
| *** tyr_ has joined #openstack-horizon | 06:40 | |
| *** fedexo has quit IRC | 06:41 | |
| *** tyr_ has quit IRC | 06:45 | |
| *** zzxwill has quit IRC | 06:56 | |
| *** Daisy has joined #openstack-horizon | 06:59 | |
| tsufiev | robcresswell: morning! Do you think there is a chance that we sort out issues with Django19 support in M? | 07:00 |
| *** zzxwill has joined #openstack-horizon | 07:02 | |
| *** Daisy has quit IRC | 07:03 | |
| *** zzxwill_ has joined #openstack-horizon | 07:04 | |
| *** zzxwill has quit IRC | 07:04 | |
| *** tesseract has joined #openstack-horizon | 07:15 | |
| *** tesseract is now known as Guest57182 | 07:15 | |
| *** vgridnev has quit IRC | 07:17 | |
| *** adiantum has quit IRC | 07:21 | |
| *** gberginc has joined #openstack-horizon | 07:22 | |
| *** aortega has quit IRC | 07:22 | |
| *** kzaitsev_mb has joined #openstack-horizon | 07:30 | |
| *** Daisy has joined #openstack-horizon | 07:34 | |
| *** kzaitsev_mb has quit IRC | 07:35 | |
| openstackgerrit | Yury Tregubov proposed openstack/horizon: Added test for flavor metadata update https://review.openstack.org/293860 | 07:35 |
| *** rcernin has joined #openstack-horizon | 07:39 | |
| *** Daisy has quit IRC | 07:48 | |
| *** Daisy has joined #openstack-horizon | 07:49 | |
| *** dratushnyy has quit IRC | 07:49 | |
| *** belmoreira has joined #openstack-horizon | 07:52 | |
| *** Daisy has quit IRC | 07:53 | |
| *** mpavlase has joined #openstack-horizon | 07:54 | |
| *** chlong has quit IRC | 07:57 | |
| *** Daisy has joined #openstack-horizon | 08:04 | |
| *** wolverineav has quit IRC | 08:12 | |
| *** vgridnev has joined #openstack-horizon | 08:16 | |
| *** schipiga has joined #openstack-horizon | 08:16 | |
| *** dratushnyy has joined #openstack-horizon | 08:20 | |
| *** pcaruana has joined #openstack-horizon | 08:24 | |
| dratushnyy | Hi folks, could you take a look on https://review.openstack.org/#/c/289314/ | 08:24 |
| *** yamamoto_ has joined #openstack-horizon | 08:29 | |
| *** tyr_ has joined #openstack-horizon | 08:29 | |
| *** kzaitsev_mb has joined #openstack-horizon | 08:31 | |
| *** zzxwill_ has quit IRC | 08:33 | |
| *** tyr_ has quit IRC | 08:34 | |
| *** zzxwill has joined #openstack-horizon | 08:35 | |
| binBASH | Hi, Question regarding Forms... When I create new Form in Instance Overview and call it from Instance Detail, is it possible to come back into Instance Detail instead into the Instance Overview after the form post? | 08:35 |
| *** xinwu has joined #openstack-horizon | 08:36 | |
| *** kzaitsev_mb has quit IRC | 08:36 | |
| mrunge | binBASH, success_url | 08:38 |
| binBASH | thanks | 08:45 |
| *** kzaitsev_mb has joined #openstack-horizon | 08:48 | |
| *** zzxwill has quit IRC | 08:54 | |
| *** ygbo has joined #openstack-horizon | 08:54 | |
| *** zzxwill has joined #openstack-horizon | 08:54 | |
| openstackgerrit | Alexandra Allakhverdieva proposed openstack/horizon: Added test for check stacks creation and deletion functionality https://review.openstack.org/266368 | 09:02 |
| openstackgerrit | Shan Guo proposed openstack/horizon: Correct the director in Customizing doc https://review.openstack.org/293887 | 09:02 |
| *** onovy has quit IRC | 09:07 | |
| *** zhurong has quit IRC | 09:10 | |
| r1chardj0n3s | tsufiev: what issues? | 09:12 |
| * r1chardj0n3s is popping in and out this evening | 09:12 | |
| *** wolverineav has joined #openstack-horizon | 09:12 | |
| *** wolverineav has quit IRC | 09:17 | |
| *** tmazur has quit IRC | 09:23 | |
| *** tmazur_ has joined #openstack-horizon | 09:23 | |
| openstackgerrit | Yury Tregubov proposed openstack/horizon: Added test for image create from local file https://review.openstack.org/293898 | 09:25 |
| *** Daisy has quit IRC | 09:26 | |
| *** Daisy has joined #openstack-horizon | 09:26 | |
| *** Daisy_ has joined #openstack-horizon | 09:28 | |
| *** aortega has joined #openstack-horizon | 09:29 | |
| *** kzaitsev_mb has quit IRC | 09:29 | |
| tsufiev | r1chardj0n3s: any *py27-dj19 job that still fails | 09:30 |
| *** xinwu has quit IRC | 09:31 | |
| *** onovy has joined #openstack-horizon | 09:31 | |
| *** vishwanathj_ has joined #openstack-horizon | 09:31 | |
| *** Daisy has quit IRC | 09:31 | |
| r1chardj0n3s | ah, right | 09:32 |
| r1chardj0n3s | tsufiev: did you see https://review.openstack.org/293168? | 09:33 |
| robcresswell | tsufiev: That depends. If I work on dj19, I stop reviewing. | 09:36 |
| *** Daisy_ has quit IRC | 09:47 | |
| *** Daisy has joined #openstack-horizon | 09:48 | |
| tsufiev | r1chardj0n3s, yeah, was going to review it today | 09:49 |
| tsufiev | robcresswell, I've tried to understand this morning how bad is the fact that Horizon cannot be packaged in Sid Debian - and came to a conclusion that it's tolerable | 09:50 |
| tsufiev | Sid is unstable, Horizon & Django19 issue is not our problem, but theirs :) | 09:51 |
| r1chardj0n3s | tsufiev: thanks | 09:51 |
| r1chardj0n3s | I wasn't aware that dj19 compat was a priority for M or I'd have paid more attention :-( | 09:51 |
| tsufiev | r1chardj0n3s, it's a priority for zigo, not necessary for us | 09:52 |
| *** Daisy has quit IRC | 09:52 | |
| zigo | r1chardj0n3s: Sid has Django 1.9, meaning that I can't upload Horizon in Debian if it doesn't support it. | 09:53 |
| r1chardj0n3s | right | 09:53 |
| tsufiev | living on a bleeding edge has its cons | 09:53 |
| zigo | tsufiev: Django 1.9 isn't bleeding edge, it's been the current upstream release for a long time already, and Django 1.8 is already out of security support upstream. | 09:54 |
| mrunge | zigo, that's wrong | 09:54 |
| mrunge | plainly wrong | 09:54 |
| zigo | mrunge: Ah? That's what the django maintainer in Debian told me !!! | 09:54 |
| mrunge | Django-1.8 is long term supported | 09:54 |
| zigo | Really? I'm surprised. | 09:54 |
| mrunge | django-1.7 is out of support | 09:54 |
| mrunge | oh yes | 09:54 |
| mrunge | zigo: https://www.djangoproject.com/weblog/2016/mar/05/bugfix-releases/ | 09:55 |
| zigo | So, either Raphael Hertzhog (aka: buxy) was wrong, or I missunderstood him. | 09:55 |
| mrunge | or htis one: https://www.djangoproject.com/weblog/2016/mar/01/security-releases/ | 09:55 |
| zigo | Thanks for correcting me. | 09:55 |
| mrunge | I bet, django-1.7 and earlier are affected by that cve as well | 09:55 |
| zigo | Never the less, Django 1.9 was out a long time ago, and IMO, we should already be working on the Django 1.10 deprecation messages. | 09:55 |
| mrunge | zigo, I was a bit astonished, Debian wants to support something short lived like django-1.9 | 09:56 |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:56 | |
| robcresswell | Well, sort of. Jessie is on 1.7 and backports is on 1.8 I think. | 09:56 |
| zigo | mrunge: Probably Stretch will have time to upgrade to Django 1.10 before it's frozen. | 09:57 |
| mrunge | zigo, and Django-1.9 was released on Dec 1st 2015 | 09:57 |
| zigo | mrunge: There's going to be 1.10 before september, no? | 09:57 |
| robcresswell | Either way, its something I want to address, but it means not reviewing in the meantime | 09:57 |
| mrunge | probably yes zigo. | 09:57 |
| robcresswell | And I can't force people to look at RC1 blueprints | 09:57 |
| zigo | So, in time for Stretch... | 09:58 |
| mrunge | and yes, you all are right, we should support django-1.9 | 09:58 |
| zigo | robcresswell: How far are we now? | 09:58 |
| robcresswell | So either, I stop reviewing RC1 bps, work on dj19, or we hit our RC1 targets. Can't have both | 09:58 |
| robcresswell | zigo: Last time I ran the tests there were 6 failures all on a single panel (i.e. likely one fault) | 09:59 |
| zigo | robcresswell: Please do dj9 !!! :) | 09:59 |
| tsufiev | robcresswell, please don't :) | 09:59 |
| r1chardj0n3s | oh, I remember .9 | 09:59 |
| zigo | tsufiev: What's your point of argumentation? | 09:59 |
| r1chardj0n3s | those were the days | 09:59 |
| mrunge | either we're only broken on debian or we're broken at all? | 10:00 |
| zigo | tsufiev: This is also blocking me for all the Horizon plugins, and we need them for MOS ASAP. | 10:00 |
| mrunge | is that where it boils down to? | 10:00 |
| tsufiev | zigo, my point is that things we're trying to address right now in RC1 are more important than Django19 support | 10:00 |
| tsufiev | we don't use Django19 yet | 10:00 |
| mrunge | ^^ | 10:00 |
| tsufiev | so it's not such a blocker for us | 10:00 |
| zigo | tsufiev: So, no Horizon in Debian is fine by your book?!? | 10:00 |
| mrunge | I would stick on django-1.8 | 10:00 |
| mrunge | as installs will probably live longer than django-1.9 | 10:00 |
| tsufiev | zigo, I agree here with mrunge | 10:01 |
| zigo | tsufiev: Talk with Dmitry Borodaenko, you'll see he has a very different opinion. | 10:01 |
| zigo | (ie: same as mine) | 10:01 |
| mrunge | zigo: so, you'd prefer a broken horizon on debian more than a fixed horizon in general? | 10:01 |
| *** JeanBriceCombebi has quit IRC | 10:02 | |
| mrunge | I mean, you're controlling the debian side | 10:02 |
| zigo | mrunge: Can't we have a working horizon that also works on Django 1.9 ? | 10:02 |
| zigo | Why is it mutually exclusive? | 10:02 |
| mrunge | zigo, it seems to boil down to either or | 10:02 |
| mrunge | because of time limitations | 10:02 |
| robcresswell | If I don't sleep until Saturday, potentially :) | 10:02 |
| zigo | Couldn't someone take a bit of rob's work, so he can finish 1.9 support? | 10:03 |
| robcresswell | We're all swamped | 10:03 |
| zigo | :( | 10:03 |
| robcresswell | I have the luxury of being primarily upstream, but most others have company work to do. | 10:03 |
| robcresswell | So its not as simple as just handing over reviews. | 10:03 |
| zigo | I wish I had enough skills to be able to help. :/ | 10:04 |
| zigo | I did what I could, but that's still limited. | 10:04 |
| zigo | robcresswell: Maybe you can work on this *later*? | 10:04 |
| zigo | I don't mind if that's after the first RC1... | 10:04 |
| zigo | Well, I do, but no choice. | 10:05 |
| tsufiev | r1chardj0n3s, I got an initial impression that the new Swift UI enablement patch causes endless page refresh, trying to understand what really happens... | 10:05 |
| *** JeanBriceCombebi has joined #openstack-horizon | 10:05 | |
| tsufiev | robcresswell, have you seen something like that ^^ ? | 10:06 |
| robcresswell | tsufiev: :/ nope | 10:07 |
| robcresswell | I just pulled my stack down too, gimme 20 mins | 10:07 |
| *** liorf has joined #openstack-horizon | 10:08 | |
| *** zzxwill has quit IRC | 10:09 | |
| *** liorf has left #openstack-horizon | 10:09 | |
| r1chardj0n3s | tsufiev: that's weird | 10:11 |
| r1chardj0n3s | I've never seen that | 10:11 |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Improve quota unit tests coverage https://review.openstack.org/285390 | 10:12 |
| tsufiev | r1chardj0n3s, did you test it on non-empty WEBROOT? | 10:12 |
| *** JeanBriceCombebi has quit IRC | 10:13 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 10:13 | |
| r1chardj0n3s | tsufiev: no, I didn't, but that shouldn't be any different to the master version | 10:15 |
| *** yamamoto_ has quit IRC | 10:17 | |
| *** tyr_ has joined #openstack-horizon | 10:18 | |
| *** JeanBriceCombebi has quit IRC | 10:20 | |
| betherly | sorry r1chardj0n3s i was on holiday yesterday :) | 10:20 |
| *** JeanBriceCombebi has joined #openstack-horizon | 10:20 | |
| betherly | feel free to ping me any qs | 10:20 |
| r1chardj0n3s | betherly: ohai, no problem. I will be looking into the ironic plugin next week I imagine. It has suddenly become Of Interest To My Masters :-) | 10:21 |
| r1chardj0n3s | betherly: so if you have some sort of plan you could share with me, of things I could focus on, that'd be great | 10:21 |
| betherly | r1chardj0n3s: ah i hear ya ;) cool ok well advance info is v1.0 is released, v1 bug fixing atm | 10:22 |
| r1chardj0n3s | okie | 10:22 |
| *** tyr_ has quit IRC | 10:22 | |
| *** zzxwill has joined #openstack-horizon | 10:23 | |
| betherly | r1chardj0n3s: heres the roadmap for v2 https://etherpad.openstack.org/p/ironic-plugin-roadmap-v2 | 10:23 |
| r1chardj0n3s | betherly: ok, I'll have a good look at that tomorrow | 10:23 |
| robcresswell | Yeah, the powers that be at Cisco also want me to remain in the know about ironic-ui and magnum-ui | 10:24 |
| betherly | r1chardj0n3s: awesome! well as i say, any qs ping me | 10:24 |
| betherly | r1chardj0n3s: robcresswell: will be interesting to see if the readme works well for you setting it up as its based on my experience and memory of what i did | 10:26 |
| tsufiev | r1chardj0n3s, so far url http://localhost:8000/project/containers/container/ (on my zero-WEBROOT dev setup) is being constantly requested | 10:26 |
| tsufiev | and on >2 times the referred of the request is that page itself | 10:26 |
| *** yamamoto has joined #openstack-horizon | 10:27 | |
| * tsufiev going to take a cup of coffee and continue investigation | 10:27 | |
| *** bradjones has quit IRC | 10:27 | |
| r1chardj0n3s | betherly: I followed the readme and it worked well, yes. I actually have more complete install instructions for my co-workers https://gist.github.com/r1chardj0n3s/6956d0bc374285a4aff4 | 10:28 |
| *** kzaitsev_mb has joined #openstack-horizon | 10:29 | |
| r1chardj0n3s | tsufiev: hmm, weird. how did you get to that URL? It actually makes no sense | 10:29 |
| r1chardj0n3s | http://localhost:8000/project/containers/ makes sense, but http://localhost:8000/project/containers/container/ would expect a name after the slash for the container name | 10:29 |
| r1chardj0n3s | ah, so I see they didn't fix the Flashy Psychedelic Graphics Glitch Of Doom in the final level of XCOM2 with that recent patch :-( | 10:30 |
| betherly | r1chardj0n3s: oh nice ok! would be interested to know if other people would like horizon install instructions on the main ironic-ui readme. could easily add them if you think would be a helpful addition | 10:30 |
| r1chardj0n3s | it might be useful just to point to the quickstart docs, really | 10:31 |
| tsufiev | r1chardj0n3s, oh, is that psychedelic glitch is constantly reproducing for you? | 10:31 |
| r1chardj0n3s | tsufiev: I've played the final level in two playthroughs now, have had it both times :-( | 10:31 |
| tsufiev | okay, seems that I should slow down my pace even more :) | 10:31 |
| tsufiev | until they deliver next patch | 10:31 |
| r1chardj0n3s | worst thing is that the baddies you have to hunt down go back into unpopped-pod mode when you reload because of the glitch, so you have to hunt them down all over again :-( | 10:32 |
| *** kzaitsev_mb has quit IRC | 10:34 | |
| robcresswell | Looks like I should hold off on buying for a bit longer | 10:34 |
| *** absubram has quit IRC | 10:34 | |
| r1chardj0n3s | robcresswell: it's still a heck of a good game, and it takes a while to get to the last level, and you should get it when M is done :-) | 10:35 |
| tsufiev | r1chardj0n3s, speaking of Horizon & Swift, take a look at http://imgur.com/sWDf5Xp | 10:35 |
| tsufiev | containers/container is what sidebar tells me | 10:36 |
| *** bradjones has joined #openstack-horizon | 10:36 | |
| *** bradjones has quit IRC | 10:36 | |
| *** bradjones has joined #openstack-horizon | 10:36 | |
| robcresswell | What is this, a screenshot for ants? | 10:36 |
| *** shu-mutou is now known as shu-mutou-AFK | 10:36 | |
| r1chardj0n3s | lol | 10:36 |
| r1chardj0n3s | tsufiev: hmm, that's odd | 10:36 |
| tsufiev | http://i.imgur.com/sWDf5Xp.png this one is better | 10:36 |
| tsufiev | r1chardj0n3s, robcresswell ^^ | 10:37 |
| robcresswell | Yeah, I figured it out with my epic web skillz. | 10:38 |
| r1chardj0n3s | hmm. I tried to get apache-fronted horizon working on my laptop so I could test WEBROOT stuff but I couldn't get it working :-( I'll have to see if I can find some other method of testing WEBROOT :-( | 10:38 |
| *** tosky has joined #openstack-horizon | 10:44 | |
| tsufiev | r1chardj0n3s, solved! see my last comment in gerrit | 10:44 |
| r1chardj0n3s | \o/ | 10:44 |
| r1chardj0n3s | oh | 10:45 |
| r1chardj0n3s | I need that URL | 10:45 |
| r1chardj0n3s | :-) | 10:45 |
| tsufiev | seems that you don't :) | 10:45 |
| tsufiev | works for me | 10:45 |
| r1chardj0n3s | that's the one that makes stacks mappings work :-( | 10:45 |
| tsufiev | oh | 10:45 |
| tsufiev | ... and breaks the UI | 10:45 |
| r1chardj0n3s | yeah | 10:45 |
| r1chardj0n3s | what if you remove the first one? | 10:45 |
| r1chardj0n3s | just have the second | 10:45 |
| robcresswell | Oh. I wonder if its reversing :index and hitting the last definition of it, since the names are the same | 10:46 |
| r1chardj0n3s | I need to try something | 10:47 |
| tsufiev | r1chardj0n3s, nope, second url alone still causes the refresh loop | 10:48 |
| r1chardj0n3s | robcresswell: oh, perhaps swapping them | 10:48 |
| r1chardj0n3s | tsufiev: maybe try swap them? | 10:48 |
| r1chardj0n3s | hmm | 10:48 |
| r1chardj0n3s | ok, I have a better idea | 10:48 |
| r1chardj0n3s | much better idea | 10:48 |
| r1chardj0n3s | rename the second one to "container" | 10:48 |
| tsufiev | works! | 10:48 |
| tsufiev | swapping fixes the issue :) | 10:49 |
| r1chardj0n3s | oh | 10:49 |
| r1chardj0n3s | durn, I was gonna try a "better" solution | 10:49 |
| r1chardj0n3s | but if that works :-) | 10:49 |
| tsufiev | renaming seems to work also | 10:50 |
| *** e0ne has joined #openstack-horizon | 10:50 | |
| r1chardj0n3s | renaming will work but will require more changes to code which I'm not gonna attempt at 10pm | 10:50 |
| *** sanjana has joined #openstack-horizon | 10:50 | |
| *** rodrigods has quit IRC | 10:51 | |
| *** rodrigods has joined #openstack-horizon | 10:51 | |
| tsufiev | r1chardj0n3s, will you submit swapping patchset? | 10:51 |
| tsufiev | or I can do it | 10:51 |
| r1chardj0n3s | I will, have just tested it locally | 10:51 |
| r1chardj0n3s | thanks | 10:51 |
| tsufiev | btw, there may be some issues with running it under non-empty WEBROOT | 10:51 |
| tsufiev | I still cannot tell if I broke something in my Devstack when pulled you patch into it, or is it another legitimate issue | 10:52 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Make ngcontainers the default Swift UI https://review.openstack.org/293168 | 10:52 |
| r1chardj0n3s | thanks robcresswell for the hint and thanks tsufiev for investigating! | 10:52 |
| tsufiev | but, I'd rather fix that in RC2 because the new UI is still 100 times better than it was | 10:53 |
| openstackgerrit | Yury Tregubov proposed openstack/horizon: Added test remove protected image https://review.openstack.org/281235 | 10:53 |
| openstackgerrit | Yury Tregubov proposed openstack/horizon: Added tests to check change of ram and disk size https://review.openstack.org/293944 | 10:53 |
| tsufiev | r1chardj0n3s, you're welcome :) | 10:53 |
| *** zzxwill has quit IRC | 10:55 | |
| *** sjmc7 has quit IRC | 10:56 | |
| *** sjmc7 has joined #openstack-horizon | 10:57 | |
| *** kzaitsev_mb has joined #openstack-horizon | 10:57 | |
| *** zzxwill has joined #openstack-horizon | 10:58 | |
| *** zzxwill has quit IRC | 11:01 | |
| *** kzaitsev_mb has quit IRC | 11:02 | |
| *** JeanBriceCombebi has quit IRC | 11:11 | |
| *** wolverineav has joined #openstack-horizon | 11:14 | |
| *** zzxwill has joined #openstack-horizon | 11:15 | |
| *** wolverineav has quit IRC | 11:18 | |
| *** vgridnev has quit IRC | 11:19 | |
| *** shu-mutou-AFK has quit IRC | 11:20 | |
| r1chardj0n3s | Defender of Humanity, again, oh yes. And with that, I'm off to bed. G'night :-) | 11:21 |
| robcresswell | night r1chardj0n3s | 11:22 |
| *** jtriley has joined #openstack-horizon | 11:27 | |
| *** yamamoto has quit IRC | 11:34 | |
| *** vishwanathj_ has quit IRC | 11:34 | |
| *** sanjana has quit IRC | 11:35 | |
| *** zzxwill has quit IRC | 11:35 | |
| *** kzaitsev_mb has joined #openstack-horizon | 11:39 | |
| *** yamamoto has joined #openstack-horizon | 11:42 | |
| *** vgridnev has joined #openstack-horizon | 11:43 | |
| robcresswell | tsufiev: Running UTs verbosely highlights some interesting delays | 11:47 |
| tsufiev | robcresswell, ? | 11:47 |
| *** chlong has joined #openstack-horizon | 11:48 | |
| *** openstackgerrit has quit IRC | 11:48 | |
| *** Daisy has joined #openstack-horizon | 11:48 | |
| *** openstackgerrit has joined #openstack-horizon | 11:49 | |
| robcresswell | tsufiev: http://paste.openstack.org/show/490874/ Look at test_server_list :) | 11:49 |
| robcresswell | Just interesting seeing what takes time. That one takes 150x the others in time. | 11:49 |
| robcresswell | At least I assume that is time? | 11:49 |
| tsufiev | looks like it's hitting timeout | 11:50 |
| tsufiev | I think it's time | 11:50 |
| robcresswell | Indeed. I think I'll run through those next cycle and see if we can speed it up a bit. | 11:51 |
| tsufiev | debugging tests is like looking into abyss | 11:51 |
| *** mtanino has joined #openstack-horizon | 11:52 | |
| * tsufiev is trying to understand JS race conditions happening in i9n tests at Matt's patch for Volume Snapshots | 11:52 | |
| robcresswell | Yeah, so all the failures for dj19 are in Volumes | 11:53 |
| robcresswell | all the volumes tests fail, but every other panel passes :p | 11:53 |
| *** Daisy has quit IRC | 11:54 | |
| tsufiev | the truth is that Volumes panels are most covered with i9n tests so far | 11:55 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Fix remaining Django 1.9 test failures https://review.openstack.org/280222 | 11:55 |
| robcresswell | Interesting | 11:55 |
| tsufiev | I have one idea, trying to upload new patchset to Matt's patch soon | 11:56 |
| tsufiev | *going | 11:56 |
| *** zzxwill has joined #openstack-horizon | 11:57 | |
| robcresswell | Wow Jenkins return time is <50 minutes right now | 11:58 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Allow Launch Instance (Angular) from Volume Snapshots https://review.openstack.org/289379 | 11:59 |
| tsufiev | RC freeze in effect? | 12:01 |
| tsufiev | hope that will fix i9n failures ^^ | 12:01 |
| *** tyr_ has joined #openstack-horizon | 12:07 | |
| *** Mounica has joined #openstack-horizon | 12:08 | |
| *** tyr_ has quit IRC | 12:11 | |
| *** Mounica has quit IRC | 12:13 | |
| *** yamamoto has quit IRC | 12:14 | |
| *** wolverineav has joined #openstack-horizon | 12:16 | |
| *** yamamoto has joined #openstack-horizon | 12:20 | |
| *** jtriley has quit IRC | 12:20 | |
| *** wolverineav has quit IRC | 12:21 | |
| openstackgerrit | Yury Tregubov proposed openstack/horizon: Added test remove protected image https://review.openstack.org/281235 | 12:25 |
| robcresswell | Okay, +2'd consistency groups patch 1 and angular swift | 12:26 |
| *** vgridnev has quit IRC | 12:26 | |
| pkarikh | Folks, does anyone know what should I do with glance md-namcespace to get it in horizon's Available Metadata form? | 12:27 |
| robcresswell | tsufiev: Looking at https://review.openstack.org/#/c/289337/ again now | 12:27 |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Improve quota unit tests coverage https://review.openstack.org/285390 | 12:28 |
| *** jtriley has joined #openstack-horizon | 12:29 | |
| *** rdopiera has joined #openstack-horizon | 12:31 | |
| *** vgridnev has joined #openstack-horizon | 12:32 | |
| tsufiev | robcresswell, /me crossed fingers :) | 12:32 |
| *** jtriley has quit IRC | 12:34 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Update URLs to Django 1.8+ style https://review.openstack.org/280901 | 12:35 |
| robcresswell | tsufiev: The thing is, it works... I'm still not entirely sure *why* | 12:36 |
| robcresswell | I assume that its because bound_url is what is updated by the quota checks? Need to dig through the table JS more | 12:37 |
| *** lapalm has joined #openstack-horizon | 12:42 | |
| *** piet has joined #openstack-horizon | 12:42 | |
| *** tosky has quit IRC | 12:44 | |
| *** yamamoto has quit IRC | 12:48 | |
| *** SeYeon has quit IRC | 12:51 | |
| *** masco has quit IRC | 12:52 | |
| *** SeYeon has joined #openstack-horizon | 12:53 | |
| tsufiev | robcresswell, btw, Swift patch still doesn't work for non-empty WEBROOT | 12:53 |
| tsufiev | that's majority of production Horizon setups | 12:54 |
| *** jpomeroy has joined #openstack-horizon | 12:54 | |
| *** amotoki has joined #openstack-horizon | 12:57 | |
| tsufiev | robcresswell, bound_url is usually set here https://github.com/openstack/horizon/blob/master/horizon/tables/base.py#L1400 - which means that it is being set for row actions only | 12:58 |
| *** yamamoto has joined #openstack-horizon | 12:58 | |
| *** peristeri has joined #openstack-horizon | 12:59 | |
| *** jprovazn has joined #openstack-horizon | 13:02 | |
| *** jtriley has joined #openstack-horizon | 13:02 | |
| robcresswell | tsufiev: Ack, I'll remove +2 | 13:03 |
| *** neelashah has joined #openstack-horizon | 13:04 | |
| *** wangbo has quit IRC | 13:05 | |
| *** pauloewerton has joined #openstack-horizon | 13:07 | |
| *** mtanino has quit IRC | 13:07 | |
| robcresswell | tsufiev: Sure, so if_table_action should trigger it to use get_link_url no? | 13:07 |
| tsufiev | robcresswell, not sure, that would blur the distinction between table and row actions | 13:09 |
| *** matt-borland has joined #openstack-horizon | 13:09 | |
| tsufiev | I suspect something will break if table_action sets bound_url | 13:09 |
| tsufiev | robcresswell, it's all complicated :( | 13:11 |
| robcresswell | tsufiev: What I mean is, that is_table_action is passed into that template here https://github.com/openstack/horizon/blob/master/horizon/templates/horizon/common/_data_table_table_actions.html#L44 | 13:12 |
| tsufiev | robcresswell, if I remove <base> tag here https://review.openstack.org/#/c/293168/6/openstack_dashboard/dashboards/project/containers/templates/containers/ngindex.html initial rendering works | 13:12 |
| tsufiev | but then folder traversal is broken | 13:12 |
| robcresswell | tsufiev: So it should go to link_url | 13:12 |
| robcresswell | and link_url *should* still be correct I thought? Or are we expecting it to use bound_url? | 13:12 |
| * tsufiev looking | 13:13 | |
| *** lblanchard has joined #openstack-horizon | 13:14 | |
| *** wolverineav has joined #openstack-horizon | 13:17 | |
| matt-borland | tsufiev, thank you for researching the integration test failures | 13:19 |
| matt-borland | ! | 13:19 |
| tsufiev | matt-borland, wow, it passed :) | 13:19 |
| tsufiev | we're lucky | 13:19 |
| robcresswell | \o/ | 13:19 |
| matt-borland | :) | 13:19 |
| tsufiev | there are still some JS timing issues lurking in the dark | 13:20 |
| tsufiev | I just rewritten some delete operations to avoid them | 13:20 |
| robcresswell | There's a -1 on the patch above it in the chain | 13:20 |
| robcresswell | Do we have time to address that? | 13:20 |
| tsufiev | yes, I'm going to address it today | 13:20 |
| tsufiev | I think I'm finished with Richard's patch | 13:20 |
| tsufiev | not very proficient with these <base> issues | 13:21 |
| tsufiev | matt-borland, could you look at it? | 13:21 |
| tsufiev | https://review.openstack.org/#/c/293168/6 | 13:21 |
| matt-borland | sure, what is the context? | 13:21 |
| tsufiev | it's the problems with Angular and WEBROOT | 13:21 |
| matt-borland | oh, heh, yeah, I can look at that :) | 13:21 |
| *** wolverineav has quit IRC | 13:22 | |
| tsufiev | matt-borland, thanks :) | 13:22 |
| * tsufiev hands over his Angular Swift UI shift to matt-borland | 13:23 | |
| matt-borland | So wait, to be clear before I start tsufiev, the note says "If I remove <base>..."...why would we remove the base tag? | 13:23 |
| matt-borland | I'll dig around, reading back | 13:24 |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:26 | |
| *** yamamoto has quit IRC | 13:28 | |
| robcresswell | matt-borland: Looks like WEBROOT is borken on Swift | 13:31 |
| robcresswell | I admit, I didnt try it. | 13:31 |
| matt-borland | yeah, I'm going to set up a webroot-style proxy here. | 13:31 |
| tsufiev | matt-borland, because if we don't then Angular Swift panel won't render at all (on setups with non-empty WEBROOT) | 13:32 |
| matt-borland | yep, working on it | 13:33 |
| *** yamamoto has joined #openstack-horizon | 13:34 | |
| *** Drago has joined #openstack-horizon | 13:39 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix empty 'href' in link actions after AJAX actions_update https://review.openstack.org/289337 | 13:39 |
| tsufiev | robcresswell, I think I found more local solution ^^^ | 13:40 |
| *** yamamoto has quit IRC | 13:40 | |
| *** Drago has quit IRC | 13:41 | |
| *** Drago has joined #openstack-horizon | 13:41 | |
| *** ducttape_ has joined #openstack-horizon | 13:43 | |
| *** piet has quit IRC | 13:45 | |
| robcresswell | Table code is a mess >.< | 13:50 |
| tsufiev | do you like second solution more? | 13:50 |
| openstackgerrit | Justin Pomeroy proposed openstack/horizon: Enforce limits on metadata tree items https://review.openstack.org/209680 | 13:50 |
| *** yamamoto has joined #openstack-horizon | 13:51 | |
| *** JeanBriceCombebi has quit IRC | 13:52 | |
| tsufiev | robcresswell, the fact that Python legacy tables are a mess should incentivize us to pay more attention to Angular tables ;) | 13:53 |
| robcresswell | Yeah I want to look a cindys patch for generating them early in N | 13:53 |
| *** piet has joined #openstack-horizon | 13:53 | |
| robcresswell | But anyway, lets look at the current issue | 13:53 |
| *** yamamoto has quit IRC | 13:53 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:54 | |
| *** tyr_ has joined #openstack-horizon | 13:55 | |
| robcresswell | tsufiev: My gut says that solution still feels wrong. There's a fix here, but I can't see it. Yet. | 13:56 |
| robcresswell | We shouldnt need to explicitly tag the is_table_action part | 13:56 |
| robcresswell | It generates the first time, but fails on ajax update... Hmmm.. | 13:57 |
| *** mtanino has joined #openstack-horizon | 13:57 | |
| *** e0ne has quit IRC | 13:59 | |
| *** e0ne has joined #openstack-horizon | 14:00 | |
| tsufiev | robcresswell, what's wrong with the current solution? | 14:00 |
| *** tyr_ has quit IRC | 14:00 | |
| robcresswell | tsufiev: Anyone adding ajax to another table would have to know about it | 14:02 |
| robcresswell | otherwise it would silently fail | 14:03 |
| robcresswell | That doesnt seem ideal to me :/ | 14:03 |
| robcresswell | brb | 14:03 |
| robcresswell | back. I now have internet! | 14:05 |
| tsufiev | robcresswell, that would require rewriting half of legacy tables, not realistic | 14:05 |
| robcresswell | tsufiev: How so? | 14:06 |
| tsufiev | or, we could return to the first variant of fix (with possible yet unknown side effects) | 14:06 |
| tsufiev | robcresswell, that's my gut feeling | 14:06 |
| robcresswell | Altering a base template during RC makes me worried :/ | 14:07 |
| robcresswell | Hence pursuit of more specific fix | 14:07 |
| tsufiev | okay, second solution doesn't alter it :) | 14:07 |
| robcresswell | second solution > first one IMO | 14:07 |
| robcresswell | but, still not ideal, in my mind | 14:07 |
| tsufiev | that's the best I could have conceived so far | 14:08 |
| tsufiev | perhaps somebody else would suggest something... | 14:09 |
| * tsufiev squints at david-lyle | 14:09 | |
| *** piet has quit IRC | 14:10 | |
| *** JeanBriceCombebi has quit IRC | 14:10 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 14:15 | |
| *** piet has joined #openstack-horizon | 14:15 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Zanata https://review.openstack.org/294052 | 14:21 |
| *** yamamoto has joined #openstack-horizon | 14:23 | |
| *** yamamoto has quit IRC | 14:26 | |
| *** tosky has joined #openstack-horizon | 14:26 | |
| *** yamamoto has joined #openstack-horizon | 14:27 | |
| *** pcaruana has quit IRC | 14:28 | |
| matt-borland | robcresswell, sorry, still trying to get webroot system going, almost there :/ | 14:30 |
| *** vishwanathj_ has joined #openstack-horizon | 14:30 | |
| *** ediardo has joined #openstack-horizon | 14:32 | |
| *** garthb has joined #openstack-horizon | 14:35 | |
| *** garthb has quit IRC | 14:36 | |
| *** piet has quit IRC | 14:37 | |
| *** erlon has joined #openstack-horizon | 14:40 | |
| *** Drago has left #openstack-horizon | 14:42 | |
| *** JeanBriceCombebi has quit IRC | 14:42 | |
| *** piet has joined #openstack-horizon | 14:42 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 14:43 | |
| *** vijendar has joined #openstack-horizon | 14:48 | |
| *** Daisy_ has joined #openstack-horizon | 14:49 | |
| *** pushkaru has joined #openstack-horizon | 14:52 | |
| *** ankurgupta1 has joined #openstack-horizon | 14:53 | |
| *** Daisy_ has quit IRC | 14:53 | |
| *** cshahani has joined #openstack-horizon | 14:55 | |
| robcresswell | matt-borland: Thanks for chasing that up | 14:55 |
| *** piet has quit IRC | 14:56 | |
| *** piet has joined #openstack-horizon | 14:56 | |
| matt-borland | I see what's going on. | 14:56 |
| robcresswell | matt-borland: \o/ | 14:57 |
| matt-borland | we're getting bad route matching. | 14:57 |
| matt-borland | yeah, I ran into this before. | 14:58 |
| matt-borland | r1chardj0n3s, tsufiev, the problem is that $routeProvider uses the path relative to the base, so you can't match on a value that includes the webroot | 14:58 |
| matt-borland | in that case it doesn't match a route, so it defaults the default route provider | 14:59 |
| *** belmoreira has quit IRC | 14:59 | |
| matt-borland | I'll try to fix it, but there's a little complexity depending on how r1chardj0n3s wrote the code. | 14:59 |
| *** JeanBriceCombebi has quit IRC | 15:00 | |
| *** deray has quit IRC | 15:01 | |
| *** aortega has quit IRC | 15:02 | |
| *** josecastroleon1 has quit IRC | 15:04 | |
| matt-borland | robcresswell, tsufiev, I think I have the fix, but I am less familiar with the depths of the patch. Should I just upload the fix, or just point it out? | 15:04 |
| robcresswell | Its blocked unless that issue can be fixed, so I'd say upload. | 15:04 |
| matt-borland | Will do, thx | 15:04 |
| robcresswell | Check what you can locally; basic functionality and tests etc. | 15:05 |
| *** alejandrito has joined #openstack-horizon | 15:05 | |
| matt-borland | yep, will run the gantlet | 15:05 |
| robcresswell | thanks Matt | 15:06 |
| *** sayalilunkad has joined #openstack-horizon | 15:08 | |
| *** xinwu has joined #openstack-horizon | 15:09 | |
| *** slunkad_ has quit IRC | 15:10 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Make ngcontainers the default Swift UI https://review.openstack.org/293168 | 15:12 |
| tsufiev | matt-borland, thank you! Downloading the new patchset... | 15:13 |
| matt-borland | ah, there may be a flaw, one moment. | 15:14 |
| matt-borland | I may have one unnecessary leading slash, not sure | 15:14 |
| *** xinwu has quit IRC | 15:14 | |
| matt-borland | it seemed to work, but I'll test a teeny bit more | 15:15 |
| *** vishwanathj_zzz is now known as vishwanathj | 15:17 | |
| tsufiev | matt-borland, still cannot walk into pseudo-folders | 15:18 |
| matt-borland | yep, let me add one twist to it to probably fix that. | 15:18 |
| tsufiev | The requested URL /project/containers/container/test/myfolder was not found on this server. | 15:18 |
| tsufiev | it's definitely missing WEBROOT prefix | 15:18 |
| matt-borland | yep. expected, sorry...will re-patch in 1 sec | 15:18 |
| *** wolverineav has joined #openstack-horizon | 15:19 | |
| matt-borland | OK, sorry about that, testing once more. | 15:19 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Make ngcontainers the default Swift UI https://review.openstack.org/293168 | 15:22 |
| *** schipiga has quit IRC | 15:22 | |
| matt-borland | tsufiev, try this one ^^ | 15:22 |
| matt-borland | This sets the routes as relative, which picks up the base tag value, | 15:22 |
| matt-borland | but also interprets the routeProvider paths correctly. | 15:22 |
| *** xinwu has joined #openstack-horizon | 15:23 | |
| *** wolverineav has quit IRC | 15:23 | |
| *** ygbo has quit IRC | 15:24 | |
| matt-borland | At least I now have a good WEBROOT environment on my dev system that I can use to test easily, now | 15:24 |
| *** tyr_ has joined #openstack-horizon | 15:26 | |
| *** Mounica has joined #openstack-horizon | 15:28 | |
| *** Mounica has quit IRC | 15:29 | |
| matt-borland | The nice thing, tsufiev and robcresswell, is that if we code properly we have to do very little to deal with webroot in Angular | 15:29 |
| matt-borland | we just use the base tag and make most requests relative. | 15:30 |
| tsufiev | matt-borland, that's really nice. Will look into the recent update once I finish conducting an interview | 15:30 |
| matt-borland | no problem, sorry about that burp, I knew it as I committed it. :) | 15:31 |
| *** tyr_ has quit IRC | 15:31 | |
| *** jpomeroy has quit IRC | 15:35 | |
| *** tyr_ has joined #openstack-horizon | 15:39 | |
| openstackgerrit | Richard Hagarty proposed openstack/horizon: Add Horizon support for volume consistency groups https://review.openstack.org/257630 | 15:39 |
| *** SimonChung1 has quit IRC | 15:41 | |
| *** Mounica has joined #openstack-horizon | 15:41 | |
| *** Mounica has quit IRC | 15:42 | |
| *** Mounica has joined #openstack-horizon | 15:42 | |
| *** tyr_ has quit IRC | 15:43 | |
| *** ygbo has joined #openstack-horizon | 15:44 | |
| *** matt-borland has quit IRC | 15:46 | |
| *** ybathia has joined #openstack-horizon | 15:50 | |
| *** bpokorny has joined #openstack-horizon | 15:50 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Use breadcrumb nav across Horizon https://review.openstack.org/284421 | 15:50 |
| robcresswell | ^^ ignore that one, just been rebasing some patches in between reviews | 15:51 |
| *** piet has quit IRC | 15:51 | |
| *** piet has joined #openstack-horizon | 15:51 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Use breadcrumb nav across Horizon https://review.openstack.org/284421 | 15:53 |
| *** xinwu has quit IRC | 15:54 | |
| TravT | tsufiev: are the swift issues you are seeing regardless of the latest swift patch to switch the default UI | 15:56 |
| *** zzxwill has quit IRC | 15:59 | |
| *** zzxwill has joined #openstack-horizon | 16:02 | |
| *** gariveradlt has joined #openstack-horizon | 16:02 | |
| *** jpomeroy has joined #openstack-horizon | 16:03 | |
| openstackgerrit | Richard Hagarty proposed openstack/horizon: Add Horizon support for volume consistency groups https://review.openstack.org/257630 | 16:03 |
| *** zzxwill has quit IRC | 16:06 | |
| *** dan_nguyen has joined #openstack-horizon | 16:07 | |
| *** neelashah has quit IRC | 16:09 | |
| *** vgridnev has quit IRC | 16:10 | |
| *** zzxwill has joined #openstack-horizon | 16:10 | |
| *** aimeeU has joined #openstack-horizon | 16:12 | |
| *** vgridnev has joined #openstack-horizon | 16:17 | |
| *** vgridnev has quit IRC | 16:17 | |
| *** matt-borland has joined #openstack-horizon | 16:17 | |
| matt-borland | tsufiev, sorry, was offline...did you get a chance to test the patch? Just let me know here or in the review | 16:19 |
| openstackgerrit | Richard Hagarty proposed openstack/horizon: Add Horizon support for volume consistency groups https://review.openstack.org/257630 | 16:19 |
| tsufiev | matt-borland, finally going to review it again | 16:19 |
| matt-borland | thx tsufiev | 16:19 |
| *** ybathia has quit IRC | 16:19 | |
| tsufiev | TravT, didn't check for WEBROOT issues before the enablement patch, so not sure if there were already there | 16:20 |
| *** aortega has joined #openstack-horizon | 16:21 | |
| *** lapalm has quit IRC | 16:21 | |
| *** pcaruana has joined #openstack-horizon | 16:22 | |
| *** doug-fish has quit IRC | 16:22 | |
| *** doug-fish has joined #openstack-horizon | 16:23 | |
| tsufiev | matt-borland, http://i.imgur.com/OAr8egJ.png there is still some room for improvement :) | 16:25 |
| matt-borland | that's fine, the problem is how the routes are used in the app. | 16:26 |
| matt-borland | that's the "trickiness" I referred to above. | 16:26 |
| tsufiev | oh | 16:26 |
| matt-borland | so, basically, my suggestion is to do as we've now got, where the routes are relative. | 16:26 |
| matt-borland | however, if somewhere someone uses a non-relative route then things won't work | 16:27 |
| matt-borland | so we need to identify exactly where things are going wrong...which features specifically broke? | 16:27 |
| matt-borland | I was able to create folders, navigate, etc... | 16:27 |
| *** doug-fish has quit IRC | 16:27 | |
| matt-borland | but I didn't do a full suite of tests, not sure what they all are | 16:27 |
| matt-borland | most likely we'll see problems with bad templates, etc. | 16:28 |
| *** jtriley_ has joined #openstack-horizon | 16:28 | |
| *** jpomeroy has quit IRC | 16:29 | |
| matt-borland | robcresswell, how would you suggest proceeding? I fixed the obvious problem, but should I work on ferreting out other webroot issues? | 16:29 |
| *** jtriley has quit IRC | 16:30 | |
| *** lapalm has joined #openstack-horizon | 16:31 | |
| tsufiev | matt-borland, are you able to upload file into a folder deeper than 2 levels of nesting? | 16:31 |
| tsufiev | because I can't | 16:31 |
| matt-borland | lemme check | 16:31 |
| matt-borland | it's nice having a webroot env now...I suggest that for everyone doing dev...that and material theme :) | 16:32 |
| *** itisha has joined #openstack-horizon | 16:33 | |
| *** gariveradlt has quit IRC | 16:33 | |
| *** jtriley_ has quit IRC | 16:34 | |
| *** jpomeroy has joined #openstack-horizon | 16:34 | |
| matt-borland | tsufiev, I don't think that's a webroot, but I can't create a folder under 2 levels now: | 16:34 |
| matt-borland | http://localhost/webroot/api/swift/containers/boogie/object/WHOA/dude%2Fmore/ | 16:34 |
| *** vishwanathj_ has quit IRC | 16:34 | |
| *** al_indigo has joined #openstack-horizon | 16:35 | |
| matt-borland | yep, can only create 2 deep. Seems to be doing a bad encoding. | 16:35 |
| *** SimonChung has joined #openstack-horizon | 16:35 | |
| *** nk2527 has joined #openstack-horizon | 16:35 | |
| robcresswell | matt-borland: Up to you. Any more time spent debugging and looking at implemented code is exactly what RC is for. | 16:36 |
| matt-borland | I'll mess around with this. I do thing the webroot problem is solved with my patchset | 16:36 |
| matt-borland | s/thing/think/ | 16:36 |
| *** doug-fish has joined #openstack-horizon | 16:38 | |
| tsufiev | matt-borland, thanks again! I guess Richard could finish the polishing | 16:38 |
| matt-borland | I will poke at it since it's a priority | 16:38 |
| *** doug-fish has quit IRC | 16:38 | |
| *** doug-fish has joined #openstack-horizon | 16:38 | |
| *** wolverineav has joined #openstack-horizon | 16:40 | |
| robcresswell | matt-borland: Thanks matt, really appreciate it! | 16:40 |
| tsufiev | do you know at which point 'framework.module.js' is being loaded? | 16:40 |
| tsufiev | I'm trying to address Tyr's comments | 16:40 |
| robcresswell | I'm stepping away for a couple hours, but will be back this evening. | 16:40 |
| *** neelashah has joined #openstack-horizon | 16:40 | |
| robcresswell | (midday for those in 'murica) | 16:41 |
| *** cshahani has quit IRC | 16:41 | |
| matt-borland | tsufiev, do you want to know what order it's loaded, or when its Angular contents are executed? | 16:42 |
| tsufiev | matt-borland, what really interests me is if legacy Horizon JS is already evaluated by the moment framework config() function runs | 16:44 |
| *** zzxwill has quit IRC | 16:44 | |
| matt-borland | it should be, yes | 16:44 |
| tsufiev | okay | 16:44 |
| matt-borland | unless the bulk of legacy waits for onload or something like that | 16:44 |
| matt-borland | but I imagine it's evaluated almost immediately after being loaded, before config(). | 16:45 |
| *** doug-fish has quit IRC | 16:45 | |
| matt-borland | If it's potentially non-deterministic (based on onload or something) then I'd prefer the existing approach for the short term. | 16:46 |
| *** doug-fish has joined #openstack-horizon | 16:46 | |
| *** doug-fish has quit IRC | 16:46 | |
| *** doug-fish has joined #openstack-horizon | 16:46 | |
| openstackgerrit | Richard Hagarty proposed openstack/horizon: Add Horizon support for volume consistency groups https://review.openstack.org/257630 | 16:48 |
| *** alejandrito has quit IRC | 16:49 | |
| matt-borland | With the 'things failing after two levels of folders' I suspect a bad replace() call, one that only replaces the first instance of a match... | 16:49 |
| *** dratushnyy has quit IRC | 16:50 | |
| openstackgerrit | Lucas Palm proposed openstack/horizon: Add the Snapshots tab on the Volume Details page https://review.openstack.org/270461 | 16:51 |
| *** alejandrito has joined #openstack-horizon | 16:51 | |
| *** cshahani has joined #openstack-horizon | 16:52 | |
| openstackgerrit | Lucas Palm proposed openstack/horizon: Fixed the Volume Type and QoS specs table size issues https://review.openstack.org/266030 | 16:53 |
| *** ankurgupta2 has joined #openstack-horizon | 16:53 | |
| *** garthb has joined #openstack-horizon | 16:53 | |
| *** ediardo has quit IRC | 16:54 | |
| *** alejandrito has quit IRC | 17:01 | |
| matt-borland | indeed, tsufiev, that 2nd-level problem was due to bad use of replace(). | 17:02 |
| matt-borland | putting another patch up. | 17:02 |
| *** JeanBriceCombebi has joined #openstack-horizon | 17:02 | |
| *** yamamoto has quit IRC | 17:04 | |
| *** ankurgupta2 has left #openstack-horizon | 17:04 | |
| *** Daisy has joined #openstack-horizon | 17:04 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix non-working Angular actions in jquery modified tables https://review.openstack.org/289849 | 17:06 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Make ngcontainers the default Swift UI https://review.openstack.org/293168 | 17:06 |
| tsufiev | matt-borland, amazing speed :) | 17:07 |
| *** vgridnev has joined #openstack-horizon | 17:07 | |
| matt-borland | thanks! espresso | 17:07 |
| *** JeanBriceCombebi has quit IRC | 17:07 | |
| *** gariveradlt has joined #openstack-horizon | 17:08 | |
| tsufiev | meanwhile, I've addressed tyr's comments | 17:08 |
| tsufiev | hope it's okay from Angular POV | 17:08 |
| *** Daisy has quit IRC | 17:09 | |
| matt-borland | I'll take a look tsufiev | 17:09 |
| *** wolverineav has quit IRC | 17:10 | |
| matt-borland | tsufiev, at worst case, rather than attaching it to the 'horizon' object, we could just attach it to the window scope. | 17:11 |
| matt-borland | I mean, that's what gettext does, and it's not beautiful, but it works fine, | 17:11 |
| matt-borland | and would avoid concerns about order of execution. | 17:11 |
| *** lhcheng has joined #openstack-horizon | 17:14 | |
| tsufiev | matt-borland, yeah, but attaching to horizon seems to work | 17:14 |
| tsufiev | at least for now | 17:14 |
| matt-borland | yeah | 17:15 |
| matt-borland | I won't hold you up on it...easy to fix if it causes problems. | 17:15 |
| tsufiev | matt-borland, I don't like at all being bringer of bad/not-so-good news today, but... | 17:15 |
| matt-borland | haha! | 17:15 |
| matt-borland | what's up? | 17:15 |
| tsufiev | Download Swift UI action still misses WEBROOT | 17:15 |
| *** david_cu has joined #openstack-horizon | 17:16 | |
| matt-borland | ha, no problem! I'll track that one down too. | 17:16 |
| tsufiev | bad r1chardj0n3s :) | 17:16 |
| matt-borland | I am going to start just devving in webroot | 17:16 |
| matt-borland | I'll fix that screaming CANCEL button too | 17:16 |
| matt-borland | I cannot imagine that is intentional | 17:17 |
| *** erlon has quit IRC | 17:17 | |
| *** david_cu_ has joined #openstack-horizon | 17:17 | |
| matt-borland | See, I ate an an Australian restaurant yesterday...and now I'm cleaning up r1chardj0n3s' code. It all makes sense. | 17:17 |
| tsufiev | haha )) | 17:18 |
| tsufiev | that's how Karma works | 17:18 |
| *** david_cu has quit IRC | 17:20 | |
| *** dratushnyy has joined #openstack-horizon | 17:21 | |
| *** ediardo has joined #openstack-horizon | 17:23 | |
| tsufiev | oh, that's interesting: | 17:24 |
| tsufiev | if first create folder1, go inside it and create folder2, then delete folder2, go to top container level, folder1 is still there | 17:25 |
| tsufiev | but if I create them as folder1/folder2, go inside folder1, delete folder2, go to top level => folder1 disappears as if had deleted it as well | 17:25 |
| *** david_cu_ has quit IRC | 17:25 | |
| * tsufiev imagines himself a hard-core QA engineer | 17:26 | |
| *** e0ne has quit IRC | 17:27 | |
| rdopiera | they are called "directories" ;) | 17:28 |
| rdopiera | folders are for papers | 17:29 |
| *** clu_ has joined #openstack-horizon | 17:29 | |
| tsufiev | rdopiera, folders are shorter! | 17:29 |
| rdopiera | dirs are shorter | 17:29 |
| tsufiev | rdopiera, okay, dirs :) | 17:29 |
| rdopiera | but I'm just nit picking | 17:30 |
| tsufiev | rdopiera, but please notice, that it's reproducible for both folders and dirs :) | 17:30 |
| *** vgridnev has quit IRC | 17:31 | |
| *** tosky has quit IRC | 17:31 | |
| *** tosky has joined #openstack-horizon | 17:32 | |
| matt-borland | lol, they're named Folders in this implementation | 17:33 |
| *** yamamoto has joined #openstack-horizon | 17:34 | |
| *** ankurgupta1 has left #openstack-horizon | 17:35 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Make ngcontainers the default Swift UI https://review.openstack.org/293168 | 17:36 |
| *** Guest57182 has quit IRC | 17:36 | |
| *** vgridnev has joined #openstack-horizon | 17:37 | |
| matt-borland | tsufiev, ^^ should fix the download/webroot issue | 17:37 |
| *** jtriley has joined #openstack-horizon | 17:38 | |
| *** Mounica has quit IRC | 17:38 | |
| matt-borland | looking for more problems :) | 17:39 |
| *** wolverineav has joined #openstack-horizon | 17:39 | |
| *** yamamoto has quit IRC | 17:40 | |
| *** mpavlase has quit IRC | 17:40 | |
| *** Mounica has joined #openstack-horizon | 17:41 | |
| *** ygbo has quit IRC | 17:43 | |
| *** kzaitsev_mb has quit IRC | 17:47 | |
| tsufiev | matt-borland: yay! all my findings were addressed | 17:48 |
| tsufiev | well, except f1/f2 chain delete, but I prefer to see it as an undocumented feature | 17:49 |
| tsufiev | matt-borland, thanks again, that was really fast :) | 17:49 |
| tsufiev | I'm going to wait until +1 from voting jobs and then +2 it | 17:49 |
| *** vishwana_ has joined #openstack-horizon | 17:51 | |
| *** jtriley has quit IRC | 17:52 | |
| *** vishwanathj has quit IRC | 17:54 | |
| *** vijendar has quit IRC | 17:55 | |
| *** rcernin has quit IRC | 17:55 | |
| *** jtriley has joined #openstack-horizon | 17:56 | |
| *** tqtran-afk has joined #openstack-horizon | 17:56 | |
| openstackgerrit | Dan Nguyen proposed openstack/horizon: Bypass get_domain call to keystone api https://review.openstack.org/293172 | 17:57 |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Zanata https://review.openstack.org/294052 | 17:58 |
| *** doug-fish has quit IRC | 18:00 | |
| *** doug-fish has joined #openstack-horizon | 18:00 | |
| *** gberginc has quit IRC | 18:02 | |
| *** gberginc has joined #openstack-horizon | 18:02 | |
| *** lhcheng_ has joined #openstack-horizon | 18:05 | |
| *** doug-fish has quit IRC | 18:05 | |
| matt-borland | tsufiev, sounds good, I'm back from lunch | 18:05 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix non-working Angular actions in jquery modified tables https://review.openstack.org/289849 | 18:07 |
| *** lhcheng has quit IRC | 18:08 | |
| *** vijendar has joined #openstack-horizon | 18:10 | |
| tsufiev | things are still not easy with $rootScopeProvider ^^ :/ | 18:10 |
| *** vijendar has left #openstack-horizon | 18:12 | |
| matt-borland | tsufiev, interesting, it's possible that we want to do this in the .run() method rather than the .config() method. | 18:12 |
| matt-borland | there you have access to the basic $window and $rootScope object, which is perhaps a better place to do it. Not sure if it makes a difference. | 18:13 |
| *** piet has quit IRC | 18:13 | |
| matt-borland | .config() is in a different phase of the Angular lifecycle, before most injectables are ready. | 18:13 |
| *** tqtran-afk is now known as tqtran | 18:13 | |
| matt-borland | If we run into too many blind turns, I would rather just keep what we had. | 18:14 |
| matt-borland | since it worked | 18:14 |
| *** gberginc has quit IRC | 18:16 | |
| *** pcaruana has quit IRC | 18:18 | |
| *** e0ne has joined #openstack-horizon | 18:18 | |
| tsufiev | matt-borland, yeah, exactly! | 18:18 |
| tsufiev | just tried it, works :D | 18:19 |
| matt-borland | excellent | 18:19 |
| *** ducttape_ has quit IRC | 18:21 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix non-working Angular actions in jquery modified tables https://review.openstack.org/289849 | 18:21 |
| *** SimonChung has quit IRC | 18:21 | |
| *** SimonChung has joined #openstack-horizon | 18:21 | |
| matt-borland | oh, nice tsufiev ! | 18:21 |
| matt-borland | I like that much better. | 18:22 |
| *** xinwu has joined #openstack-horizon | 18:22 | |
| tsufiev | might add you as a co-author :) | 18:22 |
| tsufiev | now it's a product of collective mind | 18:22 |
| matt-borland | up to you, I'm also going to rebase/change my dependent patch | 18:23 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Allow Launch Instance (Angular) from Volume Snapshots https://review.openstack.org/289379 | 18:23 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix non-working Angular actions in jquery modified tables https://review.openstack.org/289849 | 18:23 |
| tsufiev | updated commit msg | 18:23 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: minor ng containers cleanup https://review.openstack.org/294223 | 18:24 |
| tsufiev | clu_, does it fix 'Cancel' shouting? | 18:24 |
| clu_ | tsufiev: yes :D | 18:28 |
| tsufiev | awesome! | 18:28 |
| tsufiev | clu_, do you mind rebasing it on top of r1chardj0n3s patch? | 18:28 |
| tqtran | tsufiev: question regarding your patch https://review.openstack.org/#/c/289849/ | 18:29 |
| clu_ | tsufiev: which patch? https://review.openstack.org/#/q/owner:%22Richard+Jones%22+status:open | 18:29 |
| tqtran | actually, let me read your bug report first :D | 18:30 |
| tsufiev | clu_, this one https://review.openstack.org/#/c/293168/ | 18:30 |
| *** pcaruana has joined #openstack-horizon | 18:30 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Allow Launch Instance (Angular) from Volume Snapshots https://review.openstack.org/289379 | 18:30 |
| *** ducttape_ has joined #openstack-horizon | 18:31 | |
| clu_ | tsufiev: i don't think it's dependent on that one | 18:32 |
| tsufiev | clu_, sure, I just wanted to not miss that UI impact fix in RC1 | 18:32 |
| tsufiev | on the other hand, we could merge it after RC1 as well... | 18:33 |
| tsufiev | well, never mind then ) | 18:33 |
| clu_ | ok, i'll can make it dependent | 18:33 |
| matt-borland | clu_, thanks for fixing the shouting | 18:33 |
| clu_ | hahaahah np | 18:33 |
| matt-borland | r1chardj0n3s is going to wake up and find his code working! | 18:34 |
| matt-borland | ;) | 18:34 |
| *** jtriley has quit IRC | 18:34 | |
| tqtran | tsufiev: the images table you are talking about is the legacy one right? | 18:34 |
| tsufiev | tqtran, yes | 18:34 |
| *** piet has joined #openstack-horizon | 18:34 | |
| tsufiev | I'd prefer to describe it as 'the table we're shipping by default' :) | 18:35 |
| matt-borland | heh | 18:35 |
| *** yamamoto has joined #openstack-horizon | 18:38 | |
| *** jtriley has joined #openstack-horizon | 18:43 | |
| openstackgerrit | Merged openstack/horizon: Hamburger Menu icon - fix the alignment of the animated arrow https://review.openstack.org/290931 | 18:43 |
| *** yamamoto has quit IRC | 18:44 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Extensible details views in Angular https://review.openstack.org/284848 | 18:44 |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Composable Details Views https://review.openstack.org/292936 | 18:44 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: minor ng containers cleanup https://review.openstack.org/294223 | 18:45 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Make ngcontainers the default Swift UI https://review.openstack.org/293168 | 18:45 |
| *** doug-fish has joined #openstack-horizon | 18:45 | |
| *** doug-fish has quit IRC | 18:45 | |
| *** doug-fish has joined #openstack-horizon | 18:45 | |
| *** doug-fish has quit IRC | 18:50 | |
| *** mpavlase has joined #openstack-horizon | 18:50 | |
| *** doug-fish has joined #openstack-horizon | 18:51 | |
| openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Add "prev" to instance list pagination https://review.openstack.org/289314 | 19:00 |
| *** rdopiera has quit IRC | 19:01 | |
| *** tosky has quit IRC | 19:02 | |
| *** vijendar has joined #openstack-horizon | 19:05 | |
| *** vgridnev has quit IRC | 19:08 | |
| *** lapalm has quit IRC | 19:10 | |
| *** gberginc has joined #openstack-horizon | 19:13 | |
| *** vgridnev has joined #openstack-horizon | 19:16 | |
| openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Add "prev" to instance list pagination https://review.openstack.org/289314 | 19:18 |
| *** Daisy has joined #openstack-horizon | 19:20 | |
| *** e0ne has quit IRC | 19:24 | |
| *** lapalm has joined #openstack-horizon | 19:24 | |
| *** Daisy has quit IRC | 19:24 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: WIP Developer panel to allow testing of resource actions https://review.openstack.org/294247 | 19:28 |
| *** Mounica has quit IRC | 19:30 | |
| openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Add "prev" to instance list pagination https://review.openstack.org/289314 | 19:32 |
| *** davidlenwell has quit IRC | 19:36 | |
| *** doug-fish has quit IRC | 19:38 | |
| *** vgridnev has quit IRC | 19:38 | |
| *** davidlenwell has joined #openstack-horizon | 19:42 | |
| *** onovy has quit IRC | 19:43 | |
| *** gberginc has quit IRC | 19:47 | |
| robcresswell | Im back! | 19:48 |
| robcresswell | Just reading chat. | 19:48 |
| *** piet has quit IRC | 19:48 | |
| robcresswell | tsufiev: Are you satisfied with webroot issues now? | 19:49 |
| matt-borland | hey robcresswell! | 19:49 |
| matt-borland | I believe he is, he was waiting for the +1 from Jenkins | 19:49 |
| matt-borland | Also fixed a 'you can only work with 2 levels of folders' bug | 19:49 |
| robcresswell | clu_: Your patch failed jenkins here btw https://review.openstack.org/#/c/294223/2 | 19:50 |
| matt-borland | I think we found a good resolution to the injected-content compilation, too | 19:50 |
| robcresswell | Nice work | 19:52 |
| *** doug-fish has joined #openstack-horizon | 19:53 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Composable Details Views https://review.openstack.org/292936 | 19:53 |
| robcresswell | matt-borland: Chasing a new patch set record again? | 19:53 |
| matt-borland | YES | 19:54 |
| matt-borland | sorry, collaboration has its woes on master | 19:54 |
| robcresswell | If its internal, better to do it on a git repo elsewhere to avoid Jenkins runs :) | 19:56 |
| robcresswell | Okay, Swift and Consistency Groups in the gate | 19:56 |
| matt-borland | so cool | 19:56 |
| TravT | tsufiev: matt-borland: nice collaboration on that patch | 19:56 |
| matt-borland | it was a good morning :) | 19:57 |
| david-lyle | robcresswell: I need to look at the port assignment patch again | 19:57 |
| david-lyle | next on my todo list | 19:57 |
| robcresswell | david-lyle: Yeah, unfortunately I feel like I shouldnt really review it given the last patch set is mine... | 19:57 |
| robcresswell | Could do though | 19:58 |
| david-lyle | how extensive were the changes ? | 19:58 |
| *** lblanchard has quit IRC | 19:58 | |
| robcresswell | david-lyle: We should also consider dropping the two not-high RC1 patches | 19:58 |
| * david-lyle asks laziliy | 19:58 | |
| robcresswell | david-lyle: I just adding Port sorting, and fixed a couple of the unnamed functions. I looked into Policy a bit, but couldnt get an answer from the Nova guys at all. | 19:59 |
| robcresswell | And my research seemed to show that its okay as is | 19:59 |
| david-lyle | ok looking | 19:59 |
| robcresswell | All three High bugs have patches out now I believe. But the other two bugs are in limbo when I last checked. | 20:00 |
| ducttape_ | r1chardj0n3s: have new swift ui up in our environment. again, this is much much less terrible than the previous swift ui. :D | 20:01 |
| matt-borland | robcresswell, I think that 2 of those are now chained together, so Timur's patch https://review.openstack.org/#/c/289849/ seems the most critical to look at. | 20:01 |
| robcresswell | matt-borland: Yeah, also looking at https://review.openstack.org/#/c/289337 because I don't like it :p | 20:01 |
| matt-borland | we got some good work done on it this morning/afternoon/evening | 20:01 |
| *** SimonChung has quit IRC | 20:01 | |
| david-lyle | robcresswell: moved the others to N-1 | 20:02 |
| robcresswell | Great, thanks. | 20:02 |
| david-lyle | I'm going to move the CG to N-1 too, since only half will make it | 20:02 |
| robcresswell | Yep, sounds good. | 20:03 |
| ducttape_ | that swift ui thing is really slick, the pagination. if angular efforts were focused on real / material problems like this..... my brain would melt. like for admin instances.... omg..... game changer | 20:03 |
| tsufiev | robcresswell: pagination fix looks already good enough to me | 20:04 |
| robcresswell | tsufiev: I'm all for merging if its ready, but I dont think it should be a release blocker at this stage. | 20:05 |
| david-lyle | rhagarty: for your patches, one will make Mitaka, snapshots will have to wait til Newton, so moved target to N-1 | 20:05 |
| tsufiev | robcresswell: ok | 20:05 |
| matt-borland | ducttape_, your brain will soon melt, count on it | 20:06 |
| *** doug-fish has quit IRC | 20:07 | |
| robcresswell | I'd really like to get clu_ table patch finished. That would be fantastically useful for faster adoption and consistency. | 20:08 |
| robcresswell | Tired of seeing every table rewrite "No available items", its just clunky. | 20:08 |
| *** Mounica has joined #openstack-horizon | 20:08 | |
| *** SimonChung has joined #openstack-horizon | 20:09 | |
| ducttape_ | I have a swift container with 6 pages of items (20 per page) , initial page loading is less than a second. switching pages is less than 200ms. this is like amazon level good ;) | 20:09 |
| TravT | robcresswell: i definitely want that table patch in as well, and i think we need to really drill into how it can be used with registry concepts. | 20:10 |
| robcresswell | ducttape_: \o/ | 20:11 |
| matt-borland | yeah, it's a good patch, I only had a couple of naming nits | 20:11 |
| matt-borland | and suggestions for how to merge with the registry | 20:12 |
| TravT | i'd like to see it come together with the registry | 20:12 |
| matt-borland | look how our thoughts align... | 20:12 |
| tqtran | ducttape_: raving about angular? our work here is done :) | 20:13 |
| *** neelashah has quit IRC | 20:13 | |
| robcresswell | I think that kind of self-contained component would make angular much more accessible, and wayy easier to manage consistency across plugins and panels | 20:13 |
| *** doug-fish has joined #openstack-horizon | 20:13 | |
| robcresswell | I mean if you look at the workflow, fixing the themeing has meant patching every single plugin workflow | 20:13 |
| clu_ | robcresswell: TravT: matt-borland is it agreed upon what we want to put in the registry? | 20:14 |
| ducttape_ | I think angular is fine. I've been disappointed we spent time on some admin pages that don't really need / benefit from angular, so I've soured on the effort at times | 20:14 |
| rhagarty | david-lyle, thanks | 20:14 |
| TravT | clu_: matt-borland and i have talked about a bunch of ideas with it. | 20:14 |
| TravT | but the last few weeks have been drowning in end of release things | 20:14 |
| tqtran | ducttape_: haha yeah agree, brings me back to our effort back in Atlanta. boy we've come a long way | 20:14 |
| matt-borland | clu_, my perspective is that I'd like the patch you have merged (with one naming change) but that we may want an example that uses the registry to fetch its items through a mapping. | 20:15 |
| matt-borland | that could follow as it's not core to the concept of the table display | 20:15 |
| tqtran | matt-borland: yeah, i prefer to see that as well | 20:15 |
| clu_ | matt-borland: yes, we can def fix how to fetch the mapping down the line | 20:15 |
| matt-borland | yep | 20:15 |
| robcresswell | I'd also really like it if someone would rip search from inside the table HTML :p | 20:15 |
| tqtran | rip search? as in remove it? | 20:16 |
| TravT | clu_: i also am concerned about the embedded search | 20:16 |
| matt-borland | yeah, take it out of the table | 20:16 |
| robcresswell | Having a search bar wrapped inside the table is unpleasant | 20:16 |
| robcresswell | only in the markup; I'm not saying to remove search! | 20:16 |
| matt-borland | I think we can do it with a little work. | 20:16 |
| TravT | the current directive also only supports the magic search filtering | 20:16 |
| TravT | that isn't good enough | 20:16 |
| robcresswell | Just that the declaration is totally wrong, and makes styling awkward, breaks accessibility etc. | 20:16 |
| *** pcaruana has quit IRC | 20:17 | |
| matt-borland | I haven't looked at it, but it can't be hard. worst case we wrap the table and separately the bar in a greater directive that ties them together | 20:17 |
| *** SimonChung has quit IRC | 20:17 | |
| *** SimonChung1 has joined #openstack-horizon | 20:17 | |
| TravT | bah | 20:17 |
| matt-borland | As I recall it was a scoping issue that drew them together in that confuzzled way | 20:17 |
| TravT | i meant to say the current directive also only supports the smart table filtering | 20:17 |
| robcresswell | Yeah I think it just uses the st-table params | 20:18 |
| robcresswell | so when its outside, it falls over | 20:18 |
| matt-borland | We can probably just turn the scoping dependency around | 20:18 |
| TravT | i see the actions in that table are also missing the promise callback | 20:18 |
| matt-borland | ah, the table directive? | 20:19 |
| tqtran | if we make magic search the default | 20:19 |
| tqtran | we can just move the controller scope oe level up | 20:19 |
| matt-borland | yep tqtran | 20:19 |
| tqtran | and table and search can be seperate | 20:19 |
| matt-borland | robcresswell, do we have a bug on that (for Newton)? | 20:19 |
| TravT | tqtran: that's a pretty good idea. | 20:20 |
| robcresswell | matt-borland: I don't think I've put up a bug | 20:20 |
| matt-borland | I'll take a look and add one unless you want to | 20:20 |
| robcresswell | The other advantage to centralising all the templates via a table/form directive is that diana is less likely to punch you in the head. | 20:21 |
| *** e0ne has joined #openstack-horizon | 20:21 | |
| robcresswell | Which is always good | 20:21 |
| robcresswell | :D | 20:21 |
| tqtran | punch in the head, didnt know hurgleburgler was that violent | 20:21 |
| *** kzaitsev_mb has joined #openstack-horizon | 20:21 | |
| robcresswell | the hurglebeast is a frightening thing | 20:22 |
| *** ankurgupta1 has joined #openstack-horizon | 20:22 | |
| robcresswell | But yeah, its a big boon for theming to reuse the markup. | 20:22 |
| robcresswell | Would be good to keep that effort from the python side. | 20:23 |
| *** vishwanathj has joined #openstack-horizon | 20:23 | |
| tqtran | so the only thing that concerns me about the registry is that we are going to bloat it at some point (wont it be a huge memory hog)? | 20:23 |
| TravT | the whole responsive classes we use on the table aren't quite right either | 20:23 |
| TravT | i also couldn't seem to get truncate to work properly with them | 20:24 |
| matt-borland | tqtran, definitely not a memory hog relative to the whole of angular/js | 20:24 |
| tqtran | i mean, imagine all of the layout information and translations stored in a single place in memory (once single app becomes a reality) | 20:24 |
| TravT | just needed some hurglebeast help probably | 20:24 |
| r1chardj0n3s | ducttape_: there'll still be issues with your env with the large scaling, but that's really only solved by searchlight (since I can't even get basic string filtering into swift :/) | 20:24 |
| matt-borland | morning r1chardj0n3s | 20:25 |
| robcresswell | TravT: Yeah, me and hurgleburgler have talked over how to work that out, using contextual classes for the columns. | 20:25 |
| TravT | ooh, i can demo swift searching now. :) we landed the experimental patch yesterday. | 20:25 |
| TravT | it is mainly experimental because although we have working middleware | 20:25 |
| matt-borland | clu_, I'm still really heavy on the -1 on that 'route' param name | 20:25 |
| TravT | the swift team doesn't trust rabbit | 20:25 |
| matt-borland | it's a template, not a route. | 20:25 |
| clu_ | matt-borland: yes, indeed :P | 20:25 |
| *** piet has joined #openstack-horizon | 20:25 | |
| *** vishwana_ has quit IRC | 20:25 | |
| matt-borland | :) | 20:25 |
| clu_ | matt-borland: will get that addressed | 20:26 |
| ducttape_ | r1chardj0n3s: it looks great - big kudos for taking the ugliest part of horizon and making it the new hotness +10000 | 20:26 |
| matt-borland | thanks clu_ :) | 20:26 |
| clu_ | and i agree with should separate out the search, +1 | 20:26 |
| robcresswell | TravT: In python, this would just mean each column having a "dashboard_panel_column" class, and then you can just hide or show it by extending bootstraps utility classes. | 20:26 |
| matt-borland | I think r1chardj0n3s just leveled up | 20:26 |
| TravT | round of applause for r1chardj0n3s \o/ | 20:26 |
| * matt-borland claps | 20:26 | |
| TravT | i also think it is a clear demonstration of how collaboration should work | 20:26 |
| TravT | and how mid cycle meetups are valuable | 20:26 |
| robcresswell | TravT: And Horizon can just have a default, but it means its all customisable via CSS. Apparently you can do anything with CSS. | 20:26 |
| robcresswell | Totally agree! Great work on Swift rewrite. | 20:27 |
| TravT | robcresswell: yeah, i think we have some angular filters that could be handled via css | 20:27 |
| * tqtran pats r1chardj0n3s on the back. | 20:27 | |
| r1chardj0n3s | thanks clu_ and matt-borland for the subbing in on https://review.openstack.org/#/c/293168 | 20:27 |
| robcresswell | So we now have an angular panel and a workflow. We have actual content! | 20:27 |
| matt-borland | np, r1chardj0n3s, it was good to work with it! | 20:27 |
| matt-borland | I also have a true webroot environment that everything will now have to pass thru. :) | 20:28 |
| TravT | well, we've had angular content since something i worked on in juno | 20:28 |
| TravT | the metadata update widget | 20:28 |
| clu_ | r1chardj0n3s: great work, the new Swift UI is fantastic | 20:28 |
| ducttape_ | didn't mean to single out r1chardj0n3s, everyone involved - thanks to all :D | 20:28 |
| robcresswell | TravT: Thats true, sorry :) | 20:28 |
| robcresswell | Good to see more of it being pushed front and center. | 20:29 |
| TravT | yeah, i'm really happy with the team collaboration we have going on right now | 20:29 |
| TravT | and how everybody brings their talents to the table to complement each other | 20:30 |
| r1chardj0n3s | thanks all, and yes, I couldn't have done it without y'all :-) | 20:30 |
| *** pcaruana has joined #openstack-horizon | 20:30 | |
| clu_ | *table* nice one, TravT ;p | 20:30 |
| *** ankurgupta1 has left #openstack-horizon | 20:31 | |
| tqtran | i prefer the word, talent-> "hammer" | 20:31 |
| tqtran | haha jk | 20:31 |
| robcresswell | Not to dull the moment too much... but we still have an Angular bp targeted for RC1. Could cores look over https://review.openstack.org/#/c/253573/ ? | 20:32 |
| robcresswell | I updated it to allow ordering Ports, *hopefully* without breaking it. | 20:32 |
| TravT | okay, i'll look again, since that was my original question... | 20:32 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Added test for check instances pagination functionality https://review.openstack.org/269488 | 20:33 |
| robcresswell | Thanks :D | 20:34 |
| robcresswell | matt-borland: Is Tyr about? Wondering if you could get him to look at https://review.openstack.org/#/c/289849/ again, since the -1 was his. | 20:37 |
| matt-borland | tyr has been pinged and is doing that review now | 20:38 |
| robcresswell | matt-borland: Brilliant | 20:39 |
| *** tyr_ has joined #openstack-horizon | 20:40 | |
| *** AlexOughton has joined #openstack-horizon | 20:41 | |
| *** ametts has joined #openstack-horizon | 20:42 | |
| tsufiev | robcresswell, wow, you've upvoted that patch! | 20:43 |
| *** gberginc has joined #openstack-horizon | 20:44 | |
| david-lyle | robcresswell: so the ordering widget doesn't allow drag-n-drop? | 20:46 |
| david-lyle | just a number and remove add until you make the order? | 20:46 |
| david-lyle | same is true for networks | 20:46 |
| ducttape_ | david-lyle: did you see your extra nics with the "ip a" command ? | 20:47 |
| david-lyle | I can see them in the old net topology | 20:47 |
| david-lyle | :P | 20:47 |
| robcresswell | david-lyle: It should drag and drop, unless I did it wrong | 20:47 |
| * ducttape_ wishes they had a command to deliver ipa | 20:47 | |
| robcresswell | Which is not unlikely. | 20:48 |
| david-lyle | ipa -now | 20:48 |
| david-lyle | neither do for me | 20:48 |
| david-lyle | robcresswell: ^^ | 20:48 |
| ducttape_ | ipa -cold | 20:48 |
| ducttape_ | ipa -on-the-porch | 20:48 |
| david-lyle | ipa -bottomless | 20:49 |
| robcresswell | david-lyle: Huh. When I tried it, You could select a couple of ports, then drag the second above the first | 20:49 |
| robcresswell | etc | 20:49 |
| robcresswell | Just by clicking on the arrows on the left | 20:49 |
| david-lyle | yup | 20:49 |
| david-lyle | the image ghosts, but never drops | 20:50 |
| r1chardj0n3s | david-lyle: try "sudo ipa -now" | 20:50 |
| robcresswell | Hmm | 20:50 |
| TravT | hey maybe we could do a hangout | 20:50 |
| TravT | i have a question as well | 20:50 |
| TravT | http://www.tinyurl.com/horizon-hangout | 20:50 |
| robcresswell | tqtran: Could you look at https://review.openstack.org/#/c/253573/ ? I recall you were involved in the drag n drop stuff | 20:51 |
| tqtran | robcresswell: sure thing, im restacking my env atm | 20:51 |
| AlexOughton | hi guys, i submitted a bug in january, and someone submitted a patch for it too which seems to solve the problem. is there something else I need to do in order to push this along? thanks! https://bugs.launchpad.net/horizon/+bug/1539722 | 20:51 |
| openstack | Launchpad bug 1539722 in OpenStack Dashboard (Horizon) "Image "container_format" incorrectly modified when editing image" [Undecided,In progress] - Assigned to Renjie Sun (sunrenjie6) | 20:51 |
| tqtran | once its up and running, i'll toss in my 2c | 20:51 |
| david-lyle | I may have too much virtualization | 20:51 |
| *** ZZelle_ has joined #openstack-horizon | 20:52 | |
| robcresswell | tqtran: Thanks! | 20:56 |
| robcresswell | tsufiev: I dont like that patch, but its hard to argue with functioning code. | 20:56 |
| robcresswell | and I dont have a better solution | 20:56 |
| *** neelashah has joined #openstack-horizon | 20:57 | |
| tsufiev | robcresswell, appreciate your pragmatic decision | 20:58 |
| tsufiev | it's sometimes happens that bruteforce is the optimal approach | 20:59 |
| *** cshahani has quit IRC | 21:00 | |
| matt-borland | AlexOughton, thanks for checking in! We're in the last throes of the release, so sorry if we're slow to respond | 21:01 |
| AlexOughton | matt-borland: No worries! Just want to know if there's anything else needed on my side, really. | 21:01 |
| matt-borland | well, it's perhaps late to make patches into Mitaka; usually the best thing to do is to come to the IRC and clamor for reviews well in advance of the release. :) | 21:02 |
| matt-borland | if you can get someone to target a milestone for the bug, that helps as well | 21:03 |
| tsufiev | good night all! | 21:04 |
| matt-borland | what I can do as a bug reviewer is look at the bug and replicate it, then discuss with others whether to take it in | 21:04 |
| robcresswell | night tsufiev | 21:04 |
| matt-borland | thanks tsufiev ! | 21:04 |
| tsufiev | hope next morning all 3 patches will be merged :) | 21:04 |
| *** e0ne has quit IRC | 21:04 | |
| AlexOughton | ok | 21:04 |
| robcresswell | tsufiev: and release tagged | 21:04 |
| tsufiev | yep ) | 21:04 |
| matt-borland | AlexOughton, lemme review that bug and patch. It may be tomorrow morning before I can get feedback on it | 21:05 |
| AlexOughton | matt-borland: Thanks, I appreciate it! | 21:06 |
| matt-borland | thanks for following up, I know it can be a chaotic process :) | 21:06 |
| tyr_ | tsufiev: Just about to leave some minor comments on your recompile patch | 21:06 |
| robcresswell | tyr_: Thanks for looking into that | 21:06 |
| tyr_ | I'm fine with a merge as is, but I'd prefer some minor tweaks. | 21:08 |
| tyr_ | I'm happy to post an alternate version if that is helpful to meet the schedule | 21:09 |
| *** cshahani has joined #openstack-horizon | 21:11 | |
| *** dratushnyy has quit IRC | 21:12 | |
| *** gariveradlt has quit IRC | 21:13 | |
| robcresswell | tyr_: Given that it needs to be fixed better anyway, I'm thinking merge it... | 21:14 |
| robcresswell | matt-borland: Can we address tyrs comments? Or was there a reason not to? | 21:14 |
| matt-borland | There is not a functional difference to what Tyr is suggesting, so I'd merge it. | 21:15 |
| matt-borland | I agree that we could change the context to be clearer, e.g. | 21:15 |
| robcresswell | I'm not too worried, I think its fairly explicitly explained. | 21:15 |
| matt-borland | 'angularHacks.recompileAngularContent()' | 21:15 |
| openstackgerrit | Merged openstack/horizon: Add Horizon support for volume consistency groups https://review.openstack.org/257630 | 21:16 |
| matt-borland | nice ^^ | 21:16 |
| openstackgerrit | Merged openstack/horizon: Make ngcontainers the default Swift UI https://review.openstack.org/293168 | 21:17 |
| *** gberginc has quit IRC | 21:17 | |
| robcresswell | Also nice. | 21:17 |
| matt-borland | very nice, r1chardj0n3s ^^ | 21:17 |
| r1chardj0n3s | \o/ | 21:18 |
| matt-borland | congrats all around, and with that, I'm going to wander off for a while | 21:18 |
| *** jtriley has quit IRC | 21:18 | |
| *** matt-borland has quit IRC | 21:18 | |
| openstackgerrit | Ryan Peters proposed openstack/horizon: Add semantic markup to Project Overview pages https://review.openstack.org/294289 | 21:18 |
| openstackgerrit | Ryan Peters proposed openstack/horizon: Add semantic markup to Project Overview page https://review.openstack.org/294289 | 21:21 |
| *** amotoki has quit IRC | 21:29 | |
| *** lhcheng has joined #openstack-horizon | 21:30 | |
| ducttape_ | r1chardj0n3s: I found an opportunity | 21:31 |
| ducttape_ | if you don't use the horizon out of the root path, things don't go so well :'( | 21:31 |
| david-lyle | ducttape_: there is a patch to fix that | 21:32 |
| ducttape_ | http://pasteboard.co/2lfCYNtQ.png :'( | 21:32 |
| ducttape_ | ¿ donde esta el patcho ? | 21:33 |
| david-lyle | https://review.openstack.org/#/c/293168/ | 21:33 |
| david-lyle | just merged | 21:33 |
| r1chardj0n3s | I really must make another effort at gettting a WEBROOT-ey environment set up :-( | 21:33 |
| *** vgridnev has joined #openstack-horizon | 21:33 | |
| david-lyle | r1chardj0n3s: devstack default is non / | 21:33 |
| TravT | woot! | 21:33 |
| *** lhcheng_ has quit IRC | 21:33 | |
| david-lyle | for just this reason | 21:33 |
| ducttape_ | so this just merged then? | 21:33 |
| r1chardj0n3s | david-lyle: yeah, I should do one of those things | 21:33 |
| r1chardj0n3s | thanks | 21:33 |
| *** vgridnev has quit IRC | 21:34 | |
| david-lyle | ducttape_: yes | 21:34 |
| david-lyle | 17 minutes ago | 21:34 |
| ducttape_ | it would be nice if django's dev server would run with an alternate path type thing, if that is possible | 21:34 |
| TravT | and in 5 more minutes twc will be live with it... | 21:34 |
| *** pauloewerton has quit IRC | 21:34 | |
| david-lyle | ducttape_: I remember trying that, not supported | 21:35 |
| ducttape_ | yep, I kind of recall trying that too | 21:35 |
| TravT | r1chardj0n3s i'm pretty happy my hack work out last night | 21:35 |
| *** doug-fish has quit IRC | 21:35 | |
| r1chardj0n3s | TravT: yes :-) | 21:35 |
| *** jpomeroy has quit IRC | 21:35 | |
| *** Daisy has joined #openstack-horizon | 21:36 | |
| *** doug-fis_ has joined #openstack-horizon | 21:40 | |
| *** Daisy has quit IRC | 21:40 | |
| *** jprovazn has quit IRC | 21:44 | |
| *** doug-fis_ has quit IRC | 21:45 | |
| *** doug-fish has joined #openstack-horizon | 21:45 | |
| *** doug-fish has quit IRC | 21:50 | |
| *** mpavlase has quit IRC | 21:52 | |
| ducttape_ | TravT: it's taking me longer than 5 minutes, which makes me sad :'( , room for growth I suppose | 21:55 |
| TravT | c'mon ducttape_ your slipping | 21:55 |
| *** doug-fish has joined #openstack-horizon | 21:56 | |
| ducttape_ | well, it takes me 10 minutes to just run upstream unit tests and gather coverage results, so there is that | 21:56 |
| *** neelashah1 has joined #openstack-horizon | 21:57 | |
| lapalm | Would anyone happen to know hot to ping/ssh into a nova Instance from your local Devstack VM? | 21:58 |
| *** amotoki has joined #openstack-horizon | 22:00 | |
| *** neelashah has quit IRC | 22:01 | |
| *** neelashah1 has quit IRC | 22:02 | |
| ducttape_ | it depends upon the networking / neutron setup used iirc lapalm | 22:03 |
| ducttape_ | r1chardj0n3s / david-lyle that latest patch does indeed work with the other path. thanks again | 22:03 |
| robcresswell | \o/ | 22:03 |
| r1chardj0n3s | ducttape_: thanks for verifying! | 22:04 |
| ducttape_ | np | 22:04 |
| lapalm | ducttape_: Yea, I am using the default Devstack installation, created 2 instances, but cannot ping one instance from the other | 22:04 |
| lapalm | Accessing the instance from the Horizon VNC console | 22:05 |
| *** peristeri has quit IRC | 22:05 | |
| lapalm | Both on public network | 22:05 |
| *** zul has joined #openstack-horizon | 22:06 | |
| ducttape_ | they both share the same tenant network then lapalm ? | 22:07 |
| lapalm | yes | 22:07 |
| lapalm | super simple setup here but frustrating why it wont work | 22:07 |
| lapalm | I have added the sec groups for ICMP and SSH | 22:07 |
| *** clu__ has joined #openstack-horizon | 22:12 | |
| ducttape_ | lapalm: not sure what to say, I'm not 100% familiar with devstacks neutron / networking setup. can you ping your gateway ? | 22:12 |
| *** ametts has quit IRC | 22:14 | |
| *** gberginc has joined #openstack-horizon | 22:14 | |
| *** piet has quit IRC | 22:16 | |
| *** piet has joined #openstack-horizon | 22:16 | |
| *** amotoki has quit IRC | 22:17 | |
| lapalm | ducttape_: No I cannot, Thanks for trying to help though ;) | 22:17 |
| ducttape_ | but the instance got an ip address? and the interface shows up? | 22:18 |
| *** zul has quit IRC | 22:18 | |
| lapalm | instance got an IP on public network of 172.24.4.3 | 22:18 |
| openstackgerrit | Merged openstack/horizon: Add Network Port selection to new instance launch https://review.openstack.org/253573 | 22:20 |
| *** vijendar has quit IRC | 22:21 | |
| *** Drago has joined #openstack-horizon | 22:22 | |
| robcresswell | TravT: Seems to be a bunch of patches tracked against https://blueprints.launchpad.net/horizon/+spec/integrate-magic-search which aren't really relevant? | 22:25 |
| robcresswell | Might be better to put up a new bp for those | 22:25 |
| *** ducttape_ has quit IRC | 22:26 | |
| TravT | oh, that looks like people not being careful with topics | 22:27 |
| TravT | that one is implemented. i just updated it as such | 22:27 |
| TravT | also removed those. | 22:28 |
| robcresswell | TravT: Awesome, thought you'd be the one to ask since it was searchlight related. | 22:30 |
| robcresswell | Just filing missing releasenotes. | 22:30 |
| TravT | cool | 22:30 |
| robcresswell | super fun RC work :D | 22:30 |
| TravT | yeah, but it is important | 22:30 |
| *** bpokorny_ has joined #openstack-horizon | 22:31 | |
| TravT | where do those get published? | 22:32 |
| *** bpokorny has quit IRC | 22:34 | |
| robcresswell | I actually don't know | 22:35 |
| robcresswell | you can generate them locally quite easily | 22:35 |
| robcresswell | But yeah agreed TravT, def important, hence chasing them up | 22:36 |
| *** xinwu has quit IRC | 22:40 | |
| tqtran | TravT: does searchlight require neutron to be installed? | 22:43 |
| TravT | no | 22:43 |
| TravT | it is all plugin based | 22:43 |
| TravT | i'm going through sjmc7's neutron subnets plugin for it now actually | 22:44 |
| TravT | so there are plugins for different resource types | 22:44 |
| *** BillC has joined #openstack-horizon | 22:44 | |
| TravT | http://docs.openstack.org/developer/searchlight/#search-plugins | 22:45 |
| tqtran | ok im not that advanced, still just trying to get my devstack to work lol | 22:45 |
| TravT | oh, are you adding it to your devstack? | 22:45 |
| tqtran | yes | 22:45 |
| TravT | i have a sample local.conf | 22:45 |
| tqtran | yeah, im following that atm | 22:45 |
| tqtran | and appending it to the horizon local_conf rst | 22:45 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Add missing release notes https://review.openstack.org/294314 | 22:45 |
| r1chardj0n3s | TravT: could you publish that like the sample Horizon developer local.conf is? | 22:45 |
| TravT | https://github.com/openstack/searchlight/tree/master/devstack | 22:46 |
| tqtran | but its failing twice now, so im trying different combos to get it to work | 22:46 |
| r1chardj0n3s | aha | 22:46 |
| TravT | https://github.com/openstack/searchlight/blob/master/devstack/local.conf | 22:46 |
| r1chardj0n3s | yep, thanks :-) | 22:46 |
| robcresswell | david-lyle: https://review.openstack.org/294314 | 22:46 |
| * r1chardj0n3s has meetings but will fire up a new stack with that conf included after | 22:46 | |
| TravT | okay that's cool. i have a modification to it sitting locally now | 22:47 |
| robcresswell | david-lyle: I'm heading to bed, so if there's any mistakes either push a new patch set or Ill do it in the morning :) | 22:47 |
| robcresswell | night folks | 22:47 |
| r1chardj0n3s | robcresswell: hmm, I've had issues with relno barfing on notes formatted like https://review.openstack.org/#/c/294314/1/releasenotes/notes/bp-angular-performance-strict-di-3cf325d8bfca8487.yaml | 22:47 |
| r1chardj0n3s | do you mind if I make edits to keep relno happy? | 22:47 |
| r1chardj0n3s | (assuming it barfs) | 22:48 |
| TravT | r1chardj0n3s for swift, the instructions are a bit more difficult | 22:48 |
| tqtran | thanks for putting those release notes in robcresswell | 22:48 |
| TravT | thanks r1chardj0n3s | 22:48 |
| TravT | thanks robcresswell | 22:48 |
| *** gberginc has quit IRC | 22:48 | |
| TravT | r1chardj0n3s: you have to manually install the middleware piece | 22:48 |
| r1chardj0n3s | ahh | 22:48 |
| TravT | but it isn't too bad. | 22:48 |
| r1chardj0n3s | ok | 22:48 |
| TravT | i could step you through it if you want in a hangout | 22:48 |
| TravT | instructions are all there. | 22:49 |
| TravT | you are smart guy | 22:49 |
| TravT | i not | 22:49 |
| TravT | canot type | 22:49 |
| TravT | or spl | 22:49 |
| openstackgerrit | Eddie Ramirez proposed openstack/horizon: Bootstrap Theme Preview links to sections don't work Edit https://review.openstack.org/294317 | 22:49 |
| TravT | ;-P | 22:49 |
| TravT | http://docs.openstack.org/developer/searchlight/plugins/swift.html | 22:49 |
| r1chardj0n3s | TravT: I haz meetings for a bit, but then sure (assuming no fires to put out) | 22:50 |
| openstackgerrit | Merged openstack/horizon: Fix non-working Angular actions in jquery modified tables https://review.openstack.org/289849 | 22:51 |
| tqtran | r1chardj0n3s: i have a bucket of water for you | 22:51 |
| TravT | if r1chardj0n3s and tqtran can wait until next week, we'll have the rc1 tag on | 22:52 |
| TravT | but either way | 22:52 |
| TravT | i just actually need to step away for now | 22:53 |
| TravT | and finish a few reviews later. | 22:53 |
| TravT | bbiab | 22:53 |
| tqtran | stepping away for a bit as well | 22:54 |
| *** tqtran is now known as tqtran-afk | 22:54 | |
| *** piet has quit IRC | 23:00 | |
| *** piet has joined #openstack-horizon | 23:01 | |
| *** tqtran-afk has quit IRC | 23:01 | |
| *** lapalm has quit IRC | 23:07 | |
| *** aimeeU has quit IRC | 23:07 | |
| *** pushkaru has quit IRC | 23:09 | |
| *** Mounica has quit IRC | 23:09 | |
| *** Mounica has joined #openstack-horizon | 23:11 | |
| *** TravT has quit IRC | 23:11 | |
| *** gberginc has joined #openstack-horizon | 23:12 | |
| *** TravT has joined #openstack-horizon | 23:12 | |
| *** piet has quit IRC | 23:14 | |
| *** tyr_ has quit IRC | 23:19 | |
| *** pushkaru has joined #openstack-horizon | 23:19 | |
| *** gberginc has quit IRC | 23:21 | |
| openstackgerrit | David Lyle proposed openstack/horizon: Adding missing release notes around upgrades https://review.openstack.org/294328 | 23:24 |
| *** Mounica has quit IRC | 23:24 | |
| *** Mounica has joined #openstack-horizon | 23:25 | |
| openstackgerrit | David Lyle proposed openstack/horizon: Adding missing release notes around upgrades https://review.openstack.org/294328 | 23:28 |
| *** Mounica has quit IRC | 23:31 | |
| *** bpokorny_ has quit IRC | 23:31 | |
| *** pushkaru has quit IRC | 23:32 | |
| *** bpokorny has joined #openstack-horizon | 23:32 | |
| *** bpokorny has quit IRC | 23:32 | |
| *** Mounica has joined #openstack-horizon | 23:33 | |
| *** bpokorny has joined #openstack-horizon | 23:33 | |
| *** ediardo has quit IRC | 23:35 | |
| openstackgerrit | David Lyle proposed openstack/horizon: Adding missing release notes around upgrades https://review.openstack.org/294328 | 23:35 |
| hurgleburgler | david-lyle I think we should propose that a 4th time | 23:37 |
| hurgleburgler | ;) | 23:37 |
| *** clu__ has quit IRC | 23:37 | |
| r1chardj0n3s | david-lyle: https://bugs.launchpad.net/horizon/+bug/1558825 for your relnotes patch? | 23:41 |
| openstack | Launchpad bug 1558825 in OpenStack Dashboard (Horizon) "Some code changes are missing release notes" [High,In progress] - Assigned to Rob Cresswell (robcresswell) | 23:41 |
| openstackgerrit | David Lyle proposed openstack/horizon: Add missing release notes https://review.openstack.org/294314 | 23:41 |
| r1chardj0n3s | (just to tie it in with robcresswell's patch) | 23:41 |
| david-lyle | r1chardj0n3s: sure | 23:42 |
| r1chardj0n3s | david-lyle: I'm sure robcresswell won't mind me editing some typos out of his relno patch, right? | 23:42 |
| david-lyle | I edited one | 23:42 |
| david-lyle | but no, he wouldn't | 23:42 |
| openstackgerrit | David Lyle proposed openstack/horizon: Adding missing release notes around upgrades https://review.openstack.org/294328 | 23:43 |
| r1chardj0n3s | ah, that looks like the typo I was going to edit, thanks :-) | 23:43 |
| david-lyle | added bug ref on mine | 23:43 |
| *** dratushnyy has joined #openstack-horizon | 23:43 | |
| david-lyle | reno builds fail for me locally | 23:43 |
| david-lyle | will see what the gate thinks | 23:44 |
| r1chardj0n3s | ok | 23:44 |
| r1chardj0n3s | +2'ed Rob's ... will await the gate for yours | 23:44 |
| r1chardj0n3s | (Rob's passed without your trivial edit) | 23:44 |
| david-lyle | yeah I saw, his fails locally for me too | 23:45 |
| r1chardj0n3s | huh | 23:45 |
| david-lyle | pushed rob's | 23:45 |
| r1chardj0n3s | need to update local relno dependencies in your venv maybe? | 23:45 |
| david-lyle | probably | 23:46 |
| david-lyle | I think -e releasenotes doesn't pull dependencies | 23:46 |
| david-lyle | nope new venv still fails | 23:48 |
| david-lyle | oh well, the gate will do the right thing | 23:48 |
| david-lyle | I have to run, if you see issues, feel free to fix | 23:48 |
| r1chardj0n3s | Trust In The Gate | 23:48 |
| r1chardj0n3s | ok will di | 23:48 |
| r1chardj0n3s | do | 23:48 |
| david-lyle | goodnight | 23:49 |
| r1chardj0n3s | night! | 23:49 |
| *** fedexo has joined #openstack-horizon | 23:53 | |
| *** xinwu has joined #openstack-horizon | 23:53 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
