| r1chardj0n3s | robcresswell: cheers mate, I know they come from a place of love :-) | 00:00 |
|---|---|---|
| *** zzxwill has quit IRC | 00:00 | |
| robcresswell | r1chardj0n3s: Heh, its nice that you think that :) | 00:00 |
| robcresswell | r1chardj0n3s: Btw, feel free to let me know if I'm being overly picky in any of the reviews. I don't expect absolute perfection. | 00:01 |
| r1chardj0n3s | you've identified one bug which I will investigate and that loggging thing which I will try to address | 00:02 |
| r1chardj0n3s | it's all good | 00:02 |
| robcresswell | Excellent. Just reviewing object actions atm. | 00:02 |
| robcresswell | Then sleep. | 00:02 |
| r1chardj0n3s | cool | 00:02 |
| *** ski1 has joined #openstack-horizon | 00:05 | |
| *** zzxwill has joined #openstack-horizon | 00:06 | |
| *** ErikNeeley has quit IRC | 00:09 | |
| ski1 | bpokorny_: hey working with ankur on https://review.openstack.org/#/c/283171/, we are able to get the errors removed that were caused by this patch, but there are additional errors that are outside the scope of the patch, should we fix them as part of this or proceed https://gist.githubusercontent.com/stajkowski/a59962ad763a7935f944/raw/e266677e69d3494fd88294ed092672fc24ae3a33/gistfile1.txt | 00:10 |
| *** kzaitsev_mb has quit IRC | 00:12 | |
| robcresswell | r1chardj0n3s: I left a few comments. Mostly minor. Will go over both again in the morning. | 00:12 |
| robcresswell | Night folks :D | 00:13 |
| r1chardj0n3s | robcresswell: thanks! good night! | 00:13 |
| bpokorny_ | ski1: In a meeting right now, but will get back to you soon. | 00:14 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: Launch Instance https://review.openstack.org/289679 | 00:14 |
| ski1 | bpokorny_: no problem, yeah i do see one last thing not right, i'll have a quick question on that one | 00:14 |
| *** doug-fish has joined #openstack-horizon | 00:16 | |
| *** doug-fish has quit IRC | 00:17 | |
| *** doug-fish has joined #openstack-horizon | 00:17 | |
| *** TravT has quit IRC | 00:18 | |
| *** zzxwill has quit IRC | 00:20 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: Admin Panels https://review.openstack.org/290204 | 00:21 |
| *** doug-fish has quit IRC | 00:22 | |
| *** doug-fis_ has joined #openstack-horizon | 00:22 | |
| *** openstackgerrit_ has quit IRC | 00:23 | |
| *** yamamoto_ has joined #openstack-horizon | 00:24 | |
| *** zzxwill has joined #openstack-horizon | 00:24 | |
| *** bapalm has quit IRC | 00:24 | |
| *** doug-fish has joined #openstack-horizon | 00:24 | |
| *** openstackgerrit_ has joined #openstack-horizon | 00:25 | |
| *** doug-fis_ has quit IRC | 00:26 | |
| *** doug-fis_ has joined #openstack-horizon | 00:27 | |
| *** yamamoto_ has quit IRC | 00:28 | |
| *** doug-fish has quit IRC | 00:29 | |
| *** bpokorny_ has quit IRC | 00:29 | |
| *** doug-fish has joined #openstack-horizon | 00:29 | |
| *** bpokorny has joined #openstack-horizon | 00:29 | |
| *** Mounica has quit IRC | 00:31 | |
| *** doug-fis_ has quit IRC | 00:32 | |
| *** doug-fish has quit IRC | 00:34 | |
| *** jtriley has joined #openstack-horizon | 00:34 | |
| *** dan_nguyen has quit IRC | 00:39 | |
| bpokorny | ski1: I'm back now. You mentioned you fixed the errors that were caused by the patch but there are other errors outside the scope of the patch. | 00:40 |
| *** zzxwill has quit IRC | 00:41 | |
| bpokorny | Are these the errors that are outside the scope of the patch? https://gist.githubusercontent.com/stajkowski/a59962ad763a7935f944/raw/e266677e69d3494fd88294ed092672fc24ae3a33/gistfile1.txt | 00:41 |
| *** bapalm has joined #openstack-horizon | 00:41 | |
| *** zzxwill has joined #openstack-horizon | 00:42 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Material theme form errors - fix red text on red bg https://review.openstack.org/291486 | 00:44 |
| *** jpomeroy has quit IRC | 00:45 | |
| *** Mounica has joined #openstack-horizon | 00:46 | |
| ski1 | bpokorny: correct https://gist.github.com/stajkowski/a59962ad763a7935f944 | 00:46 |
| *** dan_nguyen has joined #openstack-horizon | 00:46 | |
| ski1 | bpokorny: there is one function.__call__(<class 'django.http.HttpRequest'>, 'network-ip-availability') -> None | 00:46 |
| ski1 | in test_delete_network_exception | 00:46 |
| ski1 | that i'm a bit confused about | 00:47 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Material theme form errors - fix red text on red bg https://review.openstack.org/291486 | 00:47 |
| * bpokorny looks | 00:47 | |
| *** openstackgerrit_ has quit IRC | 00:48 | |
| *** jtriley has quit IRC | 00:49 | |
| *** openstackgerrit_ has joined #openstack-horizon | 00:50 | |
| *** lblanchard has joined #openstack-horizon | 00:52 | |
| *** chlong has joined #openstack-horizon | 00:52 | |
| *** zzxwill has quit IRC | 00:52 | |
| bpokorny | ski1: Often those kinds of errors occur when you've added functionality to a codepath and you haven't modified the test for that codepath to include your new function calls. | 00:52 |
| bpokorny | In that case, the tests will stop and not continue, and you'll see errors about methods not called. | 00:53 |
| bpokorny | So in the case of test_delete_network_exception, for example, take a look at what that test is doing. | 00:53 |
| ski1 | bpokorny: understood, we are all new to this, not new to django but just need to figure out a starting point to get this going | 00:53 |
| bpokorny | And try to find the place where it's exercising a codepath that you've modified. | 00:54 |
| openstackgerrit | Merged openstack/horizon: Ensure there is checkbox before accessing it's properties https://review.openstack.org/291345 | 00:54 |
| bpokorny | You'll probably need to add some mock calls to that test so it expects your functions to be called. | 00:54 |
| ski1 | majority would be in views | 00:55 |
| bpokorny | ski1: Yeah, makes sense. | 00:56 |
| bpokorny | ski1: What company are you working for? | 00:56 |
| ski1 | bpokorny: do you have an example for a mock call, not sure on that point | 00:56 |
| ski1 | bpokorny: rackspace, the dev you were working with is an intel dev on our team, we are all neutron focused | 00:57 |
| ski1 | bpokorny: so horizon work is going to be a bit out of our knowledge atm | 00:57 |
| bpokorny | Cool, make sense. | 00:57 |
| bpokorny | Looking for an example.. | 00:57 |
| openstackgerrit | Merged openstack/horizon: Pagination for flavor - prev link https://review.openstack.org/288228 | 00:58 |
| openstackgerrit | Merged openstack/horizon: Launch Instance Wizard - Avail items count doesn't update https://review.openstack.org/246698 | 00:58 |
| ski1 | bpokorny: awesome, thanks for your help! | 00:58 |
| *** zzxwill has joined #openstack-horizon | 00:59 | |
| bpokorny | ski1: For test_delete_network_exception: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/networks/tests.py#L630 | 01:01 |
| bpokorny | They've mocked out the api.neutron.list_dhcp_agent_hosting_networks call and specified what the mock should return. | 01:02 |
| bpokorny | My guess is your code is now being called along that code path, and so you'll need to add something similar for what's being called now. | 01:02 |
| ski1 | bpokorny: yep that would be called along that path | 01:03 |
| ski1 | as a first step I added | 01:04 |
| ski1 | api.neutron.is_extension_supported( | 01:04 |
| ski1 | IsA(http.HttpRequest), | 01:04 |
| ski1 | 'network-ip-availability').AndReturn(True) | 01:04 |
| ski1 | in all other cases is returns as expected | 01:04 |
| ski1 | in the method, i get None returned for some reason | 01:04 |
| bpokorny | ski1: Wrapping your head around how all the mocks works will be hard. Just keep at it, and read up on Mox documentation. | 01:05 |
| *** Mounica has quit IRC | 01:06 | |
| ski1 | bpokorny: will do | 01:07 |
| *** neelashah has joined #openstack-horizon | 01:08 | |
| *** zzxwill has quit IRC | 01:13 | |
| *** zzxwill has joined #openstack-horizon | 01:18 | |
| *** xinwu has quit IRC | 01:20 | |
| *** clu_ has quit IRC | 01:23 | |
| *** jtriley has joined #openstack-horizon | 01:25 | |
| *** zhurong_ has joined #openstack-horizon | 01:29 | |
| *** zzxwill has quit IRC | 01:33 | |
| *** zzxwill has joined #openstack-horizon | 01:34 | |
| *** zzxwill has quit IRC | 01:49 | |
| *** zzxwill has joined #openstack-horizon | 01:49 | |
| *** pushkaru has quit IRC | 01:50 | |
| *** hurgleburgler has quit IRC | 01:51 | |
| *** lblanchard has quit IRC | 01:53 | |
| openstackgerrit | Brad Pokorny proposed openstack/horizon: Add Horizon support for volume consistency groups https://review.openstack.org/257630 | 01:56 |
| *** zzxwill has quit IRC | 02:00 | |
| *** bpokorny_ has joined #openstack-horizon | 02:00 | |
| *** mtanino has quit IRC | 02:02 | |
| *** bpokorny has quit IRC | 02:04 | |
| *** k-ishii has quit IRC | 02:05 | |
| *** bpokorny_ has quit IRC | 02:05 | |
| *** gyee has quit IRC | 02:10 | |
| *** bapalm has quit IRC | 02:11 | |
| *** zzxwill has joined #openstack-horizon | 02:12 | |
| *** lhcheng_ has quit IRC | 02:13 | |
| *** bapalm has joined #openstack-horizon | 02:16 | |
| *** zzxwill has quit IRC | 02:24 | |
| *** yamamoto_ has joined #openstack-horizon | 02:25 | |
| openstackgerrit | Merged openstack/horizon: Disable Glance option to publicize image on Update https://review.openstack.org/288814 | 02:27 |
| *** jtriley has quit IRC | 02:27 | |
| *** lhcheng has joined #openstack-horizon | 02:29 | |
| *** zzxwill has joined #openstack-horizon | 02:30 | |
| *** wangbo has joined #openstack-horizon | 02:32 | |
| *** Guest38484 is now known as mfisch | 02:33 | |
| *** mfisch is now known as Guest13749 | 02:34 | |
| *** jtriley has joined #openstack-horizon | 02:39 | |
| *** tqtran-afk has quit IRC | 02:45 | |
| *** yamamoto_ has quit IRC | 02:48 | |
| *** jtriley has quit IRC | 02:52 | |
| *** jtriley has joined #openstack-horizon | 02:53 | |
| *** pushkaru has joined #openstack-horizon | 03:00 | |
| *** zzxwill has quit IRC | 03:12 | |
| *** Mounica has joined #openstack-horizon | 03:12 | |
| *** Mounica has quit IRC | 03:15 | |
| *** Mounica has joined #openstack-horizon | 03:15 | |
| *** lhcheng has quit IRC | 03:15 | |
| *** pushkaru has quit IRC | 03:16 | |
| *** zzxwill has joined #openstack-horizon | 03:16 | |
| *** pushkaru has joined #openstack-horizon | 03:17 | |
| *** reedip_ has joined #openstack-horizon | 03:24 | |
| *** zul_ has joined #openstack-horizon | 03:25 | |
| *** leitan has quit IRC | 03:27 | |
| *** krotscheck has quit IRC | 03:30 | |
| *** zul has quit IRC | 03:30 | |
| *** reedip_away has quit IRC | 03:30 | |
| *** krotscheck has joined #openstack-horizon | 03:31 | |
| *** yamamoto has joined #openstack-horizon | 03:36 | |
| *** tqtran-afk has joined #openstack-horizon | 03:42 | |
| *** jtriley has quit IRC | 03:44 | |
| *** jtriley has joined #openstack-horizon | 03:45 | |
| *** tqtran-afk has quit IRC | 03:46 | |
| *** reedip_ is now known as reedip | 03:57 | |
| *** Mounica has quit IRC | 04:00 | |
| *** Mounica has joined #openstack-horizon | 04:00 | |
| *** wolverineav has quit IRC | 04:01 | |
| *** shu-mutou-AFK is now known as shu-mutou | 04:02 | |
| *** Mounica has quit IRC | 04:05 | |
| *** zzxwill has quit IRC | 04:11 | |
| *** zzxwill has joined #openstack-horizon | 04:12 | |
| *** TravT has joined #openstack-horizon | 04:14 | |
| *** Mounica has joined #openstack-horizon | 04:15 | |
| *** TravT has quit IRC | 04:16 | |
| *** TravT_ has joined #openstack-horizon | 04:16 | |
| *** TravT_ is now known as TravT | 04:16 | |
| *** fedexo has joined #openstack-horizon | 04:17 | |
| r1chardj0n3s | TravT: hey | 04:17 |
| r1chardj0n3s | angular hates me | 04:17 |
| TravT | hey, how are things going with swift | 04:17 |
| r1chardj0n3s | angular hates me | 04:18 |
| r1chardj0n3s | ;-) | 04:18 |
| TravT | oh yay! | 04:18 |
| *** Mounica_ has joined #openstack-horizon | 04:19 | |
| r1chardj0n3s | I have fixed a thing, and the fix makes NO SENSE | 04:20 |
| *** Mounica has quit IRC | 04:20 | |
| TravT | oh boy | 04:20 |
| TravT | i saw rob harassing you and figured i'd let him finish his harassment | 04:20 |
| r1chardj0n3s | so you know how I'm doing the public/private checkbox? | 04:21 |
| r1chardj0n3s | in the container details view? | 04:21 |
| * TravT pull up patch | 04:21 | |
| TravT | pulss | 04:21 |
| *** hurgleburgler has joined #openstack-horizon | 04:21 | |
| TravT | i really shouldn't be allowed near a keyboard | 04:21 |
| r1chardj0n3s | hahah, had a good session? | 04:21 |
| TravT | no, i was up working 'till 12:30 am last night and woke up at 5 am today. | 04:22 |
| TravT | been a long day | 04:22 |
| r1chardj0n3s | you should step away from the computer | 04:22 |
| *** wolverineav has joined #openstack-horizon | 04:23 | |
| *** wolverineav has quit IRC | 04:24 | |
| *** wolverineav has joined #openstack-horizon | 04:25 | |
| *** pushkaru has quit IRC | 04:30 | |
| *** zzxwill has quit IRC | 04:33 | |
| *** Mounica_ has quit IRC | 04:35 | |
| openstackgerrit | Alexis Rivera proposed openstack/horizon: changing-fa-icon-to-trash-icon https://review.openstack.org/289592 | 04:36 |
| *** sjmc7 has joined #openstack-horizon | 04:40 | |
| *** wangbo has quit IRC | 04:42 | |
| *** pushkaru has joined #openstack-horizon | 04:51 | |
| *** zzxwill has joined #openstack-horizon | 04:51 | |
| *** lhcheng has joined #openstack-horizon | 04:53 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add ngSwift object actions https://review.openstack.org/270553 | 04:54 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add ngSwift container actions https://review.openstack.org/259236 | 04:54 |
| *** tqtran-afk has joined #openstack-horizon | 04:58 | |
| *** masco has joined #openstack-horizon | 04:59 | |
| *** wangbo has joined #openstack-horizon | 05:00 | |
| *** Mounica has joined #openstack-horizon | 05:00 | |
| *** tqtran-afk has quit IRC | 05:02 | |
| *** vishwanathj is now known as vishwanathj_zzz | 05:07 | |
| *** wolverineav has quit IRC | 05:10 | |
| *** wolverineav has joined #openstack-horizon | 05:11 | |
| *** k-ishii has joined #openstack-horizon | 05:12 | |
| *** neelashah has quit IRC | 05:13 | |
| *** zzxwill has quit IRC | 05:14 | |
| *** k-ishii has quit IRC | 05:16 | |
| *** dan_nguyen has quit IRC | 05:16 | |
| *** zzxwill has joined #openstack-horizon | 05:18 | |
| *** fedexo has quit IRC | 05:27 | |
| *** zzxwill has quit IRC | 05:27 | |
| *** Mounica has quit IRC | 05:27 | |
| *** wangbo has quit IRC | 05:28 | |
| *** wangbo has joined #openstack-horizon | 05:28 | |
| *** Mounica has joined #openstack-horizon | 05:29 | |
| *** zzxwill has joined #openstack-horizon | 05:30 | |
| *** sjmc7 has quit IRC | 05:30 | |
| openstackgerrit | Sanjana proposed openstack/horizon: Using generic class NameFilterAction https://review.openstack.org/271185 | 05:32 |
| *** Mounica has quit IRC | 05:34 | |
| *** pushkaru has quit IRC | 05:37 | |
| *** petertr7_away has quit IRC | 05:41 | |
| *** wolverineav has quit IRC | 05:43 | |
| *** zzxwill has quit IRC | 05:43 | |
| *** zzxwill has joined #openstack-horizon | 05:44 | |
| *** wolverineav has joined #openstack-horizon | 05:44 | |
| *** jtriley has quit IRC | 05:49 | |
| *** amotoki has joined #openstack-horizon | 05:50 | |
| *** amotoki has quit IRC | 05:50 | |
| *** zhurong_ has quit IRC | 05:53 | |
| *** zzxwill has quit IRC | 05:54 | |
| *** zzxwill has joined #openstack-horizon | 05:55 | |
| *** zhurong_ has joined #openstack-horizon | 05:56 | |
| *** ski1 has quit IRC | 05:56 | |
| *** wangbo has quit IRC | 05:58 | |
| *** wangbo has joined #openstack-horizon | 05:58 | |
| *** hurgleburgler has quit IRC | 06:01 | |
| *** krotscheck has quit IRC | 06:01 | |
| *** ski1 has joined #openstack-horizon | 06:02 | |
| *** k-ishii has joined #openstack-horizon | 06:04 | |
| *** krotscheck has joined #openstack-horizon | 06:09 | |
| *** k-ishii has quit IRC | 06:12 | |
| openstackgerrit | Merged openstack/horizon: Form Fields Required Visual treatment is missing https://review.openstack.org/291424 | 06:14 |
| *** openstackgerrit_ has quit IRC | 06:17 | |
| *** cloudtrainme has joined #openstack-horizon | 06:17 | |
| *** cloudtrainme has quit IRC | 06:18 | |
| *** openstackgerrit_ has joined #openstack-horizon | 06:18 | |
| *** zzxwill has quit IRC | 06:25 | |
| *** lhcheng_ has joined #openstack-horizon | 06:27 | |
| *** zzxwill has joined #openstack-horizon | 06:28 | |
| *** lhcheng has quit IRC | 06:29 | |
| *** jprovazn has joined #openstack-horizon | 06:32 | |
| *** zzxwill has quit IRC | 06:33 | |
| *** zzxwill has joined #openstack-horizon | 06:33 | |
| *** x00350071 has joined #openstack-horizon | 06:34 | |
| *** lhcheng has joined #openstack-horizon | 06:39 | |
| *** xinwu has joined #openstack-horizon | 06:41 | |
| *** lhcheng_ has quit IRC | 06:41 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 06:42 | |
| *** shu-mutou is now known as shu-mutou-AFK | 06:46 | |
| *** rcernin has joined #openstack-horizon | 06:49 | |
| *** k-ishii has joined #openstack-horizon | 06:55 | |
| *** zzxwill has quit IRC | 06:58 | |
| *** k-ishii has quit IRC | 07:03 | |
| *** wangbo has quit IRC | 07:07 | |
| *** zzxwill has joined #openstack-horizon | 07:07 | |
| *** ski1 has quit IRC | 07:10 | |
| *** rdopiera has joined #openstack-horizon | 07:11 | |
| *** zhurong_ has quit IRC | 07:11 | |
| *** zhurong_ has joined #openstack-horizon | 07:12 | |
| *** absubram has joined #openstack-horizon | 07:18 | |
| *** absubram_ has joined #openstack-horizon | 07:19 | |
| *** ski1 has joined #openstack-horizon | 07:21 | |
| *** aortega has quit IRC | 07:22 | |
| *** wangbo has joined #openstack-horizon | 07:22 | |
| *** absubram has quit IRC | 07:23 | |
| *** absubram_ is now known as absubram | 07:23 | |
| *** jtomasek has joined #openstack-horizon | 07:27 | |
| *** amotoki has joined #openstack-horizon | 07:29 | |
| *** zzxwill has quit IRC | 07:31 | |
| *** zzxwill has joined #openstack-horizon | 07:33 | |
| *** k-ishii has joined #openstack-horizon | 07:34 | |
| *** absubram has quit IRC | 07:38 | |
| *** zzxwill has quit IRC | 07:38 | |
| *** belmoreira has joined #openstack-horizon | 07:40 | |
| *** zzxwill has joined #openstack-horizon | 07:45 | |
| *** mpavlase has joined #openstack-horizon | 07:45 | |
| *** adiantum has quit IRC | 07:45 | |
| *** ski1 has quit IRC | 07:47 | |
| *** pece has joined #openstack-horizon | 07:52 | |
| *** mpavlase has quit IRC | 07:52 | |
| *** mpavlase has joined #openstack-horizon | 07:53 | |
| *** ski1 has joined #openstack-horizon | 07:53 | |
| *** k-ishii has quit IRC | 07:55 | |
| *** k-ishii has joined #openstack-horizon | 07:58 | |
| *** kzaitsev_mb has joined #openstack-horizon | 07:59 | |
| *** wangbo has quit IRC | 08:00 | |
| *** zzxwill has quit IRC | 08:02 | |
| *** zzxwill has joined #openstack-horizon | 08:03 | |
| *** lhcheng has quit IRC | 08:03 | |
| *** wangbo has joined #openstack-horizon | 08:15 | |
| pece | Hi, when cloud admin switches context to other domain and tries to manage members of project, which belongs to that domain there is "Error: Unable to retrieve project details" message. Horizon log shows "WARNING:horizon.exceptions:Recoverable error: Malformed request URL: URL's project_id '58b7cf94dd5b45e48862b313abc2eb4d' doesn't match Context's project_id '822807ca292d45aeb0731881587dc608' | 08:16 |
| pece | (HTTP 400) (Request-ID: req-06a3b8c4-bab9-4481-ab39-965bf0bc29bf)" | 08:16 |
| pece | request is: REQ: curl -g -i 'http://127.0.0.1:9009/v2/58b7cf94dd5b45e48862b313abc2eb4d/os-quota-sets/8d50ae7be0064fb0831c054a0a37e5fb' -X GET -H "Accept: application/json" -H "User-Agent: python-novaclient" -H "X-Auth-Project-Id: 58b7cf94dd5b45e48862b313abc2eb4d" -H "X-Auth-Token: {SHA1}5483e3d6191f86958e205db407c9a6dca1657d95" | 08:17 |
| pece | RESP: [400] {'Date': 'Fri, 11 Mar 2016 08:01:14 GMT', 'X-Compute-Request-Id': 'req-06a3b8c4-bab9-4481-ab39-965bf0bc29bf' | 08:17 |
| pece | , 'Connection': 'keep-alive', 'Content-Type': 'application/json; charset=UTF-8', 'Content-Length': '188'} | 08:17 |
| pece | RESP BODY: null | 08:17 |
| *** k-ishii has quit IRC | 08:17 | |
| pece | Am I missing some patches, or is it WIP? | 08:20 |
| *** e0ne has joined #openstack-horizon | 08:21 | |
| *** jamielennox is now known as jamielennox|away | 08:23 | |
| *** ccard__ has joined #openstack-horizon | 08:24 | |
| *** zzxwill has quit IRC | 08:25 | |
| *** zzxwill has joined #openstack-horizon | 08:29 | |
| *** wolverineav has quit IRC | 08:31 | |
| *** wolverineav has joined #openstack-horizon | 08:31 | |
| *** wolverineav has quit IRC | 08:36 | |
| *** zzxwill has quit IRC | 08:37 | |
| *** wangbo has quit IRC | 08:38 | |
| mrunge | pece, iirc, it's wip, but be sure to report back | 08:40 |
| *** zzxwill has joined #openstack-horizon | 08:40 | |
| mrunge | pece, preferred way is filing bugs on launchpad | 08:40 |
| mrunge | pece, the patches are up for a while, but it doesn't seem to get any traction | 08:41 |
| *** pcaruana has joined #openstack-horizon | 08:41 | |
| *** adiantum has joined #openstack-horizon | 08:42 | |
| *** k-ishii has joined #openstack-horizon | 08:45 | |
| *** jtriley has joined #openstack-horizon | 08:45 | |
| *** zzxwill has quit IRC | 08:47 | |
| *** chlong has quit IRC | 08:49 | |
| *** zzxwill has joined #openstack-horizon | 08:50 | |
| *** jtriley has quit IRC | 08:52 | |
| *** k-ishii has quit IRC | 08:54 | |
| *** kzaitsev_mb has quit IRC | 08:54 | |
| *** ygbo has joined #openstack-horizon | 08:59 | |
| *** k-ishii has joined #openstack-horizon | 09:04 | |
| *** aortega has joined #openstack-horizon | 09:05 | |
| *** zhurong_ has quit IRC | 09:10 | |
| *** ramishra has quit IRC | 09:19 | |
| *** zzxwill has quit IRC | 09:20 | |
| *** zzxwill has joined #openstack-horizon | 09:21 | |
| *** adiantum has quit IRC | 09:29 | |
| openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Fix actions inside instance details view page https://review.openstack.org/289932 | 09:29 |
| *** Daisy has joined #openstack-horizon | 09:32 | |
| *** eugeniato has joined #openstack-horizon | 09:35 | |
| *** Daisy has quit IRC | 09:37 | |
| *** permalac has joined #openstack-horizon | 09:37 | |
| *** permalac has quit IRC | 09:37 | |
| *** xinwu has quit IRC | 09:37 | |
| *** permalac_ has joined #openstack-horizon | 09:38 | |
| *** yamamoto has quit IRC | 09:40 | |
| *** lhcheng has joined #openstack-horizon | 09:41 | |
| *** vgridnev has joined #openstack-horizon | 09:42 | |
| *** zzxwill has quit IRC | 09:58 | |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test for check instance creation when several networks are present https://review.openstack.org/276075 | 09:59 |
| *** zzxwill has joined #openstack-horizon | 10:01 | |
| pkarikh | mrunge: hi! Could be please tell me a little bit more about this commit https://github.com/openstack/requirements/commit/fe240e23f09d84d8843bd0bebea6eea273e3ce3a and what's the issue with XStatic-Angular-Cookies and angular.js>1.3? | 10:05 |
| *** k-ishii has quit IRC | 10:06 | |
| pkarikh | Is there some dependency issues? | 10:06 |
| *** adiantum has joined #openstack-horizon | 10:06 | |
| mrunge | pkarikh, sorry, I don't really remember that | 10:15 |
| mrunge | pkarikh, ah, now I know | 10:16 |
| mrunge | XStatic-Angular >= 1.3.0 includes Angular >= 1.3 includes angular-cookies | 10:16 |
| mrunge | if you include both, you'll end up with both | 10:16 |
| mrunge | all that stuff is a bit tricky with dependencies pkarikh | 10:17 |
| pkarikh | mrunge: so angular >=1.3 already has angular-cookies and I have to remove them manually? | 10:19 |
| pkarikh | or I I got it wrong? | 10:19 |
| mrunge | pkarikh, nope | 10:19 |
| mrunge | if you include angular-cookies, you have to have angular < 1.3 | 10:19 |
| mrunge | pkarikh, iirc, there were some more changes | 10:19 |
| mrunge | i.e. we basically froze dependencies for juno | 10:20 |
| mrunge | upgrading angular etc. required more patches iirc | 10:20 |
| pkarikh | mrunge: hm, got it. Thanks! :) | 10:21 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Move out integration tests scaffolds from Horizon production code https://review.openstack.org/287793 | 10:22 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: [WIP] More documentation on writing i9n tests https://review.openstack.org/272121 | 10:24 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Move out integration tests scaffolds from Horizon production code https://review.openstack.org/287793 | 10:25 |
| *** mvk has joined #openstack-horizon | 10:27 | |
| *** kzaitsev_mb has joined #openstack-horizon | 10:28 | |
| *** permalac_ has quit IRC | 10:29 | |
| *** tosky has joined #openstack-horizon | 10:29 | |
| *** k-ishii has joined #openstack-horizon | 10:32 | |
| *** wolverineav has joined #openstack-horizon | 10:33 | |
| *** zzxwill has quit IRC | 10:35 | |
| *** wolverineav has quit IRC | 10:38 | |
| *** zzxwill has joined #openstack-horizon | 10:38 | |
| *** zzxwill has quit IRC | 10:40 | |
| openstackgerrit | Andreas Jaeger proposed openstack/horizon: Sync paths in POT files with CI scripts https://review.openstack.org/284066 | 10:41 |
| openstackgerrit | Yury Tregubov proposed openstack/horizon: Added update image metadata test https://review.openstack.org/271249 | 10:41 |
| *** lhcheng has quit IRC | 10:45 | |
| *** zzxwill has joined #openstack-horizon | 10:50 | |
| -openstackstatus- NOTICE: Gerrit is going to be restarted due to bad performance | 10:52 | |
| *** ChanServ changes topic to "Gerrit is going to be restarted due to bad performance" | 10:52 | |
| *** zzxwill has quit IRC | 10:54 | |
| *** ChanServ changes topic to "OpenStack Horizon -- M-3 in the taillights" | 10:58 | |
| -openstackstatus- NOTICE: Gerrit has been restarted successfully | 10:58 | |
| *** kzaitsev_mb has quit IRC | 11:02 | |
| *** yamamoto has joined #openstack-horizon | 11:02 | |
| *** mvk has quit IRC | 11:02 | |
| *** yamamoto_ has joined #openstack-horizon | 11:06 | |
| *** yamamoto has quit IRC | 11:09 | |
| *** jprovazn has quit IRC | 11:10 | |
| *** kzaitsev_mb has joined #openstack-horizon | 11:15 | |
| *** vgridnev has quit IRC | 11:16 | |
| *** Daisy has joined #openstack-horizon | 11:20 | |
| *** ccard_ has quit IRC | 11:20 | |
| *** e0ne has quit IRC | 11:23 | |
| *** Daisy has quit IRC | 11:24 | |
| *** yamamoto_ has quit IRC | 11:25 | |
| *** yamamoto has joined #openstack-horizon | 11:26 | |
| *** tosky has quit IRC | 11:26 | |
| *** e0ne has joined #openstack-horizon | 11:26 | |
| *** mvk has joined #openstack-horizon | 11:28 | |
| *** kzaitsev_mb has quit IRC | 11:30 | |
| *** eugeniato has left #openstack-horizon | 11:30 | |
| *** yamamoto has quit IRC | 11:30 | |
| *** tosky has joined #openstack-horizon | 11:31 | |
| openstackgerrit | Alexandra Allakhverdieva proposed openstack/horizon: Add tests for network topology page https://review.openstack.org/276845 | 11:31 |
| openstackgerrit | Alexandra Allakhverdieva proposed openstack/horizon: Added tests for check basic actions from network topology page https://review.openstack.org/278327 | 11:31 |
| *** tesseract has joined #openstack-horizon | 11:33 | |
| *** jtomasek has quit IRC | 11:34 | |
| *** tesseract has quit IRC | 11:34 | |
| *** Guest16009 has joined #openstack-horizon | 11:34 | |
| *** vgridnev has joined #openstack-horizon | 11:36 | |
| *** Guest16009 has quit IRC | 11:37 | |
| *** jtomasek has joined #openstack-horizon | 11:39 | |
| *** tesseract- has joined #openstack-horizon | 11:40 | |
| *** yamamoto has joined #openstack-horizon | 11:42 | |
| *** yamamoto has quit IRC | 11:43 | |
| *** erlon has joined #openstack-horizon | 11:44 | |
| *** vgridnev has quit IRC | 11:49 | |
| *** masco has quit IRC | 11:50 | |
| *** vgridnev has joined #openstack-horizon | 11:54 | |
| *** kzaitsev_mb has joined #openstack-horizon | 11:59 | |
| robcresswell | tsufiev, mrunge: If possible, I'd quite like reviews on this: https://review.openstack.org/#/c/272205/ Without it, some of the fields just don't appear to function at all. | 12:05 |
| *** mpavlase has quit IRC | 12:10 | |
| *** zhenguo_ has quit IRC | 12:10 | |
| *** jtomasek has quit IRC | 12:25 | |
| *** rodrigods has quit IRC | 12:26 | |
| *** rodrigods has joined #openstack-horizon | 12:26 | |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon: Port list check is missing for LBaaS Add Member https://review.openstack.org/251757 | 12:27 |
| *** jtomasek has joined #openstack-horizon | 12:27 | |
| *** mpavlase has joined #openstack-horizon | 12:28 | |
| *** yamamoto has joined #openstack-horizon | 12:31 | |
| *** zzxwill has joined #openstack-horizon | 12:37 | |
| tsufiev | robcresswell, will look in the next couple of hours | 12:38 |
| robcresswell | tsufiev: Thanks! | 12:38 |
| *** yamamoto has quit IRC | 12:40 | |
| *** jtriley has joined #openstack-horizon | 12:48 | |
| *** jtriley has quit IRC | 12:53 | |
| *** lblanchard has joined #openstack-horizon | 12:53 | |
| *** e0ne has quit IRC | 12:54 | |
| *** yamamoto has joined #openstack-horizon | 12:54 | |
| *** e0ne has joined #openstack-horizon | 12:54 | |
| *** pauloewerton has joined #openstack-horizon | 12:58 | |
| *** itisha has joined #openstack-horizon | 13:01 | |
| *** yamamoto has quit IRC | 13:01 | |
| *** e0ne has quit IRC | 13:03 | |
| *** e0ne has joined #openstack-horizon | 13:04 | |
| *** ducttape_ has joined #openstack-horizon | 13:16 | |
| *** yamamoto has joined #openstack-horizon | 13:26 | |
| *** Daisy has joined #openstack-horizon | 13:34 | |
| *** jpomeroy has joined #openstack-horizon | 13:37 | |
| *** ducttape_ has quit IRC | 13:37 | |
| *** Daisy has quit IRC | 13:40 | |
| *** zzxwill has quit IRC | 13:41 | |
| *** Daisy has joined #openstack-horizon | 13:41 | |
| *** leitan has joined #openstack-horizon | 13:42 | |
| *** zzxwill has joined #openstack-horizon | 13:44 | |
| *** matt-borland has joined #openstack-horizon | 13:45 | |
| *** Daisy has quit IRC | 13:45 | |
| robcresswell | Hm, my internet went a bit crazy and I lost my scrollback | 13:49 |
| *** doug-fish has joined #openstack-horizon | 13:54 | |
| *** lapalm has joined #openstack-horizon | 13:57 | |
| *** sayalilunkad has quit IRC | 13:57 | |
| tsufiev | robcresswell, nothing happened yet | 14:01 |
| robcresswell | :D | 14:01 |
| *** neelashah has joined #openstack-horizon | 14:03 | |
| *** sayalilunkad has joined #openstack-horizon | 14:04 | |
| *** sayalilunkad has quit IRC | 14:08 | |
| *** peristeri has joined #openstack-horizon | 14:11 | |
| openstackgerrit | Richard Hagarty proposed openstack/horizon: Add support for volume consistency group snapshots https://review.openstack.org/268368 | 14:20 |
| *** ericksonsantos has quit IRC | 14:26 | |
| *** pauloewerton has quit IRC | 14:26 | |
| *** pauloewerton has joined #openstack-horizon | 14:27 | |
| *** ericksonsantos has joined #openstack-horizon | 14:27 | |
| *** vgridnev has quit IRC | 14:31 | |
| *** sayalilunkad has joined #openstack-horizon | 14:31 | |
| *** vgridnev has joined #openstack-horizon | 14:37 | |
| *** jtriley has joined #openstack-horizon | 14:41 | |
| *** Drago has joined #openstack-horizon | 14:41 | |
| *** Drago has quit IRC | 14:42 | |
| *** Drago has joined #openstack-horizon | 14:42 | |
| *** BigWillie has joined #openstack-horizon | 14:46 | |
| *** vgridnev has quit IRC | 14:46 | |
| *** vgridnev has joined #openstack-horizon | 14:46 | |
| *** mpavlase has quit IRC | 14:49 | |
| *** zzxwill has quit IRC | 14:55 | |
| *** ducttape_ has joined #openstack-horizon | 14:56 | |
| *** ducttape_ has quit IRC | 14:56 | |
| *** ducttape_ has joined #openstack-horizon | 14:56 | |
| *** zzxwill has joined #openstack-horizon | 14:57 | |
| *** Guest13749 is now known as mfisch | 14:58 | |
| *** mfisch is now known as Guest88074 | 14:59 | |
| *** hurgleburgler has joined #openstack-horizon | 14:59 | |
| *** zzxwill has quit IRC | 14:59 | |
| matt-borland | o/ | 15:00 |
| *** Guest88074 is now known as mfisch | 15:01 | |
| *** Qingqing has joined #openstack-horizon | 15:01 | |
| *** mfisch has quit IRC | 15:01 | |
| *** mfisch has joined #openstack-horizon | 15:01 | |
| *** kmartin has quit IRC | 15:07 | |
| *** sjmc7 has joined #openstack-horizon | 15:07 | |
| *** pushkaru has joined #openstack-horizon | 15:08 | |
| *** ducttape_ has quit IRC | 15:21 | |
| *** kzaitsev_mb has quit IRC | 15:25 | |
| *** kzaitsev_mb has joined #openstack-horizon | 15:30 | |
| *** vijendar has joined #openstack-horizon | 15:31 | |
| *** Drago has left #openstack-horizon | 15:34 | |
| *** ediardo has joined #openstack-horizon | 15:34 | |
| *** vgridnev has quit IRC | 15:36 | |
| openstackgerrit | Alexis Rivera proposed openstack/horizon: changing-fa-icon-to-trash-icon https://review.openstack.org/289592 | 15:36 |
| *** wolverineav has joined #openstack-horizon | 15:38 | |
| *** Mounica has joined #openstack-horizon | 15:38 | |
| *** fedexo has joined #openstack-horizon | 15:40 | |
| *** vijendar1 has joined #openstack-horizon | 15:42 | |
| *** wolverineav has quit IRC | 15:42 | |
| *** vgridnev has joined #openstack-horizon | 15:44 | |
| *** vijendar has quit IRC | 15:45 | |
| *** yamamoto has quit IRC | 15:49 | |
| *** mtanino has joined #openstack-horizon | 15:49 | |
| *** yamamoto has joined #openstack-horizon | 15:49 | |
| *** yamamoto has quit IRC | 15:50 | |
| *** yamamoto has joined #openstack-horizon | 15:51 | |
| *** rdopiera has quit IRC | 15:55 | |
| *** yamamoto has quit IRC | 15:56 | |
| *** ducttape_ has joined #openstack-horizon | 15:56 | |
| *** zzxwill has joined #openstack-horizon | 15:57 | |
| *** matt-borland has quit IRC | 15:58 | |
| *** Mounica has quit IRC | 15:59 | |
| *** sayalilunkad has quit IRC | 15:59 | |
| *** permalac has joined #openstack-horizon | 16:01 | |
| *** sayalilunkad has joined #openstack-horizon | 16:01 | |
| zigo | robcresswell: Sorry to bother again, but is there any progress on Django 1.9? Can I help somehow? | 16:04 |
| *** vgridnev has quit IRC | 16:06 | |
| robcresswell | zigo: Not at the moment, have been busy with RC1 reviews. I'll spend some more time with the patch this afternoon. | 16:08 |
| *** kmartin has joined #openstack-horizon | 16:08 | |
| *** gardlt has joined #openstack-horizon | 16:08 | |
| zigo | robcresswell: Thanks. | 16:08 |
| *** gariveradlt has quit IRC | 16:09 | |
| *** xinwu has joined #openstack-horizon | 16:10 | |
| *** gardlt has quit IRC | 16:10 | |
| *** vgridnev has joined #openstack-horizon | 16:10 | |
| *** gariveradlt has joined #openstack-horizon | 16:10 | |
| *** adiantum has quit IRC | 16:12 | |
| *** Mounica has joined #openstack-horizon | 16:12 | |
| *** gariveradlt has quit IRC | 16:15 | |
| *** gariveradlt has joined #openstack-horizon | 16:17 | |
| *** gariveradlt has quit IRC | 16:17 | |
| *** gariveradlt has joined #openstack-horizon | 16:17 | |
| *** hurgleburgler has quit IRC | 16:24 | |
| *** absubram has joined #openstack-horizon | 16:24 | |
| *** absubram_ has joined #openstack-horizon | 16:26 | |
| *** ducttape_ has quit IRC | 16:27 | |
| *** xinwu has quit IRC | 16:27 | |
| *** absubram has quit IRC | 16:29 | |
| *** absubram_ is now known as absubram | 16:29 | |
| *** belmoreira has quit IRC | 16:30 | |
| *** bpokorny has joined #openstack-horizon | 16:33 | |
| *** ducttape_ has joined #openstack-horizon | 16:34 | |
| *** zzxwill has quit IRC | 16:39 | |
| *** vgridnev has quit IRC | 16:39 | |
| *** zzxwill has joined #openstack-horizon | 16:42 | |
| *** vgridnev has joined #openstack-horizon | 16:43 | |
| *** zul_ has quit IRC | 16:43 | |
| *** zul has joined #openstack-horizon | 16:45 | |
| *** zzxwill has quit IRC | 16:46 | |
| *** vishwanathj_zzz is now known as vishwanathj | 16:48 | |
| *** pcaruana has quit IRC | 16:50 | |
| *** david_cu has joined #openstack-horizon | 16:51 | |
| *** web-doug-fish has joined #openstack-horizon | 16:52 | |
| *** tesseract- has quit IRC | 16:55 | |
| *** absubram has quit IRC | 16:55 | |
| *** sergio_nubeliu has quit IRC | 16:55 | |
| *** absubram has joined #openstack-horizon | 16:55 | |
| *** zzxwill has joined #openstack-horizon | 16:57 | |
| *** aortega has quit IRC | 16:57 | |
| *** web-doug-fish has quit IRC | 16:59 | |
| *** rcernin has quit IRC | 17:01 | |
| *** mvk has quit IRC | 17:01 | |
| *** e0ne has quit IRC | 17:05 | |
| *** BigWillie has quit IRC | 17:05 | |
| *** bpokorny has quit IRC | 17:06 | |
| *** absubram has quit IRC | 17:08 | |
| *** dan_nguyen has joined #openstack-horizon | 17:08 | |
| *** sergio_nubeliu has joined #openstack-horizon | 17:10 | |
| ducttape_ | david-lyle: is glance v1 going away / gone ? | 17:10 |
| ducttape_ | for api compat / support | 17:10 |
| ducttape_ | I can find a deleted image using the v1 api, v2 api gives me a 404 :\ | 17:10 |
| *** roxanagh_ has joined #openstack-horizon | 17:10 | |
| *** gyee has joined #openstack-horizon | 17:11 | |
| * ducttape_ heads into the glance room | 17:11 | |
| openstackgerrit | David Cusatis proposed openstack/horizon: Add event broadcast to table row expansion https://review.openstack.org/287473 | 17:12 |
| openstackgerrit | Richard Hagarty proposed openstack/horizon: Add support for volume consistency group snapshots https://review.openstack.org/268368 | 17:13 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Images Actions Return Promises https://review.openstack.org/290800 | 17:16 |
| robcresswell | :o nearly got 1.9 done | 17:17 |
| openstackgerrit | David Cusatis proposed openstack/horizon: Add event broadcast to table row expansion https://review.openstack.org/287473 | 17:19 |
| *** Qingqing has quit IRC | 17:20 | |
| *** ccard__ has quit IRC | 17:22 | |
| *** zzxwill has quit IRC | 17:23 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Images Actions Return Promises https://review.openstack.org/290800 | 17:24 |
| *** ygbo has quit IRC | 17:24 | |
| *** vgridnev has quit IRC | 17:25 | |
| openstackgerrit | Richard Hagarty proposed openstack/horizon: Add support for volume consistency group snapshots https://review.openstack.org/268368 | 17:26 |
| *** vgridnev has joined #openstack-horizon | 17:27 | |
| *** lhcheng has joined #openstack-horizon | 17:28 | |
| *** wolverineav has joined #openstack-horizon | 17:29 | |
| *** zzxwill has joined #openstack-horizon | 17:31 | |
| *** xinwu has joined #openstack-horizon | 17:33 | |
| *** krotscheck has quit IRC | 17:34 | |
| *** pcaruana has joined #openstack-horizon | 17:35 | |
| *** xinwu has quit IRC | 17:36 | |
| *** krotscheck has joined #openstack-horizon | 17:37 | |
| *** ericksonsantos has quit IRC | 17:37 | |
| *** vgridnev has quit IRC | 17:38 | |
| *** lhcheng has quit IRC | 17:40 | |
| *** pauloewerton has quit IRC | 17:40 | |
| *** pauloewerton has joined #openstack-horizon | 17:40 | |
| *** bpokorny has joined #openstack-horizon | 17:41 | |
| *** vgridnev has joined #openstack-horizon | 17:42 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: WIP Searchlight Search Panel https://review.openstack.org/227036 | 17:42 |
| *** zzxwill has quit IRC | 17:45 | |
| *** ediardo has quit IRC | 17:46 | |
| *** kzaitsev_mb has quit IRC | 17:48 | |
| *** bpokorny has quit IRC | 17:49 | |
| *** bpokorny has joined #openstack-horizon | 17:50 | |
| *** matt-borland has joined #openstack-horizon | 17:52 | |
| robcresswell | ExpectedMethodCallsError: Verify: Expected methods never called: | 17:53 |
| robcresswell | 0. <MultipleTimesGroup "default"> | 17:53 |
| robcresswell | What an infuriating return. | 17:54 |
| *** tosky_ has joined #openstack-horizon | 17:54 | |
| *** tosky has quit IRC | 17:55 | |
| david-lyle | robcresswell: what? | 17:55 |
| david-lyle | debugging tests I see | 17:55 |
| david-lyle | but what test and why | 17:56 |
| david-lyle | don't they all just work? | 17:56 |
| *** e0ne has joined #openstack-horizon | 17:56 | |
| *** vgridnev has quit IRC | 17:56 | |
| robcresswell | david-lyle: Just trying to figure out the last dj19 tests. I resolved a couple more issues in it this afternoon | 17:56 |
| tsufiev | david-lyle, was it haiku? | 17:56 |
| robcresswell | Its odd, but some tests pass under dj18, even though the code is definitely broken | 17:56 |
| robcresswell | as soon as your swap to 19, they fail. | 17:57 |
| robcresswell | The only broken part now is the volume pagination tests. everything else passes. | 17:58 |
| david-lyle | does MultipleTimes allow 0 in 1.8? | 17:58 |
| tsufiev | Judging by name Multiple is at least 1 :/ | 17:58 |
| *** zzxwill has joined #openstack-horizon | 17:58 | |
| *** wolverineav has quit IRC | 17:59 | |
| david-lyle | can't assume anything | 17:59 |
| *** absubram has joined #openstack-horizon | 18:00 | |
| robcresswell | Example of oddities: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/ngusers/panel.py#L29 | 18:01 |
| robcresswell | That line causes the dj19 tests to completely fall over | 18:01 |
| tsufiev | robcresswell, is it the famous "'ngusers' namespace not defined"? | 18:01 |
| *** david_cu has quit IRC | 18:01 | |
| *** vgridnev has joined #openstack-horizon | 18:01 | |
| robcresswell | yup | 18:01 |
| *** xinwu has joined #openstack-horizon | 18:02 | |
| *** tosky_ has quit IRC | 18:02 | |
| tsufiev | robcresswell, any chance https://review.openstack.org/#/c/275817/ is the cure here? | 18:02 |
| robcresswell | I was looking at that earlier. I don't quite understand why that decorator is useful. We'd need to add it to every single test no? | 18:03 |
| tsufiev | use case looks very similar | 18:03 |
| tsufiev | hm... | 18:03 |
| tsufiev | I'm afraid we do | 18:04 |
| robcresswell | Seems like a verbose solution. If you're going to add a decorator to each test manually anyway | 18:04 |
| *** zzxwill has quit IRC | 18:04 | |
| robcresswell | you may as well just delete the test or skip it with the available solutions now | 18:04 |
| tsufiev | if we used a custom metaclass for our unit TestCases, it could help... | 18:05 |
| tsufiev | on the other hand, it would become too implicit | 18:05 |
| robcresswell | I think there are better ways to solve the inclusion of the test files or not | 18:06 |
| robcresswell | but I haven't looked into it a great deal | 18:06 |
| robcresswell | Not a priority at this moment :) | 18:06 |
| *** vgridnev has quit IRC | 18:08 | |
| *** vgridnev has joined #openstack-horizon | 18:15 | |
| *** fedexo has quit IRC | 18:16 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Fix remaining Django 1.9 test failures https://review.openstack.org/280222 | 18:16 |
| robcresswell | ^^ Not quite done, I just want to check the gate has the same errors as I do locally. Looking for strange behaviour. | 18:17 |
| *** zzxwill has joined #openstack-horizon | 18:17 | |
| *** wolverineav has joined #openstack-horizon | 18:20 | |
| *** lhcheng has joined #openstack-horizon | 18:22 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Add ngSwift container actions https://review.openstack.org/259236 | 18:23 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: WIP: Example using action promises https://review.openstack.org/291846 | 18:25 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: WIP: Example using action promises https://review.openstack.org/291846 | 18:26 |
| *** vgridnev has quit IRC | 18:30 | |
| *** zzxwill_ has joined #openstack-horizon | 18:31 | |
| *** zzxwill has quit IRC | 18:31 | |
| robcresswell | TravT: Could you check out https://review.openstack.org/#/c/259236 ? Container actions | 18:32 |
| robcresswell | You too matt-borland :) | 18:32 |
| robcresswell | Could do with some expert angular investigating | 18:33 |
| TravT | yes | 18:33 |
| TravT | been waiting for you to finish flesh out bugs | 18:33 |
| robcresswell | haha. Yeah I've been over it a few times, and aside from styling nits I'm okay with it. | 18:33 |
| robcresswell | I'll go through the code too, but I'm not as keen a reviewer on that code as you guys are. | 18:34 |
| *** permalac has quit IRC | 18:35 | |
| TravT | i always term it "harassing" the code submitter, but i mean it in a joking way. :) | 18:35 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: WIP Searchlight Search Panel https://review.openstack.org/227036 | 18:37 |
| *** sergio_nubeliu has quit IRC | 18:37 | |
| *** zzxwill_ has quit IRC | 18:38 | |
| *** sergio_nubeliu has joined #openstack-horizon | 18:42 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: More documentation on writing i9n tests https://review.openstack.org/272121 | 18:43 |
| *** vijendar1 has quit IRC | 18:43 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Move out integration tests scaffolds from Horizon production code https://review.openstack.org/287793 | 18:45 |
| tsufiev | Yay, the second part of docs on i9n tests is complete ^^ | 18:46 |
| tsufiev | I'm going to add a few more pieces in a follow-up commits, but I think the main body is complete | 18:47 |
| *** ducttape_ has quit IRC | 18:48 | |
| *** ducttape_ has joined #openstack-horizon | 18:53 | |
| *** sjmc7 has quit IRC | 18:57 | |
| *** hurgleburgler has joined #openstack-horizon | 18:58 | |
| openstackgerrit | Ryan Peters proposed openstack/horizon: Horizon Radio Buttons are now themeable. https://review.openstack.org/278041 | 18:58 |
| *** david_cu has joined #openstack-horizon | 19:02 | |
| matt-borland | robcresswell, sorry, back from lunch | 19:03 |
| *** slogan has joined #openstack-horizon | 19:04 | |
| *** slogan has left #openstack-horizon | 19:05 | |
| *** doug-fis_ has joined #openstack-horizon | 19:05 | |
| *** tqtran-afk has joined #openstack-horizon | 19:06 | |
| *** david_cu has quit IRC | 19:06 | |
| *** doug-fish has quit IRC | 19:08 | |
| robcresswell | matt-borland: np just pestering you for reviews | 19:10 |
| matt-borland | that's not a problem! | 19:10 |
| *** tqtran-afk is now known as tqtran | 19:11 | |
| *** sjmc7 has joined #openstack-horizon | 19:13 | |
| *** e0ne_ has joined #openstack-horizon | 19:13 | |
| *** e0ne has quit IRC | 19:14 | |
| openstackgerrit | Merged openstack/horizon: Material theme form errors - fix red text on red bg https://review.openstack.org/291486 | 19:20 |
| *** vijendar has joined #openstack-horizon | 19:22 | |
| *** david_cu has joined #openstack-horizon | 19:26 | |
| *** jlk has left #openstack-horizon | 19:34 | |
| openstackgerrit | Justin Pomeroy proposed openstack/horizon: Add validateUnique form input validator https://review.openstack.org/291880 | 19:38 |
| *** e0ne_ has quit IRC | 19:40 | |
| *** ducttape_ has quit IRC | 19:41 | |
| *** xinwu has quit IRC | 19:47 | |
| *** eugeniato has joined #openstack-horizon | 19:49 | |
| *** eugeniato has left #openstack-horizon | 19:50 | |
| *** xinwu has joined #openstack-horizon | 19:54 | |
| *** xinwu has quit IRC | 19:55 | |
| *** lhcheng_ has joined #openstack-horizon | 19:57 | |
| *** lhcheng has quit IRC | 20:00 | |
| *** mpavlase has joined #openstack-horizon | 20:02 | |
| *** xinwu has joined #openstack-horizon | 20:07 | |
| *** xinwu has quit IRC | 20:08 | |
| *** xinwu has joined #openstack-horizon | 20:10 | |
| *** pece has quit IRC | 20:16 | |
| *** xinwu has quit IRC | 20:16 | |
| *** ducttape_ has joined #openstack-horizon | 20:17 | |
| *** x00350071 has quit IRC | 20:19 | |
| *** x00350071 has joined #openstack-horizon | 20:20 | |
| *** wolverineav has quit IRC | 20:21 | |
| *** vijendar has quit IRC | 20:24 | |
| *** vijendar1 has joined #openstack-horizon | 20:24 | |
| *** zul has quit IRC | 20:25 | |
| *** wolverineav has joined #openstack-horizon | 20:28 | |
| openstackgerrit | Merged openstack/horizon: changing-fa-icon-to-trash-icon https://review.openstack.org/289592 | 20:28 |
| *** wolverineav has quit IRC | 20:31 | |
| *** wolverineav has joined #openstack-horizon | 20:33 | |
| *** wolverineav has quit IRC | 20:35 | |
| *** wolverineav has joined #openstack-horizon | 20:38 | |
| *** lhcheng_ has quit IRC | 20:40 | |
| *** xinwu has joined #openstack-horizon | 20:41 | |
| *** wolverineav has quit IRC | 20:43 | |
| *** wolverineav has joined #openstack-horizon | 20:43 | |
| *** lhcheng has joined #openstack-horizon | 20:47 | |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 20:48 | |
| r1chardj0n3s | morning | 20:48 |
| *** Mounica has quit IRC | 20:57 | |
| *** ducttape_ has quit IRC | 20:57 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Allow Launch Instance (Angular) from Volume Snapshots https://review.openstack.org/289379 | 20:57 |
| *** itisha has quit IRC | 20:59 | |
| matt-borland | morning r1chardj0n3s | 20:59 |
| matt-borland | I guess it's a beautiful sunny afternoon actually | 20:59 |
| r1chardj0n3s | it's a beautiful sunny morning :-) | 21:00 |
| *** gariveradlt has quit IRC | 21:01 | |
| mrunge | hey, may I ask folks to chime in here: https://review.openstack.org/#/c/291588/ | 21:01 |
| mrunge | (horizon follows stable policy) | 21:01 |
| r1chardj0n3s | mrunge: do you have a reference to what that means? | 21:02 |
| mrunge | r1chardj0n3s, there has been a mail to -dev mailing list | 21:03 |
| mrunge | let me find it | 21:03 |
| r1chardj0n3s | matt-borland: I'm addressing your feedback on https://review.openstack.org/#/c/259236 - you mention in passing in your comment that you're going to do another review pass? | 21:04 |
| doug-fis_ | I was going to share http://docs.openstack.org/project-team-guide/stable-branches.html but maybe that's not a direct answer ... | 21:04 |
| matt-borland | r1chardj0n3s, yeah, I need to get Swift stood up :( So it will not be this week. | 21:04 |
| matt-borland | I will note that in the comments. | 21:04 |
| mrunge | r1chardj0n3s, http://lists.openstack.org/pipermail/openstack-dev/2016-March/088592.html | 21:05 |
| r1chardj0n3s | matt-borland: the set-up-devstack horizon instructions create one. easy peasy. | 21:05 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: WIP: Example using action promises https://review.openstack.org/291846 | 21:05 |
| matt-borland | oh, ok r1chardj0n3s...I'll take a look | 21:05 |
| mrunge | doug-fis_, you were right with your link :) | 21:05 |
| doug-fis_ | if you try to google "Stable policy" you get the wrong info | 21:06 |
| *** Mounica has joined #openstack-horizon | 21:06 | |
| *** Mounica has quit IRC | 21:07 | |
| r1chardj0n3s | matt-borland: doc/source/ref/local_conf.rst | 21:08 |
| matt-borland | thx r1chardj0n3s | 21:08 |
| r1chardj0n3s | I note that the stable policy mentions oslo-incubator which doesn't exist any longer, right? | 21:09 |
| r1chardj0n3s | mrunge: istm that if we're to say we're following that policy then we should have some horizon-local docs that say what the impact is on developers | 21:10 |
| r1chardj0n3s | otherwise horizon developers will just continue on as they are now, potentially violating that policy (and potentially being completely unaware that the policy is in effect) | 21:11 |
| r1chardj0n3s | I, for one, probably wouldn't even know that we're proposing to set that policy flag if I hadn't popped into IRC this (Saturday) morning | 21:11 |
| mrunge | r1chardj0n3s, today, most devs don't care about stable branches at all | 21:13 |
| doug-fis_ | r1chardj0n3s: have we been violating the policy? I thought we followed it all along | 21:13 |
| r1chardj0n3s | matt-borland: please note that time left to review the last two patches in that feature is *extremely tight* | 21:13 |
| matt-borland | sure thing, restacking | 21:13 |
| mrunge | r1chardj0n3s, they don't need to, we already acted according to stable policy | 21:13 |
| r1chardj0n3s | doug-fis_: I wouldn't know if we've been violating the policy because I only just learned what the policy is | 21:13 |
| r1chardj0n3s | :-) | 21:13 |
| doug-fis_ | I've had my eye on you. | 21:13 |
| r1chardj0n3s | eep | 21:14 |
| *** ducttape_ has joined #openstack-horizon | 21:14 | |
| mrunge | r1chardj0n3s, there are two classes of "core" | 21:14 |
| mrunge | core and stable-core | 21:14 |
| doug-fis_ | lol | 21:14 |
| r1chardj0n3s | mrunge: ah, yep | 21:14 |
| r1chardj0n3s | sorry, it's early Saturday morning and I really should be in bed but I had a notion that matt-borland had left me a patch review that I had to get up to address so my brain isn't working fully. I apologise for asking dumb questions. | 21:15 |
| *** kzaitsev_mb has joined #openstack-horizon | 21:15 | |
| mrunge | r1chardj0n3s, cheapest way to put it: no feature backports, no string changes in backports and make sure, a bug is fixed in the following branch as well | 21:15 |
| matt-borland | lol r1chardj0n3s | 21:15 |
| r1chardj0n3s | mrunge: thanks! | 21:15 |
| mrunge | you're welcome! | 21:15 |
| mrunge | r1chardj0n3s, it's 8:15 in the morning for you, time to get up anyways :P | 21:16 |
| r1chardj0n3s | wow, you're a hard man :-) | 21:16 |
| * mrunge hides | 21:16 | |
| mrunge | my son currently gets up around 4 | 21:16 |
| mrunge | am | 21:17 |
| doug-fis_ | ugh, that needs to be corrected! | 21:17 |
| mrunge | I'm just envious. I can't remember when I slept till 8 | 21:17 |
| r1chardj0n3s | hah, I remember those days | 21:17 |
| *** matt-borland_ has joined #openstack-horizon | 21:19 | |
| doug-fis_ | I remember when my son was quite little putting a digital clock in his room and telling him he couldn't come out until the first number was a "7". He could just look at books or play quietly before that. | 21:20 |
| *** matt-borland has quit IRC | 21:22 | |
| mrunge | hmm, I should try that... | 21:22 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add ngSwift object actions https://review.openstack.org/270553 | 21:23 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add ngSwift container actions https://review.openstack.org/259236 | 21:23 |
| *** roxanagh_ has quit IRC | 21:23 | |
| doug-fis_ | it worked for us. My son still likes to wake up at 7. That's not normal teenage behavior. | 21:23 |
| r1chardj0n3s | doug-fis_: we did a similar thing; when we woke up we'd find Abbey in her bed with books *covering* it... and the floor :-) | 21:23 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: Volumes https://review.openstack.org/263817 | 21:24 |
| *** roxanagh_ has joined #openstack-horizon | 21:24 | |
| doug-fis_ | r1chardj0n3s: fun! I always assumed there wouldn't be too much trouble if he stayed in his room | 21:24 |
| mrunge | I had hopes for teen age. Now let's see what happens | 21:24 |
| openstackgerrit | Ryan Peters proposed openstack/horizon: Horizon Radio Buttons are now themeable. https://review.openstack.org/278041 | 21:25 |
| r1chardj0n3s | I'm about to have a teenager - these days she just quietly gets up, comes downstairs and watches youtube or plays games until I wake up :-) | 21:25 |
| doug-fis_ | yeah, that's much easier to deal with | 21:26 |
| r1chardj0n3s | I figure when the teenager switch triggers there'll be more sleeping in | 21:26 |
| *** pauloewerton has quit IRC | 21:30 | |
| tqtran | wow talking about kids already | 21:33 |
| doug-fis_ | already? | 21:34 |
| tqtran | i mean... this early | 21:34 |
| doug-fis_ | isn't it 1:30 in the afternoon for you? | 21:34 |
| tqtran | ?_? maybe | 21:34 |
| doug-fis_ | lol | 21:34 |
| doug-fis_ | wait until you have kids! then you'll know what "early" means! | 21:34 |
| tqtran | hahaha | 21:34 |
| r1chardj0n3s | :-) | 21:35 |
| *** sergio_nubeliu has quit IRC | 21:36 | |
| *** leitan has quit IRC | 21:37 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 21:42 | |
| *** Mounica has joined #openstack-horizon | 21:52 | |
| *** jtriley has quit IRC | 21:55 | |
| *** david_cu has quit IRC | 21:57 | |
| *** e0ne has joined #openstack-horizon | 21:59 | |
| *** e0ne has quit IRC | 22:04 | |
| *** matt-borland_ has quit IRC | 22:09 | |
| *** lblanchard has quit IRC | 22:12 | |
| *** lapalm has quit IRC | 22:16 | |
| openstackgerrit | Merged openstack/horizon: Retrieve domain scoped token https://review.openstack.org/148082 | 22:20 |
| *** lhcheng has quit IRC | 22:23 | |
| *** xinwu has quit IRC | 22:31 | |
| david-lyle | dan_nguyen, bpokorny: \o/ | 22:32 |
| david-lyle | thanks doug-fis_ | 22:32 |
| dan_nguyen | thx david-lyle, doug-fis_, and bpokorny | 22:33 |
| tqtran | omg, it merged?! the world is coming to an end | 22:33 |
| tqtran | haha, congrats guys! | 22:33 |
| dan_nguyen | tqtran: don’t jinx it! | 22:34 |
| tqtran | :P | 22:34 |
| tqtran | its been a long time coming | 22:34 |
| david-lyle | only 3 years :P | 22:34 |
| dan_nguyen | yell at me and bpokorny if you find bugs | 22:34 |
| tqtran | only... you guys are troopers! | 22:34 |
| dan_nguyen | well don’t yell at brad but tell him about ‘em | 22:34 |
| dan_nguyen | you can yell at me | 22:35 |
| dan_nguyen | yeah, most of that work was laid out by dave and lin | 22:35 |
| openstackgerrit | Richard Hagarty proposed openstack/horizon: Add support for volume consistency group snapshots https://review.openstack.org/268368 | 22:35 |
| tqtran | lol dan_nguyen, no one wants to yell at you, you're too nice | 22:35 |
| bpokorny | And with that, I am officially retiring! (jk) | 22:35 |
| dan_nguyen | haha | 22:36 |
| tqtran | see you in 3 years bpokorny | 22:36 |
| bpokorny | lol. Traumatic experience recover time. | 22:36 |
| tqtran | hahaha | 22:36 |
| *** david-lyle has quit IRC | 22:37 | |
| *** jtomasek has quit IRC | 22:38 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: Volumes https://review.openstack.org/263817 | 22:38 |
| *** vijendar1 has quit IRC | 22:41 | |
| openstackgerrit | Richard Hagarty proposed openstack/horizon: Add support for volume consistency group snapshots https://review.openstack.org/268368 | 22:45 |
| *** rcernin has joined #openstack-horizon | 22:47 | |
| *** lhcheng has joined #openstack-horizon | 22:49 | |
| *** ducttape_ has quit IRC | 22:53 | |
| openstackgerrit | Merged openstack/horizon: Sync paths in POT files with CI scripts https://review.openstack.org/284066 | 22:57 |
| *** bpokorny_ has joined #openstack-horizon | 23:02 | |
| *** bpokorny_ has quit IRC | 23:04 | |
| *** amotoki has quit IRC | 23:04 | |
| *** bpokorny_ has joined #openstack-horizon | 23:04 | |
| *** bpokorny has quit IRC | 23:05 | |
| *** rcernin has quit IRC | 23:06 | |
| *** rcernin has joined #openstack-horizon | 23:08 | |
| *** gyee has quit IRC | 23:21 | |
| *** neelashah has quit IRC | 23:21 | |
| *** neelashah has joined #openstack-horizon | 23:22 | |
| *** neelashah has quit IRC | 23:24 | |
| *** vijendar has joined #openstack-horizon | 23:27 | |
| *** wolverineav has quit IRC | 23:28 | |
| *** wolverineav has joined #openstack-horizon | 23:28 | |
| *** peristeri has quit IRC | 23:29 | |
| *** rcernin has quit IRC | 23:31 | |
| *** pushkaru has quit IRC | 23:37 | |
| *** wolverineav has quit IRC | 23:38 | |
| *** dlevy has quit IRC | 23:41 | |
| *** david_cu_ has quit IRC | 23:41 | |
| *** wolverineav has joined #openstack-horizon | 23:46 | |
| *** erlon has quit IRC | 23:48 | |
| *** vijendar has quit IRC | 23:48 | |
| *** sjmc7 has quit IRC | 23:53 | |
| *** roxanagh_ has quit IRC | 23:54 | |
| *** roxanagh_ has joined #openstack-horizon | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!