| *** vinsh_ has joined #openstack-horizon | 00:00 | |
| *** SimonChung has joined #openstack-horizon | 00:00 | |
| _ducttape_ | yep, even if it was on the details page, that would help us amotoki | 00:00 |
|---|---|---|
| vinsh_ | 0_o | 00:00 |
| *** vinsh_ is now known as Vinsh | 00:00 | |
| _ducttape_ | TravT meet Vinsh | 00:00 |
| Vinsh | Pizza? | 00:00 |
| TravT | i know that guy | 00:00 |
| _ducttape_ | questions on swift stuff, might want to take it 1:1 | 00:00 |
| TravT | ;) | 00:01 |
| *** roxanaghe has quit IRC | 00:01 | |
| amotoki | _ducttape_: that's another option. in addition, it would be great if L3-HA is supported. | 00:01 |
| amotoki | _ducttape_: anyway you can move it forward. I can support you :) | 00:02 |
| _ducttape_ | yes, agree | 00:02 |
| *** k-ishii has joined #openstack-horizon | 00:02 | |
| * med_ loves the thread of conversation herein | 00:02 | |
| med_ | and Vinsh too. | 00:02 |
| _ducttape_ | ok. thanks, I'm not sure when / if I will have the time.... but I wanted to get your opinion first. thank you amotoki | 00:02 |
| openstackgerrit | Brad Pokorny proposed openstack/django_openstack_auth: Fix token hashing with python 3 https://review.openstack.org/287519 | 00:05 |
| *** ybathia has quit IRC | 00:05 | |
| *** donu7 has quit IRC | 00:05 | |
| r1chardj0n3s | TravT: we have some info on large swift captured before ui rewrite started | 00:06 |
| r1chardj0n3s | TravT: https://etherpad.openstack.org/p/mitaka-openstackux-swift | 00:06 |
| sjmc7 | the numbers the swift team gave us this morning were terrifying | 00:07 |
| r1chardj0n3s | yep, and it still boggles my brain meat that there's no built-in solution for search in swift | 00:07 |
| sjmc7 | that was the conversation we had with them :) | 00:08 |
| r1chardj0n3s | :-) | 00:08 |
| TravT | r1chardj0n3s: we called into the swift hackathon where they had a session dedicated to how to index their data | 00:08 |
| r1chardj0n3s | yup | 00:08 |
| TravT | they very clearly said they all see the need, but have no intent of providing search natively | 00:08 |
| TravT | but want to support external indexing | 00:08 |
| TravT | and want to avoid rabbit | 00:08 |
| r1chardj0n3s | erm, ok | 00:09 |
| r1chardj0n3s | everyone would *like* to avoid rabbit, but what's their alternative? | 00:09 |
| TravT | so we got the action item of giving them a library to directly push stuff into searchlight / elasticsearch | 00:09 |
| *** _ducttape_ has quit IRC | 00:09 | |
| sjmc7 | cut out the middleman! | 00:09 |
| r1chardj0n3s | TravT: positive step! | 00:09 |
| TravT | and they would look at 1 of a couple places where they'd provide ability to integrate it | 00:09 |
| r1chardj0n3s | I've been researching and basically without searchlight or some facility added into swift, a useful user interface on top of a millions-of-objects deployment is basically impossible | 00:10 |
| r1chardj0n3s | my tame swift core has a simple patch to add basic substring search, which would help immensely | 00:11 |
| r1chardj0n3s | that's substring on name only, of course | 00:11 |
| TravT | well for mitaka, we're going to go ahead a provide a plugin for searchlight | 00:11 |
| *** amotoki has quit IRC | 00:11 | |
| TravT | with a sample middleware | 00:11 |
| TravT | that publishes via rabbit | 00:11 |
| r1chardj0n3s | yup, cool | 00:11 |
| TravT | but is clearly stated as not being officially supported by swift... | 00:12 |
| *** Drago has quit IRC | 00:12 | |
| r1chardj0n3s | whatever | 00:12 |
| med_ | hmm, I thought searchlight was a glance indexer. | 00:12 |
| r1chardj0n3s | swift can go off and be in no-users land | 00:12 |
| *** Drago has joined #openstack-horizon | 00:12 | |
| r1chardj0n3s | that's interesting - I wonder how wide-spread med_'s view is | 00:13 |
| med_ | I'm wide. My view not so much. | 00:13 |
| r1chardj0n3s | I think N will change things | 00:13 |
| r1chardj0n3s | lol | 00:13 |
| TravT | med_ at end of mitaka we'll have plugins for glance, nova servers, designate zones & recordsets, neutron networks and ports, cinder volumes and snapshots, and swift objects. | 00:13 |
| med_ | TravT, are you a Horizon guy or a Searchlight guy (or is there no distinction) (not trolling, just have no idea.) | 00:14 |
| *** reedip_away is now known as reedip | 00:14 | |
| med_ | and I'd be the guy responsible for Searchlight on my team if we see any value there. | 00:14 |
| TravT | i have split personality disorder | 00:14 |
| sjmc7 | hahahah | 00:14 |
| *** ybathia has joined #openstack-horizon | 00:14 | |
| TravT | N is where we want to really push the production worthiness of it | 00:14 |
| r1chardj0n3s | yep | 00:14 |
| med_ | nod | 00:15 |
| med_ | thanks. | 00:15 |
| TravT | med_ however would like to work with you or others to help test it out early so we have time to improve in N | 00:16 |
| med_ | nod. I work with ducttape pretty closely. We bleeding edge on Horizon but haven't started with Searchlight thus far. | 00:17 |
| med_ | I'll be happy to tire kick, etc though. | 00:17 |
| *** gariveradlt has quit IRC | 00:17 | |
| TravT | ok, let's talk after rc 1 / 2 -ish | 00:17 |
| med_ | cool beans, +1 | 00:18 |
| TravT | :) | 00:18 |
| r1chardj0n3s | yes! I want to work on integrating searchlight into the new swift ui, so I'd like to make sure it's actually useful too :-) | 00:18 |
| *** alexvictorchan has joined #openstack-horizon | 00:19 | |
| TravT | r1chardj0n3s: definitely. | 00:19 |
| TravT | in my testing with the general purpose search UI, I can definitely say we'll get further with building some custom queries from your cool UI to support swift better. | 00:20 |
| *** bpokorny has quit IRC | 00:21 | |
| *** ybathia has quit IRC | 00:22 | |
| TravT | med_: FYI, here's a quick swift POC video I recorded a day or two ago to help with the discussion with the swift guys. | 00:23 |
| TravT | https://youtu.be/-Io8uaNLrVc?vq=hd720 | 00:23 |
| *** yamamoto has joined #openstack-horizon | 00:24 | |
| med_ | cool, watching | 00:25 |
| *** sjmc7 has quit IRC | 00:29 | |
| *** yamamoto has quit IRC | 00:31 | |
| *** ppiela has quit IRC | 00:32 | |
| *** bpokorny has joined #openstack-horizon | 00:33 | |
| *** lblanchard has joined #openstack-horizon | 00:34 | |
| *** jtriley has joined #openstack-horizon | 00:35 | |
| *** amotoki has joined #openstack-horizon | 00:40 | |
| *** zzxwill has joined #openstack-horizon | 00:40 | |
| *** shu-mutou-AFK is now known as shu-mutou | 00:42 | |
| *** ZZelle_ has quit IRC | 00:45 | |
| *** zzxwill has quit IRC | 00:50 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Material Design: New LI Tweaks https://review.openstack.org/287531 | 00:53 |
| *** roxanaghe has joined #openstack-horizon | 00:54 | |
| *** SimonChung has quit IRC | 00:54 | |
| *** SimonChung1 has joined #openstack-horizon | 00:54 | |
| *** sjmc7 has joined #openstack-horizon | 00:54 | |
| *** zzxwill has joined #openstack-horizon | 00:55 | |
| *** Drago has quit IRC | 00:56 | |
| *** Mounica has quit IRC | 00:56 | |
| *** amotoki has quit IRC | 00:57 | |
| *** bpokorny_ has joined #openstack-horizon | 00:58 | |
| *** bpokorny has quit IRC | 01:01 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Material Design: New LI Tweaks https://review.openstack.org/287531 | 01:02 |
| *** ducttape_ has joined #openstack-horizon | 01:03 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: WIP Proof of concept for actions returning promises https://review.openstack.org/287457 | 01:05 |
| *** tyr has quit IRC | 01:05 | |
| *** zhurong has joined #openstack-horizon | 01:08 | |
| *** sjmc7 has quit IRC | 01:08 | |
| *** kzaitsev_mb has quit IRC | 01:10 | |
| *** doug-fish has joined #openstack-horizon | 01:12 | |
| *** garthb has quit IRC | 01:15 | |
| *** ducttape_ has quit IRC | 01:18 | |
| *** jtriley has quit IRC | 01:19 | |
| openstackgerrit | David Lyle proposed openstack/horizon: Fixing heatclient release compat issues https://review.openstack.org/287543 | 01:20 |
| david-lyle | take that python-heatclient and your improved error reporting | 01:20 |
| david-lyle | that's a wrap folks | 01:20 |
| david-lyle | goodnight | 01:20 |
| *** amotoki has joined #openstack-horizon | 01:23 | |
| *** jtriley has joined #openstack-horizon | 01:24 | |
| r1chardj0n3s | doug-fish, TravT, lhcheng, if you're around please look at https://review.openstack.org/287543 | 01:25 |
| lhcheng | r1chardj0n3s: sure | 01:25 |
| r1chardj0n3s | thanks | 01:25 |
| r1chardj0n3s | confirmed it works locally for me, but obvs we need to see what jenkins things | 01:26 |
| lhcheng | I would have just deleted the tests.. but this works too | 01:26 |
| r1chardj0n3s | thinks | 01:26 |
| lhcheng | lol | 01:26 |
| r1chardj0n3s | lol | 01:26 |
| * r1chardj0n3s would have reverted global-requirements | 01:26 | |
| lhcheng | haha | 01:27 |
| r1chardj0n3s | I totally have the numbers to push that through too :-) | 01:27 |
| r1chardj0n3s | anyhoo, hopefully all will be better now. with a buncha rebasing | 01:28 |
| *** jtriley has quit IRC | 01:30 | |
| *** jtriley has joined #openstack-horizon | 01:32 | |
| *** SimonChung1 has quit IRC | 01:32 | |
| *** dank_ has quit IRC | 01:32 | |
| lhcheng | ah rebasing.. such a bad timing.. specially on the last day of the milestones :( | 01:33 |
| r1chardj0n3s | yeah i expect I'll be doing a bunch of rebasing for folks once this fix is merged | 01:34 |
| r1chardj0n3s | ok, I lunch now | 01:35 |
| *** lhcheng has quit IRC | 01:37 | |
| hurgleburgler | \o/ | 01:37 |
| *** dank_ has joined #openstack-horizon | 01:40 | |
| *** amit213 has joined #openstack-horizon | 01:41 | |
| *** bpokorny_ has quit IRC | 01:41 | |
| *** bpokorny has joined #openstack-horizon | 01:42 | |
| *** ducttape_ has joined #openstack-horizon | 01:43 | |
| *** openstackgerrit has quit IRC | 01:47 | |
| *** openstackgerrit has joined #openstack-horizon | 01:48 | |
| *** jtriley has quit IRC | 01:51 | |
| *** roxanaghe has quit IRC | 01:55 | |
| *** mtanino has quit IRC | 02:01 | |
| *** lblanchard has quit IRC | 02:08 | |
| *** yamamoto_ has joined #openstack-horizon | 02:09 | |
| *** doug-fis_ has joined #openstack-horizon | 02:16 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon Checkboxes are now themeable. https://review.openstack.org/252161 | 02:17 |
| *** ejat_ has joined #openstack-horizon | 02:18 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Material: Selection Menu headers aren't visible https://review.openstack.org/287516 | 02:18 |
| *** trams_ has joined #openstack-horizon | 02:18 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Branding: Workflow cancel btn should be themable https://review.openstack.org/286313 | 02:19 |
| *** mariusv_ has joined #openstack-horizon | 02:19 | |
| *** liuyulong has joined #openstack-horizon | 02:19 | |
| *** _stowa_ has joined #openstack-horizon | 02:22 | |
| *** ducttape_ has quit IRC | 02:23 | |
| *** jrist_ has joined #openstack-horizon | 02:23 | |
| *** zhurong has quit IRC | 02:23 | |
| *** agireud has quit IRC | 02:23 | |
| *** trams has quit IRC | 02:23 | |
| *** stevemar has quit IRC | 02:23 | |
| *** mariusv has quit IRC | 02:23 | |
| *** _stowa has quit IRC | 02:23 | |
| *** doug-fish has quit IRC | 02:23 | |
| *** jrist has quit IRC | 02:23 | |
| *** ejat has quit IRC | 02:23 | |
| *** lunarlamp is now known as mariusv | 02:23 | |
| *** agireud has joined #openstack-horizon | 02:24 | |
| *** stevemar has joined #openstack-horizon | 02:24 | |
| *** zhurong has joined #openstack-horizon | 02:24 | |
| *** doug-fis_ has quit IRC | 02:24 | |
| *** roxanagh_ has joined #openstack-horizon | 02:24 | |
| *** zzxwill has quit IRC | 02:25 | |
| *** zzxwill has joined #openstack-horizon | 02:26 | |
| *** doug-fish has joined #openstack-horizon | 02:27 | |
| *** deray has joined #openstack-horizon | 02:32 | |
| *** deray has quit IRC | 02:33 | |
| *** yamamoto_ has quit IRC | 02:33 | |
| *** ducttape_ has joined #openstack-horizon | 02:34 | |
| *** deray has joined #openstack-horizon | 02:35 | |
| *** jtriley has joined #openstack-horizon | 02:37 | |
| *** _stowa_ is now known as _stowa | 02:42 | |
| *** SimonChung has joined #openstack-horizon | 02:46 | |
| *** jrist_ is now known as jrist | 02:52 | |
| *** jrist has quit IRC | 02:52 | |
| *** jrist has joined #openstack-horizon | 02:52 | |
| *** k-ishii has quit IRC | 02:53 | |
| *** k-ishii has joined #openstack-horizon | 02:54 | |
| *** SimonChung1 has joined #openstack-horizon | 02:58 | |
| *** jtriley has quit IRC | 02:59 | |
| *** SimonChung has quit IRC | 03:01 | |
| *** jtriley has joined #openstack-horizon | 03:02 | |
| *** zzxwill has quit IRC | 03:08 | |
| *** bpokorny has quit IRC | 03:08 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Fix theming in angular launch instance https://review.openstack.org/285084 | 03:09 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Material Design: New LI Tweaks https://review.openstack.org/287531 | 03:09 |
| *** wangbo has joined #openstack-horizon | 03:10 | |
| *** doug-fish has quit IRC | 03:10 | |
| *** zzxwill has joined #openstack-horizon | 03:13 | |
| ducttape_ | is the yaml heat thing still busted david-lyle ? | 03:13 |
| *** fedexo has joined #openstack-horizon | 03:20 | |
| *** xinwu_ has joined #openstack-horizon | 03:22 | |
| *** kmartin__ has joined #openstack-horizon | 03:23 | |
| *** r1chardj0n3s_afk has joined #openstack-horizon | 03:24 | |
| *** yamamoto_ has joined #openstack-horizon | 03:25 | |
| *** marlinc_ has joined #openstack-horizon | 03:26 | |
| *** ducttape_ has quit IRC | 03:26 | |
| *** NikitaKonovalov2 has joined #openstack-horizon | 03:26 | |
| *** gbraad_ has joined #openstack-horizon | 03:26 | |
| *** xinwu_ has quit IRC | 03:26 | |
| *** mrunge has quit IRC | 03:26 | |
| *** ccard has quit IRC | 03:26 | |
| *** NikitaKonovalov has quit IRC | 03:26 | |
| *** ZZelle has quit IRC | 03:26 | |
| *** kmartin_ has quit IRC | 03:26 | |
| *** gbraad has quit IRC | 03:26 | |
| *** mnaser has quit IRC | 03:26 | |
| *** clayton has quit IRC | 03:26 | |
| *** marlinc has quit IRC | 03:26 | |
| *** xinwu has quit IRC | 03:26 | |
| *** HenryG has quit IRC | 03:26 | |
| *** r1chardj0n3s has quit IRC | 03:26 | |
| *** mrunge_ has joined #openstack-horizon | 03:26 | |
| *** NikitaKonovalov2 is now known as NikitaKonovalov | 03:26 | |
| *** ccard has joined #openstack-horizon | 03:26 | |
| *** HenryG has joined #openstack-horizon | 03:26 | |
| *** mnaser has joined #openstack-horizon | 03:27 | |
| *** ZZelle has joined #openstack-horizon | 03:27 | |
| *** marlinc_ is now known as marlinc | 03:27 | |
| *** clayton has joined #openstack-horizon | 03:28 | |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 03:34 | |
| r1chardj0n3s | the heatclient fubar patch is https://review.openstack.org/#/c/287543/ which is currently in the gate for merging. queue time looks like maybe 6 hours at this point | 03:36 |
| *** kzaitsev_mb has joined #openstack-horizon | 03:37 | |
| *** mrunge_ has quit IRC | 03:39 | |
| openstackgerrit | Wang Bo proposed openstack/horizon: Refactor codes in class TenantFilterAction https://review.openstack.org/265792 | 03:42 |
| *** mrunge has joined #openstack-horizon | 03:45 | |
| *** zzxwill has quit IRC | 03:47 | |
| *** wolverineav has quit IRC | 03:48 | |
| openstackgerrit | Wang Bo proposed openstack/horizon: Remove unnecessary class TenantFilterAction https://review.openstack.org/265792 | 03:57 |
| *** doug-fish has joined #openstack-horizon | 04:00 | |
| *** doug-fish has quit IRC | 04:05 | |
| *** kzaitsev_mb has quit IRC | 04:05 | |
| *** zzxwill has joined #openstack-horizon | 04:09 | |
| *** lhcheng has joined #openstack-horizon | 04:11 | |
| *** vishwanathj_ is now known as vishwanathj_zzz | 04:15 | |
| *** jtriley has quit IRC | 04:15 | |
| openstackgerrit | Wang Bo proposed openstack/horizon: Fix scss file to match related html file. https://review.openstack.org/273370 | 04:17 |
| lhcheng | r1chardj0n3s: jenkins passed! | 04:20 |
| lhcheng | r1chardj0n3s: dj19 still failing though, is our dj19 support still far from being ready? | 04:20 |
| *** wolverineav has joined #openstack-horizon | 04:23 | |
| *** wolverineav has quit IRC | 04:28 | |
| *** Daisy has joined #openstack-horizon | 04:28 | |
| *** wolverineav has joined #openstack-horizon | 04:31 | |
| *** wolverineav has quit IRC | 04:33 | |
| *** Daisy has quit IRC | 04:34 | |
| *** wolverineav has joined #openstack-horizon | 04:34 | |
| *** Daisy has joined #openstack-horizon | 04:34 | |
| r1chardj0n3s | lhcheng: yeah :-( | 04:35 |
| r1chardj0n3s | ooh, it's almost through the gate too | 04:36 |
| lhcheng | bummer on dj19 upgrade :( | 04:36 |
| *** zzxwill has quit IRC | 04:36 | |
| r1chardj0n3s | yeah, not sure what happened there. we seemed to be making good progress | 04:36 |
| *** roxanagh_ has quit IRC | 04:44 | |
| *** masco has joined #openstack-horizon | 04:46 | |
| *** zzxwill has joined #openstack-horizon | 04:52 | |
| *** zzxwill has quit IRC | 04:53 | |
| *** zzxwill has joined #openstack-horizon | 04:55 | |
| *** dan_nguyen has quit IRC | 04:58 | |
| *** kzaitsev_mb has joined #openstack-horizon | 05:02 | |
| *** kzaitsev_mb has quit IRC | 05:07 | |
| *** roxanaghe has joined #openstack-horizon | 05:20 | |
| *** hurgleburgler1 has joined #openstack-horizon | 05:28 | |
| *** hurgleburgler has quit IRC | 05:31 | |
| *** xinwu has joined #openstack-horizon | 05:33 | |
| *** Daisy has quit IRC | 05:44 | |
| *** zzxwill has quit IRC | 05:44 | |
| *** Daisy has joined #openstack-horizon | 05:44 | |
| *** Daisy has quit IRC | 05:46 | |
| *** Daisy has joined #openstack-horizon | 05:47 | |
| *** Daisy has quit IRC | 05:51 | |
| *** Daisy has joined #openstack-horizon | 05:52 | |
| *** hurgleburgler1 has quit IRC | 05:55 | |
| *** Daisy has quit IRC | 05:55 | |
| *** Daisy has joined #openstack-horizon | 05:55 | |
| *** Daisy has quit IRC | 05:56 | |
| *** Daisy has joined #openstack-horizon | 05:56 | |
| *** liuyulong has quit IRC | 06:01 | |
| *** kzaitsev_mb has joined #openstack-horizon | 06:03 | |
| *** kzaitsev_mb has quit IRC | 06:09 | |
| *** jtriley has joined #openstack-horizon | 06:12 | |
| *** nader has joined #openstack-horizon | 06:12 | |
| *** x00350071 has joined #openstack-horizon | 06:14 | |
| *** nader has quit IRC | 06:15 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Zanata https://review.openstack.org/287609 | 06:17 |
| *** jtriley has quit IRC | 06:18 | |
| x00350071 | Hello. when i am using FilterAction in my horizon plugin, i find the FilterAction did not work. | 06:21 |
| x00350071 | This is my codes. http://paste.openstack.org/show/489086/ | 06:22 |
| x00350071 | Could someone help me? | 06:22 |
| *** nlahouti1 has joined #openstack-horizon | 06:25 | |
| wangbo | I think you hit this bug: https://bugs.launchpad.net/horizon/+bug/1533514? | 06:25 |
| openstack | Launchpad bug 1533514 in OpenStack Dashboard (Horizon) "FilterAction does not filter rows as specified fields" [Undecided,New] - Assigned to Wang Bo (chestack) | 06:25 |
| x00350071 | wangbo:oh | 06:27 |
| x00350071 | wangbo. But i find the FilterAction is stiil in working in the Identify and other pages. | 06:28 |
| x00350071 | It just did not work in my developping horizon plugin | 06:28 |
| *** nlahouti1 has quit IRC | 06:32 | |
| *** nlahouti1 has joined #openstack-horizon | 06:32 | |
| *** amit213 has quit IRC | 06:33 | |
| *** jtomasek has joined #openstack-horizon | 06:33 | |
| x00350071 | wangbo: I guess the unicode characters may be the reason of this bug: https://bugs.launchpad.net/horizon/+bug/1533514 | 06:33 |
| openstack | Launchpad bug 1533514 in OpenStack Dashboard (Horizon) "FilterAction does not filter rows as specified fields" [Undecided,New] - Assigned to Wang Bo (chestack) | 06:33 |
| *** x00350071 is now known as xiangxinyong | 06:35 | |
| *** dan_nguyen has joined #openstack-horizon | 06:47 | |
| *** dan_nguyen has quit IRC | 06:48 | |
| *** roxanaghe has quit IRC | 06:53 | |
| *** roxanaghe has joined #openstack-horizon | 06:55 | |
| *** wangbo has quit IRC | 06:58 | |
| *** aortega has quit IRC | 06:59 | |
| *** amit213 has joined #openstack-horizon | 07:04 | |
| *** kzaitsev_mb has joined #openstack-horizon | 07:04 | |
| *** amit213 has quit IRC | 07:06 | |
| *** amit213 has joined #openstack-horizon | 07:08 | |
| *** kzaitsev_mb has quit IRC | 07:09 | |
| *** amit213 has quit IRC | 07:10 | |
| *** Daisy has quit IRC | 07:13 | |
| *** Daisy has joined #openstack-horizon | 07:13 | |
| *** amit213 has joined #openstack-horizon | 07:15 | |
| *** Daisy has quit IRC | 07:18 | |
| *** amit213 has quit IRC | 07:18 | |
| *** wangbo has joined #openstack-horizon | 07:23 | |
| *** zzxwill has joined #openstack-horizon | 07:23 | |
| *** rdopiera has joined #openstack-horizon | 07:23 | |
| *** zhurong has quit IRC | 07:32 | |
| *** zhurong has joined #openstack-horizon | 07:34 | |
| *** fedexo has quit IRC | 07:34 | |
| *** amit213 has joined #openstack-horizon | 07:40 | |
| *** amit213 has quit IRC | 07:42 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Angular Policy Caching https://review.openstack.org/286268 | 07:44 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Angular Policy Caching https://review.openstack.org/286268 | 07:45 |
| *** pcaruana has joined #openstack-horizon | 07:45 | |
| *** roxanaghe has quit IRC | 07:46 | |
| *** mpavlase has joined #openstack-horizon | 07:48 | |
| *** itxaka has joined #openstack-horizon | 07:54 | |
| *** e0ne has joined #openstack-horizon | 07:55 | |
| *** wolverineav has quit IRC | 07:55 | |
| *** e0ne has quit IRC | 07:56 | |
| *** deray_ has joined #openstack-horizon | 07:59 | |
| *** itisha has joined #openstack-horizon | 07:59 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 08:00 | |
| *** JeanBriceCombebi has quit IRC | 08:01 | |
| *** deray_ has quit IRC | 08:02 | |
| *** amotoki has quit IRC | 08:02 | |
| *** deray has quit IRC | 08:02 | |
| *** kzaitsev_mb has joined #openstack-horizon | 08:05 | |
| *** amit213 has joined #openstack-horizon | 08:09 | |
| *** kzaitsev_mb has quit IRC | 08:10 | |
| *** amit213 has quit IRC | 08:13 | |
| *** jtriley has joined #openstack-horizon | 08:14 | |
| *** amit213 has joined #openstack-horizon | 08:16 | |
| xiangxinyong | hello guys, how could i restart horizon completely? | 08:18 |
| *** amit213 has quit IRC | 08:18 | |
| *** jtriley has quit IRC | 08:19 | |
| openstackgerrit | LIU Yulong proposed openstack/horizon: Add floating IP panel to admin dashboard https://review.openstack.org/143628 | 08:20 |
| *** amit213 has joined #openstack-horizon | 08:25 | |
| *** lhcheng has quit IRC | 08:26 | |
| *** liuyulong has joined #openstack-horizon | 08:26 | |
| openstackgerrit | Merged openstack/horizon: Fixing heatclient release compat issues https://review.openstack.org/287543 | 08:30 |
| *** e0ne has joined #openstack-horizon | 08:36 | |
| *** e0ne has quit IRC | 08:38 | |
| *** vgridnev has joined #openstack-horizon | 08:40 | |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test for check launch volume as instance functionality https://review.openstack.org/276654 | 08:45 |
| *** wangbo has quit IRC | 08:49 | |
| *** ygbo has joined #openstack-horizon | 08:49 | |
| *** vgridnev has quit IRC | 08:54 | |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test check Instance Overview page https://review.openstack.org/280134 | 08:55 |
| mrunge | xiangxinyong, what do you mean? | 08:55 |
| *** vgridnev has joined #openstack-horizon | 08:55 | |
| mrunge | xiangxinyong, it's a django application, run on a web server | 08:56 |
| mrunge | something like systemctl restart httpd comes in mind | 08:56 |
| xiangxinyong | mrunge: i have find some wsgi process about horizon by inputting this command(ps -ef | grep horizon) | 08:58 |
| xiangxinyong | mrunge: what are these horizon wsgi used for? | 08:59 |
| openstackgerrit | Matthias Runge proposed openstack/horizon: Adding angular QoS panel in Horizon https://review.openstack.org/247997 | 09:00 |
| openstackgerrit | Matthias Runge proposed openstack/horizon: WIP-Added attach/detach qos policy to networks https://review.openstack.org/284619 | 09:00 |
| *** wangbo has joined #openstack-horizon | 09:01 | |
| *** gparaskevas has joined #openstack-horizon | 09:01 | |
| mrunge | xiangxinyong, uhm, are you using horizon hooked into httpd? | 09:01 |
| mrunge | or as a separate wsgi process? | 09:01 |
| mrunge | xiangxinyong, what web server are you using? | 09:02 |
| xiangxinyong | mrunge: i use ubuntu | 09:02 |
| xiangxinyong | mrunge: apache2 | 09:03 |
| *** petertr7_away has quit IRC | 09:03 | |
| mrunge | so, you should be restarting apache2 then | 09:03 |
| xiangxinyong | mrunge: yeah. and then? | 09:03 |
| mrunge | that's it? | 09:04 |
| mrunge | there is no horizon process at all | 09:05 |
| mrunge | (most probably) | 09:05 |
| mrunge | xiangxinyong, most probably, your guide is bad | 09:05 |
| *** kzaitsev_mb has joined #openstack-horizon | 09:06 | |
| *** petertr7_away has joined #openstack-horizon | 09:07 | |
| *** petertr7_away is now known as petertr7 | 09:07 | |
| xiangxinyong | mrunge: i find some process like this.http://paste.openstack.org/show/489098/ | 09:07 |
| *** ducttape_ has joined #openstack-horizon | 09:08 | |
| mrunge | aha, ok, you're most probably not using mod_wsgi then | 09:08 |
| mrunge | xiangxinyong, then you need to look up your web server configs, how horizon is hooked into your system | 09:10 |
| xiangxinyong | mrunge: i am using devstack to setup the horizon. is it not the default horizon way? | 09:10 |
| mrunge | no! | 09:10 |
| *** kzaitsev_mb has quit IRC | 09:11 | |
| mrunge | devstack is just a proof of concept, and it's being used for development | 09:11 |
| mrunge | but it's *NOT* suitable for production | 09:11 |
| xiangxinyong | mrunge: oh, i am use it for development. | 09:12 |
| *** ducttape_ has quit IRC | 09:12 | |
| mrunge | sorry about that | 09:13 |
| xiangxinyong | mrunge: i want to develop a plugin for horizon | 09:14 |
| xiangxinyong | it come across lots of quesions | 09:14 |
| mrunge | yes, sure | 09:14 |
| xiangxinyong | now the horizon is broken. so how can i restart it? | 09:15 |
| mrunge | first of all, I won't comment on devstack any more. there are others to answer those questions | 09:15 |
| openstackgerrit | LIU Yulong proposed openstack/horizon: Add floating IP panel to admin dashboard https://review.openstack.org/143628 | 09:16 |
| mrunge | heh, do a clean checkout? | 09:16 |
| mrunge | where ever devstack does that... | 09:16 |
| xiangxinyong | ok | 09:16 |
| *** deray has joined #openstack-horizon | 09:19 | |
| *** zhurong has quit IRC | 09:22 | |
| *** josecastroleon has joined #openstack-horizon | 09:23 | |
| *** wangbo has quit IRC | 09:24 | |
| *** kzaitsev_mb has joined #openstack-horizon | 09:24 | |
| *** e0ne has joined #openstack-horizon | 09:24 | |
| *** Daisy has joined #openstack-horizon | 09:26 | |
| *** Daisy has quit IRC | 09:27 | |
| *** Daisy has joined #openstack-horizon | 09:28 | |
| jgrassler | Good morning | 09:28 |
| *** xinwu has quit IRC | 09:28 | |
| *** Daisy has quit IRC | 09:29 | |
| jgrassler | Quick question about backporting the fix for https://bugs.launchpad.net/django-openstack-auth/+bug/1508421 to stable/kilo (the problem applies to Kilo as well): how would I account for the fix consisting of two changes (my flawed original fix and Thomas' patch against that)? | 09:29 |
| openstack | Launchpad bug 1508421 in django-openstack-auth "Projects dropdown fails due to incomplete Keystone endpoint URL" [Undecided,Fix released] - Assigned to Johannes Grassler (jgr-launchpad) | 09:29 |
| *** Daisy has joined #openstack-horizon | 09:29 | |
| *** Daisy has quit IRC | 09:30 | |
| jgrassler | Just cherry pick both commits from stable/liberty and commit that? | 09:30 |
| jgrassler | s/commit that/submit that for review/ | 09:30 |
| *** Daisy has joined #openstack-horizon | 09:30 | |
| openstackgerrit | Shan Guo proposed openstack/horizon: Add popular ip protocols name in security group https://review.openstack.org/286430 | 09:30 |
| *** trams_ is now known as trams | 09:31 | |
| jgrassler | Or rebase them into a single commit listing the two commits it was cherry picked from? | 09:31 |
| *** Daisy has quit IRC | 09:32 | |
| *** Daisy has joined #openstack-horizon | 09:33 | |
| *** Daisy has quit IRC | 09:33 | |
| *** Daisy has joined #openstack-horizon | 09:33 | |
| *** Murad has joined #openstack-horizon | 09:35 | |
| *** Daisy has quit IRC | 09:35 | |
| Murad | I see this when I add my plugin to horizon : Dashboard with slug "project" is not registered. | 09:35 |
| Murad | can anybody help? | 09:35 |
| *** aortega has joined #openstack-horizon | 09:36 | |
| *** Daisy has joined #openstack-horizon | 09:36 | |
| *** Daisy has quit IRC | 09:36 | |
| Murad | I see this when I add my plugin to horizon : Dashboard with slug "project" is not registered. can anybody help? | 09:37 |
| *** Daisy has joined #openstack-horizon | 09:37 | |
| mrunge | jgrassler, I'd prefer two commits then | 09:38 |
| mrunge | Murad, did you add a "enabled" file for you plugin? | 09:38 |
| Murad | yes | 09:38 |
| jgrassler | mrunge: Ok, thanks! | 09:38 |
| mrunge | ok, that's good | 09:38 |
| mrunge | Murad, still it's quite tedious to debug plugin issues | 09:39 |
| mrunge | it can be everything | 09:39 |
| Murad | I see, I tried to add a sample plugin from github, and tried to write my own basic, the result is the same | 09:40 |
| Murad | what do you suggest? | 09:41 |
| mrunge | share the code? | 09:41 |
| mrunge | my 2ct are, you're using it wrong | 09:41 |
| *** wangbo has joined #openstack-horizon | 09:45 | |
| Murad | hmmm, what is the proper steps to add after writing the plugin? | 09:45 |
| Murad | mrunge | 09:49 |
| mrunge | Murad, | 09:50 |
| Murad | yes, I was asking about the proper steps of adding the plugin | 09:50 |
| mrunge | django plugin or angular plugin? | 09:50 |
| Murad | django | 09:50 |
| *** belmoreira has joined #openstack-horizon | 09:51 | |
| mrunge | http://docs.openstack.org/developer/horizon/tutorials/plugin.html | 09:51 |
| Murad | I did exactly like what they are saying! | 09:52 |
| mrunge | so, docs is wrong? | 09:52 |
| Murad | ofcourse not | 09:52 |
| robcresswell | Well, one of them is wrong | 09:52 |
| robcresswell | Either the docs or your code :) | 09:53 |
| robcresswell | paste.openstack.org please and show us the error trace. | 09:53 |
| Murad | ok | 09:53 |
| mrunge | this is just poking in the dark and won't really work | 09:53 |
| mrunge | without sharing, I meant | 09:53 |
| robcresswell | xiangxinyong: If you want to develop easier, clone from the git repo | 09:54 |
| *** openstackgerrit_ has joined #openstack-horizon | 09:54 | |
| Murad | http://paste.openstack.org/show/489106/ | 09:54 |
| *** wolverineav has joined #openstack-horizon | 09:56 | |
| robcresswell | Huh well that didn't help. Gonna need to see code. Push it to a repo so I can have a look. | 09:56 |
| robcresswell | or paste.openstack.org the non-secret parts. | 09:56 |
| Murad | none of it is secret, I used a sample plugin from github (angular plugin), and it produced the same issue, this is the link: https://github.com/clu-7/horizon-plugin?cm_mc_uid=08742227809714446320777&cm_mc_sid_50200000=1456921803 | 09:58 |
| Murad | https://github.com/clu-7/horizon-plugin | 09:59 |
| robcresswell | I don't understand why everyone recommends using sdist instead of just pip install -e <filepath> :( | 09:59 |
| robcresswell | So much more hassle. | 09:59 |
| Murad | I don't know am just getting started | 10:00 |
| *** e0ne has quit IRC | 10:00 | |
| *** kzaitsev_mb has quit IRC | 10:01 | |
| *** wolverineav has quit IRC | 10:01 | |
| robcresswell | Yeah I'm just debugging now one moment | 10:01 |
| robcresswell | Yeah that works absolutely fine for me. | 10:02 |
| *** openstackgerrit_ has quit IRC | 10:02 | |
| Murad | so you can install that plugin? | 10:02 |
| robcresswell | yeah | 10:03 |
| robcresswell | Difficult to say what may be causing your issue | 10:03 |
| Murad | and you can see in horizon dashboard | 10:03 |
| robcresswell | yep | 10:03 |
| Murad | I am trying with openstack installed with "devstack" | 10:03 |
| Murad | how is your openstack inv. is created? | 10:04 |
| Murad | env* | 10:04 |
| robcresswell | I just clone Horizon from https://git.openstack.org/cgit/openstack/horizon | 10:05 |
| robcresswell | and then point at a local devstack | 10:05 |
| Murad | am installing horizon with devstack, not after | 10:06 |
| robcresswell | it shouldnt matter though. devstack just glones from git itself I believe. | 10:06 |
| robcresswell | clones* | 10:06 |
| *** Daisy has quit IRC | 10:06 | |
| r1chardj0n3s | probably glones too. who knows what devstack really does. | 10:06 |
| *** Daisy has joined #openstack-horizon | 10:07 | |
| robcresswell | Murad: So you're install the plugin package and then copying over the enabled file to horizon/openstack_dashboard/local/enabled? | 10:07 |
| Murad | yes | 10:08 |
| robcresswell | I'm at a loss then. That's literally all there is to it. | 10:08 |
| Murad | I excecuted this ; /opt/stack/horizon/tools/install_venv.py before pip install | 10:08 |
| *** e0ne has joined #openstack-horizon | 10:10 | |
| robcresswell | Sure, that just creates a venv for Horizon. | 10:10 |
| Murad | so I should issue in horizon itself | 10:10 |
| *** Daisy has quit IRC | 10:11 | |
| robcresswell | No it runs it relative to horizon anyway, so it won't create the venv in the wrong place. Even if the install had failed, the issue would be that 'mydashboard' was missing, not 'dashboard' | 10:12 |
| Murad | hmm, so what I am supposed to do? | 10:13 |
| robcresswell | Its pretty difficult for me to debug that. For some reason Horizon can't find the project dashboard in your installation | 10:13 |
| xiangxinyong | <robcresswell>: hi, what's the reason for( If you want to develop easier, clone from the git repo ) | 10:14 |
| robcresswell | clone a new horizon, see if you get any further | 10:14 |
| robcresswell | xiangxinyong: Packagers do extra things on top of Horizon to make it work, which we are mostly not aware of. | 10:15 |
| *** jtriley has joined #openstack-horizon | 10:15 | |
| robcresswell | Which makes it extremely difficult for us to help debug | 10:15 |
| *** qwebirc54839 has joined #openstack-horizon | 10:15 | |
| *** amotoki has joined #openstack-horizon | 10:16 | |
| qwebirc54839 | hello | 10:16 |
| Murad | thanks robcresswell | 10:16 |
| *** amotoki has quit IRC | 10:16 | |
| robcresswell | Murad: Sorry I couldnt be of more help | 10:16 |
| qwebirc54839 | does heat resources will be listed in search light ?? | 10:16 |
| robcresswell | qwebirc54839: Probably a question for the searchlight team. | 10:16 |
| robcresswell | #openstack-searchlight I believe. | 10:16 |
| qwebirc54839 | i mean to say i can see that all the resources related to images servers are listed but i cannot see heat resources or network resources | 10:17 |
| xiangxinyong | <robcresswell> which way do you supposed to debug the horizon or horiozn plugin? | 10:17 |
| qwebirc54839 | oh i see i will check it with them then | 10:17 |
| *** jtriley has quit IRC | 10:20 | |
| robcresswell | xiangxinyong: Err. Ask here. It's just Django for the most part, so any usual python/django tools. | 10:21 |
| xiangxinyong | <robcresswell>: could i use pdb? | 10:22 |
| xiangxinyong | <robcresswell>: thanks a lot. | 10:24 |
| robcresswell | xiangxinyong: Yes, although I don't often find it necessary personally. | 10:25 |
| robcresswell | xiangxinyong: ALso you don't need to paste in the <> when you ping someone. Just their name works. | 10:25 |
| xiangxinyong | robcresswell: OK. Thanks your suggestion. | 10:26 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix BaseRegion and TabbedFormRegion initialization https://review.openstack.org/286627 | 10:32 |
| robcresswell | tsufiev: Could you look at https://review.openstack.org/#/c/285084/ ? Would be good to get it merged so we can toggle LI | 10:34 |
| robcresswell | Has the stamp of approval from hurglebeast | 10:34 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add ngSwift object actions https://review.openstack.org/270553 | 10:35 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add ngSwift containers and objects display https://review.openstack.org/259231 | 10:35 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add ngSwift container actions https://review.openstack.org/259236 | 10:35 |
| r1chardj0n3s | robcresswell: I was going to push that thru once it was rebased to the fix from david | 10:35 |
| robcresswell | \o/ | 10:35 |
| robcresswell | davids fix merged I believe | 10:35 |
| r1chardj0n3s | ok, and it's not in merge conflict, so let's see ... | 10:35 |
| robcresswell | woop. itshappening. | 10:36 |
| r1chardj0n3s | #itshappening or itshappening.gif please | 10:36 |
| tsufiev | robcresswell, r1chardj0n3s: that was fast :) | 10:37 |
| r1chardj0n3s | I've been waiting most of the day for david's patch to finally merge :/ | 10:37 |
| tsufiev | https://review.openstack.org/#/c/284973/ - does it make sense to recheck this patch? | 10:37 |
| r1chardj0n3s | then I got distracted being Dad for the afternoon/evening so have only just got back to it | 10:37 |
| tsufiev | idk the status of py27/py34 unit tests failures | 10:37 |
| robcresswell | Hopefully that will merge by the time David gets up, in time for release | 10:37 |
| *** Daisy has joined #openstack-horizon | 10:38 | |
| robcresswell | tsufiev: That looks like the heat failures to me, at least partially. | 10:38 |
| robcresswell | Some of them look genuine though. | 10:38 |
| r1chardj0n3s | reverify seems reasonable | 10:38 |
| r1chardj0n3s | oh ok | 10:38 |
| r1chardj0n3s | I'll not help | 10:38 |
| r1chardj0n3s | because I'm not helping | 10:38 |
| xiangxinyong | robcresswell:Hi, if you have spare time, please review this patch. I expect your professional suggestion. | 10:38 |
| xiangxinyong | robcresswell:https://review.openstack.org/#/c/286456/ | 10:39 |
| xiangxinyong | robcresswell:thanks | 10:39 |
| tsufiev | okay. By the way, Diana patch for checkboxes https://review.openstack.org/#/c/252161/ already looks good enough to me | 10:39 |
| tsufiev | could squeeze it into M release as well | 10:39 |
| robcresswell | spare time on release day, you say | 10:39 |
| tsufiev | robcresswell, it's FF, not RC day :) | 10:40 |
| openstackgerrit | Matthias Runge proposed openstack/horizon: WIP-Added attach/detach qos policy to networks https://review.openstack.org/284619 | 10:40 |
| robcresswell | Well. Yes. But RC only exists because people break things. Realistically this is the day at which we say "this is what we're proposing for release, but we need a couple of weeks to make sure we didnt blow anything up" | 10:41 |
| robcresswell | anyways | 10:41 |
| robcresswell | checkboxes. | 10:41 |
| tsufiev | it's never too late to put another couple of fancy checkboxes into release :) | 10:42 |
| *** Daisy has quit IRC | 10:42 | |
| *** Daisy has joined #openstack-horizon | 10:42 | |
| openstackgerrit | Wang Bo proposed openstack/horizon: Clear annotaion and codes in rest create_user https://review.openstack.org/287704 | 10:43 |
| r1chardj0n3s | robcresswell: so ... we're still gonna ship two launch instance buttons? | 10:43 |
| *** mvk has joined #openstack-horizon | 10:43 | |
| *** josecastroleon has quit IRC | 10:43 | |
| robcresswell | r1chardj0n3s: I believe the idea is to change it so that the python one is disabled by default. The code is still staying in, yes. | 10:44 |
| openstackgerrit | Matthias Runge proposed openstack/horizon: Added attach/detach qos policy to networks https://review.openstack.org/284619 | 10:44 |
| r1chardj0n3s | okie | 10:44 |
| robcresswell | Can't drop that in a single release. | 10:44 |
| r1chardj0n3s | yup | 10:44 |
| r1chardj0n3s | but the default is still old LI | 10:44 |
| tsufiev | robcresswell, and the tests too are still going to run | 10:44 |
| robcresswell | Yeah just need a small patch to swap it. | 10:44 |
| robcresswell | tsufiev: Did we solve the i9n test issue? | 10:45 |
| tsufiev | Conceptually | 10:45 |
| robcresswell | The best kind of fix | 10:45 |
| tsufiev | we're just going to append a single line to horizon settings, restart Apache and have both buttons in i9n tests | 10:46 |
| tsufiev | they will know which button to press | 10:46 |
| tsufiev | ping me once you have a patch, I'll amend i9n tests changes there | 10:46 |
| robcresswell | Sure, just thinking how best to do it. We dont need both buttons any more for testing, so we could just use a single setting to toggle between the two. | 10:47 |
| *** Daisy has quit IRC | 10:47 | |
| tsufiev | no, that's more complicated for i9n tests | 10:48 |
| robcresswell | Oh? | 10:48 |
| tsufiev | we won't be able to change the switch in the middle of tox run | 10:48 |
| robcresswell | I don't see how it would differ from your previous suggestion | 10:48 |
| robcresswell | Except that there would just be one button instead of two. | 10:48 |
| tsufiev | the idea is to enable both buttons _before_ tox starts running integration tests so it could access them both | 10:49 |
| tsufiev | we need both buttons :) | 10:49 |
| robcresswell | Ah! | 10:49 |
| robcresswell | I see. | 10:49 |
| tsufiev | to be able test both legacy version (so deployers could stay calm) and to test NG version (once tests for it appear) | 10:50 |
| robcresswell | Sure. | 10:50 |
| tsufiev | Well, unless you make a special toggle inside Horizon :) | 10:50 |
| robcresswell | In that case, may as well just drop LAUNCH_INSTANCE_LEGACY_ENABLED = False and LAUNCH_INSTANCE_NG_ENABLED = True into o_d/settings.py | 10:51 |
| r1chardj0n3s | bored cores can get an easy +2 here https://review.openstack.org/#/c/287516 | 10:51 |
| tsufiev | robcresswell, seems ok to me | 10:51 |
| r1chardj0n3s | um. and now I'm going away to play some more xcom :-) | 10:51 |
| tsufiev | r1chardj0n3s, how many soldiers have died already :)? | 10:52 |
| r1chardj0n3s | tsufiev: I'm playing on Normal difficulty (about to finish the game, on the last map) and only about a dozen ;-) | 10:52 |
| tsufiev | oh, it seems you're not save-scumming) | 10:53 |
| r1chardj0n3s | *cough* no, I do that too, sometimes ;-) | 10:53 |
| tsufiev | r1chardj0n3s, good luck, Commander :) | 10:54 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Enabled Angular Launch Instance by default https://review.openstack.org/287710 | 10:58 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Enable Angular Launch Instance by default https://review.openstack.org/287710 | 10:59 |
| robcresswell | tsufiev: https://review.openstack.org/#/c/287710/ Something like this? | 10:59 |
| *** tosky has joined #openstack-horizon | 10:59 | |
| *** doug-fish has joined #openstack-horizon | 11:00 | |
| qwebirc54839 | Hello robcresswell i tried to ask them same question in openstack-searchlight meeting but i didn't get any reply from them i used opesntack-searchlight channel | 11:01 |
| qwebirc54839 | openstack-searchlight | 11:01 |
| *** shu-mutou is now known as shu-mutou-OFF | 11:01 | |
| robcresswell | qwebirc54839: Use the dev mailer then. | 11:01 |
| *** kzaitsev_mb has joined #openstack-horizon | 11:02 | |
| tsufiev | robcresswell, hm... what if we changed default values in places like here https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/images/images/tables.py#L334 ? | 11:02 |
| tsufiev | or even introduced 2 new functions which return the value of these 2 settings? | 11:02 |
| robcresswell | tsufiev: Ooh, good point. I will alter those defaults. | 11:02 |
| tsufiev | the reason why I'm suggesting that is that we already have 2 these settings commented in local_settings | 11:03 |
| robcresswell | Yes, that's a more sensible approach | 11:03 |
| robcresswell | leave the local_settings and just edit the in-code default | 11:03 |
| tsufiev | yeah | 11:03 |
| *** doug-fish has quit IRC | 11:05 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Enabled Angular Launch Instance by default https://review.openstack.org/287710 | 11:07 |
| robcresswell | tsufiev: Updated. Feel free to add your changes and add co-authored-by :) | 11:07 |
| tsufiev | ok | 11:07 |
| *** masco has quit IRC | 11:08 | |
| *** masco has joined #openstack-horizon | 11:09 | |
| *** kzaitsev_mb has quit IRC | 11:10 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Enable Angular Launch Instance by default https://review.openstack.org/287710 | 11:11 |
| robcresswell | Sorry tsufiev, commit typo ^^ | 11:11 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Enable Angular Launch Instance by default https://review.openstack.org/287710 | 11:25 |
| tsufiev | robcresswell, ^^ | 11:26 |
| tsufiev | the most complicated thing there are new .gitignore entries :) | 11:27 |
| tsufiev | An optional prefix "!" which negates the pattern; any matching file excluded by a previous pattern will become included again. It is not possible to re-include a file if a parent directory of that file is excluded. | 11:28 |
| tsufiev | so first we need to re-include parent directory, exclude all its contents and then re-include some specific content | 11:29 |
| *** jtriley has joined #openstack-horizon | 11:30 | |
| *** mvk has quit IRC | 11:32 | |
| *** wangbo has quit IRC | 11:32 | |
| *** pece has joined #openstack-horizon | 11:34 | |
| *** jtriley has quit IRC | 11:34 | |
| robcresswell | tsufiev: Do you actually need that first !statement ? | 11:36 |
| robcresswell | I think you could just do the latter 2 | 11:36 |
| *** kzaitsev_mb has joined #openstack-horizon | 11:38 | |
| *** tqtran has quit IRC | 11:42 | |
| *** wangbo has joined #openstack-horizon | 11:44 | |
| mrunge | wow, that sucks: patch fails due to lower js coverage, and my patch doesn't even contain js code at all | 11:46 |
| robcresswell | :s | 11:46 |
| robcresswell | how does that work? | 11:46 |
| openstackgerrit | Masco proposed openstack/horizon: Usability improvement in instance detail page https://review.openstack.org/255854 | 11:47 |
| mrunge | robcresswell, no idea: https://review.openstack.org/#/c/284619/4 | 11:47 |
| robcresswell | mrunge: Just lower the coverage and ping one of the JS folks | 11:51 |
| mrunge | robcresswell, isn't that like cheating? | 11:51 |
| mrunge | I mean lowering the bar is always bad | 11:52 |
| robcresswell | If everything you've done is clearly python then the detection method must be flawed | 11:52 |
| mrunge | yes | 11:52 |
| mrunge | let's make a bet how many -1 I will get for lowering coverage then? | 11:53 |
| robcresswell | Just explain in the commit message | 11:53 |
| robcresswell | travis had a similar thing | 11:53 |
| robcresswell | He removed some code that had 100% coverage, which meant the average fell, so he had to add tests elsewhere | 11:54 |
| openstackgerrit | Merged openstack/horizon: Fix theming in angular launch instance https://review.openstack.org/285084 | 11:57 |
| robcresswell | \o/ | 11:57 |
| *** wolverineav has joined #openstack-horizon | 11:58 | |
| *** jtriley has joined #openstack-horizon | 11:58 | |
| openstackgerrit | Matthias Runge proposed openstack/horizon: Added attach/detach qos policy to networks https://review.openstack.org/284619 | 11:58 |
| *** wangbo has quit IRC | 11:59 | |
| *** mvk has joined #openstack-horizon | 11:59 | |
| mrunge | robcresswell, thinking again, my patch is dependent on https://review.openstack.org/#/c/247997/21 | 11:59 |
| mrunge | that clearly uses JS | 11:59 |
| robcresswell | Oh, I didnt see that | 12:00 |
| mrunge | and it fails due to lowered coverage: http://logs.openstack.org/97/247997/21/check/gate-horizon-npm-run-test/17bacda/console.html | 12:00 |
| robcresswell | yeah ha, thats all it is | 12:00 |
| mrunge | yes, at least it sounds plausible | 12:00 |
| *** wolverineav has quit IRC | 12:03 | |
| *** openstackgerrit has quit IRC | 12:03 | |
| *** openstackgerrit has joined #openstack-horizon | 12:04 | |
| tsufiev | robcresswell, just tried deleting 1/3 of .gitignore new lines, doesn't work that way | 12:04 |
| openstackgerrit | Merged openstack/horizon: Material: Selection Menu headers aren't visible https://review.openstack.org/287516 | 12:06 |
| *** itisha has quit IRC | 12:09 | |
| *** wangbo has joined #openstack-horizon | 12:11 | |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Add Network Port selection to new instance launch https://review.openstack.org/253573 | 12:12 |
| tsufiev | robcresswell, hmm, now unit-tests for the disabled action are failing | 12:15 |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Add ID to security groups on launch instance https://review.openstack.org/254123 | 12:15 |
| tsufiev | robcresswell, itxaka: there is patch for skipping unit tests on disabled dashboards/panel, does it make sense to generalize it for disabled actions? | 12:16 |
| itxaka | tsufiev, sounds sensible to me | 12:16 |
| mrunge | not sure tsufiev | 12:17 |
| mrunge | that means, disabled panels won't be tested in general | 12:17 |
| tsufiev | mrunge, isn't that the point of itxaka's patch? | 12:17 |
| mrunge | i.e. you can propose a new disabled panel, and it doesn't get tested | 12:17 |
| *** liuyulong has quit IRC | 12:18 | |
| mrunge | I would want to have new panels tested | 12:18 |
| mrunge | in this case, it enables to disable the metering panel | 12:18 |
| tsufiev | mrunge, we still have to manually decorate tests which are to be disabled | 12:18 |
| *** doug-fish has joined #openstack-horizon | 12:19 | |
| mrunge | ack, righ | 12:19 |
| mrunge | +t | 12:19 |
| Murad | mrunge and robcresswell, I fixed the horizon plugin installation issue. Do I need to keep installing and uninstalling the plugin if I do changes to it, or there is a way to edit it live ! | 12:23 |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Angular: Configuration of boot sources for launch instance https://review.openstack.org/270182 | 12:24 |
| robcresswell | Murad: `source horizon/.venv/bin/activate` `cd ../<plugin_directory>` `pip install -e .` | 12:26 |
| robcresswell | That should do it. | 12:27 |
| tsufiev | robcresswell, our patch didn't work as expected: http://logs.openstack.org/10/287710/5/check/gate-horizon-dsvm-integration/e8116b9/screenshots/test_launch_instance_from_image_2016.03.03-115937.png | 12:29 |
| Murad | <plugin_directory> is the development dirctory (git repo ) right? | 12:29 |
| robcresswell | Murad: No, its your local plugin directory | 12:29 |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Configuration of boot sources for launch instance https://review.openstack.org/259981 | 12:29 |
| tsufiev | 'Launch Instance from Image' is trying to be smart and picks the LI to use on its own | 12:30 |
| robcresswell | tsufiev: Is that an issue with the test or the code? | 12:30 |
| *** josecastroleon has joined #openstack-horizon | 12:30 | |
| robcresswell | test or table code* | 12:30 |
| tsufiev | robcresswell, it's the table code | 12:30 |
| tsufiev | it chooses LI on its own | 12:30 |
| *** doug-fish has quit IRC | 12:31 | |
| robcresswell | If both are True, it doesnt show both? | 12:31 |
| *** belmoreira has quit IRC | 12:31 | |
| *** leitan has joined #openstack-horizon | 12:31 | |
| *** belmoreira has joined #openstack-horizon | 12:31 | |
| Murad | inside /opt/stack/horizon ? | 12:31 |
| robcresswell | Murad: No, the directory of your plugin | 12:32 |
| robcresswell | whereever you have stored that | 12:32 |
| *** jtriley has quit IRC | 12:32 | |
| tsufiev | looking right now | 12:32 |
| Murad | ok, and then update with pip install -e . | 12:32 |
| robcresswell | Murad: Yep, all you're doing is activating the venv and installing the plugin inside it with pip install -e . :) | 12:33 |
| Murad | thanks :) | 12:33 |
| robcresswell | I mean you could just pip install -e <plugin_dir> that would be fine. I'm just being overly explicit about the steps. | 12:33 |
| Murad | ok | 12:34 |
| robcresswell | tsufiev: It looks to me like both would render, which makes me think perhaps the i9n test is making assumptions | 12:34 |
| tsufiev | robcresswell, my bad, it's a test issue | 12:34 |
| *** doug-fish has joined #openstack-horizon | 12:34 | |
| robcresswell | :D | 12:34 |
| tsufiev | test is expecting Legacy LI to the the first button in a drop-down, while now it's the second | 12:35 |
| tsufiev | going to fix it in a minute | 12:35 |
| robcresswell | Hmm, the regular tests are failing too | 12:35 |
| robcresswell | Too many hardcoded items | 12:35 |
| robcresswell | When you have fixed i9n, push it and ping me, and I'll fix the other tests | 12:36 |
| *** jtriley has joined #openstack-horizon | 12:36 | |
| tsufiev | robcresswell, updated, will see what happens now | 12:38 |
| *** yamamoto_ has quit IRC | 12:38 | |
| robcresswell | tsufiev: kk, just fixing UTs | 12:40 |
| *** masco has quit IRC | 12:46 | |
| openstackgerrit | zhaozhilong proposed openstack/horizon: Fix heat-output-show post key error and Add heat-output test https://review.openstack.org/287769 | 12:49 |
| *** pauloewerton has joined #openstack-horizon | 12:52 | |
| robcresswell | tsufiev: One more to fix, just getting some lunch | 12:56 |
| *** Mounica has joined #openstack-horizon | 12:57 | |
| tsufiev | nice | 12:58 |
| *** wolverineav has joined #openstack-horizon | 12:59 | |
| *** Mounica has quit IRC | 13:03 | |
| *** wolverineav has quit IRC | 13:03 | |
| *** jtriley has quit IRC | 13:12 | |
| *** ducttape_ has joined #openstack-horizon | 13:13 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix BaseRegion and TabbedFormRegion initialization https://review.openstack.org/286627 | 13:16 |
| *** yamamoto_ has joined #openstack-horizon | 13:25 | |
| *** yamamoto_ has quit IRC | 13:26 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Move out integration tests scaffolds from Horizon production code https://review.openstack.org/287793 | 13:27 |
| *** TravT_ has joined #openstack-horizon | 13:30 | |
| *** yamamoto_ has joined #openstack-horizon | 13:31 | |
| *** TravT has quit IRC | 13:33 | |
| *** ducttape_ has quit IRC | 13:33 | |
| *** zhurong has joined #openstack-horizon | 13:34 | |
| *** yamamoto_ has quit IRC | 13:35 | |
| *** xenogear has quit IRC | 13:36 | |
| *** liuyulong has joined #openstack-horizon | 13:38 | |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Test create/delete network from Admin tab https://review.openstack.org/267521 | 13:39 |
| *** liuyulong has quit IRC | 13:48 | |
| *** ppiela has joined #openstack-horizon | 13:49 | |
| *** yamamoto_ has joined #openstack-horizon | 13:50 | |
| *** vgridnev has quit IRC | 14:00 | |
| *** xenogear has joined #openstack-horizon | 14:00 | |
| *** vgridnev has joined #openstack-horizon | 14:02 | |
| *** neelashah has joined #openstack-horizon | 14:03 | |
| *** ppiela has quit IRC | 14:04 | |
| *** rodrigods has quit IRC | 14:06 | |
| *** rodrigods has joined #openstack-horizon | 14:06 | |
| *** yamamoto_ has quit IRC | 14:07 | |
| *** zhurong has quit IRC | 14:08 | |
| *** jtriley has joined #openstack-horizon | 14:11 | |
| *** doug-fish has quit IRC | 14:17 | |
| *** lblanchard has joined #openstack-horizon | 14:19 | |
| *** jpomeroy has joined #openstack-horizon | 14:22 | |
| *** doug-fish has joined #openstack-horizon | 14:22 | |
| *** doug-fish has quit IRC | 14:24 | |
| *** matt-borland has joined #openstack-horizon | 14:24 | |
| *** doug-fish has joined #openstack-horizon | 14:24 | |
| *** tosky has quit IRC | 14:25 | |
| *** tosky has joined #openstack-horizon | 14:27 | |
| *** tmazur has joined #openstack-horizon | 14:27 | |
| *** Drago has joined #openstack-horizon | 14:28 | |
| *** Drago has quit IRC | 14:30 | |
| *** Drago has joined #openstack-horizon | 14:30 | |
| *** erlon has joined #openstack-horizon | 14:33 | |
| *** mpavlase has quit IRC | 14:36 | |
| *** absubram has joined #openstack-horizon | 14:38 | |
| *** mpavlase has joined #openstack-horizon | 14:39 | |
| *** yamamoto_ has joined #openstack-horizon | 14:39 | |
| *** roxanaghe has joined #openstack-horizon | 14:40 | |
| *** roxanaghe has quit IRC | 14:40 | |
| *** hurgleburgler has joined #openstack-horizon | 14:41 | |
| *** knikolla has joined #openstack-horizon | 14:41 | |
| *** cbader has joined #openstack-horizon | 14:44 | |
| *** vgridnev has quit IRC | 14:48 | |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test for check availability resources for projects https://review.openstack.org/269703 | 14:48 |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test case create/delete subnet from Network Overview page https://review.openstack.org/273116 | 14:48 |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Test create/delete network from Admin tab https://review.openstack.org/267521 | 14:48 |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test edit network from Admin panel https://review.openstack.org/270161 | 14:48 |
| *** petertr7 is now known as petertr7_away | 14:48 | |
| *** vgridnev has joined #openstack-horizon | 14:49 | |
| *** petertr7_away is now known as petertr7 | 14:50 | |
| *** valaparthvi has joined #openstack-horizon | 14:52 | |
| *** sjmc7 has joined #openstack-horizon | 14:54 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Enable Angular Launch Instance by default https://review.openstack.org/287710 | 14:58 |
| *** deray has quit IRC | 14:59 | |
| robcresswell | tsufiev: Think that does it. | 14:59 |
| *** yamamoto_ has quit IRC | 14:59 | |
| *** wolverineav has joined #openstack-horizon | 14:59 | |
| *** yamamoto_ has joined #openstack-horizon | 15:00 | |
| *** belmoreira has quit IRC | 15:01 | |
| *** ducttape_ has joined #openstack-horizon | 15:03 | |
| *** wolverineav has quit IRC | 15:04 | |
| *** rcernin has joined #openstack-horizon | 15:04 | |
| *** amotoki has joined #openstack-horizon | 15:06 | |
| *** valaparthvi has quit IRC | 15:07 | |
| *** gariveradlt has joined #openstack-horizon | 15:11 | |
| *** pushkaru has joined #openstack-horizon | 15:15 | |
| robcresswell | david-lyle: https://review.openstack.org/#/c/287710/ This is the dangerous one, I suppose. | 15:17 |
| *** valaparthvi has joined #openstack-horizon | 15:19 | |
| tsufiev | robcresswell, let's wait for test results anyways | 15:25 |
| *** mtanino has joined #openstack-horizon | 15:29 | |
| *** dan_nguyen has joined #openstack-horizon | 15:29 | |
| *** vgridnev has quit IRC | 15:30 | |
| ducttape_ | wow, going to go with the ng as default. feeling brave | 15:31 |
| *** john5223 has joined #openstack-horizon | 15:32 | |
| robcresswell | ducttape_: Indeed. Run with it for RC. If any big blockers show up, we can revert the patch | 15:38 |
| robcresswell | tsufiev: Does your follow on patch need to be part of the initial one? | 15:38 |
| robcresswell | It would be good to have a clean revert patch if possible. | 15:38 |
| *** valaparthvi has quit IRC | 15:39 | |
| *** dan_nguyen has quit IRC | 15:39 | |
| tsufiev | robcresswell, no, it does slightly different thing | 15:39 |
| tsufiev | robcresswell, but we could wait the followup patch till N | 15:40 |
| tsufiev | it's not urgent | 15:40 |
| *** yamamoto_ has quit IRC | 15:40 | |
| *** nlahouti1 has quit IRC | 15:41 | |
| *** valaparthvi has joined #openstack-horizon | 15:47 | |
| *** Daisy has joined #openstack-horizon | 15:50 | |
| *** aortega has quit IRC | 15:52 | |
| *** mpavlase has quit IRC | 15:53 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Material Design: New LI Tweaks https://review.openstack.org/287531 | 15:54 |
| *** valaparthvi has quit IRC | 15:54 | |
| *** pece has quit IRC | 15:55 | |
| *** yamamoto_ has joined #openstack-horizon | 15:56 | |
| *** tmazur has quit IRC | 15:57 | |
| *** tmazur has joined #openstack-horizon | 15:57 | |
| *** amotoki has quit IRC | 15:59 | |
| *** gariveradlt has quit IRC | 16:01 | |
| *** e0ne has quit IRC | 16:02 | |
| zigo | robcresswell: itxaka: How are we doing with that last Django 1.9 patch? | 16:04 |
| *** Mounica has joined #openstack-horizon | 16:04 | |
| *** gparaskevas has quit IRC | 16:05 | |
| *** rcernin has quit IRC | 16:06 | |
| *** tyr has joined #openstack-horizon | 16:06 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Angular Policy Caching https://review.openstack.org/286268 | 16:08 |
| *** alexvictorchan has quit IRC | 16:08 | |
| *** vijendar has joined #openstack-horizon | 16:11 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Adding Edit Image Action to angular images panel https://review.openstack.org/217828 | 16:11 |
| robcresswell | zigo: Not finished yet, I'm afraid. | 16:11 |
| *** permalac has joined #openstack-horizon | 16:12 | |
| zigo | robcresswell: :( | 16:12 |
| zigo | robcresswell: It would have been nice to have it before b3. | 16:12 |
| zigo | robcresswell: Horizon is the only single OpenStack package I couldn't upload for Mitaka. | 16:12 |
| *** tyr has quit IRC | 16:13 | |
| *** SimonChung1 has quit IRC | 16:14 | |
| *** lapalm has joined #openstack-horizon | 16:14 | |
| *** Daisy has quit IRC | 16:17 | |
| *** Daisy has joined #openstack-horizon | 16:17 | |
| zigo | robcresswell: Is there any blocker ? | 16:21 |
| *** Daisy has quit IRC | 16:22 | |
| *** aortega has joined #openstack-horizon | 16:22 | |
| robcresswell | zigo: Only in terms of figuring out why its failing | 16:24 |
| *** proto has joined #openstack-horizon | 16:24 | |
| tsufiev | does anyone remember why in Juno release Angular<1.3 was used? | 16:24 |
| proto | hello there | 16:24 |
| robcresswell | zigo: Looking into it now. Will see if I can get it done this afternoon. | 16:25 |
| proto | we about to upgrade juno to kilo our production system | 16:25 |
| proto | We found a bug in the swift panel that is already fixed in liberty https://review.openstack.org/#/c/287928/ | 16:25 |
| robcresswell | david-lyle: Another thought; I've yet to go back and double check all bps/large bugs have release notes. Is that okay for RC1? Or should I get that done today? | 16:26 |
| *** tmazur has quit IRC | 16:28 | |
| *** xinwu has joined #openstack-horizon | 16:29 | |
| *** vgridnev has joined #openstack-horizon | 16:29 | |
| *** garthb has joined #openstack-horizon | 16:29 | |
| matt-borland | proto, do you have a question for the group? | 16:30 |
| proto | yes | 16:30 |
| proto | I have no idea | 16:30 |
| proto | what is the process | 16:30 |
| *** Fin1te has joined #openstack-horizon | 16:30 | |
| proto | to involve the developers | 16:30 |
| proto | on a code review | 16:30 |
| proto | I am a openstack operator | 16:30 |
| proto | on the operator mailing list | 16:30 |
| proto | I have been suggested to get on IRC | 16:30 |
| proto | and raise some attention about this gerrit code review | 16:31 |
| proto | but I am not sure what I am suppose to do :) | 16:31 |
| proto | so, I found the bug is already fixed upstream | 16:31 |
| proto | I cherry-picked to review.openstack.org | 16:31 |
| robcresswell | woah, press enter less please :) | 16:31 |
| proto | to ask the merge in stable/kilo | 16:31 |
| *** zzxwill has quit IRC | 16:32 | |
| tsufiev | proto, seems like a valid fix for stable branch | 16:32 |
| proto | sorry, as you can see I am really not used to chat often in IRC. :) | 16:32 |
| robcresswell | Sure, no problem. Seems like a good fix for stable. mrunge, could you look into it? | 16:32 |
| proto | I dont understand if the tests are triggered automatically on review.openstack.org, and how does it work for having people checking the stuff and clicking +1 or -1 ? | 16:32 |
| *** Drago has quit IRC | 16:33 | |
| tsufiev | proto, they are, but it takes a while | 16:33 |
| *** Drago has joined #openstack-horizon | 16:33 | |
| robcresswell | zigo: So, Horizon Mitaka won't get released for Debian even if its the same version of Django that is supported by Jessie? | 16:33 |
| proto | tsufiev: ok, should I connect here once again after the tests have run ? so I can trigger someone to have a look and eventually vote +1 or -1 ? | 16:34 |
| tsufiev | proto, I've already added mrunge and david-lyle who are stable branch cores to the review | 16:34 |
| tsufiev | they'll take a look once tests pass | 16:34 |
| proto | tsufiev: thanks ! so I think it worked this interaction with IRC :) thank you all and have a good day | 16:35 |
| tsufiev | :) | 16:35 |
| proto | bye :) | 16:35 |
| *** proto has quit IRC | 16:35 | |
| *** woodburn has joined #openstack-horizon | 16:37 | |
| robcresswell | Ah wait, Jessie is 1.7 | 16:37 |
| *** vijendar has quit IRC | 16:38 | |
| *** donu7 has joined #openstack-horizon | 16:39 | |
| matt-borland | robcresswell, with feature freeze, how does that deal with things like https://review.openstack.org/#/c/219925/ , where it's adding code for a missing link for Launch Instance? | 16:43 |
| robcresswell | matt-borland: Bugfixes are fine, although there are more rules for string changes | 16:43 |
| *** jprovazn has joined #openstack-horizon | 16:45 | |
| *** exploreshaifali has joined #openstack-horizon | 16:45 | |
| robcresswell | SoftStringFreeze is the same time as FF I believe | 16:45 |
| matt-borland | Cool, thanks! | 16:45 |
| *** vijendar has joined #openstack-horizon | 16:45 | |
| robcresswell | That patch has a translation in it I think | 16:45 |
| robcresswell | I'd get someone to look at it ASAP | 16:45 |
| matt-borland | what if the translation already exists? | 16:46 |
| robcresswell | If its not a new string, it doesnt matter | 16:46 |
| matt-borland | I've tried to get people to look at it ASAP for a few months, but I can try again | 16:46 |
| robcresswell | tsufiev: Angular LI default patch passed tests | 16:47 |
| tsufiev | robcresswell, \o/ | 16:47 |
| robcresswell | matt-borland: them pesky cores having jobs and stuff. | 16:47 |
| matt-borland | :) robcresswell | 16:47 |
| matt-borland | I think part of the problem was that it had a Low priority assigned to it. :( | 16:48 |
| *** petertr7 is now known as petertr7_away | 16:49 | |
| matt-borland | but if you want NG LI on by default, it suddenly becomes quite high. | 16:49 |
| *** bpokorny has joined #openstack-horizon | 16:49 | |
| tsufiev | robcresswell, from what I've heard so far, new tables broke murano-dashboard plugin tests | 16:51 |
| * tsufiev is going to +2 NG LI and keep breaking more things :) | 16:51 | |
| matt-borland | lol tsufiev | 16:52 |
| zigo | robcresswell: I can only upload to Sid, nothing else. | 16:52 |
| zigo | robcresswell: I can provide a version of Horizon in a private repository, but that's it, it wont be official packages. | 16:52 |
| zigo | robcresswell: Also, Mitaka is likely to be what's going to end in Debian 9 (aka: Stretch), it'd be really a shame if we had no dashboard ... :/ | 16:53 |
| *** wolverineav has joined #openstack-horizon | 16:53 | |
| robcresswell | Indeed | 16:53 |
| zigo | robcresswell: So, what's the blockers for that last patch? | 16:53 |
| zigo | robcresswell: Was my last issue fixed? | 16:54 |
| robcresswell | zigo: Which was your last issue? | 16:54 |
| zigo | robcresswell: I could apply the patch locally in Debian, even if it's not merged, but it has to fix all the remaining issues and apply cleanly. | 16:54 |
| zigo | I cna't remember ... :( | 16:54 |
| zigo | robcresswell: I'll try as soon as Horizon b3 is out. | 16:54 |
| robcresswell | There's still a number of test failures in the most recent patch. Its related to form handling. | 16:54 |
| *** alexvictorchan has joined #openstack-horizon | 16:56 | |
| robcresswell | itxaka: ping - this looks suspicious. https://docs.djangoproject.com/es/1.9/ref/class-based-views/mixins-editing/#django.views.generic.edit.FormMixin.get_context_data | 16:59 |
| itxaka | uh uh | 16:59 |
| itxaka | nice find | 16:59 |
| itxaka | that may be the source of the double clean call | 17:00 |
| *** gyee has joined #openstack-horizon | 17:01 | |
| *** doug-fish has quit IRC | 17:02 | |
| robcresswell | Yeah. Just following the form spaghetti now. | 17:02 |
| *** rdopiera has quit IRC | 17:02 | |
| david-lyle | robcresswell: https://review.openstack.org/#/c/287710/7 | 17:04 |
| *** exploreshaifali has quit IRC | 17:04 | |
| david-lyle | couple missing things | 17:04 |
| *** dan_nguyen has joined #openstack-horizon | 17:06 | |
| *** ygbo has quit IRC | 17:06 | |
| *** petertr7_away is now known as petertr7 | 17:07 | |
| *** Fin1te has quit IRC | 17:08 | |
| robcresswell | david-lyle: Yep | 17:08 |
| robcresswell | Thanks | 17:08 |
| david-lyle | thank you | 17:09 |
| openstackgerrit | Merged openstack/horizon: Horizon Checkboxes are now themeable. https://review.openstack.org/252161 | 17:09 |
| *** doug-fish has joined #openstack-horizon | 17:09 | |
| *** nlahouti has joined #openstack-horizon | 17:15 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Move out integration tests scaffolds from Horizon production code https://review.openstack.org/287793 | 17:16 |
| robcresswell | Huh, seems like the launch instance settings were never documented? | 17:17 |
| robcresswell | david-lyle: Should I backdate the 'version added' to Liberty, or just list it as Mitaka? | 17:17 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Material Design: New LI Tweaks https://review.openstack.org/287531 | 17:18 |
| david-lyle | I'd just point out that the default values changed in Mitaka | 17:19 |
| david-lyle | O_o | 17:20 |
| david-lyle | just read the first part :P | 17:20 |
| robcresswell | Yeah | 17:20 |
| robcresswell | Thoughts? | 17:20 |
| *** petertr7 is now known as petertr7_away | 17:20 | |
| robcresswell | I was going to backdate the version added, and put a Note:: in there about the default changing | 17:20 |
| david-lyle | yeah backdate | 17:21 |
| * david-lyle facepalm | 17:21 | |
| *** deray has joined #openstack-horizon | 17:21 | |
| david-lyle | it was in a release not at least | 17:22 |
| * david-lyle believes | 17:22 | |
| *** aortega has quit IRC | 17:22 | |
| tsufiev | btw, have we fixed https://bugs.launchpad.net/horizon/+bug/1517704 ? | 17:22 |
| openstack | Launchpad bug 1517704 in OpenStack Dashboard (Horizon) "Test still passes even with tests failure" [Critical,New] | 17:22 |
| *** aortega has joined #openstack-horizon | 17:23 | |
| tsufiev | and I wonder if you are participating in a Bug Smashing Days Event? | 17:23 |
| tsufiev | do we need to split bugs between locations where the event will be hosted? | 17:24 |
| * tsufiev is picking some bugs for Mirantis office | 17:24 | |
| tsufiev | we have whole 5 folks who are going to come and fix some bugs in horizon ) | 17:24 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Material Design: New LI Tweaks https://review.openstack.org/287531 | 17:25 |
| david-lyle | robcresswell: I'd have to check, but I think that change may have landed in Kilo for the settings | 17:25 |
| david-lyle | I think the original assumption was it would be short lived | 17:25 |
| david-lyle | we should know, nothing is short lived | 17:25 |
| david-lyle | tsufiev: I haven't planned that far in advance | 17:25 |
| david-lyle | I think that bug is still valid | 17:26 |
| *** wolverineav has quit IRC | 17:26 | |
| david-lyle | if the underlying issue isn't fixed | 17:26 |
| *** valaparthvi has joined #openstack-horizon | 17:26 | |
| david-lyle | it's not a bug to track bugs, it's a bug to track that tests pass even if there are mock failures | 17:26 |
| *** nlahouti has quit IRC | 17:27 | |
| tsufiev | david-lyle, okay. On the second thought, I'll leave this bug for more experienced devs (not for Bug Smashing Days) | 17:27 |
| david-lyle | yeah, I'm not even sure we can fix it | 17:28 |
| david-lyle | and we may end up marking it "won't fix", but I'd like to fully understand the cause first | 17:28 |
| david-lyle | hiding errors is tests is not ideal :) | 17:28 |
| tsufiev | hard truth :) | 17:29 |
| david-lyle | I hear r1chardj0n3s likes tests, and is asleep so can't defend himself | 17:29 |
| *** SimonChung has joined #openstack-horizon | 17:30 | |
| tsufiev | haha )) | 17:33 |
| *** pushkaru has quit IRC | 17:33 | |
| tsufiev | that would be not fair | 17:33 |
| *** piet has joined #openstack-horizon | 17:35 | |
| robcresswell | Being unfair to r1chardj0n3s sounds like a good idea to me :p | 17:35 |
| david-lyle | I'm sure he wouldn't want it any other way | 17:35 |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Don't force people to security groups after they add a FIP https://review.openstack.org/284973 | 17:36 |
| *** aortega has quit IRC | 17:37 | |
| ducttape_ | robcresswell david-lyle ^ the test depended upon that wonky request.REQUEST behavior thing, and robcresswell's previous patch was written so tests pass, but the feature was broken | 17:37 |
| ducttape_ | if that makes sense | 17:37 |
| robcresswell | Nice. | 17:37 |
| *** aortega has joined #openstack-horizon | 17:37 | |
| robcresswell | Will approve when jenkins passes it | 17:37 |
| david-lyle | perfect sense | 17:38 |
| ducttape_ | yep no worries thanks again | 17:38 |
| david-lyle | what robcresswell said | 17:38 |
| robcresswell | Test depending upon broken code being implemented XD | 17:38 |
| robcresswell | excellent | 17:38 |
| *** valaparthvi has left #openstack-horizon | 17:38 | |
| david-lyle | consistency is the only thing that matters | 17:38 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Enable Angular Launch Instance by default https://review.openstack.org/287710 | 17:40 |
| robcresswell | reno and docs as requested. | 17:41 |
| *** vgridnev has quit IRC | 17:41 | |
| david-lyle | robcresswell: already looking | 17:42 |
| *** tyr has joined #openstack-horizon | 17:42 | |
| david-lyle | wondering about freezing the old launch instance | 17:42 |
| *** vgridnev has joined #openstack-horizon | 17:42 | |
| david-lyle | ducttape_, mrunge opinions if the above patch goes through? | 17:43 |
| robcresswell | I assume we take bugfixes and no new features? | 17:43 |
| david-lyle | yeah that would be the nature of the freeze | 17:43 |
| david-lyle | have to determine a way to note that somewhere if we do it | 17:43 |
| *** aortega has quit IRC | 17:44 | |
| robcresswell | A bright pink banner at the top of the template that says "Nope" | 17:44 |
| *** aortega has joined #openstack-horizon | 17:45 | |
| doug-fish | that's a nice solution for the integration testing | 17:45 |
| ducttape_ | you mean new launch instance thing ? | 17:45 |
| doug-fish | yep | 17:45 |
| david-lyle | doing a permanent feature freeze on the django version | 17:46 |
| ducttape_ | I'm concerned there have been complaints about the transfer table (select a flavor) which have gone un addressed for a long time, is my main concern | 17:46 |
| *** lhcheng has joined #openstack-horizon | 17:46 | |
| ducttape_ | if we are going to switch to the new launch instance, seems like there are things to work on before make a bad first impression | 17:47 |
| robcresswell | My thoughts on it are that the UI for that doesnt outweigh the plus points for the rest. But I agree that its not good. | 17:47 |
| david-lyle | ducttape_: have you tried it recently? | 17:47 |
| robcresswell | UI for single select transfer table, that is. | 17:47 |
| david-lyle | the transfer is bad yes | 17:47 |
| robcresswell | But the rest I feel, is quite a solid improvement. | 17:48 |
| david-lyle | the drag and drop network select on the django is also bad | 17:48 |
| david-lyle | we just are used to it | 17:48 |
| robcresswell | And I think for batch select, its a lot better. It just needs a better solution for single select. | 17:48 |
| *** mpavlase has joined #openstack-horizon | 17:48 | |
| robcresswell | Yeah I actually think for networks its okay. Its things like flavour... its clunky. | 17:48 |
| david-lyle | I was just noting the django side is not without warts | 17:49 |
| robcresswell | Oh absolutely. | 17:49 |
| david-lyle | we're just used to the way they look and can ignore them better | 17:49 |
| robcresswell | yup | 17:50 |
| robcresswell | doug-fish: Btw, did the recent workflow changes break the LBAAS workflows? | 17:50 |
| robcresswell | doug-fish: I can look into fixing it for you next week if so. Might be faster that way. | 17:51 |
| doug-fish | I know we were broken about a week ago ... and weren't as of about yesterday when I last updated Horizon | 17:51 |
| doug-fish | how recently did you try to break us? | 17:51 |
| robcresswell | We really need to start blocking non-bootstrap markup... | 17:51 |
| robcresswell | doug-fish: Er, this morning ;) | 17:51 |
| ducttape_ | fwiw, I have received more possitive feedback for the material theme, vs the new launch instance | 17:51 |
| doug-fish | ah | 17:51 |
| ducttape_ | out of my team of ~15 engineers that have seen both | 17:52 |
| robcresswell | ducttape_: But now you can have both at the same time. :D | 17:52 |
| ducttape_ | yes, I have that in the lab right now | 17:52 |
| doug-fish | ducttape_: do you mind summarizing the new launch instance feedback for those of us who have brains like a sieve? | 17:53 |
| ducttape_ | I can, but I have a presentation in 7 minutes I gotta get ready for | 17:53 |
| doug-fish | sure, understood | 17:53 |
| *** kzaitsev_mb has quit IRC | 17:54 | |
| ducttape_ | the main issues are usually around using the transfer table when it isn't appropriate.... thats the #1 issue / complaint / confusion spot | 17:54 |
| doug-fish | anyone else comfortable representing ducttape_'s concerns? | 17:54 |
| doug-fish | k | 17:54 |
| ducttape_ | if that change merges, it's not the end of the world to me | 17:54 |
| ducttape_ | I'm fine with it | 17:54 |
| *** e0ne has joined #openstack-horizon | 17:55 | |
| ducttape_ | but you only get one first impression, is the main concern | 17:55 |
| doug-fish | cool. It's nice to have a fallback that if people _hate_ it they can revert | 17:55 |
| robcresswell | The biggest issue I believe is the use of transfer tables for single select items | 17:55 |
| ducttape_ | +1 robcresswell | 17:56 |
| robcresswell | Its confusing/info overload/over engineered basically. | 17:56 |
| *** ybathia has joined #openstack-horizon | 17:56 | |
| *** tyr has quit IRC | 17:56 | |
| *** aortega has quit IRC | 17:57 | |
| *** yamamoto_ has quit IRC | 17:57 | |
| robcresswell | I have a couple ideas for solutions. Not sure if UX have looked into it yet | 17:57 |
| *** aortega has joined #openstack-horizon | 17:58 | |
| *** ducttape_ has quit IRC | 17:58 | |
| doug-fish | If memory serves this code has been floating around for more than a release - I think it's time to let it out. | 17:59 |
| robcresswell | Yeah, I'd quite like to. I think if the biggest complaint is that the select widget is over engineered, then we've made a fairly decent improvement. | 18:01 |
| david-lyle | robcresswell: just try one | 18:01 |
| robcresswell | david-lyle: Sorry? | 18:01 |
| david-lyle | piet: did you have someone looking at transfer tables? | 18:01 |
| *** masco has joined #openstack-horizon | 18:02 | |
| piet | david-lyle We did. Is there a resource available to work on them? | 18:02 |
| robcresswell | I'm gonna change my job title to "resource" | 18:02 |
| robcresswell | :p | 18:03 |
| piet | david-lyle UI dev resource | 18:03 |
| *** wolverineav has joined #openstack-horizon | 18:03 | |
| piet | robcresswell Better than what we were calling you | 18:03 |
| robcresswell | At this stage its too late to fix, unless you want to push it forward as a questionable wishlist bug. | 18:03 |
| robcresswell | piet: Ha! | 18:03 |
| piet | Kk | 18:03 |
| piet | Let me chat with Hayat and Sonia | 18:04 |
| *** tyr has joined #openstack-horizon | 18:04 | |
| *** clu_ has joined #openstack-horizon | 18:05 | |
| *** mariusv_ has quit IRC | 18:05 | |
| *** mariusv has quit IRC | 18:05 | |
| *** mariusv has joined #openstack-horizon | 18:06 | |
| *** mariusv has quit IRC | 18:06 | |
| *** mariusv has joined #openstack-horizon | 18:06 | |
| *** wolverineav has quit IRC | 18:07 | |
| *** wolverineav has joined #openstack-horizon | 18:09 | |
| *** SimonChung has quit IRC | 18:11 | |
| *** Ephur has joined #openstack-horizon | 18:12 | |
| mrunge | david-lyle, ok for me (new launch instance as default) if that was the question | 18:16 |
| *** Ephur_ has joined #openstack-horizon | 18:16 | |
| *** permalac has quit IRC | 18:17 | |
| *** Ephur has quit IRC | 18:18 | |
| *** ducttape_ has joined #openstack-horizon | 18:19 | |
| *** exploreshaifali has joined #openstack-horizon | 18:19 | |
| *** tyr has quit IRC | 18:19 | |
| david-lyle | mrunge: that and instituting a feature freeze on the django version | 18:20 |
| kfox1111 | adding a second region to our cloud. | 18:20 |
| david-lyle | \o/ | 18:20 |
| kfox1111 | horizon logins on our existing dashboard are defaulting to loging into the new region | 18:20 |
| kfox1111 | how do we set the default to the other region for now? | 18:20 |
| david-lyle | kfox1111: region being? | 18:20 |
| *** mpavlase has quit IRC | 18:20 | |
| david-lyle | keystone region or keystone instance | 18:21 |
| kfox1111 | 'Pilot' and 'Research' | 18:21 |
| kfox1111 | keystone region. | 18:21 |
| ducttape_ | kfox1111: I recall a doa change around that | 18:21 |
| mrunge | david-lyle, what do you mean by feature freeze on the django version? | 18:21 |
| david-lyle | so login screen would not change | 18:21 |
| mrunge | django not being upgraded any more? | 18:21 |
| ducttape_ | if you set horizon's auth url, it will try to scope to that region, where the auth url matches | 18:21 |
| mrunge | or no new features being developed on django side? | 18:21 |
| david-lyle | mrunge: no new features on django version of launch instance | 18:22 |
| *** SimonChung has joined #openstack-horizon | 18:22 | |
| mrunge | ack | 18:22 |
| david-lyle | mrunge: sound ok? | 18:22 |
| mrunge | I thought you'd freeze all django uis | 18:22 |
| kfox1111 | ideas? | 18:22 |
| mrunge | yes, ack david-lyle | 18:23 |
| kfox1111 | users are starting to notice. :/ | 18:23 |
| lhcheng | david-lyle: can we backport new features from angular to django version? :) | 18:23 |
| david-lyle | lhcheng: no | 18:23 |
| david-lyle | basically deprecating it | 18:24 |
| *** tyr has joined #openstack-horizon | 18:24 | |
| kfox1111 | can it be restricted at least with AVAILABLE_REGIONS? | 18:25 |
| kfox1111 | so only pilot shows up? | 18:25 |
| david-lyle | kfox1111: I'm still trying to determine your use of region | 18:25 |
| kfox1111 | how does it pick a region? | 18:25 |
| kfox1111 | david-lyle: keystone region. | 18:25 |
| kfox1111 | we have 2 now. | 18:25 |
| kfox1111 | Pilot and Research. | 18:25 |
| david-lyle | so only in your service catalog? or logging in to separate endpoints for keystone | 18:26 |
| david-lyle | ? | 18:26 |
| lhcheng | david-lyle: I haven't read the docs for extending the angular version, don't know if it easier now or not. But if its not easy to extend, I don't like the angular version being default. | 18:26 |
| kfox1111 | user logs in to dashboard still with just a username and password, and its throwing them into "Research" region. | 18:26 |
| david-lyle | lhcheng: workflow extensibility has been added | 18:26 |
| david-lyle | for angular | 18:26 |
| david-lyle | ok | 18:27 |
| lhcheng | david-lyle: by updating 10+ files? :) | 18:27 |
| kfox1111 | david-lyle: maybe I'm confused. there are one set of services, two sets of enpoints now. one per region. | 18:27 |
| kfox1111 | one keystone. | 18:27 |
| lhcheng | david-lyle: I'll have to check the docs | 18:27 |
| david-lyle | ok, just two types of regions and the answers are very different | 18:27 |
| kfox1111 | user logs into horizon with username/pw, then under the drop down, we have projectgs and regions now. | 18:27 |
| kfox1111 | and its defaulting to one of the two. | 18:27 |
| david-lyle | so clarifying before we go down the wrong road | 18:28 |
| david-lyle | I understand now | 18:28 |
| kfox1111 | yeah. that parts confusing. :/ | 18:28 |
| kfox1111 | k. | 18:28 |
| TravT_ | lhcheng: https://review.openstack.org/#/c/244407/ | 18:28 |
| david-lyle | kfox1111: regions are sticky by cookie | 18:28 |
| david-lyle | i thought there was a setting to provide a hint | 18:29 |
| david-lyle | looking | 18:29 |
| *** TravT_ has quit IRC | 18:30 | |
| kfox1111 | the cookie's services_region | 18:30 |
| lhcheng | TravT_: the doc is shorter than I expected, maybe its easier now :) | 18:31 |
| *** tyr has quit IRC | 18:31 | |
| david-lyle | kfox1111: no setting | 18:32 |
| david-lyle | :( | 18:32 |
| david-lyle | could override https://github.com/openstack/django_openstack_auth/blob/master/openstack_auth/utils.py | 18:33 |
| david-lyle | oops | 18:33 |
| david-lyle | https://github.com/openstack/django_openstack_auth/blob/master/openstack_auth/utils.py#L331 | 18:33 |
| kfox1111 | thx. looking... | 18:35 |
| *** tyr has joined #openstack-horizon | 18:36 | |
| kfox1111 | yeah. I can hack this I think. thanks for the pointer. that really helped. :) | 18:36 |
| *** vishwanathj_zzz is now known as vishwanathj | 18:37 | |
| kfox1111 | might be able to convince mgmt to let me make this fix configurable and contribute it. | 18:37 |
| kfox1111 | didn't seem to work. :/ | 18:42 |
| *** masco has quit IRC | 18:42 | |
| kfox1111 | let me double check the code.... | 18:42 |
| david-lyle | are you editing the right copy | 18:42 |
| david-lyle | ? | 18:42 |
| *** petertr7_away is now known as petertr7 | 18:43 | |
| kfox1111 | ah. I see. | 18:43 |
| kfox1111 | trying again. | 18:43 |
| *** tyr has quit IRC | 18:44 | |
| *** rcernin has joined #openstack-horizon | 18:44 | |
| *** piet has quit IRC | 18:45 | |
| kfox1111 | k. that seemed to fix it. | 18:46 |
| kfox1111 | thanks. :) | 18:46 |
| kfox1111 | there's two places in the code that do available_regions[0] | 18:46 |
| *** gyee has quit IRC | 18:46 | |
| kfox1111 | I initially guessed the wrong path the first time. :) | 18:46 |
| robcresswell | Angular Launch Instance patch passed gate btw. Let me know if I need to add any deprecation warnings etc. | 18:47 |
| robcresswell | Was hoping to get off IRC before midnight ;) | 18:47 |
| mrunge | well, depending on which timezone robcresswell | 18:49 |
| mrunge | :P | 18:49 |
| robcresswell | haha | 18:49 |
| openstackgerrit | Alexandra Allakhverdieva proposed openstack/horizon: Add test for volumes attach/detach https://review.openstack.org/275231 | 18:50 |
| david-lyle | kfox1111: glad it worked | 18:57 |
| *** mvk has quit IRC | 18:57 | |
| *** e0ne has quit IRC | 18:57 | |
| kfox1111 | yeah. thank you so much for the quick assistance. its really apreciated. :) | 18:58 |
| *** pushkaru has joined #openstack-horizon | 18:58 | |
| *** yamamoto_ has joined #openstack-horizon | 18:58 | |
| *** kzaitsev_mb has joined #openstack-horizon | 18:58 | |
| doug-fish | robcresswell: did you get the issue with en-gb sorted out? | 19:00 |
| robcresswell | doug-fish: Nope | 19:02 |
| * david-lyle is watching all the client releases and has a terrible feeling about today | 19:02 | |
| hurgleburgler | :-D | 19:02 |
| robcresswell | doug-fish: Still broken | 19:02 |
| doug-fish | bug yet? | 19:03 |
| robcresswell | david-lyle: I'm surprised only heat broke us. | 19:03 |
| robcresswell | doug-fish: Oh, no I'll file one now. | 19:03 |
| doug-fish | that's something we need to understand + fix | 19:03 |
| david-lyle | robcresswell: many are releasing now or in the past hour or two | 19:03 |
| * david-lyle goes to test | 19:03 | |
| *** tosky has quit IRC | 19:05 | |
| *** yamamoto_ has quit IRC | 19:05 | |
| robcresswell | doug-fish: https://bugs.launchpad.net/horizon/+bug/1552867 | 19:05 |
| openstack | Launchpad bug 1552867 in OpenStack Dashboard (Horizon) "British English translations don't appear to work in Angular Launch Instance." [Undecided,New] | 19:05 |
| *** ducttape_ has quit IRC | 19:06 | |
| doug-fish | in the future, when there are more plugins, our last minute Horizon changes will break the plugins instead of us getting broken. | 19:06 |
| doug-fish | It's going to be a hassle because the plugins are probably going to have feature freeze before Horizon | 19:06 |
| *** ducttape_ has joined #openstack-horizon | 19:07 | |
| doug-fish | or release canidates | 19:07 |
| doug-fish | robcresswell: thx! | 19:07 |
| david-lyle | doug-fish: that would be an odd choice for a plugin | 19:07 |
| robcresswell | Why would a plugin have FF before its parent? | 19:08 |
| doug-fish | I think we wanted plugins to be owned by + under the governance of their respective service | 19:08 |
| robcresswell | Doesnt mean they have to release at the same time | 19:08 |
| doug-fish | so neutron-lbaaas-dashboard belongs to neutron | 19:08 |
| david-lyle | as you go up the consumption stack, your feature freeze/release gets later | 19:08 |
| doug-fish | yeah that would make more sense | 19:08 |
| doug-fish | is that set up properly in other plugins? | 19:09 |
| doug-fish | maybe this is just a mistake of neutron-lbaas-dashboard | 19:09 |
| robcresswell | I'd expect plugins to release 2/3 weeks later | 19:09 |
| doug-fish | you don't expect them to be on the release schedule? | 19:09 |
| robcresswell | idk, neutrons plugin handling seems poor. I found out today that their plugins dont have approval rights on their own stable branches. seems bizarre. | 19:09 |
| robcresswell | But I guess they have higher stability requirements. I still feel a plugin should be able to break itself. | 19:10 |
| *** SimonChung has quit IRC | 19:10 | |
| robcresswell | doug-fish: No, I expect plugins to all have independent releases | 19:10 |
| doug-fish | It's not an urgent issue to me today, but I think I'll be more concerned about it in neutron | 19:11 |
| doug-fish | robcresswell: I don't think that's a reasonable assumption | 19:11 |
| doug-fish | IMO the plugins should be on the main release schedule | 19:11 |
| doug-fish | hey - I think I have a summit topic | 19:11 |
| robcresswell | Yeah | 19:11 |
| robcresswell | My initial thought would be that lbaas dependency is Horizon | 19:12 |
| david-lyle | I've said it before and I repeat, big tent = big mess | 19:12 |
| david-lyle | for anyone above level 0 | 19:12 |
| robcresswell | Otherwise Horizon would have to freeze at like... M-2 | 19:12 |
| *** piet has joined #openstack-horizon | 19:12 | |
| *** Fin1te has joined #openstack-horizon | 19:12 | |
| robcresswell | doug-fish: What do you gain by syncing release with Neutron instead of Horizon? | 19:13 |
| robcresswell | releasing later than neutron also gives you time to address the current feature adds inside neutron. | 19:13 |
| david-lyle | this was all covered by the hand waving part of the plan | 19:13 |
| doug-fish | well the project is under neutron governance - I think that's our preferred model because we want services to be able to own their own UI | 19:13 |
| robcresswell | shared governance does not mean shared release | 19:13 |
| *** kzaitsev_mb has quit IRC | 19:14 | |
| robcresswell | as far as I understand it | 19:14 |
| robcresswell | governance is more symbolic than anything else | 19:14 |
| doug-fish | I haven't cared about it so much before the last couple of days, so I'm not completely up to speed | 19:14 |
| david-lyle | you can even have different repos with different release methodologies under one project | 19:15 |
| piet | robcresswell david-lyle why the interested in the transfer table? | 19:15 |
| david-lyle | the main problem is, the horizon plugins in the service teams will likely be after thoughts | 19:15 |
| doug-fish | but release methodologies aren't that granular are they? doesn't that mean just on the openstack release cycle or not? | 19:15 |
| robcresswell | piet: Its the main issue people have with the new Launch Instance | 19:15 |
| david-lyle | and lucky to release at all | 19:16 |
| *** xinwu has quit IRC | 19:16 | |
| robcresswell | single select items in transfer table are generally considered the biggest downside to it so far. | 19:16 |
| david-lyle | piet because we deserve better | 19:16 |
| piet | robcresswell ok | 19:16 |
| david-lyle | :P | 19:16 |
| doug-fish | <- kind of likes the transfer tables | 19:16 |
| piet | david-lyle given the old Launch Instance I just assumed you were sadists | 19:16 |
| robcresswell | doug-fish: There's a little more to it than that, but generally yes. People either sync with OpenStack core, or whenever they want | 19:17 |
| robcresswell | There are other tags related to milestones and stable releases | 19:17 |
| doug-fish | It sounds like maybe I just need to learn more about these other tags | 19:18 |
| robcresswell | https://github.com/openstack/governance/blob/master/reference/projects.yaml | 19:18 |
| david-lyle | doug-fish: they're fine when not misapplied | 19:18 |
| doug-fish | :-) that's quite a qualification | 19:18 |
| david-lyle | well all we had was nails | 19:18 |
| robcresswell | Yeah I think the number of people that adequately understand the intent of tagging may be roughly (TC + 5) :p | 19:19 |
| david-lyle | so we nailed everything | 19:19 |
| doug-fish | which is funny, because I think we might be screwed | 19:19 |
| robcresswell | I feel like I'm in an old Bond movie. These puns. | 19:19 |
| doug-fish | (not really - I just thought it sounded funny) | 19:19 |
| david-lyle | doug-fish: now you're seeing the larger picture | 19:19 |
| robcresswell | david-lyle: There's a larger picture? | 19:20 |
| doug-fish | you know, the part where we are all screwed | 19:20 |
| robcresswell | I thought we were all just doing our own thing :p | 19:20 |
| david-lyle | robcresswell: that we're screwed, yes | 19:20 |
| robcresswell | haha | 19:20 |
| robcresswell | david-lyle: How goes the release patches? I was following d_o_a earlier | 19:20 |
| david-lyle | fixed that one | 19:21 |
| david-lyle | still working on doing the horizon one, was tracking where we were and if it made sense to go now or in a bit | 19:21 |
| robcresswell | Sure | 19:21 |
| robcresswell | are there any blueprints in the gate? | 19:22 |
| david-lyle | doug-fish: https://github.com/openstack/governance/tree/master/reference/tags is probably the more interesting read | 19:22 |
| doug-fish | david-lyle: cool, thx! | 19:23 |
| *** jtomasek_ has joined #openstack-horizon | 19:24 | |
| david-lyle | checking, but my zuul page is not happy | 19:24 |
| david-lyle | 2 minor patches about to merge | 19:25 |
| david-lyle | after that, I'll just release | 19:25 |
| robcresswell | Cool. What did you want to do about the Angular LI? | 19:25 |
| david-lyle | we can merge that before RC-1 | 19:25 |
| tsufiev | Is there a chance we'll have default memcached support in M? | 19:26 |
| robcresswell | Sounds good | 19:26 |
| robcresswell | tsufiev: award for worst timing goes to... | 19:26 |
| tsufiev | :) | 19:26 |
| *** aortega has quit IRC | 19:27 | |
| david-lyle | tsufiev: no | 19:27 |
| tsufiev | I had to ask it, otherwise i would have forgotten to ask again | 19:27 |
| *** aortega has joined #openstack-horizon | 19:27 | |
| tsufiev | This memcached thing is as stubborn as keystone pagination :/ | 19:28 |
| tsufiev | david-lyle: yep, that was an expected answer given the circumstances | 19:28 |
| * tsufiev was hoping for a miracle | 19:28 | |
| *** SimonChung has joined #openstack-horizon | 19:34 | |
| mrunge | tsufiev, why do you need memcached support? | 19:35 |
| *** aortega has quit IRC | 19:35 | |
| *** ducttape_ has quit IRC | 19:35 | |
| david-lyle | all tests passed with new client version | 19:36 |
| * david-lyle stands amazed | 19:36 | |
| mrunge | tsufiev, I mean, redis has everything, what I saw you or your colleagues implemented | 19:36 |
| mrunge | like timeouts | 19:36 |
| mrunge | and django-redis works out of the box with horizon | 19:37 |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Zanata https://review.openstack.org/287609 | 19:39 |
| openstackgerrit | Merged openstack/horizon: Fixing timezone awareness https://review.openstack.org/272617 | 19:40 |
| david-lyle | there we go | 19:40 |
| *** aortega has joined #openstack-horizon | 19:40 | |
| *** Mounica has quit IRC | 19:41 | |
| tsufiev | mrunge: I was hoping to push our upstream fix for memcached to upstream, but that requires having memcached there by default | 19:45 |
| tsufiev | The reasoning was to reduce upstream/downstream delta | 19:45 |
| mrunge | yes, I understand that | 19:45 |
| mrunge | my reasoning for tending to redis is, it's already included in the stack | 19:46 |
| mrunge | as ceilometer requires it | 19:46 |
| mrunge | it's even default in devstack | 19:46 |
| mrunge | thus I would try to switch to django_redis | 19:46 |
| mrunge | anyways: enable a cache by default | 19:47 |
| mrunge | but this is nothing we need to merge in m-3 | 19:47 |
| *** deray has quit IRC | 19:48 | |
| *** exploreshaifali has quit IRC | 19:48 | |
| mrunge | oh, btw, if one has a little time: https://review.openstack.org/#/c/278311/3 | 19:50 |
| *** Mounica has joined #openstack-horizon | 19:51 | |
| *** aortega has quit IRC | 19:51 | |
| *** aortega has joined #openstack-horizon | 19:52 | |
| *** hurgleburgler has quit IRC | 19:53 | |
| *** vgridnev has quit IRC | 19:53 | |
| *** vgridnev has joined #openstack-horizon | 19:56 | |
| *** jtomasek_ has quit IRC | 19:58 | |
| mrunge | :q | 19:59 |
| *** ducttape_ has joined #openstack-horizon | 20:00 | |
| *** aortega has quit IRC | 20:05 | |
| *** tosky has joined #openstack-horizon | 20:05 | |
| *** aortega has joined #openstack-horizon | 20:06 | |
| *** ankurgupta has joined #openstack-horizon | 20:06 | |
| tsufiev | mrunge: thanks for suggestion, perhaps we need to push this forward in N. I'd be happy to use django-redis if upstream does so :) | 20:07 |
| mrunge | tsufiev, I deally like the attempt to upstream downstream features/solutions etc | 20:08 |
| mrunge | let's see, what we can achieve in N | 20:08 |
| *** Mounica has quit IRC | 20:09 | |
| doug-fish | a launchpad bug can have only one attachment? | 20:10 |
| *** Ephur_ has quit IRC | 20:10 | |
| doug-fish | but I have so much to share. | 20:11 |
| *** SimonChung has quit IRC | 20:15 | |
| r1chardj0n3s | morning | 20:17 |
| *** ankurgupta has left #openstack-horizon | 20:17 | |
| doug-fish | hi r1chardj0n3s | 20:18 |
| doug-fish | r1chardj0n3s: are Australian translations displayed correctly on angular panels? | 20:19 |
| doug-fish | I'd check myself, but I don't speak Australian. | 20:19 |
| r1chardj0n3s | doug-fish: they're bloody beaut mate | 20:19 |
| doug-fish | lol | 20:19 |
| doug-fish | I have no idea what you just said | 20:19 |
| r1chardj0n3s | oh, so the Brits are upset because they can't read the Australian translation of LI or something? | 20:22 |
| *** TravT has joined #openstack-horizon | 20:22 | |
| *** ybathia has quit IRC | 20:23 | |
| *** vijendar has quit IRC | 20:27 | |
| openstackgerrit | Justin Pomeroy proposed openstack/horizon: Enforce limits on metadata tree items https://review.openstack.org/209680 | 20:27 |
| doug-fish | r1chardj0n3s: the brits are upset because of their fondness for extraneous "U"s. Flavour. | 20:27 |
| doug-fish | I was just curious if the same bug affected Australian | 20:28 |
| r1chardj0n3s | we're used to people dropping the U :-) | 20:28 |
| *** kzaitsev_mb has joined #openstack-horizon | 20:29 | |
| *** TravT has quit IRC | 20:31 | |
| *** e0ne has joined #openstack-horizon | 20:32 | |
| sjmc7 | what are we upset about now? | 20:32 |
| doug-fish | https://bugs.launchpad.net/horizon/+bug/1552867 | 20:33 |
| openstack | Launchpad bug 1552867 in OpenStack Dashboard (Horizon) "British English translations don't appear to work in Angular Launch Instance." [Undecided,Confirmed] | 20:33 |
| sjmc7 | i say! | 20:33 |
| sjmc7 | bad show, old bean | 20:33 |
| mrunge | do other translations work at all? | 20:33 |
| *** tyr has joined #openstack-horizon | 20:33 | |
| doug-fish | yep | 20:33 |
| mrunge | I mean, I switched to german, but still see english | 20:34 |
| *** tyr has quit IRC | 20:34 | |
| doug-fish | hmm | 20:34 |
| mrunge | although settings states to be in german | 20:34 |
| sjmc7 | mrunge: did you switch horizon or your browser? | 20:34 |
| mrunge | the only German words I see are on login page | 20:34 |
| doug-fish | I'm almost certain I saw it translated before | 20:34 |
| doug-fish | how strange | 20:34 |
| doug-fish | but that makes it a simpler bug | 20:34 |
| doug-fish | it's just plain broken. | 20:35 |
| sjmc7 | :D | 20:35 |
| mrunge | I just checked out robcresswells make angular li default | 20:35 |
| doug-fish | I assume you see German elsewhere in your UI - you have done compilemessages? | 20:35 |
| mrunge | nope | 20:36 |
| *** TravT has joined #openstack-horizon | 20:36 | |
| doug-fish | well that won't work | 20:36 |
| doug-fish | ./run_tests.sh --compilemessages | 20:36 |
| mrunge | heh, that explains it | 20:36 |
| doug-fish | and restart your dev server | 20:36 |
| doug-fish | well, maybe | 20:36 |
| *** Fin1te has quit IRC | 20:37 | |
| doug-fish | I actually checked zh-cn and zh-tw to make sure they looked different from each other. | 20:37 |
| doug-fish | they do | 20:37 |
| doug-fish | and they didn't look like English | 20:37 |
| mrunge | let me check again | 20:38 |
| doug-fish | yes, please. Would be good info. | 20:38 |
| robcresswell | sjmc7: Its outrage | 20:38 |
| robcresswell | Flavour is spelt wrong | 20:38 |
| robcresswell | and Router is pronounced wrong | 20:38 |
| doug-fish | lol | 20:38 |
| mrunge | doug-fish, ok, I see something like German words. | 20:38 |
| doug-fish | that's not entirely reassuring ... | 20:39 |
| mrunge | take it as a yes, it's working | 20:39 |
| robcresswell | something "like" German? :p | 20:39 |
| itxaka | log errors should always be in british EN, that would make reading them muhc more nicer | 20:39 |
| sjmc7 | :D | 20:39 |
| itxaka | "Mysql has gone mental" | 20:39 |
| *** Mounica has joined #openstack-horizon | 20:39 | |
| sjmc7 | you mean cockney EN | 20:39 |
| robcresswell | Admin panel becomes Gov'ner Panel. | 20:40 |
| robcresswell | admin dashboard*, even. | 20:40 |
| *** SimonChung has joined #openstack-horizon | 20:41 | |
| *** itxaka has quit IRC | 20:42 | |
| openstackgerrit | Matt Wood proposed openstack/horizon: Hamburger navigation now sits above containers https://review.openstack.org/288117 | 20:42 |
| *** SimonChung has quit IRC | 20:44 | |
| *** SimonChung has joined #openstack-horizon | 20:44 | |
| *** ZZelle_ has joined #openstack-horizon | 20:46 | |
| *** piet has quit IRC | 20:47 | |
| *** xenogear has quit IRC | 20:48 | |
| *** doug-fis_ has joined #openstack-horizon | 20:49 | |
| *** doug-fish has quit IRC | 20:50 | |
| *** tqtran has joined #openstack-horizon | 20:50 | |
| *** xenogear has joined #openstack-horizon | 20:50 | |
| *** e0ne has quit IRC | 20:54 | |
| *** itisha has joined #openstack-horizon | 20:55 | |
| *** gyee has joined #openstack-horizon | 20:55 | |
| *** Mounica has quit IRC | 20:57 | |
| *** vijendar has joined #openstack-horizon | 20:59 | |
| *** e0ne has joined #openstack-horizon | 21:00 | |
| *** lblanchard has quit IRC | 21:01 | |
| david-lyle | we have a django_openstack_auth 2.2.0 release and M-3 has been tagged | 21:03 |
| david-lyle | enjoy | 21:03 |
| *** david-lyle changes topic to "OpenStack Horizon -- M-3 in the taillights" | 21:05 | |
| mrunge | congrats david-lyle | 21:05 |
| doug-fis_ | :-) hooray | 21:05 |
| david-lyle | now let's fix all the things | 21:05 |
| doug-fis_ | robcresswell: you mentioned there were some recently merged style updates that might impact neutron-lbaas-dashboard - I see now that there are issues | 21:08 |
| doug-fis_ | you have suggestions on how to fix? | 21:08 |
| doug-fis_ | even the table isn't really laid out right any more | 21:09 |
| robcresswell | doug-fis_: Its just HTML fixes (unless you guys are carrying custom CSS too) | 21:09 |
| doug-fis_ | I think we have none of that | 21:09 |
| robcresswell | I can look at it on Monday or Tuesday if you like. I intend to check out Magnum UI too | 21:09 |
| doug-fis_ | cool - sounds good, thanks! | 21:09 |
| robcresswell | np. Need to spend tomorrow looking at django and vpn stuff. | 21:10 |
| doug-fis_ | if we aren't careful jpomeroy might fix it before then anyway. | 21:10 |
| *** donu7 has quit IRC | 21:10 | |
| david-lyle | don't make jpomeroy angry | 21:10 |
| robcresswell | Ha, up to you guys :) | 21:10 |
| *** weezS has joined #openstack-horizon | 21:10 | |
| jpomeroy | stop breaking all the things! | 21:11 |
| robcresswell | I can't do that I'm afraid | 21:11 |
| jpomeroy | my horizon is a few days old, i'll need to take a look at what changed | 21:12 |
| doug-fis_ | it's a disruptive change | 21:12 |
| jpomeroy | we have very little custom css, mostly to work around some small issues | 21:12 |
| doug-fis_ | I think the create wizard doensn't work at all | 21:13 |
| robcresswell | \o/ | 21:13 |
| doug-fis_ | the pool members can't be added | 21:13 |
| jpomeroy | bah | 21:13 |
| robcresswell | I think I made him angry | 21:14 |
| doug-fis_ | that's a quite custom behavior. I'm not too surprised it got broken. | 21:14 |
| jpomeroy | no worries i just need more coffee =] | 21:14 |
| *** e0ne has quit IRC | 21:17 | |
| *** neelashah has quit IRC | 21:17 | |
| *** e0ne has joined #openstack-horizon | 21:17 | |
| weezS | hello | 21:18 |
| david-lyle | hello | 21:21 |
| david-lyle | was waiting for the rest ;-) | 21:21 |
| weezS | hi guys, i have a question, what should i do if i found a bug in the integration test for the stable/liberty release. and for the master release its fixed, | 21:23 |
| david-lyle | cherry-pick the fix to stable/liberty | 21:23 |
| *** pauloewerton has quit IRC | 21:24 | |
| david-lyle | in particular the patch that fixed it | 21:24 |
| *** jprovazn has quit IRC | 21:25 | |
| weezS | got it | 21:26 |
| weezS | tks david-lyle | 21:27 |
| david-lyle | looking for the docs | 21:27 |
| *** e0ne has quit IRC | 21:28 | |
| david-lyle | weezS: http://docs.openstack.org/project-team-guide/stable-branches.html#proposing-fixes | 21:29 |
| weezS | got it, tks | 21:29 |
| *** tqtran has quit IRC | 21:31 | |
| *** xinwu has joined #openstack-horizon | 21:35 | |
| *** vgridnev has quit IRC | 21:36 | |
| *** e0ne has joined #openstack-horizon | 21:37 | |
| *** vijendar has quit IRC | 21:38 | |
| *** ybathia has joined #openstack-horizon | 21:40 | |
| *** saksham_ has joined #openstack-horizon | 21:40 | |
| *** TravT has quit IRC | 21:44 | |
| *** rcernin has quit IRC | 21:45 | |
| *** Mounica has joined #openstack-horizon | 21:46 | |
| *** neelashah has joined #openstack-horizon | 21:46 | |
| *** jtomasek_ has joined #openstack-horizon | 21:50 | |
| *** vijendar has joined #openstack-horizon | 21:59 | |
| *** Mounica has quit IRC | 22:00 | |
| *** Fin1te has joined #openstack-horizon | 22:01 | |
| *** SimonChung has quit IRC | 22:01 | |
| *** Mounica has joined #openstack-horizon | 22:03 | |
| *** vijendar has quit IRC | 22:03 | |
| *** amotoki has joined #openstack-horizon | 22:05 | |
| *** Ephur has joined #openstack-horizon | 22:06 | |
| *** kzaitsev_mb has quit IRC | 22:07 | |
| *** petertr7 is now known as petertr7_away | 22:07 | |
| *** kzaitsev_mb has joined #openstack-horizon | 22:09 | |
| *** tyr has joined #openstack-horizon | 22:10 | |
| *** tyr has quit IRC | 22:10 | |
| *** shu-mutou-OFF has quit IRC | 22:10 | |
| *** vijendar has joined #openstack-horizon | 22:11 | |
| *** jtomasek_ has quit IRC | 22:11 | |
| *** TravT has joined #openstack-horizon | 22:13 | |
| *** jtomasek has quit IRC | 22:19 | |
| robcresswell | david-lyle: What've we got in the way of FFEs? | 22:20 |
| robcresswell | It sounds like very little | 22:20 |
| *** knikolla has quit IRC | 22:20 | |
| david-lyle | robcresswell: I have a few I'd consider | 22:21 |
| robcresswell | h'okay | 22:21 |
| *** matt-borland has quit IRC | 22:22 | |
| david-lyle | but that's for tomorrow :) | 22:22 |
| *** teddu has joined #openstack-horizon | 22:23 | |
| teddu | Hi there, does Horizon support project admins? | 22:23 |
| david-lyle | teddu: funny you should ask | 22:24 |
| david-lyle | that's a possible FFE | 22:24 |
| david-lyle | not without a patch at the moment | 22:24 |
| david-lyle | err, wait, project admin? | 22:24 |
| teddu | yes, project admin can do adminstrative work for others in the same project | 22:25 |
| teddu | not a super admin who can see every other project | 22:25 |
| david-lyle | what admin work? | 22:25 |
| teddu | create users, assign quotas | 22:26 |
| r1chardj0n3s | . | 22:26 |
| r1chardj0n3s | right, anything broken? :-) | 22:26 |
| david-lyle | https://review.openstack.org/#/c/148082/108 is a patch to allow domain admins to do that | 22:26 |
| teddu | assign project resources to the users in the project | 22:26 |
| david-lyle | depending on policy it might work for project admin | 22:27 |
| david-lyle | hmm | 22:27 |
| *** piet has joined #openstack-horizon | 22:28 | |
| teddu | i see | 22:28 |
| david-lyle | project admin has not really been a use case we've been targeting | 22:29 |
| david-lyle | you might check that patch and see if it's flexible enough for your needs | 22:30 |
| david-lyle | you will have to edit the policy files in keystone and horizon | 22:30 |
| *** kzaitsev_mb has quit IRC | 22:30 | |
| teddu | thx, i'll check that out | 22:30 |
| *** vijendar has quit IRC | 22:32 | |
| openstackgerrit | Marcellin Fom Tchassem proposed openstack/horizon: Fixed error due to a space inserted at the end of the instance name https://review.openstack.org/288162 | 22:32 |
| *** piet has quit IRC | 22:35 | |
| *** e0ne has quit IRC | 22:35 | |
| *** absubram has quit IRC | 22:41 | |
| *** jtriley has quit IRC | 22:42 | |
| *** donu7 has joined #openstack-horizon | 22:43 | |
| *** Mounica has quit IRC | 22:46 | |
| *** ducttape_ has quit IRC | 22:47 | |
| doug-fis_ | robcresswell: are you still awake? | 22:53 |
| doug-fis_ | I'm pretty sure the only javascript English translations we will display are American English. No British English, no Australian English. | 22:54 |
| doug-fis_ | It looks like a Django problem to me. Likely a one line fix. | 22:55 |
| doug-fis_ | But I can't contribute to Django. | 22:55 |
| doug-fis_ | If anyone wants to, this would be a pretty easy fix I think: https://code.djangoproject.com/ticket/26319#ticket | 22:55 |
| openstack | Django bug 26319 in Uncategorized "British English can't be returned from the javascript_catalog" [Normal,New] - Assigned to Unknown | 22:55 |
| *** mpavlase has joined #openstack-horizon | 22:57 | |
| david-lyle | doug-fis_: isn't the use of 'en' throughout going to be problematic? | 22:59 |
| *** piet has joined #openstack-horizon | 22:59 | |
| doug-fis_ | david-lyle: There's probably an issue if the default language isn't en, but that's not the case for us | 22:59 |
| david-lyle | doug-fis_: right | 23:00 |
| doug-fis_ | our original strings are en | 23:00 |
| david-lyle | I can take a swag at it | 23:00 |
| doug-fis_ | cool | 23:00 |
| david-lyle | corporate stuff? | 23:00 |
| *** Fin1te has quit IRC | 23:00 | |
| doug-fis_ | yes | 23:00 |
| david-lyle | ah yeah, it will load from another default lower | 23:00 |
| doug-fis_ | I could get approval, but it would probably take a month or 2 | 23:01 |
| david-lyle | I'm not much for approvals | 23:01 |
| david-lyle | :) | 23:02 |
| doug-fis_ | david-lyle is out of control! | 23:02 |
| david-lyle | I may just not care enought | 23:03 |
| david-lyle | so you think it should be an equality rather than a startswith? | 23:03 |
| doug-fis_ | yes | 23:03 |
| david-lyle | seems right | 23:04 |
| doug-fis_ | actually - give me 5 mins | 23:04 |
| doug-fis_ | I might have coded it up | 23:04 |
| doug-fis_ | and might be testing it out | 23:04 |
| *** hurgleburgler has joined #openstack-horizon | 23:06 | |
| openstackgerrit | Merged openstack/horizon: Material Design: New LI Tweaks https://review.openstack.org/287531 | 23:06 |
| doug-fis_ | david-lyle: yes, equality check solves the issue | 23:06 |
| david-lyle | ok pulling the code now | 23:06 |
| doug-fis_ | great. Thanks! | 23:06 |
| *** Mounica has joined #openstack-horizon | 23:08 | |
| r1chardj0n3s | I have some friends in Django project, and Australians even, I could poke them? | 23:08 |
| *** ybathia has quit IRC | 23:08 | |
| david-lyle | maybe they can review? not sure review sequence in django | 23:10 |
| r1chardj0n3s | yeah, I'm not sure either | 23:10 |
| *** amotoki has quit IRC | 23:16 | |
| *** gariveradlt has joined #openstack-horizon | 23:16 | |
| openstackgerrit | Matt Wood proposed openstack/horizon: local_settings needs 2.76% more ',' and an '_' https://review.openstack.org/288172 | 23:20 |
| *** kzaitsev_mb has joined #openstack-horizon | 23:20 | |
| david-lyle | doug-fis_: I suppose then you'll want to backport to 1.8? | 23:23 |
| *** neelashah has quit IRC | 23:24 | |
| doug-fis_ | *shrug* it's actually not critical to me. | 23:24 |
| doug-fis_ | I speak American. | 23:24 |
| doug-fis_ | I don't have a mandate to support en-gb or en-au yet | 23:24 |
| david-lyle | I'll try 1.9 first | 23:25 |
| david-lyle | LTS _might_ be harder | 23:25 |
| TravT | if one to were judge others by their IRC typing abilities, I'm not sure that i could claim that I speak any language fluently. | 23:26 |
| doug-fis_ | :-) | 23:26 |
| *** tqtran has joined #openstack-horizon | 23:30 | |
| *** leitan has quit IRC | 23:31 | |
| r1chardj0n3s | en-gb and en-au are really pretty low-priority translations | 23:35 |
| r1chardj0n3s | we're used to americans and their weird spelling | 23:36 |
| TravT | yeah, we americans also agree on that priority | 23:36 |
| TravT | :P | 23:36 |
| r1chardj0n3s | :-) | 23:36 |
| *** itisha has quit IRC | 23:39 | |
| *** knikolla has joined #openstack-horizon | 23:44 | |
| *** gariveradlt has quit IRC | 23:46 | |
| *** mpavlase has quit IRC | 23:46 | |
| *** ybathia has joined #openstack-horizon | 23:47 | |
| *** Mounica has quit IRC | 23:49 | |
| *** knikolla has quit IRC | 23:51 | |
| david-lyle | doug-fis_: django tests check for that behaviour | 23:51 |
| david-lyle | looking | 23:51 |
| doug-fis_ | david-lyle: are you saying that they have tests to ensure the wrong behavior? | 23:51 |
| david-lyle | well the test fails because I changed the code | 23:52 |
| david-lyle | have to dig into it more | 23:52 |
| doug-fis_ | lovely | 23:52 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Fix test cases that have no expectations https://review.openstack.org/284857 | 23:53 |
| david-lyle | I think the fix is larger | 23:56 |
| david-lyle | not entirely sure I'm biting that off | 23:56 |
| david-lyle | will look a little longer, but the odd behavior around 'en' is expected | 23:57 |
| doug-fis_ | strange | 23:57 |
| doug-fis_ | I wonder why they think that's a good idea? | 23:57 |
| david-lyle | set the base lang to 'fr' or something else and validate | 23:57 |
| doug-fis_ | oh | 23:57 |
| doug-fis_ | that probably would have been a good idea | 23:57 |
| david-lyle | it's a short cut I think | 23:57 |
| TravT | so how many people would be angry if I press the +A on the LI default patch? | 23:57 |
| *** ybathia has quit IRC | 23:58 | |
| * TravT sucked the air out of the room | 23:58 | |
| doug-fis_ | I'd be happy. It would be progress AND would could blame you! | 23:58 |
| david-lyle | I think we're ok on it. I would like to see a freeze note, but that can follow on | 23:58 |
| david-lyle | I can push it too | 23:58 |
| david-lyle | I've reviewed it | 23:59 |
| TravT | robcresswell has this note: https://review.openstack.org/#/c/287710/8/releasenotes/notes/bp-enable-angular-launch-instance-897f7bb227711c86.yaml | 23:59 |
| TravT | is that what you mean? | 23:59 |
| doug-fis_ | david-lyle: French works for me in Horizon even with that patch ... | 23:59 |
| david-lyle | pulled the trigger | 23:59 |
| doug-fis_ | was it supposed to be broken? | 23:59 |
| TravT | \o/ | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
