| openstackgerrit | Diana Whitten proposed openstack/horizon: Context Picker should inherit BS dropdown styles https://review.openstack.org/271858 | 00:04 |
|---|---|---|
| openstackgerrit | Merged openstack/horizon: Remove all pre-Django 1.8 workarounds https://review.openstack.org/269123 | 00:14 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/268445 | 00:19 |
| *** kzaitsev_mb has joined #openstack-horizon | 00:20 | |
| *** kzaitsev_mb has quit IRC | 00:25 | |
| *** rcernin has quit IRC | 00:30 | |
| *** btully has quit IRC | 00:30 | |
| *** btully has joined #openstack-horizon | 00:30 | |
| *** dslev has joined #openstack-horizon | 00:34 | |
| *** Drago has joined #openstack-horizon | 00:41 | |
| *** Drago has quit IRC | 00:41 | |
| *** Drago has joined #openstack-horizon | 00:41 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Logo on non-standard themes should be centered https://review.openstack.org/271859 | 00:47 |
| *** btully has quit IRC | 00:47 | |
| *** btully has joined #openstack-horizon | 00:49 | |
| *** lhcheng has quit IRC | 00:56 | |
| *** dslev has quit IRC | 01:05 | |
| *** btully has quit IRC | 01:08 | |
| *** btully has joined #openstack-horizon | 01:08 | |
| *** lhcheng has joined #openstack-horizon | 01:15 | |
| *** btully has quit IRC | 01:20 | |
| *** btully has joined #openstack-horizon | 01:20 | |
| *** kzaitsev_mb has joined #openstack-horizon | 01:22 | |
| *** hurgleburgler1 has joined #openstack-horizon | 01:23 | |
| *** hurgleburgler has quit IRC | 01:24 | |
| *** pat has joined #openstack-horizon | 01:29 | |
| *** kzaitsev_mb has quit IRC | 01:30 | |
| *** amotoki has joined #openstack-horizon | 01:39 | |
| *** hurgleburgler has joined #openstack-horizon | 01:43 | |
| *** hurgleburgler1 has quit IRC | 01:43 | |
| *** boltR has quit IRC | 01:45 | |
| *** boltR has joined #openstack-horizon | 01:46 | |
| *** Drago has quit IRC | 01:47 | |
| *** hurgleburgler has quit IRC | 01:48 | |
| *** hurgleburgler has joined #openstack-horizon | 01:48 | |
| *** btully has quit IRC | 01:51 | |
| *** hurgleburgler has quit IRC | 01:52 | |
| *** hurgleburgler has joined #openstack-horizon | 01:52 | |
| *** btully has joined #openstack-horizon | 01:53 | |
| *** hurgleburgler1 has joined #openstack-horizon | 01:55 | |
| *** hurgleburgler has quit IRC | 01:55 | |
| *** hurgleburgler has joined #openstack-horizon | 01:58 | |
| *** hurgleburgler1 has quit IRC | 01:58 | |
| *** Liuqing has joined #openstack-horizon | 01:59 | |
| *** Ephur has quit IRC | 01:59 | |
| *** hurgleburgler1 has joined #openstack-horizon | 02:00 | |
| *** hurgleburgler has quit IRC | 02:00 | |
| *** hurgleburgler1 has quit IRC | 02:03 | |
| *** hurgleburgler has joined #openstack-horizon | 02:03 | |
| *** hurgleburgler1 has joined #openstack-horizon | 02:06 | |
| *** hurgleburgler has quit IRC | 02:06 | |
| *** yamamoto has joined #openstack-horizon | 02:20 | |
| *** zhurong has joined #openstack-horizon | 02:23 | |
| *** kzaitsev_mb has joined #openstack-horizon | 02:28 | |
| *** yamamoto has quit IRC | 02:31 | |
| *** btully has quit IRC | 02:41 | |
| *** btully has joined #openstack-horizon | 02:41 | |
| *** zhurong has quit IRC | 02:49 | |
| *** zhurong has joined #openstack-horizon | 02:50 | |
| *** kzaitsev_mb has quit IRC | 02:54 | |
| *** amotoki has quit IRC | 03:10 | |
| *** btully has quit IRC | 03:11 | |
| *** btully has joined #openstack-horizon | 03:12 | |
| *** _lnk_ has joined #openstack-horizon | 03:16 | |
| *** hurgleburgler1 has quit IRC | 03:17 | |
| *** hurgleburgler has joined #openstack-horizon | 03:17 | |
| *** zhurong has quit IRC | 03:19 | |
| *** zhurong has joined #openstack-horizon | 03:20 | |
| *** amotoki has joined #openstack-horizon | 03:21 | |
| *** chestack has joined #openstack-horizon | 03:21 | |
| *** _lnk_ has quit IRC | 03:23 | |
| *** yamamoto_ has joined #openstack-horizon | 03:23 | |
| *** btully has quit IRC | 03:25 | |
| *** btully has joined #openstack-horizon | 03:25 | |
| *** hurgleburgler has quit IRC | 03:28 | |
| *** hurgleburgler has joined #openstack-horizon | 03:28 | |
| *** amotoki has quit IRC | 03:30 | |
| *** hurgleburgler1 has joined #openstack-horizon | 03:31 | |
| *** hurgleburgler has quit IRC | 03:31 | |
| openstackgerrit | LIU Yulong proposed openstack/horizon: Restrict user private network cidr input https://review.openstack.org/135877 | 03:32 |
| *** amotoki has joined #openstack-horizon | 03:35 | |
| *** hurgleburgler has joined #openstack-horizon | 03:47 | |
| *** hurgleburgler1 has quit IRC | 03:48 | |
| *** hurgleburgler1 has joined #openstack-horizon | 03:50 | |
| *** hurgleburgler has quit IRC | 03:50 | |
| *** kzaitsev_mb has joined #openstack-horizon | 03:51 | |
| *** hurgleburgler1 has quit IRC | 03:52 | |
| *** hurgleburgler has joined #openstack-horizon | 03:52 | |
| *** kzaitsev_mb has quit IRC | 03:56 | |
| *** alexvictorchan has joined #openstack-horizon | 03:56 | |
| *** _lnk_ has joined #openstack-horizon | 03:59 | |
| *** amotoki has quit IRC | 04:01 | |
| *** dslev has joined #openstack-horizon | 04:01 | |
| *** dslev has quit IRC | 04:06 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Context selection delimiter should use font https://review.openstack.org/271887 | 04:12 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Branding: Nav icon spacing should use css https://review.openstack.org/271888 | 04:12 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Branding: Context selector delim should be font https://review.openstack.org/271887 | 04:13 |
| *** julim has quit IRC | 04:14 | |
| *** neelashah has joined #openstack-horizon | 04:14 | |
| *** amotoki has joined #openstack-horizon | 04:18 | |
| *** zhurong has quit IRC | 04:21 | |
| *** zhurong has joined #openstack-horizon | 04:22 | |
| *** _lnk_ has quit IRC | 04:24 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Removing container ID element https://review.openstack.org/260241 | 04:25 |
| *** zhurong has quit IRC | 04:29 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Material Theme: Buttons need border radius https://review.openstack.org/260237 | 04:30 |
| *** zhurong has joined #openstack-horizon | 04:30 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon Checkboxes are now themeable. https://review.openstack.org/252161 | 04:34 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Branding: Context selector delim should be icon https://review.openstack.org/271887 | 04:37 |
| *** _lnk_ has joined #openstack-horizon | 04:40 | |
| *** Liuqing has quit IRC | 04:42 | |
| *** Liuqing has joined #openstack-horizon | 04:43 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Clean up horizon.scss - _tables.scss https://review.openstack.org/260640 | 04:50 |
| *** chlong has joined #openstack-horizon | 04:52 | |
| *** kzaitsev_mb has joined #openstack-horizon | 04:52 | |
| *** hurgleburgler has quit IRC | 04:54 | |
| *** lhcheng has quit IRC | 04:57 | |
| *** _lnk_ has quit IRC | 04:59 | |
| *** btully has quit IRC | 05:01 | |
| *** btully has joined #openstack-horizon | 05:03 | |
| *** sguduru has joined #openstack-horizon | 05:04 | |
| *** sguduru has quit IRC | 05:07 | |
| *** kzaitsev_mb has quit IRC | 05:10 | |
| *** Liuqing has quit IRC | 05:11 | |
| *** Liuqing has joined #openstack-horizon | 05:12 | |
| *** sguduru has joined #openstack-horizon | 05:13 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: WIP: Add ngSwift object actions https://review.openstack.org/270553 | 05:15 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add ngSwift containers and objects display https://review.openstack.org/259231 | 05:15 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add ngSwift Django Interface https://review.openstack.org/258769 | 05:15 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add Swift REST API https://review.openstack.org/256140 | 05:15 |
| openstackgerrit | Richard Jones proposed openstack/horizon: WIP: Add ngSwift container actions https://review.openstack.org/259236 | 05:15 |
| *** _lnk_ has joined #openstack-horizon | 05:18 | |
| *** neelashah1 has joined #openstack-horizon | 05:20 | |
| *** neelashah has quit IRC | 05:21 | |
| *** neelashah1 has quit IRC | 05:25 | |
| *** neelashah has joined #openstack-horizon | 05:25 | |
| *** neelashah has quit IRC | 05:28 | |
| *** vishwanathj has joined #openstack-horizon | 05:37 | |
| *** vishwanathj has quit IRC | 05:37 | |
| *** sguduru has quit IRC | 05:38 | |
| *** sguduru has joined #openstack-horizon | 05:40 | |
| *** fedexo has joined #openstack-horizon | 05:46 | |
| *** masco has joined #openstack-horizon | 05:46 | |
| openstackgerrit | Wang Bo proposed openstack/horizon: Ensure horizon configurations could be customized https://review.openstack.org/258833 | 05:51 |
| *** rcernin has joined #openstack-horizon | 05:55 | |
| *** kzaitsev_mb has joined #openstack-horizon | 06:07 | |
| *** Liuqing has quit IRC | 06:13 | |
| *** kzaitsev_mb has quit IRC | 06:13 | |
| *** Liuqing has joined #openstack-horizon | 06:14 | |
| *** _lnk_ has quit IRC | 06:20 | |
| *** Daisy has joined #openstack-horizon | 06:27 | |
| *** Daisy has quit IRC | 06:27 | |
| *** aortega has quit IRC | 06:27 | |
| *** chlong has quit IRC | 06:28 | |
| *** sguduru has quit IRC | 06:30 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Zanata https://review.openstack.org/271153 | 06:31 |
| *** jamielennox is now known as jamielennox|away | 06:31 | |
| *** jamielennox|away is now known as jamielennox | 06:33 | |
| *** pat has quit IRC | 06:34 | |
| *** _lnk_ has joined #openstack-horizon | 06:37 | |
| *** belmoreira has joined #openstack-horizon | 06:44 | |
| openstackgerrit | javeme proposed openstack/horizon: Use timedelta.total_seconds instead of calculating https://review.openstack.org/258375 | 06:44 |
| *** lhcheng has joined #openstack-horizon | 06:46 | |
| *** lhcheng has quit IRC | 06:50 | |
| *** sguduru has joined #openstack-horizon | 06:55 | |
| *** davidlenwell has quit IRC | 07:00 | |
| *** davidlenwell has joined #openstack-horizon | 07:02 | |
| *** chestack has quit IRC | 07:02 | |
| *** _lnk_ has quit IRC | 07:02 | |
| *** _lnk_ has joined #openstack-horizon | 07:03 | |
| *** _lnk_ has quit IRC | 07:08 | |
| *** amotoki_ has joined #openstack-horizon | 07:09 | |
| *** kzaitsev_mb has joined #openstack-horizon | 07:10 | |
| openstackgerrit | Wang Bo proposed openstack/horizon: Change number of horizon specific haking rule https://review.openstack.org/271912 | 07:13 |
| *** amotoki has quit IRC | 07:13 | |
| *** deray has joined #openstack-horizon | 07:15 | |
| *** fedexo has quit IRC | 07:17 | |
| *** Daisy has joined #openstack-horizon | 07:17 | |
| *** Daisy has quit IRC | 07:21 | |
| *** lhcheng has joined #openstack-horizon | 07:21 | |
| *** davidlenwell has quit IRC | 07:24 | |
| *** Liuqing has quit IRC | 07:26 | |
| *** davidlenwell has joined #openstack-horizon | 07:26 | |
| *** Liuqing has joined #openstack-horizon | 07:27 | |
| *** zhurong has quit IRC | 07:27 | |
| *** zhurong has joined #openstack-horizon | 07:28 | |
| *** vishwanathj_ has joined #openstack-horizon | 07:28 | |
| *** davidlenwell has quit IRC | 07:29 | |
| *** jtomasek has joined #openstack-horizon | 07:29 | |
| *** kzaitsev_mb has quit IRC | 07:33 | |
| *** davidlenwell has joined #openstack-horizon | 07:33 | |
| *** Daisy has joined #openstack-horizon | 07:33 | |
| *** sayan|think has joined #openstack-horizon | 07:35 | |
| *** sguduru has quit IRC | 07:37 | |
| *** Daisy has quit IRC | 07:38 | |
| *** Daisy has joined #openstack-horizon | 07:39 | |
| *** davidlenwell has quit IRC | 07:41 | |
| *** davidlenwell has joined #openstack-horizon | 07:45 | |
| *** ybathia has joined #openstack-horizon | 07:49 | |
| *** ybathia_ has joined #openstack-horizon | 07:50 | |
| *** ybathia has quit IRC | 07:55 | |
| *** ybathia_ is now known as ybathia | 07:55 | |
| *** amotoki_ is now known as amotoki | 07:56 | |
| *** kzaitsev_mb has joined #openstack-horizon | 07:59 | |
| *** zhurong has quit IRC | 08:00 | |
| *** zhurong has joined #openstack-horizon | 08:01 | |
| *** kzaitsev_mb has quit IRC | 08:03 | |
| *** reedip is now known as outofmemory | 08:07 | |
| *** sanjana has quit IRC | 08:09 | |
| *** Liuqing has quit IRC | 08:11 | |
| *** Liuqing has joined #openstack-horizon | 08:11 | |
| *** sguduru has joined #openstack-horizon | 08:13 | |
| *** rdopiera has joined #openstack-horizon | 08:14 | |
| *** sguduru has quit IRC | 08:17 | |
| *** amotoki has quit IRC | 08:21 | |
| *** ybathia has quit IRC | 08:23 | |
| *** sguduru has joined #openstack-horizon | 08:33 | |
| *** amotoki has joined #openstack-horizon | 08:40 | |
| *** aortega has joined #openstack-horizon | 08:44 | |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for create/delete Namespace inside "Metadata Definitions" https://review.openstack.org/268039 | 08:44 |
| *** Daisy has quit IRC | 08:47 | |
| *** amotoki has quit IRC | 08:49 | |
| *** Daisy has joined #openstack-horizon | 08:51 | |
| *** amotoki has joined #openstack-horizon | 08:52 | |
| *** amotoki has quit IRC | 08:55 | |
| *** Daisy has quit IRC | 08:58 | |
| *** liangbo has joined #openstack-horizon | 09:02 | |
| *** Daisy has joined #openstack-horizon | 09:03 | |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for create/delete Namespace inside "Metadata Definitions" https://review.openstack.org/268039 | 09:06 |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:06 | |
| *** amotoki has joined #openstack-horizon | 09:08 | |
| *** sguduru has quit IRC | 09:08 | |
| *** kzaitsev_mb has joined #openstack-horizon | 09:09 | |
| ^Gal^ | Hi, my patch failed on gate-horizon-dsvm-integration - I'm not sure why https://review.openstack.org/#/c/271771/ | 09:10 |
| *** itxaka has joined #openstack-horizon | 09:12 | |
| *** bapalm has quit IRC | 09:12 | |
| *** chestack has joined #openstack-horizon | 09:15 | |
| *** amotoki has quit IRC | 09:18 | |
| *** ygbo has joined #openstack-horizon | 09:21 | |
| *** amotoki has joined #openstack-horizon | 09:30 | |
| *** JeanBriceCombebi has quit IRC | 09:35 | |
| *** vishwanathj_ has quit IRC | 09:35 | |
| openstackgerrit | Merged openstack/horizon: Updated from global requirements https://review.openstack.org/268445 | 09:35 |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:37 | |
| *** Daisy has quit IRC | 09:37 | |
| *** liangbo has quit IRC | 09:42 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: [Django 1.9] Stop using django.utils.importlib https://review.openstack.org/268042 | 09:47 |
| *** Daisy has joined #openstack-horizon | 09:48 | |
| *** Liuqing has quit IRC | 09:56 | |
| *** vgridnev has joined #openstack-horizon | 09:56 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: [Django 1.9] Remove testserver from expected_url https://review.openstack.org/271850 | 09:57 |
| *** Liuqing has joined #openstack-horizon | 09:57 | |
| *** Liuqing has quit IRC | 09:57 | |
| openstackgerrit | Yury Tregubov proposed openstack/horizon: image create delete tests https://review.openstack.org/271249 | 10:12 |
| *** zhurong has quit IRC | 10:14 | |
| *** erlon has joined #openstack-horizon | 10:14 | |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for modification of Public and Protected fields for NameSpace on 'Metadata Definitions' page https://review.openstack.org/271995 | 10:18 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for create/delete image under Admin user https://review.openstack.org/265955 | 10:19 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for create/delete Namespace inside "Metadata Definitions" https://review.openstack.org/268039 | 10:19 |
| mrunge | sigh. has anyone seen the cinder.ClientException before? | 10:20 |
| mrunge | File "/home/mrunge/git/openstack/horizon/openstack_dashboard/usage/quotas.py", line 150, in _get_quota_data | 10:20 |
| openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for modification of Public and Protected fields for NameSpace on 'Metadata Definitions' page https://review.openstack.org/271995 | 10:20 |
| mrunge | AttributeError: 'module' object has no attribute 'ClientException' | 10:20 |
| itxaka | nice catch! | 10:22 |
| itxaka | https://github.com/openstack/horizon/commit/4994df59ce1c72d0bb0002ac0bf2be8dd514a88e | 10:22 |
| itxaka | introduced there | 10:23 |
| tsufiev | yeah, I think that was exact fix | 10:23 |
| tsufiev | itxaka, at the time fix was committed, it did his job | 10:23 |
| tsufiev | seems like Cinder folks reorganized their exceptions | 10:24 |
| itxaka | actually seems like we changed this? | 10:25 |
| itxaka | https://github.com/openstack/horizon/commit/dfeb362b95f2b481ff3231b4821d4a5e94fa2e89 | 10:25 |
| itxaka | changed the import names but not the exception? | 10:25 |
| tsufiev | Frode's commit was the second | 10:26 |
| itxaka | mmmh, seems to me that one is the issue | 10:28 |
| itxaka | as we are not importing 'ClientException' anymore into the cinder module | 10:29 |
| itxaka | thus the quota cant call cinder.ClientException | 10:29 |
| mrunge | but how could we miss this that long? | 10:29 |
| robcresswell | Is this in the tests? | 10:30 |
| robcresswell | As in, where is the error occuring? | 10:30 |
| mrunge | it must be a regression since January 14th | 10:30 |
| mrunge | robcresswell, I created a network or an instance | 10:30 |
| mrunge | hmm, wait | 10:31 |
| robcresswell | Wait so, the cinder folks moved some exceptions around? | 10:31 |
| robcresswell | In that case wouldnt amending the import path fix the bug | 10:32 |
| mrunge | robcresswell, itxaka just pointed out some patches, where cinder-ClientException was changed | 10:33 |
| mrunge | I believe, we stopped importing the exception at some point | 10:33 |
| itxaka | robcresswell, seems to be our issue, we changed and import and forgot to change the call for it | 10:33 |
| openstackgerrit | Alexandra Allakhverdieva proposed openstack/horizon: Added tests for check volumes management functionality https://review.openstack.org/237044 | 10:34 |
| itxaka | but indeed more of the issue is, how is this still working, why is it passing the tests, how can we not notice | 10:34 |
| robcresswell | The only usage of cinder.ClientException appears to be in quotas | 10:37 |
| *** bluex has quit IRC | 10:37 | |
| robcresswell | Sorry I lost my scrollback halfway through that, networkign got confused when I dropped from VPN | 10:38 |
| *** Daisy has quit IRC | 10:40 | |
| *** Daisy has joined #openstack-horizon | 10:41 | |
| mrunge | exactly itxaka | 10:41 |
| itxaka | the patch is really simple | 10:42 |
| itxaka | - except cinder.ClientException: | 10:42 |
| itxaka | + except cinder.cinder_exception.ClientException: | 10:42 |
| mrunge | go for it itxaka | 10:42 |
| itxaka | on it | 10:42 |
| mrunge | there should be enough cores to approve it | 10:42 |
| *** tosky has joined #openstack-horizon | 10:43 | |
| *** sanjana has joined #openstack-horizon | 10:43 | |
| itxaka | mrunge, how did you trigger the bug? | 10:44 |
| mrunge | I just launched an instance or tried to create a network | 10:44 |
| mrunge | I was reviewing the ports patches... | 10:44 |
| *** Daisy has quit IRC | 10:45 | |
| mrunge | launch instance triggers this issue for sure | 10:46 |
| robcresswell | itxaka: Needs regression test too. | 10:47 |
| *** Daisy has joined #openstack-horizon | 10:47 | |
| mrunge | tsufiev, are integration tests already covering launch instance? | 10:47 |
| tsufiev | mrunge, yes, there is one test case covering legacy Launch Instance | 10:49 |
| mrunge | tsufiev, interesting. with that cinderclientexception bug, it's not possible to launch an instance | 10:49 |
| tsufiev | but it doesn't expect to do any manipulations with networks, so if there is no network already preselected, it will fail | 10:49 |
| * tsufiev going to re-run the test locally on freshest master | 10:50 | |
| mrunge | tsufiev, should be broken since January 4th | 10:51 |
| mrunge | https://github.com/openstack/horizon/commit/dfeb362b95f2b481ff3231b4821d4a5e94fa2e89 | 10:51 |
| itxaka | weird because I cant get the error to come up | 10:51 |
| tsufiev | mrunge, yet Launch Instance succeeded for the recent merges of i9n refactoring patches | 10:51 |
| tsufiev | doesn't make sense to me :/ | 10:52 |
| mrunge | heh | 10:52 |
| itxaka | I see that its calling that method but AttributeError is not being fired | 10:52 |
| itxaka | o_o | 10:52 |
| itxaka | but calling cinder.ClientException from the python shell does raise it | 10:52 |
| itxaka | o_O | 10:52 |
| *** Daisy has quit IRC | 10:52 | |
| mrunge | this happens when launching an instance: http://paste.openstack.org/show/484850/ | 10:53 |
| *** Daisy has joined #openstack-horizon | 10:53 | |
| itxaka | If im seeing correctly, when I try tto launch an instance that method is never called | 10:54 |
| itxaka | ah, 2 different methods calling the CleintException, disregard that | 10:55 |
| tsufiev | mrunge, from what I see in code, whether AttributeError is happens or not depends on if some exception is being raised in try block wrapped with cinder.ClientException | 10:56 |
| *** bapalm has joined #openstack-horizon | 10:57 | |
| tsufiev | so, it's being raised in your case, but everything is quiet on gate, for example | 10:57 |
| mrunge | ack | 10:57 |
| *** Daisy has quit IRC | 10:58 | |
| mrunge | so, how would we regression test the fix then? | 10:58 |
| tsufiev | that kind of errors should be caught with unit tests, because integration tests usually test for positive scenarios | 10:58 |
| mrunge | tsufiev, in my local case here, launching an instance is not possible any more | 10:59 |
| itxaka | arent unit tests just mocking those calls? the quota calls? | 10:59 |
| mrunge | so, in my local view here, it should have been caught | 10:59 |
| tsufiev | itxaka, quota module UT coverage is just bad | 10:59 |
| mrunge | itxaka, they are mocking python-client.. calls | 11:00 |
| itxaka | ugh | 11:00 |
| robcresswell | https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/tests/quotas.py | 11:00 |
| itxaka | why not mock responses | 11:00 |
| itxaka | seems that we rely on those python-*client to work properly so we should be calling them directly instead I gues | 11:00 |
| itxaka | something simple like httpretty works wonders as you just hijack the socket module and the only thing you do its register urls and return responses, instead of moxing everything ¯\_(ツ)_/¯ | 11:05 |
| robcresswell | Feel free to rewrite all tests :) | 11:07 |
| tsufiev | itxaka, a lot of good things just lack a driving force behind them ;) | 11:07 |
| robcresswell | See you in O release :p | 11:07 |
| robcresswell | Yeah, there's a lot of things we *could* change | 11:08 |
| robcresswell | Most of the UT issues are just missing test cases | 11:08 |
| mrunge | uhm, didn't we talk about a stabilizing release? | 11:08 |
| robcresswell | Yeah, there's been a mailer thread on it IIRC | 11:08 |
| mrunge | yupp | 11:08 |
| itxaka | now talking about rewriting all tests and with tsufiev here, how would you feel if someone was rewriting the whole unit testing in something easier and less complicated like gherkin :D | 11:08 |
| itxaka | just asking for...uh...a friend | 11:09 |
| robcresswell | Depends what that really gains for you. As I said, the vast majority of tests are not really complex, the big issue is that they don't exist. | 11:09 |
| robcresswell | I don't know that rewriting functioning unit tests really adds much value to Horizon. | 11:10 |
| robcresswell | We just need moar :p | 11:10 |
| mrunge | in the past, we have seen so many regressions being introduced in horizon | 11:11 |
| robcresswell | Indeed. Best thing is just to run coverage reports and then fix missing areas. A lot around branches tend to get missed, like exceptions or else statements. | 11:12 |
| openstackgerrit | Alexandra Allakhverdieva proposed openstack/horizon: Added tests for check volumes management functionality https://review.openstack.org/237044 | 11:12 |
| *** yamamoto_ has quit IRC | 11:12 | |
| itxaka | I would not call classes that call 32 classes to create abstract objects of everything just to fill a simple field "not complex" to be honest | 11:12 |
| itxaka | integration tests suffer for what I call the "enterprise mentality" of doing everything as complex as possible just to cover 99.9% of the possible cases even if you are doing 3 simple tasks | 11:13 |
| itxaka | anyway, back to checking that bug :P | 11:13 |
| mrunge | uhm, silly question: did anyone filed a bug yet? | 11:23 |
| robcresswell | Not me | 11:23 |
| mrunge | me neither | 11:24 |
| mrunge | itxaka, ? | 11:24 |
| itxaka | yes | 11:24 |
| itxaka | https://bugs.launchpad.net/horizon/+bug/1537713 | 11:24 |
| openstack | Launchpad bug 1537713 in OpenStack Dashboard (Horizon) "AttributeError: 'module' object has no attribute 'ClientException'" [Undecided,New] - Assigned to Itxaka Serrano (itxakaserrano) | 11:24 |
| mrunge | awesome, thank you itxaka | 11:24 |
| itxaka | oh wow, so you can put whatever in the except block and python wont check it for errors | 11:25 |
| itxaka | didnt know that | 11:25 |
| mrunge | I thought it uses lazy evaluation | 11:26 |
| openstackgerrit | Sanjana proposed openstack/horizon: Fixing test cases https://review.openstack.org/271129 | 11:28 |
| *** kzaitsev_mb has quit IRC | 11:34 | |
| *** JeanBriceCombebi has quit IRC | 11:36 | |
| *** zhurong has joined #openstack-horizon | 11:48 | |
| *** Daisy has joined #openstack-horizon | 11:50 | |
| *** absubram has quit IRC | 11:55 | |
| *** yamamoto has joined #openstack-horizon | 11:58 | |
| *** yamamoto_ has joined #openstack-horizon | 11:59 | |
| *** kzaitsev_mb has joined #openstack-horizon | 12:00 | |
| *** yamamoto has quit IRC | 12:03 | |
| *** yamamoto_ has quit IRC | 12:17 | |
| *** NightKhaos has quit IRC | 12:22 | |
| *** yamamoto has joined #openstack-horizon | 12:26 | |
| openstackgerrit | Masco proposed openstack/horizon: Adding angular QoS panel in horizon https://review.openstack.org/247997 | 12:28 |
| *** NightKhaos has joined #openstack-horizon | 12:30 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Zanata https://review.openstack.org/271153 | 12:42 |
| openstackgerrit | Ekaterina Shutova proposed openstack/horizon: Test create/delete network from Admin tab https://review.openstack.org/267521 | 12:47 |
| *** ericksonsantos has quit IRC | 12:49 | |
| openstackgerrit | Ekaterina Shutova proposed openstack/horizon: Test create/delete network from Admin tab https://review.openstack.org/267521 | 12:50 |
| openstackgerrit | Alexandra Allakhverdieva proposed openstack/horizon: Added tests for check volumes management functionality https://review.openstack.org/237044 | 12:50 |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: fix ClientException call https://review.openstack.org/272077 | 12:53 |
| *** lhcheng has quit IRC | 12:53 | |
| *** chestack has quit IRC | 12:55 | |
| *** NightKhaos has quit IRC | 12:59 | |
| robcresswell | itxaka: Fix looks great! | 13:01 |
| *** NightKhaos has joined #openstack-horizon | 13:02 | |
| robcresswell | Just testing | 13:02 |
| itxaka | be sure to change the exceptions back to the older ones to test that indeed the tests fail ;) | 13:03 |
| *** yamamoto has quit IRC | 13:03 | |
| * robcresswell is unsure whether to feel patronised :p | 13:04 | |
| *** yamamoto has joined #openstack-horizon | 13:04 | |
| itxaka | :D | 13:05 |
| *** pauloewerton has joined #openstack-horizon | 13:05 | |
| *** vgridnev has quit IRC | 13:05 | |
| itxaka | never bad to be extra careful, especially with tests. Look at the PYTHOHASHSEED one :P | 13:06 |
| robcresswell | Yeah, I assumed that the jenkins tests would catch that | 13:06 |
| robcresswell | workflow only triggers the gate anyway; nothing will merge without both check and gate, so you'll always get 2 runs I believe. | 13:07 |
| *** yamamoto has quit IRC | 13:08 | |
| robcresswell | I like that we prefix every test with 'test_' | 13:08 |
| *** vgridnev has joined #openstack-horizon | 13:08 | |
| robcresswell | Just in case people didn't realise that a broken test is a test. | 13:08 |
| robcresswell | itxaka: Fix looks sensible to me. Thanks. | 13:09 |
| mrunge | itxaka, did I miss something with the copyrights header here? https://review.openstack.org/#/c/253573/9/openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/networkports/ports.controller.js | 13:09 |
| *** ducttape_ has joined #openstack-horizon | 13:09 | |
| mrunge | itxaka, I mean, if it's new code, I wouldn't expect to find HP copyright there? | 13:10 |
| itxaka | lmao, copy paste gone wrong | 13:10 |
| mrunge | ack, hold on. still going through, maybe I'll find something else | 13:10 |
| itxaka | ack | 13:11 |
| mrunge | itxaka, same here: https://review.openstack.org/#/c/253573/9/openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/networkports/ports.spec.js | 13:12 |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:13 | |
| openstackgerrit | Ekaterina Shutova proposed openstack/horizon: Added test edit network from Admin panel https://review.openstack.org/270161 | 13:14 |
| *** zhurong has quit IRC | 13:15 | |
| *** zhurong has joined #openstack-horizon | 13:15 | |
| *** yamamoto has joined #openstack-horizon | 13:17 | |
| *** amotoki has quit IRC | 13:19 | |
| robcresswell | mrunge: I see you're reviewing more angular now! | 13:25 |
| robcresswell | :D | 13:25 |
| mrunge | robcresswell, how can I prevent it? | 13:26 |
| mrunge | :P | 13:26 |
| robcresswell | haha | 13:26 |
| * mrunge donates robcresswell a pair of sunglasses | 13:26 | |
| *** ducttape_ has quit IRC | 13:26 | |
| *** Daisy has quit IRC | 13:44 | |
| *** Daisy has joined #openstack-horizon | 13:45 | |
| *** Daisy has quit IRC | 13:49 | |
| *** lapalm has joined #openstack-horizon | 13:50 | |
| *** dslev has joined #openstack-horizon | 13:52 | |
| *** dslev_ has joined #openstack-horizon | 13:53 | |
| *** dslev has quit IRC | 13:57 | |
| openstackgerrit | Ekaterina Shutova proposed openstack/horizon: Added test edit network from Admin panel https://review.openstack.org/270161 | 14:00 |
| *** piet has joined #openstack-horizon | 14:01 | |
| *** yamamoto has quit IRC | 14:02 | |
| *** JeanBriceCombebi has quit IRC | 14:02 | |
| openstackgerrit | Ekaterina Shutova proposed openstack/horizon: Added test for check inaccessibility resources for different projects https://review.openstack.org/269703 | 14:02 |
| *** julim has joined #openstack-horizon | 14:07 | |
| *** jpomeroy has joined #openstack-horizon | 14:09 | |
| openstackgerrit | Masco proposed openstack/horizon: Adding angular QoS panel in horizon https://review.openstack.org/247997 | 14:10 |
| *** vgridnev has quit IRC | 14:16 | |
| *** neelashah has joined #openstack-horizon | 14:16 | |
| *** vgridnev has joined #openstack-horizon | 14:18 | |
| *** masco has quit IRC | 14:18 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 14:19 | |
| *** piet has quit IRC | 14:21 | |
| *** lblanchard has joined #openstack-horizon | 14:24 | |
| *** peristeri has joined #openstack-horizon | 14:26 | |
| *** peristeri has quit IRC | 14:26 | |
| *** peristeri has joined #openstack-horizon | 14:27 | |
| *** peristeri has quit IRC | 14:27 | |
| *** peristeri has joined #openstack-horizon | 14:28 | |
| *** mdavidson has joined #openstack-horizon | 14:29 | |
| *** piet has joined #openstack-horizon | 14:30 | |
| openstackgerrit | Alexandra Allakhverdieva proposed openstack/horizon: [WIP] Added tests for check volumes management functionality https://review.openstack.org/237044 | 14:31 |
| *** JeanBriceCombebi has quit IRC | 14:37 | |
| *** absubram has joined #openstack-horizon | 14:41 | |
| *** zhurong has quit IRC | 14:42 | |
| *** vishwanathj has joined #openstack-horizon | 14:42 | |
| *** jtriley has joined #openstack-horizon | 14:46 | |
| *** ppiela has joined #openstack-horizon | 14:49 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: [WIP] More documentation on writing i9n tests https://review.openstack.org/272121 | 14:51 |
| *** cbader_ has quit IRC | 14:52 | |
| betherly | hi all! I am working at packaging my plugin into horizon locally to see if i can get the bare minimum working before the work goes on. | 14:54 |
| betherly | got as far as step 3 https://review.openstack.org/#/c/233709/15/doc/source/tutorials/plugin.rst | 14:54 |
| betherly | using readmes I have found from other plugins also | 14:55 |
| betherly | don't really understand what i am doing with regard the install dist/package though | 14:55 |
| *** cbader has joined #openstack-horizon | 14:55 | |
| betherly | i have packaged the ironic_ui folder doing python setup.py sdist | 14:56 |
| betherly | and moved the enabled file into horizon | 14:56 |
| betherly | but where am i meant to be running the install package thing and where should that file reside as currently i cant see where it even exists | 14:56 |
| betherly | also, should the .egg files/folders created in ironic_ui be moved to horizon? | 14:57 |
| betherly | sorry, lots of qs there | 14:57 |
| *** pushkaru has joined #openstack-horizon | 14:57 | |
| *** ducttape_ has joined #openstack-horizon | 15:00 | |
| *** deray has quit IRC | 15:01 | |
| robcresswell | activate your horizon venv | 15:04 |
| robcresswell | source .venv/bin/activate | 15:04 |
| betherly | have done :) | 15:04 |
| robcresswell | and then just pip install -e . inside ironic-ui | 15:04 |
| robcresswell | then run horizon :D | 15:04 |
| betherly | so how does that make ironic-ui and horizon communicate when they are unconnected folders? | 15:05 |
| robcresswell | You're just installing it as a python package | 15:05 |
| robcresswell | hence the ironic_ui.* imports in the enabled files | 15:06 |
| betherly | right ok | 15:08 |
| *** kzaitsev_mb has quit IRC | 15:11 | |
| *** erhudy has joined #openstack-horizon | 15:12 | |
| openstackgerrit | Ekaterina Shutova proposed openstack/horizon: Added test edit network from Admin panel https://review.openstack.org/270161 | 15:13 |
| *** mtanino has joined #openstack-horizon | 15:15 | |
| betherly | sorry robcresswell still a little confused | 15:16 |
| robcresswell | Sure | 15:16 |
| betherly | why am installing the package inside of ironic-ui as opposed to inside horizon? surely i want to be bringing ironic-ui into horizon rather than vice versa? | 15:16 |
| betherly | so once its been packaged with the pip install -e how does that then get accessed by horizon? | 15:17 |
| robcresswell | You're doing it inside Horizons venv | 15:17 |
| betherly | riiight ok | 15:17 |
| betherly | do i then still need to run pip install dist/``package``.tar.gz | 15:18 |
| betherly | ? | 15:18 |
| *** kzaitsev_mb has joined #openstack-horizon | 15:18 | |
| betherly | so based on the documentation https://review.openstack.org/#/c/233709/15/doc/source/tutorials/plugin.rst | 15:18 |
| betherly | is that accurate and where does the pip install come into that process | 15:18 |
| *** vgridnev has quit IRC | 15:18 | |
| *** vgridnev has joined #openstack-horizon | 15:19 | |
| robcresswell | So that path I think is really for installing and creating a distributable package | 15:21 |
| robcresswell | If you're developing you should just use pip install -e . | 15:22 |
| robcresswell | At least, that's how I've been doing it. | 15:22 |
| robcresswell | But as long as you've copied the enabled file, all you need to do is install the plugin package | 15:23 |
| robcresswell | And its python, so thats always in venvs | 15:23 |
| mrunge | (or add the source code to your python path) | 15:24 |
| mrunge | export PYTHONPATH=~foo/bar:$PYTHONPATH | 15:24 |
| mrunge | ./manage.py runserver | 15:24 |
| mrunge | this is something I'm using while testing git snapshots of doa and horizon at the same time | 15:25 |
| mrunge | btw robcresswell did you look at doa for django-1.9? | 15:25 |
| robcresswell | mrunge: It has non-voting tests and a patch to fix them | 15:26 |
| robcresswell | mrunge: But then there's more to fix | 15:26 |
| betherly | thanks so much for all the help. sorry for all the qs | 15:27 |
| betherly | done all that. getting this error No module named ironic_ui.enabled | 15:27 |
| betherly | :( | 15:27 |
| *** chlong has joined #openstack-horizon | 15:27 | |
| *** vijendar has joined #openstack-horizon | 15:28 | |
| robcresswell | Err what are you doing with that path lol? | 15:29 |
| mrunge | who? | 15:29 |
| robcresswell | betherly, sorry | 15:29 |
| robcresswell | betherly: Can you push your code? I'll look and fix it after this meeting. | 15:30 |
| mrunge | betherly, your enabled path really contains a __init__.py file? | 15:30 |
| robcresswell | It shouldn't need to. The enabled is just for copying over :/ | 15:30 |
| robcresswell | and o_d/enabled will handle it. | 15:30 |
| mrunge | k | 15:30 |
| *** aortega has quit IRC | 15:33 | |
| *** exploreshaifali has joined #openstack-horizon | 15:35 | |
| *** masco has joined #openstack-horizon | 15:38 | |
| *** kzaitsev_mb has quit IRC | 15:39 | |
| *** aix_ has quit IRC | 15:39 | |
| betherly | I've just realised I have a meeting too!! Ahh! Sorry I'll push it as soon as I'm out | 15:39 |
| betherly | Lost track of time :/ | 15:39 |
| *** JeanBriceCombebi has joined #openstack-horizon | 15:39 | |
| *** chlong has quit IRC | 15:40 | |
| *** chlong has joined #openstack-horizon | 15:41 | |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Add Network Port selection to new instance launch https://review.openstack.org/253573 | 15:41 |
| *** chlong has quit IRC | 15:43 | |
| *** chlong has joined #openstack-horizon | 15:44 | |
| *** dslev_ has quit IRC | 15:45 | |
| openstackgerrit | Alexandra Allakhverdieva proposed openstack/horizon: [WIP] Added tests for check volumes management functionality https://review.openstack.org/237044 | 15:46 |
| *** hurgleburgler has joined #openstack-horizon | 15:49 | |
| *** doug-fish has joined #openstack-horizon | 15:50 | |
| *** sayan|think has quit IRC | 15:55 | |
| *** kzaitsev_mb has joined #openstack-horizon | 16:03 | |
| *** dslevin has joined #openstack-horizon | 16:04 | |
| *** Drago has joined #openstack-horizon | 16:05 | |
| *** Drago has quit IRC | 16:06 | |
| *** Drago has joined #openstack-horizon | 16:06 | |
| *** zul has quit IRC | 16:10 | |
| *** zul has joined #openstack-horizon | 16:10 | |
| *** alexvictorchan has quit IRC | 16:11 | |
| *** tosky has quit IRC | 16:12 | |
| *** vgridnev has quit IRC | 16:12 | |
| *** chlong has quit IRC | 16:15 | |
| *** chestack has joined #openstack-horizon | 16:15 | |
| *** belmoreira has quit IRC | 16:15 | |
| *** chlong has joined #openstack-horizon | 16:15 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: [WIP] Add Create Network workflow https://review.openstack.org/264299 | 16:16 |
| *** tosky has joined #openstack-horizon | 16:16 | |
| *** JeanBriceCombebi has quit IRC | 16:19 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 16:19 | |
| *** vgridnev has joined #openstack-horizon | 16:20 | |
| robcresswell | sjmc7: I don't suppose you'll be at the midcycle? | 16:20 |
| sjmc7 | robcresswell: apparently i have clearance to travel | 16:20 |
| robcresswell | \o/ | 16:20 |
| sjmc7 | you need a translator? | 16:21 |
| robcresswell | Would be good to talk searchlight-neutron. Just re-reading your email now so that I can reply. | 16:21 |
| robcresswell | Yes, that too | 16:21 |
| sjmc7 | ah, cool, thanks | 16:21 |
| *** bluex has joined #openstack-horizon | 16:24 | |
| openstackgerrit | Wang Bo proposed openstack/horizon: Change number of horizon specific haking rule https://review.openstack.org/271912 | 16:28 |
| *** kertis has joined #openstack-horizon | 16:30 | |
| *** vgridnev has quit IRC | 16:30 | |
| *** rcernin has quit IRC | 16:31 | |
| *** vijendar has quit IRC | 16:35 | |
| *** hurgleburgler1 has joined #openstack-horizon | 16:41 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Clean up horizon.scss - _tables.scss https://review.openstack.org/260640 | 16:41 |
| *** chestack has quit IRC | 16:42 | |
| *** hurgleburgler has quit IRC | 16:44 | |
| *** aortega has joined #openstack-horizon | 16:49 | |
| *** alexvictorchan has joined #openstack-horizon | 16:49 | |
| *** JeanBriceCombebi has quit IRC | 16:49 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 16:50 | |
| *** bpokorny has joined #openstack-horizon | 16:50 | |
| betherly | robcresswell: sorry disappeared earlier | 16:51 |
| betherly | suddenly realised the time and had to dash to an in office meeting | 16:52 |
| betherly | david also gave me https://github.com/openstack/designate-dashboard/blob/master/README.rst to look at for the plugin documentation | 16:52 |
| betherly | im probably mixing too many docs together to try and get the thing working and making a mess :/ | 16:52 |
| *** gyee has quit IRC | 16:52 | |
| *** Fin1te has joined #openstack-horizon | 16:54 | |
| *** garthb has joined #openstack-horizon | 16:56 | |
| *** gyee has joined #openstack-horizon | 16:56 | |
| *** jprovazn has joined #openstack-horizon | 16:56 | |
| *** dslevin1 has joined #openstack-horizon | 16:57 | |
| *** chestack has joined #openstack-horizon | 16:57 | |
| *** Madkiss has quit IRC | 17:00 | |
| *** chlong has quit IRC | 17:02 | |
| *** jpomeroy has quit IRC | 17:02 | |
| *** jpomeroy has joined #openstack-horizon | 17:02 | |
| *** chlong has joined #openstack-horizon | 17:03 | |
| *** chlong has quit IRC | 17:04 | |
| *** chlong has joined #openstack-horizon | 17:05 | |
| *** dslevin1 has quit IRC | 17:05 | |
| *** ygbo has quit IRC | 17:06 | |
| *** masco has quit IRC | 17:07 | |
| *** JeanBriceCombebi has quit IRC | 17:07 | |
| *** vijendar has joined #openstack-horizon | 17:09 | |
| *** dslevin1 has joined #openstack-horizon | 17:11 | |
| *** matt-borland has joined #openstack-horizon | 17:16 | |
| robcresswell | betherly: Throw the patch online so I can see it :) | 17:20 |
| *** mtanino has quit IRC | 17:20 | |
| *** julim has quit IRC | 17:20 | |
| betherly | robcresswell: what part do you want me to throw up? the horizon stuff?are you happy for me to push up a WIP patch into horizon to then abandon because obvs it is not meant to be there long term | 17:21 |
| robcresswell | ?? Shouldnt be anything in Horizon | 17:22 |
| betherly | or the actual ironic-ui thing | 17:22 |
| robcresswell | ironic-ui | 17:22 |
| robcresswell | Just push that so I can install it locally and see whats going on | 17:22 |
| openstackgerrit | Merged openstack/horizon: Themeable loader/progress bar for tables https://review.openstack.org/267231 | 17:22 |
| betherly | sure thing | 17:22 |
| betherly | its super empty - doesnt even have a panel in it yet, just an index.html blank file ready | 17:23 |
| betherly | that its pointing at | 17:23 |
| robcresswell | thats fine | 17:23 |
| *** TravT has joined #openstack-horizon | 17:23 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Clean up horizon.scss - serial_console.scss https://review.openstack.org/260641 | 17:24 |
| *** itxaka has quit IRC | 17:24 | |
| *** wolverineav has joined #openstack-horizon | 17:24 | |
| *** lhcheng has joined #openstack-horizon | 17:24 | |
| betherly | so this is the install readme ive compiled into 'English' for myself from the different sources i got pointed to so you know where im coming from https://review.openstack.org/#/c/272190/ | 17:25 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Clean up horizon.scss - default/boostrap/_form.scss https://review.openstack.org/260642 | 17:26 |
| betherly | plugin setup patch https://review.openstack.org/#/c/270768/ | 17:26 |
| betherly | existing plugin repo: https://github.com/openstack/ironic-ui | 17:26 |
| betherly | robcresswell: ^^^ | 17:27 |
| *** Ephur has joined #openstack-horizon | 17:27 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Clean up horizon.scss - default/bootstrap/_type.scss https://review.openstack.org/260643 | 17:27 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Clean up horizon.scss - Remove remaining styles https://review.openstack.org/260648 | 17:27 |
| *** dslevin has quit IRC | 17:29 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Clean up horizon.scss - Organize Imports https://review.openstack.org/260651 | 17:30 |
| *** hurgleburgler1 is now known as hurgleburgler | 17:31 | |
| *** Ephur has quit IRC | 17:32 | |
| *** julim has joined #openstack-horizon | 17:33 | |
| *** vgridnev has joined #openstack-horizon | 17:34 | |
| *** chestack has quit IRC | 17:35 | |
| doug-fish | I've created trouble in https://review.openstack.org/#/c/243974/ I think it would be good to get some other perspectives on the local_settings.d with/vs local_settings.py behavior | 17:37 |
| *** tqtran has joined #openstack-horizon | 17:37 | |
| robcresswell | Uhoh | 17:38 |
| tqtran | robcresswell: https://review.openstack.org/#/c/233709/ is that all? once i update that, there is no more problem right? | 17:41 |
| openstackgerrit | Merged openstack/horizon: [Django 1.9] Remove testserver from expected_url https://review.openstack.org/271850 | 17:41 |
| david-lyle | wow, the gate is snappy again | 17:42 |
| robcresswell | tqtran: I'd still prefer we split it into Python/ Angular, but yeah most of the content is pretty useful | 17:42 |
| robcresswell | We could also work on refining the install process listed | 17:42 |
| robcresswell | Although that may just be bias towards my own process :) | 17:43 |
| tqtran | you can always ammend to it once the patch lands | 17:43 |
| tqtran | the purpose of the patch isn't to guide you through the install process | 17:43 |
| tqtran | theres probably other ways to do it, i dont claim to be an expert in the area | 17:44 |
| *** mtanino has joined #openstack-horizon | 17:44 | |
| robcresswell | tutorial for creating and installing plugins ? | 17:44 |
| tqtran | tutorial for creating mostly, the installation is there because you need a way to do it | 17:44 |
| tqtran | do it as in testing your plugin | 17:45 |
| robcresswell | Cool. Yeah looks about there | 17:45 |
| tqtran | if you know a more elegant way, feel free to make ammend to it once it lands | 17:45 |
| robcresswell | yessir | 17:45 |
| *** agireud has quit IRC | 17:46 | |
| *** vgridnev has quit IRC | 17:47 | |
| *** vgridnev has joined #openstack-horizon | 17:47 | |
| *** jpomeroy has quit IRC | 17:47 | |
| *** agireud has joined #openstack-horizon | 17:48 | |
| *** chestack has joined #openstack-horizon | 17:48 | |
| *** wolverineav has quit IRC | 17:50 | |
| *** wolverineav has joined #openstack-horizon | 17:50 | |
| *** mtanino__ has joined #openstack-horizon | 17:52 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Add/Fix several Port Details fields https://review.openstack.org/272205 | 17:53 |
| *** julim_ has joined #openstack-horizon | 17:57 | |
| *** vijendar has quit IRC | 17:59 | |
| *** julim has quit IRC | 17:59 | |
| *** chestack has quit IRC | 18:01 | |
| *** Fin1te has quit IRC | 18:07 | |
| *** eandersson has joined #openstack-horizon | 18:13 | |
| *** vgridnev has quit IRC | 18:14 | |
| *** jpomeroy has joined #openstack-horizon | 18:25 | |
| *** chlong has quit IRC | 18:29 | |
| *** chlong has joined #openstack-horizon | 18:30 | |
| *** doug-fish has quit IRC | 18:30 | |
| *** vijendar has joined #openstack-horizon | 18:31 | |
| *** chlong has quit IRC | 18:32 | |
| *** chlong has joined #openstack-horizon | 18:32 | |
| *** lhcheng_ has joined #openstack-horizon | 18:34 | |
| *** lhcheng has quit IRC | 18:36 | |
| *** hurgleburgler1 has joined #openstack-horizon | 18:39 | |
| *** hurgleburgler has quit IRC | 18:39 | |
| robcresswell | betherly: Is this intended to be a single panel, or multiple? | 18:44 |
| *** dslevin1 has quit IRC | 18:45 | |
| betherly | robcresswell: single :) | 18:48 |
| robcresswell | Cool | 18:48 |
| robcresswell | Mind if I update your patch? | 18:49 |
| betherly | not at all! thanks so much for your help!! | 18:49 |
| *** pcaruana has joined #openstack-horizon | 18:51 | |
| openstackgerrit | Merged openstack/horizon: Clean up horizon.scss - _tables.scss https://review.openstack.org/260640 | 18:56 |
| *** jpomeroy_ has joined #openstack-horizon | 18:59 | |
| *** bpokorny has quit IRC | 18:59 | |
| *** jpomeroy has quit IRC | 19:01 | |
| *** lapalm_ has joined #openstack-horizon | 19:02 | |
| *** daemontool has joined #openstack-horizon | 19:02 | |
| *** openstackgerrit has quit IRC | 19:02 | |
| *** lapalm_ has quit IRC | 19:02 | |
| *** openstackgerrit has joined #openstack-horizon | 19:03 | |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Identity NGProjects API https://review.openstack.org/208581 | 19:04 |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding hz-if-neutron-extensions directive https://review.openstack.org/252597 | 19:04 |
| *** lapalm has quit IRC | 19:05 | |
| *** jpomeroy_ is now known as jpomeroy | 19:06 | |
| jpomeroy | TravT, question for you regarding the metadata namespace properties target | 19:06 |
| TravT | hey jpomeroy | 19:07 |
| jpomeroy | I'm not seeing where you can specify the properties target when requesting namespaces | 19:07 |
| *** lapalm has joined #openstack-horizon | 19:07 | |
| TravT | yeah, i think you have to filter after retrieving them | 19:07 |
| TravT | so, i'd probably put that on the api/glance.py | 19:07 |
| *** doug-fish has joined #openstack-horizon | 19:07 | |
| jpomeroy | TravT, ok so request all namespaces for a resource type and then filter out any namespaces that don't also have the given properties target, if provided | 19:10 |
| TravT | yeah, i don't see another way. I don't see that on the glance side API | 19:10 |
| jpomeroy | sure will give that a go | 19:11 |
| *** doug-fis_ has joined #openstack-horizon | 19:11 | |
| TravT | ok, cool | 19:11 |
| *** tosky has quit IRC | 19:12 | |
| *** doug-fish has quit IRC | 19:12 | |
| *** doug-fi__ has joined #openstack-horizon | 19:12 | |
| *** doug-fis_ has quit IRC | 19:15 | |
| *** doug-fish has joined #openstack-horizon | 19:16 | |
| *** doug-fi__ has quit IRC | 19:16 | |
| *** doug-fish has quit IRC | 19:17 | |
| *** doug-fish has joined #openstack-horizon | 19:17 | |
| david-lyle | we won't get rid of doug-fish that easily | 19:17 |
| david-lyle | :D | 19:17 |
| doug-fish | good news! I'm back! | 19:18 |
| *** vijendar has quit IRC | 19:18 | |
| robcresswell | betherly: Almost done. | 19:18 |
| david-lyle | looked touch and go there | 19:18 |
| *** bpokorny has joined #openstack-horizon | 19:18 | |
| *** ygbo has joined #openstack-horizon | 19:19 | |
| betherly | robcresswell: thank you soooo much for your help!! | 19:19 |
| *** ybathia has joined #openstack-horizon | 19:20 | |
| *** ygbo has quit IRC | 19:20 | |
| doug-fish | david-lyle: so ... did I miss something? or is that your way of saying "welcome back?" | 19:20 |
| robcresswell | Just realised I've been doing all my copyright things as 2015. Oops. | 19:21 |
| david-lyle | doug-fish: I just saw you come and go with like 4 different nick permutations | 19:22 |
| doug-fish | oh I see | 19:22 |
| doug-fish | probably impostors. | 19:22 |
| david-lyle | for some reason my client thinks it's important that I know these things | 19:22 |
| TravT | :D just read up a few lines | 19:23 |
| *** vijendar has joined #openstack-horizon | 19:23 | |
| *** Fin1te has joined #openstack-horizon | 19:24 | |
| *** piet has quit IRC | 19:28 | |
| openstackgerrit | Lucas Palm proposed openstack/horizon: Allow setting default value for config_drive https://review.openstack.org/271464 | 19:28 |
| *** exploreshaifali has quit IRC | 19:30 | |
| *** pcaruana has quit IRC | 19:32 | |
| openstackgerrit | George Peristerakis proposed openstack/horizon: Display event stream in the instance audit tab https://review.openstack.org/188134 | 19:33 |
| *** kzaitsev_mb has quit IRC | 19:35 | |
| *** pcaruana has joined #openstack-horizon | 19:36 | |
| *** patk has joined #openstack-horizon | 19:40 | |
| *** pcaruana has quit IRC | 19:40 | |
| robcresswell | david-lyle: Is this the best way to handle plugin test settings right now? https://github.com/openstack/trove-dashboard/blob/master/trove_dashboard/test/settings.py | 19:41 |
| robcresswell | Just double-checking things while I sort out this ironic one | 19:41 |
| david-lyle | robcresswell: unless someone has the pure tox version ready | 19:42 |
| david-lyle | oh wait, tox ignored | 19:42 |
| david-lyle | yes | 19:42 |
| *** pcaruana has joined #openstack-horizon | 19:43 | |
| david-lyle | installing enabled files into a dependent package doesn't work real well | 19:43 |
| david-lyle | s/installing/copying/ | 19:44 |
| *** rcernin has joined #openstack-horizon | 19:44 | |
| robcresswell | Yeah, I'm trying to understand how this fits with the cookiecutter tox.ini | 19:45 |
| david-lyle | well, you'll need a test/settings.py either way | 19:50 |
| david-lyle | and horizon will be installed in the the tox venv | 19:50 |
| robcresswell | yup. when I did the cisco one, I was mainly reusing the Horizon setup | 19:51 |
| robcresswell | Havent spent enough time with this tox setup to understand whats going on | 19:51 |
| david-lyle | with tox or without, you will need to load the plugin into horizon to test it | 19:51 |
| david-lyle | same as run_test really, just in a different location | 19:52 |
| david-lyle | both use a virtualenv | 19:52 |
| *** dslevin1 has joined #openstack-horizon | 19:53 | |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Identity NGProjects Panel https://review.openstack.org/199139 | 19:54 |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Identity NGProjects Create Action - Details https://review.openstack.org/215352 | 19:54 |
| *** pcaruana has quit IRC | 19:56 | |
| *** jprovazn has quit IRC | 19:58 | |
| *** rdopiera has quit IRC | 20:05 | |
| openstackgerrit | Alexandra Allakhverdieva proposed openstack/horizon: [WIP] Added tests for check volumes management functionality https://review.openstack.org/237044 | 20:07 |
| *** neelashah has quit IRC | 20:09 | |
| openstackgerrit | Merged openstack/horizon: Clean up horizon.scss - serial_console.scss https://review.openstack.org/260641 | 20:13 |
| *** vijendar has quit IRC | 20:13 | |
| openstackgerrit | Merged openstack/horizon: Clean up horizon.scss - default/boostrap/_form.scss https://review.openstack.org/260642 | 20:16 |
| *** ZZelle__ has joined #openstack-horizon | 20:18 | |
| *** doug-fish has quit IRC | 20:22 | |
| *** neelashah has joined #openstack-horizon | 20:24 | |
| *** neelashah1 has joined #openstack-horizon | 20:26 | |
| *** neelashah has quit IRC | 20:29 | |
| *** doug-fish has joined #openstack-horizon | 20:32 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Plugin Docs https://review.openstack.org/233709 | 20:33 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Plugin Docs https://review.openstack.org/233709 | 20:33 |
| *** piet has joined #openstack-horizon | 20:40 | |
| *** kzaitsev_mb has joined #openstack-horizon | 20:41 | |
| *** pauloewerton has quit IRC | 20:49 | |
| r1chardj0n3s | morning | 20:56 |
| *** amotoki has joined #openstack-horizon | 20:56 | |
| robcresswell | morning r1chardj0n3s | 20:57 |
| *** yamamoto has joined #openstack-horizon | 20:57 | |
| r1chardj0n3s | public holiday today \o/ just checking for important messages :-) | 20:58 |
| openstackgerrit | Alexandra Allakhverdieva proposed openstack/horizon: [WIP] Added tests for check volumes management functionality https://review.openstack.org/237044 | 20:58 |
| robcresswell | Ah nice. Enjoy. | 20:59 |
| tqtran | r1chardj0n3s: holidays? whats more important than working on horizon? | 21:02 |
| robcresswell | lol | 21:02 |
| *** vijendar has joined #openstack-horizon | 21:07 | |
| *** chlong has quit IRC | 21:07 | |
| *** chlong has joined #openstack-horizon | 21:08 | |
| ducttape_ | doug-fish : I spoke for you on https://review.openstack.org/#/c/243974/ Correct me as needed | 21:16 |
| *** davidlenwell has quit IRC | 21:16 | |
| doug-fish | scary. thanks for the heads up. :-) | 21:17 |
| ducttape_ | We both share some midwestern backstory, I feel entitled to take some liberties ;) | 21:17 |
| *** davidlenwell has joined #openstack-horizon | 21:18 | |
| robcresswell | Note to self: Doug and Eric now same person | 21:18 |
| doug-fish | lol | 21:19 |
| ducttape_ | duct-fish | 21:19 |
| ducttape_ | fish-tape | 21:19 |
| doug-fish | wow | 21:19 |
| robcresswell | Wouldnt it be doug-tape? | 21:20 |
| ducttape_ | hmm, perhaps | 21:20 |
| ducttape_ | people usually call me an ass, so it makes sense that I would have the second part of the name | 21:21 |
| robcresswell | haha | 21:21 |
| *** lhcheng has joined #openstack-horizon | 21:21 | |
| doug-fish | fish-ass | 21:22 |
| ducttape_ | lol | 21:22 |
| r1chardj0n3s | maybe I shouldn't take the day off. this is what happens with no adult supervision... | 21:24 |
| *** lhcheng_ has quit IRC | 21:24 | |
| robcresswell | Everyones building up to late-cycle madness | 21:25 |
| ducttape_ | r1chardj0n3s - if you stick around, then you are somewhat complicit. might want to run while you can | 21:25 |
| r1chardj0n3s | I'm just waiting for someone to point out the lunacy of me being the adult supervision | 21:25 |
| robcresswell | haha | 21:27 |
| robcresswell | its all relative | 21:27 |
| *** julim_ has quit IRC | 21:27 | |
| r1chardj0n3s | argh, invision, why u so terrible | 21:28 |
| robcresswell | The loading times are horrible. Whole thing just locks up. No idea why it cant just put up placeholders and async the images. | 21:28 |
| r1chardj0n3s | (the irony of user experience people using such a terrible user experience to develop new user experiences) | 21:28 |
| robcresswell | :D | 21:28 |
| r1chardj0n3s | I'm trying to work through the 33 comments that have been added, when I click on one it brings up a completely different conversation in the main view | 21:29 |
| *** kzaitsev_mb has quit IRC | 21:30 | |
| *** gariveradlt has joined #openstack-horizon | 21:31 | |
| gariveradlt | hello, I need plus two code reviews to close out my bug fix. Thank you for your time. https://review.openstack.org/#/c/252036/ | 21:32 |
| *** hurgleburgler1 has quit IRC | 21:32 | |
| *** hurgleburgler has joined #openstack-horizon | 21:33 | |
| *** Fin1te has quit IRC | 21:39 | |
| *** chlong has quit IRC | 21:39 | |
| *** chlong has joined #openstack-horizon | 21:40 | |
| *** davidlenwell has quit IRC | 21:55 | |
| *** davidlenwell has joined #openstack-horizon | 21:56 | |
| openstackgerrit | Alan Fung proposed openstack/horizon: Horizon template loader to index by actual panel directory https://review.openstack.org/271201 | 21:56 |
| *** Fin1te has joined #openstack-horizon | 21:59 | |
| *** aix_ has joined #openstack-horizon | 22:02 | |
| openstackgerrit | Merged openstack/horizon: Clean up horizon.scss - default/bootstrap/_type.scss https://review.openstack.org/260643 | 22:07 |
| matt-borland | doug-fish, were my reviews on the LBaaS UI work Friday helpful? What do you need to help get a second +2? | 22:07 |
| matt-borland | Or does the approval process work differently in this case? | 22:08 |
| doug-fish | matt-borland: yes - your reviews were quite helpful! | 22:08 |
| matt-borland | np. My plan is to review about 2 steps into the chain at a time, assuming we can get some approvals going. | 22:09 |
| doug-fish | I think the approval process allows any core from Horizon or Neutron to +2 or +A a patch ... I'd prefer to get somebody a neutron person to give the 2nd +2 on those | 22:09 |
| doug-fish | matt-borland: yeah, I'm doing the same | 22:09 |
| matt-borland | Do you have any people in mind/have you reached out to them? | 22:09 |
| doug-fish | I've heckled #opestack-lbaas in the past | 22:10 |
| matt-borland | heh | 22:10 |
| doug-fish | with limited success | 22:10 |
| matt-borland | yeah. that's a bit of a problem. I'll check around here to see if I can find additional support. | 22:10 |
| *** yamamoto has quit IRC | 22:10 | |
| doug-fish | fantastic - thx | 22:10 |
| doug-fish | don't rush too much - the next patch in the chain has at least a trivial issue to address | 22:11 |
| doug-fish | (I'm reviewing now) | 22:11 |
| matt-borland | heh, no problem. | 22:11 |
| robcresswell | david-lyle: I see what you mean about the enabled stuff. Namespace/test difficulties. | 22:11 |
| matt-borland | I am just looking for names. | 22:11 |
| sjmc7 | matt-borland: i can give you a list of names within HP | 22:11 |
| matt-borland | thanks sjmc7 ! | 22:12 |
| *** kzaitsev_mb has joined #openstack-horizon | 22:13 | |
| piet | If you folks know any end users that would be interested in participating in the overview panel interviews, please point them my way or to doodle to schedule a date/time. https://doodle.com/poll/5sqy2gr8c34fzqy8 | 22:18 |
| *** lblanchard has quit IRC | 22:19 | |
| *** peristeri has quit IRC | 22:20 | |
| *** jtriley has quit IRC | 22:30 | |
| *** rcernin has quit IRC | 22:31 | |
| *** tqtran has quit IRC | 22:31 | |
| *** davidlenwell has quit IRC | 22:34 | |
| *** davidlenwell has joined #openstack-horizon | 22:36 | |
| *** neelashah1 has quit IRC | 22:36 | |
| *** Fin1te has quit IRC | 22:38 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Add image visibility filter to NG images table https://review.openstack.org/270439 | 22:49 |
| openstackgerrit | Justin Pomeroy proposed openstack/horizon: Support properties_target when fetching namespaces https://review.openstack.org/272305 | 22:50 |
| *** vijendar has quit IRC | 22:54 | |
| *** lapalm has quit IRC | 22:56 | |
| *** doug-fish has quit IRC | 22:56 | |
| *** matt-borland has quit IRC | 22:58 | |
| *** chlong has quit IRC | 23:02 | |
| *** chlong has joined #openstack-horizon | 23:03 | |
| *** chlong has quit IRC | 23:04 | |
| *** jpomeroy has quit IRC | 23:04 | |
| *** chlong has joined #openstack-horizon | 23:05 | |
| *** amotoki has quit IRC | 23:12 | |
| *** absubram has quit IRC | 23:13 | |
| *** amotoki has joined #openstack-horizon | 23:15 | |
| *** pushkaru has quit IRC | 23:15 | |
| *** pushkaru has joined #openstack-horizon | 23:16 | |
| *** amotoki has quit IRC | 23:16 | |
| *** pushkaru has quit IRC | 23:20 | |
| *** vishwanathj has quit IRC | 23:23 | |
| *** gariveradlt has quit IRC | 23:26 | |
| *** alanf_ has joined #openstack-horizon | 23:26 | |
| *** chlong has quit IRC | 23:29 | |
| *** chlong has joined #openstack-horizon | 23:30 | |
| *** jtomasek has quit IRC | 23:32 | |
| openstackgerrit | Alan Fung proposed openstack/horizon: Horizon template loader to index by actual panel directory https://review.openstack.org/271201 | 23:32 |
| *** hurgleburgler has quit IRC | 23:39 | |
| *** hurgleburgler has joined #openstack-horizon | 23:39 | |
| *** ybathia has quit IRC | 23:40 | |
| *** david-lyle has quit IRC | 23:44 | |
| *** jtomasek has joined #openstack-horizon | 23:45 | |
| *** ZZelle__ has quit IRC | 23:52 | |
| *** ducttape_ has quit IRC | 23:53 | |
| *** yamamoto_ has joined #openstack-horizon | 23:58 | |
| *** chlong has quit IRC | 23:58 | |
| *** chlong has joined #openstack-horizon | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!