Wednesday, 2015-12-23

openstackgerritRajat Vig proposed openstack/horizon: WIP: Launch Instance - UI for Download Key Pair  https://review.openstack.org/24944200:03
*** darrenc is now known as darrenc_afk00:04
*** rajatvig has quit IRC00:10
*** piet has joined #openstack-horizon00:10
*** piet has quit IRC00:15
openstackgerritErrol Pais proposed openstack/horizon: WIP: Launch Instance - UI for Download Key Pair (Redesign)  https://review.openstack.org/25959300:16
*** davidlenwell has quit IRC00:17
*** darrenc_afk is now known as darrenc00:18
*** wolverin_ has joined #openstack-horizon00:23
*** davidlenwell has joined #openstack-horizon00:23
*** tosky has quit IRC00:25
*** wolverineav has quit IRC00:27
*** wolverin_ has quit IRC00:28
*** ZZelle has quit IRC00:31
*** jacky-zhang has joined #openstack-horizon00:58
*** gyee has quit IRC01:28
openstackgerritDoug Hellmann proposed openstack/django-openstack-auth-kerberos: remove python 2.6 trove classifier  https://review.openstack.org/26077501:38
openstackgerritDoug Hellmann proposed openstack/manila-ui: remove python 2.6 trove classifier  https://review.openstack.org/26079501:39
openstackgerritDoug Hellmann proposed openstack/tuskar-ui: remove python 2.6 trove classifier  https://review.openstack.org/26084901:43
*** mriedem has joined #openstack-horizon01:51
mriedemis this bad?01:51
mriedemhttp://logs.openstack.org/77/257677/3/gate/gate-horizon-dsvm-integration/855c771/logs/apache/horizon_error.txt.gz#_2015-12-16_13_05_17_61178001:51
mriedemi guess not, it shows up a lot but appears to not be making tests fail01:54
mriedemand this must have been fixed on the 16th:01:54
mriedemhttp://logs.openstack.org/77/257677/3/gate/gate-horizon-dsvm-integration/855c771/console.html.gz#_2015-12-16_13_08_59_89601:54
mriedemoh i see https://github.com/openstack/horizon/commit/b21d7bc55f15cfd1e394f72e75856dce11ad071701:55
*** erlon has quit IRC01:56
*** mriedem has left #openstack-horizon02:00
*** DuncanT has quit IRC02:01
*** errolpais has quit IRC02:04
*** zhurong has joined #openstack-horizon02:04
*** DuncanT has joined #openstack-horizon02:05
*** wolverineav has joined #openstack-horizon02:11
*** ianbrown_ has quit IRC02:15
*** btully has quit IRC02:15
*** ianbrown_ has joined #openstack-horizon02:15
*** wolverineav has quit IRC02:16
*** deray has joined #openstack-horizon02:35
*** zhurong has quit IRC02:49
*** zhurong has joined #openstack-horizon02:50
*** btully has joined #openstack-horizon02:54
openstackgerritMerged openstack/horizon: Increase default Python socket timeout  https://review.openstack.org/25826202:54
*** btully has quit IRC02:58
*** zhurong has quit IRC03:02
*** zhurong has joined #openstack-horizon03:03
*** zhurong has quit IRC03:09
*** zhurong has joined #openstack-horizon03:09
openstackgerritGavin Nie proposed openstack/horizon: Fix some inconsistency in docstrings  https://review.openstack.org/26086903:11
openstackgerrithgangwx@cn.ibm.com proposed openstack/horizon: Misspelling in message  https://review.openstack.org/26087103:15
*** apuimedo has quit IRC03:16
*** apuimedo has joined #openstack-horizon03:18
*** apuimedo has quit IRC03:20
*** apuimedo has joined #openstack-horizon03:22
*** jamielennox is now known as jamielennox|away03:22
*** radez` is now known as radez03:22
*** Guest13696 is now known as mfisch03:23
*** mfisch is now known as Guest30303:24
openstackgerritRichard Jones proposed openstack/horizon: Add ngSwift Django Interface  https://review.openstack.org/25876903:30
openstackgerritRichard Jones proposed openstack/horizon: WIP: Add ngSwift containers and objects display  https://review.openstack.org/25923103:31
openstackgerritRichard Jones proposed openstack/horizon: WIP: Add ngSwift actions  https://review.openstack.org/25923603:34
*** apuimedo has quit IRC03:36
*** apuimedo has joined #openstack-horizon03:38
*** apuimedo has quit IRC03:42
*** apuimedo has joined #openstack-horizon03:44
*** apuimedo has quit IRC03:54
*** apuimedo_ has joined #openstack-horizon03:55
*** alexvictorchan_ has joined #openstack-horizon03:57
*** alexvictorchan has quit IRC03:58
*** alexvictorchan_ is now known as alexvictorchan03:58
openstackgerrithgangwx@cn.ibm.com proposed openstack/horizon: Misspelling in message  https://review.openstack.org/26087103:59
*** vkmc has quit IRC04:03
*** vkmc has joined #openstack-horizon04:06
*** apuimedo_ has quit IRC04:08
*** apuimedo_ has joined #openstack-horizon04:08
*** NightKhaos has joined #openstack-horizon04:11
*** apuimedo_ has quit IRC04:15
*** apuimedo_ has joined #openstack-horizon04:16
*** apuimedo_ has quit IRC04:21
*** apuimedo has joined #openstack-horizon04:21
*** apuimedo has quit IRC04:26
*** apuimedo has joined #openstack-horizon04:28
*** vkmc is now known as vkmc_afk04:29
*** zhurong has quit IRC04:31
*** Ramanjaneya has joined #openstack-horizon04:39
*** apuimedo has quit IRC04:44
*** apuimedo has joined #openstack-horizon04:45
*** apuimedo has quit IRC04:50
*** apuimedo has joined #openstack-horizon04:52
*** apuimedo has quit IRC05:05
*** apuimedo has joined #openstack-horizon05:06
*** zhurong has joined #openstack-horizon05:09
*** apuimedo has quit IRC05:11
*** apuimedo has joined #openstack-horizon05:12
*** apuimedo has quit IRC05:19
*** apuimedo has joined #openstack-horizon05:20
*** apuimedo has quit IRC05:25
*** apuimedo has joined #openstack-horizon05:25
*** apuimedo has quit IRC05:32
*** apuimedo has joined #openstack-horizon05:34
*** mohankumar has joined #openstack-horizon05:34
*** masco_ has joined #openstack-horizon05:38
*** apuimedo has quit IRC05:38
*** apuimedo has joined #openstack-horizon05:39
*** mohankumar has quit IRC05:40
*** chestack has joined #openstack-horizon05:43
*** apuimedo has quit IRC05:44
*** apuimedo has joined #openstack-horizon05:46
*** chestack has quit IRC05:50
*** apuimedo has quit IRC05:51
*** chestack has joined #openstack-horizon05:51
*** apuimedo has joined #openstack-horizon05:53
*** r1chardj0n3s is now known as r1chardj0n3s_afk05:54
*** btully has joined #openstack-horizon05:56
*** mohankumar has joined #openstack-horizon05:56
*** apuimedo has quit IRC05:57
*** apuimedo has joined #openstack-horizon05:59
*** btully has quit IRC06:00
*** apuimedo has quit IRC06:08
*** apuimedo has joined #openstack-horizon06:09
*** apuimedo has quit IRC06:14
*** apuimedo has joined #openstack-horizon06:14
*** mohankumar has quit IRC06:16
*** Ramanjaneya has quit IRC06:18
*** apuimedo has quit IRC06:19
*** apuimedo has joined #openstack-horizon06:19
*** vgridnev has joined #openstack-horizon06:21
openstackgerritOpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Zanata  https://review.openstack.org/25967706:23
*** mohankumar has joined #openstack-horizon06:23
*** apuimedo has quit IRC06:24
*** apuimedo has joined #openstack-horizon06:25
*** errolpais has joined #openstack-horizon06:27
*** apuimedo has quit IRC06:29
*** apuimedo has joined #openstack-horizon06:31
*** apuimedo has quit IRC06:42
*** apuimedo_ has joined #openstack-horizon06:42
*** apuimedo_ has quit IRC06:47
*** apuimedo_ has joined #openstack-horizon06:49
*** apuimedo_ has quit IRC06:53
*** apuimedo has joined #openstack-horizon06:54
*** KingKhan has joined #openstack-horizon06:56
*** apuimedo has quit IRC06:59
*** wolverineav has joined #openstack-horizon07:00
*** apuimedo_ has joined #openstack-horizon07:01
*** wolverineav has quit IRC07:05
*** apuimedo_ has quit IRC07:14
*** apuimedo_ has joined #openstack-horizon07:15
*** apuimedo_ has quit IRC07:19
mrungemasco_, hey. About all these typo fixes, I don't think we really need a launchpad bug for those. but in general, you're right, and we should have either a blueprint or a launchpad bug for each commit07:19
mrungetsufiev, have you seen this? http://logs.openstack.org/77/257677/3/gate/gate-horizon-dsvm-integration/855c771/logs/apache/horizon_error.txt.gz#_2015-12-16_13_05_17_61178007:20
mrungeTemplateDoesNotExist: horizon/common/_data_table_table_action.html07:20
mrungein integration tests?07:20
mrungetsufiev, ^^^07:20
*** apuimedo_ has joined #openstack-horizon07:20
masco_mrunge, i got it, thanks.07:22
*** apuimedo_ has quit IRC07:30
*** apuimedo_ has joined #openstack-horizon07:31
*** notmorgan has quit IRC07:31
*** mordred has quit IRC07:32
*** tmazur_ has joined #openstack-horizon07:32
*** apuimedo_ has quit IRC07:35
*** apuimedo_ has joined #openstack-horizon07:36
*** mohankumar has quit IRC07:37
*** btully has joined #openstack-horizon07:44
*** apuimedo_ has quit IRC07:47
*** apuimedo_ has joined #openstack-horizon07:49
*** btully has quit IRC07:49
*** e0ne has joined #openstack-horizon07:50
*** e0ne has quit IRC07:52
*** apuimedo_ has quit IRC07:53
*** ygl has joined #openstack-horizon07:53
*** ygl has left #openstack-horizon07:54
*** apuimedo_ has joined #openstack-horizon07:55
*** alexvictorchan has quit IRC07:58
*** apuimedo_ has quit IRC07:59
*** apuimedo_ has joined #openstack-horizon08:01
openstackgerritMerged openstack/horizon: Misspelling in message  https://review.openstack.org/26087108:10
*** KingKhan has quit IRC08:10
*** apuimedo_ has quit IRC08:11
*** KingKhan has joined #openstack-horizon08:12
*** apuimedo_ has joined #openstack-horizon08:12
*** ybathia has quit IRC08:13
*** apuimedo_ has quit IRC08:17
*** apuimedo_ has joined #openstack-horizon08:18
openstackgerritWang Bo proposed openstack/horizon: Remove not required packages in requirements.txt  https://review.openstack.org/26042508:22
*** apuimedo_ has quit IRC08:32
*** apuimedo_ has joined #openstack-horizon08:34
*** KingKhan has quit IRC08:38
*** kzaitsev_mb has joined #openstack-horizon08:39
*** vgridnev has quit IRC08:40
*** errolpais has quit IRC08:42
*** apuimedo_ has quit IRC08:43
*** apuimedo has joined #openstack-horizon08:44
*** openstackgerrit has quit IRC08:47
*** openstackgerrit has joined #openstack-horizon08:48
*** e0ne has joined #openstack-horizon08:52
*** teju has joined #openstack-horizon08:52
*** mohankumar has joined #openstack-horizon08:53
*** apuimedo has quit IRC08:53
*** itxaka has joined #openstack-horizon08:54
*** apuimedo has joined #openstack-horizon08:54
*** wolverineav has joined #openstack-horizon08:56
*** wolverineav has joined #openstack-horizon08:56
*** apuimedo has quit IRC08:59
*** KingKhan has joined #openstack-horizon09:00
*** apuimedo_ has joined #openstack-horizon09:01
*** e0ne has quit IRC09:01
*** apuimedo_ has quit IRC09:06
*** apuimedo_ has joined #openstack-horizon09:07
*** JeanBriceCombebi has joined #openstack-horizon09:08
*** JeanBriceCombebi has quit IRC09:09
*** apuimedo_ has quit IRC09:11
*** apuimedo_ has joined #openstack-horizon09:13
*** rcernin has joined #openstack-horizon09:16
*** zhurong has quit IRC09:17
*** apuimedo_ has quit IRC09:18
*** apuimedo_ has joined #openstack-horizon09:19
^Gal^Hi, I wanna show a tooltip (cell_attributes_getter=getHoverHelp) on column which will show the output of another column. can I achieve that?09:21
*** kzaitsev_mb has quit IRC09:22
*** apuimedo_ has quit IRC09:24
*** apuimedo_ has joined #openstack-horizon09:24
*** wolverineav has quit IRC09:33
*** apuimedo_ has quit IRC09:34
*** apuimedo_ has joined #openstack-horizon09:34
*** aortega has quit IRC09:35
*** apuimedo_ has quit IRC09:41
*** jacky-zhang has quit IRC09:41
*** apuimedo_ has joined #openstack-horizon09:42
*** mohankumar has quit IRC09:43
*** apuimedo_ has quit IRC09:51
*** apuimedo_ has joined #openstack-horizon09:53
*** rcernin has quit IRC09:56
openstackgerritJulia Varlamova proposed openstack/manila-ui: Add share instances to manila-ui  https://review.openstack.org/26055409:59
*** apuimedo_ has quit IRC10:00
*** apuimedo_ has joined #openstack-horizon10:01
*** zhenguo has quit IRC10:01
*** e0ne has joined #openstack-horizon10:05
*** apuimedo_ has quit IRC10:05
*** apuimedo_ has joined #openstack-horizon10:07
*** aix has joined #openstack-horizon10:10
*** masco_ has quit IRC10:13
*** EmilienM has quit IRC10:27
*** EmilienM has joined #openstack-horizon10:27
*** zhurong has joined #openstack-horizon10:33
*** zhurong has quit IRC10:46
*** kzaitsev_mb has joined #openstack-horizon10:46
*** zhurong has joined #openstack-horizon10:47
*** wolverineav has joined #openstack-horizon10:47
*** wolverineav has quit IRC10:53
*** sambetts has quit IRC10:54
*** mpavlase has joined #openstack-horizon11:00
*** mohankumar has joined #openstack-horizon11:05
*** teju has quit IRC11:08
*** aortega has joined #openstack-horizon11:16
*** aortega has quit IRC11:28
*** aortega has joined #openstack-horizon11:29
*** tosky has joined #openstack-horizon11:33
*** amotoki has joined #openstack-horizon11:52
*** mohankumar has quit IRC11:53
*** wolverineav has joined #openstack-horizon11:58
*** wolverineav has quit IRC12:04
*** notmorgan has joined #openstack-horizon12:06
*** mordred has joined #openstack-horizon12:06
*** vgridnev has joined #openstack-horizon12:08
*** openstackgerrit has quit IRC12:17
*** openstackgerrit has joined #openstack-horizon12:18
*** zhenguo has joined #openstack-horizon12:24
openstackgerritItxaka Serrano Garcia proposed openstack/horizon: Enhances tox to not rely on run_tests  https://review.openstack.org/25901312:24
*** slunkad has quit IRC12:36
*** vkmc_afk is now known as vkmc12:46
*** KingKhan has quit IRC12:48
*** slunkad has joined #openstack-horizon12:49
^Gal^Hi, I wanna show a tooltip (cell_attributes_getter=getHoverHelp) on column which will show the output of another column. can I achieve that?12:54
*** lblanchard has joined #openstack-horizon13:00
*** notmorgan has quit IRC13:09
*** mordred has quit IRC13:10
itxaka^Gal^, I dont think you can if Im reading the code properly13:10
^Gal^yeah I thought so too13:10
itxakalooks like cell_attributes_getter is only passing the actual data for the affected column instead of the row13:11
itxakaso you will get only that column data :(13:11
itxakaYou could always create your own cell class as a child of Cell and override the get_data method to pass the whole row13:12
^Gal^sounds cool thanks I'll try13:13
itxakaor maybe you can create a patch upstream for that13:13
itxakaseems liek a very easy change :)13:14
^Gal^I'll dig in :) thanks13:14
*** jear has joined #openstack-horizon13:17
jearhi13:17
jearI am using devstack stable/liberty and when I try to display heat events in horizon I get some errors13:18
*** dslevin_ has quit IRC13:19
*** med_ has quit IRC13:21
*** dslevin has joined #openstack-horizon13:22
*** deray has quit IRC13:32
*** wolverineav has joined #openstack-horizon13:47
openstackgerritItxaka Serrano Garcia proposed openstack/horizon: Enhances tox to not rely on run_tests  https://review.openstack.org/25901313:48
*** wolverineav has quit IRC13:51
*** kzaitsev_mb has quit IRC14:00
*** mpavlase has quit IRC14:10
*** zhurong has quit IRC14:14
*** ducttape_ has joined #openstack-horizon14:15
*** bradjones has quit IRC14:16
*** peristeri has joined #openstack-horizon14:20
*** jasondotstar_ is now known as jasondotstar14:25
*** alexvictorchan has joined #openstack-horizon14:25
*** crobertsrh has joined #openstack-horizon14:34
*** crobertsrh has left #openstack-horizon14:47
*** jtriley has joined #openstack-horizon14:47
*** zhenguo has quit IRC14:56
*** breitz has quit IRC14:58
*** breitz has joined #openstack-horizon14:59
*** piet has joined #openstack-horizon15:07
*** erlon has joined #openstack-horizon15:11
*** btully has joined #openstack-horizon15:16
*** jtriley has quit IRC15:16
*** Guest7726 has joined #openstack-horizon15:17
jearhello15:17
jearwhen I try to display heat stak event in horizon, I get error in /var/log/apache2/horizon_error.log15:18
*** mohankumar has joined #openstack-horizon15:18
*** mohankumar has quit IRC15:18
jearAttributeError at /project/stacks/stack/6c4832fb-3eee-4ab3-9ea1-b84408a36e73/  resource_type  Request Method: GET Request URL: http://10.16.2.11/dashboard/project/stacks/stack/6c4832fb-3eee-4ab3-9ea1-b84408a36e73/?tab=stack_details__events Django Version: 1.8.7 Exception Type: AttributeError Exception Value:   resource_type  Exception Location: /usr/local/lib/python2.7/dist-packages/heatclient/openstack/common/apiclient15:19
jearError during template rendering  In template /opt/stack/horizon/horizon/templates/horizon/common/_data_table_cell.html, error at line 3715:19
jearresource_type 27                 <div class="table_cell_data_wrapper"> 28                     {% if cell.wrap_list %}<ul>{% endif %}{{ cell.value }}{% if cell.wrap_list %}</ul>{% endif %} 29                 </div> 30                 <div class="table_cell_action"> 31                     <button class="ajax-inline-edit"><span class="fa fa-pencil"></span></button> 32                 </div> 33                 <div class="15:20
*** mohankumar has joined #openstack-horizon15:21
zaopastesites are nice15:22
jearheat event-list ... works fine in CLI15:22
*** qadaemon has joined #openstack-horizon15:22
jearrigh zao15:22
*** akulshin has joined #openstack-horizon15:23
jearwill do15:23
jearhttp://pastebin.com/Bf3ViPv015:29
*** jtriley has joined #openstack-horizon15:33
*** kzaitsev_mb has joined #openstack-horizon15:34
*** piet has quit IRC15:34
*** akulshin has quit IRC15:35
*** wolverineav has joined #openstack-horizon15:35
*** gariveradlt has joined #openstack-horizon15:37
*** wolverineav has quit IRC15:39
*** piet has joined #openstack-horizon15:40
*** akulshin has joined #openstack-horizon15:41
*** kzaitsev_mb has quit IRC15:44
*** gomarivera has joined #openstack-horizon15:45
*** gomarivera has quit IRC15:46
*** kzaitsev_mb has joined #openstack-horizon15:52
*** akulshin has quit IRC15:55
*** vkmc is now known as vkmc_afk15:58
*** ducttape_ has quit IRC15:58
*** ducttape_ has joined #openstack-horizon16:06
*** ducttape_ has quit IRC16:15
*** kzaitsev_mb has quit IRC16:17
*** kzaitsev_mb has joined #openstack-horizon16:23
*** vgridnev has quit IRC16:33
*** vgridnev has joined #openstack-horizon16:34
*** crobertsrh has joined #openstack-horizon16:34
*** amotoki has quit IRC16:36
*** crobertsrh has quit IRC16:36
*** e0ne has quit IRC16:40
*** mordred has joined #openstack-horizon16:42
*** tyagiprince2010 has joined #openstack-horizon16:46
jearhi there16:46
jearshould I log an error for that : http://pastebin.com/Bf3ViPv016:46
tyagiprince2010I am trying to change the top navigation bar color..16:47
tyagiprince2010I tried changing the color value in _variables.scss but it is not changing..16:48
hurgleburglerwhich _variables.scss did you change it in?16:50
hurgleburglerare you using a custom theme?16:50
hurgleburglerAlso, any change to a .scss file might require running compress and collectstatic again16:51
*** vkmc_afk is now known as vkmc17:00
*** vgridnev has quit IRC17:05
*** jear has quit IRC17:19
*** wolverineav has joined #openstack-horizon17:23
*** wolverineav has quit IRC17:28
*** e0ne has joined #openstack-horizon17:33
openstackgerritTimur Sufiev proposed openstack/horizon: Move integration_tests.tests.decorators one level up  https://review.openstack.org/26106317:37
openstackgerritTimur Sufiev proposed openstack/horizon: Simplify tables page regions  https://review.openstack.org/26106417:37
*** mohankumar has quit IRC17:40
tsufievhurgleburgler, hi!17:44
tsufievhurgleburgler, btw, do theme-ability work in stable/kilo?17:44
tsufievlol, a got a feedback from our service engineer about http://docs.openstack.org/developer/horizon/topics/customizing.html#customizing-the-logo and stable/kilo: 'This manual is rather an ad, not a manual'17:45
*** kzaitsev_mb has quit IRC17:46
hurgleburglerIn kilo?  Not really17:49
tsufievhurgleburgler, are we supposed to customize templates in a custom theme dir in kilo?17:49
hurgleburglerthey made it easier to load a custom .scss file, but nothing in Horizon was really retrofitted to ingest the theme properly yet17:49
tsufiev:(17:50
openstackgerritMichael Krotscheck proposed openstack/horizon: Enable semi-spacing  https://review.openstack.org/24492017:50
openstackgerritMichael Krotscheck proposed openstack/horizon: Enable brace-style  https://review.openstack.org/24998117:50
openstackgerritMichael Krotscheck proposed openstack/horizon: Enable no-extra-parens  https://review.openstack.org/24998017:50
openstackgerritMichael Krotscheck proposed openstack/horizon: Enable callback-return  https://review.openstack.org/24830217:50
openstackgerritMichael Krotscheck proposed openstack/horizon: Enable block-scoped-var  https://review.openstack.org/24992617:50
openstackgerritMichael Krotscheck proposed openstack/horizon: Enable consistent-return  https://review.openstack.org/24830317:50
openstackgerritMichael Krotscheck proposed openstack/horizon: Enable "no-new" and "guard-for-in"  https://review.openstack.org/24992417:50
openstackgerritMichael Krotscheck proposed openstack/horizon: Enable no-undefined  https://review.openstack.org/24992517:50
openstackgerritMichael Krotscheck proposed openstack/horizon: Enable no-redeclare  https://review.openstack.org/24493017:50
hurgleburglerThe custom templates change was added in Liberty17:50
hurgleburglerBUT, that's super easy to do17:50
hurgleburglerJust append your custom theme dir in local_settings.py to the TEMPLATE_DIRS17:50
*** rajatvig has joined #openstack-horizon17:51
tsufievhurgleburgler, that's hardly a recipe for people whose only option is kilo-based distro :))17:51
tsufievokay, seems he had to just edit base.html in place to provide custom footer17:51
hurgleburglerthat's messy :-/17:52
krotschecktsufiev, hurgleburgler Seeking opinions on https://review.openstack.org/#/c/249983/17:52
tsufievkrotscheck, hmm, a new series of patches17:53
krotschecktsufiev: I reordered them.17:53
krotschecktsufiev: Mostly because people were squatting on the callback-return rule without engaging in discussion.17:54
* krotscheck is not going to name any names.17:54
tsufievsaying 'I have a bad feeling about this' can be seen as an initiating a discussion )17:55
*** kzaitsev_mb has joined #openstack-horizon17:55
tsufievunfortunately, nobody else cared to prove or refute my opinion17:55
krotschecktsufiev: Not directed at you :-P17:56
krotscheckAnd I provided several counterarguments to your concern.17:57
hurgleburglerIf by discussion, you just mean arguing until I change my mind17:57
krotscheckhurgleburgler: Hi there!17:57
hurgleburglerHorizon's javascript code base size is going to balloon very soon, so I can see that as becoming more annoying as time goes by17:58
hurgleburglerjust because there is only 1 instance now, doesn't mean I don't foresee many in the future17:58
krotscheckhurgleburgler: Because horizon uses the callback pattern?17:58
* krotscheck was under the impression that angularjs uses promises to fill that need, but he could be wrong.17:59
krotscheckOr is horizon going to become a node app? Because node uses the callback pattern everywhere, in which case that rule's going to become pretty critical. I'm not as up-to-date with what's on the roadmap, so I could be wrong.18:01
krotscheckhurgleburgler: But just saying "It might be annoying in the future" is not an argument. That's fillibustering.18:02
tsufievkrotscheck, well, there are not just 3 of us in the community, you'll have the chance to discuss proposed changes in a wider audience once the Christmas holidays are oer18:02
hurgleburglerand saying "its not a big deal right now" is along the same lines18:02
tsufiev*over18:02
krotscheckhurgleburgler: My argument is "Horizon does not use a framework that makes use of callbacks. It uses promises instead."18:03
*** gariveradlt has quit IRC18:03
krotscheckAlso, discussions usually involve constructive alternatives. :)18:04
krotschecktsufiev: I get that.18:04
krotschecktsufiev: That's why the eslint project usually waits for a bunch of people to weigh in before approving anything.18:05
krotscheckIt's just not on enough people's radar to check.18:05
tsufievyep, it's very quiet here this and previous week18:05
tsufievand the next one I think will be quiet too18:06
hurgleburglerMost people won't be back until after January 4th18:06
*** piet has quit IRC18:09
krotscheckYeah, I'm spending next week digging into bower to help them land their lockfile feature to build karma.18:11
*** errolpais has joined #openstack-horizon18:11
krotscheckHopefully they'll be more inclined to accept the patches that openstack needs :)18:11
*** apuimedo_ has quit IRC18:19
*** apuimedo_ has joined #openstack-horizon18:20
rhagarty__I know most folks are off today, but I'm looking for some help on data refresh. Any interest?18:25
*** kzaitsev_mb has quit IRC18:33
*** erlon has quit IRC18:36
*** apuimedo_ has quit IRC18:38
*** apuimedo_ has joined #openstack-horizon18:40
mrungekrotscheck, if you're looking for reviews on your code, you should be willing to do reviews on others code yourself.18:42
mrungethat immensely helps to get the review queue down18:42
mrunge*hint*18:42
krotscheckmrunge: If I do that you might accidentally make me a core.18:42
mrungedon't bet on that18:43
mrunge:P18:43
mrungeand actually that's a weak argument for not reviewing foreign code18:43
*** piet has joined #openstack-horizon18:45
krotscheckmrunge: *shrug* My work is focused elsewhere. My work on the eslint rules was done as a courtesy to horizon, but if you don't want it I can abandon it anytime.18:47
krotscheckIn the meantime, I'm happily improving the infra ecosystem in ways that directly benefit horizon.18:47
*** apuimedo_ has quit IRC18:47
mrungekrotscheck, I was under the impression, you were just submitting code for review, actually pinging folks for review, but never reviewing yourself18:48
mrungebut I may be wrong18:48
*** apuimedo_ has joined #openstack-horizon18:48
mrungeI'd be happy to be proven wrong18:49
krotscheckmrunge: Are you saying that contributing code to openstack comes with an obligation to review?18:49
mrungekrotscheck, that is somehow connected; if nobody reviews, nothing gets merged, no?18:50
krotscheckmrunge: And I'm very engaged on all patches that are submitted against eslint-config-openstack, the various mirror patches on infra, ironci-webclient, and oslo middleware.18:51
krotscheckI would _love_ to see more contributions against those projects.18:52
krotscheckHow about we trade off?18:52
krotscheckI'll help review horizon code, and you'll help build the ironic webclient?18:52
mrungehahaha. unfortunately I'm that blocked by reviews here, I don't have time to even submit new code to horizon18:53
mrunges/blocked/kept busy/18:53
mrungethat's why I'm asking for reviews ;-)18:53
krotscheckmrunge: Seems like we're on opposite sides of the same problem. You have too many reviews, I don't have enough contributors.18:54
krotscheckSo I totally get why you're feeling overwhelmed. I feel the same way, though my problem is "too much code that needs written and not enough help", while yours is "too much code to review and not enough help"18:55
krotscheckBut please don't give me a hard time for not helping you out, if you're not able to help me out, ok?18:58
*** piet has quit IRC18:59
*** apuimedo_ has quit IRC19:00
openstackgerritErrol Pais proposed openstack/horizon: Launch Instance - Nova API for Download Key Pair  https://review.openstack.org/25818719:01
*** apuimedo_ has joined #openstack-horizon19:02
mrungekrotscheck, I'm asking you the same I'm asking others; I completely agree reviews in horizon take way too long.19:04
mrungekrotscheck, we had some patches celebrating their first birthday in review queue19:05
krotscheckmrunge: wow.19:05
mrungethat's acutally quite a shame.19:05
tsufievmrunge,  krotscheck: better coverage is the answer to the problem of insufficient reviews. Being more confident that code doesn't break anything, human reviewer will be able to make more/ better reviewers19:05
*** hurgleburgler has quit IRC19:05
* tsufiev is advertising contributions to integration tests :D19:06
krotschecktsufiev: Dude, you're speaking my language.19:06
* krotscheck has the ironic-webclient over 80% covered at this point :)19:06
*** apuimedo_ has quit IRC19:06
tsufievkrotscheck: so you could help poor horizon ;)19:07
krotschecktsufiev: I intend to.19:07
krotschecktsufiev: There's one major piece missing though.19:07
*** hurgleburgler has joined #openstack-horizon19:07
*** hurgleburgler has quit IRC19:07
*** apuimedo has joined #openstack-horizon19:08
krotschecktsufiev: Fixing bower :/19:08
tsufievI was half joking actually, but making openstack better is still an art of compromise for many of us :/19:08
krotschecktsufiev: (that's my new years project)19:08
tsufievSince different people have different agendas19:08
krotscheckNo kidding19:08
tsufievkrotscheck: thank you for that19:09
* tsufiev meant bower stuff19:09
krotscheckI need to convince the js-* package maintainers for the distros to include bower.json and/or package.json in their packages.19:09
krotscheckAlso, the bower team is _hurting_ for contributors.19:10
krotscheckSo I may disappear there.19:10
*** dslev has quit IRC19:10
krotscheckAaaanyway. Back to building npm mirrors for infra.19:11
*** apuimedo has quit IRC19:15
*** apuimedo has joined #openstack-horizon19:16
openstackgerritErrol Pais proposed openstack/horizon: WIP: Launch Instance - UI for Download Key Pair (Redesign)  https://review.openstack.org/25959319:17
tsufievkrotscheck: is callback return rule the head or the tail of the chain?19:19
krotschecktsufiev: I moved it ot the tail.19:19
tsufievI have a problem orienting in new gerrit19:19
krotscheckAfter brace-style, because brace-style is waiting on a review in eslint-config-openstack.19:19
krotschecktsufiev: I knwo19:19
tsufievOkay, it's good19:19
tsufievOmg, undefined is a property19:21
*** dslevin_ has joined #openstack-horizon19:21
tsufievDidn't know that19:21
krotschecktsufiev: JavaScript. It's like code, except with landmines :D19:25
*** apuimedo has quit IRC19:25
*** e0ne has quit IRC19:26
*** apuimedo has joined #openstack-horizon19:27
*** apuimedo has quit IRC19:32
*** wolverineav has joined #openstack-horizon19:32
*** apuimedo has joined #openstack-horizon19:33
*** wolverineav has quit IRC19:33
*** wolverineav has joined #openstack-horizon19:34
*** Ephur has joined #openstack-horizon19:36
*** rhagarty__ has quit IRC19:38
*** apuimedo has quit IRC19:40
*** apuimedo_ has joined #openstack-horizon19:41
*** boltR_ is now known as boltR19:42
boltRquestion about the policy.json file19:46
boltRwhy would i want to have a copy of it in horizon if the API has it already?19:46
boltRdoes it improve performance?19:46
tsufievboltR, no, it doesn19:50
tsufiev*doesn´t19:50
tsufievboltR, the reason is that there is no API call for checking policy, so horizon needs to check it on its side (duplication of knowledge and efforts)19:51
*** itxaka has quit IRC19:51
boltRtsufiev: ah I see19:52
*** itxaka has joined #openstack-horizon19:52
boltRinteresting thanks19:52
*** apuimedo_ has quit IRC19:53
tsufievyouŕe welcome19:54
*** apuimedo_ has joined #openstack-horizon19:54
itxakaAre we gonna do the drivers meeting?19:54
itxakawith so few people :s19:54
*** apuimedo_ has quit IRC19:58
*** apuimedo_ has joined #openstack-horizon20:00
tsufievitxaka, all meetings have been canceled until Jan 620:03
itxakaahh20:03
itxakathen the wiki needs an update :D20:03
itxakabecause still reads == Agenda for 2015-12-23 2000UTC ==20:03
itxakawill update and off to dinner, bye bye!20:03
tsufievitxaka, thanks for taking care, bye!20:04
*** errolpais has quit IRC20:04
*** itxaka has quit IRC20:05
*** e0ne has joined #openstack-horizon20:06
*** tyagiprince2010 has quit IRC20:08
*** aorourke has quit IRC20:09
*** rajatvig has quit IRC20:13
*** apuimedo_ has quit IRC20:14
*** apuimedo_ has joined #openstack-horizon20:15
*** apuimedo_ has quit IRC20:24
*** apuimedo has joined #openstack-horizon20:26
openstackgerritElena S proposed openstack/horizon: [wip] Add test_router integration test  https://review.openstack.org/26036020:28
*** piet has joined #openstack-horizon20:31
pietAnyone around?20:31
piettsufiev ? hurgleburgler ?20:32
pietMaking a simple wireframing tool for Horizon.  Feedback is welcome.  https://docs.google.com/presentation/d/1rmCtUHSd17vtUUMFYsdHUh6B9pYUX-5LrVox3hVK25M/edit?usp=sharing20:33
*** apuimedo has quit IRC20:38
*** apuimedo_ has joined #openstack-horizon20:40
*** apuimedo_ has quit IRC20:45
*** apuimedo_ has joined #openstack-horizon20:46
*** e0ne has quit IRC20:48
*** apuimedo_ has quit IRC20:51
*** apuimedo_ has joined #openstack-horizon20:51
openstackgerritElena S proposed openstack/horizon: [wip] Add test_router integration test  https://review.openstack.org/26036020:52
*** apuimedo_ has quit IRC20:56
*** apuimedo_ has joined #openstack-horizon20:57
*** rajatvig has joined #openstack-horizon20:57
*** qadaemon has quit IRC21:00
*** jtriley has quit IRC21:00
*** apuimedo_ has quit IRC21:01
*** apuimedo_ has joined #openstack-horizon21:02
*** rajatvig has quit IRC21:03
*** ducttape_ has joined #openstack-horizon21:06
*** apuimedo_ has quit IRC21:07
*** apuimedo_ has joined #openstack-horizon21:07
*** apuimedo_ has quit IRC21:12
*** piet has quit IRC21:12
*** apuimedo_ has joined #openstack-horizon21:12
*** rajatvig has joined #openstack-horizon21:18
*** lblanchard has quit IRC21:20
*** apuimedo_ has quit IRC21:22
*** apuimedo_ has joined #openstack-horizon21:22
*** errolpais has joined #openstack-horizon21:28
*** apuimedo_ has quit IRC21:29
*** apuimedo_ has joined #openstack-horizon21:31
*** apuimedo_ has quit IRC21:39
tsufievpiet: will take a look tomorrow21:40
*** apuimedo_ has joined #openstack-horizon21:40
*** ducttape_ has quit IRC21:42
*** kzaitsev_mb has joined #openstack-horizon21:44
*** ducttape_ has joined #openstack-horizon22:02
*** vkmc is now known as vkmc_afk22:14
*** rajatvig has quit IRC22:18
*** rajatvig has joined #openstack-horizon22:19
*** peristeri has quit IRC22:19
*** openstack has joined #openstack-horizon22:23
*** e0ne has joined #openstack-horizon22:28
*** piet has joined #openstack-horizon22:29
*** piet has quit IRC22:33
*** piet has joined #openstack-horizon22:33
*** e0ne has quit IRC22:33
*** openstackstatus has quit IRC22:35
*** openstack has joined #openstack-horizon22:38
*** piet has quit IRC22:46
*** piet has joined #openstack-horizon22:46
*** Ephur has quit IRC23:02
openstackgerritRajat Vig proposed openstack/horizon: WIP: Add volumes panel that uses angular.js  https://review.openstack.org/21677823:06
openstackgerritRajat Vig proposed openstack/horizon: Add Angular Directive to show msg for empty tables  https://review.openstack.org/17503523:27
*** wolverin_ has joined #openstack-horizon23:30
*** piet has quit IRC23:31
*** wolverineav has quit IRC23:34
*** wolverin_ has quit IRC23:35
*** rajatvig has quit IRC23:38
*** tosky has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!