Friday, 2015-12-11

*** david-lyle_ has quit IRC00:02
*** chestack has quit IRC00:03
*** hurgleburgler has quit IRC00:04
*** hurgleburgler has joined #openstack-horizon00:08
*** Daisy has joined #openstack-horizon00:08
*** ianbrown__ has quit IRC00:10
*** ianbrown_ has joined #openstack-horizon00:10
*** Daisy has quit IRC00:13
*** kzaitsev_mb has quit IRC00:14
*** ianbrown_ has quit IRC00:16
*** ianbrown_ has joined #openstack-horizon00:17
*** rajatvig has joined #openstack-horizon00:17
*** david-lyle_ has joined #openstack-horizon00:18
*** hurgleburgler has quit IRC00:18
*** hurgleburgler has joined #openstack-horizon00:20
*** hurgleburgler has quit IRC00:21
*** ianbrown_ has quit IRC00:21
*** rajatvig has quit IRC00:21
*** TravT has joined #openstack-horizon00:22
*** ianbrown_ has joined #openstack-horizon00:22
*** dslevin has joined #openstack-horizon00:23
*** nlahouti has quit IRC00:24
*** nlahouti has joined #openstack-horizon00:24
*** chestack has joined #openstack-horizon00:26
*** dslevin has quit IRC00:27
*** chestack has quit IRC00:31
*** nlahouti1 has joined #openstack-horizon00:38
*** nlahouti has quit IRC00:40
*** Piet has quit IRC00:42
*** TravT has quit IRC00:43
openstackgerritRichard Jones proposed openstack/horizon: WIP: Add angular Swift interface  https://review.openstack.org/25613200:43
*** nlahouti1 has quit IRC00:44
*** swati has joined #openstack-horizon00:44
swatiHi Mathhias [mrunge_] : I have updated the BP : https://blueprints.launchpad.net/horizon/+spec/display-host-aggregate-resources00:45
swatiKIndly take a look at it00:45
*** nlahouti has joined #openstack-horizon00:46
*** Drago1 has joined #openstack-horizon00:46
*** Drago1 has quit IRC00:47
*** swati has quit IRC00:50
*** chlong has joined #openstack-horizon00:52
openstackgerritDan Nguyen proposed openstack/horizon: Retrieve domain scoped token  https://review.openstack.org/14808200:54
*** chestack has joined #openstack-horizon00:57
*** RichardRaseley has quit IRC01:00
*** rajatvig has joined #openstack-horizon01:02
*** rajatvig has left #openstack-horizon01:03
*** shu-mutou has joined #openstack-horizon01:03
*** tqtran has quit IRC01:05
*** nlahouti has quit IRC01:07
*** chestack has quit IRC01:13
*** kzaitsev_mb has joined #openstack-horizon01:15
*** mtanino has quit IRC01:15
*** dslevin has joined #openstack-horizon01:17
*** chestack has joined #openstack-horizon01:19
*** dslevin has quit IRC01:21
*** chestack has quit IRC01:26
*** jtriley has joined #openstack-horizon01:28
*** SurajD has quit IRC01:29
openstackgerritErrol Pais proposed openstack/horizon: WIP: Launch Instance - Download Private Key  https://review.openstack.org/24944201:29
*** SurajD has joined #openstack-horizon01:30
*** kzaitsev_mb has quit IRC01:31
*** ianbrown_ has quit IRC01:32
*** ianbrown_ has joined #openstack-horizon01:32
*** david-lyle has joined #openstack-horizon01:37
*** ChanServ sets mode: +o david-lyle01:37
*** zhurong has joined #openstack-horizon01:54
*** kzaitsev_mb has joined #openstack-horizon01:57
*** jamielennox is now known as jamielennox|away02:01
*** bpokorny_ has joined #openstack-horizon02:05
*** ianbrown_ is now known as ianbrown02:05
*** zhurong has quit IRC02:07
*** zhurong has joined #openstack-horizon02:07
*** bpokorny has quit IRC02:09
*** bpokorny_ has quit IRC02:10
*** ianbrown has quit IRC02:15
*** ianbrown has joined #openstack-horizon02:15
*** petertr7_away is now known as petertr702:17
*** david-lyle_ has quit IRC02:21
openstackgerritKenji Ishii proposed openstack/horizon: Add function to re-create ec2 credential  https://review.openstack.org/25219002:21
*** david-lyle_ has joined #openstack-horizon02:21
*** jtriley has quit IRC02:22
*** reedip has quit IRC02:25
*** slogan621 has joined #openstack-horizon02:27
*** jamielennox|away is now known as jamielennox02:29
*** ZZelle_ has quit IRC02:29
*** jingjing_ren has quit IRC02:31
*** lhcheng_ has quit IRC02:31
*** kzaitsev_mb has quit IRC02:34
*** kzaitsev_mb has joined #openstack-horizon03:00
*** tjones has joined #openstack-horizon03:06
*** slogan621 has quit IRC03:08
*** tjones has quit IRC03:08
openstackgerritLi Yingjun proposed openstack/horizon: Fix update/create image when using v2  https://review.openstack.org/25167203:10
*** david-lyle_ has quit IRC03:18
openstackgerritRichard Jones proposed openstack/horizon: WIP: Add Swift REST API  https://review.openstack.org/25614003:19
*** tjones has joined #openstack-horizon03:20
*** reedip has joined #openstack-horizon03:21
*** jwy has quit IRC03:40
*** kzaitsev_mb has quit IRC03:40
*** yamamoto has joined #openstack-horizon03:55
*** bpokorny has joined #openstack-horizon03:59
*** chestack has joined #openstack-horizon04:02
*** kzaitsev_mb has joined #openstack-horizon04:06
*** chestack has quit IRC04:13
*** lhcheng has joined #openstack-horizon04:20
*** lhcheng has quit IRC04:25
*** chestack has joined #openstack-horizon04:27
*** garthb has quit IRC04:34
*** ducttape_ has joined #openstack-horizon04:36
*** ducttape_ has quit IRC04:41
*** tjones has quit IRC04:41
*** hurgleburgler has joined #openstack-horizon04:46
*** kzaitsev_mb has quit IRC04:48
*** chestack has quit IRC04:51
*** hurgleburgler has quit IRC05:04
*** hurgleburgler has joined #openstack-horizon05:04
*** chestack has joined #openstack-horizon05:04
*** kzaitsev_mb has joined #openstack-horizon05:15
*** ig0r__ has joined #openstack-horizon05:15
*** nlahouti has joined #openstack-horizon05:18
*** ig0r_ has quit IRC05:19
*** ig0r__ has quit IRC05:21
*** chestack has quit IRC05:30
*** amotoki has joined #openstack-horizon05:31
*** masco has joined #openstack-horizon05:32
*** nlahouti has quit IRC05:34
*** petertr7 is now known as petertr7_away05:36
*** SurajD has quit IRC05:41
*** chestack has joined #openstack-horizon05:41
*** SurajD has joined #openstack-horizon05:43
*** nlahouti has joined #openstack-horizon05:45
*** ttrifonov has quit IRC05:45
*** nlahouti1 has joined #openstack-horizon05:48
*** ttrifonov has joined #openstack-horizon05:49
*** nlahouti has quit IRC05:51
*** bpokorny has quit IRC05:56
*** sudheer has quit IRC05:58
*** lhcheng has joined #openstack-horizon06:09
*** mohankumar has joined #openstack-horizon06:11
*** lhcheng has quit IRC06:13
*** chlong has quit IRC06:15
openstackgerritOpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Zanata  https://review.openstack.org/25623206:19
*** hurgleburgler has quit IRC06:22
*** zhenguo has joined #openstack-horizon06:24
*** vgridnev has joined #openstack-horizon06:25
*** jrist has quit IRC06:33
*** SurajD has quit IRC06:33
*** lhcheng has joined #openstack-horizon06:33
*** jamielennox is now known as jamielennox|away06:33
*** SurajD has joined #openstack-horizon06:34
*** jrist has joined #openstack-horizon06:35
*** jrist has quit IRC06:35
*** jrist has joined #openstack-horizon06:35
*** lhcheng has quit IRC06:38
*** gyee has quit IRC06:38
*** mohankumar has quit IRC06:52
*** nlahouti1 has quit IRC07:00
*** nlahouti has joined #openstack-horizon07:05
*** mohankumar has joined #openstack-horizon07:06
*** nlahouti has quit IRC07:06
*** nlahouti has joined #openstack-horizon07:09
*** steveng has joined #openstack-horizon07:16
*** vgridnev has quit IRC07:17
openstackgerritLi Yingjun proposed openstack/horizon: Fix update/create image when using v2  https://review.openstack.org/25167207:21
openstackgerritLi Yingjun proposed openstack/horizon: Fix update image metadata when using v2  https://review.openstack.org/25170407:22
*** SurajD has quit IRC07:30
*** kzaitsev_mb has quit IRC07:30
*** SurajD has joined #openstack-horizon07:31
*** ig0r_ has joined #openstack-horizon07:32
*** vgridnev has joined #openstack-horizon07:34
stevenghey people.. I cant find create subnet templated in horizon.. I wanna make some changes there..07:36
*** mohankumar has quit IRC07:45
*** nlahouti has quit IRC07:49
*** jprovazn has joined #openstack-horizon07:53
*** agireud has quit IRC08:10
*** itxaka has joined #openstack-horizon08:10
*** ig0r_ has quit IRC08:11
*** belmoreira has joined #openstack-horizon08:13
*** alexvictorchan has joined #openstack-horizon08:18
*** ig0r_ has joined #openstack-horizon08:19
*** rdopiera has joined #openstack-horizon08:20
*** steveng has quit IRC08:22
*** steveng has joined #openstack-horizon08:23
*** mpavlase has joined #openstack-horizon08:23
*** kzaitsev_mb has joined #openstack-horizon08:26
*** JeanBriceCombebi has joined #openstack-horizon08:27
*** kzaitsev_mb has quit IRC08:30
*** vgridnev has quit IRC08:38
*** chestack has quit IRC08:38
*** ygbo has joined #openstack-horizon08:38
*** rcernin has joined #openstack-horizon08:44
*** yamamoto has quit IRC08:47
*** mohankumar has joined #openstack-horizon08:47
*** yamamoto has joined #openstack-horizon08:49
*** chestack has joined #openstack-horizon08:51
*** ig0r_ has quit IRC08:53
*** steveng has quit IRC08:55
openstackgerritItxaka Serrano Garcia proposed openstack/horizon: Add download button for volume transfer creds  https://review.openstack.org/24808208:58
itxakathanks for reminding me of the missing tests robcresswell (⌒▽⌒)09:00
*** JeanBriceCombebi has quit IRC09:06
*** JeanBriceCombebi has joined #openstack-horizon09:08
*** lhcheng has joined #openstack-horizon09:09
*** ig0r_ has joined #openstack-horizon09:20
*** zhurong has quit IRC09:24
*** kzaitsev_mb has joined #openstack-horizon09:26
*** chestack has quit IRC09:31
*** kzaitsev_mb has quit IRC09:31
*** JeanBriceCombebi has quit IRC09:35
openstackgerritJohannes Grassler proposed openstack/django_openstack_auth: Add API version to identity endpoint URLs  https://review.openstack.org/23841909:41
*** aix has joined #openstack-horizon09:42
*** steveng has joined #openstack-horizon09:42
*** chestack has joined #openstack-horizon09:43
*** vgridnev has joined #openstack-horizon09:45
*** vgridnev has quit IRC09:45
*** akulshin has joined #openstack-horizon09:45
*** vgridnev has joined #openstack-horizon09:46
*** ig0r_ has quit IRC09:47
akulshindoes anybody knows how can i find template that draws Edit Project modal window under /horizon/identity/ ?09:50
*** amotoki has quit IRC09:50
*** yamamoto has quit IRC09:51
itxakaakulshin, the edit template is a workflow so its probably horizon/common/_workflow.html09:53
itxakafull path should be horizon/templates/horizon/common/_workflow.html09:53
akulshinin static folder or from where WSWGI script executed?09:55
openstackgerritTimur Sufiev proposed openstack/horizon: Disable "Disassociate floating IP" if instance is in failed state  https://review.openstack.org/25631109:55
itxakashould be where you installed horizon09:58
*** zhenguo has quit IRC10:01
*** JeanBriceCombebi has joined #openstack-horizon10:01
akulshinthanks itxaka! but still cannot find anything close... we have kilo from Mirantis, and in apache configuration i have two separate paths: one for static files (mapped to /horizon/static) and the second one for wsgi script and other django files10:02
*** kzaitsev_mb has joined #openstack-horizon10:03
itxakaI have no idea where the mirantis installer install the files, but you can do a search for them like find / -name "_workflow.html" to see if you can find it10:07
akulshinyes, i already searching by grep -Ri _workflow ./ and find may links and includes of horizon/common/_workflow.html10:08
*** SurajD has quit IRC10:10
*** liangbo has joined #openstack-horizon10:10
*** lhcheng_ has joined #openstack-horizon10:12
*** kzaitsev_mb has quit IRC10:12
jgrasslerGood morning.10:13
jgrasslerCurrently decorator-4.0.5 404s - which trips up https://review.openstack.org/238419 among others. Is this a known problem?10:13
akulshinpath  /horizon executed by wsgi, is there any routing so i can see what executed under /common ?10:14
*** lhcheng has quit IRC10:14
*** SurajD has joined #openstack-horizon10:14
*** josecastroleon has quit IRC10:17
*** JeanBriceCombebi has quit IRC10:23
*** JeanBriceCombebi has joined #openstack-horizon10:24
zigoWhen building django-openstack-auth in Debian Sid, I get this: http://paste.openstack.org/show/481602/10:25
zigoDoes anyone know how to fix?10:25
zigorobcresswell: ^10:25
zigomrunge: ^10:25
zigoIs this a Django 1.9 problem? It seems related to requests 2.8.1 to me...10:26
zigoHum... maybe not.10:26
*** steveng has quit IRC10:29
*** akulshin has quit IRC10:30
robcresswellyeah, 1.9 zigo10:31
robcresswellzigo: See https://review.openstack.org/#/c/255877/10:31
zigoAh, cool ! :)10:32
robcresswellzigo: Please note, this will only fix existing tests; it is likely that other parts are broken, but tests miss them10:32
*** aix has quit IRC10:36
*** e0ne has joined #openstack-horizon10:36
*** tosky has joined #openstack-horizon10:44
*** wolverineav has joined #openstack-horizon10:44
*** mpavlase has quit IRC10:54
*** wolverineav has quit IRC10:58
*** ccesario has quit IRC10:59
*** ccesario has joined #openstack-horizon11:00
*** JeanBriceCombebi has quit IRC11:01
*** JeanBriceCombebi has joined #openstack-horizon11:03
openstackgerritLin Hua Cheng proposed openstack/horizon: Fix duplicate Image URL validation message  https://review.openstack.org/25634611:04
lhcheng_jgrassler: yes, it is a known problem. See: http://lists.openstack.org/pipermail/openstack-dev/2015-December/082035.html11:05
*** chestack has quit IRC11:06
*** ig0r_ has joined #openstack-horizon11:09
*** jprovazn has quit IRC11:12
*** aix has joined #openstack-horizon11:12
*** kzaitsev_mb has joined #openstack-horizon11:16
*** chestack has joined #openstack-horizon11:18
lhcheng_jgrassler: should be fixed now, I ran a recheck on your patch.11:19
openstackgerritTimur Sufiev proposed openstack/horizon: Keep row 'data-display' attr up to date after inline editing a cell  https://review.openstack.org/25636211:22
jgrasslerlhcheng_: Thanks :-)11:28
*** JeanBriceCombebi has quit IRC11:32
*** chlong has joined #openstack-horizon11:33
*** kzaitsev_mb has quit IRC11:43
*** ig0r_ has quit IRC11:46
*** kzaitsev_mb has joined #openstack-horizon11:55
*** akulshin has joined #openstack-horizon12:00
*** julim has joined #openstack-horizon12:06
*** liangbo has quit IRC12:06
*** ig0r_ has joined #openstack-horizon12:15
*** rcernin has quit IRC12:18
*** kzaitsev_mb has quit IRC12:20
*** kzaitsev_mb has joined #openstack-horizon12:22
*** jprovazn has joined #openstack-horizon12:23
*** ig0r_ has quit IRC12:24
*** SurajD has quit IRC12:25
*** SurajD has joined #openstack-horizon12:28
*** petertr7_away is now known as petertr712:30
*** petertr7 is now known as petertr7_away12:39
openstackgerritTimur Sufiev proposed openstack/horizon: Keep row 'data-display' attr up to date after inline editing a cell  https://review.openstack.org/25636212:49
openstackgerritjaveme proposed openstack/horizon: Taking into account the exception with status_code  https://review.openstack.org/25639312:51
*** SurajD has quit IRC12:59
*** dslevin has joined #openstack-horizon13:00
*** SurajD has joined #openstack-horizon13:02
*** ducttape_ has joined #openstack-horizon13:05
*** pauloewerton has joined #openstack-horizon13:07
*** ig0r_ has joined #openstack-horizon13:16
vgridnevhi folks, is it possible to merge the following fix to horizon/liberty: https://review.openstack.org/#/c/256399/ ? It affects only stable/liberty, because in current upstream sahara-dashboard was moved to separate repo13:18
vgridnevAlso fix is quite simple13:18
*** mohankumar has quit IRC13:19
robcresswellvgridnev: Is it already in sahara-dashboard?13:19
vgridnevyes13:19
robcresswellShoule be fine then13:19
robcresswellShould*13:19
robcresswellThat should satisfy the in-master-branch requirement.13:19
robcresswellIt may be worth referencing that in the commit message for other reviews, vgridnev13:20
openstackgerritSayali Lunkad proposed openstack/horizon: Adds option to deactivate glance image from horizon  https://review.openstack.org/25640113:20
vgridnevrobcresswell, done13:22
robcresswellvgridnev: Nice work. mrunge, could you take a look at https://review.openstack.org/#/c/256399 ?13:23
*** ig0r_ has quit IRC13:25
*** ducttape_ has quit IRC13:27
*** akulshin has quit IRC13:27
*** lblanchard has joined #openstack-horizon13:30
*** liangbo has joined #openstack-horizon13:41
*** aortega has quit IRC13:53
*** _crobertsrh is now known as crobertsrh13:53
*** jrist has quit IRC13:56
*** lhcheng_ has quit IRC13:58
*** jrist has joined #openstack-horizon13:58
*** jrist has quit IRC13:58
*** jrist has joined #openstack-horizon13:58
*** mflobo has joined #openstack-horizon14:08
mfloboI have some questions about AngularJS panels in Horizon, anyone is up to help me :) ? thanks in advance14:12
tsufievmflobo, most of people you need are still sleeping14:14
*** jrist has quit IRC14:14
mflobotsufiev, :)14:14
*** jrist has joined #openstack-horizon14:14
tsufievmflobo, we have some kind of TZ/technology stack separation here: Django is for Europe, Angular is for America :)14:15
mflobotsufiev, I see14:15
tsufievconservative vs. innovative :)14:15
mfloboXD14:15
openstackgerritOpenStack Proposal Bot proposed openstack/tuskar-ui: Updated from global requirements  https://review.openstack.org/23905814:16
*** breitz has quit IRC14:19
*** breitz has joined #openstack-horizon14:19
*** matt-borland has joined #openstack-horizon14:19
*** JeanBriceCombebi has joined #openstack-horizon14:25
tsufievmflobo, perhaps matt-borland could help you14:26
matt-borlandmflobo, just logged in here, what's up? :)14:26
*** peristeri has joined #openstack-horizon14:29
*** deray has joined #openstack-horizon14:31
*** aortega has joined #openstack-horizon14:38
*** liangbo has quit IRC14:38
tsufievmatt-borland, hmm, seems that he figured out the answer to his angular question himself14:38
matt-borlandno problem...how are things tsufiev ?14:39
*** matt-borland has quit IRC14:39
*** matt-borland has joined #openstack-horizon14:39
tsufievmatt-borland, things are going well :)14:40
matt-borlandgood!  I'm about ready to go on vacation for a few weeks starting next Wed.14:40
*** matt-borland has quit IRC14:40
*** matt-borland has joined #openstack-horizon14:41
doug-fishtsufiev: lol @ your description of Django vs Angular!14:41
*** ig0r_ has joined #openstack-horizon14:41
tsufievdoug-fish, as I said, we have 2 parties :)14:41
tsufievmatt-borland, Merry Christmas then!14:42
matt-borlandsame to you!  2 parties is better than one? :)14:42
tsufievhope your work on ng panels standardization is going well14:42
tsufiev2 is always better than one :)14:43
tsufievit means there is still some movement and no stagnation14:43
*** ig0r_ has quit IRC14:43
matt-borlandit's never as fast as you'd like, but there is some progress14:43
matt-borlandwe're getting a lot of good adoption by other panel development14:44
matt-borlandwhich is giving us a lot of good insight/direction14:44
tsufievhave you reached some kind of consensus about table directives level of verbosity/boilerplate code?14:44
*** jtriley has joined #openstack-horizon14:45
matt-borlandno, actually the plan is to allow for 3 levels of non-conflicting markup14:45
matt-borland1) verbose - basically raw html14:45
tsufievdoug-fish, btw, has david-lyle contacted you about verifying the solution for sahara-dashboard/horizon integration tests?14:45
matt-borland2) directive-wrapped at a higher level14:46
matt-borland3) completely directive wrapped (data/config-driven)14:46
tsufievwow, I imagined just 2 levels :)14:46
matt-borlandthe resulting markup is all the same.  It's up to the dev to determine the appropriate level of.14:46
tsufievshould be even more flexible with 314:46
matt-borlandlevel of application14:46
matt-borland2 is all we've really got examples of14:46
matt-borlandthe third has a lot of limitations14:47
matt-borlandso it's arguably less valuable14:47
matt-borlandmost people like having some markup14:47
matt-borlandso those first 2 levels are really useful14:47
tsufievgot it14:48
matt-borlandI think the big challenge is to ensure we are using the extensibility options available to us14:48
matt-borlandand that those are documented, etc14:48
tsufievmatt-borland, yes, documentation is we all should work on14:51
tsufievI still have to write developer docs for integration tests, that will aid other horizoneers to write tests for the new functionality they're introducing14:51
tsufievhope it will have its readers :)14:51
matt-borlandis there anything you want help with?  I was a literature major, so writing is something I like to do.14:53
matt-borland:)14:53
*** haypo has joined #openstack-horizon14:54
haypohey. i have an issue with pgettext_lazy on python 314:55
haypopgettext_lazy(u"past", "%(action)s %(data_type)s") creates a lazy object which doesn't all all methods of the python 3 type14:56
haypodoesn't have* all methods14:56
tsufievmatt-borland, well, you may look at https://review.openstack.org/#/c/238959/ although it's generally considered 'good enough'14:57
matt-borlandnever bad to have another set of eyes...I'll look at it this morning.  Thanks!14:57
tsufievas for other docs, they are not yet written. I'm afraid that I'll have to rewrite some parts of testing machinery once I try to explain how it works :)14:58
matt-borlandha, yeah, that's often the case :)14:58
robcresswelltsufiev: How is core life going :)14:58
robcresswellDavid described it to me as same pay, more responsbility, which I think is quite accurate.14:59
doug-fishtsufiev: I've no specific requests for verifying sahara-dashboard integration tests14:59
tsufievrobcresswell, I'm starting to feel deprived of time to fix my own patches :/14:59
doug-fishbut I am interested14:59
doug-fishyou have a patch # handy?15:00
tsufievdoug-fish, I have a bash script http://paste2.org/w2Un5AMM that should be run in some temporary directory15:00
tsufievit will clone both repos, checkout to specific commits, fix the settings and run tests15:01
doug-fishnice!15:01
robcresswelltsufiev: Yeah, between helping people on IRC and responding to review requests, it gets tough. My reviews have been a little low I think, will pick up after christmas. Just have a couple more big patches for this cycle.15:01
tsufiev2 settings that you'll most likely need to adjust are at the very beginning15:01
tsufievdoug-fish, ^^15:01
*** ig0r_ has joined #openstack-horizon15:02
*** mohankumar has joined #openstack-horizon15:02
doug-fishgot it - thx15:02
*** deray has quit IRC15:02
*** mtanino has joined #openstack-horizon15:03
tsufievrobcresswell, well, I haven't got up the review speed yet, because our internal Horizon code freeze is coming and we should fix as many of our bugs as possible before that15:04
openstackgerritMerged openstack/horizon: usage.html doesn't need such specific styles.  https://review.openstack.org/24662215:05
*** Liuqing has joined #openstack-horizon15:05
matt-borlandtsufiev, +1 on https://review.openstack.org/#/c/238959/15:06
*** matt-borland has quit IRC15:06
*** ig0r_ has quit IRC15:06
*** matt-borland has joined #openstack-horizon15:06
*** lhcheng has joined #openstack-horizon15:06
*** mdavidson has quit IRC15:06
tsufievmatt-borland, thanks for looking through :)15:07
matt-borlandno problem.15:07
openstackgerritItxaka Serrano Garcia proposed openstack/horizon: Refresh the networks on ajax update  https://review.openstack.org/25646015:09
itxakaumm, someone experienced with mox around that has 3 minutes for me? :)15:09
itxakamore like mox. our horizon test mocks/stubs instead15:10
rdopieramox or mock?15:10
rdopierabetter use mock if you can15:10
robcresswellThrow the question out, rather than ask for specific help itxaka. Someone may answer async15:10
robcresswellWhich isn't possible if you leave an open statement like that :)15:10
*** masco has quit IRC15:11
openstackgerritMerged openstack/horizon: Move Page Layout Styles out of horizon.scss  https://review.openstack.org/24644515:11
itxakaok then :D15:11
itxakahttps://review.openstack.org/#/c/256460/1/openstack_dashboard/dashboards/project/instances/tests.py15:11
itxakaAdded a new stub in there15:11
itxakaapi.network: ('servers_update_addresses',)15:11
itxakathen I do api.network.servers_update_addresses(IsA(http.HttpRequest), [server])15:12
itxakabefore the self.mox.ReplayAll()15:12
itxakathat measn that the function api.network.servers_update_addresses is mocked and will be cached when being call15:12
itxakabut Im seeing Log output from the original function15:12
itxakaand the tests pass, which is even worst!15:13
itxakaso Im a bit lost after trying everything :(15:13
robcresswellThe tests are passing anyway?15:14
*** pumaranikar has joined #openstack-horizon15:15
robcresswellitxaka: In the test you're updating, flavor_get fails15:15
robcresswellSo you wouldn't expect servers_update to be called anyway, would you?15:16
robcresswellHmmm, server_get not flavor_get.15:17
rdopieraitxaka: are you sure you are looking at the right test?15:17
itxakaoh goddammit15:18
robcresswellShould be updating test_row_update at 4511, no?15:18
itxakardopiera, may be that lol15:18
*** ducttape_ has joined #openstack-horizon15:19
rdopieraitxaka: you can run just the test you want15:19
itxakaai ai ai ai ai15:19
itxakaits that15:20
itxakatgif15:20
itxakathanks rdopiera15:20
*** vgridnev has quit IRC15:22
*** jtriley has quit IRC15:22
*** _ducttape_ has joined #openstack-horizon15:24
*** ducttape_ has quit IRC15:25
*** vishwanathj has quit IRC15:27
*** vishwanathj has joined #openstack-horizon15:27
*** vijendar has joined #openstack-horizon15:28
*** tjones has joined #openstack-horizon15:29
haypoah. my issue is: str(ungettext_lazy(ugettext_lazy("singular"), ugettext_lazy("plural"), 3))15:29
openstackgerritRichard Hagarty proposed openstack/horizon: Use "GiB" and "gibibyte" labels in volume panels  https://review.openstack.org/24388015:29
*** jtriley has joined #openstack-horizon15:29
haypothis code doesn't work on python 3 because ugettext_lazy() is lazy and ungettext_lazy() is lazy15:29
haypoungettext_lazy(ugettext_lazy(...), ...).__str__() returns a lazy object instead of a string15:30
rdopierawhy would you ugettext something twice?15:31
haypordopiera: it's not my code, i'm reading horizon code :)15:31
*** vgridnev has joined #openstack-horizon15:31
rdopieradon't read horizon code, it causes brain cancer15:31
robcresswellhaypo: Where is that?15:31
*** vgridnev has quit IRC15:31
haypordopiera: _get_action_name() of horizon/tables/actions.py uses  data_type = ungettext_lazy(self.data_type_singular, self.data_type_plural, count)15:31
haypordopiera: and self.data_type_singular is defined in openstack_dashboard/dashboards/project/volumes/backups/tables.py with _('...')15:32
robcresswellNice15:32
haypordopiera: using ungettext looks correct, we want to handle singular/plural15:32
haypordopiera: but i'm not sure that *ungettext_lazy* is used correctly here15:33
haypordopiera: do you know these functions?15:33
*** mohankumar has quit IRC15:33
*** mohankumar has joined #openstack-horizon15:33
rdopierahaypo: you don't want to call it on translated strings15:33
openstackgerritItxaka Serrano Garcia proposed openstack/horizon: Refresh the networks on ajax update  https://review.openstack.org/25646015:34
robcresswellhaypo: It looks like a lot of that is deprecated code that was never removed.15:34
haypordopiera: is there a different "ngettext" function to handle singular/plural but don't try to translate again?15:34
rdopierahaypo: ungettext already translates15:34
rdopierahaypo: no, because different languages will need to do different things15:34
*** vgridnev has joined #openstack-horizon15:35
*** vgridnev has quit IRC15:35
haypordopiera: XXXgettextXXX() functions should usually be used with literal strings, not with variables, no?15:35
rdopierahaypo: in Japanese, for instance, the plural depends on the shape of the object15:35
rdopierahaypo: yes15:35
haypoi never understood what it's "0 object*s*" in english, it doesn't make any sense in french! :-D15:36
haypo0 => no S15:36
rdopieraright15:37
robcresswellhttps://github.com/openstack/horizon/blob/master/horizon/tables/actions.py#L62615:37
haypoin french, plural is for count >= 215:37
rdopieraand in Polish we have 3 plurals15:37
robcresswell"NOTE: data_type_singular and data_type_plural attributes are bad for translations and should be avoided.15:37
rdopieradifferent for 2, 3, 4 and different for 5, 6, 7, 8, 915:37
rdopieraand different for 015:37
*** jprovazn has quit IRC15:37
haypo        # TODO(ygbo): get rid of all this bellow once action_present and15:38
haypo        # action_past are changed to methods handling plurals.15:38
haypoah, deprecated code, TODO, ... fun15:38
robcresswellThis is what happens when people change projects :(15:38
robcresswellor get reassigned etc.15:38
*** alexvictorchan has quit IRC15:39
rdopieraor leave notes instead of doing stuff15:39
hayporobcresswell: what is the plan to handle plural correctly?15:39
haypordopiera: a note is better than nothing15:39
haypoat least it confirms me issue, something bad is done here :-D15:39
rdopierahaypo: it's actually worse, because it becomes wrong over time15:39
haypordopiera, robcresswell : since i want to port this code, i may help to rework it to handle plural correctly. but i don't know how to do it15:40
rdopierawe'd need to change all code that uses this15:40
robcresswelldata_type_singular has like... 3 usages15:40
robcresswellone is in test data15:40
haypook, now i understood the issue, i can propose a patch with a new TODO comment :-D15:41
haypo-            self.data_type_singular,15:41
haypo-            self.data_type_plural,15:41
haypo+            six.text_type(self.data_type_singular),15:41
haypo+            six.text_type(self.data_type_plural),15:41
rdopierarobcresswell: are you including 3rd party horizon plugins?15:41
haypo^^ this works around my issue15:41
robcresswellWait, don't just wrap broken code in more workarounds :/15:41
haypohaha15:41
robcresswellrdopiera: True15:42
*** Liuqing has quit IRC15:42
hayporobcresswell: how should the code should be rewritten to handle plural correctly?15:43
robcresswellrdopiera: It looks like there's a deprecation warning in there... may be safe to remove. I'll look more.15:44
rdopierahaypo: the strings passed to ngettext should be untranslated, to begin with15:44
rdopierahaypo: but they have to be included for translation somewhere15:44
rdopierahaypo: marked for translation15:44
doug-fishhere's a sample of proper action code: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/tables.py#L9215:44
haypordopiera: ok, but replacing _('...') with '...' in openstack_dashboard/dashboards/project/volumes/backups/tables.py would stop extracting '...' to populate  the .po file, no?15:45
robcresswellNone of this was marked with django versioning either15:45
rdopierahaypo: right15:45
rdopierahaypo: doug-fish gave you the right way :)15:45
haypodoug-fish: oh, let me see that15:45
doug-fishhaypo: where the code that has these actions?15:46
openstackgerritMerged openstack/horizon: Delete the unused LOG configure code  https://review.openstack.org/22284715:46
robcresswelldoug-fish: Search for data_type_plural and data_type_singular15:46
haypodoug-fish: i'm working on openstack_dashboard/dashboards/project/volumes/backups/tables.py15:46
haypodoug-fish: (i want to port it to python 3)15:46
*** ducttape_ has joined #openstack-horizon15:47
robcresswellits used in 4 locations in Horizon it seems, one of which is in a test15:47
haypodoug-fish: oh, it works! i will send a review15:48
doug-fishI see 2 real uses both in volumes - one for backups, one for specs15:48
robcresswellYeah, I just replied as soon as I searched :p15:48
doug-fish:-)15:49
robcresswellWe could cleanly remove this, either way.15:49
doug-fishabsolutely15:49
*** _ducttape_ has quit IRC15:49
doug-fishI recall cleaning this up at one point talking about deprecation15:49
doug-fishbut no actual removal occurred. :-(15:49
*** david-ly_ has joined #openstack-horizon15:50
hayporobcresswell: "We could cleanly remove this, either way" oh, i wrote a patch to fix a single location15:51
hayporobcresswell: is it worth? or do you require a patch replacing *all* remaining data_type_singular and data_type_plural?15:52
doug-fishhaypo: there are very few remaining instances. Cleaning up Horizon will be easy15:53
doug-fishI have vague concern about plugins not being updated15:53
doug-fishbut maybe this is a good time of the development cycle to break them15:53
*** david-lyle has quit IRC15:53
*** hurgleburgler has joined #openstack-horizon15:53
*** david-ly_ is now known as david-lyle15:53
*** ChanServ sets mode: +o david-lyle15:53
robcresswellhaypo: There are very few instances. It is worth removing all of it.15:54
robcresswelldoug-fish: There are deprecation warnings plastered across the code15:54
*** nlahouti has joined #openstack-horizon15:54
doug-fishrobcresswell: I've heard nothing is really ever deprecated on OpenStack. (see keystone v2) We can be trend setters!15:54
robcresswell:(15:55
doug-fishI can see it now "oh wait. You guys are serious about this deprecation"15:55
doug-fishIt's an easy enough fix I don't really think it will be an issue15:55
robcresswell\o/15:56
*** nlahouti1 has joined #openstack-horizon15:56
robcresswellI think openstacks problem is that its still heavily under development in some regards whilst companies are trying to deploy it at scale15:57
robcresswellThats a tough problem :p15:57
tsufievrobcresswell, the best way to learn how to swim is to jump into the water :)15:57
ygbohaypo:  action_present and action_past are changed to methods handling plurals?15:57
ygbohaypo: do you want me to perform with the TODO?15:57
*** jtriley_ has joined #openstack-horizon15:58
*** _ducttape_ has joined #openstack-horizon15:58
*** nlahouti has quit IRC15:59
openstackgerritPaul Karikh proposed openstack/horizon: Add identity v3 API filtering to users and projects tables  https://review.openstack.org/25248815:59
*** jtriley has quit IRC16:01
*** ducttape_ has quit IRC16:01
doug-fishygbo: if you want to finish up that data_type_(singular|plural) removal I think we in agreement that it's time for that to go16:01
doug-fishI think haypo is already correcting one instance where data_type_X is being used16:01
ygbodoug-fish: all the ancient ways of translating are gone or not yet?16:02
doug-fishthey were gone at one point - but we left the capability in place, but deprecated16:02
doug-fishthen a couple resurfaced16:02
*** nlahouti1 has quit IRC16:02
ygbohaypo: if you have questions about action translations, don't hesitate16:03
doug-fishgrepping on data_type_plural I see only use 2 usages of the old action usage16:03
ygbodoug-fish: oh, I see16:03
doug-fishand again - I think haypo is already correcting one of those16:04
ygbohaypo: https://wiki.openstack.org/wiki/I18n/TranslatableStrings16:08
*** david_cu has left #openstack-horizon16:09
*** belmoreira has quit IRC16:12
*** SurajD has quit IRC16:13
*** david_cu has joined #openstack-horizon16:13
openstackgerritVictor Stinner proposed openstack/horizon: Port loadbalancers tests to Python 3  https://review.openstack.org/25656216:13
openstackgerritVictor Stinner proposed openstack/horizon: Port volume backup dashboard to Python 3  https://review.openstack.org/25656316:13
hayporobcresswell: i'm in a hurry (i have to exchange my DSL box in 15 minutes!) so i pushed my 2 current python 3 patches, but i will write a new one on top of them to drop the deprecated attributes16:14
*** SurajD has joined #openstack-horizon16:15
*** rdopiera has quit IRC16:18
*** mohankumar has quit IRC16:18
*** mdavidson has joined #openstack-horizon16:19
*** mounica has joined #openstack-horizon16:19
*** ig0r_ has joined #openstack-horizon16:21
openstackgerritYves-Gwenael Bourhis proposed openstack/horizon: Changed to DeprecationWarning in BatchAction.  https://review.openstack.org/25656716:22
ygbohaypo, doug-fish : ^^ activated deprecation warning16:26
doug-fishygbo: nice! I wonder if that's immediately going to cause tests to fail16:27
ygbodoug-fish: no, they don't fail16:27
doug-fishcool16:27
ygbodoug-fish: it just ensures that when someone uses the old style h'ell get a warning16:27
*** _ducttape_ has quit IRC16:28
*** bpokorny has joined #openstack-horizon16:28
doug-fishperfect16:28
ygbodoug-fish: and if there are no warnings left (when all attributes are gone), I'll cut away the legacy16:28
doug-fishyeah, that's a good plan16:29
ygbodoug-fish: don't hesitate to ping me or mail me when it has to be done :-)16:29
doug-fishsure!16:29
haypodoug-fish: Pending- and DeprecationWarnings are hidden by default :-/16:30
doug-fish:-(16:31
ygbohaypo: https://review.openstack.org/#/c/256567/16:31
ygbohaypo: DeprecationWarnings are hidden?16:32
doug-fishhaypo: do you know where/how they are hidden?16:32
*** Drago has joined #openstack-horizon16:33
*** Drago has quit IRC16:33
ygbohaypo: I know that PendingDeprecationWarnings where hidden, but seems weird about DeprecationWarnings.16:33
*** Drago has joined #openstack-horizon16:33
haypodoug-fish: use python -Wd to see them16:33
haypodoug-fish: python -Werror to ensure that they get them :-D16:33
*** JeanBriceCombebi has quit IRC16:34
openstackgerritVictor Stinner proposed openstack/horizon: Convert present/past action to methods  https://review.openstack.org/25657516:40
hayporobcresswell, doug-fish & cie: enjoy https://review.openstack.org/256575 (sorry, it's on top of my 2 other py3 patches)16:40
*** TravT has joined #openstack-horizon16:41
*** alexvictorchan has joined #openstack-horizon16:43
*** ig0r_ has quit IRC16:47
*** dslevin has quit IRC16:52
*** mounica has quit IRC16:56
*** dslevin has joined #openstack-horizon16:56
*** Piet has joined #openstack-horizon16:56
*** garthb has joined #openstack-horizon16:57
*** mpavlase has joined #openstack-horizon17:06
*** hurgleburgler has quit IRC17:06
*** Piet has quit IRC17:08
*** nlahouti has joined #openstack-horizon17:09
*** nlahouti has quit IRC17:11
*** nlahouti has joined #openstack-horizon17:11
*** gyee has joined #openstack-horizon17:16
*** itxaka has quit IRC17:18
*** ducttape_ has joined #openstack-horizon17:18
*** ianbrown has quit IRC17:19
*** ianbrown has joined #openstack-horizon17:20
*** kzaitsev_mb has quit IRC17:23
*** tjones has quit IRC17:29
*** masco has joined #openstack-horizon17:33
*** ygbo has quit IRC17:36
*** sambetts is now known as sambetts-afk17:38
*** sweetJeebus has joined #openstack-horizon17:43
*** emilyw has joined #openstack-horizon17:43
sweetJeebusHi y'all17:43
sweetJeebusI'll get right to it: I'm rebuilding our icehouse cloud. It currently uses kilo-keystone so we can start using v3 identity api. I'm now updating to liberty-horizon. So far everything else is icehouse (for now)17:45
sweetJeebusGood news is it mostly works.17:45
*** JeanBriceCombebi has joined #openstack-horizon17:45
sweetJeebusI've performed a test matrix and found a couple of sore spots, one in particular.17:45
sweetJeebusSo its a lot of info, and I don't quite know what to do with it, nor how to fix my biggest problem.17:46
sweetJeebusany advice on where I should start? How about with my obvious code issue?17:46
sweetJeebusBefore I continue, I should probably ask... hehe... does anyone care right now?17:47
doug-fishPerhaps poke around on https://bugs.launchpad.net/horizon or share a couple of sentences here17:47
sweetJeebusright on17:47
sweetJeebusthanks doug-fish17:47
doug-fishIt's actually my lunchtime, so I don't care right now... but there is a good chance I'll care when I get back17:48
sweetJeebusso... When I click on Admin-Networks...17:48
doug-fishshare what you can and I'll catch up17:48
sweetJeebustell you what... I'll go get my lunch, too, and we can talk when we'17:48
sweetJeebuswe're both returned :)17:48
sweetJeebussound cool?17:48
doug-fishworks for me. Have a nice lunch!17:48
TravTducttape_: is that you?17:49
ducttape_yo17:49
TravT^17:49
sweetJeebuslaters... enjoy lunch peoples17:49
ducttape_TravT whats up?17:50
TravTnothing, i thought maybe you had changed your nick17:50
TravTnvrmind... :)17:51
ducttape_nah.  I do enjoy when sweetJeebus is in the room, though.  and making snarky comments about sweetJeebus and keystone v317:51
TravTlol, that always make me laugh a bit17:51
ducttape_openstack:  pretty much requires sweetJeebus in order to work™®17:52
TravTrofl17:52
ducttape_that is why I am not in marketing / social media17:52
TravTyeah, probably a good idea.17:52
*** pauloewerton has quit IRC17:56
*** bpokorny_ has joined #openstack-horizon17:58
*** bpokorny_ has quit IRC17:58
*** bpokorny_ has joined #openstack-horizon17:59
*** bpokorny has quit IRC18:02
*** harlowja has quit IRC18:06
*** harlowja has joined #openstack-horizon18:07
*** lhcheng_ has joined #openstack-horizon18:08
*** aortega has quit IRC18:10
*** lhcheng has quit IRC18:10
*** alexvictorchan has quit IRC18:11
*** JeanBriceCombebi has quit IRC18:13
*** tjones has joined #openstack-horizon18:16
openstackgerritTimur Sufiev proposed openstack/horizon: Security groups page and test for create/delete secgroup  https://review.openstack.org/15660418:18
*** hurgleburgler has joined #openstack-horizon18:20
*** alexvictorchan has joined #openstack-horizon18:21
*** chestack has quit IRC18:21
openstackgerritMerged openstack/django_openstack_auth: Move d-o-a auth library to keystoneauth  https://review.openstack.org/20525118:22
openstackgerritMerged openstack/django_openstack_auth: Use set comprehension instead of converting lists to sets  https://review.openstack.org/21644118:25
*** e0ne has quit IRC18:27
sweetJeebusI'm glad you enjoy it, _ducttape18:27
sweetJeebusanyone up for some bizarre troubleshooting?18:27
doug-fishsweetJeebus: briefly18:28
doug-fish(turns out I'm enjoying a 2 phase lunch today, phase 1 is completed, phase 2 begins soon)18:28
sweetJeebusawesome. 2 phase lunches are rivaled only by 3 martini lunches18:28
doug-fish:-)18:29
ducttape_why not both?18:29
doug-fishphase 2 involves shopping with my wife18:29
sweetJeebusducttape_: let's not get crazy now18:29
sweetJeebusor maybe let's -do-...18:29
doug-fishwouldn't mind the martinis as well.18:29
sweetJeebusOkay, I'm going to start with... does anyone want my 130 lines of results from the test matrix. I went through every Horizon link and tested all the buttons and stuff. The results have errors culled into an appendix (the last few lines)18:31
sweetJeebusI'm not going to print it here, though... so its email or possibly some other posting else-web18:31
doug-fishsweetJeebus: maybe http://paste.openstack.org/ ?18:32
sweetJeebusawesome. http://paste.openstack.org/show/481697/18:33
david-lylesweetJeebus: you're going from icehouse to Liberty with horizon?18:33
sweetJeebusso, y'all can read that to your hearts content... // @david-lyle: I am18:34
doug-fish(the nick reads really well there david-lyle)18:34
*** chestack has joined #openstack-horizon18:34
sweetJeebusbut the rest of my cloud, with the exception of kilo-keystone, everything else is still icehouse... For Now....18:34
ducttape_lol18:34
david-lyle:o18:35
ducttape_so is the desire to have kilo patches to support icehouse of most things?  is that what you are looking for sweetJeebus?18:35
sweetJeebusso... if anyone thinks my mix of components is kinda crazy... I'm with you. It's crazy.18:36
sweetJeebusso, what I'm looking for is to solve the 3 bugs that I noted at the end of my screed.18:36
sweetJeebusAlso, I thought I'd share my test matrix so y'all can see what I've encountered... just in case it ever happens again or something18:36
david-lylemost of those look like missing API version checks18:36
david-lylewhich would certainly be addressed18:37
sweetJeebusare you referring to the metadata and namespace errors, @david-lyle?18:37
david-lyles/would/should/18:37
david-lyleyes those, the cinder v2 issue as well18:37
david-lylelive migrate, etc18:38
sweetJeebusyeah, so... I was able to get past the cinder v2 issue18:38
sweetJeebusjust by putting the v1 and v2 endpoints in the service catalog side-by-side18:38
david-lyleright, we have a bug the other way too18:39
david-lylerequiring v1 with v218:39
sweetJeebusha18:39
david-lyleright now horizon requires both, because the more the merrier18:39
sweetJeebusI saw that the >=juno install guides all have both cinder versions placed into the SC18:40
sweetJeebuslines 121 and 126 of my paste have the two errors I'm hoping to address. I suspect 121 involves skipping ahead to my glance upgrade. Any thoughts on that?18:40
david-lyledo you have more of a stack trace on #9 line 71?18:40
*** chestack has quit IRC18:41
david-lylewhich is 126 I guess18:41
sweetJeebusI can get that for you.18:41
david-lylethe metadata on glance should be checking for v2 being present18:41
sweetJeebusI flipped my dev cloud back to v2 api so the rest of my team can function18:42
david-lylewonder what went wrong there18:42
sweetJeebusI think I only have v1 glance, is why18:42
david-lyleright, but the check for v2 should be there18:42
doug-fishsweetJeebus: regarding the glance issue, an alternative would be for your to cherry-pick the fix https://git.openstack.org/cgit/openstack/horizon/commit/?id=0578023d881ab77fb6708ca39a99f772763ef1a6 if that sort of thing is possible in your environment18:42
doug-fishthat'll void your warranty though.18:42
sweetJeebusAlso, there's a reference to enable_vX_api in glance_api.conf, but its not in the icehouse version (or maybe I just need to add it?)18:43
*** chestack has joined #openstack-horizon18:43
david-lyleah post liberty fix18:43
david-lyledoug-fish: has the right patch for you18:43
sweetJeebusdoug-fish: I'm looking into it now...18:43
sweetJeebusand LOL@warranty18:43
doug-fishdavid-lyle: I'm wondering if we should pick that back into stable18:44
david-lyledoug-fish: yes18:44
david-lylemake it so18:44
david-lyle:D18:44
david-lyleif you propose I can move it18:44
sweetJeebusso if that goes back into stable... will that be in the liberty repo?18:44
david-lylesweetJeebus: yes18:44
sweetJeebusWill canonical pick that up into the apt-repos?18:44
*** ducttape_ has quit IRC18:45
doug-fishdavid-lyle: if I can get somebody else to propose you and I can get it merged!18:45
sweetJeebusthat'd be swell.18:45
david-lylenext time they update18:45
david-lyledoug-fish: oh yeah, forgot you had all that power18:45
doug-fishha!18:45
david-lylesneaky18:45
sweetJeebusI'm gonna go twiddle some bits and get y'all the stack trace for that TypeError bug18:46
sweetJeebusthere are two possibilities: the log output and the webscreen output. Want both?18:46
david-lylesweetJeebus: thanks, that would be backport worthy too18:46
david-lylelog18:46
sweetJeebusk18:46
david-lyleso I know which thing changed type18:47
*** toabctl has quit IRC18:47
sweetJeebusGoing for water, then I'll do this do and get back to yous18:47
doug-fishso ... just to make it clear ... if somebody wanted to go to https://review.openstack.org/#/c/246486/ and click cherry pick to ... stable/liberty there's a good chance you'd get credit for an easy commit!18:48
doug-fish* with an outside chance of a merge issue18:49
david-lylehttps://review.openstack.org/#/c/256627/ is the glance backport18:49
david-lylewe'll get lhcheng_ or mrunge to vote too18:49
david-lyleshould be easy18:50
david-lylethanks sweetJeebus18:50
david-lylebest nick ever18:50
doug-fish:-)18:50
sweetJeebusI'm going to do that clicking for you, mang18:51
doug-fishsweetJeebus: It's done18:51
sweetJeebusoh18:52
sweetJeebuswell, it gives me a chance to exercise my openstack user account18:52
sweetJeebusI'm new to this. Don't hurt me18:53
david-lylevote it up18:53
*** aortega has joined #openstack-horizon18:53
sweetJeebushow do I 'vote it up'? I found the 'cherry pick' button.18:54
sweetJeebusNeat18:54
doug-fishsweetJeebus: the proposed patch for liberty is in https://review.openstack.org/#/c/256627/  You can look at the code, try it out, and then click review and give a +1 or -1 and tell us why18:55
doug-fishI always like to read that the cherry pick actually fixes the discovered issue18:56
doug-fishand I might be tool lazy to set up an icehouse environment18:56
sweetJeebuscool.18:57
sweetJeebus-everyone- is too lazy to set up more icehouse. That's why I'm upgrading.18:57
doug-fish:-)18:58
david-lyledoug-fish: you could just remove the v2 endpoints from the service catalog on any environment18:59
doug-fish:-O18:59
doug-fishwell that's a good idea18:59
doug-fishand inside the limitations imposed by my laziness19:00
doug-fishthanks!19:00
*** tqtran has joined #openstack-horizon19:01
david_cugonna give my first review to this backport, achievement unlocked19:01
*** jingjing_ren has joined #openstack-horizon19:01
doug-fishdavid_cu: grats!19:03
sjmc7david_cu - you asked me for help last week with pycharm, and i don’t know if i ever got back to you. let me know if you’d still like help19:04
*** tosky has quit IRC19:07
david_cuthanks bros, and sjmc7 no worries, i got my environment set up and working for the most part. thanks though!19:07
sjmc7excellent. apologies for missing your message19:07
david_cunot a problem19:08
sweetJeebusso... I'm planning to get y'all the apache2/error.log19:09
sweetJeebusis there something else you may want? I've been doing this for a couple weeks now and haven't found anything relevant, but as long as I'm here, I'll ask the dumb questions19:10
*** e0ne has joined #openstack-horizon19:11
sweetJeebushttp://paste.openstack.org/show/481700/19:12
sweetJeebusthere's yer log19:12
sweetJeebusalso.... an amazing amount of cruft came up to my screen:19:13
sweetJeebushttp://paste.openstack.org/show/481701/19:14
sweetJeebuson my browser19:14
doug-fishsweetJeebus: I don't recognize that issue immediately; I think opening a bug at https://bugs.launchpad.net/horizon and share your logs + description of what you were doing is the right next step19:16
doug-fish(unless somebody else recognized this)19:16
*** jingjing_ren has quit IRC19:17
david-lylesweetJeebus, I agree with doug-fish that's the best way to track it19:17
sweetJeebusaye aye19:17
sweetJeebusSo... don't anybody get upset. I do have a real name.19:17
sweetJeebusand it will be on the bug19:18
doug-fish:-O19:18
doug-fishare you saying you aren't sweetJeebus?19:18
* doug-fish stops helping immediately19:18
*** sqchen has joined #openstack-horizon19:19
*** aix has quit IRC19:19
david-lyleLOL19:19
*** masco has quit IRC19:20
*** JeanBriceCombebi has joined #openstack-horizon19:21
sweetJeebusWell, I -am- sweetJeebus, its just that I use a pseudonym in day-to-day life19:21
* doug-fish remains skeptical19:22
sweetJeebus...and now I'm tempted to make a new user in openstack. Clark Kent19:22
tqtrandavid-lyle, doug-fish: gm guys, can we briefly talk about this? https://review.openstack.org/#/c/255590/2/openstack_dashboard/utils/settings.py19:23
tqtranim going on vacation starting next week, if we can address it now, would be perfect.19:23
doug-fishtqtran: sure, though lunch phase 2 may start at any moment19:24
tqtranlol that is fine19:25
doug-fish... are you out for the year starting next week?19:25
david-lylewhat's the question?19:25
david-lylewhy not convert the python path to a directory?19:26
*** e0ne_ has joined #openstack-horizon19:26
sweetJeebushttps://bugs.launchpad.net/horizon/+bug/152537519:26
openstackLaunchpad bug 1525375 in OpenStack Dashboard (Horizon) "Horizon-liberty in a mixed version env throws 'TypeError at /admin/networks/'" [Undecided,New]19:26
sweetJeebusPosted19:26
doug-fishanyone know how long those paste.openstack.org posts stay around?19:27
sweetJeebusoh...19:27
doug-fishI know other services like that delete them fairly quickly19:27
sweetJeebusI can put those in files and attach them19:27
doug-fishyeah that would work for sure19:27
*** e0ne has quit IRC19:28
tqtrandavid-lyle: gimme a second, let me verify something, then i'll ask again :P19:28
*** garthb_ has joined #openstack-horizon19:28
david-lyleok19:28
*** ericksonsantos has quit IRC19:30
*** garthb has quit IRC19:30
tqtranok verified, time to ask19:31
david-lyleI always as at 12:31 as well19:32
david-lyle*ask19:32
*** ericksonsantos has joined #openstack-horizon19:32
tqtranbasically, right now, there is no way for plugins to contribute translations to the client side19:32
tqtranthat is due to two reasons: 1. the translation file isn't included in the manifest.in and 2. it is not included as part of the js catalog domain list19:32
tqtran1. is easily fix, just need better documentation and examples19:33
tqtran2. is also easily fix by removing this hardcode https://github.com/openstack/horizon/blob/master/openstack_dashboard/templates/horizon/_script_i18n.html19:33
tqtranit should be 'horizon'+'openstack_dashboard'+... all of EXTERNAL plugins19:34
* doug-fish thinks tqtran uses the work "easily" a bit too freely19:34
doug-fishyep - with you so far19:34
tqtransorry, i meant hardly19:34
doug-fishthat word doesn't mean what you think it means19:34
sweetJeebusdoug-fish: I added those logs as attachments19:34
doug-fishsweetJeebus: cool! sounds good19:35
tqtranso two ways we can go about doing this. 1. add a new flag ADD_JS_CATALOG or try to reuse the existing ADD_INSTALLED_APPS flag19:35
sweetJeebusthanks for all your help. I'm going for a quick walk, then I'll catch up19:35
doug-fishyw. Enjoy your walk19:35
tqtranADD_JS_CATALOG is a boolean and works as is, in the current patch. but we could just easily assume that if you're asking an EXTERNAL plugin, you'll want it translated19:36
tqtranso ADD_INSTALLED_APPS would also work19:36
tqtran*asking-->adding19:36
tqtranthe only issue so far is that ADD_INSTALLED_APPs also includes our INTERNAL dashboards and panels19:37
tqtranso we'll have to make some assumptions and filtern dashboards with openstack_dashboards.* from the list19:37
doug-fishtqtran: the issue with how it is now is that the panel name isn't a package, it's a slug (right?)19:37
tqtranthat is correct, the package is identified using the slug19:38
tqtranwell sort of19:38
doug-fishwhat about ADD_JS_CATATLOGS and add a list of packages that should be included in the javascript_catalog?19:39
tqtranbasically, the way i understand it is, it looks through all enabled files and looks for DASHBOARD, PANEL, PANEL_GROUP, and (something)CUSTOMIZATION19:39
* doug-fish has to leave for lunch phase 2 quite soon19:40
*** JeanBriceCombebi has quit IRC19:40
tqtrandoug-fish: not sure i follow, that would make it more complicated i think19:40
tqtranwe can talk when you get back19:40
doug-fishyeah, maybe we need to talk through this19:40
david-lyleI'm failing to see the issue19:41
*** harlowja has quit IRC19:41
david-lylebut I am slow19:41
david-lyleyou need a list of paths to read19:41
david-lyleno?19:41
*** harlowja has joined #openstack-horizon19:41
david-lylereally these are static files that should be collected before hand19:42
david-lylethe way those would be pulled in is by the INSTALLED_APPS19:42
tqtranok let me start from the beginning19:43
tqtranfirst you have a plugin with enabled folder and myplugin folder19:43
tqtraninside myplugin folder is a locale folder containing all translations19:43
tqtranwhen you add your enabled file to horizon's enabled folder, and specify the ADD_INSTALLED_APPS, it will correctly pull in all of the contents you specified in manifest.in19:44
tqtranthis includes translations such as po, mo, and pot files19:44
tqtranwhen you hit the url: localhost:9000/i18n/js/<name of plugin> it will attempt to fetch the javascript catalog from your plugin19:45
tqtranso if i wanted to fetch js message catalog for horizon, i would put localhost:9000/i18n/js/horizon19:45
tqtranand if i wanted to fetch for horizon AND openstack_dashboard, i should use localhost:9000/i18n/js/horizon+openstack_dashboards19:46
tqtranwhich is what we are doing here https://github.com/openstack/horizon/blob/master/openstack_dashboard/templates/horizon/_script_i18n.html19:46
tqtranthe issue is that we are hard coding horizon + openstack_dashboards19:46
tqtranit should be horizon + openstack_dashboars + ... plugins19:47
david-lyletqtran: where's the hardcoding?19:47
tqtran<script type="text/javascript" src="{% url 'horizon:jsi18n' 'horizon+openstack_dashboard' %}"></script>19:47
tqtran'horizon+openstack_dashboard'19:47
david-lyleI thought the idea before was to concatenate the .po files19:47
david-lyleI guess that could create conflicts though19:48
tqtranit was, until lin pointed out that this might be better19:48
tqtranwe keep the domains separate, and let django append the catalog for us19:48
tqtranorder matters in this case19:48
david-lyleso we add content dynamically to _scripts.html, why not script_i18n.html?19:48
tqtranhttps://review.openstack.org/#/c/255590/2/openstack_dashboard/templates/horizon/_script_i18n.html19:49
tqtranwe are adding to script_i18n.html19:49
*** Piet has joined #openstack-horizon19:49
tqtranhttps://review.openstack.org/#/c/255590/2/openstack_dashboard/context_processors.py19:49
tqtranwe create a context that has a list of horizon + openstack + plugins19:49
tqtranthen insert it into script_i18n19:50
tqtranthe tooling and process is already there, the issue is, essentially, how do we detect external plugins and should we add a new flag in enabled file?19:51
*** agireud has joined #openstack-horizon19:51
david-lyleI think a flag to point out the relative path from the app path would likely work19:52
david-lylebut I'm not sure what mechanism you patch was using, just reading it19:53
tqtranyou don't really need the relative path. that is already taken care of by the install19:54
tqtranall you really need is the plugin name19:54
tqtranwhich is right now, PANEL or DASHBOARD19:54
*** e0ne_ has quit IRC19:54
david-lyleok19:54
*** JeanBriceCombebi has joined #openstack-horizon19:54
openstackgerritJustin Pomeroy proposed openstack/horizon: Add action for editing instance metadata  https://review.openstack.org/24362419:54
david-lyleso what's the issue?19:54
tqtranthere is no issue, it works the way it is right now. BUT.....19:55
tqtranso example, if I have a panel or dashboard plugin, and if i wanted to add it to the js message catalog, i turn on ADD_JS_CATALOG = True19:55
tqtranthe question is, if im adding panel or dashboard, wouldn't i want it translated all the time?19:56
david-lyletqtran: sure, if there are translation available19:56
david-lyle*translations19:56
tqtranright, but we can actually safely assume that translations are always available19:57
david-lylebut dictating a location of plugin structure isn't likely going to happen19:57
david-lylethere's not a plugin out there now with translations19:58
tqtranright, but i think we have to enforce this structure because our plugins uses the django file structure19:58
tqtranlocale has to exist under the installed app19:58
tqtranin order for django to pick it up19:58
tqtranthe other option is like you said, specify a path to the locale folder, but that will require additional work and very little gain19:59
david-lyleso wait, what is in your ADD_JS_CATALOG value?19:59
*** ducttape_ has joined #openstack-horizon20:00
tqtranits a boolean that tells django to append the plugin name to the js message catalog or not20:00
david-lyleoh, I assumed it was files20:00
* david-lyle has just skimmed that patch20:00
tqtranthe files already exist once you do the pip install20:00
tqtranADD_JS_CATALOG just says, should i pick it up or not?20:01
david-lyleand if it's not there, just pick up nothing?20:01
tqtranif it is not there, you will only get horizon+openstack_dashboards20:01
david-lylehave to think about location, but a yes/no flag is of little use20:01
david-lyleI would omit if only yes/no20:02
david-lylestill not sure about the structure part20:02
tqtrani think structure part is part of the norm20:02
tqtranall of the existing plugins follow the django app structure20:02
david-lyleyeah, if locale sits under the app20:03
david-lylewe're good20:03
tqtranright, locale does sit under the app for external plugins20:03
david-lyleyou can have multiple apps in one plugin repo, but then just need mulittple locales20:03
tqtranright, kind of what we are doing for horizon and openstack_dashboard20:04
david-lyleI'd just make it the default behavior20:04
tqtranwe dont have a single locale folder, we have two20:04
david-lyleand get rid of the flag20:04
david-lyleno need20:04
tqtranok so remove ADD_JS_CATALOG20:04
david-lyleI think so20:04
tqtranok, so here is the problem with removing that flag :P20:05
tqtranright now, we are also using the plugin structure internally....20:05
tqtranso ADD_INSTALLED_APPS list will contain both external plugins and our internal plugins20:05
david-lyleok20:05
tqtranbut we shouldn't append our internal plugins to the list because it already exist under openstack_dashboards20:06
david-lyleso our internal ones won't have a locale folder20:06
*** wolverineav has joined #openstack-horizon20:06
*** mpavlase has quit IRC20:06
tqtranthat is true, but django doesn't know that until it tries to fetch it20:07
tqtranand try it will since we have it in the list20:07
david-lyleright, but we have to handle the failure case either way20:07
david-lyletry/except?20:08
tqtranwe dont have to, django is smart enough to not include anythign when it append the files20:08
david-lyleor is that deeper in django20:08
david-lyleso we're set20:08
david-lyleno?20:08
tqtran['openstack_dashboard.dashboards.project', 'openstack_dashboard.dashboards.admin', 'openstack_dashboard.dashboards.identity', 'openstack_dashboard.dashboards.settings', 'openstack_dashboard.contrib.developer', 'my_panel']20:08
*** tjones has quit IRC20:08
tqtranthat is the list that i am seeing right now for installed_apps via plugins20:09
david-lyleok20:09
tqtrani dont want to append all of that to the domain list20:09
tqtrani just want horizon+openstack_dashboard+my_panel20:09
tqtranso the straight forward thing is to exclude all dashboards/panels starting with the openstack_dashboard namespace20:10
*** jwy has joined #openstack-horizon20:10
tqtrandoes that sound reasonable?20:10
david-lyletqtran: I guess20:11
tqtrani think that is reasonable :P20:11
tqtranso lets go with that then haha20:11
*** wolverineav has quit IRC20:11
*** sqchen has quit IRC20:11
david-lylemight as well20:11
*** Piet has quit IRC20:11
tqtranhaha ok, great.... i'll do just that then20:11
david-lylemaybe eventually we can move to something cleaner20:12
david-lylebut I don't really think breaking up the openstack_dashboard catalog is useful while that's all in tree20:12
tqtranwe're not breaking it up the catalog20:13
tqtranwow terribad english20:13
david-lyleI know not now20:13
tqtrani think it is pretty clean the way it works today20:13
david-lylebut I think "eventually" having a single system is good for business :)20:13
tqtrani have several projects each with their own locale folder, django append them for me. DONE!20:14
tqtrana single one for horizon makes sense. but not for plugins20:14
david-lylewell20:14
david-lylethe problem is you treat integrated content like plugins in some cases, but not others20:15
david-lylethat gets confusing and messy20:15
*** Piet has joined #openstack-horizon20:15
tqtranconfusing and messy for us, but to the users, its all magic20:16
david-lylemagic is bad20:16
*** sqchen has joined #openstack-horizon20:16
david-lylebecause it makes us make mistakes later on20:16
david-lylejust make sure to comment the magic part and maybe add a TODO around a less hardcoded approach in the future20:17
openstackgerritOndřej Nový proposed openstack/horizon: Deprecated tox -downloadcache option removed  https://review.openstack.org/25668520:17
david-lyleat this point I don't have a better suggestion and getting translation for plugins working in a way needs to happen soon20:17
tqtranthe magically part is handled by django, so not sure if comments are needed? i'll try and write a documentation to explain the process20:18
tqtranwould that be better?20:18
tqtranlike, here are the things you need to do to enable translation in your plugin20:19
tqtranand here is a simplified version of what django is doing behind the scene20:19
*** emilyw has quit IRC20:22
david-lyletqtran: I just meant the exclusion of openstack_dashboard namespace items20:23
david-lylebut yes, how to make translations work from the plugin writer's perspective is essential20:24
*** Piet has quit IRC20:24
*** Piet has joined #openstack-horizon20:25
tqtranyep, agree. after this patch, i'll work on a documentation patch for that20:26
*** vishwanathj has quit IRC20:27
*** vishwanathj has joined #openstack-horizon20:28
*** SurajD has quit IRC20:31
*** JeanBriceCombebi has quit IRC20:32
tqtranrobcresswell: ping20:34
*** ig0r_ has joined #openstack-horizon20:37
*** Piet has quit IRC20:40
tsufievdavid-lyle, o/20:41
david-lyletsufiev: \o20:41
tsufievhow is it going?20:41
david-lylegreat!20:42
david-lyleand you?20:42
doug-fishtqtran: david-lyle, I'm back.20:42
doug-fishI can't quite tell if you came to a resolution or not20:42
tsufievdavid-lyle, slowly becoming familiar with my new responsibilities (as I understand them) :)20:43
david-lyleI think the result was make doug-fish do it20:43
david-lyle:P20:43
david-lyleoh crap20:43
doug-fishpsh. Good luck with that20:43
david-lyleemail and me didn't happen20:43
tsufievdavid-lyle, btw, found a nasty bug (seems to be) with all kinds of integration tests in horizon and Depends-On, https://bugs.launchpad.net/horizon/+bug/152539720:43
openstackLaunchpad bug 1525397 in OpenStack Dashboard (Horizon) "Integration tests (both tempest and selenium) don't respect Depends-On: Zuul feature" [Undecided,New]20:43
tsufievwonder if it's a known issue20:44
david-lyletsufiev: not to me20:44
*** e0ne has joined #openstack-horizon20:44
tsufievlife is full of surprises then :)20:45
david-lyleI could handle less surprises20:46
tqtrandoug-fish: let me upload a new patch and you can decide if is a resolution or not :P20:47
doug-fish:-020:47
doug-fish:-)20:47
doug-fishcode speaks clearly20:47
doug-fishI like it20:48
*** Piet has joined #openstack-horizon20:48
doug-fishI actually didn't realize what our internal ADD_INSTALLED_APPS values look like. I'm surprised to see each panel added as it's own application20:49
tqtranits done via the enabled files20:50
doug-fishyes20:50
tqtranat least for the dashboards20:50
doug-fishand I was looking at those20:50
doug-fishI expected our installed apps for what we deliver would still be only horizon and openstack_dashboard20:51
doug-fishI don't know what it means for openstack_dashboard.dashboards.identity to be an application when openstack_dasbboard already is20:52
*** sqchen has quit IRC20:52
tqtranright, its because we started internally making our own dashboards a plugin as well20:53
tqtranso now, theres sort of double detection happening20:53
doug-fishwhy don't our panels claim their application is openstack_dashboard?20:53
tqtrani think the solution is to remove openstack_dashbaord as an app, but that would mean localization and a few others thing have to be compartmentalize as well20:53
tqtranbecause you'll end up adding it multiple times20:54
doug-fishI think that's fixable20:54
tqtranit is, wanna do it? :P20:54
doug-fishmabye20:54
doug-fishmaybe20:54
tqtranhahahaha20:54
*** mrrowden has joined #openstack-horizon20:54
doug-fishcertainly more than I want to have 37 sets of po files20:54
*** sqchen has joined #openstack-horizon20:55
tqtranright20:55
*** rcernin has joined #openstack-horizon20:56
tqtransomeone should add the pep 8 to release note for horizon20:57
tqtranits checking at the gate but not in our run_tests script20:57
david-lyledoug-fish: remember app in django is just content20:58
openstackgerritThai Tran proposed openstack/horizon: Support javascript translation for plugin  https://review.openstack.org/25559020:58
doug-fishdavid-lyle: sure, with you there20:58
tqtrandoug-fish: ^-- see if you like that solution more20:59
*** rajatvig has joined #openstack-horizon20:59
david-lylewhen our content wasn't loaded as plugins, it made things like testing difficult20:59
doug-fishsure - I'm all for loading our content as plugins - I just hadn't realized that we were making every panel it's own application21:01
doug-fishsomehow I thought a single application might contain several panels21:02
*** peristeri has quit IRC21:04
doug-fishtqtran: does that mean that configuration is required outside of the enabled file in order for a plugin to have translation?21:04
*** peristeri has joined #openstack-horizon21:04
tqtrandoug-fish: not really... if configuration you mean including those files in the manifest.in?21:05
doug-fishtqtran: I mean, how does conf.HORIZON_CONFIG['plugins'] get populated?21:06
tqtranyou'll have to do that for manifest or setup.cfg for your static files, so i think it is in the realm of "reasonable" to also specify the path for translations21:06
tqtranif you dont package translations, well... you dont get any... i dont think there is any other way around that21:06
tqtranit cant get more magically than that lol21:07
doug-fishtqtran: the last patch was closer to what I expected21:10
doug-fishunless I'm misreading (quite possible) all the translation paths now have to be added to local_config.py, right?21:10
*** Piet has quit IRC21:11
tqtrannope21:11
tqtranin your plugin, you have a locale folder21:12
doug-fishcool - but I still don't understand how conf.HORIZON_CONFIG['plugins'] gets populated21:12
tqtranwhen you package it, it will include the translation files (po, pot, mo, etc...)21:12
tqtranwhen you request for it, django will automagically go into your installed dir and fetch the translations21:13
doug-fishright - all of that is normal stuff, just like for python21:13
doug-fishwhich works21:13
tqtranright21:13
tqtranHORIZON_CONFIG plugins is just the list of apps21:13
doug-fishdoes it get populated automatically?21:13
tqtranhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/utils/settings.py#L11921:14
tqtranthe work is already done for us21:14
*** rajatvig has quit IRC21:14
tqtranwe have a file crawler that looks through enabled files21:14
*** peristeri has quit IRC21:15
doug-fishtqtran: I thought that code was building our list of installed apps, and prepending it to the INSTALLED_APPS config value21:18
doug-fishit is populating conf.HORIZON_CONFIG['plugins'] somehow as well?21:18
*** bpokorny_ has quit IRC21:23
*** bpokorny has joined #openstack-horizon21:23
tqtrandoug-fish: that is correct21:24
*** bpokorny has quit IRC21:24
doug-fishok that's the part that I don't understand (obviously)21:24
doug-fishdo you know how that happens?21:24
tqtranyes :)21:24
*** bpokorny has joined #openstack-horizon21:25
doug-fish... and will you tell me?21:25
*** dsneddon is now known as dsneddon_biab21:25
doug-fishtell me!21:25
tqtranhahaha21:25
doug-fish:-P21:25
tqtranits all in the code, im basically stealing the apps list before it gets appended to the installed_apps (which contains other stuff like compressor, etc...)21:25
tqtranthis apps list will contain only plugins21:25
tqtranwhich is what we want21:25
doug-fishsounds promising21:26
tqtranso now, HORIZON_CONFIG will have a reference to the list containing only plugins21:26
doug-fishI'm still trying to absorb that fact that we made each of our panels an app21:26
doug-fishwon't plugins want to do that too?21:26
tqtranthen in the context_processor, we further filter that list by excluding all openstack_dashboard panels and dashboards21:26
doug-fishI overlooked your change to https://review.openstack.org/#/c/255590/3/openstack_dashboard/utils/settings.py21:27
tqtranwe made each of our dashboard an app, not the panel21:27
tqtrani am excluding anything starting with openstack_dashboard, be it dashboard or panel for safety measure/future proof21:28
doug-fishgot it21:28
doug-fishI'm getting my plugin set up now ... thanks for stepping me through this21:28
tqtrannp, let me know if that works for you21:29
tqtrani tested it locally with my self-proclaim plugin, so would be good to test it on a real plugin21:29
doug-fish:-)21:29
doug-fishwhere do you keep your plugin?21:30
tqtranhttps://github.com/tqtran7/mon-ext21:31
tqtranextension of what david had21:32
doug-fishcool21:32
doug-fishthx!21:32
tqtranjust copy/paste a locale folder in there21:32
tqtranand modify the manifest.in to include the locale folder21:32
tqtranand you're good to go21:32
doug-fishyour panel has localization problems.  :-P21:33
doug-fishoh wait21:33
doug-fishwow21:33
doug-fishI just can't read all of the lines today21:33
doug-fishbetter just stick to testing21:33
tqtranhaha21:33
tqtrani can update the repo with localization examples in teh future21:34
tqtranits on my to do along witht he doc for it21:35
*** ducttape_ has quit IRC21:35
*** ducttape_ has joined #openstack-horizon21:36
*** sweetJeebus has quit IRC21:36
*** mrrowden has quit IRC21:39
*** ducttape_ has quit IRC21:40
*** sqchen has quit IRC21:41
*** nlahouti has quit IRC21:44
*** Piet has joined #openstack-horizon21:45
*** e0ne has quit IRC21:47
*** nlahouti has joined #openstack-horizon21:47
*** e0ne has joined #openstack-horizon21:49
*** rajatvig has joined #openstack-horizon21:49
*** e0ne has quit IRC21:49
doug-fishtqtran: that patch does the job nicely21:50
*** sqchen has joined #openstack-horizon21:50
doug-fishI'll look at it again and see if I can like it more this time. :-)21:51
openstackgerritRajat Vig proposed openstack/horizon: Add extensions to $q for resolving all promises  https://review.openstack.org/24058921:52
openstackgerritOndřej Nový proposed openstack/django_openstack_auth: Deprecated tox -downloadcache option removed  https://review.openstack.org/25677121:59
*** crobertsrh is now known as _crobertsrh22:03
*** lblanchard has quit IRC22:04
openstackgerritRajat Vig proposed openstack/horizon: API for Metadata Definitions  https://review.openstack.org/21572122:10
*** tjones has joined #openstack-horizon22:11
*** rajatvig has quit IRC22:23
*** ducttape_ has joined #openstack-horizon22:26
*** matt-borland has quit IRC22:29
*** cbader has quit IRC22:30
r1chardj0n3sTravT: thanks for the comment on the swift patch; unfortunately you commented on a dupe patch (not sure how that happened)22:34
r1chardj0n3sTravT: piet is in the loop on the effort to re-do the swift ui too, hope to hear from him about it :-)22:35
TravThmm, that's interesting22:35
TravTwhat'd you think about the finder idea for swift?22:35
r1chardj0n3sthat particular interface that the finder implements is one of my least-favourite of all file interfaces :-P22:36
sjmc7:D22:36
* TravT rofl22:36
sjmc7but what do you REALLY think?22:36
TravTr1chardj0n3s never speaks his mind22:36
r1chardj0n3sTravT: so https://review.openstack.org/#/c/256132/ is the UI patch, which sits on top of the API patch https://review.openstack.org/#/c/256140/22:37
*** ZZelle_ has joined #openstack-horizon22:37
*** openstackgerrit has quit IRC22:37
TravTfunny thing is I to dislike that ui as well, but over time grew to like it.22:37
r1chardj0n3sit's probably broken right now as I did a bunch of stuff to the API patch yesterday that I couldn't test end-to-end22:37
*** pushkaru has joined #openstack-horizon22:37
*** pumaranikar has quit IRC22:37
*** rcernin has quit IRC22:37
r1chardj0n3sI do like the idea of the containers UI getting out of the way once you've actually selected a container22:37
*** openstackgerrit has joined #openstack-horizon22:38
sjmc7it’s not a bad idea to at least look at operating system file browsers22:38
r1chardj0n3sanyway, the interface design is up to the ux folks to think about and do their magic with ;-)22:38
TravTok, so since you have a UI patch up then, does this mean we're not doing mocks... or did i miss that22:38
r1chardj0n3sa reimplementation of the current UI is worthwhile as interacting with the angular version is just so much nicer and ... well, interactive22:39
*** cbader has joined #openstack-horizon22:39
r1chardj0n3sTravT: that question doesn't make sense to me - how do mocks come into this? (and yes, I use mocking in the tests...)22:39
TravTr1chardj0n3s: UI mocks. you know the stuff Piet does in invision22:40
r1chardj0n3sTravT: ah, right22:40
r1chardj0n3sso the UI patch we have up is just the first step22:40
*** pumaranikar has joined #openstack-horizon22:40
*** pushkaru has quit IRC22:40
r1chardj0n3sredesigning the interface could take a while; as I said, reimplenting in angular, with perhaps some simple UI tweaks, can get us big wins without a whole redesign22:40
r1chardj0n3sso interim22:41
r1chardj0n3salso this patch lays the ground work that would be needed for a redesign anyway22:41
TravTsure.22:41
TravTfwiw, the swift UI today is perhaps the ugliest UI i've ever seen22:42
openstackgerritOndřej Nový proposed openstack/tuskar-ui: Deprecated tox -downloadcache option removed  https://review.openstack.org/25684522:42
r1chardj0n3swe also have a swift core on our team who's gonna help us with testing scaling22:42
openstackgerritGudrun Wolfgram proposed openstack/horizon: Improve readability of Horizon Packaging doc  https://review.openstack.org/25606222:43
r1chardj0n3sgetting pagination into the current interface is on our list22:43
TravTwell, we might be pinging you after the holiday break re: searching.22:44
r1chardj0n3sheh, yeah, the current patch is all kinds of broken22:44
r1chardj0n3sTravT: yep, cool22:44
TravTbtw, RE the midcycle22:44
TravTyou can't do the first two weeks in Feb, right?22:45
*** pumaranikar has quit IRC22:45
r1chardj0n3sTravT: true, I cannot22:46
TravTwell, i was chatting with david-lyle about that yesterday22:46
openstackgerritOndřej Nový proposed openstack/xstatic-angular: Deprecated tox -downloadcache option removed  https://review.openstack.org/25684922:47
TravTmaybe the 3rd week in february would be good.22:47
TravTi can't do the first week in february22:47
openstackgerritOndřej Nový proposed openstack/xstatic-angular-bootstrap: Deprecated tox -downloadcache option removed  https://review.openstack.org/25685222:47
r1chardj0n3sTravT: I can do that week, but I understand david-lyle is busy 3rd week22:47
r1chardj0n3sI can do last two weeks in Feb22:47
openstackgerritOndřej Nový proposed openstack/xstatic-angular-fileupload: Deprecated tox -downloadcache option removed  https://review.openstack.org/25685322:47
TravTI can do the last week as well (except for Friday).22:47
r1chardj0n3sbut I have unavoidable commitment first two weeks22:47
openstackgerritOndřej Nový proposed openstack/xstatic-angular-lrdragndrop: Deprecated tox -downloadcache option removed  https://review.openstack.org/25685522:48
lhcheng_TravT: the swift UI has been the ugliest ever since :P22:48
openstackgerritOndřej Nový proposed openstack/xstatic-bootstrap-datepicker: Deprecated tox -downloadcache option removed  https://review.openstack.org/25685622:48
openstackgerritOndřej Nový proposed openstack/xstatic-bootstrap-scss: Deprecated tox -downloadcache option removed  https://review.openstack.org/25685722:48
openstackgerritOndřej Nový proposed openstack/xstatic-d3: Deprecated tox -downloadcache option removed  https://review.openstack.org/25686022:48
TravTlhcheng_ :P22:48
r1chardj0n3sTravT: I'm about to board a plane, won't be back online for about 5 hours22:48
openstackgerritOpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements  https://review.openstack.org/25648222:49
openstackgerritOndřej Nový proposed openstack/xstatic-font-awesome: Deprecated tox -downloadcache option removed  https://review.openstack.org/25686122:49
openstackgerritOndřej Nový proposed openstack/xstatic-jasmine: Deprecated tox -downloadcache option removed  https://review.openstack.org/25686222:49
TravTok, well, i'm planning on not working this weekend, so let's catch up next week22:49
openstackgerritOndřej Nový proposed openstack/xstatic-jsencrypt: Deprecated tox -downloadcache option removed  https://review.openstack.org/25686322:49
r1chardj0n3sTravT: yep!22:49
openstackgerritOndřej Nový proposed openstack/xstatic-magic-search: Deprecated tox -downloadcache option removed  https://review.openstack.org/25686422:49
TravThappy travels!22:49
openstackgerritOndřej Nový proposed openstack/xstatic-rickshaw: Deprecated tox -downloadcache option removed  https://review.openstack.org/25686622:49
r1chardj0n3sI'm most likely gonna do some more cleanup on the swift ui patches to get them working again, and then weekend22:49
r1chardj0n3s(yes, it is already Saturday here ;-)22:49
TravTi guess you need something to do on the plane, i guess22:50
r1chardj0n3so/22:50
TravTo/22:50
openstackgerritGerman Rivera proposed openstack/horizon: adding-toggle-to-date-ranges  https://review.openstack.org/25687622:55
*** rajatvig has joined #openstack-horizon23:00
*** August1914 has joined #openstack-horizon23:03
*** bpokorny has quit IRC23:05
*** bpokorny has joined #openstack-horizon23:06
openstackgerritRajat Vig proposed openstack/horizon: Add Create Volume Action for the Image  https://review.openstack.org/22967723:09
*** hurgleburgler has quit IRC23:09
*** hurgleburgler has joined #openstack-horizon23:10
*** jtriley_ has quit IRC23:10
*** ducttape_ has quit IRC23:12
openstackgerritRajat Vig proposed openstack/horizon: Adding multiple row actions for the Image table  https://review.openstack.org/21796423:18
*** vijendar has quit IRC23:20
openstackgerritRajat Vig proposed openstack/horizon: API for getting and updating quotas  https://review.openstack.org/20712623:24
*** lhcheng_ has quit IRC23:25
*** lhcheng has joined #openstack-horizon23:28
openstackgerritRajat Vig proposed openstack/horizon: Add unit tests for load-edit directive  https://review.openstack.org/23778823:29
*** lhcheng has quit IRC23:29
*** hurgleburgler has quit IRC23:29
*** August1914 has quit IRC23:36
*** tjones has quit IRC23:48
*** mpavlase has joined #openstack-horizon23:48
*** sqchen has quit IRC23:48
*** sqchen has joined #openstack-horizon23:50
*** bpokorny has quit IRC23:57
*** bpokorny has joined #openstack-horizon23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!