| *** jerrygb_ has joined #openstack-horizon | 00:04 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 00:05 |
|---|---|---|
| *** jerrygb has quit IRC | 00:05 | |
| *** belmoreira has quit IRC | 00:15 | |
| *** rebase has quit IRC | 00:15 | |
| *** openstackstatus has quit IRC | 00:24 | |
| *** openstackstatus has joined #openstack-horizon | 00:25 | |
| *** ChanServ sets mode: +v openstackstatus | 00:25 | |
| *** ducttape_ has quit IRC | 00:34 | |
| *** rebase has joined #openstack-horizon | 00:34 | |
| openstackgerrit | Errol Pais proposed openstack/horizon: Add API to Create/Update/Delete Images in Glance https://review.openstack.org/236832 | 00:35 |
| openstackgerrit | Errol Pais proposed openstack/horizon: Adding Create Image Action to angular images panel https://review.openstack.org/236042 | 00:35 |
| openstackgerrit | Errol Pais proposed openstack/horizon: Adding Edit Image Action to angular images panel https://review.openstack.org/217828 | 00:35 |
| openstackgerrit | Errol Pais proposed openstack/horizon: Add Action to delete multiple and single images to images panel https://review.openstack.org/217422 | 00:35 |
| openstackgerrit | Merged openstack/horizon: Remove data-type and sort from flavor column https://review.openstack.org/248594 | 00:35 |
| *** rajatvig has quit IRC | 00:40 | |
| openstackgerrit | Merged openstack/horizon: REST API to Get a Volume and Volume Type(s) https://review.openstack.org/241415 | 00:41 |
| *** nlahouti has quit IRC | 00:49 | |
| *** rebase has quit IRC | 00:51 | |
| *** nlahouti has joined #openstack-horizon | 00:56 | |
| *** errolpais has quit IRC | 00:56 | |
| *** zhenguo has joined #openstack-horizon | 01:19 | |
| openstackgerrit | Merged openstack/horizon: Change Permanent Cookie Contain Sensitive Info https://review.openstack.org/246611 | 01:20 |
| *** openstackgerrit has quit IRC | 01:22 | |
| *** openstackgerrit has joined #openstack-horizon | 01:22 | |
| *** SimonChung has quit IRC | 01:25 | |
| *** nlahouti has quit IRC | 01:27 | |
| *** ducttape_ has joined #openstack-horizon | 01:33 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Pagination for flavor - more link https://review.openstack.org/234638 | 01:48 |
| *** yamamoto has joined #openstack-horizon | 01:51 | |
| *** jerrygb_ has quit IRC | 01:51 | |
| *** jerrygb has joined #openstack-horizon | 01:52 | |
| *** jingjing_ren has quit IRC | 01:53 | |
| *** julim has joined #openstack-horizon | 01:53 | |
| *** jerrygb has quit IRC | 01:55 | |
| *** saksham has quit IRC | 01:56 | |
| *** SurajD has joined #openstack-horizon | 02:08 | |
| *** mtanino has quit IRC | 02:30 | |
| openstackgerrit | LIU Yulong proposed openstack/horizon: Add floating IP panel to admin dashboard https://review.openstack.org/143628 | 02:47 |
| *** jingjing_ren has joined #openstack-horizon | 02:56 | |
| *** wolverineav has joined #openstack-horizon | 02:57 | |
| *** wolverineav has quit IRC | 02:58 | |
| *** jinxing has joined #openstack-horizon | 03:02 | |
| jinxing | hi guys | 03:03 |
| jinxing | how can i use the network topology alone in horizon of liberty version? | 03:05 |
| *** jwy has quit IRC | 03:09 | |
| *** kzaitsev_mb has joined #openstack-horizon | 03:10 | |
| *** ccard_ has joined #openstack-horizon | 03:33 | |
| *** jingjing_ren has quit IRC | 03:35 | |
| *** ccard__ has quit IRC | 03:35 | |
| *** Guest80154 has joined #openstack-horizon | 03:39 | |
| *** Guest80154 has quit IRC | 03:41 | |
| *** Drago1 has joined #openstack-horizon | 03:45 | |
| *** kzaitsev_mb has quit IRC | 03:45 | |
| docaedo | r1chardj0n3s: glad you could reproduce that app-catalog error :) I don't know enough about angular to go much further | 03:51 |
| docaedo | r1chardj0n3s: but if you see its something we need to adjust in how we are passing values we can adjust quickly | 03:52 |
| r1chardj0n3s | docaedo: I'm just poking at it now, yep! | 03:52 |
| docaedo | r1chardj0n3s: cool, I'll pay attention in case I can help - thanks for looking at it! | 03:54 |
| r1chardj0n3s | hmm, the two commit hashes in the bug report don't appear to bracket the patch that's being blamed as the cause | 03:56 |
| r1chardj0n3s | 6a76dbd2fc50f2c7f8369eb92ce46bbe88069a68 is a couple of weeks before that patch landed | 03:56 |
| docaedo | I'm not at computer, but my last comment on the bug has two hashes that I think are in sequence - works with one, fails with other. | 03:59 |
| r1chardj0n3s | very weird too, since the URL being used to invoke the Create An Image form is the same when it's working and not - so I'm tempted to say this isn't an angular issue. gonna poke at that form code | 03:59 |
| r1chardj0n3s | docaedo: the hashes are in sequence, but they're a couple of weeks of commits apart :-) | 03:59 |
| r1chardj0n3s | I'm going to try to narrow it down | 04:00 |
| r1chardj0n3s | indeed, stepping back one commit from the one blamed doesn't fix the problem :-) | 04:00 |
| r1chardj0n3s | further digging required.... | 04:00 |
| docaedo | Thanks, I think I just worked back in git log to get the ones I noted :) | 04:00 |
| *** jingjing_ren has joined #openstack-horizon | 04:01 | |
| r1chardj0n3s | hmm, actually, I think git's messing with me/us | 04:07 |
| *** jingjing_ren has quit IRC | 04:07 | |
| r1chardj0n3s | "git checkout 0f39dea2c7e722781fe3374abbaada781488c2cc" doesn't list 6a76dbd2fc50f2c7f8369eb92ce46bbe88069a68 as the immediate ancestor, but the commit *before* that one | 04:08 |
| * r1chardj0n3s smh at git ;-) | 04:08 | |
| docaedo | If we can't trust git we are in trouble. Best to just shut down this whole openstack business! | 04:09 |
| r1chardj0n3s | :-D | 04:09 |
| r1chardj0n3s | I'll figure it out :-) | 04:09 |
| *** Drago1 has quit IRC | 04:09 | |
| r1chardj0n3s | so I do believe the relationship is correct (between patch and bug) I'm just trying to sort through it | 04:11 |
| r1chardj0n3s | git is just a distraction | 04:12 |
| *** jinxing has quit IRC | 04:13 | |
| *** kzaitsev_mb has joined #openstack-horizon | 04:14 | |
| *** kzaitsev_mb has quit IRC | 04:25 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add API to Create/Update/Delete Images in Glance https://review.openstack.org/236832 | 04:26 |
| *** rajatvig has joined #openstack-horizon | 04:27 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add Action to delete multiple and single images to images panel https://review.openstack.org/217422 | 04:28 |
| openstackgerrit | Kenji Ishii proposed openstack/horizon: Add style to wrap pre tag https://review.openstack.org/250146 | 04:38 |
| *** SurajD has quit IRC | 04:39 | |
| *** ianbrown has joined #openstack-horizon | 04:41 | |
| *** deray has joined #openstack-horizon | 04:42 | |
| *** SurajD has joined #openstack-horizon | 04:42 | |
| *** ducttape_ has quit IRC | 04:49 | |
| openstackgerrit | Kenji Ishii proposed openstack/horizon: Modify the regular expression when you create Pseudo-folder https://review.openstack.org/243625 | 04:50 |
| *** gyee has quit IRC | 04:52 | |
| *** ducttape_ has joined #openstack-horizon | 04:58 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add Action to delete multiple and single images to images panel https://review.openstack.org/217422 | 05:02 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Fix CSS for delete button if only delete is allowed https://review.openstack.org/243796 | 05:08 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add API services for angular Volumes panel https://review.openstack.org/233760 | 05:10 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add API to Create/Update/Delete Images in Glance https://review.openstack.org/236832 | 05:12 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add Action to delete multiple and single images to images panel https://review.openstack.org/217422 | 05:12 |
| *** dabrorob has joined #openstack-horizon | 05:12 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Adding Create Image Action to angular images panel https://review.openstack.org/236042 | 05:17 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Adding Edit Image Action to angular images panel https://review.openstack.org/217828 | 05:17 |
| *** amotoki has joined #openstack-horizon | 05:26 | |
| *** dabrorob has quit IRC | 05:27 | |
| *** dabrorob has joined #openstack-horizon | 05:28 | |
| *** masco has joined #openstack-horizon | 05:28 | |
| *** mohankumar has joined #openstack-horizon | 05:29 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add API services for angular Volumes panel https://review.openstack.org/233760 | 05:32 |
| *** ianbrown has quit IRC | 05:32 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: Add Create Volume Action for the Image https://review.openstack.org/229677 | 05:32 |
| *** SimonChung has joined #openstack-horizon | 05:32 | |
| *** SimonChung1 has joined #openstack-horizon | 05:34 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: Add Create Volume Action for the Image https://review.openstack.org/229677 | 05:34 |
| *** jerrygb has joined #openstack-horizon | 05:35 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 05:35 |
| *** SimonChung has quit IRC | 05:37 | |
| openstackgerrit | Merged openstack/horizon: Disable angular wizard finish button when clicked https://review.openstack.org/251205 | 05:37 |
| *** tyagiprince has joined #openstack-horizon | 05:40 | |
| openstackgerrit | Merged openstack/horizon: Enable eqeqeq https://review.openstack.org/244925 | 05:43 |
| *** vgridnev has joined #openstack-horizon | 05:45 | |
| *** ygl has joined #openstack-horizon | 05:50 | |
| *** ygl has quit IRC | 05:51 | |
| *** ducttape_ has quit IRC | 05:52 | |
| *** jerrygb has quit IRC | 05:52 | |
| openstackgerrit | sanjana proposed openstack/horizon: Adding ceilometer alarm management page for threshold alarms which supports -Addition of alarms -Deletion of alarms -Enabling and Disabling of alarms https://review.openstack.org/251644 | 05:54 |
| *** Guest76963 has joined #openstack-horizon | 05:55 | |
| *** SurajD has quit IRC | 05:57 | |
| *** Guest76963 has quit IRC | 06:00 | |
| *** chestack has joined #openstack-horizon | 06:00 | |
| *** chestack has quit IRC | 06:02 | |
| *** chestack has joined #openstack-horizon | 06:02 | |
| *** nlahouti has joined #openstack-horizon | 06:07 | |
| *** rajatvig has quit IRC | 06:09 | |
| *** SurajD has joined #openstack-horizon | 06:11 | |
| *** hurgleburgler has quit IRC | 06:12 | |
| *** dabrorob has quit IRC | 06:14 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Fix issue when using glance v2 api https://review.openstack.org/249531 | 06:20 |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Fix update image when using v2 https://review.openstack.org/251672 | 06:20 |
| *** rajatvig has joined #openstack-horizon | 06:24 | |
| *** rajatvig has quit IRC | 06:29 | |
| *** lhcheng has joined #openstack-horizon | 06:30 | |
| *** lhcheng_ has joined #openstack-horizon | 06:32 | |
| masco | hello all | 06:33 |
| masco | how to run 'gate-horizon-npm-run-lint' and 'gate-horizon-npm-run-test' locally? | 06:33 |
| *** lhcheng has quit IRC | 06:35 | |
| masco | lhcheng_, have any idea on this ^ | 06:35 |
| lhcheng_ | masco: I think this should work ./run_tesh.sh -e | 06:36 |
| lhcheng_ | based from: https://github.com/openstack/horizon/blob/master/run_tests.sh#L29 | 06:37 |
| openstackgerrit | sanjana proposed openstack/horizon: Adding ceilometer alarms page for -Addition -Deletion -Enabling and Disabling of alarms https://review.openstack.org/251644 | 06:37 |
| masco | lhcheng_, thanks | 06:38 |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Fix issue when using glance v2 api https://review.openstack.org/249531 | 06:43 |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Fix update image when using v2 https://review.openstack.org/251672 | 06:43 |
| *** SurajD has quit IRC | 06:45 | |
| *** rajatvig has joined #openstack-horizon | 06:46 | |
| *** jprovazn has joined #openstack-horizon | 06:49 | |
| *** t_mazur has joined #openstack-horizon | 06:52 | |
| *** ducttape_ has joined #openstack-horizon | 06:53 | |
| *** amit213 has quit IRC | 06:55 | |
| *** amit213 has joined #openstack-horizon | 06:56 | |
| *** rajatvig has quit IRC | 06:56 | |
| *** ducttape_ has quit IRC | 06:59 | |
| *** SurajD has joined #openstack-horizon | 06:59 | |
| *** ducttape_ has joined #openstack-horizon | 07:03 | |
| *** btully has quit IRC | 07:04 | |
| *** vgridnev has quit IRC | 07:06 | |
| *** tyagiprince has quit IRC | 07:17 | |
| *** aortega has quit IRC | 07:17 | |
| *** nlahouti has quit IRC | 07:19 | |
| *** ducttape_ has quit IRC | 07:20 | |
| *** tyagiprince has joined #openstack-horizon | 07:24 | |
| *** nlahouti has joined #openstack-horizon | 07:30 | |
| *** vgridnev has joined #openstack-horizon | 07:31 | |
| *** nlahouti1 has joined #openstack-horizon | 07:32 | |
| *** nlahouti has quit IRC | 07:34 | |
| *** t_mazur has quit IRC | 07:39 | |
| *** t_mazur has joined #openstack-horizon | 07:39 | |
| *** mpavlase has joined #openstack-horizon | 07:39 | |
| *** chestack has quit IRC | 07:41 | |
| *** nlahouti1 has quit IRC | 07:48 | |
| *** chestack has joined #openstack-horizon | 07:59 | |
| *** chestack has quit IRC | 07:59 | |
| *** chestack has joined #openstack-horizon | 07:59 | |
| *** ygl_ has joined #openstack-horizon | 08:05 | |
| *** reedip has quit IRC | 08:05 | |
| *** deray has quit IRC | 08:08 | |
| *** deray has joined #openstack-horizon | 08:08 | |
| *** rdopiera has joined #openstack-horizon | 08:10 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Fix issue when using glance v2 api https://review.openstack.org/249531 | 08:16 |
| openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Force releasenotes warnings to be treated as errors https://review.openstack.org/251699 | 08:16 |
| *** ducttape_ has joined #openstack-horizon | 08:21 | |
| *** reedip has joined #openstack-horizon | 08:22 | |
| *** ducttape_ has quit IRC | 08:25 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Fix update image when using v2 https://review.openstack.org/251672 | 08:30 |
| *** nullvariable has quit IRC | 08:30 | |
| *** rcernin has joined #openstack-horizon | 08:37 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Fix update image metadata when using v2 https://review.openstack.org/251704 | 08:37 |
| *** itxaka has joined #openstack-horizon | 08:43 | |
| *** kzaitsev_mb has joined #openstack-horizon | 08:47 | |
| *** josecastroleon1 has quit IRC | 08:50 | |
| *** aortega has joined #openstack-horizon | 08:50 | |
| *** jerrygb has joined #openstack-horizon | 08:52 | |
| *** btully has joined #openstack-horizon | 08:57 | |
| *** belmoreira has joined #openstack-horizon | 09:00 | |
| *** SurajD has quit IRC | 09:04 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Fix tenant_name doesn't exist for admin image table https://review.openstack.org/251722 | 09:05 |
| *** wdeclercq has joined #openstack-horizon | 09:05 | |
| *** kzaitsev_mb has quit IRC | 09:07 | |
| *** ygbo_ has joined #openstack-horizon | 09:11 | |
| *** ygbo has joined #openstack-horizon | 09:11 | |
| *** ygbo_ has quit IRC | 09:13 | |
| *** ygbo has quit IRC | 09:13 | |
| *** ygbo has joined #openstack-horizon | 09:14 | |
| *** SurajD has joined #openstack-horizon | 09:19 | |
| *** ducttape_ has joined #openstack-horizon | 09:21 | |
| *** btully has quit IRC | 09:25 | |
| *** ducttape_ has quit IRC | 09:26 | |
| *** tyagiprince has quit IRC | 09:42 | |
| *** tyagiprince has joined #openstack-horizon | 09:42 | |
| openstackgerrit | Toshiya Shiga proposed openstack/horizon: Add a status to the process provided with the logout. https://review.openstack.org/251743 | 09:46 |
| *** tyagiprince has quit IRC | 09:49 | |
| *** tyagiprince has joined #openstack-horizon | 09:49 | |
| *** mohankumar has quit IRC | 09:49 | |
| *** josecastroleon has joined #openstack-horizon | 09:50 | |
| *** lhcheng has joined #openstack-horizon | 09:55 | |
| *** mohankumar has joined #openstack-horizon | 09:58 | |
| *** lhcheng_ has quit IRC | 09:59 | |
| *** zhenguo has quit IRC | 10:04 | |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon: Port list check is missing for LBaaS Add Member https://review.openstack.org/251757 | 10:04 |
| *** aix has joined #openstack-horizon | 10:05 | |
| *** wuhg has joined #openstack-horizon | 10:09 | |
| *** mohankumar has quit IRC | 10:10 | |
| *** wuhg has left #openstack-horizon | 10:11 | |
| *** ducttape_ has joined #openstack-horizon | 10:22 | |
| *** kiran-r has joined #openstack-horizon | 10:22 | |
| *** wdeclercq has quit IRC | 10:25 | |
| *** kzaitsev_mb has joined #openstack-horizon | 10:27 | |
| *** ducttape_ has quit IRC | 10:28 | |
| *** jerrygb has quit IRC | 10:31 | |
| *** wdeclercq has joined #openstack-horizon | 10:33 | |
| *** e0ne has joined #openstack-horizon | 10:37 | |
| *** ygl_ has quit IRC | 10:38 | |
| robcresswell | Morning all | 10:44 |
| r1chardj0n3s | hey robcresswell | 10:44 |
| robcresswell | r1chardj0n3s: Late one! Whatcha working on? | 10:44 |
| *** tosky has joined #openstack-horizon | 10:44 | |
| r1chardj0n3s | fallout 4 :-) | 10:44 |
| robcresswell | haa | 10:44 |
| robcresswell | very good | 10:44 |
| r1chardj0n3s | just checking on email in loading screens | 10:45 |
| robcresswell | Ah I see | 10:45 |
| *** sambetts-afk is now known as sambetts | 10:45 | |
| robcresswell | I picked up the Starcraft 2 expansions the other week... forgot how competitive some games are online >.< | 10:45 |
| r1chardj0n3s | yep | 10:45 |
| tosky | games like "let's have this review merged"? | 10:46 |
| * tosky hides | 10:46 | |
| r1chardj0n3s | a bunch of friends are into CS:GO, but I've not really been up for that level of competing for a few years :-) | 10:46 |
| robcresswell | Yeah I used to play League of Legends a couple years ago (beta/ first release) until I realised it was stressing me out more than it was fun. Don't need two jobs :) | 10:47 |
| r1chardj0n3s | yikes, indeed! | 10:47 |
| wdeclercq | Sorry to interrupt the games :) I have a question about https://review.openstack.org/#/c/233709/12/doc/source/tutorials/plugin.rst or https://bugs.launchpad.net/horizon/+bug/1511593 | 10:47 |
| openstack | Launchpad bug 1511593 in OpenStack Dashboard (Horizon) "Missing documentation for plugins" [Critical,In progress] - Assigned to David Lyle (david-lyle) | 10:47 |
| r1chardj0n3s | I like f4 'cos it's just a bunch of pixel mayhem, but also kinda pretty :-) | 10:47 |
| *** hughhalf has quit IRC | 10:47 | |
| r1chardj0n3s | I'll stop distracting now :-) | 10:47 |
| wdeclercq | I realise that the documenation is for mitaka, but does that also mean this plugin architecture is only available since mitaka? or does it exist for longer? | 10:48 |
| robcresswell | tosky: Ha, I'll be on it this week. Had a couple days PTO. Did you have something specific that needs looking at? | 10:48 |
| *** mdavidson has joined #openstack-horizon | 10:48 | |
| robcresswell | wdeclercq: Plugin architecture has been around for a long time | 10:48 |
| tosky | robcresswell: no, no, just joking in general, but thanks :) | 10:48 |
| *** hughhalf has joined #openstack-horizon | 10:48 | |
| wdeclercq | Ah okay, So I guess I can use this draft documentation for liberty as well then. | 10:48 |
| wdeclercq | Thanks | 10:49 |
| mrunge | robcresswell, good morning | 10:49 |
| mrunge | robcresswell, I have a question for you: https://bugs.launchpad.net/horizon/+bug/1402959 | 10:49 |
| openstack | Launchpad bug 1402959 in OpenStack Dashboard (Horizon) "Support Launching an instance with a port with vnic_type=direct" [Undecided,Invalid] | 10:49 |
| mrunge | why did you mark this invalid? | 10:49 |
| robcresswell | wdeclercq: Absolutely. It was first added about 2 years ago | 10:49 |
| robcresswell | mrunge: Looking | 10:50 |
| mrunge | it should be a blueprint? | 10:50 |
| robcresswell | mrunge: You know. I think that I may have misclicked. I don't recall the reasoning and I didn't leave a comment. | 10:50 |
| *** e0ne has quit IRC | 10:51 | |
| mrunge | robcresswell, ok, thank you for looking at it. I'll move that to confirmed? Or shall we turn that into a blueprint? | 10:51 |
| robcresswell | mrunge: Frankly, there is probably little value in making a BP unless we have someone to work on it. | 10:52 |
| robcresswell | mrunge: I would leave as confirmed | 10:52 |
| mrunge | ok, will change it then | 10:52 |
| mrunge | and will try to find someone to look at that ;-) | 10:53 |
| *** mohankumar has joined #openstack-horizon | 10:53 | |
| robcresswell | mrunge: I've left a comment apologising. Sorry about the noise there! | 10:53 |
| mrunge | no worries, robcresswell | 10:53 |
| mrunge | and thank you for looking at it again | 10:53 |
| robcresswell | zigo: I'll be releasing more Django 1.9 patches in the next couple weeks. | 10:58 |
| zigo | robcresswell: Hi there! | 10:59 |
| zigo | robcresswell: Will you make a list of all of them? | 10:59 |
| robcresswell | zigo: They'll all be attached to that blueprint, and I'll try to remember to ping when they go in | 10:59 |
| zigo | robcresswell: Thanks a lot! | 11:00 |
| zigo | robcresswell: FYI, I already started working on packaging Mitaka. I'm almost done with all Oslo libs now. | 11:00 |
| robcresswell | How does that process work when its still in development? Just create the packages and then sync with upstream as code goes in? | 11:01 |
| zigo | robcresswell: Yeah, something like that. | 11:02 |
| zigo | robcresswell: For Oslo libs, it's just packaging the latest released tag. | 11:02 |
| zigo | robcresswell: We will need to package the latest commit of all server packages too, but that doesn't include oslo libs. | 11:02 |
| robcresswell | zigo: I see. I'm hoping we can make the packaging process a little smoother this cycle. I'm working on updating how we do settings, so we can support a configurable local_settings.d/ with *.ini. | 11:04 |
| robcresswell | But, takes time amongst other patches and reviewing :) | 11:04 |
| zigo | :) | 11:05 |
| *** aix has quit IRC | 11:06 | |
| robcresswell | zigo: I'm curious; last cycle it was pointed out that our MANIFEST.in is not complete/useful. Would it take much to make it usable? Would that help at all? | 11:06 |
| robcresswell | mrunge: ^^ | 11:06 |
| zigo | robcresswell: I'm happy with Horizon's MANIFEST.in, it's just that I need to patch it a little bit to have all files in, though I believe that's an issue in PBR which I haven't had time to work on. | 11:07 |
| zigo | robcresswell: The same way, PBR always misses the alembic.in of all server packages, for a reason ... :/ | 11:07 |
| *** mohankumar has quit IRC | 11:07 | |
| zigo | So, the Debian packaging has hacks to work around that. | 11:07 |
| mrunge | robcresswell, I think MANIFEST.in was fixed last time | 11:07 |
| mrunge | oh, I'm patching pbr out | 11:08 |
| robcresswell | mrunge: I patched it to remove a couple stupid things, but david-lyle mentioned that it was incomplete | 11:08 |
| robcresswell | mrunge: Heh, I saw your bug for that change | 11:08 |
| mrunge | until now, I didn't hit an issue with MANIFEST.in | 11:08 |
| robcresswell | mrunge: Ah, okay, thats good. | 11:09 |
| mrunge | yeah. there's still not much sense in calculating something static at each call again and again | 11:09 |
| mrunge | re: pbr | 11:09 |
| *** deray has quit IRC | 11:10 | |
| *** chestack has quit IRC | 11:12 | |
| *** jerrygb has joined #openstack-horizon | 11:16 | |
| *** aix has joined #openstack-horizon | 11:18 | |
| *** jerrygb has quit IRC | 11:19 | |
| *** yamamoto has quit IRC | 11:20 | |
| *** nullvariable has joined #openstack-horizon | 11:24 | |
| *** iurygregory_ is now known as iurygregory | 11:27 | |
| *** mpavlase has quit IRC | 11:29 | |
| *** mohankumar has joined #openstack-horizon | 11:29 | |
| *** chestack has joined #openstack-horizon | 11:30 | |
| *** mpavlase has joined #openstack-horizon | 11:32 | |
| *** chlong has quit IRC | 11:35 | |
| *** chlong has joined #openstack-horizon | 11:35 | |
| *** rhagarty has quit IRC | 11:37 | |
| *** chestack has quit IRC | 11:39 | |
| *** rhagarty has joined #openstack-horizon | 11:40 | |
| betherly | Hi all! Would anyone be able to help me with Cindy's IRC nick? | 11:43 |
| *** svasheka has quit IRC | 11:43 | |
| *** svasheka has joined #openstack-horizon | 11:49 | |
| mrunge | betherly, should be clu | 11:50 |
| *** chestack has joined #openstack-horizon | 11:51 | |
| betherly | great thanks mrunge :) | 11:53 |
| *** tosky has quit IRC | 11:53 | |
| *** tosky has joined #openstack-horizon | 11:53 | |
| *** erlon has joined #openstack-horizon | 11:56 | |
| *** ducttape_ has joined #openstack-horizon | 12:01 | |
| *** yamamoto has joined #openstack-horizon | 12:04 | |
| *** ducttape_ has quit IRC | 12:06 | |
| *** clayton has quit IRC | 12:06 | |
| *** zao_ has joined #openstack-horizon | 12:07 | |
| *** zao has quit IRC | 12:08 | |
| *** zao_ is now known as zao | 12:08 | |
| openstackgerrit | Serhii Vasheka proposed openstack/horizon: Add test_create_delete_volume https://review.openstack.org/237044 | 12:09 |
| openstackgerrit | Serhii Vasheka proposed openstack/horizon: Add test_create_delete_volume https://review.openstack.org/237044 | 12:11 |
| *** btully has joined #openstack-horizon | 12:12 | |
| *** mpavlase has quit IRC | 12:13 | |
| *** tosky has quit IRC | 12:13 | |
| *** clayton has joined #openstack-horizon | 12:13 | |
| *** tosky has joined #openstack-horizon | 12:14 | |
| *** _crobertsrh is now known as crobertsrh | 12:14 | |
| *** btully has quit IRC | 12:16 | |
| SurajD | Can somebody review https://review.openstack.org/#/c/249662/ | 12:17 |
| *** jerrygb has joined #openstack-horizon | 12:20 | |
| *** Daisy has joined #openstack-horizon | 12:20 | |
| *** kiranr has joined #openstack-horizon | 12:20 | |
| *** kiran-r has quit IRC | 12:21 | |
| *** tyagiprince has quit IRC | 12:23 | |
| *** mpavlase has joined #openstack-horizon | 12:24 | |
| *** e0ne has joined #openstack-horizon | 12:25 | |
| mrunge | SurajD, why should someone do review that patch before any other patch? | 12:25 |
| *** pauloewerton has joined #openstack-horizon | 12:26 | |
| SurajD | mrunge, I dont understand you :p | 12:26 |
| *** jerrygb has quit IRC | 12:27 | |
| *** zao has quit IRC | 12:27 | |
| *** zao has joined #openstack-horizon | 12:27 | |
| *** lhcheng has quit IRC | 12:33 | |
| *** lhcheng has joined #openstack-horizon | 12:34 | |
| *** e0ne has quit IRC | 12:34 | |
| *** e0ne_ has joined #openstack-horizon | 12:37 | |
| *** t_mazur has quit IRC | 12:48 | |
| *** Daisy has quit IRC | 12:49 | |
| *** mohankumar has quit IRC | 12:55 | |
| *** jerrygb has joined #openstack-horizon | 13:01 | |
| *** julim has quit IRC | 13:01 | |
| wdeclercq | About the documentation / tutorial for the plugin infrastructure: https://review.openstack.org/#/c/233709/12/doc/source/tutorials/plugin.rst | 13:09 |
| *** ducttape_ has joined #openstack-horizon | 13:10 | |
| wdeclercq | 1) in the file linked above, around line 50 is the directory tree. and at line 106 they say ADD_INSTALLED_APPS = ['myplugin'], It seems I need 'myplugin.content' | 13:10 |
| wdeclercq | 2) for installing at the bottom it says "Run "``horizon``/tools/with_venv.sh pip install sdist/``package``.tar.gz"", while for me it's not in 'sdist', but just 'dist' | 13:10 |
| wdeclercq | Not sure if these are issues on my end or the documentation. | 13:10 |
| robcresswell | 1) Yes, this sounds correct. Could you leave a comment? | 13:11 |
| robcresswell | wdeclercq: ^^ | 13:12 |
| wdeclercq | robcresswell, sure. | 13:12 |
| robcresswell | As for 2... | 13:12 |
| *** katyafervent is now known as katyafervent_awa | 13:13 | |
| robcresswell | wdeclercq: I think you're right again about 2 | 13:14 |
| *** masco has quit IRC | 13:16 | |
| *** katyafervent_awa is now known as katyafervent | 13:16 | |
| wdeclercq | robcresswell: I added both comments to gerrit | 13:16 |
| robcresswell | wdeclercq: Thanks! | 13:17 |
| *** kiranr has quit IRC | 13:19 | |
| wdeclercq | robcresswell, o yea, I also had to add an ADD_PANEL line to the enabled file for the panel to appear. That's also correct, or should ADD_INSTALLED_APPS automagically do that | 13:20 |
| *** stevemar has quit IRC | 13:22 | |
| *** stevemar_znc has joined #openstack-horizon | 13:23 | |
| *** SurajD has quit IRC | 13:25 | |
| robcresswell | wdeclercq: That sounds correct. I did that with another plugin I wrote. | 13:27 |
| robcresswell | Comment time again :) | 13:27 |
| wdeclercq | :) | 13:27 |
| *** SurajD has joined #openstack-horizon | 13:28 | |
| *** adelia has joined #openstack-horizon | 13:30 | |
| *** ducttape_ has quit IRC | 13:33 | |
| *** adelia has quit IRC | 13:33 | |
| *** adelia has joined #openstack-horizon | 13:34 | |
| tsufiev | SurajD, he meant 'what makes your patch so special that others should reprioritize their review queues and review it ahead of other patches?' | 13:37 |
| tsufiev | sad, but true | 13:37 |
| *** adelia has quit IRC | 13:38 | |
| tsufiev | look for example at my patches waiting in queue: https://review.openstack.org/#/q/owner:tsufiev+project:openstack/horizon+status:open,n,z | 13:39 |
| robcresswell | tsufiev: :( | 13:39 |
| robcresswell | tsufiev: Still trying to get my code written for this cycle so I can focus on reviewing. Tough balance. | 13:40 |
| mrunge | SurajD, just go ahead and review tsufievs patches. I'll be happily review yours after | 13:40 |
| tsufiev | robcresswell, I'm not complaining as I understand that we have priorities :) | 13:40 |
| *** yamamoto has quit IRC | 13:40 | |
| tsufiev | well, I didn't mean that )) | 13:40 |
| SurajD | tsufiev, oh sorry I didn't knew that's a bad manner to ask others to review my code. Now that I have figured out, I apologise for it. | 13:40 |
| tsufiev | SurajD, I was leading to a point that reviews in a queue are being ordered by bug/blueprint priorities | 13:40 |
| SurajD | mrunge, sure, I am little new to this process of getting review and reviewing others patches :) | 13:41 |
| tsufiev | if if fixes very severe bug, chances that it will be reviewed soon are pretty high | 13:41 |
| robcresswell | SurajD: You can try https://wiki.openstack.org/wiki/Horizon/WeeklyBugReport or https://etherpad.openstack.org/p/mitaka-horizon-priorities for ideas :) | 13:41 |
| SurajD | tsufiev, mrunge thanks for notifying me of that | 13:41 |
| SurajD | robcresswell, thanks for pointers | 13:43 |
| *** dabrorob has joined #openstack-horizon | 13:43 | |
| tsufiev | SurajD, you're welcome :) | 13:43 |
| *** dabrorob has left #openstack-horizon | 13:43 | |
| tsufiev | robcresswell, yes, I guess the same is true for others - until m-1 it's hard to attend much attention to anyone's patches because everybody is working on theirs | 13:44 |
| tsufiev | *to attract | 13:44 |
| robcresswell | tsufiev: The problem for me is, later in the cycle I tend to get way more horizon-infra work; fixing the gate, docs, making sure high priority bugs are being fixed etc etc | 13:45 |
| robcresswell | tsufiev: So early in the cycle its easier to write a few thousand lines of code and carry them along as we go | 13:45 |
| tsufiev | robcresswell, yes, makes sense. If all my patches were independent of the rest OpenStack, I could complete them before m-1 | 13:46 |
| * tsufiev sighs | 13:47 | |
| robcresswell | tsufiev: Heh. Luckily my main Networks contribution is being done in Neutron by a Cisco guy, so I can just rely on his patches locally :) | 13:48 |
| tsufiev | usually it's more like 'write some Horizon code, ask Glance/Nova/Keystone for something, wait for them to finish, try to integrate, repeat' | 13:48 |
| tsufiev | robcresswell, lucky you :) | 13:49 |
| *** yamamoto has joined #openstack-horizon | 13:50 | |
| *** mohankumar has joined #openstack-horizon | 13:54 | |
| *** e0ne_ has quit IRC | 13:55 | |
| *** e0ne has joined #openstack-horizon | 13:55 | |
| *** yamamoto has quit IRC | 13:57 | |
| *** yamamoto has joined #openstack-horizon | 13:57 | |
| *** kzaitsev_mb has quit IRC | 13:59 | |
| *** adelia has joined #openstack-horizon | 14:02 | |
| *** matt-borland has joined #openstack-horizon | 14:06 | |
| wdeclercq | robcresswell, once again about https://review.openstack.org/#/c/233709/12/doc/source/tutorials/plugin.rst - At the angular js part, is it possible I need to remove the .myplugin part of ".module('horizon.dashboard.identity.myplugin', [])" (line 314)? I have to say I don't really know AngularJS though. | 14:11 |
| *** Daisy has joined #openstack-horizon | 14:15 | |
| tsufiev | wdeclercq, this way you will redeclare module 'horizon.dashboard.identity' which most likely already exists | 14:16 |
| *** btully has joined #openstack-horizon | 14:16 | |
| tsufiev | notice second `[]` argument (it means that you're defining a module, not importing it) | 14:16 |
| *** adelia has quit IRC | 14:17 | |
| wdeclercq | tsufiev, ah that's what I kind of feared :( .. but then still I'm not seeing the data on my page if I leave the .myplugin part. Browser just says "Error: [ng:areq] Argument 'horizon.dashboard.identity.myPluginController' is not a function, got undefined" | 14:18 |
| *** adelia has joined #openstack-horizon | 14:18 | |
| *** zhenguo has joined #openstack-horizon | 14:19 | |
| tsufiev | wdeclercq, do you have a CR online? | 14:19 |
| *** neelashah has joined #openstack-horizon | 14:20 | |
| wdeclercq | tsufiev, a what? | 14:21 |
| *** peristeri has joined #openstack-horizon | 14:21 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Adding Magic Search codebase to Horizon https://review.openstack.org/245288 | 14:22 |
| *** amotoki_ has joined #openstack-horizon | 14:24 | |
| *** jpomeroy has joined #openstack-horizon | 14:24 | |
| *** Ctina has joined #openstack-horizon | 14:25 | |
| *** Ctina is now known as ctina | 14:25 | |
| *** Daisy has quit IRC | 14:27 | |
| *** Daisy has joined #openstack-horizon | 14:27 | |
| *** adelia has quit IRC | 14:28 | |
| *** aortega has quit IRC | 14:29 | |
| *** adelia has joined #openstack-horizon | 14:29 | |
| *** adelia has quit IRC | 14:30 | |
| *** adelia has joined #openstack-horizon | 14:30 | |
| *** btully has quit IRC | 14:32 | |
| *** btully has joined #openstack-horizon | 14:32 | |
| *** mounica has joined #openstack-horizon | 14:35 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 14:35 |
| *** Piet has quit IRC | 14:36 | |
| tsufiev | wdeclercq, is your code available somewhere online so others may take a look? | 14:37 |
| wdeclercq | ahh, no I'm just following this tutorial/guide locally https://review.openstack.org/#/c/233709/12/doc/source/tutorials/plugin.rst | 14:37 |
| *** amotoki has quit IRC | 14:38 | |
| wdeclercq | tsufiev: ^^ | 14:38 |
| *** Daisy has quit IRC | 14:41 | |
| openstackgerrit | Merged openstack/horizon: Improve release notes guidance - single patch https://review.openstack.org/251501 | 14:41 |
| *** Daisy has joined #openstack-horizon | 14:41 | |
| *** adelia has quit IRC | 14:42 | |
| *** adelia has joined #openstack-horizon | 14:42 | |
| tsufiev | wdeclercq, it seems like myplugin.js file wasn't loaded at myplugin.html | 14:43 |
| tsufiev | if auto loading of js file doesn't work, try loading it manually (via <script> tag) | 14:43 |
| wdeclercq | I have tried putting an alert under the 'use strict' and that one shows, so I'm assuming it's auto loading. | 14:44 |
| tsufiev | wdeclercq, btw, should it really be 'Angular' and not 'angular' on line 313? | 14:45 |
| wdeclercq | It's lowercase, I've already posted a review comment on that on the patch. | 14:46 |
| *** tqtran has joined #openstack-horizon | 14:46 | |
| wdeclercq | is that module dependant on the panel name maybe, because I changed that actually.. | 14:47 |
| tsufiev | wdeclercq, if you place alert into myPluginController, does it fire? | 14:47 |
| *** adelia has quit IRC | 14:47 | |
| *** mtanino has joined #openstack-horizon | 14:50 | |
| wdeclercq | tsufiev, nothing fires, no | 14:50 |
| *** jtriley has joined #openstack-horizon | 14:50 | |
| *** ducttape_ has joined #openstack-horizon | 14:50 | |
| *** btully has quit IRC | 14:51 | |
| tsufiev | wdeclercq, sorry, I'm out of ideas here - it seems that the module you're trying isn't injected to the main angular app, perhaps there is some bug in plugin system, or tqtran forgot to mention something in the doc | 14:52 |
| tsufiev | you'd better try asking him, he usually appears here in ~3 hours | 14:53 |
| wdeclercq | tsufiev, Okay i'll do that when I think of it at home :) Thanks for the help though. | 14:53 |
| *** petertr7_away is now known as petertr7 | 14:53 | |
| *** btully has joined #openstack-horizon | 14:54 | |
| *** tqtran has quit IRC | 14:57 | |
| *** SurajD has quit IRC | 14:57 | |
| *** tqtran has joined #openstack-horizon | 14:57 | |
| *** absubram has joined #openstack-horizon | 14:59 | |
| *** Daisy has quit IRC | 14:59 | |
| *** Daisy has joined #openstack-horizon | 14:59 | |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding NGProjects Create Action - Members https://review.openstack.org/245340 | 15:00 |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Identity NGProjects Panel https://review.openstack.org/199139 | 15:00 |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Identity NGProjects Create Action - Details https://review.openstack.org/215352 | 15:00 |
| *** SurajD has joined #openstack-horizon | 15:00 | |
| *** amotoki_ is now known as amotoki | 15:01 | |
| tqtran | wdeclercq tsufiev: hello, what did i miss? | 15:02 |
| tqtran | better question, what are you trying to do and what is the problem? | 15:02 |
| wdeclercq | tqtran, I've been following https://review.openstack.org/#/c/233709/12/doc/source/tutorials/plugin.rst but in the end the testpage does't dispaly the dummy data that the angular controller should be providing. | 15:03 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Add unit tests for load-edit directive https://review.openstack.org/237788 | 15:03 |
| *** Daisy has quit IRC | 15:03 | |
| *** Daisy has joined #openstack-horizon | 15:04 | |
| tqtran | ah thank you for taking the time to read and test it out | 15:04 |
| *** yamamoto_ has joined #openstack-horizon | 15:04 | |
| *** zhenguo has quit IRC | 15:05 | |
| *** yamamoto has quit IRC | 15:05 | |
| tqtran | if you inspect the browser, do you see the myplugin.module.js (or myplugin.js) file? | 15:05 |
| tqtran | make sure you have DEBUG = True in your local_settings.py so the files aren't compressed | 15:06 |
| *** Daisy has quit IRC | 15:06 | |
| wdeclercq | tqtran, I have debug set to true, but i'm only seeing compressed files.. (btw i'm using liberty) - but I can add an alert into the myplugin.module.js file and that alert is triggering, so it's loaded somewhere.. | 15:08 |
| tqtran | are you using the apache port 8000? or the django test server port 9000? | 15:09 |
| wdeclercq | oh, I chose "runserver 0.0.0.0:8010" | 15:09 |
| tqtran | ok that is fine. restart the server and clear browser cache. | 15:10 |
| tqtran | is it still compressed? | 15:10 |
| wdeclercq | yes :( | 15:11 |
| *** Drago has joined #openstack-horizon | 15:11 | |
| matt-borland | tqtran, I moved the file-reader service into horizon in the otherwise test-patch: https://review.openstack.org/#/c/237788/ as you suggested | 15:15 |
| matt-borland | also bumped up the code coverage a bit | 15:15 |
| tqtran | matt-borland: cool, i'll take a look at it and the glance api today | 15:15 |
| matt-borland | thanks! | 15:15 |
| *** btully has quit IRC | 15:15 | |
| *** btully has joined #openstack-horizon | 15:18 | |
| pkarikh | jpomero: hi! Thanks for API filtering patch. :) But why did you stopped working on it? Is there some issues? | 15:22 |
| jpomeroy | pkarikh, hey no problem | 15:24 |
| jpomeroy | when work started on the angular Users panel I decided to let it get fixed there | 15:24 |
| *** mohankumar has quit IRC | 15:27 | |
| tsufiev | pkarikh, that we means that we should start thinking as well about implementing our approach for angular panels | 15:27 |
| tsufiev | pkarikh, looks to me like a perfect entry point into Angular Horizon | 15:27 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Add pagination to volume snapshots and backups pages https://review.openstack.org/251427 | 15:27 |
| pkarikh | tsufiev, yep, exactly | 15:28 |
| pkarikh | jpomeroy: ok, got it | 15:28 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Add pagination support to the volume page https://review.openstack.org/118450 | 15:29 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Add pagination to volume snapshots and backups pages https://review.openstack.org/251427 | 15:29 |
| *** e0ne has quit IRC | 15:29 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Add pagination to volume snapshots and backups pages https://review.openstack.org/251427 | 15:30 |
| robcresswell | wdeclercq: COMPRESS_ENABLED = False in local_settings | 15:31 |
| wdeclercq | tqtran, robcresswell: Okay, now I see the myplugin.module.js file in the browser resources. | 15:32 |
| tqtran | great! let me review the plugin instructions and see what you can do to debug | 15:33 |
| tqtran | does your html reference the controller? <div ng-controller="horizon.dashboard.identity.myPluginController as ctrl"> | 15:34 |
| wdeclercq | yes | 15:35 |
| *** belmoreira has quit IRC | 15:35 | |
| *** hurgleburgler has joined #openstack-horizon | 15:35 | |
| tqtran | ok try something simple, add a ctrl.color = 'red' in your controller and add it your html <span>{$ ctrl.color $}</span> somewhere and see if it gets evaluated | 15:36 |
| tqtran | if it does, then the reference to your controller is working, otherwise, it is not able to locate it | 15:37 |
| *** btully has quit IRC | 15:37 | |
| wdeclercq | I'll try it, but now it already says Error: [ng:areq] Argument 'horizon.dashboard.identity.myPluginController' is not a function, got undefined, So I assume it can't locate it | 15:37 |
| tqtran | ok so that is most likely the issue | 15:39 |
| robcresswell | wdeclercq: Easiest thing is probably to throw your controller definition in http://paste.openstack.org/ so we cna take a look | 15:40 |
| robcresswell | can* | 15:40 |
| tqtran | try clearing your browser's cache and see if i works | 15:40 |
| tqtran | robcresswell: great idea! lol | 15:41 |
| robcresswell | :) | 15:41 |
| *** btully has joined #openstack-horizon | 15:42 | |
| *** tyagiprince has joined #openstack-horizon | 15:44 | |
| robcresswell | tqtran: How's the user create action going? | 15:45 |
| tqtran | theres a few nits there that i need to address, but i wanted more cores to look at it before i make changes | 15:46 |
| *** tyagiprince has quit IRC | 15:46 | |
| robcresswell | Oh good. Nits. | 15:46 |
| *** e0ne has joined #openstack-horizon | 15:47 | |
| tqtran | esp the issue that you're seeing with the dropdown, when will you have time to look into it? i can help you debug it if needed, might be faster | 15:47 |
| tqtran | ops, sorry dan, didnt mean to ping you haha | 15:47 |
| matt-borland | lol | 15:47 |
| robcresswell | tqtran: The Member/ _member_ issue? | 15:47 |
| tqtran | at this rate, i think rajat's create patch will land before mine | 15:48 |
| tqtran | yes | 15:48 |
| robcresswell | Oh yeah, I have't had time yet :( | 15:48 |
| *** piet has joined #openstack-horizon | 15:48 | |
| *** tyagiprince has joined #openstack-horizon | 15:49 | |
| *** aix has quit IRC | 15:49 | |
| robcresswell | tqtran, matt-borland: What I was trying to work out was, whether create-net needs ot be rebased on an ongoing patch | 15:49 |
| *** david_cu has joined #openstack-horizon | 15:49 | |
| matt-borland | I don't think so, robcresswell | 15:50 |
| robcresswell | Awesome. Full speed ahead then. | 15:50 |
| matt-borland | if you have new APIs, might want to break them out | 15:50 |
| tqtran | mine needs to be rebase on top of richards, he submitted a fix tot he double click issue you raised up | 15:50 |
| matt-borland | yep! | 15:50 |
| robcresswell | Yeah, will do | 15:50 |
| matt-borland | thanks robcresswell ! | 15:50 |
| *** aortega has joined #openstack-horizon | 15:53 | |
| robcresswell | matt-borland: So openstack_dashboard/static/app/core/images vs openstack_dashboard/dashboards/project/static/dashboard/project/images/ | 15:54 |
| robcresswell | was the latter just some leftover code from before? | 15:54 |
| matt-borland | hm | 15:54 |
| matt-borland | lemme see | 15:55 |
| *** adelia has joined #openstack-horizon | 15:55 | |
| matt-borland | isn't one just the static output? | 15:55 |
| matt-borland | openstack_dashboard/dashboards/project/static/dashboard/project/images/ is the real deal | 15:55 |
| robcresswell | I don't know, just looking around code | 15:56 |
| robcresswell | https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/images.module.js | 15:56 |
| *** vijendar has joined #openstack-horizon | 15:56 | |
| robcresswell | https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/static/dashboard/project/images/images.module.js | 15:56 |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Make some volume related quotas translatable https://review.openstack.org/251934 | 15:57 |
| *** btully has quit IRC | 15:57 | |
| *** bpokorny has joined #openstack-horizon | 15:57 | |
| tqtran | basically, the things that are shared are placed into core while the things that are specific to that dashboard go into dashboard | 15:58 |
| tqtran | we have images in dashboard for obvious reasons, and some of the are in core so it can be use in both project and admin dashboard | 15:58 |
| *** Drago has quit IRC | 16:00 | |
| *** Drago has joined #openstack-horizon | 16:02 | |
| *** petertr7 is now known as petertr7_away | 16:02 | |
| robcresswell | tqtran: Doesn't that make project/images sort of null and void? | 16:02 |
| *** bpokorny has quit IRC | 16:02 | |
| robcresswell | As in, all code will always be in core, at least for project, perhaps some extra for admin? | 16:02 |
| *** btully has joined #openstack-horizon | 16:03 | |
| tqtran | not quite | 16:03 |
| TravT | tqtran: robcresswell: can you look at images API patch. | 16:04 |
| TravT | https://review.openstack.org/#/c/236832/ | 16:04 |
| *** rcernin has quit IRC | 16:04 | |
| tqtran | robcresswell: yes, most of the logic should be in core and not project/dashboard. will have to take another pass at the files to make sure they aren't stale | 16:07 |
| wdeclercq | tqtran: http://paste.openstack.org/show/480525/ Took a while. Note that I had changed "myplugin" into nuage_horizon everywhere, as you can also see in the tree. But I think there should be no difference apart from that name. http://paste.openstack.org/show/480525/ | 16:07 |
| *** SimonChung1 has quit IRC | 16:07 | |
| *** tmazur has quit IRC | 16:08 | |
| tqtran | wdeclercq: your problem is line 49 | 16:09 |
| tqtran | your module and controller names are the same | 16:09 |
| tqtran | the module should be something like horizon.dashboard.nuage | 16:10 |
| tqtran | sorry horizon.dashboard.identity | 16:10 |
| tqtran | actually usage is under what? | 16:10 |
| *** kzaitsev_ws has quit IRC | 16:11 | |
| tqtran | for the purpose of the demo, using horizon.dashboard.myplugin should also work | 16:11 |
| *** tsufiev has quit IRC | 16:11 | |
| *** katyafervent has quit IRC | 16:11 | |
| tqtran | just make sure you arent clashing with existing module namespace | 16:11 |
| *** pkarikh has quit IRC | 16:12 | |
| tqtran | unless your plugin wants to reuse an existing module, then in that case, just angular.module('existingmodule) without the , []) at the end | 16:12 |
| *** kzaitsev_ws has joined #openstack-horizon | 16:13 | |
| *** petertr7_away is now known as petertr7 | 16:13 | |
| tqtran | let me know if that make sense, if not i can try to re-explain using better wording | 16:13 |
| wdeclercq | I had tried .module('horizon.dashboard.identity', []) before and can confirm that will work. But then the tutorial is incorrect there? | 16:15 |
| wdeclercq | it was also said here that "wdeclercq, this way you will redeclare module 'horizon.dashboard.identity' which most likely already exists" | 16:15 |
| wdeclercq | tqtran: ^^ | 16:15 |
| tqtran | tutorial suggests to use horizon.dashboard.identity.myplugin namespace | 16:15 |
| tqtran | horizon.dashboard.identity is an existing module. you shouldn't use that | 16:16 |
| robcresswell | TravT: Looking now | 16:16 |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon: Inline editing for LBaaS tables https://review.openstack.org/242100 | 16:17 |
| *** btully has quit IRC | 16:17 | |
| tqtran | the subtle difference is the .myplugin at the end | 16:17 |
| wdeclercq | So if I change it into "angular.module('xx.identity.nuage_horizon', []) .controller('hxx.identity.nuage_horizonController', nuage_horizonController);". What's the mistake there then? | 16:18 |
| wdeclercq | assuming I changed the html file to use the different controller name | 16:19 |
| tqtran | there is no mistake in that at all, you can do that if you wanted to | 16:21 |
| tqtran | we're merely suggesting that you namespace your plugin logically | 16:21 |
| tqtran | so if you plugin is for the identity dashboard, then horizon.dashboard.identity.myplugin will be good | 16:22 |
| robcresswell | matt-borland: I'm not going to block on this, because I want things moving, but why list the ID in one error message (delete) but not another (update)? https://review.openstack.org/#/c/236832/28/openstack_dashboard/static/app/core/openstack-service-api/glance.service.js | 16:22 |
| *** TravT has quit IRC | 16:22 | |
| *** masco has joined #openstack-horizon | 16:22 | |
| tqtran | or if you plugin is for a panel, then horizon.dashboard.identity.users.myplugin will suffice | 16:22 |
| matt-borland | robcresswell, I'll have to look in a minute...busy | 16:22 |
| robcresswell | matt-borland: Sure thing boss | 16:22 |
| tqtran | wdeclercq: but its your plugin, you have total control over it. you can choose to name it whatever you want. we cant enforce it | 16:23 |
| *** deray has joined #openstack-horizon | 16:24 | |
| *** TravT has joined #openstack-horizon | 16:25 | |
| *** btully has joined #openstack-horizon | 16:26 | |
| *** petertr7 is now known as petertr7_away | 16:26 | |
| *** katyafervent has joined #openstack-horizon | 16:26 | |
| *** SurajD has quit IRC | 16:26 | |
| *** tsufiev has joined #openstack-horizon | 16:27 | |
| *** deray_ has joined #openstack-horizon | 16:27 | |
| *** pkarikh has joined #openstack-horizon | 16:28 | |
| *** SurajD has joined #openstack-horizon | 16:28 | |
| *** yamamoto_ has quit IRC | 16:28 | |
| *** deray_ has quit IRC | 16:28 | |
| *** petertr7_away is now known as petertr7 | 16:29 | |
| *** deray_ has joined #openstack-horizon | 16:29 | |
| *** Drago has quit IRC | 16:31 | |
| *** deray has quit IRC | 16:31 | |
| piet | Here is an updated link for the Nova Networks/Neutron Migration results presentation at 10AM MST / 12PM EST / 5:00PM UTC: https://bluejeans.com/3602129738 | 16:31 |
| tqtran | matt-borland, TravT: if request.DATA.get('import_data') in https://review.openstack.org/#/c/236832/28/openstack_dashboard/api/rest/glance.py | 16:33 |
| *** Drago has joined #openstack-horizon | 16:33 | |
| *** ongk has joined #openstack-horizon | 16:33 | |
| tqtran | isn't it possible to specify import_data as false? and have it go through? | 16:33 |
| matt-borland | yes | 16:34 |
| matt-borland | it's basically saying, | 16:34 |
| tqtran | or do we not care and assume that if you pass something in (even false), we assume it is true | 16:34 |
| matt-borland | "do I load the data from this location, or just reference the location?" I beleive. | 16:34 |
| matt-borland | so I believe it is implemented properly. | 16:35 |
| tqtran | when i send data to this api, are booleans from JS converted to python? or are they still in string? | 16:35 |
| matt-borland | import_data is not passed on | 16:36 |
| tqtran | if they are still in string, then 'false' will evaluate to True | 16:36 |
| *** lblanchard has joined #openstack-horizon | 16:36 | |
| matt-borland | only the meta object is passed on | 16:36 |
| matt-borland | import_data is not copied to that object | 16:36 |
| tqtran | right i understand that part | 16:37 |
| matt-borland | ok | 16:37 |
| tqtran | basically, my question is, when we are sending data as JSON from JS to server, i am assuming they are all in string format | 16:37 |
| tqtran | so if you do request.DATA.get('import_data') you will be a string back | 16:37 |
| tqtran | which will always evaluate to True | 16:38 |
| tqtran | unless i am mistaken :P | 16:38 |
| matt-borland | well, let's take a closer look | 16:38 |
| *** btully has quit IRC | 16:39 | |
| *** btully has joined #openstack-horizon | 16:42 | |
| openstackgerrit | Richard Hagarty proposed openstack/horizon: Use "GiB" and "gibibyte" labels in volume panels https://review.openstack.org/243880 | 16:46 |
| *** tjones has joined #openstack-horizon | 16:47 | |
| *** vishwanathj has joined #openstack-horizon | 16:47 | |
| *** masco has quit IRC | 16:48 | |
| matt-borland | tqtran, ok, I'm going to test the functionality. I think if use the raw token of true/false, there's no problem, but I'll check. | 16:50 |
| *** rajatvig has joined #openstack-horizon | 16:50 | |
| tqtran | ok great :) | 16:50 |
| openstackgerrit | Justin Pomeroy proposed openstack/horizon: Pass result of submit to wizard modal close https://review.openstack.org/251967 | 16:52 |
| TravT | tqtran: I saw that as well and remember trying it out, but it still behaved as desired. | 16:52 |
| *** tyagiprince1 has joined #openstack-horizon | 16:53 | |
| matt-borland | tqtran, I believe the python tests demonstrate that given bare tokens, it works. | 16:53 |
| tqtran | right, for bare it works for sure | 16:53 |
| TravT | but, perhaps i didn't try out sending false through. | 16:53 |
| tqtran | but for 'false' will it? | 16:53 |
| matt-borland | that's what I mean. | 16:53 |
| *** tyagiprince has quit IRC | 16:54 | |
| *** tyagiprince1 is now known as tyagiprince | 16:54 | |
| matt-borland | I don't think we should handle "false" as false. | 16:54 |
| tqtran | from the JS side, it says boolean, and im guessing it has to be stringify before it gets sent, so the boolean is probably wrap in a string? not sure..... | 16:54 |
| matt-borland | that opens up the door to all sorts of things, doesn't it? | 16:54 |
| hurgleburgler | yeah | 16:54 |
| tqtran | matt-borland: then that would mean we have to omit fields to indicate false for everything, which might be less than ideal :/ whats the normal behavior when you're using the client? | 16:55 |
| matt-borland | tqtran | 16:55 |
| *** amotoki has quit IRC | 16:55 | |
| matt-borland | JSON.stringify({a: true}) -> '{"a": true}' | 16:56 |
| matt-borland | it doesn't wrap tokens in quotes. | 16:56 |
| matt-borland | I think the current behavior is exactly what we want. | 16:56 |
| *** kzaitsev_mb has joined #openstack-horizon | 16:57 | |
| matt-borland | if we're putting quotes around true/false that is a problem | 16:57 |
| tqtran | interesting, so python will auto convert true to True? | 16:57 |
| matt-borland | yes. | 16:57 |
| rajatvig | I don't think so | 16:57 |
| *** petertr7 is now known as petertr7_away | 16:58 | |
| matt-borland | look at how it handles .protected. | 16:58 |
| *** petertr7_away is now known as petertr7 | 16:58 | |
| matt-borland | we just pass that value on. true -> True, false -> False | 16:58 |
| rajatvig | actually maybe. request body will parsed by Django with JSON. Parameters on URL's won't be. that's the norm typically. | 16:59 |
| matt-borland | Yeah | 17:00 |
| tqtran | ok, worth bringing up, thanks for the enlightenment | 17:00 |
| matt-borland | if you test the functionality, it works. | 17:00 |
| matt-borland | get out a REST client | 17:00 |
| robcresswell | Out of curiosity, why were the API patches separate from their respective actions? | 17:00 |
| matt-borland | see how .protected is maintained | 17:00 |
| matt-borland | OMG robcresswell | 17:00 |
| robcresswell | hahaaa | 17:00 |
| *** btully has quit IRC | 17:01 | |
| matt-borland | it's amazing how you can give people heart attacks from thousands of miles away | 17:01 |
| robcresswell | tqtran: Did we agree your -1 doesnt matter? | 17:01 |
| robcresswell | Cause I'm ready to approve it. APIs are a little annoying and we can solve the bugs as we go. | 17:01 |
| *** btully has joined #openstack-horizon | 17:02 | |
| robcresswell | matt-borland: Oops, sorry Matt :p | 17:02 |
| matt-borland | :) | 17:02 |
| tqtran | taking a last look, one sec | 17:02 |
| robcresswell | Sure, no rush | 17:03 |
| matt-borland | thanks guys! I appreciate you taking the time. | 17:03 |
| tqtran | so last question | 17:04 |
| * robcresswell worries for matt-borlands blood pressure | 17:04 | |
| tqtran | we already have a create_image_metadata, why the code duplication? | 17:04 |
| *** mrunge has quit IRC | 17:07 | |
| *** rdopiera has quit IRC | 17:07 | |
| *** lapalm has joined #openstack-horizon | 17:09 | |
| *** mohankumar has joined #openstack-horizon | 17:10 | |
| *** mrunge has joined #openstack-horizon | 17:10 | |
| rajatvig | tqtran: the code in there is different. it accounts for glance API version differences and does it differently | 17:11 |
| *** btully has quit IRC | 17:13 | |
| *** nlahouti has joined #openstack-horizon | 17:14 | |
| *** gyee has joined #openstack-horizon | 17:14 | |
| *** SurajD has quit IRC | 17:15 | |
| robcresswell | Thats a funny one. The first 1/2 of the function is straight copy/paste | 17:15 |
| *** tyagiprince has quit IRC | 17:15 | |
| *** nlahouti has quit IRC | 17:15 | |
| *** btully has joined #openstack-horizon | 17:16 | |
| *** SurajD has joined #openstack-horizon | 17:16 | |
| rajatvig | quite true. | 17:17 |
| *** ZZelle has joined #openstack-horizon | 17:17 | |
| *** lhcheng_ has joined #openstack-horizon | 17:17 | |
| robcresswell | rajatvig: What was the reasoning with the new function? | 17:20 |
| *** lhcheng has quit IRC | 17:20 | |
| *** SimonChung has joined #openstack-horizon | 17:21 | |
| *** wdeclercq has left #openstack-horizon | 17:21 | |
| rajatvig | what it does later is different so the copy. wanted to avoid regression on code that exists | 17:23 |
| openstackgerrit | Richard Hagarty proposed openstack/horizon: Use "GiB" and "gibibyte" labels in volume panels https://review.openstack.org/243880 | 17:23 |
| *** doug-fish has joined #openstack-horizon | 17:25 | |
| *** stevemar_znc is now known as stevemar | 17:25 | |
| matt-borland | ah, robcresswell I am responsible for the create_image_metadata method... | 17:26 |
| matt-borland | sorry, thought you were talking about some sort of new method | 17:26 |
| robcresswell | Just chasing up tqtran comment so we can move this on while people are here. | 17:27 |
| matt-borland | yeah, so, this function is specific to handling all the metadata for these methods. | 17:27 |
| *** nlahouti has joined #openstack-horizon | 17:28 | |
| *** btully has quit IRC | 17:28 | |
| *** ygbo has quit IRC | 17:28 | |
| matt-borland | acutally, I didn't write this function, sorry. but either way it's specific to how we handle data specific to these methods. | 17:28 |
| matt-borland | e.g. 'visibility', unknown properties, etc. | 17:29 |
| robcresswell | Sure, just wondering why we can't reuse the blocks of code | 17:29 |
| *** lhcheng_ has quit IRC | 17:29 | |
| matt-borland | that is not necessarily in-line with how the forms pass this data. | 17:29 |
| matt-borland | lemme see if there are opportunities or risks. | 17:29 |
| *** lhcheng has joined #openstack-horizon | 17:29 | |
| *** e0ne has quit IRC | 17:30 | |
| robcresswell | Also there are things like .get('min_disk') or 0, why not just use .get('min_disk', 0) ? | 17:30 |
| matt-borland | same in forms.py | 17:31 |
| matt-borland | anywa, | 17:31 |
| matt-borland | *anyway, | 17:31 |
| rajatvig | matt-borland: you're right. it's the form fields are quite different in the angular form vs the django form. | 17:31 |
| *** btully has joined #openstack-horizon | 17:31 | |
| matt-borland | this doesn't conform to the same expectations | 17:31 |
| matt-borland | for example, | 17:31 |
| *** petertr7 is now known as petertr7_away | 17:31 | |
| matt-borland | we handle visibility/is_public differently because it's more in line with what Glance now does in its API | 17:32 |
| matt-borland | also, | 17:32 |
| matt-borland | there is a different premise (again, looking forward to new Glance features) | 17:32 |
| matt-borland | about how the metadata is presented | 17:32 |
| matt-borland | you could shoe-horn the glance.py to use the forms.py | 17:33 |
| matt-borland | but you'd have to undo much of the logic right away | 17:33 |
| matt-borland | which seems really convoluted. | 17:33 |
| matt-borland | this is simple. | 17:33 |
| matt-borland | it's not cut-and-paste from one to the other | 17:33 |
| matt-borland | it's different functionality, structured similarly. | 17:34 |
| robcresswell | I meant along the lines of; why not break out the literal copy -paste part into a function and just call that | 17:35 |
| robcresswell | the Amazon image types handling is identical | 17:35 |
| matt-borland | there is no real cut/paste part | 17:35 |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding NGProjects Create Action - Members https://review.openstack.org/245340 | 17:35 |
| matt-borland | properties is handled differently | 17:35 |
| matt-borland | is_public is handled differently | 17:35 |
| matt-borland | description and architecture are overkill | 17:36 |
| matt-borland | either way, it's just more convoluted | 17:36 |
| robcresswell | handle_disk_container_format looks the same as the forms.py part | 17:36 |
| robcresswell | Interestingly, I'm surprised the min_ram/ min_disk part in forms.py doesnt throw KeyErrors but, thats beside the point | 17:36 |
| matt-borland | to be clear, | 17:37 |
| openstackgerrit | Merged openstack/horizon: Networks tab does not show external configuration https://review.openstack.org/249173 | 17:37 |
| matt-borland | what you're saying is that the disk format code should be broken out and shared by both. But what dependency> | 17:37 |
| matt-borland | I wouldn't want the glance api to be dependent on a form. | 17:37 |
| *** kzaitsev_mb has quit IRC | 17:38 | |
| *** mpavlase has quit IRC | 17:38 | |
| matt-borland | that just sounds like a bad dependency. | 17:38 |
| robcresswell | Egh this is true, and the form shouldnt depend on the rest api. Would need to be a separate location. | 17:38 |
| tsufiev | anyone noticed something strange with py34 job recently? | 17:38 |
| *** kzaitsev_mb has joined #openstack-horizon | 17:38 | |
| tqtran | what about moving that code to the api and import it in the form? | 17:38 |
| matt-borland | yeah, it's a pickle robcresswell | 17:38 |
| tsufiev | I'm trying to understand the failure here https://review.openstack.org/#/c/230238/ but locally py34 fails with a different issue :) | 17:39 |
| robcresswell | Well, no, it just needs to be a different location. Like thai's suggestion. | 17:39 |
| *** deray_ has quit IRC | 17:39 | |
| matt-borland | OK, I'm not really sure where a good shared logic location is. | 17:39 |
| tqtran | matt-borland: it make sense the way you have it right now. just import it in the form instead? | 17:40 |
| *** saksham has joined #openstack-horizon | 17:40 | |
| matt-borland | should the form depend on the api code? | 17:40 |
| robcresswell | tqtran: Then you've got the form depending on the rest api | 17:40 |
| robcresswell | which seems a little odd. | 17:40 |
| rajatvig | tqtran: the form doesn't pass in the same form parameters | 17:40 |
| tqtran | ok lets back track a bit | 17:41 |
| tqtran | why are we even using that code to begin with? | 17:41 |
| tqtran | you have angular forms, massage the data there | 17:41 |
| tqtran | then send it and just let it pass through | 17:41 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Add pagination to Heat Stacks Details: Events https://review.openstack.org/230238 | 17:41 |
| tqtran | im not entirely sure why we even muck with the old form code to begin with | 17:42 |
| *** itxaka has quit IRC | 17:42 | |
| matt-borland | TravT, any thoughts on this (since he looked at this deeply)? | 17:42 |
| tqtran | most of it is already passthrough | 17:42 |
| TravT | i'll have to read back. | 17:42 |
| matt-borland | quite so, yeah. | 17:42 |
| tqtran | there are a few exceptions, just handle it front end | 17:42 |
| TravT | but the check for import_data is wrong. | 17:43 |
| tqtran | then you dont have to deal with this messy issue altogether | 17:43 |
| matt-borland | TravT, we settled the check for import_data | 17:43 |
| matt-borland | it will remain as is | 17:43 |
| rajatvig | some of the names of the form fields in the Angular code are different from what the Django form fields are named. | 17:43 |
| TravT | what was settled on import_data? | 17:43 |
| matt-borland | simply, that the true/false is OK. | 17:43 |
| robcresswell | TravT: It seemed that the current implementation was fine from discussion. I didnt test it myself. | 17:44 |
| matt-borland | there had been a question if someone sent "false" <string> | 17:44 |
| TravT | that is okay, from JS side is explicitly set. | 17:44 |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding tests for ng identity basePath constant https://review.openstack.org/221804 | 17:44 |
| matt-borland | yep | 17:44 |
| TravT | however, if you send in something like "foo_string" it will still evaluate to true | 17:44 |
| matt-borland | the question now is about the handle_disk_container function. | 17:44 |
| TravT | okay, let me read back on that part. | 17:44 |
| matt-borland | since some of it appears redundant with other code. | 17:45 |
| matt-borland | 1) leave it | 17:45 |
| matt-borland | 2) push that logic to the front-end | 17:45 |
| matt-borland | 3) have some other logic function that is shared between glance.py and ./openstack_dashboard/dashboards/project/images/images/forms.py | 17:45 |
| *** lhcheng_ has joined #openstack-horizon | 17:46 | |
| tqtran | i think it makes sense to use front-end logic. form validation is already done front-end. massing a few properties should be simple | 17:46 |
| tqtran | then you can just pass through on the api layer, much more elegant | 17:46 |
| tqtran | the only reason it was in forms.py to begin with was because legacy validation had to happen backend | 17:47 |
| tqtran | so for the purpose of this patch, just remove that part and assume client will pass in correct properties, and you're set | 17:47 |
| TravT | okay, here are two sides of that argument. | 17:49 |
| *** lhcheng has quit IRC | 17:49 | |
| TravT | server side: Pros: it is done once and closer to the source, meaning all users get the benefit. Cons: it is doing manipulation on the data that acts a bit as a firewall to the real API. | 17:50 |
| TravT | client side: you are changing things server side that should be reflected client side ideally. | 17:50 |
| TravT | if I select dis format of one of those, it would be nice to see the container format automatically change and be non-selectable | 17:51 |
| TravT | or something to that affect | 17:51 |
| *** kzaitsev_mb has quit IRC | 17:51 | |
| TravT | so, i do wonder the reasoning of why it wasn't done client side for that particular function | 17:51 |
| * TravT needs to read above | 17:51 | |
| matt-borland | I think the code was just all modeled somewhat on what had been done before. | 17:52 |
| robcresswell | :/ | 17:54 |
| robcresswell | At the very least, I dislike the code duplication. It means updating it in two places if anything changes. | 17:55 |
| TravT | if it is server side, then i agree it would make sense to put that function api/glance.py (not api/rest/glance.py) and then call it from both places. | 17:55 |
| TravT | so delete it here: https://github.com/openstack/horizon/blob/3d9969b31cb95b3b47c961e65e16e6d2929f5ab3/openstack_dashboard/dashboards/project/images/images/forms.py#L43-L61 | 17:55 |
| TravT | and call it | 17:55 |
| robcresswell | Agreed, TravT | 17:55 |
| matt-borland | hold on | 17:59 |
| matt-borland | sorry, was in a meeting | 17:59 |
| TravT | rajatvig: matt-borland: is the client side doing the same thing anyway to reflect this selection? | 17:59 |
| matt-borland | it isn't but I agree that it probably should | 18:00 |
| TravT | if so, then don't do it server side as Thai suggested | 18:00 |
| matt-borland | yeah | 18:00 |
| matt-borland | I'm leaning that way | 18:00 |
| matt-borland | just make those 2 fields pass through | 18:00 |
| TravT | because otherwise, i could select disk format of AMI and still select something else in container format and it will get wiped out | 18:00 |
| matt-borland | plus, you could have been client-side reflection of the selection, as I think you said. | 18:01 |
| matt-borland | so, more code on the subsequent patches, | 18:01 |
| matt-borland | but take out the logic here. | 18:01 |
| matt-borland | does that sound like a +2-able plan? | 18:01 |
| TravT | and it would make for a better user experience I think. | 18:01 |
| matt-borland | I think so | 18:01 |
| matt-borland | it's more inline with the notion of a REST interface | 18:01 |
| TravT | yeah, i think so | 18:02 |
| matt-borland | I mean, I assume that glance has any real heavy-duty consistency checking on its side | 18:02 |
| matt-borland | if required. | 18:02 |
| tqtran | matt-borland: yes that sounds good to me | 18:03 |
| TravT | you can assume glance will throw errors based on some validation checking it does and that the validation checking it does will likely change over time. | 18:03 |
| matt-borland | tqtran, robcresswell ...does that sounds good...to do as Thai suggests with the disk_format and container_name? | 18:03 |
| tqtran | i would be comfortable with +2 ing that | 18:03 |
| matt-borland | cool | 18:03 |
| *** SimonChung has quit IRC | 18:03 | |
| *** SimonChung1 has joined #openstack-horizon | 18:03 | |
| matt-borland | I will get right on that! Thanks for the in-depth discussion, guys! | 18:03 |
| matt-borland | this helps me think about how we do future APIs as well | 18:03 |
| tqtran | np, thanks for taking in the input | 18:03 |
| *** SimonChung1 has quit IRC | 18:05 | |
| *** SimonChung has joined #openstack-horizon | 18:05 | |
| robcresswell | matt-borland: Generally speaking they should be as light as possible, just handling oddities in data types etc. Like in Neutron, some of it doesn't play well with django templating. | 18:07 |
| matt-borland | exactly robcresswell | 18:07 |
| matt-borland | we do have to do a few antics to relate the glance v1/v2 dissimilarities | 18:08 |
| matt-borland | but otherwise, it should just pass thru | 18:08 |
| *** sambetts is now known as sambetts-afk | 18:08 | |
| *** lhcheng_ is now known as lhcheng | 18:12 | |
| *** neelashah has quit IRC | 18:13 | |
| *** SimonChung1 has joined #openstack-horizon | 18:18 | |
| *** SimonChung has quit IRC | 18:18 | |
| *** SimonChung has joined #openstack-horizon | 18:19 | |
| *** SimonChung1 has quit IRC | 18:19 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Add API to Create/Update/Delete Images in Glance https://review.openstack.org/236832 | 18:21 |
| *** dshaw has joined #openstack-horizon | 18:22 | |
| *** vishwana_ has joined #openstack-horizon | 18:22 | |
| *** vishwanathj has quit IRC | 18:24 | |
| matt-borland | robcresswell, tqtran, TravT...updated that API patch. Please check the diffs to see if that is what makes sense. | 18:24 |
| *** neelashah has joined #openstack-horizon | 18:28 | |
| *** SurajD has quit IRC | 18:28 | |
| *** SimonChung has quit IRC | 18:28 | |
| *** SimonChung1 has joined #openstack-horizon | 18:28 | |
| *** kzaitsev_mb has joined #openstack-horizon | 18:30 | |
| *** tqtran has quit IRC | 18:30 | |
| *** SurajD has joined #openstack-horizon | 18:31 | |
| *** tqtran has joined #openstack-horizon | 18:31 | |
| *** mohankumar has quit IRC | 18:33 | |
| *** mohankumar has joined #openstack-horizon | 18:35 | |
| *** jbell8 has joined #openstack-horizon | 18:35 | |
| *** vishwana_ has quit IRC | 18:37 | |
| *** rcernin has joined #openstack-horizon | 18:38 | |
| *** Qingqing has joined #openstack-horizon | 18:38 | |
| *** saksham has quit IRC | 18:39 | |
| *** Qingqing has quit IRC | 18:39 | |
| *** jingjing_ren has joined #openstack-horizon | 18:39 | |
| *** petertr7_away is now known as petertr7 | 18:40 | |
| *** vishwanathj has joined #openstack-horizon | 18:40 | |
| *** chestack has quit IRC | 18:43 | |
| *** neelashah1 has joined #openstack-horizon | 18:43 | |
| *** nlahouti has quit IRC | 18:44 | |
| *** neelashah has quit IRC | 18:45 | |
| *** chestack has joined #openstack-horizon | 18:45 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: WIP Angular Table Header Directive https://review.openstack.org/252014 | 18:47 |
| *** tosky has quit IRC | 18:47 | |
| *** mpavlase has joined #openstack-horizon | 18:58 | |
| *** nlahouti has joined #openstack-horizon | 19:00 | |
| *** gyee has quit IRC | 19:02 | |
| *** mohankumar has quit IRC | 19:02 | |
| *** kzaitsev_mb has quit IRC | 19:02 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add unit tests for load-edit directive https://review.openstack.org/237788 | 19:04 |
| *** neelashah has joined #openstack-horizon | 19:05 | |
| *** neelashah1 has quit IRC | 19:06 | |
| *** jwy has joined #openstack-horizon | 19:07 | |
| *** saksham has joined #openstack-horizon | 19:07 | |
| *** vijendar has quit IRC | 19:08 | |
| *** aortega has quit IRC | 19:10 | |
| *** aortega has joined #openstack-horizon | 19:11 | |
| *** aortega_ has joined #openstack-horizon | 19:12 | |
| *** aortega has quit IRC | 19:16 | |
| *** neelashah1 has joined #openstack-horizon | 19:16 | |
| *** SimonChung has joined #openstack-horizon | 19:17 | |
| *** SimonChung2 has joined #openstack-horizon | 19:17 | |
| *** SimonChung1 has quit IRC | 19:17 | |
| *** SimonChung1 has joined #openstack-horizon | 19:17 | |
| *** SimonChung2 has quit IRC | 19:17 | |
| *** SimonChung has quit IRC | 19:18 | |
| *** neelashah has quit IRC | 19:18 | |
| *** john5223 is now known as zz_john5223 | 19:20 | |
| matt-borland | tqtran, I'll clean up those [] and .get() refs. | 19:20 |
| matt-borland | .get() is probably nicer because it can include defaults. | 19:20 |
| tqtran | ok cool | 19:21 |
| *** david_cu has quit IRC | 19:22 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add Action to delete multiple and single images to images panel https://review.openstack.org/217422 | 19:22 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add API services for angular Volumes panel https://review.openstack.org/233760 | 19:24 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: Add Create Volume Action for the Image https://review.openstack.org/229677 | 19:24 |
| *** david_cu has joined #openstack-horizon | 19:25 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Add API to Create/Update/Delete Images in Glance https://review.openstack.org/236832 | 19:27 |
| matt-borland | tqtran, TravT, robcresswell...see above ^^, made changes as requested. Cleaned up all [] and .get() to be consistent. | 19:30 |
| tqtran | looking now | 19:31 |
| matt-borland | thanks! | 19:32 |
| tqtran | matt-borland: question, do we need handle_unknown_properties | 19:35 |
| matt-borland | yep! | 19:35 |
| tqtran | if you pass in extra stuff, the glance api will barf? | 19:35 |
| matt-borland | it's how glance handles meta data | 19:35 |
| matt-borland | nope | 19:35 |
| matt-borland | it basically takes .unknown-thing | 19:35 |
| matt-borland | and places it in properties.unknown-thing | 19:35 |
| matt-borland | that is how it works in glance. | 19:36 |
| tqtran | can that be done client-side as well? | 19:36 |
| matt-borland | we want to mirror that | 19:36 |
| matt-borland | I don't think so | 19:36 |
| *** julim has joined #openstack-horizon | 19:36 | |
| matt-borland | beause we want our call to be as close to the glance call so it's familiar | 19:36 |
| matt-borland | in which case, | 19:36 |
| tqtran | not sure why we want to send known and unknown props at the same level | 19:36 |
| matt-borland | this is exactly what we want. | 19:36 |
| tqtran | then iterate and sublist them | 19:36 |
| matt-borland | that is how glance works. | 19:36 |
| tqtran | ah..... | 19:36 |
| matt-borland | check out their v2 api | 19:37 |
| *** neelashah has joined #openstack-horizon | 19:37 | |
| matt-borland | I agree, it's odd | 19:37 |
| matt-borland | but TravT and I reworked this code to be more in line with glance v2. | 19:37 |
| tqtran | if what you say is true, then why meta['properties'].update(other_props)? | 19:37 |
| matt-borland | that is how it's executed. | 19:37 |
| tqtran | so glance api is expecting the properties field? | 19:37 |
| matt-borland | it's just not completely reassigning, it's just merging the props onto the properties field | 19:37 |
| tqtran | right, thats what i was getting at | 19:38 |
| matt-borland | beause right now we have a v1 backend interface | 19:38 |
| matt-borland | which is a fault of horizon | 19:38 |
| matt-borland | but we can't just rewrite that | 19:38 |
| tqtran | ok, let me try to understand this correctly. | 19:38 |
| matt-borland | ok | 19:39 |
| *** neelashah1 has quit IRC | 19:39 | |
| tqtran | you're saying, in v2 glance, we pass in known and unknown props, and glance v2 api will parse out the unknonw to make it metadata | 19:39 |
| matt-borland | yep | 19:39 |
| tqtran | does it work the same for v1? | 19:39 |
| matt-borland | well, remember we're passing an object through Horizon's function: api.glance.image_create() | 19:40 |
| matt-borland | so we need to structure the object in the way it expects. | 19:40 |
| tqtran | ah..... | 19:40 |
| matt-borland | it doesn't matter the back-end version | 19:40 |
| tqtran | ok i think i understand n ow | 19:41 |
| matt-borland | but to make the API look glance-ish...yeah | 19:41 |
| r1chardj0n3s | morning | 19:41 |
| tqtran | because we're using the horizon's api, we need to pass in what it expects | 19:41 |
| matt-borland | afternoo! | 19:41 |
| matt-borland | *n | 19:41 |
| *** SimonChung has joined #openstack-horizon | 19:41 | |
| matt-borland | tqtran, yeah | 19:41 |
| *** SimonChung1 has quit IRC | 19:41 | |
| tqtran | ok, so heres my next question, why not do the preprocessing client-side? | 19:41 |
| matt-borland | ideally, we would just make the glance call ourselves, but it would require a bit more code than is appropriate. | 19:42 |
| *** vishwanathj has quit IRC | 19:42 | |
| matt-borland | well, we want the APIs to look the same (ish) | 19:42 |
| matt-borland | so preprocessing wouldn't make sense here | 19:42 |
| tqtran | why does it matter what client is sending the server? | 19:42 |
| tqtran | users arent going to see that | 19:42 |
| *** vishwanathj has joined #openstack-horizon | 19:42 | |
| tqtran | all they see is a nice user interface to muck with | 19:42 |
| matt-borland | I think it's good to keep the REST calls in close alignment | 19:43 |
| matt-borland | and in your scenario we're just modeling our REST call after v1 | 19:43 |
| matt-borland | I'd rather see consistency | 19:43 |
| matt-borland | not restructure all calls, that just creates room for re-engineering problems already solved | 19:44 |
| matt-borland | I think that was the whole point of why TravT had me rewrite that part. | 19:44 |
| matt-borland | otherwise we're just going off and arguing REST interfaces that have been already argued over. | 19:45 |
| *** tqtran has quit IRC | 19:46 | |
| *** tjones has quit IRC | 19:48 | |
| *** tqtran has joined #openstack-horizon | 19:51 | |
| tqtran | matt-borland: hi sorry i got dc | 19:51 |
| tqtran | let me paste what i wrote to myself earlier | 19:51 |
| *** petertr7 is now known as petertr7_away | 19:51 | |
| tqtran | can we put in a little note to explain why we need it? something like "The glance api takes in known and unknown fields. unknown fields are assumed as metadata. to achieve this and continue to use existing horizon api wrapper, we need to extract unknown properties." | 19:53 |
| tqtran | otherwise, someone new will wonder why the heck we need it instead of just massaging the data client-side | 19:53 |
| matt-borland | I said: | 19:53 |
| matt-borland | "Any parameters not listed above will be assigned as custom properties for the image." | 19:54 |
| matt-borland | in the documentation | 19:54 |
| matt-borland | I think that explains it... | 19:54 |
| *** jbell8 has quit IRC | 19:54 | |
| tqtran | is the doc in the current patch? | 19:55 |
| matt-borland | it's in the header info for both the patch and post methods. | 19:55 |
| tqtran | i think its clear what the method does. whats not clear is the WHY | 19:55 |
| *** crobertsrh1 has joined #openstack-horizon | 19:55 | |
| matt-borland | L186, L73 | 19:55 |
| *** neelashah has quit IRC | 19:56 | |
| *** petertr7_away is now known as petertr7 | 19:57 | |
| openstackgerrit | German proposed openstack/horizon: fix-legend-overflow https://review.openstack.org/252036 | 19:57 |
| matt-borland | tqtran, I'm pretty happy with it as is. | 19:57 |
| matt-borland | considering this wasn't in the last last request ;) | 19:57 |
| tqtran | I am too, but I do think the documentation like the one above will help clarify why we are using the helper method | 19:58 |
| tqtran | can you please just add it? :P i promise not to bother you after this | 19:58 |
| matt-borland | so, add what you wrote to handle_unknown_properties? | 19:58 |
| matt-borland | :) | 19:58 |
| tqtran | yes | 19:58 |
| matt-borland | I always appreciate it! don't get me wrong. | 19:59 |
| matt-borland | will do! | 19:59 |
| *** jprovazn has quit IRC | 19:59 | |
| *** gerrive has joined #openstack-horizon | 20:00 | |
| tqtran | "to achieve this and continue to use existing horizon api wrapper, we need this." | 20:00 |
| tqtran | last min edit, matt-borland | 20:00 |
| piet | The deck from today's presentation of the Nova Network/Neutron Migration Study can be found at https://wiki.openstack.org/wiki/HorizonUsability_Testing#December_2015_Nova_Networks_to_Neutron_Migration_Study | 20:00 |
| tqtran | "This way, client REST api mirrors the glance API" | 20:01 |
| tqtran | thanks piet, interesting presentation | 20:01 |
| *** chestack has quit IRC | 20:01 | |
| *** jbell8 has joined #openstack-horizon | 20:01 | |
| *** dshaw has quit IRC | 20:02 | |
| piet | tqtran Thanks! | 20:02 |
| *** jingjing_ren has quit IRC | 20:03 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Add API to Create/Update/Delete Images in Glance https://review.openstack.org/236832 | 20:03 |
| matt-borland | tqtran...done and done! | 20:04 |
| *** neelashah has joined #openstack-horizon | 20:06 | |
| tqtran | cool, thanks a lot | 20:06 |
| *** erlon has quit IRC | 20:09 | |
| *** SurajD has quit IRC | 20:09 | |
| *** rajatvig has quit IRC | 20:12 | |
| *** nlahouti has quit IRC | 20:12 | |
| *** btully has quit IRC | 20:12 | |
| *** piet has quit IRC | 20:13 | |
| *** btully has joined #openstack-horizon | 20:14 | |
| openstackgerrit | floren proposed openstack/horizon: Add symbol equal "=" in several filter texts https://review.openstack.org/252044 | 20:17 |
| *** vijendar has joined #openstack-horizon | 20:18 | |
| *** neelashah has quit IRC | 20:32 | |
| *** kzaitsev_mb has joined #openstack-horizon | 20:32 | |
| *** sjmc7 has quit IRC | 20:32 | |
| *** sjmc7 has joined #openstack-horizon | 20:35 | |
| *** neelashah has joined #openstack-horizon | 20:44 | |
| *** btully has quit IRC | 20:47 | |
| *** btully has joined #openstack-horizon | 20:48 | |
| *** rajatvig has joined #openstack-horizon | 20:57 | |
| *** gerrive has quit IRC | 21:01 | |
| *** pauloewerton has quit IRC | 21:03 | |
| *** Piet_ has joined #openstack-horizon | 21:04 | |
| *** ccard__ has joined #openstack-horizon | 21:04 | |
| *** ccard_ has quit IRC | 21:05 | |
| openstackgerrit | Omar Rivera proposed openstack/horizon: fix-legend-overflow https://review.openstack.org/252036 | 21:12 |
| *** btully has quit IRC | 21:17 | |
| *** neelashah has quit IRC | 21:18 | |
| *** nlahouti has joined #openstack-horizon | 21:19 | |
| *** tjones has joined #openstack-horizon | 21:20 | |
| *** btully has joined #openstack-horizon | 21:20 | |
| *** rajatvig has quit IRC | 21:21 | |
| *** ctina_ has joined #openstack-horizon | 21:22 | |
| *** rajatvig has joined #openstack-horizon | 21:24 | |
| *** ctina has quit IRC | 21:26 | |
| *** ctina_ has quit IRC | 21:27 | |
| *** saksham has quit IRC | 21:27 | |
| *** harlowja has quit IRC | 21:27 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Angular Table Header Directive https://review.openstack.org/252014 | 21:28 |
| *** harlowja has joined #openstack-horizon | 21:28 | |
| *** rcernin has quit IRC | 21:31 | |
| *** jerrygb has quit IRC | 21:32 | |
| robcresswell | tqtran: ping | 21:33 |
| robcresswell | TravT: Could you look through https://review.openstack.org/#/c/209631/ again? Its barely changed the last few patch sets. | 21:34 |
| TravT | robcresswell: i'll try. i owe a bunch of reviews to a bunch of people, but i know this one is highly desired. | 21:37 |
| robcresswell | TravT: Oh, no don't worry. It's not like its a super high priority item, I'm just trying to poke it along. | 21:38 |
| tqtran | robcresswell: i'll take another look tmr, going to try and wrap up what im looking at atm | 21:39 |
| TravT | tqtran: what is the status on the first angular action patches? | 21:41 |
| robcresswell | tqtran: Great, thanks Thai | 21:41 |
| TravT | i'd like to cross review the initial image and user action patches | 21:41 |
| TravT | been a bit since I last went through them | 21:41 |
| TravT | was hoping to see them settle down a bit. | 21:42 |
| tqtran | i think they're in good shape, i havent bothered updating the patch though | 21:42 |
| tqtran | its mostly just nits at this point | 21:42 |
| tqtran | was waiting on you guys to take another round before i update | 21:43 |
| robcresswell | Is the merge conflict relatively trivial? | 21:44 |
| tqtran | yeah, i just need to revert mine and rebase on master | 21:44 |
| tqtran | its one file, so no issue there | 21:44 |
| robcresswell | Heh, I meant for me to test it, but one file is fine | 21:45 |
| tqtran | ideally the keystone api stuff should be its own patch as well | 21:45 |
| *** chestack has joined #openstack-horizon | 21:45 | |
| tqtran | im actually going to be out tmr, but i'll update it thursday once im back in the bay | 21:45 |
| *** btully has quit IRC | 21:48 | |
| robcresswell | Cool. I need to look at the plugin docs too | 21:49 |
| TravT | ok, well, if there aren't massive code changes already coming, i'm willing to take a peek. | 21:49 |
| TravT | I am going to be out nearly three weeks of december, FYI | 21:50 |
| *** saksham has joined #openstack-horizon | 21:50 | |
| robcresswell | TravT: Same! Off from the 15th. | 21:50 |
| TravT | cool, vacation? | 21:51 |
| robcresswell | Just seeing family and siblings, nothing exciting til skiing in Jan | 21:51 |
| robcresswell | yourself? | 21:52 |
| *** neelashah has joined #openstack-horizon | 21:52 | |
| Piet_ | UX mid-cycle will be in London this release | 21:53 |
| robcresswell | :o | 21:53 |
| robcresswell | When is it? | 21:53 |
| *** btully has joined #openstack-horizon | 21:54 | |
| TravT | seems like it would be good for this to be same week / same place as horizon meetup | 21:57 |
| robcresswell | \o/ | 21:58 |
| Piet_ | BTW - where is the Horizon meeting? | 21:58 |
| *** hurgleburgler has quit IRC | 21:59 | |
| robcresswell | david-lyle: ^^ | 22:00 |
| Piet_ | Because it would be nice to have it somewhere other than the United States | 22:00 |
| *** hurgleburgler has joined #openstack-horizon | 22:02 | |
| *** chestack has quit IRC | 22:02 | |
| Piet_ | How many folks on the Horizon team work in Europe? | 22:03 |
| robcresswell | No idea | 22:03 |
| Piet_ | Also, is it easier for the Australians to fly to Europe? | 22:03 |
| robcresswell | Depends where in Europe, but London I'd imagine not | 22:04 |
| david-lyle | I think London is about as far as possible from australia | 22:04 |
| *** SimonChung has quit IRC | 22:04 | |
| *** SimonChung1 has joined #openstack-horizon | 22:04 | |
| *** chestack has joined #openstack-horizon | 22:05 | |
| robcresswell | Thats how we like it | 22:05 |
| hurgleburgler | ouch | 22:05 |
| robcresswell | haha | 22:06 |
| robcresswell | Piet_: When is the UX meetup? | 22:06 |
| Piet_ | I would imagine end of Jan / beginning of Feb | 22:07 |
| Piet_ | We have a space available at Intel | 22:07 |
| *** jbell8 has quit IRC | 22:08 | |
| Piet_ | I have some designers in London that should attend along with Rob | 22:09 |
| Piet_ | Trying to understand whether there are any other Horizon devs that can attend | 22:09 |
| *** jbell8 has joined #openstack-horizon | 22:10 | |
| *** jbell8 has quit IRC | 22:10 | |
| *** vgridnev has quit IRC | 22:11 | |
| *** crobertsrh1 has left #openstack-horizon | 22:12 | |
| *** zz_john5223 has quit IRC | 22:13 | |
| robcresswell | tqtran: Is the Create action designed for keystone v3 too? | 22:14 |
| tqtran | yes v2 and v3 | 22:14 |
| sjmc7 | all airlines lead to london | 22:14 |
| robcresswell | :D | 22:15 |
| r1chardj0n3s | . | 22:15 |
| * r1chardj0n3s sees Australians in the immediate scrollback... | 22:15 | |
| r1chardj0n3s | robcresswell: actually, London is as easy as most of Europe | 22:15 |
| r1chardj0n3s | robcresswell: some carriers bounce thru Heathrow | 22:15 |
| robcresswell | r1chardj0n3s: Ah, fair enough. | 22:16 |
| *** zz_john5223 has joined #openstack-horizon | 22:16 | |
| r1chardj0n3s | if Horizon midcycle isn't nailed down real soon, Neill and I won't be attending. There's a fair chance Neill won't anyway, as he's got another Jan trip in the works (to Texas) | 22:16 |
| tqtran | noes! | 22:17 |
| tqtran | we needs your energy r1chardj0n3s | 22:17 |
| r1chardj0n3s | Piet_: could I, in a very friendly and in no way with any pressure ask how you're going looking a the swift redesign? | 22:17 |
| r1chardj0n3s | tqtran: I very much want to attend :-) | 22:17 |
| r1chardj0n3s | but time is running short for planning international travel in Jan | 22:17 |
| *** lblanchard has quit IRC | 22:18 | |
| robcresswell | tqtran: It seems like quite a few of the v3 fields are missing? | 22:19 |
| david-lyle | my concern is I won't be able to attend anywhere in January | 22:19 |
| Piet_ | Austin, Texas would be awesome. | 22:19 |
| robcresswell | tqtran: I left a review/ list | 22:19 |
| robcresswell | Piet_: Twice in 3 months? | 22:19 |
| r1chardj0n3s | david-lyle: late feb? | 22:19 |
| TravT | yeah, i'm also questionable for january. | 22:19 |
| TravT | for travel. | 22:19 |
| *** harlowja has quit IRC | 22:19 | |
| tqtran | robcresswell: cool thanks, i'll get around to it | 22:19 |
| Piet_ | My schedule will free up next week to focus on Swift | 22:19 |
| TravT | i am having knee surgery shortly and will be on crutches for 6 weeks. | 22:19 |
| robcresswell | tqtran: Great thanks | 22:19 |
| Piet_ | Hint, hint | 22:20 |
| sjmc7 | TravT - having done that flight on crutches: don't. | 22:20 |
| r1chardj0n3s | week of Feb 15th would be ideal | 22:20 |
| robcresswell | TravT: Oof. Good luck. | 22:20 |
| r1chardj0n3s | Piet_: cool, thanks! | 22:20 |
| r1chardj0n3s | TravT: ouch! all the best with that! | 22:20 |
| TravT | thx... wasn't planning on it, but found out yesterday | 22:20 |
| *** harlowja has joined #openstack-horizon | 22:21 | |
| r1chardj0n3s | so, robcresswell, TravT, david-lyle, tqtran: I'm kinda torn on https://review.openstack.org/#/c/251670/ ... I really feel like I should re-write it to de-angularise it (I'm pretty sure it can't be fully angular because it integrates with django forms) ... would also remove the need for the tech-debt loadAngular() | 22:22 |
| *** gyee has joined #openstack-horizon | 22:22 | |
| r1chardj0n3s | foremost I just want to fix the bug, which the patch does (though tests fail, and I'll look into that) | 22:22 |
| Piet_ | Travt: I have a hunting knife...c'mon over and I'll fix it! | 22:22 |
| r1chardj0n3s | but as robcresswell points out, the code is uuuuuuhhhhhhhhhhgly | 22:22 |
| TravT | r1chardj0n3s: i had to read the description twice to get what it even does | 22:23 |
| robcresswell | r1chardj0n3s: Yeep. I was waiting on the tests to look at it properly. | 22:24 |
| r1chardj0n3s | how about I fix the tests, we merge the bug fix and revisit the issue? | 22:24 |
| r1chardj0n3s | TravT: I could clarify things ... which description is lacking? the bug report, the patch commit message or the code docs? | 22:25 |
| r1chardj0n3s | (or all of the above? ;-) | 22:25 |
| TravT | the confusion came from reading your IRC, then looking at the patch | 22:25 |
| TravT | i was expecting that it removed the angular altogether | 22:26 |
| *** chestack has quit IRC | 22:26 | |
| *** petertr7 is now known as petertr7_away | 22:26 | |
| tqtran | r1chardj0n3s: whats the difference between .val and the ugly code you wrote? | 22:26 |
| r1chardj0n3s | TravT: ah ok, the patch does not remove the angular, just fixes it, yes. what I was just saying is the "correct" fix is to remove the angular code and rewrite the functionality in jquery | 22:26 |
| Piet_ | Proposed blueprint: Content Guidelines for UIs https://blueprints.launchpad.net/openstack-manuals/+spec/ui-content-guidelines | 22:26 |
| r1chardj0n3s | tqtran: .val doesn't work :-) | 22:27 |
| tqtran | what about .attr('value')? | 22:27 |
| r1chardj0n3s | I can write a more complete explanation in the commit message if you like? | 22:27 |
| TravT | nah, i'm not blocking that patch over the commit message | 22:28 |
| tqtran | yes, im not getting why val doesnt work | 22:28 |
| TravT | commit message is fine | 22:28 |
| r1chardj0n3s | tqtran: because .val looks at the wrong part of the DOM, in short | 22:28 |
| tqtran | i understand the missing ctrl in them HTML | 22:28 |
| r1chardj0n3s | it needs to look at *just* the value of the "value" attribute, not at the "current value of the form element" which has been altered by angular | 22:28 |
| tqtran | will attr('value') work? | 22:29 |
| r1chardj0n3s | the value attribute is set by django in the page templating, but then angular nukes the form element value | 22:29 |
| r1chardj0n3s | tqtran: I didn't try that, will do | 22:30 |
| tqtran | robcresswell: i think the theme patch is in good shape, i just need to manually pull it down and test it again | 22:30 |
| robcresswell | r1chardj0n3s: What is that code actually supposed to be doing? | 22:31 |
| tqtran | if all goes well, i'll be happy to +2 it through | 22:31 |
| robcresswell | tqtran: Thanks, I appreciate it | 22:31 |
| *** jtriley_ has joined #openstack-horizon | 22:31 | |
| r1chardj0n3s | robcresswell: the JS code sets the image format selector based on the chosen image file/url name | 22:31 |
| robcresswell | Ah, I see | 22:32 |
| *** david_cu has quit IRC | 22:32 | |
| *** jerrygb has joined #openstack-horizon | 22:32 | |
| *** david_cu has joined #openstack-horizon | 22:33 | |
| robcresswell | r1chardj0n3s: As to earlier question; yes, fix bug now, rewrite later if there happens to be time. | 22:33 |
| r1chardj0n3s | coolo | 22:34 |
| *** jtriley has quit IRC | 22:34 | |
| r1chardj0n3s | I'll look into whether it can be cleaned up a little using attr() like tqtran suggests | 22:34 |
| robcresswell | r1chardj0n3s: That would be nice. Current implementation is not a big win for code readability. | 22:35 |
| r1chardj0n3s | yeah :/ | 22:35 |
| *** jtriley_ has quit IRC | 22:36 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add unit tests for load-edit directive https://review.openstack.org/237788 | 22:37 |
| *** david_cu has quit IRC | 22:37 | |
| *** jerrygb has quit IRC | 22:37 | |
| *** Drago has quit IRC | 22:38 | |
| *** peristeri has quit IRC | 22:38 | |
| *** absubram has quit IRC | 22:39 | |
| matt-borland | thanks robcresswell / tqtran ! | 22:40 |
| *** chestack has joined #openstack-horizon | 22:40 | |
| *** matt-borland has quit IRC | 22:41 | |
| *** NightKhaos has quit IRC | 22:41 | |
| *** nlahouti has quit IRC | 22:45 | |
| *** adelia_ has joined #openstack-horizon | 22:46 | |
| *** NightKhaos has joined #openstack-horizon | 22:47 | |
| *** adelia has quit IRC | 22:49 | |
| *** adelia_ has quit IRC | 22:51 | |
| r1chardj0n3s | tqtran: turns out .val() does work (it's short-hand for .attr('value') which is short-hand for the long-hand I wrote) | 22:52 |
| r1chardj0n3s | tqtran: it wasn't working previously because the selector was incorrect; I didn't back-track along the investigation tree far enough once I figured that bit out | 22:53 |
| tqtran | :) | 22:53 |
| r1chardj0n3s | tqtran: so thanks for the prod! | 22:53 |
| tqtran | great, so your patch is a oneliner | 22:53 |
| tqtran | which makes it even easier to review lol | 22:53 |
| r1chardj0n3s | well, no | 22:53 |
| r1chardj0n3s | three liner :-) | 22:53 |
| r1chardj0n3s | I'm gonna add a comment too | 22:53 |
| r1chardj0n3s | also need to figure out the test fails | 22:55 |
| *** nlahouti has joined #openstack-horizon | 22:56 | |
| *** harlowja has quit IRC | 22:57 | |
| tqtran | alrighty, calling it a night, see yall thursday | 22:57 |
| *** tqtran has quit IRC | 22:57 | |
| *** jingjing_ren has joined #openstack-horizon | 22:58 | |
| *** jingjing_ren has quit IRC | 22:59 | |
| *** jingjing_ren has joined #openstack-horizon | 22:59 | |
| *** SimonChung1 has quit IRC | 23:01 | |
| *** SimonChung has joined #openstack-horizon | 23:01 | |
| *** harlowja has joined #openstack-horizon | 23:01 | |
| *** kzaitsev_mb has quit IRC | 23:03 | |
| Piet_ | LBaaS edit workflows. Needs +/- 2. https://invis.io/59524AX4J | 23:06 |
| *** neelashah has quit IRC | 23:08 | |
| *** Drago has joined #openstack-horizon | 23:09 | |
| *** TravT has quit IRC | 23:10 | |
| *** Drago has quit IRC | 23:10 | |
| *** Drago has joined #openstack-horizon | 23:10 | |
| *** TravT has joined #openstack-horizon | 23:12 | |
| *** TravT_ has joined #openstack-horizon | 23:12 | |
| *** mounica has quit IRC | 23:14 | |
| *** TravT has quit IRC | 23:16 | |
| *** kzaitsev_mb has joined #openstack-horizon | 23:22 | |
| *** david-lyle has quit IRC | 23:25 | |
| *** TravT_ is now known as TravT | 23:27 | |
| *** darrenc is now known as darrenc_afk | 23:31 | |
| *** e0ne has joined #openstack-horizon | 23:34 | |
| *** e0ne has quit IRC | 23:36 | |
| *** e0ne has joined #openstack-horizon | 23:36 | |
| *** e0ne_ has joined #openstack-horizon | 23:39 | |
| *** e0ne has quit IRC | 23:41 | |
| *** lhcheng has quit IRC | 23:48 | |
| *** SimonChung has quit IRC | 23:48 | |
| *** SimonChung1 has joined #openstack-horizon | 23:48 | |
| *** lhcheng has joined #openstack-horizon | 23:48 | |
| *** e0ne has joined #openstack-horizon | 23:49 | |
| *** tjones has quit IRC | 23:50 | |
| *** e0ne_ has quit IRC | 23:51 | |
| *** lapalm has quit IRC | 23:51 | |
| *** darrenc_afk is now known as darrenc | 23:52 | |
| *** e0ne_ has joined #openstack-horizon | 23:52 | |
| *** Drago has quit IRC | 23:52 | |
| *** e0ne has quit IRC | 23:54 | |
| *** mpavlase has quit IRC | 23:54 | |
| *** tjones has joined #openstack-horizon | 23:56 | |
| *** chestack has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!