Thursday, 2015-09-10

openstackgerritCindy Lu proposed openstack/horizon: GOOAdd Angular Directive to show msg for empty tables  https://review.openstack.org/17503500:04
*** asahlin has quit IRC00:05
*** asahlin has joined #openstack-horizon00:06
openstackgerritCindy Lu proposed openstack/horizon: Add Angular Directive to show msg for empty tables  https://review.openstack.org/17503500:06
*** Sukhdev has quit IRC00:07
*** Sukhdev has joined #openstack-horizon00:07
*** SimonChung has quit IRC00:08
*** stevemar has joined #openstack-horizon00:09
*** stevemar has quit IRC00:13
*** mwhagedorn has quit IRC00:24
*** garthb has quit IRC00:25
*** hurgleburgler has quit IRC00:25
*** darrenc_afk is now known as darrenc00:32
*** btully has quit IRC00:39
*** linkedinyou has quit IRC00:39
*** gyee has quit IRC00:41
*** ducttape_ has joined #openstack-horizon00:55
*** kyleolivo has quit IRC00:58
*** linkedinyou has joined #openstack-horizon00:58
openstackgerritRichard Jones proposed openstack/django_openstack_auth: Monkey-patch to avoid breaking Django with hash user.id  https://review.openstack.org/22038201:01
*** ducttape_ has quit IRC01:01
*** kyleolivo has joined #openstack-horizon01:02
*** ducttape_ has joined #openstack-horizon01:02
*** kyleolivo has quit IRC01:06
*** geoffarnold is now known as geoffarnoldX01:10
*** jtriley has joined #openstack-horizon01:11
*** shivrao has quit IRC01:12
*** saksham has quit IRC01:15
*** ducttape_ has quit IRC01:16
*** btully has joined #openstack-horizon01:17
*** jtriley has quit IRC01:17
*** tqtran has quit IRC01:18
openstackgerritDavid Lyle proposed openstack/horizon: Launch instance create volume fails  https://review.openstack.org/22200801:20
*** ducttape_ has joined #openstack-horizon01:21
*** asahlin has quit IRC01:21
*** btully has quit IRC01:21
*** asahlin has joined #openstack-horizon01:22
*** lyanchih has joined #openstack-horizon01:22
*** ducttape_ has quit IRC01:23
*** julim has joined #openstack-horizon01:23
*** asahlin has quit IRC01:26
*** asahlin has joined #openstack-horizon01:28
*** lyanchih has quit IRC01:30
*** Daisy has joined #openstack-horizon01:30
*** Daisy has quit IRC01:31
*** Daisy has joined #openstack-horizon01:31
*** linkedinyou has quit IRC01:31
*** Daisy_ has joined #openstack-horizon01:32
lhchengdoes anyone uses django-formtools?01:32
lhchengwonder why this got merged: https://github.com/openstack/requirements/commit/9692ec5759b17beaf5bb0f1e6797fe8a774e288b01:32
lhchengdoesn't look like anyone from horizon got the chance to review it01:33
*** Daisy_ has quit IRC01:34
*** Daisy_ has joined #openstack-horizon01:35
lhchengfrom the patch comment, looks like mirantis uses, but I don't think vanilla horizon uses it01:35
r1chardj0n3sweird01:35
david-lyleused to be they looked for project review01:35
david-lyleany more stuff just merges01:35
*** Daisy has quit IRC01:35
david-lylesame was happening on project jobs on zull01:35
david-lyle*zuul01:36
*** linkedinyou has joined #openstack-horizon01:38
*** asahlin has quit IRC01:39
*** Daisy_ has quit IRC01:39
lhchengwhy would anyone need the project review? :P01:39
lhchenglol01:39
* david-lyle shakes head01:40
david-lyleI'm loving that vanilla devstack with neutron now takes 4 GB of memory to run01:40
r1chardj0n3s\o/01:41
r1chardj0n3smodern computing01:41
david-lylewith my 6GB VM I have space to run devstack or tests, but certainly not both01:42
david-lyleWIN01:42
*** Daisy has joined #openstack-horizon01:42
*** Sukhdev has quit IRC01:43
r1chardj0n3sit's like a corollary to Moore's law: programmers will naturally consume whatever resources are provided01:43
david-lylememory's cheap01:44
david-lyleunless you've maxed out your laptop01:44
david-lyle:P01:45
r1chardj0n3s;)01:45
Daisydavid-lyle: Just confirmed with infra team, the translation patch is from old translation tool. So the issue is caused by bad translations. I will see how to fix it, either asking translators to fix, or fixing by myself.01:47
*** bpokorny has quit IRC01:47
david-lyleDaisy: thank you for the update. Hopefully an easy fix, seems like formatting issue only. But I'm not expert :)01:48
lhchengdavid-lyle: Timur did hit the keypair Issue: https://bugs.launchpad.net/horizon/+bug/149320501:48
openstackLaunchpad bug 1493205 in OpenStack Dashboard (Horizon) "Create Keypair failed on latest DevStack" [Critical,Fix committed] - Assigned to Timur Sufiev (tsufiev-x)01:48
lhchengit is great that bug just get fixed while sleeping :)01:49
* lhcheng should sleep longer01:50
david-lyleLin my patch is based on that01:50
*** vishwanathj has quit IRC01:50
lhchengfor the formtools, I don't know the policy about that..  maybe because of the big tent, we take all requirements too01:51
lhcheng>.<01:51
david-lylethere will be more failures then :)01:51
david-lyleprobably true for the requirements01:51
david-lylewe don't have to include it in requirements.txt if Horizon doesn't need it01:51
lhchengyup01:53
david-lyletime to walk through our nova interactions I think01:53
david-lylewell tomorrow01:54
david-lyler1chardj0n3s: when I click the back button on the login bug, my submit button is disabled01:54
david-lylehow are you submitting the form?01:54
r1chardj0n3sdavid-lyle: well that's weird, my submit button isn't disabled... chrome?01:55
david-lyleFF01:55
r1chardj0n3stry chrome?01:56
david-lylechrome eats memory for breakfast01:56
r1chardj0n3s:/ I'll try ff01:56
david-lyleok, I can repro in Chrome01:56
r1chardj0n3sff isn't starting01:57
r1chardj0n3swat01:57
r1chardj0n3sok, ff started :)01:57
r1chardj0n3sbut you've repro'd so there's that01:57
* r1chardj0n3s hunts around for some RAM to bring to the summit for david-lyle01:57
david-lylejust need another system01:58
david-lyletime to go find one01:59
david-lyleok, I'm done for the night01:59
david-lylegood night01:59
r1chardj0n3sg'night david-lyle01:59
david-lyler1chardj0n3s: will review patch in depth in my morning01:59
r1chardj0n3sthanks02:00
david-lylenow that I can repro, I feel more confident reviewing02:00
david-lyle:P02:00
* david-lyle out02:00
r1chardj0n3s:)02:00
*** kyleolivo has joined #openstack-horizon02:01
*** daisy_ has joined #openstack-horizon02:12
*** Daisy has quit IRC02:12
*** daisy_ is now known as daisy02:12
*** Daisy_ has joined #openstack-horizon02:13
*** stevemar has joined #openstack-horizon02:15
*** Daisy_ has quit IRC02:17
*** kyleoliv_ has joined #openstack-horizon02:19
*** kyleolivo has quit IRC02:19
*** asahlin has joined #openstack-horizon02:23
*** alejandrito has joined #openstack-horizon02:28
*** stevemar has quit IRC02:32
*** KunalGandhi has quit IRC02:32
*** asahlin has quit IRC02:34
*** Daisy_ has joined #openstack-horizon02:36
*** kyleoliv_ has quit IRC02:38
*** daisy has quit IRC02:46
*** Daisy_ is now known as Daisy02:47
*** geoffarnoldX is now known as geoffarnold02:50
openstackgerritLin Hua Cheng proposed openstack/django_openstack_auth: IDP specific websso  https://review.openstack.org/21904102:50
*** TravT has quit IRC02:53
*** Daisy has quit IRC02:57
*** Daisy has joined #openstack-horizon02:57
*** Daisy_ has joined #openstack-horizon02:59
*** Daisy has quit IRC02:59
*** doug-fish has quit IRC03:00
*** doug-fish has joined #openstack-horizon03:00
*** yamamoto has joined #openstack-horizon03:01
*** btully has joined #openstack-horizon03:05
*** lhcheng has quit IRC03:05
*** btully has quit IRC03:09
*** alejandrito has quit IRC03:10
*** rajatvig has joined #openstack-horizon03:11
*** btully has joined #openstack-horizon03:18
*** rajatvig has quit IRC03:19
*** tjones has joined #openstack-horizon03:20
*** btully has quit IRC03:23
*** Samos123 has quit IRC03:27
*** Samos123 has joined #openstack-horizon03:30
*** stevemar has joined #openstack-horizon03:33
*** stevemar has quit IRC03:36
*** bpokorny has joined #openstack-horizon03:39
*** Drago has quit IRC03:40
*** Daisy_ has quit IRC03:45
*** SimonChung has joined #openstack-horizon03:49
*** stevemar has joined #openstack-horizon03:50
*** geoffarnold is now known as geoffarnoldX03:51
*** SimonChung1 has joined #openstack-horizon03:51
*** SimonChung has quit IRC03:54
*** tjones has quit IRC03:55
*** Mzoorikh has joined #openstack-horizon03:58
*** lhcheng has joined #openstack-horizon04:00
*** lhcheng has left #openstack-horizon04:01
*** Mzoorikh has quit IRC04:02
*** Mzoorikh has joined #openstack-horizon04:03
*** morgan has quit IRC04:06
*** jbell8 has quit IRC04:06
*** morganfainberg has joined #openstack-horizon04:07
*** morganfainberg is now known as morgan04:09
*** hurgleburgler has joined #openstack-horizon04:16
*** geoffarnoldX is now known as geoffarnold04:19
*** geoffarnold is now known as geoffarnoldX04:20
*** jbell8 has joined #openstack-horizon04:21
*** kyleolivo has joined #openstack-horizon04:23
*** jbell8 has quit IRC04:26
*** mflobo has joined #openstack-horizon04:32
*** alanf has joined #openstack-horizon04:36
*** alanf has quit IRC04:38
*** asahlin has joined #openstack-horizon04:46
*** asahlin has quit IRC04:50
*** fifieldt has joined #openstack-horizon04:58
*** btully has joined #openstack-horizon05:03
*** bpokorny has quit IRC05:11
*** vgridnev has joined #openstack-horizon05:14
*** Daisy has joined #openstack-horizon05:14
*** kyleolivo has quit IRC05:14
*** mohankumar has joined #openstack-horizon05:15
*** Sukhdev has joined #openstack-horizon05:19
*** Daisy has quit IRC05:23
*** Daisy has joined #openstack-horizon05:23
*** vishwanathj has joined #openstack-horizon05:27
*** vishwanathj has quit IRC05:28
*** stevemar has quit IRC05:28
*** stevemar has joined #openstack-horizon05:29
*** mohankumar has quit IRC05:31
*** aortega has joined #openstack-horizon05:35
*** KingKhan_ has joined #openstack-horizon05:37
*** aortega has quit IRC05:38
*** stevemar has quit IRC05:43
*** stevemar has joined #openstack-horizon05:43
*** Drago has joined #openstack-horizon05:46
*** Drago has quit IRC05:46
*** Drago has joined #openstack-horizon05:46
*** Drago has quit IRC05:48
*** jerrygb has joined #openstack-horizon05:53
*** fifieldt has quit IRC05:56
*** KingKhan_ has quit IRC06:03
*** KingKhan_ has joined #openstack-horizon06:04
openstackgerritOpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex  https://review.openstack.org/22040406:08
*** mrunge has joined #openstack-horizon06:08
*** jbell8 has joined #openstack-horizon06:10
*** mohankumar has joined #openstack-horizon06:10
*** jbell8 has quit IRC06:14
*** jerrygb has quit IRC06:19
*** mpavlase has joined #openstack-horizon06:34
*** lawrancejing has joined #openstack-horizon06:35
*** rdopiera has joined #openstack-horizon06:39
openstackgerritLi Yingjun proposed openstack/horizon: Hide 'Gateway IP' input when 'Disable Gateway' is checked  https://review.openstack.org/21190706:40
openstackgerritAllen proposed openstack/horizon: Fix alignment issues in project table inline edit  https://review.openstack.org/22204406:44
*** evgenyf has joined #openstack-horizon06:50
*** jtomasek has joined #openstack-horizon06:50
*** jbell8 has joined #openstack-horizon06:50
*** zz_ttrifonov is now known as ttrifonov06:57
*** KingKhan_ has quit IRC06:58
*** bfic has joined #openstack-horizon07:01
*** lsmola has joined #openstack-horizon07:02
*** romainh has joined #openstack-horizon07:03
*** jcoufal has joined #openstack-horizon07:07
*** stevemar has quit IRC07:13
*** peristeri has joined #openstack-horizon07:17
*** Sukhdev has quit IRC07:19
*** vgridnev has quit IRC07:31
*** Ala has joined #openstack-horizon07:31
*** mohankumar has quit IRC07:33
*** btully has quit IRC07:39
*** mohankumar has joined #openstack-horizon07:41
*** JeanBriceCombebi has joined #openstack-horizon07:42
zigoWhen logging into Horizon Liberty b3, now I get: https://paste.debian.net/311156/07:42
zigoWhat's going on?07:42
mrungezigo, django-openstack-auth not updated, right?07:43
*** bigjools has quit IRC07:43
zigoProbably.07:43
mrungezigo, which django?07:44
zigo1.707:44
zigoTrying to upgrade openstack-auth.07:44
*** bigjools has joined #openstack-horizon07:46
*** bigjools has joined #openstack-horizon07:46
*** aortega has joined #openstack-horizon07:46
*** Daisy has quit IRC07:46
zigomrunge: Nop, I was wrong, that's Django 1.8.07:47
zigoopenstack-auth declares its incompatible with it... :(07:47
zigomrunge: Any known patch that I should apply, or just fixing the requirements.txt is enough?07:47
mrungezigo, there is a release ready for django-1.807:47
mrungezigo, make sure you're using d-o-a version 1.4 (and later)07:48
zigomrunge: There's only 1.4.0 tagged.07:48
mrungeyes07:48
zigoThat one says Django<1.8,>=1.4.207:48
mrungeI would expect 1.4.1 (or even .2 to be tagged in a few days?)07:49
mrungezigo, I would truncate -s requirements.txt07:49
mrungeI see the important patches are merged int 1.4.007:49
zigomrunge: I could package trunk if you think it's wise.07:50
*** sayan has joined #openstack-horizon07:50
mrungezigo, IMHO you should wait a few days, there is a patch in the queue07:50
zigoOk.07:51
mrungehttps://review.openstack.org/#/c/220382/07:51
mrungezigo, at least that patch should be included in your package07:52
mrungeotherwise users *will* complain07:52
zigoThanks.07:52
mrungezigo, but for your local testing, current upstream will be fine07:53
mrungeif it declares django < 1.8, truncate requirements.txt07:53
mrungerequirements are being handled by .deb anyways, aren't they?07:53
*** amotoki has joined #openstack-horizon07:55
zigomrunge: They are, but python apps can refuse stuff...07:56
zigoI don't use the --single-version-externaly-manage option, as a safety net.07:56
mrungethus truncate -s07:56
zigoYEAH!07:57
zigoI'm in ! :)07:57
mrungecongrats07:57
zigoLots of stuff to unbreak in the packages though, but it's working.07:57
*** mhickey has joined #openstack-horizon07:57
*** bapalm has quit IRC07:58
*** sayan has quit IRC07:59
zigoSome javascript aren't working ... :(08:00
zigohttps://paste.debian.net/311157/08:00
mrungezigo, please report that in launchpad08:00
*** bapalm has joined #openstack-horizon08:00
*** mohankumar has quit IRC08:01
*** asahlin has joined #openstack-horizon08:02
*** ygbo has joined #openstack-horizon08:02
openstackgerritAllen proposed openstack/horizon: Improve error message for create QoS Spec  https://review.openstack.org/22206308:05
*** asahlin has quit IRC08:06
zigomrunge: https://bugs.launchpad.net/horizon/+bug/149417108:06
openstackLaunchpad bug 1494171 in OpenStack Dashboard (Horizon) "Javascript error: Module 'horizon.auth' is not available!" [Undecided,New]08:06
mrungethank you zigo08:06
openstackgerritAllen proposed openstack/horizon: Fix alignment issue in project table inline edit  https://review.openstack.org/22204408:07
mrungetargeted to rc108:07
mrungezigo, anything else you'll find, please be sure to report as well08:07
mrungewe need to stabilize08:07
zigoSure.08:07
*** akrivoka has joined #openstack-horizon08:07
mrungethank you08:07
mrungeif you have the chance, it makes sense to have a qa person looking at b308:08
zigoIt seems I have the fonts working, though the current maintainers of fonts-roboto think there's still a problem: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=79826108:08
openstackDebian bug 798261 in wnpp "ITP: fonts-roboto-fontface -- largely geometric, friendly and open curves font" [Wishlist,Open]08:08
mrungeha, same here08:09
mrungezigo, if I understood hurgleburgler right, roboto is not used by default08:11
mrungein horizon08:11
mrungeit is required though, but not used08:11
*** sayan has joined #openstack-horizon08:13
*** vgridnev has joined #openstack-horizon08:19
*** jerrygb has joined #openstack-horizon08:19
*** stevemar has joined #openstack-horizon08:20
*** sayan has quit IRC08:21
*** sayan has joined #openstack-horizon08:22
*** ttrifonov is now known as zz_ttrifonov08:22
*** stevemar has quit IRC08:24
*** jerrygb has quit IRC08:24
*** zz_ttrifonov is now known as ttrifonov08:24
*** btully has joined #openstack-horizon08:25
*** jcoufal has quit IRC08:25
*** btully has quit IRC08:30
*** lawrancejing has quit IRC08:36
*** JeanBriceCombebi has quit IRC08:36
*** JeanBriceCombebi has joined #openstack-horizon08:36
*** bigjools has quit IRC08:38
*** bigjools has joined #openstack-horizon08:40
*** ttrifonov is now known as zz_ttrifonov08:41
*** yamamoto_ has joined #openstack-horizon08:44
*** yamamoto has quit IRC08:44
*** zz_ttrifonov is now known as ttrifonov08:44
*** yamamoto has joined #openstack-horizon08:44
openstackgerritVitaly Gridnev proposed openstack/horizon: Adding option for Spark jobs to use Swift paths  https://review.openstack.org/18771108:48
*** yamamoto_ has quit IRC08:48
openstackgerritVitaly Gridnev proposed openstack/horizon: Adding option for name and uuid substitution  https://review.openstack.org/18842208:49
openstackgerritVitaly Gridnev proposed openstack/horizon: Allow multiple clusters creation  https://review.openstack.org/19884708:49
*** jbell8 has quit IRC08:50
*** JeanBriceCombebi has quit IRC08:55
*** JeanBriceCombebi has joined #openstack-horizon08:55
*** e0ne has joined #openstack-horizon08:57
mhickeymrunge: Good morning09:03
mrungemhickey, good morning09:05
*** JeanBriceCombebi has quit IRC09:06
*** JeanBriceCombebi has joined #openstack-horizon09:06
mhickeymrunge: would you have sometime to look at this patch: https://review.openstack.org/#/c/213193/ ?09:07
*** e0ne has quit IRC09:07
*** e0ne has joined #openstack-horizon09:12
*** jcoufal has joined #openstack-horizon09:18
*** jerrygb has joined #openstack-horizon09:20
*** JeanBriceCombebi has quit IRC09:22
*** JeanBriceCombebi has joined #openstack-horizon09:23
*** tosky has joined #openstack-horizon09:24
*** jerrygb has quit IRC09:26
*** e0ne has quit IRC09:35
*** alexpilotti_ has joined #openstack-horizon09:37
*** e0ne has joined #openstack-horizon09:41
*** aix has quit IRC09:45
*** sayan has quit IRC09:45
*** sayan has joined #openstack-horizon09:46
*** JeanBriceCombebi has quit IRC09:48
*** tnovacik has joined #openstack-horizon09:49
mrungemhickey, I'm sorry, I'm in the middle of something else09:54
openstackgerritTatiana Ovchinnikova proposed openstack/horizon: Fix FWaaS Rules table displaying  https://review.openstack.org/22210210:02
mhickeymrunge: no worries. I understand :-)10:03
*** aix has joined #openstack-horizon10:13
*** kmartin has quit IRC10:20
*** ttrifonov is now known as zz_ttrifonov10:22
*** JeanBriceCombebi has joined #openstack-horizon10:24
*** bfic has quit IRC10:31
openstackgerritJulia Varlamova proposed openstack/manila-ui: Add availability zones support to manila-ui  https://review.openstack.org/21667410:31
*** zhenguo has quit IRC10:33
*** akrivoka has quit IRC10:33
*** alexpilotti_ has quit IRC10:43
openstackgerritTimur Sufiev proposed openstack/django_openstack_auth: Rename 'AVAILABLE_REGIONS' to 'AVAILABLE_KEYSTONE_ENDPOINTS'  https://review.openstack.org/22212910:45
*** sayan has quit IRC10:47
openstackgerritTimur Sufiev proposed openstack/django_openstack_auth: Rename 'AVAILABLE_REGIONS' to 'AVAILABLE_KEYSTONE_ENDPOINTS'  https://review.openstack.org/22212910:48
*** mrunge has quit IRC10:49
*** ZZelle has quit IRC10:49
openstackgerritSam Betts proposed openstack/horizon: Ensure log messages are not translation objects  https://review.openstack.org/17397410:49
*** ZZelle has joined #openstack-horizon10:49
openstackgerritTimur Sufiev proposed openstack/horizon: Rename 'AVAILABLE_REGIONS' to 'AVAILABLE_KEYSTONE_ENDPOINTS'  https://review.openstack.org/22213110:52
*** mrunge has joined #openstack-horizon10:54
openstackgerritTimur Sufiev proposed openstack/horizon: Rename 'AVAILABLE_REGIONS' to 'AVAILABLE_KEYSTONE_ENDPOINTS'  https://review.openstack.org/22213210:54
*** sayan has joined #openstack-horizon10:56
*** mpavlase has quit IRC11:04
*** mpavlase has joined #openstack-horizon11:06
*** JeanBriceCombebi has quit IRC11:11
*** vgridnev has quit IRC11:12
*** akrivoka has joined #openstack-horizon11:13
*** vgridnev has joined #openstack-horizon11:14
*** jerrygb has joined #openstack-horizon11:21
*** jerrygb has quit IRC11:26
*** lexholden has joined #openstack-horizon11:27
*** mpavlase has quit IRC11:29
*** mpavlase has joined #openstack-horizon11:30
*** aix has quit IRC11:34
*** sambetts has quit IRC11:35
*** aix has joined #openstack-horizon11:35
*** sambetts has joined #openstack-horizon11:35
*** lexholden has quit IRC11:42
*** sayan has quit IRC11:43
*** jamielennox is now known as jamielennox|away11:49
*** sayan has joined #openstack-horizon11:52
*** sayan has quit IRC11:53
*** sayan has joined #openstack-horizon11:54
robcresswelldavid-lyle: Stepping through the rc1 bugs/bps and reviewing. I've also bumped a couple, which were duplicates, or just very old bugs that have been bumped by the release team.11:55
*** btully has joined #openstack-horizon12:01
*** btully has quit IRC12:06
*** katyafervent is now known as katyafervent_awa12:12
*** katyafervent_awa is now known as katyafervent12:12
*** lexholden has joined #openstack-horizon12:21
*** JeanBriceCombebi has joined #openstack-horizon12:21
*** ducttape_ has joined #openstack-horizon12:23
openstackgerritTomáš Nová?ik proposed openstack/horizon: Add multi role test possibility to integr. tests  https://review.openstack.org/11509212:32
*** Drago1 has joined #openstack-horizon12:35
*** linkmark has joined #openstack-horizon12:36
*** Drago1 has quit IRC12:36
*** Drago1 has joined #openstack-horizon12:36
*** e0ne has quit IRC12:37
*** _crobertsrh is now known as crobertsrh12:38
*** egafford has joined #openstack-horizon12:40
*** ducttape_ has quit IRC12:40
*** jerrygb has joined #openstack-horizon12:40
*** jerrygb has quit IRC12:45
*** asahlin has joined #openstack-horizon12:55
*** yamamoto has quit IRC12:56
*** vgridnev has quit IRC12:57
*** Mzoorikh has quit IRC13:01
*** mrunge has quit IRC13:05
*** vgridnev has joined #openstack-horizon13:10
*** zhenguo has joined #openstack-horizon13:11
*** asahlin_ has joined #openstack-horizon13:13
*** asahlin has quit IRC13:16
*** pauloewerton has joined #openstack-horizon13:17
*** lapalm has joined #openstack-horizon13:32
*** e0ne has joined #openstack-horizon13:33
*** mwhagedorn has joined #openstack-horizon13:37
*** jprovazn has joined #openstack-horizon13:39
*** jerrygb has joined #openstack-horizon13:41
egafforddavid-lyle: Ping13:42
*** aortega has quit IRC13:43
*** jerrygb has quit IRC13:45
*** jtriley has joined #openstack-horizon13:47
*** Piet has quit IRC13:52
*** kyleolivo has joined #openstack-horizon13:53
*** kyleolivo has quit IRC13:53
*** tosky_ has joined #openstack-horizon13:53
*** kyleolivo has joined #openstack-horizon13:54
*** tosky has quit IRC13:57
*** kyleolivo has quit IRC13:57
*** TravT has joined #openstack-horizon13:58
*** tosky_ is now known as tosky13:59
robcresswellegafford: Anything I can help with?13:59
*** ducttape_ has joined #openstack-horizon14:01
openstackgerritTimur Sufiev proposed openstack/horizon: Use unicode characters in integration tests entities names  https://review.openstack.org/22219914:02
egaffordrobcresswell: Hey there; thanks. I'm trying to separate js and html per comments on https://review.openstack.org/#/c/209683/10/.14:02
*** lblanchard has joined #openstack-horizon14:03
*** cloudtrainme has joined #openstack-horizon14:03
egaffordI've got the .js separated out; the difficulty is that the static .js must reach back and contain a separate template html file (to create the "rows" of the argument form.)14:03
*** kyleolivo has joined #openstack-horizon14:03
egaffordThat html file needs {% trans "" %} blocks in it.14:03
*** btully has joined #openstack-horizon14:04
*** bigjools has quit IRC14:05
egaffordSo I'm wondering: is it kosher to have a script block in the main html panel template file containing the html row template (even though it's not truly html) to deal with the trans block, or do I need to have another file/layer of indirection that's effectively nested in the .js and somehow reaches through Horizon to pull out an html block?14:05
egaffordJust wondering how far down the rabbit hole it's desired that I go here. :)14:06
*** kyleoliv_ has joined #openstack-horizon14:06
robcresswellJust looking14:07
robcresswellSo the issue is needing translation in the JS file?14:07
*** bigjools has joined #openstack-horizon14:07
*** bigjools has joined #openstack-horizon14:07
egaffordYes, but it's not really. That's easy (w/ gettext)14:07
egaffordIn https://review.openstack.org/#/c/209683/10/openstack_dashboard/contrib/sahara/content/data_processing/jobs/templates/data_processing.jobs/job_interface_arguments_template.html:14:08
*** kyleolivo has quit IRC14:08
egaffordvar argument_template contains an html block that is templated into a form for a single argument.14:08
openstackgerritPaulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding tests for ng identity basePath constant  https://review.openstack.org/22180414:08
egaffordHm; I guess I can just gettext everywhere else as well.14:09
egaffordSo my real question is whether it's acceptable to nest the giant html-like blob in the script block.14:09
egaffordI've got a few examples: https://github.com/openstack/murano-dashboard/blob/master/muranodashboard/templates/services/index.html#L31 and https://github.com/openstack/horizon/commit/e0cd466ecf585d36a6598efd8a36d7e2a3dac1ff primarily.14:10
egaffordThese suggest fairly different approaches, and I'd really like the next patch to stick. The latter was suggested by david-lyle, so I suspect that embedding the html template in the .js (but not further embedding that in html) will be adequate.14:11
pkarikhHi folks! Horizon has lines like this" domain_context = self.request.session.get('domain_context', None)". But how domain_context gets into the session?14:11
robcresswellIt's... how to explain. It's not ideal.14:11
robcresswellRealistically, since Sahara is likely to move out soon, we are content for you guys to manage it how you like14:12
robcresswellBut its against the normal Horizon patterns, and I would personally -1 that sort of code. it's much more maintainable to seperate out your templates. It seems like its unnecessary abstraction at first, but it helps to seperate markup and logic (HTML bs JS) as much as possible14:13
robcresswellHTML vs JS*14:13
robcresswellI would definitely advise splitting the HTML out from the JS entirely14:14
robcresswellegafford: ^^14:14
egaffordrobcresswell: Okay. Even though this is a js template that expresses html?14:15
*** jerrygb has joined #openstack-horizon14:15
egaffordIs it adequate to put it the html template in a separate .js file (given that it really is js)?14:15
robcresswellWHat do you mean by the HTML is really JS?14:16
*** Drago1 has quit IRC14:16
egaffordrobcresswell: So there are three layers here. There's the actual html template, which is great. Then there's a small .js library which is now separated out into a static file, also great.14:17
egaffordThe .js library uses an html template, but that html template is littered with js templating $blah markup.14:18
*** Drago has joined #openstack-horizon14:18
*** Drago has quit IRC14:18
egaffordrobcresswell: I need to know where that html template needs to reside to be accepted, as it is neither fully html nor fully js.14:19
*** Drago has joined #openstack-horizon14:19
openstackgerritTomáš Nová?ik proposed openstack/horizon: Add multi role test possibility to integr. tests  https://review.openstack.org/11509214:19
egaffordIf it can be in the .js file (as a similar construct is in https://github.com/openstack/horizon/commit/e0cd466ecf585d36a6598efd8a36d7e2a3dac1ff), that's great.14:19
egaffordHowever, comments on the patch have suggested to me that a deeper separation of concerns may be desired than on david-lyle's patch, possibly because it's a larger chunk of html.14:20
egaffordSo I'm looking for clarity.14:20
*** neelashah has joined #openstack-horizon14:21
*** vijendar has joined #openstack-horizon14:22
*** vishwanathj has joined #openstack-horizon14:23
*** vishwanathj has quit IRC14:24
*** Piet has joined #openstack-horizon14:25
robcresswellOkay, just been looking at the code more.14:27
robcresswellI think if the JS has been seperated14:27
robcresswelland david has previously indicated that is all that is required14:27
robcresswellI would leave it at that stage14:27
*** aortega has joined #openstack-horizon14:28
egaffordrobcresswell: Okay, I'll leave the html template embedded in the .js then. Thanks robcresswell.14:29
robcresswell:)14:29
*** vgridnev has quit IRC14:31
*** Daisy has joined #openstack-horizon14:33
openstackgerritAlexander Vasiliev proposed openstack/horizon: Closes-Bug: #1493140  https://review.openstack.org/22221514:34
openstackbug 1493140 in OpenStack Dashboard (Horizon) "create network form duplicates errors" [Undecided,In progress] https://launchpad.net/bugs/1493140 - Assigned to Alexander Vasiliev (avasiliev)14:34
openstackgerritTimur Sufiev proposed openstack/horizon: Do not match table actions by ordering in integration tests  https://review.openstack.org/21830114:35
tsufievegafford, what about moving html from js to outer html wrapped with <script type="text/template"/>, and then extract it with $('#template_id')?14:40
tsufievegafford, I believe this way you still could use {% trans %} within the template. The actual html snippet being extracted in JS code would contain already translated strings14:42
robcresswellI'm not sure what you gain by doing that vs leaving it in the html. It seems like its still using gettext and trans in the same block, which IMO is kinda odd14:42
robcresswellleaving it in the js* sorry14:42
tsufievrobcresswell, it would make JS more readable14:43
*** yamamoto has joined #openstack-horizon14:43
tsufiev+ enable html syntax highlighting in advanced editors14:44
robcresswelltsufiev: This is true. There may be value in that.14:44
*** JeanBriceCombebi has quit IRC14:44
tsufievrobcresswell, otherwise, it looks like editing the output of ngHtmlToJS by hand :)14:44
*** JeanBriceCombebi has joined #openstack-horizon14:44
*** Daisy has quit IRC14:47
*** Daisy has joined #openstack-horizon14:48
*** geoffarnoldX is now known as geoffarnold14:48
ducttape_amotoki - are you online?14:48
amotokiducttape_: hey14:48
ducttape_I just filed this bug https://bugs.launchpad.net/horizon/+bug/1494358  and have two different ways to fix it, would like your input14:49
openstackLaunchpad bug 1494358 in OpenStack Dashboard (Horizon) "topology view does not support multi-networked instances where 1 network is outside of tenant" [Undecided,New]14:49
ducttape_So within the topology view that produces the json, I could filter out (in python) the ports that attach to networks not visible to the tenant14:49
ducttape_the other option is to change the Javascript to be more robust14:49
ducttape_I *think* the js might be broken at https://github.com/openstack/horizon/blob/master/horizon/static/horizon/js/horizon.networktopology.js#L179  because it only looks at the [0] index14:51
amotokiducttape_: is such port created by admin (or a user with some special role)?14:51
ducttape_it is created by an admin14:51
ducttape_the user asks for lbaas pool / vip etc to be setup, then we have an lbaas implementation that creates vms within the tenants network (as admin)14:52
*** Daisy has quit IRC14:52
amotokiI see. sounds reasonable approach.14:53
*** aix has quit IRC14:53
*** vgridnev has joined #openstack-horizon14:53
ducttape_so do you have a preference on correcting the javascript side, or filtering out these ports within the python code?14:54
*** e0ne has quit IRC14:55
amotokiI think network topology panel is being replaced by curvature based graph, so changing JS may conflict.14:55
amotokithis is just a note.14:55
amotokiback to the main topic.14:56
robcresswellbradjones: ^^14:56
robcresswellbradjones: This is relevant :p14:56
ducttape_yes, Brad's implementation seemed to work correctly14:56
ducttape_however, I am hoping in the meantime I can correct existing topo... just to get by for a bit longer14:56
amotokiducttape_: thinking14:57
*** stevemar has joined #openstack-horizon14:58
*** lexholden has quit IRC14:58
amotokiducttape_: IMO filtering these ports in the server side looks better. I would like to see LB VIP is connected to a network rather than based on VM ports.14:59
ducttape_http://paste.openstack.org/show/455177/  is the python fix (I think)14:59
amotokiducttape_: what do you think?14:59
ducttape_I like fixing the python side, because it is easy, and does not provide ports that are dead ends to the client14:59
*** kmartin has joined #openstack-horizon15:00
amotokiducttape_: I heard another symptom. If LBaaS instance is implemented as a service VM and a VIP port is owned by a tenant, we will see such VM is conncted to one network twice.15:01
* ducttape_ has a question that amotoki does not have an answer for = +100 points15:01
ducttape_;)15:01
amotokiducttape_: correct :)15:01
amotokiI think we need to handle VIP port of a service VM specially......15:02
*** vishwanathj has joined #openstack-horizon15:03
*** e0ne has joined #openstack-horizon15:03
*** kyleolivo has joined #openstack-horizon15:03
amotokiducttape_: what is "device_owner" of your LB instance VM?15:03
* ducttape_ checking....15:04
*** vgridnev has quit IRC15:04
ducttape_amotoki - the VM lives within the tenant's space.... that is the tenant can "nova list" and see their vm.  is that what you mean?15:06
*** rdopiera has quit IRC15:06
amotokiducttape_: what I think is "device_owner" field of neutron ports.15:06
ducttape_ahh ok, let me check15:07
*** kyleoliv_ has quit IRC15:07
*** pai15 has joined #openstack-horizon15:07
*** hurgleburgler has quit IRC15:08
amotokiAccording to the bug report, your instance has two ports. the one is VIP port connected to a tenant network. It should be visible to a tenant.15:08
*** mhickey has quit IRC15:10
pai15hello, in kilo release, you can specify external subnet for floating ip creation. But I do not see that exposed in Horizon. Basically when you go to allocate floating ip to a project, if the external network has subnets, there is no way in horizon to specify which subnet.15:10
amotokiThe other port is invisible to a tenant, it should not be visible in the network topology, but I wonder why such port is listed in the network topology python logic.15:10
pai15it can be specified from neutron cli (neutron floatingip-create), but can't do that from horizon15:10
pai15is this in the works somewhere?15:11
amotokiIt should be excluded in the phase of retrieving network information IMO.15:11
amotokipai15: I am not aware of such work so far.15:12
ducttape_[u'compute:None', u'compute:None']   are the port device owners amotoki15:12
*** garthb has joined #openstack-horizon15:13
amotokiducttape_: thanks, one port is owned by a tenatn and the other is owned by admin. I think it is better to exclude a port which is connected to invisible network in the server side.15:14
*** cbader has quit IRC15:15
pai15amotoki: thanks.15:15
amotokiducttape_: can we do this easily in JS side?15:15
ducttape_ok.  I will clean up my patch above and place you as reviewer, thanks amotoki15:15
amotokiducttape_: thanks15:16
*** peristeri has quit IRC15:16
ducttape_amotoki - define easily :D.  the python stuff I already have written15:16
*** kyleoliv_ has joined #openstack-horizon15:16
*** kyleoliv_ has quit IRC15:16
*** kyleoliv_ has joined #openstack-horizon15:17
amotokiducttape_: in my understanding, the role of the python code is to provide a logical network topology information, and JS side presents it.15:18
ducttape_ok.  I will put my code up, and we can discuss then.  and hopefully, the new topology will be available not too far from now15:18
*** hurgleburgler has joined #openstack-horizon15:19
*** kyleolivo has quit IRC15:20
*** vgridnev has joined #openstack-horizon15:23
*** JeanBriceCombebi has quit IRC15:24
*** lblanchard has quit IRC15:25
*** asahlin_ has quit IRC15:25
*** aix has joined #openstack-horizon15:26
openstackgerritEric Peterson proposed openstack/horizon: Topology filter out non tenant ports  https://review.openstack.org/22224815:28
ducttape_amotoki ^15:28
openstackgerritJustin Pomeroy proposed openstack/horizon: Escape RegEx characters from table quick search text  https://review.openstack.org/11393215:28
*** asahlin has joined #openstack-horizon15:29
*** evgenyf has quit IRC15:30
*** lblanchard has joined #openstack-horizon15:30
*** mpavlase has quit IRC15:33
*** gyee has joined #openstack-horizon15:34
*** jbell8 has joined #openstack-horizon15:34
*** bpokorny has joined #openstack-horizon15:35
*** lapalm has quit IRC15:36
*** pai15 has quit IRC15:38
*** pai15 has joined #openstack-horizon15:39
*** neelashah has quit IRC15:40
david-lyledid something merge to break the python 3.4 tests?15:41
david-lyleis this a known issue, is my question15:41
*** vgridnev has quit IRC15:41
*** pai15 has quit IRC15:43
*** lapalm has joined #openstack-horizon15:44
*** pai15 has joined #openstack-horizon15:45
*** neelashah has joined #openstack-horizon15:46
*** SimonChung1 has quit IRC15:46
*** lapalm has quit IRC15:51
*** lapalm has joined #openstack-horizon15:52
*** akanksha has joined #openstack-horizon15:54
ducttape_fun time:  https://review.openstack.org/#/c/206797  has the reviewer "Welcome, new contributor!"15:54
ducttape_"Welcome, new contributor!" never reviews any of my patches :'(15:54
hurgleburglerLOL15:56
*** e0ne has quit IRC15:56
david-lylemessage is clear I think15:57
ducttape_that I am not welcomed, you mean?15:57
ducttape_seems about right15:57
david-lylethe bot said it, not me15:57
david-lylehave you tried multiple personas?15:58
*** sayan has quit IRC15:58
ducttape_you cut me real deep, bot.... cut me to the bone15:58
*** Ala has quit IRC15:58
ducttape_david-lyle - no to multiple personas, trying to stay on my meds15:58
akankshaHello, I want to start contributing to OpenStack. I am applying to Outreachy for December- March round. Can someone please guide me on how to start?15:59
ducttape_doctor and judges orders15:59
david-lyleHi akanksha, if you are interested in Horizon in particular, there is https://github.com/openstack/horizon/blob/master/doc/source/contributing.rst16:01
david-lylefor OpenStack in general, https://wiki.openstack.org/wiki/How_To_Contribute16:02
*** e0ne has joined #openstack-horizon16:02
*** tjones has joined #openstack-horizon16:03
*** rajatvig has joined #openstack-horizon16:04
*** kyleoliv_ has quit IRC16:05
david-lyleok, missed the email, gate is horked16:06
david-lyletoday's going to be great, I can feel it16:07
kfox1111:)16:08
david-lylemaybe fixed as of 8 minutes ago16:08
david-lylehttps://review.openstack.org/#/c/222218/16:09
*** kyleolivo has joined #openstack-horizon16:09
david-lylewait, that's going to have to propagate :(16:11
*** Drago has quit IRC16:14
*** Drago has joined #openstack-horizon16:14
akankshadavid-lyle: I am not sure whether I need to install devstack or just get the code repository for working on the code?16:14
*** ygbo has quit IRC16:15
*** tnovacik has quit IRC16:17
*** tjones has quit IRC16:21
*** tjones has joined #openstack-horizon16:27
kfox1111depends what you have to test with. if you don't have a test cloud, devstack's the easiest way to get one.16:31
david-lyleakanksha: devstack is the simplest way to develop test16:33
david-lyleI would suggest creating a VM and installing devstack in it16:33
david-lyleif you're doing horizon development, it would then be most beneficial to clone another copy of horizon and run that against the devstack instance you just set up16:34
david-lylethat can also be on the same VM16:34
david-lyleor not16:34
david-lylesame VM less port forwarding required, where less is none16:34
*** romainh has left #openstack-horizon16:37
*** kyleolivo has quit IRC16:40
*** kyleolivo has joined #openstack-horizon16:41
bradjones|awayducttape_: http://pasteboard.co/xvsA4BC.png16:42
*** kyleolivo has quit IRC16:42
*** bradjones|away is now known as bradjones16:42
ducttape_sweet!16:42
*** KunalGandhi has joined #openstack-horizon16:42
ducttape_did that require any more fixes?  or is it that I have something messed up on my side?16:42
bradjones101 vms, same setup as yours apart from the one vm in two networks16:43
ducttape_even better ;)16:43
bradjonesI have tweaked the force direction so it won't lock up, I'm just doing some final testing then will push another patch16:43
bradjonesif networks are still not connected in your environment with this patch then I don't really know what's going on16:44
ducttape_cool.  thanks, I hope that's what my setup will look like.  I had a good graph show up at one point, but recently it has had the networks disconnected16:44
david-lylebradjones: shows much promise16:45
*** kyleolivo has joined #openstack-horizon16:47
*** pai15 has quit IRC16:47
egafforddavid-lyle: Hi there. I have a version of the .js separation on https://review.openstack.org/#/c/209683/10/openstack_dashboard/contrib/sahara/content/data_processing/jobs/templates/data_processing.jobs/job_interface_arguments_template.html working, but I'm running into difficulty in openstack-dashboard/enabled. If I point both the clusters panel and the jobs panel at "openstack_dashboard.contrib.sahara.content.data_process16:48
egaffordI suspect there's a simple mapping somewhere, but I grepped around a bit and couldn't find it, so I figured I'd ask.16:48
*** pai15 has joined #openstack-horizon16:48
*** cbader has joined #openstack-horizon16:49
*** kyleolivo has quit IRC16:49
*** alanf has joined #openstack-horizon16:50
david-lyleshouldn't have to add the app twice16:50
*** pai15 has quit IRC16:53
*** lsmola has quit IRC16:53
david-lyleegafford: that was intended for you16:54
egafforddavid-lyle: Okay, cool. I think I was repeatedly seeing an odd interaction with the auth redirect after compression. Yup, I got it; thanks.16:54
*** e0ne has quit IRC16:54
*** pai15 has joined #openstack-horizon16:56
*** jcoufal has quit IRC16:56
*** yamamoto has quit IRC16:56
*** lapalm has quit IRC16:57
*** kyleolivo has joined #openstack-horizon16:57
*** lapalm has joined #openstack-horizon16:57
openstackgerritEthan Gafford proposed openstack/horizon: [Sahara] Unified job interface map UI  https://review.openstack.org/20968317:00
*** KunalGandhi has quit IRC17:00
*** mrunge has joined #openstack-horizon17:02
*** lapalm has quit IRC17:02
*** KunalGandhi has joined #openstack-horizon17:02
*** jbell8 has quit IRC17:04
*** sqchen has joined #openstack-horizon17:05
*** sqchen has left #openstack-horizon17:05
*** jbell8 has joined #openstack-horizon17:05
*** sqchen has joined #openstack-horizon17:05
*** Mzoorikh has joined #openstack-horizon17:06
*** TravT_ has joined #openstack-horizon17:07
*** zhenguo has quit IRC17:07
*** TravT has quit IRC17:08
*** aix has quit IRC17:09
*** aortega has quit IRC17:09
*** aortega has joined #openstack-horizon17:09
*** tnovacik has joined #openstack-horizon17:11
*** TravT_ has quit IRC17:14
*** pai15 has quit IRC17:14
*** pai15 has joined #openstack-horizon17:15
*** lhcheng has joined #openstack-horizon17:15
*** TravT has joined #openstack-horizon17:16
*** pai15 has quit IRC17:16
*** pai15 has joined #openstack-horizon17:16
*** gyee has quit IRC17:21
*** SimonChung has joined #openstack-horizon17:28
*** Drago has quit IRC17:29
openstackgerritThai Tran proposed openstack/horizon: WIP Adding CREATE action to identity users panel  https://review.openstack.org/22229717:29
openstackgerritThai Tran proposed openstack/horizon: WIP Adding Actions to Users Panel  https://review.openstack.org/20231517:30
*** JeanBriceCombebi has joined #openstack-horizon17:32
*** Mzoorikh has quit IRC17:36
*** erlon has joined #openstack-horizon17:36
*** Mzoorikh has joined #openstack-horizon17:37
*** jpomeroy has quit IRC17:37
*** mrunge has quit IRC17:39
*** shivrao has joined #openstack-horizon17:40
*** julim has quit IRC17:46
*** jbell8 has quit IRC17:47
*** hinnant_ has joined #openstack-horizon17:47
*** saksham has joined #openstack-horizon17:50
*** kyleolivo has quit IRC17:54
*** pai15 has quit IRC17:55
*** jbell8 has joined #openstack-horizon17:55
*** pai15 has joined #openstack-horizon17:55
*** tosky has quit IRC17:55
openstackgerritMerged openstack/horizon: Fix usage of netaddr '.broadcast'  https://review.openstack.org/21876317:56
*** jpomeroy has joined #openstack-horizon17:57
*** yamamoto has joined #openstack-horizon17:57
*** lapalm has joined #openstack-horizon17:58
*** kyleolivo has joined #openstack-horizon17:59
*** pai15 has quit IRC17:59
*** pai15 has joined #openstack-horizon18:00
*** neelashah has quit IRC18:00
*** pai15 has quit IRC18:01
*** doug-fish has quit IRC18:01
*** neelashah has joined #openstack-horizon18:01
*** pai15 has joined #openstack-horizon18:01
*** yamamoto has quit IRC18:02
*** doug-fish has joined #openstack-horizon18:02
*** lapalm has quit IRC18:02
*** lapalm has joined #openstack-horizon18:02
*** lapalm has quit IRC18:02
*** lapalm has joined #openstack-horizon18:03
*** neelashah1 has joined #openstack-horizon18:03
*** neelashah has quit IRC18:05
*** doug-fish has quit IRC18:06
*** jingjing_ren has joined #openstack-horizon18:08
*** mhickey has joined #openstack-horizon18:09
*** e0ne has joined #openstack-horizon18:13
*** e0ne has quit IRC18:17
*** tjones has left #openstack-horizon18:18
openstackgerritEric Peterson proposed openstack/horizon: Topology filter out non tenant ports  https://review.openstack.org/22224818:19
*** garthb has quit IRC18:21
*** mhickey has quit IRC18:22
*** mhickey has joined #openstack-horizon18:23
openstackgerritTomáš Nová?ik proposed openstack/horizon: Add multi role test possibility to integr. tests  https://review.openstack.org/11509218:23
mhickey@david-lyle: Hi!18:23
*** doug-fish has joined #openstack-horizon18:23
*** doug-fish has quit IRC18:24
*** JeanBriceCombebi has quit IRC18:24
*** doug-fish has joined #openstack-horizon18:25
*** garthb has joined #openstack-horizon18:25
*** doug-fish has quit IRC18:27
*** doug-fish has joined #openstack-horizon18:27
*** jwy has joined #openstack-horizon18:29
*** tqtran has joined #openstack-horizon18:29
*** pauloewerton has quit IRC18:30
*** mflobo has quit IRC18:31
*** linkedinyou has quit IRC18:31
*** linkedinyou has joined #openstack-horizon18:32
*** pauloewerton has joined #openstack-horizon18:32
*** mflobo has joined #openstack-horizon18:35
*** julim has joined #openstack-horizon18:37
*** julim_ has joined #openstack-horizon18:39
*** jbell8 has quit IRC18:41
*** akrivoka has quit IRC18:41
*** Mzoorikh has quit IRC18:41
*** julim has quit IRC18:42
*** Mzoorikh has joined #openstack-horizon18:43
*** Mzoorikh has quit IRC18:47
*** Mzoorikh has joined #openstack-horizon18:47
mhickeyHey, can someone please check out my patch? https://review.openstack.org/#/c/213193/18:49
*** jingjing_ren has quit IRC18:50
doug-fishI see the Horizon integration tests seem to be running successfully now -- Hooray! -- though they aren't voting yet18:55
doug-fishI'd encourage everyone to give a -1 to a patch that doesn't pass the tests18:56
lhchengmhickey: posted some comments18:59
*** kyleolivo has quit IRC19:00
*** neelashah1 has quit IRC19:00
tsufievdoug-fish, +++19:02
*** ducttape_ has quit IRC19:02
lhchengdoug-fish: thanks for the reminder19:02
tsufievdoug-fish, they already caught 3 Horizon bugs19:02
doug-fishtsufiev, lhcheng what do you think about pursing making those voting?19:03
tsufievdoug-fish, I'd wait at least until M master opens19:03
tsufievit's dangerous to block ourselves so close to release19:03
doug-fishyeah, I was afraid of that19:04
doug-fishthough not having voting integration tests is a bit dangerous too!19:04
mhickeylhcheng: thanks for the comments19:04
*** sayan has joined #openstack-horizon19:04
mhickeyI agree with comments on checking before action; I will take a look19:04
*** JeanBriceCombebi has joined #openstack-horizon19:05
mhickeyNot so sure about table action; this is what the defect is about. If admin wants to batch delete domains then the admin would like to batch disable them first19:05
*** Drago has joined #openstack-horizon19:05
tsufievdoug-fish, any person that pushes the decision to make them voting just before release, will be blamed for some urgent horizon patch being blocked19:05
*** ybathia has joined #openstack-horizon19:05
lhchengagree with tsufiev, maybe monitor it for a bit.19:06
*** neelashah has joined #openstack-horizon19:06
* tsufiev just doesn't want to be blamed for that19:06
tsufiev:)19:06
*** Drago has quit IRC19:07
*** sayan has quit IRC19:07
*** Drago has joined #openstack-horizon19:07
doug-fishI've been married for 20+ years. I'm used to taking the blame for lots of stuff.19:07
*** doug-fish has quit IRC19:08
*** jbell8 has joined #openstack-horizon19:08
*** lapalm has quit IRC19:09
mhickeylhcheng: WRT to messing up a domain. An admin can batch delete it. Disabling/enabling a domain is less critical. In addition they would have to select before the operation.19:09
*** doug-fish has joined #openstack-horizon19:09
*** lapalm has joined #openstack-horizon19:09
*** ducttape_ has joined #openstack-horizon19:12
*** pai15 has quit IRC19:12
*** lexholden has joined #openstack-horizon19:13
*** doug-fish has quit IRC19:13
*** lapalm has quit IRC19:13
*** cloudtrainme has quit IRC19:14
jpomeroydoug-fish, tsufiev, lhcheng: until they are turned on then i think the cores need to try to make sure not to approve any patches that do not pass the integration tests19:14
tsufievjpomeroy, yes, I think the same19:14
*** doug-fish has joined #openstack-horizon19:16
*** lapalm has joined #openstack-horizon19:16
*** lapalm has quit IRC19:16
*** doug-fish has quit IRC19:16
*** doug-fish has joined #openstack-horizon19:17
*** lapalm has joined #openstack-horizon19:17
lhchengmhickey: if you keep the batch action, you might need to keep the status check in the action().19:17
*** akanksha has quit IRC19:18
mhickeylhcheng: Just posted reply to patch. You are correct, just realised it when typing! :-)19:18
lhchengmhickey: I would think batch Disable is more critical than Delete, since it would just disable access to all the domains.  While Delete is kinda okay, since it needs to move to Disabled state first.19:19
lhcheng*all the domains selected19:19
*** lexholden has quit IRC19:19
lhchengmhickey: it is just a suggestion, I'm fine either way19:19
lhchengmhickey: the -1 was just for the additional check in the allowed() method19:19
mhickeylhcheng: That sounds ok. I have to assume though that an admin knows what they are doing for the most part. If a admin want to batch delete selected domains then they want to remove them. They still will have to disable them. We just wantr to provde the emans to batch disable them as you would batch delete them.19:21
*** jingjing_ren has joined #openstack-horizon19:21
mhickeylhcheng: Thanks for the feedback:-). So does the -1 still apply if we want the batch enable/disable?19:22
*** rajatvig has quit IRC19:22
*** Sukhdev has joined #openstack-horizon19:23
lhchengmhickey: no that's fine, just need to cleanup the action() method19:23
lhchengmhickey: added comments on the patch19:24
lhchengjpomeroy: ++19:24
lhchengmaybe we can update the room status to remind other Core not to approve patch that failed integration tests19:24
lhchengnot sure what's the best way19:25
lhchengor maybe just send it to ML19:25
*** cloudtrainme has joined #openstack-horizon19:25
*** jingjing_ren has quit IRC19:25
doug-fishML is a good idea19:25
doug-fisheveryone can -1 a patch with a failing test - doesn't have to just be the cores on the hook for it19:26
*** vgridnev has joined #openstack-horizon19:27
*** mhickey has quit IRC19:33
*** geoffarnold has quit IRC19:34
*** mhickey has joined #openstack-horizon19:40
mhickeylhcheng: Replied to your comment on checking in allowed(). I think it needs to be in action(0 as currently is?19:42
*** alanf has quit IRC19:51
*** jwy has quit IRC19:51
*** rajatvig has joined #openstack-horizon19:53
*** saksham has quit IRC19:56
*** JeanBriceCombebi has quit IRC19:56
*** jerrygb has quit IRC19:58
*** kyleolivo has joined #openstack-horizon20:01
*** kyleolivo has quit IRC20:01
*** gyee has joined #openstack-horizon20:01
*** kyleolivo has joined #openstack-horizon20:02
*** amotoki has quit IRC20:03
*** linkedinyou|2 has joined #openstack-horizon20:05
*** linkedinyou|2 has quit IRC20:06
*** rajatvig has quit IRC20:06
*** rajatvig has joined #openstack-horizon20:06
*** linkedinyou has quit IRC20:07
*** cloudtrainme has quit IRC20:09
*** cloudtrainme has joined #openstack-horizon20:10
*** tnovacik has quit IRC20:11
*** alanf has joined #openstack-horizon20:14
*** jingjing_ren has joined #openstack-horizon20:17
*** neelashah has quit IRC20:21
*** jwy has joined #openstack-horizon20:22
*** jprovazn has quit IRC20:23
*** TravT_ has joined #openstack-horizon20:23
*** cloudtra_ has joined #openstack-horizon20:24
*** TravT has quit IRC20:25
*** Daisy has joined #openstack-horizon20:27
*** cloudtrainme has quit IRC20:27
*** hinnant_ has quit IRC20:30
*** jerrygb has joined #openstack-horizon20:30
*** Mzoorikh has quit IRC20:32
*** Daisy has quit IRC20:32
*** viks has joined #openstack-horizon20:34
*** rhagarty__ has joined #openstack-horizon20:37
*** akanksha has joined #openstack-horizon20:39
*** aix has joined #openstack-horizon20:40
*** Drago has quit IRC20:41
*** itisha has joined #openstack-horizon20:43
*** rhagarty__ has quit IRC20:43
*** rhagarty__ has joined #openstack-horizon20:43
openstackgerritMerged openstack/horizon: Updated from global requirements  https://review.openstack.org/22192820:44
*** neelashah has joined #openstack-horizon20:46
*** rhagarty__ has quit IRC20:46
*** rhagarty__ has joined #openstack-horizon20:47
*** ZZelle_ has joined #openstack-horizon20:48
*** geoffarnold has joined #openstack-horizon20:51
lapalmHello all, I have a question for anyone that can help...20:53
*** rhagarty__ has quit IRC20:54
lapalmI am under Project->Network Topology tab20:54
*** rhagarty__ has joined #openstack-horizon20:54
openstackgerritMerged openstack/horizon: Switch Magic Search class to the correct one.  https://review.openstack.org/22190620:55
openstackgerritMerged openstack/horizon: Switch Magic Search class to the correct one.  https://review.openstack.org/22190620:55
lapalmand there are 2 "Launch Instance" buttons in the top right of the page above the topology20:55
lapalmShould there not be 2 buttons there?20:55
david-lylelapalm: only if you configured it that way20:56
david-lyle:)20:56
david-lylebut two is possible20:56
david-lyletwo versions20:56
lapalmhmmmm oh ok20:56
lapalmI do have the new angular workflow enabled20:56
*** mpavlase has joined #openstack-horizon20:56
lapalmThe button on the right takes me to the old Launch Instance workflow20:57
lapalmWhile the button on the left takes me nowhere20:57
lapalmJust spins and spins ;)20:57
*** lblanchard has quit IRC21:00
lapalmdavid-lyle I disbaled the legacy launch instance in my local_settings and that did the trick21:01
hurgleburglerany browser console errors?21:01
lapalmnow only 1 buttons show up ;)21:01
lapalmlet me check the console21:01
*** alanf has quit IRC21:02
*** saksham has joined #openstack-horizon21:03
*** alanf has joined #openstack-horizon21:04
lapalmhurgleburgler no obvious errors at quick glance...21:04
hurgleburglerhmm21:04
hurgleburglereven on page refresh?21:04
lapalmpage refresh brings me back to the network topology page21:05
lapalmThe Launch Instance button works fine under the instances tab21:06
lapalmJust not in network topology21:06
*** jtriley has quit IRC21:08
*** tjones has joined #openstack-horizon21:12
*** pauloewerton has quit IRC21:14
david-lyletrying21:15
david-lylelapalm: ^^21:15
*** Piet has quit IRC21:16
lapalmdavid-lyle OK cool21:16
lhchengmhickey: just got back from lunch, replied to your comments21:17
lapalmdavid-lyle it is the Angular one that is not working from Network Topology page21:17
david-lyleunderstoof21:17
david-lyled21:17
r1chardj0n3smorning21:17
david-lyleI see JS errors on the console21:18
david-lylewill rebuild static from scratch21:18
*** egafford has left #openstack-horizon21:20
david-lylelapalm: you found a bug21:21
david-lyleplease add in launchpad21:21
lapalmhmmmm ok I can do that21:22
lapalmdavid-lyle although I am not entirely sure what is failing21:23
*** Sukhdev has quit IRC21:23
lapalmdavid-lyle besides the obvious that it just pop open the wizard21:24
lapalmdavid-lyle doesn't*21:24
r1chardj0n3stsufiev: around?21:26
david-lyleI can file it lapalm21:27
david-lylethere are errors on the JS console21:27
lapalmI was just in the middle of writing the summary lol21:27
*** KunalGandhi has quit IRC21:27
lapalmbut you could probably write it up better...21:27
lapalmI didnt see those errors....21:28
lapalmmust have not looked close enough i guess21:28
david-lylelapalm post it, I'll add the errors21:29
david-lyle:)21:29
david-lylecollaboration21:29
lapalm;) ok21:29
*** kzaitsev_mb has joined #openstack-horizon21:29
lapalmdavid-lyle working on it now21:30
david-lylekfox1111: remember when I said the modal code scared me?21:30
david-lyle:D21:30
*** KunalGandhi has joined #openstack-horizon21:30
lapalmdavid-lyle give me a few mins and ill link you21:30
david-lylelapalm: sure21:30
david-lylehmm fishy21:31
* david-lyle testing a theory21:32
*** tjones has left #openstack-horizon21:32
david-lyleok, theory disproven21:32
tsufievr1chardj0n3s, yep, playing with black django metaclass magic21:33
r1chardj0n3stsufiev: ohai, I just added a comment to the login bug21:33
mhickeylhcheng: got your comments, thanks. Make more sense now. I will give it a go tomorrow. Heading off to bed. Bye.21:35
tsufievr1chardj0n3s, personally I tried to replace id = AutoField(primary_key=True) inside User with another field inside overriden metaclass21:37
tsufievbut have just failed21:38
lhchengmhickey: ttyl21:38
r1chardj0n3sI tried that too :)21:38
r1chardj0n3sI should have noted that Django prevents such things21:38
tsufievI'm afraid if I finally had done this, there would be 2-3 persons in around that could understand what's happening21:39
* tsufiev bragging21:39
tsufievbut I hadn't ))21:39
openstackgerritBradley Jones proposed openstack/horizon: Add Curvature topology  https://review.openstack.org/14107821:39
*** vgridnev has quit IRC21:39
*** mhickey has quit IRC21:39
r1chardj0n3soh, no, I did note that you can't change the type of the PK21:40
r1chardj0n3sin the bug21:40
r1chardj0n3sso yeah21:40
r1chardj0n3sI've looked a a bunch of options for fixing it and I realise the monkey-patch isn't elegant but it's the only feasible option out of the four I thought of21:41
r1chardj0n3s(and also DOA already monkey-patches Django for other places it breaks it so ... yeah)21:41
*** geoffarnold has quit IRC21:41
lapalmdavid-lyle https://bugs.launchpad.net/horizon/+bug/149450321:41
openstackLaunchpad bug 1494503 in OpenStack Dashboard (Horizon) "Launch Instance button does not open the corresponding workflow on network topology page" [Undecided,New]21:41
lapalmdavid-lyle all yours21:42
david-lylelapalm: thanks!21:42
bradjonesducttape_, david-lyle: pushed up my fixes for larger deployment, I'm going to be afk  for 30 mins  so if you have questions please leave on the review21:42
tsufievr1chardj0n3s, okay, seems to be least evil21:42
* r1chardj0n3s has to do dad stuff for a while21:42
lapalmdavid-lyle Do you have any idea how to fix that/ what is going on?21:43
*** geoffarnold has joined #openstack-horizon21:44
david-lylelapalm: I updated the bug21:49
david-lylesomething in the modal handling code21:49
ducttape_sweet -thanks bradjones21:49
*** jingjing_ren has quit IRC21:49
*** shivrao has quit IRC21:50
lapalmdavid-lyle interesting...21:51
lapalmdavid-lyle Thanks for help though21:52
lapalmdavid-lyle I mean, your welcome for the bug find21:52
lapalmdavid-lyle ;)21:52
david-lylelapalm: glad you found it21:52
*** lapalm has quit IRC21:53
david-lylepulling the uncompressed js files down sure has gotten quicker >.<21:58
*** jingjing_ren has joined #openstack-horizon21:59
*** shivrao has joined #openstack-horizon22:00
*** Piet has joined #openstack-horizon22:05
*** ducttape_ has quit IRC22:07
*** erlon has quit IRC22:08
*** jbell8 has quit IRC22:09
*** vijendar has quit IRC22:09
*** geoffarnold has quit IRC22:09
*** ducttape_ has joined #openstack-horizon22:11
*** asahlin has quit IRC22:12
openstackgerritMerged openstack/horizon: Launch instance create volume fails  https://review.openstack.org/22200822:16
*** TravT_ is now known as TravT22:17
*** jpomeroy has quit IRC22:19
tsufievr1chardj0n3s, I attached the patch with my unfortunate attempt with metaclasses to the bug22:21
tsufievperhaps someone more stubborn than me would be luckier :)22:22
tsufievgood night, all22:22
doug-fishnight tsufiev22:23
r1chardj0n3snight tsufiev22:23
david-lylenight tsufiev22:23
*** geoffarnold has joined #openstack-horizon22:24
*** jbell8 has joined #openstack-horizon22:24
*** rhagarty__ has quit IRC22:26
*** doug-fish has quit IRC22:27
*** neelashah has quit IRC22:28
bradjonesducttape_: your comment about no networks, were you testing without even a public net?22:31
ducttape_there is a public net, but no tenant network setup, no tenant router, etc22:34
bradjonesI just tested a topology that just had a public net and it works as expected22:35
openstackgerritRichard Hagarty proposed openstack/horizon: Unable to attach volume to instance  https://review.openstack.org/22239022:35
ducttape_bradjones - what did it show???22:36
bradjonesJust the public network22:36
ducttape_if you have no network, no instances.... it shows something?22:36
ducttape_hmm. ok22:36
*** asahlin has joined #openstack-horizon22:37
*** saksham has quit IRC22:38
bradjonesah OK I managed to recreate the issue22:38
*** linkmark has quit IRC22:38
ducttape_which issue?22:39
ducttape_the disconnected networks, or empty list of networks?22:39
david-lylethe issue22:39
*** jpomeroy has joined #openstack-horizon22:39
* ducttape_ throws something sharp at david-lyle22:39
bradjonesempty list of networks, just by creating a new project22:39
* david-lyle enjoys helping22:39
ducttape_ah yeah.  cool22:39
ducttape_david-lyle - sarcastic or wise ass comments are not enjoyed in my neck of the woods.  100% business time around these parts22:40
david-lylehaha22:40
* ducttape_ checks if the microphone is turned on22:40
bradjonesI'll add a check in for the network list for that case22:40
ducttape_cool, thanks bradjones22:41
bradjonesducttape_: check not necessary I just mistyped the variable name :(22:45
bradjonesshould be publicnet not network22:45
* bradjones facepalm22:45
openstackgerritBradley Jones proposed openstack/horizon: Add Curvature topology  https://review.openstack.org/14107822:47
ducttape_perfect, was just going to ask ;)22:47
bradjonesstill not sure how to recreate the disconnected networks though22:49
ducttape_ok.  am testing again with the 4 networks, will also test the empty tenant22:49
bradjonesawesome thanks22:49
ducttape_bad news:  still have 4 disconnect networks    good news:  the empty tenant now gracefully displays only the single node22:51
ducttape_the ext-net that is22:51
*** mpavlase has quit IRC22:53
bradjoneswell I guess that is something22:53
bradjonescan you post the JSON blob somewhere so I can try see what is different in your setup to mine22:54
ducttape_yep, it's measurably better ;)22:54
ducttape_sure, can do.  I'm retrying with developer console to see if that is spewing anything of interest22:54
ducttape_I might have it22:55
openstackgerritKyle Olivo proposed openstack/horizon: WIP: Add volumes panel that uses angular.js  https://review.openstack.org/21677822:56
ducttape_does this pending network call look like a problem?  http://pasteboard.co/xU2P3B3.png22:56
ducttape_bradjones ^22:56
ducttape_b/c it stays stuck in pending22:56
bradjonesthat is the poll of the JSON to get updates22:57
bradjonesshouldn't be a problem because all the data about the network connections should be in the first JSON blob22:58
ducttape_so that http get is a constant stream / never completes ?22:59
bradjonesno it should definitely complete23:00
bradjoneslooks like the first call took just over a minute so that other one should complete a minute later and so on23:01
ducttape_it does not complete, opening it with chrome in separate tab23:01
*** kzaitsev_mb has quit IRC23:01
*** kyleolivo has quit IRC23:02
*** jingjing_ren has quit IRC23:04
bradjoneswell that doesn't sound right!23:05
bradjonesthe time of those requests is quite long too23:05
openstackgerritRajat Vig proposed openstack/horizon: JSCS Cleanup - Rename launch instance model file  https://review.openstack.org/21792223:05
ducttape_it finally returned23:05
ducttape_I am just not very patient23:05
*** saksham has joined #openstack-horizon23:06
bradjonesover a minute is a long time for that to return, mine is about 20 seconds with 104 vms23:06
bradjonesI assume that is just down to hardware/network differences though23:07
ducttape_I have horizon on my laptop /vm... and controll nodes are a real / larger cloud accross the vpn23:07
*** tjones has joined #openstack-horizon23:07
*** saksham has quit IRC23:07
*** tjones has left #openstack-horizon23:08
ducttape_we like to complain about our network slowness here, but I'm sure we are the only people to ever do that23:08
bradjonesducttape_: with a smaller topology (say 5-10 vms per network) do the networks still disconnect for you?23:11
*** saksham has joined #openstack-horizon23:12
ducttape_I think they work then23:13
bradjonesOK, I will rebuild my deployment try a few more things out23:14
ducttape_I'll try again, but will likely be tomorrow, and I know it's later for you23:15
*** geoffarnold has quit IRC23:15
bradjonesducttape_: yeah no worries, will have something else for you to try by morning your time23:16
*** ducttape_ has quit IRC23:23
*** cloudtra_ has quit IRC23:28
*** asahlin has quit IRC23:28
*** mwhagedorn has quit IRC23:29
*** rhagarty__ has joined #openstack-horizon23:35
*** ZZelle_ has quit IRC23:35
*** kyleolivo has joined #openstack-horizon23:38
*** yamamoto has joined #openstack-horizon23:48
gyeedavid-lyle, around?23:48
david-lylegyee, yah23:48
gyeeTrue or Fase? "it was possible to integrate Horizon with an external authentication service."23:49
gyeeI mean besides WebSSO via Federation23:50
*** aix has quit IRC23:53
*** ybathia has quit IRC23:54
*** geoffarnold has joined #openstack-horizon23:55
*** rhagarty__ has quit IRC23:55
*** Sukhdev has joined #openstack-horizon23:58
david-lylegyee just a sec, phone23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!