| *** shivrao has quit IRC | 00:10 | |
| *** stevemar has quit IRC | 00:13 | |
| *** cloudtrainme has quit IRC | 00:13 | |
| *** kzaitsev_mb has quit IRC | 00:34 | |
| *** lhcheng has joined #openstack-horizon | 00:34 | |
| *** hurgleburgler has quit IRC | 00:44 | |
| *** chlong has joined #openstack-horizon | 00:55 | |
| *** sambetts has joined #openstack-horizon | 00:57 | |
| *** zhenguo has joined #openstack-horizon | 01:24 | |
| *** Daisy has joined #openstack-horizon | 01:28 | |
| *** Daisy has quit IRC | 01:28 | |
| *** Daisy has joined #openstack-horizon | 01:29 | |
| *** Daisy has quit IRC | 01:33 | |
| *** Daisy has joined #openstack-horizon | 01:33 | |
| *** Daisy has quit IRC | 01:37 | |
| *** aix_ has joined #openstack-horizon | 01:41 | |
| *** aix has quit IRC | 01:42 | |
| *** linkedinyou has quit IRC | 01:47 | |
| *** chlong has quit IRC | 01:49 | |
| openstackgerrit | Allen proposed openstack/horizon: Add cancel button to all wizard workflow https://review.openstack.org/209399 | 01:49 |
|---|---|---|
| openstackgerrit | Richard Jones proposed openstack/horizon: Fix the selenium LazyLoadedTabsTests https://review.openstack.org/215408 | 01:52 |
| r1chardj0n3s | selenium tests are now back in the gate non-voting | 01:52 |
| *** shivrao has joined #openstack-horizon | 01:56 | |
| *** lyanchih has joined #openstack-horizon | 02:05 | |
| *** shivrao has quit IRC | 02:11 | |
| *** yamamoto has quit IRC | 02:12 | |
| *** Daisy has joined #openstack-horizon | 02:15 | |
| *** cloudtrainme has joined #openstack-horizon | 02:20 | |
| *** liangbo has joined #openstack-horizon | 02:23 | |
| *** zhurong has joined #openstack-horizon | 02:24 | |
| *** lhcheng has quit IRC | 02:25 | |
| *** stevemar has joined #openstack-horizon | 02:25 | |
| *** stevemar has quit IRC | 02:30 | |
| *** zhurong_ has joined #openstack-horizon | 02:31 | |
| *** Daisy has quit IRC | 02:32 | |
| *** cloudtrainme has quit IRC | 02:32 | |
| *** Daisy has joined #openstack-horizon | 02:32 | |
| openstackgerrit | Allen proposed openstack/horizon: Correct the wrong url in "Manage QoS Spec Association" https://review.openstack.org/218704 | 02:34 |
| *** zhurong has quit IRC | 02:34 | |
| *** Daisy_ has joined #openstack-horizon | 02:35 | |
| *** Daisy has quit IRC | 02:37 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Update Users Table to single HTML https://review.openstack.org/217879 | 02:52 |
| *** yamamoto has joined #openstack-horizon | 02:58 | |
| *** jroll has quit IRC | 03:26 | |
| *** Samos123 has quit IRC | 03:27 | |
| *** Samos123 has joined #openstack-horizon | 03:27 | |
| *** shivrao has joined #openstack-horizon | 03:31 | |
| *** jroll has joined #openstack-horizon | 03:31 | |
| *** Daisy_ has quit IRC | 03:36 | |
| *** Daisy has joined #openstack-horizon | 03:37 | |
| *** Daisy has quit IRC | 03:41 | |
| *** lhcheng has joined #openstack-horizon | 03:42 | |
| *** Piet has joined #openstack-horizon | 03:45 | |
| *** Piet has quit IRC | 03:45 | |
| *** Piet has joined #openstack-horizon | 03:45 | |
| openstackgerrit | Allen proposed openstack/horizon: Correct wrong cancel action url in Extra Specs page https://review.openstack.org/218713 | 03:46 |
| *** Piet has quit IRC | 03:48 | |
| *** Piet has joined #openstack-horizon | 03:48 | |
| *** lawrance_ has joined #openstack-horizon | 03:50 | |
| *** Piet has quit IRC | 03:50 | |
| *** cody-somerville has joined #openstack-horizon | 03:50 | |
| *** cody-somerville has quit IRC | 03:50 | |
| *** cody-somerville has joined #openstack-horizon | 03:50 | |
| *** Piet has joined #openstack-horizon | 03:50 | |
| *** Piet has quit IRC | 03:53 | |
| *** Piet has joined #openstack-horizon | 03:55 | |
| *** garthb has joined #openstack-horizon | 03:55 | |
| *** Piet has quit IRC | 03:56 | |
| *** jtriley has joined #openstack-horizon | 03:56 | |
| *** Piet has joined #openstack-horizon | 03:56 | |
| *** Piet has quit IRC | 03:59 | |
| *** lyanchih has quit IRC | 04:01 | |
| *** jtriley has quit IRC | 04:11 | |
| *** jtriley has joined #openstack-horizon | 04:18 | |
| *** stevemar has joined #openstack-horizon | 04:23 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Correct usage of angular.element https://review.openstack.org/218722 | 04:25 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Correct usage of angular.element https://review.openstack.org/218722 | 04:25 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Correct usage of angular.element https://review.openstack.org/218722 | 04:28 |
| *** zhurong_ has quit IRC | 04:34 | |
| *** jtriley has quit IRC | 04:35 | |
| *** Daisy has joined #openstack-horizon | 04:36 | |
| *** zhurong has joined #openstack-horizon | 04:43 | |
| *** Sukhdev has joined #openstack-horizon | 04:56 | |
| *** ig0r__ has joined #openstack-horizon | 04:59 | |
| *** ig0r_ has quit IRC | 04:59 | |
| *** lyanchih has joined #openstack-horizon | 05:11 | |
| *** liangbo has quit IRC | 05:14 | |
| *** Daisy has quit IRC | 05:15 | |
| *** shivrao has quit IRC | 05:15 | |
| *** Daisy has joined #openstack-horizon | 05:15 | |
| *** shivrao has joined #openstack-horizon | 05:15 | |
| *** Daisy has quit IRC | 05:20 | |
| *** Daisy has joined #openstack-horizon | 05:23 | |
| openstackgerrit | Amogh proposed openstack/horizon: Integration tests - Instances tests https://review.openstack.org/117091 | 05:24 |
| *** shivrao has quit IRC | 05:30 | |
| *** Daisy has quit IRC | 05:31 | |
| *** Daisy has joined #openstack-horizon | 05:32 | |
| *** lyanchih has quit IRC | 05:34 | |
| *** garthb has quit IRC | 05:35 | |
| *** Daisy has quit IRC | 05:36 | |
| openstackgerrit | Frode Nordahl proposed openstack/horizon: Support create subnet w/Neutron subnet allocation https://review.openstack.org/203570 | 05:43 |
| *** lhcheng has quit IRC | 05:57 | |
| *** liangbo has joined #openstack-horizon | 05:58 | |
| *** masco has joined #openstack-horizon | 06:02 | |
| masco | good morning :) | 06:02 |
| *** Daisy has joined #openstack-horizon | 06:03 | |
| *** Daisy has quit IRC | 06:08 | |
| *** Daisy has joined #openstack-horizon | 06:08 | |
| *** lyanchih has joined #openstack-horizon | 06:09 | |
| *** stevemar has quit IRC | 06:15 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/218628 | 06:17 |
| *** Daisy has quit IRC | 06:18 | |
| r1chardj0n3s | good afternoon masco :) | 06:21 |
| *** lhcheng has joined #openstack-horizon | 06:21 | |
| *** stevemar has joined #openstack-horizon | 06:29 | |
| fnordahl | The gate/integration tests seems to currently be failing on ERROR: test_routerrule_detail (openstack_dashboard.dashboards.project.routers.tests.RouterRuleTests) | 06:39 |
| fnordahl | I have created a bug here: https://bugs.launchpad.net/horizon/+bug/1490403 | 06:39 |
| openstack | Launchpad bug 1490403 in OpenStack Dashboard (Horizon) "Gate failing on test_routerrule_detail" [Undecided,New] | 06:39 |
| fnordahl | Attempting to investigate. Anyone else hit by this? | 06:40 |
| *** mrunge has joined #openstack-horizon | 06:40 | |
| openstackgerrit | Allen proposed openstack/horizon: Add cancel button to all wizard workflow https://review.openstack.org/209399 | 06:45 |
| *** zz_ttrifonov is now known as ttrifonov | 06:53 | |
| *** stevemar has quit IRC | 06:53 | |
| *** Daisy has joined #openstack-horizon | 06:59 | |
| *** Sukhdev has quit IRC | 07:00 | |
| *** stevemar has joined #openstack-horizon | 07:00 | |
| *** liangbo has quit IRC | 07:02 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: Replace SortedDict with OrderedDict https://review.openstack.org/212399 | 07:02 |
| *** Daisy has quit IRC | 07:03 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: Replace SortedDict with OrderedDict https://review.openstack.org/212399 | 07:07 |
| *** peristeri has joined #openstack-horizon | 07:09 | |
| *** jtomasek has quit IRC | 07:11 | |
| *** jtomasek has joined #openstack-horizon | 07:11 | |
| *** gparaskevas has joined #openstack-horizon | 07:12 | |
| *** gparaskevas has quit IRC | 07:16 | |
| *** lhcheng has quit IRC | 07:16 | |
| *** Daisy has joined #openstack-horizon | 07:23 | |
| *** mpavlase has joined #openstack-horizon | 07:24 | |
| *** romainh has joined #openstack-horizon | 07:27 | |
| *** Ala has joined #openstack-horizon | 07:33 | |
| *** bfic has joined #openstack-horizon | 07:44 | |
| *** rdopiera has joined #openstack-horizon | 07:47 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: filter doesn't handle unicode character https://review.openstack.org/211850 | 07:49 |
| *** liangbo has joined #openstack-horizon | 07:49 | |
| *** Daisy has quit IRC | 07:54 | |
| *** ttrifonov is now known as zz_ttrifonov | 08:11 | |
| openstackgerrit | svasheka proposed openstack/horizon: Add _save_screenshot functionality to helpers. https://review.openstack.org/194646 | 08:12 |
| *** kiran-r has joined #openstack-horizon | 08:15 | |
| *** akrivoka has joined #openstack-horizon | 08:21 | |
| *** zz_ttrifonov is now known as ttrifonov | 08:22 | |
| *** Daisy has joined #openstack-horizon | 08:25 | |
| *** Daisy has quit IRC | 08:30 | |
| *** aix_ has quit IRC | 08:32 | |
| *** aix has joined #openstack-horizon | 08:33 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: Adding informative message when deleting a using volume type https://review.openstack.org/213709 | 08:34 |
| openstackgerrit | Frode Nordahl proposed openstack/horizon: Improve check for if cidrs are affected by rule https://review.openstack.org/218763 | 08:34 |
| *** amotoki has joined #openstack-horizon | 08:41 | |
| *** Daisy has joined #openstack-horizon | 08:42 | |
| *** liangbo has quit IRC | 08:46 | |
| *** kzaitsev_mb has joined #openstack-horizon | 08:49 | |
| *** Daisy has quit IRC | 08:55 | |
| *** Daisy has joined #openstack-horizon | 08:55 | |
| *** Daisy has quit IRC | 08:56 | |
| *** Daisy has joined #openstack-horizon | 08:56 | |
| *** ttrifonov is now known as zz_ttrifonov | 08:58 | |
| *** bfic has quit IRC | 08:58 | |
| *** e0ne has joined #openstack-horizon | 08:58 | |
| *** bfic has joined #openstack-horizon | 09:00 | |
| tsufiev | fnordahl, that's unit tests, not integration | 09:00 |
| openstackgerrit | Janet Yu proposed openstack/horizon: Refactor DataTable filtering functions into mixin https://review.openstack.org/217020 | 09:01 |
| openstackgerrit | Janet Yu proposed openstack/horizon: Provide option to create images by importing data https://review.openstack.org/218773 | 09:01 |
| fnordahl | tsufiev: of course. sorry for the mixup. | 09:01 |
| fnordahl | I believe this proposal fixes the current problems with unit tests blocking: https://review.openstack.org/#/c/218763/1 | 09:01 |
| tsufiev | fnordahl, I'm a bit relieved that weren't integartion tests because I'd hate to see them broken again ) | 09:02 |
| fnordahl | tsufiev: it was not my intention to scare anyone! 8-| I will guard my words more carefully in the future :-) | 09:02 |
| tsufiev | fnordahl, no worries! Will take a look at your fix, though it's not my domain of expertise | 09:03 |
| *** liangbo has joined #openstack-horizon | 09:03 | |
| fnordahl | Not sure why that test suddenly started to fail though, maby the test data has been changed. | 09:04 |
| *** tosky has joined #openstack-horizon | 09:04 | |
| tsufiev | fnordahl, you may want to contact amotoki on this issue | 09:05 |
| amotoki | tsufiev: fnordahl: actually I am not sure the reason of the check you are fixing in 218763. | 09:06 |
| amotoki | because this feature is specific to neutron bigswitch plugin. | 09:06 |
| fnordahl | unit tests are blocking the gate | 09:07 |
| fnordahl | https://bugs.launchpad.net/horizon/+bug/1490403 | 09:07 |
| openstack | Launchpad bug 1490403 in OpenStack Dashboard (Horizon) "Gate failing on test_routerrule_detail" [Undecided,In progress] - Assigned to Frode Nordahl (fnordahl) | 09:07 |
| *** e0ne has quit IRC | 09:09 | |
| amotoki | fnordahl: I know, but what I am not sure is whether we should change the code itself to fix the gate problem. | 09:09 |
| *** e0ne has joined #openstack-horizon | 09:09 | |
| amotoki | can't we skip the test? | 09:09 |
| fnordahl | understand. yes, that may maybe be a better sollution. I don't know how to go about skipping the tests though. | 09:10 |
| *** bluex-pl has joined #openstack-horizon | 09:10 | |
| amotoki | fnordahl: regarding bug 1490403, test_routerrule_detail is failing. What you need to do is just to add @skipTest decorator to the test. | 09:11 |
| openstack | bug 1490403 in OpenStack Dashboard (Horizon) "Gate failing on test_routerrule_detail" [Undecided,In progress] https://launchpad.net/bugs/1490403 - Assigned to Frode Nordahl (fnordahl) | 09:11 |
| fnordahl | I'm on it. | 09:13 |
| *** bluex-pl has quit IRC | 09:14 | |
| amotoki | fnordahl: I think @skip() can be used: https://docs.python.org/2.7/library/unittest.html#skipping-tests-and-expected-failures | 09:14 |
| *** bluex-pl has joined #openstack-horizon | 09:14 | |
| *** kzaitsev_mb has quit IRC | 09:17 | |
| *** Daisy has quit IRC | 09:20 | |
| *** Daisy has joined #openstack-horizon | 09:20 | |
| openstackgerrit | Zhenguo Niu proposed openstack/horizon: Move volume types Forms out of volumes https://review.openstack.org/218779 | 09:24 |
| *** Daisy has quit IRC | 09:25 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Add _save_screenshot functionality to helpers. https://review.openstack.org/194646 | 09:25 |
| *** kodokuu has joined #openstack-horizon | 09:25 | |
| kodokuu | Hi, I have little issue with horizon. I can't see img on HEAT because url is http://horizon/static/dashboard/img/unknown-gray.svg ... missing http://horizon/***dashboard***/static...... | 09:26 |
| *** zhurong has quit IRC | 09:27 | |
| *** zhurong has joined #openstack-horizon | 09:27 | |
| *** zhurong has quit IRC | 09:27 | |
| *** bfic has quit IRC | 09:29 | |
| mrunge | kodokuu, easy solution would be, to add another Alias to your webserver config | 09:29 |
| *** zhurong has joined #openstack-horizon | 09:31 | |
| kodokuu | mrunge I have two alias : nameserver and localhost | 09:31 |
| kodokuu | But I can see logo.png or logo-splash.png | 09:32 |
| kodokuu | just heat img not works :/ | 09:32 |
| *** Daisy has joined #openstack-horizon | 09:32 | |
| *** Daisy has quit IRC | 09:32 | |
| *** Daisy has joined #openstack-horizon | 09:33 | |
| mrunge | kodokuu, no I meant: Alias /static "/usr/share/openstack-dashboard/static" | 09:33 |
| mrunge | add that to your dashboard configuration | 09:33 |
| kodokuu | ha | 09:34 |
| *** Daisy_ has joined #openstack-horizon | 09:35 | |
| kodokuu | works | 09:36 |
| kodokuu | thx | 09:36 |
| *** ig0r_ has joined #openstack-horizon | 09:37 | |
| *** Daisy has quit IRC | 09:37 | |
| *** zhurong has quit IRC | 09:38 | |
| *** rdopiera has quit IRC | 09:38 | |
| *** ig0r__ has quit IRC | 09:39 | |
| *** Daisy_ has quit IRC | 09:39 | |
| openstackgerrit | Frode Nordahl proposed openstack/horizon: Skip test_routerrule_detail blocking the gate https://review.openstack.org/218786 | 09:42 |
| fnordahl | ^ This proposal fixes the current unittest/gate-block | 09:42 |
| *** wimdc has joined #openstack-horizon | 09:43 | |
| *** aix has quit IRC | 09:49 | |
| *** sayan has joined #openstack-horizon | 09:50 | |
| *** romainh has quit IRC | 09:50 | |
| openstackgerrit | Wim De Clercq proposed openstack/horizon: Add allowed address pair extension UI for neutron ports. https://review.openstack.org/193079 | 09:57 |
| *** tnovacik has joined #openstack-horizon | 09:58 | |
| wimdc | is stable/juno (I know, old) still supposed to work just like that? I think I'm having issues with oslo.utils on start ( No module named utils) ... it should all work with virtualenv right? What's on my system has no effect afaik? | 10:06 |
| *** lawrance_ has quit IRC | 10:08 | |
| *** zhurong has joined #openstack-horizon | 10:11 | |
| mrunge | wimdc, where did you get oslo.utils from? | 10:13 |
| mrunge | I know, oslo messed up the sate of juno for a longer time | 10:14 |
| mrunge | there might (should) be a cap required | 10:14 |
| openstackgerrit | Zhenguo Niu proposed openstack/horizon: Add Ironic hypervisor settings to hide some unsupported actions https://review.openstack.org/215419 | 10:15 |
| wimdc | mrunge, I think the oslo requirements are part of the clients that horizon installs | 10:17 |
| mrunge | wimdc, yes | 10:17 |
| *** aix has joined #openstack-horizon | 10:18 | |
| *** linkedinyou has joined #openstack-horizon | 10:20 | |
| *** zhurong has quit IRC | 10:23 | |
| *** kzaitsev_mb has joined #openstack-horizon | 10:27 | |
| amotoki | python clients should have appropriate version cap, but many python clients have no stable branch for juno. | 10:28 |
| wimdc | mrunge, It's happening at keystoneclient .venv/local/lib/python2.7/site-packages/keystoneclient/access.py", line 20, | 10:29 |
| wimdc | pip says I got keystoneclient 1.1.1, and in the file above it has from oslo.utils import timeutils | 10:29 |
| mrunge | sigh, so keystoneclient needs to get a cap | 10:30 |
| mrunge | wimdc, unfortunately, speaking from OpenStack standpoint, Juno is dead | 10:30 |
| mrunge | developers don't care about it any more | 10:31 |
| amotoki | very minimum workaround is to add oslo.utils oslo.i18n oslo.config to horizon requirements.txt | 10:33 |
| *** bluex-pl has quit IRC | 10:34 | |
| amotoki | wimdc: as you already said, horizon has correct version requiremetns for client libs, but client libs do not have appropriate version cap in their requirements. | 10:35 |
| amotoki | wimdc: minimum workarond is to add: | 10:36 |
| wimdc | yea, it seems to be keystone. Gonna try to rerun horizon now but I set all the clients to == the lowest number in requirements | 10:36 |
| -amotoki- +oslo.config>=1.4.0,<=1.6.1 | 10:36 | |
| -amotoki- +oslo.i18n>=1.0.0,<=1.3.1 | 10:36 | |
| -amotoki- +oslo.utils>=1.4.0,<1.5.0 | 10:36 | |
| amotoki | keystoneclient 1.1.1 is a correct requirement. | 10:36 |
| wimdc | yea, install just finished same result. I'll try your 3 lines :p | 10:36 |
| *** lyanchih has quit IRC | 10:38 | |
| *** Drago has quit IRC | 10:39 | |
| amotoki | the problem is not limited to keystoneclient. ceilometerclient has the same. I didn't checked others but they must have. | 10:39 |
| *** yingjun has joined #openstack-horizon | 10:42 | |
| wimdc | it works with the extra oslo lines :) | 10:43 |
| *** bluex-pl has joined #openstack-horizon | 10:49 | |
| *** jprovazn has joined #openstack-horizon | 10:54 | |
| *** jtomasek has quit IRC | 10:59 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Pay attention to Nova disabled quotas defined in a config file https://review.openstack.org/215277 | 11:00 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Pay attention to Nova disabled quotas defined in a config file https://review.openstack.org/215277 | 11:00 |
| *** bluex-pl has quit IRC | 11:03 | |
| *** bluex-pl has joined #openstack-horizon | 11:03 | |
| *** bluex-pl has quit IRC | 11:09 | |
| *** e0ne has quit IRC | 11:10 | |
| *** yingjun has quit IRC | 11:16 | |
| *** stevemar has quit IRC | 11:22 | |
| *** jcoufal has joined #openstack-horizon | 11:28 | |
| amotoki | fnordahl: your first patch for the gate issue looks good in general. Sorry for putting -1 in hurry. Your first one loosk good and I would like to check it carefully. | 11:32 |
| amotoki | fnordahl: anyway it is better to skip the test first. Could you restore your original one too? | 11:32 |
| openstackgerrit | Ivan Udovichenko proposed stackforge/xstatic-bootstrap-datepicker: Add new version 1.4.0.0 https://review.openstack.org/218661 | 11:35 |
| *** amotoki has quit IRC | 11:39 | |
| *** bfic has joined #openstack-horizon | 11:39 | |
| *** amotoki has joined #openstack-horizon | 11:39 | |
| *** Daisy has joined #openstack-horizon | 11:40 | |
| *** lawrancejing has joined #openstack-horizon | 11:42 | |
| *** zhurong has joined #openstack-horizon | 11:42 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix for the broken header's dropdowns for both v0.11.2 and v0.13 https://review.openstack.org/218815 | 11:42 |
| *** Daisy has quit IRC | 11:42 | |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon: Skip test_routerrule_detail blocking the gate https://review.openstack.org/218786 | 11:43 |
| *** Daisy has joined #openstack-horizon | 11:43 | |
| *** kzaitsev_mb has quit IRC | 11:44 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix for the broken header's dropdowns for both v0.11.2 and v0.13 https://review.openstack.org/218815 | 11:45 |
| *** openstackgerrit has quit IRC | 11:46 | |
| *** jtomasek has joined #openstack-horizon | 11:46 | |
| *** openstackgerrit has joined #openstack-horizon | 11:47 | |
| wimdc | Is something wrong with the gate-horizon-python27 jenkins check? | 11:54 |
| wimdc | It seems to fail with the same errors on multiple patch sets | 11:55 |
| *** kzaitsev_mb has joined #openstack-horizon | 11:56 | |
| *** jtomasek has quit IRC | 11:56 | |
| *** jtomasek has joined #openstack-horizon | 11:56 | |
| masco | wimdc, yep, there is patch for the issue https://review.openstack.org/218786 | 11:58 |
| masco | wait till the patch get merge | 11:59 |
| wimdc | okay | 11:59 |
| openstackgerrit | svasheka proposed openstack/horizon: Add _save_screenshot functionality to helpers. https://review.openstack.org/194646 | 11:59 |
| *** e0ne has joined #openstack-horizon | 11:59 | |
| fnordahl | amotoki: restored. thank you for fixing the related-bug in my commit msg on the other one. | 12:00 |
| *** petertr7_away is now known as petertr7 | 12:09 | |
| *** romainh has joined #openstack-horizon | 12:09 | |
| *** bluex-pl has joined #openstack-horizon | 12:09 | |
| *** yingjun has joined #openstack-horizon | 12:15 | |
| *** yingjun has quit IRC | 12:21 | |
| *** yingjun has joined #openstack-horizon | 12:21 | |
| *** rdopiera has joined #openstack-horizon | 12:24 | |
| *** yingjun has quit IRC | 12:26 | |
| *** mhorban has quit IRC | 12:26 | |
| openstackgerrit | Sean Dague proposed openstack/horizon: Added cancel button in add rule modal https://review.openstack.org/207800 | 12:27 |
| *** Daisy has quit IRC | 12:32 | |
| *** Daisy has joined #openstack-horizon | 12:32 | |
| *** kodokuu has quit IRC | 12:33 | |
| *** crobertsrh has joined #openstack-horizon | 12:34 | |
| *** mhorban has joined #openstack-horizon | 12:36 | |
| *** lapalm has joined #openstack-horizon | 12:36 | |
| *** Daisy has quit IRC | 12:37 | |
| openstackgerrit | Ivan Udovichenko proposed stackforge/xstatic-bootstrap-datepicker: Add new version 1.4.0.0 https://review.openstack.org/218661 | 12:47 |
| *** JeanBriceCombebi has joined #openstack-horizon | 12:50 | |
| *** cbader has joined #openstack-horizon | 12:58 | |
| *** h0mer has joined #openstack-horizon | 12:59 | |
| h0mer | anyone here ever run into this problem with the openstack dashboard? "An error occurred authenticating. Please try again later." | 13:00 |
| *** cloudtrainme has joined #openstack-horizon | 13:00 | |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Moving translation to HTML for launch-instance key pair step https://review.openstack.org/215740 | 13:01 |
| *** bluex-pl has quit IRC | 13:13 | |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Moving translation to HTML for launch-instance key pair step https://review.openstack.org/215740 | 13:16 |
| *** jpomeroy has quit IRC | 13:16 | |
| *** jcoufal has quit IRC | 13:17 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: admin not able to set maintenance state for volume https://review.openstack.org/218848 | 13:17 |
| mrunge | h0mer, that can have many reasons | 13:20 |
| *** liangbo has quit IRC | 13:21 | |
| mrunge | h0mer, is are you able to reach keystone? It would be good to have a look at keystone logs | 13:21 |
| mrunge | h0mer, and/or horizon logs | 13:21 |
| *** e0ne has quit IRC | 13:22 | |
| *** e0ne has joined #openstack-horizon | 13:29 | |
| *** mtanino has joined #openstack-horizon | 13:30 | |
| *** bfic has left #openstack-horizon | 13:30 | |
| *** jcoufal has joined #openstack-horizon | 13:30 | |
| *** jcoufal has quit IRC | 13:31 | |
| *** jcoufal has joined #openstack-horizon | 13:32 | |
| *** jpomeroy has joined #openstack-horizon | 13:33 | |
| tsufiev | fnordahl, Re: [openstack-dev] [Neutron] [horizon] Netaddr 0.7.16 and gate breakage in ML, seems to be the thing you're trying to fix | 13:33 |
| *** stevemar has joined #openstack-horizon | 13:34 | |
| *** doug-fish has joined #openstack-horizon | 13:39 | |
| *** stevemar has quit IRC | 13:39 | |
| *** lblanchard has joined #openstack-horizon | 13:41 | |
| *** cloudtrainme has quit IRC | 13:42 | |
| *** cloudtrainme has joined #openstack-horizon | 13:46 | |
| *** kiran-r has quit IRC | 13:48 | |
| *** rdopiera has quit IRC | 13:50 | |
| *** rdopiera has joined #openstack-horizon | 13:51 | |
| *** rdopiera has quit IRC | 13:51 | |
| *** rdopiera has joined #openstack-horizon | 13:52 | |
| *** cloudtrainme has quit IRC | 14:03 | |
| *** rdopiera has quit IRC | 14:03 | |
| openstackgerrit | Ivan Udovichenko proposed stackforge/xstatic-bootstrap-datepicker: Add new version 1.4.0.0 https://review.openstack.org/218661 | 14:03 |
| *** rdopiera has joined #openstack-horizon | 14:08 | |
| *** cloudtrainme has joined #openstack-horizon | 14:08 | |
| *** jroll has quit IRC | 14:09 | |
| *** jroll has joined #openstack-horizon | 14:09 | |
| *** Ephur has joined #openstack-horizon | 14:09 | |
| *** lyanchih has joined #openstack-horizon | 14:10 | |
| *** cloudtrainme has quit IRC | 14:18 | |
| *** cloudtrainme has joined #openstack-horizon | 14:20 | |
| *** lawrancejing has quit IRC | 14:21 | |
| *** zhurong has quit IRC | 14:22 | |
| *** sayan has quit IRC | 14:23 | |
| *** vijendar has joined #openstack-horizon | 14:25 | |
| *** cloudtrainme has quit IRC | 14:30 | |
| openstackgerrit | svasheka proposed openstack/horizon: Add _save_screenshot functionality to helpers. https://review.openstack.org/194646 | 14:30 |
| *** cloudtrainme has joined #openstack-horizon | 14:34 | |
| *** cloudtrainme has quit IRC | 14:34 | |
| *** cloudtrainme has joined #openstack-horizon | 14:35 | |
| *** hurgleburgler has joined #openstack-horizon | 14:37 | |
| *** peristeri has quit IRC | 14:38 | |
| amotoki | tsufiev: fnordahl: that's the thread. It mainly affects neutron, but it affects us too. | 14:40 |
| amotoki | tsufiev: fnordahl: it made backward incompat chnages for "broadcast" attribute. 0.7.16 also had a bug in valid_mac, but it was already fixed in 9.7.17. | 14:41 |
| tsufiev | amotoki, seems that it breaks integration tests too. It's quite obvious that floating ip test is related, but regarding keypairs test I'm not so sure | 14:41 |
| tsufiev | yet both tests had been broken at the same time | 14:42 |
| amotoki | tsufiev: thanks. I was not aware that it affects the integration tests. | 14:43 |
| *** jtriley has joined #openstack-horizon | 14:46 | |
| *** garthb has joined #openstack-horizon | 14:47 | |
| *** masco has quit IRC | 14:48 | |
| amotoki | tsufiev: just replied to the thread to describe the situation in Horizon. | 14:48 |
| *** jtriley has quit IRC | 14:48 | |
| *** stevemar has joined #openstack-horizon | 14:48 | |
| *** stevemar has quit IRC | 14:50 | |
| *** petertr7 is now known as petertr7_away | 14:51 | |
| *** Ala has quit IRC | 14:53 | |
| *** jtriley has joined #openstack-horizon | 14:54 | |
| tsufiev | amotoki, me too | 14:54 |
| *** rhagarty__ has joined #openstack-horizon | 14:58 | |
| *** zhurong has joined #openstack-horizon | 14:59 | |
| *** petertr7_away is now known as petertr7 | 14:59 | |
| *** rhagarty__ has quit IRC | 15:02 | |
| *** gyee has joined #openstack-horizon | 15:07 | |
| *** rhagarty__ has joined #openstack-horizon | 15:08 | |
| *** ^Gal^ has quit IRC | 15:09 | |
| *** Drago has joined #openstack-horizon | 15:11 | |
| *** tjones has joined #openstack-horizon | 15:11 | |
| *** tjones has left #openstack-horizon | 15:14 | |
| *** wznoinsk1 is now known as wznoinsk | 15:15 | |
| *** stevemar has joined #openstack-horizon | 15:16 | |
| *** zhurong has quit IRC | 15:19 | |
| *** jtomasek has quit IRC | 15:20 | |
| *** stevemar has quit IRC | 15:21 | |
| *** alanf has joined #openstack-horizon | 15:23 | |
| *** david-ly_ has joined #openstack-horizon | 15:31 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/218905 | 15:31 |
| *** david-ly_ is now known as david-lyle_ | 15:33 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Move the difference function to horizon.util.js https://review.openstack.org/218538 | 15:33 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Adding action to delete multiple images to angular images panel https://review.openstack.org/217422 | 15:33 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix for the broken header's dropdowns for both v0.11.2 and v0.13 https://review.openstack.org/218815 | 15:33 |
| *** david-lyle has quit IRC | 15:33 | |
| *** fedexo has joined #openstack-horizon | 15:34 | |
| *** david-lyle_ is now known as david-lyle | 15:35 | |
| *** ChanServ sets mode: +o david-lyle | 15:35 | |
| mrunge | david-lyle, tsufiev both of you are providing patches to solve the webroot issue in stbale/kilo. could you both please coordinate? | 15:37 |
| mrunge | https://review.openstack.org/#/c/209108/ | 15:37 |
| mrunge | and https://review.openstack.org/217951 | 15:37 |
| *** lyanchih has quit IRC | 15:38 | |
| *** jtomasek has joined #openstack-horizon | 15:39 | |
| david-lyle | mine's newer will abandon | 15:40 |
| tsufiev | mrunge, david-lyle: a plain cherry-pick is better than a combined patch | 15:41 |
| tsufiev | I might remove the appropriate code from my patch | 15:41 |
| tsufiev | might -> am going :) | 15:41 |
| mrunge | tsufiev, I agree | 15:41 |
| david-lyle | ok, I think your structure is a departure anyway and would make further cherry-picks difficult, should they be necessary | 15:41 |
| mrunge | david-lyle, could you pleas wait a bit with abandon? | 15:41 |
| david-lyle | for the heat imgs | 15:41 |
| david-lyle | mrunge: sure | 15:41 |
| mrunge | david-lyle, thanks, and I agree | 15:42 |
| mrunge | I mean, cherry-picks preferred | 15:42 |
| *** rhagarty__ has quit IRC | 15:43 | |
| *** JeanBriceCombebi has quit IRC | 15:43 | |
| *** Piet has joined #openstack-horizon | 15:44 | |
| tsufiev | david-lyle, mrunge: https://review.openstack.org/#/c/209108 is updated | 15:47 |
| mrunge | tsufiev, thank you for the quick fix! | 15:48 |
| tsufiev | hm... david-lyle, I wonder if this https://review.openstack.org/#/c/209108/5/horizon/static/horizon/js/horizon.heattop.js should also be in your patch? | 15:48 |
| mrunge | tsufiev, may I still ask you to break up your patch a bit more? | 15:48 |
| tsufiev | on the second thought, no it isn't - because it's still a cherry-pick | 15:49 |
| david-lyle | tsufiev: no, as you're adding it here https://review.openstack.org/#/c/209108/5/openstack_dashboard/context_processors.py | 15:49 |
| tsufiev | sorry for the noise ) | 15:49 |
| david-lyle | no worries | 15:49 |
| tsufiev | mrunge, what are the proposed pieces? | 15:50 |
| *** amotoki has quit IRC | 15:50 | |
| *** Sukhdev has joined #openstack-horizon | 15:51 | |
| TravT_ | tsufiev: mrunge: maybe i'm not understanding, I don't think you can pure cherry pick the webroot patch. the one in Liberty was built on some other code re-org done. | 15:52 |
| *** TravT_ is now known as TravT | 15:52 | |
| tsufiev | TravT, yes, that's how the angular pieces are backported - I did it by hand | 15:54 |
| TravT | ok, that's what I thought. I was just commenting on mrunge's comment in the patch. | 15:54 |
| tsufiev | TravT, I had just piled all the fixes together, but with David's cherry-pick it made sense to drop the Heat fix out of this pile | 15:55 |
| TravT | ok | 15:55 |
| tsufiev | TravT, it's no difficult to get confused, as every day something new breaks in OpenStack ;) | 15:57 |
| TravT | :S | 15:57 |
| * tsufiev means the recent netaddr issue which broke the gate | 15:57 | |
| *** stevemar has joined #openstack-horizon | 15:57 | |
| TravT | Well, at least the fix isn't up at the top of gate tests now. :S | 15:58 |
| TravT | s/isn't/is | 15:58 |
| kfox1111 | has anyone seen this one: | 15:59 |
| kfox1111 | Compressing... CommandError: An error occured during rendering /usr/share/openstack-dashboard/openstack_dashboard/templates/_stylesheets.html: /bin/sh: horizon.utils.scss_filter.HorizonScssFilter: command not found | 15:59 |
| kfox1111 | showing up on rdo delorean now. | 15:59 |
| kfox1111 | seems to be trying to shell execute a python module. | 15:59 |
| *** jtomasek has quit IRC | 15:59 | |
| *** mpavlase has quit IRC | 16:03 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Adding action to delete multiple images to angular images panel https://review.openstack.org/217422 | 16:04 |
| *** sayali has quit IRC | 16:04 | |
| *** clu_ has joined #openstack-horizon | 16:05 | |
| *** sayali has joined #openstack-horizon | 16:06 | |
| *** lblanchard has quit IRC | 16:09 | |
| *** rajatvig has joined #openstack-horizon | 16:11 | |
| *** kiran-r has joined #openstack-horizon | 16:13 | |
| *** fedexo has quit IRC | 16:15 | |
| *** tqtran has joined #openstack-horizon | 16:17 | |
| *** vishwanathj has joined #openstack-horizon | 16:18 | |
| *** e0ne has quit IRC | 16:20 | |
| *** SimonChung has joined #openstack-horizon | 16:21 | |
| *** TravT has quit IRC | 16:23 | |
| *** TravT has joined #openstack-horizon | 16:24 | |
| *** tqtran is now known as tqtran_ | 16:30 | |
| *** tqtran has joined #openstack-horizon | 16:30 | |
| *** liangbo has joined #openstack-horizon | 16:31 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Create a Angular Modules for Admin Dashboard https://review.openstack.org/214779 | 16:31 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Dashboard Panels should not include SCSS https://review.openstack.org/218941 | 16:31 |
| *** lifeless has quit IRC | 16:34 | |
| *** Hunner has joined #openstack-horizon | 16:36 | |
| *** Hunner has left #openstack-horizon | 16:37 | |
| *** geoffarnold has joined #openstack-horizon | 16:39 | |
| *** kristinebrown has joined #openstack-horizon | 16:41 | |
| *** lifeless has joined #openstack-horizon | 16:41 | |
| *** lhcheng has joined #openstack-horizon | 16:43 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Adding missing spec for widgets.module.js https://review.openstack.org/218675 | 16:43 |
| *** lblanchard has joined #openstack-horizon | 16:46 | |
| *** kristinebrown has quit IRC | 16:46 | |
| *** jbell8 has joined #openstack-horizon | 16:47 | |
| *** romainh has left #openstack-horizon | 16:50 | |
| *** tqtran has quit IRC | 16:51 | |
| *** SimonChung has quit IRC | 16:51 | |
| *** jtriley has quit IRC | 16:51 | |
| *** kristinebrown has joined #openstack-horizon | 16:52 | |
| *** jbell8 has quit IRC | 16:53 | |
| *** jtriley has joined #openstack-horizon | 16:55 | |
| *** sayan has joined #openstack-horizon | 16:55 | |
| *** ducttape_ has joined #openstack-horizon | 16:56 | |
| ducttape_ | david-lyle TravT Piet - local openstack meetup tonight http://www.meetup.com/OpenStack-Colorado/events/224474987/ pass it on | 16:58 |
| TravT | ducttape_: thanks... i had signed up for that and had forgotten. | 16:58 |
| TravT | son has football tonight, so will be a little late. | 16:58 |
| * david-lyle believes he will be driving kids around at that time :( | 16:58 | |
| ducttape_ | no worries. pass it along to others if you are in the office TravT | 16:58 |
| TravT | will do. | 16:59 |
| david-lyle | looks interesting though | 16:59 |
| *** lapalm has quit IRC | 16:59 | |
| *** vishwanathj has quit IRC | 17:00 | |
| *** vgridnev has joined #openstack-horizon | 17:04 | |
| *** exploreshaifali has joined #openstack-horizon | 17:04 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Dashboard Panels should not include SCSS https://review.openstack.org/218941 | 17:05 |
| *** shivrao has joined #openstack-horizon | 17:09 | |
| *** rhagarty_ has quit IRC | 17:09 | |
| *** rhagarty has quit IRC | 17:09 | |
| *** kiran-r has quit IRC | 17:10 | |
| *** julim has joined #openstack-horizon | 17:11 | |
| *** jbell8 has joined #openstack-horizon | 17:14 | |
| *** akrivoka has quit IRC | 17:14 | |
| *** rhagarty has joined #openstack-horizon | 17:14 | |
| *** ybathia has joined #openstack-horizon | 17:14 | |
| *** rhagarty_ has joined #openstack-horizon | 17:14 | |
| *** rdopiera has quit IRC | 17:15 | |
| robcresswell | TravT: Do you work with Tyr? Wondering how to get in contact | 17:16 |
| robcresswell | david-lyle: When's cut off for L-3 again? Wondering if I can sneak in another pass over the angular docs. Needs updating. | 17:17 |
| david-lyle | robcresswell: L-3 is Sept 3 | 17:17 |
| david-lyle | docs changes will be accepted until RC-1 | 17:18 |
| robcresswell | Great, thanks | 17:18 |
| *** aix has quit IRC | 17:21 | |
| TravT | robcresswell: i do. | 17:21 |
| *** ruchika has joined #openstack-horizon | 17:21 | |
| *** tnovacik has quit IRC | 17:22 | |
| *** jingjing_ren has joined #openstack-horizon | 17:23 | |
| *** liangbo has quit IRC | 17:23 | |
| ruchika | Hello... I want to fix a bug of horizon but I can't install devstack on my system... so is there any way to resolve the bugs without installing devstack? | 17:24 |
| *** Drago has quit IRC | 17:24 | |
| david-lyle | ruchika: you can certainly validate them on a real install, rather than devstack | 17:24 |
| david-lyle | but validating your patches is an important part of the bug fix process | 17:25 |
| david-lyle | so some working OpenStack environment is needed | 17:25 |
| *** e0ne has joined #openstack-horizon | 17:26 | |
| exploreshaifali | david-lyle, is there any virtual env that ruchika can use? | 17:26 |
| exploreshaifali | or may be vagrant? | 17:26 |
| exploreshaifali | that will let her write code for openstack | 17:27 |
| david-lyle | I don't know that I understand the problem | 17:27 |
| david-lyle | is installing a VM and devstack in that VM prohibited? or ? | 17:27 |
| david-lyle | but I never install devstack directly on my laptop, always in a VM | 17:28 |
| *** jbell8 has quit IRC | 17:28 | |
| david-lyle | virtualbox is free and works well for the job | 17:28 |
| david-lyle | vagrant would also work | 17:28 |
| exploreshaifali | david-lyle, ruchika have hardware issues | 17:28 |
| exploreshaifali | she only have 2GB RAM | 17:28 |
| ruchika | yes | 17:29 |
| exploreshaifali | single devstack installation need 2GB RAM | 17:29 |
| david-lyle | that would be difficult | 17:29 |
| exploreshaifali | so something for now that could help her | 17:29 |
| david-lyle | not sure about hitting trystack remotely with a horizon dev server would work | 17:29 |
| exploreshaifali | I don't know if one can use trystack for development? | 17:30 |
| exploreshaifali | like makeing changes and testing | 17:30 |
| robcresswell | TravT: Awesome. I was wondering if I could update this patch ( https://review.openstack.org/#/c/203862/ ) and add more content to it | 17:30 |
| robcresswell | TravT: Not sure what Tyr's irc handle is | 17:30 |
| TravT | robcresswell: yes, i was wondering about that as well. | 17:31 |
| TravT | I will try to talk to him. | 17:31 |
| exploreshaifali | all right david-lyle Thanks :) | 17:31 |
| TravT | he's showing offline in our internal system as well | 17:31 |
| TravT | i think you could just update it | 17:31 |
| robcresswell | TravT: Thanks. I'm happy to fix the issues, as I need to add some parts too. | 17:31 |
| TravT | and ask forgiveness. | 17:31 |
| robcresswell | Ha, cool will do | 17:31 |
| david-lyle | exploreshaifali: not for dev, just for running API endpoints | 17:32 |
| david-lyle | not sure the endpoints are exposed externally | 17:33 |
| exploreshaifali | ok, Thanks david-lyle :) | 17:33 |
| exploreshaifali | ok! | 17:33 |
| david-lyle | other options are cloud envs, but that would require $ | 17:33 |
| exploreshaifali | haha | 17:33 |
| exploreshaifali | better we will go for increasing ruchika's lapy RAM | 17:33 |
| *** jbell8 has joined #openstack-horizon | 17:34 | |
| ruchika | yes I think I should increase my ram only :( | 17:35 |
| *** stevemar has quit IRC | 17:35 | |
| *** e0ne has quit IRC | 17:36 | |
| *** SimonChung has joined #openstack-horizon | 17:36 | |
| *** vgridnev has quit IRC | 17:37 | |
| david-lyle | sure, or if you have another 2GB laptop to run devstack on | 17:38 |
| *** stevemar has joined #openstack-horizon | 17:38 | |
| *** SimonChung has quit IRC | 17:38 | |
| *** e0ne has joined #openstack-horizon | 17:39 | |
| kfox1111 | hmm... does pbr work from within a horizon plugin? | 17:40 |
| *** kristinebrown has quit IRC | 17:40 | |
| david-lyle | kfox1111: only if you set it up that way | 17:40 |
| kfox1111 | I seem to be getting horizon's version numbers I think. | 17:40 |
| david-lyle | hmm | 17:40 |
| *** Drago has joined #openstack-horizon | 17:41 | |
| david-lyle | you are calling what to get version? | 17:41 |
| kfox1111 | I copied horizon.version into the plugin, then s/horizon/app_catalog/ | 17:41 |
| kfox1111 | then tried to import app_catalog.version and checkout version_info | 17:41 |
| *** Drago has quit IRC | 17:42 | |
| *** Drago has joined #openstack-horizon | 17:42 | |
| *** stevemar has quit IRC | 17:42 | |
| ducttape_ | I recalled using pip for something like that kfox1111 | 17:43 |
| *** ig0r__ has joined #openstack-horizon | 17:43 | |
| ducttape_ | I had a page that would list horizon version number, plus immediate dependancy versions.... all like a tree that was something like 3 levels deep | 17:43 |
| ducttape_ | would pip work for that too ? | 17:44 |
| kfox1111 | using pip to generate a json file or something? | 17:44 |
| kfox1111 | ../horizon/.venv/lib/python2.7/site-packages/app_catalog_ui-0.0.1.dev17-py2.7.egg-info/pbr.json seems to have the right version info in it. | 17:44 |
| *** ig0r_ has quit IRC | 17:46 | |
| *** jtriley has quit IRC | 17:47 | |
| kfox1111 | oh... it seems to be looking around in the current dir for git stuff.. which in this case is horizon. | 17:47 |
| *** aix has joined #openstack-horizon | 17:48 | |
| *** sayan has quit IRC | 17:49 | |
| kfox1111 | yeah... seeming like pbr.version and horizon plugins may be incompatable... | 17:49 |
| david-lyle | you may just add a call to __init__.py in your plugin to call it on the right package? | 17:49 |
| david-lyle | of app_catalog.get_version() | 17:50 |
| *** jtriley has joined #openstack-horizon | 17:50 | |
| david-lyle | kfox1111: looking at https://review.openstack.org/#/c/171898/1/keystoneclient_kerberos/__init__.py | 17:50 |
| david-lyle | e..g | 17:50 |
| kfox1111 | its in the right package. its for some reason not finding the pbr version, so its reverting to looking at localdir for git info, and finding horizon's... | 17:50 |
| kfox1111 | looking... | 17:51 |
| *** doug-fish has quit IRC | 17:51 | |
| *** kzaitsev_mb has quit IRC | 17:51 | |
| *** doug-fish has joined #openstack-horizon | 17:51 | |
| *** Sukhdev has quit IRC | 17:51 | |
| kfox1111 | hmm... so it can be done... I wonder if anything's actually looking at the value to ensure its the modules, and not horizons. | 17:53 |
| *** Guest57338 has joined #openstack-horizon | 17:53 | |
| kfox1111 | ah... I think I see why... | 17:55 |
| *** ruchika has quit IRC | 17:55 | |
| kfox1111 | yeah. the python module name didn't match the package name. | 17:56 |
| *** jprovazn has quit IRC | 17:57 | |
| *** lapalm has joined #openstack-horizon | 17:58 | |
| *** lapalm has quit IRC | 17:58 | |
| *** lapalm has joined #openstack-horizon | 17:58 | |
| *** jingjing_ren has quit IRC | 17:59 | |
| *** stevemar has joined #openstack-horizon | 18:03 | |
| *** lapalm has quit IRC | 18:04 | |
| *** saksham has joined #openstack-horizon | 18:05 | |
| *** lapalm has joined #openstack-horizon | 18:07 | |
| *** lapalm has quit IRC | 18:07 | |
| *** lapalm has joined #openstack-horizon | 18:07 | |
| *** cloudtrainme has quit IRC | 18:10 | |
| *** ruchika has joined #openstack-horizon | 18:11 | |
| *** jtriley has quit IRC | 18:13 | |
| *** jtriley has joined #openstack-horizon | 18:17 | |
| *** julim has quit IRC | 18:18 | |
| openstackgerrit | Merged openstack/horizon: Skip test_routerrule_detail blocking the gate https://review.openstack.org/218786 | 18:19 |
| *** julim has joined #openstack-horizon | 18:21 | |
| *** jtomasek has joined #openstack-horizon | 18:22 | |
| *** petertr7 is now known as petertr7_away | 18:23 | |
| *** ruchika has quit IRC | 18:23 | |
| *** jprovazn has joined #openstack-horizon | 18:24 | |
| *** petertr7_away is now known as petertr7 | 18:25 | |
| *** kristinebrown has joined #openstack-horizon | 18:25 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Adding row action to delete single image to angular images panel https://review.openstack.org/217949 | 18:26 |
| *** vgridnev has joined #openstack-horizon | 18:26 | |
| *** jwy has joined #openstack-horizon | 18:26 | |
| *** exploreshaifali has quit IRC | 18:28 | |
| doug-fish | lhcheng: are you around to chat about https://review.openstack.org/#/c/141153/ | 18:30 |
| *** gyee has quit IRC | 18:33 | |
| david-lyle | doug-fish: the part that is needed is the policy change in d-o-a | 18:33 |
| david-lyle | it's not much use without it | 18:33 |
| doug-fish | oooh | 18:33 |
| david-lyle | https://review.openstack.org/#/c/196328/ | 18:33 |
| doug-fish | that other part | 18:33 |
| david-lyle | so if both are ready then we have something useful :) | 18:34 |
| doug-fish | makes sense now. Thanks david-lyle | 18:34 |
| doug-fish | yeah | 18:34 |
| doug-fish | got it | 18:34 |
| david-lyle | sure | 18:34 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Adding row action to update metadata for an image https://review.openstack.org/217964 | 18:34 |
| * david-lyle needs to review https://review.openstack.org/#/c/196328/ | 18:34 | |
| doug-fish | I'm trying to wrap up half finished work before a week of time off. I'm not sure tackling https://review.openstack.org/#/c/196328/ falls within that scope | 18:36 |
| david-lyle | quitter | 18:38 |
| david-lyle | :P | 18:38 |
| doug-fish | I've taken too little vacation and I'm becoming crabby and inaccurate. If that kind of review is helpful I suppose I could squeeze it in. | 18:39 |
| doug-fish | >:-| <- cranky face | 18:39 |
| david-lyle | doug-fish: just kidding, I need to walk through that patch a bunch to reassure myself | 18:40 |
| david-lyle | focus on other stuff | 18:40 |
| doug-fish | :-) yeah, no offense taken | 18:40 |
| doug-fish | I'm pretty much focused on the time off already | 18:40 |
| david-lyle | sounds like you're doing it right | 18:41 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Cloud Service directive to check if Service is enabled https://review.openstack.org/212125 | 18:42 |
| *** jtriley_ has joined #openstack-horizon | 18:43 | |
| *** jtriley has quit IRC | 18:46 | |
| *** juggler has quit IRC | 18:47 | |
| *** ig0r__ has quit IRC | 18:48 | |
| hurgleburgler | All right everyone … I'd like some feedback REALLY quickly … I'm trying to finalize on the Primary Brand color for the 'material' theme … | 18:48 |
| hurgleburgler | Green: | 18:48 |
| hurgleburgler | https://www.dropbox.com/s/y0lzbqlpub24q5o/Screenshot%202015-08-31%2011.42.24.png?dl=0 | 18:48 |
| hurgleburgler | Blue: | 18:48 |
| hurgleburgler | https://www.dropbox.com/s/d0u098ox7rbqkf4/Screenshot%202015-08-31%2011.48.29.png?dl=0 | 18:48 |
| *** Guest57338 has quit IRC | 18:49 | |
| david-lyle | not green | 18:50 |
| *** sayan has joined #openstack-horizon | 18:50 | |
| hurgleburgler | Does that mean you like the blue more? or you dislike the green more than you dislike the blue? | 18:50 |
| tsufiev | ))) | 18:51 |
| tsufiev | green-ity discrimination | 18:51 |
| *** sayan has quit IRC | 18:52 | |
| david-lyle | green and red of openstack logo is less than optimal | 18:52 |
| *** sayan has joined #openstack-horizon | 18:52 | |
| david-lyle | at least that shade of green | 18:52 |
| hurgleburgler | Yeah, I'm gonna work on fixing the logo in a follow on patch | 18:52 |
| david-lyle | fixing the logo? | 18:52 |
| hurgleburgler | I have some vector images of it that I'm gonna play around with | 18:52 |
| hurgleburgler | We can likely get something that looks a bit better and is high def | 18:52 |
| *** sayan has quit IRC | 18:52 | |
| hurgleburgler | vector images of the openstack logo* | 18:53 |
| david-lyle | you're going to change the OpenStack logo? you might want to work with the foundation on that one | 18:53 |
| hurgleburgler | No no, its the same logo | 18:53 |
| hurgleburgler | but in vector format | 18:53 |
| david-lyle | ok | 18:53 |
| *** stevemar has quit IRC | 18:54 | |
| hurgleburgler | Is that your only detracting for the green? | 18:54 |
| hurgleburgler | Cause, I'll fix that | 18:54 |
| hurgleburgler | But, I can try a few shades of the blue too, if it seems too bright | 18:54 |
| hurgleburgler | This one is a wee bit darker: https://www.dropbox.com/s/6c139r1enqyc4ds/Screenshot%202015-08-31%2011.55.58.png?dl=0 | 18:56 |
| hurgleburgler | and even a wee bit darker still: https://www.dropbox.com/s/kjiy9kzfint5rpq/Screenshot%202015-08-31%2011.57.54.png?dl=0 | 18:58 |
| *** mrunge has quit IRC | 18:58 | |
| david-lyle | I actually like the first | 18:59 |
| david-lyle | of those | 18:59 |
| david-lyle | first of 3 | 18:59 |
| hurgleburgler | this one? | 18:59 |
| hurgleburgler | https://www.dropbox.com/s/d0u098ox7rbqkf4/Screenshot%202015-08-31%2011.48.29.png?dl=0 | 18:59 |
| *** sayan has joined #openstack-horizon | 19:00 | |
| *** kzaitsev_mb has joined #openstack-horizon | 19:00 | |
| hurgleburgler | ok, that one ^ | 19:00 |
| hurgleburgler | going once! | 19:00 |
| hurgleburgler | going twice! | 19:01 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Theming Mechanism now supports 3rd party themes https://review.openstack.org/197821 | 19:02 |
| hurgleburgler | DONE. | 19:02 |
| *** ericpeterson has joined #openstack-horizon | 19:03 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/218905 | 19:03 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Theming Mechanism now supports 3rd party themes https://review.openstack.org/197821 | 19:04 |
| *** ducttape_ has quit IRC | 19:06 | |
| *** jtriley_ has quit IRC | 19:07 | |
| *** neelashah has joined #openstack-horizon | 19:10 | |
| *** kristinebrown has quit IRC | 19:11 | |
| *** ZZelle has joined #openstack-horizon | 19:13 | |
| *** saksham has quit IRC | 19:20 | |
| *** shaleh has joined #openstack-horizon | 19:24 | |
| *** neelashah has quit IRC | 19:25 | |
| Piet | I went ahead and posted a draft version of the cloud personas to invision | 19:25 |
| Piet | Feel free to comment - https://invis.io/VM41Q203B | 19:26 |
| *** sayan has quit IRC | 19:27 | |
| *** jprovazn has quit IRC | 19:27 | |
| *** petertr7 is now known as petertr7_away | 19:28 | |
| *** Drago has quit IRC | 19:32 | |
| *** Drago has joined #openstack-horizon | 19:32 | |
| *** ericpeterson has quit IRC | 19:32 | |
| *** exploreshaifali has joined #openstack-horizon | 19:33 | |
| lhcheng | doug-fish: yeah, what david-lyle said :) | 19:35 |
| *** jtriley has joined #openstack-horizon | 19:36 | |
| doug-fish | lhcheng: so I should trust david-lyle this time? got it. | 19:38 |
| doug-fish | :-p | 19:38 |
| david-lyle | whoa, big mistake | 19:38 |
| lhcheng | yeah, always trust the author of the patch :) | 19:38 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Dashboard Panels should not include SCSS https://review.openstack.org/218941 | 19:40 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Create a Angular Modules for Admin Dashboard https://review.openstack.org/214779 | 19:40 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : API for Metadata Definitions https://review.openstack.org/215721 | 19:42 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Angular panel for Metadata Definitions https://review.openstack.org/216141 | 19:42 |
| *** alanf has quit IRC | 19:46 | |
| kfox1111 | "What could go wrong (TM)" | 19:46 |
| david-lyle | doug-fish: really, I just don't want to go rushing in willy nilly on that patch, it's only been around since Dec 11, 2014 | 19:47 |
| *** ducttape_ has joined #openstack-horizon | 19:47 | |
| *** petertr7_away is now known as petertr7 | 19:48 | |
| *** alanf has joined #openstack-horizon | 19:48 | |
| *** Sukhdev has joined #openstack-horizon | 19:49 | |
| *** stevemar has joined #openstack-horizon | 19:54 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: ESLint glob pattern not matching files for lint https://review.openstack.org/219010 | 19:57 |
| *** jtriley has quit IRC | 19:57 | |
| *** stevemar has quit IRC | 19:59 | |
| *** david-lyle has quit IRC | 20:01 | |
| *** lapalm has quit IRC | 20:03 | |
| *** lapalm has joined #openstack-horizon | 20:03 | |
| *** lapalm_ has joined #openstack-horizon | 20:04 | |
| *** lapalm_ has quit IRC | 20:04 | |
| *** lapalm_ has joined #openstack-horizon | 20:04 | |
| *** david-lyle has joined #openstack-horizon | 20:06 | |
| *** ChanServ sets mode: +o david-lyle | 20:06 | |
| *** petertr7 is now known as petertr7_away | 20:06 | |
| *** lapalm has quit IRC | 20:08 | |
| *** kristinebrown has joined #openstack-horizon | 20:09 | |
| *** stevemar has joined #openstack-horizon | 20:10 | |
| *** sqchen has joined #openstack-horizon | 20:17 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Cleaning unnecessary leading whitespace in html https://review.openstack.org/218679 | 20:19 |
| openstackgerrit | David Lyle proposed openstack/horizon: Improve message propagation in exceptions.handle https://review.openstack.org/219019 | 20:21 |
| *** kristinebrown has quit IRC | 20:21 | |
| openstackgerrit | David Lyle proposed openstack/horizon: Improve message propagation in exceptions.handle https://review.openstack.org/219019 | 20:23 |
| *** jtriley has joined #openstack-horizon | 20:24 | |
| openstackgerrit | Justin Pomeroy proposed openstack/horizon: Fix ISO tests https://review.openstack.org/199686 | 20:24 |
| lhcheng | tqtran_: do you know if the angular stuff in the login screen changed? | 20:24 |
| tqtran_ | um not that im aware of | 20:25 |
| david-lyle | lhcheng: https://review.openstack.org/219019 | 20:25 |
| david-lyle | not perfect, but workable | 20:25 |
| *** vgridnev has quit IRC | 20:27 | |
| lhcheng | tqtran_: something in websso setupis broken, the region is not getting submitted :( | 20:27 |
| tqtran_ | let me trace the file history and see if someone mess with it | 20:28 |
| lhcheng | david-lyle: nice, will test it out after I finished with the websso stuff | 20:28 |
| david-lyle | lhcheng: sure, no hurry | 20:29 |
| lhcheng | tqtran_: I see changes here: https://review.openstack.org/#/c/216517/ but it is updates on the tests. | 20:29 |
| *** kristinebrown has joined #openstack-horizon | 20:29 | |
| tqtran_ | https://review.openstack.org/#/c/216517/6/horizon/static/auth/login/login.module.js L20 looks a bit strange | 20:32 |
| tqtran_ | i havent seen that syntax before | 20:32 |
| tqtran_ | sqchen: ^---- | 20:33 |
| tqtran_ | is it possible to load config like that? | 20:33 |
| sqchen | tqtran: hi | 20:33 |
| lhcheng | tqtran_: so when I enabled WEBSSO, the region hidden field is now missing | 20:34 |
| tqtran_ | isnt it suppose to be module(...,[]).config(config)? | 20:34 |
| tqtran_ | lhcheng: do you still see the credentials selection? | 20:35 |
| lhcheng | yup | 20:35 |
| lhcheng | The Domain field is also not getting hidden, if I picked an auth_type != 'Credentials' :( | 20:36 |
| sqchen | tqtran: yes, the last optional argument to angular.module() when defining a new module it a config function. I personally find the syntext is elegant. | 20:36 |
| tqtran_ | sqchen: thats fine, just wondering, havent seen that syntax before | 20:37 |
| sqchen | This is from angular’s doc: | 20:37 |
| sqchen | angular.module(name, [requires], [configFn]); | 20:37 |
| openstackgerrit | Amogh proposed openstack/horizon: Integration tests - Instances tests https://review.openstack.org/117091 | 20:39 |
| tqtran_ | https://github.com/openstack/horizon/commits/master/horizon/static/auth/login/login.controller.js | 20:40 |
| tsufiev | david-lyle, https://review.openstack.org/#/c/140708/ is obviously a different thing from https://review.openstack.org/219019 but addresses another aspect of messaging | 20:41 |
| tqtran_ | lhcheng: https://github.com/openstack/horizon/blob/master/horizon/static/auth/login/login-finder.directive.js#L60 | 20:42 |
| tqtran_ | i think i found the issue | 20:42 |
| *** cloudtrainme has joined #openstack-horizon | 20:42 | |
| tqtran_ | https://github.com/openstack/horizon/blob/master/horizon/static/auth/login/login.controller.js#L30 | 20:42 |
| *** gyee has joined #openstack-horizon | 20:43 | |
| tqtran_ | seems like the flurry of jscs patches wasn't verified properly, what seems like a harmless change might have broken it | 20:44 |
| david-lyle | tqtran_: :D | 20:45 |
| david-lyle | :( | 20:45 |
| *** kristinebrown has quit IRC | 20:45 | |
| tqtran_ | want me to patch a fix for it? | 20:45 |
| *** tqtran_ has quit IRC | 20:46 | |
| *** jtriley has quit IRC | 20:47 | |
| *** matt-borland has joined #openstack-horizon | 20:48 | |
| *** saksham has joined #openstack-horizon | 20:52 | |
| *** crobertsrh is now known as _crobertsrh | 20:54 | |
| *** cloudtrainme has quit IRC | 20:55 | |
| *** vgridnev has joined #openstack-horizon | 20:57 | |
| *** tqtran has joined #openstack-horizon | 21:00 | |
| tqtran | sorry, having internet issues, thank you so very much comcast for your crappy service | 21:00 |
| *** jtriley has joined #openstack-horizon | 21:01 | |
| tqtran | i'll put up a patch shortly after i have internet again, currently on data | 21:01 |
| jwy | hi, is horizon following the liberty schedule at https://wiki.openstack.org/wiki/Liberty_Release_Schedule? | 21:05 |
| *** shaleh_ has joined #openstack-horizon | 21:07 | |
| openstackgerrit | Kyle Olivo proposed openstack/horizon: WIP: Add volumes panel that uses angular.js https://review.openstack.org/216778 | 21:08 |
| *** stevemar has quit IRC | 21:08 | |
| jwy | i've got a couple reviews out for this blueprint, which is targeting liberty-3 https://blueprints.launchpad.net/horizon/+spec/import-images | 21:08 |
| *** vgridnev has quit IRC | 21:08 | |
| jwy | probably cutting it close to get them in before feature freeze… | 21:08 |
| *** tqtran has quit IRC | 21:09 | |
| *** tqtran has joined #openstack-horizon | 21:11 | |
| *** tqtran has quit IRC | 21:11 | |
| *** shaleh has quit IRC | 21:11 | |
| *** doug-fish has quit IRC | 21:11 | |
| *** vgridnev has joined #openstack-horizon | 21:11 | |
| *** jbell8 has quit IRC | 21:12 | |
| *** julim has quit IRC | 21:14 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Adding missing spec for widgets.module.js https://review.openstack.org/218675 | 21:17 |
| *** kristinebrown has joined #openstack-horizon | 21:17 | |
| *** tqtran has joined #openstack-horizon | 21:19 | |
| *** mayurig has joined #openstack-horizon | 21:20 | |
| *** lapalm_ has quit IRC | 21:21 | |
| *** pauloewerton has quit IRC | 21:27 | |
| *** itisha has joined #openstack-horizon | 21:29 | |
| lhcheng | tqtran: looking at that patch, there was a cleanup on top of a cleanup | 21:29 |
| lhcheng | lol | 21:29 |
| *** mayurig has quit IRC | 21:30 | |
| *** mayurig has joined #openstack-horizon | 21:31 | |
| *** kristinebrown has quit IRC | 21:31 | |
| *** e0ne has quit IRC | 21:34 | |
| *** vgridnev has quit IRC | 21:37 | |
| *** jbell8 has joined #openstack-horizon | 21:40 | |
| *** kristinebrown has joined #openstack-horizon | 21:40 | |
| *** Drago has quit IRC | 21:43 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Login directive no longer hides domain and region dropdown https://review.openstack.org/219040 | 21:43 |
| *** jcoufal has quit IRC | 21:45 | |
| *** jbell8 has quit IRC | 21:45 | |
| openstackgerrit | Lin Hua Cheng proposed openstack/django_openstack_auth: IDP specific websso https://review.openstack.org/219041 | 21:45 |
| *** jtriley has quit IRC | 21:47 | |
| r1chardj0n3s | morning | 21:48 |
| *** Sukhdev has quit IRC | 21:49 | |
| *** cbader has quit IRC | 21:49 | |
| matt-borland | morning/afternoon! | 21:50 |
| *** Sukhdev has joined #openstack-horizon | 21:51 | |
| *** matt-borland has quit IRC | 21:52 | |
| *** akanksha has joined #openstack-horizon | 21:52 | |
| *** jtomasek has quit IRC | 21:54 | |
| *** garthb_ has joined #openstack-horizon | 21:56 | |
| *** garthb_ has quit IRC | 21:57 | |
| *** kristinebrown has quit IRC | 22:03 | |
| *** kristinebrown has joined #openstack-horizon | 22:03 | |
| *** vijendar has quit IRC | 22:08 | |
| *** jtriley has joined #openstack-horizon | 22:08 | |
| akanksha | Hey everyone, I am new to Openstack and I want to start contributing to horizon. Can someone please help me get started? | 22:09 |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Add config setting to require keypair on instance create https://review.openstack.org/75469 | 22:10 |
| ducttape_ | those familiar with the ng launch instance, I could use help with patch above ^ it's a patch I'd like to see for old launch instance, but I also would like to keep feature parity ^ | 22:11 |
| ducttape_ | i.e. I've coded the "old reliable" django way, have an option for ng gurus to update the other half | 22:12 |
| *** jtriley has quit IRC | 22:13 | |
| r1chardj0n3s | akanksha: here's a place to start https://wiki.openstack.org/wiki/How_To_Contribute#If_you.27re_a_developer | 22:15 |
| *** linkedinyou has quit IRC | 22:15 | |
| *** shivrao has quit IRC | 22:17 | |
| *** garthb has quit IRC | 22:17 | |
| *** garthb has joined #openstack-horizon | 22:17 | |
| *** garthb_ has joined #openstack-horizon | 22:17 | |
| *** mpavlase has joined #openstack-horizon | 22:17 | |
| *** garthb_ has quit IRC | 22:17 | |
| *** garthb has quit IRC | 22:18 | |
| *** garthb_ has joined #openstack-horizon | 22:18 | |
| ducttape_ | http://docs.openstack.org/developer/horizon/index.html to follow on with r1chardj0n3s' suggestion akanksha | 22:18 |
| *** Drago has joined #openstack-horizon | 22:18 | |
| *** garthb has joined #openstack-horizon | 22:19 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Login directive no longer hides domain and region dropdown https://review.openstack.org/219040 | 22:21 |
| *** alanf has quit IRC | 22:21 | |
| *** alanf has joined #openstack-horizon | 22:22 | |
| *** Piet has quit IRC | 22:22 | |
| lhcheng | tqtran: the error in console is gone, but the login page is still not passing the hidden region field ^ | 22:24 |
| tqtran | do you know if the doa side of it changed? | 22:24 |
| tqtran | especially if the ids of the form? | 22:25 |
| *** kyleolivo has joined #openstack-horizon | 22:25 | |
| tqtran | hm doesnt look like it | 22:26 |
| tqtran | is your username/password fields hiding correctly though? | 22:26 |
| lhcheng | tqtran: yes, the fields are hiding correctly | 22:26 |
| *** kyleolivo has quit IRC | 22:27 | |
| lhcheng | the hidden region field is missing in the form though | 22:27 |
| *** dguerri` is now known as dguerri | 22:27 | |
| lhcheng | if I turn off WEBSSO, the hidden region field is available | 22:27 |
| tqtran | isnt that the intended behavior? if websso is off, its normally what it should be | 22:29 |
| lhcheng | tqtran: nope, that is still needed :) | 22:30 |
| lhcheng | tqtran: https://github.com/openstack/django_openstack_auth/blob/master/openstack_auth/views.py#L64 | 22:30 |
| lhcheng | it is needed to determine the keystone endpoint to perform the fed login | 22:31 |
| *** dguerri is now known as dguerri` | 22:31 | |
| *** kristinebrown has quit IRC | 22:31 | |
| lhcheng | tqtran: it should be just made hidden. | 22:34 |
| *** btully has quit IRC | 22:36 | |
| *** kristinebrown has joined #openstack-horizon | 22:36 | |
| *** Daisy has joined #openstack-horizon | 22:38 | |
| *** SimonChung has joined #openstack-horizon | 22:40 | |
| *** jpomeroy has quit IRC | 22:42 | |
| *** kristinebrown has quit IRC | 22:42 | |
| *** Daisy has quit IRC | 22:43 | |
| *** Piet has joined #openstack-horizon | 22:52 | |
| *** lblanchard has quit IRC | 22:54 | |
| *** lblanchard has joined #openstack-horizon | 22:56 | |
| tqtran | lhcheng: im confused | 22:58 |
| tqtran | so you're saying that we should hide the region field if websso is not enabled? | 22:59 |
| *** kristinebrown has joined #openstack-horizon | 22:59 | |
| lhcheng | the region field should always be there.. hidden or rendered... | 23:00 |
| lhcheng | if I turn on WEBSSO, the region field is missing (the hidden field is not in HTML) | 23:00 |
| tqtran | ah..... | 23:00 |
| tqtran | ok, so right now, if you enable websso and select credentials, the domain and region dropdown disappears | 23:01 |
| tqtran | is that the problem? | 23:01 |
| *** jpomeroy has joined #openstack-horizon | 23:02 | |
| tqtran | ok nvm i got what you're saying | 23:02 |
| tqtran | just need to remove the region detection from the list https://github.com/openstack/horizon/blob/master/horizon/static/auth/login/login-finder.directive.js#L72 | 23:03 |
| *** stevemar has joined #openstack-horizon | 23:04 | |
| *** exploreshaifali has quit IRC | 23:04 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Login directive no longer hides domain and region dropdown https://review.openstack.org/219040 | 23:05 |
| *** tosky has quit IRC | 23:06 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Update Users Table to single HTML https://review.openstack.org/217879 | 23:06 |
| lhcheng | tqtran: the code used to work before, not sure if that is the problem. | 23:06 |
| lhcheng | was that line recently added? | 23:06 |
| tqtran | i dont think so | 23:07 |
| tqtran | yeah i think its always been there | 23:08 |
| *** Drago has quit IRC | 23:08 | |
| lhcheng | if you remove that, it won't hide the region dropdown right? | 23:09 |
| tqtran | original code: https://review.openstack.org/#/c/151842/38/horizon/static/angular/login/login.js | 23:10 |
| tqtran | that is correct | 23:10 |
| *** kristinebrown has quit IRC | 23:10 | |
| tqtran | i also checked the history of the doa side, seems like its all in order | 23:10 |
| lhcheng | yeah, that used to work. I doubt removing the regionInput action will fix the issue. | 23:11 |
| lhcheng | something else changed... :( | 23:12 |
| lhcheng | too much cleanup, the region field got cleaned-up.. | 23:12 |
| lhcheng | :P | 23:12 |
| lhcheng | probably somewhere in one of the three cleanup patches. | 23:13 |
| *** SimonChung1 has joined #openstack-horizon | 23:15 | |
| *** SimonChung has quit IRC | 23:15 | |
| *** shivrao has joined #openstack-horizon | 23:15 | |
| *** SimonChung1 has quit IRC | 23:15 | |
| *** SimonChung has joined #openstack-horizon | 23:15 | |
| *** kzaitsev_mb has quit IRC | 23:19 | |
| lhcheng | tqtran: I'll dig around, I think we should just keep the old logic for regionInput in your patch. | 23:25 |
| *** sambetts has quit IRC | 23:28 | |
| *** sambetts has joined #openstack-horizon | 23:28 | |
| *** kzaitsev_mb has joined #openstack-horizon | 23:32 | |
| *** ZZelle has quit IRC | 23:35 | |
| *** stevemar has quit IRC | 23:38 | |
| *** ducttape_ has quit IRC | 23:43 | |
| openstackgerrit | Lin Hua Cheng proposed openstack/django_openstack_auth: Fix missing region field on WebSSO setup https://review.openstack.org/219063 | 23:45 |
| lhcheng | tqtran: found the issue. ^ lin introduced the bug, never trust that guy. :P | 23:47 |
| tqtran | lol what happened? | 23:47 |
| tqtran | ah i see | 23:48 |
| lhcheng | just added a comment on the patch | 23:49 |
| *** lblanchard has quit IRC | 23:49 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP Adding Create Image Action to angular images panel https://review.openstack.org/217828 | 23:50 |
| lhcheng | we still need the patch you submitted right? changed: scope -> ctrl | 23:50 |
| *** kristinebrown has joined #openstack-horizon | 23:50 | |
| *** Sukhdev has quit IRC | 23:51 | |
| *** btully has joined #openstack-horizon | 23:52 | |
| *** kristinebrown has quit IRC | 23:53 | |
| *** btully has quit IRC | 23:57 | |
| *** mayurig has quit IRC | 23:58 | |
| tqtran | yes | 23:58 |
| tqtran | i'll update that | 23:58 |
| tqtran | nvm its updated lol | 23:58 |
| *** kristinebrown has joined #openstack-horizon | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
