| *** masco has joined #openstack-horizon | 00:04 | |
| *** lblanchard has joined #openstack-horizon | 00:05 | |
| *** rdopiera has quit IRC | 00:05 | |
| *** geoffarnold has quit IRC | 00:06 | |
| *** geoffarnold has joined #openstack-horizon | 00:07 | |
| *** garthb has quit IRC | 00:11 | |
| *** geoffarnold has quit IRC | 00:11 | |
| openstackgerrit | Michael Krotscheck proposed openstack/horizon: Upgraded eslint rule libraries. https://review.openstack.org/213818 | 00:13 |
|---|---|---|
| *** btully has quit IRC | 00:34 | |
| *** Piet has joined #openstack-horizon | 00:36 | |
| *** mwhagedorn has quit IRC | 00:37 | |
| *** hurgleburgler has quit IRC | 00:38 | |
| *** shivrao has quit IRC | 00:38 | |
| *** tyr has quit IRC | 00:40 | |
| *** DWfuturetec has quit IRC | 00:47 | |
| *** masco has quit IRC | 00:48 | |
| *** ducttape_ has joined #openstack-horizon | 00:49 | |
| *** shivrao has joined #openstack-horizon | 00:50 | |
| *** shivrao has quit IRC | 00:53 | |
| *** Piet has quit IRC | 00:55 | |
| *** gyee has quit IRC | 00:55 | |
| *** dshaw___ has quit IRC | 00:56 | |
| openstackgerrit | Merged openstack/horizon: Inconsistent karma conf for xstatic files https://review.openstack.org/213846 | 01:01 |
| *** KunalGandhi has quit IRC | 01:07 | |
| *** darrenc is now known as darrenc_afk | 01:07 | |
| *** KunalGandhi has joined #openstack-horizon | 01:08 | |
| *** zhenguo has joined #openstack-horizon | 01:09 | |
| *** bpokorny has quit IRC | 01:10 | |
| *** linkedinyou has joined #openstack-horizon | 01:12 | |
| *** cbader has joined #openstack-horizon | 01:15 | |
| *** saksham has quit IRC | 01:15 | |
| *** jwy has quit IRC | 01:17 | |
| *** yamamoto has joined #openstack-horizon | 01:18 | |
| *** tqtran has quit IRC | 01:20 | |
| *** darrenc_afk is now known as darrenc | 01:21 | |
| *** julim has joined #openstack-horizon | 01:24 | |
| *** cbader has quit IRC | 01:25 | |
| *** liangbo has joined #openstack-horizon | 01:26 | |
| openstackgerrit | Merged openstack/horizon: Babel extractor translating inner tags https://review.openstack.org/213904 | 01:28 |
| *** tjones has quit IRC | 01:29 | |
| *** yamamoto has quit IRC | 01:30 | |
| openstackgerrit | Dan Siwiec proposed openstack/horizon: Angular metadata update modal https://review.openstack.org/184274 | 01:31 |
| *** liangbo has quit IRC | 01:31 | |
| *** lblanchard has quit IRC | 01:31 | |
| *** tjones has joined #openstack-horizon | 01:35 | |
| *** jwy has joined #openstack-horizon | 01:38 | |
| *** lyanchih has joined #openstack-horizon | 01:41 | |
| *** tyr has joined #openstack-horizon | 01:52 | |
| *** ducttape_ has quit IRC | 01:55 | |
| *** tyr has quit IRC | 01:57 | |
| *** liangbo has joined #openstack-horizon | 01:58 | |
| *** Piet has joined #openstack-horizon | 02:04 | |
| *** neelashah has joined #openstack-horizon | 02:13 | |
| openstackgerrit | lawrancejing proposed openstack/horizon: Populate volume/volume_snapshot status without current status https://review.openstack.org/191570 | 02:14 |
| *** yamamoto has joined #openstack-horizon | 02:16 | |
| *** tjones has quit IRC | 02:18 | |
| *** tqtran has joined #openstack-horizon | 02:19 | |
| *** tqtran has quit IRC | 02:21 | |
| *** Piet2 has joined #openstack-horizon | 02:22 | |
| *** KunalGandhi has quit IRC | 02:24 | |
| *** ybathia has joined #openstack-horizon | 02:27 | |
| *** neelashah has quit IRC | 02:28 | |
| *** neelashah has joined #openstack-horizon | 02:34 | |
| *** ybathia has quit IRC | 02:35 | |
| *** geoffarnold has joined #openstack-horizon | 02:35 | |
| *** geoffarnold has quit IRC | 02:36 | |
| *** geoffarnold has joined #openstack-horizon | 02:38 | |
| *** ducttape_ has joined #openstack-horizon | 02:41 | |
| *** ducttape_ has quit IRC | 02:47 | |
| *** ducttape_ has joined #openstack-horizon | 02:55 | |
| *** KunalGandhi has joined #openstack-horizon | 02:56 | |
| *** ducttape_ has quit IRC | 02:57 | |
| *** Piet2 has quit IRC | 03:08 | |
| *** tjones has joined #openstack-horizon | 03:09 | |
| *** liangbo has quit IRC | 03:09 | |
| *** rodrigods has quit IRC | 03:16 | |
| *** jwy has quit IRC | 03:17 | |
| *** rodrigods has joined #openstack-horizon | 03:19 | |
| *** tqtran has joined #openstack-horizon | 03:20 | |
| *** KunalGandhi has quit IRC | 03:21 | |
| *** tqtran has quit IRC | 03:22 | |
| *** raginbajin has quit IRC | 03:27 | |
| *** boltR has quit IRC | 03:28 | |
| *** boltR has joined #openstack-horizon | 03:29 | |
| *** raginbajin has joined #openstack-horizon | 03:29 | |
| *** jpomeroy_ has joined #openstack-horizon | 03:31 | |
| *** logan2 has quit IRC | 03:31 | |
| *** jpomeroy has quit IRC | 03:31 | |
| *** jpomeroy_ has quit IRC | 03:36 | |
| *** kiran-r has joined #openstack-horizon | 03:36 | |
| *** kiran-r has quit IRC | 03:36 | |
| *** yamamoto has quit IRC | 03:37 | |
| *** yamamoto has joined #openstack-horizon | 03:41 | |
| *** julim has quit IRC | 03:59 | |
| *** raginbajin has quit IRC | 04:10 | |
| *** garthb has joined #openstack-horizon | 04:13 | |
| *** lyanchih has quit IRC | 04:18 | |
| *** neelashah has quit IRC | 04:27 | |
| *** raginbajin has joined #openstack-horizon | 04:28 | |
| *** yamamoto has quit IRC | 04:33 | |
| *** mohankumar has joined #openstack-horizon | 04:36 | |
| *** yamamoto has joined #openstack-horizon | 04:41 | |
| *** tjones has quit IRC | 04:57 | |
| *** mohankumar has quit IRC | 04:59 | |
| *** cody-somerville has joined #openstack-horizon | 05:02 | |
| *** liangbo has joined #openstack-horizon | 05:12 | |
| *** KunalGandhi has joined #openstack-horizon | 05:13 | |
| *** boltR has quit IRC | 05:17 | |
| *** garthb has quit IRC | 05:19 | |
| *** peristeri has joined #openstack-horizon | 05:22 | |
| *** cody-somerville has quit IRC | 05:24 | |
| *** vgridnev has joined #openstack-horizon | 05:24 | |
| *** liangbo has quit IRC | 05:27 | |
| *** boltR has joined #openstack-horizon | 05:30 | |
| *** lhcheng_ has joined #openstack-horizon | 05:31 | |
| *** vgridnev has quit IRC | 05:38 | |
| *** KunalGandhi has quit IRC | 05:48 | |
| *** amotoki has joined #openstack-horizon | 05:50 | |
| *** jprovazn has joined #openstack-horizon | 05:53 | |
| *** mohankumar has joined #openstack-horizon | 05:55 | |
| *** lyanchih has joined #openstack-horizon | 06:02 | |
| *** peristeri has quit IRC | 06:03 | |
| *** peristeri has joined #openstack-horizon | 06:08 | |
| *** KunalGandhi has joined #openstack-horizon | 06:08 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/214466 | 06:12 |
| *** mrunge has joined #openstack-horizon | 06:13 | |
| *** KunalGandhi has quit IRC | 06:15 | |
| *** geoffarnold has quit IRC | 06:15 | |
| *** geoffarnold has joined #openstack-horizon | 06:16 | |
| *** lsmola has joined #openstack-horizon | 06:21 | |
| *** vgridnev has joined #openstack-horizon | 06:22 | |
| *** mhorban has quit IRC | 06:22 | |
| *** mhorban has joined #openstack-horizon | 06:29 | |
| *** markus_z has joined #openstack-horizon | 06:30 | |
| *** mhorban has left #openstack-horizon | 06:31 | |
| *** mhorban has joined #openstack-horizon | 06:33 | |
| *** Drago has quit IRC | 06:36 | |
| *** lhcheng_ has quit IRC | 06:40 | |
| *** Drago has joined #openstack-horizon | 06:40 | |
| openstackgerrit | Merged openstack/horizon: Added volume type description for volume type https://review.openstack.org/133872 | 07:01 |
| *** KingKhan has joined #openstack-horizon | 07:02 | |
| *** kiran-r has joined #openstack-horizon | 07:06 | |
| *** vgridnev has quit IRC | 07:07 | |
| *** kzaitsev_mb has joined #openstack-horizon | 07:14 | |
| *** peristeri has quit IRC | 07:18 | |
| *** jtomasek has quit IRC | 07:26 | |
| *** lyanchih has quit IRC | 07:27 | |
| *** belmoreira has joined #openstack-horizon | 07:28 | |
| *** kiran-r has quit IRC | 07:29 | |
| *** mohankumar has quit IRC | 07:33 | |
| *** kiran-r has joined #openstack-horizon | 07:33 | |
| *** lyanchih has joined #openstack-horizon | 07:40 | |
| *** MaxV has joined #openstack-horizon | 07:44 | |
| *** yamamoto has quit IRC | 07:46 | |
| *** yamamoto has joined #openstack-horizon | 07:48 | |
| *** romainh has joined #openstack-horizon | 07:51 | |
| *** kzaitsev_mb has quit IRC | 07:53 | |
| *** kzaitsev_mb has joined #openstack-horizon | 07:53 | |
| *** mpavlase has joined #openstack-horizon | 07:55 | |
| *** jcoufal has joined #openstack-horizon | 08:02 | |
| *** MaxV has quit IRC | 08:14 | |
| *** lyanchih has quit IRC | 08:18 | |
| *** lawrancejing has joined #openstack-horizon | 08:23 | |
| *** exploreshaifali has joined #openstack-horizon | 08:24 | |
| *** liangbo has joined #openstack-horizon | 08:25 | |
| lawrancejing | could some cores help review the patch : https://review.openstack.org/#/c/196336/ | 08:26 |
| *** vgridnev has joined #openstack-horizon | 08:29 | |
| *** KingKhan has quit IRC | 08:35 | |
| *** kzaitsev_mb has quit IRC | 08:35 | |
| *** mpavlase has quit IRC | 08:37 | |
| *** MaxV has joined #openstack-horizon | 08:41 | |
| *** sayan has joined #openstack-horizon | 08:45 | |
| *** lawrancejing has quit IRC | 08:47 | |
| *** mpavlase has joined #openstack-horizon | 08:48 | |
| *** kiran-r has quit IRC | 08:49 | |
| *** aix has joined #openstack-horizon | 08:54 | |
| *** sayan has quit IRC | 08:58 | |
| *** lyanchih has joined #openstack-horizon | 09:18 | |
| *** liangbo has quit IRC | 09:19 | |
| *** gerchardon has quit IRC | 09:22 | |
| *** gerchardon has joined #openstack-horizon | 09:23 | |
| robcresswell | haypo: Just looking at https://review.openstack.org/#/c/201098/8/horizon/tables/base.py | 09:23 |
| robcresswell | Why `db_attrs`? | 09:24 |
| *** bluex-pl has joined #openstack-horizon | 09:24 | |
| *** bluex-pl has quit IRC | 09:24 | |
| *** bluex-pl has joined #openstack-horizon | 09:25 | |
| *** tosky has joined #openstack-horizon | 09:30 | |
| *** mohankumar has joined #openstack-horizon | 09:30 | |
| *** kiran-r has joined #openstack-horizon | 09:34 | |
| *** akrivoka has joined #openstack-horizon | 09:34 | |
| *** DWfuturetec has joined #openstack-horizon | 09:35 | |
| *** _kiran_ has joined #openstack-horizon | 09:40 | |
| *** kiran-r has quit IRC | 09:41 | |
| robcresswell | dshaw___: Patch looks good. | 09:52 |
| *** _kiran_ is now known as kiran-r | 09:53 | |
| *** kiran-r has quit IRC | 09:53 | |
| *** kiran-r has joined #openstack-horizon | 09:54 | |
| *** jtomasek has joined #openstack-horizon | 09:55 | |
| *** exploreshaifali has quit IRC | 09:57 | |
| *** DWfuturetec has quit IRC | 10:00 | |
| *** exploreshaifali has joined #openstack-horizon | 10:02 | |
| *** yamamoto has quit IRC | 10:04 | |
| *** Samos123 has quit IRC | 10:06 | |
| *** belmoreira has quit IRC | 10:08 | |
| *** belmoreira has joined #openstack-horizon | 10:09 | |
| *** Samos123 has joined #openstack-horizon | 10:11 | |
| *** aortega has joined #openstack-horizon | 10:13 | |
| *** belmoreira has quit IRC | 10:14 | |
| *** belmoreira has joined #openstack-horizon | 10:15 | |
| *** kmartin has quit IRC | 10:16 | |
| *** _kiran_ has joined #openstack-horizon | 10:23 | |
| *** kiran-r has quit IRC | 10:24 | |
| *** kzaitsev_mb has joined #openstack-horizon | 10:26 | |
| *** _kiran_ has quit IRC | 10:29 | |
| *** MaxV has quit IRC | 10:30 | |
| openstackgerrit | Martin Hickey proposed openstack/horizon: Adds button to disable more than one domain at a time https://review.openstack.org/213193 | 10:35 |
| openstackgerrit | Karthik Suresh proposed openstack/horizon: Added small block to remove default panels https://review.openstack.org/213139 | 10:42 |
| *** Drago has quit IRC | 10:42 | |
| *** kiran-r has joined #openstack-horizon | 10:43 | |
| *** _kiran_ has joined #openstack-horizon | 10:45 | |
| *** _kiran_ has quit IRC | 10:45 | |
| *** _kiran_ has joined #openstack-horizon | 10:45 | |
| openstackgerrit | Karthik Suresh proposed openstack/horizon: Added small block to remove default panels https://review.openstack.org/213139 | 10:46 |
| *** _kiran_ has quit IRC | 10:46 | |
| *** _kiran_ has joined #openstack-horizon | 10:47 | |
| *** belmoreira has quit IRC | 10:48 | |
| *** kiran-r has quit IRC | 10:48 | |
| *** _kiran_ has quit IRC | 10:48 | |
| *** kiran-r has joined #openstack-horizon | 10:49 | |
| robcresswell | mrunge: Minot patch related to django deprecations in 1.7 https://review.openstack.org/#/c/173921/ Not sure if it had been done elsewhere. | 10:57 |
| robcresswell | Minor* | 10:57 |
| *** MaxV has joined #openstack-horizon | 10:57 | |
| *** peristeri has joined #openstack-horizon | 10:58 | |
| *** yamamoto_ has joined #openstack-horizon | 10:58 | |
| mrunge | robcresswell, /me clicks | 10:58 |
| *** ccesario_ has quit IRC | 10:59 | |
| mrunge | robcresswell, thank you. could you please use bp drop-django14-support for tracking purposes? | 11:00 |
| robcresswell | Sure | 11:00 |
| mrunge | awesome! | 11:00 |
| *** MaxV has quit IRC | 11:02 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Address deprecated templatetags in Django 1.7 https://review.openstack.org/173921 | 11:05 |
| robcresswell | mrunge: Added, and it seems to have tracked properly. | 11:06 |
| mrunge | yes, great :D | 11:06 |
| *** doug-fish has joined #openstack-horizon | 11:07 | |
| christophs | Hi, can someone please review this: https://review.openstack.org/#/c/213054/ | 11:10 |
| robcresswell | christophs: Hmm.. I've +2'd it, but I'm a little unsure | 11:17 |
| christophs | robcresswell, about support of the old glance backend? | 11:18 |
| robcresswell | Indeed | 11:18 |
| mrunge | christophs, we used to support versions n-1. I wouldn't bet you'd be hitting other issues with way newer horizon versions | 11:19 |
| *** vgridnev has quit IRC | 11:19 | |
| robcresswell | I was literally just pinging you :D | 11:20 |
| robcresswell | I don't know if we have any actual rules about it now. | 11:20 |
| mrunge | we don't | 11:21 |
| robcresswell | mrunge: So the issue is a key that always exists in Glance since Icehouse, but not in Havana | 11:21 |
| robcresswell | The patch adds a getattr to the key, so its very minor | 11:22 |
| mrunge | it was more an unwritten rule, that horizon worked cross versions | 11:22 |
| *** jtomasek has quit IRC | 11:22 | |
| mrunge | I'm all in, if it's a bug and we can fix it, we should do | 11:22 |
| mrunge | and backport | 11:22 |
| robcresswell | https://review.openstack.org/#/c/213054/ | 11:22 |
| robcresswell | Yes, agreed, definite backport | 11:23 |
| robcresswell | christophs: Please propose backport after master merge. | 11:23 |
| mrunge | added my vote | 11:24 |
| christophs | Okay thank you two. robcresswell how can I do this? | 11:24 |
| robcresswell | checkout the stable branch instead of master, then cherry-pick the commit id | 11:26 |
| robcresswell | One moment, I'll find the doc | 11:26 |
| *** DWfuturetec has joined #openstack-horizon | 11:26 | |
| robcresswell | christophs: https://wiki.openstack.org/wiki/StableBranch#Proposing_Fixes | 11:27 |
| *** vgridnev has joined #openstack-horizon | 11:27 | |
| christophs | robcresswell, Thank you, will do this! | 11:29 |
| *** mohankumar has quit IRC | 11:30 | |
| robcresswell | Thanks | 11:33 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix integration tests https://review.openstack.org/214238 | 11:33 |
| *** lyanchih has quit IRC | 11:34 | |
| *** yamamoto_ has quit IRC | 11:35 | |
| *** yamamoto has joined #openstack-horizon | 11:36 | |
| *** yamamoto has quit IRC | 11:37 | |
| *** jtomasek has joined #openstack-horizon | 11:37 | |
| *** yamamoto has joined #openstack-horizon | 11:37 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix integration tests https://review.openstack.org/214238 | 11:38 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix integration tests https://review.openstack.org/214238 | 11:40 |
| *** kzaitsev_mb has quit IRC | 11:42 | |
| *** doug-fish has quit IRC | 11:54 | |
| *** KingKhan has joined #openstack-horizon | 11:54 | |
| *** sayan has joined #openstack-horizon | 11:55 | |
| *** pc_m_ has joined #openstack-horizon | 11:57 | |
| *** tmazur has joined #openstack-horizon | 12:00 | |
| david-lyle | Starting the horizon meeting in #openstack-meeting-3 | 12:01 |
| *** kzaitsev_mb has joined #openstack-horizon | 12:02 | |
| david-lyle | looking at you robcresswell :) | 12:02 |
| david-lyle | I didn't get a harumph outta that guy | 12:03 |
| david-lyle | http://memecrunch.com/meme/1I5B8/harumph/image.png | 12:03 |
| robcresswell | Ha, I'm here/ there | 12:04 |
| *** doug-fish has joined #openstack-horizon | 12:05 | |
| *** mohankumar has joined #openstack-horizon | 12:06 | |
| *** julim has joined #openstack-horizon | 12:10 | |
| *** ducttape_ has joined #openstack-horizon | 12:12 | |
| *** amotoki_ has joined #openstack-horizon | 12:17 | |
| *** belmoreira has joined #openstack-horizon | 12:19 | |
| *** belmoreira has quit IRC | 12:19 | |
| *** MaxV has joined #openstack-horizon | 12:22 | |
| *** chlong has joined #openstack-horizon | 12:27 | |
| *** amotoki_ has quit IRC | 12:27 | |
| *** KingKhan has quit IRC | 12:29 | |
| *** yamamoto has quit IRC | 12:32 | |
| *** gerchardon has quit IRC | 12:33 | |
| *** KingKhan has joined #openstack-horizon | 12:34 | |
| *** logan2 has joined #openstack-horizon | 12:39 | |
| *** julim has quit IRC | 12:41 | |
| *** julim has joined #openstack-horizon | 12:42 | |
| *** yamamoto has joined #openstack-horizon | 12:43 | |
| *** amotoki_ has joined #openstack-horizon | 12:47 | |
| *** yamamoto has quit IRC | 12:47 | |
| *** _crobertsrh is now known as crobertsrh | 12:48 | |
| *** pauloewerton has joined #openstack-horizon | 12:49 | |
| *** KingKhan has quit IRC | 12:50 | |
| *** lapalm has joined #openstack-horizon | 12:52 | |
| *** MaxV has quit IRC | 12:53 | |
| *** exploreshaifali has quit IRC | 12:54 | |
| *** lyanchih has joined #openstack-horizon | 12:54 | |
| *** tosky has quit IRC | 12:57 | |
| *** jcoufal_ has joined #openstack-horizon | 12:58 | |
| *** ducttape_ has quit IRC | 13:00 | |
| *** jcoufal has quit IRC | 13:01 | |
| *** wimdc has joined #openstack-horizon | 13:02 | |
| r1chardj0n3s | g'night all, catch you tomorrow at the next meeting (BPs!) | 13:02 |
| neillc | night all | 13:02 |
| david-lyle | goodnight | 13:02 |
| mrunge | goodnight | 13:03 |
| tsufiev | bye ) | 13:03 |
| david-lyle | of course it's 7am here | 13:03 |
| david-lyle | :D | 13:03 |
| mrunge | david-lyle, are you saying, r1chardj0n3s is supposed to get to work? | 13:04 |
| david-lyle | no, just that I'm still here | 13:05 |
| david-lyle | seems like there is no 1300 UTC meeting in meeting-3, but better to close on the hour | 13:05 |
| david-lyle | never know when one will pop up | 13:06 |
| *** doug-fish has quit IRC | 13:06 | |
| openstackgerrit | Wim De Clercq proposed openstack/horizon: Add allowed address pair extension UI for neutron ports. https://review.openstack.org/193079 | 13:07 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix integration tests https://review.openstack.org/214238 | 13:08 |
| kfox1111 | david-lyle: how close is the app catalog review? | 13:09 |
| david-lyle | kfox1111: in my queue or in general? | 13:10 |
| kfox1111 | kzaitsev_mb is thinking about suggesting splitting the patch. But I'm a bit worried that will just slow reviews down further. | 13:10 |
| kfox1111 | either? :) | 13:10 |
| *** DWfuturetec has quit IRC | 13:10 | |
| david-lyle | can you link again. I'm sure I have it open already, but also sure I won't find it easily | 13:11 |
| kfox1111 | https://review.openstack.org/#/c/206773/ | 13:11 |
| *** petertr7_away is now known as petertr7 | 13:11 | |
| david-lyle | split why? | 13:12 |
| kfox1111 | cause there's kind of two things in the patch. passing params to forms and the start of a heatapi rest service. | 13:13 |
| *** pc_m_ has quit IRC | 13:15 | |
| kfox1111 | he figured it might review better seperately. | 13:16 |
| *** tosky has joined #openstack-horizon | 13:16 | |
| david-lyle | kfox1111: I think either way is reasonable | 13:16 |
| kfox1111 | I'm thinking if its close, then we just leave it together? | 13:16 |
| david-lyle | I'm ok with merged patch | 13:17 |
| david-lyle | it's close | 13:17 |
| kfox1111 | k. thanks. | 13:17 |
| david-lyle | I just commented on something minor | 13:17 |
| kfox1111 | cool. thanks for the review. | 13:17 |
| david-lyle | but didn't any large issues, I'll dig more deeply | 13:17 |
| *** kzaitsev_ip has joined #openstack-horizon | 13:17 | |
| kfox1111 | ah. yeah. I'll fix that. | 13:18 |
| david-lyle | also, there is a horizon.version.py that will has version_info | 13:19 |
| david-lyle | I know you were asking about that | 13:19 |
| david-lyle | horizon/version.py | 13:20 |
| kfox1111 | oh, cool. thanks. :) | 13:20 |
| *** MaxV has joined #openstack-horizon | 13:20 | |
| kfox1111 | ah. that should work. :) | 13:20 |
| *** doug-fish has joined #openstack-horizon | 13:21 | |
| david-lyle | is that sufficient or will you need a versioned API? | 13:21 |
| *** doug-fish has quit IRC | 13:21 | |
| kfox1111 | I think that will work. | 13:21 |
| david-lyle | so your plugin when shipped will be capped? | 13:22 |
| *** doug-fish has joined #openstack-horizon | 13:22 | |
| *** doug-fish has quit IRC | 13:22 | |
| david-lyle | I know I work with 8.0.0, but 9.0.0 could break me horribly | 13:22 |
| kfox1111 | no. if its not a known version, it will assume trunk I think. | 13:22 |
| david-lyle | but with no guarantee of API stability, you could be broken on trunk at any time | 13:23 |
| kfox1111 | Its mostly to ensure if I upgrade the plugin, I can downgrade features if its known not to work on a particular version. | 13:23 |
| *** doug-fish has joined #openstack-horizon | 13:23 | |
| david-lyle | the best you'll have is I know it worked with 8.0.0 | 13:23 |
| david-lyle | beyond that (shrug) | 13:23 |
| *** doug-fis_ has joined #openstack-horizon | 13:24 | |
| kfox1111 | so, say the launch wizard. at some point, the ajax-modal link I have to pop up the wizard breaks. | 13:24 |
| kfox1111 | so I update it, and leave the link the old way for version <= 8 or something. | 13:24 |
| david-lyle | I'm think even the heat API call your adding | 13:24 |
| david-lyle | *thinking | 13:24 |
| david-lyle | *you're | 13:25 |
| * david-lyle hopes coffee starts working soon | 13:25 | |
| kfox1111 | yeah. I'm hoping most of the stuf I can programatically probe from js to know what the right thing to do is. | 13:25 |
| kfox1111 | but for the ajax-modal stuff, Its kind of "magic". | 13:26 |
| kfox1111 | so having a rough idea of horizon's version would help. | 13:26 |
| david-lyle | if you've been following the JS code stability in Horizon this release, I'd be super worried | 13:26 |
| david-lyle | but maybe that's just me | 13:27 |
| kfox1111 | heh. I was having to rebase this patch multiple times a day for a while. :( | 13:27 |
| openstackgerrit | Kevin Fox proposed openstack/horizon: A few fixes to make the App Catalog plugin work. https://review.openstack.org/206773 | 13:27 |
| *** doug-fish has quit IRC | 13:28 | |
| kfox1111 | fixed the copyright thing. | 13:28 |
| david-lyle | thanks | 13:28 |
| *** jpomeroy has joined #openstack-horizon | 13:29 | |
| *** lblanchard has joined #openstack-horizon | 13:36 | |
| *** kiran-r has quit IRC | 13:42 | |
| *** MaxV has quit IRC | 13:43 | |
| *** mohankumar has quit IRC | 13:46 | |
| *** yamamoto has joined #openstack-horizon | 13:46 | |
| *** yamamoto has quit IRC | 13:46 | |
| *** yamamoto has joined #openstack-horizon | 13:46 | |
| *** yamamoto has quit IRC | 13:46 | |
| *** dboik has joined #openstack-horizon | 13:46 | |
| *** yamamoto has joined #openstack-horizon | 13:47 | |
| *** jtriley has joined #openstack-horizon | 13:48 | |
| *** jcoufal_ has quit IRC | 13:49 | |
| *** jcoufal has joined #openstack-horizon | 13:51 | |
| *** yamamoto has quit IRC | 13:56 | |
| *** yamamoto has joined #openstack-horizon | 13:56 | |
| *** yamamoto has quit IRC | 13:56 | |
| *** yamamoto has joined #openstack-horizon | 13:57 | |
| *** lapalm has quit IRC | 13:58 | |
| *** neelashah has joined #openstack-horizon | 13:59 | |
| *** vgridnev has quit IRC | 14:00 | |
| *** doug-fish has joined #openstack-horizon | 14:00 | |
| *** dboik has quit IRC | 14:02 | |
| *** yamamoto has quit IRC | 14:03 | |
| *** doug-fis_ has quit IRC | 14:03 | |
| *** linkedinyou has quit IRC | 14:04 | |
| *** MaxV has joined #openstack-horizon | 14:09 | |
| *** petertr7 is now known as petertr7_away | 14:10 | |
| *** jtriley has quit IRC | 14:13 | |
| wimdc | Could anyone have a look at https://review.openstack.org/#/c/205423/ too? Relates to this https://launchpad.net/bugs/1234912 | 14:14 |
| openstack | Launchpad bug 1234912 in OpenStack Dashboard (Horizon) "SNAT option for neutron" [Wishlist,In progress] - Assigned to Wim De Clercq (wim-de-clercq) | 14:14 |
| *** doug-fish has quit IRC | 14:17 | |
| openstackgerrit | Brianna Poulos proposed openstack/horizon: Add volume type encryption update https://review.openstack.org/72024 | 14:18 |
| *** vgridnev has joined #openstack-horizon | 14:18 | |
| *** doug-fish has joined #openstack-horizon | 14:19 | |
| *** vgridnev has quit IRC | 14:19 | |
| *** ducttape_ has joined #openstack-horizon | 14:20 | |
| *** absubram has joined #openstack-horizon | 14:23 | |
| *** ducttape_ has quit IRC | 14:24 | |
| *** mpavlase has quit IRC | 14:25 | |
| *** ducttape_ has joined #openstack-horizon | 14:25 | |
| *** ducttape_ has quit IRC | 14:25 | |
| *** yamamoto has joined #openstack-horizon | 14:27 | |
| *** yamamoto has quit IRC | 14:27 | |
| *** yamamoto has joined #openstack-horizon | 14:28 | |
| *** doug-fish has quit IRC | 14:28 | |
| *** doug-fish has joined #openstack-horizon | 14:29 | |
| *** doug-fish has quit IRC | 14:32 | |
| *** vgridnev has joined #openstack-horizon | 14:32 | |
| *** doug-fish has joined #openstack-horizon | 14:32 | |
| robcresswell | wimdc: It's on my list. Unfortunately. our lab has decided there will be no DNS today which is making work quite tricky. | 14:32 |
| wimdc | :) thanks robcresswell | 14:33 |
| openstackgerrit | Merged openstack/horizon: Moving translation to HTML for launch-instance network step https://review.openstack.org/210366 | 14:33 |
| *** vijendar has joined #openstack-horizon | 14:35 | |
| *** hurgleburgler has joined #openstack-horizon | 14:36 | |
| *** hurgleburgler has quit IRC | 14:36 | |
| *** doug-fish has quit IRC | 14:37 | |
| *** lapalm has joined #openstack-horizon | 14:38 | |
| *** lapalm has quit IRC | 14:38 | |
| *** doug-fish has joined #openstack-horizon | 14:38 | |
| *** lapalm has joined #openstack-horizon | 14:38 | |
| *** lapalm has quit IRC | 14:39 | |
| *** jtriley has joined #openstack-horizon | 14:39 | |
| *** tmazur has quit IRC | 14:40 | |
| *** tvanderwiel has joined #openstack-horizon | 14:40 | |
| *** petertr7_away is now known as petertr7 | 14:40 | |
| *** tvanderwiel has left #openstack-horizon | 14:40 | |
| *** lapalm has joined #openstack-horizon | 14:41 | |
| *** lapalm has quit IRC | 14:41 | |
| *** lapalm has joined #openstack-horizon | 14:42 | |
| *** jprovazn has quit IRC | 14:42 | |
| *** neelashah has quit IRC | 14:43 | |
| *** ducttape_ has joined #openstack-horizon | 14:44 | |
| *** jcoufal_ has joined #openstack-horizon | 14:45 | |
| *** lapalm has quit IRC | 14:47 | |
| *** lapalm has joined #openstack-horizon | 14:47 | |
| *** jcoufal has quit IRC | 14:48 | |
| *** lapalm has quit IRC | 14:51 | |
| *** fedexo has joined #openstack-horizon | 14:53 | |
| *** linkedinyou has joined #openstack-horizon | 14:58 | |
| *** vgridnev has quit IRC | 14:58 | |
| *** vgridnev has joined #openstack-horizon | 14:59 | |
| *** ccesario has joined #openstack-horizon | 14:59 | |
| *** geoffarnold has quit IRC | 15:01 | |
| *** logan2 has quit IRC | 15:01 | |
| *** peristeri has quit IRC | 15:01 | |
| *** vgridnev has quit IRC | 15:01 | |
| *** garthb has joined #openstack-horizon | 15:03 | |
| *** logan2 has joined #openstack-horizon | 15:05 | |
| *** zul has joined #openstack-horizon | 15:07 | |
| *** MaxV has quit IRC | 15:12 | |
| *** MaxV has joined #openstack-horizon | 15:15 | |
| *** bpokorny has joined #openstack-horizon | 15:18 | |
| *** vgridnev has joined #openstack-horizon | 15:21 | |
| *** mohankumar has joined #openstack-horizon | 15:22 | |
| *** MaxV has quit IRC | 15:22 | |
| *** zul has quit IRC | 15:23 | |
| *** doug-fish has quit IRC | 15:24 | |
| *** doug-fish has joined #openstack-horizon | 15:24 | |
| *** Ephur has quit IRC | 15:25 | |
| *** petertr7 is now known as petertr7_away | 15:26 | |
| *** sayan has quit IRC | 15:27 | |
| *** petertr7_away is now known as petertr7 | 15:27 | |
| *** jbell8 has joined #openstack-horizon | 15:27 | |
| *** Drago has joined #openstack-horizon | 15:29 | |
| *** Drago has quit IRC | 15:30 | |
| *** Drago has joined #openstack-horizon | 15:30 | |
| *** hurgleburgler has joined #openstack-horizon | 15:30 | |
| *** hurgleburgler has quit IRC | 15:31 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Integration tests no longer use form's fields ordering for matching https://review.openstack.org/214238 | 15:32 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Adapt integration tests to recent devstack and page layout changes https://review.openstack.org/214670 | 15:32 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Integration tests no longer rely on entities' display names in tables https://review.openstack.org/214671 | 15:32 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Adapt integration tests to recent devstack and page layout changes https://review.openstack.org/214670 | 15:34 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Integration tests no longer use form's fields ordering for matching https://review.openstack.org/214238 | 15:34 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Integration tests no longer rely on entities' display names in tables https://review.openstack.org/214671 | 15:34 |
| *** hurgleburgler has joined #openstack-horizon | 15:34 | |
| *** vgridnev has quit IRC | 15:37 | |
| *** tyr has joined #openstack-horizon | 15:37 | |
| *** tyr has quit IRC | 15:38 | |
| tosky | tsufiev: do you think that the failures of Sahara jobs are unrelated to the other fixes you proposed? | 15:41 |
| tsufiev | tosky, most likely they are related. I'm deploying cluster with Sahara right now, and once I am able to debug Sahara tests locally, I'll upload another commit | 15:42 |
| tosky | tsufiev: thanks! | 15:42 |
| *** Piet has quit IRC | 15:42 | |
| tsufiev | right now I'd like others to see that integration tests are passing | 15:43 |
| tsufiev | tosky, yw. the sooner we fix it, the better chances that job will be made voting again | 15:43 |
| tosky | yeah, I was waiting for the results as well; then maybe it would be easy to reenable the tests with a fake review | 15:43 |
| tosky | jenkins results of the current reviews | 15:44 |
| *** zul has joined #openstack-horizon | 15:45 | |
| *** tyr has joined #openstack-horizon | 15:46 | |
| *** tyr_ has joined #openstack-horizon | 15:47 | |
| *** tyr has quit IRC | 15:47 | |
| *** petertr7 is now known as petertr7_away | 15:49 | |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon: Display admin users in project table and detail pages https://review.openstack.org/214220 | 15:49 |
| *** MaxV has joined #openstack-horizon | 15:49 | |
| *** tyr_ has quit IRC | 15:51 | |
| *** DWfuturetec has joined #openstack-horizon | 15:53 | |
| *** Sukhdev has joined #openstack-horizon | 15:54 | |
| *** zul has quit IRC | 15:55 | |
| *** mwhagedorn has joined #openstack-horizon | 15:58 | |
| *** SimonChung has joined #openstack-horizon | 15:58 | |
| *** fedexo has quit IRC | 16:02 | |
| *** lyanchih has quit IRC | 16:02 | |
| *** lapalm has joined #openstack-horizon | 16:03 | |
| *** kiran-r has joined #openstack-horizon | 16:03 | |
| *** geoffarnold has joined #openstack-horizon | 16:03 | |
| *** cbader has joined #openstack-horizon | 16:05 | |
| *** SimonChung1 has joined #openstack-horizon | 16:05 | |
| *** jbell8_ has joined #openstack-horizon | 16:05 | |
| *** jbell8 has quit IRC | 16:05 | |
| *** exploreshaifali has joined #openstack-horizon | 16:06 | |
| *** lapalm has quit IRC | 16:07 | |
| *** Piet has joined #openstack-horizon | 16:08 | |
| *** SimonChung has quit IRC | 16:09 | |
| *** kmartin has joined #openstack-horizon | 16:11 | |
| *** mohankumar has quit IRC | 16:16 | |
| *** jtriley has quit IRC | 16:17 | |
| *** jcoufal_ has quit IRC | 16:18 | |
| *** jtriley has joined #openstack-horizon | 16:20 | |
| *** gyee has joined #openstack-horizon | 16:20 | |
| *** bluex-pl has quit IRC | 16:22 | |
| *** petertr7_away is now known as petertr7 | 16:24 | |
| *** _kiran_ has joined #openstack-horizon | 16:27 | |
| *** mwhagedorn has quit IRC | 16:30 | |
| *** mwhagedorn_ has joined #openstack-horizon | 16:30 | |
| *** kiran-r has quit IRC | 16:31 | |
| *** kzaitsev_ip has quit IRC | 16:32 | |
| *** petertr7 is now known as petertr7_away | 16:34 | |
| *** lapalm has joined #openstack-horizon | 16:35 | |
| *** lapalm_ has joined #openstack-horizon | 16:36 | |
| *** lapalm_ has quit IRC | 16:36 | |
| *** lapalm_ has joined #openstack-horizon | 16:37 | |
| *** kzaitsev_mb has quit IRC | 16:37 | |
| openstackgerrit | Merged openstack/horizon: Fix attribute error with old glance backend https://review.openstack.org/213054 | 16:39 |
| *** lapalm has quit IRC | 16:39 | |
| *** zul has joined #openstack-horizon | 16:40 | |
| *** lhcheng has joined #openstack-horizon | 16:41 | |
| *** mwhagedorn_ has quit IRC | 16:41 | |
| *** rajatvig has joined #openstack-horizon | 16:43 | |
| *** tyr has joined #openstack-horizon | 16:45 | |
| *** jtomasek has quit IRC | 16:46 | |
| *** romainh has quit IRC | 16:46 | |
| *** zul has quit IRC | 16:47 | |
| *** mwhagedorn has joined #openstack-horizon | 16:48 | |
| *** MaxV has quit IRC | 16:49 | |
| *** zul has joined #openstack-horizon | 16:49 | |
| *** KunalGandhi has joined #openstack-horizon | 16:51 | |
| *** garthb has quit IRC | 16:52 | |
| *** vgridnev has joined #openstack-horizon | 16:54 | |
| *** doug-fish has quit IRC | 16:56 | |
| *** mohankumar has joined #openstack-horizon | 16:56 | |
| Piet | Can the team leave feedback on a proposal to change the selecting table for flavors? https://openstack.invisionapp.com/d/main/#/console/4168226/90954366/comments | 16:56 |
| *** doug-fish has joined #openstack-horizon | 16:56 | |
| *** lapalm_ has quit IRC | 16:57 | |
| *** mwhagedorn has quit IRC | 16:57 | |
| *** lapalm has joined #openstack-horizon | 16:58 | |
| openstackgerrit | Dan Siwiec proposed openstack/horizon: Angular metadata update modal https://review.openstack.org/184274 | 16:59 |
| *** _kiran_ has quit IRC | 16:59 | |
| *** sayan has joined #openstack-horizon | 17:00 | |
| openstackgerrit | Merged openstack/horizon: User email no longer raises exceptions if missing https://review.openstack.org/207392 | 17:01 |
| *** lapalm has quit IRC | 17:02 | |
| *** jingjing_ren has joined #openstack-horizon | 17:03 | |
| *** jingjing_ren has quit IRC | 17:03 | |
| *** rhagarty has quit IRC | 17:03 | |
| *** rhagarty_ has quit IRC | 17:04 | |
| *** cbader has quit IRC | 17:04 | |
| *** cbader has joined #openstack-horizon | 17:04 | |
| *** jingjing_ren has joined #openstack-horizon | 17:04 | |
| *** rhagarty_ has joined #openstack-horizon | 17:04 | |
| *** rhagarty has joined #openstack-horizon | 17:04 | |
| tsufiev | tosky, https://review.openstack.org/#/c/214238/ hurray! | 17:05 |
| tosky | tsufiev: ooooh! | 17:06 |
| *** petertr7_away is now known as petertr7 | 17:07 | |
| robcresswell | david-lyle: I *may* not be in the meeting in a few hours. Forgot its at 9pm :p | 17:07 |
| *** kmartin has quit IRC | 17:08 | |
| *** kmartin has joined #openstack-horizon | 17:08 | |
| *** cbader has quit IRC | 17:10 | |
| *** rhagarty has quit IRC | 17:10 | |
| *** cbader has joined #openstack-horizon | 17:10 | |
| *** rhagarty has joined #openstack-horizon | 17:10 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: API for getting and updating quotas https://review.openstack.org/207126 | 17:13 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Add angular defaults panel for admin https://review.openstack.org/205296 | 17:13 |
| *** markus_z has quit IRC | 17:14 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: API for getting and updating quotas https://review.openstack.org/207126 | 17:15 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Add angular defaults panel for admin https://review.openstack.org/205296 | 17:15 |
| *** clu_ has joined #openstack-horizon | 17:17 | |
| haypo | robcresswell: hi. for https://review.openstack.org/#/c/201098/ i agree that db_attrs name is confusing. in fact, i understood that it's a dataBASE whereas it's a dataTABLE | 17:18 |
| haypo | robcresswell: is it worth to update the patch? | 17:18 |
| robcresswell | haypo: If you do, I will +2 it again quickly :) | 17:19 |
| robcresswell | It did not seem worth blocking over a variable name, but IMO db_attrs is misleading. | 17:19 |
| haypo | robcresswell: which name do you suggest? | 17:19 |
| haypo | robcresswell: do you like "dt_attrs"? | 17:20 |
| robcresswell | haha, yeah thats fine | 17:20 |
| haypo | robcresswell: by the way, i have to discuss with george. there is an issue in run_tests.sh, it doesn't run horizon tests on python 3.4 | 17:21 |
| haypo | we already discuss that, but i don't remember the discussion :-D | 17:22 |
| haypo | it's an issue with virutal environment, something like bad | 17:22 |
| *** dsneddon_brb is now known as dsneddon | 17:22 | |
| openstackgerrit | Victor Stinner proposed openstack/horizon: Fix code that modified dictionaries while iterating over them https://review.openstack.org/201098 | 17:23 |
| openstackgerrit | Victor Stinner proposed openstack/horizon: Port last test to Python 3 https://review.openstack.org/214291 | 17:23 |
| *** zul has quit IRC | 17:23 | |
| haypo | robcresswell: ^^ here you have | 17:23 |
| *** tosky has quit IRC | 17:24 | |
| robcresswell | haypo: Just looking over code again | 17:25 |
| *** saksham has joined #openstack-horizon | 17:27 | |
| robcresswell | Food time. | 17:27 |
| *** DWfuturetec has quit IRC | 17:28 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Fix doc reference in settings.rst: 'hz' should be 'horizon' https://review.openstack.org/214289 | 17:28 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - use DI in launch instance model https://review.openstack.org/211741 | 17:31 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Run ESLint on Javascript files in dashboards https://review.openstack.org/214057 | 17:32 |
| *** mohankumar has quit IRC | 17:32 | |
| *** mwhagedorn has joined #openstack-horizon | 17:33 | |
| *** Piet has quit IRC | 17:35 | |
| *** jbell8_ has quit IRC | 17:35 | |
| *** Piet has joined #openstack-horizon | 17:36 | |
| *** exploreshaifali has quit IRC | 17:38 | |
| *** ^Gal^ has quit IRC | 17:41 | |
| *** Piet has quit IRC | 17:41 | |
| *** jwy has joined #openstack-horizon | 17:43 | |
| *** Piet has joined #openstack-horizon | 17:45 | |
| *** tosky has joined #openstack-horizon | 17:52 | |
| *** SimonChung has joined #openstack-horizon | 17:54 | |
| *** Sukhdev has quit IRC | 17:54 | |
| *** KunalGan_ has joined #openstack-horizon | 17:55 | |
| *** aix has quit IRC | 17:55 | |
| *** ericpeterson has joined #openstack-horizon | 17:55 | |
| *** akrivoka has quit IRC | 17:55 | |
| *** mwhagedorn has quit IRC | 17:55 | |
| *** SimonChung1 has quit IRC | 17:55 | |
| *** kiran-r has joined #openstack-horizon | 17:55 | |
| *** Sukhdev has joined #openstack-horizon | 17:56 | |
| *** mwhagedorn has joined #openstack-horizon | 17:56 | |
| *** KunalGandhi has quit IRC | 17:57 | |
| *** akrivoka has joined #openstack-horizon | 17:57 | |
| *** SimonChung has quit IRC | 17:57 | |
| *** ducttape_ has quit IRC | 17:57 | |
| *** lapalm has joined #openstack-horizon | 17:57 | |
| *** lapalm has quit IRC | 17:57 | |
| *** DWfuturetec has joined #openstack-horizon | 17:58 | |
| *** lapalm has joined #openstack-horizon | 17:58 | |
| *** kmARC has quit IRC | 17:58 | |
| *** kmARC has joined #openstack-horizon | 17:59 | |
| *** jbell8 has joined #openstack-horizon | 18:03 | |
| *** kiran-r has quit IRC | 18:05 | |
| *** ericpeterson has quit IRC | 18:09 | |
| *** rdopiera has joined #openstack-horizon | 18:11 | |
| *** mwhagedorn has quit IRC | 18:11 | |
| *** tvanderwiel has joined #openstack-horizon | 18:13 | |
| *** tvanderwiel has left #openstack-horizon | 18:13 | |
| *** rdopiera has quit IRC | 18:14 | |
| *** rdopiera has joined #openstack-horizon | 18:14 | |
| *** Piet has quit IRC | 18:16 | |
| *** geoffarnold has quit IRC | 18:20 | |
| *** lhcheng has quit IRC | 18:20 | |
| *** danieru has quit IRC | 18:26 | |
| *** stevemar has joined #openstack-horizon | 18:28 | |
| *** geoffarnold has joined #openstack-horizon | 18:31 | |
| *** bapalm has quit IRC | 18:31 | |
| *** yamamoto has quit IRC | 18:32 | |
| *** kmartin has quit IRC | 18:32 | |
| *** bapalm has joined #openstack-horizon | 18:32 | |
| *** tqtran has joined #openstack-horizon | 18:33 | |
| *** SimonChung has joined #openstack-horizon | 18:36 | |
| *** Piet has joined #openstack-horizon | 18:41 | |
| haypo | rdopiera: oh, i didn't know that you was a core :) good to know :) | 18:42 |
| *** exploreshaifali has joined #openstack-horizon | 18:42 | |
| *** MaxV has joined #openstack-horizon | 18:44 | |
| *** lhcheng has joined #openstack-horizon | 18:47 | |
| *** MaxV has quit IRC | 18:49 | |
| rdopiera | haypo: I had been a little inactive recently, but I'm trying to catch up | 18:49 |
| *** zul has joined #openstack-horizon | 18:50 | |
| haypo | rdopiera: do you know run_tests.sh? it runs "manage.py test" but on python 3, nosetests (executed by manage.py test) doesn't find any test | 18:50 |
| openstackgerrit | Chad Roberts proposed openstack/horizon: Adding manila shares as an option for data sources https://review.openstack.org/214754 | 18:51 |
| krotscheck | clu_: I've got two reviews on eslint-config-openstack waiting for a second +2. Do you have a minute to look at them? https://review.openstack.org/#/q/status:open+project:openstack/eslint-config-openstack,n,z | 18:51 |
| *** geoffarnold has quit IRC | 18:52 | |
| rdopiera | haypo: I guess the best way to run tests on py3 is tox | 18:53 |
| *** geoffarnold has joined #openstack-horizon | 18:54 | |
| haypo | rdopiera: i'm trying to understand why "tox -e py34" only executes openstack_dashboard tests, not horizon tests | 18:54 |
| *** hurgleburgler has quit IRC | 18:54 | |
| rdopiera | my understanding is that tox doesn't use run_tests.sh | 18:55 |
| *** kmartin has joined #openstack-horizon | 18:56 | |
| *** hurgleburgler has joined #openstack-horizon | 18:58 | |
| *** tyr has quit IRC | 18:58 | |
| david-lyle | haypo: https://github.com/openstack/horizon/blob/master/run_tests.sh#L362 | 18:58 |
| *** hurgleburgler has quit IRC | 18:59 | |
| david-lyle | manage is called for each | 18:59 |
| david-lyle | rdopiera: tox just calls run_tests | 19:01 |
| david-lyle | https://github.com/openstack/horizon/blob/master/tox.ini#L35 | 19:02 |
| rdopiera | david-lyle: oh, sorry then | 19:02 |
| *** ducttape_ has joined #openstack-horizon | 19:02 | |
| rdopiera | I must have mixed that up with how it's done in tuskar-ui | 19:02 |
| david-lyle | so while 3.4 is an env in tox.ini, it has no definition to run run_tests.sh | 19:03 |
| david-lyle | which may be the source of the problem | 19:03 |
| david-lyle | ?? | 19:03 |
| rdopiera | most likely | 19:03 |
| *** mwhagedorn has joined #openstack-horizon | 19:04 | |
| rdopiera | but on the other hand, neither does py27 | 19:04 |
| david-lyle | good point, happens on line 30 | 19:07 |
| david-lyle | err 20 | 19:07 |
| *** stevemar has quit IRC | 19:07 | |
| *** danieru has joined #openstack-horizon | 19:12 | |
| *** hhuang has quit IRC | 19:13 | |
| *** neelashah has joined #openstack-horizon | 19:15 | |
| *** mwhagedorn has quit IRC | 19:16 | |
| *** lhcheng has quit IRC | 19:18 | |
| haypo | david-lyle: what are "definition"? | 19:18 |
| haypo | david-lyle: there is no testenv:py34 in tox.ini, so py34 uses testenv | 19:19 |
| tqtran | TravT: ping | 19:19 |
| *** Piet has quit IRC | 19:19 | |
| rdopiera | haypo: for me tox prints both "Running Horizon application tests" and "Running openstack_dashboard tests | 19:19 |
| rdopiera | " | 19:19 |
| david-lyle | haypo: yeah, we worked back through that | 19:19 |
| haypo | rdopiera: yes, and it says "0 tests" | 19:20 |
| *** geoffarnold has quit IRC | 19:20 | |
| haypo | rdopiera: versus many tests executed on python 2.7 | 19:20 |
| rdopiera | no | 19:20 |
| rdopiera | tests from both are run | 19:21 |
| rdopiera | I can tell, because lots of failures | 19:21 |
| haypo | rdopiera: tox -e py34 says "Running Horizon application tests ... Ran 0 tests in 0.000s" | 19:21 |
| rdopiera | haypo: works for me | 19:22 |
| haypo | rdopiera: you should try from https://review.openstack.org/#/c/214291/ -- git review -d I69aeaf172d1d405dfeb4d2314f7bf0c571760201 | 19:22 |
| *** Sukhdev has quit IRC | 19:23 | |
| * rdopiera tries | 19:23 | |
| rdopiera | yes, that one is broken | 19:23 |
| rdopiera | but master works fine | 19:23 |
| haypo | rdopiera: on master, nosetests fails on loading tests | 19:23 |
| haypo | rdopiera: my 2 patches fix the loading failures, but then nosetests doesn't _run_ any test on python 3 | 19:24 |
| *** mwhagedorn has joined #openstack-horizon | 19:25 | |
| rdopiera | I see | 19:25 |
| doug-fish | I've only been about half following this chat - so my apologies if this is remedial, but is there some expectation that Horizon is going to run on python 3? | 19:27 |
| doug-fish | because I believe anyone with that expectation should prepare for disappointment | 19:27 |
| david-lyle | doug-fish: that's the target | 19:27 |
| doug-fish | is there a time for that target? | 19:27 |
| david-lyle | what haypo has been working toward | 19:27 |
| doug-fish | oh sorry | 19:28 |
| doug-fish | are there patches already? | 19:28 |
| david-lyle | M I believe, the sooner the better though | 19:28 |
| doug-fish | ok got it | 19:28 |
| doug-fish | I guess enabling tests is the right first step | 19:28 |
| doug-fish | and M seems appropriately far enough away for this to happen | 19:29 |
| *** SimonChung has quit IRC | 19:29 | |
| *** hhuang has joined #openstack-horizon | 19:29 | |
| haypo | my methodology is to fix tests | 19:30 |
| haypo | if tests are not executed on python 3, it cannot fix them :-) | 19:30 |
| doug-fish | Without thinking very hard there are probably 30-45 uses of "unicode" here that have to be updated to use the six library https://github.com/openstack/horizon/search?l=python&q=unicode%28&utf8=%E2%9C%93 | 19:30 |
| haypo | it would be nice to finish porting Horizon to Python 3 for the Liberty release | 19:31 |
| david-lyle | haypo: understood | 19:31 |
| *** rajatvig has quit IRC | 19:31 | |
| doug-fish | haypo: sure, enabling the tests for python3 is a very sensible first step | 19:31 |
| haypo | doug-fish: you can use my tool https://pypi.python.org/pypi/sixer to replace unicode with six.text_type | 19:31 |
| doug-fish | That will reveal to a fuller extent what will need to be addressed | 19:32 |
| doug-fish | haypo: clever! | 19:32 |
| haypo | this specific "unicode" operation for sixer produces wrong changes, like modifying docstrings or comments, but it helps a lot for such task | 19:32 |
| *** yamamoto has joined #openstack-horizon | 19:32 | |
| doug-fish | yeah understood. And I'm no python3 expert - I know only enough to know that Horizon is broken, and using six is part of the answer. | 19:33 |
| haypo | FYI horizon got a new non-voting py34 job ;) | 19:33 |
| haypo | (if you didn't notice yet) | 19:33 |
| doug-fish | nope. I hadn't. | 19:33 |
| haypo | i wrote the patch and it was quickly merged, cool | 19:34 |
| haypo | ( https://review.openstack.org/#/c/214292/ for project-config ) | 19:36 |
| haypo | see my second horizon test: https://review.openstack.org/#/c/214291/ "gate-horizon-python34 SUCCESS in 4m 04s (non-voting)" | 19:36 |
| haypo | so the check confirms that my patch fixes "tox -e py34" | 19:36 |
| *** rajatvig has joined #openstack-horizon | 19:37 | |
| doug-fish | nice. I'm just looking at the output of the tests in the gate now. Not a very high success rate yet. | 19:37 |
| *** yamamoto has quit IRC | 19:38 | |
| rdopiera | haypo: running the manage.py test command manually in tox's virtualenv seems to work | 19:38 |
| haypo | rdopiera: what do you mean by "work"? do you see tests executed? | 19:39 |
| rdopiera | Ran 171 tests in 7.044s | 19:39 |
| *** kmartin has quit IRC | 19:40 | |
| rdopiera | DJANGO_SETTINGS_MODULE=openstack_dashboard.test.settings ./manage.py test horizon | 19:41 |
| *** petertr7 is now known as petertr7_away | 19:41 | |
| *** petertr7_away is now known as petertr7 | 19:41 | |
| *** hurgleburgler has joined #openstack-horizon | 19:42 | |
| tqtran | david-lyle: are we having the blueprint review in this channel or openstack-meeting-3? | 19:42 |
| david-lyle | meeting-3 | 19:42 |
| *** Sukhdev has joined #openstack-horizon | 19:43 | |
| *** e0ne has joined #openstack-horizon | 19:45 | |
| *** rdopiera has quit IRC | 19:47 | |
| *** e0ne has quit IRC | 19:47 | |
| *** gyee has quit IRC | 19:47 | |
| *** pauloewerton has quit IRC | 19:48 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Add angular defaults panel for admin https://review.openstack.org/205296 | 19:48 |
| *** pauloewerton has joined #openstack-horizon | 19:49 | |
| *** belmoreira has joined #openstack-horizon | 19:50 | |
| *** tqtran is now known as tqtran_ | 19:53 | |
| *** jgravel has joined #openstack-horizon | 19:54 | |
| *** jgravel has left #openstack-horizon | 19:54 | |
| *** kzaitsev_mb has joined #openstack-horizon | 19:54 | |
| *** gyee has joined #openstack-horizon | 19:56 | |
| *** geoffarnold has joined #openstack-horizon | 19:56 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Create a Angular Modules for Admin Dashboard https://review.openstack.org/214779 | 19:56 |
| *** MaxV has joined #openstack-horizon | 19:57 | |
| *** alejandrito has joined #openstack-horizon | 19:59 | |
| TravT | hey tqtran: saw you pinged while I was out to lunch | 20:00 |
| *** alejandrito_ has joined #openstack-horizon | 20:00 | |
| tqtran_ | hey TravT lets catch up after the horizon bp meeting | 20:00 |
| *** alejandrito has quit IRC | 20:00 | |
| TravT | ok sounds good | 20:00 |
| *** MaxV has quit IRC | 20:01 | |
| *** e0ne has joined #openstack-horizon | 20:02 | |
| *** mwhagedorn has quit IRC | 20:10 | |
| *** Piet has joined #openstack-horizon | 20:11 | |
| *** rajatvig has quit IRC | 20:14 | |
| *** stevemar has joined #openstack-horizon | 20:14 | |
| *** lhcheng has joined #openstack-horizon | 20:17 | |
| *** e0ne has quit IRC | 20:18 | |
| *** rajatvig has joined #openstack-horizon | 20:18 | |
| *** alejandrito_ has quit IRC | 20:18 | |
| *** rajatvig has joined #openstack-horizon | 20:19 | |
| *** julim has quit IRC | 20:25 | |
| *** jingjin__ has joined #openstack-horizon | 20:25 | |
| *** mwhagedorn has joined #openstack-horizon | 20:26 | |
| *** Drago has quit IRC | 20:27 | |
| *** jingjing_ren has quit IRC | 20:27 | |
| *** Piet has quit IRC | 20:29 | |
| *** e0ne has joined #openstack-horizon | 20:29 | |
| *** ybathia has joined #openstack-horizon | 20:29 | |
| *** SimonChung has joined #openstack-horizon | 20:29 | |
| *** SimonChung1 has joined #openstack-horizon | 20:31 | |
| *** mwhagedorn has quit IRC | 20:31 | |
| *** Piet has joined #openstack-horizon | 20:32 | |
| *** petertr7 is now known as petertr7_away | 20:34 | |
| *** SimonChung has quit IRC | 20:34 | |
| *** e0ne has quit IRC | 20:35 | |
| *** e0ne has joined #openstack-horizon | 20:36 | |
| *** petertr7_away is now known as petertr7 | 20:37 | |
| *** geoffarnold has quit IRC | 20:40 | |
| *** exploreshaifali has quit IRC | 20:41 | |
| *** kmartin has joined #openstack-horizon | 20:42 | |
| *** belmoreira has quit IRC | 20:44 | |
| openstackgerrit | Justin Pomeroy proposed openstack/horizon: Support angular workflow extension as a feature plugin https://review.openstack.org/214306 | 20:44 |
| *** rdopiera has joined #openstack-horizon | 20:47 | |
| *** Drago has joined #openstack-horizon | 20:50 | |
| *** Ephur has joined #openstack-horizon | 20:51 | |
| *** Drago has quit IRC | 20:52 | |
| *** Drago has joined #openstack-horizon | 20:52 | |
| *** mwhagedorn has joined #openstack-horizon | 20:53 | |
| *** geoffarnold has joined #openstack-horizon | 20:54 | |
| *** Ephur has quit IRC | 20:56 | |
| *** neelashah has quit IRC | 20:59 | |
| *** zul has quit IRC | 21:00 | |
| *** jpomeroy has quit IRC | 21:01 | |
| *** skylerberg has joined #openstack-horizon | 21:02 | |
| *** tqtran has joined #openstack-horizon | 21:05 | |
| *** stevemar has quit IRC | 21:05 | |
| tqtran | hey TravT, have time to talk about the transfer-table and your promise-toggle? | 21:05 |
| TravT | sure. i just left some comments on the promise toggle patch. | 21:06 |
| TravT | rajatvig pinged me and said he had some ideas re: the json comment. | 21:06 |
| TravT | so, he was going to play with it a bit and get back to us. | 21:06 |
| *** tqtran_ has quit IRC | 21:06 | |
| rajatvig | yes, I'll. are there any examples/code that I could verify my idea against? | 21:07 |
| *** Ephur has joined #openstack-horizon | 21:07 | |
| *** petertr7 is now known as petertr7_away | 21:07 | |
| tqtran | yes let me look it up for you | 21:07 |
| TravT | i can take a look at the transfer table one again. | 21:07 |
| tsufiev | david-lyle, btw, all the pieces fixing integration tests are in place - https://review.openstack.org/#/c/214238/ (and 2 dependent commits) | 21:07 |
| TravT | i briefly looked at it yesterday tqtran, but didn't have time to properly think about it. | 21:08 |
| tqtran | rajatvig: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/static/dashboard/identity/users/table/table.controller.js#L57 i want to use that policy to toggle visibility of the table | 21:08 |
| david-lyle | thanks tsufiev I have it open, will try to work to it | 21:08 |
| david-lyle | it's important to get those fixed in | 21:08 |
| rajatvig | tqtran: thanks for the link. I'll give it a shot. | 21:08 |
| tqtran | rajatvig: what are the ideas you have in mind? i was thinking of $attr.$observe or $scope.$watch for the direction's value | 21:09 |
| tsufiev | david-lyle, my pleasure :) | 21:09 |
| robcresswell | tsufiev: Really nice work on the integration testing. | 21:09 |
| robcresswell | I think doug-fish might hug you at the next summit. | 21:09 |
| david-lyle | I need to change owner on that, or did it with your patch? | 21:09 |
| * david-lyle can't remember launchpad workflow | 21:09 | |
| TravT | tqtran: i don't want to make it so that you can only watch objects / stuff in controllers. | 21:10 |
| david-lyle | there was another bug too | 21:10 |
| david-lyle | hmm | 21:10 |
| tsufiev | robcresswell, hm... I think more verbal gratitude would suffice ) | 21:10 |
| rajatvig | tqtran: there's the $parse that can be used to eval the attribute value | 21:10 |
| TravT | i'd like to support both inline strings and a way to pass in objects | 21:10 |
| *** mpavlase has joined #openstack-horizon | 21:10 | |
| tsufiev | robcresswell, it's a pity the guys who made this testing framework are no longer working on it | 21:11 |
| tqtran | rajatvig: parse only does it once, which might be ok if the value doesn't change over time | 21:12 |
| tsufiev | someone had to pick up the torch | 21:12 |
| TravT | tqtran: that is a limitation of this right now, which is in the documentation for it. | 21:12 |
| *** tyr has joined #openstack-horizon | 21:13 | |
| TravT | this is intended for things that won't change constantly | 21:13 |
| *** lblanchard has quit IRC | 21:13 | |
| tqtran | TravT: you might be able to do it via hz-toggle="'somestring here'" | 21:13 |
| tqtran | but not sure if it would work for string inside objects, might need to escape it | 21:13 |
| TravT | is = is not | 21:13 |
| TravT | ^ my statement above | 21:13 |
| *** amotoki_ has quit IRC | 21:14 | |
| TravT | tqtran, did you already have a dependent patch started for policy? | 21:14 |
| doug-fish | robcresswell: I was away at a meeting ... um ... I'm giving out hugs now? | 21:15 |
| TravT | that is to make a policy toggle directive | 21:15 |
| tqtran | TravT: i started work on it, but ran into that issue, havent uploaded the patch yet | 21:15 |
| *** e0ne has quit IRC | 21:15 | |
| doug-fish | robcresswell: I hope you aren't suggesting I hug TravT -- I don't think he's really a "hugger" | 21:15 |
| TravT | if you did, then we could have it as a concrete example to work on the parent patch. | 21:15 |
| rajatvig | yeah, it'll be great. | 21:16 |
| * TravT just had to scroll back to figure out what doug-fish is talking about | 21:16 | |
| TravT | doug-fish: you need to hug tsufiev | 21:17 |
| TravT | lol | 21:17 |
| doug-fish | TravT: mmmkay | 21:17 |
| david-lyle | doug-fish: give him one for me too | 21:17 |
| doug-fish | lol | 21:17 |
| *** tyr has quit IRC | 21:17 | |
| *** lapalm has quit IRC | 21:17 | |
| tqtran | TravT: ok i'll upload it in a bit, busy atm | 21:17 |
| david-lyle | or I could just buy him a beer | 21:17 |
| doug-fish | Maybe I can buy tsufiev a beer. I am pleased about integration test progress | 21:18 |
| TravT | sure, no worries. | 21:18 |
| doug-fish | beer >> hugs | 21:18 |
| openstackgerrit | Chad Roberts proposed openstack/horizon: Adding support for Manila-based shares in Sahara https://review.openstack.org/207086 | 21:18 |
| TravT | +1 | 21:18 |
| david-lyle | is that beer before hugs | 21:18 |
| david-lyle | ? | 21:18 |
| TravT | that is often the case... | 21:18 |
| doug-fish | beer is much greater than hugs | 21:18 |
| * david-lyle has to run away for a bit, back online later | 21:18 | |
| doug-fish | at least in terms of thanking my Horizon buddies. | 21:18 |
| *** e0ne has joined #openstack-horizon | 21:19 | |
| TravT | okay, i'm off to review patches. | 21:19 |
| *** crobertsrh is now known as _crobertsrh | 21:19 | |
| *** cody-somerville has joined #openstack-horizon | 21:20 | |
| r1chardj0n3s | morning | 21:22 |
| *** geoffarnold has quit IRC | 21:23 | |
| *** geoffarnold has joined #openstack-horizon | 21:24 | |
| *** shivrao has joined #openstack-horizon | 21:28 | |
| *** e0ne has quit IRC | 21:28 | |
| *** jpomeroy has joined #openstack-horizon | 21:33 | |
| *** vgridnev has quit IRC | 21:35 | |
| *** Piet has quit IRC | 21:38 | |
| tqtran | morning r1chardj0n3s | 21:39 |
| tqtran | robcresswell: still around? i think having docs for how to install plugin would be useful as well | 21:39 |
| tqtran | base off of dave's plugin example: https://github.com/tqtran7/mon-ext the steps below could prove to be useful | 21:40 |
| *** Sukhdev has quit IRC | 21:43 | |
| *** aortega has quit IRC | 21:44 | |
| *** jtriley has quit IRC | 21:44 | |
| *** lhcheng has quit IRC | 21:46 | |
| *** mwhagedorn has quit IRC | 21:48 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Refactor angular cloud services utilities https://review.openstack.org/179516 | 21:50 |
| *** sambetts has quit IRC | 21:51 | |
| rajatvig | TravT: I used $parse vs angular.fromJson. This allows for passed in content to be evaluated in context of the scope. Also, addressed some of the commentary | 21:51 |
| *** sambetts has joined #openstack-horizon | 21:51 | |
| TravT | rajatvig - thanks will take a look after the meeting i'm having to join right now | 21:51 |
| rhagarty_ | hello - want to add a new tabbed panel to Project->Volumes. Should I be using angular? | 21:52 |
| *** dshaw_ has joined #openstack-horizon | 21:53 | |
| *** doug-fish has quit IRC | 21:53 | |
| openstackgerrit | Dan Siwiec proposed openstack/horizon: Angular metadata update modal https://review.openstack.org/184274 | 21:53 |
| openstackgerrit | KBrown proposed openstack/horizon: WIP: Add angular flavors panel subflows https://review.openstack.org/214294 | 21:53 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Directive to check if policy check passes https://review.openstack.org/214815 | 21:56 |
| tqtran | TravT, rajatvig: https://review.openstack.org/#/c/214815/1/openstack_dashboard/static/app/core/cloud-services/hz-policy-toggle.directive.js L40 | 21:57 |
| tqtran | i dont have something concrete for you to use, but basically that is what im asking for | 21:57 |
| TravT | ok, will look after meeting that i'm in. | 21:57 |
| TravT | thx | 21:57 |
| *** akrivoka has quit IRC | 22:00 | |
| *** absubram has quit IRC | 22:03 | |
| *** mrunge has quit IRC | 22:04 | |
| *** geoffarnold has quit IRC | 22:05 | |
| *** geoffarnold has joined #openstack-horizon | 22:06 | |
| dshaw_ | appreciate any reviews, https://review.openstack.org/#/c/212041/ | 22:07 |
| * ducttape_ loves pep8 compliance | 22:12 | |
| openstackgerrit | Merged openstack/horizon: Fix docs translation import errors https://review.openstack.org/214277 | 22:12 |
| *** Sukhdev has joined #openstack-horizon | 22:13 | |
| *** btully has joined #openstack-horizon | 22:13 | |
| *** tyr has joined #openstack-horizon | 22:13 | |
| *** vijendar has quit IRC | 22:14 | |
| *** amotoki_ has joined #openstack-horizon | 22:14 | |
| openstackgerrit | Merged openstack/horizon: STATIC_ROOT underline too short https://review.openstack.org/214278 | 22:18 |
| *** tyr has quit IRC | 22:18 | |
| openstackgerrit | Merged openstack/horizon: Fixing .rst file issues https://review.openstack.org/214318 | 22:18 |
| openstackgerrit | Merged openstack/horizon: Fixing docstring formatting errors and warnings https://review.openstack.org/214379 | 22:18 |
| *** SimonChung1 has quit IRC | 22:19 | |
| *** amotoki_ has quit IRC | 22:19 | |
| openstackgerrit | Dan Siwiec proposed openstack/horizon: WIP : Add angular defaults panel for admin https://review.openstack.org/205296 | 22:19 |
| haypo | rdopiera, david-lyle: ah! i found the reason why "tox -e py34" doesn't execute tests. nose_exclude plugin is not compatible with Python 3 | 22:21 |
| *** mwhagedorn has joined #openstack-horizon | 22:23 | |
| tqtran | tsufiev: thanks for fixing the integration tests!!!!! | 22:26 |
| tqtran | i'll make some time for it if it doesn't get push through by end of week | 22:26 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Re-work static_settings to clean up https://review.openstack.org/204838 | 22:27 |
| r1chardj0n3s | could I get some core love for https://review.openstack.org/#/c/204838/ please? | 22:27 |
| *** Piet has joined #openstack-horizon | 22:28 | |
| r1chardj0n3s | tsufiev fixed the integration tests? awesome! | 22:28 |
| haypo | good news: the nose-exclude bug on Python 3 is already fixed. i opened an issue to request a release: https://github.com/kgrandis/nose-exclude/issues/3 | 22:30 |
| *** rajatvig has quit IRC | 22:34 | |
| openstackgerrit | KBrown proposed openstack/horizon: WIP: Add angular flavors panel https://review.openstack.org/206203 | 22:36 |
| openstackgerrit | KBrown proposed openstack/horizon: WIP: Add angular flavors panel https://review.openstack.org/206203 | 22:37 |
| rdopiera | r1chardj0n3s: argh | 22:38 |
| r1chardj0n3s | rdopiera: ohai | 22:39 |
| rdopiera | r1chardj0n3s: that was supposed to be a simple file easy to edit by the packagers... | 22:40 |
| r1chardj0n3s | I've had feedback from zigo and mrunge that this change is OK | 22:40 |
| r1chardj0n3s | they don't edit static_settings | 22:40 |
| rdopiera | r1chardj0n3s: your changes tie it to xstatic | 22:40 |
| r1chardj0n3s | well, we are currently tied to xstatic, yes | 22:41 |
| rdopiera | r1chardj0n3s: so far, the only thing you needed to get rid of xstatic was to just edit that file and replace the xstatic calls with explicit paths | 22:41 |
| *** rajatvig has joined #openstack-horizon | 22:41 | |
| r1chardj0n3s | we're not getting rid of xstatic any time soon though | 22:42 |
| r1chardj0n3s | (and I say that as one who would love to asap) | 22:42 |
| rdopiera | r1chardj0n3s: you are cementing xstatic in, basically | 22:42 |
| rdopiera | r1chardj0n3s: how the new code looks like, there is absolutely no reason for it to live in a settings file | 22:43 |
| r1chardj0n3s | not in the slightest - I'm just making it much saner working with xstatic | 22:43 |
| r1chardj0n3s | it's only in a "settings" file because that happens to be the name at the moment :) | 22:43 |
| r1chardj0n3s | it's not actually a "settings" file | 22:43 |
| r1chardj0n3s | no-one outside of Horizon dev actually edit it | 22:43 |
| rdopiera | I don't agree with your definition of "sanity" | 22:43 |
| rdopiera | then get rid of it altogether | 22:44 |
| r1chardj0n3s | the current file is 90% just arbitrary directory name choices when xstatic already provides directory names | 22:44 |
| r1chardj0n3s | get rid of xstatic? I'd love to :) but as I said, we can't. there is no alternative | 22:44 |
| rdopiera | of the settings file | 22:44 |
| r1chardj0n3s | we need *something* to do this work. please feel free to suggest a rename? | 22:45 |
| rdopiera | r1chardj0n3s: just move the code to where the rest of this logic lives | 22:45 |
| r1chardj0n3s | where *is* that? | 22:45 |
| r1chardj0n3s | you have something in mind, clearly, but I do not :) | 22:45 |
| rdopiera | openstack_dashboard/utils/settings.py | 22:46 |
| r1chardj0n3s | (can't help but point out that that file has "settings" in its name :P ) | 22:46 |
| rdopiera | sigh | 22:46 |
| rdopiera | whatever | 22:46 |
| rdopiera | forget it | 22:46 |
| * rdopiera goes back to the work he's actually paid for | 22:46 | |
| r1chardj0n3s | rdopiera: nono, please add a comment to the review suggesting that move - if others think it a good idea, I'm happy to | 22:48 |
| rdopiera | I don't think it's a good idea | 22:48 |
| rdopiera | but I don't really have the resources to argue my case | 22:49 |
| rdopiera | so I will just leave it to others | 22:49 |
| r1chardj0n3s | ok, thanks for your thoughts anyway | 22:49 |
| rajatvig | tqtran: have a look at the commit for the https://review.openstack.org/179516. I changed it to use $parse, so "ctrl.policy" will work but it'll not evaluate it again if that changes. | 22:50 |
| tqtran | rdopiera: i think you made a valid point, the way r1chardj0n3s has it, we are tying the horizon config object into it. it does make it easier but i can also definitely see your pov | 22:51 |
| david-lyle | haypo: that is good news | 22:51 |
| tqtran | rajatvig: i think that is fine for now, i cant imagine any toggle that will want to change rules midway through, so no real use case for dynamic checking | 22:52 |
| tqtran | but there are a few nits remaining that if you can address would be grand :) | 22:52 |
| *** Piet has quit IRC | 22:53 | |
| rdopiera | r1chardj0n3s: perhpas (didn't really think about it for very long), it would make sense to add that list of files to settings.py itself as a new variable, and move the logic to utils/settings.py ? | 22:53 |
| rdopiera | r1chardj0n3s: so that people can edit the config without wading through python code? | 22:53 |
| r1chardj0n3s | rdopiera: moving it to utils/settings.py makes sense; I used HORIZON_CONFIG because that's where we are puttig other lists-of-static-files config at the moment | 22:53 |
| rdopiera | r1chardj0n3s: no, I mean separating out the actual xstatic_modules list | 22:54 |
| kfox1111 | tqtran: could you please point me in the general directo of where the lagacy dialog code lives? | 22:54 |
| r1chardj0n3s | rdopiera: yes, I think I just caught up with that train of thought. very interesting! | 22:54 |
| rdopiera | r1chardj0n3s: maybe make it text-only too, and do getattr() in the processing logic | 22:54 |
| tqtran | r1chardj0n3s: right we use HORIZON_CONFIG for plugins and such. | 22:54 |
| r1chardj0n3s | ... since hurgleburgler's got a use case for deployers adding more xstatic packages | 22:55 |
| r1chardj0n3s | rdopiera: yes, though it won't be a getattr() it'd be an __import__ | 22:55 |
| tqtran | kfox1111: sure let me look | 22:55 |
| kfox1111 | thx. | 22:55 |
| rdopiera | so it would be [..., ('xstatic.pkg.angular_bootstrap', ['angular-bootstrap.js']), ...] | 22:55 |
| r1chardj0n3s | yep | 22:55 |
| rdopiera | r1chardj0n3s: also, perhaps, if the string *doesn't* start with 'xstatic', treat it as a literal path? | 22:56 |
| r1chardj0n3s | yeah, was just thinking that also | 22:56 |
| rdopiera | r1chardj0n3s: so you can add files that are not packaged as xstatic if you really must | 22:56 |
| r1chardj0n3s | yeah, we have a vendored file in Horizon still :/ | 22:57 |
| *** geoffarnold has quit IRC | 22:57 | |
| r1chardj0n3s | there is just that one niggle of the problem if the jquery_ui xstatic package that moved the entry point file location :/ | 22:58 |
| r1chardj0n3s | but I guess it can remain a special case | 22:58 |
| rdopiera | r1chardj0n3s: thanks, I think that would be a really nice improvement then! | 22:59 |
| r1chardj0n3s | rdopiera: it's going to be a much better patch now, thanks for your input! | 22:59 |
| rdopiera | r1chardj0n3s: sorry for the attitude | 22:59 |
| r1chardj0n3s | rdopiera: not a problem at all :) | 23:00 |
| rdopiera | I had that "oh no, he's ruining everything" moment | 23:00 |
| tqtran | kfox1111: https://github.com/openstack/horizon/blob/master/horizon/static/horizon/js/horizon.modals.js#L308 | 23:00 |
| tqtran | I'm sure david-lyle sees those moment on a daily basis | 23:01 |
| kfox1111 | tqtran: Thanks. That will save me quite a bit of time searching. | 23:01 |
| tqtran | np, hope you get it figured out :) | 23:01 |
| *** btully has quit IRC | 23:02 | |
| *** cody-somerville has quit IRC | 23:03 | |
| *** Sukhdev has quit IRC | 23:05 | |
| *** albertom is now known as albertom-afk | 23:06 | |
| *** mwhagedorn has quit IRC | 23:06 | |
| *** zul has joined #openstack-horizon | 23:07 | |
| *** tyr has joined #openstack-horizon | 23:07 | |
| *** mwhagedorn has joined #openstack-horizon | 23:09 | |
| *** DWfuturetec has quit IRC | 23:09 | |
| rajatvig | tqtran: will do that tonight | 23:09 |
| *** mwhagedorn has quit IRC | 23:10 | |
| *** tosky has quit IRC | 23:11 | |
| *** ducttape_ has quit IRC | 23:11 | |
| *** tyr has quit IRC | 23:11 | |
| *** zul has quit IRC | 23:12 | |
| *** Piet has joined #openstack-horizon | 23:12 | |
| *** hurgleburgler has quit IRC | 23:12 | |
| openstackgerrit | Dan Siwiec proposed openstack/horizon: WIP: API for getting and updating quotas https://review.openstack.org/207126 | 23:14 |
| david-lyle | tqtran: :) | 23:14 |
| tqtran | hahaha | 23:14 |
| tqtran | ok thanks rajatvig! | 23:15 |
| openstackgerrit | Dan Siwiec proposed openstack/horizon: WIP : Add angular defaults panel for admin https://review.openstack.org/205296 | 23:15 |
| *** amotoki_ has joined #openstack-horizon | 23:15 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: API for getting and updating quotas https://review.openstack.org/207126 | 23:16 |
| *** amotoki_ has quit IRC | 23:19 | |
| openstackgerrit | Dan Siwiec proposed openstack/horizon: WIP : Add angular defaults panel for admin https://review.openstack.org/205296 | 23:25 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Add angular defaults panel for admin https://review.openstack.org/205296 | 23:26 |
| *** chlong has quit IRC | 23:28 | |
| *** kzaitsev_mb has quit IRC | 23:29 | |
| *** dshaw_ has quit IRC | 23:29 | |
| *** geoffarnold has joined #openstack-horizon | 23:29 | |
| *** kzaitsev_mb has joined #openstack-horizon | 23:32 | |
| *** Piet has quit IRC | 23:33 | |
| *** geoffarnold has quit IRC | 23:34 | |
| *** mpavlase has quit IRC | 23:34 | |
| *** geoffarnold has joined #openstack-horizon | 23:34 | |
| *** fedexo has joined #openstack-horizon | 23:37 | |
| *** Piet has joined #openstack-horizon | 23:37 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Run ESLint on Javascript files in dashboards https://review.openstack.org/214057 | 23:37 |
| *** kzaitsev_mb has quit IRC | 23:38 | |
| haypo | rdopiera: WOW! https://pypi.python.org/pypi/nose-exclude 0.4 is already released | 23:41 |
| *** zul has joined #openstack-horizon | 23:41 | |
| rdopiera | haypo: \o/ | 23:41 |
| rdopiera | haypo: so now you just want to bump it in requirements.txt, I guess | 23:42 |
| rdopiera | test-requirements.txt, I mean | 23:42 |
| *** Piet has quit IRC | 23:47 | |
| *** sayan has quit IRC | 23:48 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Re-work static_settings to clean up https://review.openstack.org/204838 | 23:48 |
| r1chardj0n3s | rdopiera: https://review.openstack.org/#/c/204838/ has your suggested changes | 23:49 |
| r1chardj0n3s | hm, but it's busted | 23:49 |
| r1chardj0n3s | or at least the tests will be | 23:50 |
| openstackgerrit | KBrown proposed openstack/horizon: WIP: API Services for Flavors Panel https://review.openstack.org/214896 | 23:51 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Refactor angular cloud services utilities https://review.openstack.org/179516 | 23:52 |
| *** Piet has joined #openstack-horizon | 23:53 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Cloud Service directive to check if Service is enabled https://review.openstack.org/212125 | 23:53 |
| *** lhcheng has joined #openstack-horizon | 23:53 | |
| *** geoffarn_ has joined #openstack-horizon | 23:53 | |
| *** geoffarnold has quit IRC | 23:54 | |
| openstackgerrit | KBrown proposed openstack/horizon: WIP: Add angular flavors panel subflows https://review.openstack.org/214294 | 23:56 |
| haypo | rdopiera: yes, https://review.openstack.org/#/c/214892/ | 23:57 |
| haypo | rdopiera: for horizon, we may wait for the bot updating requirements | 23:58 |
| *** rajatvig has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
