| tqtran-afk | kfox1111: its been going on for a while... hopefully the dust will settle soon...... | 00:00 |
|---|---|---|
| *** kristinebrown has quit IRC | 00:01 | |
| kfox1111 | yeah.... ok. so maybe I should just split the one review into 2. | 00:01 |
| kfox1111 | The stuff that keeps moving around is like 4 lines. :/ | 00:01 |
| kfox1111 | maybe we can slide that in quicker if its seperate. | 00:02 |
| *** yamamoto has quit IRC | 00:03 | |
| *** ybathia has quit IRC | 00:04 | |
| *** lucas__ has joined #openstack-horizon | 00:06 | |
| *** zul has joined #openstack-horizon | 00:09 | |
| *** yamamoto has joined #openstack-horizon | 00:09 | |
| *** lucas__ has quit IRC | 00:10 | |
| *** kyleolivo has joined #openstack-horizon | 00:11 | |
| *** yamamoto has quit IRC | 00:14 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: JSCS/eslint cleanup - o_s/tech-debt, bind-scope, toast https://review.openstack.org/205104 | 00:15 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: API for getting default quotas in admin https://review.openstack.org/207126 | 00:15 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Add angular defaults panel for admin https://review.openstack.org/205296 | 00:15 |
| openstackgerrit | Steve McLellan proposed openstack/horizon: Searchlight API for horizon https://review.openstack.org/204721 | 00:16 |
| *** yamamoto has joined #openstack-horizon | 00:16 | |
| *** kzaitsev_mb has joined #openstack-horizon | 00:17 | |
| *** yingjun has joined #openstack-horizon | 00:19 | |
| *** sjmc7 has quit IRC | 00:20 | |
| *** rajatvig has quit IRC | 00:20 | |
| *** garthb has quit IRC | 00:20 | |
| *** kzaitsev_mb has quit IRC | 00:21 | |
| *** alexvictorchan has quit IRC | 00:29 | |
| *** kyleolivo has quit IRC | 00:29 | |
| *** Guest5314 is now known as med_ | 00:29 | |
| *** med_ has quit IRC | 00:29 | |
| *** med_ has joined #openstack-horizon | 00:29 | |
| *** SimonChung1 has quit IRC | 00:30 | |
| *** lucas__ has joined #openstack-horizon | 00:35 | |
| *** nlahouti has quit IRC | 00:36 | |
| *** lucas__ has quit IRC | 00:39 | |
| openstackgerrit | Kevin Fox proposed openstack/horizon: A few tweaks to make the App Catalog plugin work. https://review.openstack.org/206773 | 00:42 |
| *** lucas__ has joined #openstack-horizon | 00:42 | |
| *** yamamoto has quit IRC | 00:43 | |
| *** annashen has joined #openstack-horizon | 00:45 | |
| *** jingjing_ren has quit IRC | 00:47 | |
| *** kzaitsev_mb has joined #openstack-horizon | 00:47 | |
| *** lucas__ has quit IRC | 00:49 | |
| *** annashen has quit IRC | 00:49 | |
| *** kzaitsev_mb has quit IRC | 00:51 | |
| *** stevemar has joined #openstack-horizon | 00:55 | |
| *** geoffarnold has quit IRC | 00:57 | |
| *** stevemar has quit IRC | 00:58 | |
| *** alexpilotti has quit IRC | 01:03 | |
| *** lucas__ has joined #openstack-horizon | 01:04 | |
| *** amotoki has joined #openstack-horizon | 01:07 | |
| *** lucas__ has quit IRC | 01:08 | |
| *** saksham has quit IRC | 01:11 | |
| *** kyleolivo has joined #openstack-horizon | 01:11 | |
| *** skylerberg has quit IRC | 01:15 | |
| *** jingjing_ren has joined #openstack-horizon | 01:17 | |
| *** david-lyle has joined #openstack-horizon | 01:19 | |
| *** ChanServ sets mode: +o david-lyle | 01:19 | |
| *** lucas__ has joined #openstack-horizon | 01:23 | |
| *** jingjing_ren has quit IRC | 01:23 | |
| r1chardj0n3s | is anyone aware of the current thoughts on the domain-scoped tokens work? specifically https://review.openstack.org/#/c/141153/ and https://review.openstack.org/#/c/148082/ ? | 01:24 |
| openstackgerrit | Bradley Jones proposed openstack/horizon: Add Curvature topology https://review.openstack.org/141078 | 01:26 |
| *** lucas__ has quit IRC | 01:27 | |
| david-lyle | r1chardj0n3s: oh, oh, pick me, pick me | 01:33 |
| r1chardj0n3s | ohai david-lyle :) | 01:33 |
| david-lyle | the first should be about ready to merge | 01:33 |
| r1chardj0n3s | if I had've known it was going to be a priority I'd have paid more attention to it at the midcycle ;) | 01:33 |
| david-lyle | esp was going to do a last bit of refactoring, just to isolate some logic, I know he posted a patch but I haven't looked at it yet | 01:34 |
| *** tqtran-afk has quit IRC | 01:34 | |
| r1chardj0n3s | ok, if there's anything I can do to help move it along, pls say | 01:34 |
| r1chardj0n3s | also, my overlords would like to see it back-ported to kilo | 01:34 |
| david-lyle | the second one is more involved and a little further out, but probably not too far | 01:34 |
| *** clu_ has quit IRC | 01:35 | |
| david-lyle | that probably won't happen | 01:35 |
| david-lyle | the backport | 01:35 |
| r1chardj0n3s | yeah, I figured. it's a complex change | 01:35 |
| david-lyle | yeah feature add, but I think esp is maintaining a kilo version of it already | 01:35 |
| david-lyle | you may be able to leverage that | 01:36 |
| r1chardj0n3s | oh, ok, I will ping him on that thanks | 01:36 |
| r1chardj0n3s | esp: consider yourself pung ^^ | 01:36 |
| r1chardj0n3s | :) | 01:36 |
| david-lyle | sure, he was going to have to do juno for a while so it could have been worse | 01:36 |
| david-lyle | :/ | 01:36 |
| r1chardj0n3s | yikes | 01:36 |
| david-lyle | yeah | 01:36 |
| r1chardj0n3s | so these changes - do they require keystone changes also? | 01:37 |
| r1chardj0n3s | I ask because there's a couple of patches mentioned in our internal discussion on the keystone side | 01:37 |
| r1chardj0n3s | https://review.openstack.org/#/c/180846/ and https://review.openstack.org/#/c/188184/ | 01:37 |
| r1chardj0n3s | those are quite stuck tho | 01:37 |
| david-lyle | doa patch no | 01:37 |
| david-lyle | horizon patch yes | 01:38 |
| david-lyle | well, not entirely, but domain admin functionality is broken in a couple places without them | 01:38 |
| r1chardj0n3s | ok | 01:38 |
| david-lyle | there is a lengthy wiki and etherpad if you want more details | 01:38 |
| r1chardj0n3s | https://wiki.openstack.org/wiki/Horizon/DomainWorkFlow ? | 01:38 |
| david-lyle | yeah that's the wiki | 01:39 |
| david-lyle | let me find the etherpad | 01:39 |
| david-lyle | all the gory details | 01:39 |
| r1chardj0n3s | cool. I don't have the etherpad tho, thanks | 01:39 |
| *** lucas__ has joined #openstack-horizon | 01:39 | |
| david-lyle | https://etherpad.openstack.org/p/domains_planning | 01:39 |
| r1chardj0n3s | cheers | 01:40 |
| david-lyle | I'd invite you to a meeting but it would be in the middle of the night for you | 01:40 |
| *** sqchen has joined #openstack-horizon | 01:40 | |
| *** yingjun_ has joined #openstack-horizon | 01:40 | |
| david-lyle | plus then you might have to attend a meeting | 01:40 |
| david-lyle | and I hate to do that to anyone | 01:40 |
| *** yingjun has quit IRC | 01:41 | |
| r1chardj0n3s | heh. I added talking about it to the agenda for the next (imminent) horizon meeting, but I can probably remove it after this chat | 01:41 |
| r1chardj0n3s | what time/place is the meeting - someone in the castle could probably attend | 01:41 |
| *** yamamoto has joined #openstack-horizon | 01:41 | |
| david-lyle | I'll forward you the invite | 01:41 |
| r1chardj0n3s | thanks | 01:42 |
| david-lyle | anyones welcome to attend, just has all the details | 01:42 |
| *** yamamoto has quit IRC | 01:42 | |
| david-lyle | incoming email | 01:43 |
| *** lucas__ has quit IRC | 01:43 | |
| r1chardj0n3s | cheers | 01:44 |
| *** lucas__ has joined #openstack-horizon | 01:44 | |
| *** kzaitsev_mb has joined #openstack-horizon | 01:48 | |
| *** lucas__ has quit IRC | 01:49 | |
| *** julim has joined #openstack-horizon | 01:51 | |
| *** tjones has quit IRC | 01:52 | |
| *** tjones has joined #openstack-horizon | 01:54 | |
| openstackgerrit | ziyu032 proposed openstack/horizon: Cancel button in "Create Keypair" redirect to wrong url https://review.openstack.org/209313 | 01:54 |
| *** annashen has joined #openstack-horizon | 01:59 | |
| openstackgerrit | Kevin Fox proposed openstack/horizon: A few tweaks to make the App Catalog plugin work. https://review.openstack.org/206773 | 02:04 |
| *** lyanchih_ has joined #openstack-horizon | 02:06 | |
| *** sjmc7 has joined #openstack-horizon | 02:08 | |
| *** jbell8 has joined #openstack-horizon | 02:09 | |
| *** zul has quit IRC | 02:09 | |
| *** sjmc7 has quit IRC | 02:13 | |
| *** kzaitsev_mb has quit IRC | 02:14 | |
| *** jbell8 has quit IRC | 02:16 | |
| *** yingjun_ has quit IRC | 02:25 | |
| *** yingjun has joined #openstack-horizon | 02:30 | |
| *** annashen has quit IRC | 02:31 | |
| *** yamamoto has joined #openstack-horizon | 02:31 | |
| *** jingjing_ren has joined #openstack-horizon | 02:32 | |
| *** clu_ has joined #openstack-horizon | 02:34 | |
| *** gyee has quit IRC | 02:35 | |
| *** clu_ has quit IRC | 02:35 | |
| *** jingjing_ren has quit IRC | 02:37 | |
| *** lucas__ has joined #openstack-horizon | 02:38 | |
| *** lucas__ has quit IRC | 02:43 | |
| *** lucas__ has joined #openstack-horizon | 02:46 | |
| *** KunalGandhi has quit IRC | 02:49 | |
| *** lucas__ has quit IRC | 02:51 | |
| openstackgerrit | lyanchih proposed openstack/horizon: Couldn't provision instance from volume snapshot https://review.openstack.org/199457 | 02:53 |
| *** lucas__ has joined #openstack-horizon | 03:03 | |
| *** clu_ has joined #openstack-horizon | 03:04 | |
| *** btully has quit IRC | 03:04 | |
| *** ^Gal^ has quit IRC | 03:05 | |
| *** clu_ has quit IRC | 03:06 | |
| *** ^Gal^ has joined #openstack-horizon | 03:07 | |
| *** jbell8 has joined #openstack-horizon | 03:08 | |
| *** lucas__ has quit IRC | 03:08 | |
| *** jingjing_ren has joined #openstack-horizon | 03:13 | |
| *** jingjing_ren has quit IRC | 03:21 | |
| *** doug-fish has joined #openstack-horizon | 03:24 | |
| *** lucas__ has joined #openstack-horizon | 03:42 | |
| *** kzaitsev_mb has joined #openstack-horizon | 03:44 | |
| *** lucas__ has quit IRC | 03:46 | |
| *** lucas__ has joined #openstack-horizon | 03:48 | |
| *** kzaitsev_mb has quit IRC | 03:49 | |
| *** sayan has joined #openstack-horizon | 03:51 | |
| *** lucas__ has quit IRC | 03:53 | |
| *** sqchen has quit IRC | 03:53 | |
| *** stevemar has joined #openstack-horizon | 03:55 | |
| *** yingjun has quit IRC | 03:57 | |
| *** stevemar has quit IRC | 03:58 | |
| *** geoffarnold has joined #openstack-horizon | 04:04 | |
| *** tjones has quit IRC | 04:05 | |
| *** lucas__ has joined #openstack-horizon | 04:06 | |
| *** geoffarnold has quit IRC | 04:06 | |
| *** geoffarnold has joined #openstack-horizon | 04:09 | |
| *** lucas__ has quit IRC | 04:10 | |
| *** geoffarnold has quit IRC | 04:16 | |
| *** amotoki has quit IRC | 04:18 | |
| openstackgerrit | Merged openstack/horizon: Improving Horizon's angular module management: https://review.openstack.org/199319 | 04:19 |
| *** sqchen has joined #openstack-horizon | 04:19 | |
| *** annashen has joined #openstack-horizon | 04:26 | |
| *** stevemar has joined #openstack-horizon | 04:29 | |
| *** fifieldt has joined #openstack-horizon | 04:32 | |
| *** btully has joined #openstack-horizon | 04:33 | |
| *** KingaKhan has joined #openstack-horizon | 04:34 | |
| *** jbell8 has quit IRC | 04:35 | |
| *** btully has quit IRC | 04:37 | |
| *** annashen has quit IRC | 04:38 | |
| *** julim has quit IRC | 04:38 | |
| *** fedexo has joined #openstack-horizon | 04:40 | |
| *** jbell8 has joined #openstack-horizon | 04:43 | |
| *** lucas__ has joined #openstack-horizon | 04:45 | |
| *** jbell8 has quit IRC | 04:47 | |
| *** kyleolivo has quit IRC | 04:48 | |
| *** lucas___ has joined #openstack-horizon | 04:49 | |
| *** lucas__ has quit IRC | 04:49 | |
| *** KunalGandhi has joined #openstack-horizon | 04:53 | |
| *** lucas___ has quit IRC | 04:53 | |
| *** KunalGan_ has joined #openstack-horizon | 04:57 | |
| *** KunalGandhi has quit IRC | 04:57 | |
| *** pcaruana has quit IRC | 04:59 | |
| openstackgerrit | Merged openstack/horizon: Adding and using app.scss https://review.openstack.org/207668 | 05:00 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Dashboard ReOrg - Relocate Launch Instance module https://review.openstack.org/197234 | 05:01 |
| *** sayan has quit IRC | 05:02 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Dashboard ReOrg - Relocate Launch Instance module https://review.openstack.org/197234 | 05:14 |
| openstackgerrit | Richard Jones proposed openstack/horizon: JSCS Cleanup - style guide cleanup for Launch Instance wizard https://review.openstack.org/208316 | 05:17 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Dashboard ReOrg - Relocate Launch Instance module https://review.openstack.org/197234 | 05:22 |
| *** lucas__ has joined #openstack-horizon | 05:24 | |
| *** pkarikh_ has joined #openstack-horizon | 05:25 | |
| *** pkarikh_ has quit IRC | 05:25 | |
| r1chardj0n3s | sqchen: sorry about that app/core mis-merge! | 05:28 |
| r1chardj0n3s | thanks for picking up on it | 05:28 |
| sqchen | np. :) | 05:28 |
| *** lucas__ has quit IRC | 05:29 | |
| *** KunalGan_ has quit IRC | 05:29 | |
| r1chardj0n3s | I'd only just done one merge and was trying to submit my follow-on patch when another thing merged with master. ugh! :) | 05:29 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Dashboard ReOrg - retiring dashboard.scss https://review.openstack.org/209346 | 05:31 |
| *** yingjun has joined #openstack-horizon | 05:35 | |
| sqchen | sorry for that. | 05:36 |
| sqchen | :) | 05:36 |
| r1chardj0n3s | oh, we're gonna nuke dashboard.scss completely eh? I don't feel so bad about my bad merge now ;) | 05:36 |
| *** fedexo has quit IRC | 05:39 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: JSCS Cleanup - style guide cleanup for Launch Instance wizard https://review.openstack.org/208316 | 05:44 |
| *** kyleolivo has joined #openstack-horizon | 05:48 | |
| *** neelabh has joined #openstack-horizon | 05:51 | |
| *** lucas__ has joined #openstack-horizon | 05:51 | |
| *** neelabh has quit IRC | 05:51 | |
| *** lucas__ has quit IRC | 05:56 | |
| *** kyleolivo has quit IRC | 05:58 | |
| *** lyanchih_ has quit IRC | 05:58 | |
| *** lyanchih_ has joined #openstack-horizon | 06:06 | |
| *** neelabh has joined #openstack-horizon | 06:08 | |
| *** neelabh has quit IRC | 06:08 | |
| *** lucas__ has joined #openstack-horizon | 06:10 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/209358 | 06:11 |
| *** mrunge has joined #openstack-horizon | 06:12 | |
| *** sayan has joined #openstack-horizon | 06:15 | |
| *** lucas__ has quit IRC | 06:15 | |
| *** neelabh has joined #openstack-horizon | 06:24 | |
| *** alexvictorchan has joined #openstack-horizon | 06:25 | |
| *** nlahouti has joined #openstack-horizon | 06:27 | |
| *** neelabh has quit IRC | 06:29 | |
| *** nlahouti has quit IRC | 06:31 | |
| *** nlahouti has joined #openstack-horizon | 06:31 | |
| *** jbell8 has joined #openstack-horizon | 06:32 | |
| *** sqchen has quit IRC | 06:34 | |
| *** sqchen has joined #openstack-horizon | 06:35 | |
| *** pcaruana has joined #openstack-horizon | 06:36 | |
| *** jbell8 has quit IRC | 06:37 | |
| *** nlahouti has quit IRC | 06:40 | |
| *** stevemar has quit IRC | 06:40 | |
| *** stevemar has joined #openstack-horizon | 06:41 | |
| *** stevemar has quit IRC | 06:43 | |
| *** nlahouti has joined #openstack-horizon | 06:44 | |
| *** rdopiera has joined #openstack-horizon | 06:44 | |
| *** neelabh_ has joined #openstack-horizon | 06:47 | |
| *** lucas__ has joined #openstack-horizon | 06:47 | |
| *** neelabh_ has quit IRC | 06:48 | |
| *** lucas___ has joined #openstack-horizon | 06:50 | |
| *** lucas__ has quit IRC | 06:52 | |
| *** lucas___ has quit IRC | 06:55 | |
| *** neelabh_ has joined #openstack-horizon | 07:04 | |
| *** neelabh_ has quit IRC | 07:11 | |
| *** nlahouti has quit IRC | 07:12 | |
| *** Ala has joined #openstack-horizon | 07:12 | |
| *** jcoufal has joined #openstack-horizon | 07:13 | |
| *** sayan has quit IRC | 07:14 | |
| *** romainh has joined #openstack-horizon | 07:15 | |
| *** markus_z has joined #openstack-horizon | 07:16 | |
| *** neillc is now known as neillc_afk | 07:18 | |
| *** alexvictorchan has quit IRC | 07:21 | |
| *** lucas__ has joined #openstack-horizon | 07:21 | |
| *** yamamoto has quit IRC | 07:21 | |
| *** lucas__ has quit IRC | 07:25 | |
| *** yamamoto has joined #openstack-horizon | 07:26 | |
| *** neelabh_ has joined #openstack-horizon | 07:27 | |
| *** lsmola has joined #openstack-horizon | 07:29 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 07:29 | |
| *** neelabh_ has quit IRC | 07:30 | |
| *** pbourke has quit IRC | 07:33 | |
| *** mpavlase has joined #openstack-horizon | 07:33 | |
| *** pbourke has joined #openstack-horizon | 07:33 | |
| *** kodoku has joined #openstack-horizon | 07:34 | |
| kodoku | Hi, I have this bug : https://bugs.launchpad.net/horizon/+bug/1464461 So I need to disable french language on HORIZON. How can I force to choice english and how can I disable french language ? | 07:38 |
| openstack | Launchpad bug 1464461 in OpenStack Dashboard (Horizon) "delete action always cause error ( in kilo)" [High,Fix released] - Assigned to Matthias Runge (mrunge) | 07:38 |
| *** MaxV has joined #openstack-horizon | 07:38 | |
| *** sqchen has quit IRC | 07:42 | |
| openstackgerrit | ziyu032 proposed openstack/horizon: All workflow view miss url for a cancel action https://review.openstack.org/209386 | 07:43 |
| *** josecastroleon has quit IRC | 07:44 | |
| *** e0ne has joined #openstack-horizon | 07:47 | |
| *** josecastroleon has joined #openstack-horizon | 07:48 | |
| *** amotoki has joined #openstack-horizon | 07:48 | |
| *** neelabh has joined #openstack-horizon | 07:49 | |
| *** e0ne has quit IRC | 07:52 | |
| *** neelabh has quit IRC | 07:52 | |
| *** zz_ttrifonov is now known as ttrifonov | 07:54 | |
| *** e0ne has joined #openstack-horizon | 07:56 | |
| *** ttrifonov is now known as zz_ttrifonov | 07:56 | |
| mrunge | kodoku, any reason not to apply the patch? https://review.openstack.org/#/c/196637/1/horizon/tables/actions.py | 07:58 |
| *** bluex-pl has joined #openstack-horizon | 07:58 | |
| *** bluex-pl has quit IRC | 07:59 | |
| *** bluex-pl has joined #openstack-horizon | 07:59 | |
| kodoku | mrunge I have apply this patch, no works | 07:59 |
| mrunge | it doesn't work? | 07:59 |
| *** lucas__ has joined #openstack-horizon | 07:59 | |
| kodoku | mrunge I add comment on launchpad | 07:59 |
| mrunge | then please file a bug | 08:00 |
| kodoku | mrunge ok I'll add log after patch :) | 08:00 |
| openstackgerrit | Merged openstack/horizon: Use setUp() method for neutron rest test https://review.openstack.org/208781 | 08:01 |
| kodoku | mrunge I have same bug like #1 in launchpad | 08:01 |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Allow to edit image metadata from project view https://review.openstack.org/184280 | 08:01 |
| kodoku | mrunge UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 9: ordinal not in range(128) | 08:02 |
| kodoku | mrunge http://paste.openstack.org/show/408095/ | 08:02 |
| *** zz_ttrifonov is now known as ttrifonov | 08:02 | |
| *** lucas___ has joined #openstack-horizon | 08:03 | |
| openstackgerrit | ziyu032 proposed openstack/horizon: Display the project name in user detail page https://review.openstack.org/205983 | 08:03 |
| mrunge | kodoku, could you please add the same fix there too? | 08:03 |
| *** e0ne has quit IRC | 08:04 | |
| *** lucas__ has quit IRC | 08:04 | |
| kodoku | I add your two "u" like msgstr = pgettext_lazy(u"past", "%(action)s %(data_type)s") | 08:04 |
| kodoku | and msgstr = pgettext_lazy(u"present", "%(action)s %(data_type)s") | 08:04 |
| kodoku | copy come on my actions.py | 08:05 |
| kodoku | from* | 08:05 |
| mrunge | the error was in line 817 | 08:06 |
| kodoku | mrunge maybe need command for apply this patch ? I make ./manage.py collectstatic --clear => ./manage.py compress --force => service httpd restart | 08:06 |
| mrunge | looking at your log | 08:06 |
| kodoku | mrunge yes like in #1 in https://bugs.launchpad.net/horizon/+bug/1464461 | 08:06 |
| openstack | Launchpad bug 1464461 in OpenStack Dashboard (Horizon) "delete action always cause error ( in kilo)" [High,Fix released] - Assigned to Matthias Runge (mrunge) | 08:06 |
| openstackgerrit | Merged openstack/horizon: Replace filter() with a list-comprehension https://review.openstack.org/201101 | 08:06 |
| openstackgerrit | Yi Ming Zhao proposed openstack/horizon: Fix incorrect error message displayed while creating duplicate project https://review.openstack.org/209394 | 08:07 |
| kodoku | mrunge line 817 is "(self._get_action_name(past=True), datum_display))" | 08:08 |
| *** lucas___ has quit IRC | 08:08 | |
| mrunge | kodoku, I *think* you need to patch line 816 | 08:08 |
| *** neelabh_ has joined #openstack-horizon | 08:08 | |
| kodoku | mrunge ok patch LOG.info('%s: "%s"' % | 08:09 |
| mrunge | yes | 08:09 |
| *** btully has joined #openstack-horizon | 08:09 | |
| mrunge | and systemctl restart httpd | 08:09 |
| *** neelabh_ has quit IRC | 08:09 | |
| kodoku | What I need to modify ? add "u" ? | 08:09 |
| kodoku | mrunge ? | 08:13 |
| mrunge | yes | 08:13 |
| *** btully has quit IRC | 08:13 | |
| *** yingjun has quit IRC | 08:14 | |
| openstackgerrit | Yi Ming Zhao proposed openstack/horizon: Fix incorrect error message displayed while creating duplicate project https://review.openstack.org/209394 | 08:14 |
| kodoku | mrunge What I need to modify ? add "u" ? | 08:15 |
| mrunge | yes kodoku | 08:16 |
| kodoku | mrunge Can you give me patch plz ? I'am not good in python :/ | 08:16 |
| mrunge | kodoku, then you'll have to wait. | 08:16 |
| kodoku | ok no pb ;) | 08:16 |
| mrunge | kodoku, I am in the middle of something else | 08:16 |
| kodoku | I follow bug in launchpad thx :) | 08:17 |
| *** yingjun has joined #openstack-horizon | 08:21 | |
| *** kmARC has joined #openstack-horizon | 08:23 | |
| *** belmoreira has joined #openstack-horizon | 08:23 | |
| *** neelabh_ has joined #openstack-horizon | 08:26 | |
| *** sayali has joined #openstack-horizon | 08:29 | |
| *** kzaitsev_mb has joined #openstack-horizon | 08:30 | |
| *** jcoufal has quit IRC | 08:31 | |
| openstackgerrit | ziyu032 proposed openstack/horizon: Refacter the _workflow.html code https://review.openstack.org/209399 | 08:31 |
| *** jcoufal has joined #openstack-horizon | 08:33 | |
| *** kzaitsev_mb has quit IRC | 08:35 | |
| *** kodoku has quit IRC | 08:36 | |
| *** josecastroleon has quit IRC | 08:36 | |
| *** stevemar has joined #openstack-horizon | 08:41 | |
| *** MaxV has quit IRC | 08:42 | |
| *** neelabh_ has quit IRC | 08:42 | |
| *** yingjun has quit IRC | 08:45 | |
| *** josecastroleon has joined #openstack-horizon | 08:45 | |
| *** stevemar has quit IRC | 08:45 | |
| *** yingjun has joined #openstack-horizon | 08:47 | |
| *** bluex-pl has quit IRC | 08:55 | |
| *** kyleolivo has joined #openstack-horizon | 08:56 | |
| pkarikh | Hi folks! Can anyone tell me, why do we need to log Unauthorized exceptions? (https://github.com/openstack/horizon/blob/master/horizon/exceptions.py#L231) | 08:57 |
| mrunge | pkarikh, I have a use case for this. but we can make it configurable | 08:58 |
| mrunge | pkarikh, e.g you can easily create those exceptions yourself: https://bugs.launchpad.net/django-openstack-auth/+bug/1338986 | 08:59 |
| openstack | Launchpad bug 1338986 in django-openstack-auth "domain_context is not set in the client session" [High,Confirmed] | 08:59 |
| *** neelabh_ has joined #openstack-horizon | 08:59 | |
| pkarikh | mrunge: yep, I think we need. I've created test to be sure, that in some case user gets Unauthorized exception, and now when I run tests, I have these logging messages in the terminal. And I'm not sure that it is ok. | 09:00 |
| mrunge | ah, I see, pkarikh | 09:01 |
| *** kyleolivo has quit IRC | 09:01 | |
| mrunge | there were tests, which disabled logging for exceptions | 09:01 |
| mrunge | this is not really beautiful either | 09:02 |
| *** kodoku has joined #openstack-horizon | 09:03 | |
| pkarikh | mrunge: could you please tell me, where I can find an example of such tests? Maybe I can use them as a compromise. | 09:04 |
| mrunge | pkarikh, I'll have to look a bit | 09:05 |
| mrunge | I think that was used in sahara | 09:05 |
| *** lucas__ has joined #openstack-horizon | 09:05 | |
| *** jcoufal has quit IRC | 09:05 | |
| *** dboik_ has joined #openstack-horizon | 09:07 | |
| *** dboik_ has quit IRC | 09:07 | |
| *** dboik has joined #openstack-horizon | 09:08 | |
| *** lucas__ has quit IRC | 09:10 | |
| *** neelabh_ has quit IRC | 09:11 | |
| pkarikh | mrunge: hm.. Do you mean these tests? https://github.com/openstack/sahara-dashboard/tree/master/saharadashboard/tests | 09:11 |
| *** lyanchih has quit IRC | 09:13 | |
| *** lyanchih_ is now known as lyanchih | 09:13 | |
| mrunge | pkarikh, it was in horizon code base already | 09:13 |
| *** sayali has quit IRC | 09:14 | |
| mrunge | I just discovered it by accident, because it started to fail in django-1.8 | 09:14 |
| *** tosky has joined #openstack-horizon | 09:16 | |
| *** sayali has joined #openstack-horizon | 09:16 | |
| *** JeanBriceCombebi has quit IRC | 09:16 | |
| pkarikh | mrunge: yes, dashboards/project/data_processing, I've found is | 09:16 |
| pkarikh | *it | 09:16 |
| openstackgerrit | ziyu032 proposed openstack/horizon: All workflow view miss url for a cancel action https://review.openstack.org/209386 | 09:16 |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:16 | |
| *** jcoufal has joined #openstack-horizon | 09:18 | |
| *** jcoufal has quit IRC | 09:19 | |
| *** kzaitsev_mb has joined #openstack-horizon | 09:19 | |
| openstackgerrit | ziyu032 proposed openstack/horizon: Display the project name in user detail page https://review.openstack.org/205983 | 09:24 |
| *** MaxV has joined #openstack-horizon | 09:25 | |
| *** vgridnev has joined #openstack-horizon | 09:26 | |
| *** neelabh__ has joined #openstack-horizon | 09:29 | |
| *** lucas___ has joined #openstack-horizon | 09:30 | |
| *** e0ne has joined #openstack-horizon | 09:31 | |
| *** neelabh__ has quit IRC | 09:32 | |
| pkarikh | mrunge: but I can't find anything you've said about suppresing erros in tests. Have you find something? | 09:33 |
| mrunge | pkarikh, I stopped looking at it once you said "I've found it" | 09:34 |
| mrunge | let me have another look | 09:34 |
| *** lucas___ has quit IRC | 09:34 | |
| *** yingjun has quit IRC | 09:37 | |
| pkarikh | yes, sorry for confusing, I meant that I found data_procensing dashboard only | 09:37 |
| openstackgerrit | Vitaly Gridnev proposed openstack/horizon: [Sahara] Configure autoconfiguration for templates https://review.openstack.org/207399 | 09:38 |
| *** e0ne has quit IRC | 09:38 | |
| *** akrivoka has joined #openstack-horizon | 09:41 | |
| *** stevemar has joined #openstack-horizon | 09:42 | |
| *** stevemar has quit IRC | 09:46 | |
| *** MaxV has quit IRC | 09:47 | |
| *** JeanBriceCombebi has quit IRC | 09:47 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:48 | |
| *** neelabh__ has joined #openstack-horizon | 09:49 | |
| *** yamamoto has quit IRC | 09:52 | |
| *** neelabh__ has quit IRC | 09:54 | |
| *** jcoufal has joined #openstack-horizon | 09:56 | |
| *** KingaKhan has quit IRC | 09:57 | |
| *** KingKhan has joined #openstack-horizon | 09:57 | |
| *** KingKhan has quit IRC | 09:58 | |
| *** rdopiera has quit IRC | 09:59 | |
| *** MaxV has joined #openstack-horizon | 10:02 | |
| *** lucas___ has joined #openstack-horizon | 10:02 | |
| *** sayan has joined #openstack-horizon | 10:04 | |
| *** kzaitsev_mb has quit IRC | 10:05 | |
| *** yamamoto has joined #openstack-horizon | 10:07 | |
| *** lucas___ has quit IRC | 10:07 | |
| *** romainh has quit IRC | 10:07 | |
| *** lucas___ has joined #openstack-horizon | 10:07 | |
| openstackgerrit | Ana Krivokapic proposed openstack/horizon: Add generic session/cookie value getters/setters https://review.openstack.org/155939 | 10:07 |
| *** neelabh__ has joined #openstack-horizon | 10:10 | |
| *** lucas___ has quit IRC | 10:12 | |
| *** kodoku has quit IRC | 10:12 | |
| *** dimitrovskif has joined #openstack-horizon | 10:24 | |
| *** neelabh__ has joined #openstack-horizon | 10:27 | |
| openstackgerrit | Matthias Runge proposed openstack/django_openstack_auth: Replace AnonymousUser with AbstractBaseUser https://review.openstack.org/167981 | 10:28 |
| *** yamamoto has quit IRC | 10:29 | |
| *** e0ne has joined #openstack-horizon | 10:30 | |
| *** lucas___ has joined #openstack-horizon | 10:31 | |
| *** lucas___ has quit IRC | 10:35 | |
| *** Guest71092 has joined #openstack-horizon | 10:41 | |
| *** lyanchih has quit IRC | 10:43 | |
| *** Guest32642 has joined #openstack-horizon | 10:45 | |
| *** Guest71092 has quit IRC | 10:46 | |
| *** e0ne has quit IRC | 10:46 | |
| *** robcresswell_ has joined #openstack-horizon | 10:46 | |
| *** jasondotstar has joined #openstack-horizon | 10:47 | |
| *** robcresswell_ has quit IRC | 10:48 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: Fixed alignment issues in create firewall https://review.openstack.org/209455 | 10:50 |
| *** josecastroleon has quit IRC | 10:52 | |
| *** dimitrovskif has quit IRC | 10:52 | |
| *** Guest32642 has quit IRC | 10:53 | |
| *** jpomeroy has quit IRC | 10:55 | |
| pkarikh | mrunge: looks like there is no simple way to avoid unauthorized exceptions logging only in tests, since I test the consequences this exception was raised.. Am I right that such logging messages in tests terminal output is a very bad idea? | 10:56 |
| *** markus_z has quit IRC | 10:57 | |
| pkarikh | here is thetest, if it is important https://review.openstack.org/#/c/142481/44/openstack_dashboard/dashboards/project/overview/tests.py | 10:57 |
| *** h00327910__ has quit IRC | 10:58 | |
| *** kyleolivo has joined #openstack-horizon | 10:58 | |
| mrunge | pkarikh, I just started to look at it again | 11:01 |
| *** jprovazn_ has joined #openstack-horizon | 11:02 | |
| *** kyleolivo has quit IRC | 11:03 | |
| *** lucas__ has joined #openstack-horizon | 11:03 | |
| pkarikh | mrunge: oh, ok | 11:03 |
| *** kzaitsev_mb has joined #openstack-horizon | 11:03 | |
| mrunge | pkarikh, https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/projects/tests.py#L1555 | 11:06 |
| *** josecastroleon has joined #openstack-horizon | 11:06 | |
| mrunge | hope that helps | 11:06 |
| pkarikh | mrunge: am I right that logging.disable(logging.NOTSET) restores logging as it was before? | 11:06 |
| *** e0ne has joined #openstack-horizon | 11:07 | |
| *** JeanBriceCombebi has quit IRC | 11:07 | |
| *** lucas__ has quit IRC | 11:08 | |
| mrunge | pkarikh, I assume that | 11:08 |
| *** yamamoto has joined #openstack-horizon | 11:11 | |
| openstackgerrit | Matthias Runge proposed openstack/horizon: remove django<1.7 from tests https://review.openstack.org/201066 | 11:12 |
| *** jprovazn_ is now known as jprovazn | 11:12 | |
| *** yamamoto_ has joined #openstack-horizon | 11:12 | |
| *** markus_z has joined #openstack-horizon | 11:12 | |
| *** yamamoto has quit IRC | 11:16 | |
| *** robcresswel has joined #openstack-horizon | 11:16 | |
| *** robcresswell has joined #openstack-horizon | 11:16 | |
| robcresswel | Ah hooray, ZNC is alive | 11:16 |
| *** robcresswel has left #openstack-horizon | 11:16 | |
| *** robcresswell is now known as Guest24481 | 11:16 | |
| *** jpomeroy has joined #openstack-horizon | 11:25 | |
| *** jpomeroy has quit IRC | 11:25 | |
| *** Guest24481 has quit IRC | 11:25 | |
| *** alexpilotti has joined #openstack-horizon | 11:26 | |
| *** robcresswell has joined #openstack-horizon | 11:26 | |
| *** robcresswell is now known as Guest17976 | 11:27 | |
| *** Guest17976 is now known as robcresswell | 11:30 | |
| *** e0ne has quit IRC | 11:34 | |
| *** yamamoto_ has quit IRC | 11:35 | |
| *** robcresswell has quit IRC | 11:37 | |
| *** robcresswell has joined #openstack-horizon | 11:37 | |
| *** robcresswell is now known as Guest46587 | 11:37 | |
| *** romainh has joined #openstack-horizon | 11:37 | |
| Guest46587 | o/ | 11:38 |
| Guest46587 | Ugh, znc still borken | 11:39 |
| Guest46587 | brb | 11:39 |
| *** masco has joined #openstack-horizon | 11:39 | |
| *** Guest46587 has quit IRC | 11:41 | |
| *** btully has joined #openstack-horizon | 11:45 | |
| *** robcresswell has joined #openstack-horizon | 11:47 | |
| *** yingjun has joined #openstack-horizon | 11:47 | |
| robcresswell | Success! ZNC lives! Afternoon all. | 11:48 |
| *** julim has joined #openstack-horizon | 11:49 | |
| *** btully has quit IRC | 11:50 | |
| *** yamamoto has joined #openstack-horizon | 11:50 | |
| r1chardj0n3s | ohai robcresswell | 11:52 |
| *** jcoufal has quit IRC | 11:56 | |
| robcresswell | r1chardj0n3s: o/ | 11:57 |
| *** lucas___ has joined #openstack-horizon | 11:57 | |
| r1chardj0n3s | how's things? | 11:58 |
| mrunge | good morning robcresswell | 11:58 |
| robcresswell | I managed to argue some more time on upstream work. Gonna be picking up lotsa reviews if you have any requests. | 11:58 |
| mrunge | hey r1chardj0n3s o/ | 11:58 |
| r1chardj0n3s | ohai mrunge | 11:58 |
| robcresswell | Yeah, all well, been learning alot about the python customisation stuff in Horizon. | 11:58 |
| robcresswell | How's things with you? | 11:58 |
| r1chardj0n3s | busy busy :) | 11:59 |
| r1chardj0n3s | caught the flu just before the midcycle which knocked me out the week after it (and on the plane home) so I'm just getting back into things now | 11:59 |
| r1chardj0n3s | and I've just been told that domain-scoped tokens stuff is a priority, so that's fun :) | 11:59 |
| *** ttrifonov is now known as zz_ttrifonov | 12:00 | |
| mrunge | yes, domain-scoped tokens are actually requested quite often | 12:01 |
| mrunge | but we might have to come up with a plan, how to visualize that stuff | 12:01 |
| robcresswell | Meeting over in #openstack-meeting-3 folks. All welcome! | 12:01 |
| *** lucas___ has quit IRC | 12:02 | |
| *** lucas___ has joined #openstack-horizon | 12:03 | |
| *** rdopiera has joined #openstack-horizon | 12:03 | |
| *** e0ne has joined #openstack-horizon | 12:06 | |
| *** lucas___ has quit IRC | 12:07 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/209358 | 12:08 |
| *** bluex-pl has joined #openstack-horizon | 12:09 | |
| *** bluex-pl has quit IRC | 12:09 | |
| *** bluex-pl has joined #openstack-horizon | 12:09 | |
| *** Samos123 has joined #openstack-horizon | 12:11 | |
| Samos123 | hi guys would appreciate reviews on: https://review.openstack.org/#/c/174211/ Pre-create neutron ports on instance creation | 12:12 |
| *** JeanBriceCombebi has joined #openstack-horizon | 12:13 | |
| *** lucas___ has joined #openstack-horizon | 12:13 | |
| *** kodoku has joined #openstack-horizon | 12:14 | |
| pkarikh | mrunge: hm, looks like your approach works, thanks. I need to fix some problems since __exit__ method is missing in mock, but looks like it is the right way. | 12:17 |
| mrunge | pkarikh, yay! Great! | 12:17 |
| *** jcoufal has joined #openstack-horizon | 12:17 | |
| *** lucas___ has quit IRC | 12:18 | |
| *** alejandrito has joined #openstack-horizon | 12:19 | |
| *** JeanBriceCombebi has quit IRC | 12:30 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 12:31 | |
| *** kzaitsev_mb has quit IRC | 12:35 | |
| *** lucas___ has joined #openstack-horizon | 12:36 | |
| *** markus_z has quit IRC | 12:40 | |
| *** lucas___ has quit IRC | 12:41 | |
| *** markus_z has joined #openstack-horizon | 12:42 | |
| *** yamamoto has quit IRC | 12:43 | |
| *** lucas___ has joined #openstack-horizon | 12:48 | |
| *** lucas___ has quit IRC | 12:52 | |
| *** bapalm has joined #openstack-horizon | 12:52 | |
| *** bapalm_ has joined #openstack-horizon | 12:53 | |
| *** yamamoto has joined #openstack-horizon | 12:54 | |
| *** bapalm has quit IRC | 12:57 | |
| *** lucas___ has joined #openstack-horizon | 13:02 | |
| *** petertr7_away is now known as petertr7 | 13:03 | |
| *** zul has joined #openstack-horizon | 13:05 | |
| masco | robcresswell, i hope you are planning to do some reviews ;) today, you can have a look at some of my patches. thanks in advance :) | 13:05 |
| *** lucas___ has quit IRC | 13:07 | |
| *** JeanBriceCombebi has quit IRC | 13:07 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:07 | |
| *** alejandrito has quit IRC | 13:10 | |
| *** yamamoto has quit IRC | 13:10 | |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Logout user if he has no valid tokens https://review.openstack.org/142481 | 13:13 |
| *** lucas__ has joined #openstack-horizon | 13:16 | |
| *** vgridnev has quit IRC | 13:16 | |
| *** masco has quit IRC | 13:20 | |
| *** lucas__ has quit IRC | 13:20 | |
| *** alexpilotti has quit IRC | 13:21 | |
| *** lblanchard has joined #openstack-horizon | 13:22 | |
| *** alexpilotti has joined #openstack-horizon | 13:23 | |
| *** kodoku has quit IRC | 13:23 | |
| *** ccard has quit IRC | 13:24 | |
| *** tosky has quit IRC | 13:25 | |
| *** btully has joined #openstack-horizon | 13:25 | |
| *** jpomeroy has joined #openstack-horizon | 13:26 | |
| *** tosky has joined #openstack-horizon | 13:29 | |
| *** rdopiera has quit IRC | 13:30 | |
| *** neelabh__ has quit IRC | 13:31 | |
| *** lucas___ has joined #openstack-horizon | 13:33 | |
| robcresswell | david-lyle: Did you say there's some docs coming for the panel patch? | 13:34 |
| *** petertr7 is now known as petertr7_away | 13:34 | |
| david-lyle | robcresswell: not with the current patch | 13:35 |
| david-lyle | larger doc patch around policies and how tos | 13:35 |
| david-lyle | probably should come as two doc patches | 13:36 |
| robcresswell | david-lyle: Cool, just wanted to see if any were in the pipeline | 13:36 |
| david-lyle | then add around things that I consider missing features | 13:36 |
| david-lyle | s/around/more content around/ | 13:36 |
| *** lucas___ has quit IRC | 13:38 | |
| *** petertr7_away is now known as petertr7 | 13:38 | |
| robcresswell | david-lyle: So Dashboards are still registered as usual, too? But panels/ groups are now enabled-only | 13:38 |
| *** neelashah has joined #openstack-horizon | 13:38 | |
| david-lyle | robcresswell: so dashboard.py still requires the register call | 13:39 |
| david-lyle | I think that's a bug that should be addressed separately | 13:39 |
| david-lyle | the panels are already registered in the process so having in panel.py is redundant | 13:39 |
| *** tvanderwiel has joined #openstack-horizon | 13:40 | |
| *** tvanderwiel has left #openstack-horizon | 13:40 | |
| david-lyle | and panel groups are just different | 13:40 |
| robcresswell | david-lyle: Yeah, addressing it seperately is fine, just making sure I understand correctly. Looks good. | 13:41 |
| david-lyle | I was hoping to remove that too, but things don't work well without the dashboard register, and by not well I mean not at all | 13:42 |
| david-lyle | should be a relatively easy fix | 13:42 |
| david-lyle | _should_ | 13:42 |
| *** jtriley has joined #openstack-horizon | 13:45 | |
| *** lucas___ has joined #openstack-horizon | 13:48 | |
| *** lucas___ has quit IRC | 13:52 | |
| robcresswell | david-lyle: Approved it boss. | 13:56 |
| david-lyle | robcresswell: check is in the mail | 13:56 |
| david-lyle | :) | 13:56 |
| robcresswell | Its amazing how lively everyone is when I mention I have time to review, so many messages :p | 13:56 |
| robcresswell | They'll be sorry when I throw -1s all over their patches. | 13:57 |
| david-lyle | haha | 13:57 |
| david-lyle | robcresswell: https://review.openstack.org/209523 | 13:59 |
| david-lyle | FYI | 13:59 |
| openstackgerrit | Chad Roberts proposed openstack/horizon: Adding option for Spark jobs to use Swift paths https://review.openstack.org/187711 | 14:00 |
| *** sjmc7 has joined #openstack-horizon | 14:01 | |
| *** matt-borland has joined #openstack-horizon | 14:03 | |
| matt-borland | robcresswell: around? | 14:03 |
| *** matt-borland has quit IRC | 14:04 | |
| *** matt-borland has joined #openstack-horizon | 14:04 | |
| *** mpavlase has quit IRC | 14:05 | |
| *** zigo has quit IRC | 14:05 | |
| *** zigo has joined #openstack-horizon | 14:06 | |
| *** mpavlase has joined #openstack-horizon | 14:08 | |
| openstackgerrit | Chad Roberts proposed openstack/horizon: Adding option for Spark jobs to use Swift paths https://review.openstack.org/187711 | 14:09 |
| *** yamamoto has joined #openstack-horizon | 14:11 | |
| *** romainh has quit IRC | 14:11 | |
| *** matt-borland_ has joined #openstack-horizon | 14:13 | |
| *** mpavlase has quit IRC | 14:16 | |
| *** yamamoto has quit IRC | 14:16 | |
| openstackgerrit | Chad Roberts proposed openstack/horizon: Adding option for name and uuid substitution https://review.openstack.org/188422 | 14:17 |
| *** matt-borland has quit IRC | 14:17 | |
| *** lucas___ has joined #openstack-horizon | 14:18 | |
| *** geoffarnold has joined #openstack-horizon | 14:19 | |
| *** yingjun has quit IRC | 14:20 | |
| *** geoffarnold has quit IRC | 14:22 | |
| *** lucas___ has quit IRC | 14:22 | |
| *** matt-borland__ has joined #openstack-horizon | 14:23 | |
| *** geoffarnold has joined #openstack-horizon | 14:23 | |
| *** matt-borland_ has quit IRC | 14:27 | |
| *** lucas___ has joined #openstack-horizon | 14:27 | |
| *** romainh has joined #openstack-horizon | 14:27 | |
| *** mpavlase has joined #openstack-horizon | 14:28 | |
| pkarikh | Fols, does anyone know, why DOA does not raise here some unauthorised exception? https://github.com/openstack/django_openstack_auth/blob/master/openstack_auth/user.py#L309 Is there some reason for it? | 14:35 |
| pkarikh | *folks | 14:35 |
| pkarikh | Now user just will get _authorized_tenants=[], but there is no redirection to login page or something like this. Is it ok? | 14:36 |
| *** yingjun has joined #openstack-horizon | 14:36 | |
| *** bapalm_ has quit IRC | 14:38 | |
| *** matt-borland__ has quit IRC | 14:38 | |
| *** jcoufal has quit IRC | 14:39 | |
| *** vijendar has joined #openstack-horizon | 14:42 | |
| *** stevemar has joined #openstack-horizon | 14:46 | |
| *** bapalm_ has joined #openstack-horizon | 14:46 | |
| *** romainh has left #openstack-horizon | 14:47 | |
| *** jcoufal has joined #openstack-horizon | 14:47 | |
| *** jcoufal has quit IRC | 14:48 | |
| *** jcoufal has joined #openstack-horizon | 14:49 | |
| kfox1111 | david-lyle: https://youtu.be/2UQ6xa6uDQY :) | 14:50 |
| openstackgerrit | Merged openstack/horizon: Move Horizon to pure plugin loading only https://review.openstack.org/208643 | 14:51 |
| *** jcoufal has quit IRC | 14:51 | |
| *** jcoufal has joined #openstack-horizon | 14:52 | |
| *** sayan has quit IRC | 14:52 | |
| *** Piet has quit IRC | 14:55 | |
| *** _crobertsrh is now known as crobertsrh | 14:57 | |
| *** mwhagedorn has quit IRC | 14:59 | |
| *** JeanBriceCombebi has quit IRC | 15:05 | |
| jschlueter | pkarikh: what would cause Authentication Failure for that case to be thrown? | 15:08 |
| jschlueter | pkarikh: any common or edge cases? | 15:08 |
| *** emw has joined #openstack-horizon | 15:09 | |
| openstackgerrit | Chad Roberts proposed openstack/horizon: Adding option for name and uuid substitution https://review.openstack.org/188422 | 15:10 |
| pkarikh | jschlueter: for example, user loggs in to the Horizon. After that admin disables user, so now users token is invalid. User tries to open some page (I've got it on the access and security). And this code loggs "Unauthorized: The request you have made requires authentication. " message. But user will get correctly rendered page. | 15:11 |
| openstackgerrit | Merged openstack/horizon: Implement client API bindings for Neutron subnet allocation https://review.openstack.org/203569 | 15:11 |
| openstackgerrit | Merged openstack/horizon: added common name based filter for tables https://review.openstack.org/171063 | 15:12 |
| *** hurgleburgler has joined #openstack-horizon | 15:13 | |
| pkarikh | jschlueter: I'm working on patch for Horizon. which makes Horizon log out user if he has invalid token and gets unauthorized exception from services. | 15:14 |
| *** radez is now known as radez_g0n3 | 15:15 | |
| jschlueter | pkarikh: ok thanks, was just trying to figure out how the create_instance flow popup could come up with the Projects & Users panel with no Projects listed in the drop down | 15:15 |
| *** Ephur has quit IRC | 15:16 | |
| robcresswell | Dang, missed Matt | 15:17 |
| *** mpavlase has quit IRC | 15:20 | |
| pkarikh | jschlueter: oh, you faced this issue already? | 15:20 |
| kfox1111 | Can anyone help me with this: http://logs.openstack.org/73/206773/11/check/gate-horizon-npm-run-test/a04199c/console.html with reguards to this code: https://review.openstack.org/#/c/206773/ | 15:26 |
| kfox1111 | I don't quite get what the test framework's doing. | 15:26 |
| *** Ephur has joined #openstack-horizon | 15:26 | |
| robcresswell | kfox1111: Karma spins up PhantomJS, which is a kind of headless browser engine afaik, then runs the unit tests. Your code is failing at openstack_dashboard/static/app/core/openstack-service-api/heat.service.spec.js:56 | 15:28 |
| robcresswell | It seems | 15:28 |
| *** bpokorny has joined #openstack-horizon | 15:29 | |
| *** bapalm_ has quit IRC | 15:34 | |
| *** josecastroleon has quit IRC | 15:34 | |
| *** petertr7 is now known as petertr7_away | 15:35 | |
| *** gyee has joined #openstack-horizon | 15:36 | |
| *** Sukhdev has joined #openstack-horizon | 15:37 | |
| *** belmoreira has quit IRC | 15:39 | |
| kfox1111 | robcresswell: Yeah. But I don't understand what the error message means. | 15:41 |
| *** jbell8 has joined #openstack-horizon | 15:41 | |
| kfox1111 | TypeError: '[object Object]' is not a valid argument for 'Function.prototype.apply' (evaluating 'config.testInput') | 15:42 |
| *** garthb has joined #openstack-horizon | 15:42 | |
| *** sqchen has joined #openstack-horizon | 15:46 | |
| *** mwhagedorn has joined #openstack-horizon | 15:47 | |
| *** garthb has quit IRC | 15:48 | |
| *** lucas___ has quit IRC | 15:49 | |
| *** geoffarnold has quit IRC | 15:52 | |
| robcresswell | kfox1111: Ah, sorry | 15:52 |
| *** sayali has quit IRC | 15:54 | |
| *** nlahouti has joined #openstack-horizon | 15:55 | |
| *** yamamoto has joined #openstack-horizon | 15:55 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Dashboard ReOrg - Relocate Launch Instance module https://review.openstack.org/197234 | 15:55 |
| *** bapalm_ has joined #openstack-horizon | 15:57 | |
| *** Ala has quit IRC | 15:57 | |
| *** lucas__ has joined #openstack-horizon | 15:59 | |
| *** lucas__ has quit IRC | 16:00 | |
| *** lucas__ has joined #openstack-horizon | 16:01 | |
| openstackgerrit | Kevin Fox proposed openstack/horizon: A few tweaks to make the App Catalog plugin work. https://review.openstack.org/206773 | 16:03 |
| *** alexvictorchan has joined #openstack-horizon | 16:03 | |
| *** neelashah has quit IRC | 16:04 | |
| *** SimonChung has joined #openstack-horizon | 16:05 | |
| *** sayan has joined #openstack-horizon | 16:05 | |
| *** alexpilotti has quit IRC | 16:06 | |
| *** neelashah has joined #openstack-horizon | 16:07 | |
| *** stevemar has quit IRC | 16:10 | |
| *** stevemar has joined #openstack-horizon | 16:11 | |
| *** yingjun has quit IRC | 16:12 | |
| *** kyleolivo has joined #openstack-horizon | 16:12 | |
| *** yingjun has joined #openstack-horizon | 16:12 | |
| *** radez_g0n3 is now known as radez | 16:12 | |
| *** kyleolivo has quit IRC | 16:13 | |
| *** yingjun has quit IRC | 16:13 | |
| *** kyleolivo has joined #openstack-horizon | 16:13 | |
| *** jpomeroy has quit IRC | 16:13 | |
| *** yingjun has joined #openstack-horizon | 16:14 | |
| *** jpomeroy has joined #openstack-horizon | 16:14 | |
| *** garthb has joined #openstack-horizon | 16:16 | |
| *** garthb_ has joined #openstack-horizon | 16:16 | |
| *** garthb_ has quit IRC | 16:17 | |
| *** kmARC has quit IRC | 16:18 | |
| *** raildo has joined #openstack-horizon | 16:18 | |
| *** yingjun has quit IRC | 16:18 | |
| *** jwy has joined #openstack-horizon | 16:23 | |
| *** rdopiera has joined #openstack-horizon | 16:24 | |
| *** rdopiera has joined #openstack-horizon | 16:24 | |
| robcresswell | david-lyle: Thinking out loud... can we make a panel that appears just when DEBUG is True? could use it to route to the in-browser jasmine tests, as well as an example page for angular bits and pieces when we get to that stage. | 16:25 |
| robcresswell | Like a dev page. Seems like it would be valuable. | 16:26 |
| *** pcaruana has quit IRC | 16:26 | |
| david-lyle | the can_register method could check for DEBUG | 16:26 |
| david-lyle | sure | 16:26 |
| kfox1111 | that would be cool. :) | 16:26 |
| david-lyle | that's the type of thing it's for | 16:26 |
| robcresswell | Nice | 16:27 |
| david-lyle | so easy as could be | 16:27 |
| david-lyle | make the magic robcresswell | 16:27 |
| *** geoffarnold has joined #openstack-horizon | 16:29 | |
| *** petertr7_away is now known as petertr7 | 16:29 | |
| *** openstackgerrit_ has joined #openstack-horizon | 16:30 | |
| kfox1111 | david-lyle: Know what Paulo was talking about here: https://review.openstack.org/#/c/206773/7/openstack_dashboard/static/openstack-service-api/heat.service.spec.js ? | 16:30 |
| david-lyle | kfox1111: I must admit I'm not up on the eslint rules | 16:31 |
| kfox1111 | k. thanks. | 16:32 |
| david-lyle | TravT: do you know? | 16:32 |
| david-lyle | ^^^^ | 16:32 |
| *** jingjing_ren has joined #openstack-horizon | 16:32 | |
| TravT | david-lyle: looking | 16:33 |
| TravT | kfox1111: you can inject $windowProvider and the call $get on it to get the window. | 16:34 |
| TravT | this way you are using the angular version of it | 16:34 |
| kfox1111 | so var window = $widnowProvider.$get() ? | 16:34 |
| TravT | quick search of horizon github shows a number of examples | 16:35 |
| robcresswell | dang, I was just writing this :p | 16:35 |
| TravT | https://github.com/openstack/horizon/search?utf8=%E2%9C%93&q=%24windowProvider | 16:35 |
| robcresswell | $windowProvider.$get() is correct, yes | 16:35 |
| robcresswell | Basically, avoiding globals is the aim I *think* ? | 16:35 |
| TravT | i think there is a patch out there for mocking window... | 16:36 |
| kfox1111 | horizon/static/framework/framework.module.spec.js maybe? | 16:36 |
| TravT | yeah that's somebody using it today | 16:36 |
| kfox1111 | I see no examples of window.apiTest.initServices($provide, apiService, toastService); with $windowProvider anywhere in tree. | 16:37 |
| TravT | here's what I was thinking of... I haven't read it too deeply yet though | 16:37 |
| TravT | https://review.openstack.org/#/c/199333/ | 16:37 |
| robcresswell | Yeah, a unit test shouldn't rely on window right? Not dependable. | 16:38 |
| kfox1111 | should I be copying a set of code that hasn't been reviewed yet into a bug fix? | 16:38 |
| kfox1111 | /hasn't fininished being reviewed yet/ | 16:38 |
| TravT | oh man... you are updating cloud services too. | 16:39 |
| kfox1111 | yeah. this is getting really painful. :/ | 16:39 |
| TravT | i've got to get my refactoring of that rebased | 16:39 |
| *** jingjing_ren has quit IRC | 16:39 | |
| kfox1111 | stuff keeps moving around. | 16:40 |
| kfox1111 | I had to refactor it like 4 times yesterday alone. | 16:40 |
| *** mwhagedorn has quit IRC | 16:41 | |
| *** zz_ttrifonov is now known as ttrifonov | 16:42 | |
| TravT | i think you'd be safe following that pattern for replacing window that is going into that patch i mentioned above | 16:42 |
| TravT | but then you might have to depend on that patch... | 16:42 |
| TravT | :( | 16:42 |
| TravT | s/might/would | 16:43 |
| robcresswell | It seems like Rajat has just been rebasing that patch loads... I wonder why | 16:43 |
| robcresswell | Its active, either way, depending on it may not be a bad idea. | 16:43 |
| *** kyleolivo has quit IRC | 16:45 | |
| *** kyleolivo has joined #openstack-horizon | 16:46 | |
| *** mwhagedorn has joined #openstack-horizon | 16:49 | |
| kfox1111 | I'm starting to think I should just break this patch up into lots of small ones, so I can slide them in quickly, one at a time. | 16:49 |
| kfox1111 | but I don't know if I can get them reviewed quickly though. | 16:50 |
| kfox1111 | save some work rebasing the whole set each time then getting all of it rereviewed. | 16:50 |
| *** ttrifonov is now known as zz_ttrifonov | 16:51 | |
| TravT | you are adding heat API in that patch because the other items in that patch use it? | 16:51 |
| openstackgerrit | Steve McLellan proposed openstack/horizon: Searchlight API for horizon https://review.openstack.org/204721 | 16:53 |
| *** KunalGandhi has joined #openstack-horizon | 16:55 | |
| *** ybathia has joined #openstack-horizon | 16:55 | |
| kfox1111 | no. I think it can be split out pretty easily. It was just simple to have it all in one patch. | 16:56 |
| TravT | then i think it would be better to separate the API pieces | 16:57 |
| kfox1111 | k. | 16:57 |
| TravT | those typically go into a single patch. | 16:57 |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 16:57 |
| TravT | so, python and angular side all in one API patch. | 16:57 |
| kfox1111 | ok. will do. | 16:57 |
| *** DaveJ__ has joined #openstack-horizon | 16:58 | |
| kfox1111 | hanks. | 16:58 |
| kfox1111 | thanks. | 16:58 |
| *** sayan has quit IRC | 16:58 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 16:58 | |
| TravT | david-lyle: any traction on that horizon devstack patch? | 16:59 |
| *** sayan has joined #openstack-horizon | 16:59 | |
| david-lyle | still trying to fix new issue with moved themes | 17:00 |
| david-lyle | other than that I think it will be approved easily | 17:00 |
| david-lyle | I'm aiming for a moving target | 17:00 |
| TravT | i couldn't stand not being all up to date anymore and just kicked off another devstack. also, need to get a devstack running with designate in it. | 17:00 |
| *** bapalm_ has quit IRC | 17:00 | |
| *** rdopiera has quit IRC | 17:00 | |
| *** Piet has joined #openstack-horizon | 17:02 | |
| *** raildo has quit IRC | 17:03 | |
| Piet | I went ahead and started adding status icons to each of the projects in Invision so folks know which need to be reviewed and which have been closed. Take a look and let me know if it is helpful. https://openstack.invisionapp.com | 17:03 |
| *** lhcheng has joined #openstack-horizon | 17:05 | |
| *** openstackgerrit_ has quit IRC | 17:05 | |
| gyee | david-lyle, WebSSO for federation is not supported in Kilo right? | 17:05 |
| *** lhcheng has left #openstack-horizon | 17:05 | |
| david-lyle | gyee: it was | 17:06 |
| gyee | oh | 17:06 |
| david-lyle | er, is | 17:07 |
| gyee | so Horizon starting to support websso in Kilo, but nothing before that | 17:07 |
| gyee | I don't see it in the release note | 17:07 |
| david-lyle | gyee, yes | 17:07 |
| david-lyle | it should be there | 17:07 |
| gyee | btw, I am putting together an executive summary for the big boys, just don't want them to think I am shooting bulls | 17:07 |
| gyee | lemme 2x check | 17:08 |
| *** sqchen has quit IRC | 17:08 | |
| *** tyr has joined #openstack-horizon | 17:08 | |
| *** akrivoka has quit IRC | 17:08 | |
| david-lyle | gyee #1 new feature | 17:08 |
| david-lyle | Key New Feature, I might add | 17:08 |
| gyee | oh I see | 17:08 |
| gyee | david-lyle, thanks! | 17:09 |
| david-lyle | you keystone guys get all the press | 17:09 |
| david-lyle | and jackets | 17:09 |
| david-lyle | :P | 17:09 |
| gyee | I was searching for keyword federation | 17:09 |
| gyee | hah | 17:09 |
| *** MaxV has quit IRC | 17:10 | |
| stevemar | gyee: rookie mistake | 17:10 |
| gyee | stevemar, you want to proofread my stuff once I have it? | 17:11 |
| gyee | I have some nice looking charts too | 17:11 |
| jschlueter | pkarikh: was at lunch, but we have a bug report that may have see this issue but haven't found root cause yet. | 17:12 |
| david-lyle | gyee, up and to the right? | 17:13 |
| *** e0ne has quit IRC | 17:13 | |
| gyee | david-lyle, that's "the door" I think :) | 17:13 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Add angular defaults panel for admin https://review.openstack.org/205296 | 17:13 |
| david-lyle | just the highest window I can reach with a decent ledge | 17:13 |
| gyee | lol | 17:14 |
| *** skylerberg has joined #openstack-horizon | 17:18 | |
| *** lhcheng has joined #openstack-horizon | 17:19 | |
| *** ^Gal^ has quit IRC | 17:20 | |
| *** sqchen has joined #openstack-horizon | 17:20 | |
| *** neelashah has quit IRC | 17:20 | |
| *** jingjing_ren has joined #openstack-horizon | 17:20 | |
| *** kyleolivo has quit IRC | 17:21 | |
| *** sqchen has left #openstack-horizon | 17:22 | |
| *** ^Gal^ has joined #openstack-horizon | 17:22 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Dashboard ReOrg - Relocate Launch Instance module https://review.openstack.org/197234 | 17:23 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Dashboard ReOrg - hz.dashboard --> horizon.dashboard https://review.openstack.org/206760 | 17:23 |
| *** openstackgerrit_ has joined #openstack-horizon | 17:24 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - horizon/ tech-debt https://review.openstack.org/199345 | 17:28 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - horizon/ tech-debt https://review.openstack.org/199345 | 17:28 |
| openstackgerrit | Thai Tran proposed openstack/horizon: WIP Testing new transfer table. https://review.openstack.org/208867 | 17:29 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP - Image Details Edit/Delete (UX/Angular) https://review.openstack.org/158409 | 17:30 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Detail-page directives (Angular/UX) with CSS https://review.openstack.org/158881 | 17:31 |
| *** rajatvig has joined #openstack-horizon | 17:31 | |
| *** iamjarvo has joined #openstack-horizon | 17:32 | |
| *** iamjarvo has quit IRC | 17:32 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 17:32 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP - Image Details Edit/Delete (UX/Angular) https://review.openstack.org/158409 | 17:32 |
| *** iamjarvo has joined #openstack-horizon | 17:32 | |
| *** iamjarvo has quit IRC | 17:32 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: API for getting default quotas in admin https://review.openstack.org/207126 | 17:33 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Add angular defaults panel for admin https://review.openstack.org/205296 | 17:33 |
| *** iamjarvo has joined #openstack-horizon | 17:33 | |
| *** iamjarvo has quit IRC | 17:33 | |
| *** iamjarvo has joined #openstack-horizon | 17:34 | |
| *** openstackgerrit_ has quit IRC | 17:34 | |
| *** tosky has quit IRC | 17:36 | |
| *** kyleolivo has joined #openstack-horizon | 17:36 | |
| *** sqchen has joined #openstack-horizon | 17:37 | |
| *** Sukhdev has quit IRC | 17:37 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Move humanize and truncate to horizon.quota.js https://review.openstack.org/207549 | 17:38 |
| *** kyleoliv_ has joined #openstack-horizon | 17:40 | |
| *** kyleolivo has quit IRC | 17:41 | |
| *** jprovazn has quit IRC | 17:41 | |
| *** lsmola has quit IRC | 17:42 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Dashboard ReOrg - Remove unused dashboard.module.js https://review.openstack.org/209613 | 17:44 |
| *** iamjarvo has quit IRC | 17:45 | |
| *** petertr7 is now known as petertr7_away | 17:46 | |
| *** kyleoliv_ has quit IRC | 17:46 | |
| *** markus_z has quit IRC | 17:46 | |
| *** neelashah has joined #openstack-horizon | 17:47 | |
| *** e0ne has joined #openstack-horizon | 17:53 | |
| *** tosky has joined #openstack-horizon | 17:53 | |
| *** mwhagedorn has quit IRC | 17:53 | |
| *** yamamoto has quit IRC | 17:53 | |
| openstackgerrit | Chad Roberts proposed openstack/horizon: Adding support for Manila-based shares in Sahara https://review.openstack.org/207086 | 17:55 |
| *** petertr7_away is now known as petertr7 | 17:56 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Remove app-specific config from framework module https://review.openstack.org/203832 | 17:57 |
| openstackgerrit | Chad Roberts proposed openstack/horizon: Adding support for Manila-based shares in Sahara https://review.openstack.org/207086 | 17:57 |
| *** matt-borland has joined #openstack-horizon | 17:58 | |
| *** lucas__ has quit IRC | 17:59 | |
| *** lucas__ has joined #openstack-horizon | 18:00 | |
| *** saksham has joined #openstack-horizon | 18:00 | |
| *** bapalm_ has joined #openstack-horizon | 18:00 | |
| stevemar | gyee: sure | 18:04 |
| *** alexvictorchan has quit IRC | 18:04 | |
| *** kmARC has joined #openstack-horizon | 18:05 | |
| robcresswell | david-lyle: https://github.com/openstack/horizon/blob/master/openstack_dashboard/enabled/_3020_identity_projects_panel.py << It looks like at some point the comments got switched around? Also I don't think the panel_group is necessary, is it? | 18:05 |
| robcresswell | Man, who approved this stuff anyway. | 18:06 |
| *** bapalm_ has quit IRC | 18:06 | |
| kfox1111 | arg... not sure splitting this review will actually make it any easier. :( | 18:07 |
| kfox1111 | Well, I guess it depends on how far out is: https://review.openstack.org/#/c/205104 ? | 18:10 |
| robcresswell | kfox1111: About 5 minutes, I've already got it open and mid-review | 18:10 |
| robcresswell | Well, then it needs gate | 18:11 |
| kfox1111 | ah. cool. thanks. :) | 18:11 |
| robcresswell | So that could be 30 mins to... 2 days | 18:11 |
| kfox1111 | heh. yeah. :) | 18:11 |
| *** tqtran has joined #openstack-horizon | 18:13 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Dashboard ReOrg - retiring dashboard.scss https://review.openstack.org/209346 | 18:13 |
| robcresswell | Anyone else on master and seeing a dead dashboard? | 18:15 |
| tqtran | robcresswell: i can check, though most likely its just you | 18:16 |
| robcresswell | tqtran: haha | 18:16 |
| robcresswell | Attitude on these developers... | 18:16 |
| robcresswell | :p | 18:16 |
| tqtran | lol | 18:17 |
| *** JeanBriceCombebi has quit IRC | 18:17 | |
| tqtran | rebuilding my venv, one sec | 18:18 |
| tqtran | robcresswell: yep, working fine for me | 18:18 |
| tqtran | whats the error you are getting? | 18:18 |
| tqtran | if its compression related, you might just need to restart apache or dev server | 18:19 |
| robcresswell | tqtran: Nah it's a keyerror on the data processing wizard panel | 18:19 |
| robcresswell | I've probably done something silly. | 18:19 |
| *** KunalGandhi has quit IRC | 18:20 | |
| *** KunalGandhi has joined #openstack-horizon | 18:20 | |
| kfox1111 | how do you run the npm tests locally? | 18:26 |
| robcresswell | npm run test | 18:28 |
| robcresswell | inside horizon | 18:28 |
| *** josecastroleon has joined #openstack-horizon | 18:29 | |
| robcresswell | it looks at the package.json and uses the test command in there | 18:29 |
| kfox1111 | oh. so no tox hook? ok. | 18:29 |
| kfox1111 | so I gota do some nodeenv thing too... | 18:29 |
| *** bluex-pl has quit IRC | 18:29 | |
| robcresswell | tqtran: That was a fun bug. Fixed now. It was due to duplicates in the enabled folder I think, or perhaps the .pyc files... either way, removing that folder and checking it out again fixed my problems. | 18:33 |
| robcresswell | Not sure why a hard reset didnt though. My git-fu failed me. | 18:33 |
| *** yamamoto has joined #openstack-horizon | 18:34 | |
| tqtran | i think reset only resets the current files in trunk | 18:34 |
| tqtran | so if you have additional files in there, it won't delete those | 18:34 |
| *** jcoufal has quit IRC | 18:38 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 18:38 | |
| robcresswell | tqtran: Ah, I see | 18:39 |
| *** Piet has quit IRC | 18:41 | |
| kfox1111 | npm run test didn't work. no karma command. | 18:46 |
| kfox1111 | is that something npm installable? | 18:46 |
| *** openstackgerrit has quit IRC | 18:46 | |
| *** openstackgerrit has joined #openstack-horizon | 18:47 | |
| *** alexvictorchan has joined #openstack-horizon | 18:48 | |
| *** JeanBriceCombebi has quit IRC | 18:49 | |
| robcresswell | kfox1111: Yah, npm install | 18:50 |
| robcresswell | kfox1111: That'll do your deps | 18:51 |
| kfox1111 | k. thx. | 18:54 |
| *** MaxV has joined #openstack-horizon | 18:55 | |
| *** geoffarnold has quit IRC | 18:55 | |
| kfox1111 | nice. now I can check the test results in seconds rather then hours in zuul. :) | 18:56 |
| kfox1111 | thanks. :) | 18:56 |
| *** kyleolivo has joined #openstack-horizon | 18:57 | |
| robcresswell | kfox1111: No problem! | 18:58 |
| *** mwhagedorn has joined #openstack-horizon | 18:58 | |
| *** vgridnev has joined #openstack-horizon | 18:58 | |
| *** josecastroleon has quit IRC | 18:58 | |
| *** geoffarnold has joined #openstack-horizon | 19:01 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: [WIP] Add Debug Dashboard https://review.openstack.org/209631 | 19:01 |
| *** kyleolivo has quit IRC | 19:02 | |
| *** mwhagedorn has quit IRC | 19:03 | |
| *** MaxV has quit IRC | 19:03 | |
| *** mwhagedorn has joined #openstack-horizon | 19:03 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: API for getting default quotas in admin https://review.openstack.org/207126 | 19:10 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Add angular defaults panel for admin https://review.openstack.org/205296 | 19:11 |
| *** mwhagedorn_ has joined #openstack-horizon | 19:13 | |
| kfox1111 | Error: [$injector:modulerr] Failed to instantiate module function ($provide) due to: | 19:14 |
| kfox1111 | TypeError: 'undefined' is not an object (evaluating 'dst.$$hashKey') | 19:14 |
| kfox1111 | ?!? | 19:14 |
| *** mwhagedorn has quit IRC | 19:14 | |
| *** mwhagedorn_ is now known as mwhagedorn | 19:14 | |
| *** yamamoto has quit IRC | 19:15 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: [WIP] Add Debug Dashboard https://review.openstack.org/209631 | 19:16 |
| *** kyleolivo has joined #openstack-horizon | 19:16 | |
| *** iamjarvo has joined #openstack-horizon | 19:17 | |
| *** kyleolivo has quit IRC | 19:17 | |
| *** jbell8 has quit IRC | 19:18 | |
| *** zz_ttrifonov is now known as ttrifonov | 19:19 | |
| kfox1111 | any ideas? | 19:19 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Add angular defaults panel for admin https://review.openstack.org/205296 | 19:25 |
| *** ttrifonov is now known as zz_ttrifonov | 19:28 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon should still collect 'default' theme https://review.openstack.org/209641 | 19:28 |
| kfox1111 | growing to dislike this js testing framework.... | 19:29 |
| *** MaxV has joined #openstack-horizon | 19:30 | |
| *** DaveJ__ has quit IRC | 19:33 | |
| *** TravT_ has joined #openstack-horizon | 19:33 | |
| *** TravT has quit IRC | 19:35 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon should still collect 'default' theme https://review.openstack.org/209641 | 19:36 |
| openstackgerrit | Vitaly Gridnev proposed openstack/horizon: [Sahara] Move cluster configuration to separate tab https://review.openstack.org/197965 | 19:37 |
| openstackgerrit | Vitaly Gridnev proposed openstack/horizon: [Sahara] Move node processes selection to own tab https://review.openstack.org/197018 | 19:37 |
| *** e0ne has quit IRC | 19:38 | |
| *** SimonChung has quit IRC | 19:45 | |
| *** crobertsrh has quit IRC | 19:46 | |
| *** vgridnev has quit IRC | 19:49 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Add angular defaults panel for admin https://review.openstack.org/205296 | 19:51 |
| *** TravT_ has quit IRC | 19:52 | |
| *** TravT has joined #openstack-horizon | 19:52 | |
| *** vgridnev has joined #openstack-horizon | 19:57 | |
| *** saksham has quit IRC | 19:59 | |
| openstackgerrit | Kevin Fox proposed openstack/horizon: A few tweaks to make the App Catalog plugin work. https://review.openstack.org/206773 | 19:59 |
| kfox1111 | arg. so its not a jasmine thing, its a horizon specifc testing framework thing. | 20:00 |
| *** vgridnev has quit IRC | 20:00 | |
| *** iamjarvo_ has joined #openstack-horizon | 20:00 | |
| *** SimonChung has joined #openstack-horizon | 20:01 | |
| *** iamjarvo has quit IRC | 20:03 | |
| *** MaxV has quit IRC | 20:07 | |
| *** jasondot_ has joined #openstack-horizon | 20:07 | |
| *** jasondotstar has quit IRC | 20:08 | |
| *** yamamoto has joined #openstack-horizon | 20:16 | |
| tqtran | kfox1111: can you paste the details of the error into pastebin? | 20:16 |
| *** bapalm has joined #openstack-horizon | 20:16 | |
| tqtran | try refreshing your browser cache | 20:16 |
| *** lhcheng has left #openstack-horizon | 20:16 | |
| tqtran | sometimes its a cache issue | 20:16 |
| kfox1111 | it was the test cases base code assuming toast was used. | 20:18 |
| *** emilyw has joined #openstack-horizon | 20:18 | |
| kfox1111 | I always was wanting to catch the error myself in the app-catalog code, so I didn't implement toast support. | 20:18 |
| kfox1111 | I worked around it by copying the code from one of the glance api's that support toast with an optional argument to disable it. | 20:19 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: API for getting default quotas in admin https://review.openstack.org/207126 | 20:19 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Add angular defaults panel for admin https://review.openstack.org/205296 | 20:20 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Add angular defaults panel for admin https://review.openstack.org/205296 | 20:20 |
| *** yamamoto has quit IRC | 20:21 | |
| *** emw has quit IRC | 20:21 | |
| *** pkarikh_ has joined #openstack-horizon | 20:22 | |
| *** pkarikh_ has quit IRC | 20:23 | |
| *** rajatvig has quit IRC | 20:27 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 20:27 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Add pagination support to the volume page https://review.openstack.org/118450 | 20:28 |
| *** lucas__ has quit IRC | 20:33 | |
| robcresswell | Is there a way to prevent a dashboard being registered based on a setting? I know the panels now have can_register, but that seems to be specific to the panels. | 20:35 |
| david-lyle | robcresswell: not yet | 20:38 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Angular code theory documentation https://review.openstack.org/203862 | 20:38 |
| david-lyle | robcresswell: well actually yes | 20:38 |
| *** jrist has quit IRC | 20:39 | |
| david-lyle | the way that can_register replaced, which is just put the logic around the register call, only if condition is met, call register | 20:39 |
| *** mrunge has quit IRC | 20:39 | |
| robcresswell | Is that the recommended way to handle it? You said not "yet" to the initial query | 20:42 |
| robcresswell | Makes me think more stuff is on the way :) | 20:42 |
| david-lyle | robcresswell: for now that is the accepted method | 20:42 |
| david-lyle | later can_register and the register action should probably happen in the plugin loading code | 20:43 |
| robcresswell | Cool | 20:44 |
| *** jrist has joined #openstack-horizon | 20:45 | |
| robcresswell | Me and hurgleburgler were discussing providing a debug dashboard for things like the jasmine tests, theme examples etc | 20:45 |
| robcresswell | Just an idea, anyway, wanted to give it a go and see what people thought. | 20:46 |
| hurgleburgler | yay! | 20:46 |
| *** stevemar has quit IRC | 20:46 | |
| hurgleburgler | we were thinking it would be a great place to house this: https://review.openstack.org/#/c/187818/ | 20:47 |
| kfox1111 | nice. :) | 20:49 |
| *** sqchen has quit IRC | 20:51 | |
| openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Hide private method on neutron rest test https://review.openstack.org/209668 | 20:51 |
| kfox1111 | is the gate broken again? | 20:52 |
| *** Sukhdev has joined #openstack-horizon | 20:52 | |
| robcresswell | I'm not getting into gate fixing at 10pm :p | 20:53 |
| *** saksham has joined #openstack-horizon | 20:54 | |
| *** sqchen has joined #openstack-horizon | 20:56 | |
| *** iamjarvo has joined #openstack-horizon | 20:56 | |
| *** kmARC has quit IRC | 20:57 | |
| *** iamjarvo_ has quit IRC | 20:59 | |
| *** kmARC has joined #openstack-horizon | 20:59 | |
| *** iamjarvo has quit IRC | 21:00 | |
| *** iamjarvo has joined #openstack-horizon | 21:01 | |
| *** iamjarvo has quit IRC | 21:02 | |
| *** emw has joined #openstack-horizon | 21:04 | |
| *** emilyw has quit IRC | 21:05 | |
| -openstackstatus- NOTICE: Zuul has been restarted to resolve a reconfiguration failure: previously running jobs have been reenqueued but change events between 19:50-20:54 UTC have been lost and will need to be rechecked or their approvals reapplied to trigger testing. | 21:05 | |
| kfox1111 | there it is. :) | 21:05 |
| *** rajatvig has joined #openstack-horizon | 21:05 | |
| *** kmARC has quit IRC | 21:06 | |
| kfox1111 | doh. patch got sent to the back of the bus. :/ oh well. | 21:06 |
| *** bapalm has quit IRC | 21:06 | |
| *** SimonChung has quit IRC | 21:06 | |
| robcresswell | Zuul is the new "can't work, waiting for my code to compile" | 21:07 |
| kfox1111 | that has its advantages. ;) | 21:08 |
| kfox1111 | when so much stuff's getting shuffled around the tree, its painful too. :( | 21:08 |
| -openstackstatus- NOTICE: Correction: change events between 20:50-20:54 UTC (during the restart only) have been lost and will need to be rechecked or their approvals reapplied to trigger testing. | 21:10 | |
| *** julim has quit IRC | 21:10 | |
| *** radez is now known as radez_g0n3 | 21:10 | |
| kfox1111 | has anyone been working on any enhancements to the horizon ceilometer stuff? Its tantilizingly close to useful, but not quite. :/ | 21:10 |
| *** petertr7 is now known as petertr7_away | 21:10 | |
| *** yamamoto has joined #openstack-horizon | 21:12 | |
| *** rajatvig has quit IRC | 21:15 | |
| *** chlong has quit IRC | 21:16 | |
| *** yamamoto has quit IRC | 21:16 | |
| *** JeanBriceCombebi has quit IRC | 21:16 | |
| *** SimonChung has joined #openstack-horizon | 21:16 | |
| *** lblanchard has quit IRC | 21:17 | |
| *** kcaj has left #openstack-horizon | 21:28 | |
| *** chlong has joined #openstack-horizon | 21:30 | |
| *** rajatvig has joined #openstack-horizon | 21:30 | |
| *** rajatvig has joined #openstack-horizon | 21:30 | |
| r1chardj0n3s | morning | 21:32 |
| matt-borland | morning! | 21:34 |
| robcresswell | r1chardj0n3s: Hi again! | 21:37 |
| r1chardj0n3s | :) | 21:37 |
| *** fnordahl has quit IRC | 21:39 | |
| *** fnordahl has joined #openstack-horizon | 21:39 | |
| robcresswell | dammit, I think I found a stupid bug with using enabled-only plugins | 21:40 |
| r1chardj0n3s | robcresswell needs to be more of a team player and stop making bugs | 21:41 |
| robcresswell | :( | 21:41 |
| robcresswell | I'll pester david in the morning. I'm hoping I'm just doing it wrong. | 21:42 |
| kfox1111 | "so, if debugging is the act of removing bugs, is programming the act of creating them?" :) | 21:42 |
| openstackgerrit | Justin Pomeroy proposed openstack/horizon: Add ability to set limits on metadata tree items https://review.openstack.org/209680 | 21:44 |
| kfox1111 | oh... that article reminds me. is there any activity on making a keystone v3 rc in horizon? | 21:44 |
| *** zul has quit IRC | 21:45 | |
| robcresswell | I'm not sure what the current status is with defaulting to v3. afaik its still v2, but there's a lot of demand for us to improve keystone stuff. david-lyle and lhcheng would likely know more. | 21:46 |
| robcresswell | -likely | 21:46 |
| robcresswell | *definitely* know more :p | 21:46 |
| rajatvig | anyone here that can help us understand the defaults panel under admin? | 21:47 |
| *** geoffarnold has quit IRC | 21:48 | |
| rajatvig | we were trying to understand if there's a rule around what default values can be edited? or we can only edit the values shown in the modal? | 21:48 |
| rajatvig | we are currently replicating the modal and panel in Angular, so need to understand how the current panel + modal works | 21:49 |
| *** geoffarnold has joined #openstack-horizon | 21:50 | |
| tqtran | rajatvig: why not just play around with the current defaults panel? | 21:52 |
| *** jtriley has quit IRC | 21:54 | |
| *** neillc_afk is now known as neillc | 21:54 | |
| *** tqtran has quit IRC | 21:55 | |
| rajatvig | In the current defaults panel, there isn't a 1-1 mapping between the defaults that are shown, and the defaults that can have their values updated. Is this by design? | 21:55 |
| *** neelashah has quit IRC | 21:56 | |
| rajatvig | the list shows 19 default values and the modal only 11. we'll surely look at the code in more detail in the meanwhile. | 21:57 |
| openstackgerrit | Ethan Gafford proposed openstack/horizon: [WIP] [Sahara] Unified job interface map UI https://review.openstack.org/209683 | 22:00 |
| *** tqtran has joined #openstack-horizon | 22:00 | |
| *** nlahouti has quit IRC | 22:05 | |
| *** SimonChung has quit IRC | 22:07 | |
| *** SimonChung1 has joined #openstack-horizon | 22:08 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: [WIP] Add Debug Dashboard https://review.openstack.org/209631 | 22:10 |
| *** dboik has quit IRC | 22:13 | |
| *** yamamoto has joined #openstack-horizon | 22:17 | |
| *** vijendar has quit IRC | 22:21 | |
| *** emw has quit IRC | 22:21 | |
| *** yamamoto has quit IRC | 22:22 | |
| *** tosky has quit IRC | 22:26 | |
| *** nlahouti has joined #openstack-horizon | 22:27 | |
| *** matt-borland has quit IRC | 22:27 | |
| *** tqtran has quit IRC | 22:33 | |
| *** jingjing_ren has quit IRC | 22:35 | |
| *** jtriley has joined #openstack-horizon | 22:39 | |
| david-lyle | kfox1111: v3 default is pending session storage default change | 22:42 |
| david-lyle | should be done by the end of Liberty | 22:42 |
| kfox1111 | sorry. guess I didn't articulate that right. | 22:45 |
| kfox1111 | horizon has a feature where a user can download a shell rc file. | 22:45 |
| kfox1111 | its keystone v2 formatted. | 22:45 |
| kfox1111 | it would be very nice if it supported v3 as well. | 22:45 |
| *** tqtran has joined #openstack-horizon | 22:46 | |
| david-lyle | kfox1111: I put a patch up for that | 22:48 |
| david-lyle | a while ago | 22:48 |
| david-lyle | https://review.openstack.org/#/c/186846/ | 22:48 |
| david-lyle | haven't gone back to it yet | 22:48 |
| kfox1111 | ah. | 22:48 |
| kfox1111 | nice. | 22:50 |
| *** Sukhdev has quit IRC | 22:52 | |
| *** fnordahl has quit IRC | 22:52 | |
| david-lyle | some concern about naming | 22:56 |
| kfox1111 | yeah. reviewing now. | 22:56 |
| david-lyle | I was hoping that once v2.0 was deprecated, we could drop that one | 22:56 |
| *** jpomeroy has quit IRC | 22:56 | |
| david-lyle | probably would be better to have the button be a select or something | 22:57 |
| *** xnox has quit IRC | 22:57 | |
| david-lyle | not sure on that one | 22:57 |
| kfox1111 | maybe a dropdown button? default to v3, but can go back versions? | 22:57 |
| kfox1111 | yeah. once you start supporting v3, it would be nice to drop 2. but at least so far, not enough openstack services support v3 to make it work fully. :/ | 22:58 |
| kfox1111 | as of juno, you couldn't use neutron+nova at v3. :( | 22:58 |
| david-lyle | right | 22:58 |
| kfox1111 | we use v3 to for heat and some other stuff. but leave all the users in v2. | 22:59 |
| david-lyle | once the hotter fires are put out, I'll go back and work on the UX | 22:59 |
| kfox1111 | I'd really really like to move the service accounts to v3 into sql. | 22:59 |
| kfox1111 | yeah. just being able to tell a user "click here to get a v3 config file" is a huge win. | 22:59 |
| *** xnox has joined #openstack-horizon | 22:59 | |
| kfox1111 | just how pretty, not a big deal. | 23:00 |
| kfox1111 | I did run into that, v2 left stuff that v3 trips over and visa versa issue a lot until I added the unset's in my rc's. | 23:00 |
| *** fnordahl has joined #openstack-horizon | 23:01 | |
| david-lyle | yeah I think a conversation with you in the keystone room spurred my patch, actually | 23:02 |
| david-lyle | :) | 23:02 |
| *** iamjarvo has joined #openstack-horizon | 23:12 | |
| *** iamjarvo has quit IRC | 23:13 | |
| *** iamjarvo has joined #openstack-horizon | 23:14 | |
| *** geoffarnold has quit IRC | 23:15 | |
| *** Sukhdev has joined #openstack-horizon | 23:15 | |
| *** RA_ has joined #openstack-horizon | 23:16 | |
| kfox1111 | ah. yeah, probably. :) | 23:18 |
| kfox1111 | I think at the time, it was really unobvious how to build a v3 compatable rc file. | 23:19 |
| kfox1111 | I'm not sure how much that has changed. :/ | 23:19 |
| *** SimonChung has joined #openstack-horizon | 23:24 | |
| *** SimonChung1 has quit IRC | 23:24 | |
| *** Guest58084 has quit IRC | 23:28 | |
| kfox1111 | nice. got magic search to work. :) | 23:29 |
| kfox1111 | it was this patch that makes it work: https://review.openstack.org/#/c/201582/7/openstack_dashboard/templates/horizon/_scripts.html | 23:30 |
| *** Guest58084 has joined #openstack-horizon | 23:38 | |
| kfox1111 | hmm... | 23:44 |
| kfox1111 | in javascript, say you have a list of hashes that have name entries. | 23:44 |
| kfox1111 | is there a simple way to get at the hash by name value? | 23:45 |
| openstackgerrit | Amogh proposed openstack/horizon: Integration tests - Instances tests changed the TestCase->AdminTestCase I added below methods: * instancespage : _get_row_with_instance_name method is_instance_present method create_instance method terminate_instance method https://review.openstack.org/117091 | 23:48 |
| *** nlahouti has quit IRC | 23:49 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: API for updating default quotas in admin https://review.openstack.org/209706 | 23:50 |
| *** julim has joined #openstack-horizon | 23:50 | |
| *** jtriley has quit IRC | 23:51 | |
| *** rajatvig has quit IRC | 23:53 | |
| *** sjmc7 has quit IRC | 23:54 | |
| *** iamjarvo has quit IRC | 23:55 | |
| *** nlahouti has joined #openstack-horizon | 23:55 | |
| *** nlahouti has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!